[jdk17u-dev] RFR: 8326521: JFR: CompilerPhase event test fails on windows 32 bit

Robert Toyonaga duke at openjdk.org
Thu Feb 22 20:30:29 UTC 2024


This test failure is a problem for the Adoptium CI. The reason that this test fails on 32 bit Windows is that Hotspot only uses the C1 compiler in this configuration by design. If the system is Windows and not 64 bit, [`NeverActAsServerClassMachine`](https://github.com/openjdk/jdk17u/blob/master/src/hotspot/share/compiler/compilerDefinitions.cpp#L559)  will be set. This results in setting the compilation mode to be [quick_only](https://github.com/openjdk/jdk17u/blob/master/src/hotspot/share/compiler/compilerDefinitions.cpp#L171), which results in [constraining to C1 compilation](https://github.com/openjdk/jdk17u/blob/master/src/hotspot/share/compiler/compilerDefinitions.hpp#L157).

The CompilerPhase JFR events are only emitted from C2 code in hotspot. So although the test succeeds in compiling the method it intends to (with C1), it isn't able to generate the JFR events it expects, and so fails.


----------System.out:(4/182)----------
CompileCommand: compileonly jdk/jfr/event/compiler/TestCompilerPhase.dummyMethod bool compileonly = true
1 compiler directives added
WB error: invalid compilation level 4
hello!
----------System.err:(16/1050)----------
java.lang.RuntimeException: No events: expected false, was true
at jdk.test.lib.Asserts.fail(Asserts.java:594)
at jdk.test.lib.Asserts.assertFalse(Asserts.java:461)
at jdk.test.lib.jfr.Events.hasEvents(Events.java:161)
at jdk.jfr.event.compiler.TestCompilerPhase.main(TestCompilerPhase.java:76)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
at java.base/java.lang.Thread.run(Thread.java:840)

JavaTest Message: Test threw exception: java.lang.RuntimeException: No events: expected false, was true
JavaTest Message: shutting down test

STATUS:Failed.`main' threw exception: java.lang.RuntimeException: No events: expected false, was true



This PR prevents `NeverActAsServerClassMachine` from being set during the test, so that it isn't restricted to C1.

-------------

Commit messages:
 - Prevent C1 only in order to generate CompilerPhase JFR events

Changes: https://git.openjdk.org/jdk17u-dev/pull/2222/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2222&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8326521
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk17u-dev/pull/2222.diff
  Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2222/head:pull/2222

PR: https://git.openjdk.org/jdk17u-dev/pull/2222


More information about the jdk-updates-dev mailing list