[jdk11u-dev] RFR: 8326503: [11u] java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fail because of package org.junit.jupiter.api does not exist

[Severin Gehwolf]

On Mon, 26 Feb 2024 10:39:20 GMT, Anton Bobrov <abobrov at openjdk.org> wrote:

> This patch addresses the test failures described in https://bugs.openjdk.org/browse/JDK-8326503 due to junit 5 package org.junit.jupiter.api which does not exist in older junit 4 that is being used here now for 11u builds by refactoring junit 5 api use to available junit 4 api.

Have you considered `@BeforeClass` and `@AfterClass` annotations?

test/jdk/java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java line 68:

> 66:     }
> 67: 
> 68:     @Before

Wouldn't `@BeforeClass` be appropriate here?

test/jdk/java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java line 171:

> 169:     }
> 170: 
> 171:     @After

Same here: `@AfterClass`?

-------------

PR Review: https://git.openjdk.org/jdk11u-dev/pull/2553#pullrequestreview-1900547186
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2553#discussion_r1502406293
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2553#discussion_r1502407434