[jdk17u-dev] RFR: 8269914: Factor out heap printing for G1 young and full gc
Goetz Lindenmaier
goetz at openjdk.org
Wed Feb 28 13:40:00 UTC 2024
I backport this as prerequisite for [8291753](https://bugs.openjdk.org/browse/JDK-8291753) as proposed before in https://github.com/openjdk/jdk17u-dev/pull/1900.
The backport has been tested by [releaseing it in SapMachine in 17.0.10](https://github.com/SAP/SapMachine/commit/4b0c2c7a070c7ad13f0da24a9418aea2883473af). This patch here is identical to the one in SapMachine. It will go to 17.0.12 giving enough time to settle.
Also, this will bring G1 code of 17 closer to head probably simplifying further backports.
Some simple resolves needed:
src/hotspot/share/gc/g1/g1CollectedHeap.cpp
Basically trivial resolve due to context. One of the calls removed
in the original change is not in 17.
The patch brings a call to _g1h->rem_set()->print_coarsen_stats()
which is not available in 17. I uncommented this call to make
it build.
src/hotspot/share/gc/g1/g1FullGCScope.cpp
Trivial resolve.
Removes a destructor that calls several routines.
The destructor in 17 has one addtitional call that remains after removing the same ones as in the
original change. Thus I kept the destructor with this single call.
To make it build, I need to also keep the declaration of the destructor in the .hpp file.
-------------
Commit messages:
- Build fixes
- Backport c93204ce3d4653705e6aeeadb9b3c591e469de77
Changes: https://git.openjdk.org/jdk17u-dev/pull/2250/files
Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2250&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8269914
Stats: 194 lines in 7 files changed: 107 ins; 57 del; 30 mod
Patch: https://git.openjdk.org/jdk17u-dev/pull/2250.diff
Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2250/head:pull/2250
PR: https://git.openjdk.org/jdk17u-dev/pull/2250
More information about the jdk-updates-dev
mailing list