[jdk17u-dev] RFR: 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range

Zhengyu Gu zgu at openjdk.org
Thu Feb 29 15:09:52 UTC 2024


On Fri, 23 Feb 2024 10:34:12 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

> This backport is a transitive dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031
> 
> 8310031 requires 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel
> and 8282094 requires this backport.
> 
> 8310031 could be backported w/o this backport if 8282094 could be squashed into it because with 8310031 `ObjectStartArray::object_starts_in_range()` is not reached anymore from `PSCardTable::scavenge_contents_parallel()`.
> 
> This backport applies cleanly but needs a trivial renaming (see 2nd commit).
> 
> Risk is low: it's a small change. The changed method has just 2 callers of which one is for diagnostics.
> 
> Manual testing on x86_64:
> jdk:tier1       TEST_VM_OPTS="-XX:+UseParallelGC"
> langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC"
> 
> Local CI Testing:
> The fix passed our CI testing (e.g. 2024-02-22): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC).
> Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le.

LGTM

-------------

Marked as reviewed by zgu (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/2226#pullrequestreview-1909134424


More information about the jdk-updates-dev mailing list