From ysr at openjdk.org Mon Jan 1 01:08:49 2024 From: ysr at openjdk.org (Y. Srinivas Ramakrishna) Date: Mon, 1 Jan 2024 01:08:49 GMT Subject: [jdk17u-dev] RFR: 8296812: sprintf is deprecated in Xcode 14 In-Reply-To: <7XLC13Ldl8cqJVuWXdUwLON6ExwW3MKry9fWgia0QXg=.6cc0be3c-cd35-4ac2-9263-4344f4c08737@github.com> References: <7XLC13Ldl8cqJVuWXdUwLON6ExwW3MKry9fWgia0QXg=.6cc0be3c-cd35-4ac2-9263-4344f4c08737@github.com> Message-ID: On Fri, 27 Oct 2023 16:09:10 GMT, Elif Aslan wrote: > https://developer.apple.com/news/?id=y5mjxqmn > > Starting November 1, 2023, the Apple notary service will no longer accept uploads from altool or Xcode 13 or earlier. > > > This is not a clean backport and this pull request contains a backport of the closed bug [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) commit [f1522c648c2e](https://github.com/openjdk/jdk/commit/478ef389dc3767edfbe21d10a7f7f1522c648c2e). > > Conflicts includes: > > - whitespace conflicts on src/hotspot/share/utilities/utf8.cpp > > - missing src/hotspot/share/jfr/support/jfrSymbolTable.cpp > > - context difference on src/hotspot/cpu/aarch64/vm_version_aarch64.cpp > > The sprintf is deprecated in Xcode 14 and the use of it causing building failure. The build could pass if warnings are disabled for codes that use sprintf method. For the long run, the sprintf could be replaced with snprintf. This patch is trying to check if snprintf could be used. > > Testing: > > GHA tested. > Successfull tier1,tier2,tier3 and jck tests for linux platforms. > Successfull tier1 and tier2 for windows. See previous comment in conversation. ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1930#pullrequestreview-1799703027 From jkratochvil at openjdk.org Mon Jan 1 15:23:05 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Mon, 1 Jan 2024 15:23:05 GMT Subject: [jdk21u-dev] RFR: 8314610: hotspot can't compile with the latest of gtest because of Message-ID: /home/azul/azul/jdk21u-git/test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp: In member function 'virtual void gc_memset_with_concurrent_readers_Test::TestBody()': /home/azul/azul/jdk21u-git/test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp:82:34: error: 'setw' is not a member of 'std' 82 | << std::setw(2) << line_byte(lp, 0) << " " | ^~~~ /home/azul/azul/jdk21u-git/test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp:34:1: note: 'std::setw' is defined in header ''; did you forget to '#include '? 33 | #include "unittest.hpp" +++ |+#include 34 | ------------- Commit messages: - 8314610: hotspot can't compile with the latest of gtest because of Changes: https://git.openjdk.org/jdk21u-dev/pull/107/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=107&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314610 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/107.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/107/head:pull/107 PR: https://git.openjdk.org/jdk21u-dev/pull/107 From serb at openjdk.org Tue Jan 2 00:00:51 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 2 Jan 2024 00:00:51 GMT Subject: [jdk21u] Withdrawn: 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp In-Reply-To: References: Message-ID: On Wed, 29 Nov 2023 19:38:04 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [eb44bafe](https://github.com/openjdk/jdk/commit/eb44bafe7709b108acca06b083f306d6ab7a8050) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 29 Nov 2023 and was reviewed by David Holmes and Aleksey Shipilev. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u/pull/413 From serb at openjdk.org Tue Jan 2 00:05:49 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 2 Jan 2024 00:05:49 GMT Subject: [jdk11u-dev] RFR: 8275843: Random crashes while the UI code is executed In-Reply-To: References: Message-ID: On Tue, 5 Sep 2023 17:20:19 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [a9c1acbb](https://github.com/openjdk/jdk/commit/a9c1acbb8aec46e4a488b7c77bb6318af87747f6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 14 Dec 2021 and was reviewed by Alexander Zvegintsev. > > Thanks! keep open ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2122#issuecomment-1873534088 From serb at openjdk.org Tue Jan 2 00:05:49 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 2 Jan 2024 00:05:49 GMT Subject: [jdk11u-dev] RFR: 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp In-Reply-To: References: Message-ID: On Wed, 29 Nov 2023 19:45:37 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [eb44bafe](https://github.com/openjdk/jdk/commit/eb44bafe7709b108acca06b083f306d6ab7a8050) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 29 Nov 2023 and was reviewed by David Holmes and Aleksey Shipilev. > > Thanks! keep open ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2311#issuecomment-1873533985 From serb at openjdk.org Tue Jan 2 00:16:55 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 2 Jan 2024 00:16:55 GMT Subject: [jdk21u-dev] RFR: 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp Message-ID: Hi all, This pull request contains a backport of commit [eb44bafe](https://github.com/openjdk/jdk/commit/eb44bafe7709b108acca06b083f306d6ab7a8050) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 29 Nov 2023 and was reviewed by David Holmes and Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport eb44bafe7709b108acca06b083f306d6ab7a8050 Changes: https://git.openjdk.org/jdk21u-dev/pull/108/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=108&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320937 Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/108.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/108/head:pull/108 PR: https://git.openjdk.org/jdk21u-dev/pull/108 From serb at openjdk.org Tue Jan 2 00:18:06 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 2 Jan 2024 00:18:06 GMT Subject: [jdk21u-dev] RFR: 8301310: The SendRawSysexMessage test may cause a JVM crash Message-ID: Hi all, This pull request contains a backport of commit [d725b73d](https://github.com/openjdk/jdk/commit/d725b73df01ae4478dfaabc47c48cd7231d91afa) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alec Su on 14 Nov 2023 and was reviewed by Sergey Bylokhov. Thanks! ------------- Commit messages: - Backport d725b73df01ae4478dfaabc47c48cd7231d91afa Changes: https://git.openjdk.org/jdk21u-dev/pull/109/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=109&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301310 Stats: 19 lines in 2 files changed: 13 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/109.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/109/head:pull/109 PR: https://git.openjdk.org/jdk21u-dev/pull/109 From lmao at openjdk.org Tue Jan 2 02:50:58 2024 From: lmao at openjdk.org (Liang Mao) Date: Tue, 2 Jan 2024 02:50:58 GMT Subject: [jdk11u-dev] RFR: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2 Message-ID: Backport of JDK-8280007. Additional testing: aarch64 server ARM Neoverse N2 release/fastdebug tier1 ------------- Commit messages: - Backport f823bed043dc38d838baaf8c2024ef24b8a50e9b Changes: https://git.openjdk.org/jdk11u-dev/pull/2425/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2425&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280007 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2425.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2425/head:pull/2425 PR: https://git.openjdk.org/jdk11u-dev/pull/2425 From mbaesken at openjdk.org Tue Jan 2 08:04:48 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 2 Jan 2024 08:04:48 GMT Subject: [jdk11u-dev] RFR: 8322417: Console read line with zero out should zero out when throwing exception In-Reply-To: <3FqQdNO7Z3yIZAEAxMnfNc1VjHwd-5uULx493xzP8NQ=.854a1604-fd62-42e5-b25c-c69361f1f386@github.com> References: <3FqQdNO7Z3yIZAEAxMnfNc1VjHwd-5uULx493xzP8NQ=.854a1604-fd62-42e5-b25c-c69361f1f386@github.com> Message-ID: On Fri, 29 Dec 2023 14:31:12 GMT, Goetz Lindenmaier wrote: > A change we should have in 11, too. > > I had to adapt the instanceof. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2424#pullrequestreview-1800056037 From mbaesken at openjdk.org Tue Jan 2 08:06:50 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 2 Jan 2024 08:06:50 GMT Subject: [jdk17u-dev] RFR: 8322772: Clean up code after JDK-8322417 In-Reply-To: References: Message-ID: On Sun, 31 Dec 2023 14:40:35 GMT, Christoph Langer wrote: > Code cleanup after JDK-8322417 Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2090#pullrequestreview-1800057263 From jkratochvil at openjdk.org Tue Jan 2 10:27:50 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Tue, 2 Jan 2024 10:27:50 GMT Subject: [jdk21u-dev] RFR: 8314610: hotspot can't compile with the latest of gtest because of In-Reply-To: References: Message-ID: On Mon, 1 Jan 2024 15:17:16 GMT, Jan Kratochvil wrote: > /home/azul/azul/jdk21u-git/test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp: In member function 'virtual void gc_memset_with_concurrent_readers_Test::TestBody()': > /home/azul/azul/jdk21u-git/test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp:82:34: error: 'setw' is not a member of 'std' > 82 | << std::setw(2) << line_byte(lp, 0) << " " > | ^~~~ > /home/azul/azul/jdk21u-git/test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp:34:1: note: 'std::setw' is defined in header ''; did you forget to '#include '? > 33 | #include "unittest.hpp" > +++ |+#include > 34 | I am just not sure whether the copyright year should be from the trunk commit (2023) or from this backport commit (2024). ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/107#issuecomment-1873844532 From goetz at openjdk.org Tue Jan 2 10:46:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Jan 2024 10:46:49 GMT Subject: [jdk11u-dev] RFR: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2 In-Reply-To: References: Message-ID: On Tue, 2 Jan 2024 02:45:29 GMT, Liang Mao wrote: > Backport of JDK-8280007. The change should be enabled in JDK11 better performance on Neoverse V1/N1/N2. It is quite safe for existing in upstream and 17u for years. > > Additional testing: aarch64 server ARM Neoverse N2 release/fastdebug tier1 Hi, you approval request is not complete. Please list reason, risk, testing and whether the backport was clean. See also https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix "Example Fix Request comment" Also, please enable GHA actions and restart the tests. Removing the label in the meantime. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2425#issuecomment-1873864622 From goetz at openjdk.org Tue Jan 2 10:49:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Jan 2024 10:49:49 GMT Subject: [jdk21u] RFR: 8301310: The SendRawSysexMessage test may cause a JVM crash In-Reply-To: References: Message-ID: On Tue, 14 Nov 2023 23:08:33 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [d725b73d](https://github.com/openjdk/jdk/commit/d725b73df01ae4478dfaabc47c48cd7231d91afa) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alec Su on 14 Nov 2023 and was reviewed by Sergey Bylokhov. > > Thanks! Hi @mrserb, can you please close this PR? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/366#issuecomment-1873868294 From aph at openjdk.org Tue Jan 2 10:53:47 2024 From: aph at openjdk.org (Andrew Haley) Date: Tue, 2 Jan 2024 10:53:47 GMT Subject: [jdk11u-dev] RFR: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2 In-Reply-To: References: Message-ID: On Tue, 2 Jan 2024 02:45:29 GMT, Liang Mao wrote: > Backport of JDK-8280007. The change should be enabled in JDK11 better performance on Neoverse V1/N1/N2. It is quite safe for existing in upstream and 17u for years. > > Additional testing: aarch64 server ARM Neoverse N2 release/fastdebug tier1 Have a look at "Fix Approvals" https://wiki.openjdk.org/display/JDKUpdates/JDK11u and see what you think. I'm not sure if this one qualifies. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2425#issuecomment-1873871910 From jkratochvil at openjdk.org Tue Jan 2 17:01:52 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Tue, 2 Jan 2024 17:01:52 GMT Subject: [jdk21u-dev] Integrated: 8314610: hotspot can't compile with the latest of gtest because of In-Reply-To: References: Message-ID: On Mon, 1 Jan 2024 15:17:16 GMT, Jan Kratochvil wrote: > /home/azul/azul/jdk21u-git/test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp: In member function 'virtual void gc_memset_with_concurrent_readers_Test::TestBody()': > /home/azul/azul/jdk21u-git/test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp:82:34: error: 'setw' is not a member of 'std' > 82 | << std::setw(2) << line_byte(lp, 0) << " " > | ^~~~ > /home/azul/azul/jdk21u-git/test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp:34:1: note: 'std::setw' is defined in header ''; did you forget to '#include '? > 33 | #include "unittest.hpp" > +++ |+#include > 34 | This pull request has now been integrated. Changeset: 3bf9212d Author: Jan Kratochvil Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/3bf9212d432197cf3c4a787bab615b7c8519200b Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8314610: hotspot can't compile with the latest of gtest because of Backport-of: febc34dd285c3382716e068748d4a3b0c73d87ad ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/107 From goetz at openjdk.org Tue Jan 2 17:22:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 2 Jan 2024 17:22:10 GMT Subject: [jdk21u-dev] RFR: 8316594: C2 SuperWord: wrong result with hand unrolled loops Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 3630af26e6f05237195e53b98603adf404e90a1a Changes: https://git.openjdk.org/jdk21u-dev/pull/110/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=110&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316594 Stats: 112 lines in 3 files changed: 104 ins; 5 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/110.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/110/head:pull/110 PR: https://git.openjdk.org/jdk21u-dev/pull/110 From shade at openjdk.org Tue Jan 2 18:12:07 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 2 Jan 2024 18:12:07 GMT Subject: [jdk21u-dev] RFR: 8319137: release _object in ObjectMonitor dtor to avoid races [v2] In-Reply-To: References: Message-ID: > Transplanted from https://github.com/openjdk/jdk21u/pull/401 > > This effectively reverts [JDK-8256302](https://bugs.openjdk.org/browse/JDK-8256302), which introduced race condition in JDK 21. The patch does not apply cleanly for two reasons: > 1. Deleted `release_object()` has a different form in JDK 21 due to slight WeakHandle API change. This is not relevant for this patch, just a backporting conflict. I removed `release_object()` by hand. > 2. Without [JDK-8319896](https://bugs.openjdk.org/browse/JDK-8319896) we cannot do `JavaThread::cast` in the incoming changeset, because we can be called by a non-Java thread. I suspect JDK-8319896 would come with its own bugtail, so I would prefer not to backport it now. I have replaced the code back to original pre- JDK 21 form in a separate commit: [Modifications to fit JDK 21](https://github.com/openjdk/jdk21u-dev/commit/65251865632a5624fec70527b7bc1f4dd1d0d637) > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `runtime/Monitor` passes > - [x] Linux AArch64 server fastdebug, `tier1 tier2 tier3 tier4` > - [x] Linux x86_64 server fastdebug, `tier1 tier2 tier3 tier4` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into JDK-8319137-revert-object-release - Modifications to fit JDK 21 - Backport c39d001c7a1ae9eb322a7bb621a03e18c9bf02a1 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/12/files - new: https://git.openjdk.org/jdk21u-dev/pull/12/files/65251865..56e9a2c4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=12&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=12&range=00-01 Stats: 15150 lines in 417 files changed: 6962 ins; 2579 del; 5609 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/12.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/12/head:pull/12 PR: https://git.openjdk.org/jdk21u-dev/pull/12 From shade at openjdk.org Tue Jan 2 18:13:26 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 2 Jan 2024 18:13:26 GMT Subject: [jdk17u-dev] RFR: 8318961: increase javacserver connection timeout values and max retry attempts [v2] In-Reply-To: References: Message-ID: <_qjyU-Cl5y9uFUE6vW9Y8Nsdb1VIW9ZI4zxthAr9W20=.95964f8c-1d60-4c64-ab39-3b6249beff0a@github.com> > Unclean backport to improve build reliability. Affected file was moved in JDK 20 with large refactoring, [JDK-8297444](https://bugs.openjdk.org/browse/JDK-8297444). I had to re-apply the patch by hand. > > Additional testing: > - [x] Local macos-aarch64-server-fastdebug build > - [x] GHA Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8318961-javac-timeout - Backport b9983c72295a31e5f5079bc96c892177fbea3a6e ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2063/files - new: https://git.openjdk.org/jdk17u-dev/pull/2063/files/ab31d46d..4a8a1e41 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2063&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2063&range=00-01 Stats: 8255 lines in 173 files changed: 4071 ins; 2177 del; 2007 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2063.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2063/head:pull/2063 PR: https://git.openjdk.org/jdk17u-dev/pull/2063 From shade at openjdk.org Tue Jan 2 18:14:53 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 2 Jan 2024 18:14:53 GMT Subject: [jdk17u-dev] Integrated: 8307926: Support byte-sized atomic bitset operations In-Reply-To: <0O6TVPTRdPdoH27EMThQfD9dKxGBRCYFGHoPhBTq62c=.4842979d-b992-4ee0-bdb7-dbc92c5af65f@github.com> References: <0O6TVPTRdPdoH27EMThQfD9dKxGBRCYFGHoPhBTq62c=.4842979d-b992-4ee0-bdb7-dbc92c5af65f@github.com> Message-ID: <_3nuPNLz7lJ-CdkaNZzAUS1kfs8AGsQqH_tA9ph8ATM=.d45b5f4d-5111-4943-96c0-95330b310131@github.com> On Tue, 19 Dec 2023 11:32:52 GMT, Aleksey Shipilev wrote: > Clean backport to improve Atomic support in JDK 17 and align it with mainline JDKs, simplifying future backports. Note the patch basically adds documentation that byte-level support is available, and adds a few tests. Therefore, there is no direct product impact. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `Atomic` gtests This pull request has now been integrated. Changeset: 43d15d17 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/43d15d17cabb902dd05c363f9364b862e73e331d Stats: 17 lines in 2 files changed: 14 ins; 0 del; 3 mod 8307926: Support byte-sized atomic bitset operations Backport-of: 646747fd7c7320910eed682ae6da3cd4c60a51a5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2061 From shade at openjdk.org Tue Jan 2 18:17:06 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 2 Jan 2024 18:17:06 GMT Subject: [jdk17u-dev] RFR: 8205076: [17u] Inet6AddressImpl.c: `lookupIfLocalHost` accesses `int InetAddress.preferIPv6Address` as a boolean [v2] In-Reply-To: References: Message-ID: > This is a 11u and 17u -specific bug, see JBS and its comments for more details. I think we can fix this by explicitly checking against the `PREFER_IPV6_VALUE`, like post JDK 18 code does. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `DcmdMBeanTestCheckJni.java` now passes > - [x] macos-aarch64-server-fastdebug, `jdk_net` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8205076-macosx-ipv6-check-jni - Fix ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2048/files - new: https://git.openjdk.org/jdk17u-dev/pull/2048/files/fa0cd6b8..841b6fb6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2048&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2048&range=00-01 Stats: 10262 lines in 202 files changed: 5884 ins; 2239 del; 2139 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2048.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2048/head:pull/2048 PR: https://git.openjdk.org/jdk17u-dev/pull/2048 From shade at openjdk.org Tue Jan 2 18:17:24 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 2 Jan 2024 18:17:24 GMT Subject: [jdk17u-dev] RFR: 8286312: Stop mixing signed and unsigned types in bit operations [v2] In-Reply-To: References: Message-ID: > Clean backport to improve Atomics reliability in JDK 17u. The fix accrued no bug tail for 1.5 years. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `Atomic` gtests Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8286312-atomics-cleanup-signed-unsigned - Backport 39f4434f44d46548917926c7a802b046197bbe33 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2060/files - new: https://git.openjdk.org/jdk17u-dev/pull/2060/files/4c3dd557..ed0e708b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2060&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2060&range=00-01 Stats: 8255 lines in 173 files changed: 4071 ins; 2177 del; 2007 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2060.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2060/head:pull/2060 PR: https://git.openjdk.org/jdk17u-dev/pull/2060 From shade at openjdk.org Tue Jan 2 18:17:27 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 2 Jan 2024 18:17:27 GMT Subject: [jdk17u-dev] RFR: 8318183: C2: VM may crash after hitting node limit [v2] In-Reply-To: References: Message-ID: > Semi-clean backport to solve a potential VM crash due to C2 failing. > > The uncleanliness comes from two places: > > 1. In `Compile::Optimize()`, we do not have the new hunk from [JDK-8286104](https://bugs.openjdk.org/browse/JDK-8286104): https://github.com/openjdk/jdk/commit/31e50f2c7642b046dc9ea1de8ec245dcbc4e1926#diff-f076857d7da81f56709da3de1511b1105727032186cde4d02c678667761f46eaR2247-R2248 -- so no return is needed. > 2. In `PhaseIdealLoop::verify`, we do not have the rewrites from [JDK-8173709](https://bugs.openjdk.org/browse/JDK-8173709): https://github.com/openjdk/jdk/commit/24c6af0637631153707615932f1f10ced4e5c0e8#diff-d49652d43244d52415873c37bf6990269b0d6e2f2111f4f971660470b6bca738R4653-R4657 -- so I had to resolve the conflict by hand. > > Additional testing: > - [x] Linux x86_64 server fastdebug `tier{1,2,3}` > - [x] Linux AArch64 server fastdebug `tier{1,2,3}` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8318183-c2-crash-node-limit - Backport 31ef400f31b1fd9a861870cce69f6d3eec72aa46 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2044/files - new: https://git.openjdk.org/jdk17u-dev/pull/2044/files/612848ed..dc645cd4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2044&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2044&range=00-01 Stats: 10262 lines in 202 files changed: 5884 ins; 2239 del; 2139 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2044.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2044/head:pull/2044 PR: https://git.openjdk.org/jdk17u-dev/pull/2044 From shade at openjdk.org Tue Jan 2 18:19:11 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 2 Jan 2024 18:19:11 GMT Subject: [jdk17u-dev] RFR: 8283626: AArch64: Set relocInfo::offset_unit to 4 [v2] In-Reply-To: References: Message-ID: > Clean backport to improve relocation density. > > Additional testing: > - [x] Linux AArch64 server fastdebug, `tier{1,2,3,4}` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8283626-aarch64-reloc-4bytes - Backport ab17f88f6ccd793b718394987f868322a2cc0d1f ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2040/files - new: https://git.openjdk.org/jdk17u-dev/pull/2040/files/304f0392..a3392c52 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2040&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2040&range=00-01 Stats: 10387 lines in 204 files changed: 5997 ins; 2239 del; 2151 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2040.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2040/head:pull/2040 PR: https://git.openjdk.org/jdk17u-dev/pull/2040 From serb at openjdk.org Tue Jan 2 20:23:03 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 2 Jan 2024 20:23:03 GMT Subject: [jdk11u-dev] Integrated: 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp In-Reply-To: References: Message-ID: On Wed, 29 Nov 2023 19:45:37 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [eb44bafe](https://github.com/openjdk/jdk/commit/eb44bafe7709b108acca06b083f306d6ab7a8050) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 29 Nov 2023 and was reviewed by David Holmes and Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: c2417189 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/c241718949e21c20c2c3480bfcb3cb053726234e Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp Backport-of: eb44bafe7709b108acca06b083f306d6ab7a8050 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2311 From serb at openjdk.org Tue Jan 2 20:26:48 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 2 Jan 2024 20:26:48 GMT Subject: [jdk17u-dev] Integrated: 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp In-Reply-To: <33hZXHhlLFUkbq_FYy4EaJ0HV1YZ8AhF5xh_OJdOvGI=.e8336bb9-3c40-4e05-911e-07abad001ace@github.com> References: <33hZXHhlLFUkbq_FYy4EaJ0HV1YZ8AhF5xh_OJdOvGI=.e8336bb9-3c40-4e05-911e-07abad001ace@github.com> Message-ID: <3TSV9F2XFDCS8__S2DSE2eNT5PCQr75ZgSXyet4gbQs=.d94d567f-31c9-4fe4-89c1-93216cb463ef@github.com> On Wed, 29 Nov 2023 19:41:39 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [eb44bafe](https://github.com/openjdk/jdk/commit/eb44bafe7709b108acca06b083f306d6ab7a8050) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 29 Nov 2023 and was reviewed by David Holmes and Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: 5d86e194 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/5d86e1944a669affa0199eb3264a83e1a241f1fd Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp Backport-of: eb44bafe7709b108acca06b083f306d6ab7a8050 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2003 From serb at openjdk.org Tue Jan 2 20:57:51 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 2 Jan 2024 20:57:51 GMT Subject: [jdk21u-dev] Integrated: 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp In-Reply-To: References: Message-ID: On Mon, 1 Jan 2024 23:57:19 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [eb44bafe](https://github.com/openjdk/jdk/commit/eb44bafe7709b108acca06b083f306d6ab7a8050) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 29 Nov 2023 and was reviewed by David Holmes and Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: dc899e2b Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk21u-dev/commit/dc899e2be287f184b5ea94fa922fb0cabcc26d14 Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp Backport-of: eb44bafe7709b108acca06b083f306d6ab7a8050 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/108 From serb at openjdk.org Tue Jan 2 23:01:54 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 2 Jan 2024 23:01:54 GMT Subject: [jdk21u] Withdrawn: 8301310: The SendRawSysexMessage test may cause a JVM crash In-Reply-To: References: Message-ID: On Tue, 14 Nov 2023 23:08:33 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [d725b73d](https://github.com/openjdk/jdk/commit/d725b73df01ae4478dfaabc47c48cd7231d91afa) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alec Su on 14 Nov 2023 and was reviewed by Sergey Bylokhov. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u/pull/366 From lmao at openjdk.org Wed Jan 3 02:39:47 2024 From: lmao at openjdk.org (Liang Mao) Date: Wed, 3 Jan 2024 02:39:47 GMT Subject: [jdk11u-dev] RFR: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2 In-Reply-To: References: Message-ID: On Tue, 2 Jan 2024 10:50:35 GMT, Andrew Haley wrote: > Have a look at "Fix Approvals" https://wiki.openjdk.org/display/JDKUpdates/JDK11u and see what you think. I'm not sure if this one qualifies. I believe this backport is worth considering. JDK11 is still the most used JDK version and Arm Neoverse servers grow rapidly. And this patch is quite safe. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2425#issuecomment-1874781602 From goetz at openjdk.org Wed Jan 3 08:01:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Jan 2024 08:01:47 GMT Subject: [jdk11u-dev] RFR: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2 In-Reply-To: References: Message-ID: On Tue, 2 Jan 2024 02:45:29 GMT, Liang Mao wrote: > Backport of JDK-8280007. The change should be enabled in JDK11 better performance on Neoverse V1/N1/N2. It is quite safe for existing in upstream and 17u for years. > > Additional testing: aarch64 server ARM Neoverse N2 release/fastdebug tier1 Please enable the GHA tests for the jdk11u-dev repo and restart the tests. You can restart them by merging head. Given the fact this runs live at Alibaba it should be tested sufficiently to consider approval for 11, although this is a stable release and the change an optimization. Disabling it again is simple in case it actually brings problems. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2425#issuecomment-1874972366 PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2425#issuecomment-1874973781 From goetz at openjdk.org Wed Jan 3 08:17:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Jan 2024 08:17:55 GMT Subject: [jdk21u-dev] RFR: 8310238: [test bug] javax/swing/JTableHeader/6889007/bug6889007.java fails Message-ID: <6Zcc3q26sqBoZ7xDXrDMiZbi_TQx3P6UV1VLNtCzLiI=.bcbe3acb-fa56-4ae4-962f-98fa09e170d6@github.com> I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 2cf5c2f4b6cdb52a3560ab03d272f19f47b22b17 Changes: https://git.openjdk.org/jdk21u-dev/pull/112/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=112&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310238 Stats: 24 lines in 1 file changed: 19 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/112.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/112/head:pull/112 PR: https://git.openjdk.org/jdk21u-dev/pull/112 From goetz at openjdk.org Wed Jan 3 08:20:59 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Jan 2024 08:20:59 GMT Subject: [jdk21u-dev] RFR: 8311279: TestStressIGVNAndCCP.java failed with different IGVN traces for the same seed Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport edb2be10fb897834ed78ab4493d3a4f73dc2e140 Changes: https://git.openjdk.org/jdk21u-dev/pull/113/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=113&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311279 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/113.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/113/head:pull/113 PR: https://git.openjdk.org/jdk21u-dev/pull/113 From goetz at openjdk.org Wed Jan 3 08:24:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Jan 2024 08:24:10 GMT Subject: [jdk21u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 Changes: https://git.openjdk.org/jdk21u-dev/pull/114/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=114&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296631 Stats: 43 lines in 11 files changed: 28 ins; 2 del; 13 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/114.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/114/head:pull/114 PR: https://git.openjdk.org/jdk21u-dev/pull/114 From goetz at openjdk.org Wed Jan 3 08:34:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Jan 2024 08:34:08 GMT Subject: [jdk21u-dev] RFR: 8316693: Simplify at-requires checkDockerSupport() Message-ID: I backport this for parity with 21.0.3-oracle. Checked that tests using @requires docker.support still work. ------------- Commit messages: - Backport 16fd43c5eb0fb18e93f00b5817d368df5afad969 Changes: https://git.openjdk.org/jdk21u-dev/pull/115/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=115&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316693 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/115.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/115/head:pull/115 PR: https://git.openjdk.org/jdk21u-dev/pull/115 From roland at openjdk.org Wed Jan 3 08:45:49 2024 From: roland at openjdk.org (Roland Westrelin) Date: Wed, 3 Jan 2024 08:45:49 GMT Subject: [jdk21u-dev] RFR: 8316594: C2 SuperWord: wrong result with hand unrolled loops In-Reply-To: References: Message-ID: <6uDvllrh33zxVwRQkBrL8FhBFeRYSGR-AnVNa71hqE4=.cb4833ca-30ba-409a-a9a6-3f7e02041588@github.com> On Tue, 2 Jan 2024 17:16:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. > > I had to resove SWPointer / VPointer because 8312332: C2: Refactor SWPointer out from SuperWord is not in 21. > > We had previous backports that needed to be resolved because of this refactoring missing. I assume this will hit us in future repeatedly. > > Thus I had a look at backporting 8312332, but that depends on three other cleanup changes: > 8305636: Expand and clean up predicate classes and move them into separate files > 8311691: C2: Remove legacy code related to PostLoopMultiversioning > 8308606: C2 SuperWord: remove alignment checks when not required > > All four of them can be backported clean, but 8305363 has four follow-up bugs. > > So maybe we need to go the patch and accept the unclean backports right from the beginning of 21u :( Looks good to me. ------------- Marked as reviewed by roland (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/110#pullrequestreview-1801574362 From goetz at openjdk.org Wed Jan 3 09:02:03 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Jan 2024 09:02:03 GMT Subject: [jdk21u-dev] RFR: 8319938: TestFileChooserSingleDirectorySelection.java fails with "getSelectedFiles returned empty array" Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 4ef24e2596340c5375f2ab07883c26a6458efe0e Changes: https://git.openjdk.org/jdk21u-dev/pull/116/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=116&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319938 Stats: 148 lines in 1 file changed: 58 ins; 53 del; 37 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/116.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/116/head:pull/116 PR: https://git.openjdk.org/jdk21u-dev/pull/116 From goetz at openjdk.org Wed Jan 3 09:13:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Jan 2024 09:13:13 GMT Subject: [jdk17u-dev] RFR: 8278028: [test-library] Warnings cleanup of the test library Message-ID: I think this is good to have in 17 to reduce the warnings and to simplify further test backports Skipped patch to OldWhiteBox.java, file not in 17. Resolved InMemoryJavaCompiler.java: Copyright, import. Changes already backported. ------------- Commit messages: - Backport 03f647f4bb640bf5df1c461eec9860c7ac3eb076 Changes: https://git.openjdk.org/jdk17u-dev/pull/2092/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2092&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8278028 Stats: 25 lines in 13 files changed: 8 ins; 1 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2092.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2092/head:pull/2092 PR: https://git.openjdk.org/jdk17u-dev/pull/2092 From aph at openjdk.org Wed Jan 3 09:26:52 2024 From: aph at openjdk.org (Andrew Haley) Date: Wed, 3 Jan 2024 09:26:52 GMT Subject: [jdk11u-dev] RFR: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2 In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 02:36:54 GMT, Liang Mao wrote: > > Have a look at "Fix Approvals" https://wiki.openjdk.org/display/JDKUpdates/JDK11u and see what you think. I'm not sure if this one qualifies. > > I believe this backport is worth considering. JDK11 is still the most used JDK version and Arm Neoverse servers grow rapidly. And this patch is quite safe. Understood, but that only addresses the "is of low risk" part of the requirement, but not the "substantial benefit to OpenJDK 11u users" part. What is the substantial benefit? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2425#issuecomment-1875062920 From aph at openjdk.org Wed Jan 3 09:28:46 2024 From: aph at openjdk.org (Andrew Haley) Date: Wed, 3 Jan 2024 09:28:46 GMT Subject: [jdk21u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 08:18:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. Marked as reviewed by aph (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/114#pullrequestreview-1801638232 From lmao at openjdk.org Wed Jan 3 09:36:50 2024 From: lmao at openjdk.org (Liang Mao) Date: Wed, 3 Jan 2024 09:36:50 GMT Subject: [jdk11u-dev] RFR: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2 In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 09:23:53 GMT, Andrew Haley wrote: > > > Have a look at "Fix Approvals" https://wiki.openjdk.org/display/JDKUpdates/JDK11u and see what you think. I'm not sure if this one qualifies. > > > > > > I believe this backport is worth considering. JDK11 is still the most used JDK version and Arm Neoverse servers grow rapidly. And this patch is quite safe. > > Understood, but that only addresses the "is of low risk" part of the requirement, but not the "substantial benefit to OpenJDK 11u users" part. What is the substantial benefit? UseSIMDForMemoryOps takes great advantage of ARM Neoverse on array copy ops which is substantial to applications on JDK11 running on ARM Neoverse servers. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2425#issuecomment-1875077140 From lmao at openjdk.org Wed Jan 3 09:55:23 2024 From: lmao at openjdk.org (Liang Mao) Date: Wed, 3 Jan 2024 09:55:23 GMT Subject: [jdk11u-dev] RFR: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2 [v2] In-Reply-To: References: Message-ID: <0dBbEQspU0YzRIlNR73gHPiB8djK8a3SO4hwgjGcqJ8=.8bb1a2ef-5396-47cf-81dc-dcbdcd3c4a32@github.com> > Backport of JDK-8280007. The change should be enabled in JDK11 better performance on Neoverse V1/N1/N2. It is quite safe for existing in upstream and 17u for years. > > Additional testing: aarch64 server ARM Neoverse N2 release/fastdebug tier1 Liang Mao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'jdk11dev/master' into backport-mmyxym-f823bed0 - Backport f823bed043dc38d838baaf8c2024ef24b8a50e9b ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2425/files - new: https://git.openjdk.org/jdk11u-dev/pull/2425/files/a8ce3aeb..95e36a4a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2425&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2425&range=00-01 Stats: 235 lines in 10 files changed: 204 ins; 16 del; 15 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2425.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2425/head:pull/2425 PR: https://git.openjdk.org/jdk11u-dev/pull/2425 From shade at openjdk.org Wed Jan 3 10:14:59 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 3 Jan 2024 10:14:59 GMT Subject: [jdk21u-dev] RFR: 8322159: ThisEscapeAnalyzer crashes for erroneous code Message-ID: Clean backport to fix a javac corner case. Additional testing: - [x] New regression test fails without the fix, passes with it - [x] macos-aarch64-server-fastdebug, `langtools_all` ------------- Commit messages: - Backport 7455b1b527568aff5b1c16a29fd80b05260c0fad Changes: https://git.openjdk.org/jdk21u-dev/pull/117/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=117&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322159 Stats: 44 lines in 2 files changed: 41 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/117.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/117/head:pull/117 PR: https://git.openjdk.org/jdk21u-dev/pull/117 From shade at openjdk.org Wed Jan 3 10:45:51 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 3 Jan 2024 10:45:51 GMT Subject: [jdk17u-dev] Integrated: 8318961: increase javacserver connection timeout values and max retry attempts In-Reply-To: References: Message-ID: On Tue, 19 Dec 2023 15:29:36 GMT, Aleksey Shipilev wrote: > Unclean backport to improve build reliability. Affected file was moved in JDK 20 with large refactoring, [JDK-8297444](https://bugs.openjdk.org/browse/JDK-8297444). I had to re-apply the patch by hand. > > Additional testing: > - [x] Local macos-aarch64-server-fastdebug build > - [x] GHA This pull request has now been integrated. Changeset: 53211e09 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/53211e097cf83dcd97c23aaeea2942aed78c3da5 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8318961: increase javacserver connection timeout values and max retry attempts Reviewed-by: mbaesken Backport-of: b9983c72295a31e5f5079bc96c892177fbea3a6e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2063 From shade at openjdk.org Wed Jan 3 10:50:56 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 3 Jan 2024 10:50:56 GMT Subject: [jdk17u-dev] Integrated: 8318183: C2: VM may crash after hitting node limit In-Reply-To: References: Message-ID: On Mon, 11 Dec 2023 20:03:43 GMT, Aleksey Shipilev wrote: > Semi-clean backport to solve a potential VM crash due to C2 failing. > > The uncleanliness comes from two places: > > 1. In `Compile::Optimize()`, we do not have the new hunk from [JDK-8286104](https://bugs.openjdk.org/browse/JDK-8286104): https://github.com/openjdk/jdk/commit/31e50f2c7642b046dc9ea1de8ec245dcbc4e1926#diff-f076857d7da81f56709da3de1511b1105727032186cde4d02c678667761f46eaR2247-R2248 -- so no return is needed. > 2. In `PhaseIdealLoop::verify`, we do not have the rewrites from [JDK-8173709](https://bugs.openjdk.org/browse/JDK-8173709): https://github.com/openjdk/jdk/commit/24c6af0637631153707615932f1f10ced4e5c0e8#diff-d49652d43244d52415873c37bf6990269b0d6e2f2111f4f971660470b6bca738R4653-R4657 -- so I had to resolve the conflict by hand. > > Additional testing: > - [x] Linux x86_64 server fastdebug `tier{1,2,3}` > - [x] Linux AArch64 server fastdebug `tier{1,2,3}` This pull request has now been integrated. Changeset: 2a0d0acb Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/2a0d0acb84f8eb74014784cd5c1e0ce86391d11b Stats: 25 lines in 8 files changed: 21 ins; 0 del; 4 mod 8318183: C2: VM may crash after hitting node limit Reviewed-by: phh Backport-of: 31ef400f31b1fd9a861870cce69f6d3eec72aa46 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2044 From rreddy at openjdk.org Wed Jan 3 10:51:01 2024 From: rreddy at openjdk.org (Ravi Reddy) Date: Wed, 3 Jan 2024 10:51:01 GMT Subject: [jdk21u] RFR: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries Message-ID: javac fails with "Unable to implement method" after fixing [JDK-8225377](https://bugs.openjdk.org/browse/JDK-8225377) and [JDK-8320001](https://bugs.openjdk.org/browse/JDK-8320001) in 21.0.2 . More details in [JDK-8322641](https://bugs.openjdk.org/browse/JDK-8322641). Backing out fix [JDK-8225377](https://bugs.openjdk.org/browse/JDK-8225377) and [JDK-8320001](https://bugs.openjdk.org/browse/JDK-8320001) from 21.0.2. ------------- Commit messages: - 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries Changes: https://git.openjdk.org/jdk21u/pull/427/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=427&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322883 Stats: 444 lines in 3 files changed: 0 ins; 444 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/427.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/427/head:pull/427 PR: https://git.openjdk.org/jdk21u/pull/427 From shade at openjdk.org Wed Jan 3 10:52:56 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 3 Jan 2024 10:52:56 GMT Subject: [jdk17u-dev] Integrated: 8205076: [17u] Inet6AddressImpl.c: `lookupIfLocalHost` accesses `int InetAddress.preferIPv6Address` as a boolean In-Reply-To: References: Message-ID: On Tue, 12 Dec 2023 15:17:37 GMT, Aleksey Shipilev wrote: > This is a 11u and 17u -specific bug, see JBS and its comments for more details. I think we can fix this by explicitly checking against the `PREFER_IPV6_VALUE`, like post JDK 18 code does. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `DcmdMBeanTestCheckJni.java` now passes > - [x] macos-aarch64-server-fastdebug, `jdk_net` This pull request has now been integrated. Changeset: 3eb15b02 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/3eb15b02b5efeb065ada8c6ae2bc8718e7892deb Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8205076: [17u] Inet6AddressImpl.c: `lookupIfLocalHost` accesses `int InetAddress.preferIPv6Address` as a boolean Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2048 From shade at openjdk.org Wed Jan 3 10:52:54 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 3 Jan 2024 10:52:54 GMT Subject: [jdk17u-dev] RFR: 8205076: [17u] Inet6AddressImpl.c: `lookupIfLocalHost` accesses `int InetAddress.preferIPv6Address` as a boolean [v2] In-Reply-To: References: Message-ID: On Tue, 2 Jan 2024 18:17:06 GMT, Aleksey Shipilev wrote: >> This is a 11u and 17u -specific bug, see JBS and its comments for more details. I think we can fix this by explicitly checking against the `PREFER_IPV6_VALUE`, like post JDK 18 code does. >> >> Additional testing: >> - [x] macos-aarch64-server-fastdebug, `DcmdMBeanTestCheckJni.java` now passes >> - [x] macos-aarch64-server-fastdebug, `jdk_net` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8205076-macosx-ipv6-check-jni > - Fix Thanks! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2048#issuecomment-1875172408 From shade at openjdk.org Wed Jan 3 10:55:11 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 3 Jan 2024 10:55:11 GMT Subject: [jdk21u-dev] RFR: 8309203: C2: remove copy-by-value of GrowableArray for InterfaceSet In-Reply-To: References: Message-ID: <-N3YLi4TKEBKoVFHikCxhhIDa-FV2iv6ueG11MBV8Bo=.18795500-ca83-4299-a696-f954009a503b@github.com> On Mon, 25 Dec 2023 18:19:57 GMT, Goetz Lindenmaier wrote: > You might want to have a look at the GHA test. That one looks environmental (macos worker died). But I pulled from the master anyway to catch more surprises, and this would re-run GHA. Let's see. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/11#issuecomment-1875176721 From shade at openjdk.org Wed Jan 3 10:55:11 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 3 Jan 2024 10:55:11 GMT Subject: [jdk21u-dev] RFR: 8309203: C2: remove copy-by-value of GrowableArray for InterfaceSet [v2] In-Reply-To: References: Message-ID: > Transplanted from https://github.com/openjdk/jdk21u/pull/423 > > Clean backport to amend JDK 21 change, dodge the potential copy-by-value issues, and sync up codebases. > > Maybe @rwestrel would bless it. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `hotspot:tier1` > - [x] Linux x86_64 server fastdebug `tier{1,2,3}` > - [x] Linux AArch64 server fastdebug `tier{1,2,3}` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8309203-c2-growable-array-copy-by-value - Backport 21cda19d05b688148f023f6d92778b5da210b709 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/11/files - new: https://git.openjdk.org/jdk21u-dev/pull/11/files/72e8221c..2e060f9e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=11&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=11&range=00-01 Stats: 15160 lines in 418 files changed: 6972 ins; 2579 del; 5609 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/11.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/11/head:pull/11 PR: https://git.openjdk.org/jdk21u-dev/pull/11 From shade at openjdk.org Wed Jan 3 11:20:49 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 3 Jan 2024 11:20:49 GMT Subject: [jdk21u-dev] RFR: 8316594: C2 SuperWord: wrong result with hand unrolled loops In-Reply-To: References: Message-ID: <_cvYfjeiYR1EtiaC4lfmApoIPATDBKIW_aE4B_QuEzo=.a1f086c9-9b97-4ea7-8ecc-82f3c4f67176@github.com> On Tue, 2 Jan 2024 17:16:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. > > I had to resove SWPointer / VPointer because 8312332: C2: Refactor SWPointer out from SuperWord is not in 21. > > We had previous backports that needed to be resolved because of this refactoring missing. I assume this will hit us in future repeatedly. > > Thus I had a look at backporting 8312332, but that depends on three other cleanup changes: > 8305636: Expand and clean up predicate classes and move them into separate files > 8311691: C2: Remove legacy code related to PostLoopMultiversioning > 8308606: C2 SuperWord: remove alignment checks when not required > > All four of them can be backported clean, but 8305363 has four follow-up bugs. > > So maybe we need to go the patch and accept the unclean backports right from the beginning of 21u :( Cool. I did the similar thing in https://github.com/openjdk/jdk21u-dev/pull/21, but have not tested it deeply. In my version, I chose to pass `this` to `overlap_possible_with_any_in`, but just using `_slp` looks cleaner. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/110#pullrequestreview-1801808538 From shade at openjdk.org Wed Jan 3 11:31:48 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 3 Jan 2024 11:31:48 GMT Subject: [jdk17u-dev] Integrated: 8283626: AArch64: Set relocInfo::offset_unit to 4 In-Reply-To: References: Message-ID: On Mon, 11 Dec 2023 17:15:15 GMT, Aleksey Shipilev wrote: > Clean backport to improve relocation density. > > Additional testing: > - [x] Linux AArch64 server fastdebug, `tier{1,2,3,4}` This pull request has now been integrated. Changeset: 21171d99 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/21171d9924586089121a548cf6bb0558fbb62009 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8283626: AArch64: Set relocInfo::offset_unit to 4 Backport-of: ab17f88f6ccd793b718394987f868322a2cc0d1f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2040 From goetz at openjdk.org Wed Jan 3 12:08:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Jan 2024 12:08:53 GMT Subject: [jdk11u-dev] RFR: 8259801: Enable XML Signature secure validation mode by default Message-ID: I backport this for parity with 11.0.23-oracle. I resolved the Copyright in the test, will mark clean. I have to check for the backport CSR. ------------- Commit messages: - Backport baf46bac41f11c01691c4d4c77b24f76fedb5926 Changes: https://git.openjdk.org/jdk11u-dev/pull/2426/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2426&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8259801 Stats: 54 lines in 3 files changed: 12 ins; 3 del; 39 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2426.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2426/head:pull/2426 PR: https://git.openjdk.org/jdk11u-dev/pull/2426 From goetz at openjdk.org Wed Jan 3 12:21:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Jan 2024 12:21:55 GMT Subject: [jdk11u-dev] RFR: 8321215: Incorrect x86 instruction encoding for VSIB addressing mode Message-ID: I backport this for parity with 11.0.23-oracle. I had to resolve due to context. ------------- Commit messages: - Backport 027b5dbb6a299e49d3dcbe67d529d6edc67f16d9 Changes: https://git.openjdk.org/jdk11u-dev/pull/2427/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2427&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321215 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2427.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2427/head:pull/2427 PR: https://git.openjdk.org/jdk11u-dev/pull/2427 From shade at openjdk.org Wed Jan 3 12:26:49 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 3 Jan 2024 12:26:49 GMT Subject: [jdk11u-dev] RFR: 8321215: Incorrect x86 instruction encoding for VSIB addressing mode In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 12:16:56 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.23-oracle. > > I had to resolve due to context. Looks fine. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2427#pullrequestreview-1801901496 From shade at openjdk.org Wed Jan 3 12:41:51 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 3 Jan 2024 12:41:51 GMT Subject: [jdk21u-dev] Integrated: 8319137: release _object in ObjectMonitor dtor to avoid races In-Reply-To: References: Message-ID: On Wed, 13 Dec 2023 11:02:46 GMT, Aleksey Shipilev wrote: > Transplanted from https://github.com/openjdk/jdk21u/pull/401 > > This effectively reverts [JDK-8256302](https://bugs.openjdk.org/browse/JDK-8256302), which introduced race condition in JDK 21. The patch does not apply cleanly for two reasons: > 1. Deleted `release_object()` has a different form in JDK 21 due to slight WeakHandle API change. This is not relevant for this patch, just a backporting conflict. I removed `release_object()` by hand. > 2. Without [JDK-8319896](https://bugs.openjdk.org/browse/JDK-8319896) we cannot do `JavaThread::cast` in the incoming changeset, because we can be called by a non-Java thread. I suspect JDK-8319896 would come with its own bugtail, so I would prefer not to backport it now. I have replaced the code back to original pre- JDK 21 form in a separate commit: [Modifications to fit JDK 21](https://github.com/openjdk/jdk21u-dev/commit/65251865632a5624fec70527b7bc1f4dd1d0d637) > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `runtime/Monitor` passes > - [x] Linux AArch64 server fastdebug, `tier1 tier2 tier3 tier4` > - [x] Linux x86_64 server fastdebug, `tier1 tier2 tier3 tier4` This pull request has now been integrated. Changeset: 91773198 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/91773198439b2f5a633f40cb9aea067d73fb58f5 Stats: 48 lines in 3 files changed: 6 ins; 36 del; 6 mod 8319137: release _object in ObjectMonitor dtor to avoid races Reviewed-by: rkennke Backport-of: c39d001c7a1ae9eb322a7bb621a03e18c9bf02a1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/12 From coffeys at openjdk.org Wed Jan 3 13:30:50 2024 From: coffeys at openjdk.org (Sean Coffey) Date: Wed, 3 Jan 2024 13:30:50 GMT Subject: [jdk21u] RFR: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 10:46:27 GMT, Ravi Reddy wrote: > javac fails with "Unable to implement method" after fixing [JDK-8225377](https://bugs.openjdk.org/browse/JDK-8225377) and [JDK-8320001](https://bugs.openjdk.org/browse/JDK-8320001) in 21.0.2 . More details in [JDK-8322641](https://bugs.openjdk.org/browse/JDK-8322641). > > Backing out fix [JDK-8225377](https://bugs.openjdk.org/browse/JDK-8225377) and [JDK-8320001](https://bugs.openjdk.org/browse/JDK-8320001) from 21.0.2. backout code looks correct ------------- Marked as reviewed by coffeys (Reviewer). PR Review: https://git.openjdk.org/jdk21u/pull/427#pullrequestreview-1802053067 From robm at openjdk.org Wed Jan 3 13:30:51 2024 From: robm at openjdk.org (Rob McKenna) Date: Wed, 3 Jan 2024 13:30:51 GMT Subject: [jdk21u] RFR: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 10:46:27 GMT, Ravi Reddy wrote: > javac fails with "Unable to implement method" after fixing [JDK-8225377](https://bugs.openjdk.org/browse/JDK-8225377) and [JDK-8320001](https://bugs.openjdk.org/browse/JDK-8320001) in 21.0.2 . More details in [JDK-8322641](https://bugs.openjdk.org/browse/JDK-8322641). > > Backing out fix [JDK-8225377](https://bugs.openjdk.org/browse/JDK-8225377) and [JDK-8320001](https://bugs.openjdk.org/browse/JDK-8320001) from 21.0.2. LGTM ------------- Marked as reviewed by robm (Lead). PR Review: https://git.openjdk.org/jdk21u/pull/427#pullrequestreview-1802058663 From andrewlu at openjdk.org Wed Jan 3 13:31:58 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 3 Jan 2024 13:31:58 GMT Subject: [jdk11u-dev] Integrated: 8166275: vm/mlvm/meth/stress/compiler/deoptimize keeps timeouting In-Reply-To: References: Message-ID: On Mon, 18 Dec 2023 07:55:54 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. > backport for JDK-8233453 and JDK-8166275. This pull request has now been integrated. Changeset: a0fe96ea Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/a0fe96ea70c55c8cbfbbc9c0af9bb5a334b8f61c Stats: 26 lines in 1 file changed: 24 ins; 0 del; 2 mod 8166275: vm/mlvm/meth/stress/compiler/deoptimize keeps timeouting 8233453: MLVM deoptimize stress test timed out Reviewed-by: mbaesken Backport-of: 05015118259408a399836df563bbd608e9766734 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2407 From andrewlu at openjdk.org Wed Jan 3 13:34:49 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 3 Jan 2024 13:34:49 GMT Subject: [jdk11u-dev] Integrated: 8271890: mark hotspot runtime/Dictionary tests which ignore external VM flags In-Reply-To: References: Message-ID: On Tue, 26 Dec 2023 07:01:24 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. > CleanProtectionDomain.java, this test has not been added to jdk11u-dev, so ignore the backport. This pull request has now been integrated. Changeset: b29ef197 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/b29ef197c9e0c9a15e2721d6103309d3ecd86691 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8271890: mark hotspot runtime/Dictionary tests which ignore external VM flags Reviewed-by: mbaesken Backport-of: cdf3d55c82844a3c8817f8cc33e85ca15a5ad930 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2415 From andrewlu at openjdk.org Wed Jan 3 13:34:50 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 3 Jan 2024 13:34:50 GMT Subject: [jdk11u-dev] Integrated: 8271829: mark hotspot runtime/Throwable tests which ignore external VM flags In-Reply-To: References: Message-ID: On Wed, 27 Dec 2023 07:34:54 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. > > test/hotspot/jtreg/runtime/Throwable/TestCatchThrowableOOM.java > this test has not been added to jdk11u-dev, so ignore the backport. This pull request has now been integrated. Changeset: 2a96f769 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/2a96f76919a416e2935636291400e1032d8b1993 Stats: 4 lines in 2 files changed: 2 ins; 0 del; 2 mod 8271829: mark hotspot runtime/Throwable tests which ignore external VM flags Reviewed-by: mbaesken Backport-of: 659498a07f5be0feae26c1772a6b4e8ad2dec103 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2422 From andrewlu at openjdk.org Wed Jan 3 13:33:53 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 3 Jan 2024 13:33:53 GMT Subject: [jdk11u-dev] Integrated: 8058176: [mlvm] tests should not allow code cache exhaustion In-Reply-To: References: Message-ID: <1-fmf0_QooAYW3JTxem-thC8bTQ0uw6OQYypb_q79zc=.78c7f963-dcfc-4f5e-a20b-f0b42e968b4b@github.com> On Wed, 27 Dec 2023 03:16:56 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. > > test/hotspot/jtreg/ProblemList.txt > the removed tests are not in ProblemList.txt, > "vmTestbase/vm/mlvm/meth/stress/jdi/breakpointInCompiledCode/Test.java 8208255 generic-all" > JDK-8208255 is duplicated with JDK-8058176, so change to 8058176 This pull request has now been integrated. Changeset: cf74d9d8 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/cf74d9d86a0a3c9da8a58c1586eae3f05b55c64b Stats: 51 lines in 2 files changed: 49 ins; 0 del; 2 mod 8058176: [mlvm] tests should not allow code cache exhaustion Reviewed-by: mbaesken Backport-of: 4c83d24f0a12103aa8dedc750bef565aecd7bb4c ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2419 From andrewlu at openjdk.org Wed Jan 3 13:33:52 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 3 Jan 2024 13:33:52 GMT Subject: [jdk11u-dev] Integrated: 8264135: UnsafeGetStableArrayElement should account for different JIT implementation details In-Reply-To: References: Message-ID: <2B1_jZ9aR4P_dYQ3sPQ0WK48ec8OyBQL6YR_a28YLvQ=.838bc444-1e2e-464d-a0fe-9cd013513182@github.com> On Wed, 27 Dec 2023 05:32:33 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. > > ?ClassFileInstaller? path is modified as can't find jdk.test.lib.helpers.ClassFileInstaller, then local test pass. This pull request has now been integrated. Changeset: 325fc37c Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/325fc37c9b30fe34e99451958d97a26ef16e1900 Stats: 18 lines in 1 file changed: 13 ins; 0 del; 5 mod 8264135: UnsafeGetStableArrayElement should account for different JIT implementation details Reviewed-by: mbaesken Backport-of: 5a930c42de276a31de94d72917425374e3bfe207 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2420 From andrewlu at openjdk.org Wed Jan 3 13:34:49 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 3 Jan 2024 13:34:49 GMT Subject: [jdk11u-dev] Integrated: 8271828: mark hotspot runtime/classFileParserBug tests which ignore external VM flags In-Reply-To: <3eg-WrndgTHMMWtVZdhNzQgEfZswXc2zIPxrDuGMWEw=.513f6296-c940-4996-b4f6-f4caccfc2716@github.com> References: <3eg-WrndgTHMMWtVZdhNzQgEfZswXc2zIPxrDuGMWEw=.513f6296-c940-4996-b4f6-f4caccfc2716@github.com> Message-ID: On Tue, 26 Dec 2023 07:28:47 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. > test/hotspot/jtreg/runtime/classFileParserBug/ClassFileParserBug.java > test/hotspot/jtreg/runtime/classFileParserBug/TestEmptyBootstrapMethodsAttr.java > Copyright. > > test/hotspot/jtreg/runtime/classFileParserBug/TestBadPackageWithInterface.java > this test has not been added to jdk11u-dev, so ignore the backport. This pull request has now been integrated. Changeset: 5fc2f4cb Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/5fc2f4cbe50aa8279ec0d702a9f76380163549a5 Stats: 3 lines in 2 files changed: 2 ins; 0 del; 1 mod 8271828: mark hotspot runtime/classFileParserBug tests which ignore external VM flags Reviewed-by: mbaesken Backport-of: e49b7d958c1db70c452cb6c47c885b7e6264b822 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2416 From rreddy at openjdk.org Wed Jan 3 13:33:52 2024 From: rreddy at openjdk.org (Ravi Reddy) Date: Wed, 3 Jan 2024 13:33:52 GMT Subject: [jdk21u] Integrated: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries In-Reply-To: References: Message-ID: <8_9570WVaww33OLQNWAyBBlrXZ8y1b6Lbwyfw82ziZk=.19594992-74dc-407c-a37f-6a2923e9f2f0@github.com> On Wed, 3 Jan 2024 10:46:27 GMT, Ravi Reddy wrote: > javac fails with "Unable to implement method" after fixing [JDK-8225377](https://bugs.openjdk.org/browse/JDK-8225377) and [JDK-8320001](https://bugs.openjdk.org/browse/JDK-8320001) in 21.0.2 . More details in [JDK-8322641](https://bugs.openjdk.org/browse/JDK-8322641). > > Backing out fix [JDK-8225377](https://bugs.openjdk.org/browse/JDK-8225377) and [JDK-8320001](https://bugs.openjdk.org/browse/JDK-8320001) from 21.0.2. This pull request has now been integrated. Changeset: 18e97aa2 Author: Ravi Reddy Committer: Rob McKenna URL: https://git.openjdk.org/jdk21u/commit/18e97aa217087ff7af13a0147eaf091df3cb20eb Stats: 444 lines in 3 files changed: 0 ins; 444 del; 0 mod 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries Reviewed-by: coffeys, robm ------------- PR: https://git.openjdk.org/jdk21u/pull/427 From jdowland at openjdk.org Wed Jan 3 14:09:08 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Wed, 3 Jan 2024 14:09:08 GMT Subject: [jdk21u-dev] RFR: 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location Message-ID: Hi all, This pull request contains a backport of commit [e7486e8c](https://github.com/openjdk/jdk/commit/e7486e8cfc9a3f5cbe3515c68e325a25863c162e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Prasanta Sadhukhan on 15 Nov 2023 and was reviewed by Damon Nguyen, Harshitha Onkar and Alexey Ivanov. Clean backport, test passes afterwards. ------------- Commit messages: - Backport e7486e8cfc9a3f5cbe3515c68e325a25863c162e Changes: https://git.openjdk.org/jdk21u-dev/pull/118/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=118&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315986 Stats: 72 lines in 1 file changed: 22 ins; 30 del; 20 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/118.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/118/head:pull/118 PR: https://git.openjdk.org/jdk21u-dev/pull/118 From aph at openjdk.org Wed Jan 3 14:12:46 2024 From: aph at openjdk.org (Andrew Haley) Date: Wed, 3 Jan 2024 14:12:46 GMT Subject: [jdk11u-dev] RFR: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2 In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 09:34:25 GMT, Liang Mao wrote: > > > > Have a look at "Fix Approvals" https://wiki.openjdk.org/display/JDKUpdates/JDK11u and see what you think. I'm not sure if this one qualifies. > > > > > > > > > I believe this backport is worth considering. JDK11 is still the most used JDK version and Arm Neoverse servers grow rapidly. And this patch is quite safe. > > > > > > Understood, but that only addresses the "is of low risk" part of the requirement, but not the "substantial benefit to OpenJDK 11u users" part. What is the substantial benefit? > > UseSIMDForMemoryOps takes great advantage of ARM Neoverse on array copy ops which is substantial to applications on JDK11 running on ARM Neoverse servers. OK, so let's have a look at the benchmark results. I guess there was a benchmark submitted with the original patch which introduced vectorized memcpy, so it should just be a matter of re-running that on Neoverse V1 & N2. We could try it on V2 while we're at it, so we don't have to go through all this again soon. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2425#issuecomment-1875432070 From goetz at openjdk.org Wed Jan 3 14:54:05 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Jan 2024 14:54:05 GMT Subject: [jdk11u-dev] RFR: 8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport a6ef655b6f98fc2e1c4aa04525b91485b372aaff Changes: https://git.openjdk.org/jdk11u-dev/pull/2428/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2428&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309119 Stats: 85 lines in 2 files changed: 78 ins; 2 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2428.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2428/head:pull/2428 PR: https://git.openjdk.org/jdk11u-dev/pull/2428 From goetz at openjdk.org Wed Jan 3 15:28:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Jan 2024 15:28:55 GMT Subject: [jdk17u-dev] RFR: 8303605: Memory leaks in Metaspace gtests Message-ID: <02B20Ny6IjOJWf9y1H-JMc_AraZyUGaq35_aDlEXzXo=.8baef9b2-05ac-4930-b137-2f0b87b086bc@github.com> I backport this for parity with 17.0.11-oracle. I resolved test_virtualspacenode.cpp due to an extra empty line, will mark as clean. ------------- Commit messages: - Backport ddcb369ceabd2207699632e90a358baf251c6f36 Changes: https://git.openjdk.org/jdk17u-dev/pull/2093/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2093&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303605 Stats: 19 lines in 4 files changed: 18 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2093.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2093/head:pull/2093 PR: https://git.openjdk.org/jdk17u-dev/pull/2093 From goetz at openjdk.org Wed Jan 3 15:37:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 3 Jan 2024 15:37:57 GMT Subject: [jdk17u-dev] RFR: 8316693: Simplify at-requires checkDockerSupport() Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 16fd43c5eb0fb18e93f00b5817d368df5afad969 Changes: https://git.openjdk.org/jdk17u-dev/pull/2094/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2094&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316693 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2094.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2094/head:pull/2094 PR: https://git.openjdk.org/jdk17u-dev/pull/2094 From mbaesken at openjdk.org Wed Jan 3 16:27:47 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 3 Jan 2024 16:27:47 GMT Subject: [jdk11u-dev] Integrated: 8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen In-Reply-To: <95hn_lAIioffQNY7cKRlyurAL8g6CsxPo8goSs3zDvM=.638f8b28-2640-4ae0-922b-b36f7743e3fe@github.com> References: <95hn_lAIioffQNY7cKRlyurAL8g6CsxPo8goSs3zDvM=.638f8b28-2640-4ae0-922b-b36f7743e3fe@github.com> Message-ID: On Mon, 11 Dec 2023 12:52:59 GMT, Matthias Baesken wrote: > 8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen This pull request has now been integrated. Changeset: 93d1dc76 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/93d1dc760a5cbbfa77a143823e2112c573845f16 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod 8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen Backport-of: ed2b4673de6893047407c61f82b5e68741459876 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2352 From mbaesken at openjdk.org Wed Jan 3 17:05:47 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 3 Jan 2024 17:05:47 GMT Subject: [jdk21u-dev] RFR: 8319124: Update XML Security for Java to 3.0.3 In-Reply-To: <7Q7VgKXec5eRGqdwiBGMMxj19YbbL7Vm3AdeEnwkxfY=.952410d3-79d1-44ac-ba7e-0290e08be141@github.com> References: <7Q7VgKXec5eRGqdwiBGMMxj19YbbL7Vm3AdeEnwkxfY=.952410d3-79d1-44ac-ba7e-0290e08be141@github.com> Message-ID: On Sat, 23 Dec 2023 15:23:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. > > The patch applied clean (first commit). > > I removed the strings from SignatureMethod.java as documented in the backport CSR. > I did not change DOMSignatureMethod.java. > > I skipped the changes to GenerationTest.java. The test passes. Hi Goetz , looks mostly good. But I am not sure about this change src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignatureFactory.java } else if (algorithm.equals(DOMSignatureMethod.RSA_SHA3_224_MGF1)) { return new DOMSignatureMethod.SHA3_224withRSAandMGF1(params); } else if (algorithm.equals(DOMSignatureMethod.RSA_SHA3_256_MGF1)) { return new DOMSignatureMethod.SHA3_256withRSAandMGF1(params); } else if (algorithm.equals(DOMSignatureMethod.RSA_SHA3_384_MGF1)) { return new DOMSignatureMethod.SHA3_384withRSAandMGF1(params); } else if (algorithm.equals(DOMSignatureMethod.RSA_SHA3_512_MGF1)) { return new DOMSignatureMethod.SHA3_512withRSAandMGF1(params); here you reference new algorithms from higher jdk versions; should they really be present here in jdk21 ? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/94#issuecomment-1875687231 From sviswanathan at openjdk.org Wed Jan 3 17:02:46 2024 From: sviswanathan at openjdk.org (Sandhya Viswanathan) Date: Wed, 3 Jan 2024 17:02:46 GMT Subject: [jdk11u-dev] RFR: 8321215: Incorrect x86 instruction encoding for VSIB addressing mode In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 12:16:56 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.23-oracle. > > I had to resolve due to context. Marked as reviewed by sviswanathan (no project role). Looks good to me. ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2427#pullrequestreview-1802710416 PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2427#issuecomment-1875683946 From shade at openjdk.org Wed Jan 3 17:16:50 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 3 Jan 2024 17:16:50 GMT Subject: [jdk17u-dev] RFR: 8286312: Stop mixing signed and unsigned types in bit operations [v2] In-Reply-To: References: Message-ID: On Tue, 2 Jan 2024 18:17:24 GMT, Aleksey Shipilev wrote: >> Clean backport to improve Atomics reliability in JDK 17u. The fix accrued no bug tail for 1.5 years. >> >> Additional testing: >> - [x] macos-aarch64-server-fastdebug, `Atomic` gtests > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8286312-atomics-cleanup-signed-unsigned > - Backport 39f4434f44d46548917926c7a802b046197bbe33 GHA run is clean. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2060#issuecomment-1875701833 From shade at openjdk.org Wed Jan 3 17:16:51 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 3 Jan 2024 17:16:51 GMT Subject: [jdk17u-dev] Integrated: 8286312: Stop mixing signed and unsigned types in bit operations In-Reply-To: References: Message-ID: On Tue, 19 Dec 2023 11:23:14 GMT, Aleksey Shipilev wrote: > Clean backport to improve Atomics reliability in JDK 17u. The fix accrued no bug tail for 1.5 years. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `Atomic` gtests This pull request has now been integrated. Changeset: 13ca9b78 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/13ca9b78eb9c0730ae06c0f7b69e984c89137acc Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8286312: Stop mixing signed and unsigned types in bit operations Backport-of: 39f4434f44d46548917926c7a802b046197bbe33 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2060 From shade at openjdk.org Wed Jan 3 18:06:04 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 3 Jan 2024 18:06:04 GMT Subject: [jdk17u-dev] RFR: 8322968: [17u] Amend Atomics gtest with 1-byte tests Message-ID: [JDK-8316645](https://bugs.openjdk.org/browse/JDK-8316645) was backported to 17u without the relevant test additions, because the test file was missing. But now, after the series of atomic support backports, we have the test file, so we can now complete the backport with the test hunks. Compare 17u-dev version: https://github.com/openjdk/jdk17u-dev/commit/db83123c5cc054cee5663201ead92410e6487d81 ...and the mainline: https://github.com/openjdk/jdk/commit/fb055e7e5300958b2a6a290aa6783e8ede929d9a This change adds the missing hunk from mainline change. It includes [JDK-8317335](https://bugs.openjdk.org/browse/JDK-8317335) fix as well. cc: @zifeihan, @RealFYang Additional testing: - [x] macos-aarch64-server-fastdebug, `Atomics` test still passes ------------- Commit messages: - Backport JDK-8317335 - Missing piece of JDK-8316645 Changes: https://git.openjdk.org/jdk17u-dev/pull/2095/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2095&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322968 Stats: 45 lines in 1 file changed: 45 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2095.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2095/head:pull/2095 PR: https://git.openjdk.org/jdk17u-dev/pull/2095 From shade at openjdk.org Wed Jan 3 18:59:15 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 3 Jan 2024 18:59:15 GMT Subject: [jdk17u-dev] RFR: 8293547: Add relaxed add_and_fetch for macos aarch64 atomics Message-ID: Clean backport to improve Atomics performance for the code that opts-in to relaxed CASes. Additional testing: - [x] macos-server-aarch64-fastdebug, `gtest:Atomic` passes - [ ] macos-server-aarch64-fastdebug, `tier1` ------------- Commit messages: - Backport 7a1cb64bc1b85b3ef1b0ba2d84dbc5b8b05c60ff Changes: https://git.openjdk.org/jdk17u-dev/pull/2097/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2097&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293547 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2097.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2097/head:pull/2097 PR: https://git.openjdk.org/jdk17u-dev/pull/2097 From serb at openjdk.org Wed Jan 3 21:04:27 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 3 Jan 2024 21:04:27 GMT Subject: [jdk21u-dev] Integrated: 8301310: The SendRawSysexMessage test may cause a JVM crash In-Reply-To: References: Message-ID: On Tue, 2 Jan 2024 00:07:04 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [d725b73d](https://github.com/openjdk/jdk/commit/d725b73df01ae4478dfaabc47c48cd7231d91afa) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alec Su on 14 Nov 2023 and was reviewed by Sergey Bylokhov. > > Thanks! This pull request has now been integrated. Changeset: 8fbd10bc Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk21u-dev/commit/8fbd10bc5db476abf76a55a456f811132041301f Stats: 19 lines in 2 files changed: 13 ins; 0 del; 6 mod 8301310: The SendRawSysexMessage test may cause a JVM crash Backport-of: d725b73df01ae4478dfaabc47c48cd7231d91afa ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/109 From serb at openjdk.org Thu Jan 4 01:23:51 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 4 Jan 2024 01:23:51 GMT Subject: [jdk21u-dev] RFR: 8315042: NPE in PKCS7.parseOldSignedData Message-ID: Hi all, This pull request contains a backport of commit [8c0d026d](https://github.com/openjdk/jdk/commit/8c0d026d0f508e0c896fd28d725915c52d1b689d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Mark Powers on 4 Oct 2023 and was reviewed by Valerie Peng and Weijun Wang. Thanks! ------------- Commit messages: - Backport 8c0d026d0f508e0c896fd28d725915c52d1b689d Changes: https://git.openjdk.org/jdk21u-dev/pull/111/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=111&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315042 Stats: 49 lines in 2 files changed: 11 ins; 20 del; 18 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/111.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/111/head:pull/111 PR: https://git.openjdk.org/jdk21u-dev/pull/111 From fyang at openjdk.org Thu Jan 4 02:52:25 2024 From: fyang at openjdk.org (Fei Yang) Date: Thu, 4 Jan 2024 02:52:25 GMT Subject: [jdk17u-dev] RFR: 8322968: [17u] Amend Atomics gtest with 1-byte tests In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 18:00:29 GMT, Aleksey Shipilev wrote: > [JDK-8316645](https://bugs.openjdk.org/browse/JDK-8316645) was backported to 17u without the relevant test additions, because the test file was missing. But now, after the series of atomic support backports, we have the test file, so we can now complete the backport with the test hunks. > > Compare 17u-dev version: > https://github.com/openjdk/jdk17u-dev/commit/db83123c5cc054cee5663201ead92410e6487d81 > > ...and the mainline: > https://github.com/openjdk/jdk/commit/fb055e7e5300958b2a6a290aa6783e8ede929d9a > > This change adds the missing hunk from mainline change. It includes [JDK-8317335](https://bugs.openjdk.org/browse/JDK-8317335) fix as well. > > cc: @zifeihan, @RealFYang > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `Atomics` test still passes Looks good. Thanks. Also performed `gtest:Atomic` on linux-riscv64 platform. BTW: Maybe we should link https://bugs.openjdk.org/browse/JDK-8317335 with this PR as well? ------------- Marked as reviewed by fyang (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2095#pullrequestreview-1803358363 From serb at openjdk.org Thu Jan 4 02:57:34 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 4 Jan 2024 02:57:34 GMT Subject: [jdk17u-dev] RFR: 8315042: NPE in PKCS7.parseOldSignedData Message-ID: Hi all, This pull request contains a backport of commit [8c0d026d](https://github.com/openjdk/jdk/commit/8c0d026d0f508e0c896fd28d725915c52d1b689d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Mark Powers on 4 Oct 2023 and was reviewed by Valerie Peng and Weijun Wang. Thanks! ------------- Commit messages: - Backport 8c0d026d0f508e0c896fd28d725915c52d1b689d Changes: https://git.openjdk.org/jdk17u-dev/pull/2091/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2091&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315042 Stats: 49 lines in 2 files changed: 11 ins; 20 del; 18 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2091.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2091/head:pull/2091 PR: https://git.openjdk.org/jdk17u-dev/pull/2091 From andrewlu at openjdk.org Thu Jan 4 03:22:36 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 4 Jan 2024 03:22:36 GMT Subject: [jdk11u-dev] RFR: 8311585: Add JRadioButtonMenuItem to bug8031573.java Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport 4f90abaf17716493bad740dcef76d49f16d69379 Changes: https://git.openjdk.org/jdk11u-dev/pull/2430/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2430&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311585 Stats: 24 lines in 1 file changed: 12 ins; 2 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2430.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2430/head:pull/2430 PR: https://git.openjdk.org/jdk11u-dev/pull/2430 From serb at openjdk.org Thu Jan 4 03:32:37 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 4 Jan 2024 03:32:37 GMT Subject: [jdk11u-dev] RFR: 8315042: NPE in PKCS7.parseOldSignedData Message-ID: Hi all, This pull request contains a backport of commit [8c0d026d](https://github.com/openjdk/jdk/commit/8c0d026d0f508e0c896fd28d725915c52d1b689d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Mark Powers on 4 Oct 2023 and was reviewed by Valerie Peng and Weijun Wang. Thanks! ------------- Commit messages: - Backport 8c0d026d0f508e0c896fd28d725915c52d1b689d Changes: https://git.openjdk.org/jdk11u-dev/pull/2429/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2429&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315042 Stats: 49 lines in 2 files changed: 11 ins; 20 del; 18 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2429.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2429/head:pull/2429 PR: https://git.openjdk.org/jdk11u-dev/pull/2429 From andrewlu at openjdk.org Thu Jan 4 05:46:48 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 4 Jan 2024 05:46:48 GMT Subject: [jdk11u-dev] RFR: 8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt Message-ID: <6eE0ccBtzGIucxC0IAAZOTxUQavdPo_uP8LyTTqFEZE=.66acf5d3-c261-4566-a0b4-a0a619b89eea@github.com> I backport this for parity with 11.0.23-oracle. Not in ProblemList.txt?so make it clean. ------------- Commit messages: - Backport c84866ac0dcda487fe2abc2a8841f237df0a395b Changes: https://git.openjdk.org/jdk11u-dev/pull/2431/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2431&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310551 Stats: 8 lines in 2 files changed: 1 ins; 1 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2431.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2431/head:pull/2431 PR: https://git.openjdk.org/jdk11u-dev/pull/2431 From andrewlu at openjdk.org Thu Jan 4 05:59:46 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 4 Jan 2024 05:59:46 GMT Subject: [jdk11u-dev] RFR: 8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport b6dddf4ce6072416e17cadefbd8280f959fd93ca Changes: https://git.openjdk.org/jdk11u-dev/pull/2432/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2432&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8239801 Stats: 159 lines in 1 file changed: 159 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2432.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2432/head:pull/2432 PR: https://git.openjdk.org/jdk11u-dev/pull/2432 From andrewlu at openjdk.org Thu Jan 4 06:13:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 4 Jan 2024 06:13:40 GMT Subject: [jdk11u-dev] RFR: 8202931: [macos] java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java fails Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport f80faced6e6c6c1b10541a8b0c91625215c9ef43 Changes: https://git.openjdk.org/jdk11u-dev/pull/2433/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2433&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8202931 Stats: 10 lines in 2 files changed: 7 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2433.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2433/head:pull/2433 PR: https://git.openjdk.org/jdk11u-dev/pull/2433 From lmao at openjdk.org Thu Jan 4 06:35:27 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 4 Jan 2024 06:35:27 GMT Subject: [jdk11u-dev] RFR: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2 In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 14:10:14 GMT, Andrew Haley wrote: > > > > > Have a look at "Fix Approvals" https://wiki.openjdk.org/display/JDKUpdates/JDK11u and see what you think. I'm not sure if this one qualifies. > > > > > > > > > > > > I believe this backport is worth considering. JDK11 is still the most used JDK version and Arm Neoverse servers grow rapidly. And this patch is quite safe. > > > > > > > > > Understood, but that only addresses the "is of low risk" part of the requirement, but not the "substantial benefit to OpenJDK 11u users" part. What is the substantial benefit? > > > > > > UseSIMDForMemoryOps takes great advantage of ARM Neoverse on array copy ops which is substantial to applications on JDK11 running on ARM Neoverse servers. > > OK, so let's have a look at the benchmark results. I guess there was a benchmark submitted with the original patch which introduced vectorized memcpy, so it should just be a matter of re-running that on Neoverse V1 & N2. We could try it on V2 while we're at it, so we don't have to go through all this again soon. We have a bunch of array tests. UseSIMDForMemoryOps provides 10-60% improvements on several typical non-short array copy micro benchmarks on JDK11 with Neoverse N2. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2425#issuecomment-1876475140 From lmao at openjdk.org Thu Jan 4 06:35:28 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 4 Jan 2024 06:35:28 GMT Subject: [jdk11u-dev] RFR: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2 In-Reply-To: References: Message-ID: <23z7tBbkzpt9KYctPifm4uUxBewqboeBzdW_CXgh5jY=.526a09b9-ac5c-437c-b923-1a62732f95d5@github.com> On Wed, 3 Jan 2024 07:57:39 GMT, Goetz Lindenmaier wrote: > Please enable the GHA tests for the jdk11u-dev repo and restart the tests. You can restart them by merging head. Merged and passed the GHA tests. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2425#issuecomment-1876476350 From shade at openjdk.org Thu Jan 4 08:38:34 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 08:38:34 GMT Subject: [jdk17u-dev] RFR: 8322968: [17u] Amend Atomics gtest with 1-byte tests In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 18:00:29 GMT, Aleksey Shipilev wrote: > [JDK-8316645](https://bugs.openjdk.org/browse/JDK-8316645) was backported to 17u without the relevant test additions, because the test file was missing. But now, after the series of atomic support backports, we have the test file, so we can now complete the backport with the test hunks. > > Compare 17u-dev version: > https://github.com/openjdk/jdk17u-dev/commit/db83123c5cc054cee5663201ead92410e6487d81 > > ...and the mainline: > https://github.com/openjdk/jdk/commit/fb055e7e5300958b2a6a290aa6783e8ede929d9a > > This change adds the missing hunk from mainline change. It includes [JDK-8317335](https://bugs.openjdk.org/browse/JDK-8317335) fix as well. > > cc: @zifeihan, @RealFYang > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `Atomics` test still passes All right, this was weird, the `8317335` was not treated as backport. I could probably redo the PR to include it with its commit hash, but I prefer not to. So I would instead like to move forward with this. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2095#issuecomment-1876704059 From jdowland at openjdk.org Thu Jan 4 09:14:25 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 4 Jan 2024 09:14:25 GMT Subject: [jdk21u-dev] Integrated: 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 14:02:11 GMT, Jonathan Dowland wrote: > Hi all, > > This pull request contains a backport of commit [e7486e8c](https://github.com/openjdk/jdk/commit/e7486e8cfc9a3f5cbe3515c68e325a25863c162e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Prasanta Sadhukhan on 15 Nov 2023 and was reviewed by Damon Nguyen, Harshitha Onkar and Alexey Ivanov. > > Clean backport, test passes afterwards. This pull request has now been integrated. Changeset: 57b51472 Author: Jonathan Dowland URL: https://git.openjdk.org/jdk21u-dev/commit/57b5147260464214122cb5200566c2b4d2889c75 Stats: 72 lines in 1 file changed: 22 ins; 30 del; 20 mod 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location Backport-of: e7486e8cfc9a3f5cbe3515c68e325a25863c162e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/118 From aph at openjdk.org Thu Jan 4 09:16:31 2024 From: aph at openjdk.org (Andrew Haley) Date: Thu, 4 Jan 2024 09:16:31 GMT Subject: [jdk17u-dev] RFR: 8293547: Add relaxed add_and_fetch for macos aarch64 atomics In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 18:29:27 GMT, Aleksey Shipilev wrote: > Clean backport to improve Atomics performance for the code that opts-in to relaxed CASes. > > Additional testing: > - [x] macos-server-aarch64-fastdebug, `gtest:Atomic` passes > - [x] macos-server-aarch64-fastdebug, `tier1` Marked as reviewed by aph (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2097#pullrequestreview-1803767904 From shade at openjdk.org Thu Jan 4 09:05:31 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 09:05:31 GMT Subject: [jdk21u-dev] Integrated: 8309203: C2: remove copy-by-value of GrowableArray for InterfaceSet In-Reply-To: References: Message-ID: On Wed, 13 Dec 2023 10:52:49 GMT, Aleksey Shipilev wrote: > Transplanted from https://github.com/openjdk/jdk21u/pull/423 > > Clean backport to amend JDK 21 change, dodge the potential copy-by-value issues, and sync up codebases. > > Maybe @rwestrel would bless it. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `hotspot:tier1` > - [x] Linux x86_64 server fastdebug `tier{1,2,3}` > - [x] Linux AArch64 server fastdebug `tier{1,2,3}` This pull request has now been integrated. Changeset: 966071a5 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/966071a5f10a7a8910b2639e10c961924a07d675 Stats: 286 lines in 2 files changed: 66 ins; 44 del; 176 mod 8309203: C2: remove copy-by-value of GrowableArray for InterfaceSet Backport-of: 21cda19d05b688148f023f6d92778b5da210b709 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/11 From goetz at openjdk.org Thu Jan 4 09:04:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 4 Jan 2024 09:04:46 GMT Subject: [jdk17u-dev] RFR: 8303605: Memory leaks in Metaspace gtests In-Reply-To: <02B20Ny6IjOJWf9y1H-JMc_AraZyUGaq35_aDlEXzXo=.8baef9b2-05ac-4930-b137-2f0b87b086bc@github.com> References: <02B20Ny6IjOJWf9y1H-JMc_AraZyUGaq35_aDlEXzXo=.8baef9b2-05ac-4930-b137-2f0b87b086bc@github.com> Message-ID: On Wed, 3 Jan 2024 15:23:38 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. > > I resolved test_virtualspacenode.cpp due to an extra empty line, will mark as clean. GHA failure: macos upload timeout: Error: Request timeout: /8fQIQO4jqtxkMRqmMDLs8VYF6JFz66gUS8qbLflltLWCwd5en1/_apis/resources/Containers/53869739?itemPath=bundles-macos-x64%2Fjdk-macos-x64.tar.gz ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2093#issuecomment-1876735775 From goetz at openjdk.org Thu Jan 4 09:04:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 4 Jan 2024 09:04:44 GMT Subject: [jdk17u-dev] RFR: 8303605: Memory leaks in Metaspace gtests [v2] In-Reply-To: <02B20Ny6IjOJWf9y1H-JMc_AraZyUGaq35_aDlEXzXo=.8baef9b2-05ac-4930-b137-2f0b87b086bc@github.com> References: <02B20Ny6IjOJWf9y1H-JMc_AraZyUGaq35_aDlEXzXo=.8baef9b2-05ac-4930-b137-2f0b87b086bc@github.com> Message-ID: > I backport this for parity with 17.0.11-oracle. > > I resolved test_virtualspacenode.cpp due to an extra empty line, will mark as clean. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into goetz_backport_8303605 - Backport ddcb369ceabd2207699632e90a358baf251c6f36 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2093/files - new: https://git.openjdk.org/jdk17u-dev/pull/2093/files/cbba7c01..2ad59446 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2093&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2093&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2093.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2093/head:pull/2093 PR: https://git.openjdk.org/jdk17u-dev/pull/2093 From mdoerr at openjdk.org Thu Jan 4 09:26:31 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 4 Jan 2024 09:26:31 GMT Subject: [jdk17u-dev] RFR: 8278028: [test-library] Warnings cleanup of the test library In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 09:07:31 GMT, Goetz Lindenmaier wrote: > I think this is good to have in 17 to reduce the warnings and to simplify further test backports > > Skipped patch to OldWhiteBox.java, file not in 17. > Resolved InMemoryJavaCompiler.java: Copyright, import. Changes already backported. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2092#pullrequestreview-1803783112 From mdoerr at openjdk.org Thu Jan 4 09:28:28 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 4 Jan 2024 09:28:28 GMT Subject: [jdk17u-dev] RFR: 8303605: Memory leaks in Metaspace gtests [v2] In-Reply-To: References: <02B20Ny6IjOJWf9y1H-JMc_AraZyUGaq35_aDlEXzXo=.8baef9b2-05ac-4930-b137-2f0b87b086bc@github.com> Message-ID: On Thu, 4 Jan 2024 09:04:44 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.11-oracle. >> >> I resolved test_virtualspacenode.cpp due to an extra empty line, will mark as clean. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into goetz_backport_8303605 > - Backport ddcb369ceabd2207699632e90a358baf251c6f36 LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2093#pullrequestreview-1803787289 From shade at openjdk.org Thu Jan 4 09:28:58 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 09:28:58 GMT Subject: [jdk21u-dev] RFR: 8321974: Crash in ciKlass::is_subtype_of because TypeAryPtr::_klass is not initialized Message-ID: Clean backport to fix C2 regression in JDK 21. Additional testing: - [x] New regression test _passes_ even without a fix - [ ] linux-x86_64-server-fastdebug, `tier{1,2,3}` ------------- Commit messages: - Backport c8ad7b7f84ead3f850f034e1db6335bbbac41589 Changes: https://git.openjdk.org/jdk21u-dev/pull/119/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=119&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321974 Stats: 89 lines in 3 files changed: 54 ins; 22 del; 13 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/119.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/119/head:pull/119 PR: https://git.openjdk.org/jdk21u-dev/pull/119 From shade at openjdk.org Thu Jan 4 09:29:31 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 09:29:31 GMT Subject: [jdk17u-dev] Integrated: 8322968: [17u] Amend Atomics gtest with 1-byte tests In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 18:00:29 GMT, Aleksey Shipilev wrote: > [JDK-8316645](https://bugs.openjdk.org/browse/JDK-8316645) was backported to 17u without the relevant test additions, because the test file was missing. But now, after the series of atomic support backports, we have the test file, so we can now complete the backport with the test hunks. > > Compare 17u-dev version: > https://github.com/openjdk/jdk17u-dev/commit/db83123c5cc054cee5663201ead92410e6487d81 > > ...and the mainline: > https://github.com/openjdk/jdk/commit/fb055e7e5300958b2a6a290aa6783e8ede929d9a > > This change adds the missing hunk from mainline change. It includes [JDK-8317335](https://bugs.openjdk.org/browse/JDK-8317335) fix as well. > > cc: @zifeihan, @RealFYang > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `Atomics` test still passes This pull request has now been integrated. Changeset: 73fcc8ea Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/73fcc8ea23689f1f7970b2a1a36be2528cc6a5b6 Stats: 45 lines in 1 file changed: 45 ins; 0 del; 0 mod 8322968: [17u] Amend Atomics gtest with 1-byte tests Reviewed-by: fyang ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2095 From shade at openjdk.org Thu Jan 4 09:34:57 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 09:34:57 GMT Subject: [jdk21u-dev] RFR: 8320921: GHA: Parallelize hotspot_compiler test jobs Message-ID: <3Tt6YF-fAZVXmDPdcgk0OkhpKazZH4j3jRrNcL8hnJc=.7ae82c77-b824-4e5e-9ac2-cd918788e3a5@github.com> Clean backport to make GHA testing faster. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 694136909c058370a5833322ebaf2e71a0a15164 Changes: https://git.openjdk.org/jdk21u-dev/pull/121/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=121&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320921 Stats: 13 lines in 1 file changed: 10 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/121.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/121/head:pull/121 PR: https://git.openjdk.org/jdk21u-dev/pull/121 From shade at openjdk.org Thu Jan 4 09:50:30 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 09:50:30 GMT Subject: [jdk21u-dev] RFR: 8322321: Add man page doc for -XX:+VerifySharedSpaces Message-ID: Clean backport for parity with 21.0.3-oracle. ------------- Commit messages: - Backport f7dc257a206d3104d6d24c2079ef1fe349368c49 Changes: https://git.openjdk.org/jdk21u-dev/pull/120/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=120&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322321 Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/120.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/120/head:pull/120 PR: https://git.openjdk.org/jdk21u-dev/pull/120 From shade at openjdk.org Thu Jan 4 09:58:40 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 09:58:40 GMT Subject: [jdk21u-dev] RFR: 8318082: ConcurrentModificationException from IndexWriter [v2] In-Reply-To: References: Message-ID: > Unclean backport to fix a customer-visible bug in Javadoc tool. The uncleanliness comes from the missing refactoring ([JDK-8309566](https://bugs.openjdk.org/browse/JDK-8309566), that looks unnecessary to backport. > > Maybe @jonathan-gibbons and @pavelrappo want to take a look. > > Additional testing: > - [x] New test fails without the product fix, passes with it > - [x] `jdk/javadoc` still passes Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8318082-cme-indexwriter - Backport fc29a2e152310ed81bd1bb23e6f17d02f055a454 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/23/files - new: https://git.openjdk.org/jdk21u-dev/pull/23/files/fb40d3da..d7f22a8a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=23&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=23&range=00-01 Stats: 15513 lines in 425 files changed: 7057 ins; 2659 del; 5797 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/23.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/23/head:pull/23 PR: https://git.openjdk.org/jdk21u-dev/pull/23 From ogillespie at openjdk.org Thu Jan 4 09:54:51 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 4 Jan 2024 09:54:51 GMT Subject: [jdk21u-dev] RFR: 8321599: Data loss in AVX3 Base64 decoding Message-ID: Hi all, This pull request contains a backport of commit [13c11487](https://github.com/openjdk/jdk/commit/13c11487f7126a370d9ce8e62f661ea83eedefe6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Scott Gibbons on 4 Jan 2024 and was reviewed by Sandhya Viswanathan and Vladimir Kozlov. Thanks! ------------- Commit messages: - Backport 13c11487f7126a370d9ce8e62f661ea83eedefe6 Changes: https://git.openjdk.org/jdk21u-dev/pull/122/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=122&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321599 Stats: 124 lines in 2 files changed: 121 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/122.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/122/head:pull/122 PR: https://git.openjdk.org/jdk21u-dev/pull/122 From shade at openjdk.org Thu Jan 4 09:56:25 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 09:56:25 GMT Subject: [jdk21u-dev] RFR: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM Message-ID: Clean backport to improve heap dump reliability w.r.t. filler objects. Only happens after JDK 19. Additional testing: - [x] Affected test still passes ------------- Commit messages: - Backport 05745e3f1d56f71d7647e81fa5933c9f4ed18430 Changes: https://git.openjdk.org/jdk21u-dev/pull/123/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=123&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319548 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/123.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/123/head:pull/123 PR: https://git.openjdk.org/jdk21u-dev/pull/123 From jdowland at openjdk.org Thu Jan 4 10:01:49 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 4 Jan 2024 10:01:49 GMT Subject: [jdk21u-dev] RFR: 8315731: Open source several Swing Text related tests Message-ID: For Oracle parity. Cherry picks clean. Test only. Introduces 5 newly-open-sourced Swing tests which all pass. ------------- Commit messages: - Backport d475f61fd52b7d379260811b32d3815786858411 Changes: https://git.openjdk.org/jdk21u-dev/pull/124/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=124&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315731 Stats: 468 lines in 5 files changed: 468 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/124.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/124/head:pull/124 PR: https://git.openjdk.org/jdk21u-dev/pull/124 From jdowland at openjdk.org Thu Jan 4 10:08:23 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 4 Jan 2024 10:08:23 GMT Subject: [jdk21u-dev] RFR: 8315731: Open source several Swing Text related tests In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 09:53:29 GMT, Jonathan Dowland wrote: > For Oracle parity. Cherry picks clean. Test only. Introduces 5 newly-open-sourced Swing tests which all pass. First time trying this... ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/124#issuecomment-1876826220 From shade at openjdk.org Thu Jan 4 09:58:41 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 09:58:41 GMT Subject: [jdk21u-dev] RFR: 8318082: ConcurrentModificationException from IndexWriter In-Reply-To: References: Message-ID: On Wed, 13 Dec 2023 18:17:06 GMT, Aleksey Shipilev wrote: > Unclean backport to fix a customer-visible bug in Javadoc tool. The uncleanliness comes from the missing refactoring ([JDK-8309566](https://bugs.openjdk.org/browse/JDK-8309566), that looks unnecessary to backport. > > Maybe @jonathan-gibbons and @pavelrappo want to take a look. > > Additional testing: > - [x] New test fails without the product fix, passes with it > - [x] `jdk/javadoc` still passes Still looking for formal (R)eviewers here, then I could apply for maintainer approval. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/23#issuecomment-1876811311 From jdowland at openjdk.org Thu Jan 4 10:12:08 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 4 Jan 2024 10:12:08 GMT Subject: [jdk17u-dev] RFR: 8322321: Add man page doc for -XX:+VerifySharedSpaces Message-ID: This is an unclean backport of a manpage fix, for Oracle parity. The conflict was trivial to resolve manually and was due to the troff source being updated post-17u for 8297164, which is unlikely to be backported itself. ------------- Commit messages: - 8322321: Add man page doc for -XX:+VerifySharedSpaces Changes: https://git.openjdk.org/jdk17u-dev/pull/2098/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2098&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322321 Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2098.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2098/head:pull/2098 PR: https://git.openjdk.org/jdk17u-dev/pull/2098 From shade at openjdk.org Thu Jan 4 10:17:28 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 10:17:28 GMT Subject: [jdk17u-dev] RFR: 8322321: Add man page doc for -XX:+VerifySharedSpaces In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:03:44 GMT, Jonathan Dowland wrote: > This is an unclean backport of a manpage fix, for Oracle parity. The conflict was trivial to resolve manually and was due to the troff source being updated post-17u for 8297164, which is unlikely to be backported itself. Looks okay. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2098#pullrequestreview-1803865648 From shade at openjdk.org Thu Jan 4 10:27:33 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 10:27:33 GMT Subject: [jdk17u-dev] RFR: 8320921: GHA: Parallelize hotspot_compiler test jobs Message-ID: Clean backport to make GHA testing faster. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 694136909c058370a5833322ebaf2e71a0a15164 Changes: https://git.openjdk.org/jdk17u-dev/pull/2099/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2099&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320921 Stats: 13 lines in 1 file changed: 10 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2099.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2099/head:pull/2099 PR: https://git.openjdk.org/jdk17u-dev/pull/2099 From ogillespie at openjdk.org Thu Jan 4 10:29:35 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 4 Jan 2024 10:29:35 GMT Subject: [jdk17u-dev] RFR: 8321599: Data loss in AVX3 Base64 decoding Message-ID: Hi all, This pull request contains a backport of commit [13c11487](https://github.com/openjdk/jdk/commit/13c11487f7126a370d9ce8e62f661ea83eedefe6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Scott Gibbons on 4 Jan 2024 and was reviewed by Sandhya Viswanathan and Vladimir Kozlov. Thanks! There were 3 conflicts when merging: 1. Trivial original copyright year difference (2021 here, 2023 in tip) 2. Trivial whitespace difference for the dp_mem hunk (4 space indentation here, 2 spaces in tip) 3. Git was confused about where to apply the addq/subq hunk, and chose the wrong place (indentation difference again?). Also trivial, once moved. ------------- Commit messages: - Backport 13c11487f7126a370d9ce8e62f661ea83eedefe6 Changes: https://git.openjdk.org/jdk17u-dev/pull/2100/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2100&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321599 Stats: 124 lines in 2 files changed: 121 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2100.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2100/head:pull/2100 PR: https://git.openjdk.org/jdk17u-dev/pull/2100 From jdowland at openjdk.org Thu Jan 4 10:35:53 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 4 Jan 2024 10:35:53 GMT Subject: [jdk17u-dev] RFR: 8315731: Open source several Swing Text related tests Message-ID: Clean backport of 5 newly-opensourced Swing tests. All the tests pass in 17u-dev. For Oracle parity. ------------- Commit messages: - Backport d475f61fd52b7d379260811b32d3815786858411 Changes: https://git.openjdk.org/jdk17u-dev/pull/2101/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2101&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315731 Stats: 468 lines in 5 files changed: 468 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2101.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2101/head:pull/2101 PR: https://git.openjdk.org/jdk17u-dev/pull/2101 From shade at openjdk.org Thu Jan 4 10:42:37 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 10:42:37 GMT Subject: [jdk21u-dev] RFR: 8320145: Compiler should accept final variable in Record Pattern Message-ID: Clean backport to fix the new language feature in JDK 21. The patch extends the space of compilable programs. Additional testing: - [x] New regression test fails without the fix, passes with it - [x] macos-aarch64-server-fastdebug, `langtools_all` ------------- Commit messages: - Backport 4ba94ef69ef2ee576c50bb6003a795746dcdf30d Changes: https://git.openjdk.org/jdk21u-dev/pull/125/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=125&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320145 Stats: 48 lines in 3 files changed: 44 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/125.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/125/head:pull/125 PR: https://git.openjdk.org/jdk21u-dev/pull/125 From shade at openjdk.org Thu Jan 4 10:43:28 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 10:43:28 GMT Subject: [jdk17u-dev] RFR: 8322321: Add man page doc for -XX:+VerifySharedSpaces In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:03:44 GMT, Jonathan Dowland wrote: > This is an unclean backport of a manpage fix, for Oracle parity. The conflict was trivial to resolve manually and was due to the troff source being updated post-17u for 8297164, which is unlikely to be backported itself. Nope, you now need maintainer approval. My review only covers the "unclean backport" part. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2098#issuecomment-1876877377 From jdowland at openjdk.org Thu Jan 4 10:47:31 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 4 Jan 2024 10:47:31 GMT Subject: [jdk17u-dev] RFR: 8322321: Add man page doc for -XX:+VerifySharedSpaces In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:40:52 GMT, Aleksey Shipilev wrote: > Nope, you now need maintainer approval. My review only covers the "unclean backport" part. Gotcha, thanks. I'm somewhat rusty. This is useful [grist for the mill](https://fosdem.org/2024/schedule/event/fosdem-2024-2460-a-beginner-s-guide-to-backports/). ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2098#issuecomment-1876883157 From duke at openjdk.org Thu Jan 4 11:11:59 2024 From: duke at openjdk.org (yaqsun) Date: Thu, 4 Jan 2024 11:11:59 GMT Subject: [jdk21u-dev] RFR: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize Message-ID: Patch can be applied cleanly. And test have been locally verified to pass. ------------- Commit messages: - Backport fe862639e7ce40f5adef0e482b1fb9c718e061a3 Changes: https://git.openjdk.org/jdk21u-dev/pull/126/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=126&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316319 Stats: 40 lines in 6 files changed: 30 ins; 10 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/126.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/126/head:pull/126 PR: https://git.openjdk.org/jdk21u-dev/pull/126 From ogillespie at openjdk.org Thu Jan 4 11:43:23 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 4 Jan 2024 11:43:23 GMT Subject: [jdk21u-dev] RFR: 8321599: Data loss in AVX3 Base64 decoding In-Reply-To: References: Message-ID: <8zFLI9wwtjLODn0xH7a-_EjnK25t1rY5DdGRFNydWNs=.bdf613bf-1714-4fda-acaf-0560bc09af43@github.com> On Thu, 4 Jan 2024 09:48:48 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [13c11487](https://github.com/openjdk/jdk/commit/13c11487f7126a370d9ce8e62f661ea83eedefe6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Scott Gibbons on 4 Jan 2024 and was reviewed by Sandhya Viswanathan and Vladimir Kozlov. > > Thanks! Confirmed that `make test TEST="compiler/intrinsics/base64/TestBase64.java"` fails with the new test but without the fix, and passes with the fix (on an AWS c6i instance type to trigger the problematic path). ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/122#issuecomment-1876957108 From ogillespie at openjdk.org Thu Jan 4 11:43:26 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 4 Jan 2024 11:43:26 GMT Subject: [jdk17u-dev] RFR: 8321599: Data loss in AVX3 Base64 decoding In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:23:52 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [13c11487](https://github.com/openjdk/jdk/commit/13c11487f7126a370d9ce8e62f661ea83eedefe6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Scott Gibbons on 4 Jan 2024 and was reviewed by Sandhya Viswanathan and Vladimir Kozlov. > > Thanks! > > There were 3 conflicts when merging: > 1. Trivial original copyright year difference (2021 here, 2023 in tip) > 2. Trivial whitespace difference for the dp_mem hunk (4 space indentation here, 2 spaces in tip) > 3. Git was confused about where to apply the addq/subq hunk, and chose the wrong place (indentation difference again?). Also trivial, once moved. Confirmed that `make test TEST="compiler/intrinsics/base64/TestBase64.java"` fails with the new test but without the fix, and passes with the fix (on an AWS c6i instance type to trigger the problematic path). ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2100#issuecomment-1876957864 From shade at openjdk.org Thu Jan 4 11:56:25 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 11:56:25 GMT Subject: [jdk17u-dev] RFR: 8321599: Data loss in AVX3 Base64 decoding In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:23:52 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [13c11487](https://github.com/openjdk/jdk/commit/13c11487f7126a370d9ce8e62f661ea83eedefe6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Scott Gibbons on 4 Jan 2024 and was reviewed by Sandhya Viswanathan and Vladimir Kozlov. > > Thanks! > > There were 3 conflicts when merging: > 1. Trivial original copyright year difference (2021 here, 2023 in tip) > 2. Trivial whitespace difference for the dp_mem hunk (4 space indentation here, 2 spaces in tip) > 3. Git was confused about where to apply the addq/subq hunk, and chose the wrong place (indentation difference again?). Also trivial, once moved. Looks fine. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2100#pullrequestreview-1804012968 From goetz at openjdk.org Thu Jan 4 12:10:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 4 Jan 2024 12:10:23 GMT Subject: [jdk21u-dev] RFR: 8319124: Update XML Security for Java to 3.0.3 In-Reply-To: References: <7Q7VgKXec5eRGqdwiBGMMxj19YbbL7Vm3AdeEnwkxfY=.952410d3-79d1-44ac-ba7e-0290e08be141@github.com> Message-ID: On Wed, 3 Jan 2024 17:02:54 GMT, Matthias Baesken wrote: > Hi Goetz , looks mostly good. But I am not sure about this change > > src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignatureFactory.java > > ``` > } else if (algorithm.equals(DOMSignatureMethod.RSA_SHA3_224_MGF1)) { > return new DOMSignatureMethod.SHA3_224withRSAandMGF1(params); > } else if (algorithm.equals(DOMSignatureMethod.RSA_SHA3_256_MGF1)) { > return new DOMSignatureMethod.SHA3_256withRSAandMGF1(params); > } else if (algorithm.equals(DOMSignatureMethod.RSA_SHA3_384_MGF1)) { > return new DOMSignatureMethod.SHA3_384withRSAandMGF1(params); > } else if (algorithm.equals(DOMSignatureMethod.RSA_SHA3_512_MGF1)) { > return new DOMSignatureMethod.SHA3_512withRSAandMGF1(params); > ``` > > here you reference new algorithms from higher jdk versions; should they really be present here in jdk21 ? I left this in the code because the CSR says "but the underlying implementation code will be integrated for use via the XML signature implementation." There is also code in DOMSignatureMethod.java mentioning the new algs. But I am not sure this is the code that is meant by that note. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/94#issuecomment-1876991257 From mbaesken at openjdk.org Thu Jan 4 12:39:24 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 4 Jan 2024 12:39:24 GMT Subject: [jdk21u-dev] RFR: 8319124: Update XML Security for Java to 3.0.3 In-Reply-To: <7Q7VgKXec5eRGqdwiBGMMxj19YbbL7Vm3AdeEnwkxfY=.952410d3-79d1-44ac-ba7e-0290e08be141@github.com> References: <7Q7VgKXec5eRGqdwiBGMMxj19YbbL7Vm3AdeEnwkxfY=.952410d3-79d1-44ac-ba7e-0290e08be141@github.com> Message-ID: On Sat, 23 Dec 2023 15:23:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. > > The patch applied clean (first commit). > > I removed the strings from SignatureMethod.java as documented in the backport CSR. > I did not change DOMSignatureMethod.java. > > I skipped the changes to GenerationTest.java. The test passes. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/94#pullrequestreview-1804080931 From shade at openjdk.org Thu Jan 4 12:49:51 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 12:49:51 GMT Subject: [jdk21u-dev] RFR: 8321582: yield .class not parsed correctly. Message-ID: Fixes the javac bug, extends the space of compilable Java programs. Additional testing: - [x] New regression test fails without the fix, passes with it - [x] `langtools_all` pass ------------- Commit messages: - Backport ce8399fd6071766114f5f201b6e44a7abdba9f5a Changes: https://git.openjdk.org/jdk21u-dev/pull/128/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=128&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321582 Stats: 29 lines in 2 files changed: 27 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/128.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/128/head:pull/128 PR: https://git.openjdk.org/jdk21u-dev/pull/128 From mbaesken at openjdk.org Thu Jan 4 13:03:31 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 4 Jan 2024 13:03:31 GMT Subject: [jdk17u-dev] Integrated: 8318957: Enhance agentlib:jdwp help output by info about allow option In-Reply-To: <5mqBNoZfm-9VZKtrXD-4OGKZzQW9pM4HtNEuCmqVoOE=.9b06fc09-5bb5-4414-ba13-484b8d6e04f9@github.com> References: <5mqBNoZfm-9VZKtrXD-4OGKZzQW9pM4HtNEuCmqVoOE=.9b06fc09-5bb5-4414-ba13-484b8d6e04f9@github.com> Message-ID: <7-9zFSbj0jDuWWi-f2EtlhfjPLwjJbKwcFmfC823uVo=.0abc5f50-bbb8-499e-896a-086bf7ac53ed@github.com> On Thu, 28 Dec 2023 14:09:31 GMT, Matthias Baesken wrote: > 8318957: Enhance agentlib:jdwp help output by info about allow option This pull request has now been integrated. Changeset: bb50eb37 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/bb50eb37796a5a6256fa43a15492b1c7005af5a8 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8318957: Enhance agentlib:jdwp help output by info about allow option Backport-of: 53bb7cd415f1d2e87d8f06ad5eb611bfdf8ef0ad ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2086 From jlaskey at openjdk.org Thu Jan 4 13:11:36 2024 From: jlaskey at openjdk.org (Jim Laskey) Date: Thu, 4 Jan 2024 13:11:36 GMT Subject: [jdk21u] RFR: 8322512: StringBuffer.repeat does not work correctly after toString() was called Message-ID: 8322512: StringBuffer.repeat does not work correctly after toString() was called ------------- Commit messages: - Backport df22fb322e6c4c9931a770bd0abf4c43b83c4e4a Changes: https://git.openjdk.org/jdk21u/pull/428/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=428&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322512 Stats: 16 lines in 2 files changed: 15 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u/pull/428.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/428/head:pull/428 PR: https://git.openjdk.org/jdk21u/pull/428 From mdoerr at openjdk.org Thu Jan 4 13:55:25 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 4 Jan 2024 13:55:25 GMT Subject: [jdk17u-dev] RFR: 8320208: Update Public Suffix List to b5bf572 In-Reply-To: References: Message-ID: On Tue, 26 Dec 2023 06:41:26 GMT, Andrew Lu wrote: > Backport for JDK-8320208. > make backports to the origin file: > make/data/publicsuffixlist/VERSION > make/data/publicsuffixlist/public_suffix_list.dat Looks good. It's only unclean because files were moved. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2083#pullrequestreview-1804198257 From jdowland at openjdk.org Thu Jan 4 14:21:22 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 4 Jan 2024 14:21:22 GMT Subject: [jdk11u-dev] RFR: 8315731: Open source several Swing Text related tests Message-ID: Test-only backport for Oracle parity. 5 newly-opensource Swing tests. Not clean: one required adjusting for JDK<14 (rework instanceof pattern matching). After that, they all pass for 11u. ------------- Commit messages: - Rework instanceof pattern matching from test (not in 11u) - 8315731: Open source several Swing Text related tests Changes: https://git.openjdk.org/jdk11u-dev/pull/2434/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2434&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315731 Stats: 469 lines in 5 files changed: 469 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2434.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2434/head:pull/2434 PR: https://git.openjdk.org/jdk11u-dev/pull/2434 From phh at openjdk.org Thu Jan 4 14:28:26 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 4 Jan 2024 14:28:26 GMT Subject: [jdk17u-dev] RFR: 8321599: Data loss in AVX3 Base64 decoding In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:23:52 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [13c11487](https://github.com/openjdk/jdk/commit/13c11487f7126a370d9ce8e62f661ea83eedefe6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Scott Gibbons on 4 Jan 2024 and was reviewed by Sandhya Viswanathan and Vladimir Kozlov. > > Thanks! > > There were 3 conflicts when merging: > 1. Trivial original copyright year difference (2021 here, 2023 in tip) > 2. Trivial whitespace difference for the dp_mem hunk (4 space indentation here, 2 spaces in tip) > 3. Git was confused about where to apply the addq/subq hunk, and chose the wrong place (indentation difference again?). Also trivial, once moved. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2100#pullrequestreview-1804274839 From goetz at openjdk.org Thu Jan 4 14:35:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 4 Jan 2024 14:35:34 GMT Subject: [jdk17u-dev] RFR: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries Message-ID: <5_9LRg5OA0VmlTIo9JsJiRDHv5GrIuYMeA3Iiwl21lo=.e8487b5a-2ba6-4c8d-8355-f0e7580cf1e1@github.com> This is a backout needed as the change is too intrusive for a backport. ------------- Commit messages: - Backport 18e97aa217087ff7af13a0147eaf091df3cb20eb Changes: https://git.openjdk.org/jdk17u-dev/pull/2102/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2102&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322883 Stats: 448 lines in 3 files changed: 0 ins; 448 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2102.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2102/head:pull/2102 PR: https://git.openjdk.org/jdk17u-dev/pull/2102 From goetz at openjdk.org Thu Jan 4 16:38:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 4 Jan 2024 16:38:24 GMT Subject: [jdk21u-dev] RFR: 8319569: Several java/util tests should be updated to accept VM flags Message-ID: I backport this to keep the 21u test suite up-to-date. This will simplify future test backports. ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/106 Commit messages: - Backport 2bb4b9398d65e3f37f34e45476c969ff0afb1540 - Remove -Xbatch in TestAbortVmOnException.java - Adapt some remaining tests - Backport of follow up 8318964, clean except for file missing in 21 - Resolves needed - Clean parts Changes: https://git.openjdk.org/jdk21u-dev/pull/129/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=129&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319569 Stats: 1763 lines in 577 files changed: 64 ins; 52 del; 1647 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/129.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/129/head:pull/129 PR: https://git.openjdk.org/jdk21u-dev/pull/129 From goetz at openjdk.org Thu Jan 4 18:14:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 4 Jan 2024 18:14:35 GMT Subject: [jdk21u-dev] RFR: 8210410: Refactor java.util.Currency:i18n shell tests to plain java tests Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/129 Commit messages: - Backport 2584bf87aef66744a8e586805735cded0d2f98f1 Changes: https://git.openjdk.org/jdk21u-dev/pull/130/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=130&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8210410 Stats: 144 lines in 1 file changed: 0 ins; 144 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/130.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/130/head:pull/130 PR: https://git.openjdk.org/jdk21u-dev/pull/130 From goetz at openjdk.org Thu Jan 4 18:20:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 4 Jan 2024 18:20:40 GMT Subject: [jdk21u-dev] RFR: 8319569: Several java/util tests should be updated to accept VM flags [v2] In-Reply-To: References: Message-ID: > I backport this to keep the 21u test suite up-to-date. This will simplify future test backports. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/129/files - new: https://git.openjdk.org/jdk21u-dev/pull/129/files/379d7a55..379d7a55 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=129&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=129&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/129.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/129/head:pull/129 PR: https://git.openjdk.org/jdk21u-dev/pull/129 From serb at openjdk.org Thu Jan 4 19:20:30 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 4 Jan 2024 19:20:30 GMT Subject: [jdk21u-dev] Integrated: 8315042: NPE in PKCS7.parseOldSignedData In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 02:02:24 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [8c0d026d](https://github.com/openjdk/jdk/commit/8c0d026d0f508e0c896fd28d725915c52d1b689d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Mark Powers on 4 Oct 2023 and was reviewed by Valerie Peng and Weijun Wang. > > Thanks! This pull request has now been integrated. Changeset: 58b1b0cc Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk21u-dev/commit/58b1b0cc359b5c14895c07560166779ec70975c9 Stats: 49 lines in 2 files changed: 11 ins; 20 del; 18 mod 8315042: NPE in PKCS7.parseOldSignedData Backport-of: 8c0d026d0f508e0c896fd28d725915c52d1b689d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/111 From shade at openjdk.org Thu Jan 4 20:19:43 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 4 Jan 2024 20:19:43 GMT Subject: [jdk21u-dev] RFR: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index Message-ID: Nearly clean backport to fix a Loom bug. The uncleanliness is due to `foreign_globals.cpp` context change in `ForeignGlobals::java_calling_convention`, which renamed the argument. I reapplied that hunk by hand. Additional testing: - [x] macos-aarch64-server-fastdebug, `jdk_loom hotspot_loom` - [ ] linux-aarch64-server-fastdebug, `tier{1,2,3,4}` - [ ] linux-x86_64-server-fastdebug, `tier{1,2,3,4}` ------------- Commit messages: - Backport e9e694f4ef7b080d7fe1ad5b2f2daa2fccd0456e Changes: https://git.openjdk.org/jdk21u-dev/pull/131/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=131&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320275 Stats: 81 lines in 17 files changed: 38 ins; 9 del; 34 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/131.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/131/head:pull/131 PR: https://git.openjdk.org/jdk21u-dev/pull/131 From serb at openjdk.org Fri Jan 5 02:04:31 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 5 Jan 2024 02:04:31 GMT Subject: [jdk17u-dev] Integrated: 8315042: NPE in PKCS7.parseOldSignedData In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 05:35:02 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [8c0d026d](https://github.com/openjdk/jdk/commit/8c0d026d0f508e0c896fd28d725915c52d1b689d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Mark Powers on 4 Oct 2023 and was reviewed by Valerie Peng and Weijun Wang. > > Thanks! This pull request has now been integrated. Changeset: da730528 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/da73052844a21ade173bad4f61bac269239049de Stats: 49 lines in 2 files changed: 11 ins; 20 del; 18 mod 8315042: NPE in PKCS7.parseOldSignedData Backport-of: 8c0d026d0f508e0c896fd28d725915c52d1b689d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2091 From serb at openjdk.org Fri Jan 5 02:53:27 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 5 Jan 2024 02:53:27 GMT Subject: [jdk11u-dev] Integrated: 8315042: NPE in PKCS7.parseOldSignedData In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 22:29:05 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [8c0d026d](https://github.com/openjdk/jdk/commit/8c0d026d0f508e0c896fd28d725915c52d1b689d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Mark Powers on 4 Oct 2023 and was reviewed by Valerie Peng and Weijun Wang. > > Thanks! This pull request has now been integrated. Changeset: 888837a1 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/888837a1411b72d92c86a75100614fa6c453307b Stats: 49 lines in 2 files changed: 11 ins; 20 del; 18 mod 8315042: NPE in PKCS7.parseOldSignedData Backport-of: 8c0d026d0f508e0c896fd28d725915c52d1b689d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2429 From gcao at openjdk.org Fri Jan 5 06:57:48 2024 From: gcao at openjdk.org (Gui Cao) Date: Fri, 5 Jan 2024 06:57:48 GMT Subject: [jdk21u-dev] RFR: 8322583: RISC-V: Enable fast class initialization checks Message-ID: <4NawOTgi7mWwo2Zf47do4xJryURVn0tlkgofUKDLYEk=.a243054a-dc79-4408-89bc-4971299303e9@github.com> Hi, The same issue also exists in the JDK21U: I can locally reproduce the performance issues reported by JDK-8219233. So I would like to backport this to JDK21U. Tier1-3 tested with release build using qemu systems. This is a risc-v specific change. Backport is clean, risk is low. ------------- Commit messages: - Backport 5235cc987d8c4455622acda947bed7321086a385 Changes: https://git.openjdk.org/jdk21u-dev/pull/132/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=132&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322583 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/132.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/132/head:pull/132 PR: https://git.openjdk.org/jdk21u-dev/pull/132 From goetz at openjdk.org Fri Jan 5 07:24:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 5 Jan 2024 07:24:30 GMT Subject: [jdk11u-dev] RFR: 8315731: Open source several Swing Text related tests In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 14:13:06 GMT, Jonathan Dowland wrote: > Test-only backport for Oracle parity. 5 newly-opensource Swing tests. Not clean: one required adjusting for JDK<14 (rework instanceof pattern matching). After that, they all pass for 11u. Please get a review before requesting approval. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2434#issuecomment-1878239163 From goetz at openjdk.org Fri Jan 5 07:34:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 5 Jan 2024 07:34:28 GMT Subject: [jdk17u-dev] RFR: 8322321: Add man page doc for -XX:+VerifySharedSpaces In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:44:59 GMT, Jonathan Dowland wrote: >> Nope, you now need maintainer approval. My review only covers the "unclean backport" part. > >> Nope, you now need maintainer approval. My review only covers the "unclean backport" part. > > Gotcha, thanks. I'm somewhat rusty. This is useful [grist for the mill](https://fosdem.org/2024/schedule/event/fosdem-2024-2460-a-beginner-s-guide-to-backports/). Hi @jmtd somewhat off-topic: you might want to have a look at "dependent pull requests", i.e. how to stack several PRs. There is a current example: PRs 105, 129, 130. Have a look at the branch they compare to (openjdkd:pr/129 etc). ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2098#issuecomment-1878246830 From goetz at openjdk.org Fri Jan 5 07:37:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 5 Jan 2024 07:37:29 GMT Subject: [jdk17u-dev] RFR: 8322321: Add man page doc for -XX:+VerifySharedSpaces In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:03:44 GMT, Jonathan Dowland wrote: > This is an unclean backport of a manpage fix, for Oracle parity. The conflict was trivial to resolve manually and was due to the troff source being updated post-17u for 8297164, which is unlikely to be backported itself. For this change, you should have a look at the broken GHA tests and tell in the PR what is going on. >From the content of the change it's pretty likely that that is unrelated stuff, but these should be checked by the backporter. I will only approve changes with green GHA tests, or, if red, if the backporter states the that the issues are unrelated to his change. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2098#issuecomment-1878249160 From andrewlu at openjdk.org Fri Jan 5 07:57:27 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 5 Jan 2024 07:57:27 GMT Subject: [jdk17u-dev] Integrated: 8320208: Update Public Suffix List to b5bf572 In-Reply-To: References: Message-ID: On Tue, 26 Dec 2023 06:41:26 GMT, Andrew Lu wrote: > Backport for JDK-8320208. > make backports to the origin file: > make/data/publicsuffixlist/VERSION > make/data/publicsuffixlist/public_suffix_list.dat This pull request has now been integrated. Changeset: ae071610 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/ae0716100a64004deef0ed49e7a6196cf78210e4 Stats: 3002 lines in 4 files changed: 1753 ins; 73 del; 1176 mod 8320208: Update Public Suffix List to b5bf572 Reviewed-by: mdoerr Backport-of: 2b4e99140a315d3da765b2edb031b38725a05f1c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2083 From andrewlu at openjdk.org Fri Jan 5 08:01:30 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 5 Jan 2024 08:01:30 GMT Subject: [jdk11u-dev] Integrated: 8202931: [macos] java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java fails In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 06:09:06 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: 78ca5ec7 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/78ca5ec70f1f350f7c8f0482e330e14ec92078da Stats: 10 lines in 2 files changed: 7 ins; 1 del; 2 mod 8202931: [macos] java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java fails Backport-of: f80faced6e6c6c1b10541a8b0c91625215c9ef43 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2433 From goetz at openjdk.org Fri Jan 5 08:01:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 5 Jan 2024 08:01:32 GMT Subject: [jdk11u-dev] RFR: 8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt In-Reply-To: <6eE0ccBtzGIucxC0IAAZOTxUQavdPo_uP8LyTTqFEZE=.66acf5d3-c261-4566-a0b4-a0a619b89eea@github.com> References: <6eE0ccBtzGIucxC0IAAZOTxUQavdPo_uP8LyTTqFEZE=.66acf5d3-c261-4566-a0b4-a0a619b89eea@github.com> Message-ID: On Thu, 4 Jan 2024 05:40:51 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. > Not in ProblemList.txt?so make it clean. Hi @luchenlin, It would be better to base your backport on the jdk17u backport. That also does not have the change to the ProblemList. If you use the hash from the push to 17u in the PR title, it should be recognized as clean automatically. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2431#issuecomment-1878269647 From andrewlu at openjdk.org Fri Jan 5 08:07:29 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 5 Jan 2024 08:07:29 GMT Subject: [jdk11u-dev] Integrated: 8311585: Add JRadioButtonMenuItem to bug8031573.java In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 03:17:46 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: e3b6c508 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/e3b6c5085ca37e581ebd0ddcd4c4de41eb348cb1 Stats: 24 lines in 1 file changed: 12 ins; 2 del; 10 mod 8311585: Add JRadioButtonMenuItem to bug8031573.java Backport-of: 4f90abaf17716493bad740dcef76d49f16d69379 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2430 From goetz at openjdk.org Fri Jan 5 08:09:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 5 Jan 2024 08:09:08 GMT Subject: [jdk17u-dev] RFR: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries [v2] In-Reply-To: <5_9LRg5OA0VmlTIo9JsJiRDHv5GrIuYMeA3Iiwl21lo=.e8487b5a-2ba6-4c8d-8355-f0e7580cf1e1@github.com> References: <5_9LRg5OA0VmlTIo9JsJiRDHv5GrIuYMeA3Iiwl21lo=.e8487b5a-2ba6-4c8d-8355-f0e7580cf1e1@github.com> Message-ID: > This is a backout needed as the change is too intrusive for a backport. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into goetz_backport_8322883 - Backport 18e97aa217087ff7af13a0147eaf091df3cb20eb ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2102/files - new: https://git.openjdk.org/jdk17u-dev/pull/2102/files/2df20328..a8835e76 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2102&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2102&range=00-01 Stats: 3051 lines in 6 files changed: 1764 ins; 93 del; 1194 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2102.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2102/head:pull/2102 PR: https://git.openjdk.org/jdk17u-dev/pull/2102 From goetz at openjdk.org Fri Jan 5 08:09:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 5 Jan 2024 08:09:09 GMT Subject: [jdk17u-dev] RFR: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries In-Reply-To: <5_9LRg5OA0VmlTIo9JsJiRDHv5GrIuYMeA3Iiwl21lo=.e8487b5a-2ba6-4c8d-8355-f0e7580cf1e1@github.com> References: <5_9LRg5OA0VmlTIo9JsJiRDHv5GrIuYMeA3Iiwl21lo=.e8487b5a-2ba6-4c8d-8355-f0e7580cf1e1@github.com> Message-ID: On Thu, 4 Jan 2024 14:30:30 GMT, Goetz Lindenmaier wrote: > This is a backout needed as the change is too intrusive for a backport. GHA failure: test job never ran. Restarting tests by merging head. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2102#issuecomment-1878276041 From mbaesken at openjdk.org Fri Jan 5 09:29:39 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 5 Jan 2024 09:29:39 GMT Subject: [jdk22u] RFR: 8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886 Message-ID: 8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886 ------------- Commit messages: - Backport 1230853343c38787c90820d19d0626f0c37540dc Changes: https://git.openjdk.org/jdk22u/pull/8/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=8&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322163 Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/8.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/8/head:pull/8 PR: https://git.openjdk.org/jdk22u/pull/8 From shade at openjdk.org Fri Jan 5 10:00:35 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 5 Jan 2024 10:00:35 GMT Subject: [jdk17u-dev] Integrated: 8293547: Add relaxed add_and_fetch for macos aarch64 atomics In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 18:29:27 GMT, Aleksey Shipilev wrote: > Clean backport to improve Atomics performance for the code that opts-in to relaxed CASes. > > Additional testing: > - [x] macos-server-aarch64-fastdebug, `gtest:Atomic` passes > - [x] macos-server-aarch64-fastdebug, `tier1` This pull request has now been integrated. Changeset: 6340b666 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/6340b666706183845eea2d036bab59d772088b95 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod 8293547: Add relaxed add_and_fetch for macos aarch64 atomics Reviewed-by: aph Backport-of: 7a1cb64bc1b85b3ef1b0ba2d84dbc5b8b05c60ff ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2097 From shade at openjdk.org Fri Jan 5 10:01:35 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 5 Jan 2024 10:01:35 GMT Subject: [jdk17u-dev] Integrated: 8320921: GHA: Parallelize hotspot_compiler test jobs In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:22:35 GMT, Aleksey Shipilev wrote: > Clean backport to make GHA testing faster. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 0e2ca18a Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/0e2ca18ac22b94ce566bb43efdbaaf1966710f6a Stats: 13 lines in 1 file changed: 10 ins; 0 del; 3 mod 8320921: GHA: Parallelize hotspot_compiler test jobs Backport-of: 694136909c058370a5833322ebaf2e71a0a15164 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2099 From shade at openjdk.org Fri Jan 5 10:01:36 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 5 Jan 2024 10:01:36 GMT Subject: [jdk21u-dev] Integrated: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 09:48:55 GMT, Aleksey Shipilev wrote: > Clean backport to improve heap dump reliability w.r.t. filler objects. Only happens after JDK 19. > > Additional testing: > - [x] Affected test still passes This pull request has now been integrated. Changeset: 23a0b905 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/23a0b9059782a9659feb00d97963b0f8e1184110 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8319548: Unexpected internal name for Filler array klass causes error in VisualVM Backport-of: 05745e3f1d56f71d7647e81fa5933c9f4ed18430 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/123 From shade at openjdk.org Fri Jan 5 10:01:39 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 5 Jan 2024 10:01:39 GMT Subject: [jdk21u-dev] Integrated: 8321974: Crash in ciKlass::is_subtype_of because TypeAryPtr::_klass is not initialized In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 09:20:01 GMT, Aleksey Shipilev wrote: > Clean backport to fix C2 regression in JDK 21. > > Additional testing: > - [x] New regression test _passes_ even without a fix > - [x] linux-x86_64-server-fastdebug, `tier{1,2,3}` This pull request has now been integrated. Changeset: 9f603605 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/9f6036053e802c6e16289a02051f3d624be810c5 Stats: 89 lines in 3 files changed: 54 ins; 22 del; 13 mod 8321974: Crash in ciKlass::is_subtype_of because TypeAryPtr::_klass is not initialized Backport-of: c8ad7b7f84ead3f850f034e1db6335bbbac41589 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/119 From shade at openjdk.org Fri Jan 5 10:02:32 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 5 Jan 2024 10:02:32 GMT Subject: [jdk21u-dev] Integrated: 8320921: GHA: Parallelize hotspot_compiler test jobs In-Reply-To: <3Tt6YF-fAZVXmDPdcgk0OkhpKazZH4j3jRrNcL8hnJc=.7ae82c77-b824-4e5e-9ac2-cd918788e3a5@github.com> References: <3Tt6YF-fAZVXmDPdcgk0OkhpKazZH4j3jRrNcL8hnJc=.7ae82c77-b824-4e5e-9ac2-cd918788e3a5@github.com> Message-ID: On Thu, 4 Jan 2024 09:28:16 GMT, Aleksey Shipilev wrote: > Clean backport to make GHA testing faster. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 49dd575d Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/49dd575df93aee07bb512fede446f3e2d240b2bc Stats: 13 lines in 1 file changed: 10 ins; 0 del; 3 mod 8320921: GHA: Parallelize hotspot_compiler test jobs Backport-of: 694136909c058370a5833322ebaf2e71a0a15164 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/121 From shade at openjdk.org Fri Jan 5 10:02:33 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 5 Jan 2024 10:02:33 GMT Subject: [jdk21u-dev] Integrated: 8322159: ThisEscapeAnalyzer crashes for erroneous code In-Reply-To: References: Message-ID: <1a_wUOLpm_tSGJxLei09BKQh6okoPgLP3Jec55hQc0I=.f965fbcb-d631-444d-a59c-6b27958f036d@github.com> On Wed, 3 Jan 2024 09:54:31 GMT, Aleksey Shipilev wrote: > Clean backport to fix a javac corner case. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] macos-aarch64-server-fastdebug, `langtools_all` This pull request has now been integrated. Changeset: 5f2cf881 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/5f2cf881b1b941d5771328f6822693c5b9c4da0d Stats: 44 lines in 2 files changed: 41 ins; 0 del; 3 mod 8322159: ThisEscapeAnalyzer crashes for erroneous code Backport-of: 7455b1b527568aff5b1c16a29fd80b05260c0fad ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/117 From shade at openjdk.org Fri Jan 5 10:02:34 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 5 Jan 2024 10:02:34 GMT Subject: [jdk21u-dev] Integrated: 8322321: Add man page doc for -XX:+VerifySharedSpaces In-Reply-To: References: Message-ID: <7NKPwUmZKEeoy5A2zmZDFlND7Ce4nYoNnzUyxyO2To0=.f7267a64-51a1-427c-9332-d5c5d2f075bd@github.com> On Thu, 4 Jan 2024 09:24:39 GMT, Aleksey Shipilev wrote: > Clean backport for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 579c56f0 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/579c56f0a5bea433fc2ec1d89777bca83cda5bf3 Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod 8322321: Add man page doc for -XX:+VerifySharedSpaces Backport-of: f7dc257a206d3104d6d24c2079ef1fe349368c49 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/120 From shade at openjdk.org Fri Jan 5 10:30:35 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 5 Jan 2024 10:30:35 GMT Subject: [jdk21u-dev] RFR: 8319883: Zero: Use atomic built-ins for 64-bit accesses Message-ID: Clean backport to fix 32-bit Zero concurrency bug. Additional testing: - [x] Linux x86_32 Zero fastdebug, jcstress run - [x] Linux Zero build matrix ------------- Commit messages: - Backport 25f9af99be1c906fc85b8192df8fa50cced3474f Changes: https://git.openjdk.org/jdk21u-dev/pull/127/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=127&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319883 Stats: 63 lines in 2 files changed: 0 ins; 48 del; 15 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/127.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/127/head:pull/127 PR: https://git.openjdk.org/jdk21u-dev/pull/127 From mdoerr at openjdk.org Fri Jan 5 12:03:29 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 5 Jan 2024 12:03:29 GMT Subject: [jdk11u-dev] RFR: 8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 05:54:44 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. > Also backport for JDK-8237222, both clean. Looks correct. You could make reviewing easier by using separate commits when putting more than one backport into one PR in the future. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2432#pullrequestreview-1805822519 From mbaesken at openjdk.org Fri Jan 5 12:50:33 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 5 Jan 2024 12:50:33 GMT Subject: [jdk11u-dev] RFR: 8313643: Update HarfBuzz to 8.2.2 In-Reply-To: <8dPJK420ndqBRy34vAIWdH6MZL4sUKxsDSPirEeuRik=.0e1c5178-6dae-4225-97d1-24e6e4b02cfb@github.com> References: <8dPJK420ndqBRy34vAIWdH6MZL4sUKxsDSPirEeuRik=.0e1c5178-6dae-4225-97d1-24e6e4b02cfb@github.com> Message-ID: On Fri, 15 Dec 2023 08:32:10 GMT, Amos Shi wrote: > Backport of [JDK-8313643](https://bugs.openjdk.org/browse/JDK-8313643) > > Unclean Backport: > - `src/java.desktop/share/native/libharfbuzz/hb-subset.cc` > - Manually merged the code of bellow; > - This file change could be considered as `Clean` > > > @@ -43,21 +43,19 @@ > #include "OT/Color/sbix/sbix.hh" > #include "hb-ot-os2-table.hh" > #include "hb-ot-post-table.hh" > - > -#if !defined(AIX) || defined(AIX_XLC_GE_17) > #include "hb-ot-post-table-v2subset.hh" > -#endif > - > #include "hb-ot-cff1-table.hh" > #include "hb-ot-cff2-table.hh" > #include "hb-ot-vorg-table.hh" > #include "hb-ot-name-table.hh" > #include "hb-ot-layout-gsub-table.hh" > #include "hb-ot-layout-gpos-table.hh" > +#include "hb-ot-var-avar-table.hh" > #include "hb-ot-var-cvar-table.hh" > #include "hb-ot-var-fvar-table.hh" > #include "hb-ot-var-gvar-table.hh" > #include "hb-ot-var-hvar-table.hh" > +#include "hb-ot-var-mvar-table.hh" > #include "hb-ot-math-table.hh" > #include "hb-ot-stat-table.hh" > #include "hb-repacker.hh" > > > - `make/modules/java.desktop/lib/Awt2dLibraries.gmk` > - Manually merged the code of bellow to the file `make/lib/Awt2dLibraries.gmk`. > - This file change could be considered as `Clean` > > > @@ -495,6 +495,11 @@ > # hb-ft.cc is not presently needed, and requires freetype 2.4.2 or later. > LIBFONTMANAGER_EXCLUDE_FILES += libharfbuzz/hb-ft.cc > > + # list of disabled warnings and the compilers for which it was specifically added. > + # array-bounds -> GCC 12 on Alpine Linux > + # parentheses -> GCC 6 > + # range-loop-analysis -> clang on Xcode12 > + > HARFBUZZ_DISABLED_WARNINGS_gcc := missing-field-initializers strict-aliasing \ > unused-result array-bounds parentheses > # noexcept-type required for GCC 7 builds. Not required for GCC 8+. > > > Tests > - PR: All checks have passed > - SAP nightlies passed on `2023-12-21,22,23,24` Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2398#pullrequestreview-1805897047 From jdowland at openjdk.org Fri Jan 5 15:35:33 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Fri, 5 Jan 2024 15:35:33 GMT Subject: [jdk21u-dev] Integrated: 8315731: Open source several Swing Text related tests In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 09:53:29 GMT, Jonathan Dowland wrote: > For Oracle parity. Cherry picks clean. Test only. Introduces 5 newly-open-sourced Swing tests which all pass. This pull request has now been integrated. Changeset: b3344f24 Author: Jonathan Dowland URL: https://git.openjdk.org/jdk21u-dev/commit/b3344f2422a9a606dbb779d639c515c857412d3e Stats: 468 lines in 5 files changed: 468 ins; 0 del; 0 mod 8315731: Open source several Swing Text related tests Backport-of: d475f61fd52b7d379260811b32d3815786858411 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/124 From jdowland at openjdk.org Fri Jan 5 15:35:35 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Fri, 5 Jan 2024 15:35:35 GMT Subject: [jdk17u-dev] Integrated: 8315731: Open source several Swing Text related tests In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:31:26 GMT, Jonathan Dowland wrote: > Clean backport of 5 newly-opensourced Swing tests. All the tests pass in 17u-dev. For Oracle parity. This pull request has now been integrated. Changeset: b89db38a Author: Jonathan Dowland URL: https://git.openjdk.org/jdk17u-dev/commit/b89db38aa95c6dec418d1d8c5ef3ee157068bbe4 Stats: 468 lines in 5 files changed: 468 ins; 0 del; 0 mod 8315731: Open source several Swing Text related tests Backport-of: d475f61fd52b7d379260811b32d3815786858411 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2101 From shade at openjdk.org Fri Jan 5 16:04:41 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 5 Jan 2024 16:04:41 GMT Subject: [jdk17u-dev] RFR: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used Message-ID: This reverts the patch that caused recently identified regression. Luckily, we have it only in 17.0.11, which gives us a normal opportunity to revert it. The complication is that mainline patch is not applying cleanly, because JDK 17u backport is contextually different. So I `git revert`-ed the jdk17u-dev commit instead: https://github.com/openjdk/jdk17u-dev/commit/9a104e08f79fecabf5de2e0ece914260319d2f28. But that makes the backport formally unclean. Additional testing: - [ ] GHA ------------- Commit messages: - Backport ed9f3243f04718a50bbdc589437872f7215c0e08 Changes: https://git.openjdk.org/jdk17u-dev/pull/2103/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2103&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322985 Stats: 247 lines in 4 files changed: 1 ins; 244 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2103.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2103/head:pull/2103 PR: https://git.openjdk.org/jdk17u-dev/pull/2103 From duke at openjdk.org Fri Jan 5 16:56:49 2024 From: duke at openjdk.org (Elif Aslan) Date: Fri, 5 Jan 2024 16:56:49 GMT Subject: [jdk21u] RFR: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests Message-ID: Clean backport to enable parallelism in vmTestbase/nsk/stress/jni tests Tested with GHA ------------- Commit messages: - Backport 43f31d73852d63ccdcc2dcd8d6c7355435a50fb3 Changes: https://git.openjdk.org/jdk21u/pull/429/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=429&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318607 Stats: 24 lines in 1 file changed: 0 ins; 24 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/429.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/429/head:pull/429 PR: https://git.openjdk.org/jdk21u/pull/429 From duke at openjdk.org Fri Jan 5 17:01:16 2024 From: duke at openjdk.org (Elif Aslan) Date: Fri, 5 Jan 2024 17:01:16 GMT Subject: [jdk21u] RFR: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests Message-ID: Clean backport to enable parallelism in vmTestbase/nsk/stress/threads tests. Tested with GHA. ------------- Commit messages: - Backport cee44a625594fd805a05c4a69033eb677a5a6f17 Changes: https://git.openjdk.org/jdk21u/pull/430/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=430&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318608 Stats: 24 lines in 1 file changed: 0 ins; 24 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/430.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/430/head:pull/430 PR: https://git.openjdk.org/jdk21u/pull/430 From duke at openjdk.org Fri Jan 5 17:02:39 2024 From: duke at openjdk.org (Elif Aslan) Date: Fri, 5 Jan 2024 17:02:39 GMT Subject: [jdk21u] Withdrawn: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests In-Reply-To: References: Message-ID: <-hxyvEf1AUOOiAPhALGDHfPevBYys91dRKK7YEKkFNE=.35d5e076-1b5a-42d7-b9cc-a664c6c37a61@github.com> On Fri, 5 Jan 2024 16:50:44 GMT, Elif Aslan wrote: > Clean backport to enable parallelism in vmTestbase/nsk/stress/jni tests > > Tested with GHA This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u/pull/429 From duke at openjdk.org Fri Jan 5 17:04:30 2024 From: duke at openjdk.org (Elif Aslan) Date: Fri, 5 Jan 2024 17:04:30 GMT Subject: [jdk21u] Withdrawn: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 16:52:10 GMT, Elif Aslan wrote: > Clean backport to enable parallelism in vmTestbase/nsk/stress/threads tests. > > Tested with GHA. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u/pull/430 From kvn at openjdk.org Fri Jan 5 17:33:30 2024 From: kvn at openjdk.org (Vladimir Kozlov) Date: Fri, 5 Jan 2024 17:33:30 GMT Subject: [jdk17u-dev] RFR: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 15:54:28 GMT, Aleksey Shipilev wrote: > This reverts the patch that caused recently identified regression. Luckily, we have it only in 17.0.11, which gives us a normal opportunity to revert it. > > The complication is that mainline patch is not applying cleanly, because JDK 17u backport is contextually different. So I `git revert`-ed the jdk17u-dev commit instead: https://github.com/openjdk/jdk17u-dev/commit/9a104e08f79fecabf5de2e0ece914260319d2f28. But that makes the backport formally unclean. > > Additional testing: > - [ ] GHA Good. ------------- Marked as reviewed by kvn (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2103#pullrequestreview-1806462720 From dlutker at openjdk.org Fri Jan 5 17:49:32 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Fri, 5 Jan 2024 17:49:32 GMT Subject: [jdk21u-dev] RFR: 8322725: (tz) Update Timezone Data to 2023d Message-ID: Clean backport of tzdata2023d. `make test TEST="test/jdk/java/util/TimeZone test/jdk/java/time/test test/jdk/sun/util/resources test/jdk/sun/text/resources test/jdk/sun/util/calendar"` is passing locally. ------------- Commit messages: - Backport 2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc Changes: https://git.openjdk.org/jdk21u-dev/pull/133/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=133&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322725 Stats: 140 lines in 14 files changed: 94 ins; 15 del; 31 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/133.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/133/head:pull/133 PR: https://git.openjdk.org/jdk21u-dev/pull/133 From dlutker at openjdk.org Fri Jan 5 17:55:44 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Fri, 5 Jan 2024 17:55:44 GMT Subject: [jdk17u-dev] RFR: 8322725: (tz) Update Timezone Data to 2023d Message-ID: Clean backport of tzdata2023d ------------- Commit messages: - Backport 2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc Changes: https://git.openjdk.org/jdk17u-dev/pull/2104/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2104&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322725 Stats: 140 lines in 14 files changed: 94 ins; 15 del; 31 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2104.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2104/head:pull/2104 PR: https://git.openjdk.org/jdk17u-dev/pull/2104 From thartmann at openjdk.org Fri Jan 5 18:00:35 2024 From: thartmann at openjdk.org (Tobias Hartmann) Date: Fri, 5 Jan 2024 18:00:35 GMT Subject: [jdk21u] Integrated: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used Message-ID: Hi all, This pull request contains a backport of commit [ed9f3243](https://github.com/openjdk/jdk/commit/ed9f3243f04718a50bbdc589437872f7215c0e08) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Tobias Hartmann on 5 Jan 2024 and was reviewed by Christian Hagedorn and Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport ed9f3243f04718a50bbdc589437872f7215c0e08 Changes: https://git.openjdk.org/jdk21u/pull/431/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=431&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322985 Stats: 247 lines in 4 files changed: 0 ins; 245 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/431.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/431/head:pull/431 PR: https://git.openjdk.org/jdk21u/pull/431 From thartmann at openjdk.org Fri Jan 5 18:00:36 2024 From: thartmann at openjdk.org (Tobias Hartmann) Date: Fri, 5 Jan 2024 18:00:36 GMT Subject: [jdk21u] Integrated: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 17:52:37 GMT, Tobias Hartmann wrote: > Hi all, > > This pull request contains a backport of commit [ed9f3243](https://github.com/openjdk/jdk/commit/ed9f3243f04718a50bbdc589437872f7215c0e08) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Tobias Hartmann on 5 Jan 2024 and was reviewed by Christian Hagedorn and Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: 1c7197fe Author: Tobias Hartmann URL: https://git.openjdk.org/jdk21u/commit/1c7197fe3b4663f404eb31744640d239ab734b4c Stats: 247 lines in 4 files changed: 0 ins; 245 del; 2 mod 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used Backport-of: ed9f3243f04718a50bbdc589437872f7215c0e08 ------------- PR: https://git.openjdk.org/jdk21u/pull/431 From dlutker at openjdk.org Fri Jan 5 18:02:42 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Fri, 5 Jan 2024 18:02:42 GMT Subject: [jdk11u-dev] RFR: 8322725: (tz) Update Timezone Data to 2023d Message-ID: Clean backport of tadata2023d. ------------- Commit messages: - Backport 2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc Changes: https://git.openjdk.org/jdk11u-dev/pull/2435/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2435&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322725 Stats: 140 lines in 14 files changed: 94 ins; 15 del; 31 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2435.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2435/head:pull/2435 PR: https://git.openjdk.org/jdk11u-dev/pull/2435 From shade at openjdk.org Fri Jan 5 18:06:26 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 5 Jan 2024 18:06:26 GMT Subject: [jdk17u-dev] RFR: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries [v2] In-Reply-To: References: <5_9LRg5OA0VmlTIo9JsJiRDHv5GrIuYMeA3Iiwl21lo=.e8487b5a-2ba6-4c8d-8355-f0e7580cf1e1@github.com> Message-ID: On Fri, 5 Jan 2024 08:09:08 GMT, Goetz Lindenmaier wrote: >> This is a backout needed as the change is too intrusive for a backport. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into goetz_backport_8322883 > - Backport 18e97aa217087ff7af13a0147eaf091df3cb20eb So this backs out these two? - https://github.com/openjdk/jdk17u-dev/commit/3a2bf8e570d5e329f22b4eaf5e90fef8cd14f8b2 - https://github.com/openjdk/jdk17u-dev/commit/c44bd2bd09e43b719b87eb1f8e153560c5901a6b For extra safety, I would have tried to just `git revert` both from jdk17u-dev. This would prove mechanically that the revert is clean. Not sure if that is how you did it. ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2102#pullrequestreview-1806542572 From wkemper at openjdk.org Fri Jan 5 19:18:31 2024 From: wkemper at openjdk.org (William Kemper) Date: Fri, 5 Jan 2024 19:18:31 GMT Subject: [jdk22u] RFR: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread Message-ID: Clean backport, trivial fix. ------------- Commit messages: - Backport f0e2e4311b8cab160dc9e35f43e9ae5a145c5e23 Changes: https://git.openjdk.org/jdk22u/pull/9/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=9&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323021 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/9.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/9/head:pull/9 PR: https://git.openjdk.org/jdk22u/pull/9 From wkemper at openjdk.org Fri Jan 5 19:24:34 2024 From: wkemper at openjdk.org (William Kemper) Date: Fri, 5 Jan 2024 19:24:34 GMT Subject: [jdk21u-dev] RFR: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread Message-ID: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread ------------- Commit messages: - Backport f0e2e4311b8cab160dc9e35f43e9ae5a145c5e23 Changes: https://git.openjdk.org/jdk21u-dev/pull/134/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=134&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323021 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/134.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/134/head:pull/134 PR: https://git.openjdk.org/jdk21u-dev/pull/134 From duke at openjdk.org Fri Jan 5 19:27:39 2024 From: duke at openjdk.org (Elif Aslan) Date: Fri, 5 Jan 2024 19:27:39 GMT Subject: [jdk21u-dev] RFR: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests Message-ID: Clean backport to enable parallelism in vmTestbase/nsk/stress/jni tests Tested with GHA ------------- Commit messages: - Backport 43f31d73852d63ccdcc2dcd8d6c7355435a50fb3 Changes: https://git.openjdk.org/jdk21u-dev/pull/135/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=135&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318607 Stats: 24 lines in 1 file changed: 0 ins; 24 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/135.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/135/head:pull/135 PR: https://git.openjdk.org/jdk21u-dev/pull/135 From duke at openjdk.org Fri Jan 5 19:28:33 2024 From: duke at openjdk.org (Elif Aslan) Date: Fri, 5 Jan 2024 19:28:33 GMT Subject: [jdk21u-dev] RFR: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests Message-ID: Clean backport to enable parallelism in vmTestbase/nsk/stress/threads tests. Tested with GHA. ------------- Commit messages: - Backport cee44a625594fd805a05c4a69033eb677a5a6f17 Changes: https://git.openjdk.org/jdk21u-dev/pull/136/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=136&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318608 Stats: 24 lines in 1 file changed: 0 ins; 24 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/136.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/136/head:pull/136 PR: https://git.openjdk.org/jdk21u-dev/pull/136 From wkemper at openjdk.org Fri Jan 5 19:32:33 2024 From: wkemper at openjdk.org (William Kemper) Date: Fri, 5 Jan 2024 19:32:33 GMT Subject: [jdk17u-dev] RFR: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread Message-ID: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread ------------- Commit messages: - 8323021: Shenandoah: Encountered reference count always attributed to first worker thread Changes: https://git.openjdk.org/jdk17u-dev/pull/2105/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2105&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323021 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2105.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2105/head:pull/2105 PR: https://git.openjdk.org/jdk17u-dev/pull/2105 From mbalao at openjdk.org Sat Jan 6 00:20:29 2024 From: mbalao at openjdk.org (Martin Balao) Date: Sat, 6 Jan 2024 00:20:29 GMT Subject: [jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v5] In-Reply-To: References: Message-ID: On Mon, 4 Dec 2023 14:31:45 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.11-oracle. >> >> The backport was almost clean, except for two trivial resolves due to differences in whitespace in the context. >> >> The change comes with a CSR, which is already approved for 17. >> But the CSR requires changes wrt. to the original change. >> In 17, no EDDSA support is added. >> >> The PR comes with two commits: >> 1. the almost clean backport. I already skipped two comments added in head but not needed in 17 (SignatureMethod, DigestMethod). >> 2. removing the eddsa support. >> >> Tests pass, SAP nightly testing passed. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Do the whitespace fix properly. Hi Goetz, Thanks for proposing this backport. One minor comment: * test/jdk/javax/xml/crypto/dsig/GenerationTests.java * The import of X509Certificate and the definition of x5ks are dead code. Otherwise, looks good to me. I'll give my approval anyways, as this is a minor comment. On a final note, I agree with your changes of removing EdDSA code and aligning to the approved CSR. However, I have to say that doing this for 17u does not only prevent users from the enhancement but also increases the maintenance cost as there will be more chances of updates not applying cleanly for the years to come. I would have treated 17u differently than previous releases. Martin.- ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2006#pullrequestreview-1807104143 From duke at openjdk.org Sat Jan 6 01:37:41 2024 From: duke at openjdk.org (Elif Aslan) Date: Sat, 6 Jan 2024 01:37:41 GMT Subject: [jdk17u-dev] RFR: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests Message-ID: Clean backport to enable parallelism in vmTestbase/nsk/stress/jni tests Tested with GHA ------------- Commit messages: - Backport 43f31d73852d63ccdcc2dcd8d6c7355435a50fb3 Changes: https://git.openjdk.org/jdk17u-dev/pull/2106/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2106&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318607 Stats: 24 lines in 1 file changed: 0 ins; 24 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2106.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2106/head:pull/2106 PR: https://git.openjdk.org/jdk17u-dev/pull/2106 From duke at openjdk.org Sat Jan 6 01:37:52 2024 From: duke at openjdk.org (Elif Aslan) Date: Sat, 6 Jan 2024 01:37:52 GMT Subject: [jdk17u-dev] RFR: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests Message-ID: Clean backport to enable parallelism in vmTestbase/nsk/stress/threads tests. Tested with GHA. ------------- Commit messages: - Backport 43f31d73852d63ccdcc2dcd8d6c7355435a50fb3 Changes: https://git.openjdk.org/jdk17u-dev/pull/2107/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2107&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318607 Stats: 24 lines in 1 file changed: 0 ins; 24 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2107.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2107/head:pull/2107 PR: https://git.openjdk.org/jdk17u-dev/pull/2107 From duke at openjdk.org Sat Jan 6 01:39:50 2024 From: duke at openjdk.org (Elif Aslan) Date: Sat, 6 Jan 2024 01:39:50 GMT Subject: [jdk11u-dev] RFR: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests Message-ID: <7T6YoUvmz3PXXIN7EUzgVaG1h1wYfztRl9_cXVuc_oM=.c7356d43-9298-42ee-931e-fa5c7c5cead2@github.com> Clean backport to enable parallelism in vmTestbase/nsk/stress/jni tests Tested with GHA ------------- Commit messages: - Backport 43f31d73852d63ccdcc2dcd8d6c7355435a50fb3 Changes: https://git.openjdk.org/jdk11u-dev/pull/2436/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2436&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318607 Stats: 24 lines in 1 file changed: 0 ins; 24 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2436.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2436/head:pull/2436 PR: https://git.openjdk.org/jdk11u-dev/pull/2436 From duke at openjdk.org Sat Jan 6 01:42:54 2024 From: duke at openjdk.org (Elif Aslan) Date: Sat, 6 Jan 2024 01:42:54 GMT Subject: [jdk11u-dev] RFR: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests Message-ID: Clean backport to enable parallelism in vmTestbase/nsk/stress/threads tests. Tested with GHA. ------------- Commit messages: - Backport cee44a625594fd805a05c4a69033eb677a5a6f17 Changes: https://git.openjdk.org/jdk11u-dev/pull/2437/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2437&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318608 Stats: 24 lines in 1 file changed: 0 ins; 24 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2437.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2437/head:pull/2437 PR: https://git.openjdk.org/jdk11u-dev/pull/2437 From duke at openjdk.org Sat Jan 6 01:44:29 2024 From: duke at openjdk.org (Elif Aslan) Date: Sat, 6 Jan 2024 01:44:29 GMT Subject: [jdk17u-dev] Withdrawn: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests In-Reply-To: References: Message-ID: On Sat, 6 Jan 2024 01:32:28 GMT, Elif Aslan wrote: > Clean backport to enable parallelism in vmTestbase/nsk/stress/jni tests > > Tested with GHA This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2106 From duke at openjdk.org Sat Jan 6 01:45:27 2024 From: duke at openjdk.org (Elif Aslan) Date: Sat, 6 Jan 2024 01:45:27 GMT Subject: [jdk17u-dev] Withdrawn: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests In-Reply-To: References: Message-ID: On Sat, 6 Jan 2024 01:33:02 GMT, Elif Aslan wrote: > Clean backport to enable parallelism in vmTestbase/nsk/stress/threads tests. > > Tested with GHA. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2107 From duke at openjdk.org Sat Jan 6 01:52:49 2024 From: duke at openjdk.org (Elif Aslan) Date: Sat, 6 Jan 2024 01:52:49 GMT Subject: [jdk17u-dev] RFR: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests Message-ID: Clean backport of Enable parallelism in vmTestbase/nsk/stress/threads tests GHA Tested ------------- Commit messages: - Backport cee44a625594fd805a05c4a69033eb677a5a6f17 Changes: https://git.openjdk.org/jdk17u-dev/pull/2108/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2108&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318608 Stats: 24 lines in 1 file changed: 0 ins; 24 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2108.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2108/head:pull/2108 PR: https://git.openjdk.org/jdk17u-dev/pull/2108 From goetz at openjdk.org Sat Jan 6 10:50:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 6 Jan 2024 10:50:22 GMT Subject: [jdk21u-dev] RFR: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 19:22:09 GMT, Elif Aslan wrote: > Clean backport to enable parallelism in vmTestbase/nsk/stress/threads tests. > > Tested with GHA. Hi, your approval request is not complete. Please list reason, risk, testing and whether the backport was clean. See also https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix "Example Fix Request comment". ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/136#issuecomment-1879635021 From goetz at openjdk.org Sat Jan 6 10:53:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 6 Jan 2024 10:53:37 GMT Subject: [jdk21u] RFR: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 16:50:44 GMT, Elif Aslan wrote: > Clean backport to enable parallelism in vmTestbase/nsk/stress/jni tests > > Tested with GHA Hi, your approval request is not complete. Please list reason, risk, testing and whether the backport was clean. See also https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix "Example Fix Request comment". Removing tags in meantime. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/429#issuecomment-1879635636 From goetz at openjdk.org Sat Jan 6 10:56:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 6 Jan 2024 10:56:24 GMT Subject: [jdk17u-dev] RFR: 8322321: Add man page doc for -XX:+VerifySharedSpaces In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:03:44 GMT, Jonathan Dowland wrote: > This is an unclean backport of a manpage fix, for Oracle parity. The conflict was trivial to resolve manually and was due to the troff source being updated post-17u for 8297164, which is unlikely to be backported itself. I'll remove the label for now. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2098#issuecomment-1879636229 From ashi at openjdk.org Sat Jan 6 11:07:32 2024 From: ashi at openjdk.org (Amos Shi) Date: Sat, 6 Jan 2024 11:07:32 GMT Subject: [jdk11u-dev] Integrated: 8208243: vmTestbase/gc/lock/jni/jnilock002/TestDescription.java fails in jdk/hs nightly In-Reply-To: References: Message-ID: On Wed, 20 Dec 2023 03:00:37 GMT, Amos Shi wrote: > Backport of [JDK-8208243](https://bugs.openjdk.org/browse/JDK-8208243) > > This is an `Unclean` back port, because > - `test/hotspot/jtreg/ProblemList.txt` the line number location is different, well the code change is the same > - The `TRACE_JNI_CALL` parameter does not exist in Java 11, so in this pr we removed this parameter in all the `.cpp` files > > Tests > - PR: All checks have passed > - SAP nightlies passed on `2023 Dec 25,27` and `2024-01-02,04` This pull request has now been integrated. Changeset: ed37e2d3 Author: Amos Shi Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/ed37e2d384d43003bf428186c57d861dec8acd86 Stats: 307 lines in 10 files changed: 18 ins; 0 del; 289 mod 8208243: vmTestbase/gc/lock/jni/jnilock002/TestDescription.java fails in jdk/hs nightly Reviewed-by: mbaesken Backport-of: 5899ef11fb2c44c3e497915a3f184b1f7e22213d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2412 From goetz at openjdk.org Sat Jan 6 11:08:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 6 Jan 2024 11:08:26 GMT Subject: [jdk17u-dev] RFR: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries [v2] In-Reply-To: References: <5_9LRg5OA0VmlTIo9JsJiRDHv5GrIuYMeA3Iiwl21lo=.e8487b5a-2ba6-4c8d-8355-f0e7580cf1e1@github.com> Message-ID: On Fri, 5 Jan 2024 08:09:08 GMT, Goetz Lindenmaier wrote: >> This is a backout needed as the change is too intrusive for a backport. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into goetz_backport_8322883 > - Backport 18e97aa217087ff7af13a0147eaf091df3cb20eb Yes, it backs out the two changes. I patched the 21u change. I first tried git revert, but later I figured I used the older change, which did not succeed. The second change fixes within the newly added code. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2102#issuecomment-1879638352 From gcao at openjdk.org Sat Jan 6 12:17:25 2024 From: gcao at openjdk.org (Gui Cao) Date: Sat, 6 Jan 2024 12:17:25 GMT Subject: [jdk21u-dev] Integrated: 8322583: RISC-V: Enable fast class initialization checks In-Reply-To: <4NawOTgi7mWwo2Zf47do4xJryURVn0tlkgofUKDLYEk=.a243054a-dc79-4408-89bc-4971299303e9@github.com> References: <4NawOTgi7mWwo2Zf47do4xJryURVn0tlkgofUKDLYEk=.a243054a-dc79-4408-89bc-4971299303e9@github.com> Message-ID: On Fri, 5 Jan 2024 06:51:47 GMT, Gui Cao wrote: > Hi, The same issue also exists in the JDK21U. Since corresponding fixes for the other ports are already there in jdk21u, I would like to backport this to jdk21u too. So I would like to backport this to JDK21U. Tier1-3 tested with release build using qemu systems. This is a risc-v specific change. Backport is clean, risk is low. This pull request has now been integrated. Changeset: 4bdda4b5 Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/jdk21u-dev/commit/4bdda4b59757a593cbceeb1ace071b489678b903 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8322583: RISC-V: Enable fast class initialization checks Backport-of: 5235cc987d8c4455622acda947bed7321086a385 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/132 From duke at openjdk.org Sat Jan 6 21:54:25 2024 From: duke at openjdk.org (Elif Aslan) Date: Sat, 6 Jan 2024 21:54:25 GMT Subject: [jdk17u-dev] Withdrawn: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests In-Reply-To: References: Message-ID: On Sat, 6 Jan 2024 01:47:06 GMT, Elif Aslan wrote: > Clean backport of Enable parallelism in vmTestbase/nsk/stress/threads tests > > GHA Tested This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2108 From duke at openjdk.org Sat Jan 6 21:55:28 2024 From: duke at openjdk.org (Elif Aslan) Date: Sat, 6 Jan 2024 21:55:28 GMT Subject: [jdk17u-dev] Withdrawn: 8299254: Support dealing with standard assert macro In-Reply-To: References: Message-ID: On Thu, 2 Nov 2023 00:42:47 GMT, Elif Aslan wrote: > Not a clean backport of [c61bd4e1d5e58a0129c7](https://git.openjdk.org/jdk/commit/3e2314d08218dc8a4f4fc61bd4e1d5e58a0129c7) . > There were white space conflicts and non existent test/hotspot/gtest/code/test_codestrings.cpp file to be deleted. > Resolved JBS issue is [JDK-8299254](https://bugs.openjdk.org/browse/JDK-8299254) > > GHA tested. > Tier1/tier2 tests passed on linux This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1940 From duke at openjdk.org Sat Jan 6 22:00:34 2024 From: duke at openjdk.org (Elif Aslan) Date: Sat, 6 Jan 2024 22:00:34 GMT Subject: [jdk17u-dev] RFR: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests Message-ID: <2qo0_qsCOvZf3KRgaCVZ50EHkEx6c3cIZIQxlcFGXv0=.e4de2e03-617c-4ac6-b376-d85c9bf98776@github.com> Clean backport to enable parallelism in vmTestbase/nsk/stress/jni tests Tested with GHA ------------- Commit messages: - Backport 43f31d73852d63ccdcc2dcd8d6c7355435a50fb3 Changes: https://git.openjdk.org/jdk17u-dev/pull/2109/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2109&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318607 Stats: 24 lines in 1 file changed: 0 ins; 24 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2109.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2109/head:pull/2109 PR: https://git.openjdk.org/jdk17u-dev/pull/2109 From andrewlu at openjdk.org Mon Jan 8 02:15:29 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 8 Jan 2024 02:15:29 GMT Subject: [jdk11u-dev] Integrated: 8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt In-Reply-To: <6eE0ccBtzGIucxC0IAAZOTxUQavdPo_uP8LyTTqFEZE=.66acf5d3-c261-4566-a0b4-a0a619b89eea@github.com> References: <6eE0ccBtzGIucxC0IAAZOTxUQavdPo_uP8LyTTqFEZE=.66acf5d3-c261-4566-a0b4-a0a619b89eea@github.com> Message-ID: On Thu, 4 Jan 2024 05:40:51 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. > Not in ProblemList.txt?so make it clean. This pull request has now been integrated. Changeset: 9a16bee4 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/9a16bee409d77b0207c9c745c654c765ec6b34c6 Stats: 8 lines in 2 files changed: 1 ins; 1 del; 6 mod 8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt Backport-of: c84866ac0dcda487fe2abc2a8841f237df0a395b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2431 From andrewlu at openjdk.org Mon Jan 8 02:23:39 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 8 Jan 2024 02:23:39 GMT Subject: [jdk11u-dev] RFR: 8320208: Update Public Suffix List to b5bf572 [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.23-oracle. > make backports to the origin file: > make/data/publicsuffixlist/VERSION > make/data/publicsuffixlist/public_suffix_list.dat Andrew Lu has updated the pull request incrementally with two additional commits since the last revision: - Merge remote-tracking branch 'origin/andrewLu_backport_8320208' into andrewLu_backport_8320208 - Backport 8c76f46f2d90b7c3a4cb6bcfc8fccc93811b2cdc ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2414/files - new: https://git.openjdk.org/jdk11u-dev/pull/2414/files/9275c6d8..f0c679dc Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2414&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2414&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2414.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2414/head:pull/2414 PR: https://git.openjdk.org/jdk11u-dev/pull/2414 From andrewlu at openjdk.org Mon Jan 8 03:12:27 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 8 Jan 2024 03:12:27 GMT Subject: [jdk11u-dev] Withdrawn: 8320208: Update Public Suffix List to b5bf572 In-Reply-To: References: Message-ID: On Tue, 26 Dec 2023 06:44:43 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. > make backports to the origin file: > make/data/publicsuffixlist/VERSION > make/data/publicsuffixlist/public_suffix_list.dat This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2414 From goetz at openjdk.org Mon Jan 8 07:08:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 07:08:33 GMT Subject: [jdk21u-dev] Integrated: 8315097: Rename createJavaProcessBuilder In-Reply-To: References: Message-ID: On Sat, 30 Dec 2023 11:12:30 GMT, Goetz Lindenmaier wrote: > I backport this to keep the 21u test suite up-to-date. This will simplify future test backports. > > I split this into 4 commits: > 1. The clean parts. > 2. The files I resolved. > 3. Follow up change JDK-8318964 needed. > 4. Edit some files that were removed after 21. > > Details: > > Commit 2: > > test/hotspot/jtreg/compiler/compilercontrol/TestConflictInlineCommands.java > Resolved. Later change was backported already. > > test/hotspot/jtreg/compiler/jvmci/TestJVMCISavedProperties.java > Test not in 21u. > > test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckHoistingScaledIV.java > Resolved. Predecessor 8312522: Implementation of Foreign Function & Memory API cannot be backported. > > test/hotspot/jtreg/runtime/CommandLine/DoubleFlagWithIntegerValue.java > Resolved Predecessor 8305506: Add support for fractional values of SafepointTimeoutDelay cannot be backported. > > test/hotspot/jtreg/runtime/ErrorHandling/TestAbortVmOnException.java > Resolved. I backported predecessor 8310919 and resolved this on top of that change. > I missed one -Xbatch, removed in commit 5. > > test/hotspot/jtreg/runtime/Safepoint/TestAbortVMOnSafepointTimeout.java > Resolved because of 82205507, which cannot be backported, it is a new feature. > > test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/LambdasInTwoArchives.java > Test not in 21. Came with 8307468, new feature. Skipped. > > test/hotspot/jtreg/runtime/logging/ClassLoadUnloadTest.java > Resolved. Would need several predecessor backports. > > test/hotspot/jtreg/runtime/posixSig/TestPosixSig.java > Resolved. Previous change is a new feature, cannot be backported. > > test/hotspot/jtreg/runtime/verifier/TestTableSwitch.java > Test not in 21. New feature. Skipped. > > > Commit 3: > > Follow up "8318964: Fix build failures caused by 8315097:" > This change could be applied clean on top of the previous commits except for > the change to > test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointersEncodingScheme.java > which I omitted as the test is not in 21. > > > Commit 4: > > The following files were removed after 21. > I adapted them because they are also using the removed function createJavaProcessBuilder(): > > test/hotspot/jtreg/gc/arguments/TestArrayAllocatorMallocLimit.java > Removed by 8299915: Remove ArrayAllocatorMallocLimit and associated code. Fixed. > > test/hotspot/jtreg/gc/startup_warnings/TestG1.java > test/hotspot/jtreg/gc/startup_warnings/TestParallelGC.java > test/hotspot/jtreg/gc/startup_warnings/TestSerialGC.java > test/hotspot/jtreg/gc/startup_warnings/TestShenandoah.java > Removed by 831... This pull request has now been integrated. Changeset: 1f38afa6 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/1f38afa6c6fa7949c5d7171b817f1d7883987cf4 Stats: 1579 lines in 566 files changed: 44 ins; 10 del; 1525 mod 8315097: Rename createJavaProcessBuilder 8318964: Fix build failures caused by 8315097 Reviewed-by: mdoerr Backport-of: d52a995f35de26c2cc4074297a75141e4a363e1b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/105 From goetz at openjdk.org Mon Jan 8 07:10:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 07:10:30 GMT Subject: [jdk17u-dev] Integrated: 8278028: [test-library] Warnings cleanup of the test library In-Reply-To: References: Message-ID: <7vvMg6zhHmrP90SkRkRfbpoUsIGNUUlI9yTEKbR1Pyc=.d27cac1f-04ac-440d-846a-2a44350b7468@github.com> On Wed, 3 Jan 2024 09:07:31 GMT, Goetz Lindenmaier wrote: > I think this is good to have in 17 to reduce the warnings and to simplify further test backports > > Skipped patch to OldWhiteBox.java, file not in 17. > Resolved InMemoryJavaCompiler.java: Copyright, import. Changes already backported. This pull request has now been integrated. Changeset: dff69b7c Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/dff69b7cfaa872ac8baa062d9264f610f0c195df Stats: 25 lines in 13 files changed: 8 ins; 1 del; 16 mod 8278028: [test-library] Warnings cleanup of the test library Reviewed-by: mdoerr Backport-of: 03f647f4bb640bf5df1c461eec9860c7ac3eb076 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2092 From goetz at openjdk.org Mon Jan 8 07:18:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 07:18:45 GMT Subject: [jdk21u-dev] RFR: 8319569: Several java/util tests should be updated to accept VM flags [v3] In-Reply-To: References: Message-ID: > I backport this to keep the 21u test suite up-to-date. This will simplify future test backports. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Merge branch 'master' into goetz_backport_8319569 - Backport 2bb4b9398d65e3f37f34e45476c969ff0afb1540 - Remove -Xbatch in TestAbortVmOnException.java I missed this when resolving 8310919 - Adapt some remaining tests - Backport of follow up 8318964, clean except for file missing in 21 - Resolves needed - Clean parts ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/129/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=129&range=02 Stats: 185 lines in 12 files changed: 20 ins; 42 del; 123 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/129.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/129/head:pull/129 PR: https://git.openjdk.org/jdk21u-dev/pull/129 From goetz at openjdk.org Mon Jan 8 07:18:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 07:18:47 GMT Subject: [jdk21u-dev] Integrated: 8319569: Several java/util tests should be updated to accept VM flags In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 16:29:34 GMT, Goetz Lindenmaier wrote: > I backport this to keep the 21u test suite up-to-date. This will simplify future test backports. This pull request has now been integrated. Changeset: 854c3191 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/854c3191c31e4e33b66fb4c236e44014c8cce7a4 Stats: 185 lines in 12 files changed: 20 ins; 42 del; 123 mod 8319569: Several java/util tests should be updated to accept VM flags Backport-of: 2bb4b9398d65e3f37f34e45476c969ff0afb1540 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/129 From goetz at openjdk.org Mon Jan 8 07:22:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 07:22:48 GMT Subject: [jdk21u-dev] RFR: 8210410: Refactor java.util.Currency:i18n shell tests to plain java tests [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.3-oracle. > > Note: this was a clean backport. Obviously the bot's don't recognize this. If they still don't manage after pushing and merging the predecessor changes, I will mark it clean. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/130/files - new: https://git.openjdk.org/jdk21u-dev/pull/130/files/ddc852b3..ddc852b3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=130&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=130&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/130.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/130/head:pull/130 PR: https://git.openjdk.org/jdk21u-dev/pull/130 From shade at openjdk.org Mon Jan 8 08:25:31 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 08:25:31 GMT Subject: [jdk17u-dev] Integrated: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 15:54:28 GMT, Aleksey Shipilev wrote: > This reverts the patch that caused recently identified regression. Luckily, we have it only in 17.0.11, which gives us a normal opportunity to revert it. > > The complication is that mainline patch is not applying cleanly, because JDK 17u backport is contextually different. So I `git revert`-ed the jdk17u-dev commit instead: https://github.com/openjdk/jdk17u-dev/commit/9a104e08f79fecabf5de2e0ece914260319d2f28. But that makes the backport formally unclean. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: f001819b Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/f001819b625e5c67444dd764e3afeddc3959f1a2 Stats: 247 lines in 4 files changed: 1 ins; 244 del; 2 mod 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used Reviewed-by: kvn Backport-of: ed9f3243f04718a50bbdc589437872f7215c0e08 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2103 From shade at openjdk.org Mon Jan 8 08:48:26 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 08:48:26 GMT Subject: [jdk21u] RFR: 8322512: StringBuffer.repeat does not work correctly after toString() was called In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 13:06:00 GMT, Jim Laskey wrote: > 8322512: StringBuffer.repeat does not work correctly after toString() was called @JimLaskey, are you planning to deliver this fix to 21.0.2 (GA in Jan 2024, very soon)? If not, then PR should be against jdk21u-dev repo and target 21.0.3. The PRs against jdk21u would probably be left unacknowledged. Tell me if you don't want to do it, I'll take over. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/428#issuecomment-1880583151 From goetz at openjdk.org Mon Jan 8 08:49:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 08:49:41 GMT Subject: [jdk21u-dev] RFR: 8210410: Refactor java.util.Currency:i18n shell tests to plain java tests [v3] In-Reply-To: References: Message-ID: <6AImD_woJZ_QtUL0M5iFSVAs3Ddy2_8fsSq1qEQMkgg=.e70fa714-d0fe-4fe7-825d-9793610d6278@github.com> > I backport this for parity with 21.0.3-oracle. > > Note: this was a clean backport. Obviously the bot's don't recognize this. If they still don't manage after pushing and merging the predecessor changes, I will mark it clean. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/130/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=130&range=02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/130.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/130/head:pull/130 PR: https://git.openjdk.org/jdk21u-dev/pull/130 From goetz at openjdk.org Mon Jan 8 08:49:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 08:49:42 GMT Subject: [jdk21u-dev] Withdrawn: 8210410: Refactor java.util.Currency:i18n shell tests to plain java tests In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 18:08:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. > > Note: this was a clean backport. Obviously the bot's don't recognize this. If they still don't manage after pushing and merging the predecessor changes, I will mark it clean. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/130 From andrewlu at openjdk.org Mon Jan 8 08:54:39 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 8 Jan 2024 08:54:39 GMT Subject: [jdk11u-dev] Integrated: 8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 05:54:44 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. > Also backport for JDK-8237222, both clean. This pull request has now been integrated. Changeset: 4031a889 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/4031a889b7a802d19ad3b43d0056ea1593596d97 Stats: 159 lines in 1 file changed: 159 ins; 0 del; 0 mod 8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails 8237222: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails Reviewed-by: mdoerr Backport-of: b6dddf4ce6072416e17cadefbd8280f959fd93ca ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2432 From shade at openjdk.org Mon Jan 8 08:56:27 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 08:56:27 GMT Subject: [jdk21u-dev] RFR: 8320145: Compiler should accept final variable in Record Pattern In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:18:57 GMT, Aleksey Shipilev wrote: > Clean backport to fix the new language feature in JDK 21. The patch extends the space of compilable programs. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] macos-aarch64-server-fastdebug, `langtools_all` @biboudis: just checking, you are good with this going into 21u, right? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/125#issuecomment-1880592581 From shade at openjdk.org Mon Jan 8 08:57:28 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 08:57:28 GMT Subject: [jdk21u-dev] RFR: 8321582: yield .class not parsed correctly. In-Reply-To: References: Message-ID: <8KretFKuniQXRuwJFNkWYRNhEgdxorwxj4-iVGaThSg=.a0ae6468-37d6-415f-a802-9fe21d5b1cd0@github.com> On Thu, 4 Jan 2024 12:42:56 GMT, Aleksey Shipilev wrote: > Fixes the javac bug, extends the space of compilable Java programs. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] `langtools_all` pass @lahodaj: just checking, you are good with this going into 21u, right? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/128#issuecomment-1880594454 From goetz at openjdk.org Mon Jan 8 09:05:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 09:05:47 GMT Subject: [jdk21u-dev] RFR: 8210410: Refactor java.util.Currency:i18n shell tests to plain java tests [v4] In-Reply-To: References: Message-ID: <2_hyzijI6WBCC84_rLTlxg5tFyTZ_7urlYdi_e3ii_s=.532344b4-9a93-48bb-b324-247ade16e6f6@github.com> > I backport this for parity with 21.0.3-oracle. > > Note: this was a clean backport. Obviously the bot's don't recognize this. If they still don't manage after pushing and merging the predecessor changes, I will mark it clean. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Backport 2584bf87aef66744a8e586805735cded0d2f98f1 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/130/files - new: https://git.openjdk.org/jdk21u-dev/pull/130/files/854c3191..9feae497 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=130&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=130&range=02-03 Stats: 301 lines in 2 files changed: 157 ins; 144 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/130.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/130/head:pull/130 PR: https://git.openjdk.org/jdk21u-dev/pull/130 From james.laskey at oracle.com Mon Jan 8 09:06:14 2024 From: james.laskey at oracle.com (Jim Laskey) Date: Mon, 8 Jan 2024 09:06:14 +0000 Subject: [jdk21u] RFR: 8322512: StringBuffer.repeat does not work correctly after toString() was called In-Reply-To: References: Message-ID: <85A67776-E0F5-48C1-A125-492EA41C6739@oracle.com> Go ahead. ? > On Jan 8, 2024, at 4:49?AM, Aleksey Shipilev wrote: > > ?On Thu, 4 Jan 2024 13:06:00 GMT, Jim Laskey wrote: > >> 8322512: StringBuffer.repeat does not work correctly after toString() was called > > @JimLaskey, are you planning to deliver this fix to 21.0.2 (GA in Jan 2024, very soon)? If not, then PR should be against jdk21u-dev repo and target 21.0.3. The PRs against jdk21u would probably be left unacknowledged. Tell me if you don't want to do it, I'll take over. > > ------------- > > PR Comment: https://git.openjdk.org/jdk21u/pull/428#issuecomment-1880583151 From goetz at openjdk.org Mon Jan 8 09:10:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 09:10:26 GMT Subject: [jdk21u-dev] Integrated: 8310238: [test bug] javax/swing/JTableHeader/6889007/bug6889007.java fails In-Reply-To: <6Zcc3q26sqBoZ7xDXrDMiZbi_TQx3P6UV1VLNtCzLiI=.bcbe3acb-fa56-4ae4-962f-98fa09e170d6@github.com> References: <6Zcc3q26sqBoZ7xDXrDMiZbi_TQx3P6UV1VLNtCzLiI=.bcbe3acb-fa56-4ae4-962f-98fa09e170d6@github.com> Message-ID: On Wed, 3 Jan 2024 08:12:56 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: e8aa37db Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/e8aa37dbe6a69889256d886a8faa75dfaa8849a7 Stats: 24 lines in 1 file changed: 19 ins; 2 del; 3 mod 8310238: [test bug] javax/swing/JTableHeader/6889007/bug6889007.java fails Backport-of: 2cf5c2f4b6cdb52a3560ab03d272f19f47b22b17 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/112 From goetz at openjdk.org Mon Jan 8 09:11:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 09:11:25 GMT Subject: [jdk21u-dev] Integrated: 8311279: TestStressIGVNAndCCP.java failed with different IGVN traces for the same seed In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 08:15:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: c8caefa5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/c8caefa5c3ab4206eff90ea0684a3bb4e14362a4 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8311279: TestStressIGVNAndCCP.java failed with different IGVN traces for the same seed Backport-of: edb2be10fb897834ed78ab4493d3a4f73dc2e140 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/113 From goetz at openjdk.org Mon Jan 8 09:16:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 09:16:28 GMT Subject: [jdk21u-dev] Integrated: 8316594: C2 SuperWord: wrong result with hand unrolled loops In-Reply-To: References: Message-ID: On Tue, 2 Jan 2024 17:16:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. > > I had to resove SWPointer / VPointer because 8312332: C2: Refactor SWPointer out from SuperWord is not in 21. > > We had previous backports that needed to be resolved because of this refactoring missing. I assume this will hit us in future repeatedly. > > Thus I had a look at backporting 8312332, but that depends on three other cleanup changes: > 8305636: Expand and clean up predicate classes and move them into separate files > 8311691: C2: Remove legacy code related to PostLoopMultiversioning > 8308606: C2 SuperWord: remove alignment checks when not required > > All four of them can be backported clean, but 8305363 has four follow-up bugs. > > So maybe we need to go the path and accept the unclean backports right from the beginning of 21u :( This pull request has now been integrated. Changeset: db1fa92d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/db1fa92d7420dc94f82af0c781a04a6e0ca511eb Stats: 112 lines in 3 files changed: 104 ins; 5 del; 3 mod 8316594: C2 SuperWord: wrong result with hand unrolled loops Reviewed-by: roland, shade Backport-of: 3630af26e6f05237195e53b98603adf404e90a1a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/110 From goetz at openjdk.org Mon Jan 8 09:16:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 09:16:34 GMT Subject: [jdk17u-dev] Integrated: 8303605: Memory leaks in Metaspace gtests In-Reply-To: <02B20Ny6IjOJWf9y1H-JMc_AraZyUGaq35_aDlEXzXo=.8baef9b2-05ac-4930-b137-2f0b87b086bc@github.com> References: <02B20Ny6IjOJWf9y1H-JMc_AraZyUGaq35_aDlEXzXo=.8baef9b2-05ac-4930-b137-2f0b87b086bc@github.com> Message-ID: <04IgmjWuvt4JT4BDUnDGKA0_odaQmO4aKabH-atsofg=.9c2d53d4-2f65-45ab-a2d1-c5ed27b72811@github.com> On Wed, 3 Jan 2024 15:23:38 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. > > I resolved test_virtualspacenode.cpp due to an extra empty line, will mark as clean. This pull request has now been integrated. Changeset: f59ca35a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f59ca35a137da1b93dc8cc8e6d5dec61f2736b70 Stats: 19 lines in 4 files changed: 18 ins; 0 del; 1 mod 8303605: Memory leaks in Metaspace gtests Reviewed-by: mdoerr Backport-of: ddcb369ceabd2207699632e90a358baf251c6f36 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2093 From goetz at openjdk.org Mon Jan 8 09:22:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 09:22:32 GMT Subject: [jdk17u-dev] Integrated: 8316693: Simplify at-requires checkDockerSupport() In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 15:32:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 2470cace Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/2470cace0dc5a9ac68fdfbf230447feec8e3db0b Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod 8316693: Simplify at-requires checkDockerSupport() Backport-of: 16fd43c5eb0fb18e93f00b5817d368df5afad969 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2094 From goetz at openjdk.org Mon Jan 8 09:23:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 09:23:28 GMT Subject: [jdk21u-dev] Integrated: 8319938: TestFileChooserSingleDirectorySelection.java fails with "getSelectedFiles returned empty array" In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 08:55:17 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 307569f2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/307569f2c332fcbaeff360ed90d2038fec8c3b5b Stats: 148 lines in 1 file changed: 58 ins; 53 del; 37 mod 8319938: TestFileChooserSingleDirectorySelection.java fails with "getSelectedFiles returned empty array" Backport-of: 4ef24e2596340c5375f2ab07883c26a6458efe0e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/116 From goetz at openjdk.org Mon Jan 8 09:23:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 09:23:27 GMT Subject: [jdk21u-dev] Integrated: 8319879: Stress mode to randomize incremental inlining decision In-Reply-To: References: Message-ID: On Sat, 30 Dec 2023 15:22:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: dfc93243 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/dfc93243a870ccd5fa2a3e39346e04713077380a Stats: 21 lines in 9 files changed: 9 ins; 2 del; 10 mod 8319879: Stress mode to randomize incremental inlining decision Backport-of: 303757b3a0d73329c954b28f08058fb60e5c9729 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/106 From goetz at openjdk.org Mon Jan 8 09:24:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 09:24:36 GMT Subject: [jdk11u-dev] Integrated: 8322417: Console read line with zero out should zero out when throwing exception In-Reply-To: <3FqQdNO7Z3yIZAEAxMnfNc1VjHwd-5uULx493xzP8NQ=.854a1604-fd62-42e5-b25c-c69361f1f386@github.com> References: <3FqQdNO7Z3yIZAEAxMnfNc1VjHwd-5uULx493xzP8NQ=.854a1604-fd62-42e5-b25c-c69361f1f386@github.com> Message-ID: On Fri, 29 Dec 2023 14:31:12 GMT, Goetz Lindenmaier wrote: > A change we should have in 11, too. > > I had to adapt the instanceof. This pull request has now been integrated. Changeset: 8ca3b77e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/8ca3b77e67c379c7419c6145720d8ff8a028a24b Stats: 11 lines in 1 file changed: 10 ins; 0 del; 1 mod 8322417: Console read line with zero out should zero out when throwing exception Reviewed-by: mbaesken Backport-of: ddc909d6a4ac51c4d589d6a7e9c943464dbfe3c2 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2424 From goetz at openjdk.org Mon Jan 8 09:25:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 09:25:25 GMT Subject: [jdk21u-dev] Integrated: 8316693: Simplify at-requires checkDockerSupport() In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 08:27:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. > > Checked that tests using @requires docker.support still work. This pull request has now been integrated. Changeset: d4797b71 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/d4797b711e7666ebd7d0ef77ebfb2d94cd183c8d Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod 8316693: Simplify at-requires checkDockerSupport() Backport-of: 16fd43c5eb0fb18e93f00b5817d368df5afad969 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/115 From shade at openjdk.org Mon Jan 8 09:25:26 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 09:25:26 GMT Subject: [jdk21u-dev] RFR: 8318082: ConcurrentModificationException from IndexWriter [v2] In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 09:58:40 GMT, Aleksey Shipilev wrote: >> Unclean backport to fix a customer-visible bug in Javadoc tool. The uncleanliness comes from the missing refactoring ([JDK-8309566](https://bugs.openjdk.org/browse/JDK-8309566), that looks unnecessary to backport. >> >> Maybe @jonathan-gibbons and @pavelrappo want to take a look. >> >> Additional testing: >> - [x] New test fails without the product fix, passes with it >> - [x] `jdk/javadoc` still passes > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8318082-cme-indexwriter > - Backport fc29a2e152310ed81bd1bb23e6f17d02f055a454 @phohensee, @jerboaa, maybe? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/23#issuecomment-1880634300 From shade at openjdk.org Mon Jan 8 09:27:51 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 09:27:51 GMT Subject: [jdk21u-dev] RFR: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate Message-ID: Clean backport to fix 1.5 yrs old regression. Effectively reverts [JDK-8287349](https://bugs.openjdk.org/browse/JDK-8287349). Additional testing: - [x] macos-aarch64-server-fastdebug: New test fails without a patch, passes with it - [ ] linux-aarch64-server-fastdebug, `tier{1,2,3}` ------------- Commit messages: - Backport ade21a965f8a5fc889cd48bba76fad507bdeddf5 Changes: https://git.openjdk.org/jdk21u-dev/pull/137/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=137&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310844 Stats: 149 lines in 2 files changed: 147 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/137.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/137/head:pull/137 PR: https://git.openjdk.org/jdk21u-dev/pull/137 From aph at openjdk.org Mon Jan 8 09:33:24 2024 From: aph at openjdk.org (Andrew Haley) Date: Mon, 8 Jan 2024 09:33:24 GMT Subject: [jdk21u-dev] RFR: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 09:14:24 GMT, Aleksey Shipilev wrote: > Clean backport to fix 1.5 yrs old regression. Effectively reverts [JDK-8287349](https://bugs.openjdk.org/browse/JDK-8287349). > > Additional testing: > - [x] macos-aarch64-server-fastdebug: New test fails without a patch, passes with it > - [ ] linux-aarch64-server-fastdebug, `tier{1,2,3}` Marked as reviewed by aph (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/137#pullrequestreview-1808482581 From shade at openjdk.org Mon Jan 8 09:38:33 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 09:38:33 GMT Subject: [jdk21u-dev] RFR: 8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects Message-ID: Clean backport to fix Generational ZGC. Picking this up for 21u, @fisk -- tell me if that is not a good idea. Additional testing: - [ ] Linux x86-64 server fastdebug, `hotspot_gc` with `-XX:+UseZGC -XX:+ZGenerational` ------------- Commit messages: - Backport be49dabd0d7e1cd270399849e5353bf33361c4c5 Changes: https://git.openjdk.org/jdk21u-dev/pull/138/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=138&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321619 Stats: 31 lines in 3 files changed: 26 ins; 1 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/138.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/138/head:pull/138 PR: https://git.openjdk.org/jdk21u-dev/pull/138 From ogillespie at openjdk.org Mon Jan 8 10:36:29 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Mon, 8 Jan 2024 10:36:29 GMT Subject: [jdk17u-dev] Integrated: 8321599: Data loss in AVX3 Base64 decoding In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:23:52 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [13c11487](https://github.com/openjdk/jdk/commit/13c11487f7126a370d9ce8e62f661ea83eedefe6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Scott Gibbons on 4 Jan 2024 and was reviewed by Sandhya Viswanathan and Vladimir Kozlov. > > Thanks! > > There were 3 conflicts when merging: > 1. Trivial original copyright year difference (2021 here, 2023 in tip) > 2. Trivial whitespace difference for the dp_mem hunk (4 space indentation here, 2 spaces in tip) > 3. Git was confused about where to apply the addq/subq hunk, and chose the wrong place (indentation difference again?). Also trivial, once moved. This pull request has now been integrated. Changeset: 1f957962 Author: Oli Gillespie Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/1f95796210bd8389c6b599a6ce00c5ae7c2c4f4d Stats: 124 lines in 2 files changed: 121 ins; 0 del; 3 mod 8321599: Data loss in AVX3 Base64 decoding Reviewed-by: shade, phh Backport-of: 13c11487f7126a370d9ce8e62f661ea83eedefe6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2100 From ogillespie at openjdk.org Mon Jan 8 10:37:27 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Mon, 8 Jan 2024 10:37:27 GMT Subject: [jdk21u-dev] Integrated: 8321599: Data loss in AVX3 Base64 decoding In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 09:48:48 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [13c11487](https://github.com/openjdk/jdk/commit/13c11487f7126a370d9ce8e62f661ea83eedefe6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Scott Gibbons on 4 Jan 2024 and was reviewed by Sandhya Viswanathan and Vladimir Kozlov. > > Thanks! This pull request has now been integrated. Changeset: 1e664886 Author: Oli Gillespie Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/1e6648867b9b04f079332ce8baf59ae4b471571e Stats: 124 lines in 2 files changed: 121 ins; 0 del; 3 mod 8321599: Data loss in AVX3 Base64 decoding Backport-of: 13c11487f7126a370d9ce8e62f661ea83eedefe6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/122 From ashi at openjdk.org Mon Jan 8 10:46:30 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 8 Jan 2024 10:46:30 GMT Subject: [jdk11u-dev] Integrated: 8202790: DnD test DisposeFrameOnDragTest.java does not clean up In-Reply-To: <45OS2lWjhA7xLlZC-doL-5xRZFDcn6nMfkqK9QRpbfE=.5d1f39a5-6836-435b-8dd4-e26229e730cf@github.com> References: <45OS2lWjhA7xLlZC-doL-5xRZFDcn6nMfkqK9QRpbfE=.5d1f39a5-6836-435b-8dd4-e26229e730cf@github.com> Message-ID: <6WvDocsSbgAfC7AVKzeg3X_x3_hjcxjQNm65n3uXaZ0=.0a666564-a13f-48a8-a409-c0410753e758@github.com> On Wed, 13 Dec 2023 18:50:19 GMT, Amos Shi wrote: > Backport of [JDK-8202790](https://bugs.openjdk.org/browse/JDK-8202790) > Clean Backport > > Tests > - Test Succeeded in local Dev Apple M1 Laptop > - PR: All checks have passed > - SAP nightlies passed on `2023-12-23,24` This pull request has now been integrated. Changeset: 94bf6db8 Author: Amos Shi Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/94bf6db8ed4ed93b8fbf15f6773af895202ab6e8 Stats: 9 lines in 2 files changed: 7 ins; 1 del; 1 mod 8202790: DnD test DisposeFrameOnDragTest.java does not clean up Backport-of: 102a305f73d52d8e378de46c3c0b170db0f2c8af ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2375 From ashi at openjdk.org Mon Jan 8 10:48:29 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 8 Jan 2024 10:48:29 GMT Subject: [jdk11u-dev] Integrated: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM In-Reply-To: References: Message-ID: On Fri, 15 Dec 2023 05:27:56 GMT, Amos Shi wrote: > Backport of [JDK-8296083](https://bugs.openjdk.org/browse/JDK-8296083) > > About Clean vs Unclean > - Unclean Backport from `jdk`: > - `test/jdk/ProblemList.txt` The change to this file has been ignored, because the `bug6263446.java` line does not exist > - Clean Backport from `jdk17u-dev` > > Tests > - Test Succeeded in local Dev Apple M1 Laptop > - PR: All checks have passed > - SAP nightlies passed on `2023-12-19` This pull request has now been integrated. Changeset: f6ddc4b4 Author: Amos Shi Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/f6ddc4b4a42d2f4050b67c7d4597b56bcee604d6 Stats: 25 lines in 1 file changed: 21 ins; 1 del; 3 mod 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM Reviewed-by: phh Backport-of: 728dc4de173f2bb1e06b3b3574cb430621e2969b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2391 From ashi at openjdk.org Mon Jan 8 10:53:34 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 8 Jan 2024 10:53:34 GMT Subject: [jdk11u-dev] Integrated: 8294402: Add diagnostic logging to VMProps.checkDockerSupport In-Reply-To: References: Message-ID: On Fri, 15 Dec 2023 05:07:19 GMT, Amos Shi wrote: > Backport of [JDK-8294402](https://bugs.openjdk.org/browse/JDK-8294402) > > Clean vs Unclean Backport > - Unclean Backport because we have manually edited the file `test/jtreg-ext/requires/VMProps.java` > - The `Copyright year` line are conflicting. Manually merged. > - `log("Entering dockerSupport()")` base line are different. Manually merged. > - This file can be considered as `Clean backport` > - Well the system added the `clean` label > > Tests > - PR: All checks have passed > - SAP nightlies passed on 2023-12-19 This pull request has now been integrated. Changeset: de6ccb96 Author: Amos Shi Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/de6ccb964a64c284957f79dded9c55cbd8633ccb Stats: 89 lines in 1 file changed: 87 ins; 0 del; 2 mod 8294402: Add diagnostic logging to VMProps.checkDockerSupport Backport-of: 03d613bbab99dd84dfc5115a5034c60f4e510259 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2390 From ashi at openjdk.org Mon Jan 8 10:58:28 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 8 Jan 2024 10:58:28 GMT Subject: [jdk11u-dev] Integrated: 8281377: Remove vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock/JavaDeadlock001/TestDescription.java from problemlist. In-Reply-To: References: Message-ID: On Wed, 13 Dec 2023 21:09:14 GMT, Amos Shi wrote: > Backport of [JDK-8281377](https://bugs.openjdk.org/browse/JDK-8281377) > - Clean Backport > - About Testing > - This PR is saying the [JDK-8060733](https://bugs.openjdk.org/browse/JDK-8060733) issue has been gone > - [JDK-8060733](https://bugs.openjdk.org/browse/JDK-8060733) is related to `test/hotspot/jtreg/vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock/JavaDeadlock001/TestDescription.java` > > Test > - I have tested the `TestDescription.java` in local dev laptop, it passed > - PR: All checks have passed > - SAP nightlies passed on `2023-12-25,27` and `2024-01-02,04` This pull request has now been integrated. Changeset: 3c732a61 Author: Amos Shi Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/3c732a61bfc573c2c34ca9644f299a1a1a757e56 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod 8281377: Remove vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock/JavaDeadlock001/TestDescription.java from problemlist. Backport-of: 1dfc94dd561f6a91ef3784fe28c83f839f8188c4 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2377 From goetz at openjdk.org Mon Jan 8 11:54:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 11:54:33 GMT Subject: [jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v5] In-Reply-To: References: Message-ID: On Sat, 6 Jan 2024 00:13:15 GMT, Martin Balao wrote: >> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: >> >> Do the whitespace fix properly. > > Hi Goetz, > > Thanks for proposing this backport. > > One minor comment: > > * test/jdk/javax/xml/crypto/dsig/GenerationTests.java > * The import of X509Certificate and the definition of x5ks are dead code. > > Otherwise, looks good to me. I'll give my approval anyways, as this is a minor comment. > > On a final note, I agree with your changes of removing EdDSA code and aligning to the approved CSR. However, I have to say that doing this for 17u does not only prevent users from the enhancement but also increases the maintenance cost as there will be more chances of updates not applying cleanly for the years to come. I would have treated 17u differently than previous releases. > > Martin.- Hi @martinuy, do you think it would be better to keep all the code and only remove the two String and the change to the comment of DigestMethod? In the 21u change for the update to [3.0.3](https://github.com/openjdk/jdk21u-dev/pull/94) I have done it that way. Probably that's also the better solution here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2006#issuecomment-1880854953 From abimpoudis at openjdk.org Mon Jan 8 12:05:24 2024 From: abimpoudis at openjdk.org (Aggelos Biboudis) Date: Mon, 8 Jan 2024 12:05:24 GMT Subject: [jdk21u-dev] RFR: 8320145: Compiler should accept final variable in Record Pattern In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 08:53:22 GMT, Aleksey Shipilev wrote: >> Clean backport to fix the new language feature in JDK 21. The patch extends the space of compilable programs. >> >> Additional testing: >> - [x] New regression test fails without the fix, passes with it >> - [x] macos-aarch64-server-fastdebug, `langtools_all` > > @biboudis: just checking, you are good with this going into 21u, right? @shipilev Looks good to me, yes! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/125#issuecomment-1880870731 From shade at openjdk.org Mon Jan 8 12:11:28 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 12:11:28 GMT Subject: [jdk21u-dev] RFR: 8320145: Compiler should accept final variable in Record Pattern In-Reply-To: References: Message-ID: <2lrMWLfPBd-j9zbHxXZjRdz9xRLt6u24OsrOvAtcZFA=.267d1012-dee5-416e-9fba-92c279794ac3@github.com> On Thu, 4 Jan 2024 10:18:57 GMT, Aleksey Shipilev wrote: > Clean backport to fix the new language feature in JDK 21. The patch extends the space of compilable programs. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] macos-aarch64-server-fastdebug, `langtools_all` Ack! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/125#issuecomment-1880877143 From shade at openjdk.org Mon Jan 8 12:11:29 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 12:11:29 GMT Subject: [jdk21u-dev] Integrated: 8320145: Compiler should accept final variable in Record Pattern In-Reply-To: References: Message-ID: <5EDAw30ZL9IVJyPFzE3wbdzKx60QfyhMdaAOFXSJMwk=.baaa452d-997a-456c-a5c9-37fc92778e3f@github.com> On Thu, 4 Jan 2024 10:18:57 GMT, Aleksey Shipilev wrote: > Clean backport to fix the new language feature in JDK 21. The patch extends the space of compilable programs. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] macos-aarch64-server-fastdebug, `langtools_all` This pull request has now been integrated. Changeset: a85f3f83 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/a85f3f8300245d97daee8f35f4ebdeb442fe1fdb Stats: 48 lines in 3 files changed: 44 ins; 2 del; 2 mod 8320145: Compiler should accept final variable in Record Pattern Backport-of: 4ba94ef69ef2ee576c50bb6003a795746dcdf30d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/125 From shade at openjdk.org Mon Jan 8 12:46:29 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 12:46:29 GMT Subject: [jdk17u-dev] RFR: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries [v2] In-Reply-To: References: <5_9LRg5OA0VmlTIo9JsJiRDHv5GrIuYMeA3Iiwl21lo=.e8487b5a-2ba6-4c8d-8355-f0e7580cf1e1@github.com> Message-ID: On Fri, 5 Jan 2024 08:09:08 GMT, Goetz Lindenmaier wrote: >> This is a backout needed as the change is too intrusive for a backport. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into goetz_backport_8322883 > - Backport 18e97aa217087ff7af13a0147eaf091df3cb20eb OK then! Minor: I think the `@bug` line here is not restored to original: https://github.com/openjdk/jdk17u-dev/commit/3a2bf8e570d5e329f22b4eaf5e90fef8cd14f8b2?diff=unified&w=0#diff-4dd7943869aeaa2236b89ff67fdedbf28bc58667354307dc7cb717c5f667c496L26-R26 ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2102#pullrequestreview-1809019081 From eosterlund at openjdk.org Mon Jan 8 12:58:24 2024 From: eosterlund at openjdk.org (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Mon, 8 Jan 2024 12:58:24 GMT Subject: [jdk21u-dev] RFR: 8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 09:32:06 GMT, Aleksey Shipilev wrote: > Clean backport to fix Generational ZGC. > > Picking this up for 21u, @fisk -- tell me if that is not a good idea. > > Additional testing: > - [x] Linux x86-64 server fastdebug, `hotspot_gc` with `-XX:+UseZGC -XX:+ZGenerational` Looks good, thanks for picking it up! ------------- Marked as reviewed by eosterlund (Committer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/138#pullrequestreview-1809040303 From goetz at openjdk.org Mon Jan 8 13:06:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 13:06:49 GMT Subject: [jdk21u-dev] RFR: 8311992: Test java/lang/Thread/virtual/JfrEvents::testVirtualThreadPinned failed Message-ID: <31nKOrYvQ7BbcobPimT0SsOq7iMjLiYMdzSfxCGzJwY=.3f1f9c9f-93f7-4e32-b5c5-7f80ef5627fa@github.com> I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 0d2196f8e5b03577a14ff97505718f4fa53f3792 Changes: https://git.openjdk.org/jdk21u-dev/pull/139/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=139&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311992 Stats: 42 lines in 1 file changed: 19 ins; 2 del; 21 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/139.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/139/head:pull/139 PR: https://git.openjdk.org/jdk21u-dev/pull/139 From jlaskey at openjdk.org Mon Jan 8 13:12:27 2024 From: jlaskey at openjdk.org (Jim Laskey) Date: Mon, 8 Jan 2024 13:12:27 GMT Subject: [jdk21u] RFR: 8322512: StringBuffer.repeat does not work correctly after toString() was called In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 13:06:00 GMT, Jim Laskey wrote: > 8322512: StringBuffer.repeat does not work correctly after toString() was called Go ahead. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/428#issuecomment-1880978735 From goetz at openjdk.org Mon Jan 8 13:13:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 13:13:47 GMT Subject: [jdk21u-dev] RFR: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport b20dc1e9cda1ea3a76b3f14c778c6816e5cc1c0c Changes: https://git.openjdk.org/jdk21u-dev/pull/140/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=140&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310629 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/140.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/140/head:pull/140 PR: https://git.openjdk.org/jdk21u-dev/pull/140 From gcao at openjdk.org Mon Jan 8 13:21:35 2024 From: gcao at openjdk.org (Gui Cao) Date: Mon, 8 Jan 2024 13:21:35 GMT Subject: [jdk17u-dev] RFR: 8322583: RISC-V: Enable fast class initialization checks Message-ID: Hi, The same issue also exists in the JDK17u. Since corresponding fixes for the other ports are already there in jdk17u, I would like to backport this to jdk17u too. So I would like to backport this to JDK17u. Tier1-3 tested with release build using qemu systems. This is a risc-v specific change. risk is low. ------------- Commit messages: - Backport 8322583: RISC-V: Enable fast class initialization checks Changes: https://git.openjdk.org/jdk17u-dev/pull/2110/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2110&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322583 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2110.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2110/head:pull/2110 PR: https://git.openjdk.org/jdk17u-dev/pull/2110 From goetz at openjdk.org Mon Jan 8 13:53:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 13:53:45 GMT Subject: [jdk17u-dev] RFR: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries [v3] In-Reply-To: <5_9LRg5OA0VmlTIo9JsJiRDHv5GrIuYMeA3Iiwl21lo=.e8487b5a-2ba6-4c8d-8355-f0e7580cf1e1@github.com> References: <5_9LRg5OA0VmlTIo9JsJiRDHv5GrIuYMeA3Iiwl21lo=.e8487b5a-2ba6-4c8d-8355-f0e7580cf1e1@github.com> Message-ID: > This is a backout needed as the change is too intrusive for a backport. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Proverly revert @bug in BasicAnnoTests.java ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2102/files - new: https://git.openjdk.org/jdk17u-dev/pull/2102/files/a8835e76..44f8374a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2102&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2102&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2102.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2102/head:pull/2102 PR: https://git.openjdk.org/jdk17u-dev/pull/2102 From goetz at openjdk.org Mon Jan 8 13:53:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 13:53:48 GMT Subject: [jdk17u-dev] RFR: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries [v2] In-Reply-To: References: <5_9LRg5OA0VmlTIo9JsJiRDHv5GrIuYMeA3Iiwl21lo=.e8487b5a-2ba6-4c8d-8355-f0e7580cf1e1@github.com> Message-ID: On Fri, 5 Jan 2024 08:09:08 GMT, Goetz Lindenmaier wrote: >> This is a backout needed as the change is too intrusive for a backport. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into goetz_backport_8322883 > - Backport 18e97aa217087ff7af13a0147eaf091df3cb20eb Thanks for the review, I fixed the @bug. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2102#issuecomment-1881046142 From goetz at openjdk.org Mon Jan 8 14:03:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 14:03:39 GMT Subject: [jdk17u-dev] RFR: 8272853: improve `JavadocTester.runTests` Message-ID: I backport this for parity with 17.0.11-oracle. Resolved one import, probably recognized clean. ------------- Commit messages: - Backport b0028a459c7e99b5e4090cc19127f6347fe220ba Changes: https://git.openjdk.org/jdk17u-dev/pull/2111/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2111&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272853 Stats: 109 lines in 1 file changed: 97 ins; 6 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2111.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2111/head:pull/2111 PR: https://git.openjdk.org/jdk17u-dev/pull/2111 From goetz at openjdk.org Mon Jan 8 14:28:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 14:28:51 GMT Subject: [jdk17u-dev] RFR: 8307185: pkcs11 native libraries make JNI calls into java code while holding GC lock Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 354c6605e32790ca421869636d8bf5456fc51717 Changes: https://git.openjdk.org/jdk17u-dev/pull/2112/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2112&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307185 Stats: 42 lines in 2 files changed: 16 ins; 11 del; 15 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2112.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2112/head:pull/2112 PR: https://git.openjdk.org/jdk17u-dev/pull/2112 From goetz at openjdk.org Mon Jan 8 14:31:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 14:31:48 GMT Subject: [jdk17u-dev] RFR: 8309302: java/net/Socket/Timeouts.java fails with AssertionError on test temporal post condition Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 87c79c080186abc53d033449dd9f76c8832d44f5 Changes: https://git.openjdk.org/jdk17u-dev/pull/2113/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2113&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309302 Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2113.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2113/head:pull/2113 PR: https://git.openjdk.org/jdk17u-dev/pull/2113 From mbaesken at openjdk.org Mon Jan 8 14:32:21 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 8 Jan 2024 14:32:21 GMT Subject: [jdk22u] RFR: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output Message-ID: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output ------------- Commit messages: - Backport a8e4229852fac703c6271aa8c5f94f67bea44902 Changes: https://git.openjdk.org/jdk22u/pull/10/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=10&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322783 Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/10.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/10/head:pull/10 PR: https://git.openjdk.org/jdk22u/pull/10 From mbaesken at openjdk.org Mon Jan 8 14:37:30 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 8 Jan 2024 14:37:30 GMT Subject: [jdk22u] RFR: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size Message-ID: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size ------------- Commit messages: - Backport b31454e36234091c3827c3b4d07f62345cb0cee4 Changes: https://git.openjdk.org/jdk22u/pull/11/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=11&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322098 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/11.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/11/head:pull/11 PR: https://git.openjdk.org/jdk22u/pull/11 From mbaesken at openjdk.org Mon Jan 8 14:47:36 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 8 Jan 2024 14:47:36 GMT Subject: [jdk21u-dev] RFR: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output Message-ID: <13c6l8iwKE7XUtgAxOL92SghD0502tDS9pQ54WTX0FA=.e9330c80-c55d-41b7-823c-d40c9e37fc6b@github.com> 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output ------------- Commit messages: - Backport a8e4229852fac703c6271aa8c5f94f67bea44902 Changes: https://git.openjdk.org/jdk21u-dev/pull/141/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=141&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322783 Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/141.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/141/head:pull/141 PR: https://git.openjdk.org/jdk21u-dev/pull/141 From goetz at openjdk.org Mon Jan 8 15:02:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 8 Jan 2024 15:02:41 GMT Subject: [jdk21u-dev] RFR: 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 6f263111a1812873291e91870e341ccce804d049 Changes: https://git.openjdk.org/jdk21u-dev/pull/142/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=142&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318490 Stats: 41 lines in 41 files changed: 0 ins; 0 del; 41 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/142.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/142/head:pull/142 PR: https://git.openjdk.org/jdk21u-dev/pull/142 From simonis at openjdk.org Mon Jan 8 15:13:30 2024 From: simonis at openjdk.org (Volker Simonis) Date: Mon, 8 Jan 2024 15:13:30 GMT Subject: [jdk21u-dev] RFR: 8318082: ConcurrentModificationException from IndexWriter [v2] In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 09:58:40 GMT, Aleksey Shipilev wrote: >> Unclean backport to fix a customer-visible bug in Javadoc tool. The uncleanliness comes from the missing refactoring ([JDK-8309566](https://bugs.openjdk.org/browse/JDK-8309566), that looks unnecessary to backport. >> >> Maybe @jonathan-gibbons and @pavelrappo want to take a look. >> >> Additional testing: >> - [x] New test fails without the product fix, passes with it >> - [x] `jdk/javadoc` still passes > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8318082-cme-indexwriter > - Backport fc29a2e152310ed81bd1bb23e6f17d02f055a454 Looks good. ------------- Marked as reviewed by simonis (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/23#pullrequestreview-1809321346 From shade at openjdk.org Mon Jan 8 16:15:28 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 16:15:28 GMT Subject: [jdk17u-dev] RFR: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries [v3] In-Reply-To: References: <5_9LRg5OA0VmlTIo9JsJiRDHv5GrIuYMeA3Iiwl21lo=.e8487b5a-2ba6-4c8d-8355-f0e7580cf1e1@github.com> Message-ID: On Mon, 8 Jan 2024 13:53:45 GMT, Goetz Lindenmaier wrote: >> This is a backout needed as the change is too intrusive for a backport. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Proverly revert @bug in BasicAnnoTests.java Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2102#pullrequestreview-1809511635 From shade at openjdk.org Mon Jan 8 16:21:39 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 16:21:39 GMT Subject: [jdk21u] RFR: 8322512: StringBuffer.repeat does not work correctly after toString() was called In-Reply-To: <85A67776-E0F5-48C1-A125-492EA41C6739@oracle.com> References: <85A67776-E0F5-48C1-A125-492EA41C6739@oracle.com> Message-ID: <7cJ1fgKxuVwwWz0DngUP3ONBkVgoiKcvs8IqgnXhpec=.095ca34d-d285-4f54-98ce-9521923794e4@github.com> On Mon, 8 Jan 2024 14:05:16 GMT, Jim Laskey wrote: > Go ahead. jdk21u-dev PR: https://github.com/openjdk/jdk21u-dev/pull/143 Feel free to close this one. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/428#issuecomment-1881395266 From shade at openjdk.org Mon Jan 8 16:24:41 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 16:24:41 GMT Subject: [jdk21u-dev] RFR: 8322512: StringBuffer.repeat does not work correctly after toString() was called Message-ID: Clean backport to fix JDK 21 feature misbehavior. Additional testing: - [x] New regression test fails without the fix, passes with it - [ ] GHA (includes some Repeat tests) ------------- Commit messages: - Backport df22fb322e6c4c9931a770bd0abf4c43b83c4e4a Changes: https://git.openjdk.org/jdk21u-dev/pull/143/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=143&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322512 Stats: 16 lines in 2 files changed: 15 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/143.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/143/head:pull/143 PR: https://git.openjdk.org/jdk21u-dev/pull/143 From jlaskey at openjdk.org Mon Jan 8 16:31:38 2024 From: jlaskey at openjdk.org (Jim Laskey) Date: Mon, 8 Jan 2024 16:31:38 GMT Subject: [jdk21u] Withdrawn: 8322512: StringBuffer.repeat does not work correctly after toString() was called In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 13:06:00 GMT, Jim Laskey wrote: > 8322512: StringBuffer.repeat does not work correctly after toString() was called This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u/pull/428 From shade at openjdk.org Mon Jan 8 16:37:31 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 16:37:31 GMT Subject: [jdk21u-dev] RFR: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 11:06:14 GMT, yaqsun wrote: > Patch can be applied cleanly. > And test have been locally verified to pass. It looks fine, but you need to go to https://github.com/yaqsun/jdk21u-dev/actions, enable the testing workflow, and kick off the test run. Then apply for maintainer approval, like bot above says. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/126#issuecomment-1881428748 From shade at openjdk.org Mon Jan 8 16:39:32 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 16:39:32 GMT Subject: [jdk21u-dev] Integrated: 8319883: Zero: Use atomic built-ins for 64-bit accesses In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 11:08:23 GMT, Aleksey Shipilev wrote: > Clean backport to fix 32-bit Zero concurrency bug. > > Additional testing: > - [x] Linux x86_32 Zero fastdebug, jcstress run > - [x] Linux Zero build matrix This pull request has now been integrated. Changeset: b745bb51 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/b745bb515f19d47e5246773ddfc48a23deda1345 Stats: 63 lines in 2 files changed: 0 ins; 48 del; 15 mod 8319883: Zero: Use atomic built-ins for 64-bit accesses Backport-of: 25f9af99be1c906fc85b8192df8fa50cced3474f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/127 From mbalao at openjdk.org Mon Jan 8 16:52:28 2024 From: mbalao at openjdk.org (Martin Balao) Date: Mon, 8 Jan 2024 16:52:28 GMT Subject: [jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v5] In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 11:51:26 GMT, Goetz Lindenmaier wrote: >> Hi Goetz, >> >> Thanks for proposing this backport. >> >> One minor comment: >> >> * test/jdk/javax/xml/crypto/dsig/GenerationTests.java >> * The import of X509Certificate and the definition of x5ks are dead code. >> >> Otherwise, looks good to me. I'll give my approval anyways, as this is a minor comment. >> >> On a final note, I agree with your changes of removing EdDSA code and aligning to the approved CSR. However, I have to say that doing this for 17u does not only prevent users from the enhancement but also increases the maintenance cost as there will be more chances of updates not applying cleanly for the years to come. I would have treated 17u differently than previous releases. >> >> Martin.- > > Hi @martinuy, > do you think it would be better to keep all the code and only remove the two String and the change to the comment of DigestMethod? > In the 21u change for the update to [3.0.3](https://github.com/openjdk/jdk21u-dev/pull/94) I have done it that way. Probably that's also the better solution here. Hi @GoeLin , I assume that in 21u you kept all the (implementation) code except for the public members. If so, I understand the motivations but personally prefer what you proposed for 17u in this PR. It makes the code more clear in terms of what is supported. For example, it would be misleading for someone who looks for "EdDSA" references in the code, finds many ?even beyond defines? and assumes that it is supported. This is, of course, at the expense of higher chances of non-clean updates. We have taken this approach in other libraries before such as when we removed the implementation of DTLS in the 8u backport of the TLS engine. Martin.- ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2006#issuecomment-1881457955 From shade at openjdk.org Mon Jan 8 18:28:57 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 18:28:57 GMT Subject: [jdk21u-dev] RFR: 8316132: CDSProtectionDomain::get_shared_protection_domain should check for exception Message-ID: Clean backport to propagate CDS exceptions better. Additional testing: - [ ] Linux x86_64 server fastdebug, `tier{1,2,3}` ------------- Commit messages: - Backport 11394828b32941a69d549bae613ab4c3afb713d5 Changes: https://git.openjdk.org/jdk21u-dev/pull/144/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=144&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316132 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/144.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/144/head:pull/144 PR: https://git.openjdk.org/jdk21u-dev/pull/144 From wkemper at openjdk.org Mon Jan 8 19:39:41 2024 From: wkemper at openjdk.org (William Kemper) Date: Mon, 8 Jan 2024 19:39:41 GMT Subject: [jdk22u] RFR: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation Message-ID: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation ------------- Commit messages: - Backport c4a83bd6f6c45e72bd776e929005be0aa9408867 Changes: https://git.openjdk.org/jdk22u/pull/12/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=12&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323086 Stats: 21 lines in 1 file changed: 21 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/12.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/12/head:pull/12 PR: https://git.openjdk.org/jdk22u/pull/12 From wkemper at openjdk.org Mon Jan 8 19:39:46 2024 From: wkemper at openjdk.org (William Kemper) Date: Mon, 8 Jan 2024 19:39:46 GMT Subject: [jdk21u-dev] RFR: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation Message-ID: <1FVUHUww6yCcpVPdp-TZLcPZU_8-PCwGUZGicGeM8ZQ=.9d3bb228-da53-41cd-ae14-6021149c5930@github.com> 8323086: Shenandoah: Heap could be corrupted by oom during evacuation ------------- Commit messages: - Backport c4a83bd6f6c45e72bd776e929005be0aa9408867 Changes: https://git.openjdk.org/jdk21u-dev/pull/145/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=145&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323086 Stats: 21 lines in 1 file changed: 21 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/145.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/145/head:pull/145 PR: https://git.openjdk.org/jdk21u-dev/pull/145 From wkemper at openjdk.org Mon Jan 8 19:41:44 2024 From: wkemper at openjdk.org (William Kemper) Date: Mon, 8 Jan 2024 19:41:44 GMT Subject: [jdk17u-dev] RFR: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation Message-ID: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation ------------- Commit messages: - Backport c4a83bd6f6c45e72bd776e929005be0aa9408867 Changes: https://git.openjdk.org/jdk17u-dev/pull/2114/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2114&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323086 Stats: 21 lines in 1 file changed: 21 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2114.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2114/head:pull/2114 PR: https://git.openjdk.org/jdk17u-dev/pull/2114 From shade at openjdk.org Mon Jan 8 19:43:32 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 19:43:32 GMT Subject: [jdk17u-dev] RFR: 8322725: (tz) Update Timezone Data to 2023d In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 17:50:45 GMT, Dan Lutker wrote: > Clean backport of tzdata2023d So this is apparently the automatic `/backport`, but it is not marked `clean`, because the paths are different. Bots seemed to have auto-detected the moves correctly, and then correctly implicitly asked for reviews. Good bots. I checked the change against the mainline commit (https://github.com/openjdk/jdk/commit/2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc) and previous commit to jdk17u-dev (https://github.com/openjdk/jdk17u/commit/f8408c7896952320f8b9dc5b515c697d81639197), and I think this is a correct thing to do. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2104#pullrequestreview-1809901702 From shade at openjdk.org Mon Jan 8 19:49:37 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 8 Jan 2024 19:49:37 GMT Subject: [jdk11u-dev] RFR: 8322725: (tz) Update Timezone Data to 2023d In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 17:56:32 GMT, Dan Lutker wrote: > Clean backport of tadata2023d. Apparently same deal as with 17u-dev backport. This is apparently the automatic `/backport`, but it is not marked `clean`, because the paths are different. Bots seemed to have auto-detected the moves correctly, and then correctly implicitly asked for reviews. Good bots. I checked the change against the mainline commit (https://github.com/openjdk/jdk/commit/2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc) and previous commit to jdk11u (https://github.com/openjdk/jdk11u/commit/7f30a6c7c192ff5c96fe5c6d214c834d54952e51), and I think this is a correct thing to do. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2435#pullrequestreview-1809909610 From phh at openjdk.org Tue Jan 9 00:13:28 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 9 Jan 2024 00:13:28 GMT Subject: [jdk17u-dev] RFR: 8272853: improve `JavadocTester.runTests` In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 13:59:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. > > Resolved one import, probably recognized clean. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2111#pullrequestreview-1810220705 From itakiguchi at openjdk.org Tue Jan 9 00:42:27 2024 From: itakiguchi at openjdk.org (Ichiroh Takiguchi) Date: Tue, 9 Jan 2024 00:42:27 GMT Subject: [jdk11u-dev] RFR: 6928542: Chinese characters in RTF are not decoded In-Reply-To: References: Message-ID: On Sat, 2 Dec 2023 03:16:11 GMT, Ichiroh Takiguchi wrote: > Cherry-pick was failed because of following changes: > > [8271456](https://bugs.openjdk.org/browse/JDK-8271456): Avoid looking up standard charsets in "java.desktop" module > openjdk/jdk at 6b55ef3 > 8271456 was code cleanup issue, it's not required for JDK11. > > On src/java.desktop/share/classes/javax/swing/text/rtf/RTFReader.java > Following code is required > > import static java.nio.charset.StandardCharsets.ISO_8859_1; > > On src/java.desktop/share/classes/javax/swing/text/rtf/RTFParser.java > Copyright year is changed from 2017 to 2023. > > Could someone please review it? > > Thanks, > Ichiroh Takiguchi I added jdk11u-fix-request into JBS ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2325#issuecomment-1882070472 From andrewlu at openjdk.org Tue Jan 9 01:53:10 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 9 Jan 2024 01:53:10 GMT Subject: [jdk11u-dev] RFR: 8306076: Open source AWT misc tests Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport f7d45b85a5c664a87c94e0baccd8b9eddce27e2c Changes: https://git.openjdk.org/jdk11u-dev/pull/2439/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2439&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306076 Stats: 169 lines in 3 files changed: 169 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2439.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2439/head:pull/2439 PR: https://git.openjdk.org/jdk11u-dev/pull/2439 From andrewlu at openjdk.org Tue Jan 9 02:15:49 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 9 Jan 2024 02:15:49 GMT Subject: [jdk11u-dev] RFR: 8320208: Update Public Suffix List to b5bf572 Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport ae0716100a64004deef0ed49e7a6196cf78210e4 Changes: https://git.openjdk.org/jdk11u-dev/pull/2440/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2440&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320208 Stats: 3002 lines in 4 files changed: 1753 ins; 73 del; 1176 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2440.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2440/head:pull/2440 PR: https://git.openjdk.org/jdk11u-dev/pull/2440 From duke at openjdk.org Tue Jan 9 02:37:41 2024 From: duke at openjdk.org (yaqsun) Date: Tue, 9 Jan 2024 02:37:41 GMT Subject: [jdk21u-dev] RFR: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize [v2] In-Reply-To: References: Message-ID: > Patch can be applied cleanly. > And test have been locally verified to pass. yaqsun has updated the pull request incrementally with one additional commit since the last revision: trigger test ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/126/files - new: https://git.openjdk.org/jdk21u-dev/pull/126/files/4be4685f..be07444b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=126&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=126&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/126.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/126/head:pull/126 PR: https://git.openjdk.org/jdk21u-dev/pull/126 From duke at openjdk.org Tue Jan 9 03:04:39 2024 From: duke at openjdk.org (yaqsun) Date: Tue, 9 Jan 2024 03:04:39 GMT Subject: [jdk21u-dev] RFR: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize [v3] In-Reply-To: References: Message-ID: > Patch can be applied cleanly. > And test have been locally verified to pass. yaqsun has updated the pull request incrementally with one additional commit since the last revision: del temporary file test.txt ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/126/files - new: https://git.openjdk.org/jdk21u-dev/pull/126/files/be07444b..7d5588ad Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=126&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=126&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/126.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/126/head:pull/126 PR: https://git.openjdk.org/jdk21u-dev/pull/126 From andrewlu at openjdk.org Tue Jan 9 05:36:54 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 9 Jan 2024 05:36:54 GMT Subject: [jdk11u-dev] RFR: 8274621: NullPointerException because listenAddress[0] is null Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport 5bbc8d3cb2ce487b367ee1a621d78699c9b30100 Changes: https://git.openjdk.org/jdk11u-dev/pull/2441/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2441&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274621 Stats: 14 lines in 1 file changed: 4 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2441.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2441/head:pull/2441 PR: https://git.openjdk.org/jdk11u-dev/pull/2441 From clanger at openjdk.org Tue Jan 9 06:13:29 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 9 Jan 2024 06:13:29 GMT Subject: [jdk22u] Integrated: 8322417: Console read line with zero out should zero out when throwing exception In-Reply-To: <_1cnYgFNQpArtyndAfg4a4HMc-UA0hCG14iiUFSMIZM=.fe291267-725b-4e76-855d-1e62728438c5@github.com> References: <_1cnYgFNQpArtyndAfg4a4HMc-UA0hCG14iiUFSMIZM=.fe291267-725b-4e76-855d-1e62728438c5@github.com> Message-ID: On Fri, 29 Dec 2023 13:33:17 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8322417](https://bugs.openjdk.org/browse/JDK-8322417), commit [2f917bff](https://github.com/openjdk/jdk/commit/2f917bff5cbb71dccd70960f563ca1a05d109fda) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Goetz Lindenmaier on 20 Dec 2023 and was reviewed by Matthias Baesken, Thomas Stuefe and Naoto Sato. > > Thanks! This pull request has now been integrated. Changeset: 512cd870 Author: Christoph Langer URL: https://git.openjdk.org/jdk22u/commit/512cd870e138b71b66588957798b6ec213dd3124 Stats: 10 lines in 1 file changed: 9 ins; 0 del; 1 mod 8322417: Console read line with zero out should zero out when throwing exception 8322772: Clean up code after JDK-8322417 Reviewed-by: mbaesken Backport-of: 2f917bff5cbb71dccd70960f563ca1a05d109fda ------------- PR: https://git.openjdk.org/jdk22u/pull/7 From clanger at openjdk.org Tue Jan 9 06:18:35 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 9 Jan 2024 06:18:35 GMT Subject: [jdk17u-dev] Integrated: 8322772: Clean up code after JDK-8322417 In-Reply-To: References: Message-ID: On Sun, 31 Dec 2023 14:40:35 GMT, Christoph Langer wrote: > Code cleanup after JDK-8322417 This pull request has now been integrated. Changeset: bfd23aea Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/bfd23aeae1566b86c20bdcbecff58f216947612a Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8322772: Clean up code after JDK-8322417 Reviewed-by: mbaesken Backport-of: 24b3b2b66f0bed3e9812999a5b6d511f31e9ad1f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2090 From clanger at openjdk.org Tue Jan 9 06:30:48 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 9 Jan 2024 06:30:48 GMT Subject: [jdk11u-dev] RFR: 8322772: Clean up code after JDK-8322417 Message-ID: Hi all, This pull request contains a backport of [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772), commit [bfd23aea](https://github.com/openjdk/jdk17u-dev/commit/bfd23aeae1566b86c20bdcbecff58f216947612a) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. The commit being backported was authored by Christoph Langer on 9 Jan 2024 and was reviewed by Matthias Baesken. Thanks! ------------- Commit messages: - Backport bfd23aeae1566b86c20bdcbecff58f216947612a Changes: https://git.openjdk.org/jdk11u-dev/pull/2443/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2443&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322772 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2443.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2443/head:pull/2443 PR: https://git.openjdk.org/jdk11u-dev/pull/2443 From andrewlu at openjdk.org Tue Jan 9 06:31:48 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 9 Jan 2024 06:31:48 GMT Subject: [jdk11u-dev] RFR: 8276796: gc/TestSystemGC.java large pages subtest fails with ZGC Message-ID: I backport this for parity with 11.0.23-oracle. Backport for JDK-8269077 and JDK-8276796, for JDK-8269077, it's clean, as CMS test is remain in this file, only modify the '@test id=CMS', other added parts are clean. ------------- Commit messages: - Backport 91bb0d658bce010e74b248b56f0fa5b8a79e8802 Changes: https://git.openjdk.org/jdk11u-dev/pull/2442/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2442&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8276796 Stats: 22 lines in 1 file changed: 14 ins; 1 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2442.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2442/head:pull/2442 PR: https://git.openjdk.org/jdk11u-dev/pull/2442 From duke at openjdk.org Tue Jan 9 06:42:31 2024 From: duke at openjdk.org (Johny Jose) Date: Tue, 9 Jan 2024 06:42:31 GMT Subject: [jdk22u] RFR: 8322725: (tz) Update Timezone Data to 2023d Message-ID: Clean backport of https://github.com/openjdk/jdk/commit/2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc ------------- Commit messages: - Backport 745a2ad5c7c4c9e9210bff47493195348de3d21b Changes: https://git.openjdk.org/jdk22u/pull/13/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=13&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322725 Stats: 140 lines in 14 files changed: 94 ins; 15 del; 31 mod Patch: https://git.openjdk.org/jdk22u/pull/13.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/13/head:pull/13 PR: https://git.openjdk.org/jdk22u/pull/13 From andrewlu at openjdk.org Tue Jan 9 07:07:41 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 9 Jan 2024 07:07:41 GMT Subject: [jdk11u-dev] RFR: 8290909: MemoryPoolMBean/isUsageThresholdExceeded tests failed with "isUsageThresholdExceeded() returned false, and is still false, while threshold = MMMMMMM and used peak = NNNNNNN" Message-ID: <0svuggu9914StmJ6_y7VQwlbyVV688QalW7t7XAVMQw=.b9d69bab-3b39-4664-a216-32df34d44eeb@github.com> I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport 3601e30df794db122d8d04fb3c04868ccbaa0baf Changes: https://git.openjdk.org/jdk11u-dev/pull/2444/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2444&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290909 Stats: 19 lines in 1 file changed: 4 ins; 8 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2444.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2444/head:pull/2444 PR: https://git.openjdk.org/jdk11u-dev/pull/2444 From andrewlu at openjdk.org Tue Jan 9 07:18:08 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 9 Jan 2024 07:18:08 GMT Subject: [jdk11u-dev] RFR: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests Message-ID: <22joBDCR17whIWrLMhUL0dBw6mIEv-RrTO1X5mInBlA=.96fd78d8-14fd-4bb7-87b4-c98adbed1b34@github.com> I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport 732179ca84ee1dab6530255c33de7f35cab649c2 Changes: https://git.openjdk.org/jdk11u-dev/pull/2445/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2445&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306409 Stats: 615 lines in 6 files changed: 615 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2445.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2445/head:pull/2445 PR: https://git.openjdk.org/jdk11u-dev/pull/2445 From andrewlu at openjdk.org Tue Jan 9 07:34:21 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 9 Jan 2024 07:34:21 GMT Subject: [jdk11u-dev] RFR: 8306652: Open source AWT MenuItem related tests Message-ID: <56wlwXMvG4YtyOHRsTl3FJD6gWq1XvYFft3qHvKShoc=.f89b2fee-824d-48d7-813c-5ab56bf28c68@github.com> I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport ed1ebd242a4bb82a7074564ea96dc3d26b78f9e1 Changes: https://git.openjdk.org/jdk11u-dev/pull/2446/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2446&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306652 Stats: 326 lines in 4 files changed: 326 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2446.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2446/head:pull/2446 PR: https://git.openjdk.org/jdk11u-dev/pull/2446 From duke at openjdk.org Tue Jan 9 07:49:37 2024 From: duke at openjdk.org (duke) Date: Tue, 9 Jan 2024 07:49:37 GMT Subject: [jdk17u-dev] Withdrawn: 8300259: Add test coverage for processing of pending block files in signed JARs In-Reply-To: References: Message-ID: On Tue, 1 Aug 2023 20:40:06 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [c129ce46](https://github.com/openjdk/jdk/commit/c129ce4660e6c9b5365c8bf89fb916e2a7c28e98) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Eirik Bjorsnos on 6 Feb 2023 and was reviewed by Weijun Wang. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1634 From andrewlu at openjdk.org Tue Jan 9 07:51:00 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 9 Jan 2024 07:51:00 GMT Subject: [jdk11u-dev] RFR: 8306753: Open source several container AWT tests Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport b372f28ad4b7c1f46e0070a930911542d4d1a032 Changes: https://git.openjdk.org/jdk11u-dev/pull/2448/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2448&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306753 Stats: 814 lines in 4 files changed: 814 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2448.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2448/head:pull/2448 PR: https://git.openjdk.org/jdk11u-dev/pull/2448 From andrewlu at openjdk.org Tue Jan 9 07:51:08 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 9 Jan 2024 07:51:08 GMT Subject: [jdk11u-dev] RFR: 8306871: Open source more AWT Drag & Drop tests Message-ID: <2QAvi-HJ8DLLyovurcVNShQup5HT3zS1nFxcKjHIKcQ=.191aebfc-fb54-490a-b382-852aa345c79b@github.com> I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport b5a48277ab5b42c4b13db7ddb5418a17ada512ec Changes: https://git.openjdk.org/jdk11u-dev/pull/2447/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2447&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306871 Stats: 1915 lines in 6 files changed: 1915 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2447.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2447/head:pull/2447 PR: https://git.openjdk.org/jdk11u-dev/pull/2447 From mbaesken at openjdk.org Tue Jan 9 08:07:23 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 9 Jan 2024 08:07:23 GMT Subject: [jdk22u] Integrated: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 14:24:08 GMT, Matthias Baesken wrote: > 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output This pull request has now been integrated. Changeset: 136180b1 Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/136180b1bafafb83562549ddb97cd33b6b7b94b0 Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output Backport-of: a8e4229852fac703c6271aa8c5f94f67bea44902 ------------- PR: https://git.openjdk.org/jdk22u/pull/10 From andrewlu at openjdk.org Tue Jan 9 08:47:19 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 9 Jan 2024 08:47:19 GMT Subject: [jdk11u-dev] RFR: 8307381: Open Source JFrame, JIF related Swing Tests Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport 4386d42d31af9042121581cd3fd4d5a7cf8961e6 Changes: https://git.openjdk.org/jdk11u-dev/pull/2449/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2449&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307381 Stats: 354 lines in 6 files changed: 354 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2449.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2449/head:pull/2449 PR: https://git.openjdk.org/jdk11u-dev/pull/2449 From shade at openjdk.org Tue Jan 9 08:51:43 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 08:51:43 GMT Subject: [jdk21u-dev] RFR: 8318082: ConcurrentModificationException from IndexWriter [v2] In-Reply-To: References: Message-ID: <7mfH6slWmqP2bnwyZva_jvLAp_pWiMr3H3liJKTdGC8=.a1fec91c-cb62-4176-8861-8308f586a8ac@github.com> On Thu, 4 Jan 2024 09:58:40 GMT, Aleksey Shipilev wrote: >> Unclean backport to fix a customer-visible bug in Javadoc tool. The uncleanliness comes from the missing refactoring ([JDK-8309566](https://bugs.openjdk.org/browse/JDK-8309566), that looks unnecessary to backport. >> >> Maybe @jonathan-gibbons and @pavelrappo want to take a look. >> >> Additional testing: >> - [x] New test fails without the product fix, passes with it >> - [x] `jdk/javadoc` still passes > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8318082-cme-indexwriter > - Backport fc29a2e152310ed81bd1bb23e6f17d02f055a454 Thanks all! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/23#issuecomment-1882634392 From shade at openjdk.org Tue Jan 9 08:51:44 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 08:51:44 GMT Subject: [jdk21u-dev] Integrated: 8318082: ConcurrentModificationException from IndexWriter In-Reply-To: References: Message-ID: On Wed, 13 Dec 2023 18:17:06 GMT, Aleksey Shipilev wrote: > Unclean backport to fix a customer-visible bug in Javadoc tool. The uncleanliness comes from the missing refactoring ([JDK-8309566](https://bugs.openjdk.org/browse/JDK-8309566), that looks unnecessary to backport. > > Maybe @jonathan-gibbons and @pavelrappo want to take a look. > > Additional testing: > - [x] New test fails without the product fix, passes with it > - [x] `jdk/javadoc` still passes This pull request has now been integrated. Changeset: 1a9c7ec2 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/1a9c7ec2af95d53ca16519bcab8b79afe6d0c615 Stats: 240 lines in 9 files changed: 205 ins; 28 del; 7 mod 8318082: ConcurrentModificationException from IndexWriter Reviewed-by: prappo, simonis Backport-of: fc29a2e152310ed81bd1bb23e6f17d02f055a454 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/23 From shade at openjdk.org Tue Jan 9 08:53:29 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 08:53:29 GMT Subject: [jdk17u-dev] RFR: 8318078: ADLC: pass ASSERT and PRODUCT flags In-Reply-To: <8QTmSBUL7yHgxLt0S5A3ZWUcz28z5ET2VbAVyJxyRBQ=.91929890-0d30-4c35-b3b2-59b7bd0d74ea@github.com> References: <8QTmSBUL7yHgxLt0S5A3ZWUcz28z5ET2VbAVyJxyRBQ=.91929890-0d30-4c35-b3b2-59b7bd0d74ea@github.com> Message-ID: <4G9s1S263_RcbhQEiNptuG5gxUVjm4vTHOf71px-kdE=.7d501649-25a3-45b4-bc86-5546ea091a1c@github.com> On Mon, 11 Dec 2023 14:17:16 GMT, Aleksey Shipilev wrote: > Clean backport to make sure the asserts work in `.ad` files. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `hotspot:tier1` > - [ ] linux-aarch64-server-fastdebug, `tier1` > - [ ] linux-x86_64-server-fastdebug, `tier1` Not now, bot. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2034#issuecomment-1882639317 From wkemper at openjdk.org Tue Jan 9 08:54:31 2024 From: wkemper at openjdk.org (William Kemper) Date: Tue, 9 Jan 2024 08:54:31 GMT Subject: [jdk17u-dev] Integrated: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 19:27:09 GMT, William Kemper wrote: > 8323021: Shenandoah: Encountered reference count always attributed to first worker thread This pull request has now been integrated. Changeset: 002270c4 Author: William Kemper Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/002270c4bf2983d5b21d703a16f683f35d0b0cd6 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8323021: Shenandoah: Encountered reference count always attributed to first worker thread Backport-of: f0e2e4311b8cab160dc9e35f43e9ae5a145c5e23 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2105 From mbaesken at openjdk.org Tue Jan 9 08:59:29 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 9 Jan 2024 08:59:29 GMT Subject: [jdk22u] Integrated: 8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886 In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 09:23:29 GMT, Matthias Baesken wrote: > 8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886 This pull request has now been integrated. Changeset: beb35a84 Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/beb35a84ba8748ae6a1563813845cb269a953b5f Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod 8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886 Backport-of: 1230853343c38787c90820d19d0626f0c37540dc ------------- PR: https://git.openjdk.org/jdk22u/pull/8 From shade at openjdk.org Tue Jan 9 09:08:36 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 09:08:36 GMT Subject: [jdk21u-dev] Integrated: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 09:14:24 GMT, Aleksey Shipilev wrote: > Clean backport to fix 1.5 yrs old regression. Effectively reverts [JDK-8287349](https://bugs.openjdk.org/browse/JDK-8287349). > > Additional testing: > - [x] macos-aarch64-server-fastdebug: New test fails without a patch, passes with it > - [x] linux-aarch64-server-fastdebug, `tier{1,2,3}` This pull request has now been integrated. Changeset: e652bb72 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/e652bb72d05b8058032e9f525f3f225da82bc05c Stats: 149 lines in 2 files changed: 147 ins; 0 del; 2 mod 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate Reviewed-by: aph Backport-of: ade21a965f8a5fc889cd48bba76fad507bdeddf5 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/137 From wkemper at openjdk.org Tue Jan 9 09:12:30 2024 From: wkemper at openjdk.org (William Kemper) Date: Tue, 9 Jan 2024 09:12:30 GMT Subject: [jdk21u-dev] Integrated: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 19:18:55 GMT, William Kemper wrote: > 8323021: Shenandoah: Encountered reference count always attributed to first worker thread This pull request has now been integrated. Changeset: d44b5dc7 Author: William Kemper Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/d44b5dc7a634b08f27f9a3e71112607a12023f8b Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8323021: Shenandoah: Encountered reference count always attributed to first worker thread Backport-of: f0e2e4311b8cab160dc9e35f43e9ae5a145c5e23 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/134 From duke at openjdk.org Tue Jan 9 09:37:29 2024 From: duke at openjdk.org (Johny Jose) Date: Tue, 9 Jan 2024 09:37:29 GMT Subject: [jdk22u] Integrated: 8322725: (tz) Update Timezone Data to 2023d In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 06:26:22 GMT, Johny Jose wrote: > Clean backport of https://github.com/openjdk/jdk/commit/2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc This pull request has now been integrated. Changeset: 07df9e32 Author: Johny Jose URL: https://git.openjdk.org/jdk22u/commit/07df9e3243687245effa0d1218ad08f2891eefde Stats: 140 lines in 14 files changed: 94 ins; 15 del; 31 mod 8322725: (tz) Update Timezone Data to 2023d Reviewed-by: coffeys, naoto Backport-of: 2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc ------------- PR: https://git.openjdk.org/jdk22u/pull/13 From shade at openjdk.org Tue Jan 9 10:07:43 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 10:07:43 GMT Subject: [jdk21u-dev] RFR: 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...] Message-ID: Clean backport to fix a corner case in javac. Additional testing: - [x] macos-aarch64-server-fastdebug, new regression test fails without the patch, passes with it - [x] macos-aarch64-server-fastdebug, `langtools_all` pass ------------- Commit messages: - Backport 03c4595173d564df97aa4f2b3156adcd4be379fa Changes: https://git.openjdk.org/jdk21u-dev/pull/146/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=146&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321164 Stats: 134 lines in 2 files changed: 124 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/146.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/146/head:pull/146 PR: https://git.openjdk.org/jdk21u-dev/pull/146 From aph at openjdk.org Tue Jan 9 10:42:37 2024 From: aph at openjdk.org (Andrew Haley) Date: Tue, 9 Jan 2024 10:42:37 GMT Subject: [jdk11u-dev] RFR: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2 [v2] In-Reply-To: <0dBbEQspU0YzRIlNR73gHPiB8djK8a3SO4hwgjGcqJ8=.8bb1a2ef-5396-47cf-81dc-dcbdcd3c4a32@github.com> References: <0dBbEQspU0YzRIlNR73gHPiB8djK8a3SO4hwgjGcqJ8=.8bb1a2ef-5396-47cf-81dc-dcbdcd3c4a32@github.com> Message-ID: On Wed, 3 Jan 2024 09:55:23 GMT, Liang Mao wrote: >> Backport of JDK-8280007. The change should be enabled in JDK11 better performance on Neoverse V1/N1/N2. It is quite safe for existing in upstream and 17u for years. >> >> Additional testing: aarch64 server ARM Neoverse N2 release/fastdebug tier1 > > Liang Mao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'jdk11dev/master' into backport-mmyxym-f823bed0 > - Backport f823bed043dc38d838baaf8c2024ef24b8a50e9b OK. On further contemplation, this falls within the scope of a change intended to keep the JDK working well as the world moves on. It doesn't set any precedents for other performance backports. ------------- Marked as reviewed by aph (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2425#pullrequestreview-1810877415 From fthevenet at openjdk.org Tue Jan 9 11:08:30 2024 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Tue, 9 Jan 2024 11:08:30 GMT Subject: [jdk22u] Integrated: 8321374: Add a configure option to explicitly set CompanyName property in VersionInfo resource for Windows exe/dll In-Reply-To: References: Message-ID: On Mon, 18 Dec 2023 10:58:34 GMT, Frederic Thevenet wrote: > Hi all, > > This pull request contains a backport of commit [05f95093](https://github.com/openjdk/jdk/commit/05f950934ee720c82e9b62dd8d31e13bab7775da) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Frederic Thevenet on 8 Dec 2023 and was reviewed by Erik Joelsson and Magnus Ihse Bursie. > > Thanks! This pull request has now been integrated. Changeset: 085dccd2 Author: Frederic Thevenet Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk22u/commit/085dccd28b9ac4fe9278f61e3e99c80ede01d947 Stats: 11 lines in 3 files changed: 10 ins; 0 del; 1 mod 8321374: Add a configure option to explicitly set CompanyName property in VersionInfo resource for Windows exe/dll Backport-of: 05f950934ee720c82e9b62dd8d31e13bab7775da ------------- PR: https://git.openjdk.org/jdk22u/pull/3 From shade at openjdk.org Tue Jan 9 11:12:37 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 11:12:37 GMT Subject: [jdk17u-dev] RFR: 8296812: sprintf is deprecated in Xcode 14 In-Reply-To: <7XLC13Ldl8cqJVuWXdUwLON6ExwW3MKry9fWgia0QXg=.6cc0be3c-cd35-4ac2-9263-4344f4c08737@github.com> References: <7XLC13Ldl8cqJVuWXdUwLON6ExwW3MKry9fWgia0QXg=.6cc0be3c-cd35-4ac2-9263-4344f4c08737@github.com> Message-ID: On Fri, 27 Oct 2023 16:09:10 GMT, Elif Aslan wrote: > https://developer.apple.com/news/?id=y5mjxqmn > > Starting November 1, 2023, the Apple notary service will no longer accept uploads from altool or Xcode 13 or earlier. > > > This is not a clean backport and this pull request contains a backport of the closed bug [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) commit [f1522c648c2e](https://github.com/openjdk/jdk/commit/478ef389dc3767edfbe21d10a7f7f1522c648c2e). > > Conflicts includes: > > - whitespace conflicts on src/hotspot/share/utilities/utf8.cpp > > - missing src/hotspot/share/jfr/support/jfrSymbolTable.cpp > > - context difference on src/hotspot/cpu/aarch64/vm_version_aarch64.cpp > > The sprintf is deprecated in Xcode 14 and the use of it causing building failure. The build could pass if warnings are disabled for codes that use sprintf method. For the long run, the sprintf could be replaced with snprintf. This patch is trying to check if snprintf could be used. > > Testing: > > GHA tested. > Successfull tier1,tier2,tier3 and jck tests for linux platforms. > Successfull tier1 and tier2 for windows. This looks generally fine, but I think there is an accidental change that crept in. Otherwise the backport looks similar to what mainline does. I see there are many linked issues to this bug, but all of them look like dealing with other places, and they should probably be considered for future backports. src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 235: > 233: int buf_used_len = os::snprintf_checked(buf, sizeof(buf), "0x%02x:0x%x:0x%03x:%d", _cpu, _variant, _model, _revision); > 234: if (_model2) os::snprintf_checked(buf + buf_used_len, sizeof(buf) - buf_used_len, "(0x%03x)", _model2); > 235: #define ADD_FEATURE_IF_SUPPORTED(id, name, bit) if (_features & CPU_##id) strcat(buf, ", " #name); Original commit does not add `#` to `#name`. ------------- Changes requested by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1930#pullrequestreview-1809767253 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1930#discussion_r1445125907 From goetz at openjdk.org Tue Jan 9 11:25:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 9 Jan 2024 11:25:29 GMT Subject: [jdk22u] Withdrawn: 8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781 In-Reply-To: References: Message-ID: On Fri, 22 Dec 2023 09:51:29 GMT, Goetz Lindenmaier wrote: > I backport this as we see these failing in 22, too. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk22u/pull/6 From shade at openjdk.org Tue Jan 9 11:50:41 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 11:50:41 GMT Subject: [jdk21u-dev] RFR: 8320888: Shenandoah: Enable ShenandoahVerifyOptoBarriers in debug builds Message-ID: Clean backport to improve Shenandoah maintainability. ------------- Commit messages: - Backport c86431767e6802317dc2be6221a5d0990b976ddc Changes: https://git.openjdk.org/jdk21u-dev/pull/148/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=148&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320888 Stats: 39 lines in 4 files changed: 0 ins; 37 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/148.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/148/head:pull/148 PR: https://git.openjdk.org/jdk21u-dev/pull/148 From shade at openjdk.org Tue Jan 9 11:51:33 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 11:51:33 GMT Subject: [jdk21u-dev] RFR: 8320877: Shenandoah: Remove ShenandoahUnloadClassesFrequency support Message-ID: Clean backport to improve Shenandoah maintainability. ------------- Commit messages: - Backport b65ccff357e2e294b027f693ceb3d25410236a6b Changes: https://git.openjdk.org/jdk21u-dev/pull/147/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=147&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320877 Stats: 37 lines in 5 files changed: 0 ins; 34 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/147.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/147/head:pull/147 PR: https://git.openjdk.org/jdk21u-dev/pull/147 From shade at openjdk.org Tue Jan 9 11:54:44 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 11:54:44 GMT Subject: [jdk17u-dev] RFR: 8320877: Shenandoah: Remove ShenandoahUnloadClassesFrequency support Message-ID: Clean backport to improve Shenandoah maintainability. ------------- Commit messages: - Backport b65ccff357e2e294b027f693ceb3d25410236a6b Changes: https://git.openjdk.org/jdk17u-dev/pull/2115/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2115&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320877 Stats: 37 lines in 5 files changed: 0 ins; 34 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2115.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2115/head:pull/2115 PR: https://git.openjdk.org/jdk17u-dev/pull/2115 From shade at openjdk.org Tue Jan 9 11:55:45 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 11:55:45 GMT Subject: [jdk21u-dev] RFR: 8321269: Require platforms to define DEFAULT_CACHE_LINE_SIZE Message-ID: Clean backport to improve platform support. Unblocks future backports that rely on default cache line size. ------------- Commit messages: - Backport a56286f7ad9a8110026f48eb45f1d7a273b2f9fb Changes: https://git.openjdk.org/jdk21u-dev/pull/150/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=150&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321269 Stats: 7 lines in 4 files changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/150.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/150/head:pull/150 PR: https://git.openjdk.org/jdk21u-dev/pull/150 From shade at openjdk.org Tue Jan 9 11:56:01 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 11:56:01 GMT Subject: [jdk21u-dev] RFR: 8320907: Shenandoah: Remove ShenandoahSelfFixing flag Message-ID: Clean backport to improve Shenandoah reliability and maintainability. ------------- Commit messages: - Backport 43c7f6a673c2fa0b4dbec232e92b621619a98246 Changes: https://git.openjdk.org/jdk21u-dev/pull/149/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=149&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320907 Stats: 7 lines in 3 files changed: 0 ins; 5 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/149.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/149/head:pull/149 PR: https://git.openjdk.org/jdk21u-dev/pull/149 From shade at openjdk.org Tue Jan 9 12:04:46 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 12:04:46 GMT Subject: [jdk22u] RFR: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination Message-ID: Clean backport for trivial little inefficiency. ------------- Commit messages: - Backport eb9e754b3a439cc3ce36c2c9393bc8b250343844 Changes: https://git.openjdk.org/jdk22u/pull/14/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=14&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323065 Stats: 4 lines in 1 file changed: 3 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/14.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/14/head:pull/14 PR: https://git.openjdk.org/jdk22u/pull/14 From goetz at openjdk.org Tue Jan 9 14:36:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 9 Jan 2024 14:36:25 GMT Subject: [jdk21u-dev] RFR: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize [v3] In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 03:04:39 GMT, yaqsun wrote: >> Patch can be applied cleanly. >> And test have been locally verified to pass. > > yaqsun has updated the pull request incrementally with one additional commit since the last revision: > > del temporary file test.txt Hi, your approval request is not complete. Please list reason, risk, testing and whether the backport was clean. See also https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix "Example Fix Request comment". Removing label in the meantime. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/126#issuecomment-1883160069 From goetz at openjdk.org Tue Jan 9 14:46:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 9 Jan 2024 14:46:25 GMT Subject: [jdk21u-dev] RFR: 8322512: StringBuffer.repeat does not work correctly after toString() was called In-Reply-To: References: Message-ID: <_Tcc-iXIdFWgPZ1Tjok9xe6IaJs0-qRYNuIma2-hzt4=.68a0f8a0-4d4f-4b96-b771-abce03ba21a0@github.com> On Mon, 8 Jan 2024 16:18:11 GMT, Aleksey Shipilev wrote: > Clean backport to fix JDK 21 feature misbehavior. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [ ] GHA (includes some Repeat tests) @JimLaskey, why did you want to close this issue? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/143#issuecomment-1883179750 From goetz at openjdk.org Tue Jan 9 15:02:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 9 Jan 2024 15:02:54 GMT Subject: [jdk11u-dev] RFR: 8259801: Enable XML Signature secure validation mode by default [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.23-oracle. > > I resolved the Copyright in the test, will mark clean. > > I have to check for the backport CSR. > > Update: CSR available now: https://bugs.openjdk.org/browse/JDK-8323287 Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into goetz_backport_8259801 - Backport baf46bac41f11c01691c4d4c77b24f76fedb5926 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2426/files - new: https://git.openjdk.org/jdk11u-dev/pull/2426/files/f903b230..b629bc45 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2426&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2426&range=00-01 Stats: 800 lines in 31 files changed: 426 ins; 27 del; 347 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2426.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2426/head:pull/2426 PR: https://git.openjdk.org/jdk11u-dev/pull/2426 From goetz at openjdk.org Tue Jan 9 15:06:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 9 Jan 2024 15:06:30 GMT Subject: [jdk17u-dev] RFR: 8272853: improve `JavadocTester.runTests` In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 13:59:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. > > Resolved one import, probably recognized clean. Thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2111#issuecomment-1883217783 From robm at openjdk.org Tue Jan 9 15:11:30 2024 From: robm at openjdk.org (Rob McKenna) Date: Tue, 9 Jan 2024 15:11:30 GMT Subject: [jdk22u] RFR: Merge jdk22:master Message-ID: merge ------------- Commit messages: - Merge - 8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781 - 8322532: JShell : Unnamed variable issue - 8322142: JFR: Periodic tasks aren't orphaned between recordings - 8322489: 22-b27: Up to 7% regression in all Footprint3-*-G1/ZGC - 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate - 8319948: jcmd man page needs to be updated - 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used - 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index - 8321582: yield .class not parsed correctly. - ... and 8 more: https://git.openjdk.org/jdk22u/compare/085dccd2...50926960 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk22u/pull/15/files Stats: 1831 lines in 88 files changed: 1086 ins; 410 del; 335 mod Patch: https://git.openjdk.org/jdk22u/pull/15.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/15/head:pull/15 PR: https://git.openjdk.org/jdk22u/pull/15 From jlaskey at openjdk.org Tue Jan 9 15:15:26 2024 From: jlaskey at openjdk.org (Jim Laskey) Date: Tue, 9 Jan 2024 15:15:26 GMT Subject: [jdk21u-dev] RFR: 8322512: StringBuffer.repeat does not work correctly after toString() was called In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 16:18:11 GMT, Aleksey Shipilev wrote: > Clean backport to fix JDK 21 feature misbehavior. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [ ] GHA (includes some Repeat tests) It was a mistake. I was trying to close my own pr because Alexsey took it over and I was in the wrong window. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/143#issuecomment-1883231572 From goetz at openjdk.org Tue Jan 9 15:21:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 9 Jan 2024 15:21:39 GMT Subject: [jdk21u-dev] Integrated: 8296631: NSS tests failing on OL9 linux-aarch64 hosts In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 08:18:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: c21a12d4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/c21a12d44165a907b1875e02f1676aa7076f062b Stats: 43 lines in 11 files changed: 28 ins; 2 del; 13 mod 8296631: NSS tests failing on OL9 linux-aarch64 hosts Reviewed-by: aph Backport-of: 6e1aacdfba5a32f7b071eea8039888d275827e83 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/114 From robm at openjdk.org Tue Jan 9 15:22:07 2024 From: robm at openjdk.org (Rob McKenna) Date: Tue, 9 Jan 2024 15:22:07 GMT Subject: [jdk22u] Integrated: Merge jdk22:master In-Reply-To: References: Message-ID: <1T4_AdOdxRRXN4CrTEKtxhNfYo_OMtJ5rgV6-XupvZQ=.7da85b0d-3dc5-4cd4-adc2-90912d79d38c@github.com> On Tue, 9 Jan 2024 15:02:53 GMT, Rob McKenna wrote: > merge This pull request has now been integrated. Changeset: 648ebeaa Author: Rob McKenna URL: https://git.openjdk.org/jdk22u/commit/648ebeaaf72a1e2d7105015c43e19bb4e4128979 Stats: 1831 lines in 88 files changed: 1086 ins; 410 del; 335 mod Merge ------------- PR: https://git.openjdk.org/jdk22u/pull/15 From robm at openjdk.org Tue Jan 9 15:22:06 2024 From: robm at openjdk.org (Rob McKenna) Date: Tue, 9 Jan 2024 15:22:06 GMT Subject: [jdk22u] RFR: Merge jdk22:master [v2] In-Reply-To: References: Message-ID: > merge Rob McKenna has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision: - Merge - 8321374: Add a configure option to explicitly set CompanyName property in VersionInfo resource for Windows exe/dll Backport-of: 05f950934ee720c82e9b62dd8d31e13bab7775da - 8322725: (tz) Update Timezone Data to 2023d Reviewed-by: coffeys, naoto Backport-of: 2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc - 8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886 Backport-of: 1230853343c38787c90820d19d0626f0c37540dc - 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output Backport-of: a8e4229852fac703c6271aa8c5f94f67bea44902 - 8322417: Console read line with zero out should zero out when throwing exception 8322772: Clean up code after JDK-8322417 Reviewed-by: mbaesken Backport-of: 2f917bff5cbb71dccd70960f563ca1a05d109fda - Merge - 8322092: Bump version numbers for 22.0.1 Reviewed-by: coffeys ------------- Changes: - all: https://git.openjdk.org/jdk22u/pull/15/files - new: https://git.openjdk.org/jdk22u/pull/15/files/50926960..50926960 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk22u&pr=15&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk22u&pr=15&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/15.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/15/head:pull/15 PR: https://git.openjdk.org/jdk22u/pull/15 From goetz at openjdk.org Tue Jan 9 15:35:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 9 Jan 2024 15:35:31 GMT Subject: [jdk21u-dev] Integrated: 8210410: Refactor java.util.Currency:i18n shell tests to plain java tests In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 18:08:48 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. > > Note: this was a clean backport. Obviously the bot's don't recognize this. If they still don't manage after pushing and merging the predecessor changes, I will mark it clean. This pull request has now been integrated. Changeset: 772ac178 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/772ac17887b11abf8d1769b4abd44346d01aa0ec Stats: 301 lines in 2 files changed: 157 ins; 144 del; 0 mod 8210410: Refactor java.util.Currency:i18n shell tests to plain java tests Backport-of: 2584bf87aef66744a8e586805735cded0d2f98f1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/130 From goetz at openjdk.org Tue Jan 9 15:35:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 9 Jan 2024 15:35:49 GMT Subject: [jdk11u-dev] Integrated: 8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 14:47:51 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: c759b2e5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/c759b2e569602e0756b1c59d3ea98e0aee13cf7b Stats: 85 lines in 2 files changed: 78 ins; 2 del; 5 mod 8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication Backport-of: a6ef655b6f98fc2e1c4aa04525b91485b372aaff ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2428 From ashi at openjdk.org Tue Jan 9 15:35:56 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 9 Jan 2024 15:35:56 GMT Subject: [jdk11u-dev] Integrated: 8313643: Update HarfBuzz to 8.2.2 In-Reply-To: <8dPJK420ndqBRy34vAIWdH6MZL4sUKxsDSPirEeuRik=.0e1c5178-6dae-4225-97d1-24e6e4b02cfb@github.com> References: <8dPJK420ndqBRy34vAIWdH6MZL4sUKxsDSPirEeuRik=.0e1c5178-6dae-4225-97d1-24e6e4b02cfb@github.com> Message-ID: On Fri, 15 Dec 2023 08:32:10 GMT, Amos Shi wrote: > Backport of [JDK-8313643](https://bugs.openjdk.org/browse/JDK-8313643) > > Unclean Backport: > - `src/java.desktop/share/native/libharfbuzz/hb-subset.cc` > - Manually merged the code of bellow; > - This file change could be considered as `Clean` > > > @@ -43,21 +43,19 @@ > #include "OT/Color/sbix/sbix.hh" > #include "hb-ot-os2-table.hh" > #include "hb-ot-post-table.hh" > - > -#if !defined(AIX) || defined(AIX_XLC_GE_17) > #include "hb-ot-post-table-v2subset.hh" > -#endif > - > #include "hb-ot-cff1-table.hh" > #include "hb-ot-cff2-table.hh" > #include "hb-ot-vorg-table.hh" > #include "hb-ot-name-table.hh" > #include "hb-ot-layout-gsub-table.hh" > #include "hb-ot-layout-gpos-table.hh" > +#include "hb-ot-var-avar-table.hh" > #include "hb-ot-var-cvar-table.hh" > #include "hb-ot-var-fvar-table.hh" > #include "hb-ot-var-gvar-table.hh" > #include "hb-ot-var-hvar-table.hh" > +#include "hb-ot-var-mvar-table.hh" > #include "hb-ot-math-table.hh" > #include "hb-ot-stat-table.hh" > #include "hb-repacker.hh" > > > - `make/modules/java.desktop/lib/Awt2dLibraries.gmk` > - Manually merged the code of bellow to the file `make/lib/Awt2dLibraries.gmk`. > - This file change could be considered as `Clean` > > > @@ -495,6 +495,11 @@ > # hb-ft.cc is not presently needed, and requires freetype 2.4.2 or later. > LIBFONTMANAGER_EXCLUDE_FILES += libharfbuzz/hb-ft.cc > > + # list of disabled warnings and the compilers for which it was specifically added. > + # array-bounds -> GCC 12 on Alpine Linux > + # parentheses -> GCC 6 > + # range-loop-analysis -> clang on Xcode12 > + > HARFBUZZ_DISABLED_WARNINGS_gcc := missing-field-initializers strict-aliasing \ > unused-result array-bounds parentheses > # noexcept-type required for GCC 7 builds. Not required for GCC 8+. > > > Tests > - PR: All checks have passed > - SAP nightlies passed on `2023-12-21,22,23,24` This pull request has now been integrated. Changeset: c342a032 Author: Amos Shi Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/c342a032be48ea506a95963b3a44a18e611aebf3 Stats: 12812 lines in 179 files changed: 7127 ins; 1316 del; 4369 mod 8313643: Update HarfBuzz to 8.2.2 Reviewed-by: mbaesken Backport-of: 0bc91f60d28567f888eee948dbb156c1405bbeeb ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2398 From goetz at openjdk.org Tue Jan 9 15:43:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 9 Jan 2024 15:43:31 GMT Subject: [jdk11u-dev] Integrated: 8321215: Incorrect x86 instruction encoding for VSIB addressing mode In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 12:16:56 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.23-oracle. > > I had to resolve due to context. This pull request has now been integrated. Changeset: 666bf87e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/666bf87ed378c544450e24092bf68a49369d5fb6 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8321215: Incorrect x86 instruction encoding for VSIB addressing mode Reviewed-by: shade, sviswanathan Backport-of: 027b5dbb6a299e49d3dcbe67d529d6edc67f16d9 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2427 From shade at openjdk.org Tue Jan 9 16:00:05 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 16:00:05 GMT Subject: [jdk21u-dev] RFR: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 15:30:51 GMT, Aleksey Shipilev wrote: > Clean backport to eliminate a trivial inefficiency in release builds. > ?? @shipilev could not find any commit with hash `eb9e754b3a439cc3ce36c2c9393bc8b250343844`. Please update the title with the hash for an existing commit. Bot is mistaken, here it is: https://github.com/openjdk/jdk/commit/eb9e754b3a439cc3ce36c2c9393bc8b250343844 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/151#issuecomment-1883306543 From shade at openjdk.org Tue Jan 9 16:00:05 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 16:00:05 GMT Subject: [jdk21u-dev] RFR: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination Message-ID: Clean backport to eliminate a trivial inefficiency in release builds. ------------- Commit messages: - Backport eb9e754b3a439cc3ce36c2c9393bc8b250343844 Changes: https://git.openjdk.org/jdk21u-dev/pull/151/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=151&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323065 Stats: 4 lines in 1 file changed: 3 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/151.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/151/head:pull/151 PR: https://git.openjdk.org/jdk21u-dev/pull/151 From duke at openjdk.org Tue Jan 9 16:03:32 2024 From: duke at openjdk.org (Weibing Xiao) Date: Tue, 9 Jan 2024 16:03:32 GMT Subject: [jdk22u] Integrated: 8321480: ISO 4217 Amendment 176 Update In-Reply-To: <4C_Qv3zaTyn1iYIiCTWvrlz0bCtz0kmC_BgnpB_h5Uw=.38524cde-b1cf-4e34-8ef4-4634cbf66e1a@github.com> References: <4C_Qv3zaTyn1iYIiCTWvrlz0bCtz0kmC_BgnpB_h5Uw=.38524cde-b1cf-4e34-8ef4-4634cbf66e1a@github.com> Message-ID: On Fri, 15 Dec 2023 19:07:18 GMT, Weibing Xiao wrote: > FIX REQUEST > > It is ISO 4217 Amendment 176 Update. It is a mandatory change.
> The patch was applied cleanly. It has a minimum risk to push this to the release. This pull request has now been integrated. Changeset: 9e1e6e15 Author: Weibing Xiao Committer: Sean Coffey URL: https://git.openjdk.org/jdk22u/commit/9e1e6e156c37c69332bdc0f16ba6ae019af85f6c Stats: 43 lines in 5 files changed: 10 ins; 0 del; 33 mod 8321480: ISO 4217 Amendment 176 Update Backport-of: 8b24851b9d3619c41c7a6cdb9193ed26a9b732dc ------------- PR: https://git.openjdk.org/jdk22u/pull/2 From shade at openjdk.org Tue Jan 9 16:27:27 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 16:27:27 GMT Subject: [jdk21u-dev] Integrated: 8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects In-Reply-To: References: Message-ID: <4pE_wFdwFfBk3ca6xbXJgNiVKfYX-eBcNr3XLyxxp_w=.ce28e617-f8f0-4c0e-bec7-74575bfd8e1c@github.com> On Mon, 8 Jan 2024 09:32:06 GMT, Aleksey Shipilev wrote: > Clean backport to fix Generational ZGC. > > Picking this up for 21u, @fisk -- tell me if that is not a good idea. > > Additional testing: > - [x] Linux x86-64 server fastdebug, `hotspot_gc` with `-XX:+UseZGC -XX:+ZGenerational` This pull request has now been integrated. Changeset: 36c21207 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/36c21207f5a461929b48970f2c08b2a23c37a5a3 Stats: 31 lines in 3 files changed: 26 ins; 1 del; 4 mod 8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects Reviewed-by: eosterlund Backport-of: be49dabd0d7e1cd270399849e5353bf33361c4c5 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/138 From dchuyko at openjdk.org Tue Jan 9 16:29:46 2024 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Tue, 9 Jan 2024 16:29:46 GMT Subject: [jdk17u-dev] RFR: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate Message-ID: This changes reverts https://bugs.openjdk.org/browse/JDK-8293671 backport due to the correctness problems in the initial change. Original reverting patch applies cleanly with the only exception of copyright update (already 2024) which has been excluded. The new test fails on current 17u aarch64 and doesn't fail with the change applied. Additional testing: jtreg tier1,2 (aarch64 fastdebug) ------------- Commit messages: - Backport ade21a965f8a5fc889cd48bba76fad507bdeddf5 Changes: https://git.openjdk.org/jdk17u-dev/pull/2117/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2117&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310844 Stats: 148 lines in 2 files changed: 147 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2117.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2117/head:pull/2117 PR: https://git.openjdk.org/jdk17u-dev/pull/2117 From ogillespie at openjdk.org Tue Jan 9 16:52:42 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 9 Jan 2024 16:52:42 GMT Subject: [jdk21u-dev] RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn Message-ID: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> Hi all, This pull request contains a backport of commit [d23f4f12](https://github.com/openjdk/jdk/commit/d23f4f12adf1ea26b8c340efe2c3854e50b68301) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Oli Gillespie on 4 Dec 2023 and was reviewed by Coleen Phillimore, Kim Barrett and Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport d23f4f12adf1ea26b8c340efe2c3854e50b68301 Changes: https://git.openjdk.org/jdk21u-dev/pull/154/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=154&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315559 Stats: 134 lines in 4 files changed: 125 ins; 1 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/154.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/154/head:pull/154 PR: https://git.openjdk.org/jdk21u-dev/pull/154 From shade at openjdk.org Tue Jan 9 17:24:35 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 9 Jan 2024 17:24:35 GMT Subject: [jdk21u-dev] Integrated: 8316132: CDSProtectionDomain::get_shared_protection_domain should check for exception In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 18:22:49 GMT, Aleksey Shipilev wrote: > Clean backport to propagate CDS exceptions better. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `tier{1,2,3}` This pull request has now been integrated. Changeset: 9406448c Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/9406448ce21e3ccd48335bcc475fc6ebfe0ba0b7 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8316132: CDSProtectionDomain::get_shared_protection_domain should check for exception Backport-of: 11394828b32941a69d549bae613ab4c3afb713d5 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/144 From dlutker at openjdk.org Tue Jan 9 17:27:28 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Tue, 9 Jan 2024 17:27:28 GMT Subject: [jdk21u-dev] Integrated: 8322725: (tz) Update Timezone Data to 2023d In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 17:44:11 GMT, Dan Lutker wrote: > Clean backport of tzdata2023d. > > `make test TEST="test/jdk/java/util/TimeZone test/jdk/java/time/test test/jdk/sun/util/resources test/jdk/sun/text/resources test/jdk/sun/util/calendar"` is passing locally. This pull request has now been integrated. Changeset: d5b8c283 Author: Dan Lutker Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/d5b8c283ba6d58eb4c3af9709c7c3ad60dc11366 Stats: 140 lines in 14 files changed: 94 ins; 15 del; 31 mod 8322725: (tz) Update Timezone Data to 2023d Backport-of: 2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/133 From dlutker at openjdk.org Tue Jan 9 17:27:29 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Tue, 9 Jan 2024 17:27:29 GMT Subject: [jdk17u-dev] Integrated: 8322725: (tz) Update Timezone Data to 2023d In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 17:50:45 GMT, Dan Lutker wrote: > Clean backport of tzdata2023d This pull request has now been integrated. Changeset: 26b55978 Author: Dan Lutker Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/26b559780da02e3b695a3e3e00a03c32f2ed6264 Stats: 140 lines in 14 files changed: 94 ins; 15 del; 31 mod 8322725: (tz) Update Timezone Data to 2023d Reviewed-by: shade Backport-of: 2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2104 From dlutker at openjdk.org Tue Jan 9 17:27:34 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Tue, 9 Jan 2024 17:27:34 GMT Subject: [jdk11u-dev] Integrated: 8322725: (tz) Update Timezone Data to 2023d In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 17:56:32 GMT, Dan Lutker wrote: > Clean backport of tadata2023d. This pull request has now been integrated. Changeset: 58b154e9 Author: Dan Lutker Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk11u-dev/commit/58b154e971ed7c751415b68e5de989263446ff9a Stats: 140 lines in 14 files changed: 94 ins; 15 del; 31 mod 8322725: (tz) Update Timezone Data to 2023d Reviewed-by: shade Backport-of: 2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2435 From aph at openjdk.org Tue Jan 9 17:28:34 2024 From: aph at openjdk.org (Andrew Haley) Date: Tue, 9 Jan 2024 17:28:34 GMT Subject: [jdk17u-dev] RFR: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 15:10:52 GMT, Dmitry Chuyko wrote: > This changes reverts https://bugs.openjdk.org/browse/JDK-8293671 backport due to the correctness problems in the initial change. > > Original reverting patch applies cleanly with the only exception of copyright update (already 2024) which has been excluded. > > The new test fails on current 17u aarch64 and doesn't fail with the change applied. > > Additional testing: jtreg tier1,2 (linux-aarch64 fastdebug) Marked as reviewed by aph (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2117#pullrequestreview-1811657131 From duke at openjdk.org Tue Jan 9 17:47:27 2024 From: duke at openjdk.org (Elif Aslan) Date: Tue, 9 Jan 2024 17:47:27 GMT Subject: [jdk21u-dev] RFR: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 19:21:38 GMT, Elif Aslan wrote: > Clean backport to enable parallelism in vmTestbase/nsk/stress/jni tests > > Tested with GHA I see jdk21u-fix-yes in the jbs bug ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/135#issuecomment-1883511638 From duke at openjdk.org Tue Jan 9 17:49:27 2024 From: duke at openjdk.org (Elif Aslan) Date: Tue, 9 Jan 2024 17:49:27 GMT Subject: [jdk21u-dev] RFR: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 19:22:09 GMT, Elif Aslan wrote: > Clean backport to enable parallelism in vmTestbase/nsk/stress/threads tests. > > Tested with GHA. I see [jdk21u-fix-yes] label in the jbs issue ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/136#issuecomment-1883513202 From goetz at openjdk.org Tue Jan 9 19:11:03 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 9 Jan 2024 19:11:03 GMT Subject: [jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 Message-ID: I backport this for parity with 17.0.11-oracle. This is a minimal version that only removes the strings from the interface, as well as the comment. Removing these is explicitly stated in the CSR. The change keeps the EdDSA implementation. As I understand, 17 supports EdDSA in general, it was just not included for XML when 17 was released. https://bugs.openjdk.org/browse/JDK-8305972 ------------- Commit messages: - Add new files, forgotten in first commit - Remove Strings as proposed in CSR - Backport f0aebc8141de5a50c88658a40caa01967a9afc53 Changes: https://git.openjdk.org/jdk17u-dev/pull/2116/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2116&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305972 Stats: 1423 lines in 39 files changed: 1171 ins; 142 del; 110 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2116.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2116/head:pull/2116 PR: https://git.openjdk.org/jdk17u-dev/pull/2116 From clanger at openjdk.org Tue Jan 9 21:47:35 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 9 Jan 2024 21:47:35 GMT Subject: [jdk11u-dev] Integrated: 8322772: Clean up code after JDK-8322417 In-Reply-To: References: Message-ID: <4VbPVhVAKKfPj9UjAVzQ_vlgx_50RW3JiqDrHJH8lXU=.293f420f-69c6-4e4c-a9ac-1c1edddbb7c5@github.com> On Tue, 9 Jan 2024 06:24:37 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772), commit [bfd23aea](https://github.com/openjdk/jdk17u-dev/commit/bfd23aeae1566b86c20bdcbecff58f216947612a) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > > The commit being backported was authored by Christoph Langer on 9 Jan 2024 and was reviewed by Matthias Baesken. > > Thanks! This pull request has now been integrated. Changeset: e3a18faf Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/e3a18fafec16dbee4f67cc35a35ec404babbb9a4 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8322772: Clean up code after JDK-8322417 Backport-of: bfd23aeae1566b86c20bdcbecff58f216947612a ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2443 From itakiguchi at openjdk.org Wed Jan 10 01:09:34 2024 From: itakiguchi at openjdk.org (Ichiroh Takiguchi) Date: Wed, 10 Jan 2024 01:09:34 GMT Subject: [jdk21u-dev] Integrated: 6928542: Chinese characters in RTF are not decoded In-Reply-To: <854gYSeslkxeIUzJyBALU5IEtUOr9bZsdr3yNdBmsOM=.2a6244a7-fba6-4510-9882-2a47e874c934@github.com> References: <854gYSeslkxeIUzJyBALU5IEtUOr9bZsdr3yNdBmsOM=.2a6244a7-fba6-4510-9882-2a47e874c934@github.com> Message-ID: On Sat, 16 Dec 2023 01:03:14 GMT, Ichiroh Takiguchi wrote: > Backport [JDK-6928542](https://bugs.openjdk.org/browse/JDK-6928542) Chinese characters in RTF are not decoded > Cherry-pick worked fine as expected. This pull request has now been integrated. Changeset: a1d7bcfd Author: Ichiroh Takiguchi URL: https://git.openjdk.org/jdk21u-dev/commit/a1d7bcfd0754ed2748d08a9d55f90a2d73f2a4af Stats: 286 lines in 3 files changed: 282 ins; 0 del; 4 mod 6928542: Chinese characters in RTF are not decoded Backport-of: a26f7c03c72e4efe6d3219d294294c554aebc631 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/46 From serb at openjdk.org Wed Jan 10 01:09:54 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 10 Jan 2024 01:09:54 GMT Subject: [jdk21u-dev] RFR: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA Message-ID: Hi all, This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/aba19334eaeb46d37169cddeef929b13e050a60e from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 9 Jan 2024 and was reviewed by Philip Race. Thanks! ------------- Commit messages: - Backport aba19334eaeb46d37169cddeef929b13e050a60e Changes: https://git.openjdk.org/jdk21u-dev/pull/156/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=156&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323210 Stats: 8 lines in 2 files changed: 5 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/156.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/156/head:pull/156 PR: https://git.openjdk.org/jdk21u-dev/pull/156 From itakiguchi at openjdk.org Wed Jan 10 01:11:41 2024 From: itakiguchi at openjdk.org (Ichiroh Takiguchi) Date: Wed, 10 Jan 2024 01:11:41 GMT Subject: [jdk11u-dev] Integrated: 6928542: Chinese characters in RTF are not decoded In-Reply-To: References: Message-ID: On Sat, 2 Dec 2023 03:16:11 GMT, Ichiroh Takiguchi wrote: > Cherry-pick was failed because of following changes: > > [8271456](https://bugs.openjdk.org/browse/JDK-8271456): Avoid looking up standard charsets in "java.desktop" module > openjdk/jdk at 6b55ef3 > 8271456 was code cleanup issue, it's not required for JDK11. > > On src/java.desktop/share/classes/javax/swing/text/rtf/RTFReader.java > Following code is required > > import static java.nio.charset.StandardCharsets.ISO_8859_1; > > On src/java.desktop/share/classes/javax/swing/text/rtf/RTFParser.java > Copyright year is changed from 2017 to 2023. > > Could someone please review it? > > Thanks, > Ichiroh Takiguchi This pull request has now been integrated. Changeset: 224f0f30 Author: Ichiroh Takiguchi URL: https://git.openjdk.org/jdk11u-dev/commit/224f0f30bded37d003e66445bae98d9f7f80c60d Stats: 288 lines in 3 files changed: 284 ins; 0 del; 4 mod 6928542: Chinese characters in RTF are not decoded Reviewed-by: phh Backport-of: a26f7c03c72e4efe6d3219d294294c554aebc631 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2325 From itakiguchi at openjdk.org Wed Jan 10 01:13:36 2024 From: itakiguchi at openjdk.org (Ichiroh Takiguchi) Date: Wed, 10 Jan 2024 01:13:36 GMT Subject: [jdk17u-dev] Integrated: 6928542: Chinese characters in RTF are not decoded In-Reply-To: <-r87d7xtvM-IysJig0J1tIiYfuBi8WCFB3R1zLonjr8=.e5494d41-7ef6-40b1-aa83-08c3e9f34ad7@github.com> References: <-r87d7xtvM-IysJig0J1tIiYfuBi8WCFB3R1zLonjr8=.e5494d41-7ef6-40b1-aa83-08c3e9f34ad7@github.com> Message-ID: On Sat, 2 Dec 2023 00:10:08 GMT, Ichiroh Takiguchi wrote: > Cherry-pick was failed because of following changes: > > [8271456](https://bugs.openjdk.org/browse/JDK-8271456): Avoid looking up standard charsets in "java.desktop" module > openjdk/jdk at 6b55ef3 > 8271456 was code cleanup issue, it's not required for JDK17. > > But only following code is required: > src/java.desktop/share/classes/javax/swing/text/rtf/RTFReader.java > > import static java.nio.charset.StandardCharsets.ISO_8859_1; > > > Could someone please review it? > > Thanks, > Ichiroh Takiguchi This pull request has now been integrated. Changeset: 09275870 Author: Ichiroh Takiguchi URL: https://git.openjdk.org/jdk17u-dev/commit/092758703e25644cc6f867ec8a4fbd4e23e8cd3a Stats: 288 lines in 3 files changed: 284 ins; 0 del; 4 mod 6928542: Chinese characters in RTF are not decoded Reviewed-by: phh Backport-of: a26f7c03c72e4efe6d3219d294294c554aebc631 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2010 From serb at openjdk.org Wed Jan 10 03:26:51 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 10 Jan 2024 03:26:51 GMT Subject: [jdk17u-dev] RFR: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA Message-ID: Hi all, This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/aba19334eaeb46d37169cddeef929b13e050a60e from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 9 Jan 2024 and was reviewed by Philip Race. Thanks! ------------- Commit messages: - Backport aba19334eaeb46d37169cddeef929b13e050a60e Changes: https://git.openjdk.org/jdk17u-dev/pull/2118/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2118&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323210 Stats: 8 lines in 2 files changed: 5 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2118.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2118/head:pull/2118 PR: https://git.openjdk.org/jdk17u-dev/pull/2118 From gcao at openjdk.org Wed Jan 10 06:23:31 2024 From: gcao at openjdk.org (Gui Cao) Date: Wed, 10 Jan 2024 06:23:31 GMT Subject: [jdk17u-dev] Integrated: 8322583: RISC-V: Enable fast class initialization checks In-Reply-To: References: Message-ID: <7jDsVMiVWsVTIk4w0K-Xj6X9GJnPAM5vHM7Tk1dBx6U=.8669c7ab-7c31-4cbf-966d-877a414aeedb@github.com> On Mon, 8 Jan 2024 13:15:47 GMT, Gui Cao wrote: > Hi, The same issue also exists in the JDK17u. Since corresponding fixes for the other ports are already there in jdk17u, I would like to backport this to jdk17u too. So I would like to backport this to JDK17u. Tier1-3 tested with release build using qemu systems. This is a risc-v specific change. Backport is clean, risk is low. > > The original performance issue reported by JDK-8219233 is resolved when this optimization is enabled (x2.1 improvement for reported case on linux-riscv64). > > OpenJDK17 linux-riscv64 when setting VM_Version::supports_fast_class_init_checks returns false(default): > > > $ clojure -A:user > "Elapsed time: 78459.498421 msecs" > $ clojure -A:user > "Elapsed time: 77513.115408 msecs" > $ clojure -A:user > "Elapsed time: 75132.908155 msecs" > $ clojure foo.clj > "Elapsed time: 36337.585315 msecs" > $ clojure foo.clj > "Elapsed time: 35009.33778 msecs" > $ clojure foo.clj > "Elapsed time: 35490.216435 msecs" > > > OpenJDK17 linux-riscv64 when setting VM_Version::supports_fast_class_init_checks returns true: > > > $ clojure -A:user > "Elapsed time: 37013.598933 msecs" > $ clojure -A:user > "Elapsed time: 36210.164686 msecs" > $ clojure -A:user > "Elapsed time: 36674.069441 msecs" > $ clojure foo.clj > "Elapsed time: 36813.877226 msecs" > $ clojure foo.clj > "Elapsed time: 37079.673782 msecs" This pull request has now been integrated. Changeset: 262b83c8 Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/jdk17u-dev/commit/262b83c84ee29bec2a067ab02d6979fba5b7ae55 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8322583: RISC-V: Enable fast class initialization checks Backport-of: 5235cc987d8c4455622acda947bed7321086a385 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2110 From goetz at openjdk.org Wed Jan 10 07:46:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 10 Jan 2024 07:46:22 GMT Subject: [jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.11-oracle. > > This is a minimal version that only removes the strings from the interface, as well as the comment. Removing these is explicitly stated in the CSR. > > The change keeps the EdDSA implementation. As I understand, 17 supports EdDSA in general, it was just not included for XML when 17 was released. > https://bugs.openjdk.org/browse/JDK-8305972 Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision: - Remove Strings as proposed in CSR - Backport f0aebc8141de5a50c88658a40caa01967a9afc53 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2116/files - new: https://git.openjdk.org/jdk17u-dev/pull/2116/files/3abbcfe0..b0809398 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2116&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2116&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2116.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2116/head:pull/2116 PR: https://git.openjdk.org/jdk17u-dev/pull/2116 From shade at openjdk.org Wed Jan 10 08:01:28 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 10 Jan 2024 08:01:28 GMT Subject: [jdk21u-dev] RFR: 8320907: Shenandoah: Remove ShenandoahSelfFixing flag In-Reply-To: References: Message-ID: On Wed, 10 Jan 2024 07:56:45 GMT, Goetz Lindenmaier wrote: > Hi @shipilev, there seems to be a problem with GHA. Same with the others. Yeah, GitHub had an outage yesterday. I restarted the workflows, let's see if it works now. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/149#issuecomment-1884354653 From goetz at openjdk.org Wed Jan 10 08:01:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 10 Jan 2024 08:01:27 GMT Subject: [jdk21u-dev] RFR: 8320907: Shenandoah: Remove ShenandoahSelfFixing flag In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 11:48:32 GMT, Aleksey Shipilev wrote: > Clean backport to improve Shenandoah reliability and maintainability. Hi @shipilev, there seems to be a problem with GHA. Same with the others. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/149#issuecomment-1884352793 From goetz at openjdk.org Wed Jan 10 08:16:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 10 Jan 2024 08:16:30 GMT Subject: [jdk11u-dev] RFR: 8306871: Open source more AWT Drag & Drop tests In-Reply-To: <2QAvi-HJ8DLLyovurcVNShQup5HT3zS1nFxcKjHIKcQ=.191aebfc-fb54-490a-b382-852aa345c79b@github.com> References: <2QAvi-HJ8DLLyovurcVNShQup5HT3zS1nFxcKjHIKcQ=.191aebfc-fb54-490a-b382-852aa345c79b@github.com> Message-ID: On Tue, 9 Jan 2024 07:44:39 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. @luchenlin, what is wrong with GHA? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2447#issuecomment-1884373720 From goetz at openjdk.org Wed Jan 10 08:19:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 10 Jan 2024 08:19:31 GMT Subject: [jdk11u-dev] RFR: 8307381: Open Source JFrame, JIF related Swing Tests In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 08:41:16 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. @luchenclin, what is wrong with GHA? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2449#issuecomment-1884376820 From goetz at openjdk.org Wed Jan 10 08:20:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 10 Jan 2024 08:20:29 GMT Subject: [jdk11u-dev] RFR: 8320208: Update Public Suffix List to b5bf572 In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 02:11:12 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. @luchenlin Well done that this is a clean backport! Please have a look at the GHA failures. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2440#issuecomment-1884378273 From duke at openjdk.org Wed Jan 10 08:32:36 2024 From: duke at openjdk.org (Philip Helger) Date: Wed, 10 Jan 2024 08:32:36 GMT Subject: [jdk17u-dev] RFR: 8296343: CPVE thrown on missing content-length in OCSP response In-Reply-To: References: Message-ID: On Thu, 18 May 2023 15:59:18 GMT, Alexey Pavlyutkin wrote: > Hi! > > Here is backport of [JDK-8296343](https://bugs.openjdk.org/browse/JDK-8296343). The patch fixes CertPathValidatorException taking place if OCSP response does not contain `ContentLength` field. > > Original patch is applied cleanly. > > Verification/regression (amd64/20.04 LTS): `jdk_security` including newly added `test/jdk/sun/security/provider/certpath/OCSP/OCSPNoContentLength.java` Dear all. The problem with OCSP responders not returning `Content-Length` header is still present and needs fixing. Please don't forget this one.... ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1361#issuecomment-1884394053 From andrewlu at openjdk.org Wed Jan 10 08:32:42 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 10 Jan 2024 08:32:42 GMT Subject: [jdk11u-dev] Integrated: 8306753: Open source several container AWT tests In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 07:44:48 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: c360cd5e Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/c360cd5e257d06dc3a34992988cb42eed4217aba Stats: 814 lines in 4 files changed: 814 ins; 0 del; 0 mod 8306753: Open source several container AWT tests Backport-of: b372f28ad4b7c1f46e0070a930911542d4d1a032 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2448 From andrewlu at openjdk.org Wed Jan 10 08:34:27 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 10 Jan 2024 08:34:27 GMT Subject: [jdk11u-dev] Integrated: 8274621: NullPointerException because listenAddress[0] is null In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 05:32:07 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: 8a1e29df Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/8a1e29df7296a8b45d582b3d2844a2b938680e6f Stats: 14 lines in 1 file changed: 4 ins; 0 del; 10 mod 8274621: NullPointerException because listenAddress[0] is null Backport-of: 5bbc8d3cb2ce487b367ee1a621d78699c9b30100 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2441 From andrewlu at openjdk.org Wed Jan 10 08:35:32 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 10 Jan 2024 08:35:32 GMT Subject: [jdk11u-dev] Integrated: 8290909: MemoryPoolMBean/isUsageThresholdExceeded tests failed with "isUsageThresholdExceeded() returned false, and is still false, while threshold = MMMMMMM and used peak = NNNNNNN" In-Reply-To: <0svuggu9914StmJ6_y7VQwlbyVV688QalW7t7XAVMQw=.b9d69bab-3b39-4664-a216-32df34d44eeb@github.com> References: <0svuggu9914StmJ6_y7VQwlbyVV688QalW7t7XAVMQw=.b9d69bab-3b39-4664-a216-32df34d44eeb@github.com> Message-ID: On Tue, 9 Jan 2024 07:02:36 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: bcfabe3c Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/bcfabe3ce20f9ba39501030957d6e5a96847d70c Stats: 19 lines in 1 file changed: 4 ins; 8 del; 7 mod 8290909: MemoryPoolMBean/isUsageThresholdExceeded tests failed with "isUsageThresholdExceeded() returned false, and is still false, while threshold = MMMMMMM and used peak = NNNNNNN" Backport-of: 3601e30df794db122d8d04fb3c04868ccbaa0baf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2444 From andrewlu at openjdk.org Wed Jan 10 08:35:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 10 Jan 2024 08:35:40 GMT Subject: [jdk11u-dev] Integrated: 8306652: Open source AWT MenuItem related tests In-Reply-To: <56wlwXMvG4YtyOHRsTl3FJD6gWq1XvYFft3qHvKShoc=.f89b2fee-824d-48d7-813c-5ab56bf28c68@github.com> References: <56wlwXMvG4YtyOHRsTl3FJD6gWq1XvYFft3qHvKShoc=.f89b2fee-824d-48d7-813c-5ab56bf28c68@github.com> Message-ID: On Tue, 9 Jan 2024 07:27:49 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: 9ee3b1cf Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/9ee3b1cf5dd95d81936c02c101c309fa17edb54a Stats: 326 lines in 4 files changed: 326 ins; 0 del; 0 mod 8306652: Open source AWT MenuItem related tests Backport-of: ed1ebd242a4bb82a7074564ea96dc3d26b78f9e1 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2446 From andrewlu at openjdk.org Wed Jan 10 08:35:44 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 10 Jan 2024 08:35:44 GMT Subject: [jdk11u-dev] Integrated: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests In-Reply-To: <22joBDCR17whIWrLMhUL0dBw6mIEv-RrTO1X5mInBlA=.96fd78d8-14fd-4bb7-87b4-c98adbed1b34@github.com> References: <22joBDCR17whIWrLMhUL0dBw6mIEv-RrTO1X5mInBlA=.96fd78d8-14fd-4bb7-87b4-c98adbed1b34@github.com> Message-ID: <_Yb15I6MB5qqcv2-DK2pCNbnsj92n70xaKTHBMk6s7E=.5be784fa-b8ee-4ea7-8f50-a363e91267d0@github.com> On Tue, 9 Jan 2024 07:11:55 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: 61c0718e Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/61c0718e4cc8d7f4c52e4f90f2071122a36bc401 Stats: 615 lines in 6 files changed: 615 ins; 0 del; 0 mod 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests Backport-of: 732179ca84ee1dab6530255c33de7f35cab649c2 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2445 From goetz at openjdk.org Wed Jan 10 08:40:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 10 Jan 2024 08:40:32 GMT Subject: [jdk17u-dev] Integrated: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries In-Reply-To: <5_9LRg5OA0VmlTIo9JsJiRDHv5GrIuYMeA3Iiwl21lo=.e8487b5a-2ba6-4c8d-8355-f0e7580cf1e1@github.com> References: <5_9LRg5OA0VmlTIo9JsJiRDHv5GrIuYMeA3Iiwl21lo=.e8487b5a-2ba6-4c8d-8355-f0e7580cf1e1@github.com> Message-ID: On Thu, 4 Jan 2024 14:30:30 GMT, Goetz Lindenmaier wrote: > This is a backout needed as the change is too intrusive for a backport. This pull request has now been integrated. Changeset: ea6fc214 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ea6fc2147182f5b7168dc6f4e240c49446bf2ca3 Stats: 449 lines in 3 files changed: 0 ins; 448 del; 1 mod 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries Reviewed-by: shade Backport-of: 18e97aa217087ff7af13a0147eaf091df3cb20eb ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2102 From goetz at openjdk.org Wed Jan 10 09:17:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 10 Jan 2024 09:17:48 GMT Subject: [jdk11u-dev] RFR: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries Message-ID: This is a backout needed as the change is too intrusive for a backport. Backport of the 17 change. ------------- Commit messages: - Revert "8225377: type annotations are not visible to javac plugins across compilation boundaries" - Revert "8320001: javac crashes while adding type annotations to the return type of a constructor" Changes: https://git.openjdk.org/jdk11u-dev/pull/2450/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2450&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322883 Stats: 445 lines in 3 files changed: 0 ins; 444 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2450.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2450/head:pull/2450 PR: https://git.openjdk.org/jdk11u-dev/pull/2450 From goetz at openjdk.org Wed Jan 10 11:49:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 10 Jan 2024 11:49:30 GMT Subject: [jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v2] In-Reply-To: References: Message-ID: On Wed, 10 Jan 2024 07:46:22 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.11-oracle. >> >> This is a minimal version that only removes the strings from the interface, as well as the comment. Removing these is explicitly stated in the CSR. >> >> The change keeps the EdDSA implementation. As I understand, 17 supports EdDSA in general, it was just not included for XML when 17 was released. >> https://bugs.openjdk.org/browse/JDK-8305972 > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision: > > - Remove Strings as proposed in CSR > - Backport f0aebc8141de5a50c88658a40caa01967a9afc53 GHA failures look unrelated, but strange. javadoc/testJavadocTester/TestRunTests.java does not compile testJavadocTester/TestRunTests.java:122: error: no suitable method found for runTests(Function,String,String,String) g.runTests(f, "m1", "m4", "m2"); ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2116#issuecomment-1884697996 From duke at openjdk.org Wed Jan 10 11:50:36 2024 From: duke at openjdk.org (duke) Date: Wed, 10 Jan 2024 11:50:36 GMT Subject: [jdk11u-dev] Withdrawn: 8303215: Make thread stacks not use huge pages In-Reply-To: References: Message-ID: On Tue, 24 Oct 2023 06:22:34 GMT, Thomas Stuefe wrote: > Backported for parity with Oracle and as preparation to fix https://bugs.openjdk.org/browse/JDK-8312182. > > Backport is unclean, but the difference is minor. I had to adjust hunks in `os::large_page_init()` since the surrounding coding changed a lot since JDK 11. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2208 From goetz at openjdk.org Wed Jan 10 11:55:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 10 Jan 2024 11:55:30 GMT Subject: [jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v5] In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 16:49:38 GMT, Martin Balao wrote: >> Hi @martinuy, >> do you think it would be better to keep all the code and only remove the two String and the change to the comment of DigestMethod? >> In the 21u change for the update to [3.0.3](https://github.com/openjdk/jdk21u-dev/pull/94) I have done it that way. Probably that's also the better solution here. > > Hi @GoeLin , > > I assume that in 21u you kept all the (implementation) code except for the public members. If so, I understand the motivations but personally prefer what you proposed for 17u in this PR. It makes the code more clear in terms of what is supported. For example, it would be misleading for someone who looks for "EdDSA" references in the code, finds many ?even beyond defines? and assumes that it is supported. This is, of course, at the expense of higher chances of non-clean updates. We have taken this approach in other libraries before such as when we removed the implementation of DTLS in the 8u backport of the TLS engine. > > Martin.- Hi @martinuy, looking at the CSR differences: [CSR for head](https://bugs.openjdk.org/browse/JDK-8307507) [CSR for 11 & 17](https://bugs.openjdk.org/browse/JDK-8320594) I still believe it is more correct to keep the coding. At least for 17, which, as I understand, supports EdDSA in general. It was just not specified for XML Security (i.e. not contained in SignatureMethod.java). Probably changing this would require more than just a CSR so Oracle omitted it. I prepared a minimal PR: https://github.com/openjdk/jdk17u-dev/pull/2116 that only removes the strings and replace their usage by the plain strings. The tests pass, our nightly testing passed for this PR, too. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2006#issuecomment-1884706983 From wkemper at openjdk.org Wed Jan 10 12:13:30 2024 From: wkemper at openjdk.org (William Kemper) Date: Wed, 10 Jan 2024 12:13:30 GMT Subject: [jdk22u] Integrated: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 19:33:47 GMT, William Kemper wrote: > 8323086: Shenandoah: Heap could be corrupted by oom during evacuation This pull request has now been integrated. Changeset: 484138e3 Author: William Kemper Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/484138e3e1bf6cbfe36baa3a24b86e259b45a49f Stats: 21 lines in 1 file changed: 21 ins; 0 del; 0 mod 8323086: Shenandoah: Heap could be corrupted by oom during evacuation Backport-of: c4a83bd6f6c45e72bd776e929005be0aa9408867 ------------- PR: https://git.openjdk.org/jdk22u/pull/12 From wkemper at openjdk.org Wed Jan 10 12:14:30 2024 From: wkemper at openjdk.org (William Kemper) Date: Wed, 10 Jan 2024 12:14:30 GMT Subject: [jdk22u] Integrated: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 19:13:03 GMT, William Kemper wrote: > Clean backport, trivial fix. This pull request has now been integrated. Changeset: 4c8b8399 Author: William Kemper Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/4c8b839993a75cb4fd9d1583c756f164c28c1750 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8323021: Shenandoah: Encountered reference count always attributed to first worker thread Backport-of: f0e2e4311b8cab160dc9e35f43e9ae5a145c5e23 ------------- PR: https://git.openjdk.org/jdk22u/pull/9 From duke at openjdk.org Wed Jan 10 12:22:27 2024 From: duke at openjdk.org (Elif Aslan) Date: Wed, 10 Jan 2024 12:22:27 GMT Subject: [jdk21u-dev] Integrated: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 19:21:38 GMT, Elif Aslan wrote: > Clean backport to enable parallelism in vmTestbase/nsk/stress/jni tests > > Tested with GHA This pull request has now been integrated. Changeset: 4537bfa9 Author: Elif Aslan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/4537bfa9cc091ff1807d9e03f1c0c971345adf6e Stats: 24 lines in 1 file changed: 0 ins; 24 del; 0 mod 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests Backport-of: 43f31d73852d63ccdcc2dcd8d6c7355435a50fb3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/135 From duke at openjdk.org Wed Jan 10 12:22:34 2024 From: duke at openjdk.org (Elif Aslan) Date: Wed, 10 Jan 2024 12:22:34 GMT Subject: [jdk21u-dev] Integrated: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests In-Reply-To: References: Message-ID: On Fri, 5 Jan 2024 19:22:09 GMT, Elif Aslan wrote: > Clean backport to enable parallelism in vmTestbase/nsk/stress/threads tests. > > Tested with GHA. This pull request has now been integrated. Changeset: a28d29c5 Author: Elif Aslan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/a28d29c53b5c37781e8ced684b7b38e56f890711 Stats: 24 lines in 1 file changed: 0 ins; 24 del; 0 mod 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests Backport-of: cee44a625594fd805a05c4a69033eb677a5a6f17 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/136 From dchuyko at openjdk.org Wed Jan 10 12:25:33 2024 From: dchuyko at openjdk.org (Dmitry Chuyko) Date: Wed, 10 Jan 2024 12:25:33 GMT Subject: [jdk17u-dev] Integrated: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 15:10:52 GMT, Dmitry Chuyko wrote: > This changes reverts https://bugs.openjdk.org/browse/JDK-8293671 backport due to the correctness problems in the initial change. > > Original reverting patch applies cleanly with the only exception of copyright update (already 2024) which has been excluded. > > The new test fails on current 17u aarch64 and doesn't fail with the change applied. > > Additional testing: jtreg tier1,2 (linux-aarch64 fastdebug) This pull request has now been integrated. Changeset: f194105b Author: Dmitry Chuyko Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/f194105b29d674be11bdcf02b7e8ee702228ee32 Stats: 148 lines in 2 files changed: 147 ins; 0 del; 1 mod 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate Reviewed-by: aph Backport-of: ade21a965f8a5fc889cd48bba76fad507bdeddf5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2117 From jdowland at openjdk.org Wed Jan 10 13:21:39 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Wed, 10 Jan 2024 13:21:39 GMT Subject: [jdk11u-dev] RFR: 8247818: GCC 10 warning stringop-overflow with symbol code Message-ID: 11u-dev is tricky to build with GCC 11 and newer. GCC 11 is the default version in current Debian stable (and likely derivatives e.g. Ubuntu, but I have not checked) as well as RHEL 9 (and derivatives, likewise unchecked), so I think it's worthwhile to improve that. This particular patch addresses one of the obstacles (a warning from GCC 10 onwards). It doesn't apply clean, but cherry-pick conflicts were trivial to resolve. It was backported from 16 to 15 and 13 and seems worthwhile for 11u. ------------- Commit messages: - 8247818: GCC 10 warning stringop-overflow with symbol code Changes: https://git.openjdk.org/jdk11u-dev/pull/2451/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2451&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8247818 Stats: 8 lines in 2 files changed: 0 ins; 7 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2451.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2451/head:pull/2451 PR: https://git.openjdk.org/jdk11u-dev/pull/2451 From jbechberger at openjdk.org Wed Jan 10 15:25:49 2024 From: jbechberger at openjdk.org (Johannes Bechberger) Date: Wed, 10 Jan 2024 15:25:49 GMT Subject: [jdk11u-dev] RFR: 8304725: AsyncGetCallTrace can cause SIGBUS on M1 Message-ID: <2jxFITZGCv2XIA_RhusYu0SOK1AyN681Csv9AUTJ9cA=.cb4fd0ee-49f3-465f-a02f-a5fc1c0e9ec0@github.com> 8304725: AsyncGetCallTrace can cause SIGBUS on M1 ------------- Commit messages: - Merge branch 'openjdk:master' into backport-parttimenerd-d8af7a60 - Backport d8af7a6014055295355a1242db6c2872299c6398 Changes: https://git.openjdk.org/jdk11u-dev/pull/2452/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2452&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304725 Stats: 34 lines in 3 files changed: 30 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2452.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2452/head:pull/2452 PR: https://git.openjdk.org/jdk11u-dev/pull/2452 From goetz at openjdk.org Wed Jan 10 15:27:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 10 Jan 2024 15:27:17 GMT Subject: [jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v6] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.11-oracle. > > The backport was almost clean, except for two trivial resolves due to differences in whitespace in the context. > > The change comes with a CSR, which is already approved for 17. > But the CSR requires changes wrt. to the original change. > In 17, no EDDSA support is added. > > The PR comes with two commits: > 1. the almost clean backport. I already skipped two comments added in head but not needed in 17 (SignatureMethod, DigestMethod). > 2. removing the eddsa support. > > Tests pass, SAP nightly testing passed. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Cleanup Test as proposed by Martin B. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2006/files - new: https://git.openjdk.org/jdk17u-dev/pull/2006/files/3f4616cd..45845757 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2006&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2006&range=04-05 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2006.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2006/head:pull/2006 PR: https://git.openjdk.org/jdk17u-dev/pull/2006 From mbaesken at openjdk.org Wed Jan 10 15:33:35 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 10 Jan 2024 15:33:35 GMT Subject: [jdk21u-dev] Integrated: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output In-Reply-To: <13c6l8iwKE7XUtgAxOL92SghD0502tDS9pQ54WTX0FA=.e9330c80-c55d-41b7-823c-d40c9e37fc6b@github.com> References: <13c6l8iwKE7XUtgAxOL92SghD0502tDS9pQ54WTX0FA=.e9330c80-c55d-41b7-823c-d40c9e37fc6b@github.com> Message-ID: On Mon, 8 Jan 2024 14:38:54 GMT, Matthias Baesken wrote: > 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output This pull request has now been integrated. Changeset: 2bf21b4c Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/2bf21b4c87df7a718ea9a34c5a5af84fbb7d4d1c Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output Backport-of: a8e4229852fac703c6271aa8c5f94f67bea44902 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/141 From shade at openjdk.org Wed Jan 10 15:33:46 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 10 Jan 2024 15:33:46 GMT Subject: [jdk21u-dev] RFR: 8319650: Improve heap dump performance with class metadata caching [v2] In-Reply-To: <_Ib2XP8lK31x6lHk8Dk-F5w6ZD_C-yX9cTlbnBaqfTk=.60c3387a-dd78-4f70-9622-ca79e6321848@github.com> References: <_Ib2XP8lK31x6lHk8Dk-F5w6ZD_C-yX9cTlbnBaqfTk=.60c3387a-dd78-4f70-9622-ca79e6321848@github.com> Message-ID: > Transplanted from https://github.com/openjdk/jdk21u/pull/388 > > Unclean backport to improve heap dump performance. The uncleanliness comes from [JDK-8306441](https://bugs.openjdk.org/browse/JDK-8306441) that does not exist in JDK 21, and which I don't think we want to backport at the moment. I had to add a few more `ResourceMark`-s near `HeapDumpWriter` to manage the cache allocations. > > Additional testing: > - [x] MacOS AArch64 server release, heap dump performance improved > - [x] Linux x86_64 server fastdebug, serviceability/ (contains heap dump tests) > - [x] Linux x86_64 server fastdebug, runtime/ErrorHandling (contains heap dump on failure tests) > - [x] Linux x86_64 server fastdebug, gc/epsilon (contains heap dump on failure tests) > - [x] Linux x86_64 server fastdebug, sun/tools/jhsdb (contains heap dump tests) Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8319650-heapdump-cache-class - Backport 03db82818b905f21cb5ad1d56a687e238b4a6e33 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/8/files - new: https://git.openjdk.org/jdk21u-dev/pull/8/files/d0ba9f6e..da6d93ed Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=8&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=8&range=00-01 Stats: 18883 lines in 952 files changed: 8445 ins; 2921 del; 7517 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/8.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/8/head:pull/8 PR: https://git.openjdk.org/jdk21u-dev/pull/8 From mbaesken at openjdk.org Wed Jan 10 15:51:59 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 10 Jan 2024 15:51:59 GMT Subject: [jdk22u] RFR: 8322945: Problemlist runtime/CompressedOops/CompressedClassPointers.java on AIX Message-ID: 8322945: Problemlist runtime/CompressedOops/CompressedClassPointers.java on AIX ------------- Commit messages: - Backport 730663649fdaf3a0e268ee27f41bd8673df2bbfd Changes: https://git.openjdk.org/jdk22u/pull/16/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=16&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322945 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/16.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/16/head:pull/16 PR: https://git.openjdk.org/jdk22u/pull/16 From mbaesken at openjdk.org Wed Jan 10 15:51:59 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 10 Jan 2024 15:51:59 GMT Subject: [jdk22u] RFR: 8322945: Problemlist runtime/CompressedOops/CompressedClassPointers.java on AIX In-Reply-To: References: Message-ID: On Wed, 10 Jan 2024 15:45:32 GMT, Matthias Baesken wrote: > 8322945: Problemlist runtime/CompressedOops/CompressedClassPointers.java on AIX jdk22u backport request I would like to backport the patch to jdk22u because the issue is present there too. The backport is clean and low risk. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/16#issuecomment-1885114497 From jbechberger at openjdk.org Wed Jan 10 16:16:43 2024 From: jbechberger at openjdk.org (Johannes Bechberger) Date: Wed, 10 Jan 2024 16:16:43 GMT Subject: [jdk11u-dev] RFR: 8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use" Message-ID: <2jiqLb2EU3dCCGbaDiOf1Y1_prq-JT7QwecDwCOQQPk=.90a6c2a1-7928-44c9-bce7-bdf986908bae@github.com> Tested it locally. ------------- Commit messages: - Backport 28e1a33856504abfc003a283ece928fb87f6623c Changes: https://git.openjdk.org/jdk11u-dev/pull/2453/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2453&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318736 Stats: 80 lines in 2 files changed: 32 ins; 20 del; 28 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2453.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2453/head:pull/2453 PR: https://git.openjdk.org/jdk11u-dev/pull/2453 From jbechberger at openjdk.org Wed Jan 10 16:42:42 2024 From: jbechberger at openjdk.org (Johannes Bechberger) Date: Wed, 10 Jan 2024 16:42:42 GMT Subject: [jdk11u-dev] RFR: 8304725: AsyncGetCallTrace can cause SIGBUS on M1 [v2] In-Reply-To: <2jxFITZGCv2XIA_RhusYu0SOK1AyN681Csv9AUTJ9cA=.cb4fd0ee-49f3-465f-a02f-a5fc1c0e9ec0@github.com> References: <2jxFITZGCv2XIA_RhusYu0SOK1AyN681Csv9AUTJ9cA=.cb4fd0ee-49f3-465f-a02f-a5fc1c0e9ec0@github.com> Message-ID: > 8304725: AsyncGetCallTrace can cause SIGBUS on M1 Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision: Fix compilation issue ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2452/files - new: https://git.openjdk.org/jdk11u-dev/pull/2452/files/cdac227b..21485f80 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2452&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2452&range=00-01 Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2452.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2452/head:pull/2452 PR: https://git.openjdk.org/jdk11u-dev/pull/2452 From jbechberger at openjdk.org Wed Jan 10 17:21:55 2024 From: jbechberger at openjdk.org (Johannes Bechberger) Date: Wed, 10 Jan 2024 17:21:55 GMT Subject: [jdk11u-dev] RFR: 8304725: AsyncGetCallTrace can cause SIGBUS on M1 [v3] In-Reply-To: <2jxFITZGCv2XIA_RhusYu0SOK1AyN681Csv9AUTJ9cA=.cb4fd0ee-49f3-465f-a02f-a5fc1c0e9ec0@github.com> References: <2jxFITZGCv2XIA_RhusYu0SOK1AyN681Csv9AUTJ9cA=.cb4fd0ee-49f3-465f-a02f-a5fc1c0e9ec0@github.com> Message-ID: > 8304725: AsyncGetCallTrace can cause SIGBUS on M1 Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision: Replace nullptr with NULL ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2452/files - new: https://git.openjdk.org/jdk11u-dev/pull/2452/files/21485f80..057a1511 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2452&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2452&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2452.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2452/head:pull/2452 PR: https://git.openjdk.org/jdk11u-dev/pull/2452 From shade at openjdk.org Wed Jan 10 19:10:48 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 10 Jan 2024 19:10:48 GMT Subject: [jdk21u-dev] RFR: 8319372: C2 compilation fails with "Bad immediate dominator info" Message-ID: Clean backport to fix C2 bug and better parity. Testing: - [x] New regression tests fail with the fix and pass with it - [ ] Linux x86_64 server fastdebug, `tier{1,2,3,4}` - [ ] Linux x86_64 server fastdebug, `tier{1,2,3,4}` ------------- Commit messages: - Backport 7766785098816cfcdae3479540cdc866c1ed18ad Changes: https://git.openjdk.org/jdk21u-dev/pull/157/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=157&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319372 Stats: 244 lines in 4 files changed: 171 ins; 73 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/157.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/157/head:pull/157 PR: https://git.openjdk.org/jdk21u-dev/pull/157 From btaylor at openjdk.org Wed Jan 10 19:56:37 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 10 Jan 2024 19:56:37 GMT Subject: [jdk17u-dev] RFR: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader Message-ID: Clean backport of [JDK-8319436](https://bugs.openjdk.org/browse/JDK-8319436) to resolve a regression introduced in 17.0.8. Included tests pass locally on linux x64. ------------- Commit messages: - Backport 8eb6f617b3f8e2a990e4244af4e56287f9741b20 Changes: https://git.openjdk.org/jdk17u-dev/pull/2119/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2119&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319436 Stats: 143 lines in 2 files changed: 20 ins; 77 del; 46 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2119.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2119/head:pull/2119 PR: https://git.openjdk.org/jdk17u-dev/pull/2119 From btaylor at openjdk.org Wed Jan 10 19:56:42 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 10 Jan 2024 19:56:42 GMT Subject: [jdk11u-dev] RFR: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader Message-ID: <6-YRvqmmwW7Y2c8JR0oZlTmhFhhU8dp8P20hBs8UXDY=.54b1acb9-1881-41a4-ad8a-00110c0401a9@github.com> Clean backport of [JDK-8319436](https://bugs.openjdk.org/browse/JDK-8319436) to resolve a regression introduced in 11.0.20. Included tests pass locally on linux x64. ------------- Commit messages: - Backport 8eb6f617b3f8e2a990e4244af4e56287f9741b20 Changes: https://git.openjdk.org/jdk11u-dev/pull/2454/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2454&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319436 Stats: 143 lines in 2 files changed: 20 ins; 77 del; 46 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2454.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2454/head:pull/2454 PR: https://git.openjdk.org/jdk11u-dev/pull/2454 From wkemper at openjdk.org Wed Jan 10 23:56:33 2024 From: wkemper at openjdk.org (William Kemper) Date: Wed, 10 Jan 2024 23:56:33 GMT Subject: [jdk22u] RFR: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled Message-ID: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled ------------- Commit messages: - Backport a7db4fecebe98135d36c6f46e1fa60959adbe78b Changes: https://git.openjdk.org/jdk22u/pull/17/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=17&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323428 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/17.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/17/head:pull/17 PR: https://git.openjdk.org/jdk22u/pull/17 From wkemper at openjdk.org Thu Jan 11 00:12:38 2024 From: wkemper at openjdk.org (William Kemper) Date: Thu, 11 Jan 2024 00:12:38 GMT Subject: [jdk17u-dev] RFR: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled Message-ID: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled ------------- Commit messages: - Backport a7db4fecebe98135d36c6f46e1fa60959adbe78b Changes: https://git.openjdk.org/jdk17u-dev/pull/2120/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2120&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323428 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2120.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2120/head:pull/2120 PR: https://git.openjdk.org/jdk17u-dev/pull/2120 From wkemper at openjdk.org Thu Jan 11 00:12:43 2024 From: wkemper at openjdk.org (William Kemper) Date: Thu, 11 Jan 2024 00:12:43 GMT Subject: [jdk21u-dev] RFR: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled Message-ID: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled ------------- Commit messages: - Backport a7db4fecebe98135d36c6f46e1fa60959adbe78b Changes: https://git.openjdk.org/jdk21u-dev/pull/158/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=158&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323428 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/158.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/158/head:pull/158 PR: https://git.openjdk.org/jdk21u-dev/pull/158 From goetz at openjdk.org Thu Jan 11 07:26:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 11 Jan 2024 07:26:31 GMT Subject: [jdk21u-dev] Integrated: 8311992: Test java/lang/Thread/virtual/JfrEvents::testVirtualThreadPinned failed In-Reply-To: <31nKOrYvQ7BbcobPimT0SsOq7iMjLiYMdzSfxCGzJwY=.3f1f9c9f-93f7-4e32-b5c5-7f80ef5627fa@github.com> References: <31nKOrYvQ7BbcobPimT0SsOq7iMjLiYMdzSfxCGzJwY=.3f1f9c9f-93f7-4e32-b5c5-7f80ef5627fa@github.com> Message-ID: On Mon, 8 Jan 2024 13:01:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 1ea0d080 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/1ea0d080483202e7f9185fad769680d1a7e84332 Stats: 42 lines in 1 file changed: 19 ins; 2 del; 21 mod 8311992: Test java/lang/Thread/virtual/JfrEvents::testVirtualThreadPinned failed Backport-of: 0d2196f8e5b03577a14ff97505718f4fa53f3792 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/139 From goetz at openjdk.org Thu Jan 11 07:29:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 11 Jan 2024 07:29:33 GMT Subject: [jdk21u-dev] Integrated: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 13:07:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 2abfc99d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/2abfc99d2cece7f6020cf97593bb63641dd8e7de Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready Backport-of: b20dc1e9cda1ea3a76b3f14c778c6816e5cc1c0c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/140 From goetz at openjdk.org Thu Jan 11 07:31:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 11 Jan 2024 07:31:27 GMT Subject: [jdk17u-dev] Integrated: 8272853: improve `JavadocTester.runTests` In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 13:59:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. > > Resolved one import, probably recognized clean. This pull request has now been integrated. Changeset: 5e819418 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/5e8194187fc97baaf69c59d4aec5d5ae777d708d Stats: 109 lines in 1 file changed: 97 ins; 6 del; 6 mod 8272853: improve `JavadocTester.runTests` Reviewed-by: phh Backport-of: b0028a459c7e99b5e4090cc19127f6347fe220ba ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2111 From goetz at openjdk.org Thu Jan 11 07:33:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 11 Jan 2024 07:33:07 GMT Subject: [jdk17u-dev] Integrated: 8309302: java/net/Socket/Timeouts.java fails with AssertionError on test temporal post condition In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 14:24:07 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 1ef95db1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/1ef95db13293aa8e1e48e7daefb142fb70a12e04 Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod 8309302: java/net/Socket/Timeouts.java fails with AssertionError on test temporal post condition Backport-of: 87c79c080186abc53d033449dd9f76c8832d44f5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2113 From goetz at openjdk.org Thu Jan 11 07:34:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 11 Jan 2024 07:34:28 GMT Subject: [jdk21u-dev] Integrated: 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 14:56:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: cd166703 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/cd166703a20c4ac51bc6478e8a0bb1275d9cb913 Stats: 41 lines in 41 files changed: 0 ins; 0 del; 41 mod 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal Backport-of: 6f263111a1812873291e91870e341ccce804d049 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/142 From goetz at openjdk.org Thu Jan 11 07:36:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 11 Jan 2024 07:36:33 GMT Subject: [jdk17u-dev] Integrated: 8307185: pkcs11 native libraries make JNI calls into java code while holding GC lock In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 14:23:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 20fdc05b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/20fdc05b0b1b101687f0c6ad538fb85af9ca9c67 Stats: 42 lines in 2 files changed: 16 ins; 11 del; 15 mod 8307185: pkcs11 native libraries make JNI calls into java code while holding GC lock Backport-of: 354c6605e32790ca421869636d8bf5456fc51717 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2112 From andrewlu at openjdk.org Thu Jan 11 08:29:01 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 11 Jan 2024 08:29:01 GMT Subject: [jdk11u-dev] RFR: 8276796: gc/TestSystemGC.java large pages subtest fails with ZGC [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.23-oracle. > Backport for JDK-8269077 and JDK-8276796, > for JDK-8269077, it's clean, as CMS test is remain in this file, only modify the '@test id=CMS', other added parts are clean. Local test pass. Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: add -XX:+UnlockExperimentalVMOptions ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2442/files - new: https://git.openjdk.org/jdk11u-dev/pull/2442/files/26a25bc4..c982127b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2442&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2442&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2442.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2442/head:pull/2442 PR: https://git.openjdk.org/jdk11u-dev/pull/2442 From shade at openjdk.org Thu Jan 11 09:58:28 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 11 Jan 2024 09:58:28 GMT Subject: [jdk21u-dev] RFR: 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...] In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 10:02:34 GMT, Aleksey Shipilev wrote: > Clean backport to fix a corner case in javac. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, new regression test fails without the patch, passes with it > - [x] macos-aarch64-server-fastdebug, `langtools_all` pass Checking here: @lahodaj, you are good with this going into 21u? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/146#issuecomment-1886752516 From goetz at openjdk.org Thu Jan 11 11:06:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 11 Jan 2024 11:06:28 GMT Subject: [jdk17u-dev] RFR: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader In-Reply-To: References: Message-ID: On Wed, 10 Jan 2024 19:48:04 GMT, Ben Taylor wrote: > Clean backport of [JDK-8319436](https://bugs.openjdk.org/browse/JDK-8319436) to resolve a regression introduced in 17.0.8. Included tests pass locally on linux x64. Please only label fix-request after passing GHA tests! I'll remove the label in the meantime. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2119#issuecomment-1886883652 From goetz at openjdk.org Thu Jan 11 11:13:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 11 Jan 2024 11:13:32 GMT Subject: [jdk11u-dev] RFR: 8247818: GCC 10 warning stringop-overflow with symbol code In-Reply-To: References: Message-ID: <6JlJ7BurDIQJbpoSFOROAXZ9HVHdSTbkMYiiVdx0iI4=.4d9b9247-4aed-47fc-8c81-e07d267ccca3@github.com> On Wed, 10 Jan 2024 13:12:49 GMT, Jonathan Dowland wrote: > 11u-dev is tricky to build with GCC 11 and newer. GCC 11 is the default version in current Debian stable (and likely derivatives e.g. Ubuntu, but I have not checked) as well as RHEL 9 (and derivatives, likewise unchecked), so I think it's worthwhile to improve that. > > This particular patch addresses one of the obstacles (a warning from GCC 10 onwards). It doesn't apply clean, but cherry-pick conflicts were trivial to resolve. It was backported from 16 to 15 and 13 and seems worthwhile for 11u. Hi @jmtd, what about follow up JDK_8249087? I think we need that, too. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2451#issuecomment-1886907685 From mbaesken at openjdk.org Thu Jan 11 13:45:47 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 11 Jan 2024 13:45:47 GMT Subject: [jdk22u] RFR: 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18 Message-ID: <6E8ykfv46HQg1wRY_nxqZIVdpknWJS0bccL9iNaRo0g=.0379f72d-ad0b-4b63-8d5d-1c51dd7fa1b2@github.com> 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18 ------------- Commit messages: - Backport b530c0281b5082994065b10addeb8366ffa58e2f Changes: https://git.openjdk.org/jdk22u/pull/18/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=18&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317804 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/18.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/18/head:pull/18 PR: https://git.openjdk.org/jdk22u/pull/18 From szaldana at openjdk.org Thu Jan 11 15:27:47 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Thu, 11 Jan 2024 15:27:47 GMT Subject: [jdk21u-dev] RFR: 8318154: Improve stability of WheelModifier.java test Message-ID: Hi all, This pull request contains a backport of commit [668d4b07](https://github.com/openjdk/jdk/commit/668d4b077f260a30a90842a01b38a9cf6718d418) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Renjith Kannath Pariyangad on 16 Oct 2023 and was reviewed by Alexey Ivanov. Thanks! ------------- Commit messages: - Backport 668d4b077f260a30a90842a01b38a9cf6718d418 Changes: https://git.openjdk.org/jdk21u-dev/pull/153/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=153&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318154 Stats: 25 lines in 1 file changed: 16 ins; 1 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/153.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/153/head:pull/153 PR: https://git.openjdk.org/jdk21u-dev/pull/153 From szaldana at openjdk.org Thu Jan 11 15:29:58 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Thu, 11 Jan 2024 15:29:58 GMT Subject: [jdk21u-dev] RFR: 8316106: Open source few swing JInternalFrame and JMenuBar tests Message-ID: Hi all, This pull request contains a backport of commit [0775bf2f](https://github.com/openjdk/jdk/commit/0775bf2f0375b1bc63c187399cbc3fdc5a192bce) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Abhishek Kumar on 15 Sep 2023 and was reviewed by Alexander Zuev and Tejesh R. Thanks! ------------- Commit messages: - Backport 0775bf2f0375b1bc63c187399cbc3fdc5a192bce Changes: https://git.openjdk.org/jdk21u-dev/pull/152/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=152&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316106 Stats: 457 lines in 5 files changed: 457 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/152.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/152/head:pull/152 PR: https://git.openjdk.org/jdk21u-dev/pull/152 From szaldana at openjdk.org Thu Jan 11 15:31:38 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Thu, 11 Jan 2024 15:31:38 GMT Subject: [jdk21u-dev] RFR: 8319103: Popups that request focus are not shown on Linux with Wayland Message-ID: Hi all, This pull request contains a backport of commit [f3ed2758](https://github.com/openjdk/jdk/commit/f3ed27582e16c3a323f590863cbeec6d35e20b58) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alexander Zvegintsev on 16 Nov 2023 and was reviewed by Sergey Bylokhov and Phil Race. Thanks! ------------- Commit messages: - Backport f3ed27582e16c3a323f590863cbeec6d35e20b58 Changes: https://git.openjdk.org/jdk21u-dev/pull/155/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=155&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319103 Stats: 128 lines in 2 files changed: 121 ins; 5 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/155.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/155/head:pull/155 PR: https://git.openjdk.org/jdk21u-dev/pull/155 From goetz at openjdk.org Thu Jan 11 16:14:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 11 Jan 2024 16:14:39 GMT Subject: [jdk11u-dev] Integrated: 8259801: Enable XML Signature secure validation mode by default In-Reply-To: References: Message-ID: <8dq3wwCe0qH8O2PGWdEFKfbB2-yFAuKsoua7ggYXaDg=.34b80357-a0f0-49e5-8997-52d45cc593db@github.com> On Wed, 3 Jan 2024 12:03:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.23-oracle. > > I resolved the Copyright in the test, will mark clean. > > I have to check for the backport CSR. > > Update: CSR available now: https://bugs.openjdk.org/browse/JDK-8323287 This pull request has now been integrated. Changeset: e55aac2b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/e55aac2bf7846663529209f3b12aac82710b0501 Stats: 54 lines in 3 files changed: 12 ins; 3 del; 39 mod 8259801: Enable XML Signature secure validation mode by default Backport-of: baf46bac41f11c01691c4d4c77b24f76fedb5926 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2426 From phh at openjdk.org Thu Jan 11 22:33:25 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 11 Jan 2024 22:33:25 GMT Subject: [jdk17u-dev] RFR: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA In-Reply-To: References: Message-ID: On Wed, 10 Jan 2024 01:23:13 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/aba19334eaeb46d37169cddeef929b13e050a60e from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 9 Jan 2024 and was reviewed by Philip Race. > > The patch is functionally the same but different in context due to the next patch is missing in 17: > https://bugs.openjdk.org/browse/JDK-8294488 I do not plan to backport that cleanup > > Thanks! Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2118#pullrequestreview-1816915517 From phh at openjdk.org Thu Jan 11 23:02:23 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 11 Jan 2024 23:02:23 GMT Subject: [jdk21u-dev] RFR: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 20:14:19 GMT, Aleksey Shipilev wrote: > Nearly clean backport to fix a Loom bug. The uncleanliness is due to `foreign_globals.cpp` context change in `ForeignGlobals::java_calling_convention`, which renamed the argument. I reapplied that hunk by hand. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `jdk_loom hotspot_loom` > - [x] linux-aarch64-server-fastdebug, `tier{1,2,3,4}` > - [x] linux-x86_64-server-fastdebug, `tier{1,2,3,4}` Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/131#pullrequestreview-1816984618 From andrewlu at openjdk.org Fri Jan 12 02:06:39 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 12 Jan 2024 02:06:39 GMT Subject: [jdk11u-dev] Integrated: 8306076: Open source AWT misc tests In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 01:46:34 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: e7f17f1b Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/e7f17f1bf7352472c610e1a25fc2a9c6b64e5047 Stats: 169 lines in 3 files changed: 169 ins; 0 del; 0 mod 8306076: Open source AWT misc tests Backport-of: f7d45b85a5c664a87c94e0baccd8b9eddce27e2c ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2439 From andrewlu at openjdk.org Fri Jan 12 05:16:14 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 12 Jan 2024 05:16:14 GMT Subject: [jdk11u-dev] RFR: 8276796: gc/TestSystemGC.java large pages subtest fails with ZGC [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.23-oracle. > Backport for JDK-8269077 and JDK-8276796, > for JDK-8269077, it's clean, as CMS test is remain in this file, only modify the '@test id=CMS', other added parts are clean. Local test pass. Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: add -XX:+UnlockExperimentalVMOptions ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2442/files - new: https://git.openjdk.org/jdk11u-dev/pull/2442/files/c982127b..5b8a4e20 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2442&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2442&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2442.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2442/head:pull/2442 PR: https://git.openjdk.org/jdk11u-dev/pull/2442 From lmao at openjdk.org Fri Jan 12 06:17:26 2024 From: lmao at openjdk.org (Liang Mao) Date: Fri, 12 Jan 2024 06:17:26 GMT Subject: [jdk11u-dev] RFR: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2 [v2] In-Reply-To: References: <0dBbEQspU0YzRIlNR73gHPiB8djK8a3SO4hwgjGcqJ8=.8bb1a2ef-5396-47cf-81dc-dcbdcd3c4a32@github.com> Message-ID: On Tue, 9 Jan 2024 10:40:12 GMT, Andrew Haley wrote: > OK. On further contemplation, this falls within the scope of a change intended to keep the JDK working well as the world moves on. It doesn't set any precedents for other performance backports. Hi APH, could you please help to sponsor? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2425#issuecomment-1888494342 From clanger at openjdk.org Fri Jan 12 07:10:14 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 12 Jan 2024 07:10:14 GMT Subject: [jdk21u-dev] RFR: 8320309: AIX: pthreads created by foreign test library don't work as expected Message-ID: Hi all, This pull request contains a backport of [JDK-8320309](https://bugs.openjdk.org/browse/JDK-8320309), commit [8b47a149](https://github.com/openjdk/jdk/commit/8b47a14958913c70291d46afdde4e527f9bdc91a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Varada M on 22 Nov 2023 and was reviewed by Martin Doerr, Matthias Baesken and Thomas Stuefe. Thanks! ------------- Commit messages: - Backport 8b47a14958913c70291d46afdde4e527f9bdc91a Changes: https://git.openjdk.org/jdk21u-dev/pull/159/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=159&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320309 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/159.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/159/head:pull/159 PR: https://git.openjdk.org/jdk21u-dev/pull/159 From goetz at openjdk.org Fri Jan 12 07:36:00 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 12 Jan 2024 07:36:00 GMT Subject: [jdk11u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 Message-ID: This backport is based on https://github.com/openjdk/jdk17u-dev/pull/2116 , the minimal version. It contains the full EdDSA functionality and only removes the Strings that are explicitly not documented for backport in the CSRs. I needed the following adaptions you find in seperate commits: **Resolves**: The implementation in the jdk patched clean. There were some conflicts in the tests: test/jdk/TEST.groups trivial resolve due to context. test/jdk/javax/xml/crypto/dsig/GenerationTests.java trivial resolve due to context. 8241306 is missing in the context. test/jdk/javax/xml/crypto/dsig/SecureValidation.java This file is not in 11. It came with "8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params" which was not backported. Changes omitted. test/lib/jdk/test/lib/security/XMLUtils.java One chunk does not apply because the removed code differs. In 17, a switch statement is used that was adapted to Java 11. Moved the comment and exception thrown in 11 to the new place. **Make it compile and make the tests work**: The changes to the libraries compile out of the box. The tests needed several adaptions. I did not remove the bad code yet, but just commented it out to highlight the differences better for now. test/jdk/javax/xml/crypto/dsig/Basic.java I had to remove test cases because 8241305: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params 8166597: Crypto support for the EdDSA Signature Algorithm are not in 11. test/jdk/javax/xml/crypto/dsig/GenerationTests.java To make it compile, I replaced HexFormat.of().parseHex() by jdk.test.lib.Utils.toByteArray(). Further, I commented a row of test coding that does not compile. "8166597: Crypto support for the EdDSA Signature Algorithm" would be needed to get these test cases working. This effectively removes the test cases for the new functionality. test/jdk/javax/xml/crypto/dsig/HereFunction.java A simple tweak to enable testing of sha1 is not needed in 11. In 11, sha1 is still available per default as "8259709: Disable SHA-1 XML Signatures" was not backported. test/lib/jdk/test/lib/security/XMLUtils.java More complex resolve because a previous backport was already adapted to 11. The code in 17 uses incompatible switch and instanceof in several places. It also needed adaptions because it does not compile as 8166597: Crypto support for the EdDSA Signature Algorithm is not in 11. ------------- Commit messages: - Merge branch 'openjdk:master' into goetz_backport_8305972-minimal - Fix tests, they now all pass - Resolve chunks that did not apply. - Backport 8309572 17u minimal change -- clean parts Changes: https://git.openjdk.org/jdk11u-dev/pull/2455/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2455&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305972 Stats: 1175 lines in 37 files changed: 917 ins; 144 del; 114 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2455.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2455/head:pull/2455 PR: https://git.openjdk.org/jdk11u-dev/pull/2455 From goetz at openjdk.org Fri Jan 12 07:36:00 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 12 Jan 2024 07:36:00 GMT Subject: [jdk11u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 In-Reply-To: References: Message-ID: <-_tZxJWHIGSKLTuMNP6DshFzfqHS9zaz8XR8haF7O5I=.c900915b-4ee4-4743-b889-8edaf33d22a4@github.com> On Thu, 11 Jan 2024 19:19:19 GMT, Goetz Lindenmaier wrote: > This backport is based on https://github.com/openjdk/jdk17u-dev/pull/2116 , the minimal version. > It contains the full EdDSA functionality and only removes the Strings that are explicitly not documented for backport in the CSRs. > > I needed the following adaptions you find in seperate commits: > > **Resolves**: > > The implementation in the jdk patched clean. > There were some conflicts in the tests: > > test/jdk/TEST.groups > trivial resolve due to context. > > test/jdk/javax/xml/crypto/dsig/GenerationTests.java > trivial resolve due to context. 8241306 is missing in the context. > > test/jdk/javax/xml/crypto/dsig/SecureValidation.java > This file is not in 11. > It came with "8241306: Add SignatureMethodParameterSpec subclass > for RSASSA-PSS params" which was not backported. Changes omitted. > > test/lib/jdk/test/lib/security/XMLUtils.java > One chunk does not apply because the removed code differs. > In 17, a switch statement is used that was adapted to Java 11. > Moved the comment and exception thrown in 11 to the new place. > > > **Make it compile and make the tests work**: > > The changes to the libraries compile out of the box. > > The tests needed several adaptions. I did not remove the > bad code yet, but just commented it out to highlight the > differences better for now. > > test/jdk/javax/xml/crypto/dsig/Basic.java > I had to remove test cases because > 8241305: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params > 8166597: Crypto support for the EdDSA Signature Algorithm > are not in 11. > > test/jdk/javax/xml/crypto/dsig/GenerationTests.java > To make it compile, I > replaced HexFormat.of().parseHex() by jdk.test.lib.Utils.toByteArray(). > Further, I commented a row of test coding that does not compile. > "8166597: Crypto support for the EdDSA Signature Algorithm" would > be needed to get these test cases working. > This effectively removes the test cases for the new functionality. > > test/jdk/javax/xml/crypto/dsig/HereFunction.java > A simple tweak to enable testing of sha1 is not needed in 11. > In 11, sha1 is still available per default as > "8259709: Disable SHA-1 XML Signatures" was not backported. > > test/lib/jdk/test/lib/security/XMLUtils.java > More complex resolve because a previous backport was already adapted to 11. > The code in 17 uses incompatible switch and instanceof > in several places. > It also needed adaptions because it does not compile as > 8166597: Crypto support for the EdDSA Signature Algorithm > is not in 11. GHA actions: jtharness download failed. Needs rerun. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2455#issuecomment-1888565481 From goetz at openjdk.org Fri Jan 12 07:41:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 12 Jan 2024 07:41:37 GMT Subject: [jdk21u-dev] RFR: 8319124: Update XML Security for Java to 3.0.3 [v2] In-Reply-To: <7Q7VgKXec5eRGqdwiBGMMxj19YbbL7Vm3AdeEnwkxfY=.952410d3-79d1-44ac-ba7e-0290e08be141@github.com> References: <7Q7VgKXec5eRGqdwiBGMMxj19YbbL7Vm3AdeEnwkxfY=.952410d3-79d1-44ac-ba7e-0290e08be141@github.com> Message-ID: <_JycgejsrzXvSYXLXMQKa-YoGPzfrZ6VdBTVXN3e5k8=.75d5f740-3fc3-4213-83c1-2977af3ef4a9@github.com> > I backport this for parity with 21.0.3-oracle. > > The patch applied clean (first commit). > > I removed the strings from SignatureMethod.java as documented in the backport CSR. > I did not change DOMSignatureMethod.java. > > I skipped the changes to GenerationTest.java. The test passes. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Fix comment ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/94/files - new: https://git.openjdk.org/jdk21u-dev/pull/94/files/e33aee4a..4c01cfa8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=94&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=94&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/94.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/94/head:pull/94 PR: https://git.openjdk.org/jdk21u-dev/pull/94 From goetz at openjdk.org Fri Jan 12 09:05:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 12 Jan 2024 09:05:37 GMT Subject: [jdk21u-dev] RFR: 8319124: Update XML Security for Java to 3.0.3 [v3] In-Reply-To: <7Q7VgKXec5eRGqdwiBGMMxj19YbbL7Vm3AdeEnwkxfY=.952410d3-79d1-44ac-ba7e-0290e08be141@github.com> References: <7Q7VgKXec5eRGqdwiBGMMxj19YbbL7Vm3AdeEnwkxfY=.952410d3-79d1-44ac-ba7e-0290e08be141@github.com> Message-ID: > I backport this for parity with 21.0.3-oracle. > > The patch applied clean (first commit). > > I removed the strings from SignatureMethod.java as documented in the backport CSR. > I did not change DOMSignatureMethod.java. > > I skipped the changes to GenerationTest.java. The test passes. > > **Update**: > I pushed a new commit that makes the four new test cases work. > As proposed in the CSR, I use the plain strings instead of the constants defined in SignaturMethod. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Make new test cases work anyways ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/94/files - new: https://git.openjdk.org/jdk21u-dev/pull/94/files/4c01cfa8..619eacc1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=94&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=94&range=01-02 Stats: 43 lines in 1 file changed: 42 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/94.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/94/head:pull/94 PR: https://git.openjdk.org/jdk21u-dev/pull/94 From goetz.lindenmaier at sap.com Fri Jan 12 09:26:26 2024 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Fri, 12 Jan 2024 09:26:26 +0000 Subject: GHA actions fail because jtharness unaccessible Message-ID: Hi, we see a lot of GHA failures in the updates repositories: e.g.: https://github.com/openjdk/jdk11u-dev/pull/2455 https://github.com/openjdk/jdk17u-dev/pull/2120 https://github.com/openjdk/jdk21u-dev/pull/159 also in head: https://github.com/openjdk/jdk/pull/17388 with this error message: Downloading https://git.openjdk.java.net/jtharness/archive/jt6.0-b14.zip to /home/runner/work/jdk11u-dev/jdk11u-dev/jtreg/src/make/../build/deps/jtharness/src/../source.zip Error: sh][ERROR] wget exited with exit code 4 It seems to be an intermittent issue. Is there something that needs to be done? Or is it a problem of the resource? Best regards, Goetz. -------------- next part -------------- An HTML attachment was scrubbed... URL: From mbaesken at openjdk.org Fri Jan 12 11:05:25 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 12 Jan 2024 11:05:25 GMT Subject: [jdk22u] Integrated: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 14:30:22 GMT, Matthias Baesken wrote: > 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size This pull request has now been integrated. Changeset: 3257d9db Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/3257d9db0b691d86643d01a805beda71d158fafd Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size Backport-of: b31454e36234091c3827c3b4d07f62345cb0cee4 ------------- PR: https://git.openjdk.org/jdk22u/pull/11 From mbaesken at openjdk.org Fri Jan 12 11:11:39 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 12 Jan 2024 11:11:39 GMT Subject: [jdk22u] RFR: 8323331: fix typo hpage_pdm_size Message-ID: 8323331: fix typo hpage_pdm_size ------------- Commit messages: - Backport 16170678a72dbd7eecf55c21a426fb6179362fba Changes: https://git.openjdk.org/jdk22u/pull/19/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=19&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323331 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/19.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/19/head:pull/19 PR: https://git.openjdk.org/jdk22u/pull/19 From mbaesken at openjdk.org Fri Jan 12 12:50:56 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 12 Jan 2024 12:50:56 GMT Subject: [jdk22u] RFR: 8323008: filter out harmful -std* flags added by autoconf from CXX Message-ID: 8323008: filter out harmful -std* flags added by autoconf from CXX ------------- Commit messages: - Backport 68c4286026bc2c0ec0f594e0b96fe03fe5624d6d Changes: https://git.openjdk.org/jdk22u/pull/20/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=20&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323008 Stats: 8 lines in 2 files changed: 4 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk22u/pull/20.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/20/head:pull/20 PR: https://git.openjdk.org/jdk22u/pull/20 From goetz at openjdk.org Fri Jan 12 13:05:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 12 Jan 2024 13:05:47 GMT Subject: [jdk21u-dev] RFR: 8310923: Refactor Currency tests to use JUnit Message-ID: I backport this to keep the 21u test suite up-to-date. This will simplify future test backports. ------------- Commit messages: - Backport e848d9471f5de86e5ac157b710cd7371f12f0024 Changes: https://git.openjdk.org/jdk21u-dev/pull/162/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=162&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310923 Stats: 1089 lines in 9 files changed: 436 ins; 372 del; 281 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/162.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/162/head:pull/162 PR: https://git.openjdk.org/jdk21u-dev/pull/162 From lmao at openjdk.org Fri Jan 12 13:10:38 2024 From: lmao at openjdk.org (Liang Mao) Date: Fri, 12 Jan 2024 13:10:38 GMT Subject: [jdk11u-dev] Integrated: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2 In-Reply-To: References: Message-ID: On Tue, 2 Jan 2024 02:45:29 GMT, Liang Mao wrote: > Backport of JDK-8280007. The change should be enabled in JDK11 better performance on Neoverse V1/N1/N2. It is quite safe for existing in upstream and 17u for years. > > Additional testing: aarch64 server ARM Neoverse N2 release/fastdebug tier1 This pull request has now been integrated. Changeset: 7262e7de Author: Liang Mao Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/7262e7deb12c197cb7d7bd3b913bf4ab71d1767b Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2 Reviewed-by: aph Backport-of: f823bed043dc38d838baaf8c2024ef24b8a50e9b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2425 From jpai at openjdk.org Fri Jan 12 13:26:43 2024 From: jpai at openjdk.org (Jaikiran Pai) Date: Fri, 12 Jan 2024 13:26:43 GMT Subject: [jdk17u-dev] RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address Message-ID: Can I please get a review for this change which backports the fix that was done in https://bugs.openjdk.org/browse/JDK-8305906? The fix in the source is a clean backport. However, the newly introduced test in mainline uses a test specific libraries which aren't the same in 17u. As a result, the tests `test/jdk/java/net/httpclient/http2/ConnectionReuseTest.java` had conflicts. I have manually updated relevant parts of that test to make it use the test libraries that are available and applicable in 17u. I have also verified that the test fails (as expected) if I undo the source change and passes when I re-introduce the source change. Additionally, I have run this test in our CI to verify that it passes. ------------- Commit messages: - remove unintentional debug system property - test changes to accomodate test infrastructure in 17u - Backport 3ccb3c0e09f9a414229d3f76031f3fc8f271c936 Changes: https://git.openjdk.org/jdk17u-dev/pull/2121/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2121&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305906 Stats: 211 lines in 4 files changed: 199 ins; 4 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2121.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2121/head:pull/2121 PR: https://git.openjdk.org/jdk17u-dev/pull/2121 From goetz at openjdk.org Fri Jan 12 13:29:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 12 Jan 2024 13:29:46 GMT Subject: [jdk21u-dev] RFR: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 8ae309ebacd6947bbad2ef168ca13702e1cba099 Changes: https://git.openjdk.org/jdk21u-dev/pull/163/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=163&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318971 Stats: 86 lines in 2 files changed: 84 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/163.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/163/head:pull/163 PR: https://git.openjdk.org/jdk21u-dev/pull/163 From mdoerr at openjdk.org Fri Jan 12 13:34:29 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 12 Jan 2024 13:34:29 GMT Subject: [jdk11u-dev] RFR: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries In-Reply-To: References: Message-ID: On Wed, 10 Jan 2024 09:12:03 GMT, Goetz Lindenmaier wrote: > This is a backout needed as the change is too intrusive for a backport. > Backport of the 17 change. > > This is not clean because in 11 > * an extra import was needed > * a """ string was adapted to 11 syntax > > The backout was crafted with two git revert commands. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2450#pullrequestreview-1818273738 From goetz at openjdk.org Fri Jan 12 13:35:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 12 Jan 2024 13:35:41 GMT Subject: [jdk17u-dev] RFR: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 8ae309ebacd6947bbad2ef168ca13702e1cba099 Changes: https://git.openjdk.org/jdk17u-dev/pull/2122/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2122&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318971 Stats: 86 lines in 2 files changed: 84 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2122.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2122/head:pull/2122 PR: https://git.openjdk.org/jdk17u-dev/pull/2122 From mbaesken at openjdk.org Fri Jan 12 13:58:57 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 12 Jan 2024 13:58:57 GMT Subject: [jdk17u-dev] RFR: 8320300: Adjust hs_err output in malloc/mmap error cases Message-ID: Backport 8320300 ------------- Commit messages: - Backport 60c8d9c045be16fee99a83117844c2a8100f7c1a Changes: https://git.openjdk.org/jdk17u-dev/pull/2123/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2123&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320300 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2123.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2123/head:pull/2123 PR: https://git.openjdk.org/jdk17u-dev/pull/2123 From mbaesken at openjdk.org Fri Jan 12 14:24:31 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 12 Jan 2024 14:24:31 GMT Subject: [jdk17u-dev] RFR: 8280241: (aio) AsynchronousSocketChannel init fails in IPv6 only Windows env Message-ID: 8280241: (aio) AsynchronousSocketChannel init fails in IPv6 only Windows env ------------- Commit messages: - Backport 36fbec78be837fe1defb72f39c6e3f2b5135fddf Changes: https://git.openjdk.org/jdk17u-dev/pull/2124/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2124&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280241 Stats: 10 lines in 2 files changed: 8 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2124.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2124/head:pull/2124 PR: https://git.openjdk.org/jdk17u-dev/pull/2124 From mbaesken at openjdk.org Fri Jan 12 14:37:24 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 12 Jan 2024 14:37:24 GMT Subject: [jdk21u-dev] RFR: 8319124: Update XML Security for Java to 3.0.3 [v3] In-Reply-To: References: <7Q7VgKXec5eRGqdwiBGMMxj19YbbL7Vm3AdeEnwkxfY=.952410d3-79d1-44ac-ba7e-0290e08be141@github.com> Message-ID: On Fri, 12 Jan 2024 09:05:37 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 21.0.3-oracle. >> >> The patch applied clean (first commit). >> >> I removed the strings from SignatureMethod.java as documented in the backport CSR. >> I did not change DOMSignatureMethod.java. >> >> I skipped the changes to GenerationTest.java. The test passes. >> >> **Update**: >> I pushed a new commit that makes the four new test cases work. >> As proposed in the CSR, I use the plain strings instead of the constants defined in SignaturMethod. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Make new test cases work anyways Marked as reviewed by mbaesken (Reviewer). > I use the plain strings instead of the constants defined in SignaturMethod. Little typo, SignatureMethod . Yes I think this is correct according to the CSR for older releases https://bugs.openjdk.org/browse/JDK-8321532 . ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/94#pullrequestreview-1818396941 PR Comment: https://git.openjdk.org/jdk21u-dev/pull/94#issuecomment-1889373892 From jwaters at openjdk.org Fri Jan 12 14:56:35 2024 From: jwaters at openjdk.org (Julian Waters) Date: Fri, 12 Jan 2024 14:56:35 GMT Subject: [jdk22u] RFR: 8323008: filter out harmful -std* flags added by autoconf from CXX In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 14:51:51 GMT, Matthias Baesken wrote: > > Could you hold this backport for a moment? [openjdk/jdk#17401](https://github.com/openjdk/jdk/pull/17401) > > okay, the GHA#s are not doing well currently anyway ... Yeah, no idea what's causing JTReg to explode on GHAs at the moment :/ ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/20#issuecomment-1889424187 From mbaesken at openjdk.org Fri Jan 12 14:56:34 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 12 Jan 2024 14:56:34 GMT Subject: [jdk22u] RFR: 8323008: filter out harmful -std* flags added by autoconf from CXX In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 12:43:33 GMT, Matthias Baesken wrote: > 8323008: filter out harmful -std* flags added by autoconf from CXX > Could you hold this backport for a moment? [openjdk/jdk#17401](https://github.com/openjdk/jdk/pull/17401) okay, the GHA#s are not doing well currently anyway ... ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/20#issuecomment-1889418902 From jwaters at openjdk.org Fri Jan 12 14:56:33 2024 From: jwaters at openjdk.org (Julian Waters) Date: Fri, 12 Jan 2024 14:56:33 GMT Subject: [jdk22u] RFR: 8323008: filter out harmful -std* flags added by autoconf from CXX In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 12:43:33 GMT, Matthias Baesken wrote: > 8323008: filter out harmful -std* flags added by autoconf from CXX Could you hold this backport for a moment? https://github.com/openjdk/jdk/pull/17401 ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/20#issuecomment-1889412412 From goetz at openjdk.org Fri Jan 12 15:09:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 12 Jan 2024 15:09:54 GMT Subject: [jdk21u-dev] RFR: 8319124: Update XML Security for Java to 3.0.3 [v4] In-Reply-To: <7Q7VgKXec5eRGqdwiBGMMxj19YbbL7Vm3AdeEnwkxfY=.952410d3-79d1-44ac-ba7e-0290e08be141@github.com> References: <7Q7VgKXec5eRGqdwiBGMMxj19YbbL7Vm3AdeEnwkxfY=.952410d3-79d1-44ac-ba7e-0290e08be141@github.com> Message-ID: > I backport this for parity with 21.0.3-oracle. > > The patch applied clean (first commit). > > I removed the strings from SignatureMethod.java as documented in the backport CSR. > I did not change DOMSignatureMethod.java. > > I skipped the changes to GenerationTest.java. The test passes. > > **Update**: > I pushed a new commit that makes the four new test cases work. > As proposed in the CSR, I use the plain strings instead of the constants defined in SignaturMethod. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'openjdk:master' into goetz_backport_8319124 - Make new test cases work anyways - Fix comment - Undo changes not suitable for 21 - Backport 1c0bd81a10f97c752818163a573d5983c7e481ac ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/94/files - new: https://git.openjdk.org/jdk21u-dev/pull/94/files/619eacc1..41beac9e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=94&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=94&range=02-03 Stats: 5628 lines in 750 files changed: 2799 ins; 654 del; 2175 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/94.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/94/head:pull/94 PR: https://git.openjdk.org/jdk21u-dev/pull/94 From goetz at openjdk.org Fri Jan 12 15:22:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 12 Jan 2024 15:22:32 GMT Subject: [jdk21u-dev] RFR: 8319124: Update XML Security for Java to 3.0.3 [v4] In-Reply-To: References: <7Q7VgKXec5eRGqdwiBGMMxj19YbbL7Vm3AdeEnwkxfY=.952410d3-79d1-44ac-ba7e-0290e08be141@github.com> Message-ID: On Fri, 12 Jan 2024 15:09:54 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 21.0.3-oracle. >> >> The patch applied clean (first commit). >> >> I removed the strings from SignatureMethod.java as documented in the backport CSR. >> I did not change DOMSignatureMethod.java. >> >> I skipped the changes to GenerationTest.java. The test passes. >> >> **Update**: >> I pushed a new commit that makes the four new test cases work. >> As proposed in the CSR, I use the plain strings instead of the constants defined in SignaturMethod. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'openjdk:master' into goetz_backport_8319124 > - Make new test cases work anyways > - Fix comment > - Undo changes not suitable for 21 > - Backport 1c0bd81a10f97c752818163a573d5983c7e481ac GHA tests had been clean before I updated the test. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/94#issuecomment-1889493883 From igavrilin at openjdk.org Fri Jan 12 15:23:36 2024 From: igavrilin at openjdk.org (Ilya Gavrilin) Date: Fri, 12 Jan 2024 15:23:36 GMT Subject: [jdk22u] RFR: 8322790: RISC-V: Tune costs for shuffles with no conversion Message-ID: Hi all, I would like to backport [JDK-8322790](https://bugs.openjdk.org/browse/JDK-8322790) to jdk22u in order to improve performance for methods operating with integer representations of floating point values. Patch applies clean. ------------- Commit messages: - Backport 2acb5bd9924511b58b0e57ea9eb6c2dee9fd3ee8 Changes: https://git.openjdk.org/jdk22u/pull/22/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=22&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322790 Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk22u/pull/22.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/22/head:pull/22 PR: https://git.openjdk.org/jdk22u/pull/22 From phh at openjdk.org Fri Jan 12 19:23:32 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 12 Jan 2024 19:23:32 GMT Subject: [jdk17u-dev] RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address In-Reply-To: References: Message-ID: On Thu, 11 Jan 2024 11:28:46 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which backports the fix that was done in https://bugs.openjdk.org/browse/JDK-8305906? > > The fix in the source is a clean backport. However, the newly introduced test in mainline uses a test specific libraries which aren't the same in 17u. As a result, the tests `test/jdk/java/net/httpclient/http2/ConnectionReuseTest.java` had conflicts. I have manually updated relevant parts of that test to make it use the test libraries that are available and applicable in 17u. > > I have also verified that the test fails (as expected) if I undo the source change and passes when I re-introduce the source change. Additionally, I have run this test in our CI to verify that it passes. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2121#pullrequestreview-1818893345 From clanger at openjdk.org Sat Jan 13 17:34:21 2024 From: clanger at openjdk.org (Christoph Langer) Date: Sat, 13 Jan 2024 17:34:21 GMT Subject: [jdk22u] RFR: 8323008: filter out harmful -std* flags added by autoconf from CXX In-Reply-To: References: Message-ID: <3QEQGEhYu_Os8P6K1mJcbxsGxbF-QYTJy_3V6Zhylxc=.338f5827-7b2e-4047-80fc-6cbc984d2e57@github.com> On Fri, 12 Jan 2024 12:43:33 GMT, Matthias Baesken wrote: > 8323008: filter out harmful -std* flags added by autoconf from CXX Can we please close this in favour of the backport to jdk22: https://github.com/openjdk/jdk22/pull/70 It's a P3 fix, eligible under RDP1 rules. And I'd like to have the flags filtered out in all builds wherever possible. @TheShermanTanker did you spot any problem with the change, except for the GHA issues? ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/20#issuecomment-1890601991 From jwaters at openjdk.org Sat Jan 13 18:08:33 2024 From: jwaters at openjdk.org (Julian Waters) Date: Sat, 13 Jan 2024 18:08:33 GMT Subject: [jdk22u] RFR: 8323008: filter out harmful -std* flags added by autoconf from CXX In-Reply-To: <3QEQGEhYu_Os8P6K1mJcbxsGxbF-QYTJy_3V6Zhylxc=.338f5827-7b2e-4047-80fc-6cbc984d2e57@github.com> References: <3QEQGEhYu_Os8P6K1mJcbxsGxbF-QYTJy_3V6Zhylxc=.338f5827-7b2e-4047-80fc-6cbc984d2e57@github.com> Message-ID: On Sat, 13 Jan 2024 17:31:47 GMT, Christoph Langer wrote: >> 8323008: filter out harmful -std* flags added by autoconf from CXX > > Can we please close this in favour of the backport to jdk22: https://github.com/openjdk/jdk22/pull/70 > > It's a P3 fix, eligible under RDP1 rules. And I'd like to have the flags filtered out in all builds wherever possible. > > @TheShermanTanker did you spot any problem with the change, except for the GHA issues? @RealCLanger Nope, looks ok to me (Hopefully we can come up with a better solution to this problem in the future though...) ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/20#issuecomment-1890638790 From serb at openjdk.org Sat Jan 13 19:34:29 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 13 Jan 2024 19:34:29 GMT Subject: [jdk22u] RFR: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA Message-ID: Hi all, This pull request contains a backport of commit [aba19334](https://github.com/openjdk/jdk/commit/aba19334eaeb46d37169cddeef929b13e050a60e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 9 Jan 2024 and was reviewed by Phil Race. Thanks! ------------- Commit messages: - Backport aba19334eaeb46d37169cddeef929b13e050a60e Changes: https://git.openjdk.org/jdk22u/pull/23/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=23&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323210 Stats: 8 lines in 2 files changed: 5 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk22u/pull/23.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/23/head:pull/23 PR: https://git.openjdk.org/jdk22u/pull/23 From kyukihiro at openjdk.org Sun Jan 14 23:40:57 2024 From: kyukihiro at openjdk.org (Kimura Yukihiro) Date: Sun, 14 Jan 2024 23:40:57 GMT Subject: [jdk11u-dev] RFR: 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows Message-ID: <_Jjn9WIIQt8Jmuv_ugzxUcT1rFiXtd9yDM2OyKj84hs=.5c8bdd6f-ef1b-426c-b93d-3a9f1aa22111@github.com> I would like to fix this issue because the test dose not work as intended. 8318410 resolved two issues. However, the first issue related to JEP400 is not relevant to JDK11. Therefore, I would like to backport only the second issue, which is the problem of tests not running properly on Windows cygwin. Backporting to JDK11 is the same as backporting to JDK17 which has already done. Could someone please review it? Thanks, Kimura Yukihiro ------------- Commit messages: - Backport d051f22284e7ccc288c658588f73da672d9bfacd Changes: https://git.openjdk.org/jdk11u-dev/pull/2456/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2456&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318410 Stats: 24 lines in 2 files changed: 20 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2456.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2456/head:pull/2456 PR: https://git.openjdk.org/jdk11u-dev/pull/2456 From goetz at openjdk.org Mon Jan 15 07:13:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 15 Jan 2024 07:13:46 GMT Subject: [jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.11-oracle. > > This is a minimal version that only removes the strings from the interface, as well as the comment. Removing these is explicitly stated in the CSR. > > The change keeps the EdDSA implementation. As I understand, 17 supports EdDSA in general, it was just not included for XML when 17 was released. > https://bugs.openjdk.org/browse/JDK-8305972 Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into goetz_backport_8305972-minimal - Remove Strings as proposed in CSR - Backport f0aebc8141de5a50c88658a40caa01967a9afc53 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2116/files - new: https://git.openjdk.org/jdk17u-dev/pull/2116/files/b0809398..d294d014 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2116&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2116&range=01-02 Stats: 1188 lines in 29 files changed: 641 ins; 480 del; 67 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2116.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2116/head:pull/2116 PR: https://git.openjdk.org/jdk17u-dev/pull/2116 From serb at openjdk.org Mon Jan 15 07:34:45 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 15 Jan 2024 07:34:45 GMT Subject: [jdk17u-dev] RFR: 8309462: [AIX] vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop Message-ID: Hi all, This pull request contains a backport of commit [cf9e6353](https://github.com/openjdk/jdk/commit/cf9e6353cc6fe9e57a7a9883813d09892e7e7621) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by JoKern65 on 12 Jun 2023 and was reviewed by Matthias Baesken, Martin Doerr and Christoph Langer. Thanks! ------------- Commit messages: - Backport cf9e6353cc6fe9e57a7a9883813d09892e7e7621 Changes: https://git.openjdk.org/jdk17u-dev/pull/2125/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2125&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309462 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2125.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2125/head:pull/2125 PR: https://git.openjdk.org/jdk17u-dev/pull/2125 From goetz at openjdk.org Mon Jan 15 07:41:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 15 Jan 2024 07:41:30 GMT Subject: [jdk17u-dev] RFR: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation In-Reply-To: References: Message-ID: <7l3OgKeA_9mNbQlv3VPVLDfMnshGVzfEeN682__VncE=.7d1be42e-e3ea-461a-8fa3-268f6d23f74c@github.com> On Mon, 8 Jan 2024 19:33:52 GMT, William Kemper wrote: > 8323086: Shenandoah: Heap could be corrupted by oom during evacuation @earthling-amzn I removed the fix-request tag. Please label again when we develop 17.0.12. Also, please follow https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix in your fix-request comment. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2114#issuecomment-1891477442 From andrewlu at openjdk.org Mon Jan 15 09:27:21 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 15 Jan 2024 09:27:21 GMT Subject: [jdk11u-dev] Integrated: 8306871: Open source more AWT Drag & Drop tests In-Reply-To: <2QAvi-HJ8DLLyovurcVNShQup5HT3zS1nFxcKjHIKcQ=.191aebfc-fb54-490a-b382-852aa345c79b@github.com> References: <2QAvi-HJ8DLLyovurcVNShQup5HT3zS1nFxcKjHIKcQ=.191aebfc-fb54-490a-b382-852aa345c79b@github.com> Message-ID: On Tue, 9 Jan 2024 07:44:39 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: 3bb03ee3 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/3bb03ee32c7c52357b8d0c699d2129123a3cdf95 Stats: 1915 lines in 6 files changed: 1915 ins; 0 del; 0 mod 8306871: Open source more AWT Drag & Drop tests Backport-of: b5a48277ab5b42c4b13db7ddb5418a17ada512ec ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2447 From andrewlu at openjdk.org Mon Jan 15 09:28:01 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 15 Jan 2024 09:28:01 GMT Subject: [jdk11u-dev] Integrated: 8307381: Open Source JFrame, JIF related Swing Tests In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 08:41:16 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: 8aa55098 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/8aa5509891bf36942593f4bb2c27cf546e785c87 Stats: 354 lines in 6 files changed: 354 ins; 0 del; 0 mod 8307381: Open Source JFrame, JIF related Swing Tests Backport-of: 4386d42d31af9042121581cd3fd4d5a7cf8961e6 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2449 From serb at openjdk.org Mon Jan 15 11:12:39 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 15 Jan 2024 11:12:39 GMT Subject: [jdk11u-dev] RFR: 8309462: [AIX] vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop Message-ID: Hi all, This pull request contains a backport of commit [cf9e6353](https://github.com/openjdk/jdk/commit/cf9e6353cc6fe9e57a7a9883813d09892e7e7621) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by JoKern65 on 12 Jun 2023 and was reviewed by Matthias Baesken, Martin Doerr and Christoph Langer. Thanks! ------------- Commit messages: - Backport cf9e6353cc6fe9e57a7a9883813d09892e7e7621 Changes: https://git.openjdk.org/jdk11u-dev/pull/2457/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2457&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309462 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2457.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2457/head:pull/2457 PR: https://git.openjdk.org/jdk11u-dev/pull/2457 From goetz at openjdk.org Mon Jan 15 12:52:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 15 Jan 2024 12:52:28 GMT Subject: [jdk17u-dev] RFR: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 13:28:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. retest this please ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2122#issuecomment-1892118282 From omikhaltcova at openjdk.org Mon Jan 15 13:17:31 2024 From: omikhaltcova at openjdk.org (Olga Mikhaltsova) Date: Mon, 15 Jan 2024 13:17:31 GMT Subject: [jdk22u] RFR: 8318158: RISC-V: implement roundD/roundF intrinsics Message-ID: I would like to backport [JDK-8318158](https://bugs.openjdk.org/browse/JDK-8318158) to jdk22u in order to optimize performance in double/float rounding operations by means of intrinsics. The patch applied cleanly. Tested: no regression in tier1 tests. The benchmark shows the following performance improvement on the T-Head RVB-ICE board: **Before** Benchmark (TESTSIZE) Mode Cnt Score Error Units FpRoundingBenchmark.test_round_double 2048 thrpt 15 59.722 0.259 ops/ms FpRoundingBenchmark.test_round_float 2048 thrpt 15 49.729 0.127 ops/ms **After** Benchmark (TESTSIZE) Mode Cnt Score Error Units FpRoundingBenchmark.test_round_double 2048 thrpt 15 118.496 0.277 ops/ms FpRoundingBenchmark.test_round_float 2048 thrpt 15 121.008 0.488 ops/ms ------------- Commit messages: - Backport 19147f326c6b0e78fe72f9a7e7100047f16a0921 Changes: https://git.openjdk.org/jdk22u/pull/21/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=21&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318158 Stats: 82 lines in 3 files changed: 82 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/21.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/21/head:pull/21 PR: https://git.openjdk.org/jdk22u/pull/21 From omikhaltcova at openjdk.org Mon Jan 15 13:19:34 2024 From: omikhaltcova at openjdk.org (Olga Mikhaltsova) Date: Mon, 15 Jan 2024 13:19:34 GMT Subject: [jdk21u-dev] RFR: 8318158: RISC-V: implement roundD/roundF intrinsics Message-ID: I would like to backport [JDK-8318158](https://bugs.openjdk.org/browse/JDK-8318158) to jdk21u in order to optimize performance in double/float rounding operations by means of intrinsics. The patch applied cleanly. Tested: tier1 tests passed. The benchmark shows the following performance improvement on the T-Head RVB-ICE board: **Before** Benchmark (TESTSIZE) Mode Cnt Score Error Units FpRoundingBenchmark.test_round_double 2048 thrpt 15 58.679 ? 0.965 ops/ms FpRoundingBenchmark.test_round_float 2048 thrpt 15 49.252 ? 0.887 ops/ms **After** Benchmark (TESTSIZE) Mode Cnt Score Error Units FpRoundingBenchmark.test_round_double 2048 thrpt 15 117.264 ? 1.254 ops/ms FpRoundingBenchmark.test_round_float 2048 thrpt 15 119.752 ? 1.751 ops/ms ------------- Commit messages: - Backport 19147f326c6b0e78fe72f9a7e7100047f16a0921 Changes: https://git.openjdk.org/jdk21u-dev/pull/161/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=161&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318158 Stats: 82 lines in 3 files changed: 82 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/161.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/161/head:pull/161 PR: https://git.openjdk.org/jdk21u-dev/pull/161 From goetz at openjdk.org Mon Jan 15 14:16:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 15 Jan 2024 14:16:38 GMT Subject: [jdk21u-dev] RFR: 8306922: IR verification fails because IR dump is chopped up Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 9057b3503349ead7d995b1a705317324830eabb2 Changes: https://git.openjdk.org/jdk21u-dev/pull/167/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=167&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306922 Stats: 173 lines in 8 files changed: 26 ins; 6 del; 141 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/167.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/167/head:pull/167 PR: https://git.openjdk.org/jdk21u-dev/pull/167 From goetz at openjdk.org Mon Jan 15 14:21:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 15 Jan 2024 14:21:37 GMT Subject: [jdk21u-dev] RFR: 8311986: Disable runtime/os/TestTracePageSizes.java for ShenandoahGC Message-ID: <2UdIibnEOqz_dvzDTzfB1xWdxcGV_n8RoB3EOhrR0YA=.42e56db5-752c-46eb-848b-5a62456e4873@github.com> I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 167d1c183546a9501a4f255baecc8a4a5b859ab1 Changes: https://git.openjdk.org/jdk21u-dev/pull/168/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=168&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311986 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/168.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/168/head:pull/168 PR: https://git.openjdk.org/jdk21u-dev/pull/168 From goetz at openjdk.org Mon Jan 15 14:51:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 15 Jan 2024 14:51:52 GMT Subject: [jdk17u-dev] RFR: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing Message-ID: I backport this for parity with 17.0.11-oracle. I hat to resolve trivialle, presumably because [8257733: Move module-specific data from make to respective module](https://github.com/openjdk/jdk/commit/f8878cb0cc436993ef1222bc13b00b923d91aad1) is not in 17. ------------- Commit messages: - Backport e3201d1d13433857a1b34ff0ca93f9ae1a4e22aa Changes: https://git.openjdk.org/jdk17u-dev/pull/2126/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2126&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310631 Stats: 377 lines in 7 files changed: 80 ins; 228 del; 69 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2126.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2126/head:pull/2126 PR: https://git.openjdk.org/jdk17u-dev/pull/2126 From goetz at openjdk.org Mon Jan 15 14:53:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 15 Jan 2024 14:53:31 GMT Subject: [jdk21u-dev] RFR: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport e3201d1d13433857a1b34ff0ca93f9ae1a4e22aa Changes: https://git.openjdk.org/jdk21u-dev/pull/169/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=169&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310631 Stats: 20 lines in 2 files changed: 14 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/169.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/169/head:pull/169 PR: https://git.openjdk.org/jdk21u-dev/pull/169 From goetz at openjdk.org Mon Jan 15 14:53:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 15 Jan 2024 14:53:46 GMT Subject: [jdk17u-dev] RFR: 8311986: Disable runtime/os/TestTracePageSizes.java for ShenandoahGC Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 167d1c183546a9501a4f255baecc8a4a5b859ab1 Changes: https://git.openjdk.org/jdk17u-dev/pull/2127/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2127&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311986 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2127.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2127/head:pull/2127 PR: https://git.openjdk.org/jdk17u-dev/pull/2127 From shade at openjdk.org Mon Jan 15 15:02:26 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 15 Jan 2024 15:02:26 GMT Subject: [jdk22u] Integrated: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 11:58:41 GMT, Aleksey Shipilev wrote: > Clean backport for trivial little inefficiency. This pull request has now been integrated. Changeset: dfce95ad Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/dfce95adcf9e6c7c7efc21876f8dbd67d64affca Stats: 4 lines in 1 file changed: 3 ins; 1 del; 0 mod 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination Backport-of: eb9e754b3a439cc3ce36c2c9393bc8b250343844 ------------- PR: https://git.openjdk.org/jdk22u/pull/14 From jlahoda at openjdk.org Mon Jan 15 15:12:23 2024 From: jlahoda at openjdk.org (Jan Lahoda) Date: Mon, 15 Jan 2024 15:12:23 GMT Subject: [jdk21u-dev] RFR: 8321582: yield .class not parsed correctly. In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 12:42:56 GMT, Aleksey Shipilev wrote: > Fixes the javac bug, extends the space of compilable Java programs. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] `langtools_all` pass No problem from me. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/128#issuecomment-1892349893 From jlahoda at openjdk.org Mon Jan 15 15:12:23 2024 From: jlahoda at openjdk.org (Jan Lahoda) Date: Mon, 15 Jan 2024 15:12:23 GMT Subject: [jdk21u-dev] RFR: 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...] In-Reply-To: References: Message-ID: <6f-wry-10zoUFkPVb4nq7wx24u6l6LZZ8M01nSOElk4=.cca3abd8-dcba-4e4c-aff7-d57708ec5153@github.com> On Tue, 9 Jan 2024 10:02:34 GMT, Aleksey Shipilev wrote: > Clean backport to fix a corner case in javac. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, new regression test fails without the patch, passes with it > - [x] macos-aarch64-server-fastdebug, `langtools_all` pass No problem from me. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/146#issuecomment-1892350046 From goetz at openjdk.org Mon Jan 15 15:15:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 15 Jan 2024 15:15:43 GMT Subject: [jdk21u-dev] RFR: 8315721: CloseRace.java#id0 fails transiently on libgraal Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 1be355734da94243e29f0899b53aa1ebdf3bcb79 Changes: https://git.openjdk.org/jdk21u-dev/pull/170/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=170&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315721 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/170.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/170/head:pull/170 PR: https://git.openjdk.org/jdk21u-dev/pull/170 From shade at openjdk.org Mon Jan 15 15:16:27 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 15 Jan 2024 15:16:27 GMT Subject: [jdk21u-dev] RFR: 8321582: yield .class not parsed correctly. In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 12:42:56 GMT, Aleksey Shipilev wrote: > Fixes the javac bug, extends the space of compilable Java programs. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] `langtools_all` pass Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/128#issuecomment-1892356915 From clanger at openjdk.org Mon Jan 15 15:18:28 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 15 Jan 2024 15:18:28 GMT Subject: [jdk21u-dev] Integrated: 8320309: AIX: pthreads created by foreign test library don't work as expected In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 07:02:43 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8320309](https://bugs.openjdk.org/browse/JDK-8320309), commit [8b47a149](https://github.com/openjdk/jdk/commit/8b47a14958913c70291d46afdde4e527f9bdc91a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Varada M on 22 Nov 2023 and was reviewed by Martin Doerr, Matthias Baesken and Thomas Stuefe. > > Thanks! This pull request has now been integrated. Changeset: d92ff7c3 Author: Christoph Langer URL: https://git.openjdk.org/jdk21u-dev/commit/d92ff7c35a4f9fca5b47958ca610f7ae6b99bc74 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod 8320309: AIX: pthreads created by foreign test library don't work as expected Backport-of: 8b47a14958913c70291d46afdde4e527f9bdc91a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/159 From shade at openjdk.org Mon Jan 15 15:19:32 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 15 Jan 2024 15:19:32 GMT Subject: [jdk21u-dev] Integrated: 8321582: yield .class not parsed correctly. In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 12:42:56 GMT, Aleksey Shipilev wrote: > Fixes the javac bug, extends the space of compilable Java programs. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] `langtools_all` pass This pull request has now been integrated. Changeset: e08eb0ec Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/e08eb0ec0181228468c51129a6a9378d749d6d02 Stats: 29 lines in 2 files changed: 27 ins; 1 del; 1 mod 8321582: yield .class not parsed correctly. Backport-of: ce8399fd6071766114f5f201b6e44a7abdba9f5a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/128 From goetz at openjdk.org Mon Jan 15 15:33:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 15 Jan 2024 15:33:32 GMT Subject: [jdk21u-dev] RFR: 8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 4c5b66dceab15ce27f742c4173e14156249eb61a Changes: https://git.openjdk.org/jdk21u-dev/pull/171/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=171&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317522 Stats: 82 lines in 1 file changed: 55 ins; 11 del; 16 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/171.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/171/head:pull/171 PR: https://git.openjdk.org/jdk21u-dev/pull/171 From goetz at openjdk.org Mon Jan 15 15:38:02 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 15 Jan 2024 15:38:02 GMT Subject: [jdk11u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v2] In-Reply-To: References: Message-ID: > This backport is based on https://github.com/openjdk/jdk17u-dev/pull/2116 , the minimal version. > It contains the full EdDSA functionality and only removes the Strings that are explicitly not documented for backport in the CSRs. > > I needed the following adaptions you find in seperate commits: > > **Resolves**: > > The implementation in the jdk patched clean. > There were some conflicts in the tests: > > test/jdk/TEST.groups > trivial resolve due to context. > > test/jdk/javax/xml/crypto/dsig/GenerationTests.java > trivial resolve due to context. 8241306 is missing in the context. > > test/jdk/javax/xml/crypto/dsig/SecureValidation.java > This file is not in 11. > It came with "8241306: Add SignatureMethodParameterSpec subclass > for RSASSA-PSS params" which was not backported. Changes omitted. > > test/lib/jdk/test/lib/security/XMLUtils.java > One chunk does not apply because the removed code differs. > In 17, a switch statement is used that was adapted to Java 11. > Moved the comment and exception thrown in 11 to the new place. > > > **Make it compile and make the tests work**: > > The changes to the libraries compile out of the box. > > The tests needed several adaptions. I did not remove the > bad code yet, but just commented it out to highlight the > differences better for now. > > test/jdk/javax/xml/crypto/dsig/Basic.java > I had to remove test cases because > 8241305: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params > 8166597: Crypto support for the EdDSA Signature Algorithm > are not in 11. > > test/jdk/javax/xml/crypto/dsig/GenerationTests.java > To make it compile, I > replaced HexFormat.of().parseHex() by jdk.test.lib.Utils.toByteArray(). > Further, I commented a row of test coding that does not compile. > "8166597: Crypto support for the EdDSA Signature Algorithm" would > be needed to get these test cases working. > This effectively removes the test cases for the new functionality. > > test/jdk/javax/xml/crypto/dsig/HereFunction.java > A simple tweak to enable testing of sha1 is not needed in 11. > In 11, sha1 is still available per default as > "8259709: Disable SHA-1 XML Signatures" was not backported. > > test/lib/jdk/test/lib/security/XMLUtils.java > More complex resolve because a previous backport was already adapted to 11. > The code in 17 uses incompatible switch and instanceof > in several places. > It also needed adaptions because it does not compile as > 8166597: Crypto support for the EdDSA Signature Algorithm > is not in 11. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'openjdk:master' into goetz_backport_8305972-minimal - Merge branch 'openjdk:master' into goetz_backport_8305972-minimal - Fix tests, they now all pass - Resolve chunks that did not apply. - Backport 8309572 17u minimal change -- clean parts ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2455/files - new: https://git.openjdk.org/jdk11u-dev/pull/2455/files/1da0c3c5..68c77490 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2455&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2455&range=00-01 Stats: 2274 lines in 13 files changed: 2271 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2455.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2455/head:pull/2455 PR: https://git.openjdk.org/jdk11u-dev/pull/2455 From goetz at openjdk.org Mon Jan 15 15:39:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 15 Jan 2024 15:39:34 GMT Subject: [jdk21u-dev] RFR: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport f0b7eb519ae1cf6f4cb2baea55b5e02a46a8192e Changes: https://git.openjdk.org/jdk21u-dev/pull/172/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=172&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304020 Stats: 316 lines in 3 files changed: 226 ins; 90 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/172.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/172/head:pull/172 PR: https://git.openjdk.org/jdk21u-dev/pull/172 From sgehwolf at openjdk.org Mon Jan 15 17:46:22 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 15 Jan 2024 17:46:22 GMT Subject: [jdk21u-dev] RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn In-Reply-To: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> References: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> Message-ID: On Tue, 9 Jan 2024 16:46:27 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [d23f4f12](https://github.com/openjdk/jdk/commit/d23f4f12adf1ea26b8c340efe2c3854e50b68301) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Oli Gillespie on 4 Dec 2023 and was reviewed by Coleen Phillimore, Kim Barrett and Aleksey Shipilev. > > Thanks! @olivergillespie When applying for backports please add a description why that fix is needed in the requested release, what it's risk is and what testing you've done. Besides, this is a fairly new change and should probably wait for 21.0.4 so that more soak time can be had in JDK 22 before backporting. For now I'll remove the `jdk21u-fix-request` label. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/154#issuecomment-1892574509 From shade at openjdk.org Mon Jan 15 19:20:29 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 15 Jan 2024 19:20:29 GMT Subject: [jdk21u-dev] Integrated: 8322512: StringBuffer.repeat does not work correctly after toString() was called In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 16:18:11 GMT, Aleksey Shipilev wrote: > Clean backport to fix JDK 21 feature misbehavior. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] GHA (includes some Repeat tests) This pull request has now been integrated. Changeset: 6ee8f477 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/6ee8f477721354ca6caaf62e74e24496b5ec850c Stats: 16 lines in 2 files changed: 15 ins; 0 del; 1 mod 8322512: StringBuffer.repeat does not work correctly after toString() was called Backport-of: df22fb322e6c4c9931a770bd0abf4c43b83c4e4a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/143 From shade at openjdk.org Mon Jan 15 19:22:22 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 15 Jan 2024 19:22:22 GMT Subject: [jdk21u-dev] Integrated: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination In-Reply-To: References: Message-ID: <0aa7JCuJIRs8ZRpCuJwlBdSit3ijgcLhOqzc8XQBXkg=.a8717573-e21c-42b2-bbf8-27cb988e0371@github.com> On Tue, 9 Jan 2024 15:30:51 GMT, Aleksey Shipilev wrote: > Clean backport to eliminate a trivial inefficiency in release builds. This pull request has now been integrated. Changeset: 1b5aeb92 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/1b5aeb92607dd0bc8012dda0f28cc9d8a0fcff23 Stats: 4 lines in 1 file changed: 3 ins; 1 del; 0 mod 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination Backport-of: eb9e754b3a439cc3ce36c2c9393bc8b250343844 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/151 From szaldana at openjdk.org Mon Jan 15 21:02:34 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 15 Jan 2024 21:02:34 GMT Subject: [jdk21u-dev] RFR: 8318613: ChoiceFormat patterns are not well tested Message-ID: Hi all, This pull request contains a backport of commit [10427c02](https://github.com/openjdk/jdk/commit/10427c023a142a24db3c2492977a7233a1afc25d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Justin Lu on 25 Oct 2023 and was reviewed by Naoto Sato. Thanks! ------------- Commit messages: - Backport 10427c023a142a24db3c2492977a7233a1afc25d Changes: https://git.openjdk.org/jdk21u-dev/pull/164/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=164&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318613 Stats: 153 lines in 1 file changed: 153 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/164.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/164/head:pull/164 PR: https://git.openjdk.org/jdk21u-dev/pull/164 From omikhaltcova at openjdk.org Mon Jan 15 22:08:38 2024 From: omikhaltcova at openjdk.org (Olga Mikhaltsova) Date: Mon, 15 Jan 2024 22:08:38 GMT Subject: [jdk22u] RFR: 8318158: RISC-V: implement roundD/roundF intrinsics [v2] In-Reply-To: References: Message-ID: > I would like to backport [JDK-8318158](https://bugs.openjdk.org/browse/JDK-8318158) to jdk22u in order to optimize performance in double/float rounding operations by means of intrinsics. > The patch applied cleanly. > Tested: no regression in tier1 tests. > > The benchmark shows the following performance improvement on the T-Head RVB-ICE board: > **Before** > > Benchmark (TESTSIZE) Mode Cnt Score Error Units > FpRoundingBenchmark.test_round_double 2048 thrpt 15 59.722 0.259 ops/ms > FpRoundingBenchmark.test_round_float 2048 thrpt 15 49.729 0.127 ops/ms > > **After** > > Benchmark (TESTSIZE) Mode Cnt Score Error Units > FpRoundingBenchmark.test_round_double 2048 thrpt 15 118.496 0.277 ops/ms > FpRoundingBenchmark.test_round_float 2048 thrpt 15 121.008 0.488 ops/ms Olga Mikhaltsova has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-omikhaltsova-19147f32 - Backport 19147f326c6b0e78fe72f9a7e7100047f16a0921 ------------- Changes: - all: https://git.openjdk.org/jdk22u/pull/21/files - new: https://git.openjdk.org/jdk22u/pull/21/files/aa33e2a5..1e021623 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk22u&pr=21&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk22u&pr=21&range=00-01 Stats: 6 lines in 2 files changed: 5 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/21.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/21/head:pull/21 PR: https://git.openjdk.org/jdk22u/pull/21 From serb at openjdk.org Mon Jan 15 22:48:23 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 15 Jan 2024 22:48:23 GMT Subject: [jdk17u-dev] Integrated: 8309462: [AIX] vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop In-Reply-To: References: Message-ID: On Mon, 15 Jan 2024 06:39:11 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [cf9e6353](https://github.com/openjdk/jdk/commit/cf9e6353cc6fe9e57a7a9883813d09892e7e7621) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by JoKern65 on 12 Jun 2023 and was reviewed by Matthias Baesken, Martin Doerr and Christoph Langer. > > Thanks! This pull request has now been integrated. Changeset: 2ca591e1 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/2ca591e1f4862a970496563a5387f9f20f797113 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8309462: [AIX] vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop Backport-of: cf9e6353cc6fe9e57a7a9883813d09892e7e7621 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2125 From andrewlu at openjdk.org Tue Jan 16 02:20:43 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 16 Jan 2024 02:20:43 GMT Subject: [jdk11u-dev] RFR: 8286969: Add a new test library API to execute kinit in SecurityTools.java Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport dbda0e2bda5d8ba86f068684941a05387947d993 Changes: https://git.openjdk.org/jdk11u-dev/pull/2458/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2458&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286969 Stats: 12 lines in 1 file changed: 12 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2458.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2458/head:pull/2458 PR: https://git.openjdk.org/jdk11u-dev/pull/2458 From lmao at openjdk.org Tue Jan 16 03:46:46 2024 From: lmao at openjdk.org (Liang Mao) Date: Tue, 16 Jan 2024 03:46:46 GMT Subject: [jdk21u-dev] RFR: 8322279: Generational ZGC: Use ZFragmentationLimit and ZYoungCompactionLimit as percentage instead of multiples Message-ID: <-l0U_b-rR8Q1YkafdBqS0rdMKt5cFwkyn0o_4AceWwk=.17a38e29-2d5a-4a65-87dd-c54efe1ea463@github.com> This commit fixed incorrect use of production options of generational ZGC. Since JDK21 is the only LST version with generational ZGC? we need to fix the potential bugs. Additional testing on fastdebug against test/hotspot/jtreg/gc/z ------------- Commit messages: - Backport bf813be0f30391c67de3ea74c7522d7cbb8d3c3b Changes: https://git.openjdk.org/jdk21u-dev/pull/173/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=173&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322279 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/173.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/173/head:pull/173 PR: https://git.openjdk.org/jdk21u-dev/pull/173 From serb at openjdk.org Tue Jan 16 04:50:26 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 16 Jan 2024 04:50:26 GMT Subject: [jdk11u-dev] Integrated: 8309462: [AIX] vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop In-Reply-To: References: Message-ID: On Mon, 15 Jan 2024 10:14:00 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [cf9e6353](https://github.com/openjdk/jdk/commit/cf9e6353cc6fe9e57a7a9883813d09892e7e7621) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by JoKern65 on 12 Jun 2023 and was reviewed by Matthias Baesken, Martin Doerr and Christoph Langer. > > Thanks! This pull request has now been integrated. Changeset: 1f3c7d58 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/1f3c7d58c1735a0a9a0ab781af7c05f151b9434c Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8309462: [AIX] vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop Backport-of: cf9e6353cc6fe9e57a7a9883813d09892e7e7621 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2457 From andrewlu at openjdk.org Tue Jan 16 05:47:48 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 16 Jan 2024 05:47:48 GMT Subject: [jdk17u-dev] RFR: 8318154: Improve stability of WheelModifier.java test Message-ID: Backport for JDK-8318154. ------------- Commit messages: - Backport 668d4b077f260a30a90842a01b38a9cf6718d418 Changes: https://git.openjdk.org/jdk17u-dev/pull/2128/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2128&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318154 Stats: 25 lines in 1 file changed: 16 ins; 1 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2128.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2128/head:pull/2128 PR: https://git.openjdk.org/jdk17u-dev/pull/2128 From andrewlu at openjdk.org Tue Jan 16 05:53:49 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 16 Jan 2024 05:53:49 GMT Subject: [jdk11u-dev] RFR: 8318154: Improve stability of WheelModifier.java test Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport 668d4b077f260a30a90842a01b38a9cf6718d418 Changes: https://git.openjdk.org/jdk11u-dev/pull/2459/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2459&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318154 Stats: 25 lines in 1 file changed: 16 ins; 1 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2459.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2459/head:pull/2459 PR: https://git.openjdk.org/jdk11u-dev/pull/2459 From shade at openjdk.org Tue Jan 16 08:25:26 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 16 Jan 2024 08:25:26 GMT Subject: [jdk21u-dev] Integrated: 8320907: Shenandoah: Remove ShenandoahSelfFixing flag In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 11:48:32 GMT, Aleksey Shipilev wrote: > Clean backport to improve Shenandoah reliability and maintainability. This pull request has now been integrated. Changeset: 7fe7cfce Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/7fe7cfce829cda52b612d457ebeffa4146a14748 Stats: 7 lines in 3 files changed: 0 ins; 5 del; 2 mod 8320907: Shenandoah: Remove ShenandoahSelfFixing flag Backport-of: 43c7f6a673c2fa0b4dbec232e92b621619a98246 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/149 From andrewlu at openjdk.org Tue Jan 16 08:29:03 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 16 Jan 2024 08:29:03 GMT Subject: [jdk21u-dev] RFR: 8315594: Open source few headless Swing misc tests Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 806ef0897b42c8f3cb3b4d7bd904af9ed18a543e Changes: https://git.openjdk.org/jdk21u-dev/pull/174/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=174&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315594 Stats: 256 lines in 4 files changed: 256 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/174.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/174/head:pull/174 PR: https://git.openjdk.org/jdk21u-dev/pull/174 From andrewlu at openjdk.org Tue Jan 16 08:31:07 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 16 Jan 2024 08:31:07 GMT Subject: [jdk17u-dev] RFR: 8315594: Open source few headless Swing misc tests Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 806ef0897b42c8f3cb3b4d7bd904af9ed18a543e Changes: https://git.openjdk.org/jdk17u-dev/pull/2129/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2129&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315594 Stats: 256 lines in 4 files changed: 256 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2129.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2129/head:pull/2129 PR: https://git.openjdk.org/jdk17u-dev/pull/2129 From andrewlu at openjdk.org Tue Jan 16 08:35:10 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 16 Jan 2024 08:35:10 GMT Subject: [jdk11u-dev] RFR: 8315594: Open source few headless Swing misc tests Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport 806ef0897b42c8f3cb3b4d7bd904af9ed18a543e Changes: https://git.openjdk.org/jdk11u-dev/pull/2460/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2460&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315594 Stats: 256 lines in 4 files changed: 256 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2460.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2460/head:pull/2460 PR: https://git.openjdk.org/jdk11u-dev/pull/2460 From shade at openjdk.org Tue Jan 16 08:36:34 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 16 Jan 2024 08:36:34 GMT Subject: [jdk21u-dev] Integrated: 8320877: Shenandoah: Remove ShenandoahUnloadClassesFrequency support In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 11:45:05 GMT, Aleksey Shipilev wrote: > Clean backport to improve Shenandoah maintainability. This pull request has now been integrated. Changeset: b114a5e6 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/b114a5e6a06580260de266a712c09a34dd758824 Stats: 37 lines in 5 files changed: 0 ins; 34 del; 3 mod 8320877: Shenandoah: Remove ShenandoahUnloadClassesFrequency support Backport-of: b65ccff357e2e294b027f693ceb3d25410236a6b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/147 From shade at openjdk.org Tue Jan 16 08:36:34 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 16 Jan 2024 08:36:34 GMT Subject: [jdk21u-dev] Integrated: 8320888: Shenandoah: Enable ShenandoahVerifyOptoBarriers in debug builds In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 11:45:36 GMT, Aleksey Shipilev wrote: > Clean backport to improve Shenandoah maintainability. This pull request has now been integrated. Changeset: 77c743e5 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/77c743e5275aabcb7687a1a0f302f10535efdaf0 Stats: 39 lines in 4 files changed: 0 ins; 37 del; 2 mod 8320888: Shenandoah: Enable ShenandoahVerifyOptoBarriers in debug builds Backport-of: c86431767e6802317dc2be6221a5d0990b976ddc ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/148 From mbaesken at openjdk.org Tue Jan 16 08:44:34 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 16 Jan 2024 08:44:34 GMT Subject: [jdk11u-dev] RFR: 8276796: gc/TestSystemGC.java large pages subtest fails with ZGC [v3] In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 05:16:14 GMT, Andrew Lu wrote: >> I backport this for parity with 11.0.23-oracle. >> Backport for JDK-8269077 and JDK-8276796, >> For JDK-8269077, it's clean, as CMS test is remain in this file, only modify the '@test id=CMS', other added parts are clean. Local test pass. >> For ZGC test, add '-XX:+UnlockExperimentalVMOptions', pass on sap nightly test. > > Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: > > add -XX:+UnlockExperimentalVMOptions Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2442#pullrequestreview-1822783907 From shade at openjdk.org Tue Jan 16 08:55:34 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 16 Jan 2024 08:55:34 GMT Subject: [jdk21u-dev] RFR: 8318809: java/util/concurrent/ConcurrentLinkedQueue/WhiteBox.java shows intermittent failures on linux ppc64le and aarch64 Message-ID: Clean backport to stabilize tests and better parity. Removes test cases, guaranteed to be safe. ------------- Commit messages: - Backport 50d1839d54f13631946925d8ecf03ce71f31bab8 Changes: https://git.openjdk.org/jdk21u-dev/pull/175/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=175&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318809 Stats: 30 lines in 1 file changed: 0 ins; 30 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/175.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/175/head:pull/175 PR: https://git.openjdk.org/jdk21u-dev/pull/175 From mbaesken at openjdk.org Tue Jan 16 08:56:22 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 16 Jan 2024 08:56:22 GMT Subject: [jdk22u] Integrated: 8323331: fix typo hpage_pdm_size In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 11:04:10 GMT, Matthias Baesken wrote: > 8323331: fix typo hpage_pdm_size This pull request has now been integrated. Changeset: 879d36ed Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/879d36edcc53c567b361f8c53f4aa4645751b4ed Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8323331: fix typo hpage_pdm_size Backport-of: 16170678a72dbd7eecf55c21a426fb6179362fba ------------- PR: https://git.openjdk.org/jdk22u/pull/19 From goetz at openjdk.org Tue Jan 16 08:58:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Jan 2024 08:58:49 GMT Subject: [jdk17u-dev] RFR: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.11-oracle. > > I hat to resolve trivialle, presumably because [8257733: Move module-specific data from make to respective module](https://github.com/openjdk/jdk/commit/f8878cb0cc436993ef1222bc13b00b923d91aad1) is not in 17. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Only include files to be changed in this change ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2126/files - new: https://git.openjdk.org/jdk17u-dev/pull/2126/files/0099108c..9c33919c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2126&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2126&range=00-01 Stats: 150 lines in 4 files changed: 19 ins; 66 del; 65 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2126.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2126/head:pull/2126 PR: https://git.openjdk.org/jdk17u-dev/pull/2126 From mbaesken at openjdk.org Tue Jan 16 09:00:25 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 16 Jan 2024 09:00:25 GMT Subject: [jdk22u] Integrated: 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18 In-Reply-To: <6E8ykfv46HQg1wRY_nxqZIVdpknWJS0bccL9iNaRo0g=.0379f72d-ad0b-4b63-8d5d-1c51dd7fa1b2@github.com> References: <6E8ykfv46HQg1wRY_nxqZIVdpknWJS0bccL9iNaRo0g=.0379f72d-ad0b-4b63-8d5d-1c51dd7fa1b2@github.com> Message-ID: On Thu, 11 Jan 2024 13:39:08 GMT, Matthias Baesken wrote: > 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18 This pull request has now been integrated. Changeset: 7b32b944 Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/7b32b944b4e5b2d80db6568680ce0fd289a9f12b Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18 Backport-of: b530c0281b5082994065b10addeb8366ffa58e2f ------------- PR: https://git.openjdk.org/jdk22u/pull/18 From goetz at openjdk.org Tue Jan 16 09:04:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Jan 2024 09:04:30 GMT Subject: [jdk21u-dev] Integrated: 8319124: Update XML Security for Java to 3.0.3 In-Reply-To: <7Q7VgKXec5eRGqdwiBGMMxj19YbbL7Vm3AdeEnwkxfY=.952410d3-79d1-44ac-ba7e-0290e08be141@github.com> References: <7Q7VgKXec5eRGqdwiBGMMxj19YbbL7Vm3AdeEnwkxfY=.952410d3-79d1-44ac-ba7e-0290e08be141@github.com> Message-ID: <2qBL2X4hKHuHY49ann3_CgG1MC_AAIrPVeDVr24AxJE=.65b55659-9252-44fb-abe2-21d414b7fd29@github.com> On Sat, 23 Dec 2023 15:23:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. > > The patch applied clean (first commit). > > I removed the strings from SignatureMethod.java as documented in the backport CSR. > I did not change DOMSignatureMethod.java. > > I skipped the changes to GenerationTest.java. The test passes. > > **Update**: > I pushed a new commit that makes the four new test cases work. > As proposed in the CSR, I use the plain strings instead of the constants defined in SignatureMethod. This pull request has now been integrated. Changeset: 45df0785 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/45df078510ad6b8fb336e4180622ca3792bbe0cc Stats: 1531 lines in 130 files changed: 1114 ins; 231 del; 186 mod 8319124: Update XML Security for Java to 3.0.3 Reviewed-by: mbaesken Backport-of: 1c0bd81a10f97c752818163a573d5983c7e481ac ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/94 From goetz at openjdk.org Tue Jan 16 09:06:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Jan 2024 09:06:30 GMT Subject: [jdk11u-dev] Integrated: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries In-Reply-To: References: Message-ID: On Wed, 10 Jan 2024 09:12:03 GMT, Goetz Lindenmaier wrote: > This is a backout needed as the change is too intrusive for a backport. > Backport of the 17 change. > > This is not clean because in 11 > * an extra import was needed > * a """ string was adapted to 11 syntax > > The backout was crafted with two git revert commands. This pull request has now been integrated. Changeset: ff6e6d74 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/ff6e6d74e06e374186cbe3358e07ace58034d5b5 Stats: 445 lines in 3 files changed: 0 ins; 444 del; 1 mod 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries Reviewed-by: mdoerr Backport-of: ea6fc2147182f5b7168dc6f4e240c49446bf2ca3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2450 From goetz at openjdk.org Tue Jan 16 09:07:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Jan 2024 09:07:24 GMT Subject: [jdk21u-dev] Integrated: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 13:24:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 4b829786 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/4b829786ccb984ef2378b55bfc14a1c5d3fc6347 Stats: 86 lines in 2 files changed: 84 ins; 0 del; 2 mod 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files Backport-of: 8ae309ebacd6947bbad2ef168ca13702e1cba099 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/163 From goetz at openjdk.org Tue Jan 16 09:09:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Jan 2024 09:09:39 GMT Subject: [jdk21u-dev] RFR: 8310923: Refactor Currency tests to use JUnit [v2] In-Reply-To: References: Message-ID: > I backport this to keep the 21u test suite up-to-date. This will simplify future test backports. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-GoeLin-e848d947 - Backport e848d9471f5de86e5ac157b710cd7371f12f0024 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/162/files - new: https://git.openjdk.org/jdk21u-dev/pull/162/files/08a30821..bd58a988 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=162&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=162&range=00-01 Stats: 1755 lines in 148 files changed: 1248 ins; 309 del; 198 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/162.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/162/head:pull/162 PR: https://git.openjdk.org/jdk21u-dev/pull/162 From goetz at openjdk.org Tue Jan 16 09:10:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Jan 2024 09:10:48 GMT Subject: [jdk17u-dev] RFR: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 13:28:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. GHA failure: jtharness infra issue, restarted ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2122#issuecomment-1893331990 From goetz at openjdk.org Tue Jan 16 09:10:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Jan 2024 09:10:47 GMT Subject: [jdk17u-dev] RFR: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.11-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-GoeLin-8ae309eb - Backport 8ae309ebacd6947bbad2ef168ca13702e1cba099 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2122/files - new: https://git.openjdk.org/jdk17u-dev/pull/2122/files/e700d208..58211c12 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2122&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2122&range=00-01 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2122.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2122/head:pull/2122 PR: https://git.openjdk.org/jdk17u-dev/pull/2122 From mbaesken at openjdk.org Tue Jan 16 09:11:36 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 16 Jan 2024 09:11:36 GMT Subject: [jdk21u-dev] RFR: 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18 Message-ID: 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18 ------------- Commit messages: - Backport b530c0281b5082994065b10addeb8366ffa58e2f Changes: https://git.openjdk.org/jdk21u-dev/pull/176/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=176&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317804 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/176.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/176/head:pull/176 PR: https://git.openjdk.org/jdk21u-dev/pull/176 From goetz at openjdk.org Tue Jan 16 09:13:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Jan 2024 09:13:22 GMT Subject: [jdk21u-dev] RFR: 8306922: IR verification fails because IR dump is chopped up In-Reply-To: References: Message-ID: On Mon, 15 Jan 2024 14:10:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. GHA failure: on macos langtools jdk/jshell/ToolTabSnippetTest.java failed. This is unrelated to this C2 testing change. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/167#issuecomment-1893335524 From mbaesken at openjdk.org Tue Jan 16 09:17:26 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 16 Jan 2024 09:17:26 GMT Subject: [jdk22u] Withdrawn: 8323008: filter out harmful -std* flags added by autoconf from CXX In-Reply-To: References: Message-ID: <4ZKvwETJfFNDmosSyjoY3lKVdv3bo9HLzLFJmWtDsMI=.d828962c-6c86-4056-96b0-3f93466342e6@github.com> On Fri, 12 Jan 2024 12:43:33 GMT, Matthias Baesken wrote: > 8323008: filter out harmful -std* flags added by autoconf from CXX This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk22u/pull/20 From goetz at openjdk.org Tue Jan 16 09:20:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Jan 2024 09:20:22 GMT Subject: [jdk21u-dev] RFR: 8322279: Generational ZGC: Use ZFragmentationLimit and ZYoungCompactionLimit as percentage instead of multiples In-Reply-To: <-l0U_b-rR8Q1YkafdBqS0rdMKt5cFwkyn0o_4AceWwk=.17a38e29-2d5a-4a65-87dd-c54efe1ea463@github.com> References: <-l0U_b-rR8Q1YkafdBqS0rdMKt5cFwkyn0o_4AceWwk=.17a38e29-2d5a-4a65-87dd-c54efe1ea463@github.com> Message-ID: On Tue, 16 Jan 2024 03:40:14 GMT, Liang Mao wrote: > This commit fixed incorrect use of production options of generational ZGC. Since JDK21 is the only LST version with generational ZGC? we need to fix the potential bugs. > Additional testing on fastdebug against test/hotspot/jtreg/gc/z Hi @mmyxym, please give a risk estimate. What will be the effects of this this change? It looks as if a heurisitc will be changed by a factor of 100. Will normal ZGC be affected? Any other GC? Will pause time, heap size etc be affected? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/173#issuecomment-1893347027 From lucy at openjdk.org Tue Jan 16 09:28:26 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Tue, 16 Jan 2024 09:28:26 GMT Subject: [jdk17u-dev] RFR: 8320300: Adjust hs_err output in malloc/mmap error cases In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 13:53:48 GMT, Matthias Baesken wrote: > Backport 8320300 Changes look good. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2123#pullrequestreview-1822881700 From goetz at openjdk.org Tue Jan 16 09:29:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Jan 2024 09:29:32 GMT Subject: [jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v5] In-Reply-To: References: Message-ID: On Mon, 8 Jan 2024 16:49:38 GMT, Martin Balao wrote: >> Hi @martinuy, >> do you think it would be better to keep all the code and only remove the two String and the change to the comment of DigestMethod? >> In the 21u change for the update to [3.0.3](https://github.com/openjdk/jdk21u-dev/pull/94) I have done it that way. Probably that's also the better solution here. > > Hi @GoeLin , > > I assume that in 21u you kept all the (implementation) code except for the public members. If so, I understand the motivations but personally prefer what you proposed for 17u in this PR. It makes the code more clear in terms of what is supported. For example, it would be misleading for someone who looks for "EdDSA" references in the code, finds many ?even beyond defines? and assumes that it is supported. This is, of course, at the expense of higher chances of non-clean updates. We have taken this approach in other libraries before such as when we removed the implementation of DTLS in the 8u backport of the TLS engine. > > Martin.- Hi @martinuy, are you fine with me driving [#2116](https://github.com/openjdk/jdk17u-dev/pull/2116) and similarly [#2455](https://github.com/openjdk/jdk11u-dev/pull/2455) for 11? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2006#issuecomment-1893362585 From shade at openjdk.org Tue Jan 16 09:30:45 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 16 Jan 2024 09:30:45 GMT Subject: [jdk21u-dev] RFR: 8321120: Shenandoah: Remove ShenandoahElasticTLAB flag Message-ID: <9RxbqcBg2N9k3W1IyGphkAnK5Eo_tZlBkQmZoCfa2Es=.0a186435-7b97-4a55-a3c0-177867841e76@github.com> Clean backport to improve Shenandoah maintainability. Additional testing: - [x] macos-aarch64-server-fastdebug, `hotspot_gc_shenandoah` ------------- Commit messages: - Backport 93b9235f19dab2a0c08ba8a1afcc82ee71be4c0b Changes: https://git.openjdk.org/jdk21u-dev/pull/177/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=177&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321120 Stats: 92 lines in 5 files changed: 0 ins; 87 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/177.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/177/head:pull/177 PR: https://git.openjdk.org/jdk21u-dev/pull/177 From andrewlu at openjdk.org Tue Jan 16 10:01:32 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 16 Jan 2024 10:01:32 GMT Subject: [jdk11u-dev] Integrated: 8320208: Update Public Suffix List to b5bf572 In-Reply-To: References: Message-ID: <41H2GUN093B9ZnzzxvvFU_D_VdWLN2gqAqb_I88MsYI=.050b4e47-af07-4130-bcae-ff004af92a67@github.com> On Tue, 9 Jan 2024 02:11:12 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: 499e1c14 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/499e1c14cf89c759d21562b1cd8e046865ce2bbe Stats: 3002 lines in 4 files changed: 1753 ins; 73 del; 1176 mod 8320208: Update Public Suffix List to b5bf572 Backport-of: ae0716100a64004deef0ed49e7a6196cf78210e4 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2440 From duke at openjdk.org Tue Jan 16 10:12:35 2024 From: duke at openjdk.org (xiaotaonan) Date: Tue, 16 Jan 2024 10:12:35 GMT Subject: [jdk17u-dev] RFR: 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18 Message-ID: <2kma7LF2MZV7xALf05Smx9eqtgcci7Sre0H1WEqh2GA=.6a159c17-074f-4f33-84e4-b8a1c6acadd7@github.com> Backport-Fix the JdwpAllowTest.java test exception issue. ------------- Commit messages: - fixed bug-com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18 Changes: https://git.openjdk.org/jdk17u-dev/pull/2132/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2132&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317804 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2132.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2132/head:pull/2132 PR: https://git.openjdk.org/jdk17u-dev/pull/2132 From shade at openjdk.org Tue Jan 16 10:15:30 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 16 Jan 2024 10:15:30 GMT Subject: [jdk21u-dev] RFR: 8321122: Shenandoah: Remove ShenandoahLoopOptsAfterExpansion flag Message-ID: Clean backport to improve Shenandoah maintainability. Additional testing: - [x] macos-aarch64-server-fastdebug, `hotspot_gc_shenandoah` ------------- Commit messages: - Backport b02fc8681e57d75b5e05ce98216c53ff4d1e3b5d Changes: https://git.openjdk.org/jdk21u-dev/pull/178/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=178&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321122 Stats: 18 lines in 2 files changed: 5 ins; 11 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/178.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/178/head:pull/178 PR: https://git.openjdk.org/jdk21u-dev/pull/178 From shade at openjdk.org Tue Jan 16 10:33:40 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 16 Jan 2024 10:33:40 GMT Subject: [jdk21u-dev] RFR: 8323101: C2: assert(n->in(0) == nullptr) failed: divisions with zero check should already have bailed out earlier in split-if Message-ID: Clean backport to fix a C2 corner case. Additional testing: - [x] MacOS AArch64 server fastdebug: new tests fail without the patch, pass with the patch - [ ] Linux AArch64 server fastdebug, `tier{1,2,3,4}` ------------- Commit messages: - Backport 7e0a4ed6292586772c23292dbdd67ed1db5c12f7 Changes: https://git.openjdk.org/jdk21u-dev/pull/179/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=179&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323101 Stats: 215 lines in 2 files changed: 214 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/179.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/179/head:pull/179 PR: https://git.openjdk.org/jdk21u-dev/pull/179 From lmao at openjdk.org Tue Jan 16 10:40:21 2024 From: lmao at openjdk.org (Liang Mao) Date: Tue, 16 Jan 2024 10:40:21 GMT Subject: [jdk21u-dev] RFR: 8322279: Generational ZGC: Use ZFragmentationLimit and ZYoungCompactionLimit as percentage instead of multiples In-Reply-To: References: <-l0U_b-rR8Q1YkafdBqS0rdMKt5cFwkyn0o_4AceWwk=.17a38e29-2d5a-4a65-87dd-c54efe1ea463@github.com> Message-ID: On Tue, 16 Jan 2024 09:17:32 GMT, Goetz Lindenmaier wrote: > Hi @mmyxym, please give a risk estimate. What will be the effects of this this change? It looks as if a heurisitc will be changed by a factor of 100. Will normal ZGC be affected? Any other GC? Will pause time, heap size etc be affected? Hi, I think the risk is quite low because the genz author @fisk treated it as a trivial fix and the actual behaviors changed by the commit is not critical that it only affects the decision of per cpu shared small page and aging heuristics. The change will make the policy decision more reasonable. The commit doesn't affect the behavior of normal ZGC or other GCS and won't affect those major metrics like pause time or heap size, etc. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/173#issuecomment-1893480962 From rrich at openjdk.org Tue Jan 16 11:20:34 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Tue, 16 Jan 2024 11:20:34 GMT Subject: [jdk21u-dev] RFR: 8310031: Parallel: Implement better work distribution for large object arrays in old gen Message-ID: <67UuihGoUUiBrOdU3AJBFDyynhlo8b12p_dE46-fUsg=.06e45d5d-1895-45c0-89a8-027a2e72d5b8@github.com> Hi all, This pull request contains a backport of commit 4bfe2268 from the openjdk/jdk repository. The commit being backported was authored by Richard Reingruber on 24 Oct 2023 and was reviewed by Thomas Schatzl and Albert Mingkun Yang. The fix passed our CI testing: most JCK and JTREG (tiers 1-4) tests, also in Xcomp mode, Renaissance benchmark and SAP specific tests with fastdebug and release builds on the standard platforms plus PPC64. Thanks, Richard. ------------- Commit messages: - Backport 4bfe226870a15306b1e015c38fe3835f26b41fe6 Changes: https://git.openjdk.org/jdk21u-dev/pull/160/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=160&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310031 Stats: 334 lines in 5 files changed: 177 ins; 70 del; 87 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/160.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/160/head:pull/160 PR: https://git.openjdk.org/jdk21u-dev/pull/160 From rrich at openjdk.org Tue Jan 16 11:28:23 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Tue, 16 Jan 2024 11:28:23 GMT Subject: [jdk21u-dev] RFR: 8310031: Parallel: Implement better work distribution for large object arrays in old gen In-Reply-To: <67UuihGoUUiBrOdU3AJBFDyynhlo8b12p_dE46-fUsg=.06e45d5d-1895-45c0-89a8-027a2e72d5b8@github.com> References: <67UuihGoUUiBrOdU3AJBFDyynhlo8b12p_dE46-fUsg=.06e45d5d-1895-45c0-89a8-027a2e72d5b8@github.com> Message-ID: On Fri, 12 Jan 2024 09:19:27 GMT, Richard Reingruber wrote: > Hi all, > > This pull request contains a backport of commit 4bfe2268 from the openjdk/jdk repository. > > The commit being backported was authored by Richard Reingruber on 24 Oct 2023 and was reviewed by Thomas Schatzl and Albert Mingkun Yang. > > The fix passed our CI testing: most JCK and JTREG (tiers 1-4) tests, also in Xcomp mode, Renaissance benchmark and SAP specific tests with fastdebug and release builds on the standard platforms plus PPC64. > > Thanks, Richard. GHA failures are unrelated. Can I restart them (without merging master)? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/160#issuecomment-1893553310 From shade at openjdk.org Tue Jan 16 11:36:22 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 16 Jan 2024 11:36:22 GMT Subject: [jdk21u-dev] RFR: 8310031: Parallel: Implement better work distribution for large object arrays in old gen In-Reply-To: References: <67UuihGoUUiBrOdU3AJBFDyynhlo8b12p_dE46-fUsg=.06e45d5d-1895-45c0-89a8-027a2e72d5b8@github.com> Message-ID: <6Zbfu5DZ3VRjiR-pRla3wX5eRAmYbLFmKRUnndmoXBY=.9c5df69b-ef9d-497a-880d-8177efb9dd95@github.com> On Tue, 16 Jan 2024 11:25:32 GMT, Richard Reingruber wrote: > GHA failures are unrelated. Can I restart them (without merging master)? Yeah, go to https://github.com/reinrich/jdk/actions/workflows/main.yml and trigger it on your branch. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/160#issuecomment-1893564736 From rrich at openjdk.org Tue Jan 16 11:47:21 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Tue, 16 Jan 2024 11:47:21 GMT Subject: [jdk21u-dev] RFR: 8310031: Parallel: Implement better work distribution for large object arrays in old gen In-Reply-To: <6Zbfu5DZ3VRjiR-pRla3wX5eRAmYbLFmKRUnndmoXBY=.9c5df69b-ef9d-497a-880d-8177efb9dd95@github.com> References: <67UuihGoUUiBrOdU3AJBFDyynhlo8b12p_dE46-fUsg=.06e45d5d-1895-45c0-89a8-027a2e72d5b8@github.com> <6Zbfu5DZ3VRjiR-pRla3wX5eRAmYbLFmKRUnndmoXBY=.9c5df69b-ef9d-497a-880d-8177efb9dd95@github.com> Message-ID: On Tue, 16 Jan 2024 11:33:24 GMT, Aleksey Shipilev wrote: > > GHA failures are unrelated. Can I restart them (without merging master)? > > Yeah, go to https://github.com/reinrich/jdk/actions/workflows/main.yml and trigger it on your branch. Thanks for answering. With a little tweak it worked I think: I used the /backport command. The branch for the pr is in a repo created by the bot. Just now I've accepted its invitation and then I was able to start a run for my branch. The request ist queued now... ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/160#issuecomment-1893581370 From mbaesken at openjdk.org Tue Jan 16 12:52:28 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 16 Jan 2024 12:52:28 GMT Subject: [jdk17u-dev] RFR: 8320300: Adjust hs_err output in malloc/mmap error cases In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 13:53:48 GMT, Matthias Baesken wrote: > Backport 8320300 Hi Lucy, thanks for the review ! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2123#issuecomment-1893677712 From goetz at openjdk.org Tue Jan 16 14:05:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Jan 2024 14:05:52 GMT Subject: [jdk17u-dev] RFR: 8323806: [17u] VS2017 build fails with warning after 8293117. Message-ID: We need this to fix our build with VS2017. The warning is disabled limited to this one compiler version. ------------- Commit messages: - 8323806: [17u] VS2017 build fails with warning after 8293117. Changes: https://git.openjdk.org/jdk17u-dev/pull/2133/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2133&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323806 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2133.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2133/head:pull/2133 PR: https://git.openjdk.org/jdk17u-dev/pull/2133 From goetz at openjdk.org Tue Jan 16 14:28:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Jan 2024 14:28:22 GMT Subject: [jdk21u-dev] Integrated: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing In-Reply-To: References: Message-ID: On Mon, 15 Jan 2024 14:47:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 551855c0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/551855c0dd88a34b79dbed46d15dc8dfe2132ae9 Stats: 20 lines in 2 files changed: 14 ins; 2 del; 4 mod 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing Backport-of: e3201d1d13433857a1b34ff0ca93f9ae1a4e22aa ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/169 From shade at openjdk.org Tue Jan 16 16:09:33 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 16 Jan 2024 16:09:33 GMT Subject: [jdk21u-dev] Integrated: 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...] In-Reply-To: References: Message-ID: <4ytA0Tf1NtmKzcmy6OGaStN8K5BT5exiOByfesDPto8=.c328a5fb-8d86-446d-bd96-7afc93321d84@github.com> On Tue, 9 Jan 2024 10:02:34 GMT, Aleksey Shipilev wrote: > Clean backport to fix a corner case in javac. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, new regression test fails without the patch, passes with it > - [x] macos-aarch64-server-fastdebug, `langtools_all` pass This pull request has now been integrated. Changeset: f57f2cba Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/f57f2cbaa08e53a81a803bde982d912feea15515 Stats: 134 lines in 2 files changed: 124 ins; 0 del; 10 mod 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...] Backport-of: 03c4595173d564df97aa4f2b3156adcd4be379fa ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/146 From robm at openjdk.org Tue Jan 16 16:11:38 2024 From: robm at openjdk.org (Rob McKenna) Date: Tue, 16 Jan 2024 16:11:38 GMT Subject: [jdk21u] RFR: Merge f423faa3e05b2aee4c169dae1d0c9817b4be1b46 Message-ID: <7vbky8RlC92AfoYNl2J9EsB-IHzpIZYhSLyEQ-Ma6q8=.7cb4ee75-75fb-4e57-8d5b-17ab9b265b0f@github.com> Merge ------------- Commit messages: - Merge - 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries - Merge - 8317547: Enhance TLS connection support - Merge - Merge - 8320001: javac crashes while adding type annotations to the return type of a constructor - Merge remote-tracking branch 'jdk21u/master' into jdk21.0.2 - Merge remote-tracking branch 'jdk21u/master' into jdk21.0.2 - 8314307: Improve loop handling - ... and 29 more: https://git.openjdk.org/jdk21u/compare/1c7197fe...289f7a7a The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk21u/pull/432/files Stats: 795 lines in 20 files changed: 496 ins; 90 del; 209 mod Patch: https://git.openjdk.org/jdk21u/pull/432.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/432/head:pull/432 PR: https://git.openjdk.org/jdk21u/pull/432 From robm at openjdk.org Tue Jan 16 16:21:38 2024 From: robm at openjdk.org (Rob McKenna) Date: Tue, 16 Jan 2024 16:21:38 GMT Subject: [jdk21u] Integrated: Merge f423faa3e05b2aee4c169dae1d0c9817b4be1b46 In-Reply-To: <7vbky8RlC92AfoYNl2J9EsB-IHzpIZYhSLyEQ-Ma6q8=.7cb4ee75-75fb-4e57-8d5b-17ab9b265b0f@github.com> References: <7vbky8RlC92AfoYNl2J9EsB-IHzpIZYhSLyEQ-Ma6q8=.7cb4ee75-75fb-4e57-8d5b-17ab9b265b0f@github.com> Message-ID: On Tue, 16 Jan 2024 16:06:49 GMT, Rob McKenna wrote: > Merge This pull request has now been integrated. Changeset: 375769c6 Author: Rob McKenna URL: https://git.openjdk.org/jdk21u/commit/375769c6986866210a0f36aad580e3ac8e9eb068 Stats: 795 lines in 20 files changed: 496 ins; 90 del; 209 mod Merge ------------- PR: https://git.openjdk.org/jdk21u/pull/432 From rob.mckenna at oracle.com Tue Jan 16 18:12:53 2024 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Tue, 16 Jan 2024 18:12:53 +0000 Subject: [21u Communication] JDK 21.0.2 changes pushed Message-ID: 21.0.2 content has been pushed to https://github.com/openjdk/jdk21u -Rob From shade at openjdk.org Tue Jan 16 19:14:48 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 16 Jan 2024 19:14:48 GMT Subject: [jdk17u-dev] RFR: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation In-Reply-To: <7l3OgKeA_9mNbQlv3VPVLDfMnshGVzfEeN682__VncE=.7d1be42e-e3ea-461a-8fa3-268f6d23f74c@github.com> References: <7l3OgKeA_9mNbQlv3VPVLDfMnshGVzfEeN682__VncE=.7d1be42e-e3ea-461a-8fa3-268f6d23f74c@github.com> Message-ID: On Mon, 15 Jan 2024 07:38:43 GMT, Goetz Lindenmaier wrote: >> 8323086: Shenandoah: Heap could be corrupted by oom during evacuation > > @earthling-amzn I removed the fix-request tag. > Please label again when we develop 17.0.12. > Also, please follow https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix in your fix-request comment. I think the part of the missing background here (which would really be in fix-request) is that we have been running with this patch in GenShen for quite a while. So this is not really a new patch, it fixes an important corner case, and so I think it would be useful to have in current 17u (17.0.11). @GoeLin, can we still do it? @earthling-amzn should probably re-request with the much better fix-request. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2114#issuecomment-1894347427 From serb at openjdk.org Tue Jan 16 19:19:00 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 16 Jan 2024 19:19:00 GMT Subject: [jdk11u-dev] Integrated: 8309462: [AIX] vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop Message-ID: Hi all, This pull request contains a backport of commit [cf9e6353](https://github.com/openjdk/jdk/commit/cf9e6353cc6fe9e57a7a9883813d09892e7e7621) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by JoKern65 on 12 Jun 2023 and was reviewed by Matthias Baesken, Martin Doerr and Christoph Langer. Thanks! ------------- Commit messages: - Backport cf9e6353cc6fe9e57a7a9883813d09892e7e7621 Changes: https://git.openjdk.org/jdk11u-dev/pull/2457/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2457&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309462 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2457.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2457/head:pull/2457 PR: https://git.openjdk.org/jdk11u-dev/pull/2457 From serb at openjdk.org Tue Jan 16 19:19:07 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 16 Jan 2024 19:19:07 GMT Subject: [jdk11u-dev] Integrated: 8309462: [AIX] vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop In-Reply-To: References: Message-ID: On Mon, 15 Jan 2024 10:14:00 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [cf9e6353](https://github.com/openjdk/jdk/commit/cf9e6353cc6fe9e57a7a9883813d09892e7e7621) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by JoKern65 on 12 Jun 2023 and was reviewed by Matthias Baesken, Martin Doerr and Christoph Langer. > > Thanks! This pull request has now been integrated. Changeset: 1f3c7d58 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u-dev/commit/1f3c7d58c1735a0a9a0ab781af7c05f151b9434c Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8309462: [AIX] vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop Backport-of: cf9e6353cc6fe9e57a7a9883813d09892e7e7621 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2457 From goetz at openjdk.org Tue Jan 16 19:19:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Jan 2024 19:19:23 GMT Subject: [jdk11u-dev] Integrated: 8259801: Enable XML Signature secure validation mode by default Message-ID: I backport this for parity with 11.0.23-oracle. I resolved the Copyright in the test, will mark clean. I have to check for the backport CSR. Update: CSR available now: https://bugs.openjdk.org/browse/JDK-8323287 ------------- Commit messages: - Merge branch 'openjdk:master' into goetz_backport_8259801 - Backport baf46bac41f11c01691c4d4c77b24f76fedb5926 Changes: https://git.openjdk.org/jdk11u-dev/pull/2426/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2426&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8259801 Stats: 54 lines in 3 files changed: 12 ins; 3 del; 39 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2426.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2426/head:pull/2426 PR: https://git.openjdk.org/jdk11u-dev/pull/2426 From goetz at openjdk.org Tue Jan 16 19:19:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Jan 2024 19:19:30 GMT Subject: [jdk11u-dev] Integrated: 8259801: Enable XML Signature secure validation mode by default In-Reply-To: References: Message-ID: <8dq3wwCe0qH8O2PGWdEFKfbB2-yFAuKsoua7ggYXaDg=.cfa97ee4-4165-4e82-96cb-0793a956be88@github.com> On Wed, 3 Jan 2024 12:03:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.23-oracle. > > I resolved the Copyright in the test, will mark clean. > > I have to check for the backport CSR. > > Update: CSR available now: https://bugs.openjdk.org/browse/JDK-8323287 This pull request has now been integrated. Changeset: e55aac2b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/e55aac2bf7846663529209f3b12aac82710b0501 Stats: 54 lines in 3 files changed: 12 ins; 3 del; 39 mod 8259801: Enable XML Signature secure validation mode by default Backport-of: baf46bac41f11c01691c4d4c77b24f76fedb5926 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2426 From goetz at openjdk.org Tue Jan 16 19:20:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 16 Jan 2024 19:20:27 GMT Subject: [jdk11u-dev] Integrated: 8306871: Open source more AWT Drag & Drop tests In-Reply-To: <2QAvi-HJ8DLLyovurcVNShQup5HT3zS1nFxcKjHIKcQ=.f0237112-dae8-4590-89d5-20dfc9da05b7@github.com> References: <2QAvi-HJ8DLLyovurcVNShQup5HT3zS1nFxcKjHIKcQ=.f0237112-dae8-4590-89d5-20dfc9da05b7@github.com> Message-ID: On Tue, 9 Jan 2024 07:44:39 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. @luchenlin, what is wrong with GHA? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2447#issuecomment-1884373720 From andrewlu at openjdk.org Tue Jan 16 19:20:19 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 16 Jan 2024 19:20:19 GMT Subject: [jdk11u-dev] Integrated: 8306871: Open source more AWT Drag & Drop tests Message-ID: <2QAvi-HJ8DLLyovurcVNShQup5HT3zS1nFxcKjHIKcQ=.f0237112-dae8-4590-89d5-20dfc9da05b7@github.com> I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport b5a48277ab5b42c4b13db7ddb5418a17ada512ec Changes: https://git.openjdk.org/jdk11u-dev/pull/2447/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2447&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306871 Stats: 1915 lines in 6 files changed: 1915 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2447.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2447/head:pull/2447 PR: https://git.openjdk.org/jdk11u-dev/pull/2447 From andrewlu at openjdk.org Tue Jan 16 19:20:31 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 16 Jan 2024 19:20:31 GMT Subject: [jdk11u-dev] Integrated: 8306871: Open source more AWT Drag & Drop tests In-Reply-To: <2QAvi-HJ8DLLyovurcVNShQup5HT3zS1nFxcKjHIKcQ=.f0237112-dae8-4590-89d5-20dfc9da05b7@github.com> References: <2QAvi-HJ8DLLyovurcVNShQup5HT3zS1nFxcKjHIKcQ=.f0237112-dae8-4590-89d5-20dfc9da05b7@github.com> Message-ID: On Tue, 9 Jan 2024 07:44:39 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: 3bb03ee3 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/3bb03ee32c7c52357b8d0c699d2129123a3cdf95 Stats: 1915 lines in 6 files changed: 1915 ins; 0 del; 0 mod 8306871: Open source more AWT Drag & Drop tests Backport-of: b5a48277ab5b42c4b13db7ddb5418a17ada512ec ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2447 From serb at openjdk.org Tue Jan 16 20:38:08 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 16 Jan 2024 20:38:08 GMT Subject: [jdk22u] Integrated: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA In-Reply-To: References: Message-ID: <3MYzl4ZpaSYys3kAg3OQUvoe4Xz9WEa6pM09bYTxYqI=.573f4aaa-d2fb-4d41-9101-f3de8a13b2bb@github.com> On Sat, 13 Jan 2024 18:48:06 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [aba19334](https://github.com/openjdk/jdk/commit/aba19334eaeb46d37169cddeef929b13e050a60e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 9 Jan 2024 and was reviewed by Phil Race. > > Thanks! This pull request has now been integrated. Changeset: ed269bf4 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk22u/commit/ed269bf4bc8412397dd13f23d13e0951a3149a14 Stats: 8 lines in 2 files changed: 5 ins; 0 del; 3 mod 8323210: Update the usage of cmsFLAGS_COPY_ALPHA Backport-of: aba19334eaeb46d37169cddeef929b13e050a60e ------------- PR: https://git.openjdk.org/jdk22u/pull/23 From christoph.langer at sap.com Tue Jan 16 21:58:59 2024 From: christoph.langer at sap.com (Langer, Christoph) Date: Tue, 16 Jan 2024 21:58:59 +0000 Subject: [11u, 17u communication] JDK 17.0.10 and 11.0.22 changes pushed Message-ID: Hi, changes for 17.0.10 and 11.0.22 have been pushed to https://github.com/openjdk/jdk17u and https://github.com/openjdk/jdk11u respectively. Best regards Christoph -------------- next part -------------- An HTML attachment was scrubbed... URL: From macarte at openjdk.org Tue Jan 16 22:08:05 2024 From: macarte at openjdk.org (Mat Carter) Date: Tue, 16 Jan 2024 22:08:05 GMT Subject: [jdk17u-dev] RFR: 8275509: ModuleDescriptor.hashCode isn't reproducible across builds In-Reply-To: References: Message-ID: On Tue, 24 Oct 2023 20:18:16 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [396132ff](https://github.com/openjdk/jdk/commit/396132ff1e56463ad195cac5c9ac8e2eac5a16e8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 5 Nov 2021 and was reviewed by Alan Bateman and Magnus Ihse Bursie. > > Thanks! The tests fail on arm64 macOS and arm64 windows with hashCodes not matching (github actions doesn't run tests on those platforms). Is it possible that https://bugs.openjdk.org/browse/JDK-8290041 needs to be backported also as it addressed issues with the hashCodes and introduced additional tests ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1913#issuecomment-1894594863 From christoph.langer at sap.com Tue Jan 16 22:11:57 2024 From: christoph.langer at sap.com (Langer, Christoph) Date: Tue, 16 Jan 2024 22:11:57 +0000 Subject: [21u Communication] JDK 21.0.2 changes pushed In-Reply-To: References: Message-ID: Hi Rob, looks like you forgot to also push the individual build tags (e.g. via git push --follow-tags). Can you please publish them as well? Thanks Christoph > -----Original Message----- > From: jdk-updates-dev On Behalf Of > Robert Mckenna > Sent: Dienstag, 16. Januar 2024 19:13 > To: jdk-updates-dev at openjdk.org > Subject: [21u Communication] JDK 21.0.2 changes pushed > > 21.0.2 content has been pushed to https://github.com/openjdk/jdk21u > > -Rob From rob.mckenna at oracle.com Tue Jan 16 23:04:16 2024 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Tue, 16 Jan 2024 23:04:16 +0000 Subject: [21u Communication] JDK 21.0.2 changes pushed In-Reply-To: References: Message-ID: Hi Christoph, In fact, we hadn't forgotten to add these tags, but we do seem to have underestimated the demand for them. Explanation: We have moved to a new process for merging the CPU content to the open repo. Enhancements to skara have made it possible to merge this content via a PR. This means that integrators no longer need direct push access to the master repositories. (this is desirable for several reasons) Unfortunately as a result we will no longer be able to push the tags directly either. Instead, what we have decided to do is use skara to add the ga & +0 tags after the PR has been integrated by commenting on the relevant commit. (e.g. https://github.com/openjdk/jdk21u/commit/375769c6986866210a0f36aad580e3ac8e9eb068) Sergey (cc'd) and I have just been discussing it and he requested the addition of the final promotion tag too (in this case jdk-21.0.2+13) which I have just done. Adding the tags for all every promotion would be time consuming and error prone so I don't currently intend to do that in the absence of any substantive objections. We will have to rethink our new approach if this is a problem. -Rob ________________________________________ From: Langer, Christoph Sent: Tuesday 16 January 2024 22:11 To: Robert Mckenna; jdk-updates-dev at openjdk.org Subject: [External] : RE: [21u Communication] JDK 21.0.2 changes pushed Hi Rob, looks like you forgot to also push the individual build tags (e.g. via git push --follow-tags). Can you please publish them as well? Thanks Christoph > -----Original Message----- > From: jdk-updates-dev On Behalf Of > Robert Mckenna > Sent: Dienstag, 16. Januar 2024 19:13 > To: jdk-updates-dev at openjdk.org > Subject: [21u Communication] JDK 21.0.2 changes pushed > > 21.0.2 content has been pushed to https://urldefense.com/v3/__https://github.com/openjdk/jdk21u__;!!ACWV5N9M2RV99hQ!PBdoWPD_UMqXDM-4XjLGKk6gypcsEc9jcPyuucDPsZEexHuVznQUip4OEe5xRVdXl5s7XYpj00Gc_-jihHIHBMtOhQ$ > > -Rob From mbalao at openjdk.org Wed Jan 17 01:31:58 2024 From: mbalao at openjdk.org (Martin Balao) Date: Wed, 17 Jan 2024 01:31:58 GMT Subject: [jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v5] In-Reply-To: References: Message-ID: <7doKKABgZX7dS4HzjKwXUEuNZhibQTwND-2mk6Ult8U=.f19326a5-7634-4a49-b645-60e05ea91a6f@github.com> On Tue, 16 Jan 2024 09:27:07 GMT, Goetz Lindenmaier wrote: >> Hi @GoeLin , >> >> I assume that in 21u you kept all the (implementation) code except for the public members. If so, I understand the motivations but personally prefer what you proposed for 17u in this PR. It makes the code more clear in terms of what is supported. For example, it would be misleading for someone who looks for "EdDSA" references in the code, finds many ?even beyond defines? and assumes that it is supported. This is, of course, at the expense of higher chances of non-clean updates. We have taken this approach in other libraries before such as when we removed the implementation of DTLS in the 8u backport of the TLS engine. >> >> Martin.- > > Hi @martinuy, > are you fine with me driving [#2116](https://github.com/openjdk/jdk17u-dev/pull/2116) and similarly [#2455](https://github.com/openjdk/jdk11u-dev/pull/2455) for 11? Hi @GoeLin , I personally prefer the approach taken in PR #2006 (here), for the reasons in my [previous comment](https://github.com/openjdk/jdk17u-dev/pull/2006#issuecomment-1881457955). With that said, I see your motivation. I would be interested in hearing @jerboaa view on this issue. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2006#issuecomment-1894787300 From gnu.andrew at redhat.com Wed Jan 17 01:57:23 2024 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 17 Jan 2024 01:57:23 +0000 Subject: OpenJDK 17.0.10 Released Message-ID: We are pleased to announce the release of OpenJDK 17.0.10. The source tarball is available from: * https://openjdk-sources.osci.io/openjdk17/openjdk-17.0.10+7.tar.xz The tarball is accompanied by a digital signature available at: * https://openjdk-sources.osci.io/openjdk17/openjdk-17.0.10+7.tar.xz.sig This is signed by our Red Hat OpenJDK key (openjdk at redhat.com): PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net) Fingerprint = CA5F 11C6 CE22 644D 42C6 AC44 92EF 8D39 DC13 168F SHA256 checksums: 3b0035e7c485f45632006d50c65883014c362f14088e2fe2631ad91816f615e9 openjdk-17.0.10+7.tar.xz df32c51337c7fe73df5b71415164c8f973252cd718f3a9b8d79d76016063dca7 openjdk-17.0.10+7.tar.xz.sig The checksums can be downloaded from: * https://openjdk-sources.osci.io/openjdk17/openjdk-17.0.10+7.sha256 New in release OpenJDK 17.0.10 (2024-01-16): ============================================ Live versions of these release notes can be found at: * https://bit.ly/openjdk1710 * CVEs - CVE-2024-20918 - CVE-2024-20919 - CVE-2024-20921 - CVE-2024-20932 - CVE-2024-20945 - CVE-2024-20952 * Security fixes - JDK-8276123, JDK-8316613: ZipFile::getEntry will not return a file entry when there is a directory entry of the same name within a Zip File - JDK-8308204: Enhanced certificate processing - JDK-8314295: Enhance verification of verifier - JDK-8314307: Improve loop handling - JDK-8314468: Improve Compiler loops - JDK-8316976: Improve signature handling - JDK-8317547: Enhance TLS connection support * Other changes - JDK-6445283: ProgressMonitorInputStream not large file aware (>2GB) - JDK-8041447: Test javax/swing/dnd/7171812/bug7171812.java fails with java.lang.RuntimeException: Test failed, scroll on drag doesn't work - JDK-8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs - JDK-8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException - JDK-8168469: Memory leak in JceSecurity - JDK-8176567: nsk/jdi/ReferenceType/instances/instances002: TestFailure: Unexpected size of referenceType.instances(nsk.share.jdi.TestInterfaceImplementer1): 11, expected: 10 - JDK-8193543: Regression automated test '/open/test/jdk/java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java' fails - JDK-8198668: MemoryPoolMBean/isUsageThresholdExceeded/isexceeded001/TestDescription.java still failing - JDK-8202790: DnD test DisposeFrameOnDragTest.java does not clean up - JDK-8202931: [macos] java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java fails - JDK-8207166: jdk/jshell/JdiHangingLaunchExecutionControlTest.java - launch timeout - JDK-8225313: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java failed with Unexpected high difference percentage - JDK-8228990: JFR: TestNetworkUtilizationEvent.java expects 2+ Network interfaces on Linux but finding 1 - JDK-8232839: JDI AfterThreadDeathTest.java failed due to "FAILED: Did not get expected IllegalThreadStateException on a StepRequest.enable()" - JDK-8232933: Javac inferred type does not conform to equality constraint - JDK-8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails - JDK-8244289: fatal error: Possible safepoint reached by thread that does not allow it - JDK-8247351: [aarch64] NullPointerException during stack walking (clhsdb "where -a") - JDK-8249826: 5 javax/net/ssl/SSLEngine tests use @ignore w/o bug-id - JDK-8258951: java/net/httpclient/HandshakeFailureTest.java failed with "RuntimeException: Not found expected SSLHandshakeException in java.io.IOException" - JDK-8262186: Call X509KeyManager.chooseClientAlias once for all key types - JDK-8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10> - JDK-8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set. - JDK-8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be" - JDK-8268433: serviceability/dcmd/framework/VMVersionTest.java fails with Unable to send object throw not established PipeIO Listener Thread connection - JDK-8268916: Tests for AffirmTrust roots - JDK-8269425: 2 jdk/jfr/api/consumer/streaming tests failed to attach - JDK-8270199: Most SA tests are skipped on macosx-aarch64 because all executables are signed - JDK-8270447: [IR Framework] Add missing compilation level restriction when using FlipC1C2 stress option - JDK-8271073: Improve testing with VM option VerifyArchivedFields - JDK-8271566: DSA signature length value is not accurate in P11Signature - JDK-8271824: mark hotspot runtime/CompressedOops tests which ignore external VM flags - JDK-8271826: mark hotspot runtime/condy tests which ignore external VM flags - JDK-8271828: mark hotspot runtime/classFileParserBug tests which ignore external VM flags - JDK-8271829: mark hotspot runtime/Throwable tests which ignore external VM flags - JDK-8271886: mark hotspot runtime/InvocationTests tests which ignore external VM flags - JDK-8271887: mark hotspot runtime/CDSCompressedKPtrs tests which ignore external VM flags - JDK-8271890: mark hotspot runtime/Dictionary tests which ignore external VM flags - JDK-8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags - JDK-8271892: mark hotspot runtime/PrintStringTableStats/PrintStringTableStatsTest.java test as ignoring external VM flags - JDK-8271893: mark hotspot runtime/PerfMemDestroy/PerfMemDestroy.java test as ignoring external VM flags - JDK-8271904: mark hotspot runtime/ClassFile tests which ignore external VM flags - JDK-8271905: mark hotspot runtime/Metaspace tests which ignore external VM flags - JDK-8272099: mark hotspot runtime/Monitor tests which ignore external VM flags - JDK-8272291: mark hotspot runtime/logging tests which ignore external VM flags - JDK-8272551: mark hotspot runtime/modules tests which ignore external VM flags - JDK-8272552: mark hotspot runtime/cds tests which ignore external VM flags - JDK-8272998: ImageIO.read() throws incorrect exception type - JDK-8273456: Do not hold ttyLock around stack walking - JDK-8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap - JDK-8273629: compiler/uncommontrap/TestDeoptOOM.java fails with release VMs - JDK-8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned - JDK-8273921: Refactor NSK/JDI tests to create thread using factory - JDK-8274211: Test man page that options are documented - JDK-8274345: make build-test-lib is broken - JDK-8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases? - JDK-8275333: Print count in "Too many recored phases?" assert - JDK-8275440: Remove VirtualSpaceList::is_full() - JDK-8275509: ModuleDescriptor.hashCode isn't reproducible across builds - JDK-8276036: The value of full_count in the message of insufficient codecache is wrong - JDK-8276054: JMH benchmarks for Fences - JDK-8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint - JDK-8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free - JDK-8277307: Pre shared key sent under both session_ticket and pre_shared_key extensions - JDK-8279856: Parallel: Use PreservedMarks to record promotion-failed objects - JDK-8281015: Further simplify NMT backend - JDK-8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB - JDK-8281874: Can't unpack msi installers from test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java test - JDK-8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if light.exe is not in %PATH% - JDK-8282017: sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server" - JDK-8283670: gtest os.release_multi_mappings_vm is still racy - JDK-8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates - JDK-8285516: clearPassword should be called in a finally try block - JDK-8285785: CheckCleanerBound test fails with PasswordCallback object is not released - JDK-8285867: Convert applet manual tests SelectionVisible.java to Frame and automate - JDK-8286430: make test TEST="gtest:" exits with error when it shouldn't - JDK-8286473: Drop --enable-preview from Record related tests - JDK-8286474: Drop --enable-preview from Sealed Classes related tests - JDK-8286475: Drop --enable-preview from instanceof pattern matching related tests - JDK-8286969: Add a new test library API to execute kinit in SecurityTools.java - JDK-8287596: Reorg jdk.test.lib.util.ForceGC - JDK-8287671: Adjust ForceGC to invoke System::gc fewer times for negative case - JDK-8287867: Bad merge of jdk/test/lib/util/ForceGC.java causing test compilation error - JDK-8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different - JDK-8288961: jpackage: test MSI installation fix - JDK-8288993: Make AwtFramePackTest generic by removing @requires tag - JDK-8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB - JDK-8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes - JDK-8290909: MemoryPoolMBean/isUsageThresholdExceeded tests failed with "isUsageThresholdExceeded() returned false, and is still false, while threshold = MMMMMMM and used peak = NNNNNNN" - JDK-8291154: Create a non static nested class without enclosing class throws VerifyError - JDK-8291550: RISC-V: jdk uses misaligned memory access when AvoidUnalignedAccess enabled - JDK-8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160" - JDK-8292067: Convert test/sun/management/jmxremote/bootstrap shell tests to java version - JDK-8292072: NMT: repurpose Tracking overhead counter as global malloc counter - JDK-8292261: adjust timeouts in JLI GetObjectSizeIntrinsicsTest.java - JDK-8292381: java/net/httpclient/SpecialHeadersTest.java fails with "ERROR: Shutting down connection: HTTP/2 client stopped" - JDK-8292636: (dc) Problem listing of java/nio/channels/DatagramChannel/Unref.java has incorrect issue ID - JDK-8292717: Clean up checking of testing requirements in configure - JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy - JDK-8293335: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1failed with "Agent communication error: java.io.EOFException" - JDK-8293343: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java failed with "Agent communication error: java.io.EOFException" - JDK-8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException - JDK-8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java fails on Japanese Windows platform - JDK-8294402: Add diagnostic logging to VMProps.checkDockerSupport - JDK-8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env - JDK-8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails - JDK-8295229: Try to verify gtest version - JDK-8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest - JDK-8296275: Write a test to verify setAccelerator method of JMenuItem - JDK-8296437: NMT incurs costs if disabled - JDK-8296821: compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java fails after JDK-8262901 - JDK-8297142: jdk/jfr/event/runtime/TestShutdown.java fails on Linux ppc64le and Linux aarch64 - JDK-8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!" - JDK-8297367: disable TestRedirectLinks.java in slowdebug mode - JDK-8297640: Increase buffer size for buf (insert_features_names) in Abstract_VM_Version::insert_features_names - JDK-8297798: Timeout with DTLSOverDatagram test template - JDK-8297958: NMT: Display peak values - JDK-8298298: NMT: count deltas are printed with 32-bit signed size - JDK-8298619: java/io/File/GetXSpace.java is failing - JDK-8298735: Some tools/jpackage/windows/* tests fails with jtreg test timeout - JDK-8298867: Basics.java fails with SSL handshake exception - JDK-8298868: Update EngineCloseOnAlert.java for changes to TLS implementation - JDK-8298869: Update ConnectionTest.java for changes to TLS implementation - JDK-8298872: Update CheckStatus.java for changes to TLS implementation - JDK-8298873: Update IllegalRecordVersion.java for changes to TLS implementation - JDK-8298874: Update TestAllSuites.java for TLS v1.2 and 1.3 - JDK-8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display - JDK-8299075: TestStringDeduplicationInterned.java fails because extra deduplication - JDK-8299207: [Testbug] Add back test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java - JDK-8299241: jdk/jfr/api/consumer/streaming/TestJVMCrash.java generates unnecessary core file - JDK-8299255: Unexpected round errors in FreetypeFontScaler - JDK-8299677: Formatter.format might take a long time to format an integer or floating-point - JDK-8299748: java/util/zip/Deinflate.java failing on s390x - JDK-8300259: Add test coverage for processing of pending block files in signed JARs - JDK-8300272: Improve readability of the test JarWithOneNonDisabledDigestAlg - JDK-8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected" - JDK-8300997: Add curl support to createJMHBundle.sh - JDK-8301065: Handle control characters in java_lang_String::print - JDK-8301189: validate-source fails after JDK-8298873 - JDK-8301247: JPackage app-image exe launches multiple exe's in JDK 17+ - JDK-8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again - JDK-8301455: comments in TestTypeAnnotations still refer to resolved JDK-8068737 - JDK-8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed - JDK-8301489: C1: ShortLoopOptimizer might lift instructions before their inputs - JDK-8301570: Test runtime/jni/nativeStack/ needs to detach the native thread - JDK-8301701: java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened - JDK-8302017: Allocate BadPaddingException only if it will be thrown - JDK-8302109: Trivial fixes to btree tests - JDK-8302525: Write a test to check various components send Events while mouse and key are used simultaneously - JDK-8302607: increase timeout for ContinuousCallSiteTargetChange.java - JDK-8303607: SunMSCAPI provider leaks memory and keys - JDK-8303922: build-test-lib target is broken - JDK-8304174: Remove delays from httpserver tests - JDK-8304954: SegmentedCodeCache fails when using large pages - JDK-8305502: adjust timeouts in three more M&M tests - JDK-8305505: NPE in javazic compiler - JDK-8305646: compile error on Alpine with gcc12 after 8298619 in libGetXSpace.c - JDK-8306280: Open source several choice AWT tests - JDK-8307123: Fix deprecation warnings in DPrinter - JDK-8307311: Timeouts on one macOS 12.6.1 host of two Swing JTableHeader tests - JDK-8307403: java/util/zip/DeInflate.java timed out - JDK-8307732: build-test-lib is broken - JDK-8308047: java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors - JDK-8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17 - JDK-8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files - JDK-8308223: failure handler missed jcmd.vm.info command - JDK-8308592: Framework for CA interoperability testing - JDK-8308593: Add KEEPALIVE Extended Socket Options Support for Windows - JDK-8308910: Allow executeAndLog to accept running process - JDK-8309032: jpackage does not work for module projects unless --module-path is specified - JDK-8309104: [JVMCI] compiler/unsafe/UnsafeGetStableArrayElement test asserts wrong values with Graal - JDK-8309216: Cast from jchar* to char* in test java/io/GetXSpace.java - JDK-8309258: RISC-V: Add riscv_hwprobe syscall - JDK-8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads - JDK-8309778: java/nio/file/Files/CopyAndMove.java fails when using second test directory - JDK-8309974: some JVMCI tests fail when VM options include -XX:+EnableJVMCI - JDK-8310233: Fix THP detection on Linux - JDK-8310265: (process) jspawnhelper should not use argv[0] - JDK-8310268: RISC-V: misaligned memory access in String.Compare intrinsic - JDK-8310321: make JDKOPT_CHECK_CODESIGN_PARAMS more verbose - JDK-8310656: RISC-V: __builtin___clear_cache can fail silently. - JDK-8310687: JDK-8303215 is incomplete - JDK-8311511: Improve description of NativeLibrary JFR event - JDK-8311514: Incorrect regex in TestMetaSpaceLog.java - JDK-8311585: Add JRadioButtonMenuItem to bug8031573.java - JDK-8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers - JDK-8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files - JDK-8311813: C1: Uninitialized PhiResolver::_loop field - JDK-8312065: Socket.connect does not timeout when profiling - JDK-8312078: [PPC] JcmdScale.java Failing on AIX - JDK-8312126: NullPointerException in CertStore.getCRLs after 8297955 - JDK-8312182: THPs cause huge RSS due to thread start timing issue - JDK-8312394: [linux] SIGSEGV if kernel was built without hugepage support - JDK-8312395: Improve assertions in growableArray - JDK-8312440: assert(cast != nullptr) failed: must have added a cast to pin the node - JDK-8312467: relax the builddir check in make/autoconf/basic.m4 - JDK-8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar - JDK-8312535: MidiSystem.getSoundbank() throws unexpected SecurityException - JDK-8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere - JDK-8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation - JDK-8312592: New parentheses warnings after HarfBuzz 7.2.0 update - JDK-8312612: handle WideCharToMultiByte return values - JDK-8312620: WSL Linux build crashes after JDK-8310233 - JDK-8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased - JDK-8312909: C1 should not inline through interface calls with non-subtype receiver - JDK-8312974: Bump update version for OpenJDK: jdk-17.0.10 - JDK-8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources - JDK-8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early returns - JDK-8313322: RISC-V: implement MD5 intrinsic - JDK-8313626: C2 crash due to unexpected exception control flow - JDK-8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors - JDK-8313691: use close after failing os::fdopen in vmError and ciEnv - JDK-8313779: RISC-V: use andn / orn in the MD5 instrinsic - JDK-8313781: Add regression tests for large page logging and user-facing error messages - JDK-8313782: Add user-facing warning if THPs are enabled but cannot be used - JDK-8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md - JDK-8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info - JDK-8314045: ArithmeticException in GaloisCounterMode - JDK-8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection - JDK-8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges - JDK-8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8 - JDK-8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores - JDK-8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp - JDK-8314242: Update applications/scimark/Scimark.java to accept VM flags - JDK-8314263: Signed jars triggering Logger finder recursion and StackOverflowError - JDK-8314495: Update to use jtreg 7.3.1 - JDK-8314679: SA fails to properly attach to JVM after having just detached from a different JVM - JDK-8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case - JDK-8315020: The macro definition for LoongArch64 zero build is not accurate. - JDK-8315062: [GHA] get-bootjdk action should return the abolute path - JDK-8315195: RISC-V: Update hwprobe query for new extensions - JDK-8315206: RISC-V: hwprobe query is_set return wrong value - JDK-8315214: Do not run sun/tools/jhsdb tests concurrently - JDK-8315377: C2: assert(u->find_out_with(Op_AddP) == nullptr) failed: more than 2 chained AddP nodes? - JDK-8315415: OutputAnalyzer.shouldMatchByLine() fails in some cases - JDK-8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen - JDK-8315549: CITime misreports code/total nmethod sizes - JDK-8315606: Open source few swing text/html tests - JDK-8315644: increase timeout of sun/security/tools/jarsigner/Warning.java - JDK-8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java - JDK-8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test - JDK-8315696: SignedLoggerFinderTest.java test failed - JDK-8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le - JDK-8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test - JDK-8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies - JDK-8315863: [GHA] Update checkout action to use v4 - JDK-8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests - JDK-8316087: Test SignedLoggerFinderTest.java is still failing - JDK-8316178: Better diagnostic header for CodeBlobs - JDK-8316206: Test StretchedFontTest.java fails for Baekmuk font - JDK-8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit - JDK-8316514: Better diagnostic header for VtableStub - JDK-8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg - JDK-8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b - JDK-8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java - JDK-8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning - JDK-8316746: Top of lock-stack does not match the unlocked object - JDK-8316778: test hprof lib: invalid array element type from JavaValueArray.elementSize - JDK-8316859: RISC-V: Disable detection of V through HWCAP - JDK-8316906: Clarify TLABWasteTargetPercent flag - JDK-8317121: vector_masked_load instruction is moved too early after JDK-8286941 - JDK-8317327: Remove JT_JAVA dead code in jib-profiles.js - JDK-8317373: Add Telia Root CA v2 - JDK-8317374: Add Let's Encrypt ISRG Root X2 - JDK-8317705: ProblemList sun/tools/jstat/jstatLineCountsX.sh on linux-ppc64le and aix due to JDK-8248691 - JDK-8317706: Exclude java/awt/Graphics2D/DrawString/RotTransText.java on linux - JDK-8317772: NMT: Make peak values available in release builds - JDK-8317834: java/lang/Thread/IsAlive.java timed out - JDK-8317920: JDWP-agent sends broken exception event with onthrow option - JDK-8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases - JDK-8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2 - JDK-8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java - JDK-8318759: Add four DigiCert root certificates - JDK-8318855: Extra file added by mistake during the backport of JDK-8283326 - JDK-8318889: C2: add bailout after assert Bad graph detected in build_loop_late - JDK-8318953: RISC-V: Small refactoring for MacroAssembler::test_bit - JDK-8319184: RISC-V: improve MD5 intrinsic - JDK-8319187: Add three eMudhra emSign roots - JDK-8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc - JDK-8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit - JDK-8320053: GHA: Cross-compile gtest code - JDK-8320209: VectorMaskGen clobbers rflags on x86_64 - JDK-8320597: RSA signature verification fails on signed data that does not encode params correctly - JDK-8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all - JDK-8323422: [17u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 17.0.10 Notes on individual issues: =========================== core-libs/java.net: JDK-8308593: Add KEEPALIVE Extended Socket Options Support for Windows ====================================================================== On Windows 10 version 1709 and above, TCP_KEEPIDLE and TCP_KEEPINTERVAL are now supported in the java.net.ExtendedSocketOptions class. Similarly, on Windows 10 version 1703 and above, TCP_KEEPCOUNT is now supported. security-libs/javax.net.ssl: JDK-8262186: Call `X509KeyManager.chooseClientAlias` Once for All Key Types =========================================================================== The (D)TLS implementation in OpenJDK now makes only one call to the X509Keymanager.chooseClientAlias method during handshaking for client authentication, regardless of how many algorithms are requested. hotspot/runtime: JDK-8317772: NMT: Make peak values available in release builds ============================================================== The peak value is the highest value for committed memory in a given Native Memory Tracking (NMT) category over the lifetime of the JVM process. NMT reports will now show the peak value for all categories. If the committed memory for a category is at its peak, NMT will print "at peak". Otherwise, it prints the peak value. For example, "Compiler (arena=196KB #4) (peak=6126KB #16)" shows that compiler arena memory peaked above 6 MB, but now hovers around 200KB. JDK-8313782: Add user-facing warning if THPs are enabled but cannot be used =========================================================================== On Linux, the JVM will now print the following message to standard output if Transparent Huge Pages (THPs) are requested, but are not supported on the operating system: "UseTransparentHugePages disabled; transparent huge pages are not supported by the operating system." security-libs/java.security: JDK-8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar =============================================================================================================================== A maximum signature file size property, jdk.jar.maxSignatureFileSize, was introduced in the 17.0.8 release of OpenJDK by JDK-8300596, with a default of 8MB. This default proved to be too small for some JAR files. This release, 17.0.10, increases it to 16MB. JDK-8317374: Added ISRG Root X2 CA Certificate from Let's Encrypt ================================================================= The following root certificate has been added to the cacerts truststore: Name: Let's Encrypt Alias Name: letsencryptisrgx2 Distinguished Name: CN=ISRG Root X2, O=Internet Security Research Group, C=US JDK-8318759: Added Four Root Certificates from DigiCert, Inc. ============================================================= The following root certificates have been added to the cacerts truststore: Name: DigiCert, Inc. Alias Name: digicertcseccrootg5 Distinguished Name: CN=DigiCert CS ECC P384 Root G5, O="DigiCert, Inc.", C=US Name: DigiCert, Inc. Alias Name: digicertcsrsarootg5 Distinguished Name: CN=DigiCert CS RSA4096 Root G5, O="DigiCert, Inc.", C=US Name: DigiCert, Inc. Alias Name: digicerttlseccrootg5 Distinguished Name: CN=DigiCert TLS ECC P384 Root G5, O="DigiCert, Inc.", C=US Name: DigiCert, Inc. Alias Name: digicerttlsrsarootg5 Distinguished Name: CN=DigiCert TLS RSA4096 Root G5, O="DigiCert, Inc.", C=US JDK-8319187: Added Three Root Certificates from eMudhra Technologies Limited ============================================================================ The following root certificates have been added to the cacerts truststore: Name: eMudhra Technologies Limited Alias Name: emsignrootcag1 Distinguished Name: CN=emSign Root CA - G1, O=eMudhra Technologies Limited, OU=emSign PKI, C=IN Name: eMudhra Technologies Limited Alias Name: emsigneccrootcag3 Distinguished Name: CN=emSign ECC Root CA - G3, O=eMudhra Technologies Limited, OU=emSign PKI, C=IN Name: eMudhra Technologies Limited Alias Name: emsignrootcag2 Distinguished Name: CN=emSign Root CA - G2, O=eMudhra Technologies Limited, OU=emSign PKI, C=IN JDK-8317373: Added Telia Root CA v2 Certificate =============================================== The following root certificate has been added to the cacerts truststore: Name: Telia Root CA v2 Alias Name: teliarootcav2 Distinguished Name: CN=Telia Root CA v2, O=Telia Finland Oyj, C=FI ``` Thanks, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From gnu.andrew at redhat.com Wed Jan 17 02:02:21 2024 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 17 Jan 2024 02:02:21 +0000 Subject: OpenJDK 21.0.2 Released Message-ID: We are pleased to announce the release of OpenJDK 21.0.2. The source tarball is available from: * https://openjdk-sources.osci.io/openjdk21/openjdk-21.0.2+13.tar.xz The tarball is accompanied by a digital signature available at: * https://openjdk-sources.osci.io/openjdk21/openjdk-21.0.2+13.tar.xz.sig This is signed by our Red Hat OpenJDK key (openjdk at redhat.com): PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net) Fingerprint = CA5F 11C6 CE22 644D 42C6 AC44 92EF 8D39 DC13 168F SHA256 checksums: 750d311f0e211ce5811ed76bdb959ec6013af64cb4d51ed150c714bc4755c5da openjdk-21.0.2+13.tar.xz 5e207c169e0eab4ad2637956a2ba48855001db5e22572efbe2746629c2b44df6 openjdk-21.0.2+13.tar.xz.sig The checksums can be downloaded from: * https://openjdk-sources.osci.io/openjdk21/openjdk-21.0.2+13.sha256 New in release OpenJDK 21.0.2 (2024-01-16): =========================================== Live versions of these release notes can be found at: * https://bit.ly/openjdk2102 * CVEs - CVE-2024-20918 - CVE-2024-20919 - CVE-2024-20921 - CVE-2024-20945 - CVE-2024-20952 * Security fixes - JDK-8308204: Enhanced certificate processing - JDK-8314295: Enhance verification of verifier - JDK-8314307: Improve loop handling - JDK-8314468: Improve Compiler loops - JDK-8316976: Improve signature handling - JDK-8317547: Enhance TLS connection support * Other changes - JDK-8038244: (fs) Check return value of malloc in Java_sun_nio_fs_AixNativeDispatcher_getmntctl() - JDK-8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException - JDK-8219652: [aix] Tests failing with JNI attach problems. - JDK-8225377: type annotations are not visible to javac plugins across compilation boundaries - JDK-8232839: JDI AfterThreadDeathTest.java failed due to "FAILED: Did not get expected IllegalThreadStateException on a StepRequest.enable()" - JDK-8267502: JDK-8246677 caused 16x performance regression in SynchronousQueue - JDK-8267509: Improve IllegalAccessException message to include the cause of the exception - JDK-8268916: Tests for AffirmTrust roots - JDK-8286757: adlc tries to build with /pathmap but without /experimental:deterministic - JDK-8294156: Allow PassFailJFrame.Builder to create test UI - JDK-8294158: HTML formatting for PassFailJFrame instructions - JDK-8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env - JDK-8294535: Add screen capture functionality to PassFailJFrame - JDK-8295068: SSLEngine throws NPE parsing CertificateRequests - JDK-8295555: Primitive wrapper caches could be `@Stable` - JDK-8299614: Shenandoah: STW mark should keep nmethod/oops referenced from stack chunk alive - JDK-8300663: java/util/concurrent/SynchronousQueue/Fairness.java failed with "Error: fair=true i=0 j=1" - JDK-8301247: JPackage app-image exe launches multiple exe's in JDK 17+ - JDK-8301341: LinkedTransferQueue does not respect timeout for poll() - JDK-8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed - JDK-8301489: C1: ShortLoopOptimizer might lift instructions before their inputs - JDK-8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library - JDK-8303737: C2: Load can bypass subtype check that enforces it's from the right object type - JDK-8306561: Possible out of bounds access in print_pointer_information - JDK-8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17 - JDK-8308452: Extend internal Architecture enum with byte order and address size - JDK-8308479: [s390x] Implement alternative fast-locking scheme - JDK-8308592: Framework for CA interoperability testing - JDK-8308593: Add KEEPALIVE Extended Socket Options Support for Windows - JDK-8309209: C2 failed "assert(_stack_guard_state == stack_guard_reserved_disabled) failed: inconsistent state" - JDK-8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout - JDK-8309545: Thread.interrupted from virtual thread needlessly resets interrupt status - JDK-8309663: test fails "assert(check_alignment(result)) failed: address not aligned: 0x00000008baadbabe" - JDK-8309778: java/nio/file/Files/CopyAndMove.java fails when using second test directory - JDK-8309974: some JVMCI tests fail when VM options include -XX:+EnableJVMCI - JDK-8310239: Add missing cross modifying fence in nmethod entry barriers - JDK-8310512: Cleanup indentation in jfc files - JDK-8310596: Utilize existing method frame::interpreter_frame_monitor_size_in_bytes() - JDK-8310982: jdk/internal/util/ArchTest.java fails after JDK-8308452 failed with Method isARM() - JDK-8311261: [AIX] TestAlwaysPreTouchStacks.java fails due to java.lang.RuntimeException: Did not find expected NMT output - JDK-8311514: Incorrect regex in TestMetaSpaceLog.java - JDK-8311585: Add JRadioButtonMenuItem to bug8031573.java - JDK-8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder - JDK-8311630: [s390] Implementation of Foreign Function & Memory API (Preview) - JDK-8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files - JDK-8311680: Update the release version after forking Oct CPU23_10 - JDK-8311681: Update the Jan CPU24_01 release date in master branch after forking Oct CPU23_10 - JDK-8311813: C1: Uninitialized PhiResolver::_loop field - JDK-8311938: Add default cups include location for configure on AIX - JDK-8312078: [PPC] JcmdScale.java Failing on AIX - JDK-8312126: NullPointerException in CertStore.getCRLs after 8297955 - JDK-8312166: (dc) DatagramChannel's socket adaptor does not release carrier thread when blocking in receive - JDK-8312174: missing JVMTI events from vthreads parked during JVMTI attach - JDK-8312191: ColorConvertOp.filter for the default destination is too slow - JDK-8312433: HttpClient request fails due to connection being considered idle and closed - JDK-8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom" - JDK-8312440: assert(cast != nullptr) failed: must have added a cast to pin the node - JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag - JDK-8312467: relax the builddir check in make/autoconf/basic.m4 - JDK-8312592: New parentheses warnings after HarfBuzz 7.2.0 update - JDK-8312612: handle WideCharToMultiByte return values - JDK-8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources - JDK-8313167: Update to use jtreg 7.3 - JDK-8313206: PKCS11 tests silently skip execution - JDK-8313244: NM flags handling in configure process - JDK-8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early returns - JDK-8313322: RISC-V: implement MD5 intrinsic - JDK-8313368: (fc) FileChannel.size returns 0 on block special files - JDK-8313575: Refactor PKCS11Test tests - JDK-8313616: support loading library members on AIX in os::dll_load - JDK-8313643: Update HarfBuzz to 8.2.2 - JDK-8313656: assert(!JvmtiExport::can_support_virtual_threads()) with -XX:-DoJVMTIVirtualThreadTransitions - JDK-8313756: [BACKOUT] 8308682: Enhance AES performance - JDK-8313760: [REDO] Enhance AES performance - JDK-8313779: RISC-V: use andn / orn in the MD5 instrinsic - JDK-8313781: Add regression tests for large page logging and user-facing error messages - JDK-8313782: Add user-facing warning if THPs are enabled but cannot be used - JDK-8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md - JDK-8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation - JDK-8314045: ArithmeticException in GaloisCounterMode - JDK-8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges - JDK-8314120: Add tests for FileDescriptor.sync - JDK-8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8 - JDK-8314191: C2 compilation fails with "bad AD file" - JDK-8314226: Series of colon-style fallthrough switch cases with guards compiled incorrectly - JDK-8314242: Update applications/scimark/Scimark.java to accept VM flags - JDK-8314246: javax/swing/JToolBar/4529206/bug4529206.java fails intermittently on Linux - JDK-8314263: Signed jars triggering Logger finder recursion and StackOverflowError - JDK-8314330: java/foreign tests should respect vm flags when start new processes - JDK-8314476: TestJstatdPortAndServer.java failed with "java.rmi.NoSuchObjectException: no such object in table" - JDK-8314495: Update to use jtreg 7.3.1 - JDK-8314551: More generic way to handshake GC threads with monitor deflation - JDK-8314580: PhaseIdealLoop::transform_long_range_checks fails with assert "was tested before" - JDK-8314632: Intra-case dominance check fails in the presence of a guard - JDK-8314759: VirtualThread.parkNanos timeout adjustment when pinned should be replaced - JDK-8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case - JDK-8314935: Shenandoah: Unable to throw OOME on back-to-back Full GCs - JDK-8315026: ProcessHandle implementation listing processes on AIX should use getprocs64 - JDK-8315062: [GHA] get-bootjdk action should return the abolute path - JDK-8315082: [REDO] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index)) - JDK-8315088: C2: assert(wq.size() - before == EMPTY_LOOP_SIZE) failed: expect the EMPTY_LOOP_SIZE nodes of this body if empty - JDK-8315195: RISC-V: Update hwprobe query for new extensions - JDK-8315206: RISC-V: hwprobe query is_set return wrong value - JDK-8315213: java/lang/ProcessHandle/TreeTest.java test enhance output of children - JDK-8315214: Do not run sun/tools/jhsdb tests concurrently - JDK-8315362: NMT: summary diff reports threads count incorrectly - JDK-8315377: C2: assert(u->find_out_with(Op_AddP) == nullptr) failed: more than 2 chained AddP nodes? - JDK-8315383: jlink SystemModulesPlugin incorrectly parses the options - JDK-8315415: OutputAnalyzer.shouldMatchByLine() fails in some cases - JDK-8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests - JDK-8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests - JDK-8315452: Erroneous AST missing modifiers for partial input - JDK-8315499: build using devkit on Linux ppc64le RHEL puts path to devkit into libsplashscreen - JDK-8315545: C1: x86 cmove can use short branches - JDK-8315549: CITime misreports code/total nmethod sizes - JDK-8315554: C1: Replace "cmp reg, 0" with "test reg, reg" on x86 - JDK-8315578: PPC builds are broken after JDK-8304913 - JDK-8315579: SPARC64 builds are broken after JDK-8304913 - JDK-8315606: Open source few swing text/html tests - JDK-8315612: RISC-V: intrinsic for unsignedMultiplyHigh - JDK-8315644: increase timeout of sun/security/tools/jarsigner/Warning.java - JDK-8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix) - JDK-8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java - JDK-8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java - JDK-8315688: Update jdk21u fix version to 21.0.2 - JDK-8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test - JDK-8315696: SignedLoggerFinderTest.java test failed - JDK-8315702: jcmd Thread.dump_to_file slow with millions of virtual threads - JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX - JDK-8315735: VerifyError when switch statement used with synchronized block - JDK-8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le - JDK-8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test - JDK-8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies - JDK-8315774: Enable parallelism in vmTestbase/gc/g1/unloading tests - JDK-8315863: [GHA] Update checkout action to use v4 - JDK-8315869: UseHeavyMonitors not used - JDK-8315920: C2: "control input must dominate current control" assert failure - JDK-8315931: RISC-V: xxxMaxVectorTestsSmokeTest fails when using RVV - JDK-8315936: Parallelize gc/stress/TestStressG1Humongous.java test - JDK-8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests - JDK-8315942: Sort platform enums and definitions after JDK-8304913 follow-ups - JDK-8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind - JDK-8315971: ProblemList containers/docker/TestMemoryAwareness.java on linux-all - JDK-8316003: Update FileChooserSymLinkTest.java to HTML instructions - JDK-8316017: Refactor timeout handler in PassFailJFrame - JDK-8316025: Use testUI() method of PassFailJFrame.Builder in FileChooserSymLinkTest.java - JDK-8316030: Update Libpng to 1.6.40 - JDK-8316031: SSLFlowDelegate should not log from synchronized block - JDK-8316060: test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java may fail if heap is huge - JDK-8316087: Test SignedLoggerFinderTest.java is still failing - JDK-8316113: Infinite permission checking loop in java/net/spi/InetAddressResolverProvider/RuntimePermissionTest - JDK-8316123: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on AIX - JDK-8316130: Incorrect control in LibraryCallKit::inline_native_notify_jvmti_funcs - JDK-8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests - JDK-8316156: ByteArrayInputStream.transferTo causes MaxDirectMemorySize overflow - JDK-8316178: Better diagnostic header for CodeBlobs - JDK-8316179: Use consistent naming for lightweight locking in MacroAssembler - JDK-8316181: Move the fast locking implementation out of the .ad files - JDK-8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows. - JDK-8316206: Test StretchedFontTest.java fails for Baekmuk font - JDK-8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux - JDK-8316337: (bf) Concurrency issue in DirectByteBuffer.Deallocator - JDK-8316341: sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le Ubuntu 22 - JDK-8316387: Exclude more failing multicast tests on AIX after JDK-8315651 - JDK-8316396: Endless loop in C2 compilation triggered by AddNode::IdealIL - JDK-8316399: Exclude java/net/MulticastSocket/Promiscuous.java on AIX - JDK-8316400: Exclude jdk/jfr/event/runtime/TestResidentSetSizeEvent.java on AIX - JDK-8316401: sun/tools/jhsdb/JStackStressTest.java failed with "InternalError: We should have found a thread that owns the anonymous lock" - JDK-8316411: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with force inline by CompileCommand missing - JDK-8316414: C2: large byte array clone triggers "failed: malformed control flow" assertion failure on linux-x86 - JDK-8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests - JDK-8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC - JDK-8316436: ContinuationWrapper uses unhandled nullptr oop - JDK-8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit - JDK-8316468: os::write incorrectly handles partial write - JDK-8316514: Better diagnostic header for VtableStub - JDK-8316540: StoreReproducibilityTest fails on some locales - JDK-8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg - JDK-8316581: Improve performance of Symbol::print_value_on() - JDK-8316585: [REDO] runtime/InvocationTests spend a lot of time on dependency verification - JDK-8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b - JDK-8316648: jrt-fs.jar classes not reproducible between standard and bootcycle builds - JDK-8316659: assert(LockingMode != LM_LIGHTWEIGHT || flag == CCR0) failed: bad condition register - JDK-8316671: sun/security/ssl/SSLSocketImpl/SSLSocketCloseHang.java test fails intermittent with Read timed out - JDK-8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable - JDK-8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java - JDK-8316719: C2 compilation still fails with "bad AD file" - JDK-8316735: Print LockStack in hs_err files - JDK-8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes - JDK-8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning - JDK-8316746: Top of lock-stack does not match the unlocked object - JDK-8316778: test hprof lib: invalid array element type from JavaValueArray.elementSize - JDK-8316859: RISC-V: Disable detection of V through HWCAP - JDK-8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163 - JDK-8316880: AArch64: "stop: Header is not fast-locked" with -XX:-UseLSE since JDK-8315880 - JDK-8316894: make test TEST="jtreg:test/jdk/..." fails on AIX - JDK-8316906: Clarify TLABWasteTargetPercent flag - JDK-8316929: Shenandoah: Shenandoah degenerated GC and full GC need to cleanup old OopMapCache entries - JDK-8316933: RISC-V: compiler/vectorapi/VectorCastShape128Test.java fails when using RVV - JDK-8316935: [s390x] Use consistent naming for lightweight locking in MacroAssembler - JDK-8316958: Add test for unstructured locking - JDK-8316967: Correct the scope of vmtimer in UnregisteredClasses::load_class - JDK-8317039: Enable specifying the JDK used to run jtreg - JDK-8317136: [AIX] Problem List runtime/jni/terminatedThread/TestTerminatedThread.java - JDK-8317257: RISC-V: llvm build broken - JDK-8317262: LockStack::contains(oop) fails "assert(t->is_Java_thread()) failed: incorrect cast to JavaThread" - JDK-8317294: Classloading throws exceptions over already pending exceptions - JDK-8317327: Remove JT_JAVA dead code in jib-profiles.js - JDK-8317331: Solaris build failed with "declaration can not follow a statement (E_DECLARATION_IN_CODE)" - JDK-8317335: Build on windows fails after 8316645 - JDK-8317336: Assertion error thrown during 'this' escape analysis - JDK-8317340: Windows builds are not reproducible if MS VS compiler install path differs - JDK-8317373: Add Telia Root CA v2 - JDK-8317374: Add Let's Encrypt ISRG Root X2 - JDK-8317439: Updating RE Configs for BUILD REQUEST 21.0.2+1 - JDK-8317507: C2 compilation fails with "Exceeded _node_regs array" - JDK-8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name - JDK-8317581: [s390x] Multiple test failure with LockingMode=2 - JDK-8317601: Windows build on WSL broken after JDK-8317340 - JDK-8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win) - JDK-8317692: jcmd GC.heap_dump performance regression after JDK-8292818 - JDK-8317705: ProblemList sun/tools/jstat/jstatLineCountsX.sh on linux-ppc64le and aix due to JDK-8248691 - JDK-8317706: Exclude java/awt/Graphics2D/DrawString/RotTransText.java on linux - JDK-8317711: Exclude gtest/GTestWrapper.java on AIX - JDK-8317736: Stream::handleReset locks twice - JDK-8317751: ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows - JDK-8317772: NMT: Make peak values available in release builds - JDK-8317790: Fix Bug entry for exclusion of runtime/jni/terminatedThread/TestTerminatedThread.java on AIX - JDK-8317803: Exclude java/net/Socket/asyncClose/Race.java on AIX - JDK-8317807: JAVA_FLAGS removed from jtreg running in JDK-8317039 - JDK-8317818: Combinatorial explosion during 'this' escape analysis - JDK-8317834: java/lang/Thread/IsAlive.java timed out - JDK-8317839: Exclude java/nio/channels/Channels/SocketChannelStreams.java on AIX - JDK-8317920: JDWP-agent sends broken exception event with onthrow option - JDK-8317959: Check return values of malloc in native java.base coding - JDK-8317964: java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java fails on macosx-all after JDK-8317751 - JDK-8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases - JDK-8317987: C2 recompilations cause high memory footprint - JDK-8318078: ADLC: pass ASSERT and PRODUCT flags - JDK-8318089: Class space not marked as such with NMT when CDS is off - JDK-8318137: Change milestone to fcs for all releases - JDK-8318144: Match on enum constants with body compiles but fails with MatchException - JDK-8318183: C2: VM may crash after hitting node limit - JDK-8318240: [AIX] Cleaners.java test failure - JDK-8318415: Adjust describing comment of os_getChildren after 8315026 - JDK-8318474: Fix memory reporter for thread_count - JDK-8318525: Atomic gtest should run as TEST_VM to access VM capabilities - JDK-8318528: Rename TestUnstructuredLocking test - JDK-8318540: make test cannot run .jasm tests directly - JDK-8318562: Computational test more than 2x slower when AVX instructions are used - JDK-8318587: refresh libraries cache on AIX in print_vm_info - JDK-8318591: avoid leaks in loadlib_aix.cpp reload_table() - JDK-8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2 - JDK-8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java - JDK-8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use" - JDK-8318759: Add four DigiCert root certificates - JDK-8318889: C2: add bailout after assert Bad graph detected in build_loop_late - JDK-8318895: Deoptimization results in incorrect lightweight locking stack - JDK-8318951: Additional negative value check in JPEG decoding - JDK-8318953: RISC-V: Small refactoring for MacroAssembler::test_bit - JDK-8318955: Add ReleaseIntArrayElements in Java_sun_awt_X11_XlibWrapper_SetBitmapShape XlbWrapper.c to early return - JDK-8318957: enhance agentlib:jdwp help output by info about allow option - JDK-8318961: increase javacserver connection timeout values and max retry attempts - JDK-8318981: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with 'disallowed by CompileCommand' missing from stdout/stderr - JDK-8319104: GtestWrapper crashes with SIGILL in AsyncLogTest::test_asynclog_raw on AIX opt - JDK-8319120: Unbound ScopedValue.get() throws the wrong exception - JDK-8319184: RISC-V: improve MD5 intrinsic - JDK-8319187: Add three eMudhra emSign roots - JDK-8319195: Move most tier 1 vector API regression tests to tier 3 - JDK-8319268: Build failure with GCC8.3.1 after 8313643 - JDK-8319339: Internal error on spurious markup in a hybrid snippet - JDK-8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader - JDK-8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc - JDK-8319532: jshell - Non-sealed declarations sometimes break a snippet evaluation - JDK-8319542: Fix boundaries of region to be tested with os::is_readable_range - JDK-8319700: [AArch64] C2 compilation fails with "Field too big for insn" - JDK-8319828: runtime/NMT/VirtualAllocCommitMerge.java may fail if mixing interpreted and compiled native invocations - JDK-8319922: libCreationTimeHelper.so fails to link in JDK 21 - JDK-8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit - JDK-8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks - JDK-8320001: javac crashes while adding type annotations to the return type of a constructor - JDK-8320053: GHA: Cross-compile gtest code - JDK-8320209: VectorMaskGen clobbers rflags on x86_64 - JDK-8320280: RISC-V: Avoid passing t0 as temp register to MacroAssembler::lightweight_lock/unlock - JDK-8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity - JDK-8320597: RSA signature verification fails on signed data that does not encode params correctly - JDK-8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all - JDK-8321067: Unlock experimental options in EATests.java - JDK-8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries - JDK-8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used Notes on individual issues: =========================== core-libs/java.net: JDK-8308593: Add KEEPALIVE Extended Socket Options Support for Windows ====================================================================== On Windows 10 version 1709 and above, TCP_KEEPIDLE and TCP_KEEPINTERVAL are now supported in the java.net.ExtendedSocketOptions class. Similarly, on Windows 10 version 1703 and above, TCP_KEEPCOUNT is now supported. hotspot/compiler: JDK-8315082: [REDO] Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index)) ================================================================================================= In the initial release of JDK 21, running the JVM with -XX:+UseZGC and a non-default value of -XX:ObjectAlignmentInBytes could lead to JVM crashes or incorrect execution. This issue should now be resolved and it should be possible to use these options again. hotspot/runtime: JDK-8317772: NMT: Make peak values available in release builds ============================================================== The peak value is the highest value for committed memory in a given Native Memory Tracking (NMT) category over the lifetime of the JVM process. NMT reports will now show the peak value for all categories. If the committed memory for a category is at its peak, NMT will print "at peak". Otherwise, it prints the peak value. For example, "Compiler (arena=196KB #4) (peak=6126KB #16)" shows that compiler arena memory peaked above 6 MB, but now hovers around 200KB. JDK-8313782: Add user-facing warning if THPs are enabled but cannot be used =========================================================================== On Linux, the JVM will now print the following message to standard output if Transparent Huge Pages (THPs) are requested, but are not supported on the operating system: "UseTransparentHugePages disabled; transparent huge pages are not supported by the operating system." security-libs/java.security: JDK-8317374: Added ISRG Root X2 CA Certificate from Let's Encrypt ================================================================= The following root certificate has been added to the cacerts truststore: Name: Let's Encrypt Alias Name: letsencryptisrgx2 Distinguished Name: CN=ISRG Root X2, O=Internet Security Research Group, C=US JDK-8318759: Added Four Root Certificates from DigiCert, Inc. ============================================================= The following root certificates have been added to the cacerts truststore: Name: DigiCert, Inc. Alias Name: digicertcseccrootg5 Distinguished Name: CN=DigiCert CS ECC P384 Root G5, O="DigiCert, Inc.", C=US Name: DigiCert, Inc. Alias Name: digicertcsrsarootg5 Distinguished Name: CN=DigiCert CS RSA4096 Root G5, O="DigiCert, Inc.", C=US Name: DigiCert, Inc. Alias Name: digicerttlseccrootg5 Distinguished Name: CN=DigiCert TLS ECC P384 Root G5, O="DigiCert, Inc.", C=US Name: DigiCert, Inc. Alias Name: digicerttlsrsarootg5 Distinguished Name: CN=DigiCert TLS RSA4096 Root G5, O="DigiCert, Inc.", C=US JDK-8319187: Added Three Root Certificates from eMudhra Technologies Limited ============================================================================ The following root certificates have been added to the cacerts truststore: Name: eMudhra Technologies Limited Alias Name: emsignrootcag1 Distinguished Name: CN=emSign Root CA - G1, O=eMudhra Technologies Limited, OU=emSign PKI, C=IN Name: eMudhra Technologies Limited Alias Name: emsigneccrootcag3 Distinguished Name: CN=emSign ECC Root CA - G3, O=eMudhra Technologies Limited, OU=emSign PKI, C=IN Name: eMudhra Technologies Limited Alias Name: emsignrootcag2 Distinguished Name: CN=emSign Root CA - G2, O=eMudhra Technologies Limited, OU=emSign PKI, C=IN JDK-8317373: Added Telia Root CA v2 Certificate =============================================== The following root certificate has been added to the cacerts truststore: Name: Telia Root CA v2 Alias Name: teliarootcav2 Distinguished Name: CN=Telia Root CA v2, O=Telia Finland Oyj, C=FI ``` Thanks, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From cushon at openjdk.org Wed Jan 17 03:51:24 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Wed, 17 Jan 2024 03:51:24 GMT Subject: [jdk22u] RFR: 8322040: Missing array bounds check in ClassReader.parameter [v2] In-Reply-To: References: Message-ID: > Hi, > > This is a backport of [JDK-8322040: Missing array bounds check in ClassReader.parameter](https://bugs.openjdk.org/browse/JDK-8322040). > > The fix applied cleanly. The test required updating due to changes in the Class-File API. The modified test fails without the patch, and passes with it. Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into backport-JDK-8322040 - Backport 20de541b1304b4dc3a385f8a78f1215da237e4aa ------------- Changes: - all: https://git.openjdk.org/jdk22u/pull/4/files - new: https://git.openjdk.org/jdk22u/pull/4/files/1511ce17..41e60f11 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk22u&pr=4&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk22u&pr=4&range=00-01 Stats: 2388 lines in 139 files changed: 1414 ins; 515 del; 459 mod Patch: https://git.openjdk.org/jdk22u/pull/4.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/4/head:pull/4 PR: https://git.openjdk.org/jdk22u/pull/4 From cushon at openjdk.org Wed Jan 17 03:51:24 2024 From: cushon at openjdk.org (Liam Miller-Cushon) Date: Wed, 17 Jan 2024 03:51:24 GMT Subject: [jdk22u] RFR: 8322040: Missing array bounds check in ClassReader.parameter In-Reply-To: References: Message-ID: <8DNHc-eGSDZzEnqIYDoP6PRgI7etnoK8ThY5odIm8Ws=.c3a6f450-d597-4042-a48e-d3db1bbe56f8@github.com> On Tue, 19 Dec 2023 16:47:29 GMT, Liam Miller-Cushon wrote: > Hi, > > This is a backport of [JDK-8322040: Missing array bounds check in ClassReader.parameter](https://bugs.openjdk.org/browse/JDK-8322040). > > The fix applied cleanly. The test required updating due to changes in the Class-File API. The modified test fails without the patch, and passes with it. Please keep this open ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/4#issuecomment-1894891260 From andrewlu at openjdk.org Wed Jan 17 08:05:02 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 17 Jan 2024 08:05:02 GMT Subject: [jdk21u-dev] Integrated: 8315594: Open source few headless Swing misc tests In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 08:21:51 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 9b5cd9dc Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/9b5cd9dc43d3aa34ead39f7ac29c2f8e03ea6109 Stats: 256 lines in 4 files changed: 256 ins; 0 del; 0 mod 8315594: Open source few headless Swing misc tests Backport-of: 806ef0897b42c8f3cb3b4d7bd904af9ed18a543e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/174 From goetz at openjdk.org Wed Jan 17 08:07:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 08:07:55 GMT Subject: [jdk21u-dev] RFR: 8321120: Shenandoah: Remove ShenandoahElasticTLAB flag In-Reply-To: <9RxbqcBg2N9k3W1IyGphkAnK5Eo_tZlBkQmZoCfa2Es=.0a186435-7b97-4a55-a3c0-177867841e76@github.com> References: <9RxbqcBg2N9k3W1IyGphkAnK5Eo_tZlBkQmZoCfa2Es=.0a186435-7b97-4a55-a3c0-177867841e76@github.com> Message-ID: On Tue, 16 Jan 2024 09:24:10 GMT, Aleksey Shipilev wrote: > Clean backport to improve Shenandoah maintainability. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `hotspot_gc_shenandoah` Hi @shipilev shouldn't we keep the definition of the option to assure the flag is still accepted in case some installation uses it? I think we should not silently remove product flags in released versions, even for DIAGNOSTIC ones. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/177#issuecomment-1895288677 From goetz at openjdk.org Wed Jan 17 08:20:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 08:20:58 GMT Subject: [jdk17u-dev] RFR: 8320300: Adjust hs_err output in malloc/mmap error cases In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 12:50:02 GMT, Matthias Baesken wrote: >> Backport 8320300 > > Hi Lucy, thanks for the review ! @MBaesken, What's wrong with the GHA tests? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2123#issuecomment-1895305509 From andrewlu at openjdk.org Wed Jan 17 08:24:00 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 17 Jan 2024 08:24:00 GMT Subject: [jdk17u-dev] Integrated: 8318154: Improve stability of WheelModifier.java test In-Reply-To: References: Message-ID: <6GkbjmhCwOZxfAhpgtttygV6Krq-QS2DfOeiFbNo-U4=.01df2ae4-4791-44bd-9cac-922092f98166@github.com> On Tue, 16 Jan 2024 05:41:17 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 11998d7d Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/11998d7d6fcdbc17cb2ab5d37d791855f6787e00 Stats: 25 lines in 1 file changed: 16 ins; 1 del; 8 mod 8318154: Improve stability of WheelModifier.java test Backport-of: 668d4b077f260a30a90842a01b38a9cf6718d418 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2128 From andrewlu at openjdk.org Wed Jan 17 08:28:03 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 17 Jan 2024 08:28:03 GMT Subject: [jdk17u-dev] Integrated: 8315594: Open source few headless Swing misc tests In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 08:25:07 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 3b03c062 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/3b03c0625c4eb62eedd89af39bb1310508a0131a Stats: 256 lines in 4 files changed: 256 ins; 0 del; 0 mod 8315594: Open source few headless Swing misc tests Backport-of: 806ef0897b42c8f3cb3b4d7bd904af9ed18a543e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2129 From mbaesken at openjdk.org Wed Jan 17 08:32:59 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 17 Jan 2024 08:32:59 GMT Subject: [jdk17u-dev] RFR: 8320300: Adjust hs_err output in malloc/mmap error cases In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 12:50:02 GMT, Matthias Baesken wrote: >> Backport 8320300 > > Hi Lucy, thanks for the review ! > @MBaesken, What's wrong with the GHA tests? Broken GHA ; cannot get jtreg for some reason (but I did not click through all of them, as I said they are more broken recently than helpful). [build.sh][INFO] Downloading https://git.openjdk.java.net/jtharness/archive/jt6.0-b24.zip to /home/runner/work/jdk17u-dev/jdk17u-dev/jtreg/src/make/../build/deps/jtharness/src/../source.zip Error: sh][ERROR] wget exited with exit code 4 Error: Process completed with exit code 1. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2123#issuecomment-1895322981 From goetz at openjdk.org Wed Jan 17 08:36:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 08:36:55 GMT Subject: [jdk21u-dev] RFR: 8310923: Refactor Currency tests to use JUnit [v2] In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 09:09:39 GMT, Goetz Lindenmaier wrote: >> I backport this to keep the 21u test suite up-to-date. This will simplify future test backports. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-GoeLin-e848d947 > - Backport e848d9471f5de86e5ac157b710cd7371f12f0024 GHA tests pending: there seems to be a bottelnech on mac today. I saw others pending too. As this is not a mac specific change, and as this is only a testbug, we can go without this GHA result. SAP testing for mac is green. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/162#issuecomment-1895328200 From mbaesken at openjdk.org Wed Jan 17 08:36:58 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 17 Jan 2024 08:36:58 GMT Subject: [jdk21u-dev] Integrated: 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18 In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 09:03:39 GMT, Matthias Baesken wrote: > 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18 This pull request has now been integrated. Changeset: 0ac1bb75 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/0ac1bb75a0d97e88fbdae85d85e9658cf549c3fe Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18 Backport-of: b530c0281b5082994065b10addeb8366ffa58e2f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/176 From andrewlu at openjdk.org Wed Jan 17 08:49:00 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 17 Jan 2024 08:49:00 GMT Subject: [jdk11u-dev] Integrated: 8318154: Improve stability of WheelModifier.java test In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 05:48:12 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: 621a5e5b Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/621a5e5b590f29052577252c3e8384d6333e83b8 Stats: 25 lines in 1 file changed: 16 ins; 1 del; 8 mod 8318154: Improve stability of WheelModifier.java test Backport-of: 668d4b077f260a30a90842a01b38a9cf6718d418 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2459 From andrewlu at openjdk.org Wed Jan 17 08:56:02 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 17 Jan 2024 08:56:02 GMT Subject: [jdk11u-dev] Integrated: 8286969: Add a new test library API to execute kinit in SecurityTools.java In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 02:15:59 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: 573f6b3f Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/573f6b3f2e9f5f316e74960633f536eb3589d371 Stats: 12 lines in 1 file changed: 12 ins; 0 del; 0 mod 8286969: Add a new test library API to execute kinit in SecurityTools.java Backport-of: dbda0e2bda5d8ba86f068684941a05387947d993 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2458 From andrewlu at openjdk.org Wed Jan 17 08:56:04 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 17 Jan 2024 08:56:04 GMT Subject: [jdk11u-dev] Integrated: 8276796: gc/TestSystemGC.java large pages subtest fails with ZGC In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 06:20:09 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. > Backport for JDK-8269077 and JDK-8276796, > For JDK-8269077, it's clean, as CMS test is remain in this file, only modify the '@test id=CMS', other added parts are clean. Local test pass. > For ZGC test, add '-XX:+UnlockExperimentalVMOptions', pass on sap nightly test. This pull request has now been integrated. Changeset: cc6fab36 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/cc6fab36bc229538d2b85522c0f023f368e5e4dd Stats: 22 lines in 1 file changed: 14 ins; 1 del; 7 mod 8276796: gc/TestSystemGC.java large pages subtest fails with ZGC 8269077: TestSystemGC uses "require vm.gc.G1" for large pages subtest Reviewed-by: mbaesken Backport-of: 91bb0d658bce010e74b248b56f0fa5b8a79e8802 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2442 From christoph.langer at sap.com Wed Jan 17 09:05:39 2024 From: christoph.langer at sap.com (Langer, Christoph) Date: Wed, 17 Jan 2024 09:05:39 +0000 Subject: [21u Communication] JDK 21.0.2 changes pushed In-Reply-To: References: Message-ID: Hi Rob, thanks for your prompt response. I think it is ok to only push the final promotion tag. (At least for me.) One thing that I can see now is that the original (merge-)commit that was tagged jdk-21.0.2+13 in the bundle distributed via vuln-dev (e.g. https://github.com/openjdk/jdk21u/pull/432/commits/289f7a7ab6f5f6cdd46e6183083842a91f496f34) is different from the merge commit created by the merge PR that is now in the jdk21u repo (https://github.com/openjdk/jdk21u/commit/375769c6986866210a0f36aad580e3ac8e9eb068). Not sure whether Skara tools could be further improved to keep the original commit (hash) if possible? Thanks Christoph > -----Original Message----- > From: Robert Mckenna > Sent: Mittwoch, 17. Januar 2024 00:04 > To: Langer, Christoph ; jdk-updates- > dev at openjdk.org > Cc: Sergey Bylokhov > Subject: Re: [21u Communication] JDK 21.0.2 changes pushed > > Hi Christoph, > > In fact, we hadn't forgotten to add these tags, but we do seem to have > underestimated the demand for them. Explanation: > > We have moved to a new process for merging the CPU content to the open > repo. Enhancements to skara have made it possible to merge this content via a > PR. This means that integrators no longer need direct push access to the master > repositories. (this is desirable for several reasons) Unfortunately as a result we > will no longer be able to push the tags directly either. Instead, what we have > decided to do is use skara to add the ga & +0 tags after the PR has been > integrated by commenting on the relevant commit. (e.g. > https://github.com/openjdk/jdk21u/commit/375769c6986866210a0f36aad580 > e3ac8e9eb068) > > Sergey (cc'd) and I have just been discussing it and he requested the addition of > the final promotion tag too (in this case jdk-21.0.2+13) which I have just done. > > Adding the tags for all every promotion would be time consuming and error > prone so I don't currently intend to do that in the absence of any substantive > objections. We will have to rethink our new approach if this is a problem. > > -Rob > > > ________________________________________ > From: Langer, Christoph > Sent: Tuesday 16 January 2024 22:11 > To: Robert Mckenna; jdk-updates-dev at openjdk.org > Subject: [External] : RE: [21u Communication] JDK 21.0.2 changes pushed > > Hi Rob, > > looks like you forgot to also push the individual build tags (e.g. via git push -- > follow-tags). Can you please publish them as well? > > Thanks > Christoph > > > -----Original Message----- > > From: jdk-updates-dev On Behalf Of > > Robert Mckenna > > Sent: Dienstag, 16. Januar 2024 19:13 > > To: jdk-updates-dev at openjdk.org > > Subject: [21u Communication] JDK 21.0.2 changes pushed > > > > 21.0.2 content has been pushed to > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Furld > > > efense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2Fopenjdk%2Fjdk21u__ > %3B!! > > ACWV5N9M2RV99hQ!PBdoWPD_UMqXDM- > 4XjLGKk6gypcsEc9jcPyuucDPsZEexHuVznQUip > > 4OEe5xRVdXl5s7XYpj00Gc_- > jihHIHBMtOhQ%24&data=05%7C02%7Cchristoph.lange > > > r%40sap.com%7Ccda56888f6fe472ea67008dc16e78355%7C42f7676cf455423 > c82f6d > > > c2d99791af7%7C0%7C0%7C638410430790364473%7CUnknown%7CTWFpbG > Zsb3d8eyJWI > > > joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30 > 00%7 > > > C%7C%7C&sdata=e50ndmLOs9ZseITB9MhZURyyzeyC5cGIYIeowWb7%2FjY%3D > &reserve > > d=0 > > > > -Rob From andrewlu at openjdk.org Wed Jan 17 09:39:07 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 17 Jan 2024 09:39:07 GMT Subject: [jdk17u-dev] RFR: 8169475: WheelModifier.java fails by timeout Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 613d32c2822a443fdcb131a7d67c528410e9f7e6 Changes: https://git.openjdk.org/jdk17u-dev/pull/2134/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2134&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8169475 Stats: 60 lines in 1 file changed: 41 ins; 9 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2134.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2134/head:pull/2134 PR: https://git.openjdk.org/jdk17u-dev/pull/2134 From andrewlu at openjdk.org Wed Jan 17 09:39:23 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 17 Jan 2024 09:39:23 GMT Subject: [jdk11u-dev] RFR: 8169475: WheelModifier.java fails by timeout Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport 613d32c2822a443fdcb131a7d67c528410e9f7e6 Changes: https://git.openjdk.org/jdk11u-dev/pull/2461/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2461&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8169475 Stats: 60 lines in 1 file changed: 41 ins; 9 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2461.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2461/head:pull/2461 PR: https://git.openjdk.org/jdk11u-dev/pull/2461 From sgehwolf at openjdk.org Wed Jan 17 09:57:03 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 17 Jan 2024 09:57:03 GMT Subject: [jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v6] In-Reply-To: References: Message-ID: On Wed, 10 Jan 2024 15:27:17 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.11-oracle. >> >> The backport was almost clean, except for two trivial resolves due to differences in whitespace in the context. >> >> The change comes with a CSR, which is already approved for 17. >> But the CSR requires changes wrt. to the original change. >> In 17, no EDDSA support is added. >> >> The PR comes with two commits: >> 1. the almost clean backport. I already skipped two comments added in head but not needed in 17 (SignatureMethod, DigestMethod). >> 2. removing the eddsa support. >> >> Tests pass, SAP nightly testing passed. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Cleanup Test as proposed by Martin B. >From the 17, 11 and 8u CSR: The port is largely the same in terms of implementation as that done for JDK 21. The javax.xml.crypto.dsig.SignatureMethod and javax.xml.crypto.dsig.DigestMethod interfaces will not be updated. Instead, end users would define the newly added EdDSA Signature methods locally in application code. Unlike JDK 17 and later, JDK 11 and 8 doesn't have EdDSA support by default. A 3rd party security provider which supports ed25519 and ed448 would be required. This suggests that EdDSA support was kept as this bug is about updating a bundled in-tree library from a third party (Apache Santuario). So changes to that third party code should be kept to a minimum, IMO. For JDK 11 and JDK 8 even a third party provider would be needed in order to be able to use EdDSA there. TLDR; Since this is a third-party library code upgrade, I'd suggest to go with https://github.com/openjdk/jdk17u-dev/pull/2116 HTH. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2006#issuecomment-1895461204 From goetz at openjdk.org Wed Jan 17 10:14:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 10:14:53 GMT Subject: [jdk17u-dev] RFR: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.11-oracle. > > I hat to resolve trivialle, presumably because [8257733: Move module-specific data from make to respective module](https://github.com/openjdk/jdk/commit/f8878cb0cc436993ef1222bc13b00b923d91aad1) is not in 17. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Restore missing files ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2126/files - new: https://git.openjdk.org/jdk17u-dev/pull/2126/files/9c33919c..1e7b281e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2126&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2126&range=01-02 Stats: 207 lines in 3 files changed: 207 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2126.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2126/head:pull/2126 PR: https://git.openjdk.org/jdk17u-dev/pull/2126 From omikhaltcova at openjdk.org Wed Jan 17 10:28:02 2024 From: omikhaltcova at openjdk.org (Olga Mikhaltsova) Date: Wed, 17 Jan 2024 10:28:02 GMT Subject: [jdk22u] RFR: 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform Message-ID: Hi! I would like to backport [JDK-8321972](https://bugs.openjdk.org/browse/JDK-8321972) to jdk22u. This patch fixes failure of runtime/Unsafe/InternalErrorTest.java after [JDK-8320886](https://bugs.openjdk.org/browse/JDK-8320886) for RISC-V platform, that was backported to jdk22 by [JDK-8321919](https://bugs.openjdk.org/browse/JDK-8321919). The original patch applies cleanly. It's related only to RISC-V. No risks for other platforms. I reproduced this issue on StarFive VisionFive2 board. After appling this patch runtime/Unsafe/InternalErrorTest.java passes. tier1 tests passed for RISC-V platform. ------------- Commit messages: - Backport e8768ae08dbee9c3e1ed01934142c03ffad5f349 Changes: https://git.openjdk.org/jdk22u/pull/24/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=24&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321972 Stats: 13 lines in 2 files changed: 11 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/24.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/24/head:pull/24 PR: https://git.openjdk.org/jdk22u/pull/24 From chegar at openjdk.org Wed Jan 17 10:41:24 2024 From: chegar at openjdk.org (Chris Hegarty) Date: Wed, 17 Jan 2024 10:41:24 GMT Subject: [jdk21u] RFR: 8323659: LinkedTransferQueue add and put methods call overridable offer Message-ID: Hi all, This pull request contains a backport of commit [ee4d9aa4](https://github.com/openjdk/jdk/commit/ee4d9aa4c11c47e7cf15f2742919ac20311f9ea7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Chris Hegarty on 16 Jan 2024 and was reviewed by Alan Bateman. Thanks! ------------- Commit messages: - Backport ee4d9aa4c11c47e7cf15f2742919ac20311f9ea7 Changes: https://git.openjdk.org/jdk21u/pull/433/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=433&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323659 Stats: 75 lines in 2 files changed: 72 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u/pull/433.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/433/head:pull/433 PR: https://git.openjdk.org/jdk21u/pull/433 From shade at openjdk.org Wed Jan 17 11:08:56 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 17 Jan 2024 11:08:56 GMT Subject: [jdk21u-dev] RFR: 8321120: Shenandoah: Remove ShenandoahElasticTLAB flag In-Reply-To: References: <9RxbqcBg2N9k3W1IyGphkAnK5Eo_tZlBkQmZoCfa2Es=.0a186435-7b97-4a55-a3c0-177867841e76@github.com> Message-ID: <-SE4OpLBUUNIogfTpL36ZL24wzWkDRRxx0OVpb9wtPs=.345c8d4e-a39f-41bb-9706-bb5e2c6d9717@github.com> On Wed, 17 Jan 2024 08:04:57 GMT, Goetz Lindenmaier wrote: > Hi @shipilev shouldn't we keep the definition of the option to assure the flag is still accepted in case some installation uses it? I think we should not silently remove product flags in released versions, even for DIAGNOSTIC ones. TBH, there is substantial freedom in dealing with experimental/diagnostic flags. This freedom allows easily adding unstable flags for field use _without_ associated maintenance headache. Once the flag outlives it usefulness, it could (and should) be removed. Once removed, backporting the removal to actively maintained releases simplifies backports. >From the user interface perspective, there are no stability guarantees attached to these flags. Their management does not even require CSR. Leaving the definition in while removing the implementation actually gets is in more awkward situation when diagnostic/experimental flag silently _does not work_. Yes, one can issue a warning, but I don't think we should care. This is why there is a long history of doing these cleanups. Just from the top history of `shenandoah_globals.hpp`: https://bugs.openjdk.org/browse/JDK-8259849 https://bugs.openjdk.org/browse/JDK-8254075 https://bugs.openjdk.org/browse/JDK-8241007 https://bugs.openjdk.org/browse/JDK-8245754 https://bugs.openjdk.org/browse/JDK-8245825 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/177#issuecomment-1895584528 From chegar at openjdk.org Wed Jan 17 11:23:06 2024 From: chegar at openjdk.org (Chris Hegarty) Date: Wed, 17 Jan 2024 11:23:06 GMT Subject: [jdk21u] Withdrawn: 8323659: LinkedTransferQueue add and put methods call overridable offer In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 10:35:16 GMT, Chris Hegarty wrote: > Hi all, > > This pull request contains a backport of commit [ee4d9aa4](https://github.com/openjdk/jdk/commit/ee4d9aa4c11c47e7cf15f2742919ac20311f9ea7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Chris Hegarty on 16 Jan 2024 and was reviewed by Alan Bateman. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u/pull/433 From chegar at openjdk.org Wed Jan 17 11:23:05 2024 From: chegar at openjdk.org (Chris Hegarty) Date: Wed, 17 Jan 2024 11:23:05 GMT Subject: [jdk21u] RFR: 8323659: LinkedTransferQueue add and put methods call overridable offer In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 10:35:16 GMT, Chris Hegarty wrote: > Hi all, > > This pull request contains a backport of commit [ee4d9aa4](https://github.com/openjdk/jdk/commit/ee4d9aa4c11c47e7cf15f2742919ac20311f9ea7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Chris Hegarty on 16 Jan 2024 and was reviewed by Alan Bateman. > > Thanks! Closing in favour of a separate PR targeting 21u-dev ( whereas this PR incorrectly targeted 21u ) ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/433#issuecomment-1895605955 From chegar at openjdk.org Wed Jan 17 11:27:39 2024 From: chegar at openjdk.org (Chris Hegarty) Date: Wed, 17 Jan 2024 11:27:39 GMT Subject: [jdk21u-dev] RFR: 8323659: LinkedTransferQueue add and put methods call overridable offer Message-ID: Hi all, This pull request contains a backport of commit [ee4d9aa4](https://github.com/openjdk/jdk/commit/ee4d9aa4c11c47e7cf15f2742919ac20311f9ea7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Chris Hegarty on 16 Jan 2024 and was reviewed by Alan Bateman. Thanks! ------------- Commit messages: - Backport ee4d9aa4c11c47e7cf15f2742919ac20311f9ea7 Changes: https://git.openjdk.org/jdk21u-dev/pull/180/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=180&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323659 Stats: 75 lines in 2 files changed: 72 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/180.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/180/head:pull/180 PR: https://git.openjdk.org/jdk21u-dev/pull/180 From chegar at openjdk.org Wed Jan 17 11:32:57 2024 From: chegar at openjdk.org (Chris Hegarty) Date: Wed, 17 Jan 2024 11:32:57 GMT Subject: [jdk21u-dev] RFR: 8323659: LinkedTransferQueue add and put methods call overridable offer In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 11:21:18 GMT, Chris Hegarty wrote: > Hi all, > > This pull request contains a backport of commit [ee4d9aa4](https://github.com/openjdk/jdk/commit/ee4d9aa4c11c47e7cf15f2742919ac20311f9ea7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Chris Hegarty on 16 Jan 2024 and was reviewed by Alan Bateman. > > Thanks! A 21u fix request has been added to the master JIRA issue. Awaiting CI test results and then approval. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/180#issuecomment-1895620750 From mbaesken at openjdk.org Wed Jan 17 11:42:54 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 17 Jan 2024 11:42:54 GMT Subject: [jdk17u-dev] RFR: 8323806: [17u] VS2017 build fails with warning after 8293117. In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 13:58:25 GMT, Goetz Lindenmaier wrote: > We need this to fix our build with VS2017. > The warning is disabled limited to this one compiler version. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2133#pullrequestreview-1827107714 From shade at openjdk.org Wed Jan 17 12:05:57 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 17 Jan 2024 12:05:57 GMT Subject: [jdk17u-dev] RFR: 8323806: [17u] VS2017 build fails with warning after 8293117. In-Reply-To: References: Message-ID: <9gKkT6mbV04g7wBIOtHJ3R_h9_TgDwmig6sqLP_xwiE=.73599aa1-37c0-4f4d-b6d2-8f78d74c6b08@github.com> On Tue, 16 Jan 2024 13:58:25 GMT, Goetz Lindenmaier wrote: > We need this to fix our build with VS2017. > The warning is disabled limited to this one compiler version. OK, fine, let's do it for 17u specifically. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2133#pullrequestreview-1827146555 From mbaesken at openjdk.org Wed Jan 17 12:37:03 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 17 Jan 2024 12:37:03 GMT Subject: [jdk21u-dev] RFR: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size Message-ID: Backport 8322098 ------------- Commit messages: - Backport b31454e36234091c3827c3b4d07f62345cb0cee4 Changes: https://git.openjdk.org/jdk21u-dev/pull/181/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=181&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322098 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/181.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/181/head:pull/181 PR: https://git.openjdk.org/jdk21u-dev/pull/181 From goetz at openjdk.org Wed Jan 17 12:46:07 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 12:46:07 GMT Subject: [jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v6] In-Reply-To: References: Message-ID: On Wed, 10 Jan 2024 15:27:17 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.11-oracle. >> >> The backport was almost clean, except for two trivial resolves due to differences in whitespace in the context. >> >> The change comes with a CSR, which is already approved for 17. >> But the CSR requires changes wrt. to the original change. >> In 17, no EDDSA support is added. >> >> The PR comes with two commits: >> 1. the almost clean backport. I already skipped two comments added in head but not needed in 17 (SignatureMethod, DigestMethod). >> 2. removing the eddsa support. >> >> Tests pass, SAP nightly testing passed. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Cleanup Test as proposed by Martin B. Thanks for your help! Closing this PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2006#issuecomment-1895736060 From goetz at openjdk.org Wed Jan 17 12:46:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 12:46:09 GMT Subject: [jdk17u-dev] Withdrawn: 8305972: Update XML Security for Java to 3.0.2 In-Reply-To: References: Message-ID: On Thu, 30 Nov 2023 08:48:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. > > The backport was almost clean, except for two trivial resolves due to differences in whitespace in the context. > > The change comes with a CSR, which is already approved for 17. > But the CSR requires changes wrt. to the original change. > In 17, no EDDSA support is added. > > The PR comes with two commits: > 1. the almost clean backport. I already skipped two comments added in head but not needed in 17 (SignatureMethod, DigestMethod). > 2. removing the eddsa support. > > Tests pass, SAP nightly testing passed. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2006 From mbaesken at openjdk.org Wed Jan 17 12:58:28 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 17 Jan 2024 12:58:28 GMT Subject: [jdk11u-dev] RFR: 8318955: Add ReleaseIntArrayElements in Java_sun_awt_X11_XlibWrapper_SetBitmapShape XlbWrapper.c to early return Message-ID: <8ZjUbvRHFkQr30C_aghRISr12CE5JBrENe64yTuSgRY=.54ec02cd-1956-446d-a3d1-a29f43504fd2@github.com> 8318955: Add ReleaseIntArrayElements in Java_sun_awt_X11_XlibWrapper_SetBitmapShape XlbWrapper.c to early return ------------- Commit messages: - Backport 81db1721d4fac954003441ca2c3c29b0998d310d Changes: https://git.openjdk.org/jdk11u-dev/pull/2462/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2462&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318955 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2462.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2462/head:pull/2462 PR: https://git.openjdk.org/jdk11u-dev/pull/2462 From kevin.rushforth at oracle.com Wed Jan 17 13:01:29 2024 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Wed, 17 Jan 2024 05:01:29 -0800 Subject: [21u Communication] JDK 21.0.2 changes pushed In-Reply-To: References: Message-ID: Hi Christoph, This was the result of a misunderstanding about the commit hash to use in the PR title when creating the Merge PR. The original merge commit, with hash 289f7a7ab6f5f6cdd46e6183083842a91f496f34, was in the PR branch, but was dropped by Skara because the PR title pointed to the parent of that commit and not to the merge commit itself. Skara then (correctly, given the title of the PR) dropped that Merge commit and produced an identical merge commit, but with a different hash. It will be easy to avoid this problem next time by using the right hash in the PR title. -- Kevin On 1/17/2024 1:05 AM, Langer, Christoph wrote: > Hi Rob, > > thanks for your prompt response. > > I think it is ok to only push the final promotion tag. (At least for me.) > > One thing that I can see now is that the original (merge-)commit that was tagged jdk-21.0.2+13 in the bundle distributed via vuln-dev (e.g. https://github.com/openjdk/jdk21u/pull/432/commits/289f7a7ab6f5f6cdd46e6183083842a91f496f34) is different from the merge commit created by the merge PR that is now in the jdk21u repo (https://github.com/openjdk/jdk21u/commit/375769c6986866210a0f36aad580e3ac8e9eb068). Not sure whether Skara tools could be further improved to keep the original commit (hash) if possible? > > Thanks > Christoph > >> -----Original Message----- >> From: Robert Mckenna >> Sent: Mittwoch, 17. Januar 2024 00:04 >> To: Langer, Christoph ; jdk-updates- >> dev at openjdk.org >> Cc: Sergey Bylokhov >> Subject: Re: [21u Communication] JDK 21.0.2 changes pushed >> >> Hi Christoph, >> >> In fact, we hadn't forgotten to add these tags, but we do seem to have >> underestimated the demand for them. Explanation: >> >> We have moved to a new process for merging the CPU content to the open >> repo. Enhancements to skara have made it possible to merge this content via a >> PR. This means that integrators no longer need direct push access to the master >> repositories. (this is desirable for several reasons) Unfortunately as a result we >> will no longer be able to push the tags directly either. Instead, what we have >> decided to do is use skara to add the ga & +0 tags after the PR has been >> integrated by commenting on the relevant commit. (e.g. >> https://github.com/openjdk/jdk21u/commit/375769c6986866210a0f36aad580 >> e3ac8e9eb068) >> >> Sergey (cc'd) and I have just been discussing it and he requested the addition of >> the final promotion tag too (in this case jdk-21.0.2+13) which I have just done. >> >> Adding the tags for all every promotion would be time consuming and error >> prone so I don't currently intend to do that in the absence of any substantive >> objections. We will have to rethink our new approach if this is a problem. >> >> -Rob >> >> >> ________________________________________ >> From: Langer, Christoph >> Sent: Tuesday 16 January 2024 22:11 >> To: Robert Mckenna; jdk-updates-dev at openjdk.org >> Subject: [External] : RE: [21u Communication] JDK 21.0.2 changes pushed >> >> Hi Rob, >> >> looks like you forgot to also push the individual build tags (e.g. via git push -- >> follow-tags). Can you please publish them as well? >> >> Thanks >> Christoph >> >>> -----Original Message----- >>> From: jdk-updates-dev On Behalf Of >>> Robert Mckenna >>> Sent: Dienstag, 16. Januar 2024 19:13 >>> To: jdk-updates-dev at openjdk.org >>> Subject: [21u Communication] JDK 21.0.2 changes pushed >>> >>> 21.0.2 content has been pushed to >>> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Furld >>> >> efense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2Fopenjdk%2Fjdk21u__ >> %3B!! >>> ACWV5N9M2RV99hQ!PBdoWPD_UMqXDM- >> 4XjLGKk6gypcsEc9jcPyuucDPsZEexHuVznQUip >>> 4OEe5xRVdXl5s7XYpj00Gc_- >> jihHIHBMtOhQ%24&data=05%7C02%7Cchristoph.lange >> r%40sap.com%7Ccda56888f6fe472ea67008dc16e78355%7C42f7676cf455423 >> c82f6d >> c2d99791af7%7C0%7C0%7C638410430790364473%7CUnknown%7CTWFpbG >> Zsb3d8eyJWI >> joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30 >> 00%7 >> C%7C%7C&sdata=e50ndmLOs9ZseITB9MhZURyyzeyC5cGIYIeowWb7%2FjY%3D >> &reserve >>> d=0 >>> >>> -Rob From mbaesken at openjdk.org Wed Jan 17 13:03:59 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 17 Jan 2024 13:03:59 GMT Subject: [jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v3] In-Reply-To: References: Message-ID: On Mon, 15 Jan 2024 07:13:46 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.11-oracle. >> >> This is a minimal version that only removes the strings from the interface, as well as the comment. Removing these is explicitly stated in the CSR. >> >> The change keeps the EdDSA implementation. As I understand, 17 supports EdDSA in general, it was just not included for XML when 17 was released. >> https://bugs.openjdk.org/browse/JDK-8305972 > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into goetz_backport_8305972-minimal > - Remove Strings as proposed in CSR > - Backport f0aebc8141de5a50c88658a40caa01967a9afc53 Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2116#pullrequestreview-1827246553 From goetz at openjdk.org Wed Jan 17 13:08:15 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 13:08:15 GMT Subject: [jdk21u-dev] RFR: 8318590: JButton ignores margin when painting HTML text Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport acaf2c8dcfd5235f758af2fe3e308b72263113e4 Changes: https://git.openjdk.org/jdk21u-dev/pull/182/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=182&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318590 Stats: 193 lines in 4 files changed: 8 ins; 177 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/182.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/182/head:pull/182 PR: https://git.openjdk.org/jdk21u-dev/pull/182 From mdoerr at openjdk.org Wed Jan 17 13:22:57 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 17 Jan 2024 13:22:57 GMT Subject: [jdk17u-dev] RFR: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing [v3] In-Reply-To: References: Message-ID: <6W8K7BpGwqs4VIbtInv_FchKA2EJtC72lGM1Ger0ETE=.7b2d8d72-486d-49bd-b19e-9fff3f1548e2@github.com> On Wed, 17 Jan 2024 10:14:53 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 17.0.11-oracle. >> >> I hat to resolve trivialle, presumably because [8257733: Move module-specific data from make to respective module](https://github.com/openjdk/jdk/commit/f8878cb0cc436993ef1222bc13b00b923d91aad1) is not in 17. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Restore missing files LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2126#pullrequestreview-1827282331 From goetz at openjdk.org Wed Jan 17 13:34:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 13:34:16 GMT Subject: [jdk21u-dev] RFR: 8311663: Additional refactoring of Locale tests to JUnit Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 71cac8ce47b69a2b78d54cbceb0f0510e5ea4cdc Changes: https://git.openjdk.org/jdk21u-dev/pull/183/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=183&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311663 Stats: 549 lines in 10 files changed: 159 ins; 217 del; 173 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/183.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/183/head:pull/183 PR: https://git.openjdk.org/jdk21u-dev/pull/183 From goetz at openjdk.org Wed Jan 17 13:41:18 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 13:41:18 GMT Subject: [jdk21u-dev] RFR: 8315241: (fs) Move toRealPath tests in java/nio/file/Path/Misc.java to separate JUnit 5 test Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport dd64a4a483a831fd66912491af10502c4cf8596b Changes: https://git.openjdk.org/jdk21u-dev/pull/184/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=184&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315241 Stats: 334 lines in 2 files changed: 191 ins; 141 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/184.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/184/head:pull/184 PR: https://git.openjdk.org/jdk21u-dev/pull/184 From goetz at openjdk.org Wed Jan 17 13:54:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 13:54:20 GMT Subject: [jdk21u-dev] RFR: 8312136: Modify runtime/ErrorHandling/TestDwarf.java to split dwarf and decoder testing Message-ID: <-8u86DeMW6iKrMnEyMvM0DcUCdLBI9e1dpPG4iDThWk=.a479e3ed-c4b9-4c9c-bb0b-6f6c38cde6bb@github.com> I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport e2e8e8e210ea9a7a9d901a1da729551714015d04 Changes: https://git.openjdk.org/jdk21u-dev/pull/185/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=185&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312136 Stats: 37 lines in 2 files changed: 30 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/185.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/185/head:pull/185 PR: https://git.openjdk.org/jdk21u-dev/pull/185 From lucy at openjdk.org Wed Jan 17 14:15:53 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Wed, 17 Jan 2024 14:15:53 GMT Subject: [jdk21u-dev] RFR: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 12:29:32 GMT, Matthias Baesken wrote: > Backport 8322098 Looks good. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/181#pullrequestreview-1827391504 From goetz at openjdk.org Wed Jan 17 14:24:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 14:24:14 GMT Subject: [jdk21u-dev] RFR: 8314283: Support for NSS tests on aarch64 platforms Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 2a8016096000de5836251f2ca9bc8ad6479e6942 Changes: https://git.openjdk.org/jdk21u-dev/pull/187/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=187&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314283 Stats: 41 lines in 2 files changed: 24 ins; 3 del; 14 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/187.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/187/head:pull/187 PR: https://git.openjdk.org/jdk21u-dev/pull/187 From goetz at openjdk.org Wed Jan 17 14:24:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 14:24:24 GMT Subject: [jdk21u-dev] RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 Message-ID: I backport this for parity with 21.0.3-oracle. I had to resolve the ProblemList. Probably clean anyways, else will mark as such. ------------- Commit messages: - Backport c2e77e2f17b624e750dea8fd51bbfde99596690e Changes: https://git.openjdk.org/jdk21u-dev/pull/186/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=186&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319128 Stats: 121 lines in 7 files changed: 9 ins; 87 del; 25 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/186.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/186/head:pull/186 PR: https://git.openjdk.org/jdk21u-dev/pull/186 From goetz at openjdk.org Wed Jan 17 14:53:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 14:53:56 GMT Subject: [jdk21u-dev] RFR: Merge jdk21u:master Message-ID: Merge build tag 21.0.2-ga from jdk21u to jdk21u-dev ------------- Commit messages: - Merge - Merge - 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries - Merge - 8317547: Enhance TLS connection support - Merge - Merge - 8320001: javac crashes while adding type annotations to the return type of a constructor - Merge remote-tracking branch 'jdk21u/master' into jdk21.0.2 - Merge remote-tracking branch 'jdk21u/master' into jdk21.0.2 - ... and 33 more: https://git.openjdk.org/jdk21u-dev/compare/0ac1bb75...5fd5e0d7 The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=188&range=00.0 - jdk21u:master: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=188&range=00.1 Changes: https://git.openjdk.org/jdk21u-dev/pull/188/files Stats: 1571 lines in 27 files changed: 562 ins; 790 del; 219 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/188.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/188/head:pull/188 PR: https://git.openjdk.org/jdk21u-dev/pull/188 From clanger at openjdk.org Wed Jan 17 15:00:57 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 17 Jan 2024 15:00:57 GMT Subject: [jdk21u-dev] RFR: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 12:29:32 GMT, Matthias Baesken wrote: > Backport 8322098 Hi @MBaesken, could you please also add JDK-8323331 as issue to this PR? It should be marked as resolved by this backport, too. Thx. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/181#issuecomment-1895986119 From mbaesken at openjdk.org Wed Jan 17 15:09:56 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 17 Jan 2024 15:09:56 GMT Subject: [jdk21u-dev] RFR: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size In-Reply-To: References: Message-ID: <-KC_5xN38d9bu7AX1hb7vKaDx5tvLG6YoltG8G2xIjU=.d19615ca-f7a2-486f-9195-d0e343dd5876@github.com> On Wed, 17 Jan 2024 14:58:15 GMT, Christoph Langer wrote: > Hi @MBaesken, could you please also add JDK-8323331 as issue to this PR? It should be marked as resolved by this backport, too. Thx. Sure , I added it above, hope this is okay and works as expected . ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/181#issuecomment-1896005981 From goetz at openjdk.org Wed Jan 17 15:12:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 15:12:11 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:master Message-ID: Merge build tag 17.0.10-ga from jdk17u to jdk17u-dev (Well, the branch name is a bit misleading, sorry) ------------- Commit messages: - Merge - 8323422: [17u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 17.0.10 - 8314307: Improve loop handling - 8317547: Enhance TLS connection support - 8316976: Improve signature handling - 8276123: ZipFile::getEntry will not return a file entry when there is a directory entry of the same name within a Zip File - 8314468: Improve Compiler loops - 8314295: Enhance verification of verifier - 8308204: Enhanced certificate processing - 8320597: RSA signature verification fails on signed data that does not encode params correctly - ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/3b03c062...0543deda The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2135&range=00.0 - jdk17u:master: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2135&range=00.1 Changes: https://git.openjdk.org/jdk17u-dev/pull/2135/files Stats: 1175 lines in 16 files changed: 972 ins; 62 del; 141 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2135.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2135/head:pull/2135 PR: https://git.openjdk.org/jdk17u-dev/pull/2135 From shade at openjdk.org Wed Jan 17 15:21:03 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 17 Jan 2024 15:21:03 GMT Subject: [jdk21u-dev] Integrated: 8319372: C2 compilation fails with "Bad immediate dominator info" In-Reply-To: References: Message-ID: On Wed, 10 Jan 2024 19:04:32 GMT, Aleksey Shipilev wrote: > Clean backport to fix C2 bug and better parity. > > Testing: > - [x] New regression tests fail with the fix and pass with it > - [x] Linux x86_64 server fastdebug, `tier{1,2,3,4}` > - [x] Linux x86_64 server fastdebug, `tier{1,2,3,4}` This pull request has now been integrated. Changeset: b4c163d0 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/b4c163d07b2db96ce91a0f712ced60ace14dbf63 Stats: 244 lines in 4 files changed: 171 ins; 73 del; 0 mod 8319372: C2 compilation fails with "Bad immediate dominator info" Backport-of: 7766785098816cfcdae3479540cdc866c1ed18ad ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/157 From shade at openjdk.org Wed Jan 17 15:22:54 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 17 Jan 2024 15:22:54 GMT Subject: [jdk21u-dev] RFR: Merge jdk21u:master In-Reply-To: References: Message-ID: <8GgHPI2d6vIcq7bxaoeumrorgwOE91eSSEIMedScgDs=.52b7db38-eccd-44d4-a487-d3f4e7ba65b6@github.com> On Wed, 17 Jan 2024 14:44:14 GMT, Goetz Lindenmaier wrote: > Merge build tag 21.0.2-ga from jdk21u to jdk21u-dev Oh. I just started integrating stuff to jdk21u-dev after the recent round of approvals, and now I see it might collide with some of these changes. Please push this as soon as possible, so we detect the conflicts early. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/188#issuecomment-1896031607 From goetz at openjdk.org Wed Jan 17 15:54:02 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 15:54:02 GMT Subject: [jdk21u-dev] Integrated: Merge jdk21u:master In-Reply-To: References: Message-ID: <42Pcw_x2itJ7N8WA9fcUbJaHyujnS-wPFhaiO1Tszak=.1ba849d7-e864-4ea9-b904-c2d7da2d145a@github.com> On Wed, 17 Jan 2024 14:44:14 GMT, Goetz Lindenmaier wrote: > Merge build tag 21.0.2-ga from jdk21u to jdk21u-dev This pull request has now been integrated. Changeset: 95142cf9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/95142cf93bb6ac1abe085af51dac91b8e2bd739e Stats: 1571 lines in 27 files changed: 562 ins; 790 del; 219 mod Merge ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/188 From goetz at openjdk.org Wed Jan 17 15:56:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 15:56:01 GMT Subject: [jdk17u-dev] Integrated: Merge jdk17u:master In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 15:06:51 GMT, Goetz Lindenmaier wrote: > Merge build tag 17.0.10-ga from jdk17u to jdk17u-dev > > (Well, the branch name is a bit misleading, sorry) This pull request has now been integrated. Changeset: 8e41a9a5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/8e41a9a5053cc8e58a434430b8b5fd0f05ac2740 Stats: 1175 lines in 16 files changed: 972 ins; 62 del; 141 mod Merge ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2135 From goetz at openjdk.org Wed Jan 17 16:05:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 16:05:17 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: <0YESh5ctwpK3XdNSE4jTETFU3KwGxLkSgKr8lbEcbUU=.6dd8ad29-0216-484f-a7e5-b362d51ee780@github.com> Merge build tag 11.0.22-ga from jdk11u to jdk11u-dev ------------- Commit messages: - Merge branch 'master' into Merge_jdk11u_master - Merge - 8323423: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.22 - 8314307: Improve loop handling - 8317547: Enhance TLS connection support - 8316976: Improve signature handling - 8314468: Improve Compiler loops - 8314295: Enhance verification of verifier - 8314284: Enhance Nashorn performance - 8308204: Enhanced certificate processing - ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/573f6b3f...8398f36f The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2463&range=00.0 - jdk11u:master: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2463&range=00.1 Changes: https://git.openjdk.org/jdk11u-dev/pull/2463/files Stats: 609 lines in 15 files changed: 394 ins; 56 del; 159 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2463.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2463/head:pull/2463 PR: https://git.openjdk.org/jdk11u-dev/pull/2463 From wkemper at openjdk.org Wed Jan 17 16:05:58 2024 From: wkemper at openjdk.org (William Kemper) Date: Wed, 17 Jan 2024 16:05:58 GMT Subject: [jdk21u-dev] Integrated: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation In-Reply-To: <1FVUHUww6yCcpVPdp-TZLcPZU_8-PCwGUZGicGeM8ZQ=.9d3bb228-da53-41cd-ae14-6021149c5930@github.com> References: <1FVUHUww6yCcpVPdp-TZLcPZU_8-PCwGUZGicGeM8ZQ=.9d3bb228-da53-41cd-ae14-6021149c5930@github.com> Message-ID: On Mon, 8 Jan 2024 19:33:39 GMT, William Kemper wrote: > 8323086: Shenandoah: Heap could be corrupted by oom during evacuation This pull request has now been integrated. Changeset: 9ca87615 Author: William Kemper Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/9ca87615550eba5493dde94e6204e58ca8cc1119 Stats: 21 lines in 1 file changed: 21 ins; 0 del; 0 mod 8323086: Shenandoah: Heap could be corrupted by oom during evacuation Backport-of: c4a83bd6f6c45e72bd776e929005be0aa9408867 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/145 From shade at openjdk.org Wed Jan 17 16:06:56 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 17 Jan 2024 16:06:56 GMT Subject: [jdk21u-dev] RFR: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled In-Reply-To: References: Message-ID: On Thu, 11 Jan 2024 00:06:16 GMT, William Kemper wrote: > 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled I restarted the jobs in GHA for this PR (since it was bots repo, I apparently can do that!). Let's make sure it passes before we integrate. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/158#issuecomment-1896119567 From szaldana at openjdk.org Wed Jan 17 16:09:58 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 17 Jan 2024 16:09:58 GMT Subject: [jdk21u-dev] Integrated: 8319103: Popups that request focus are not shown on Linux with Wayland In-Reply-To: References: Message-ID: <8vjtuZvz79nh3L2zRRXROG4BhQLiYuFHUVGiZiOinRQ=.c36ac2a7-1b6d-4ce2-be51-bc8c77397d2e@github.com> On Tue, 9 Jan 2024 18:52:10 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [f3ed2758](https://github.com/openjdk/jdk/commit/f3ed27582e16c3a323f590863cbeec6d35e20b58) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexander Zvegintsev on 16 Nov 2023 and was reviewed by Sergey Bylokhov and Phil Race. > > Thanks! This pull request has now been integrated. Changeset: fcf9ebde Author: Sonia Zaldana Calles Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/fcf9ebde634a7274fc110094f613e0c0af979893 Stats: 128 lines in 2 files changed: 121 ins; 5 del; 2 mod 8319103: Popups that request focus are not shown on Linux with Wayland Backport-of: f3ed27582e16c3a323f590863cbeec6d35e20b58 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/155 From szaldana at openjdk.org Wed Jan 17 16:10:53 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 17 Jan 2024 16:10:53 GMT Subject: [jdk21u-dev] Integrated: 8318154: Improve stability of WheelModifier.java test In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 16:06:05 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [668d4b07](https://github.com/openjdk/jdk/commit/668d4b077f260a30a90842a01b38a9cf6718d418) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Renjith Kannath Pariyangad on 16 Oct 2023 and was reviewed by Alexey Ivanov. > > Thanks! This pull request has now been integrated. Changeset: 8d536b6f Author: Sonia Zaldana Calles Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/8d536b6f1045c243e0e36951544320c15adfa7c1 Stats: 25 lines in 1 file changed: 16 ins; 1 del; 8 mod 8318154: Improve stability of WheelModifier.java test Backport-of: 668d4b077f260a30a90842a01b38a9cf6718d418 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/153 From szaldana at openjdk.org Wed Jan 17 16:14:02 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 17 Jan 2024 16:14:02 GMT Subject: [jdk21u-dev] Integrated: 8318613: ChoiceFormat patterns are not well tested In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 16:01:22 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [10427c02](https://github.com/openjdk/jdk/commit/10427c023a142a24db3c2492977a7233a1afc25d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Justin Lu on 25 Oct 2023 and was reviewed by Naoto Sato. > > Thanks! This pull request has now been integrated. Changeset: 32a4568e Author: Sonia Zaldana Calles Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/32a4568ec49df66798c7d5b20765281f45b66d1e Stats: 153 lines in 1 file changed: 153 ins; 0 del; 0 mod 8318613: ChoiceFormat patterns are not well tested Backport-of: 10427c023a142a24db3c2492977a7233a1afc25d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/164 From szaldana at openjdk.org Wed Jan 17 16:14:03 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 17 Jan 2024 16:14:03 GMT Subject: [jdk21u-dev] Integrated: 8316106: Open source few swing JInternalFrame and JMenuBar tests In-Reply-To: References: Message-ID: <9ytjCu4FwHA67Mun22QBcBXJonOlAoHWQMjFQqnOz98=.eb8b33d5-13d3-4295-a1a6-02f4026632e0@github.com> On Tue, 9 Jan 2024 15:42:31 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [0775bf2f](https://github.com/openjdk/jdk/commit/0775bf2f0375b1bc63c187399cbc3fdc5a192bce) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Abhishek Kumar on 15 Sep 2023 and was reviewed by Alexander Zuev and Tejesh R. > > Thanks! This pull request has now been integrated. Changeset: 1e8c226d Author: Sonia Zaldana Calles Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/1e8c226da521f84751f0ef7820cfeb0ba44457ec Stats: 457 lines in 5 files changed: 457 ins; 0 del; 0 mod 8316106: Open source few swing JInternalFrame and JMenuBar tests Backport-of: 0775bf2f0375b1bc63c187399cbc3fdc5a192bce ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/152 From clanger at openjdk.org Wed Jan 17 16:32:53 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 17 Jan 2024 16:32:53 GMT Subject: [jdk21u-dev] RFR: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size In-Reply-To: <-KC_5xN38d9bu7AX1hb7vKaDx5tvLG6YoltG8G2xIjU=.d19615ca-f7a2-486f-9195-d0e343dd5876@github.com> References: <-KC_5xN38d9bu7AX1hb7vKaDx5tvLG6YoltG8G2xIjU=.d19615ca-f7a2-486f-9195-d0e343dd5876@github.com> Message-ID: <7Sclf0sUoXVdUkqU6jRd6l_zh7zTuA3vBXPD0snvzpQ=.5afc6b23-304b-4a6d-8166-0d3b76183489@github.com> On Wed, 17 Jan 2024 15:07:39 GMT, Matthias Baesken wrote: > > Hi @MBaesken, could you please also add JDK-8323331 as issue to this PR? It should be marked as resolved by this backport, too. Thx. > > Sure , I added it above, hope this is okay and works as expected . No, I meant to add the issue to the list of issues resolved by this PR via the "/issue add" skara command. I tried to add it above but I believe Skara won't accept this because it is not my PR. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/181#issuecomment-1896170061 From shade at openjdk.org Wed Jan 17 18:06:22 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 17 Jan 2024 18:06:22 GMT Subject: [jdk21u-dev] RFR: 8322957: Generational ZGC: Relocation selection must join the STS Message-ID: Clean backport to fix Generational ZGC. FYI @fisk, @stefank, I am picking this up to 21u. Tell me if this is a bad idea :) Additional testing: - [x] Linux x86_64 server fastdebug, `hotspot_gc` with `+ZGenerational` - [ ] Linux x86_64 server fastdebug, `tier{1,2,3,4}` ------------- Commit messages: - Backport ba23025cd8a9c1af37afea6444ce5ea2ff41e5af Changes: https://git.openjdk.org/jdk21u-dev/pull/189/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=189&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322957 Stats: 168 lines in 14 files changed: 127 ins; 20 del; 21 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/189.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/189/head:pull/189 PR: https://git.openjdk.org/jdk21u-dev/pull/189 From eosterlund at openjdk.org Wed Jan 17 18:06:22 2024 From: eosterlund at openjdk.org (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Wed, 17 Jan 2024 18:06:22 GMT Subject: [jdk21u-dev] RFR: 8322957: Generational ZGC: Relocation selection must join the STS In-Reply-To: References: Message-ID: <4_CwHrK80vU9kKNfqzivhqcn7Q1rwnHVT91kLOfBrEU=.739e0545-08c4-4dee-83f7-b8f1a3645c46@github.com> On Wed, 17 Jan 2024 15:45:23 GMT, Aleksey Shipilev wrote: > Clean backport to fix Generational ZGC. > > FYI @fisk, @stefank, I am picking this up to 21u. Tell me if this is a bad idea :) > > Additional testing: > - [x] Linux x86_64 server fastdebug, `hotspot_gc` with `+ZGenerational` > - [ ] Linux x86_64 server fastdebug, `tier{1,2,3,4}` Sounds like a good idea. ------------- Marked as reviewed by eosterlund (Committer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/189#pullrequestreview-1827749865 From phh at openjdk.org Wed Jan 17 18:18:01 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 17 Jan 2024 18:18:01 GMT Subject: [jdk17u-dev] RFR: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled In-Reply-To: References: Message-ID: <0n5zujVtUOyZnb88kJkD-GXkoBV1F2QK_3Nllem_BMk=.4d4b9534-6e14-4b73-91ba-54b3d02be5fa@github.com> On Thu, 11 Jan 2024 00:06:11 GMT, William Kemper wrote: > 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled GHA failures are infrastructure issues. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2120#issuecomment-1896350194 From wkemper at openjdk.org Wed Jan 17 18:18:02 2024 From: wkemper at openjdk.org (William Kemper) Date: Wed, 17 Jan 2024 18:18:02 GMT Subject: [jdk17u-dev] Integrated: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled In-Reply-To: References: Message-ID: On Thu, 11 Jan 2024 00:06:11 GMT, William Kemper wrote: > 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled This pull request has now been integrated. Changeset: af1e82cf Author: William Kemper Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/af1e82cf6a4b5172c242d04bb38a0e581b66bd09 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled Backport-of: a7db4fecebe98135d36c6f46e1fa60959adbe78b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2120 From phh at openjdk.org Wed Jan 17 18:19:58 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 17 Jan 2024 18:19:58 GMT Subject: [jdk21u-dev] RFR: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled In-Reply-To: References: Message-ID: On Thu, 11 Jan 2024 00:06:16 GMT, William Kemper wrote: > 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled GHA failures are GHA infrastructure issues. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/158#issuecomment-1896354784 From wkemper at openjdk.org Wed Jan 17 18:19:59 2024 From: wkemper at openjdk.org (William Kemper) Date: Wed, 17 Jan 2024 18:19:59 GMT Subject: [jdk21u-dev] Integrated: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled In-Reply-To: References: Message-ID: On Thu, 11 Jan 2024 00:06:16 GMT, William Kemper wrote: > 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled This pull request has now been integrated. Changeset: f0115385 Author: William Kemper Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/f0115385b61774220a87be4b2ecfb0bf61abea64 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled Backport-of: a7db4fecebe98135d36c6f46e1fa60959adbe78b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/158 From phh at openjdk.org Wed Jan 17 18:20:00 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 17 Jan 2024 18:20:00 GMT Subject: [jdk22u] RFR: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled In-Reply-To: References: Message-ID: On Wed, 10 Jan 2024 23:48:15 GMT, William Kemper wrote: > 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled GHA failures are GHA infrastructure issues. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/17#issuecomment-1896358444 From wkemper at openjdk.org Wed Jan 17 18:20:00 2024 From: wkemper at openjdk.org (William Kemper) Date: Wed, 17 Jan 2024 18:20:00 GMT Subject: [jdk22u] Integrated: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled In-Reply-To: References: Message-ID: On Wed, 10 Jan 2024 23:48:15 GMT, William Kemper wrote: > 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled This pull request has now been integrated. Changeset: a1f0a3cc Author: William Kemper Committer: Paul Hohensee URL: https://git.openjdk.org/jdk22u/commit/a1f0a3cccc9d09efe0b62e1922caf9ac68fecfd6 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled Backport-of: a7db4fecebe98135d36c6f46e1fa60959adbe78b ------------- PR: https://git.openjdk.org/jdk22u/pull/17 From stefank at openjdk.org Wed Jan 17 18:21:54 2024 From: stefank at openjdk.org (Stefan Karlsson) Date: Wed, 17 Jan 2024 18:21:54 GMT Subject: [jdk21u-dev] RFR: 8322957: Generational ZGC: Relocation selection must join the STS In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 15:45:23 GMT, Aleksey Shipilev wrote: > Clean backport to fix Generational ZGC. > > FYI @fisk, @stefank, I am picking this up to 21u. Tell me if this is a bad idea :) > > Additional testing: > - [x] Linux x86_64 server fastdebug, `hotspot_gc` with `+ZGenerational` > - [ ] Linux x86_64 server fastdebug, `tier{1,2,3,4}` Thanks for taking care of this backport! ------------- Marked as reviewed by stefank (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/189#pullrequestreview-1827906702 From stefank at openjdk.org Wed Jan 17 18:24:52 2024 From: stefank at openjdk.org (Stefan Karlsson) Date: Wed, 17 Jan 2024 18:24:52 GMT Subject: [jdk21u-dev] RFR: 8322957: Generational ZGC: Relocation selection must join the STS In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 15:45:23 GMT, Aleksey Shipilev wrote: > Linux x86_64 server fastdebug, hotspot_gc with +ZGenerational Just to be sure, you're running this with -XX:+ZGenerational together with -XX:+UseZGC? I just want to make sure that you don't accidentally run G1 when testing this. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/189#issuecomment-1896374064 From duke at openjdk.org Wed Jan 17 19:23:02 2024 From: duke at openjdk.org (Philip Helger) Date: Wed, 17 Jan 2024 19:23:02 GMT Subject: [jdk17u-dev] RFR: 8296343: CPVE thrown on missing content-length in OCSP response In-Reply-To: References: Message-ID: On Wed, 24 May 2023 17:20:27 GMT, Alexey Pavlyutkin wrote: >> Hi @apavlyutkin >> since this push we see OCSPNoContentLength.java failing in out nightly tests. >> There is a related issue handling this: [JDK-8300939](https://bugs.openjdk.org/browse/JDK-8300939) >> >> sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors >> >> Please backport this, too! >> And next time please check related issues in the JBS Bug before labeling fix-request!!!! > >> Hi @apavlyutkin since this push we see OCSPNoContentLength.java failing in out nightly tests. There is a related issue handling this: [JDK-8300939](https://bugs.openjdk.org/browse/JDK-8300939) >> >> sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors >> >> Please backport this, too! And next time please check related issues in the JBS Bug before labeling fix-request!!!! > > https://github.com/openjdk/jdk17u-dev/pull/1394 @apavlyutkin what needs to be done, to get this issue back on track? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1361#issuecomment-1896480725 From shade at openjdk.org Wed Jan 17 20:01:54 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 17 Jan 2024 20:01:54 GMT Subject: [jdk21u-dev] RFR: 8323659: LinkedTransferQueue add and put methods call overridable offer In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 11:21:18 GMT, Chris Hegarty wrote: > Hi all, > > This pull request contains a backport of commit [ee4d9aa4](https://github.com/openjdk/jdk/commit/ee4d9aa4c11c47e7cf15f2742919ac20311f9ea7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Chris Hegarty on 16 Jan 2024 and was reviewed by Alan Bateman. > > Thanks! Looks good. I think you are good to `/integrate` as soon as GHA turn green. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/180#pullrequestreview-1828078823 From shade at openjdk.org Wed Jan 17 20:07:52 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 17 Jan 2024 20:07:52 GMT Subject: [jdk21u-dev] RFR: 8322957: Generational ZGC: Relocation selection must join the STS In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 18:21:54 GMT, Stefan Karlsson wrote: > > Linux x86_64 server fastdebug, hotspot_gc with +ZGenerational > > Just to be sure, you're running this with -XX:+ZGenerational together with -XX:+UseZGC? I just want to make sure that you don't accidentally run G1 when testing this. Yes, of course. I meant to indicate that I ran the tests with Generational ZGC. I am running even more tests now, and would request push approvals next week. Thanks for chiming in here! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/189#issuecomment-1896601665 From goetz at openjdk.org Wed Jan 17 20:45:59 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 20:45:59 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master In-Reply-To: <0YESh5ctwpK3XdNSE4jTETFU3KwGxLkSgKr8lbEcbUU=.6dd8ad29-0216-484f-a7e5-b362d51ee780@github.com> References: <0YESh5ctwpK3XdNSE4jTETFU3KwGxLkSgKr8lbEcbUU=.6dd8ad29-0216-484f-a7e5-b362d51ee780@github.com> Message-ID: <3pZtWLRbFlCcc6eos3Sj_akaX7VLHiAJGenfCxMCsfc=.0801f132-a7eb-4baf-9c78-b72d1d83d67c@github.com> On Wed, 17 Jan 2024 15:22:09 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.22-ga from jdk11u to jdk11u-dev GHA failure: Mac build fails with Compiling os.cpp (for libjvm.dylib) errorerror: C++11 was disabled in PCH file but is currently enabled : C++11 was disabled in PCH file but is currently enabled ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2463#issuecomment-1896657462 From goetz at openjdk.org Wed Jan 17 21:16:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 21:16:57 GMT Subject: [jdk21u-dev] Integrated: 8306922: IR verification fails because IR dump is chopped up In-Reply-To: References: Message-ID: <9mOKTKj3xikSNEBPy6Z7sQ6Kp0iZUTRZCF-6Ds_cxp0=.55b0bc1f-eb43-411c-86f4-1f0429b20eeb@github.com> On Mon, 15 Jan 2024 14:10:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: a51c74db Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/a51c74db293a38de4bef5568db3a90617d43a645 Stats: 173 lines in 8 files changed: 26 ins; 6 del; 141 mod 8306922: IR verification fails because IR dump is chopped up Backport-of: 9057b3503349ead7d995b1a705317324830eabb2 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/167 From goetz at openjdk.org Wed Jan 17 21:18:59 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 21:18:59 GMT Subject: [jdk21u-dev] Integrated: 8310923: Refactor Currency tests to use JUnit In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 12:59:47 GMT, Goetz Lindenmaier wrote: > I backport this to keep the 21u test suite up-to-date. This will simplify future test backports. This pull request has now been integrated. Changeset: ba59249d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/ba59249dc9c5568f5dcca92cd6dcb5f3293f55ee Stats: 1089 lines in 9 files changed: 436 ins; 372 del; 281 mod 8310923: Refactor Currency tests to use JUnit Backport-of: e848d9471f5de86e5ac157b710cd7371f12f0024 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/162 From goetz at openjdk.org Wed Jan 17 21:24:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 21:24:56 GMT Subject: [jdk21u-dev] Integrated: 8315721: CloseRace.java#id0 fails transiently on libgraal In-Reply-To: References: Message-ID: On Mon, 15 Jan 2024 15:09:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 29818585 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/2981858526d707b37ae82df22a434c488fb57a25 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8315721: CloseRace.java#id0 fails transiently on libgraal Backport-of: 1be355734da94243e29f0899b53aa1ebdf3bcb79 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/170 From goetz at openjdk.org Wed Jan 17 21:25:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 21:25:58 GMT Subject: [jdk17u-dev] Integrated: 8323806: [17u] VS2017 build fails with warning after 8293117. In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 13:58:25 GMT, Goetz Lindenmaier wrote: > We need this to fix our build with VS2017. > The warning is disabled limited to this one compiler version. This pull request has now been integrated. Changeset: 381d90b9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/381d90b9b325ba906248904e7539f1f0e09bfd98 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8323806: [17u] VS2017 build fails with warning after 8293117. Reviewed-by: mbaesken, shade ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2133 From goetz at openjdk.org Wed Jan 17 21:26:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 21:26:10 GMT Subject: [jdk17u-dev] Integrated: 8305972: Update XML Security for Java to 3.0.2 In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 14:24:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. > > This is a minimal version that only removes the strings from the interface, as well as the comment. Removing these is explicitly stated in the CSR. > > The change keeps the EdDSA implementation. As I understand, 17 supports EdDSA in general, it was just not included for XML when 17 was released. > https://bugs.openjdk.org/browse/JDK-8305972 This pull request has now been integrated. Changeset: f1331082 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f13310825600518699b4e5ea4c6929357b146eab Stats: 1423 lines in 39 files changed: 1171 ins; 142 del; 110 mod 8305972: Update XML Security for Java to 3.0.2 Reviewed-by: mbaesken Backport-of: f0aebc8141de5a50c88658a40caa01967a9afc53 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2116 From goetz at openjdk.org Wed Jan 17 21:27:02 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 21:27:02 GMT Subject: [jdk17u-dev] Integrated: 8311986: Disable runtime/os/TestTracePageSizes.java for ShenandoahGC In-Reply-To: References: Message-ID: On Mon, 15 Jan 2024 14:48:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: ddd5f219 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ddd5f21949fc08269d7df063a4bfcc11c70e0325 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8311986: Disable runtime/os/TestTracePageSizes.java for ShenandoahGC Backport-of: 167d1c183546a9501a4f255baecc8a4a5b859ab1 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2127 From goetz at openjdk.org Wed Jan 17 21:27:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 21:27:54 GMT Subject: [jdk21u-dev] Integrated: 8311986: Disable runtime/os/TestTracePageSizes.java for ShenandoahGC In-Reply-To: <2UdIibnEOqz_dvzDTzfB1xWdxcGV_n8RoB3EOhrR0YA=.42e56db5-752c-46eb-848b-5a62456e4873@github.com> References: <2UdIibnEOqz_dvzDTzfB1xWdxcGV_n8RoB3EOhrR0YA=.42e56db5-752c-46eb-848b-5a62456e4873@github.com> Message-ID: On Mon, 15 Jan 2024 14:15:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 993a746e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/993a746e7d6fce0793264c17063d39785251122b Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8311986: Disable runtime/os/TestTracePageSizes.java for ShenandoahGC Backport-of: 167d1c183546a9501a4f255baecc8a4a5b859ab1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/168 From goetz at openjdk.org Wed Jan 17 21:28:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 21:28:54 GMT Subject: [jdk17u-dev] Integrated: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing In-Reply-To: References: Message-ID: On Mon, 15 Jan 2024 14:46:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. > > I hat to resolve trivialle, presumably because [8257733: Move module-specific data from make to respective module](https://github.com/openjdk/jdk/commit/f8878cb0cc436993ef1222bc13b00b923d91aad1) is not in 17. This pull request has now been integrated. Changeset: 347ee0f9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/347ee0f91c5186b60471d636bf9f75f4f4777b26 Stats: 20 lines in 2 files changed: 14 ins; 2 del; 4 mod 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing Reviewed-by: mdoerr Backport-of: e3201d1d13433857a1b34ff0ca93f9ae1a4e22aa ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2126 From goetz at openjdk.org Wed Jan 17 21:29:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 21:29:54 GMT Subject: [jdk21u-dev] Integrated: 8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong In-Reply-To: References: Message-ID: On Mon, 15 Jan 2024 15:28:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 0668efa6 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/0668efa6a4afc96d805cfa125a6d73fd0253f0d8 Stats: 82 lines in 1 file changed: 55 ins; 11 del; 16 mod 8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong Backport-of: 4c5b66dceab15ce27f742c4173e14156249eb61a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/171 From goetz at openjdk.org Wed Jan 17 21:33:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 21:33:58 GMT Subject: [jdk17u-dev] Integrated: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 13:28:57 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 769708f8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/769708f8c4070c69dea1c8bb6206e433f5a41580 Stats: 86 lines in 2 files changed: 84 ins; 0 del; 2 mod 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files Backport-of: 8ae309ebacd6947bbad2ef168ca13702e1cba099 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2122 From goetz at openjdk.org Wed Jan 17 21:35:02 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 17 Jan 2024 21:35:02 GMT Subject: [jdk21u-dev] Integrated: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose In-Reply-To: References: Message-ID: On Mon, 15 Jan 2024 15:33:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: e3084fc3 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/e3084fc3604c8ed87adfd2310429134e4f70d262 Stats: 316 lines in 3 files changed: 226 ins; 90 del; 0 mod 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose Backport-of: f0b7eb519ae1cf6f4cb2baea55b5e02a46a8192e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/172 From andrewlu at openjdk.org Thu Jan 18 02:19:15 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 18 Jan 2024 02:19:15 GMT Subject: [jdk21u-dev] RFR: 8169475: WheelModifier.java fails by timeout Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 613d32c2822a443fdcb131a7d67c528410e9f7e6 Changes: https://git.openjdk.org/jdk21u-dev/pull/190/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=190&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8169475 Stats: 60 lines in 1 file changed: 41 ins; 9 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/190.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/190/head:pull/190 PR: https://git.openjdk.org/jdk21u-dev/pull/190 From chegar at openjdk.org Thu Jan 18 03:52:22 2024 From: chegar at openjdk.org (Chris Hegarty) Date: Thu, 18 Jan 2024 03:52:22 GMT Subject: [jdk21u-dev] Integrated: 8323659: LinkedTransferQueue add and put methods call overridable offer In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 11:21:18 GMT, Chris Hegarty wrote: > Hi all, > > This pull request contains a backport of commit [ee4d9aa4](https://github.com/openjdk/jdk/commit/ee4d9aa4c11c47e7cf15f2742919ac20311f9ea7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Chris Hegarty on 16 Jan 2024 and was reviewed by Alan Bateman. > > Thanks! This pull request has now been integrated. Changeset: 309a16e6 Author: Chris Hegarty URL: https://git.openjdk.org/jdk21u-dev/commit/309a16e6093fbcc0d856fcd1009808ddf52f1181 Stats: 75 lines in 2 files changed: 72 ins; 0 del; 3 mod 8323659: LinkedTransferQueue add and put methods call overridable offer Reviewed-by: shade Backport-of: ee4d9aa4c11c47e7cf15f2742919ac20311f9ea7 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/180 From duke at openjdk.org Thu Jan 18 05:54:20 2024 From: duke at openjdk.org (Alexey Pavlyutkin) Date: Thu, 18 Jan 2024 05:54:20 GMT Subject: [jdk17u-dev] RFR: 8296343: CPVE thrown on missing content-length in OCSP response In-Reply-To: References: Message-ID: <0ggDVOhEAVkrW9BY4cNtNrTWwE50YQR8QxkLmKXri2U=.bd22b0a6-e843-4751-9879-0ba0be68f845@github.com> On Thu, 18 May 2023 15:59:18 GMT, Alexey Pavlyutkin wrote: > Hi! > > Here is backport of [JDK-8296343](https://bugs.openjdk.org/browse/JDK-8296343). The patch fixes CertPathValidatorException taking place if OCSP response does not contain `ContentLength` field. > > Original patch is applied cleanly. > > Verification/regression (amd64/20.04 LTS): `jdk_security` including newly added `test/jdk/sun/security/provider/certpath/OCSP/OCSPNoContentLength.java` I will take a look. Thank you ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1361#issuecomment-1897845851 From goetz at openjdk.org Thu Jan 18 07:12:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 07:12:21 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: <0YESh5ctwpK3XdNSE4jTETFU3KwGxLkSgKr8lbEcbUU=.6dd8ad29-0216-484f-a7e5-b362d51ee780@github.com> References: <0YESh5ctwpK3XdNSE4jTETFU3KwGxLkSgKr8lbEcbUU=.6dd8ad29-0216-484f-a7e5-b362d51ee780@github.com> Message-ID: <21nPPz6uqwVZxW0VUO8gNbO0RAe07xf7pfCNPrEbZuo=.8728dc24-104c-43e2-b01f-74432543af4e@github.com> On Wed, 17 Jan 2024 15:22:09 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.22-ga from jdk11u to jdk11u-dev This pull request has now been integrated. Changeset: 0f1f6565 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/0f1f65652ca0bf743417df04be155693e350f1d9 Stats: 609 lines in 15 files changed: 394 ins; 56 del; 159 mod Merge ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2463 From goetz at openjdk.org Thu Jan 18 07:28:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 07:28:16 GMT Subject: [jdk21u-dev] RFR: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 12:29:32 GMT, Matthias Baesken wrote: > Backport 8322098 Yes, please add issue 8323331. It makes sense to combine them, but we need to annotate this. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/181#issuecomment-1897938322 From goetz at openjdk.org Thu Jan 18 07:30:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 07:30:23 GMT Subject: [jdk21u-dev] RFR: 8322279: Generational ZGC: Use ZFragmentationLimit and ZYoungCompactionLimit as percentage instead of multiples In-Reply-To: <-l0U_b-rR8Q1YkafdBqS0rdMKt5cFwkyn0o_4AceWwk=.17a38e29-2d5a-4a65-87dd-c54efe1ea463@github.com> References: <-l0U_b-rR8Q1YkafdBqS0rdMKt5cFwkyn0o_4AceWwk=.17a38e29-2d5a-4a65-87dd-c54efe1ea463@github.com> Message-ID: On Tue, 16 Jan 2024 03:40:14 GMT, Liang Mao wrote: > This commit fixed incorrect use of production options of generational ZGC. Since JDK21 is the only LST version with generational ZGC? we need to fix the potential bugs. > Additional testing on fastdebug against test/hotspot/jtreg/gc/z The risk estimate should go into the fix request comment. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/173#issuecomment-1897940316 From goetz at openjdk.org Thu Jan 18 07:36:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 07:36:23 GMT Subject: [jdk11u-dev] RFR: 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows In-Reply-To: <_Jjn9WIIQt8Jmuv_ugzxUcT1rFiXtd9yDM2OyKj84hs=.5c8bdd6f-ef1b-426c-b93d-3a9f1aa22111@github.com> References: <_Jjn9WIIQt8Jmuv_ugzxUcT1rFiXtd9yDM2OyKj84hs=.5c8bdd6f-ef1b-426c-b93d-3a9f1aa22111@github.com> Message-ID: On Sun, 14 Jan 2024 23:33:47 GMT, Kimura Yukihiro wrote: > I would like to fix this issue because the test dose not work as intended. > 8318410 resolved two issues. However, the first issue related to JEP400 is not relevant to JDK11. > Therefore, I would like to backport only the second issue, > which is the problem of tests not running properly on Windows cygwin. > Backporting to JDK11 is the same as backporting to JDK17 which has already done. > > Could someone please review it? > > Thanks, > Kimura Yukihiro HI, you are missing a review. Don't label before you have a review. If it's identical to the 17u backport, base it on that commit and it is clean, and you need no review. Retroactively you can fix this by editing the title of this PR to be "Backport ". The bots will first issue an error that they did not find the hash, but after a while (>2h) they will manage. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2456#issuecomment-1897946227 From andrewlu at openjdk.org Thu Jan 18 07:55:23 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 18 Jan 2024 07:55:23 GMT Subject: [jdk11u-dev] Integrated: 8315594: Open source few headless Swing misc tests In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 08:29:18 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: 0e8244bd Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/0e8244bd423d305f86e2e456ccad7ad2a628b48a Stats: 256 lines in 4 files changed: 256 ins; 0 del; 0 mod 8315594: Open source few headless Swing misc tests Backport-of: 806ef0897b42c8f3cb3b4d7bd904af9ed18a543e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2460 From mbaesken at openjdk.org Thu Jan 18 08:06:21 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 18 Jan 2024 08:06:21 GMT Subject: [jdk11u-dev] Integrated: 8318955: Add ReleaseIntArrayElements in Java_sun_awt_X11_XlibWrapper_SetBitmapShape XlbWrapper.c to early return In-Reply-To: <8ZjUbvRHFkQr30C_aghRISr12CE5JBrENe64yTuSgRY=.54ec02cd-1956-446d-a3d1-a29f43504fd2@github.com> References: <8ZjUbvRHFkQr30C_aghRISr12CE5JBrENe64yTuSgRY=.54ec02cd-1956-446d-a3d1-a29f43504fd2@github.com> Message-ID: <6Z40l202sjZl2uEk4i3TXMXrWVzoExsqU2zYNQOVMZw=.081a471c-efe0-40be-9767-51101a66b808@github.com> On Wed, 17 Jan 2024 12:50:41 GMT, Matthias Baesken wrote: > 8318955: Add ReleaseIntArrayElements in Java_sun_awt_X11_XlibWrapper_SetBitmapShape XlbWrapper.c to early return This pull request has now been integrated. Changeset: 51d944e5 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/51d944e570ee23b8a9b2af8bb4c91becf7bde5e3 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8318955: Add ReleaseIntArrayElements in Java_sun_awt_X11_XlibWrapper_SetBitmapShape XlbWrapper.c to early return Backport-of: 81db1721d4fac954003441ca2c3c29b0998d310d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2462 From eosterlund at openjdk.org Thu Jan 18 08:06:23 2024 From: eosterlund at openjdk.org (Erik =?UTF-8?B?w5ZzdGVybHVuZA==?=) Date: Thu, 18 Jan 2024 08:06:23 GMT Subject: [jdk21u-dev] RFR: 8322279: Generational ZGC: Use ZFragmentationLimit and ZYoungCompactionLimit as percentage instead of multiples In-Reply-To: <-l0U_b-rR8Q1YkafdBqS0rdMKt5cFwkyn0o_4AceWwk=.17a38e29-2d5a-4a65-87dd-c54efe1ea463@github.com> References: <-l0U_b-rR8Q1YkafdBqS0rdMKt5cFwkyn0o_4AceWwk=.17a38e29-2d5a-4a65-87dd-c54efe1ea463@github.com> Message-ID: On Tue, 16 Jan 2024 03:40:14 GMT, Liang Mao wrote: > This commit fixed incorrect use of production options of generational ZGC. Since JDK21 is the only LST version with generational ZGC? we need to fix the potential bugs. > Additional testing on fastdebug against test/hotspot/jtreg/gc/z Looks good. ------------- Marked as reviewed by eosterlund (Committer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/173#pullrequestreview-1829075810 From mbaesken at openjdk.org Thu Jan 18 08:08:26 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 18 Jan 2024 08:08:26 GMT Subject: [jdk17u-dev] Integrated: 8320300: Adjust hs_err output in malloc/mmap error cases In-Reply-To: References: Message-ID: <73uMQ2cw6bPgmwLGDYFJa62WafSOFZ7AicUf-hl06hU=.be7874bf-71c7-4af1-9b08-f6cfa759f79b@github.com> On Fri, 12 Jan 2024 13:53:48 GMT, Matthias Baesken wrote: > Backport 8320300 This pull request has now been integrated. Changeset: 6513d234 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/6513d234ae54723b1c58a92c5b89ce52f2af019e Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8320300: Adjust hs_err output in malloc/mmap error cases Reviewed-by: lucy Backport-of: 60c8d9c045be16fee99a83117844c2a8100f7c1a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2123 From mbaesken at openjdk.org Thu Jan 18 08:11:21 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 18 Jan 2024 08:11:21 GMT Subject: [jdk17u-dev] Withdrawn: 8318961: increase javacserver connection timeout values and max retry attempts In-Reply-To: <7ibamafh-ohnn69XTaAKoxSjiHH-mUNOY5LRHawlkSY=.016ee60b-6aff-46d5-979f-8df40c039649@github.com> References: <7ibamafh-ohnn69XTaAKoxSjiHH-mUNOY5LRHawlkSY=.016ee60b-6aff-46d5-979f-8df40c039649@github.com> Message-ID: On Wed, 20 Dec 2023 11:41:49 GMT, Matthias Baesken wrote: > Backport of 8318961 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2066 From mbaesken at openjdk.org Thu Jan 18 08:39:19 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 18 Jan 2024 08:39:19 GMT Subject: [jdk21u-dev] Integrated: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 12:29:32 GMT, Matthias Baesken wrote: > Backport 8322098 This pull request has now been integrated. Changeset: 419e0168 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/419e01685b36aeccc47f52594a2026ccb2dcebb3 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size 8323331: fix typo hpage_pdm_size Reviewed-by: lucy Backport-of: b31454e36234091c3827c3b4d07f62345cb0cee4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/181 From kyukihiro at openjdk.org Thu Jan 18 08:44:17 2024 From: kyukihiro at openjdk.org (Kimura Yukihiro) Date: Thu, 18 Jan 2024 08:44:17 GMT Subject: [jdk11u-dev] RFR: 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows In-Reply-To: <_Jjn9WIIQt8Jmuv_ugzxUcT1rFiXtd9yDM2OyKj84hs=.5c8bdd6f-ef1b-426c-b93d-3a9f1aa22111@github.com> References: <_Jjn9WIIQt8Jmuv_ugzxUcT1rFiXtd9yDM2OyKj84hs=.5c8bdd6f-ef1b-426c-b93d-3a9f1aa22111@github.com> Message-ID: On Sun, 14 Jan 2024 23:33:47 GMT, Kimura Yukihiro wrote: > I would like to fix this issue because the test dose not work as intended. > 8318410 resolved two issues. However, the first issue related to JEP400 is not relevant to JDK11. > Therefore, I would like to backport only the second issue, > which is the problem of tests not running properly on Windows cygwin. > Backporting to JDK11 is the same as backporting to JDK17 which has already done. > > Could someone please review it? > > Thanks, > Kimura Yukihiro Hello Goetz, Thank you for your advice. I deleted the Fix Request 11u label, and changed the tittle of this PR. Thanks, Kimura Yukihiro ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2456#issuecomment-1898032123 From goetz at openjdk.org Thu Jan 18 09:06:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 09:06:25 GMT Subject: [jdk21u-dev] RFR: 8323008: filter out harmful -std* flags added by autoconf from CXX Message-ID: GHA actions are failing because of this issue. Resolved Copyright, will mark clean if not recognized as such anyways. ------------- Commit messages: - Backport 68c4286026bc2c0ec0f594e0b96fe03fe5624d6d Changes: https://git.openjdk.org/jdk21u-dev/pull/191/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=191&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323008 Stats: 8 lines in 2 files changed: 4 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/191.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/191/head:pull/191 PR: https://git.openjdk.org/jdk21u-dev/pull/191 From goetz at openjdk.org Thu Jan 18 09:14:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 09:14:28 GMT Subject: [jdk17u-dev] RFR: 8323008: filter out harmful -std* flags added by autoconf from CXX Message-ID: GHA actions are failing because of this issue. Resolved two Copyrights, will mark clean if not recognized as such anyways. ------------- Commit messages: - Backport 68c4286026bc2c0ec0f594e0b96fe03fe5624d6d Changes: https://git.openjdk.org/jdk17u-dev/pull/2137/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2137&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323008 Stats: 8 lines in 2 files changed: 4 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2137.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2137/head:pull/2137 PR: https://git.openjdk.org/jdk17u-dev/pull/2137 From goetz at openjdk.org Thu Jan 18 09:16:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 09:16:29 GMT Subject: [jdk11u-dev] RFR: 8323008: filter out harmful -std* flags added by autoconf from CXX Message-ID: GHA actions are failing because of this issue. Resolved two Copyrights. Can not be based on the 17u backport because the old year in utils.m7 differes. Will mark clean if not recognized as such anyways. ------------- Commit messages: - Backport 68c4286026bc2c0ec0f594e0b96fe03fe5624d6d Changes: https://git.openjdk.org/jdk11u-dev/pull/2464/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2464&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323008 Stats: 8 lines in 2 files changed: 4 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2464.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2464/head:pull/2464 PR: https://git.openjdk.org/jdk11u-dev/pull/2464 From goetz at openjdk.org Thu Jan 18 09:44:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 09:44:29 GMT Subject: [jdk11u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v3] In-Reply-To: References: Message-ID: > This backport is based on https://github.com/openjdk/jdk17u-dev/pull/2116 , the minimal version. > It contains the full EdDSA functionality and only removes the Strings that are explicitly not documented for backport in the CSRs. > > I needed the following adaptions you find in seperate commits: > > **Resolves**: > > The implementation in the jdk patched clean. > There were some conflicts in the tests: > > test/jdk/TEST.groups > trivial resolve due to context. > > test/jdk/javax/xml/crypto/dsig/GenerationTests.java > trivial resolve due to context. 8241306 is missing in the context. > > test/jdk/javax/xml/crypto/dsig/SecureValidation.java > This file is not in 11. > It came with "8241306: Add SignatureMethodParameterSpec subclass > for RSASSA-PSS params" which was not backported. Changes omitted. > > test/lib/jdk/test/lib/security/XMLUtils.java > One chunk does not apply because the removed code differs. > In 17, a switch statement is used that was adapted to Java 11. > Moved the comment and exception thrown in 11 to the new place. > > > **Make it compile and make the tests work**: > > The changes to the libraries compile out of the box. > > The tests needed several adaptions. I did not remove the > bad code yet, but just commented it out to highlight the > differences better for now. > > test/jdk/javax/xml/crypto/dsig/Basic.java > I had to remove test cases because > 8241305: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params > 8166597: Crypto support for the EdDSA Signature Algorithm > are not in 11. > > test/jdk/javax/xml/crypto/dsig/GenerationTests.java > To make it compile, I > replaced HexFormat.of().parseHex() by jdk.test.lib.Utils.toByteArray(). > Further, I commented a row of test coding that does not compile. > "8166597: Crypto support for the EdDSA Signature Algorithm" would > be needed to get these test cases working. > This effectively removes the test cases for the new functionality. > > test/jdk/javax/xml/crypto/dsig/HereFunction.java > A simple tweak to enable testing of sha1 is not needed in 11. > In 11, sha1 is still available per default as > "8259709: Disable SHA-1 XML Signatures" was not backported. > > test/lib/jdk/test/lib/security/XMLUtils.java > More complex resolve because a previous backport was already adapted to 11. > The code in 17 uses incompatible switch and instanceof > in several places. > It also needed adaptions because it does not compile as > 8166597: Crypto support for the EdDSA Signature Algorithm > is not in 11. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Fix whitespace issue ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2455/files - new: https://git.openjdk.org/jdk11u-dev/pull/2455/files/68c77490..0a26d374 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2455&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2455&range=01-02 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2455.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2455/head:pull/2455 PR: https://git.openjdk.org/jdk11u-dev/pull/2455 From goetz at openjdk.org Thu Jan 18 11:20:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 11:20:21 GMT Subject: [jdk17u-dev] RFR: 8319124: Update XML Security for Java to 3.0.3 Message-ID: I backport this for parity with 17.0.11-oracle. I used the 21u commit as base. This makes the backport almost clean, and alredy reflects the adaptions needed because of the backport CSR. The following trivial resolves were made: src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRSAPSSSignatureMethod.java Cannot remove line with logging code because this was already removed by "8316976: Improve signature handling" src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Utils.java Resolved imports due to context. ------------- Commit messages: - Backport 45df078510ad6b8fb336e4180622ca3792bbe0cc Changes: https://git.openjdk.org/jdk17u-dev/pull/2139/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2139&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319124 Stats: 1529 lines in 130 files changed: 1114 ins; 229 del; 186 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2139.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2139/head:pull/2139 PR: https://git.openjdk.org/jdk17u-dev/pull/2139 From duke at openjdk.org Thu Jan 18 11:27:21 2024 From: duke at openjdk.org (sendaoYan) Date: Thu, 18 Jan 2024 11:27:21 GMT Subject: [jdk17u-dev] RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 Message-ID: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 ------------- Commit messages: - 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 Changes: https://git.openjdk.org/jdk17u-dev/pull/2138/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2138&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316563 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2138.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2138/head:pull/2138 PR: https://git.openjdk.org/jdk17u-dev/pull/2138 From duke at openjdk.org Thu Jan 18 12:06:18 2024 From: duke at openjdk.org (sendaoYan) Date: Thu, 18 Jan 2024 12:06:18 GMT Subject: [jdk17u-dev] RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 11:12:51 GMT, sendaoYan wrote: > 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/e8f7df8b-da83-4bf8-9302-154fcc84ed82) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2138#issuecomment-1898350595 From duke at openjdk.org Thu Jan 18 12:22:26 2024 From: duke at openjdk.org (sendaoYan) Date: Thu, 18 Jan 2024 12:22:26 GMT Subject: [jdk21u-dev] RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 Message-ID: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 ------------- Commit messages: - Backport 52814994efc4831fdbc1f796ed1db6ae88cb616c Changes: https://git.openjdk.org/jdk21u-dev/pull/192/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=192&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316563 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/192.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/192/head:pull/192 PR: https://git.openjdk.org/jdk21u-dev/pull/192 From duke at openjdk.org Thu Jan 18 12:28:19 2024 From: duke at openjdk.org (sendaoYan) Date: Thu, 18 Jan 2024 12:28:19 GMT Subject: [jdk21u-dev] RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 In-Reply-To: References: Message-ID: <9TT_3ROykHwjerH971YD6AjZ43z2WU82tT-g4OU2fiA=.b7c46b56-3e0b-4838-933a-e6471c29dbc6@github.com> On Thu, 18 Jan 2024 12:16:59 GMT, sendaoYan wrote: > 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/49720a68-1e0d-4135-911c-144ae04eb576) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/192#issuecomment-1898385436 From mbaesken at openjdk.org Thu Jan 18 13:11:21 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 18 Jan 2024 13:11:21 GMT Subject: [jdk11u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v3] In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 09:44:29 GMT, Goetz Lindenmaier wrote: >> This backport is based on https://github.com/openjdk/jdk17u-dev/pull/2116 , the minimal version. >> It contains the full EdDSA functionality and only removes the Strings that are explicitly not documented for backport in the CSRs. >> >> I needed the following adaptions you find in seperate commits: >> >> **Resolves**: >> >> The implementation in the jdk patched clean. >> There were some conflicts in the tests: >> >> test/jdk/TEST.groups >> trivial resolve due to context. >> >> test/jdk/javax/xml/crypto/dsig/GenerationTests.java >> trivial resolve due to context. 8241306 is missing in the context. >> >> test/jdk/javax/xml/crypto/dsig/SecureValidation.java >> This file is not in 11. >> It came with "8241306: Add SignatureMethodParameterSpec subclass >> for RSASSA-PSS params" which was not backported. Changes omitted. >> >> test/lib/jdk/test/lib/security/XMLUtils.java >> One chunk does not apply because the removed code differs. >> In 17, a switch statement is used that was adapted to Java 11. >> Moved the comment and exception thrown in 11 to the new place. >> >> >> **Make it compile and make the tests work**: >> >> The changes to the libraries compile out of the box. >> >> The tests needed several adaptions. I did not remove the >> bad code yet, but just commented it out to highlight the >> differences better for now. >> >> test/jdk/javax/xml/crypto/dsig/Basic.java >> I had to remove test cases because >> 8241305: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params >> 8166597: Crypto support for the EdDSA Signature Algorithm >> are not in 11. >> >> test/jdk/javax/xml/crypto/dsig/GenerationTests.java >> To make it compile, I >> replaced HexFormat.of().parseHex() by jdk.test.lib.Utils.toByteArray(). >> Further, I commented a row of test coding that does not compile. >> "8166597: Crypto support for the EdDSA Signature Algorithm" would >> be needed to get these test cases working. >> This effectively removes the test cases for the new functionality. >> >> test/jdk/javax/xml/crypto/dsig/HereFunction.java >> A simple tweak to enable testing of sha1 is not needed in 11. >> In 11, sha1 is still available per default as >> "8259709: Disable SHA-1 XML Signatures" was not backported. >> >> test/lib/jdk/test/lib/security/XMLUtils.java >> More complex resolve because a previous backport was already adapted to 11. >> The code in 17 uses incompatible switch and instanceof >> in several places. >> It also needed adaptions because it does not comp... > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Fix whitespace issue Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2455#pullrequestreview-1829641216 From jbechberger at openjdk.org Thu Jan 18 13:45:30 2024 From: jbechberger at openjdk.org (Johannes Bechberger) Date: Thu, 18 Jan 2024 13:45:30 GMT Subject: [jdk21u-dev] RFR: 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma Message-ID: Hi all, This pull request contains a backport of commit [ffa33d7b](https://github.com/openjdk/jdk/commit/ffa33d7b807bfef6ff05c9adba869dddf813cf68) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Artem Semenov on 17 Jan 2024 and was reviewed by Alexander Zuev. Thanks! ------------- Commit messages: - Backport ffa33d7b807bfef6ff05c9adba869dddf813cf68 Changes: https://git.openjdk.org/jdk21u-dev/pull/193/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=193&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317771 Stats: 65 lines in 1 file changed: 64 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/193.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/193/head:pull/193 PR: https://git.openjdk.org/jdk21u-dev/pull/193 From jbechberger at openjdk.org Thu Jan 18 13:48:27 2024 From: jbechberger at openjdk.org (Johannes Bechberger) Date: Thu, 18 Jan 2024 13:48:27 GMT Subject: [jdk17u-dev] RFR: 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma Message-ID: Hi all, This pull request contains a backport of commit [ffa33d7b](https://github.com/openjdk/jdk/commit/ffa33d7b807bfef6ff05c9adba869dddf813cf68) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Artem Semenov on 17 Jan 2024 and was reviewed by Alexander Zuev. Thanks! ------------- Commit messages: - Backport ffa33d7b807bfef6ff05c9adba869dddf813cf68 Changes: https://git.openjdk.org/jdk17u-dev/pull/2140/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2140&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317771 Stats: 65 lines in 1 file changed: 64 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2140.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2140/head:pull/2140 PR: https://git.openjdk.org/jdk17u-dev/pull/2140 From goetz at openjdk.org Thu Jan 18 14:22:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 14:22:21 GMT Subject: [jdk21u-dev] Integrated: 8311663: Additional refactoring of Locale tests to JUnit In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 13:28:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 7eea17b8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/7eea17b847429edfb9b859322145d4a9689e0d75 Stats: 549 lines in 10 files changed: 159 ins; 217 del; 173 mod 8311663: Additional refactoring of Locale tests to JUnit Backport-of: 71cac8ce47b69a2b78d54cbceb0f0510e5ea4cdc ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/183 From goetz at openjdk.org Thu Jan 18 14:24:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 14:24:22 GMT Subject: [jdk21u-dev] Integrated: 8315241: (fs) Move toRealPath tests in java/nio/file/Path/Misc.java to separate JUnit 5 test In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 13:35:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: c79c5efa Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/c79c5efa4de89457a5b5ef5e88bc63c320558aef Stats: 334 lines in 2 files changed: 191 ins; 141 del; 2 mod 8315241: (fs) Move toRealPath tests in java/nio/file/Path/Misc.java to separate JUnit 5 test Backport-of: dd64a4a483a831fd66912491af10502c4cf8596b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/184 From goetz at openjdk.org Thu Jan 18 14:24:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 14:24:23 GMT Subject: [jdk21u-dev] Integrated: 8312136: Modify runtime/ErrorHandling/TestDwarf.java to split dwarf and decoder testing In-Reply-To: <-8u86DeMW6iKrMnEyMvM0DcUCdLBI9e1dpPG4iDThWk=.a479e3ed-c4b9-4c9c-bb0b-6f6c38cde6bb@github.com> References: <-8u86DeMW6iKrMnEyMvM0DcUCdLBI9e1dpPG4iDThWk=.a479e3ed-c4b9-4c9c-bb0b-6f6c38cde6bb@github.com> Message-ID: On Wed, 17 Jan 2024 13:49:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 8413dc00 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/8413dc002067fedd81d98939b5a036c655e0d376 Stats: 37 lines in 2 files changed: 30 ins; 0 del; 7 mod 8312136: Modify runtime/ErrorHandling/TestDwarf.java to split dwarf and decoder testing Backport-of: e2e8e8e210ea9a7a9d901a1da729551714015d04 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/185 From goetz at openjdk.org Thu Jan 18 14:26:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 14:26:16 GMT Subject: [jdk21u-dev] Integrated: 8318590: JButton ignores margin when painting HTML text In-Reply-To: References: Message-ID: <8IozEPW40T6dDckhEJbzZP6TArsngntJ1Ar2nZAHuBs=.e6de61dc-658b-454d-b3d6-baae3368962e@github.com> On Wed, 17 Jan 2024 13:02:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 0d30c8d4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/0d30c8d497a15a28f6fcae2ae8f6bdcba878d260 Stats: 193 lines in 4 files changed: 8 ins; 177 del; 8 mod 8318590: JButton ignores margin when painting HTML text Backport-of: acaf2c8dcfd5235f758af2fe3e308b72263113e4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/182 From goetz at openjdk.org Thu Jan 18 14:28:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 14:28:23 GMT Subject: [jdk11u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v3] In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 09:44:29 GMT, Goetz Lindenmaier wrote: >> This backport is based on https://github.com/openjdk/jdk17u-dev/pull/2116 , the minimal version. >> It contains the full EdDSA functionality and only removes the Strings that are explicitly not documented for backport in the CSRs. >> >> I needed the following adaptions you find in seperate commits: >> >> **Resolves**: >> >> The implementation in the jdk patched clean. >> There were some conflicts in the tests: >> >> test/jdk/TEST.groups >> trivial resolve due to context. >> >> test/jdk/javax/xml/crypto/dsig/GenerationTests.java >> trivial resolve due to context. 8241306 is missing in the context. >> >> test/jdk/javax/xml/crypto/dsig/SecureValidation.java >> This file is not in 11. >> It came with "8241306: Add SignatureMethodParameterSpec subclass >> for RSASSA-PSS params" which was not backported. Changes omitted. >> >> test/lib/jdk/test/lib/security/XMLUtils.java >> One chunk does not apply because the removed code differs. >> In 17, a switch statement is used that was adapted to Java 11. >> Moved the comment and exception thrown in 11 to the new place. >> >> >> **Make it compile and make the tests work**: >> >> The changes to the libraries compile out of the box. >> >> The tests needed several adaptions. I did not remove the >> bad code yet, but just commented it out to highlight the >> differences better for now. >> >> test/jdk/javax/xml/crypto/dsig/Basic.java >> I had to remove test cases because >> 8241305: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params >> 8166597: Crypto support for the EdDSA Signature Algorithm >> are not in 11. >> >> test/jdk/javax/xml/crypto/dsig/GenerationTests.java >> To make it compile, I >> replaced HexFormat.of().parseHex() by jdk.test.lib.Utils.toByteArray(). >> Further, I commented a row of test coding that does not compile. >> "8166597: Crypto support for the EdDSA Signature Algorithm" would >> be needed to get these test cases working. >> This effectively removes the test cases for the new functionality. >> >> test/jdk/javax/xml/crypto/dsig/HereFunction.java >> A simple tweak to enable testing of sha1 is not needed in 11. >> In 11, sha1 is still available per default as >> "8259709: Disable SHA-1 XML Signatures" was not backported. >> >> test/lib/jdk/test/lib/security/XMLUtils.java >> More complex resolve because a previous backport was already adapted to 11. >> The code in 17 uses incompatible switch and instanceof >> in several places. >> It also needed adaptions because it does not comp... > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Fix whitespace issue GHA failure: infra issue: rror: C++11 was disabled in PCH file but is currently enabled Adressed by backport JDK-8323008. Passed before pushing change adding empty line ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2455#issuecomment-1898579406 From asemenov at openjdk.org Thu Jan 18 14:52:20 2024 From: asemenov at openjdk.org (Artem Semenov) Date: Thu, 18 Jan 2024 14:52:20 GMT Subject: [jdk17u-dev] RFR: 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 13:43:19 GMT, Johannes Bechberger wrote: > Hi all, > > This pull request contains a backport of commit [ffa33d7b](https://github.com/openjdk/jdk/commit/ffa33d7b807bfef6ff05c9adba869dddf813cf68) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Artem Semenov on 17 Jan 2024 and was reviewed by Alexander Zuev. > > Thanks! LGTM ------------- Marked as reviewed by asemenov (Committer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2140#pullrequestreview-1829862381 From asemenov at openjdk.org Thu Jan 18 14:56:15 2024 From: asemenov at openjdk.org (Artem Semenov) Date: Thu, 18 Jan 2024 14:56:15 GMT Subject: [jdk21u-dev] RFR: 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 13:39:30 GMT, Johannes Bechberger wrote: > Hi all, > > This pull request contains a backport of commit [ffa33d7b](https://github.com/openjdk/jdk/commit/ffa33d7b807bfef6ff05c9adba869dddf813cf68) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Artem Semenov on 17 Jan 2024 and was reviewed by Alexander Zuev. > > Thanks! ???? ------------- Marked as reviewed by asemenov (Committer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/193#pullrequestreview-1829872802 From rrich at openjdk.org Thu Jan 18 14:57:24 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 18 Jan 2024 14:57:24 GMT Subject: [jdk21u-dev] Integrated: 8310031: Parallel: Implement better work distribution for large object arrays in old gen In-Reply-To: <67UuihGoUUiBrOdU3AJBFDyynhlo8b12p_dE46-fUsg=.06e45d5d-1895-45c0-89a8-027a2e72d5b8@github.com> References: <67UuihGoUUiBrOdU3AJBFDyynhlo8b12p_dE46-fUsg=.06e45d5d-1895-45c0-89a8-027a2e72d5b8@github.com> Message-ID: <7a8eVJLrKlhV2qwBg7MOmX0--jMGWGH2aDlc7g5waws=.fb5e540c-b4b4-4b51-a1d4-a38b092f85a3@github.com> On Fri, 12 Jan 2024 09:19:27 GMT, Richard Reingruber wrote: > Hi all, > > This pull request contains a backport of commit 4bfe2268 from the openjdk/jdk repository. > > The commit being backported was authored by Richard Reingruber on 24 Oct 2023 and was reviewed by Thomas Schatzl and Albert Mingkun Yang. > > The fix passed our CI testing: most JCK and JTREG (tiers 1-4) tests, also in Xcomp mode, Renaissance benchmark and SAP specific tests with fastdebug and release builds on the standard platforms plus PPC64. > > Thanks, Richard. This pull request has now been integrated. Changeset: c8f04185 Author: Richard Reingruber URL: https://git.openjdk.org/jdk21u-dev/commit/c8f04185f185d01c94dbf104899b5de13630ad6f Stats: 334 lines in 5 files changed: 177 ins; 70 del; 87 mod 8310031: Parallel: Implement better work distribution for large object arrays in old gen Backport-of: 4bfe226870a15306b1e015c38fe3835f26b41fe6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/160 From goetz at openjdk.org Thu Jan 18 15:15:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 15:15:17 GMT Subject: [jdk17u-dev] Integrated: 8323008: filter out harmful -std* flags added by autoconf from CXX In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 09:04:17 GMT, Goetz Lindenmaier wrote: > GHA actions are failing because of this issue. > > Resolved two Copyrights, will mark clean if not recognized as such anyways. This pull request has now been integrated. Changeset: a632e300 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/a632e300a9aa5fc5ec51e0057c2739784811df5d Stats: 8 lines in 2 files changed: 4 ins; 0 del; 4 mod 8323008: filter out harmful -std* flags added by autoconf from CXX Backport-of: 68c4286026bc2c0ec0f594e0b96fe03fe5624d6d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2137 From goetz at openjdk.org Thu Jan 18 15:15:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 15:15:21 GMT Subject: [jdk11u-dev] Integrated: 8323008: filter out harmful -std* flags added by autoconf from CXX In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 09:10:17 GMT, Goetz Lindenmaier wrote: > GHA actions are failing because of this issue. > > Resolved two Copyrights. Can not be based on the 17u backport because the old year in utils.m7 differes. Will mark clean if not recognized as such anyways. This pull request has now been integrated. Changeset: dc028f28 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/dc028f28d1ec5a4efd89af1b5f83fa4dc349defc Stats: 8 lines in 2 files changed: 4 ins; 0 del; 4 mod 8323008: filter out harmful -std* flags added by autoconf from CXX Backport-of: 68c4286026bc2c0ec0f594e0b96fe03fe5624d6d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2464 From omikhaltcova at openjdk.org Thu Jan 18 16:02:37 2024 From: omikhaltcova at openjdk.org (Olga Mikhaltsova) Date: Thu, 18 Jan 2024 16:02:37 GMT Subject: [jdk22u] Integrated: 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 23:02:01 GMT, Olga Mikhaltsova wrote: > Hi! I would like to backport [JDK-8321972](https://bugs.openjdk.org/browse/JDK-8321972) to jdk22u. > This patch fixes failure of runtime/Unsafe/InternalErrorTest.java after [JDK-8320886](https://bugs.openjdk.org/browse/JDK-8320886) for RISC-V platform, that was backported to jdk22 by [JDK-8321919](https://bugs.openjdk.org/browse/JDK-8321919). > The original patch applies cleanly. It's related only to RISC-V. No risks for other platforms. > I reproduced this issue on StarFive VisionFive2 board. After appling this patch runtime/Unsafe/InternalErrorTest.java passes. > tier1 tests passed for RISC-V platform. This pull request has now been integrated. Changeset: e27e5998 Author: Olga Mikhaltsova URL: https://git.openjdk.org/jdk22u/commit/e27e5998b3870dfa0e6f2aa9caaec7e1ebfd6eb3 Stats: 13 lines in 2 files changed: 11 ins; 0 del; 2 mod 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform Backport-of: e8768ae08dbee9c3e1ed01934142c03ffad5f349 ------------- PR: https://git.openjdk.org/jdk22u/pull/24 From omikhaltcova at openjdk.org Thu Jan 18 16:02:40 2024 From: omikhaltcova at openjdk.org (Olga Mikhaltsova) Date: Thu, 18 Jan 2024 16:02:40 GMT Subject: [jdk22u] Integrated: 8318158: RISC-V: implement roundD/roundF intrinsics In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 12:54:02 GMT, Olga Mikhaltsova wrote: > I would like to backport [JDK-8318158](https://bugs.openjdk.org/browse/JDK-8318158) to jdk22u in order to optimize performance in double/float rounding operations by means of intrinsics. > The patch applied cleanly. > Tested: no regression in tier1 tests. > > The benchmark shows the following performance improvement on the T-Head RVB-ICE board: > **Before** > > Benchmark (TESTSIZE) Mode Cnt Score Error Units > FpRoundingBenchmark.test_round_double 2048 thrpt 15 59.722 0.259 ops/ms > FpRoundingBenchmark.test_round_float 2048 thrpt 15 49.729 0.127 ops/ms > > **After** > > Benchmark (TESTSIZE) Mode Cnt Score Error Units > FpRoundingBenchmark.test_round_double 2048 thrpt 15 118.496 0.277 ops/ms > FpRoundingBenchmark.test_round_float 2048 thrpt 15 121.008 0.488 ops/ms This pull request has now been integrated. Changeset: 8ff288f9 Author: Olga Mikhaltsova URL: https://git.openjdk.org/jdk22u/commit/8ff288f986eb661607b265d012c7ece805c3cdea Stats: 82 lines in 3 files changed: 82 ins; 0 del; 0 mod 8318158: RISC-V: implement roundD/roundF intrinsics Backport-of: 19147f326c6b0e78fe72f9a7e7100047f16a0921 ------------- PR: https://git.openjdk.org/jdk22u/pull/21 From goetz at openjdk.org Thu Jan 18 16:06:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 18 Jan 2024 16:06:23 GMT Subject: [jdk21u-dev] Integrated: 8323008: filter out harmful -std* flags added by autoconf from CXX In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 09:00:15 GMT, Goetz Lindenmaier wrote: > GHA actions are failing because of this issue. > > Resolved Copyright, will mark clean if not recognized as such anyways. This pull request has now been integrated. Changeset: 64439376 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/644393769f453f9d2fad7f50b3ca44cd9ff72408 Stats: 8 lines in 2 files changed: 4 ins; 0 del; 4 mod 8323008: filter out harmful -std* flags added by autoconf from CXX Backport-of: 68c4286026bc2c0ec0f594e0b96fe03fe5624d6d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/191 From wkemper at openjdk.org Thu Jan 18 17:02:21 2024 From: wkemper at openjdk.org (William Kemper) Date: Thu, 18 Jan 2024 17:02:21 GMT Subject: [jdk21u-dev] RFR: 8317535: Shenandoah: Remove unused code Message-ID: Removes unused and/or unreachable code. ------------- Commit messages: - Backport e942f368c370e059c654e33408940a987013a5c7 Changes: https://git.openjdk.org/jdk21u-dev/pull/194/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=194&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317535 Stats: 185 lines in 20 files changed: 0 ins; 179 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/194.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/194/head:pull/194 PR: https://git.openjdk.org/jdk21u-dev/pull/194 From duke at openjdk.org Thu Jan 18 20:22:34 2024 From: duke at openjdk.org (Elif Aslan) Date: Thu, 18 Jan 2024 20:22:34 GMT Subject: [jdk17u-dev] RFR: 8296812: sprintf is deprecated in Xcode 14 [v2] In-Reply-To: <7XLC13Ldl8cqJVuWXdUwLON6ExwW3MKry9fWgia0QXg=.6cc0be3c-cd35-4ac2-9263-4344f4c08737@github.com> References: <7XLC13Ldl8cqJVuWXdUwLON6ExwW3MKry9fWgia0QXg=.6cc0be3c-cd35-4ac2-9263-4344f4c08737@github.com> Message-ID: > https://developer.apple.com/news/?id=y5mjxqmn > > Starting November 1, 2023, the Apple notary service will no longer accept uploads from altool or Xcode 13 or earlier. > > > This is not a clean backport and this pull request contains a backport of the closed bug [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) commit [f1522c648c2e](https://github.com/openjdk/jdk/commit/478ef389dc3767edfbe21d10a7f7f1522c648c2e). > > Conflicts includes: > > - whitespace conflicts on src/hotspot/share/utilities/utf8.cpp > > - missing src/hotspot/share/jfr/support/jfrSymbolTable.cpp > > - context difference on src/hotspot/cpu/aarch64/vm_version_aarch64.cpp > > The sprintf is deprecated in Xcode 14 and the use of it causing building failure. The build could pass if warnings are disabled for codes that use sprintf method. For the long run, the sprintf could be replaced with snprintf. This patch is trying to check if snprintf could be used. > > Testing: > > GHA tested. > Successfull tier1,tier2,tier3 and jck tests for linux platforms. > Successfull tier1 and tier2 for windows. Elif Aslan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8296812 - add CPU back - remove CPU_STXR_PREFETCH - 8296812: Backport of 478ef389dc3767edfbe21d10a7f7f1522c648c2e ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1930/files - new: https://git.openjdk.org/jdk17u-dev/pull/1930/files/2e407ff1..717d60c7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1930&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1930&range=00-01 Stats: 41102 lines in 775 files changed: 24470 ins; 6971 del; 9661 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1930.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1930/head:pull/1930 PR: https://git.openjdk.org/jdk17u-dev/pull/1930 From rmahajan at openjdk.org Thu Jan 18 23:46:52 2024 From: rmahajan at openjdk.org (Rajat Mahajan) Date: Thu, 18 Jan 2024 23:46:52 GMT Subject: [jdk22u] RFR: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions Message-ID: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions ------------- Commit messages: - Backport f695ca588453265d6ad791c6a396197e8a53ba39 Changes: https://git.openjdk.org/jdk22u/pull/25/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=25&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321151 Stats: 54 lines in 1 file changed: 43 ins; 2 del; 9 mod Patch: https://git.openjdk.org/jdk22u/pull/25.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/25/head:pull/25 PR: https://git.openjdk.org/jdk22u/pull/25 From gnu.andrew at redhat.com Fri Jan 19 00:52:32 2024 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Fri, 19 Jan 2024 00:52:32 +0000 Subject: OpenJDK 11.0.22 Released Message-ID: We are pleased to announce the release of OpenJDK 11.0.22. The source tarball is available from: * https://openjdk-sources.osci.io/openjdk11/openjdk-11.0.22+7.tar.xz The tarball is accompanied by a digital signature available at: * https://openjdk-sources.osci.io/openjdk11/openjdk-11.0.22+7.tar.xz.sig This is signed by our Red Hat OpenJDK key (openjdk at redhat.com): PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net) Fingerprint = CA5F 11C6 CE22 644D 42C6 AC44 92EF 8D39 DC13 168F SHA256 checksums: e310b1a8343ffb857240ba97ea95f1319781d2d5614de99fc499f674bd268aa1 openjdk-11.0.22+7.tar.xz 582225ed8f9116084b102e10c726908617e7d10c99341da72eb16d353a2c4399 openjdk-11.0.22+7.tar.xz.sig The checksums can be downloaded from: * https://openjdk-sources.osci.io/openjdk11/openjdk-11.0.22+7.sha256 New in release OpenJDK 11.0.22 (2024-01-16): ============================================ Live versions of these release notes can be found at: * https://bit.ly/openjdk11022 * CVEs - CVE-2024-20918 - CVE-2024-20919 - CVE-2024-20921 - CVE-2024-20926 - CVE-2024-20945 - CVE-2024-20952 * Security fixes - JDK-8308204: Enhanced certificate processing - JDK-8314284: Enhance Nashorn performance - JDK-8314295: Enhance verification of verifier - JDK-8314307: Improve loop handling - JDK-8314468: Improve Compiler loops - JDK-8316976: Improve signature handling - JDK-8317547: Enhance TLS connection support * Other changes - JDK-6381945: (cal) Japanese calendar unit test system should avoid multiple static imports - JDK-6445283: ProgressMonitorInputStream not large file aware (>2GB) - JDK-8026393: jarsigner never shows a warning in badKeyUsage case - JDK-8041447: Test javax/swing/dnd/7171812/bug7171812.java fails with java.lang.RuntimeException: Test failed, scroll on drag doesn't work - JDK-8053479: (dc) DatagramChannel.read() throws exception instead of discarding data when buffer too small - JDK-8067250: [mlvm] vm/mlvm/mixed/stress/regression/b6969574 fails and perf regression - JDK-8153090: TAB key cannot change input focus after the radio button in the Color Selection dialog - JDK-8168408: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows - JDK-8183374: Refactor java/lang/Runtime shell tests to java - JDK-8185531: [TESTBUG] Improve test configuration for shared strings - JDK-8195589: T6587786.java failed after JDK-8189997 - JDK-8197825: [Test] Intermittent timeout with javax/swing JColorChooser Test - JDK-8205467: javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java possible deadlock - JDK-8207166: jdk/jshell/JdiHangingLaunchExecutionControlTest.java - launch timeout - JDK-8210168: JCK test .vm.classfmt.ins.code__002.code__00201m1.code__00201m1 hangs with -noverify - JDK-8210265: Crash in HSpaceCounters::update_used() - JDK-8211045: [Testbug] Fix for 8144279 didn't define a test case! - JDK-8212997: [TESTBUG] Remove defmeth tests for class file versions 50 and 51 - JDK-8213898: CDS dumping of springboot asserts in G1ArchiveAllocator::alloc_new_region - JDK-8214694: cleanup rawtypes warnings in open jndi tests - JDK-8217329: JTREG: Clean up, remove unused imports in gc folder - JDK-8218178: vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java fails with -Xcomp - JDK-8220083: Remove hard-coded 127.0.0.1 loopback address in JDK networking tests - JDK-8221396: Clean up serviceability/sa/TestUniverse.java - JDK-8223145: Replace wildcard address with loopback or local host in tests - part 1 - JDK-8223788: [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key. - JDK-8224035: Replace wildcard address with loopback or local host in tests - part 9 - JDK-8224204: Replace wildcard address with loopback or local host in tests - part 10 - JDK-8226825: Replace wildcard address with loopback or local host in tests - part 19 - JDK-8230435: Replace wildcard address with loopback or local host in tests - part 22 - JDK-8230858: Replace wildcard address with loopback or local host in tests - part 23 - JDK-8231556: Wrong font ligatures used when 2 versions of same font used - JDK-8231931: [TESTBUG] serviceability/sa/TestUniverse.java looks for wrong string with Shenandoah - JDK-8232135: Add diagnostic output to test java/util/ProcessBuilder/Basic.java - JDK-8232513: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with BindException - JDK-8232933: Javac inferred type does not conform to equality constraint - JDK-8233000: Mark vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize test as stress test - JDK-8233847: (sctp) Flx link-local IPv6 scope handling and test cleanup. - JDK-8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly - JDK-8238740: java/net/httpclient/whitebox/FlowTestDriver.java should not specify a TLS protocol - JDK-8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly - JDK-8240604: Rewrite sun/management/jmxremote/bootstrap/CustomLauncherTest.java test to make binaries from source file - JDK-8240754: Instrument FlowTest.java to provide more debug traces. - JDK-8244508: JFR: FlightRecorderOptions reset date format - JDK-8249812: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with SocketTimeoutException - JDK-8251177: [macosx] The text "big" is truncated in JTabbedPane - JDK-8252713: jtreg time out of CtrlASCII.java seems to hang the Xserver. - JDK-8254711: Add java.security.Provider.getService JFR Event - JDK-8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext - JDK-8258914: javax/net/ssl/DTLS/RespondToRetransmit.java timed out - JDK-8259266: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo 2<' missing from stdout/stderr" - JDK-8260035: Deproblemlist few problemlisted test - JDK-8260431: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo<' missing from stdout/stderr" - JDK-8263530: sun.awt.X11.ListHelper.removeAll() should use clear() - JDK-8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set. - JDK-8265678: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows - JDK-8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS - JDK-8267860: Off-by-one bug when searching arrays in AlpnGreaseTest - JDK-8268916: Tests for AffirmTrust roots - JDK-8271519: java/awt/event/SequencedEvent/MultipleContextsFunctionalTest.java failed with "Total [200] - Expected [400]" - JDK-8273804: Platform.isTieredSupported should handle the no-compiler case - JDK-8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases? - JDK-8275333: Print count in "Too many recored phases?" assert - JDK-8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing. - JDK-8280004: DCmdArgument::parse_value() should handle NULL input - JDK-8282143: Objects.requireNonNull should be ForceInline - JDK-8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time" - JDK-8284331: Add sanity check for signal handler modification warning. - JDK-8285612: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java - JDK-8285687: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PageRangesDlgTest.java - JDK-8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events - JDK-8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different - JDK-8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines - JDK-8288993: Make AwtFramePackTest generic by removing @requires tag - JDK-8289077: Add manual tests to open - JDK-8289238: Refactoring changes to PassFailJFrame Test Framework - JDK-8289547: Update javax/swing/Popup/TaskbarPositionTest.java - JDK-8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB - JDK-8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes - JDK-8289917: Metadata for regionsRefilled of G1EvacuationStatistics event is wrong - JDK-8290067: Show stack dimensions in UL logging when attaching threads - JDK-8290469: Add new positioning options to PassFailJFrame test framework - JDK-8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures - JDK-8292683: Remove BadKeyUsageTest.java from Problem List - JDK-8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses - JDK-8293098: GHA: Harmonize GCC version handling for host and cross builds - JDK-8293107: GHA: Bump to Ubuntu 22.04 - JDK-8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64 - JDK-8293361: GHA: dump config.log in case of configure failure - JDK-8293466: libjsig should ignore non-modifying sigaction calls - JDK-8293811: Provide a reason for PassFailJFrame.forceFail - JDK-8294281: Allow warnings to be disabled on a per-file basis - JDK-8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env - JDK-8294673: JFR: Add SecurityProviderService#threshold to TestActiveSettingEvent.java - JDK-8294941: GHA: Cut down cross-compilation sysroots - JDK-8294956: GHA: qemu-debootstrap is deprecated, use the regular one - JDK-8295213: Run GHA manually with user-specified make and configure arguments - JDK-8295885: GHA: Bump gcc versions - JDK-8296275: Write a test to verify setAccelerator method of JMenuItem - JDK-8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!" - JDK-8297640: Increase buffer size for buf (insert_features_names) in Abstract_VM_Version::insert_features_names - JDK-8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display - JDK-8299255: Unexpected round errors in FreetypeFontScaler - JDK-8299330: Minor improvements in MSYS2 Workflow handling - JDK-8300259: Add test coverage for processing of pending block files in signed JARs - JDK-8300272: Improve readability of the test JarWithOneNonDisabledDigestAlg - JDK-8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case - JDK-8301065: Handle control characters in java_lang_String::print - JDK-8301167: Update VerifySignedJar to actually exercise and test verification - JDK-8301570: Test runtime/jni/nativeStack/ needs to detach the native thread - JDK-8302017: Allocate BadPaddingException only if it will be thrown - JDK-8302525: Write a test to check various components send Events while mouse and key are used simultaneously - JDK-8303607: SunMSCAPI provider leaks memory and keys - JDK-8306134: Open source some AWT tests relating to Button and a few other classes - JDK-8306135: Clean up and open source some AWT tests - JDK-8306280: Open source several choice AWT tests - JDK-8306372: Open source AWT CardLayout and Checkbox tests - JDK-8306430: Open source some AWT tests related to TextComponent and Toolkit - JDK-8306575: Clean up and open source four Dialog related tests - JDK-8306765: Some client related jtreg problem list entries are malformed - JDK-8306883: Thread stacksize is reported with wrong units in os::create_thread logging - JDK-8307079: Update test java/awt/Choice/DragOffNoSelect.java - JDK-8307165: java/awt/dnd/NoFormatsDropTest/NoFormatsDropTest.java timed out - JDK-8308592: Framework for CA interoperability testing - JDK-8308910: Allow executeAndLog to accept running process - JDK-8309095: Remove UTF-8 character from TaskbarPositionTest.java - JDK-8310265: (process) jspawnhelper should not use argv[0] - JDK-8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns - JDK-8311285: report some fontconfig related environment variables in hs_err file - JDK-8311813: C1: Uninitialized PhiResolver::_loop field - JDK-8312065: Socket.connect does not timeout when profiling - JDK-8312126: NullPointerException in CertStore.getCRLs after 8297955 - JDK-8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar - JDK-8312535: MidiSystem.getSoundbank() throws unexpected SecurityException - JDK-8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere - JDK-8312972: Bump update version for OpenJDK: jdk-11.0.22 - JDK-8313428: GHA: Bump GCC versions for July 2023 updates - JDK-8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0 - JDK-8313626: C2 crash due to unexpected exception control flow - JDK-8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors - JDK-8313691: use close after failing os::fdopen in vmError and ciEnv - JDK-8313707: GHA: Bootstrap sysroots with --variant=minbase - JDK-8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md - JDK-8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows - JDK-8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection - JDK-8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges - JDK-8314242: Update applications/scimark/Scimark.java to accept VM flags - JDK-8314262: GHA: Cut down cross-compilation sysroots deeper - JDK-8314263: Signed jars triggering Logger finder recursion and StackOverflowError - JDK-8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev - JDK-8315020: The macro definition for LoongArch64 zero build is not accurate. - JDK-8315062: [GHA] get-bootjdk action should return the abolute path - JDK-8315214: Do not run sun/tools/jhsdb tests concurrently - JDK-8315480: [11u] Harmonize GHA cross-compilation block with mainline - JDK-8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java - JDK-8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test - JDK-8315696: SignedLoggerFinderTest.java test failed - JDK-8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test - JDK-8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies - JDK-8315862: [11u] Backport 8227337: javax/management/remote/mandatory/connection/ReconnectTest.java NoSuchObjectException no such object in table - JDK-8315863: [GHA] Update checkout action to use v4 - JDK-8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests - JDK-8316087: Test SignedLoggerFinderTest.java is still failing - JDK-8316178: Better diagnostic header for CodeBlobs - JDK-8316206: Test StretchedFontTest.java fails for Baekmuk font - JDK-8316380: [11u] Backport 8170089: nsk/jdi/EventSet/resume/resume008: ERROR: suspendCounts don't match for : Common-Cleaner - JDK-8316514: Better diagnostic header for VtableStub - JDK-8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java - JDK-8316746: Top of lock-stack does not match the unlocked object - JDK-8316906: Clarify TLABWasteTargetPercent flag - JDK-8317373: Add Telia Root CA v2 - JDK-8317374: Add Let's Encrypt ISRG Root X2 - JDK-8317920: JDWP-agent sends broken exception event with onthrow option - JDK-8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases - JDK-8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2 - JDK-8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java - JDK-8318759: Add four DigiCert root certificates - JDK-8319187: Add three eMudhra emSign roots - JDK-8320597: RSA signature verification fails on signed data that does not encode params correctly - JDK-8323423: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.22 Notes on individual issues: =========================== security-libs/java.security: JDK-8254711: New JFR Event: jdk.SecurityProviderService ======================================================= A new Java Flight Recorder (JFR) event has been added to record details of calls to the java.security.Provider.getService(String type, String algorithm) method. The event contains three fields: * type - the type of service * algorithm - the algorithm name * provider - the security provider This event is disabled by default. It may be enabled via the usual JFR configuration files and options. JDK-8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar =============================================================================================================================== A maximum signature file size property, jdk.jar.maxSignatureFileSize, was introduced in the 11.0.20 release of OpenJDK by JDK-8300596, with a default of 8MB. This default proved to be too small for some JAR files. This release, 11.0.22, increases it to 16MB. JDK-8317373: Added Telia Root CA v2 Certificate =============================================== The following root certificate has been added to the cacerts truststore: Name: Telia Root CA v2 Alias Name: teliarootcav2 Distinguished Name: CN=Telia Root CA v2, O=Telia Finland Oyj, C=FI ``` JDK-8317374: Added ISRG Root X2 CA Certificate from Let's Encrypt ================================================================= The following root certificate has been added to the cacerts truststore: Name: Let's Encrypt Alias Name: letsencryptisrgx2 Distinguished Name: CN=ISRG Root X2, O=Internet Security Research Group, C=US JDK-8318759: Added Four Root Certificates from DigiCert, Inc. ============================================================= The following root certificates have been added to the cacerts truststore: Name: DigiCert, Inc. Alias Name: digicertcseccrootg5 Distinguished Name: CN=DigiCert CS ECC P384 Root G5, O="DigiCert, Inc.", C=US Name: DigiCert, Inc. Alias Name: digicertcsrsarootg5 Distinguished Name: CN=DigiCert CS RSA4096 Root G5, O="DigiCert, Inc.", C=US Name: DigiCert, Inc. Alias Name: digicerttlseccrootg5 Distinguished Name: CN=DigiCert TLS ECC P384 Root G5, O="DigiCert, Inc.", C=US Name: DigiCert, Inc. Alias Name: digicerttlsrsarootg5 Distinguished Name: CN=DigiCert TLS RSA4096 Root G5, O="DigiCert, Inc.", C=US JDK-8319187: Added Three Root Certificates from eMudhra Technologies Limited ============================================================================ The following root certificates have been added to the cacerts truststore: Name: eMudhra Technologies Limited Alias Name: emsignrootcag1 Distinguished Name: CN=emSign Root CA - G1, O=eMudhra Technologies Limited, OU=emSign PKI, C=IN Name: eMudhra Technologies Limited Alias Name: emsigneccrootcag3 Distinguished Name: CN=emSign ECC Root CA - G3, O=eMudhra Technologies Limited, OU=emSign PKI, C=IN Name: eMudhra Technologies Limited Alias Name: emsignrootcag2 Distinguished Name: CN=emSign Root CA - G2, O=eMudhra Technologies Limited, OU=emSign PKI, C=IN Thanks, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From andrew at openjdk.org Fri Jan 19 01:10:40 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 19 Jan 2024 01:10:40 GMT Subject: [jdk17u-dev] RFR: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'" Message-ID: Hi all, This pull request contains a backport of commit [4d078930](https://github.com/openjdk/jdk21u/commit/4d078930eecfacb28a7c8324f233080eaf649334) from the [openjdk/jdk21u](https://git.openjdk.org/jdk21u) repository. The commit being backported was authored by Coleen Phillimore on 2 Oct 2023 and had no reviewers. The backport is primarily for 8u, where the VS2010 build seems to be broken because of the placing of the declarations of `low`, `high` and `index` in JDK-8314295; see https://github.com/gnu-andrew/jdk8u-dev/actions/runs/7549766959/job/20554342418. This is fixed by this private bug fix, JDK-8317331: `Solaris build failed with "declaration can not follow a statement (E_DECLARATION_IN_CODE)"`. However, it makes sense to have the code in sync everywhere and this change is already in 21u: https://github.com/openjdk/jdk21u/commit/4d078930eecfacb28a7c8324f233080eaf649334 I don't know if the new approval commands will work with a private bug. I guess we will see. Backport was clean and built fine on GNU/Linux with GCC 12. Thanks! ------------- Commit messages: - Backport 4d078930eecfacb28a7c8324f233080eaf649334 Changes: https://git.openjdk.org/jdk17u-dev/pull/2136/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2136&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324184 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2136.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2136/head:pull/2136 PR: https://git.openjdk.org/jdk17u-dev/pull/2136 From sgehwolf at openjdk.org Fri Jan 19 01:10:41 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 19 Jan 2024 01:10:41 GMT Subject: [jdk17u-dev] RFR: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'" In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 01:45:16 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [4d078930](https://github.com/openjdk/jdk21u/commit/4d078930eecfacb28a7c8324f233080eaf649334) from the [openjdk/jdk21u](https://git.openjdk.org/jdk21u) repository. > > The commit being backported was authored by Coleen Phillimore on 2 Oct 2023 and had no reviewers. > > The backport is primarily for 8u, where the VS2010 build seems to be broken because of the placing of the declarations of `low`, `high` and `index` in JDK-8314295; see https://github.com/gnu-andrew/jdk8u-dev/actions/runs/7549766959/job/20554342418. This is fixed by this private bug fix, JDK-8317331: `Solaris build failed with "declaration can not follow a statement (E_DECLARATION_IN_CODE)"`. However, it makes sense to have the code in sync everywhere and this change is already in 21u: https://github.com/openjdk/jdk21u/commit/4d078930eecfacb28a7c8324f233080eaf649334 > > I don't know if the new approval commands will work with a private bug. I guess we will see. > > Backport was clean and built fine on GNU/Linux with GCC 12. > > Thanks! @gnu-andrew I think you need to use `Backport JDK-8317331` if the bug is private. See https://wiki.openjdk.org/display/SKARA/Backports, section `Unknown or Missing Original Commit`. In this case I also suggest to use `/summary` with a `Backport-of: 4d078930eecfacb28a7c8324f233080eaf649334` as the bots won't add it. Hmm, not sure why it's not working. +1 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2136#issuecomment-1898013815 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2136#issuecomment-1898754497 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2136#issuecomment-1898918482 From andrew at openjdk.org Fri Jan 19 01:10:41 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 19 Jan 2024 01:10:41 GMT Subject: [jdk17u-dev] RFR: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'" In-Reply-To: References: Message-ID: <-gUdxA0S5IG6qUjEheq2l482O-_AltTegz11MPk3gnE=.5cd7ca90-a415-4112-a80c-d8f5cf9f88d5@github.com> On Thu, 18 Jan 2024 08:28:14 GMT, Severin Gehwolf wrote: > @gnu-andrew I think you need to use `Backport JDK-8317331` if the bug is private. See https://wiki.openjdk.org/display/SKARA/Backports, section `Unknown or Missing Original Commit`. In this case I also suggest to use `/summary` with a `Backport-of: 4d078930eecfacb28a7c8324f233080eaf649334` as the bots won't add it. Thanks. Not sure I've seen that more detailed page before. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2136#issuecomment-1898519784 From andrew at openjdk.org Fri Jan 19 01:10:42 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 19 Jan 2024 01:10:42 GMT Subject: [jdk17u-dev] RFR: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'" In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 01:45:16 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [4d078930](https://github.com/openjdk/jdk21u/commit/4d078930eecfacb28a7c8324f233080eaf649334) from the [openjdk/jdk21u](https://git.openjdk.org/jdk21u) repository. > > The commit being backported was authored by Coleen Phillimore on 2 Oct 2023 and had no reviewers. > > The backport is primarily for 8u, where the VS2010 build seems to be broken because of the placing of the declarations of `low`, `high` and `index` in JDK-8314295; see https://github.com/gnu-andrew/jdk8u-dev/actions/runs/7549766959/job/20554342418. This is fixed by this private bug fix, JDK-8317331: `Solaris build failed with "declaration can not follow a statement (E_DECLARATION_IN_CODE)"`. However, it makes sense to have the code in sync everywhere and this change is already in 21u: https://github.com/openjdk/jdk21u/commit/4d078930eecfacb28a7c8324f233080eaf649334 > > I don't know if the new approval commands will work with a private bug. I guess we will see. > > Backport was clean and built fine on GNU/Linux with GCC 12. > > Thanks! It may be easier just to file a new bug. Then the backport records would also be visible for 8u & 11u. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2136#issuecomment-1898843822 From jbechberger at openjdk.org Fri Jan 19 07:38:31 2024 From: jbechberger at openjdk.org (Johannes Bechberger) Date: Fri, 19 Jan 2024 07:38:31 GMT Subject: [jdk17u-dev] Integrated: 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 13:43:19 GMT, Johannes Bechberger wrote: > Hi all, > > This pull request contains a backport of commit [ffa33d7b](https://github.com/openjdk/jdk/commit/ffa33d7b807bfef6ff05c9adba869dddf813cf68) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Artem Semenov on 17 Jan 2024 and was reviewed by Alexander Zuev. > > Thanks! This pull request has now been integrated. Changeset: e113ab7c Author: Johannes Bechberger Committer: Artem Semenov URL: https://git.openjdk.org/jdk17u-dev/commit/e113ab7c15190be8c375d86da3c5f2ddb7c242ec Stats: 65 lines in 1 file changed: 64 ins; 1 del; 0 mod 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma Reviewed-by: asemenov Backport-of: ffa33d7b807bfef6ff05c9adba869dddf813cf68 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2140 From goetz at openjdk.org Fri Jan 19 07:51:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 07:51:33 GMT Subject: [jdk21u-dev] RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 Message-ID: <844wt1xNgoJha8KJHdhmbp_LNBxDEcxsTTF2qbQk_SM=.9864660f-be80-43cc-965a-58113fa6ab7b@github.com> I backport this for parity with 21.0.3-oracle. This is a composition of two clean backports. See also separate commits. Will mark as clean. ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/187 Commit messages: - Backport 8319128 - Backport 8319136 Changes: https://git.openjdk.org/jdk21u-dev/pull/195/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=195&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319128 Stats: 44 lines in 5 files changed: 35 ins; 3 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/195.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/195/head:pull/195 PR: https://git.openjdk.org/jdk21u-dev/pull/195 From goetz at openjdk.org Fri Jan 19 08:34:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 08:34:38 GMT Subject: [jdk17u-dev] RFR: 8317039: Enable specifying the JDK used to run jtreg Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 2545f55e509fdc3a2fa6e4dec33f1b4a20a8b679 Changes: https://git.openjdk.org/jdk17u-dev/pull/2141/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2141&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317039 Stats: 44 lines in 5 files changed: 42 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2141.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2141/head:pull/2141 PR: https://git.openjdk.org/jdk17u-dev/pull/2141 From lmao at openjdk.org Fri Jan 19 08:47:42 2024 From: lmao at openjdk.org (Liang Mao) Date: Fri, 19 Jan 2024 08:47:42 GMT Subject: [jdk21u-dev] RFR: 8322279: Generational ZGC: Use ZFragmentationLimit and ZYoungCompactionLimit as percentage instead of multiples In-Reply-To: <-l0U_b-rR8Q1YkafdBqS0rdMKt5cFwkyn0o_4AceWwk=.17a38e29-2d5a-4a65-87dd-c54efe1ea463@github.com> References: <-l0U_b-rR8Q1YkafdBqS0rdMKt5cFwkyn0o_4AceWwk=.17a38e29-2d5a-4a65-87dd-c54efe1ea463@github.com> Message-ID: On Tue, 16 Jan 2024 03:40:14 GMT, Liang Mao wrote: > This commit fixed incorrect use of production options of generational ZGC. Since JDK21 is the only LST version with generational ZGC? we need to fix the potential bugs. > Additional testing on fastdebug against test/hotspot/jtreg/gc/z Could committers please help to sponsor, thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/173#issuecomment-1899989853 From goetz at openjdk.org Fri Jan 19 09:01:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 09:01:36 GMT Subject: [jdk17u-dev] RFR: 8322321: Add man page doc for -XX:+VerifySharedSpaces In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:44:59 GMT, Jonathan Dowland wrote: >> Nope, you now need maintainer approval. My review only covers the "unclean backport" part. > >> Nope, you now need maintainer approval. My review only covers the "unclean backport" part. > > Gotcha, thanks. I'm somewhat rusty. This is useful [grist for the mill](https://fosdem.org/2024/schedule/event/fosdem-2024-2460-a-beginner-s-guide-to-backports/). Hi @jmtd, have you given this up? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2098#issuecomment-1900009326 From goetz at openjdk.org Fri Jan 19 09:12:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 09:12:33 GMT Subject: [jdk17u-dev] RFR: 8311581: Remove obsolete code and comments in TestLVT.java Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 27de536b409aa80c8b8bb452160329be52814e0b Changes: https://git.openjdk.org/jdk17u-dev/pull/2142/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2142&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311581 Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2142.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2142/head:pull/2142 PR: https://git.openjdk.org/jdk17u-dev/pull/2142 From goetz at openjdk.org Fri Jan 19 09:31:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 09:31:41 GMT Subject: [jdk17u-dev] RFR: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 8042a50b99a671390910afa5f816894f77255429 Changes: https://git.openjdk.org/jdk17u-dev/pull/2144/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2144&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309305 Stats: 57 lines in 1 file changed: 20 ins; 24 del; 13 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2144.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2144/head:pull/2144 PR: https://git.openjdk.org/jdk17u-dev/pull/2144 From goetz at openjdk.org Fri Jan 19 09:31:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 09:31:52 GMT Subject: [jdk17u-dev] RFR: 8313206: PKCS11 tests silently skip execution Message-ID: I backport this for parity with 17.0.11-oracle. I had to do trivial adaptions: test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java It was introduced by 8301154, a bigger bugfix in PKCS11. I don't want to backport this. Patch omitted. test/jdk/sun/security/pkcs11/PKCS11Test.java trivial resolve, Skipped whitespace fixes in code that was only introduced by "8301553: Support Password-Based Cryptography in SunPKCS11" ------------- Commit messages: - Backport 515add88ed6c290ee90f3d6f522a22971e37a62c Changes: https://git.openjdk.org/jdk17u-dev/pull/2143/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2143&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313206 Stats: 340 lines in 9 files changed: 159 ins; 85 del; 96 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2143.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2143/head:pull/2143 PR: https://git.openjdk.org/jdk17u-dev/pull/2143 From lmao at openjdk.org Fri Jan 19 09:37:37 2024 From: lmao at openjdk.org (Liang Mao) Date: Fri, 19 Jan 2024 09:37:37 GMT Subject: [jdk21u-dev] Integrated: 8322279: Generational ZGC: Use ZFragmentationLimit and ZYoungCompactionLimit as percentage instead of multiples In-Reply-To: <-l0U_b-rR8Q1YkafdBqS0rdMKt5cFwkyn0o_4AceWwk=.17a38e29-2d5a-4a65-87dd-c54efe1ea463@github.com> References: <-l0U_b-rR8Q1YkafdBqS0rdMKt5cFwkyn0o_4AceWwk=.17a38e29-2d5a-4a65-87dd-c54efe1ea463@github.com> Message-ID: On Tue, 16 Jan 2024 03:40:14 GMT, Liang Mao wrote: > This commit fixed incorrect use of production options of generational ZGC. Since JDK21 is the only LST version with generational ZGC? we need to fix the potential bugs. > Additional testing on fastdebug against test/hotspot/jtreg/gc/z This pull request has now been integrated. Changeset: 95e36bc7 Author: Liang Mao Committer: Erik ?sterlund URL: https://git.openjdk.org/jdk21u-dev/commit/95e36bc7e970dd4038d6df0b25cb4ff1c19b6e70 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8322279: Generational ZGC: Use ZFragmentationLimit and ZYoungCompactionLimit as percentage instead of multiples Reviewed-by: eosterlund Backport-of: bf813be0f30391c67de3ea74c7522d7cbb8d3c3b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/173 From goetz at openjdk.org Fri Jan 19 10:17:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 10:17:56 GMT Subject: [jdk17u-dev] RFR: 8312428: PKCS11 tests fail with NSS 3.91 Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 1c598c2245c5c348e946f4d0df653daa6e42da94 Changes: https://git.openjdk.org/jdk17u-dev/pull/2145/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2145&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312428 Stats: 268 lines in 4 files changed: 153 ins; 60 del; 55 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2145.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2145/head:pull/2145 PR: https://git.openjdk.org/jdk17u-dev/pull/2145 From mbaesken at openjdk.org Fri Jan 19 11:52:33 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 19 Jan 2024 11:52:33 GMT Subject: [jdk17u-dev] RFR: 8319124: Update XML Security for Java to 3.0.3 In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 11:13:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. > I used the 21u commit as base. This makes the backport almost clean, and alredy reflects the adaptions needed because of the backport CSR. > > The following trivial resolves were made: > > src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java > src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRSAPSSSignatureMethod.java > Cannot remove line with logging code because this was already > removed by "8316976: Improve signature handling" > > src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Utils.java > Resolved imports due to context. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2139#pullrequestreview-1832286452 From goetz at openjdk.org Fri Jan 19 14:01:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 14:01:16 GMT Subject: [jdk21u-dev] RFR: 8312416: Tests in Locale should have more descriptive names Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport a9a3463afb33b9df4cbf64d1866255bff638824f Changes: https://git.openjdk.org/jdk21u-dev/pull/197/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=197&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312416 Stats: 265 lines in 16 files changed: 93 ins; 138 del; 34 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/197.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/197/head:pull/197 PR: https://git.openjdk.org/jdk21u-dev/pull/197 From goetz at openjdk.org Fri Jan 19 14:04:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 14:04:08 GMT Subject: [jdk21u-dev] RFR: 8077371: Binary files in JAXP test should be removed Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 40106422bd2ae3da98d028bdbab2c240a71081e3 Changes: https://git.openjdk.org/jdk21u-dev/pull/198/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=198&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8077371 Stats: 928 lines in 16 files changed: 808 ins; 68 del; 52 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/198.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/198/head:pull/198 PR: https://git.openjdk.org/jdk21u-dev/pull/198 From goetz at openjdk.org Fri Jan 19 14:11:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 14:11:38 GMT Subject: [jdk21u-dev] RFR: 8319213: Compatibility.java reads both stdout and stderr of JdkUtils Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 84f4f7477c4e1b7ecc4c7fead2ded21242efddd7 Changes: https://git.openjdk.org/jdk21u-dev/pull/199/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=199&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319213 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/199.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/199/head:pull/199 PR: https://git.openjdk.org/jdk21u-dev/pull/199 From goetz at openjdk.org Fri Jan 19 14:12:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 14:12:44 GMT Subject: [jdk17u-dev] RFR: 8319213: Compatibility.java reads both stdout and stderr of JdkUtils Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 84f4f7477c4e1b7ecc4c7fead2ded21242efddd7 Changes: https://git.openjdk.org/jdk17u-dev/pull/2146/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2146&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319213 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2146.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2146/head:pull/2146 PR: https://git.openjdk.org/jdk17u-dev/pull/2146 From goetz at openjdk.org Fri Jan 19 14:14:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 14:14:58 GMT Subject: [jdk17u-dev] RFR: 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal Message-ID: I backport this for parity with 17.0.11-oracle. Some tests are not in 17, skipped. All the other are clean. Will mark as clean. ------------- Commit messages: - Backport 6f263111a1812873291e91870e341ccce804d049 Changes: https://git.openjdk.org/jdk17u-dev/pull/2147/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2147&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318490 Stats: 34 lines in 34 files changed: 0 ins; 0 del; 34 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2147.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2147/head:pull/2147 PR: https://git.openjdk.org/jdk17u-dev/pull/2147 From jbechberger at openjdk.org Fri Jan 19 15:50:33 2024 From: jbechberger at openjdk.org (Johannes Bechberger) Date: Fri, 19 Jan 2024 15:50:33 GMT Subject: [jdk21u-dev] Integrated: 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 13:39:30 GMT, Johannes Bechberger wrote: > Hi all, > > This pull request contains a backport of commit [ffa33d7b](https://github.com/openjdk/jdk/commit/ffa33d7b807bfef6ff05c9adba869dddf813cf68) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Artem Semenov on 17 Jan 2024 and was reviewed by Alexander Zuev. > > Thanks! This pull request has now been integrated. Changeset: c3657ee0 Author: Johannes Bechberger Committer: Christoph Langer URL: https://git.openjdk.org/jdk21u-dev/commit/c3657ee02898ff022fa8bb7fc5d5d77ed74b1011 Stats: 65 lines in 1 file changed: 64 ins; 1 del; 0 mod 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma Reviewed-by: asemenov Backport-of: ffa33d7b807bfef6ff05c9adba869dddf813cf68 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/193 From goetz at openjdk.org Fri Jan 19 15:50:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 15:50:44 GMT Subject: [jdk11u-dev] Integrated: 8305972: Update XML Security for Java to 3.0.2 In-Reply-To: References: Message-ID: On Thu, 11 Jan 2024 19:19:19 GMT, Goetz Lindenmaier wrote: > This backport is based on https://github.com/openjdk/jdk17u-dev/pull/2116 , the minimal version. > It contains the full EdDSA functionality and only removes the Strings that are explicitly not documented for backport in the CSRs. > > I needed the following adaptions you find in seperate commits: > > **Resolves**: > > The implementation in the jdk patched clean. > There were some conflicts in the tests: > > test/jdk/TEST.groups > trivial resolve due to context. > > test/jdk/javax/xml/crypto/dsig/GenerationTests.java > trivial resolve due to context. 8241306 is missing in the context. > > test/jdk/javax/xml/crypto/dsig/SecureValidation.java > This file is not in 11. > It came with "8241306: Add SignatureMethodParameterSpec subclass > for RSASSA-PSS params" which was not backported. Changes omitted. > > test/lib/jdk/test/lib/security/XMLUtils.java > One chunk does not apply because the removed code differs. > In 17, a switch statement is used that was adapted to Java 11. > Moved the comment and exception thrown in 11 to the new place. > > > **Make it compile and make the tests work**: > > The changes to the libraries compile out of the box. > > The tests needed several adaptions. I did not remove the > bad code yet, but just commented it out to highlight the > differences better for now. > > test/jdk/javax/xml/crypto/dsig/Basic.java > I had to remove test cases because > 8241305: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params > 8166597: Crypto support for the EdDSA Signature Algorithm > are not in 11. > > test/jdk/javax/xml/crypto/dsig/GenerationTests.java > To make it compile, I > replaced HexFormat.of().parseHex() by jdk.test.lib.Utils.toByteArray(). > Further, I commented a row of test coding that does not compile. > "8166597: Crypto support for the EdDSA Signature Algorithm" would > be needed to get these test cases working. > This effectively removes the test cases for the new functionality. > > test/jdk/javax/xml/crypto/dsig/HereFunction.java > A simple tweak to enable testing of sha1 is not needed in 11. > In 11, sha1 is still available per default as > "8259709: Disable SHA-1 XML Signatures" was not backported. > > test/lib/jdk/test/lib/security/XMLUtils.java > More complex resolve because a previous backport was already adapted to 11. > The code in 17 uses incompatible switch and instanceof > in several places. > It also needed adaptions because it does not compile as > 8166597: Crypto support for the EdDSA Signature Algorithm > is not in 11. This pull request has now been integrated. Changeset: ef246341 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/ef2463415113e0025357824b75e68583e1e90a18 Stats: 1176 lines in 37 files changed: 918 ins; 144 del; 114 mod 8305972: Update XML Security for Java to 3.0.2 Reviewed-by: mbaesken Backport-of: f0aebc8141de5a50c88658a40caa01967a9afc53 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2455 From goetz at openjdk.org Fri Jan 19 15:51:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 15:51:31 GMT Subject: [jdk21u-dev] Integrated: 8314283: Support for NSS tests on aarch64 platforms In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 14:18:32 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: c01bdbbf Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/c01bdbbfb1784bff6ae4b66d156b3c78546ad264 Stats: 41 lines in 2 files changed: 24 ins; 3 del; 14 mod 8314283: Support for NSS tests on aarch64 platforms Backport-of: 2a8016096000de5836251f2ca9bc8ad6479e6942 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/187 From goetz at openjdk.org Fri Jan 19 15:53:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 15:53:35 GMT Subject: [jdk17u-dev] Integrated: 8319124: Update XML Security for Java to 3.0.3 In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 11:13:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. > I used the 21u commit as base. This makes the backport almost clean, and alredy reflects the adaptions needed because of the backport CSR. > > The following trivial resolves were made: > > src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java > src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRSAPSSSignatureMethod.java > Cannot remove line with logging code because this was already > removed by "8316976: Improve signature handling" > > src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Utils.java > Resolved imports due to context. This pull request has now been integrated. Changeset: 6b5655a6 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/6b5655a651a7c4418d0f4e19ce34b487e021910e Stats: 1529 lines in 130 files changed: 1114 ins; 229 del; 186 mod 8319124: Update XML Security for Java to 3.0.3 Reviewed-by: mbaesken Backport-of: 45df078510ad6b8fb336e4180622ca3792bbe0cc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2139 From goetz at openjdk.org Fri Jan 19 15:55:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 15:55:47 GMT Subject: [jdk21u-dev] RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 [v2] In-Reply-To: <844wt1xNgoJha8KJHdhmbp_LNBxDEcxsTTF2qbQk_SM=.9864660f-be80-43cc-965a-58113fa6ab7b@github.com> References: <844wt1xNgoJha8KJHdhmbp_LNBxDEcxsTTF2qbQk_SM=.9864660f-be80-43cc-965a-58113fa6ab7b@github.com> Message-ID: > I backport this for parity with 21.0.3-oracle. > > This is a composition of two clean backports. See also separate commits. Will mark as clean. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/195/files - new: https://git.openjdk.org/jdk21u-dev/pull/195/files/bb05ffc3..bb05ffc3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=195&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=195&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/195.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/195/head:pull/195 PR: https://git.openjdk.org/jdk21u-dev/pull/195 From igavrilin at openjdk.org Fri Jan 19 16:47:43 2024 From: igavrilin at openjdk.org (Ilya Gavrilin) Date: Fri, 19 Jan 2024 16:47:43 GMT Subject: [jdk22u] Integrated: 8322790: RISC-V: Tune costs for shuffles with no conversion In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 15:18:24 GMT, Ilya Gavrilin wrote: > Hi all, I would like to backport [JDK-8322790](https://bugs.openjdk.org/browse/JDK-8322790) to jdk22u in order to improve performance for methods operating with integer representations of floating point values. > Patch applies clean. This pull request has now been integrated. Changeset: bbbc0ea6 Author: Ilya Gavrilin Committer: Vladimir Kempik URL: https://git.openjdk.org/jdk22u/commit/bbbc0ea6b2687caf5a3e596eb67bb7d5ea8a5694 Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod 8322790: RISC-V: Tune costs for shuffles with no conversion Backport-of: 2acb5bd9924511b58b0e57ea9eb6c2dee9fd3ee8 ------------- PR: https://git.openjdk.org/jdk22u/pull/22 From goetz at openjdk.org Fri Jan 19 17:30:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 17:30:42 GMT Subject: [jdk21u-dev] RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 [v3] In-Reply-To: <844wt1xNgoJha8KJHdhmbp_LNBxDEcxsTTF2qbQk_SM=.9864660f-be80-43cc-965a-58113fa6ab7b@github.com> References: <844wt1xNgoJha8KJHdhmbp_LNBxDEcxsTTF2qbQk_SM=.9864660f-be80-43cc-965a-58113fa6ab7b@github.com> Message-ID: <4i5fo_Ql6RQUUYcbRNCkY7Wyf_lABPCwnmQDrUYcFqE=.25bb5030-0c0e-4646-92b2-16e47b5ca48e@github.com> > I backport this for parity with 21.0.3-oracle. > > This is a composition of two clean backports. See also separate commits. Will mark as clean. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into goetz_backport_8319128 - Backport 8319128 - Backport 8319136 - Backport 2a8016096000de5836251f2ca9bc8ad6479e6942 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/195/files - new: https://git.openjdk.org/jdk21u-dev/pull/195/files/bb05ffc3..9c98732d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=195&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=195&range=01-02 Stats: 5868 lines in 93 files changed: 2958 ins; 1954 del; 956 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/195.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/195/head:pull/195 PR: https://git.openjdk.org/jdk21u-dev/pull/195 From goetz at openjdk.org Fri Jan 19 17:38:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 17:38:33 GMT Subject: [jdk17u-dev] RFR: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 09:27:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. GHA failure: infra issue, unrelated: Download failed: https://ghcr.io/v2/homebrew/core/make/blobs/sha256:2571cf69a3d123408660797685af0040097b1c273b13dfd0e3653ca1150830e2 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2144#issuecomment-1900819839 From goetz at openjdk.org Fri Jan 19 17:39:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 19 Jan 2024 17:39:48 GMT Subject: [jdk11u-dev] RFR: 8319124: Update XML Security for Java to 3.0.3 Message-ID: I backport this for parity with 11.0.23-oracle. Large parts applied clean, see first commit. I had to do the following mostly trivial resolves: src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/Init.java A larger chunk did not apply, I could not see why so far. src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureBaseRSA.java patching file src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRSAPSSSignatureMethod.java patching file src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java Trivial resolve of imports. To make it compile I had to remove RSAPSSParameterSpec from the imports in two places. patching file test/jdk/javax/xml/crypto/dsig/GenerationTests.java All failed to apply automatically because RSAPSS coding is missing in the context. Also, the new tests don't work as "JDK-8172680: Support SHA-3 based Hmac algorithms" is not in 11. I kept the test coding to simplify future backports. ------------- Commit messages: - Fix whitespace - Resolves, disable new tests - Backport 8319124 - clean parts Changes: https://git.openjdk.org/jdk11u-dev/pull/2465/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2465&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319124 Stats: 1523 lines in 130 files changed: 1114 ins; 226 del; 183 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2465.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2465/head:pull/2465 PR: https://git.openjdk.org/jdk11u-dev/pull/2465 From rmahajan at openjdk.org Fri Jan 19 18:19:28 2024 From: rmahajan at openjdk.org (Rajat Mahajan) Date: Fri, 19 Jan 2024 18:19:28 GMT Subject: [jdk22u] Integrated: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 23:39:27 GMT, Rajat Mahajan wrote: > 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions This pull request has now been integrated. Changeset: 160f6508 Author: Rajat Mahajan Committer: Alexey Ivanov URL: https://git.openjdk.org/jdk22u/commit/160f65086c991d28448aa62f44f31b73f2d8d815 Stats: 54 lines in 1 file changed: 43 ins; 2 del; 9 mod 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions Backport-of: f695ca588453265d6ad791c6a396197e8a53ba39 ------------- PR: https://git.openjdk.org/jdk22u/pull/25 From duke at openjdk.org Fri Jan 19 23:25:34 2024 From: duke at openjdk.org (duke) Date: Fri, 19 Jan 2024 23:25:34 GMT Subject: [jdk11u-dev] Withdrawn: 8269280: (bf) Replace StringBuffer in *Buffer.toString() In-Reply-To: References: Message-ID: On Fri, 27 Oct 2023 15:46:04 GMT, Sonia Zaldana Calles wrote: > 8269280: (bf) Replace StringBuffer in *Buffer.toString() This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2231 From serb at openjdk.org Sat Jan 20 06:11:42 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 20 Jan 2024 06:11:42 GMT Subject: [jdk21u-dev] RFR: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions Message-ID: Hi all, This pull request contains a backport of commit [f695ca58](https://github.com/openjdk/jdk/commit/f695ca588453265d6ad791c6a396197e8a53ba39) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Rajat Mahajan on 22 Dec 2023 and was reviewed by Alexey Ivanov and Alisen Chung. Thanks! ------------- Commit messages: - Backport f695ca588453265d6ad791c6a396197e8a53ba39 Changes: https://git.openjdk.org/jdk21u-dev/pull/200/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=200&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321151 Stats: 54 lines in 1 file changed: 43 ins; 2 del; 9 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/200.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/200/head:pull/200 PR: https://git.openjdk.org/jdk21u-dev/pull/200 From serb at openjdk.org Sat Jan 20 06:11:46 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 20 Jan 2024 06:11:46 GMT Subject: [jdk17u-dev] RFR: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions Message-ID: Hi all, This pull request contains a backport of commit [f695ca58](https://github.com/openjdk/jdk/commit/f695ca588453265d6ad791c6a396197e8a53ba39) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Rajat Mahajan on 22 Dec 2023 and was reviewed by Alexey Ivanov and Alisen Chung. Thanks! ------------- Commit messages: - Backport f695ca588453265d6ad791c6a396197e8a53ba39 Changes: https://git.openjdk.org/jdk17u-dev/pull/2148/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2148&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321151 Stats: 54 lines in 1 file changed: 43 ins; 2 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2148.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2148/head:pull/2148 PR: https://git.openjdk.org/jdk17u-dev/pull/2148 From jdowland at openjdk.org Sat Jan 20 10:21:32 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Sat, 20 Jan 2024 10:21:32 GMT Subject: [jdk17u-dev] RFR: 8322321: Add man page doc for -XX:+VerifySharedSpaces In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 08:58:53 GMT, Goetz Lindenmaier wrote: >>> Nope, you now need maintainer approval. My review only covers the "unclean backport" part. >> >> Gotcha, thanks. I'm somewhat rusty. This is useful [grist for the mill](https://fosdem.org/2024/schedule/event/fosdem-2024-2460-a-beginner-s-guide-to-backports/). > > Hi @jmtd, have you given this up? Hi @GoeLin no, I just haven't had a chance to pivot back to backports this week. Sorry! I'll look at it Monday. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2098#issuecomment-1902057585 From luhenry at openjdk.org Mon Jan 22 07:50:51 2024 From: luhenry at openjdk.org (Ludovic Henry) Date: Mon, 22 Jan 2024 07:50:51 GMT Subject: [jdk17u-dev] RFR: 8324234: Use reserved IP for java.net testing Message-ID: Some tests like test/jdk/java/net/Socket/B8312065.java use specific IPs (like 192.168.255.255) taking the assumption that the address is not going to be assigned. This doesn't always hold true, as 192.168.255.255 for example is a valid address. [RFC 5737](https://www.rfc-editor.org/rfc/rfc5737) defines specific ranges of IP addresses that may are reserved for these exact purpose and that will never be assigned. Let's make sure to use an IP in this range, like 192.0.2.1 for example. The specific test test/jdk/java/net/Socket/B8312065.java was introduced with https://git.openjdk.org/jdk17u-dev/pull/1639. ------------- Commit messages: - 8324234: Use reserved IP for java.net testing Changes: https://git.openjdk.org/jdk17u-dev/pull/2149/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2149&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324234 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2149.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2149/head:pull/2149 PR: https://git.openjdk.org/jdk17u-dev/pull/2149 From luhenry at openjdk.org Mon Jan 22 07:59:42 2024 From: luhenry at openjdk.org (Ludovic Henry) Date: Mon, 22 Jan 2024 07:59:42 GMT Subject: [jdk17u-dev] RFR: 8286447: [Linux] AWT should start in Headless mode if headful AWT library not installed Message-ID: <-9qNHiwn7V3nTaQOijDyyl6q7U1T6JUMJl7fYe0zb2c=.eef4a1e4-2397-40b2-96cf-a80467fbe5dc@github.com> Backport applied cleanly. ------------- Commit messages: - Backport aa5062584c5a17d1ad21e31ce3f4768f6a5edbc8 Changes: https://git.openjdk.org/jdk17u-dev/pull/2150/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2150&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286447 Stats: 35 lines in 1 file changed: 30 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2150.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2150/head:pull/2150 PR: https://git.openjdk.org/jdk17u-dev/pull/2150 From shade at openjdk.org Mon Jan 22 08:20:30 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 22 Jan 2024 08:20:30 GMT Subject: [jdk21u-dev] Integrated: 8318809: java/util/concurrent/ConcurrentLinkedQueue/WhiteBox.java shows intermittent failures on linux ppc64le and aarch64 In-Reply-To: References: Message-ID: <03nq5ImLn7FLNDMJ2KDh3vYHKRPlk4CNfRVJR-7mXoY=.8930f2a1-971e-4733-bc16-d486f621a6ef@github.com> On Tue, 16 Jan 2024 08:48:25 GMT, Aleksey Shipilev wrote: > Clean backport to stabilize tests and better parity. Removes test cases, guaranteed to be safe. This pull request has now been integrated. Changeset: 69416f48 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/69416f4880ebb7c17f8faa17b52749e7085882de Stats: 30 lines in 1 file changed: 0 ins; 30 del; 0 mod 8318809: java/util/concurrent/ConcurrentLinkedQueue/WhiteBox.java shows intermittent failures on linux ppc64le and aarch64 Backport-of: 50d1839d54f13631946925d8ecf03ce71f31bab8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/175 From ashi at openjdk.org Mon Jan 22 08:38:58 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 22 Jan 2024 08:38:58 GMT Subject: [jdk11u-dev] RFR: 8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes Message-ID: <9wEFl5sDvMps_5tCkCQwxelb6Zxel_te9GWc7y7oeK0=.1879da5b-8e2e-4e45-b93a-720dc677f30d@github.com> Backport of [JDK-8272335](https://bugs.openjdk.org/browse/JDK-8272335) - The file `test/hotspot/jtreg/runtime/cds/appcds/MoveJDKTest.java` match to `test/hotspot/jtreg/runtime/appcds/MoveJDKTest.java` in Java 11 - The `diff` file patched successfully, except the `Copyright year` line - So this change can be considered as `Clean` although technically not clean Testing - Local: not aplicable - `no tests selected` - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 75a06421e596b0e0006120a13836ec65a3ab9d46 Changes: https://git.openjdk.org/jdk11u-dev/pull/2467/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2467&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272335 Stats: 8 lines in 1 file changed: 5 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2467.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2467/head:pull/2467 PR: https://git.openjdk.org/jdk11u-dev/pull/2467 From goetz at openjdk.org Mon Jan 22 08:40:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 22 Jan 2024 08:40:35 GMT Subject: [jdk17u-dev] RFR: 8324234: Use reserved IP for java.net testing In-Reply-To: References: Message-ID: On Mon, 22 Jan 2024 07:46:34 GMT, Ludovic Henry wrote: > Some tests like test/jdk/java/net/Socket/B8312065.java use specific IPs (like 192.168.255.255) taking the assumption that the address is not going to be assigned. This doesn't always hold true, as 192.168.255.255 for example is a valid address. > > [RFC 5737](https://www.rfc-editor.org/rfc/rfc5737) defines specific ranges of IP addresses that may are reserved for these exact purpose and that will never be assigned. Let's make sure to use an IP in this range, like 192.0.2.1 for example. > > The specific test test/jdk/java/net/Socket/B8312065.java was introduced with https://git.openjdk.org/jdk17u-dev/pull/1639. 2luhenry Reviewi missing. Tests fail. Fix-request comment missing. Removing the tag. Why don't you fix this in head? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2149#issuecomment-1903496150 From andrewlu at openjdk.org Mon Jan 22 08:45:31 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 22 Jan 2024 08:45:31 GMT Subject: [jdk17u-dev] Integrated: 8169475: WheelModifier.java fails by timeout In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 09:00:27 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: a6135d78 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/a6135d783d49dc8047375f62bd969b0874a21891 Stats: 60 lines in 1 file changed: 41 ins; 9 del; 10 mod 8169475: WheelModifier.java fails by timeout Backport-of: 613d32c2822a443fdcb131a7d67c528410e9f7e6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2134 From andrewlu at openjdk.org Mon Jan 22 08:45:35 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 22 Jan 2024 08:45:35 GMT Subject: [jdk11u-dev] Integrated: 8169475: WheelModifier.java fails by timeout In-Reply-To: References: Message-ID: On Wed, 17 Jan 2024 09:06:03 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: 03cd8852 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/03cd88522ed4af7d0c008abd6dedf70ddd37e253 Stats: 60 lines in 1 file changed: 41 ins; 9 del; 10 mod 8169475: WheelModifier.java fails by timeout Backport-of: 613d32c2822a443fdcb131a7d67c528410e9f7e6 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2461 From andrewlu at openjdk.org Mon Jan 22 08:46:42 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 22 Jan 2024 08:46:42 GMT Subject: [jdk21u-dev] Integrated: 8169475: WheelModifier.java fails by timeout In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 02:10:39 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 1dd2f2a8 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/1dd2f2a8aa15f27a7db2c5d8b785604783d363d3 Stats: 60 lines in 1 file changed: 41 ins; 9 del; 10 mod 8169475: WheelModifier.java fails by timeout Backport-of: 613d32c2822a443fdcb131a7d67c528410e9f7e6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/190 From goetz at openjdk.org Mon Jan 22 08:46:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 22 Jan 2024 08:46:43 GMT Subject: [jdk21u-dev] Integrated: 8077371: Binary files in JAXP test should be removed In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 13:55:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: e9be5319 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/e9be531942fc42b2630db8e6b63b21f7981c0099 Stats: 928 lines in 16 files changed: 808 ins; 68 del; 52 mod 8077371: Binary files in JAXP test should be removed Backport-of: 40106422bd2ae3da98d028bdbab2c240a71081e3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/198 From goetz at openjdk.org Mon Jan 22 08:50:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 22 Jan 2024 08:50:33 GMT Subject: [jdk17u-dev] RFR: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 09:27:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. GHA failure on mac: Download failed: https://ghcr.io/v2/homebrew/core/make/blobs/sha256:2571cf69a3d123408660797685af0040097b1c273b13dfd0e3653ca1150830e2 Infra issue, unrelated ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2144#issuecomment-1903510279 From goetz at openjdk.org Mon Jan 22 08:51:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 22 Jan 2024 08:51:32 GMT Subject: [jdk17u-dev] RFR: 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 14:07:44 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. > > Some tests are not in 17, skipped. > All the other are clean. > > Will mark as clean. \clean ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2147#issuecomment-1903512167 From duke at openjdk.org Mon Jan 22 08:56:58 2024 From: duke at openjdk.org (sendaoYan) Date: Mon, 22 Jan 2024 08:56:58 GMT Subject: [jdk17u-dev] RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 [v2] In-Reply-To: References: Message-ID: <6gPZQV52-BV_Jsd4CuGCL4ydQTQgUK5SOLdH6bTB6V4=.d5aab586-a7b6-4daa-871d-a3ebd85085d5@github.com> > 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 sendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-52814994efc4831fdbc1f796ed1db6ae88cb616c - 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 Backport-of: 52814994efc4831fdbc1f796ed1db6ae88cb616c Signed-off-by: sendaoYan ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2138/files - new: https://git.openjdk.org/jdk17u-dev/pull/2138/files/8e8e6865..6bb3a544 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2138&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2138&range=00-01 Stats: 1662 lines in 134 files changed: 1223 ins; 239 del; 200 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2138.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2138/head:pull/2138 PR: https://git.openjdk.org/jdk17u-dev/pull/2138 From shade at openjdk.org Mon Jan 22 08:58:54 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 22 Jan 2024 08:58:54 GMT Subject: [jdk21u-dev] RFR: 8323154: C2: assert(cmp != nullptr && cmp->Opcode() == Op_Cmp(bt)) failed: no exit test Message-ID: Clean backport to fix another C2 corner case; introduced by https://bugs.openjdk.org/browse/JDK-8316719, which is in 21.0.2. Additional testing: - [x] New test fails without the fix, passes with it - [ ] Linux x86_64 fastdebug `tier{1,2,3,4}` ------------- Commit messages: - Backport 6997bfc68def7f80fbf6a7486a4b9f61225fc471 Changes: https://git.openjdk.org/jdk21u-dev/pull/201/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=201&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323154 Stats: 50 lines in 2 files changed: 49 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/201.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/201/head:pull/201 PR: https://git.openjdk.org/jdk21u-dev/pull/201 From shade at openjdk.org Mon Jan 22 09:13:56 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 22 Jan 2024 09:13:56 GMT Subject: [jdk21u-dev] RFR: 8323243: JNI invocation of an abstract instance method corrupts the stack Message-ID: <6d968EH2Wyb3HOQXo8Z5p4gEALHZy76NZByepnTxxBM=.a7c4ac9b-e1b0-4c74-8976-abc2860019b9@github.com> Clean backport to fix the JNI corner case. Looks simple and safe. Additional testing: - [x] New regression test fails without the fix and passes with it - [ ] Linux AArch64 server fastdebug, `tier{1,2,3,4}` ------------- Commit messages: - Backport 71d9a83dece7eb4bdb6ffdd9caf14a1348045ce0 Changes: https://git.openjdk.org/jdk21u-dev/pull/202/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=202&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323243 Stats: 159 lines in 4 files changed: 159 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/202.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/202/head:pull/202 PR: https://git.openjdk.org/jdk21u-dev/pull/202 From ashi at openjdk.org Mon Jan 22 09:23:45 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 22 Jan 2024 09:23:45 GMT Subject: [jdk11u-dev] RFR: 8272552: mark hotspot runtime/cds tests which ignore external VM flags Message-ID: Backport of [JDK-8272335](https://bugs.openjdk.org/browse/JDK-8272335) - The original commit contains 6 files, well this PR only contains 4 of them, because the following 2 files do not exist - `VerifyWithDefaultArchive.java` does not exist in Java 11, it was added by [JDK-8264337](https://bugs.openjdk.org/browse/JDK-8264337) since Java 17 - `JCmdTestDynamicDump.java` does not exist in Java 11, it was added by [JDK-8265393](https://bugs.openjdk.org/browse/JDK-8265393) since Java 17 - So this is unclean backport Testing - Local: not aplicable - `no tests selected` - `MaxMetaspaceSize.java` - Test results: no tests selected - `SharedStrings.java` - Test results: no tests selected - `MoveJDKTest.java` - Test results: no tests selected - `ArchivedModuleWithCustomImageTest.java` - Test results: no tests selected - `test/hotspot/jtreg/runtime/SharedArchiveFile` folder - Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 989f39f8106a22498053a4ca5f2becf8df5f2420 Changes: https://git.openjdk.org/jdk11u-dev/pull/2468/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2468&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272552 Stats: 4 lines in 4 files changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2468.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2468/head:pull/2468 PR: https://git.openjdk.org/jdk11u-dev/pull/2468 From duke at openjdk.org Mon Jan 22 09:48:33 2024 From: duke at openjdk.org (sendaoYan) Date: Mon, 22 Jan 2024 09:48:33 GMT Subject: [jdk17u-dev] Withdrawn: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 11:12:51 GMT, sendaoYan wrote: > 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2138 From jdowland at openjdk.org Mon Jan 22 10:29:32 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Mon, 22 Jan 2024 10:29:32 GMT Subject: [jdk17u-dev] RFR: 8322321: Add man page doc for -XX:+VerifySharedSpaces In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:03:44 GMT, Jonathan Dowland wrote: > This is an unclean backport of a manpage fix, for Oracle parity. The conflict was trivial to resolve manually and was due to the troff source being updated post-17u for 8297164, which is unlikely to be backported itself. THe GHA test failure macos-x64 (hs/tier1 gc) is unrelated (gc/logging/TestMetaSpaceLog.java Error. Agent error: java.lang.Exception: Agent 7 timed out with a timeout of 480 seconds; check console log for any additional details). ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2098#issuecomment-1903686012 From mdoerr at openjdk.org Mon Jan 22 10:36:32 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 22 Jan 2024 10:36:32 GMT Subject: [jdk17u-dev] RFR: 8313206: PKCS11 tests silently skip execution In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 09:26:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. > > I had to do trivial adaptions: > > test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java > It was introduced by 8301154, a bigger bugfix in PKCS11. I don't want to backport this. > Patch omitted. > > test/jdk/sun/security/pkcs11/PKCS11Test.java > trivial resolve, Skipped whitespace fixes in code that was only introduced by "8301553: Support Password-Based Cryptography in SunPKCS11" Ok, you also skipped the move of `private static final SecureRandom srdm = new SecureRandom();` which is not in 17u. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2143#pullrequestreview-1836153905 From omikhaltcova at openjdk.org Mon Jan 22 10:40:37 2024 From: omikhaltcova at openjdk.org (Olga Mikhaltsova) Date: Mon, 22 Jan 2024 10:40:37 GMT Subject: [jdk21u-dev] Integrated: 8318158: RISC-V: implement roundD/roundF intrinsics In-Reply-To: References: Message-ID: <5n8UlXouX60pfJhYmh2Yg0I8dLCmJEurMedyxpka3V0=.0541d9b0-18be-4876-8f37-18307c59949c@github.com> On Fri, 12 Jan 2024 11:58:59 GMT, Olga Mikhaltsova wrote: > I would like to backport [JDK-8318158](https://bugs.openjdk.org/browse/JDK-8318158) to jdk21u in order to optimize performance in double/float rounding operations by means of intrinsics. > The patch applied cleanly. > Tested: tier1 tests passed. > > The benchmark shows the following performance improvement on the T-Head RVB-ICE board: > **Before** > > Benchmark (TESTSIZE) Mode Cnt Score Error Units > FpRoundingBenchmark.test_round_double 2048 thrpt 15 58.679 ? 0.965 ops/ms > FpRoundingBenchmark.test_round_float 2048 thrpt 15 49.252 ? 0.887 ops/ms > > **After** > > Benchmark (TESTSIZE) Mode Cnt Score Error Units > FpRoundingBenchmark.test_round_double 2048 thrpt 15 117.264 ? 1.254 ops/ms > FpRoundingBenchmark.test_round_float 2048 thrpt 15 119.752 ? 1.751 ops/ms This pull request has now been integrated. Changeset: ada400cf Author: Olga Mikhaltsova URL: https://git.openjdk.org/jdk21u-dev/commit/ada400cffe35140d62452e3899e5a04a40b737c8 Stats: 82 lines in 3 files changed: 82 ins; 0 del; 0 mod 8318158: RISC-V: implement roundD/roundF intrinsics Backport-of: 19147f326c6b0e78fe72f9a7e7100047f16a0921 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/161 From ashi at openjdk.org Mon Jan 22 10:53:47 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 22 Jan 2024 10:53:47 GMT Subject: [jdk11u-dev] RFR: 8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects" Message-ID: Backport of [JDK-8289764](https://bugs.openjdk.org/browse/JDK-8289764) The following files are manually merged, can be consider as clean - test/hotspot/jtreg/vmTestbase/gc/lock/jni/jnilock001/TestDescription.java - test/hotspot/jtreg/vmTestbase/gc/lock/jniref/jniglobalreflock01/TestDescription.java - test/hotspot/jtreg/vmTestbase/gc/lock/jniref/jnilocalreflock01/TestDescription.java - test/hotspot/jtreg/vmTestbase/gc/lock/jniref/jnireflock01/TestDescription.java - test/hotspot/jtreg/vmTestbase/gc/lock/jniref/jniweakglobalreflock01/TestDescription.java - test/hotspot/jtreg/vmTestbase/gc/lock/jvmti/alloc/jvmtialloclock01/TestDescription.java - test/hotspot/jtreg/vmTestbase/gc/lock/malloc/malloclock01/TestDescription.java - test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java - The `Copyright year` is manually merged, can be consider as clean ------------- Commit messages: - Backport 7b81a9c75d60f6eb2727515bacfffcf7cf15e128 Changes: https://git.openjdk.org/jdk11u-dev/pull/2469/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2469&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289764 Stats: 1367 lines in 50 files changed: 29 ins; 1300 del; 38 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2469.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2469/head:pull/2469 PR: https://git.openjdk.org/jdk11u-dev/pull/2469 From duke at openjdk.org Mon Jan 22 11:13:43 2024 From: duke at openjdk.org (sendaoYan) Date: Mon, 22 Jan 2024 11:13:43 GMT Subject: [jdk17u-dev] RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 Message-ID: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 ------------- Commit messages: - Backport 52814994efc4831fdbc1f796ed1db6ae88cb616c Changes: https://git.openjdk.org/jdk17u-dev/pull/2151/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2151&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316563 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2151.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2151/head:pull/2151 PR: https://git.openjdk.org/jdk17u-dev/pull/2151 From duke at openjdk.org Mon Jan 22 11:13:43 2024 From: duke at openjdk.org (sendaoYan) Date: Mon, 22 Jan 2024 11:13:43 GMT Subject: [jdk17u-dev] RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 In-Reply-To: References: Message-ID: On Mon, 22 Jan 2024 11:08:59 GMT, sendaoYan wrote: > 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/c3fcfe81-4ab2-4d54-b25e-9a5595ccde89) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2151#issuecomment-1903777193 From duke at openjdk.org Mon Jan 22 11:14:35 2024 From: duke at openjdk.org (sendaoYan) Date: Mon, 22 Jan 2024 11:14:35 GMT Subject: [jdk21u-dev] Withdrawn: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 12:16:59 GMT, sendaoYan wrote: > 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/192 From duke at openjdk.org Mon Jan 22 11:19:52 2024 From: duke at openjdk.org (sendaoYan) Date: Mon, 22 Jan 2024 11:19:52 GMT Subject: [jdk21u-dev] RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 Message-ID: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 ------------- Commit messages: - Backport 52814994efc4831fdbc1f796ed1db6ae88cb616c Changes: https://git.openjdk.org/jdk21u-dev/pull/204/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=204&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316563 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/204.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/204/head:pull/204 PR: https://git.openjdk.org/jdk21u-dev/pull/204 From duke at openjdk.org Mon Jan 22 11:19:53 2024 From: duke at openjdk.org (sendaoYan) Date: Mon, 22 Jan 2024 11:19:53 GMT Subject: [jdk21u-dev] RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 In-Reply-To: References: Message-ID: On Mon, 22 Jan 2024 11:14:08 GMT, sendaoYan wrote: > 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/37049ab1-bcd6-40e4-930e-83852e686e5b) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/204#issuecomment-1903785250 From luhenry at openjdk.org Mon Jan 22 11:50:43 2024 From: luhenry at openjdk.org (Ludovic Henry) Date: Mon, 22 Jan 2024 11:50:43 GMT Subject: [jdk17u-dev] RFR: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs' Message-ID: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs' ------------- Commit messages: - Backport 2f1c65486b1e584f9c4a2eb7af2414d032a02748 Changes: https://git.openjdk.org/jdk17u-dev/pull/2152/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2152&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307955 Stats: 24 lines in 1 file changed: 9 ins; 13 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2152.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2152/head:pull/2152 PR: https://git.openjdk.org/jdk17u-dev/pull/2152 From luhenry at openjdk.org Mon Jan 22 11:53:32 2024 From: luhenry at openjdk.org (Ludovic Henry) Date: Mon, 22 Jan 2024 11:53:32 GMT Subject: [jdk17u-dev] RFR: 8324234: Use reserved IP for java.net testing In-Reply-To: References: Message-ID: On Mon, 22 Jan 2024 08:38:14 GMT, Goetz Lindenmaier wrote: > Why don't you fix this in head? @GoeLin this test only exists on jdk17u, and the whole code was removed in https://github.com/openjdk/jdk/commit/2f3f3b618500b5f112fabca30d4c6780b2a8e723 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2149#issuecomment-1903842405 From mbaesken at openjdk.org Mon Jan 22 12:07:37 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 22 Jan 2024 12:07:37 GMT Subject: [jdk11u-dev] RFR: 8319124: Update XML Security for Java to 3.0.3 In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 16:43:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.23-oracle. > > Large parts applied clean, see first commit. > > I had to do the following mostly trivial resolves: > > src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/Init.java > A larger chunk did not apply, I could not see why so far. > > src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureBaseRSA.java > patching file src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRSAPSSSignatureMethod.java > patching file src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java > Trivial resolve of imports. > To make it compile I had to remove RSAPSSParameterSpec from the imports in two places. > > patching file test/jdk/javax/xml/crypto/dsig/GenerationTests.java > All failed to apply automatically because RSAPSS coding is missing in the context. > Also, the new tests don't work as "JDK-8172680: Support SHA-3 based Hmac algorithms" is not in 11. > > I kept the test coding to simplify future backports. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2465#pullrequestreview-1836313314 From mbaesken at openjdk.org Mon Jan 22 12:26:42 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 22 Jan 2024 12:26:42 GMT Subject: [jdk22u] RFR: 8318696: Do not use LFS64 symbols on Linux Message-ID: 8318696: Do not use LFS64 symbols on Linux ------------- Commit messages: - Backport f4d08ccf80812d4f26a148fac6bf99b96672a63f Changes: https://git.openjdk.org/jdk22u/pull/26/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=26&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318696 Stats: 26 lines in 5 files changed: 5 ins; 0 del; 21 mod Patch: https://git.openjdk.org/jdk22u/pull/26.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/26/head:pull/26 PR: https://git.openjdk.org/jdk22u/pull/26 From jdowland at openjdk.org Mon Jan 22 12:26:57 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Mon, 22 Jan 2024 12:26:57 GMT Subject: [jdk11u-dev] RFR: 8324307: hotspot fails to build with GCC 12 and newer (non-static data member initializers) Message-ID: <6SHv_m7FpCT-A2ZXiiWlFshlcMBuSze8LzwuC6fXz2U=.26be4f57-fee8-4f8d-a5cf-521117eeed26@github.com> ?a member initializers) The approach used here is to remove the initialisers, in common with what we did for jdk8u-dev. ------------- Commit messages: - 8324307: hotspot fails to build with GCC 12 and newer (non-static data member initializers) Changes: https://git.openjdk.org/jdk11u-dev/pull/2470/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2470&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324307 Stats: 8 lines in 2 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2470.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2470/head:pull/2470 PR: https://git.openjdk.org/jdk11u-dev/pull/2470 From rehn at openjdk.org Mon Jan 22 12:56:32 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Mon, 22 Jan 2024 12:56:32 GMT Subject: [jdk17u-dev] RFR: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs' In-Reply-To: References: Message-ID: On Mon, 22 Jan 2024 11:45:00 GMT, Ludovic Henry wrote: > 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs' Thanks! ------------- Marked as reviewed by rehn (Committer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2152#pullrequestreview-1836403130 From jdowland at openjdk.org Mon Jan 22 13:21:35 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Mon, 22 Jan 2024 13:21:35 GMT Subject: [jdk11u-dev] RFR: 8247818: GCC 10 warning stringop-overflow with symbol code In-Reply-To: <6JlJ7BurDIQJbpoSFOROAXZ9HVHdSTbkMYiiVdx0iI4=.4d9b9247-4aed-47fc-8c81-e07d267ccca3@github.com> References: <6JlJ7BurDIQJbpoSFOROAXZ9HVHdSTbkMYiiVdx0iI4=.4d9b9247-4aed-47fc-8c81-e07d267ccca3@github.com> Message-ID: <3KZK9zeJlG7yxCRAFux_IXssz1RQjz0nqsbIVLZ7UlE=.9bc514d4-fe78-44ed-bd77-1fd0834e2222@github.com> On Thu, 11 Jan 2024 11:10:56 GMT, Goetz Lindenmaier wrote: > what about follow up JDK_8249087? I think we need that, too. I think you are right: perhaps 8247818 in isolation merely promotes the bug from compile-time to run time! I've got a PR for that I'm about to raise. For 8247818, I don't hit the compiler error unless I first apply GitHub PR #2470 (8324307), to resolve earlier errors. They are otherwise unrelated. Would this be an appropriate place to use dependent PRs? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2451#issuecomment-1903990924 From mbaesken at openjdk.org Mon Jan 22 13:23:48 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 22 Jan 2024 13:23:48 GMT Subject: [jdk21u-dev] RFR: 8318696: Do not use LFS64 symbols on Linux Message-ID: Backport 8318696, os_linux.cpp missed 8314021 (os::Linux:sendfile) so one part of the change from jdk-dev was not needed in 21. Otherwise clean backport. ------------- Commit messages: - Backport f4d08ccf80812d4f26a148fac6bf99b96672a63f Changes: https://git.openjdk.org/jdk21u-dev/pull/206/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=206&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318696 Stats: 25 lines in 5 files changed: 5 ins; 0 del; 20 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/206.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/206/head:pull/206 PR: https://git.openjdk.org/jdk21u-dev/pull/206 From sgehwolf at openjdk.org Mon Jan 22 14:42:31 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 22 Jan 2024 14:42:31 GMT Subject: [jdk17u-dev] RFR: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'" In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 01:45:16 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [4d078930](https://github.com/openjdk/jdk21u/commit/4d078930eecfacb28a7c8324f233080eaf649334) from the [openjdk/jdk21u](https://git.openjdk.org/jdk21u) repository. > > The commit being backported was authored by Coleen Phillimore on 2 Oct 2023 and had no reviewers. > > The backport is primarily for 8u, where the VS2010 build seems to be broken because of the placing of the declarations of `low`, `high` and `index` in JDK-8314295; see https://github.com/gnu-andrew/jdk8u-dev/actions/runs/7549766959/job/20554342418. This is fixed by this private bug fix, JDK-8317331: `Solaris build failed with "declaration can not follow a statement (E_DECLARATION_IN_CODE)"`. However, it makes sense to have the code in sync everywhere and this change is already in 21u: https://github.com/openjdk/jdk21u/commit/4d078930eecfacb28a7c8324f233080eaf649334 > > ~~I don't know if the new approval commands will work with a private bug. I guess we will see.~~ It didn't, so we created a new bug. > > Backport was clean and built fine on GNU/Linux with GCC 12. > > Thanks! Seems fine. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2136#pullrequestreview-1836628601 From jdowland at openjdk.org Mon Jan 22 14:47:44 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Mon, 22 Jan 2024 14:47:44 GMT Subject: [jdk11u-dev] RFR: 8249087: Always initialize _body[0..1] in Symbol constructor Message-ID: This change is closely related to 8247818, which we want to backport as part of getting jdk11u-dev to build with GCC >= 12. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/2451 Commit messages: - 8249087: Always initialize _body[0..1] in Symbol constructor Changes: https://git.openjdk.org/jdk11u-dev/pull/2471/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2471&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8249087 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2471.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2471/head:pull/2471 PR: https://git.openjdk.org/jdk11u-dev/pull/2471 From lucy at openjdk.org Mon Jan 22 16:10:34 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Mon, 22 Jan 2024 16:10:34 GMT Subject: [jdk21u-dev] RFR: 8318696: Do not use LFS64 symbols on Linux In-Reply-To: References: Message-ID: On Mon, 22 Jan 2024 13:13:09 GMT, Matthias Baesken wrote: > Backport 8318696, os_linux.cpp missed 8314021 (os::Linux:sendfile) so one part of the change from jdk-dev was not needed in 21. Otherwise clean backport. Looks good. Good to ship after SAP-internal testing passed. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/206#pullrequestreview-1836833232 From goetz at openjdk.org Mon Jan 22 16:27:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 22 Jan 2024 16:27:42 GMT Subject: [jdk17u-dev] RFR: 8281585: Remove unused imports under test/lib and jtreg/gc Message-ID: I backport this for parity with 17.0.11-oracle. Some simple resolves were needed: test/hotspot/jtreg/gc/arguments/TestArrayAllocatorMallocLimit.java Copyright. test/hotspot/jtreg/gc/arguments/TestG1HeapRegionSize.java Resolved import. test/hotspot/jtreg/gc/arguments/TestG1RemSetFlags.java Not in 17. test/hotspot/jtreg/gc/arguments/TestVerifyBeforeAndAfterGCFlags.java Copyright and imports due to context. test/hotspot/jtreg/gc/g1/TestEvacuationFailure.java Test not in 17. test/hotspot/jtreg/gc/g1/TestSkipRebuildRemsetPhase.java Resulved imports due to differences in context. test/lib/jdk/test/lib/hprof/model/JavaValueArray.java Copyright ------------- Commit messages: - Backport 2604a88fbb6d0f9aec51c7d607ea275bc34a672c Changes: https://git.openjdk.org/jdk17u-dev/pull/2154/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2154&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8281585 Stats: 141 lines in 58 files changed: 0 ins; 86 del; 55 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2154.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2154/head:pull/2154 PR: https://git.openjdk.org/jdk17u-dev/pull/2154 From phh at openjdk.org Mon Jan 22 16:43:35 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 22 Jan 2024 16:43:35 GMT Subject: [jdk11u-dev] RFR: 8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes In-Reply-To: <9wEFl5sDvMps_5tCkCQwxelb6Zxel_te9GWc7y7oeK0=.1879da5b-8e2e-4e45-b93a-720dc677f30d@github.com> References: <9wEFl5sDvMps_5tCkCQwxelb6Zxel_te9GWc7y7oeK0=.1879da5b-8e2e-4e45-b93a-720dc677f30d@github.com> Message-ID: On Mon, 22 Jan 2024 08:30:31 GMT, Amos Shi wrote: > Backport of [JDK-8272335](https://bugs.openjdk.org/browse/JDK-8272335) > - The file `test/hotspot/jtreg/runtime/cds/appcds/MoveJDKTest.java` match to `test/hotspot/jtreg/runtime/appcds/MoveJDKTest.java` in Java 11 > - The `diff` file patched successfully, except the `Copyright year` line > - So this change can be considered as `Clean` although technically not clean > > > Testing > - Local: not aplicable - `no tests selected` > - Pipeline: > - Testing Machine: Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2467#pullrequestreview-1836900410 From andrew at openjdk.org Mon Jan 22 17:03:34 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 22 Jan 2024 17:03:34 GMT Subject: [jdk11u-dev] RFR: 8247818: GCC 10 warning stringop-overflow with symbol code In-Reply-To: <3KZK9zeJlG7yxCRAFux_IXssz1RQjz0nqsbIVLZ7UlE=.9bc514d4-fe78-44ed-bd77-1fd0834e2222@github.com> References: <6JlJ7BurDIQJbpoSFOROAXZ9HVHdSTbkMYiiVdx0iI4=.4d9b9247-4aed-47fc-8c81-e07d267ccca3@github.com> <3KZK9zeJlG7yxCRAFux_IXssz1RQjz0nqsbIVLZ7UlE=.9bc514d4-fe78-44ed-bd77-1fd0834e2222@github.com> Message-ID: On Mon, 22 Jan 2024 13:18:56 GMT, Jonathan Dowland wrote: > > what about follow up JDK_8249087? I think we need that, too. > > I think you are right: perhaps 8247818 in isolation merely promotes the bug from compile-time to run time! > > I've got a PR for that I'm about to raise. For 8247818, I don't hit the compiler error unless I first apply GitHub PR #2470 (8324307), to resolve earlier errors. They are otherwise unrelated. Would this be an appropriate place to use dependent PRs? I would only use dependent PRs if they are touching the same file and so need to be applied in order. Or, in other words, it's a rebasing headache you can likely avoid if they are related but the changes don't depend on being applied in a certain order. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2451#issuecomment-1904425519 From andrew at openjdk.org Mon Jan 22 17:12:32 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 22 Jan 2024 17:12:32 GMT Subject: [jdk11u-dev] RFR: 8247818: GCC 10 warning stringop-overflow with symbol code In-Reply-To: References: Message-ID: On Wed, 10 Jan 2024 13:12:49 GMT, Jonathan Dowland wrote: > 11u-dev is tricky to build with GCC 11 and newer. GCC 11 is the default version in current Debian stable (and likely derivatives e.g. Ubuntu, but I have not checked) as well as RHEL 9 (and derivatives, likewise unchecked), so I think it's worthwhile to improve that. > > This particular patch addresses one of the obstacles (a warning from GCC 10 onwards). It doesn't apply clean, but cherry-pick conflicts were trivial to resolve. It was backported from 16 to 15 and 13 and seems worthwhile for 11u. Changes are the same as 17u, but patch is unclean due to context differences and the changed signature of `byte_at_put`. Thanks for looking into this. I've had warnings as errors turned off for goodness knows how long, likely because of build failures like this. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2451#pullrequestreview-1836962501 From shade at openjdk.org Mon Jan 22 17:25:34 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 22 Jan 2024 17:25:34 GMT Subject: [jdk21u-dev] RFR: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize [v3] In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 03:04:39 GMT, yaqsun wrote: >> runtime/cds/appcds/TestZGCWithCDS.java#ZGenerational failed, we want to make the test pass. >> Patch can be applied cleanly. >> Low risk. >> And test have been locally verified to pass. > > yaqsun has updated the pull request incrementally with one additional commit since the last revision: > > del temporary file test.txt @yaqsun, I think you are ready to integrate. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/126#issuecomment-1904465092 From shade at openjdk.org Mon Jan 22 18:57:41 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 22 Jan 2024 18:57:41 GMT Subject: [jdk21u-dev] RFR: 8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468 Message-ID: <-boeJfKQlmYle9akahLVOX9pDmZZ8dZngmQiEK681Sg=.4835eebf-5dba-4bff-b57d-77076553bf06@github.com> Clean backport to fix a JDK 21 regression. The fix is trivial. Additional testing: - [x] Linux x86_64 server fastdebug, `tier{1,2,3}` - [ ] Linux AArch64 server fastdebug, `tier{1,2,3}` ------------- Commit messages: - Backport bde650f21e2fa2f7730d3f948105159762e4fdd0 Changes: https://git.openjdk.org/jdk21u-dev/pull/205/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=205&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322282 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/205.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/205/head:pull/205 PR: https://git.openjdk.org/jdk21u-dev/pull/205 From serb at openjdk.org Mon Jan 22 19:31:43 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 22 Jan 2024 19:31:43 GMT Subject: [jdk11u-dev] RFR: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions Message-ID: <6eWsNiIqvLPE-idVZdacSRS4_tTjdJV8TjlYOzlWAJ4=.7ddaa864-839d-467b-ac80-da8ed3f3f45e@github.com> Hi all, This pull request contains a backport of commit [f695ca58](https://github.com/openjdk/jdk/commit/f695ca588453265d6ad791c6a396197e8a53ba39) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Rajat Mahajan on 22 Dec 2023 and was reviewed by Alexey Ivanov and Alisen Chung. Thanks! ------------- Commit messages: - Backport f695ca588453265d6ad791c6a396197e8a53ba39 Changes: https://git.openjdk.org/jdk11u-dev/pull/2466/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2466&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321151 Stats: 54 lines in 1 file changed: 43 ins; 2 del; 9 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2466.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2466/head:pull/2466 PR: https://git.openjdk.org/jdk11u-dev/pull/2466 From duke at openjdk.org Mon Jan 22 19:36:34 2024 From: duke at openjdk.org (Terry Chow) Date: Mon, 22 Jan 2024 19:36:34 GMT Subject: [jdk11u-dev] RFR: 8308593: Add KEEPALIVE Extended Socket Options Support for Windows In-Reply-To: References: Message-ID: On Fri, 10 Nov 2023 20:04:31 GMT, Terry Chow wrote: > This is an unclean backport of [JDK-8308593](https://bugs.openjdk.org/browse/JDK-8308593), which provides support for the keepalive extended socket options on Windows. > > The following changes are the differences from the original patch in order to get this backport working for 11u: > > make/lib/Lib-jdk.net.gmk -- Updated this script to support building extnet for Windows. > > src/jdk.net/share/classes/jdk/net/ExtendedSocketOptions.java -- Added a case to support returning an instance of WindowsSocketOptions in PlatformSocketOptions. > > src/java.base/windows/classes/java/net/PlainSocketImpl.java -- The Windows PlainSocketImpl class will need to have similar setOption/getOption methods as the Unix PlainSocketImpl class to support setting these extended socket options for Windows. > > Backport passed against Tier 1 tests and was manually verified to be working on Windows. Let me know how I can progress this towards integration. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2278#issuecomment-1904672876 From shade at openjdk.org Mon Jan 22 19:44:59 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 22 Jan 2024 19:44:59 GMT Subject: [jdk17u-dev] RFR: 8323243: JNI invocation of an abstract instance method corrupts the stack Message-ID: Clean backport to fix the JNI corner case. Additional testing: - [x] New test fails without the fix, passes with it - [ ] Linux x86_64 server fastdebug, `tier{1,2,3,4}` ------------- Commit messages: - Backport 71d9a83dece7eb4bdb6ffdd9caf14a1348045ce0 Changes: https://git.openjdk.org/jdk17u-dev/pull/2155/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2155&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323243 Stats: 159 lines in 4 files changed: 159 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2155.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2155/head:pull/2155 PR: https://git.openjdk.org/jdk17u-dev/pull/2155 From goetz at openjdk.org Mon Jan 22 20:03:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 22 Jan 2024 20:03:43 GMT Subject: [jdk17u-dev] RFR: 8306014: Update javax.net.ssl TLS tests to use SSLContextTemplate or SSLEngineTemplate Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 705ad7d829dcbf8f5e2f098275d0856f6b86db2d Changes: https://git.openjdk.org/jdk17u-dev/pull/2156/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2156&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306014 Stats: 1002 lines in 6 files changed: 266 ins; 693 del; 43 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2156.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2156/head:pull/2156 PR: https://git.openjdk.org/jdk17u-dev/pull/2156 From goetz at openjdk.org Mon Jan 22 20:05:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 22 Jan 2024 20:05:46 GMT Subject: [jdk17u-dev] RFR: 8210410: Refactor java.util.Currency:i18n shell tests to plain java tests Message-ID: I backport this for parity with 17.0.11-oracle. I had to delete the file by hand becuase it differs slightly. Further I had to add FILE_SEPARATOR to jdk.test.lib.Utils.java. This miight be useful for other backports as well. ------------- Commit messages: - Backport 2584bf87aef66744a8e586805735cded0d2f98f1 Changes: https://git.openjdk.org/jdk17u-dev/pull/2157/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2157&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8210410 Stats: 306 lines in 3 files changed: 162 ins; 144 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2157.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2157/head:pull/2157 PR: https://git.openjdk.org/jdk17u-dev/pull/2157 From goetz at openjdk.org Mon Jan 22 20:27:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 22 Jan 2024 20:27:45 GMT Subject: [jdk11u-dev] RFR: 8244679: JVM/TI GetCurrentContendedMonitor/contmon001 failed due to "(IsSameObject#3) unexpected monitor object: 0x000000562336DBA8" Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport c5fe2c1fcb5b5cec0a3f53716c24b2778467900b Changes: https://git.openjdk.org/jdk11u-dev/pull/2472/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2472&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8244679 Stats: 36 lines in 2 files changed: 22 ins; 5 del; 9 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2472.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2472/head:pull/2472 PR: https://git.openjdk.org/jdk11u-dev/pull/2472 From dholmes at openjdk.org Mon Jan 22 23:00:51 2024 From: dholmes at openjdk.org (David Holmes) Date: Mon, 22 Jan 2024 23:00:51 GMT Subject: [jdk22u] RFR: 8318696: Do not use LFS64 symbols on Linux In-Reply-To: References: Message-ID: On Mon, 22 Jan 2024 12:20:33 GMT, Matthias Baesken wrote: > 8318696: Do not use LFS64 symbols on Linux Marked as reviewed by dholmes (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk22u/pull/26#pullrequestreview-1837544153 From ashi at openjdk.org Mon Jan 22 23:41:01 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 22 Jan 2024 23:41:01 GMT Subject: [jdk11u-dev] RFR: 8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects" [v2] In-Reply-To: References: Message-ID: > Backport of [JDK-8289764](https://bugs.openjdk.org/browse/JDK-8289764) > > The following files are manually merged, can be consider as clean > - test/hotspot/jtreg/vmTestbase/gc/lock/jni/jnilock001/TestDescription.java > - test/hotspot/jtreg/vmTestbase/gc/lock/jniref/jniglobalreflock01/TestDescription.java > - test/hotspot/jtreg/vmTestbase/gc/lock/jniref/jnilocalreflock01/TestDescription.java > - test/hotspot/jtreg/vmTestbase/gc/lock/jniref/jnireflock01/TestDescription.java > - test/hotspot/jtreg/vmTestbase/gc/lock/jniref/jniweakglobalreflock01/TestDescription.java > - test/hotspot/jtreg/vmTestbase/gc/lock/jvmti/alloc/jvmtialloclock01/TestDescription.java > - test/hotspot/jtreg/vmTestbase/gc/lock/malloc/malloclock01/TestDescription.java > - test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java - The `Copyright year` is manually merged, can be consider as clean > > Testing > - Local: > - Pipeline: All checks have passed > - Testing Machine: Amos Shi has updated the pull request incrementally with one additional commit since the last revision: 8289764: Change code as JDK 11 style ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2469/files - new: https://git.openjdk.org/jdk11u-dev/pull/2469/files/709fa19e..7780d8cb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2469&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2469&range=00-01 Stats: 17 lines in 9 files changed: 0 ins; 0 del; 17 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2469.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2469/head:pull/2469 PR: https://git.openjdk.org/jdk11u-dev/pull/2469 From robm at openjdk.org Tue Jan 23 02:06:51 2024 From: robm at openjdk.org (Rob McKenna) Date: Tue, 23 Jan 2024 02:06:51 GMT Subject: [jdk22u] Integrated: Merge jdk22:master Message-ID: merge ------------- Commit messages: - Merge - 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions - 8322790: RISC-V: Tune costs for shuffles with no conversion - 8318158: RISC-V: implement roundD/roundF intrinsics - 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform - 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled - 8323210: Update the usage of cmsFLAGS_COPY_ALPHA - 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18 - 8323331: fix typo hpage_pdm_size - 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination - ... and 12 more: https://git.openjdk.org/jdk22u/compare/23301d57...968d7573 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk22u/pull/27/files Stats: 224 lines in 20 files changed: 191 ins; 4 del; 29 mod Patch: https://git.openjdk.org/jdk22u/pull/27.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/27/head:pull/27 PR: https://git.openjdk.org/jdk22u/pull/27 From robm at openjdk.org Tue Jan 23 02:06:51 2024 From: robm at openjdk.org (Rob McKenna) Date: Tue, 23 Jan 2024 02:06:51 GMT Subject: [jdk22u] Integrated: Merge jdk22:master In-Reply-To: References: Message-ID: On Tue, 23 Jan 2024 01:58:35 GMT, Rob McKenna wrote: > merge This pull request has now been integrated. Changeset: e995a732 Author: Rob McKenna URL: https://git.openjdk.org/jdk22u/commit/e995a732ca85bfb3f3b89e65175c0b4d27e178a6 Stats: 6166 lines in 207 files changed: 4201 ins; 1142 del; 823 mod Merge ------------- PR: https://git.openjdk.org/jdk22u/pull/27 From andrewlu at openjdk.org Tue Jan 23 02:28:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 23 Jan 2024 02:28:40 GMT Subject: [jdk17u-dev] RFR: 8310238: [test bug] javax/swing/JTableHeader/6889007/bug6889007.java fails Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 2cf5c2f4b6cdb52a3560ab03d272f19f47b22b17 Changes: https://git.openjdk.org/jdk17u-dev/pull/2158/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2158&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310238 Stats: 24 lines in 1 file changed: 19 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2158.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2158/head:pull/2158 PR: https://git.openjdk.org/jdk17u-dev/pull/2158 From andrewlu at openjdk.org Tue Jan 23 02:38:41 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 23 Jan 2024 02:38:41 GMT Subject: [jdk11u-dev] RFR: 8310238: [test bug] javax/swing/JTableHeader/6889007/bug6889007.java fails Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport 2cf5c2f4b6cdb52a3560ab03d272f19f47b22b17 Changes: https://git.openjdk.org/jdk11u-dev/pull/2473/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2473&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310238 Stats: 24 lines in 1 file changed: 19 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2473.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2473/head:pull/2473 PR: https://git.openjdk.org/jdk11u-dev/pull/2473 From andrewlu at openjdk.org Tue Jan 23 05:36:47 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 23 Jan 2024 05:36:47 GMT Subject: [jdk21u-dev] RFR: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 00ef9f9c322dde236256953272d6906f6151635d Changes: https://git.openjdk.org/jdk21u-dev/pull/207/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=207&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316947 Stats: 132 lines in 1 file changed: 132 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/207.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/207/head:pull/207 PR: https://git.openjdk.org/jdk21u-dev/pull/207 From andrewlu at openjdk.org Tue Jan 23 05:38:43 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 23 Jan 2024 05:38:43 GMT Subject: [jdk17u-dev] RFR: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 00ef9f9c322dde236256953272d6906f6151635d Changes: https://git.openjdk.org/jdk17u-dev/pull/2159/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2159&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316947 Stats: 132 lines in 1 file changed: 132 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2159.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2159/head:pull/2159 PR: https://git.openjdk.org/jdk17u-dev/pull/2159 From andrewlu at openjdk.org Tue Jan 23 05:40:45 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 23 Jan 2024 05:40:45 GMT Subject: [jdk11u-dev] RFR: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly Message-ID: <5T_Ft6MXzDKbC0gwLX4gGPq0_F6b0gWAyx0bxc3uvg4=.62bb072a-fa4f-4e44-b466-3487780db656@github.com> I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport 00ef9f9c322dde236256953272d6906f6151635d Changes: https://git.openjdk.org/jdk11u-dev/pull/2474/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2474&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316947 Stats: 132 lines in 1 file changed: 132 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2474.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2474/head:pull/2474 PR: https://git.openjdk.org/jdk11u-dev/pull/2474 From ashi at openjdk.org Tue Jan 23 05:53:41 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 23 Jan 2024 05:53:41 GMT Subject: [jdk17u-dev] RFR: 8209595: MonitorVmStartTerminate.java timed out Message-ID: Backport of [JDK-8209595](https://bugs.openjdk.org/browse/JDK-8209595) Testing - Local: Test passed - `MonitorVmStartTerminate.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport a045258ae2eb02daa17a9a9799a666f42daa7e20 Changes: https://git.openjdk.org/jdk17u-dev/pull/2160/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2160&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8209595 Stats: 51 lines in 1 file changed: 33 ins; 10 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2160.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2160/head:pull/2160 PR: https://git.openjdk.org/jdk17u-dev/pull/2160 From ashi at openjdk.org Tue Jan 23 06:28:39 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 23 Jan 2024 06:28:39 GMT Subject: [jdk11u-dev] RFR: 8209595: MonitorVmStartTerminate.java timed out Message-ID: Backport of [JDK-8209595](https://bugs.openjdk.org/browse/JDK-8209595) Testing - Local: Test passed - `MonitorVmStartTerminate.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport a045258ae2eb02daa17a9a9799a666f42daa7e20 Changes: https://git.openjdk.org/jdk11u-dev/pull/2475/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2475&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8209595 Stats: 51 lines in 1 file changed: 33 ins; 10 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2475.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2475/head:pull/2475 PR: https://git.openjdk.org/jdk11u-dev/pull/2475 From ashi at openjdk.org Tue Jan 23 07:04:57 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 23 Jan 2024 07:04:57 GMT Subject: [jdk11u-dev] RFR: 8246222: Rename javac test T6395981.java to be more informative Message-ID: Backport of [JDK-8246222](https://bugs.openjdk.org/browse/JDK-8246222) - The only differences between current PR and the original commit is, we removed `RELEASE_12` to `RELEASE_16` - Because the original commit was on Java `16`, and current repo is Java `11` - So current PR is `unclean` - The following is the original PR diff part: it contains `RELEASE_12` to `RELEASE_16` - * @run main/fail T6395981 - * @run main/fail T6395981 RELEASE_3 RELEASE_5 RELEASE_6 - * @run main/fail T6395981 RELEASE_0 RELEASE_1 RELEASE_2 RELEASE_3 RELEASE_4 - * RELEASE_5 RELEASE_6 - * @run main T6395981 RELEASE_3 RELEASE_4 RELEASE_5 RELEASE_6 RELEASE_7 - * RELEASE_8 RELEASE_9 RELEASE_10 RELEASE_11 RELEASE_12 - * RELEASE_13 RELEASE_14 RELEASE_15 RELEASE_16 + * @run main/fail TestGetSourceVersions + * @run main/fail TestGetSourceVersions RELEASE_3 RELEASE_5 RELEASE_6 + * @run main/fail TestGetSourceVersions RELEASE_0 RELEASE_1 RELEASE_2 RELEASE_3 RELEASE_4 + * RELEASE_5 RELEASE_6 + * @run main TestGetSourceVersions RELEASE_3 RELEASE_4 RELEASE_5 RELEASE_6 RELEASE_7 + * RELEASE_8 RELEASE_9 RELEASE_10 RELEASE_11 RELEASE_12 + * RELEASE_13 RELEASE_14 RELEASE_15 RELEASE_16 Testing - Local: Test passed - `TestGetSourceVersions.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport be278bc56461c7c9b9e2d9a07e3c15280ab2af03 Changes: https://git.openjdk.org/jdk11u-dev/pull/2476/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2476&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8246222 Stats: 124 lines in 2 files changed: 63 ins; 61 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2476.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2476/head:pull/2476 PR: https://git.openjdk.org/jdk11u-dev/pull/2476 From ashi at openjdk.org Tue Jan 23 07:34:39 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 23 Jan 2024 07:34:39 GMT Subject: [jdk21u-dev] RFR: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 Message-ID: Backport of [JDK-8274122](https://bugs.openjdk.org/browse/JDK-8274122) Testing - Local: Test passed - MacOS - `SpecialTempFile.java`: Test results: passed: 1 - Windows 11 - `TODO` need to retest on a Windows 11 laptop for this PR - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 4a142c3b0831d60b3d5540f58973e8ad3d1304bf Changes: https://git.openjdk.org/jdk21u-dev/pull/208/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=208&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274122 Stats: 13 lines in 2 files changed: 6 ins; 2 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/208.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/208/head:pull/208 PR: https://git.openjdk.org/jdk21u-dev/pull/208 From andrewlu at openjdk.org Tue Jan 23 07:47:48 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 23 Jan 2024 07:47:48 GMT Subject: [jdk17u-dev] RFR: 8308245: Add -proc:full to describe current default annotation processing policy Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 42ecc8a37ffc7e4ad7beb49cac7d821c00a5568e Changes: https://git.openjdk.org/jdk17u-dev/pull/2161/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2161&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308245 Stats: 43 lines in 3 files changed: 41 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2161.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2161/head:pull/2161 PR: https://git.openjdk.org/jdk17u-dev/pull/2161 From andrewlu at openjdk.org Tue Jan 23 07:49:43 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 23 Jan 2024 07:49:43 GMT Subject: [jdk11u-dev] RFR: 8308245: Add -proc:full to describe current default annotation processing policy Message-ID: I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport 42ecc8a37ffc7e4ad7beb49cac7d821c00a5568e Changes: https://git.openjdk.org/jdk11u-dev/pull/2477/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2477&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308245 Stats: 43 lines in 3 files changed: 41 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2477.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2477/head:pull/2477 PR: https://git.openjdk.org/jdk11u-dev/pull/2477 From goetz at openjdk.org Tue Jan 23 07:49:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 23 Jan 2024 07:49:35 GMT Subject: [jdk17u-dev] RFR: 8322321: Add man page doc for -XX:+VerifySharedSpaces In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:03:44 GMT, Jonathan Dowland wrote: > This is an unclean backport of a manpage fix, for Oracle parity. The conflict was trivial to resolve manually and was due to the troff source being updated post-17u for 8297164, which is unlikely to be backported itself. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2098#issuecomment-1905465663 From goetz at openjdk.org Tue Jan 23 07:58:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 23 Jan 2024 07:58:33 GMT Subject: [jdk21u-dev] Integrated: 8312416: Tests in Locale should have more descriptive names In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 13:46:44 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: fae1a030 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/fae1a030731c3571aa6614e7a5f82443115b1752 Stats: 265 lines in 16 files changed: 93 ins; 138 del; 34 mod 8312416: Tests in Locale should have more descriptive names Backport-of: a9a3463afb33b9df4cbf64d1866255bff638824f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/197 From goetz at openjdk.org Tue Jan 23 08:02:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 23 Jan 2024 08:02:34 GMT Subject: [jdk21u-dev] Integrated: 8319213: Compatibility.java reads both stdout and stderr of JdkUtils In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 13:59:27 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: be8733b8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/be8733b8b600ff417eec6c550e649f8321828130 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8319213: Compatibility.java reads both stdout and stderr of JdkUtils Backport-of: 84f4f7477c4e1b7ecc4c7fead2ded21242efddd7 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/199 From luhenry at openjdk.org Tue Jan 23 08:02:35 2024 From: luhenry at openjdk.org (Ludovic Henry) Date: Tue, 23 Jan 2024 08:02:35 GMT Subject: [jdk17u-dev] Integrated: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs' In-Reply-To: References: Message-ID: On Mon, 22 Jan 2024 11:45:00 GMT, Ludovic Henry wrote: > 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs' This pull request has now been integrated. Changeset: 81624250 Author: Ludovic Henry Committer: Robbin Ehn URL: https://git.openjdk.org/jdk17u-dev/commit/81624250791b8cc3cb2f65003b68644306e4ac00 Stats: 24 lines in 1 file changed: 9 ins; 13 del; 2 mod 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs' Reviewed-by: rehn Backport-of: 2f1c65486b1e584f9c4a2eb7af2414d032a02748 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2152 From goetz at openjdk.org Tue Jan 23 08:08:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 23 Jan 2024 08:08:31 GMT Subject: [jdk21u-dev] Integrated: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 In-Reply-To: <844wt1xNgoJha8KJHdhmbp_LNBxDEcxsTTF2qbQk_SM=.9864660f-be80-43cc-965a-58113fa6ab7b@github.com> References: <844wt1xNgoJha8KJHdhmbp_LNBxDEcxsTTF2qbQk_SM=.9864660f-be80-43cc-965a-58113fa6ab7b@github.com> Message-ID: <5dSpaGt4c_Kaj4hEz--qgJYVjAKkafHdD8-wFy2lVgc=.48527e56-c0bd-40d5-9d7e-63d40c331451@github.com> On Fri, 19 Jan 2024 07:38:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.3-oracle. > > This is a composition of two clean backports. See also separate commits. Will mark as clean. This pull request has now been integrated. Changeset: 1f9b03e5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/1f9b03e597d87679964e8772c6bea538c74feb2c Stats: 44 lines in 5 files changed: 35 ins; 3 del; 6 mod 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 8319136: Skip pkcs11 tests on linux-aarch64 Backport-of: c2e77e2f17b624e750dea8fd51bbfde99596690e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/195 From mbaesken at openjdk.org Tue Jan 23 08:09:32 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 23 Jan 2024 08:09:32 GMT Subject: [jdk21u-dev] Integrated: 8318696: Do not use LFS64 symbols on Linux In-Reply-To: References: Message-ID: <0gWw5dB9y_hI5LmFNcB8YCeVDr0PUSxbIC5AN63j3ls=.a8dc9a9b-cb4d-4c1f-925a-88aa392c67a7@github.com> On Mon, 22 Jan 2024 13:13:09 GMT, Matthias Baesken wrote: > Backport 8318696, os_linux.cpp missed 8314021 (os::Linux:sendfile) so one part of the change from jdk-dev was not needed in 21. Otherwise clean backport. This pull request has now been integrated. Changeset: 2697a9d1 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/2697a9d1c288daaddae751a7e8a2d2239c5d884c Stats: 25 lines in 5 files changed: 5 ins; 0 del; 20 mod 8318696: Do not use LFS64 symbols on Linux Reviewed-by: lucy Backport-of: f4d08ccf80812d4f26a148fac6bf99b96672a63f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/206 From goetz at openjdk.org Tue Jan 23 08:09:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 23 Jan 2024 08:09:48 GMT Subject: [jdk21u-dev] RFR: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.3-oracle. > > I had to resolve the ProblemList. Probably clean anyways, else will mark as such. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into goetz_backport_8295343 - Backport c2e77e2f17b624e750dea8fd51bbfde99596690e ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/186/files - new: https://git.openjdk.org/jdk21u-dev/pull/186/files/09a322e0..ed9c3a8a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=186&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=186&range=00-01 Stats: 8335 lines in 140 files changed: 4605 ins; 2764 del; 966 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/186.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/186/head:pull/186 PR: https://git.openjdk.org/jdk21u-dev/pull/186 From ashi at openjdk.org Tue Jan 23 08:19:39 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 23 Jan 2024 08:19:39 GMT Subject: [jdk17u-dev] RFR: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out Message-ID: Backport of [JDK-8310807](https://bugs.openjdk.org/browse/JDK-8310807) Testing - Local: Test passed - MacOS - `Connect.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 570dffb104fc37f053fcdf38a24aa2cabdc921c0 Changes: https://git.openjdk.org/jdk17u-dev/pull/2162/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2162&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310807 Stats: 79 lines in 1 file changed: 43 ins; 0 del; 36 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2162.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2162/head:pull/2162 PR: https://git.openjdk.org/jdk17u-dev/pull/2162 From duke at openjdk.org Tue Jan 23 08:28:33 2024 From: duke at openjdk.org (yaqsun) Date: Tue, 23 Jan 2024 08:28:33 GMT Subject: [jdk21u-dev] Integrated: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 11:06:14 GMT, yaqsun wrote: > runtime/cds/appcds/TestZGCWithCDS.java#ZGenerational failed, we want to make the test pass. > Patch can be applied cleanly. > Low risk. > And test have been locally verified to pass. This pull request has now been integrated. Changeset: 80842442 Author: sunyaqi Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/80842442da4c116564f55000216645eda93a70d8 Stats: 40 lines in 6 files changed: 30 ins; 10 del; 0 mod 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize Backport-of: fe862639e7ce40f5adef0e482b1fb9c718e061a3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/126 From ashi at openjdk.org Tue Jan 23 08:28:41 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 23 Jan 2024 08:28:41 GMT Subject: [jdk11u-dev] RFR: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out Message-ID: Backport of [JDK-8310807](https://bugs.openjdk.org/browse/JDK-8310807) Testing - Local: Test passed - MacOS - `Connect.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 570dffb104fc37f053fcdf38a24aa2cabdc921c0 Changes: https://git.openjdk.org/jdk11u-dev/pull/2478/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2478&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310807 Stats: 79 lines in 1 file changed: 43 ins; 0 del; 36 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2478.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2478/head:pull/2478 PR: https://git.openjdk.org/jdk11u-dev/pull/2478 From shade at openjdk.org Tue Jan 23 08:29:36 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 23 Jan 2024 08:29:36 GMT Subject: [jdk21u-dev] RFR: 8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468 In-Reply-To: <-boeJfKQlmYle9akahLVOX9pDmZZ8dZngmQiEK681Sg=.4835eebf-5dba-4bff-b57d-77076553bf06@github.com> References: <-boeJfKQlmYle9akahLVOX9pDmZZ8dZngmQiEK681Sg=.4835eebf-5dba-4bff-b57d-77076553bf06@github.com> Message-ID: On Mon, 22 Jan 2024 12:34:23 GMT, Aleksey Shipilev wrote: > Clean backport to fix a JDK 21 regression. The fix is trivial. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `tier{1,2,3}` > - [x] Linux AArch64 server fastdebug, `tier{1,2,3}` Testing passes, push approval is granted. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/205#issuecomment-1905536537 From shade at openjdk.org Tue Jan 23 08:29:36 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 23 Jan 2024 08:29:36 GMT Subject: [jdk21u-dev] Integrated: 8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468 In-Reply-To: <-boeJfKQlmYle9akahLVOX9pDmZZ8dZngmQiEK681Sg=.4835eebf-5dba-4bff-b57d-77076553bf06@github.com> References: <-boeJfKQlmYle9akahLVOX9pDmZZ8dZngmQiEK681Sg=.4835eebf-5dba-4bff-b57d-77076553bf06@github.com> Message-ID: On Mon, 22 Jan 2024 12:34:23 GMT, Aleksey Shipilev wrote: > Clean backport to fix a JDK 21 regression. The fix is trivial. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `tier{1,2,3}` > - [x] Linux AArch64 server fastdebug, `tier{1,2,3}` This pull request has now been integrated. Changeset: d69a0978 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/d69a0978cc035a5d23dccf88fd0d2b02a6f5d769 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468 Backport-of: bde650f21e2fa2f7730d3f948105159762e4fdd0 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/205 From goetz at openjdk.org Tue Jan 23 08:32:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 23 Jan 2024 08:32:38 GMT Subject: [jdk17u-dev] RFR: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests In-Reply-To: References: Message-ID: On Sat, 6 Jan 2024 01:47:06 GMT, Elif Aslan wrote: > Clean backport of Enable parallelism in vmTestbase/nsk/stress/threads tests > > GHA Tested Hi @elifaslan1, why did you close this instead of integrating it? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2108#issuecomment-1905547406 From goetz at openjdk.org Tue Jan 23 08:35:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 23 Jan 2024 08:35:35 GMT Subject: [jdk17u-dev] Integrated: 8311581: Remove obsolete code and comments in TestLVT.java In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 09:05:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: e9ddb514 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/e9ddb5147c0616c93e2e9b881cd1a7767361e7e8 Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod 8311581: Remove obsolete code and comments in TestLVT.java Backport-of: 27de536b409aa80c8b8bb452160329be52814e0b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2142 From goetz at openjdk.org Tue Jan 23 08:37:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 23 Jan 2024 08:37:38 GMT Subject: [jdk17u-dev] Integrated: 8313206: PKCS11 tests silently skip execution In-Reply-To: References: Message-ID: <2XRcg5RDNVBG4Q88wRk5mlMjo4xYc2ftvAhAYUhm9Pw=.cd31ae8c-95ff-4721-b556-66bf8d92ccdc@github.com> On Fri, 19 Jan 2024 09:26:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. > > I had to do trivial adaptions: > > test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java > It was introduced by 8301154, a bigger bugfix in PKCS11. I don't want to backport this. > Patch omitted. > > test/jdk/sun/security/pkcs11/PKCS11Test.java > trivial resolve, Skipped whitespace fixes in code that was only introduced by "8301553: Support Password-Based Cryptography in SunPKCS11" This pull request has now been integrated. Changeset: 7c4aaec0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7c4aaec0dc74badb8363c10d2a10a29e85ceb246 Stats: 340 lines in 9 files changed: 159 ins; 85 del; 96 mod 8313206: PKCS11 tests silently skip execution Reviewed-by: mdoerr Backport-of: 515add88ed6c290ee90f3d6f522a22971e37a62c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2143 From goetz at openjdk.org Tue Jan 23 08:37:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 23 Jan 2024 08:37:38 GMT Subject: [jdk17u-dev] Integrated: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 09:27:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 391bd2db Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/391bd2db80155e4083ff03de51f9b63df7a58847 Stats: 57 lines in 1 file changed: 20 ins; 24 del; 13 mod 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout Backport-of: 8042a50b99a671390910afa5f816894f77255429 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2144 From shade at openjdk.org Tue Jan 23 08:41:36 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 23 Jan 2024 08:41:36 GMT Subject: [jdk21u-dev] RFR: 8323243: JNI invocation of an abstract instance method corrupts the stack In-Reply-To: <6d968EH2Wyb3HOQXo8Z5p4gEALHZy76NZByepnTxxBM=.a7c4ac9b-e1b0-4c74-8976-abc2860019b9@github.com> References: <6d968EH2Wyb3HOQXo8Z5p4gEALHZy76NZByepnTxxBM=.a7c4ac9b-e1b0-4c74-8976-abc2860019b9@github.com> Message-ID: On Mon, 22 Jan 2024 08:58:56 GMT, Aleksey Shipilev wrote: > Clean backport to fix the JNI corner case. Looks simple and safe. > > Additional testing: > - [x] New regression test fails without the fix and passes with it > - [x] Linux AArch64 server fastdebug, `tier{1,2,3,4}` Push approval granted. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/202#issuecomment-1905559793 From shade at openjdk.org Tue Jan 23 08:41:38 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 23 Jan 2024 08:41:38 GMT Subject: [jdk21u-dev] Integrated: 8323243: JNI invocation of an abstract instance method corrupts the stack In-Reply-To: <6d968EH2Wyb3HOQXo8Z5p4gEALHZy76NZByepnTxxBM=.a7c4ac9b-e1b0-4c74-8976-abc2860019b9@github.com> References: <6d968EH2Wyb3HOQXo8Z5p4gEALHZy76NZByepnTxxBM=.a7c4ac9b-e1b0-4c74-8976-abc2860019b9@github.com> Message-ID: On Mon, 22 Jan 2024 08:58:56 GMT, Aleksey Shipilev wrote: > Clean backport to fix the JNI corner case. Looks simple and safe. > > Additional testing: > - [x] New regression test fails without the fix and passes with it > - [x] Linux AArch64 server fastdebug, `tier{1,2,3,4}` This pull request has now been integrated. Changeset: ad2e1141 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/ad2e11417494cef94cbaa4cebca507aa03c47992 Stats: 159 lines in 4 files changed: 159 ins; 0 del; 0 mod 8323243: JNI invocation of an abstract instance method corrupts the stack Backport-of: 71d9a83dece7eb4bdb6ffdd9caf14a1348045ce0 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/202 From goetz at openjdk.org Tue Jan 23 08:43:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 23 Jan 2024 08:43:34 GMT Subject: [jdk17u-dev] Integrated: 8317039: Enable specifying the JDK used to run jtreg In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 08:27:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: b1864465 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/b186446511655b317e05c79aeb3cdd324e254cdc Stats: 44 lines in 5 files changed: 42 ins; 0 del; 2 mod 8317039: Enable specifying the JDK used to run jtreg 8317807: JAVA_FLAGS removed from jtreg running in JDK-8317039 Backport-of: 2545f55e509fdc3a2fa6e4dec33f1b4a20a8b679 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2141 From goetz at openjdk.org Tue Jan 23 08:43:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 23 Jan 2024 08:43:35 GMT Subject: [jdk17u-dev] Integrated: 8312428: PKCS11 tests fail with NSS 3.91 In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 10:12:38 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: b4f1deb5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/b4f1deb597baf96327f65a0aef52db2d257620ac Stats: 268 lines in 4 files changed: 153 ins; 60 del; 55 mod 8312428: PKCS11 tests fail with NSS 3.91 Backport-of: 1c598c2245c5c348e946f4d0df653daa6e42da94 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2145 From goetz at openjdk.org Tue Jan 23 08:45:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 23 Jan 2024 08:45:33 GMT Subject: [jdk17u-dev] Integrated: 8319213: Compatibility.java reads both stdout and stderr of JdkUtils In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 13:59:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 67aa1dea Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/67aa1dea033d099d7b62426e436e22325e69c88d Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8319213: Compatibility.java reads both stdout and stderr of JdkUtils Backport-of: 84f4f7477c4e1b7ecc4c7fead2ded21242efddd7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2146 From goetz at openjdk.org Tue Jan 23 08:48:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 23 Jan 2024 08:48:34 GMT Subject: [jdk17u-dev] Integrated: 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 14:07:44 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. > > Some tests are not in 17, skipped. > All the other are clean. > > Will mark as clean. This pull request has now been integrated. Changeset: 5b2aec66 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/5b2aec660ff68e15a31b6b48d567387ed363f2cd Stats: 34 lines in 34 files changed: 0 ins; 0 del; 34 mod 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal Backport-of: 6f263111a1812873291e91870e341ccce804d049 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2147 From ashi at openjdk.org Tue Jan 23 08:48:47 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 23 Jan 2024 08:48:47 GMT Subject: [jdk11u-dev] RFR: 8311081: KeytoolReaderP12Test.java fail on localized Windows platform Message-ID: <2zKE8K4PlQ97D3WBSSck_EBZfiI2ykafp-4zUI9PQF8=.f5dd5ce6-ca22-45ac-9092-5300d7d72e0e@github.com> Backport of [JDK-8311081](https://bugs.openjdk.org/browse/JDK-8311081) Testing - Local: Not applicable - jtreg message: Not a test or directory containing tests: `java/security/KeyStore/PKCS12/Utils.java` - Pipeline: - Testing Machine: ------------- Commit messages: - Backport b4b2fecb42d9f14d73e8d79a9e59dee4d697f9cf Changes: https://git.openjdk.org/jdk11u-dev/pull/2479/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2479&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311081 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2479.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2479/head:pull/2479 PR: https://git.openjdk.org/jdk11u-dev/pull/2479 From ashi at openjdk.org Tue Jan 23 08:48:54 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 23 Jan 2024 08:48:54 GMT Subject: [jdk17u-dev] RFR: 8311081: KeytoolReaderP12Test.java fail on localized Windows platform Message-ID: Backport of [JDK-8311081](https://bugs.openjdk.org/browse/JDK-8311081) Testing - Local: Not applicable - jtreg message: Not a test or directory containing tests: `java/security/KeyStore/PKCS12/Utils.java` - Pipeline: - Testing Machine: ------------- Commit messages: - Backport b4b2fecb42d9f14d73e8d79a9e59dee4d697f9cf Changes: https://git.openjdk.org/jdk17u-dev/pull/2163/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2163&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311081 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2163.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2163/head:pull/2163 PR: https://git.openjdk.org/jdk17u-dev/pull/2163 From mbaesken at openjdk.org Tue Jan 23 09:03:42 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 23 Jan 2024 09:03:42 GMT Subject: [jdk17u-dev] RFR: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp Message-ID: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp ------------- Commit messages: - Backport c4c76e2f34f7e709f8b3c960d8c796ff4e2dc4a5 Changes: https://git.openjdk.org/jdk17u-dev/pull/2164/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2164&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272811 Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2164.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2164/head:pull/2164 PR: https://git.openjdk.org/jdk17u-dev/pull/2164 From goetz at openjdk.org Tue Jan 23 09:06:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 23 Jan 2024 09:06:40 GMT Subject: [jdk11u-dev] Integrated: 8319124: Update XML Security for Java to 3.0.3 In-Reply-To: References: Message-ID: On Fri, 19 Jan 2024 16:43:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.23-oracle. > > Large parts applied clean, see first commit. > > I had to do the following mostly trivial resolves: > > src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/Init.java > A larger chunk did not apply, I could not see why so far. > > src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureBaseRSA.java > patching file src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRSAPSSSignatureMethod.java > patching file src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java > Trivial resolve of imports. > To make it compile I had to remove RSAPSSParameterSpec from the imports in two places. > > patching file test/jdk/javax/xml/crypto/dsig/GenerationTests.java > All failed to apply automatically because RSAPSS coding is missing in the context. > Also, the new tests don't work as "JDK-8172680: Support SHA-3 based Hmac algorithms" is not in 11. > > I kept the test coding to simplify future backports. This pull request has now been integrated. Changeset: cb3c6ca3 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/cb3c6ca3e7a560af2071c7ba865e19869e2c8f9b Stats: 1523 lines in 130 files changed: 1114 ins; 226 del; 183 mod 8319124: Update XML Security for Java to 3.0.3 Reviewed-by: mbaesken Backport-of: 6b5655a651a7c4418d0f4e19ce34b487e021910e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2465 From ashi at openjdk.org Tue Jan 23 09:13:48 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 23 Jan 2024 09:13:48 GMT Subject: [jdk21u-dev] RFR: 8315600: Open source few more headless Swing misc tests Message-ID: Backport of [JDK-8315600](https://bugs.openjdk.org/browse/JDK-8315600) Testing - Local: Test passed on MacOS M1 Laptop - bug4210354.java - Test results: passed: 1 - bug4706533.java - Test results: passed: 1 - bug4992178.java - Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport b05198a4f354934bc344fe9cbc19d98fd8bc3977 Changes: https://git.openjdk.org/jdk21u-dev/pull/209/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=209&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315600 Stats: 209 lines in 3 files changed: 209 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/209.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/209/head:pull/209 PR: https://git.openjdk.org/jdk21u-dev/pull/209 From jdowland at openjdk.org Tue Jan 23 09:18:38 2024 From: jdowland at openjdk.org (Jonathan Dowland) Date: Tue, 23 Jan 2024 09:18:38 GMT Subject: [jdk17u-dev] Integrated: 8322321: Add man page doc for -XX:+VerifySharedSpaces In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 10:03:44 GMT, Jonathan Dowland wrote: > This is an unclean backport of a manpage fix, for Oracle parity. The conflict was trivial to resolve manually and was due to the troff source being updated post-17u for 8297164, which is unlikely to be backported itself. This pull request has now been integrated. Changeset: 14259710 Author: Jonathan Dowland URL: https://git.openjdk.org/jdk17u-dev/commit/1425971033823f6d43197b27b6427b00d94fdd4f Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod 8322321: Add man page doc for -XX:+VerifySharedSpaces Reviewed-by: shade Backport-of: f7dc257a206d3104d6d24c2079ef1fe349368c49 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2098 From ashi at openjdk.org Tue Jan 23 09:20:54 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 23 Jan 2024 09:20:54 GMT Subject: [jdk11u-dev] RFR: 8315600: Open source few more headless Swing misc tests Message-ID: <8mMiRfWuYDWgukZSG8PY6z2lgXtBG1n_Sy-PExWpfdY=.101a971e-8f74-41d7-9b64-eb6ecdda84c8@github.com> Backport of [JDK-8315600](https://bugs.openjdk.org/browse/JDK-8315600) Testing - Local: Test passed on MacOS M1 Laptop - bug4210354.java - Test results: passed: 1 - bug4706533.java - Test results: passed: 1 - bug4992178.java - Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport b05198a4f354934bc344fe9cbc19d98fd8bc3977 Changes: https://git.openjdk.org/jdk11u-dev/pull/2480/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2480&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315600 Stats: 209 lines in 3 files changed: 209 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2480.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2480/head:pull/2480 PR: https://git.openjdk.org/jdk11u-dev/pull/2480 From ashi at openjdk.org Tue Jan 23 09:20:57 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 23 Jan 2024 09:20:57 GMT Subject: [jdk17u-dev] RFR: 8315600: Open source few more headless Swing misc tests Message-ID: Backport of [JDK-8315600](https://bugs.openjdk.org/browse/JDK-8315600) Testing - Local: Test passed on MacOS M1 Laptop - bug4210354.java - Test results: passed: 1 - bug4706533.java - Test results: passed: 1 - bug4992178.java - Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport b05198a4f354934bc344fe9cbc19d98fd8bc3977 Changes: https://git.openjdk.org/jdk17u-dev/pull/2165/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2165&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315600 Stats: 209 lines in 3 files changed: 209 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2165.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2165/head:pull/2165 PR: https://git.openjdk.org/jdk17u-dev/pull/2165 From ashi at openjdk.org Tue Jan 23 09:54:41 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 23 Jan 2024 09:54:41 GMT Subject: [jdk17u-dev] RFR: 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location Message-ID: Backport of [JDK-8315986](https://bugs.openjdk.org/browse/JDK-8315986) Testing - Local: Test passed on MacOS M1 Laptop - bug4654927.java - Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport e7486e8cfc9a3f5cbe3515c68e325a25863c162e Changes: https://git.openjdk.org/jdk17u-dev/pull/2166/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2166&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315986 Stats: 72 lines in 1 file changed: 22 ins; 30 del; 20 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2166.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2166/head:pull/2166 PR: https://git.openjdk.org/jdk17u-dev/pull/2166 From ashi at openjdk.org Tue Jan 23 09:54:54 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 23 Jan 2024 09:54:54 GMT Subject: [jdk11u-dev] RFR: 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location Message-ID: Backport of [JDK-8315986](https://bugs.openjdk.org/browse/JDK-8315986) Testing - Local: Test passed on MacOS M1 Laptop - bug4654927.java - Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport e7486e8cfc9a3f5cbe3515c68e325a25863c162e Changes: https://git.openjdk.org/jdk11u-dev/pull/2481/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2481&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315986 Stats: 72 lines in 1 file changed: 22 ins; 30 del; 20 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2481.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2481/head:pull/2481 PR: https://git.openjdk.org/jdk11u-dev/pull/2481 From shade at openjdk.org Tue Jan 23 10:06:53 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 23 Jan 2024 10:06:53 GMT Subject: [jdk22u] RFR: 8324050: Issue store-store barrier after re-materializing objects during deoptimization Message-ID: Clean backport to improve deopt reliability. Adds the barrier on uncommonly used path. The functional and performance risk is low. ------------- Commit messages: - Backport 52523d33dde797bf03b15a05bb227b19b22c06be Changes: https://git.openjdk.org/jdk22u/pull/28/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=28&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324050 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/28.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/28/head:pull/28 PR: https://git.openjdk.org/jdk22u/pull/28 From ashi at openjdk.org Tue Jan 23 10:09:56 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 23 Jan 2024 10:09:56 GMT Subject: [jdk17u-dev] RFR: 8316106: Open source few swing JInternalFrame and JMenuBar tests Message-ID: Backport of [JDK-8316106](https://bugs.openjdk.org/browse/JDK-8316106) Testing - Local: Test passed on MacOS M1 Laptop - bug4268949.java - Test results: passed: 1 - bug4309079.java - Test results: passed: 1 - bug4732229.java - Test results: passed: 1 - bug5009724.java - Test results: no tests selected - bug4191374.java - Test results: passed: 1 - Pipeline: