[jdk17u-dev] RFR: 8322968: [17u] Amend Atomics gtest with 1-byte tests
Fei Yang
fyang at openjdk.org
Thu Jan 4 02:52:25 UTC 2024
On Wed, 3 Jan 2024 18:00:29 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> [JDK-8316645](https://bugs.openjdk.org/browse/JDK-8316645) was backported to 17u without the relevant test additions, because the test file was missing. But now, after the series of atomic support backports, we have the test file, so we can now complete the backport with the test hunks.
>
> Compare 17u-dev version:
> https://github.com/openjdk/jdk17u-dev/commit/db83123c5cc054cee5663201ead92410e6487d81
>
> ...and the mainline:
> https://github.com/openjdk/jdk/commit/fb055e7e5300958b2a6a290aa6783e8ede929d9a
>
> This change adds the missing hunk from mainline change. It includes [JDK-8317335](https://bugs.openjdk.org/browse/JDK-8317335) fix as well.
>
> cc: @zifeihan, @RealFYang
>
> Additional testing:
> - [x] macos-aarch64-server-fastdebug, `Atomics` test still passes
Looks good. Thanks. Also performed `gtest:Atomic` on linux-riscv64 platform.
BTW: Maybe we should link https://bugs.openjdk.org/browse/JDK-8317335 with this PR as well?
-------------
Marked as reviewed by fyang (Reviewer).
PR Review: https://git.openjdk.org/jdk17u-dev/pull/2095#pullrequestreview-1803358363
More information about the jdk-updates-dev
mailing list