[jdk21u-dev] RFR: 8319124: Update XML Security for Java to 3.0.3

[Goetz Lindenmaier]

On Wed, 3 Jan 2024 17:02:54 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Hi Goetz , looks mostly good. But I am not sure about this change
> 
> src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignatureFactory.java
> 
> ```
>     } else if (algorithm.equals(DOMSignatureMethod.RSA_SHA3_224_MGF1)) {
>         return new DOMSignatureMethod.SHA3_224withRSAandMGF1(params);
>     } else if (algorithm.equals(DOMSignatureMethod.RSA_SHA3_256_MGF1)) {
>         return new DOMSignatureMethod.SHA3_256withRSAandMGF1(params);
>     } else if (algorithm.equals(DOMSignatureMethod.RSA_SHA3_384_MGF1)) {
>         return new DOMSignatureMethod.SHA3_384withRSAandMGF1(params);
>     } else if (algorithm.equals(DOMSignatureMethod.RSA_SHA3_512_MGF1)) {
>         return new DOMSignatureMethod.SHA3_512withRSAandMGF1(params);
> ```
> 
> here you reference new algorithms from higher jdk versions; should they really be present here in jdk21 ?

I left this in the code because the CSR says "but the underlying implementation code will be integrated for use via the XML signature implementation."  There is also code in DOMSignatureMethod.java mentioning the new algs.

But I am not sure this is the code that is meant by that note.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/94#issuecomment-1876991257