[jdk21u-dev] RFR: 8319124: Update XML Security for Java to 3.0.3 [v3]

[Matthias Baesken]

On Fri, 12 Jan 2024 09:05:37 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I backport this for parity with 21.0.3-oracle.
>> 
>> The patch applied clean (first commit).
>> 
>> I removed the strings from SignatureMethod.java as documented in the backport CSR.
>> I did not change DOMSignatureMethod.java.
>> 
>> I skipped the changes to GenerationTest.java. The test passes.
>> 
>> **Update**: 
>> I pushed a new commit that makes the four new test cases work.
>> As proposed in the CSR, I use the plain strings instead of the constants defined in SignaturMethod.
>
> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Make new test cases work anyways

Marked as reviewed by mbaesken (Reviewer).

> I use the plain strings instead of the constants defined in SignaturMethod.

Little typo, SignatureMethod .  Yes I think this is correct according to the CSR for older releases https://bugs.openjdk.org/browse/JDK-8321532 .

-------------

PR Review: https://git.openjdk.org/jdk21u-dev/pull/94#pullrequestreview-1818396941
PR Comment: https://git.openjdk.org/jdk21u-dev/pull/94#issuecomment-1889373892