[jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v5]

[Martin Balao]

On Tue, 16 Jan 2024 09:27:07 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Hi @GoeLin ,
>> 
>> I assume that in 21u you kept all the (implementation) code except for the public members. If so, I understand the motivations but personally prefer what you proposed for 17u in this PR. It makes the code more clear in terms of what is supported. For example, it would be misleading for someone who looks for "EdDSA" references in the code, finds many —even beyond defines— and assumes that it is supported. This is, of course, at the expense of higher chances of non-clean updates. We have taken this approach in other libraries before such as when we removed the implementation of DTLS in the 8u backport of the TLS engine.
>> 
>> Martin.-
>
> Hi @martinuy,
> are you fine with me driving [#2116](https://github.com/openjdk/jdk17u-dev/pull/2116) and similarly [#2455](https://github.com/openjdk/jdk11u-dev/pull/2455)  for 11?

Hi @GoeLin ,

I personally prefer the approach taken in PR #2006 (here), for the reasons in my [previous comment](https://github.com/openjdk/jdk17u-dev/pull/2006#issuecomment-1881457955). With that said, I see your motivation. I would be interested in hearing @jerboaa view on this issue.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2006#issuecomment-1894787300