[jdk17u-dev] RFR: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"

Andrew John Hughes andrew at openjdk.org
Fri Jan 19 01:10:40 UTC 2024


Hi all,

This pull request contains a backport of commit [4d078930](https://github.com/openjdk/jdk21u/commit/4d078930eecfacb28a7c8324f233080eaf649334) from the [openjdk/jdk21u](https://git.openjdk.org/jdk21u) repository.

The commit being backported was authored by Coleen Phillimore on 2 Oct 2023 and had no reviewers.

The backport is primarily for 8u, where the VS2010 build seems to be broken because of the placing of the declarations of `low`, `high` and `index` in JDK-8314295; see https://github.com/gnu-andrew/jdk8u-dev/actions/runs/7549766959/job/20554342418. This is fixed by this private bug fix, JDK-8317331: `Solaris build failed with "declaration can not follow a statement (E_DECLARATION_IN_CODE)"`. However, it makes sense to have the code in sync everywhere and this change is already in 21u: https://github.com/openjdk/jdk21u/commit/4d078930eecfacb28a7c8324f233080eaf649334

I don't know if the new approval commands will work with a private bug. I guess we will see.

Backport was clean and built fine on GNU/Linux with GCC 12.

Thanks!

-------------

Commit messages:
 - Backport 4d078930eecfacb28a7c8324f233080eaf649334

Changes: https://git.openjdk.org/jdk17u-dev/pull/2136/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2136&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8324184
  Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk17u-dev/pull/2136.diff
  Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2136/head:pull/2136

PR: https://git.openjdk.org/jdk17u-dev/pull/2136


More information about the jdk-updates-dev mailing list