[jdk17u-dev] RFR: 8313206: PKCS11 tests silently skip execution

Martin Doerr mdoerr at openjdk.org
Mon Jan 22 10:36:32 UTC 2024


On Fri, 19 Jan 2024 09:26:31 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I backport this for parity with 17.0.11-oracle.
> 
> I had to do trivial adaptions:
> 
> test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java
>   It was introduced by 8301154, a bigger bugfix in PKCS11. I don't want to backport this.
>   Patch omitted.
>   
> test/jdk/sun/security/pkcs11/PKCS11Test.java
>   trivial resolve, Skipped whitespace fixes in code that was only introduced by "8301553: Support Password-Based Cryptography in SunPKCS11"

Ok, you also skipped the move of `private static final SecureRandom srdm = new SecureRandom();` which is not in 17u. LGTM.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/2143#pullrequestreview-1836153905


More information about the jdk-updates-dev mailing list