[jdk11u-dev] RFR: 8247818: GCC 10 warning stringop-overflow with symbol code

[Andrew John Hughes]

On Mon, 22 Jan 2024 13:18:56 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

> > what about follow up JDK_8249087? I think we need that, too.
> 
> I think you are right: perhaps 8247818 in isolation merely promotes the bug from compile-time to run time!
> 
> I've got a PR for that I'm about to raise. For 8247818, I don't hit the compiler error unless I first apply GitHub PR #2470 (8324307), to resolve earlier errors. They are otherwise unrelated. Would this be an appropriate place to use dependent PRs?

I would only use dependent PRs if they are touching the same file and so need to be applied in order. Or, in other words, it's a rebasing headache you can likely avoid if they are related but the changes don't depend on being applied in a certain order.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2451#issuecomment-1904425519