[jdk21u-dev] RFR: 8322142: JFR: Periodic tasks aren't orphaned between recordings

[Severin Gehwolf]

On Thu, 25 Jan 2024 06:00:06 GMT, Anton Hägerstrand <duke at openjdk.org> wrote:

>> The fix request comment didn't mention it so I'm removing the approval label for now. Please re-apply once that's present/fixed.
>
> @jerboaa Thanks - I did run the tier1 suite locally before creating the PR. I also enabled GHA for the for the fork, but did that after creating the PR so I don't think that it automatically triggered - I now triggered a run which seems to have passed: https://github.com/antonha/jdk21u-dev/actions/runs/7646727789
> 
> I'm not that familiar with the test suite so I don't quite know which JFR tests there are, but I did now try running the `jdk/jfr` tests using `make run-test TEST=jdk/jfr` for `linux-x86_64-server-release` and `linux-x86_64-server-fastdebug` locally, both pass with the same message:
> 
> 
> ==============================
> Test summary
> ==============================
>    TEST                                              TOTAL  PASS  FAIL ERROR   
>    jtreg:test/jdk/jdk/jfr                              584   584     0     0   
> ==============================
> TEST SUCCESS
> 
> 
> Should I re-apply for approval now?

@antonha Thanks!

> Should I re-apply for approval now?

Yes. Mention the testing you've done in the approval comment.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/203#issuecomment-1909762604