[jdk17u-dev] RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address

[Jaikiran Pai]

On Mon, 29 Jan 2024 14:49:14 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Can I please get a review for this change which backports the fix that was done in https://bugs.openjdk.org/browse/JDK-8305906?
>> 
>> The fix in the source is a clean backport. However, the newly introduced test in mainline uses a test specific libraries which aren't the same in 17u. As a result, the tests `test/jdk/java/net/httpclient/http2/ConnectionReuseTest.java` had conflicts. I have manually updated relevant parts of that test to make it use the test libraries that are available and applicable in 17u. 
>> 
>> I have also verified that the test fails (as expected) if I undo the source change and passes when I re-introduce the source change. Additionally, I have run this test in our CI to verify that it passes.
>
> Hi @jaikiran, you might want to re-run the GHA tests.

Hello @GoeLin, I'm running some internal CI tests as well and I have a change in the works for (only) the test. I'll update this PR with that change soon and rerun the GitHub jobs as well.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2121#issuecomment-1914964011