[jdk11u-dev] RFR: 8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use" [v3]

[Matthias Baesken]

On Tue, 30 Jan 2024 09:58:07 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:

>> Tested it locally.
>
> Johannes Bechberger has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Update JdwpOnThrowTest.java
>  - Update Debuggee.java
>  - Update Debuggee.java

looks okay, still wondering a bit about the COPYRIGHT 2024 in Debugee.java, this is newer than 17u-dev ?

test/jdk/com/sun/jdi/lib/jdb/Debuggee.java line 2:

> 1: /*
> 2:  * Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.

I see no year change in the original commit  https://github.com/openjdk/jdk/commit/1a21c1a783d64ca0930c358c06a43975f96ffac6
so why here ?

test/jdk/com/sun/jdi/lib/jdb/Debuggee.java line 2:

> 1: /*
> 2:  * Copyright (c) 2018, 2024, Oracle and/or its affiliates. All rights reserved.

the jdk17u-dev change  (https://github.com/openjdk/jdk17u-dev/pull/1949/files)  has  Copyright (c) 2018, 2023,
so why 2024 at this place?

test/jdk/com/sun/jdi/lib/jdb/Debuggee.java line 236:

> 234:         }
> 235:     }
> 236: }

file ending issue ?  original commit does not have this ?

-------------

Marked as reviewed by mbaesken (Reviewer).

PR Review: https://git.openjdk.org/jdk11u-dev/pull/2453#pullrequestreview-1843323391
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2453#discussion_r1466140260
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2453#discussion_r1470965914
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2453#discussion_r1466142019