[jdk17u-dev] RFR: 8299635: Hotspot update for deprecated sprintf in Xcode 14

[George Adams]

On Thu, 4 Jul 2024 20:40:44 GMT, George Adams <gdams at openjdk.org> wrote:

> Changes to the patch:
> 
> The following files don't exist in jdk17u
> - `test/hotspot/jtreg/runtime/Thread/libAsyncExceptionOnMonitorEnter.cpp` (https://github.com/openjdk/jdk/commit/4e20a03786094f1eb0c662fe8f281295bf1bac83 JDK19+)
> - `test/hotspot/jtreg/serviceability/jvmti/events/ThreadEnd/threadend01/libthreadend01.cpp` (https://github.com/openjdk/jdk/commit/9583e3657e43cc1c6f2101a64534564db2a9bd84 JDK19+)
> - `test/hotspot/jtreg/serviceability/jvmti/events/ThreadStart/threadstart01/libthreadstart01.cpp` (https://github.com/openjdk/jdk/commit/9583e3657e43cc1c6f2101a64534564db2a9bd84 JDK19+)
> 
> The changes didn't apply to `src/hotspot/share/opto/node.cpp` as https://github.com/openjdk/jdk/commit/33ed0365c3ed182a9d063e1701fe69bfb72dfa2e is JDK20+
> 
> The changes didn't apply to `src/hotspot/share/utilities/globalDefinitions.hpp` as https://github.com/openjdk/jdk/commit/04f02ac6b2ce496b86642987bb7e25d21b52a5b6 is JDK19+

test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/functions/rawmonitor/rawmonitor.cpp line 2:

> 1: /*
> 2: s

this feels like an accidental `s` added to the comment but it's the same in openjdk/jdk https://github.com/openjdk/jdk/blob/4ec1ae109710aa150e27acf5706475d335c4655c/test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/functions/rawmonitor/rawmonitor.cpp#L1-L5 so needs fixing there

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2663#discussion_r1666506381