[jdk17u-dev] RFR: 8299378: sprintf is deprecated in Xcode 14 [v3]
Andrew John Hughes
andrew at openjdk.org
Fri Jul 5 19:02:34 UTC 2024
On Fri, 5 Jul 2024 07:42:47 GMT, George Adams <gdams at openjdk.org> wrote:
>> Backport applies cleanly except for the missing `test/hotspot/gtest/utilities/test_unsigned5.cpp` in JDK17u.
>>
>> I had to manually add the `runtime/os.hpp` import which was added as part of https://github.com/openjdk/jdk/commit/df6cf1e41d0fc2dd5f5c094f66c7c8969cf5548d
>
> George Adams has updated the pull request incrementally with one additional commit since the last revision:
>
> include runtime/os.hpp
Backport looks good to me too. No issue with adding imports as needed rather than backporting where they were added in a later JDK version.
-------------
Marked as reviewed by andrew (Reviewer).
PR Review: https://git.openjdk.org/jdk17u-dev/pull/2661#pullrequestreview-2161145226
More information about the jdk-updates-dev
mailing list