[jdk17u-dev] RFR: 8299635: Hotspot update for deprecated sprintf in Xcode 14

[Andrew John Hughes]

On Thu, 4 Jul 2024 20:40:44 GMT, George Adams <gdams at openjdk.org> wrote:

> Changes to the patch:
> 
> The following files don't exist in jdk17u
> - `test/hotspot/jtreg/runtime/Thread/libAsyncExceptionOnMonitorEnter.cpp` (https://github.com/openjdk/jdk/commit/4e20a03786094f1eb0c662fe8f281295bf1bac83 JDK19+)
> - `test/hotspot/jtreg/serviceability/jvmti/events/ThreadEnd/threadend01/libthreadend01.cpp` (https://github.com/openjdk/jdk/commit/9583e3657e43cc1c6f2101a64534564db2a9bd84 JDK19+)
> - `test/hotspot/jtreg/serviceability/jvmti/events/ThreadStart/threadstart01/libthreadstart01.cpp` (https://github.com/openjdk/jdk/commit/9583e3657e43cc1c6f2101a64534564db2a9bd84 JDK19+)
> 
> The changes didn't apply to `src/hotspot/share/opto/node.cpp` as https://github.com/openjdk/jdk/commit/33ed0365c3ed182a9d063e1701fe69bfb72dfa2e is JDK20+
> 
> The changes didn't apply to `src/hotspot/share/utilities/globalDefinitions.hpp` as https://github.com/openjdk/jdk/commit/04f02ac6b2ce496b86642987bb7e25d21b52a5b6 is JDK19+

Backport looks good. The omissions are actually a good example of how more instance of `sprintf` have been creeping in since JDK 17. The Mac build failures should now keep more from happening.

* `test/hotspot/jtreg/runtime/Thread/libAsyncExceptionOnMonitorEnter.cpp` is from 
[JDK-8283044](https://bugs.openjdk.org/browse/JDK-8283044) so wouldn't expect that to ever appear in 17
* `test/hotspot/jtreg/serviceability/jvmti/events/ThreadEnd/threadend01/libthreadend01.cpp` and test/hotspot/jtreg/serviceability/jvmti/events/ThreadStart/threadstart01/libthreadstart01.cpp` are both from the Virtual Threads JEP ([JDK-8284161](https://bugs.openjdk.org/browse/JDK-8284161)) so definitely wouldn't expect a backport
* The `node.cpp` changes are from a dumping enhancement ([JDK-8283775](https://bugs.openjdk.org/browse/JDK-8283775)) so again no backport exported
* The `globalDefinitions.hpp` change is from a fairly controversial adjustment to block the use of the "raw" variants over the `os::` versions, and definitely shouldn't be backported ([JDK-8214976](https://bugs.openjdk.org/browse/JDK-8214976))

TL;DR: I agree with your omissions.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/2663#pullrequestreview-2161173175