[jdk17u-dev] RFR: 8299254: Support dealing with standard assert macro

[George Adams]

On Mon, 8 Jul 2024 14:52:26 GMT, George Adams <gdams at openjdk.org> wrote:

> Not a clean backport as there were whitespace conflicts and non existent `test/hotspot/gtest/code/test_codestrings.cpp` file to be deleted.
> 
> GHA tested.
> Tier1/tier2 tests passed on linux

> test/hotspot/gtest/unittest.hpp why did you remove // A work around for GCC math header bug leaving isfinite() undefined, // see: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=14608 #include "utilities/globalDefinitions.hpp"
> 
> I do not really see what this has to do with the attention of 8299254. And gtest_exit_from_child_vm was added in the same file - is there some good reason for this ? Do not see in the original commit [openjdk/jdk at 3e2314d](https://github.com/openjdk/jdk/commit/3e2314d08218dc8a4f4fc61bd4e1d5e58a0129c7)

good spot! thanks @MBaesken, I've fixed that now

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2689#issuecomment-2214443958