[jdk17u-dev] RFR: 8300806: Update googletest to v1.13.0 [v2]

Severin Gehwolf sgehwolf at openjdk.org
Tue Jul 9 10:24:48 UTC 2024


On Tue, 9 Jul 2024 08:27:04 GMT, George Adams <gdams at openjdk.org> wrote:

>> Prerequisite to bumping to xcode 14+. This change applies cleanly other than the fact that the JTREG version is different in JDK17u
>
> George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Merge remote-tracking branch 'upstream/master' into gtest
>  - Backport ccf2f5837b31cddd24ec81f7f67107d9fc03c294
>  - Backport 3e2314d08218dc8a4f4fc61bd4e1d5e58a0129c7

Looks OK to me. One minor nit. I've also ran `gtests:all` on Linux x86_64 and the results are a pass:


==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   gtest:all/server                                    901   901     0     0   
==============================
TEST SUCCESS

make/autoconf/lib-tests.m4 line 30:

> 28: ################################################################################
> 29: 
> 30: # Minimum supported version

The original change has:

Suggestion:

# Minimum supported versions

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/2667#pullrequestreview-2165769044
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2667#discussion_r1670189181


More information about the jdk-updates-dev mailing list