[jdk17u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions

[Zdenek Zambersky]

On Tue, 9 Jul 2024 14:32:59 GMT, George Adams <gdams at openjdk.org> wrote:

>>> > For 11u I don't think we can do the google test upgrade since that would need all the type trait fixes (all the linked issues in [JDK-8299386](https://bugs.openjdk.org/browse/JDK-8299386). We will have to find a more minimal solution there.
>>> 
>>> We won't need to do that for 11u as https://bugs.openjdk.org/browse/JDK-8222414 is 13+. It should just be a case of backporting the appropriate `sprint` removals.
>>> 
>>> > Yes, that sounds about right. That's enough change as it is. We need the lowest risk solution for that one, which means the fewest amount of changes/backports. On the plus side, gtest isn't needed for JDK 8 since it only got introduced in JDK 9 with: https://openjdk.org/jeps/281
>>> 
>>> I did have a go at building 8u with Xcode 13 on macos-12 but wasn't successful, I'll do some digging and see what needs to be backported
>> 
>> I have also done some experiments with jdk8 and I was able to pass builds on `macos-12` + `Xcode 13.1` in [GHA](https://github.com/zzambers/jdk8u-dev/actions/runs/9857418127/job/27216478718). 
>> At first, I saw this build failure on macos-12:
>> 
>> ...
>> ## Starting jaxp
>> Compiling 1870 files for BUILD_JAXP
>> /usr/bin/awk: towc: multibyte conversion failure on: '�vard Wigtil)'
>> Updating jaxp/dist/lib/src.zip
>> 
>>  input record number 22, file 
>>  source line number 1
>> gmake[1]: *** [BuildJaxp.gmk:58: /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/macos-x64/jaxp/classes/com/sun/org/apache/xml/internal/serializer/Encodings.properties] Error 2
>> gmake[1]: *** Waiting for unfinished jobs....
>> ...
>> 
>> However I was able to fix this by installing gawk.
>
>> > > For 11u I don't think we can do the google test upgrade since that would need all the type trait fixes (all the linked issues in [JDK-8299386](https://bugs.openjdk.org/browse/JDK-8299386). We will have to find a more minimal solution there.
>> > 
>> > 
>> > We won't need to do that for 11u as https://bugs.openjdk.org/browse/JDK-8222414 is 13+. It should just be a case of backporting the appropriate `sprint` removals.
>> > > Yes, that sounds about right. That's enough change as it is. We need the lowest risk solution for that one, which means the fewest amount of changes/backports. On the plus side, gtest isn't needed for JDK 8 since it only got introduced in JDK 9 with: https://openjdk.org/jeps/281
>> > 
>> > 
>> > I did have a go at building 8u with Xcode 13 on macos-12 but wasn't successful, I'll do some digging and see what needs to be backported
>> 
>> I have also done some experiments with jdk8 and I was able to pass builds on `macos-12` + `Xcode 13.1` in [GHA](https://github.com/zzambers/jdk8u-dev/actions/runs/9857418127/job/27216478718). At first, I saw this build failure on macos-12:
>> 
>> ```
>> ...
>> ## Starting jaxp
>> Compiling 1870 files for BUILD_JAXP
>> /usr/bin/awk: towc: multibyte conversion failure on: '�vard Wigtil)'
>> Updating jaxp/dist/lib/src.zip
>> 
>>  input record number 22, file 
>>  source line number 1
>> gmake[1]: *** [BuildJaxp.gmk:58: /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/macos-x64/jaxp/classes/com/sun/org/apache/xml/internal/serializer/Encodings.properties] Error 2
>> gmake[1]: *** Waiting for unfinished jobs....
>> ...
>> ```
>> 
>> However I was able to fix this by installing gawk.
> 
> Interesting, you seem to have got further than I did, would you raise a PR so I can take a look @zzambers

@gdams Sure.

Actually, turned out, I was even able build jdk8 on macos-13 and Xcode 14.3.1, so I created it as backport of this issue.

PR (with details): https://github.com/openjdk/jdk8u-dev/pull/544

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2206#issuecomment-2217964354