[jdk17u-dev] RFR: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651 [v5]
Christoph Langer
clanger at openjdk.org
Fri Jul 19 05:56:41 UTC 2024
On Fri, 12 Jul 2024 08:47:27 GMT, Suchismith Roy <sroy at openjdk.org> wrote:
>> Hi all,
>>
>> This pull request contains a backport of commit [c86bad51](https://github.com/openjdk/jdk21u/commit/c86bad51a88b867de3cd0b1a50bf544c2111755f) from the [openjdk/jdk21u](https://git.openjdk.org/jdk21u) repository.
>>
>> The commit being backported was authored by Christoph Langer on 21 Sep 2023 and was reviewed by Matthias Baesken.
>>
>> Thanks!
>
> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
>
> Update ProblemList.txt
I have a few change requests.
test/jdk/ProblemList.txt line 599:
> 597:
> 598: java/nio/channels/DatagramChannel/Unref.java 8233437 generic-all
> 599:
Please keep this empy line.
test/jdk/ProblemList.txt line 601:
> 599: java/net/MulticastSocket/Promiscuous.java 8308807 aix-ppc64
> 600: java/net/MulticastSocket/SetGetNetworkInterfaceTest.java 8308807 aix-ppc64
> 601: java/net/MulticastSocket/SetOutgoingIf.java 8308807 aix-ppc64
Can you please order the test exclusions like in the head commit? That is, start with java/net/DatagramSocket exclusions. Then java/net/MulticastSocket, then java/net/ServerSocket.
Please also merge the entries for java/net/MulticastSocket/SetGetNetworkInterfaceTest.java.
test/jdk/ProblemList.txt line 610:
> 608: java/nio/channels/DatagramChannel/Unref.java 8233437 generic-all
> 609: java/nio/channels/AsynchronousSocketChannel/StressLoopback.java 8211851 aix-ppc64
> 610: java/nio/channels/DatagramChannel/AdaptorMulticasting.java 8308807 aix-ppc64
Please move these lines for the new exclusions to line 608, that is before java/nio/channels/DatagramChannel/Unref.java
-------------
Changes requested by clanger (Reviewer).
PR Review: https://git.openjdk.org/jdk17u-dev/pull/2619#pullrequestreview-2187365067
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2619#discussion_r1683829491
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2619#discussion_r1683828197
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2619#discussion_r1683829391
More information about the jdk-updates-dev
mailing list