[jdk17u-dev] RFR: 8318696: Do not use LFS64 symbols on Linux [v2]
Andrew John Hughes
andrew at openjdk.org
Fri Jul 26 01:19:43 UTC 2024
On Thu, 25 Jul 2024 13:35:14 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Backport 8318696 from jdk21u-dev
>
> Matthias Baesken has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>
> - Merge branch 'master' into backport-MBaesken-2697a9d1
> - Backport 2697a9d1c288daaddae751a7e8a2d2239c5d884c
Thanks for re-opening this.
Copyright header adaptations look fine. `os::available` was removed by [JDK-8285307](https://bugs.openjdk.org/browse/JDK-8285307) in later JDKs, which is why it isn't in the original patch and needs to be fixed in the backport.
The only change I'm curious about is in `os::current_file_offset` & `os::seek_to_file_offset` as they retain `off64_t` casts. The 21u version uses `off_t`. Was this deliberate or just missed?
Also, I presume we'll also need [JDK-8324753](https://bugs.openjdk.org/browse/JDK-8324753) for AIX as a follow-up?
-------------
PR Review: https://git.openjdk.org/jdk17u-dev/pull/2173#pullrequestreview-2200713263
PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2173#issuecomment-2251774389
More information about the jdk-updates-dev
mailing list