[jdk21u-dev] RFR: 8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native

Matthias Baesken mbaesken at openjdk.org
Mon Jul 29 17:59:39 UTC 2024


On Wed, 24 Jul 2024 09:34:23 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> Test `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java` invoke `CreationTimeHelper` in [CreationTime.java](https://github.com/openjdk/jdk21u-dev/blob/master/test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#L109), and `CreationTimeHelper` invoke native function. So test `test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java` should set as `/native`.
> In the [PR](https://github.com/openjdk/jdk21u/pull/282) of backport [JDK-8316304](https://bugs.openjdk.org/browse/JDK-8316304) to jdk21u-dev, this test has been rewritten to use JNI instead so as to avoid using `Linker API`, thus this is specific to jdk21u-dev and jdk17u-dev.
> Trivial fix, the change has been verified, no risk.

Marked as reviewed by mbaesken (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk21u-dev/pull/869#pullrequestreview-2205638119


More information about the jdk-updates-dev mailing list