[jdk17u-dev] RFR: 8329995: Restricted access to `/proc` can cause JFR initialization to crash [v2]

Aleksey Shipilev shade at openjdk.org
Wed Jun 5 13:25:59 UTC 2024


On Wed, 5 Jun 2024 13:16:12 GMT, Neethu Prasad <duke at openjdk.org> wrote:

>> Backport of JDK-8329995
>> 
>> The call to os::opendir("/proc") may return nulltptr if the /proc is not accessible due to restrictions placed by the SELinux. In that case the ProcessIterator will SIGSEG because it assumes the _dir, which is the variable storing the result of the os::opendir("/proc") call to be non-null.
>> 
>> The patch is missing regression test because it is very hard to simulate /proc not being accessible to the test process.
>> 
>> **Testing**
>> All jdk_jfr and hotspot_gc tests passed.
>
> Neethu Prasad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8329995: Address PR feedback to remove extra ; and use NULL instead of nullptr

Marked as reviewed by shade (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk17u-dev/pull/2516#pullrequestreview-2099186984


More information about the jdk-updates-dev mailing list