[jdk17u-dev] RFR: 8303942: os::write should write completely [v3]

Elif Aslan duke at openjdk.org
Wed Jun 5 16:27:04 UTC 2024


On Wed, 5 Jun 2024 15:42:19 GMT, Elif Aslan <duke at openjdk.org> wrote:

>> This is not a clean backport. There were multiple merge conflicts related to undefined parameters and existing methods. This backport is required to address a crash observed in Amazon production. Please refer to the related [PR](https://github.com/openjdk/jdk17u-dev/pull/2281), which has already been merged.
>> 
>> 
>> In addition to GHA Tier 1, runtime hotspot, JFR, and hotspot GC tests have been run on macOS.
>> 
>> 
>>    TEST                                              TOTAL  PASS  FAIL ERROR
>>    jtreg:test/hotspot/jtreg:hotspot_runtime            880   880     0     0
>> ==============================
>> TEST SUCCESS
>> 
>> Finished building target 'test' in configuration 'macosx-x86_64-server-release'
>> 
>> Additinonally, added clean backport of [JDK-8316468] (https://github.com/openjdk/jdk/commit/7ce5bd159024e70f5a997c47ed2ce962d6e6091b)
>> 
>> After new commit reran runtime hotspot tests and they all passed
>
> Elif Aslan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

Thanks Aleksey, it is much cleaner with [this](https://github.com/openjdk/jdk/commit/4ff6720573f9b55eb397d1aac9b398228faf2ceb) commit and there was only 3 conflicted files. First I applied the commit that you referred , after that I applied the last 2 commits.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2490#issuecomment-2150475051


More information about the jdk-updates-dev mailing list