[jdk21u-dev] RFR: 8330027: Identity hashes of archived objects must be based on a reproducible random seed [v3]

Thomas Stuefe stuefe at openjdk.org
Sun Jun 9 06:21:44 UTC 2024


> This fixes an issue with CDS archive reproducibility that can happen under rare circumstances. See original JBS issue for details.
> 
> I had to manually resolve the hunk in src/hotspot/share/cds/heapShared.cpp because both
> 
>     8251330: Reorder CDS archived heap to speed up relocation
>     8329431: Improve speed of writing CDS heap objects
>     were missing.
> 
> I also had to change `CDSConfig::is_dumping_static_archive()` - which only exists in JDK 22 and later - to the technically equal `DumpSharedSpaces`.

Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'openjdk:master' into backport-tstuefe-9f43ce5a
 - Update heapShared.cpp
 - 8330027: Identity hashes of archived objects must be based on a reproducible random seed
   
   Reviewed-by: ccheung, iklam

-------------

Changes:
  - all: https://git.openjdk.org/jdk21u-dev/pull/562/files
  - new: https://git.openjdk.org/jdk21u-dev/pull/562/files/a2f6ffc5..daf07a8d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=562&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=562&range=01-02

  Stats: 8530 lines in 388 files changed: 5128 ins; 1534 del; 1868 mod
  Patch: https://git.openjdk.org/jdk21u-dev/pull/562.diff
  Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/562/head:pull/562

PR: https://git.openjdk.org/jdk21u-dev/pull/562


More information about the jdk-updates-dev mailing list