[jdk11u-dev] RFR: 8333837: [11u] HexPrinterTest.java javac compile fails illegal start of expression

Martin Doerr mdoerr at openjdk.org
Tue Jun 11 08:29:14 UTC 2024


On Sat, 8 Jun 2024 09:28:16 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
>   The testcase `test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java` fails because of Java 11 doesn't support `var v = switch(String) { case String -> ... }` syntax. This testcase was backported by [JDK-8333837](https://bugs.openjdk.org/browse/JDK-8333837) from jdk15. This PR fix the syntax error to make the testcase work normally.
>   Only change the testcase, the change has been verified, no risk.

Please fix the link in the description. The related issue is [JDK-8329248](https://bugs.openjdk.org/browse/JDK-8329248). I think it's better not to update the Copyright because you are only repairing a backport. We usually avoid touching the Copyright headers for backports unless the original change updates it. Otherwise, LGTM. Thanks for fixing it!

-------------

PR Review: https://git.openjdk.org/jdk11u-dev/pull/2750#pullrequestreview-2109711510


More information about the jdk-updates-dev mailing list