[jdk11u-dev] RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v8]
Martin Doerr
mdoerr at openjdk.org
Fri Jun 14 14:59:27 UTC 2024
On Fri, 14 Jun 2024 14:23:30 GMT, Sruthy Jayan <duke at openjdk.org> wrote:
>> test/jdk/sun/misc/URLClassPath/LargeClasspathWithPkgPrefix.java line 68:
>>
>>> 66:
>>> 67: JAVA_MAIN_CONTENT = sb.toString();
>>> 68: }
>>
>> Multi-line Strings are typically written like https://github.com/openjdk/jdk11u-dev/blob/f08e5e87938d3f20575ef186f4eefeb9faeb6e80/test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java#L88. Please also make sure the `}` is aligned properly.
>
> Changes done
I suggest to add spaces within the String such that the program is better readable and looks like in the original change.
-------------
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2749#discussion_r1639957197
More information about the jdk-updates-dev
mailing list