[jdk21u-dev] RFR: 8325494: C2: Broken graph after not skipping CastII node anymore for Assertion Predicates after JDK-8309902

[Aleksey Shipilev]

On Mon, 17 Jun 2024 17:21:49 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Originally clean backport of [JDK-8325494](https://bugs.openjdk.org/browse/JDK-8325494). A part of the assertion can only be enabled after [JDK-8305636](https://bugs.openjdk.org/browse/JDK-8305636) is backported (see 2nd commit).
>> The included test fails without the fix and passes with it.
>
> See: https://bugs.openjdk.org/browse/JDK-8325494?focusedId=14666187&#comment-14666187 :)
> 
> (I was just surprised this backport was "clean")

> @shipilev: JDK 21 needs this fix (the included test shows it). The tests are passing when this fix is applied. I suggest to take it with the weakened assertion which is not relevant for fixing the issue. We can reactivate it when [JDK-8305636](https://bugs.openjdk.org/browse/JDK-8305636) gets backported (later release). Or do you have another proposal what to do with it?

Relaxing assert looks fine to me. It is unfortunate we have to do this, but alas. @TobiHartmann, is that what you folks did too?

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/734#issuecomment-2180296867