[jdk21u-dev] RFR: 8332920: C2: Partial Peeling is wrongly applied for CmpU with negative limit [v2]
Christian Hagedorn
chagedorn at openjdk.org
Thu Jun 20 14:16:11 UTC 2024
On Thu, 20 Jun 2024 14:03:33 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Originally clean backport of [JDK-8332920](https://bugs.openjdk.org/browse/JDK-8332920).
>> Unfortunately, `-XX:CompileOnly` is not available in 21u, so I had to adapt the new test compiler/loopopts/TestPartialPeelAtUnsignedTestsNegativeLimit.java (see 2nd commit). Tier 1-4 have passed.
>
> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>
> Replace -XX:CompileOnly
test/hotspot/jtreg/compiler/loopopts/TestPartialPeelAtUnsignedTestsNegativeLimit.java line 29:
> 27: * @summary Tests partial peeling at unsigned tests with limit being negative in exit tests "i >u limit".
> 28: * @run main/othervm -Xbatch -XX:-TieredCompilation
> 29: * -XX:CompileCommand=compileonly,*TestPartialPeel*::original*,*TestPartialPeel*::test*
You need separate `CompileCommand=compileonly` statements since they only supports one pattern. The idea of JDK-8027711 was to keep the benefit of defining multiple patterns with `CompileOnly` but also getting the same syntax as used by `CompileCommand=compileonly`. This was the reason I used `CompileOnly` here in mainline and not a compile command.
-------------
PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/728#discussion_r1647655026
More information about the jdk-updates-dev
mailing list