[jdk11u-dev] RFR: 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"

[Martin Doerr]

On Thu, 16 May 2024 19:43:53 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

> backport of c0dce25756911ce49e7d8b034d5f12a25fc3c81d
> 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"
> 1. Clean backport from tip
> 2. validated the modified test case

Sorry for the delay. I had started a review and forgot to finish it.

test/hotspot/jtreg/serviceability/sa/TestInstanceKlassSizeForInterface.java line 41:

> 39: import jdk.test.lib.SA.SATestUtils;
> 40: import jdk.test.lib.Utils;
> 41: import java.util.Arrays;

Please add the import where the other java.util imports are (alphabetically sorted).

-------------

Changes requested by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk11u-dev/pull/2712#pullrequestreview-2123750257
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2712#discussion_r1643339631