[jdk21u-dev] RFR: 8332920: C2: Partial Peeling is wrongly applied for CmpU with negative limit [v2]

[Christian Hagedorn]

On Fri, 21 Jun 2024 09:01:44 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/loopopts/TestPartialPeelAtUnsignedTestsNegativeLimit.java line 29:
>> 
>>> 27:  * @summary Tests partial peeling at unsigned tests with limit being negative in exit tests "i >u limit".
>>> 28:  * @run main/othervm -Xbatch -XX:-TieredCompilation
>>> 29:  *                   -XX:CompileCommand=compileonly,*TestPartialPeel*::original*,*TestPartialPeel*::test*
>> 
>> You need separate `CompileCommand=compileonly` statements since they only supports one pattern. The idea of JDK-8027711 was to keep the benefit of defining multiple patterns with `CompileOnly` but also getting the same syntax as used by `CompileCommand=compileonly`. This was the reason I used `CompileOnly` here in mainline and not a compile command.
>
> Thank you! I was not aware of that. Fixed.

You're welcome :-) looks good now!

-------------

PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/728#discussion_r1648664407