[jdk21u-dev] RFR: 8325494: C2: Broken graph after not skipping CastII node anymore for Assertion Predicates after JDK-8309902 [v2]

[Christian Hagedorn]

On Mon, 17 Jun 2024 20:15:58 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Originally clean backport of [JDK-8325494](https://bugs.openjdk.org/browse/JDK-8325494). A part of the assertion can only be enabled after [JDK-8305636](https://bugs.openjdk.org/browse/JDK-8305636) is backported (see 2nd commit).
>> The included test fails without the fix and passes with it.
>
> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Disable part of an assertion which requires JDK-8305636.

For completeness, the code was once removed and then inserted again with this change. Back there, we have not applied the clean-ups around Assertion Predicates and the code looked like the snippet posted by Tobias:

> assert(((CastIINode*)init)->carry_dependency() && loop_head->skip_predicates() == init->in(0), "casted iv phi from pre loop expected");

Reference:
https://github.com/openjdk/jdk/commit/26efff758684b9c5615fb3b087538d713e6eca10#diff-6a59f91cb710d682247df87c75faf602f0ff9f87e2855ead1b80719704fbedffL2049

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/734#issuecomment-2186367531