[jdk11u-dev] RFR: 8212726: Replace some use of drop- and foldArguments with filtering argument combinator in StringConcatFactory

[Anton Bobrov]

On Thu, 20 Jun 2024 14:15:04 GMT, Anton Bobrov <abobrov at openjdk.org> wrote:

> This is a backport of 06a2bb52747eab8033f53b45fad714eb649475f0 / [JDK-8212726](https://bugs.openjdk.org/browse/JDK-8212726)
> 
> This backport is needed to facilitate the backport of [JDK-8222852](https://bugs.openjdk.org/browse/JDK-8222852) which is otherwise very complex and high risk to rework for 11u-dev.
> 
> Aside from positional merge conflict in StringConcatFactory this is a clean backport
> Testing: x86_64 build, tier1, tier2, tier3
> 
> Due to possible high exposure ran tier2 and tier3 as well to ensure safety for 11u-dev.

the merge that makes this backport unclean is based on an earlier change for [JDK-8212597](https://bugs.openjdk.org/browse/JDK-8212597)

https://github.com/openjdk/jdk/commit/b3b41df70fb5ec3187d165786b3c8ad2d4b4012b#diff-77881b7bd279b9c0365ba2c5ffa9ebbbb23014e30ff467dc3630b380c7ec9d2d

that has never been backported or even marked for any backports.  i'm not sure whats the best course of action here then, either backport this earlier change and then redo this one on top of it (hopefully as clean then) or keep this one as it as it overwrites the earlier change anyway?

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2800#issuecomment-2188264802