[jdk17u-dev] RFR: 8317372: Refactor some NumberFormat tests to use JUnit

[Martin Doerr]

On Mon, 24 Jun 2024 09:33:39 GMT, Andrew Lu <andrewlu at openjdk.org> wrote:

> I backport this for parity with 17.0.13-oracle.
> test/jdk/java/text/Format/NumberFormat/Bug4838107.java has changed by 8316696: Remove the testing base classes: IntlTest and CollatorTest
> test/jdk/java/text/Format/NumberFormat/Bug8132125.java has changed by 8283698: Refactor Locale constructors used in src/test
> test/jdk/java/text/Format/NumberFormat/CurrencyFormat.java has changed by 8283698: Refactor Locale constructors used in src/test and 8301991: Convert l10n properties resource bundles to UTF-8 native
> test/jdk/java/text/Format/NumberFormat/TestPeruCurrencyFormat.java has changed by 8283698: Refactor Locale constructors used in src/test

You forgot to mention the `@run junit/othervm` changes. But, ok. LGTM. I only found one minor nit.

test/jdk/java/text/Format/NumberFormat/Bug4838107.java line 50:

> 48: import static org.junit.jupiter.api.Assertions.fail;
> 49: 
> 50: 

Extra empty line. Please remove.

-------------

PR Review: https://git.openjdk.org/jdk17u-dev/pull/2628#pullrequestreview-2138806847
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2628#discussion_r1652901343