[jdk11u-dev] RFR: 8227122: [TESTBUG] Create Docker sidecar test cases

[Severin Gehwolf]

On Wed, 26 Jun 2024 16:03:44 GMT, Antonio Vieiro <duke at openjdk.org> wrote:

>> This is a backport of [JDK-8227122](https://bugs.openjdk.org/browse/JDK-8227122).
>> 
>> Backport is not clean because we've already applied [JDK-8272398](https://bugs.openjdk.org/browse/JDK-8272398) in jdk11u (in upstream JDK-8272398 was applied _after_ JDK-8227122), so it's necessary to make a small adaptation, that I've separated in a second commit to ease review.  Let me know if you prefer me squashing the commits.
>> 
>> Tested on Fedora 40 with Docker version 27.0.1, build 7fafd33.
>> 
>> 
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR   
>>    jtreg:test/hotspot/jtreg/containers/docker/TestJcmdWithSideCar.java
>>                                                          1     1     0     0   
>> ==============================
>> TEST SUCCESS
>
> Thanks for the review! Let's now request approval

@vieiro Please take a minute and look at the generated fix request comment created in https://github.com/openjdk/jdk11u-dev/pull/2815#issuecomment-2192072624. It's not useful (consider that maintainers use the JBS system to look at those requests):


[jdk11u-fix-request] Approval Request from Antonio Vieiro
[JDK-8227122](https://bugs.openjdk.org/browse/JDK-8227122) [TESTBUG] Create Docker sidecar test cases


So you're request comment repeats the bug synopsis, which is already apparent when looking at it for approval.

Fix request comment guidance is here (Step 6, point `ii`):
https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix

Please update the request by issuing `/approval request` again.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2815#issuecomment-2192091938