From rrich at openjdk.org Fri Mar 1 07:19:17 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Fri, 1 Mar 2024 07:19:17 GMT Subject: [jdk21u-dev] RFR: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 Message-ID: This adds a `ThreadWXEnable` to `JVM_ENTRY_FROM_LEAF`. Without we can get similar crashes as described in the bug report when writing to the code cache. Note that in jdk21 we cannot get the very same crash because the nmethod sweeper was removed in jdk20 with [JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025). The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. ------------- Commit messages: - Add ThreadWXEnable to JVM_ENTRY_FROM_LEAF macro Changes: https://git.openjdk.org/jdk21u-dev/pull/305/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=305&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327036 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/305.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/305/head:pull/305 PR: https://git.openjdk.org/jdk21u-dev/pull/305 From rrich at openjdk.org Fri Mar 1 07:19:17 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Fri, 1 Mar 2024 07:19:17 GMT Subject: [jdk21u-dev] RFR: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 14:49:21 GMT, Richard Reingruber wrote: > This adds a `ThreadWXEnable` to `JVM_ENTRY_FROM_LEAF`. > Without we can get similar crashes as described in the bug report when writing to the code cache. > Note that in jdk21 we cannot get the very same crash because the nmethod sweeper was removed in jdk20 with [JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025). > > The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. Riscv64 error in GHA is unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/305#issuecomment-1972628707 From mdoerr at openjdk.org Fri Mar 1 07:36:54 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 1 Mar 2024 07:36:54 GMT Subject: [jdk21u-dev] RFR: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 14:49:21 GMT, Richard Reingruber wrote: > This adds a `ThreadWXEnable` to `JVM_ENTRY_FROM_LEAF`. > Without we can get similar crashes as described in the bug report when writing to the code cache. > Note that in jdk21 we cannot get the very same crash because the nmethod sweeper was removed in jdk20 with [JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025). > > The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/305#pullrequestreview-1910501857 From andrewlu at openjdk.org Fri Mar 1 07:47:15 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 1 Mar 2024 07:47:15 GMT Subject: [jdk11u-dev] RFR: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work [v2] In-Reply-To: References: Message-ID: > Backport 8310380 > add backports for JDK-8270199, JDK-8248194, JDK-8248667 Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: Backport 39c104df44f17c1d65e35becd4272f73e2c6610c ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2577/files - new: https://git.openjdk.org/jdk11u-dev/pull/2577/files/7214ab3c..862d0743 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2577&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2577&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2577.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2577/head:pull/2577 PR: https://git.openjdk.org/jdk11u-dev/pull/2577 From aph at openjdk.org Fri Mar 1 08:15:56 2024 From: aph at openjdk.org (Andrew Haley) Date: Fri, 1 Mar 2024 08:15:56 GMT Subject: [jdk21u-dev] RFR: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 14:49:21 GMT, Richard Reingruber wrote: > This adds a `ThreadWXEnable` to `JVM_ENTRY_FROM_LEAF`. > Without we can get similar crashes as described in the bug report when writing to the code cache. > Note that in jdk21 we cannot get the very same crash because the nmethod sweeper was removed in jdk20 with [JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025). > > The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. So that adds a WX transition to every JVM_ENTRY_FROM_LEAF? I think we need to think about the cost of that. Isn't it better to do the transition when we actually need it? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/305#issuecomment-1972714048 From goetz at openjdk.org Fri Mar 1 08:19:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 1 Mar 2024 08:19:58 GMT Subject: [jdk17u-dev] RFR: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053 In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 07:26:12 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. @andrewlu, please merge head, this will fix the GHA build issues. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2246#issuecomment-1972720304 From duke at openjdk.org Fri Mar 1 08:21:17 2024 From: duke at openjdk.org (Long Yang) Date: Fri, 1 Mar 2024 08:21:17 GMT Subject: [jdk21u-dev] RFR: 8319876: Reduce memory consumption of VM_ThreadDump::doit Message-ID: <24gHo7dmt8Yjtp-6kIIYVZMlUPCNfXoDEDo3P0Q1yoM=.fd04c34b-3814-4703-8ad2-7c3f71f96f3b@github.com> Hi, all Could I have a review of this backport. This pull request contains a backport of commit [8ec6b8de3bb3d7aeebdcb45d761b18cce3bab75e](https://github.com/openjdk/jdk/commit/8ec6b8de3bb3d7aeebdcb45d761b18cce3bab75e) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. This backport can significantly reduce the `RSS` during the execution of `ThreadMXBean.dumpAllThreads(boolean, boolean)`. On `jdk21u-dev`, if creates 4096 threads, and the stack depth of each thread is 256. On the version that does not contain this backport, during the execution of `ThreadMXBean.dumpAllThreads(true, true)`, the `RSS` reaches about 5GiB. On the version that contains this backport, the max `RSS` is about 300MiB. There is a difference between `jdk21u-dev` and `openjdk/jdk`. On `openjdk/jdk`, `ThreadStackTrace::dump_stack_at_safepoint` will only be executed in `VMThread`. But on `jdk21u-dev`, `ThreadStackTrace::dump_stack_at_safepoint` will be executed in `VMThread` or `RuntimeWorker`, so when creating `ResourceMark`, can not directedly specify `VMThread` like what `openjdk/jdk` does, but needs to read current thread. Testing: I ran `tier1`, `tier2`, `tier3`, `tier4` on my host machine with the `jdk21u-dev` including this backport. `tier1`, `tier2`, and `tier3` all passed. Because my host does not have a `display device`, I added `export JTREG_KEYWORDS="!headful"` before running `tier4`. Finally, some tests in `tier4` that depend on the printing device failed, and the rest were successful. The [GHA](https://github.com/yanglong1010/jdk21u-dev/actions/runs/8093195914/job/22116320956) failed in [linux-cross-compile, build(riscv64), Create sysroot]. I've also seen others fail at this step as well (e.g. [link](https://github.com/openjdk-bots/jdk21u-dev/actions/runs/8077954001/job/22081472372)), it looks like there's an issue with the GHA's process. I would appreciate it if anyone could review this. Thanks! ------------- Commit messages: - 8319876: Reduce memory consumption of VM_ThreadDump::doit Changes: https://git.openjdk.org/jdk21u-dev/pull/307/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=307&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319876 Stats: 3 lines in 2 files changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/307.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/307/head:pull/307 PR: https://git.openjdk.org/jdk21u-dev/pull/307 From goetz at openjdk.org Fri Mar 1 08:25:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 1 Mar 2024 08:25:54 GMT Subject: [jdk21u-dev] RFR: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 02:47:26 GMT, Vladimir Petko wrote: > Hi all, > > This pull request contains a backport of commit [d1099033](https://github.com/openjdk/jdk/commit/d1099033ac63b9dd0dd6e3a7341db929e9e0e56e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alan Bateman on 8 Feb 2024 and was reviewed by Brian Burkhalter. > > This change fixes a bug in jruby[1] that broken pipeline functions of Open3[1][2]. > > Thanks! > > [1] https://github.com/jruby/jruby/issues/8069 > [2] https://bugs.launchpad.net/ubuntu/+source/jruby/+bug/2054943 @vpa1977 please also backport this to jdk22u. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/290#issuecomment-1972728329 From goetz at openjdk.org Fri Mar 1 08:28:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 1 Mar 2024 08:28:56 GMT Subject: [jdk17u-dev] RFR: 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used In-Reply-To: <-pNl27hnJvTUMD9biuEkMOrR2K1cmCvuG8EgiIObPTc=.0662dd66-97ca-445b-85fd-92c6bdd2e094@github.com> References: <-pNl27hnJvTUMD9biuEkMOrR2K1cmCvuG8EgiIObPTc=.0662dd66-97ca-445b-85fd-92c6bdd2e094@github.com> Message-ID: <3dYX2keEIXrj7Fa-Thv_Si0KGp7a9NWrqDK5fCfOT_Y=.d37f060b-a68e-4e52-acb9-177737b1dc1f@github.com> On Thu, 29 Feb 2024 12:06:15 GMT, Sergey Nazarkin wrote: > I'd like to backport this changes as it fixes some custom launchers issue. Fix applies cleanly. > > The functionality was tested with the new test and manually > > cd ~/tools/bin > cp -r ~/jdk . > cp jdk/bin/java jdk/lib > jdk/lib/java -version > > > Without the patch JVM can't start > > Error: could not find libjava.so > Error: Could not find Java SE Runtime Environment. @snazarkin, why are the GHA tests failing? Next time, I might just remove the fix-request label instead of asking. Testing is a prereq for labeling. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2257#issuecomment-1972733215 From mdoerr at openjdk.org Fri Mar 1 08:36:52 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 1 Mar 2024 08:36:52 GMT Subject: [jdk21u-dev] RFR: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 08:13:07 GMT, Andrew Haley wrote: > So that adds a WX transition to every JVM_ENTRY_FROM_LEAF? I think we need to think about the cost of that. Isn't it better to do the transition when we actually need it? There is only one usage. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/305#issuecomment-1972745007 From snazarki at openjdk.org Fri Mar 1 08:38:55 2024 From: snazarki at openjdk.org (Sergey Nazarkin) Date: Fri, 1 Mar 2024 08:38:55 GMT Subject: [jdk17u-dev] RFR: 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used In-Reply-To: <3dYX2keEIXrj7Fa-Thv_Si0KGp7a9NWrqDK5fCfOT_Y=.d37f060b-a68e-4e52-acb9-177737b1dc1f@github.com> References: <-pNl27hnJvTUMD9biuEkMOrR2K1cmCvuG8EgiIObPTc=.0662dd66-97ca-445b-85fd-92c6bdd2e094@github.com> <3dYX2keEIXrj7Fa-Thv_Si0KGp7a9NWrqDK5fCfOT_Y=.d37f060b-a68e-4e52-acb9-177737b1dc1f@github.com> Message-ID: On Fri, 1 Mar 2024 08:25:57 GMT, Goetz Lindenmaier wrote: > @snazarkin, why are the GHA tests failing? Next time, I might just remove the fix-request label instead of asking. Testing is a prereq for labeling. It is riscv pipeline can't create sysroot. Looks like all PR for the last few days are failing ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2257#issuecomment-1972747470 From vpetko at openjdk.org Fri Mar 1 08:41:55 2024 From: vpetko at openjdk.org (Vladimir Petko) Date: Fri, 1 Mar 2024 08:41:55 GMT Subject: [jdk21u-dev] RFR: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread In-Reply-To: References: Message-ID: <38YcO6xMpFw4gP-fwqxSU0D9ioMMP2Xz_Xz7Lhgza5o=.46a47ec3-37bd-47f9-98ea-83f302deb30c@github.com> On Fri, 1 Mar 2024 08:22:39 GMT, Goetz Lindenmaier wrote: > @vpa1977 please also backport this to jdk22u. I apologise for forgetting this. I have created https://github.com/openjdk/jdk22u/pull/79 . ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/290#issuecomment-1972752202 From vpetko at openjdk.org Fri Mar 1 08:42:21 2024 From: vpetko at openjdk.org (Vladimir Petko) Date: Fri, 1 Mar 2024 08:42:21 GMT Subject: [jdk22u] RFR: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread Message-ID: Hi all, This pull request contains a backport of commit [d1099033](https://github.com/openjdk/jdk/commit/d1099033ac63b9dd0dd6e3a7341db929e9e0e56e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alan Bateman on 8 Feb 2024 and was reviewed by Brian Burkhalter. This change fixes a bug in jruby[1] that broken pipeline functions of Open3[1][2]. Thanks! [1] https://github.com/jruby/jruby/issues/8069 [2] https://bugs.launchpad.net/ubuntu/+source/jruby/+bug/2054943 ------------- Commit messages: - Backport d1099033ac63b9dd0dd6e3a7341db929e9e0e56e Changes: https://git.openjdk.org/jdk22u/pull/79/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=79&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325028 Stats: 84 lines in 2 files changed: 70 ins; 4 del; 10 mod Patch: https://git.openjdk.org/jdk22u/pull/79.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/79/head:pull/79 PR: https://git.openjdk.org/jdk22u/pull/79 From rrich at openjdk.org Fri Mar 1 08:54:51 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Fri, 1 Mar 2024 08:54:51 GMT Subject: [jdk21u-dev] RFR: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 08:33:58 GMT, Martin Doerr wrote: > So that adds a WX transition to every JVM_ENTRY_FROM_LEAF? I think we need to think about the cost of that. Isn't it better to do the transition when we actually need it? There are no usages of JVM_ENTRY_FROM_LEAF where the WX transition already happened. So I think it is safest to add it to JVM_ENTRY_FROM_LEAF. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/305#issuecomment-1972771033 From vklang at openjdk.org Fri Mar 1 09:03:17 2024 From: vklang at openjdk.org (Viktor Klang) Date: Fri, 1 Mar 2024 09:03:17 GMT Subject: [jdk22u] RFR: 8309218: java/util/concurrent/locks/Lock/OOMEInAQS.java still times out with ZGC, Generational ZGC, and SerialGC Message-ID: This is a test-stabilization backport. ------------- Commit messages: - Backport b86c3b7a68335d57699ea3c5ec6d09a62ea9026a Changes: https://git.openjdk.org/jdk22u/pull/80/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=80&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309218 Stats: 8 lines in 3 files changed: 1 ins; 3 del; 4 mod Patch: https://git.openjdk.org/jdk22u/pull/80.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/80/head:pull/80 PR: https://git.openjdk.org/jdk22u/pull/80 From shade at openjdk.org Fri Mar 1 09:14:52 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 1 Mar 2024 09:14:52 GMT Subject: [jdk21u-dev] RFR: 8323519: Add applications/ctw/modules to Hotspot tiered testing In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 13:46:35 GMT, Aleksey Shipilev wrote: > Clean backport to improve testing. GHA failure is environmental. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/304#issuecomment-1972803213 From clanger at openjdk.org Fri Mar 1 09:17:12 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 1 Mar 2024 09:17:12 GMT Subject: [jdk17u] RFR: 8272903: Missing license header in ArenaAllocator.java [v2] In-Reply-To: References: <2G6lPPbqhafMmrBkOPWDsuZXeKFB6bNEXDN0yF5uHtw=.aecab267-7ed3-4e01-83e9-7708fd311400@github.com> Message-ID: On Thu, 29 Feb 2024 02:27:36 GMT, Amit Kumar wrote: >> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision: >> >> updates copyright header year > > @mcimadamore would you help me in integrating this one, if you have bandwidth. @offamitkumar Is there any reason why this needs to be done in rampdown jdk17u repository? I guess jdk17u-dev would be more appropriate. Also, for the backport, please don't add the copyright year 2024. Then it would apply cleanly and no formal PR review would be necessary. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/388#issuecomment-1972805500 From duke at openjdk.org Fri Mar 1 09:23:51 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 1 Mar 2024 09:23:51 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 12:52:28 GMT, Mar?a Arias de Reyna wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8280377 MethodHandleProxies does not correctly invoke default methods with varags > > I applied the same fix that was applied to version 19 in https://github.com/openjdk/jdk/commit/a183bfb436a7dd998e602c2d16486e88c390fca1 I tested with the `Main.java` example that is provided in the bug: import java.lang.invoke.MethodHandleProxies; import java.lang.invoke.MethodHandles; import static java.lang.invoke.MethodType.methodType; public class Main { public interface Interface { void method(Object... args); default void defaultMethod(Object... args) { method(args); } default void defaultMethod2(Object[] args) { method(args); } } private static void callMeViaMethodHandles(String foo, int bar) { System.out.println("foo=" + foo + ", bar=" + bar); } public static void main(String[] args) throws NoSuchMethodException, IllegalAccessException { var mh = MethodHandles.lookup().findStatic( Main.class, "callMeViaMethodHandles", methodType(void.class, String.class, int.class) ); mh = mh.asSpreader(Object[].class, mh.type().parameterCount()); var proxy = MethodHandleProxies.asInterfaceInstance(Interface.class, mh); // throws incorrect exception proxy.defaultMethod("should be foo", 3); // works fine proxy.defaultMethod2(new Object[] { "should be foo", 3 }); } } With the regular Java 17 installed on my Debian, I get the expected error pre-fix (I also tested with a local build of latest master at the time, but as I built with the fix, I cannot provide right now the output for that): $ javac Main.java ; java --version; java Main openjdk 17.0.10 2024-01-16 OpenJDK Runtime Environment (build 17.0.10+7-Debian-1deb12u1) OpenJDK 64-Bit Server VM (build 17.0.10+7-Debian-1deb12u1, mixed mode, sharing) Exception in thread "main" java.lang.IllegalArgumentException: array is not of length 2 at java.base/java.lang.invoke.MethodHandleStatics.newIllegalArgumentException(MethodHandleStatics.java:167) at java.base/java.lang.invoke.MethodHandleImpl.checkSpreadArgument(MethodHandleImpl.java:584) at java.base/java.lang.invoke.MethodHandleProxies$1.invoke(MethodHandleProxies.java:198) at jdk.proxy1/com.sun.proxy.jdk.proxy1.$Proxy0.method(Unknown Source) at Main$Interface.defaultMethod(Main.java:12) at java.base/java.lang.invoke.MethodHandleProxies.callDefaultMethod(MethodHandleProxies.java:354) at java.base/java.lang.invoke.MethodHandleProxies$1.invoke(MethodHandleProxies.java:205) at jdk.proxy1/com.sun.proxy.jdk.proxy1.$Proxy0.defaultMethod(Unknown Source) at Main.main(Main.java:32) After fixing it, I get the correct answer: $ ~/git/jdk17u-dev/build/linux-x86_64-server-release/jdk/bin/javac Main.java && ~/git/jdk17u-dev/build/linux-x86_64-server-release/jdk/bin/java --version && ~/git/jdk17u-dev/build/linux-x86_64-server-release/jdk/bin/java Main openjdk 17.0.11-internal 2024-04-16 OpenJDK Runtime Environment (build 17.0.11-internal+0-adhoc.delawen.jdk17u-dev) OpenJDK 64-Bit Server VM (build 17.0.11-internal+0-adhoc.delawen.jdk17u-dev, mixed mode) foo=should be foo, bar=3 foo=should be foo, bar=3 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#issuecomment-1972812190 From duke at openjdk.org Fri Mar 1 09:23:51 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 1 Mar 2024 09:23:51 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: <40U25UQnUJ22lpC66tALzPcBO5slqjGzY7GcOLfLnK4=.f5cb1427-348d-4b97-b4ac-0a6a1578f0b0@github.com> References: <40U25UQnUJ22lpC66tALzPcBO5slqjGzY7GcOLfLnK4=.f5cb1427-348d-4b97-b4ac-0a6a1578f0b0@github.com> Message-ID: On Tue, 27 Feb 2024 19:50:48 GMT, Goetz Lindenmaier wrote: > get some more testing than just checking that is fixes the issue. @GoeLin I am going to test other things with my local build with the fix, like running other Java apps. Any suggestions on what should I try to make sure it works, besides the different `make tests` and try to run for example IntellijIDEA or other Java apps? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#issuecomment-1972815005 From qpzhang at openjdk.org Fri Mar 1 09:26:55 2024 From: qpzhang at openjdk.org (Patrick Zhang) Date: Fri, 1 Mar 2024 09:26:55 GMT Subject: [jdk17u-dev] RFR: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 10:36:36 GMT, Andrew Dinn wrote: >> Hi, >> >> This pull request contains a backport of commit [9936aeea](https://github.com/openjdk/jdk/commit/9936aeea32b71509151099e6d28905e0322b2bc2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> Not a clean merge to 17u-dev. >> Manually resolved the merging conflicts due to line differences on `enum Ampere_CPU_Model` and `Feature_Flag`, removed redundant changes in order to limit the update to the code changes only from commit [9936aeea]. This can also lower the risk and limit the functionality impact to to particular Ampere new CPU cores Ampere-1/1A/1B. Same scope as that of the commit [9936aeea]. >> >> Passed pre-submit tests, ran Jtreg `tier1`, `tier2`, and `gtest` tests, no related issue found with the patch, also tested: >> `make run-test TEST="jtreg:hotspot/jtreg/compiler/onSpinWait*" ` >> `make run-test TEST="micro:ThreadOnSpinWait*"` >> >> Thanks for review. > > Ok. Thanks for your view @adinn , I noticed that the check-box of "**Change must be properly reviewed (1 review required)**" is still blank. Probably I need an "Approve" on it, before moving forward to ask for 17u-dev maintainer's approval of the integration, right? or Is there any code change required on this PR? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2202#issuecomment-1972821743 From duke at openjdk.org Fri Mar 1 09:28:56 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 1 Mar 2024 09:28:56 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 12:52:28 GMT, Mar?a Arias de Reyna wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8280377 MethodHandleProxies does not correctly invoke default methods with varags > > I applied the same fix that was applied to version 19 in https://github.com/openjdk/jdk/commit/a183bfb436a7dd998e602c2d16486e88c390fca1 The commit contains a test for the different ways of calling a method with varargs: https://github.com/openjdk/jdk17u-dev/pull/2235/files#diff-41008904ed7aa596f5de5930e082a8cf6b239603883818fa940bb04ff511455aR65-R68 But I understand this may be a "too simple" example. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#issuecomment-1972824178 From qpzhang at openjdk.org Fri Mar 1 09:34:54 2024 From: qpzhang at openjdk.org (Patrick Zhang) Date: Fri, 1 Mar 2024 09:34:54 GMT Subject: [jdk21u-dev] RFR: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs In-Reply-To: References: Message-ID: <76U3vclWDXcEsOFEzzigm5o79ygUbDZbczCyBG2n7Zg=.f15337d0-fe1e-4212-adb2-5d1eb3632240@github.com> On Fri, 9 Feb 2024 08:39:09 GMT, Patrick Zhang wrote: > Hi all, > > This pull request contains a backport of commit [9936aeea](https://github.com/openjdk/jdk/commit/9936aeea32b71509151099e6d28905e0322b2bc2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Patrick Zhang on 8 Feb 2024 and was reviewed by Dean Long and Tobias Hartmann. > > Thanks! Hi @dean-long, Could you please do me another favor and help sponsor to push this backport into jdk21u-dev? Thanks in advance. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/249#issuecomment-1972833649 From shade at openjdk.org Fri Mar 1 09:34:54 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 1 Mar 2024 09:34:54 GMT Subject: [jdk17u-dev] RFR: 8323519: Add applications/ctw/modules to Hotspot tiered testing In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 13:49:45 GMT, Aleksey Shipilev wrote: > Clean backport to improve testing. GHA failure is environmental. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2258#issuecomment-1972834675 From shade at openjdk.org Fri Mar 1 09:41:56 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 1 Mar 2024 09:41:56 GMT Subject: [jdk17u-dev] RFR: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs In-Reply-To: References: Message-ID: On Sat, 10 Feb 2024 10:34:54 GMT, Patrick Zhang wrote: > Hi, > > This pull request contains a backport of commit [9936aeea](https://github.com/openjdk/jdk/commit/9936aeea32b71509151099e6d28905e0322b2bc2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > Not a clean merge to 17u-dev. > Manually resolved the merging conflicts due to line differences on `enum Ampere_CPU_Model` and `Feature_Flag`, removed redundant changes in order to limit the update to the code changes only from commit [9936aeea]. This can also lower the risk and limit the functionality impact to to particular Ampere new CPU cores Ampere-1/1A/1B. Same scope as that of the commit [9936aeea]. > > Passed pre-submit tests, ran Jtreg `tier1`, `tier2`, and `gtest` tests, no related issue found with the patch, also tested: > `make run-test TEST="jtreg:hotspot/jtreg/compiler/onSpinWait*" ` > `make run-test TEST="micro:ThreadOnSpinWait*"` > > Thanks for review. Looks good to me. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2202#pullrequestreview-1910706525 From shade at openjdk.org Fri Mar 1 09:41:56 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 1 Mar 2024 09:41:56 GMT Subject: [jdk21u-dev] RFR: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs In-Reply-To: References: Message-ID: <8NY20kC3nYIRiXEgcQUYYlxFPWKIkyA95rS3cVhBeMo=.97dc771c-a8f5-42ec-93f4-8105621c6fdb@github.com> On Fri, 9 Feb 2024 08:39:09 GMT, Patrick Zhang wrote: > Hi all, > > This pull request contains a backport of commit [9936aeea](https://github.com/openjdk/jdk/commit/9936aeea32b71509151099e6d28905e0322b2bc2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Patrick Zhang on 8 Feb 2024 and was reviewed by Dean Long and Tobias Hartmann. > > Thanks! Let's not put Dean into a bit of a tough spot here :) I'll sponsor instead. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/249#issuecomment-1972842862 From qpzhang at openjdk.org Fri Mar 1 09:41:56 2024 From: qpzhang at openjdk.org (Patrick Zhang) Date: Fri, 1 Mar 2024 09:41:56 GMT Subject: [jdk21u-dev] Integrated: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs In-Reply-To: References: Message-ID: On Fri, 9 Feb 2024 08:39:09 GMT, Patrick Zhang wrote: > Hi all, > > This pull request contains a backport of commit [9936aeea](https://github.com/openjdk/jdk/commit/9936aeea32b71509151099e6d28905e0322b2bc2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Patrick Zhang on 8 Feb 2024 and was reviewed by Dean Long and Tobias Hartmann. > > Thanks! This pull request has now been integrated. Changeset: 4243aed4 Author: Patrick Zhang Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/4243aed45758772dc6ba24c65b2e15cedbf2bac5 Stats: 12 lines in 2 files changed: 9 ins; 0 del; 3 mod 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs Backport-of: 9936aeea32b71509151099e6d28905e0322b2bc2 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/249 From shade at openjdk.org Fri Mar 1 09:45:58 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 1 Mar 2024 09:45:58 GMT Subject: [jdk11u-dev] RFR: 8281507: Two javac tests have bad jtreg `@clean` tags In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 18:11:59 GMT, Amos Shi wrote: >>> Added to test environments to validate >> >> Not sure what that means. :) Are you testing this locally somewhere? If so, and the tests are passing, can you please formally review? > >> > Added to test environments to validate >> >> Not sure what that means. :) Are you testing this locally somewhere? If so, and the tests are passing, can you please formally review? > > HI @shipilev , > this is Amos from SAP, there is a list of test machines in SAP office can do testings on PR in `jdk11u-dev` > This Jira was assigned to me last week, due to some delay and I did not pickup it. Luckily you have created this PR. > So I just added the PR to the test machines inside SAP. > > I will update in this PR with comments when the test becomes green. > It takes 1-2 days usually, or could be more time, depending on the test system situations. So I am in the weird spot here: there is a maintainer approval for it, but no reviews :) Which means I still cannot integrate. @amosshi, @GoeLin -- could you please formally (R)eview this? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2556#issuecomment-1972851834 From goetz at openjdk.org Fri Mar 1 10:03:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 1 Mar 2024 10:03:56 GMT Subject: [jdk17u-dev] Integrated: 8269914: Factor out heap printing for G1 young and full gc In-Reply-To: <-ae8R4pGnuS6DHtpM_HrROD0cIQbHiJlrMvB2NLdsn4=.af8375b9-147a-4192-a8af-cb156e0b06f5@github.com> References: <-ae8R4pGnuS6DHtpM_HrROD0cIQbHiJlrMvB2NLdsn4=.af8375b9-147a-4192-a8af-cb156e0b06f5@github.com> Message-ID: On Wed, 28 Feb 2024 13:32:10 GMT, Goetz Lindenmaier wrote: > I backport this as prerequisite for [8291753](https://bugs.openjdk.org/browse/JDK-8291753) as proposed before in https://github.com/openjdk/jdk17u-dev/pull/1900. > The backport has been tested by [releaseing it in SapMachine in 17.0.10](https://github.com/SAP/SapMachine/commit/4b0c2c7a070c7ad13f0da24a9418aea2883473af). This patch here is identical to the one in SapMachine. It will go to 17.0.12 giving enough time to settle. > > Also, this will bring G1 code of 17 closer to head probably simplifying further backports. > > This change solves two JBS issue, so I need approval for two. > > Some simple resolves needed: > > src/hotspot/share/gc/g1/g1CollectedHeap.cpp > Basically trivial resolve due to context. One of the calls removed > in the original change is not in 17. > The patch brings a call to _g1h->rem_set()->print_coarsen_stats() > which is not available in 17. I uncommented this call to make > it build. > > src/hotspot/share/gc/g1/g1FullGCScope.cpp > Trivial resolve. > Removes a destructor that calls several routines. > The destructor in 17 has one addtitional call that remains after removing the same ones as in the > original change. Thus I kept the destructor with this single call. > To make it build, I need to also keep the declaration of the destructor in the .hpp file. This pull request has now been integrated. Changeset: 0052ab70 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/0052ab7061f01515d4f2a73566513f5f3476c518 Stats: 194 lines in 7 files changed: 107 ins; 57 del; 30 mod 8269914: Factor out heap printing for G1 young and full gc 8270018: Add scoped object for g1 young gc JFR notification Reviewed-by: phh Backport-of: c93204ce3d4653705e6aeeadb9b3c591e469de77 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2250 From alanb at openjdk.org Fri Mar 1 10:43:57 2024 From: alanb at openjdk.org (Alan Bateman) Date: Fri, 1 Mar 2024 10:43:57 GMT Subject: [jdk22u] RFR: 8309218: java/util/concurrent/locks/Lock/OOMEInAQS.java still times out with ZGC, Generational ZGC, and SerialGC In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 08:59:21 GMT, Viktor Klang wrote: > This is a test-stabilization backport. Marked as reviewed by alanb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk22u/pull/80#pullrequestreview-1910841391 From mbaesken at openjdk.org Fri Mar 1 11:31:57 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 1 Mar 2024 11:31:57 GMT Subject: [jdk11u-dev] RFR: 8281507: Two javac tests have bad jtreg `@clean` tags In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 11:36:26 GMT, Aleksey Shipilev wrote: > Semi-clean backport on the way to jtreg update. Both files still have source/target=6 blocks, which need to be handled as well. > > Additional testing: > - [x] Affected tests now pass with jtreg 7.3.1+1 Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2556#pullrequestreview-1910921561 From goetz at openjdk.org Fri Mar 1 12:07:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 1 Mar 2024 12:07:58 GMT Subject: [jdk17u-dev] RFR: 8272651: G1 heap region info print order changed by JDK-8269914 Message-ID: I backport this as prerequisite for [8291753](https://bugs.openjdk.org/browse/JDK-8291753) as proposed before in https://github.com/openjdk/jdk17u-dev/pull/1900. The backport has been tested by [releaseing it in SapMachine in 17.0.10](https://github.com/SAP/SapMachine/commit/4b0c2c7a070c7ad13f0da24a9418aea2883473af). This patch here is identical to the one in SapMachine. It will go to 17.0.12 giving enough time to settle. Also, this will bring G1 code of 17 closer to head probably simplifying further backports. src/hotspot/share/gc/g1/g1CollectedHeap.cpp Some lines removed are not in 17: - set_young_collection_default_active_worker_threads(); some later: - G1YoungGCNotifyPauseMark npm; These are added again a bit further down. As adding them would modify the behaviour, I only added them uncommented. test/hotspot/jtreg/gc/g1/TestEagerReclaimHumongousRegionsLog.java The file already has the correct coding. Obviously these lines were changed after 17 and later reverted again. ------------- Commit messages: - Backport f11e099a149adfecc474ba37276ec8672067d090 Changes: https://git.openjdk.org/jdk17u-dev/pull/2261/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2261&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272651 Stats: 28 lines in 4 files changed: 20 ins; 6 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2261.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2261/head:pull/2261 PR: https://git.openjdk.org/jdk17u-dev/pull/2261 From mbaesken at openjdk.org Fri Mar 1 13:02:08 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 1 Mar 2024 13:02:08 GMT Subject: [jdk22u] RFR: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests Message-ID: <9CjUPPR5A0pwZI_jENaKt9x5Kc2la_55_UdBjnemTy8=.e1101dd6-a3ab-43b6-8ce0-50457b61e6ef@github.com> 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests ------------- Commit messages: - Backport 9f4ec21f4793d4c5fc10f93a32140c26ec0eec00 Changes: https://git.openjdk.org/jdk22u/pull/81/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=81&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325862 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/81.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/81/head:pull/81 PR: https://git.openjdk.org/jdk22u/pull/81 From goetz at openjdk.org Fri Mar 1 13:09:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 1 Mar 2024 13:09:53 GMT Subject: [jdk17u-dev] RFR: 8272651: G1 heap region info print order changed by JDK-8269914 In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 12:03:58 GMT, Goetz Lindenmaier wrote: > I backport this as prerequisite for [8291753](https://bugs.openjdk.org/browse/JDK-8291753) as proposed before in https://github.com/openjdk/jdk17u-dev/pull/1900. > The backport has been tested by [releaseing it in SapMachine in 17.0.10](https://github.com/SAP/SapMachine/commit/4b0c2c7a070c7ad13f0da24a9418aea2883473af). This patch here is identical to the one in SapMachine. It will go to 17.0.12 giving enough time to settle. > > Also, this will bring G1 code of 17 closer to head probably simplifying further backports. > > src/hotspot/share/gc/g1/g1CollectedHeap.cpp > > Some lines removed are not in 17: > - set_young_collection_default_active_worker_threads(); > some later: > - G1YoungGCNotifyPauseMark npm; > > These are added again a bit further down. > > As adding them would modify the behaviour, I only added > them uncommented. > > test/hotspot/jtreg/gc/g1/TestEagerReclaimHumongousRegionsLog.java > The file already has the correct coding. Obviously these lines > were changed after 17 and later reverted again. GHA failure: Well known Risk-V build issue. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2261#issuecomment-1973166592 From amitkumar at openjdk.org Fri Mar 1 13:12:00 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Fri, 1 Mar 2024 13:12:00 GMT Subject: [jdk17u] RFR: 8272903: Missing license header in ArenaAllocator.java [v2] In-Reply-To: References: <2G6lPPbqhafMmrBkOPWDsuZXeKFB6bNEXDN0yF5uHtw=.aecab267-7ed3-4e01-83e9-7708fd311400@github.com> Message-ID: On Fri, 1 Mar 2024 09:13:43 GMT, Christoph Langer wrote: >> @mcimadamore would you help me in integrating this one, if you have bandwidth. > > @offamitkumar Is there any reason why this needs to be done in rampdown jdk17u repository? I guess jdk17u-dev would be more appropriate. > > Also, for the backport, please don't add the copyright year 2024. Then it would apply cleanly and no formal PR review would be necessary. Thanks. @RealCLanger do we need to create separate PR manually for that or we can just use backport command like "/backport jdk17u-dev" ? ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/388#issuecomment-1973169625 From mbaesken at openjdk.org Fri Mar 1 13:13:17 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 1 Mar 2024 13:13:17 GMT Subject: [jdk21u-dev] RFR: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests Message-ID: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests ------------- Commit messages: - Backport 9f4ec21f4793d4c5fc10f93a32140c26ec0eec00 Changes: https://git.openjdk.org/jdk21u-dev/pull/308/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=308&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325862 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/308.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/308/head:pull/308 PR: https://git.openjdk.org/jdk21u-dev/pull/308 From sgehwolf at openjdk.org Fri Mar 1 13:37:12 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 1 Mar 2024 13:37:12 GMT Subject: [jdk17u] RFR: 8272903: Missing license header in ArenaAllocator.java [v2] In-Reply-To: References: <2G6lPPbqhafMmrBkOPWDsuZXeKFB6bNEXDN0yF5uHtw=.aecab267-7ed3-4e01-83e9-7708fd311400@github.com> Message-ID: On Fri, 1 Mar 2024 13:09:05 GMT, Amit Kumar wrote: > or we can just use backport command like "/backport jdk17u-dev" ? Yes, that should work. Please close this and use a PR for `jdk17u-dev` instead. ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/388#issuecomment-1973214868 From goetz at openjdk.org Fri Mar 1 15:02:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 1 Mar 2024 15:02:20 GMT Subject: [jdk21u-dev] RFR: 8306040: HttpResponseInputStream.available() returns 1 on empty stream Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport acaab6fd74f507bb6b18167505d88e505bdf24bd Changes: https://git.openjdk.org/jdk21u-dev/pull/309/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=309&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306040 Stats: 163 lines in 2 files changed: 161 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/309.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/309/head:pull/309 PR: https://git.openjdk.org/jdk21u-dev/pull/309 From duke at openjdk.org Fri Mar 1 15:08:54 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 1 Mar 2024 15:08:54 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 12:52:28 GMT, Mar?a Arias de Reyna wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8280377 MethodHandleProxies does not correctly invoke default methods with varags > > I applied the same fix that was applied to version 19 in https://github.com/openjdk/jdk/commit/a183bfb436a7dd998e602c2d16486e88c390fca1 @mlchung You did the original commit for this fix. Can you give me some ideas on how to properly test this backport and make sure I'm not breaking anything else? // cc @AlanBateman @DasBrain @liach as you were also involved on the original PR ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#issuecomment-1973356460 From duke at openjdk.org Fri Mar 1 15:17:55 2024 From: duke at openjdk.org (KIRIYAMA Takuya) Date: Fri, 1 Mar 2024 15:17:55 GMT Subject: [jdk21u-dev] Integrated: 8313394: Array Elements in OldObjectSample event has the incorrect description In-Reply-To: References: Message-ID: On Tue, 30 Jan 2024 05:34:43 GMT, KIRIYAMA Takuya wrote: > Hi all, > > I want to backport JDK-8313394 for jdk21u. > This is clean backport. > > Would you review and sponsor this fix, please? This pull request has now been integrated. Changeset: 94634c08 Author: KIRIYAMA Takuya Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/94634c08e6eaecbdb61223d390c1fc4f8ebab848 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8313394: Array Elements in OldObjectSample event has the incorrect description Backport-of: e8c325dea39f959ab6bb310c3913b98655e95734 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/225 From mdoerr at openjdk.org Fri Mar 1 15:21:58 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 1 Mar 2024 15:21:58 GMT Subject: [jdk22u] Integrated: 8325326: [PPC64] Don't relocate in case of allocation failure In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 09:59:47 GMT, Martin Doerr wrote: > Clean backport of [JDK-8325326](https://bugs.openjdk.org/browse/JDK-8325326). This pull request has now been integrated. Changeset: aeb85fdc Author: Martin Doerr URL: https://git.openjdk.org/jdk22u/commit/aeb85fdceb19e0367733df46c67049493d907c66 Stats: 12 lines in 1 file changed: 6 ins; 2 del; 4 mod 8325326: [PPC64] Don't relocate in case of allocation failure Backport-of: 4388095cde20dec602ada9fe2977f1a359ceab91 ------------- PR: https://git.openjdk.org/jdk22u/pull/75 From mdoerr at openjdk.org Fri Mar 1 15:21:58 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 1 Mar 2024 15:21:58 GMT Subject: [jdk22u] Integrated: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 10:30:59 GMT, Martin Doerr wrote: > Basically clean backport of [JDK-8326101](https://bugs.openjdk.org/browse/JDK-8326101). I only had to integrate the ppc.ad parts manually because of the NULL -> nullptr replacement in JDK 23. This pull request has now been integrated. Changeset: e3ae81ee Author: Martin Doerr URL: https://git.openjdk.org/jdk22u/commit/e3ae81eeeee8e2b0063a576a90624dd927b512f0 Stats: 11 lines in 2 files changed: 9 ins; 0 del; 2 mod 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space Reviewed-by: mbaesken Backport-of: a19314b08789afb28e14651868f91d54ed6a9c30 ------------- PR: https://git.openjdk.org/jdk22u/pull/76 From jkuhn at openjdk.org Fri Mar 1 15:24:56 2024 From: jkuhn at openjdk.org (Johannes Kuhn) Date: Fri, 1 Mar 2024 15:24:56 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 12:52:28 GMT, Mar?a Arias de Reyna wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8280377 MethodHandleProxies does not correctly invoke default methods with varags > > I applied the same fix that was applied to version 19 in https://github.com/openjdk/jdk/commit/a183bfb436a7dd998e602c2d16486e88c390fca1 I did not read through the entire patch - @mlchung did comment on the bug report back then: > Alternative fix for backport consideration: > > @@ -343,7 +343,7 @@ public class MethodHandleProxies { > intfc, mk.getName(), > MethodType.methodType(mk.getReturnType(), mk.getParameterTypes()), > self.getClass()); > - return mh.asSpreader(Object[].class, mk.getParameterCount()); > + return mh.asFixedArity().asSpreader(Object[].class, mk.getParameterCount()); https://bugs.openjdk.org/browse/JDK-8280377?focusedId=14471119&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14471119 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#issuecomment-1973379395 From amitkumar at openjdk.org Fri Mar 1 15:28:58 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Fri, 1 Mar 2024 15:28:58 GMT Subject: [jdk17u] RFR: 8272903: Missing license header in ArenaAllocator.java [v2] In-Reply-To: References: <2G6lPPbqhafMmrBkOPWDsuZXeKFB6bNEXDN0yF5uHtw=.aecab267-7ed3-4e01-83e9-7708fd311400@github.com> Message-ID: On Fri, 1 Mar 2024 13:33:44 GMT, Severin Gehwolf wrote: >> @RealCLanger do we need to create separate PR manually for that or we can just use backport command like "/backport jdk17u-dev" ? > >> or we can just use backport command like "/backport jdk17u-dev" ? > > Yes, that should work. Please close this and use a PR for `jdk17u-dev` instead. Thanks @jerboaa ; ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/388#issuecomment-1973385248 From amitkumar at openjdk.org Fri Mar 1 15:28:59 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Fri, 1 Mar 2024 15:28:59 GMT Subject: [jdk17u] Withdrawn: 8272903: Missing license header in ArenaAllocator.java In-Reply-To: <2G6lPPbqhafMmrBkOPWDsuZXeKFB6bNEXDN0yF5uHtw=.aecab267-7ed3-4e01-83e9-7708fd311400@github.com> References: <2G6lPPbqhafMmrBkOPWDsuZXeKFB6bNEXDN0yF5uHtw=.aecab267-7ed3-4e01-83e9-7708fd311400@github.com> Message-ID: On Tue, 27 Feb 2024 15:38:37 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [96614da0](https://github.com/openjdk/jdk/commit/96614da0254e7fd4ac9dd3c3059bf23c1aaf37ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Maurizio Cimadamore on 9 Sep 2021 and was reviewed by Brian Burkhalter and Lance Andersen. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u/pull/388 From goetz at openjdk.org Fri Mar 1 15:42:05 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 1 Mar 2024 15:42:05 GMT Subject: [jdk21u-dev] RFR: 8322477: order of subclasses in the permits clause can differ between compilations Message-ID: I backport this for parity with 21.0.4-oracle. src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java I had to resolve because indentation is different. Changed coding is the same. ------------- Commit messages: - Backport 5ba69e17340cf44194c080a38219c6e150418fcf Changes: https://git.openjdk.org/jdk21u-dev/pull/310/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=310&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322477 Stats: 107 lines in 9 files changed: 68 ins; 1 del; 38 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/310.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/310/head:pull/310 PR: https://git.openjdk.org/jdk21u-dev/pull/310 From goetz at openjdk.org Fri Mar 1 15:45:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 1 Mar 2024 15:45:52 GMT Subject: [jdk21u-dev] RFR: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread In-Reply-To: References: Message-ID: <7T6SBRsACAURyIUr7KJHe7ksLNLUcUC3Un4R0um1E0s=.38738aa8-efae-418e-afce-7318d386de5a@github.com> On Mon, 26 Feb 2024 02:47:26 GMT, Vladimir Petko wrote: > Hi all, > > This pull request contains a backport of commit [d1099033](https://github.com/openjdk/jdk/commit/d1099033ac63b9dd0dd6e3a7341db929e9e0e56e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alan Bateman on 8 Feb 2024 and was reviewed by Brian Burkhalter. > > This change fixes a bug in jruby[1] that broken pipeline functions of Open3[1][2]. > > Thanks! > > [1] https://github.com/jruby/jruby/issues/8069 > [2] https://bugs.launchpad.net/ubuntu/+source/jruby/+bug/2054943 Thanks. I also ran it through our nightly testing. No issues found. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/290#issuecomment-1973413277 From mdoerr at openjdk.org Fri Mar 1 15:52:15 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 1 Mar 2024 15:52:15 GMT Subject: [jdk21u-dev] RFR: 8325326: [PPC64] Don't relocate in case of allocation failure Message-ID: Clean backport of [JDK-8325326](https://bugs.openjdk.org/browse/JDK-8325326). ------------- Commit messages: - Backport 4388095cde20dec602ada9fe2977f1a359ceab91 Changes: https://git.openjdk.org/jdk21u-dev/pull/311/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=311&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325326 Stats: 12 lines in 1 file changed: 6 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/311.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/311/head:pull/311 PR: https://git.openjdk.org/jdk21u-dev/pull/311 From mdoerr at openjdk.org Fri Mar 1 15:53:01 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 1 Mar 2024 15:53:01 GMT Subject: [jdk21u-dev] RFR: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space Message-ID: Clean backport of [JDK-8326101](https://bugs.openjdk.org/browse/JDK-8326101) from JDK 22u. ------------- Commit messages: - Backport e3ae81eeeee8e2b0063a576a90624dd927b512f0 Changes: https://git.openjdk.org/jdk21u-dev/pull/312/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=312&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326101 Stats: 11 lines in 2 files changed: 9 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/312.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/312/head:pull/312 PR: https://git.openjdk.org/jdk21u-dev/pull/312 From amitkumar at openjdk.org Fri Mar 1 16:21:18 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Fri, 1 Mar 2024 16:21:18 GMT Subject: [jdk17u-dev] RFR: 8272903: Missing license header in ArenaAllocator.java Message-ID: Hi all, This pull request contains a backport of commit [96614da0](https://github.com/openjdk/jdk/commit/96614da0254e7fd4ac9dd3c3059bf23c1aaf37ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Maurizio Cimadamore on 9 Sep 2021 and was reviewed by Brian Burkhalter and Lance Andersen. Thanks! ------------- Commit messages: - Backport 96614da0254e7fd4ac9dd3c3059bf23c1aaf37ff Changes: https://git.openjdk.org/jdk17u-dev/pull/2262/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2262&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272903 Stats: 25 lines in 1 file changed: 25 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2262.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2262/head:pull/2262 PR: https://git.openjdk.org/jdk17u-dev/pull/2262 From shade at openjdk.org Fri Mar 1 17:01:53 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 1 Mar 2024 17:01:53 GMT Subject: [jdk21u-dev] RFR: 8322477: order of subclasses in the permits clause can differ between compilations In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 15:36:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. > > src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java > I had to resolve because indentation is different. Changed coding is the same. I am surprised we have indenting conflicts. Shouldn't we do the backport of https://bugs.openjdk.org/browse/JDK-8319987 first? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/310#issuecomment-1973544503 From szaldana at openjdk.org Fri Mar 1 17:45:21 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Fri, 1 Mar 2024 17:45:21 GMT Subject: [jdk21u-dev] RFR: 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [9481d06e](https://github.com/openjdk/jdk/commit/9481d06e62334872af539ccfb8c1ea25e30a6da3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Renjith Kannath Pariyangad on 2 Jan 2024 and was reviewed by Alexey Ivanov. > > Thanks! Sonia Zaldana Calles has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-SoniaZaldana-9481d06e - Backport 9481d06e62334872af539ccfb8c1ea25e30a6da3 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/165/files - new: https://git.openjdk.org/jdk21u-dev/pull/165/files/01f1c1df..cddbfeb3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=165&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=165&range=00-01 Stats: 18422 lines in 644 files changed: 12072 ins; 4136 del; 2214 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/165.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/165/head:pull/165 PR: https://git.openjdk.org/jdk21u-dev/pull/165 From ashi at openjdk.org Fri Mar 1 22:19:18 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 1 Mar 2024 22:19:18 GMT Subject: [jdk11u-dev] RFR: 8281507: Two javac tests have bad jtreg `@clean` tags In-Reply-To: References: Message-ID: <48CKWzxalnqEfHU19dy4WOSp0uKSUrHC6ku9yox_rOQ=.b08c21cf-e19c-4430-9905-6ce34ddd4077@github.com> On Wed, 28 Feb 2024 18:11:59 GMT, Amos Shi wrote: > Added to test environments to validate SAP nightlies passed on `2024-02-29`, `2024-03-01` @shipilev ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2556#issuecomment-1974008153 From vpetko at openjdk.org Fri Mar 1 22:49:59 2024 From: vpetko at openjdk.org (Vladimir Petko) Date: Fri, 1 Mar 2024 22:49:59 GMT Subject: [jdk22u] RFR: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread In-Reply-To: References: Message-ID: <-NFoTwOpzqao3rPnVAFjV3XbYESMg2bg_lEWkpaN71o=.ef8da6e5-e4c5-4993-83d7-aaf323e19c0b@github.com> On Fri, 1 Mar 2024 08:32:03 GMT, Vladimir Petko wrote: > Hi all, > > This pull request contains a backport of commit [d1099033](https://github.com/openjdk/jdk/commit/d1099033ac63b9dd0dd6e3a7341db929e9e0e56e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alan Bateman on 8 Feb 2024 and was reviewed by Brian Burkhalter. > > This change fixes a bug in jruby[1] that broken pipeline functions of Open3[1][2]. > > Thanks! > > [1] https://github.com/jruby/jruby/issues/8069 > [2] https://bugs.launchpad.net/ubuntu/+source/jruby/+bug/2054943 GHA failure setting up RISCV schroot. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/79#issuecomment-1974035922 From serb at openjdk.org Sat Mar 2 02:48:56 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 2 Mar 2024 02:48:56 GMT Subject: [jdk21u-dev] Integrated: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA In-Reply-To: References: Message-ID: On Tue, 9 Jan 2024 22:15:00 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/aba19334eaeb46d37169cddeef929b13e050a60e from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 9 Jan 2024 and was reviewed by Philip Race. > > Thanks! This pull request has now been integrated. Changeset: ee6445c4 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk21u-dev/commit/ee6445c4952171b42b05638e5ea46a0b35fc4b99 Stats: 8 lines in 2 files changed: 5 ins; 0 del; 3 mod 8323210: Update the usage of cmsFLAGS_COPY_ALPHA Backport-of: aba19334eaeb46d37169cddeef929b13e050a60e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/156 From serb at openjdk.org Sat Mar 2 04:45:54 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 2 Mar 2024 04:45:54 GMT Subject: [jdk17u-dev] Integrated: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA In-Reply-To: References: Message-ID: <958zt29CSqGliSdeTeKAexLfOc9cL6i011f3y3bsKPk=.57506315-a09a-4888-8950-e48b334cae3d@github.com> On Wed, 10 Jan 2024 01:23:13 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/aba19334eaeb46d37169cddeef929b13e050a60e from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 9 Jan 2024 and was reviewed by Philip Race. > > The patch is functionally the same but different in context due to the next patch is missing in 17: > https://bugs.openjdk.org/browse/JDK-8294488 I do not plan to backport that cleanup > > Thanks! This pull request has now been integrated. Changeset: ab602af4 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/ab602af46251f29541826c57de5e1236f317acda Stats: 8 lines in 2 files changed: 5 ins; 0 del; 3 mod 8323210: Update the usage of cmsFLAGS_COPY_ALPHA Reviewed-by: phh Backport-of: aba19334eaeb46d37169cddeef929b13e050a60e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2118 From amitkumar at openjdk.org Mon Mar 4 02:07:53 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 4 Mar 2024 02:07:53 GMT Subject: [jdk17u-dev] RFR: 8272903: Missing license header in ArenaAllocator.java In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 16:16:23 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [96614da0](https://github.com/openjdk/jdk/commit/96614da0254e7fd4ac9dd3c3059bf23c1aaf37ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Maurizio Cimadamore on 9 Sep 2021 and was reviewed by Brian Burkhalter and Lance Andersen. > > Thanks! @RealCLanger would you please sponsor this change? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2262#issuecomment-1975526905 From andrewlu at openjdk.org Mon Mar 4 03:11:55 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 4 Mar 2024 03:11:55 GMT Subject: [jdk21u-dev] Integrated: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053 In-Reply-To: <0SEe-LC49XuVuyRFIIFO5sGnVucVED3IJHxnf64xHBk=.a42a515d-1138-41b5-959f-78a841207fa7@github.com> References: <0SEe-LC49XuVuyRFIIFO5sGnVucVED3IJHxnf64xHBk=.a42a515d-1138-41b5-959f-78a841207fa7@github.com> Message-ID: On Wed, 28 Feb 2024 07:24:18 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 500d85aa Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/500d85aad72b4bfd64ba6208e9bdd49cd3992956 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053 Backport-of: e4803e0cbf00da89b98c8703769edc403bb5055b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/298 From andrewlu at openjdk.org Mon Mar 4 03:17:05 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 4 Mar 2024 03:17:05 GMT Subject: [jdk17u-dev] RFR: 8320303: Allow PassFailJFrame to accept single window creator [v2] In-Reply-To: References: Message-ID: <-xljSLQalJmMv_JP5gTed_pgYJEnVnZhT9jrEOc-lUA=.ad427da6-3669-4539-b34f-8011a5caf192@github.com> > I backport this for parity with 17.0.11-oracle. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-luchenlin-83ffc1ac - Backport 83ffc1ac94b8893532d8663b9058592f1714d337 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2247/files - new: https://git.openjdk.org/jdk17u-dev/pull/2247/files/4aba9d6f..4cd78c02 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2247&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2247&range=00-01 Stats: 370 lines in 56 files changed: 156 ins; 59 del; 155 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2247.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2247/head:pull/2247 PR: https://git.openjdk.org/jdk17u-dev/pull/2247 From andrewlu at openjdk.org Mon Mar 4 03:17:15 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 4 Mar 2024 03:17:15 GMT Subject: [jdk17u-dev] RFR: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053 [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.11-oracle. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-luchenlin-e4803e0c - Backport e4803e0cbf00da89b98c8703769edc403bb5055b ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2246/files - new: https://git.openjdk.org/jdk17u-dev/pull/2246/files/fe5dcca7..b5427231 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2246&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2246&range=00-01 Stats: 388 lines in 66 files changed: 160 ins; 60 del; 168 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2246.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2246/head:pull/2246 PR: https://git.openjdk.org/jdk17u-dev/pull/2246 From andrewlu at openjdk.org Mon Mar 4 03:26:01 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 4 Mar 2024 03:26:01 GMT Subject: [jdk21u-dev] RFR: 8325972: Add -x to bash for building with LOG=debug Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 8668198c26bdac412f0a9d1255ca74da860761c5 Changes: https://git.openjdk.org/jdk21u-dev/pull/315/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=315&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325972 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/315.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/315/head:pull/315 PR: https://git.openjdk.org/jdk21u-dev/pull/315 From andrewlu at openjdk.org Mon Mar 4 05:41:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 4 Mar 2024 05:41:06 GMT Subject: [jdk17u-dev] RFR: 8325972: Add -x to bash for building with LOG=debug Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 8668198c26bdac412f0a9d1255ca74da860761c5 Changes: https://git.openjdk.org/jdk17u-dev/pull/2264/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2264&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325972 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2264.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2264/head:pull/2264 PR: https://git.openjdk.org/jdk17u-dev/pull/2264 From andrewlu at openjdk.org Mon Mar 4 05:48:00 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 4 Mar 2024 05:48:00 GMT Subject: [jdk11u-dev] RFR: 8325972: Add -x to bash for building with LOG=debug Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 8668198c26bdac412f0a9d1255ca74da860761c5 Changes: https://git.openjdk.org/jdk11u-dev/pull/2579/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2579&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325972 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2579.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2579/head:pull/2579 PR: https://git.openjdk.org/jdk11u-dev/pull/2579 From amitkumar at openjdk.org Mon Mar 4 06:49:52 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 4 Mar 2024 06:49:52 GMT Subject: [jdk17u-dev] Integrated: 8272903: Missing license header in ArenaAllocator.java In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 16:16:23 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [96614da0](https://github.com/openjdk/jdk/commit/96614da0254e7fd4ac9dd3c3059bf23c1aaf37ff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Maurizio Cimadamore on 9 Sep 2021 and was reviewed by Brian Burkhalter and Lance Andersen. > > Thanks! This pull request has now been integrated. Changeset: 3add2e32 Author: Amit Kumar Committer: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/3add2e32041a7a0f1cf9865c30315c504a36b9cc Stats: 25 lines in 1 file changed: 25 ins; 0 del; 0 mod 8272903: Missing license header in ArenaAllocator.java Backport-of: 96614da0254e7fd4ac9dd3c3059bf23c1aaf37ff ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2262 From thartmann at openjdk.org Mon Mar 4 07:33:56 2024 From: thartmann at openjdk.org (Tobias Hartmann) Date: Mon, 4 Mar 2024 07:33:56 GMT Subject: [jdk22u] Integrated: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 06:31:02 GMT, Tobias Hartmann wrote: > Hi all, > > This pull request contains a backport of commit [9f0e7da6](https://github.com/openjdk/jdk/commit/9f0e7da64e21237322e55ca4f0e3639fa5d1c4ed) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Tobias Hartmann on 27 Feb 2024 and was reviewed by Christian Hagedorn and Vladimir Kozlov. > > Thanks! This pull request has now been integrated. Changeset: 1a2b1223 Author: Tobias Hartmann URL: https://git.openjdk.org/jdk22u/commit/1a2b12239ca78cbd13b6d9edd23ec62381bd9d05 Stats: 60 lines in 2 files changed: 57 ins; 0 del; 3 mod 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop Backport-of: 9f0e7da64e21237322e55ca4f0e3639fa5d1c4ed ------------- PR: https://git.openjdk.org/jdk22u/pull/71 From thartmann at openjdk.org Mon Mar 4 07:34:55 2024 From: thartmann at openjdk.org (Tobias Hartmann) Date: Mon, 4 Mar 2024 07:34:55 GMT Subject: [jdk22u] Integrated: 8325672: C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena() In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 06:38:28 GMT, Tobias Hartmann wrote: > Hi all, > > This pull request contains a backport of commit [74b90aa8](https://github.com/openjdk/jdk/commit/74b90aa87e7cfa52ac09bf2e57258d792f740f00) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Emanuel Peter on 13 Feb 2024 and was reviewed by Vladimir Kozlov and Christian Hagedorn. > > Thanks! This pull request has now been integrated. Changeset: 78df8c1e Author: Tobias Hartmann URL: https://git.openjdk.org/jdk22u/commit/78df8c1e0e5e2f68696431409088adcdb2a7305a Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8325672: C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena() Backport-of: 74b90aa87e7cfa52ac09bf2e57258d792f740f00 ------------- PR: https://git.openjdk.org/jdk22u/pull/72 From thartmann at openjdk.org Mon Mar 4 07:34:58 2024 From: thartmann at openjdk.org (Tobias Hartmann) Date: Mon, 4 Mar 2024 07:34:58 GMT Subject: [jdk22u] Integrated: 8317299: safepoint scalarization doesn't keep track of the depth of the JVM state In-Reply-To: References: Message-ID: <1GcAwMGXpiCnmrpyX7eCF7oxpapegR2mpwe55WGgPhg=.204c93a5-9608-4ff8-9a57-9bdc03b60f1c@github.com> On Wed, 28 Feb 2024 06:50:47 GMT, Tobias Hartmann wrote: > Hi all, > > This pull request contains a backport of commit [6d911f68](https://github.com/openjdk/jdk/commit/6d911f68a3244c40a62ab2570dfec68b8d0ed5d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Damon Fenacci on 6 Feb 2024 and was reviewed by Tobias Hartmann and Vladimir Ivanov. > > Thanks! This pull request has now been integrated. Changeset: dd4dc386 Author: Tobias Hartmann URL: https://git.openjdk.org/jdk22u/commit/dd4dc386ab8ea59eaaee4a6c270202925ea85259 Stats: 22 lines in 5 files changed: 13 ins; 0 del; 9 mod 8317299: safepoint scalarization doesn't keep track of the depth of the JVM state Backport-of: 6d911f68a3244c40a62ab2570dfec68b8d0ed5d8 ------------- PR: https://git.openjdk.org/jdk22u/pull/74 From thartmann at openjdk.org Mon Mar 4 07:35:52 2024 From: thartmann at openjdk.org (Tobias Hartmann) Date: Mon, 4 Mar 2024 07:35:52 GMT Subject: [jdk22u] Integrated: 8323154: C2: assert(cmp != nullptr && cmp->Opcode() == Op_Cmp(bt)) failed: no exit test In-Reply-To: <2BFMHhWRvMIJQ-bk40PXtugrzPACURUk0GciP72w2dA=.6c06db85-829c-4fdc-bb39-80a006cce706@github.com> References: <2BFMHhWRvMIJQ-bk40PXtugrzPACURUk0GciP72w2dA=.6c06db85-829c-4fdc-bb39-80a006cce706@github.com> Message-ID: <9X1UDgZADCrZTGLVjxdm7_5Zkcr1WxfcB34-gnTKB6o=.56d85a22-d5f5-40fe-94ab-67c49aac3943@github.com> On Wed, 28 Feb 2024 06:42:56 GMT, Tobias Hartmann wrote: > Hi all, > > This pull request contains a backport of commit [6997bfc6](https://github.com/openjdk/jdk/commit/6997bfc68def7f80fbf6a7486a4b9f61225fc471) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Christian Hagedorn on 19 Jan 2024 and was reviewed by Roland Westrelin, Tobias Hartmann and Quan Anh Mai. > > Thanks! This pull request has now been integrated. Changeset: b73c15e5 Author: Tobias Hartmann URL: https://git.openjdk.org/jdk22u/commit/b73c15e57ae0ee4100f4067423f0a6b13b74ec5d Stats: 50 lines in 2 files changed: 49 ins; 0 del; 1 mod 8323154: C2: assert(cmp != nullptr && cmp->Opcode() == Op_Cmp(bt)) failed: no exit test Backport-of: 6997bfc68def7f80fbf6a7486a4b9f61225fc471 ------------- PR: https://git.openjdk.org/jdk22u/pull/73 From mbaesken at openjdk.org Mon Mar 4 08:18:03 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 4 Mar 2024 08:18:03 GMT Subject: [jdk22u] RFR: 8324834: Use _LARGE_FILES on AIX Message-ID: 8324834: Use _LARGE_FILES on AIX ------------- Commit messages: - Backport 8e45182357f4990c86fd0b711a7a91887945480b Changes: https://git.openjdk.org/jdk22u/pull/82/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=82&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324834 Stats: 21 lines in 4 files changed: 4 ins; 0 del; 17 mod Patch: https://git.openjdk.org/jdk22u/pull/82.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/82/head:pull/82 PR: https://git.openjdk.org/jdk22u/pull/82 From mbaesken at openjdk.org Mon Mar 4 08:24:10 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 4 Mar 2024 08:24:10 GMT Subject: [jdk21u-dev] RFR: 8324834: Use _LARGE_FILES on AIX Message-ID: 8324834: Use _LARGE_FILES on AIX ------------- Commit messages: - Backport 8e45182357f4990c86fd0b711a7a91887945480b Changes: https://git.openjdk.org/jdk21u-dev/pull/316/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=316&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324834 Stats: 21 lines in 4 files changed: 4 ins; 0 del; 17 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/316.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/316/head:pull/316 PR: https://git.openjdk.org/jdk21u-dev/pull/316 From shade at openjdk.org Mon Mar 4 08:33:59 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 4 Mar 2024 08:33:59 GMT Subject: [jdk11u-dev] RFR: 8281507: Two javac tests have bad jtreg `@clean` tags In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 11:36:26 GMT, Aleksey Shipilev wrote: > Semi-clean backport on the way to jtreg update. Both files still have source/target=6 blocks, which need to be handled as well. > > Additional testing: > - [x] Affected tests now pass with jtreg 7.3.1+1 Thanks! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2556#issuecomment-1975998443 From shade at openjdk.org Mon Mar 4 08:33:59 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 4 Mar 2024 08:33:59 GMT Subject: [jdk11u-dev] Integrated: 8281507: Two javac tests have bad jtreg `@clean` tags In-Reply-To: References: Message-ID: <2TOVD1ghv90Y3NMV0c1ip0JUh-29vbDiUIweD6qdThM=.9f30d453-589b-46b1-ba6b-2b2a11be917a@github.com> On Mon, 26 Feb 2024 11:36:26 GMT, Aleksey Shipilev wrote: > Semi-clean backport on the way to jtreg update. Both files still have source/target=6 blocks, which need to be handled as well. > > Additional testing: > - [x] Affected tests now pass with jtreg 7.3.1+1 This pull request has now been integrated. Changeset: a582e118 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk11u-dev/commit/a582e1180cd61b81407c4d9b0d64d343e716ff12 Stats: 8 lines in 2 files changed: 0 ins; 0 del; 8 mod 8281507: Two javac tests have bad jtreg `@clean` tags Reviewed-by: mbaesken Backport-of: 86723d4892485651bcae735ed13545ea89b9bb22 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2556 From shade at openjdk.org Mon Mar 4 08:35:58 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 4 Mar 2024 08:35:58 GMT Subject: [jdk11u-dev] Integrated: 8326938: [11u] JDK-8214908 broke two CTW tests In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 10:08:06 GMT, Aleksey Shipilev wrote: > This is a 11u-specific test bug. Not sure how the original backport passed testing, because the failure reproduces reliably. See more investigation in the bug itself. This PR reverts the entire https://github.com/openjdk/jdk11u-dev/commit/9d4da7c1dfb829ef5973857c2707b0feadeaa8c7 commit. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `applications/ctw/modules` now passes This pull request has now been integrated. Changeset: f6e6eefc Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk11u-dev/commit/f6e6eefcc10f85ee289bbcc8de9caba1c915beeb Stats: 4 lines in 2 files changed: 0 ins; 2 del; 2 mod 8326938: [11u] JDK-8214908 broke two CTW tests Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2570 From andrewlu at openjdk.org Mon Mar 4 08:38:08 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 4 Mar 2024 08:38:08 GMT Subject: [jdk11u-dev] RFR: 8248667: Need support for building native libraries located in the test/lib directory Message-ID: Backport for JDK-8248194 and JDK-8248667 ------------- Commit messages: - Backport 1356a0f1ac06b006a20ca9fa2306ef60aef5c16e Changes: https://git.openjdk.org/jdk11u-dev/pull/2580/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2580&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8248667 Stats: 638 lines in 10 files changed: 463 ins; 137 del; 38 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2580.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2580/head:pull/2580 PR: https://git.openjdk.org/jdk11u-dev/pull/2580 From rehn at openjdk.org Mon Mar 4 08:38:12 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Mon, 4 Mar 2024 08:38:12 GMT Subject: [jdk22u] RFR: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support Message-ID: Hi all, This pull request contains a backport of commit [68eb5a1d](https://github.com/openjdk/jdk/commit/68eb5a1df5afdc011aa467f1c723a8792532dd3f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Robbin Ehn on 21 Feb 2024 and was reviewed by Fei Yang, Yadong Wang and Ludovic Henry. Thanks! ------------- Commit messages: - Backport 68eb5a1df5afdc011aa467f1c723a8792532dd3f Changes: https://git.openjdk.org/jdk22u/pull/83/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=83&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321075 Stats: 40 lines in 3 files changed: 39 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/83.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/83/head:pull/83 PR: https://git.openjdk.org/jdk22u/pull/83 From andrewlu at openjdk.org Mon Mar 4 09:16:08 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 4 Mar 2024 09:16:08 GMT Subject: [jdk21u-dev] RFR: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 9f0e7da64e21237322e55ca4f0e3639fa5d1c4ed Changes: https://git.openjdk.org/jdk21u-dev/pull/317/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=317&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326638 Stats: 60 lines in 2 files changed: 57 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/317.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/317/head:pull/317 PR: https://git.openjdk.org/jdk21u-dev/pull/317 From goetz at openjdk.org Mon Mar 4 09:16:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 09:16:35 GMT Subject: [jdk17u] RFR: 8305900: Use loopback IP addresses in security policy files of httpclient tests Message-ID: <9DFiZbHnoEzJ8ek5BD4UxYILaPxoB17gsSSa2aXR2-I=.e37b5c31-5453-48da-a9af-350de624173c@github.com> I backport this to fix testing issues with ConnectionReueseTest.java that showed after backporting https://bugs.openjdk.org/browse/JDK-8305906. Jaikiran proposes to do a local fix, but I think backporting this test-only change keeps the test suite better up-to-date. Also later similar issues will be avoided. Some simple adaptions were needed: test/jdk/java/net/httpclient/AsFileDownloadTest.java Trivial resolve. test/jdk/java/net/httpclient/httpclient-localaddr-security.policy File not in 17. Skipped. test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServer.java Trivial resolve, file in other loction. ------------- Commit messages: - Backport 646b666a265c4de961b8ba3f9e4e8c9231be8a6f Changes: https://git.openjdk.org/jdk17u/pull/390/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=390&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305900 Stats: 429 lines in 32 files changed: 193 ins; 38 del; 198 mod Patch: https://git.openjdk.org/jdk17u/pull/390.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/390/head:pull/390 PR: https://git.openjdk.org/jdk17u/pull/390 From andrewlu at openjdk.org Mon Mar 4 09:48:22 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 4 Mar 2024 09:48:22 GMT Subject: [jdk17u-dev] RFR: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 9f0e7da64e21237322e55ca4f0e3639fa5d1c4ed Changes: https://git.openjdk.org/jdk17u-dev/pull/2265/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2265&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326638 Stats: 60 lines in 2 files changed: 57 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2265.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2265/head:pull/2265 PR: https://git.openjdk.org/jdk17u-dev/pull/2265 From andrewlu at openjdk.org Mon Mar 4 09:49:16 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 4 Mar 2024 09:49:16 GMT Subject: [jdk11u-dev] RFR: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 9f0e7da64e21237322e55ca4f0e3639fa5d1c4ed Changes: https://git.openjdk.org/jdk11u-dev/pull/2581/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2581&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326638 Stats: 60 lines in 2 files changed: 57 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2581.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2581/head:pull/2581 PR: https://git.openjdk.org/jdk11u-dev/pull/2581 From goetz at openjdk.org Mon Mar 4 10:15:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 10:15:58 GMT Subject: [jdk21u-dev] RFR: 8306040: HttpResponseInputStream.available() returns 1 on empty stream In-Reply-To: References: Message-ID: <3__DkkegefUvBnNzfWrPdPO13DaU0BIHxzsxp_S9T_c=.fda52c86-fb99-4c4a-bf98-978e2639b0a6@github.com> On Fri, 1 Mar 2024 14:56:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: Well known Risk-V build issue. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/309#issuecomment-1976230175 From goetz at openjdk.org Mon Mar 4 10:24:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 10:24:52 GMT Subject: [jdk21u-dev] RFR: 8322477: order of subclasses in the permits clause can differ between compilations In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 15:36:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. > > src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java > I had to resolve because indentation is different. Changed coding is the same. GHA failure: Well known Risk-V build issue. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/310#issuecomment-1976246923 From goetz at openjdk.org Mon Mar 4 10:27:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 10:27:56 GMT Subject: [jdk21u-dev] RFR: 8322477: order of subclasses in the permits clause can differ between compilations In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 15:36:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. > > src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java > I had to resolve because indentation is different. Changed coding is the same. Hi, yes, JDK-8319987 might make Types.java clean. in Attr.java, the indentation was changed by https://bugs.openjdk.org/browse/JDK-8316470: Incorrect error location for "invalid permits clause" depending on file order. I don't think we should backport all dependencies just to avoid trivial conflicts. I chose this one to keep track with Oracle. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/310#issuecomment-1976253165 From shade at openjdk.org Mon Mar 4 11:21:56 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 4 Mar 2024 11:21:56 GMT Subject: [jdk17u-dev] Integrated: 8323519: Add applications/ctw/modules to Hotspot tiered testing In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 13:49:45 GMT, Aleksey Shipilev wrote: > Clean backport to improve testing. This pull request has now been integrated. Changeset: bfe8974e Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/bfe8974e532952bfd255d85d9afe7043b8a09a55 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8323519: Add applications/ctw/modules to Hotspot tiered testing Backport-of: ba3c3bbd879eaf7532663663d73e21fafc65b574 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2258 From shade at openjdk.org Mon Mar 4 11:22:53 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 4 Mar 2024 11:22:53 GMT Subject: [jdk21u-dev] Integrated: 8323519: Add applications/ctw/modules to Hotspot tiered testing In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 13:46:35 GMT, Aleksey Shipilev wrote: > Clean backport to improve testing. This pull request has now been integrated. Changeset: dbcce04a Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/dbcce04ae9e3ee903cadf7b877aee34ea21ed9ea Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8323519: Add applications/ctw/modules to Hotspot tiered testing Backport-of: ba3c3bbd879eaf7532663663d73e21fafc65b574 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/304 From mbaesken at openjdk.org Mon Mar 4 11:28:52 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 4 Mar 2024 11:28:52 GMT Subject: [jdk17u] RFR: 8305900: Use loopback IP addresses in security policy files of httpclient tests In-Reply-To: <9DFiZbHnoEzJ8ek5BD4UxYILaPxoB17gsSSa2aXR2-I=.e37b5c31-5453-48da-a9af-350de624173c@github.com> References: <9DFiZbHnoEzJ8ek5BD4UxYILaPxoB17gsSSa2aXR2-I=.e37b5c31-5453-48da-a9af-350de624173c@github.com> Message-ID: On Mon, 4 Mar 2024 09:11:09 GMT, Goetz Lindenmaier wrote: > I backport this to fix testing issues with ConnectionReueseTest.java that showed after backporting https://bugs.openjdk.org/browse/JDK-8305906. > > Jaikiran proposes to do a local fix, but I think backporting this test-only change keeps the test suite better up-to-date. Also later similar issues will be avoided. > > Some simple adaptions were needed: > > test/jdk/java/net/httpclient/AsFileDownloadTest.java > Trivial resolve. > > test/jdk/java/net/httpclient/httpclient-localaddr-security.policy > File not in 17. Skipped. > > test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java > test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServer.java > Trivial resolve, file in other loction. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u/pull/390#pullrequestreview-1914067705 From mgronlun at openjdk.org Mon Mar 4 11:39:53 2024 From: mgronlun at openjdk.org (Markus =?UTF-8?B?R3LDtm5sdW5k?=) Date: Mon, 4 Mar 2024 11:39:53 GMT Subject: [jdk11u-dev] RFR: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id [v2] In-Reply-To: References: Message-ID: <67SMliQUzJoeAmuHTXm46uJg_48WjwRnL44MZwvxj2c=.8d3725a9-877a-4c85-9b57-1964e5bada47@github.com> On Tue, 30 Jan 2024 09:42:03 GMT, ??? wrote: >> It isn't a clean backport for two reasons. >> 1. jdk11 cannot use nullptr, so it should use NULL instead. >> 2. `parent_thread_group_handle != NULL` will cause a compile error without a type cast. >> >> This backport prevents a JFR operation from accessing an illegal address which has not be filled before the initialization of a JavaThread, which is created from a JNI interface. >> >> The risk is very low since it only adds a null pointer check. Besides, This backport has be accepted in [jdk17-dev](https://github.com/openjdk/jdk17u-dev/pull/2179). >> >> Additional testing: >> - [x] Linux aarch64 server fastdebug, test/jdk/jdk/jfr passed > > ??? has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport a885aab696777c99c8c4c5d9a46afc5fe0a4fe47 Marked as reviewed by mgronlun (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2501#pullrequestreview-1914088470 From mbaesken at openjdk.org Mon Mar 4 11:48:52 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 4 Mar 2024 11:48:52 GMT Subject: [jdk21u-dev] Integrated: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 13:07:15 GMT, Matthias Baesken wrote: > 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests This pull request has now been integrated. Changeset: fdbed07d Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/fdbed07d38d4217d209380544d4447ce9b85bad7 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests Backport-of: 9f4ec21f4793d4c5fc10f93a32140c26ec0eec00 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/308 From goetz at openjdk.org Mon Mar 4 12:02:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 12:02:56 GMT Subject: [jdk17u] RFR: 8305900: Use loopback IP addresses in security policy files of httpclient tests In-Reply-To: <9DFiZbHnoEzJ8ek5BD4UxYILaPxoB17gsSSa2aXR2-I=.e37b5c31-5453-48da-a9af-350de624173c@github.com> References: <9DFiZbHnoEzJ8ek5BD4UxYILaPxoB17gsSSa2aXR2-I=.e37b5c31-5453-48da-a9af-350de624173c@github.com> Message-ID: On Mon, 4 Mar 2024 09:11:09 GMT, Goetz Lindenmaier wrote: > I backport this to fix testing issues with ConnectionReueseTest.java that showed after backporting https://bugs.openjdk.org/browse/JDK-8305906. > > Jaikiran proposes to do a local fix, but I think backporting this test-only change keeps the test suite better up-to-date. Also later similar issues will be avoided. > > Some simple adaptions were needed: > > test/jdk/java/net/httpclient/AsFileDownloadTest.java > Trivial resolve. > > test/jdk/java/net/httpclient/httpclient-localaddr-security.policy > File not in 17. Skipped. > > test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java > test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServer.java > Trivial resolve, file in other loction. GHA-failure: known Risc-V build problem. ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/390#issuecomment-1976423567 From duke at openjdk.org Mon Mar 4 12:32:09 2024 From: duke at openjdk.org (Jiawei Tang) Date: Mon, 4 Mar 2024 12:32:09 GMT Subject: [jdk11u-dev] RFR: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id [v3] In-Reply-To: References: Message-ID: > It isn't a clean backport for two reasons. > 1. jdk11 cannot use nullptr, so it should use NULL instead. > 2. `parent_thread_group_handle != NULL` will cause a compile error without a type cast. > > This backport prevents a JFR operation from accessing an illegal address which has not be filled before the initialization of a JavaThread, which is created from a JNI interface. > > The risk is very low since it only adds a null pointer check. Besides, This backport has be accepted in [jdk17-dev](https://github.com/openjdk/jdk17u-dev/pull/2179). > > Additional testing: > - [x] Linux aarch64 server fastdebug, test/jdk/jdk/jfr passed Jiawei Tang has updated the pull request incrementally with one additional commit since the last revision: Update full name ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2501/files - new: https://git.openjdk.org/jdk11u-dev/pull/2501/files/a929af31..e720c8a6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2501&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2501&range=01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2501.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2501/head:pull/2501 PR: https://git.openjdk.org/jdk11u-dev/pull/2501 From rehn at openjdk.org Mon Mar 4 12:52:58 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Mon, 4 Mar 2024 12:52:58 GMT Subject: [jdk21u-dev] RFR: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support [v2] In-Reply-To: <9QpsRx46Z81i8gfhceeZdBfhR7MZNutmsihst1_oBQ8=.d26e1de0-a67d-498e-9345-b5ee85113f24@github.com> References: <9QpsRx46Z81i8gfhceeZdBfhR7MZNutmsihst1_oBQ8=.d26e1de0-a67d-498e-9345-b5ee85113f24@github.com> Message-ID: On Thu, 29 Feb 2024 12:39:20 GMT, Ludovic Henry wrote: >> 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support > > Ludovic Henry has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' of github.com:openjdk/jdk21u into backport-luhenry-68eb5a1d > - Backport 68eb5a1df5afdc011aa467f1c723a8792532dd3f Thanks! ------------- Marked as reviewed by rehn (Committer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/294#pullrequestreview-1914237094 From ogillespie at openjdk.org Mon Mar 4 13:46:19 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Mon, 4 Mar 2024 13:46:19 GMT Subject: [jdk21u-dev] RFR: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [69b2674c](https://github.com/openjdk/jdk/commit/69b2674c6861fdb7d9f9cb39e07d50515c73e33a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev, Weijun Wang, Chen Liang and Valerie Peng. > > Thanks! Oli Gillespie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into backport-olivergillespie-69b2674c - Backport 69b2674c6861fdb7d9f9cb39e07d50515c73e33a ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/257/files - new: https://git.openjdk.org/jdk21u-dev/pull/257/files/01292d85..2913778a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=257&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=257&range=00-01 Stats: 4758 lines in 208 files changed: 3752 ins; 301 del; 705 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/257.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/257/head:pull/257 PR: https://git.openjdk.org/jdk21u-dev/pull/257 From ogillespie at openjdk.org Mon Mar 4 13:53:21 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Mon, 4 Mar 2024 13:53:21 GMT Subject: [jdk21u-dev] RFR: 8324646: Avoid Class.forName in SecureRandom constructor [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [8ef918d6](https://github.com/openjdk/jdk/commit/8ef918d6678437a5b351b172bb4cf144eeaa975f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev and Weijun Wang. > > Thanks! Oli Gillespie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into backport-olivergillespie-8ef918d6 - Backport 8ef918d6678437a5b351b172bb4cf144eeaa975f ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/258/files - new: https://git.openjdk.org/jdk21u-dev/pull/258/files/765bc40a..39d16242 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=258&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=258&range=00-01 Stats: 4758 lines in 208 files changed: 3752 ins; 301 del; 705 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/258.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/258/head:pull/258 PR: https://git.openjdk.org/jdk21u-dev/pull/258 From goetz at openjdk.org Mon Mar 4 14:22:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 14:22:53 GMT Subject: [jdk21u-dev] RFR: 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java In-Reply-To: References: Message-ID: On Wed, 14 Feb 2024 14:33:18 GMT, Sonia Zaldana Calles wrote: >> Hi >> to rerun the GHA either go to your branch (at the top right) [openjdk-bots:backport-SoniaZaldana-9481d06e](https://github.com/openjdk-bots/jdk21u-dev/tree/backport-SoniaZaldana-9481d06e) >> and there click "Sync fork" and then "update branch". >> Alternatively you can start them by going to the branch, select the Action tab, select the run, and click "Re-run all jobs." > > Hi @GoeLin, I don't seem to have write access for the bot fork so I'm unable to sync the fork or re-run any actions. @SoniaZaldana, seems your re-run workde. We now only see the well known Risk-V issue. Is there anything else keeping you from integrating this? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/165#issuecomment-1976688379 From szaldana at openjdk.org Mon Mar 4 14:30:55 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 4 Mar 2024 14:30:55 GMT Subject: [jdk21u-dev] RFR: 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java In-Reply-To: References: Message-ID: <0RbvlnkfuuotYIyElOnj2bgxEGAW7GlL3XNC8Q73n50=.b410f9a2-f1a3-4eaa-8c74-0933db23b438@github.com> On Wed, 14 Feb 2024 14:33:18 GMT, Sonia Zaldana Calles wrote: >> Hi >> to rerun the GHA either go to your branch (at the top right) [openjdk-bots:backport-SoniaZaldana-9481d06e](https://github.com/openjdk-bots/jdk21u-dev/tree/backport-SoniaZaldana-9481d06e) >> and there click "Sync fork" and then "update branch". >> Alternatively you can start them by going to the branch, select the Action tab, select the run, and click "Re-run all jobs." > > Hi @GoeLin, I don't seem to have write access for the bot fork so I'm unable to sync the fork or re-run any actions. > @SoniaZaldana, seems your re-run workde. We now only see the well known Risk-V issue. Is there anything else keeping you from integrating this? No, I was just waiting to see if the Risk-V issue got resolved. I'll integrate. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/165#issuecomment-1976703622 From goetz at openjdk.org Mon Mar 4 14:41:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 14:41:21 GMT Subject: [jdk21u-dev] RFR: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 57fc9a3e968cafe3b618a216630e703a39d5676e Changes: https://git.openjdk.org/jdk21u-dev/pull/318/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=318&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309763 Stats: 0 lines in 5 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/318.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/318/head:pull/318 PR: https://git.openjdk.org/jdk21u-dev/pull/318 From goetz at openjdk.org Mon Mar 4 14:44:03 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 14:44:03 GMT Subject: [jdk17u-dev] RFR: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader Message-ID: I backport this for parity with 17.0.12-oracle. Omitted one file not in 17. Others clean. Will mark clean. ------------- Commit messages: - Backport 57fc9a3e968cafe3b618a216630e703a39d5676e Changes: https://git.openjdk.org/jdk17u-dev/pull/2266/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2266&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309763 Stats: 0 lines in 4 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2266.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2266/head:pull/2266 PR: https://git.openjdk.org/jdk17u-dev/pull/2266 From duke at openjdk.org Mon Mar 4 14:50:59 2024 From: duke at openjdk.org (Jiawei Tang) Date: Mon, 4 Mar 2024 14:50:59 GMT Subject: [jdk11u-dev] Integrated: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id In-Reply-To: References: Message-ID: On Tue, 30 Jan 2024 09:30:06 GMT, Jiawei Tang wrote: > It isn't a clean backport for two reasons. > 1. jdk11 cannot use nullptr, so it should use NULL instead. > 2. `parent_thread_group_handle != NULL` will cause a compile error without a type cast. > > This backport prevents a JFR operation from accessing an illegal address which has not be filled before the initialization of a JavaThread, which is created from a JNI interface. > > The risk is very low since it only adds a null pointer check. Besides, This backport has be accepted in [jdk17-dev](https://github.com/openjdk/jdk17u-dev/pull/2179). > > Additional testing: > - [x] Linux aarch64 server fastdebug, test/jdk/jdk/jfr passed This pull request has now been integrated. Changeset: a4a5c7fe Author: Jiawei Tang Committer: Jie Fu URL: https://git.openjdk.org/jdk11u-dev/commit/a4a5c7fe66679ce4d9022443e3cd1f9ec38059ac Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id Reviewed-by: mgronlun Backport-of: a885aab696777c99c8c4c5d9a46afc5fe0a4fe47 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2501 From qpzhang at openjdk.org Mon Mar 4 14:54:57 2024 From: qpzhang at openjdk.org (Patrick Zhang) Date: Mon, 4 Mar 2024 14:54:57 GMT Subject: [jdk17u-dev] RFR: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 09:39:18 GMT, Aleksey Shipilev wrote: >> Hi, >> >> This pull request contains a backport of commit [9936aeea](https://github.com/openjdk/jdk/commit/9936aeea32b71509151099e6d28905e0322b2bc2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> Not a clean merge to 17u-dev. >> Manually resolved the merging conflicts due to line differences on `enum Ampere_CPU_Model` and `Feature_Flag`, removed redundant changes in order to limit the update to the code changes only from commit [9936aeea]. This can also lower the risk and limit the functionality impact to to particular Ampere new CPU cores Ampere-1/1A/1B. Same scope as that of the commit [9936aeea]. >> >> Passed pre-submit tests, ran Jtreg `tier1`, `tier2`, and `gtest` tests, no related issue found with the patch, also tested: >> `make run-test TEST="jtreg:hotspot/jtreg/compiler/onSpinWait*" ` >> `make run-test TEST="micro:ThreadOnSpinWait*"` >> >> Thanks for review. > > Looks good to me. Hi, @shipilev , thanks for the review, and could you please help sponsor this too? Very appreciate. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2202#issuecomment-1976759521 From goetz at openjdk.org Mon Mar 4 14:55:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 14:55:21 GMT Subject: [jdk21u-dev] RFR: 8310070: Test: javax/net/ssl/DTLS/DTLSWontNegotiateV10.java timed out Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport af7f95e24ad5981c5de4b5dbf37da6f4f5e42129 Changes: https://git.openjdk.org/jdk21u-dev/pull/319/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=319&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310070 Stats: 44 lines in 1 file changed: 30 ins; 0 del; 14 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/319.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/319/head:pull/319 PR: https://git.openjdk.org/jdk21u-dev/pull/319 From goetz at openjdk.org Mon Mar 4 15:22:14 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 15:22:14 GMT Subject: [jdk21u-dev] RFR: 8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 1664e793eb725d6328751657d5718df96175da29 Changes: https://git.openjdk.org/jdk21u-dev/pull/320/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=320&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311792 Stats: 58 lines in 1 file changed: 58 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/320.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/320/head:pull/320 PR: https://git.openjdk.org/jdk21u-dev/pull/320 From goetz at openjdk.org Mon Mar 4 15:28:02 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 15:28:02 GMT Subject: [jdk21u-dev] RFR: 8314824: Fix serviceability/jvmti/8036666/GetObjectLockCount.java to use vm flags Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 93e82c01460a70f214653a558d53c1c6180ae0d3 Changes: https://git.openjdk.org/jdk21u-dev/pull/321/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=321&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314824 Stats: 6 lines in 1 file changed: 3 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/321.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/321/head:pull/321 PR: https://git.openjdk.org/jdk21u-dev/pull/321 From goetz at openjdk.org Mon Mar 4 15:38:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 15:38:12 GMT Subject: [jdk21u-dev] RFR: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 704c6ea16cabc217588f430fd3c302d6df5e9c19 Changes: https://git.openjdk.org/jdk21u-dev/pull/323/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=323&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303525 Stats: 174 lines in 2 files changed: 59 ins; 93 del; 22 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/323.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/323/head:pull/323 PR: https://git.openjdk.org/jdk21u-dev/pull/323 From goetz at openjdk.org Mon Mar 4 16:09:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 16:09:01 GMT Subject: [jdk21u-dev] RFR: 8319757: java/nio/channels/DatagramChannel/InterruptibleOrNot.java failed: wrong exception thrown Message-ID: <6C-xJSOIpRePAf2_agZaHShC1ZyHS4yluGlo_tIbiWI=.0009d0b1-101b-4764-a9c3-9fdf112ca2df@github.com> I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport ace010b38a83e0c9b43aeeb6bc5c92d0886dc53f Changes: https://git.openjdk.org/jdk21u-dev/pull/324/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=324&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319757 Stats: 161 lines in 1 file changed: 55 ins; 29 del; 77 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/324.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/324/head:pull/324 PR: https://git.openjdk.org/jdk21u-dev/pull/324 From goetz at openjdk.org Mon Mar 4 16:16:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 16:16:20 GMT Subject: [jdk21u-dev] RFR: 8323276: StressDirListings.java fails on AIX Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport e5aed6be7a184a86a32fa671d48e0781fab54183 Changes: https://git.openjdk.org/jdk21u-dev/pull/325/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=325&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323276 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/325.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/325/head:pull/325 PR: https://git.openjdk.org/jdk21u-dev/pull/325 From goetz at openjdk.org Mon Mar 4 16:20:00 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 16:20:00 GMT Subject: [jdk21u-dev] RFR: 8320712: Rewrite BadFactoryTest in pure Java Message-ID: <7ejFjB-jV5MQ7F59Pd5wmuPqVV36cvH0keQdbTlj36M=.42a6a882-d0b8-4912-94e6-086d5d635207@github.com> I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 66971600f7ba796ff5bb9714591c3faa0bb2249d Changes: https://git.openjdk.org/jdk21u-dev/pull/326/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=326&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320712 Stats: 86 lines in 2 files changed: 24 ins; 60 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/326.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/326/head:pull/326 PR: https://git.openjdk.org/jdk21u-dev/pull/326 From goetz at openjdk.org Mon Mar 4 16:24:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 16:24:17 GMT Subject: [jdk17u-dev] RFR: 8320712: Rewrite BadFactoryTest in pure Java Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport 66971600f7ba796ff5bb9714591c3faa0bb2249d Changes: https://git.openjdk.org/jdk17u-dev/pull/2267/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2267&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320712 Stats: 86 lines in 2 files changed: 24 ins; 60 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2267.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2267/head:pull/2267 PR: https://git.openjdk.org/jdk17u-dev/pull/2267 From goetz at openjdk.org Mon Mar 4 16:35:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 16:35:52 GMT Subject: [jdk21u-dev] RFR: 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information In-Reply-To: References: Message-ID: On Sat, 24 Feb 2024 16:50:33 GMT, SendaoYan wrote: > The testcase implement and the commnet is unmatch. Just modify the comment. The risk is low. Hi @sendaoYan, please finish this backport. It's easy enough. I recommend using https://github.com/pulls aka https://github.com/pulls?q=is%3Aopen+is%3Apr+author%3AsendaoYan+archived%3Afalse+ to track your open PRs. I check this list every day to see the progress of the issues and react. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/289#issuecomment-1976996155 From goetz at openjdk.org Mon Mar 4 16:46:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 16:46:13 GMT Subject: [jdk21u-dev] RFR: 8314828: Mark 3 jcmd command-line options test as vm.flagless Message-ID: I backport this for parity with 21.0.4-oracle. As 8312828 breaks the tests, I include follow-up 8316228. Both are clean backports. Will mark as clean. ------------- Commit messages: - Backport 8316228 - Backport 8314828 Changes: https://git.openjdk.org/jdk21u-dev/pull/322/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=322&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314828 Stats: 6 lines in 3 files changed: 3 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/322.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/322/head:pull/322 PR: https://git.openjdk.org/jdk21u-dev/pull/322 From mdoerr at openjdk.org Mon Mar 4 16:51:52 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 4 Mar 2024 16:51:52 GMT Subject: [jdk21u-dev] RFR: 8322477: order of subclasses in the permits clause can differ between compilations In-Reply-To: References: Message-ID: <593_ucbu6W9z0XL2ouXZtjM21LSfiTv-4y3NuA4f3EY=.d1294a0d-e14f-422b-9e2c-e582648bbe67@github.com> On Fri, 1 Mar 2024 15:36:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. > > src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java > I had to resolve because indentation is different. Changed coding is the same. Looks basically good. Only one minor thing below. https://bugs.openjdk.org/browse/JDK-8319987 would only resolve one trivial diff. Is that planned to be backported for 21.0.4, too? If nobody wants to backport that one very soon, I don't think we have to wait. src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 5495: > 5493: if (!c.type.isCompound()) { > 5494: for (ClassSymbol supertypeSym : sealedSupers) { > 5495: if (!supertypeSym.isPermittedSubclass(c.type.tsym)) { Indentation is off by one. ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/310#pullrequestreview-1914806586 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/310#discussion_r1511464758 From dlutker at openjdk.org Mon Mar 4 17:09:03 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Mon, 4 Mar 2024 17:09:03 GMT Subject: [jdk21u-dev] RFR: 8294699: Launcher causes lingering busy cursor Message-ID: Backport for parity with Oracle 21.0.4 ------------- Commit messages: - Backport d3df3eb5d7f5537ade917db7a36caba028f94111 Changes: https://git.openjdk.org/jdk21u-dev/pull/327/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=327&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294699 Stats: 78 lines in 1 file changed: 76 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/327.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/327/head:pull/327 PR: https://git.openjdk.org/jdk21u-dev/pull/327 From adinn at openjdk.org Mon Mar 4 17:17:56 2024 From: adinn at openjdk.org (Andrew Dinn) Date: Mon, 4 Mar 2024 17:17:56 GMT Subject: [jdk17u-dev] RFR: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs In-Reply-To: References: Message-ID: On Sat, 10 Feb 2024 10:34:54 GMT, Patrick Zhang wrote: > Hi, > > This pull request contains a backport of commit [9936aeea](https://github.com/openjdk/jdk/commit/9936aeea32b71509151099e6d28905e0322b2bc2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > Not a clean merge to 17u-dev. > Manually resolved the merging conflicts due to line differences on `enum Ampere_CPU_Model` and `Feature_Flag`, removed redundant changes in order to limit the update to the code changes only from commit [9936aeea]. This can also lower the risk and limit the functionality impact to to particular Ampere new CPU cores Ampere-1/1A/1B. Same scope as that of the commit [9936aeea]. > > Passed pre-submit tests, ran Jtreg `tier1`, `tier2`, and `gtest` tests, no related issue found with the patch, also tested: > `make run-test TEST="jtreg:hotspot/jtreg/compiler/onSpinWait*" ` > `make run-test TEST="micro:ThreadOnSpinWait*"` > > Thanks for review. @sponsor ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2202#issuecomment-1977078256 From qpzhang at openjdk.org Mon Mar 4 17:17:56 2024 From: qpzhang at openjdk.org (Patrick Zhang) Date: Mon, 4 Mar 2024 17:17:56 GMT Subject: [jdk17u-dev] Integrated: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs In-Reply-To: References: Message-ID: On Sat, 10 Feb 2024 10:34:54 GMT, Patrick Zhang wrote: > Hi, > > This pull request contains a backport of commit [9936aeea](https://github.com/openjdk/jdk/commit/9936aeea32b71509151099e6d28905e0322b2bc2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > Not a clean merge to 17u-dev. > Manually resolved the merging conflicts due to line differences on `enum Ampere_CPU_Model` and `Feature_Flag`, removed redundant changes in order to limit the update to the code changes only from commit [9936aeea]. This can also lower the risk and limit the functionality impact to to particular Ampere new CPU cores Ampere-1/1A/1B. Same scope as that of the commit [9936aeea]. > > Passed pre-submit tests, ran Jtreg `tier1`, `tier2`, and `gtest` tests, no related issue found with the patch, also tested: > `make run-test TEST="jtreg:hotspot/jtreg/compiler/onSpinWait*" ` > `make run-test TEST="micro:ThreadOnSpinWait*"` > > Thanks for review. This pull request has now been integrated. Changeset: f3e90af7 Author: Patrick Zhang Committer: Andrew Dinn URL: https://git.openjdk.org/jdk17u-dev/commit/f3e90af7995462e5048ed198097e5af10e513f7e Stats: 13 lines in 2 files changed: 9 ins; 0 del; 4 mod 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs Reviewed-by: shade Backport-of: 9936aeea32b71509151099e6d28905e0322b2bc2 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2202 From goetz at openjdk.org Mon Mar 4 17:18:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 17:18:16 GMT Subject: [jdk21u-dev] RFR: 8322477: order of subclasses in the permits clause can differ between compilations [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.4-oracle. > > src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java > I had to resolve because indentation is different. Changed coding is the same. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Fix indentation. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/310/files - new: https://git.openjdk.org/jdk21u-dev/pull/310/files/262093af..15a706c8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=310&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=310&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/310.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/310/head:pull/310 PR: https://git.openjdk.org/jdk21u-dev/pull/310 From goetz at openjdk.org Mon Mar 4 17:18:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 4 Mar 2024 17:18:16 GMT Subject: [jdk21u-dev] RFR: 8322477: order of subclasses in the permits clause can differ between compilations [v2] In-Reply-To: <593_ucbu6W9z0XL2ouXZtjM21LSfiTv-4y3NuA4f3EY=.d1294a0d-e14f-422b-9e2c-e582648bbe67@github.com> References: <593_ucbu6W9z0XL2ouXZtjM21LSfiTv-4y3NuA4f3EY=.d1294a0d-e14f-422b-9e2c-e582648bbe67@github.com> Message-ID: On Mon, 4 Mar 2024 16:45:45 GMT, Martin Doerr wrote: >> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix indentation. > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 5495: > >> 5493: if (!c.type.isCompound()) { >> 5494: for (ClassSymbol supertypeSym : sealedSupers) { >> 5495: if (!supertypeSym.isPermittedSubclass(c.type.tsym)) { > > Indentation is off by one. Thanks for the review. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/310#discussion_r1511505583 From shade at openjdk.org Mon Mar 4 17:52:59 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 4 Mar 2024 17:52:59 GMT Subject: [jdk21u-dev] RFR: 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java [v2] In-Reply-To: References: Message-ID: <_fkmOSTRFDDD2aMa3e87DfTXGsXh5qddWviPs8bD8V0=.f422a3ab-4a6e-42d8-8d20-a665d0892bb4@github.com> On Fri, 1 Mar 2024 17:45:21 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This pull request contains a backport of commit [9481d06e](https://github.com/openjdk/jdk/commit/9481d06e62334872af539ccfb8c1ea25e30a6da3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Renjith Kannath Pariyangad on 2 Jan 2024 and was reviewed by Alexey Ivanov. >> >> Thanks! > > Sonia Zaldana Calles has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-SoniaZaldana-9481d06e > - Backport 9481d06e62334872af539ccfb8c1ea25e30a6da3 There is no need to wait for RISC-V GHA to get green. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/165#issuecomment-1977142632 From szaldana at openjdk.org Mon Mar 4 17:52:59 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 4 Mar 2024 17:52:59 GMT Subject: [jdk21u-dev] Integrated: 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java In-Reply-To: References: Message-ID: On Fri, 12 Jan 2024 16:21:36 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [9481d06e](https://github.com/openjdk/jdk/commit/9481d06e62334872af539ccfb8c1ea25e30a6da3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Renjith Kannath Pariyangad on 2 Jan 2024 and was reviewed by Alexey Ivanov. > > Thanks! This pull request has now been integrated. Changeset: 2d628549 Author: Sonia Zaldana Calles Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/2d62854922ea6fd3a948af64bd0f263db7dd6aa3 Stats: 39 lines in 8 files changed: 22 ins; 4 del; 13 mod 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java Backport-of: 9481d06e62334872af539ccfb8c1ea25e30a6da3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/165 From szaldana at openjdk.org Mon Mar 4 18:25:10 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 4 Mar 2024 18:25:10 GMT Subject: [jdk21u-dev] RFR: 8315609: Open source few more swing text/html tests Message-ID: <2Ri7uMob-n0HrsvlthzX2UDp5nO_zk_gInJEkSgFqro=.04acb910-951c-4e90-9ef8-8db2bb950c4f@github.com> Hi all, This pull request contains a backport of commit [a04c6c1a](https://github.com/openjdk/jdk/commit/a04c6c1ac663a1eab7d45913940cb6ac0af2c11c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Prasanta Sadhukhan on 11 Sep 2023 and was reviewed by Jayathirth D V. Thanks! ------------- Commit messages: - Backport a04c6c1ac663a1eab7d45913940cb6ac0af2c11c Changes: https://git.openjdk.org/jdk21u-dev/pull/313/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=313&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315609 Stats: 422 lines in 4 files changed: 422 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/313.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/313/head:pull/313 PR: https://git.openjdk.org/jdk21u-dev/pull/313 From szaldana at openjdk.org Mon Mar 4 18:27:13 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 4 Mar 2024 18:27:13 GMT Subject: [jdk21u-dev] RFR: 8315898: Open source swing JMenu tests Message-ID: Hi all, This pull request contains a backport of commit [fecd2fd8](https://github.com/openjdk/jdk/commit/fecd2fd8f26d0e8905a519e30e9aa171683c9df1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Abhishek Kumar on 13 Sep 2023 and was reviewed by Sergey Bylokhov. Thanks! ------------- Commit messages: - Backport fecd2fd8f26d0e8905a519e30e9aa171683c9df1 Changes: https://git.openjdk.org/jdk21u-dev/pull/314/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=314&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315898 Stats: 357 lines in 6 files changed: 357 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/314.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/314/head:pull/314 PR: https://git.openjdk.org/jdk21u-dev/pull/314 From szaldana at openjdk.org Mon Mar 4 18:30:53 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 4 Mar 2024 18:30:53 GMT Subject: [jdk21u-dev] RFR: 8315898: Open source swing JMenu tests In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 17:43:11 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [fecd2fd8](https://github.com/openjdk/jdk/commit/fecd2fd8f26d0e8905a519e30e9aa171683c9df1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Abhishek Kumar on 13 Sep 2023 and was reviewed by Sergey Bylokhov. > > Thanks! GHA failure: Unrelated Risk-V build issue. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/314#issuecomment-1977204801 From szaldana at openjdk.org Mon Mar 4 18:30:52 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 4 Mar 2024 18:30:52 GMT Subject: [jdk21u-dev] RFR: 8315609: Open source few more swing text/html tests In-Reply-To: <2Ri7uMob-n0HrsvlthzX2UDp5nO_zk_gInJEkSgFqro=.04acb910-951c-4e90-9ef8-8db2bb950c4f@github.com> References: <2Ri7uMob-n0HrsvlthzX2UDp5nO_zk_gInJEkSgFqro=.04acb910-951c-4e90-9ef8-8db2bb950c4f@github.com> Message-ID: On Fri, 1 Mar 2024 17:40:37 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [a04c6c1a](https://github.com/openjdk/jdk/commit/a04c6c1ac663a1eab7d45913940cb6ac0af2c11c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Prasanta Sadhukhan on 11 Sep 2023 and was reviewed by Jayathirth D V. > > Thanks! GHA failure: Unrelated Risk-V build issue. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/313#issuecomment-1977205193 From rrich at openjdk.org Mon Mar 4 21:37:00 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Mon, 4 Mar 2024 21:37:00 GMT Subject: [jdk17u-dev] RFR: 8272651: G1 heap region info print order changed by JDK-8269914 In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 12:03:58 GMT, Goetz Lindenmaier wrote: > I backport this as prerequisite for [8291753](https://bugs.openjdk.org/browse/JDK-8291753) as proposed before in https://github.com/openjdk/jdk17u-dev/pull/1900. > The backport has been tested by [releaseing it in SapMachine in 17.0.10](https://github.com/SAP/SapMachine/commit/4b0c2c7a070c7ad13f0da24a9418aea2883473af). This patch here is identical to the one in SapMachine. It will go to 17.0.12 giving enough time to settle. > > Also, this will bring G1 code of 17 closer to head probably simplifying further backports. > > src/hotspot/share/gc/g1/g1CollectedHeap.cpp > > Some lines removed are not in 17: > - set_young_collection_default_active_worker_threads(); > some later: > - G1YoungGCNotifyPauseMark npm; > > These are added again a bit further down. > > As adding them would modify the behaviour, I only added > them uncommented. > > test/hotspot/jtreg/gc/g1/TestEagerReclaimHumongousRegionsLog.java > The file already has the correct coding. Obviously these lines > were changed after 17 and later reverted again. Marked as reviewed by rrich (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2261#pullrequestreview-1915397895 From dlutker at openjdk.org Mon Mar 4 23:00:10 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Mon, 4 Mar 2024 23:00:10 GMT Subject: [jdk21u-dev] RFR: 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi Message-ID: Backporting to 21 which also has the same issue. ------------- Commit messages: - Backport 5d414da50459b7a1e6f0f537ff3b318854b2c427 Changes: https://git.openjdk.org/jdk21u-dev/pull/306/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=306&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325372 Stats: 100 lines in 4 files changed: 99 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/306.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/306/head:pull/306 PR: https://git.openjdk.org/jdk21u-dev/pull/306 From ashi at openjdk.org Mon Mar 4 23:50:06 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 4 Mar 2024 23:50:06 GMT Subject: [jdk11u-dev] RFR: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all Message-ID: Backport of [JDK-8290203](https://bugs.openjdk.org/browse/JDK-8290203) - This is a Semantics clean pull request Testing - Pipeline: - Testing Machine: ------------- Commit messages: - Backport ce36f6ea855a7ede02df969e6bb599ac36ac04fe Changes: https://git.openjdk.org/jdk11u-dev/pull/2582/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2582&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290203 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2582.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2582/head:pull/2582 PR: https://git.openjdk.org/jdk11u-dev/pull/2582 From syan at openjdk.org Tue Mar 5 01:36:48 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Mar 2024 01:36:48 GMT Subject: [jdk21u-dev] RFR: 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 16:32:43 GMT, Goetz Lindenmaier wrote: > Hi @sendaoYan, please finish this backport. It's easy enough. I recommend using https://github.com/pulls aka https://github.com/pulls?q=is%3Aopen+is%3Apr+author%3AsendaoYan+archived%3Afalse+ to track your open PRs. I check this list every day to see the progress of the issues and react. Sorry. I will track mine PRs this two days. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/289#issuecomment-1977782007 From mdoerr at openjdk.org Tue Mar 5 01:51:47 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 5 Mar 2024 01:51:47 GMT Subject: [jdk21u-dev] RFR: 8322477: order of subclasses in the permits clause can differ between compilations [v2] In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 17:18:16 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 21.0.4-oracle. >> >> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >> I had to resolve because indentation is different. Changed coding is the same. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Fix indentation. Marked as reviewed by mdoerr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/310#pullrequestreview-1915689452 From duke at openjdk.org Tue Mar 5 03:14:01 2024 From: duke at openjdk.org (Jiawei Tang) Date: Tue, 5 Mar 2024 03:14:01 GMT Subject: [jdk11u-dev] RFR: 8322511: JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id [v4] In-Reply-To: References: Message-ID: <426I6MDNxce_VFqi_lcS3TzcJF4RS0FtgWcD4ZWMW10=.464138b5-9749-4742-b43b-95e7f98ffe36@github.com> > Threads which are in the state of `is_attaching_via_jni` may have the NULL object as their `_threadObj` . > So the JVM will crash when calling `JfrCheckpointThreadClosure::do_thread()`. Jiawei Tang has updated the pull request incrementally with one additional commit since the last revision: Update full name ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2413/files - new: https://git.openjdk.org/jdk11u-dev/pull/2413/files/0cc754ad..0c58a66f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2413&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2413&range=02-03 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2413.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2413/head:pull/2413 PR: https://git.openjdk.org/jdk11u-dev/pull/2413 From lmao at openjdk.org Tue Mar 5 03:17:44 2024 From: lmao at openjdk.org (Liang Mao) Date: Tue, 5 Mar 2024 03:17:44 GMT Subject: [jdk17u-dev] RFR: 8324123: aarch64: fix prfm literal encoding in assembler [v2] In-Reply-To: References: Message-ID: <-LhrBY8JvHA8rFd6qBCtnT3uu8Ktfp_tOI6EcE9MnIs=.34a641d0-6e97-45a6-94d7-e2b9144e41b8@github.com> > Unclean backport of fixing aarch64 PRFM (literal) encoding. > > Additional testing: > - [x] Linux aarch64 server fastdebug, tier1 Liang Mao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'jdk17dev/master' into backport-mmyxym-bde87895-17u - Backport bde87895c8b1b9df198e3883d24cd9ea840efc98 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2256/files - new: https://git.openjdk.org/jdk17u-dev/pull/2256/files/f0c0f95c..c4765abe Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2256&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2256&range=00-01 Stats: 406 lines in 59 files changed: 191 ins; 58 del; 157 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2256.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2256/head:pull/2256 PR: https://git.openjdk.org/jdk17u-dev/pull/2256 From serb at openjdk.org Tue Mar 5 03:27:55 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 5 Mar 2024 03:27:55 GMT Subject: [jdk21u] Integrated: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 05:15:18 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [5a988a50](https://github.com/openjdk/jdk/commit/5a988a5087d0afbb577c6715fd5e1e44564888cb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexander Zvegintsev on 15 Feb 2024 and was reviewed by Jayathirth D V, Alexander Zuev, Prasanta Sadhukhan and Phil Race. > > tck-red-21 > > > Thanks! This pull request has now been integrated. Changeset: 29bf21fd Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk21u/commit/29bf21fd99f54eb8336f64f649e515f51c7f5090 Stats: 92 lines in 2 files changed: 85 ins; 0 del; 7 mod 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray Backport-of: 5a988a5087d0afbb577c6715fd5e1e44564888cb ------------- PR: https://git.openjdk.org/jdk21u/pull/439 From duke at openjdk.org Tue Mar 5 03:41:49 2024 From: duke at openjdk.org (Jiawei Tang) Date: Tue, 5 Mar 2024 03:41:49 GMT Subject: [jdk11u-dev] RFR: 8322511: JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id [v4] In-Reply-To: <426I6MDNxce_VFqi_lcS3TzcJF4RS0FtgWcD4ZWMW10=.464138b5-9749-4742-b43b-95e7f98ffe36@github.com> References: <426I6MDNxce_VFqi_lcS3TzcJF4RS0FtgWcD4ZWMW10=.464138b5-9749-4742-b43b-95e7f98ffe36@github.com> Message-ID: On Tue, 5 Mar 2024 03:14:01 GMT, Jiawei Tang wrote: >> Threads which are in the state of `is_attaching_via_jni` may have the NULL object as their `_threadObj` . >> So the JVM will crash when calling `JfrCheckpointThreadClosure::do_thread()`. > > Jiawei Tang has updated the pull request incrementally with one additional commit since the last revision: > > Update full name @phohensee @jerboaa Could you pls approve this [JDK-8322511](https://bugs.openjdk.org/browse/JDK-8322511) and review my codes? I showed the details about how JVM visit the null object `_threadObj` before and the change is harmless (only add the null condition check). ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2413#issuecomment-1977911409 From lmao at openjdk.org Tue Mar 5 05:31:52 2024 From: lmao at openjdk.org (Liang Mao) Date: Tue, 5 Mar 2024 05:31:52 GMT Subject: [jdk17u-dev] RFR: 8324123: aarch64: fix prfm literal encoding in assembler [v2] In-Reply-To: <-LhrBY8JvHA8rFd6qBCtnT3uu8Ktfp_tOI6EcE9MnIs=.34a641d0-6e97-45a6-94d7-e2b9144e41b8@github.com> References: <-LhrBY8JvHA8rFd6qBCtnT3uu8Ktfp_tOI6EcE9MnIs=.34a641d0-6e97-45a6-94d7-e2b9144e41b8@github.com> Message-ID: On Tue, 5 Mar 2024 03:17:44 GMT, Liang Mao wrote: >> Unclean backport of fixing aarch64 PRFM (literal) encoding. >> >> Additional testing: >> - [x] Linux aarch64 server fastdebug, tier1 > > Liang Mao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'jdk17dev/master' into backport-mmyxym-bde87895-17u > - Backport bde87895c8b1b9df198e3883d24cd9ea840efc98 Could reviewers please help with the review? The risk is very low as the original wrong encoding is not used in code base. riscv64 build failed because of the risc GHA infra which is also seen in JDK21u. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2256#issuecomment-1977995764 From aph at openjdk.org Tue Mar 5 07:21:47 2024 From: aph at openjdk.org (Andrew Haley) Date: Tue, 5 Mar 2024 07:21:47 GMT Subject: [jdk17u-dev] RFR: 8324123: aarch64: fix prfm literal encoding in assembler [v2] In-Reply-To: References: <-LhrBY8JvHA8rFd6qBCtnT3uu8Ktfp_tOI6EcE9MnIs=.34a641d0-6e97-45a6-94d7-e2b9144e41b8@github.com> Message-ID: On Tue, 5 Mar 2024 05:29:34 GMT, Liang Mao wrote: > Could reviewers please help with the review? The risk is very low as the original wrong encoding is not used in code base. There is, therefore, no reason to backport this. It should not be approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2256#issuecomment-1978106377 From syan at openjdk.org Tue Mar 5 07:22:54 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Mar 2024 07:22:54 GMT Subject: [jdk21u-dev] RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 In-Reply-To: References: Message-ID: <97eDcR89u0wVHNIzmgjVjN9WuQU1ce2SEtK4nyeQLLA=.dc9ebab1-8f50-4a26-ac2e-22101b01c148@github.com> On Mon, 22 Jan 2024 11:14:08 GMT, SendaoYan wrote: > 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/1db535fb-079c-4730-845d-5f4d03b8c551) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/204#issuecomment-1978104318 From duke at openjdk.org Tue Mar 5 07:28:51 2024 From: duke at openjdk.org (lusou-zhangquan) Date: Tue, 5 Mar 2024 07:28:51 GMT Subject: [jdk11u-dev] RFR: 8324754: WB_IsIntrinsicAvailable failed with "compiler not available" with option -Xint In-Reply-To: References: Message-ID: <5YFXRwRyoV2Kq9CHjNuKwYgWv5y6SgnmjMHlcFyCZbc=.5c533a34-c099-4147-8a50-56562261d271@github.com> On Mon, 29 Jan 2024 09:04:48 GMT, lusou-zhangquan wrote: > If interpreter mode is enabled, the highest compile level should be none. Therefore, WB_IsIntrinsicAvailable will return false directly rather than check intrinsic availability with non-existent compiler. @vnkozlov Could you please take a look at this PR? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2497#issuecomment-1978114407 From lmao at openjdk.org Tue Mar 5 07:34:52 2024 From: lmao at openjdk.org (Liang Mao) Date: Tue, 5 Mar 2024 07:34:52 GMT Subject: [jdk17u-dev] RFR: 8324123: aarch64: fix prfm literal encoding in assembler [v2] In-Reply-To: References: <-LhrBY8JvHA8rFd6qBCtnT3uu8Ktfp_tOI6EcE9MnIs=.34a641d0-6e97-45a6-94d7-e2b9144e41b8@github.com> Message-ID: <_B_r1JPVsDiQ87rxYNrAZTW-EeZMEh6O0GtxM2-I5JI=.449a498d-1184-4f88-8c97-d444e2076b4d@github.com> On Tue, 5 Mar 2024 07:19:28 GMT, Andrew Haley wrote: > > Could reviewers please help with the review? The risk is very low as the original wrong encoding is not used in code base. > > There is, therefore, no reason to backport this. It should not be approved. Hi @theRealAph , I guess we might have enhancements in the future depending on this correct instruction encoding. 17u still accepts enhancements with substantial benefit. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2256#issuecomment-1978121946 From syan at openjdk.org Tue Mar 5 07:46:52 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Mar 2024 07:46:52 GMT Subject: [jdk17u-dev] RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 In-Reply-To: References: Message-ID: On Mon, 22 Jan 2024 11:08:59 GMT, SendaoYan wrote: > 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/91a4d577-b734-4b8d-9006-de21b5543622) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2151#issuecomment-1978138271 From goetz at openjdk.org Tue Mar 5 08:33:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Mar 2024 08:33:57 GMT Subject: [jdk17u] RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray In-Reply-To: References: <58urSEwC2yIBIQIMq06yy-gpiZKbT_X-OlNHULyiTKo=.d68f3268-9113-41db-af72-8036d0b9f71d@github.com> Message-ID: On Wed, 28 Feb 2024 05:34:04 GMT, Sergey Bylokhov wrote: >> Hi all, >> >> This pull request contains a backport of commit [5a988a50](https://github.com/openjdk/jdk/commit/5a988a5087d0afbb577c6715fd5e1e44564888cb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alexander Zvegintsev on 15 Feb 2024 and was reviewed by Jayathirth D V, Alexander Zuev, Prasanta Sadhukhan and Phil Race. >> >> tck-red-17 >> >> Thanks! > > FYI https://github.com/openjdk/jdk17u-dev/pull/2212 Hi @mrserb I would appreciate if this makes this weeks tag, i.e., is integrated by 18:00 CET today. Same for the 11u change. Except if you have good reasons to hold it back. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/389#issuecomment-1978211023 From aph at openjdk.org Tue Mar 5 08:35:50 2024 From: aph at openjdk.org (Andrew Haley) Date: Tue, 5 Mar 2024 08:35:50 GMT Subject: [jdk17u-dev] RFR: 8324123: aarch64: fix prfm literal encoding in assembler [v2] In-Reply-To: <_B_r1JPVsDiQ87rxYNrAZTW-EeZMEh6O0GtxM2-I5JI=.449a498d-1184-4f88-8c97-d444e2076b4d@github.com> References: <-LhrBY8JvHA8rFd6qBCtnT3uu8Ktfp_tOI6EcE9MnIs=.34a641d0-6e97-45a6-94d7-e2b9144e41b8@github.com> <_B_r1JPVsDiQ87rxYNrAZTW-EeZMEh6O0GtxM2-I5JI=.449a498d-1184-4f88-8c97-d444e2076b4d@github.com> Message-ID: <7mndLk2b2N4iZ7ymPR0UaVAESvOrB9gO_evZOMutnFg=.3701dcbf-1ca5-493f-872d-767461e5d8d7@github.com> On Tue, 5 Mar 2024 07:32:09 GMT, Liang Mao wrote: > > > Could reviewers please help with the review? The risk is very low as the original wrong encoding is not used in code base. > > > > There is, therefore, no reason to backport this. It should not be approved. > > Hi @theRealAph , I guess we might have enhancements in the future depending on this correct instruction encoding. 17u still accepts enhancements with substantial benefit. ... to the users. I guess what you say is possible, and applying this patch now might avoid some future risk. Having said that, if we can speculate about any and every possible future we'd backport an awful lot of stuff, with the risk that implies. As it stands, this backport is outside the current rules. The maintainers are allowed to make an exception for a special case, though. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2256#issuecomment-1978214789 From lmao at openjdk.org Tue Mar 5 08:46:47 2024 From: lmao at openjdk.org (Liang Mao) Date: Tue, 5 Mar 2024 08:46:47 GMT Subject: [jdk17u-dev] RFR: 8324123: aarch64: fix prfm literal encoding in assembler [v2] In-Reply-To: <7mndLk2b2N4iZ7ymPR0UaVAESvOrB9gO_evZOMutnFg=.3701dcbf-1ca5-493f-872d-767461e5d8d7@github.com> References: <-LhrBY8JvHA8rFd6qBCtnT3uu8Ktfp_tOI6EcE9MnIs=.34a641d0-6e97-45a6-94d7-e2b9144e41b8@github.com> <_B_r1JPVsDiQ87rxYNrAZTW-EeZMEh6O0GtxM2-I5JI=.449a498d-1184-4f88-8c97-d444e2076b4d@github.com> <7mndLk2b2N4iZ7ymPR0UaVAESvOrB9gO_evZOMutnFg=.3701dcbf-1ca5-493f-872d-767461e5d8d7@github.com> Message-ID: On Tue, 5 Mar 2024 08:33:34 GMT, Andrew Haley wrote: > > > > Could reviewers please help with the review? The risk is very low as the original wrong encoding is not used in code base. > > > > > > > > > There is, therefore, no reason to backport this. It should not be approved. > > > > > > Hi @theRealAph , I guess we might have enhancements in the future depending on this correct instruction encoding. 17u still accepts enhancements with substantial benefit. > > ... to the users. I guess what you say is possible, and applying this patch now might avoid some future risk. Having said that, if we can speculate about any and every possible future we'd backport an awful lot of stuff, with the risk that implies. > > As it stands, this backport is outside the current rules. The maintainers are allowed to make an exception for a special case, though. Sure. We can still have a review before maintainer makes the decision. It's not just a normal pre-requisite enhancement which seems unnecessary as you described but an incorrect instruction encoding mistake which really makes compiler engineers nervous. The wrong encoding may not lead to crash but cannot perform the prefetch as expected and very difficult for engineers to find out the root cause. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2256#issuecomment-1978233147 From goetz at openjdk.org Tue Mar 5 08:53:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Mar 2024 08:53:53 GMT Subject: [jdk21u-dev] RFR: 8322477: order of subclasses in the permits clause can differ between compilations [v2] In-Reply-To: References: Message-ID: <-AzFIMO12lZ2LrF4EKVR8ZyyMB5y4YVsJyAtlel0r2k=.d5a5f06d-2480-404a-a3ff-9929651762dd@github.com> On Mon, 4 Mar 2024 17:18:16 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 21.0.4-oracle. >> >> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >> I had to resolve because indentation is different. Changed coding is the same. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Fix indentation. GHA failure: Risc-V compile issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/310#issuecomment-1978244560 From goetz at openjdk.org Tue Mar 5 08:54:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Mar 2024 08:54:52 GMT Subject: [jdk21u-dev] RFR: 8314824: Fix serviceability/jvmti/8036666/GetObjectLockCount.java to use vm flags In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 15:21:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: Risc-V compile issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/321#issuecomment-1978246563 From goetz at openjdk.org Tue Mar 5 08:54:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Mar 2024 08:54:58 GMT Subject: [jdk21u-dev] RFR: 8310070: Test: javax/net/ssl/DTLS/DTLSWontNegotiateV10.java timed out In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 14:50:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: Risc-V compile issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/319#issuecomment-1978245759 From goetz at openjdk.org Tue Mar 5 08:54:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Mar 2024 08:54:53 GMT Subject: [jdk21u-dev] RFR: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 14:36:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: Risc-V compile issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/318#issuecomment-1978245389 From goetz at openjdk.org Tue Mar 5 08:54:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Mar 2024 08:54:57 GMT Subject: [jdk21u-dev] RFR: 8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 15:16:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: Risc-V compile issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/320#issuecomment-1978246115 From goetz at openjdk.org Tue Mar 5 08:55:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Mar 2024 08:55:50 GMT Subject: [jdk21u-dev] RFR: 8314828: Mark 3 jcmd command-line options test as vm.flagless In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 15:29:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. > > As 8312828 breaks the tests, I include follow-up 8316228. > Both are clean backports. Will mark as clean. GHA failure: Risc-V compile issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/322#issuecomment-1978247003 From goetz at openjdk.org Tue Mar 5 08:55:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Mar 2024 08:55:50 GMT Subject: [jdk21u-dev] RFR: 8319757: java/nio/channels/DatagramChannel/InterruptibleOrNot.java failed: wrong exception thrown In-Reply-To: <6C-xJSOIpRePAf2_agZaHShC1ZyHS4yluGlo_tIbiWI=.0009d0b1-101b-4764-a9c3-9fdf112ca2df@github.com> References: <6C-xJSOIpRePAf2_agZaHShC1ZyHS4yluGlo_tIbiWI=.0009d0b1-101b-4764-a9c3-9fdf112ca2df@github.com> Message-ID: On Mon, 4 Mar 2024 16:03:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: Risc-V compile issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/324#issuecomment-1978247881 From goetz at openjdk.org Tue Mar 5 08:55:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Mar 2024 08:55:50 GMT Subject: [jdk21u-dev] RFR: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 15:33:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: Risc-V compile issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/323#issuecomment-1978247432 From goetz at openjdk.org Tue Mar 5 08:55:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Mar 2024 08:55:51 GMT Subject: [jdk21u-dev] RFR: 8323276: StressDirListings.java fails on AIX In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 16:10:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: Risc-V compile issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/325#issuecomment-1978248316 From goetz at openjdk.org Tue Mar 5 08:56:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Mar 2024 08:56:46 GMT Subject: [jdk21u-dev] RFR: 8320712: Rewrite BadFactoryTest in pure Java In-Reply-To: <7ejFjB-jV5MQ7F59Pd5wmuPqVV36cvH0keQdbTlj36M=.42a6a882-d0b8-4912-94e6-086d5d635207@github.com> References: <7ejFjB-jV5MQ7F59Pd5wmuPqVV36cvH0keQdbTlj36M=.42a6a882-d0b8-4912-94e6-086d5d635207@github.com> Message-ID: On Mon, 4 Mar 2024 16:14:46 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: Risc-V compile issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/326#issuecomment-1978248810 From goetz at openjdk.org Tue Mar 5 09:03:00 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Mar 2024 09:03:00 GMT Subject: [jdk17u] Integrated: 8305900: Use loopback IP addresses in security policy files of httpclient tests In-Reply-To: <9DFiZbHnoEzJ8ek5BD4UxYILaPxoB17gsSSa2aXR2-I=.e37b5c31-5453-48da-a9af-350de624173c@github.com> References: <9DFiZbHnoEzJ8ek5BD4UxYILaPxoB17gsSSa2aXR2-I=.e37b5c31-5453-48da-a9af-350de624173c@github.com> Message-ID: On Mon, 4 Mar 2024 09:11:09 GMT, Goetz Lindenmaier wrote: > I backport this to fix testing issues with ConnectionReueseTest.java that showed after backporting https://bugs.openjdk.org/browse/JDK-8305906. > > Jaikiran proposes to do a local fix, but I think backporting this test-only change keeps the test suite better up-to-date. Also later similar issues will be avoided. > > Some simple adaptions were needed: > > test/jdk/java/net/httpclient/AsFileDownloadTest.java > Trivial resolve. > > test/jdk/java/net/httpclient/httpclient-localaddr-security.policy > File not in 17. Skipped. > > test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java > test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServer.java > Trivial resolve, file in other loction. This pull request has now been integrated. Changeset: 72881deb Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u/commit/72881debbdd87ed47039aa95efd04054e955e4f8 Stats: 429 lines in 32 files changed: 193 ins; 38 del; 198 mod 8305900: Use loopback IP addresses in security policy files of httpclient tests Reviewed-by: mbaesken Backport-of: 646b666a265c4de961b8ba3f9e4e8c9231be8a6f ------------- PR: https://git.openjdk.org/jdk17u/pull/390 From serb at openjdk.org Tue Mar 5 09:09:05 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 5 Mar 2024 09:09:05 GMT Subject: [jdk17u] Integrated: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray In-Reply-To: <58urSEwC2yIBIQIMq06yy-gpiZKbT_X-OlNHULyiTKo=.d68f3268-9113-41db-af72-8036d0b9f71d@github.com> References: <58urSEwC2yIBIQIMq06yy-gpiZKbT_X-OlNHULyiTKo=.d68f3268-9113-41db-af72-8036d0b9f71d@github.com> Message-ID: On Wed, 28 Feb 2024 05:30:10 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [5a988a50](https://github.com/openjdk/jdk/commit/5a988a5087d0afbb577c6715fd5e1e44564888cb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexander Zvegintsev on 15 Feb 2024 and was reviewed by Jayathirth D V, Alexander Zuev, Prasanta Sadhukhan and Phil Race. > > tck-red-17 > > Thanks! This pull request has now been integrated. Changeset: f45e5871 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u/commit/f45e5871d7003ba48e74efbb0ef5a9a188436128 Stats: 92 lines in 2 files changed: 85 ins; 0 del; 7 mod 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray Backport-of: 5a988a5087d0afbb577c6715fd5e1e44564888cb ------------- PR: https://git.openjdk.org/jdk17u/pull/389 From syan at openjdk.org Tue Mar 5 09:50:46 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Mar 2024 09:50:46 GMT Subject: [jdk17u-dev] RFR: 8327312: Problem list ReflectionCallerCacheTest.java due to 8324978 In-Reply-To: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> References: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> Message-ID: On Tue, 30 Jan 2024 16:25:52 GMT, SendaoYan wrote: > 8327312: Problem list ReflectionCallerCacheTest.java due to 8324978 The testcase ReflectionCallerCacheTest.java run failed with -Xcomp, both on linux-x86_64 and linux-aarch64. And it run pass on jdk23 binary, the testcase in jdk17u-dev repository and jdk repository is the same, the md5sum of this testcase file is 9f928d28291ced95e7b8a9e2062b4d33. Before we found the root cause of this failure, should we problem list testcase. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2186#issuecomment-1978352458 From ogillespie at openjdk.org Tue Mar 5 10:25:57 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 5 Mar 2024 10:25:57 GMT Subject: [jdk21u-dev] RFR: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG [v2] In-Reply-To: References: Message-ID: <3vWex7a36km1LjnoYUj80oRYlQTHTOXI_MpD5oR3myo=.5aa4bf43-b2a1-415d-a323-5c089d064c22@github.com> On Mon, 4 Mar 2024 13:46:19 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [69b2674c](https://github.com/openjdk/jdk/commit/69b2674c6861fdb7d9f9cb39e07d50515c73e33a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev, Weijun Wang, Chen Liang and Valerie Peng. >> >> Thanks! > > Oli Gillespie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into backport-olivergillespie-69b2674c > - Backport 69b2674c6861fdb7d9f9cb39e07d50515c73e33a Note - GHA linux-cross-compile riscv64 is failing, which seems to be globally broken (I checked a few other recent PRs and it's failing everywhere). ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/257#issuecomment-1978425707 From ogillespie at openjdk.org Tue Mar 5 10:58:51 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 5 Mar 2024 10:58:51 GMT Subject: [jdk21u-dev] Integrated: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG In-Reply-To: References: Message-ID: On Tue, 13 Feb 2024 11:26:50 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [69b2674c](https://github.com/openjdk/jdk/commit/69b2674c6861fdb7d9f9cb39e07d50515c73e33a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev, Weijun Wang, Chen Liang and Valerie Peng. > > Thanks! This pull request has now been integrated. Changeset: d6ad6256 Author: Oli Gillespie Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/d6ad6256038228bf5c15bea1e7f5af6c399a7cfa Stats: 16 lines in 1 file changed: 9 ins; 3 del; 4 mod 8324648: Avoid NoSuchMethodError when instantiating NativePRNG Backport-of: 69b2674c6861fdb7d9f9cb39e07d50515c73e33a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/257 From shade at openjdk.org Tue Mar 5 11:06:49 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 5 Mar 2024 11:06:49 GMT Subject: [jdk21u-dev] RFR: 8324646: Avoid Class.forName in SecureRandom constructor [v2] In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 13:53:21 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [8ef918d6](https://github.com/openjdk/jdk/commit/8ef918d6678437a5b351b172bb4cf144eeaa975f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev and Weijun Wang. >> >> Thanks! > > Oli Gillespie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into backport-olivergillespie-8ef918d6 > - Backport 8ef918d6678437a5b351b172bb4cf144eeaa975f Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/258#pullrequestreview-1916582145 From goetz at openjdk.org Tue Mar 5 11:45:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Mar 2024 11:45:54 GMT Subject: [jdk17u-dev] Integrated: 8272651: G1 heap region info print order changed by JDK-8269914 In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 12:03:58 GMT, Goetz Lindenmaier wrote: > I backport this as prerequisite for [8291753](https://bugs.openjdk.org/browse/JDK-8291753) as proposed before in https://github.com/openjdk/jdk17u-dev/pull/1900. > The backport has been tested by [releaseing it in SapMachine in 17.0.10](https://github.com/SAP/SapMachine/commit/4b0c2c7a070c7ad13f0da24a9418aea2883473af). This patch here is identical to the one in SapMachine. It will go to 17.0.12 giving enough time to settle. > > Also, this will bring G1 code of 17 closer to head probably simplifying further backports. > > src/hotspot/share/gc/g1/g1CollectedHeap.cpp > > Some lines removed are not in 17: > - set_young_collection_default_active_worker_threads(); > some later: > - G1YoungGCNotifyPauseMark npm; > > These are added again a bit further down. > > As adding them would modify the behaviour, I only added > them uncommented. > > test/hotspot/jtreg/gc/g1/TestEagerReclaimHumongousRegionsLog.java > The file already has the correct coding. Obviously these lines > were changed after 17 and later reverted again. This pull request has now been integrated. Changeset: 158f91a8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/158f91a888020d1ea67682a07f6138737ea0cc67 Stats: 28 lines in 4 files changed: 20 ins; 6 del; 2 mod 8272651: G1 heap region info print order changed by JDK-8269914 Reviewed-by: rrich Backport-of: f11e099a149adfecc474ba37276ec8672067d090 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2261 From goetz at openjdk.org Tue Mar 5 12:00:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 5 Mar 2024 12:00:49 GMT Subject: [jdk21u-dev] Integrated: 8306040: HttpResponseInputStream.available() returns 1 on empty stream In-Reply-To: References: Message-ID: <2g1KI6f6Ag2i2pf0nY72Tdod7zcx8cxwrmzMcksT9gE=.a95a2e42-fd78-4086-a417-7d7eb7e5192e@github.com> On Fri, 1 Mar 2024 14:56:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 4244cb0d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/4244cb0d9927bd2b6c565b10e6bd40be0c3c7843 Stats: 163 lines in 2 files changed: 161 ins; 0 del; 2 mod 8306040: HttpResponseInputStream.available() returns 1 on empty stream Backport-of: acaab6fd74f507bb6b18167505d88e505bdf24bd ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/309 From syan at openjdk.org Tue Mar 5 12:28:51 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Mar 2024 12:28:51 GMT Subject: [jdk21u-dev] RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test In-Reply-To: References: Message-ID: On Tue, 6 Feb 2024 08:31:02 GMT, SendaoYan wrote: > The option "-XX:LoopUnrollLimit=0" results in no unrolling and consequently no vectorization opportunities in the test code. TestSSE2IntVect.java and TestSSE4IntVect.java fails with -XX:LoopUnrollLimit=0 ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/740cd3b9-da76-4c1c-93c5-fe9ce681a97a) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/235#issuecomment-1978659982 From shade at openjdk.org Tue Mar 5 12:34:06 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 5 Mar 2024 12:34:06 GMT Subject: [jdk21u-dev] RFR: 8320707: Virtual thread test updates Message-ID: Test-only backport that simplifies Loom maintenance. The original commit applies cleanly, but it does not work out of the box, because `VThreadPinner` uses FFM, which is a preview feature in JDK 21, made final in JDK 22. I believe it is safe to rely on FFM for these tests, and the only thing we need to do is to add `@enablePreview` in relevant tests. See the additional commits on top that do it. This would also make subsequent backports clean. Additional testing: - [x] MacOS AArch64 server fastdebug, `jdk_loom hotspot_loom` - [ ] Linux AArch64 server fastdebug, `all` - [ ] Linux x86_64 server fastdebug, `all` ------------- Commit messages: - Enable preview in affected tests - Backport b67b71cd87c62f15d5b73f923c300d0f77c988f5 Changes: https://git.openjdk.org/jdk21u-dev/pull/328/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=328&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320707 Stats: 989 lines in 16 files changed: 626 ins; 213 del; 150 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/328.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/328/head:pull/328 PR: https://git.openjdk.org/jdk21u-dev/pull/328 From syan at openjdk.org Tue Mar 5 12:45:51 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Mar 2024 12:45:51 GMT Subject: [jdk21u-dev] RFR: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test In-Reply-To: References: Message-ID: On Tue, 6 Feb 2024 08:31:02 GMT, SendaoYan wrote: > The option "-XX:LoopUnrollLimit=0" results in no unrolling and consequently no vectorization opportunities in the test code. TestIntVect.java test fails after patch applied with default jvm options, test pass with -XX:LoopUnrollLimit=0. It's needed more investigation, and this PR should be closed before the investigation is finished. [test-vm-flags-pid-2890138.log](https://github.com/openjdk/jdk21u-dev/files/14495390/test-vm-flags-pid-2890138.log) [pid-2890163-output.log](https://github.com/openjdk/jdk21u-dev/files/14495392/pid-2890163-output.log) [pid-2890138-output.log](https://github.com/openjdk/jdk21u-dev/files/14495394/pid-2890138-output.log) [hotspot_pid2890163.log](https://github.com/openjdk/jdk21u-dev/files/14495395/hotspot_pid2890163.log) [TestIntVect-default-jvm-options.jtr.log](https://github.com/openjdk/jdk21u-dev/files/14495396/TestIntVect-default-jvm-options.jtr.log) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/235#issuecomment-1978696430 From syan at openjdk.org Tue Mar 5 12:45:52 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 5 Mar 2024 12:45:52 GMT Subject: [jdk21u-dev] Withdrawn: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test In-Reply-To: References: Message-ID: On Tue, 6 Feb 2024 08:31:02 GMT, SendaoYan wrote: > The option "-XX:LoopUnrollLimit=0" results in no unrolling and consequently no vectorization opportunities in the test code. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/235 From mbaesken at openjdk.org Tue Mar 5 14:51:02 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 5 Mar 2024 14:51:02 GMT Subject: [jdk21u-dev] RFR: 8327059: os::Linux::print_proc_sys_info add swappiness information Message-ID: 8327059: os::Linux::print_proc_sys_info add swappiness information ------------- Commit messages: - Backport f3b15abcb7dcd00158df84818965fc1282dcc1d9 Changes: https://git.openjdk.org/jdk21u-dev/pull/329/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=329&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327059 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/329.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/329/head:pull/329 PR: https://git.openjdk.org/jdk21u-dev/pull/329 From mbaesken at openjdk.org Tue Mar 5 14:58:56 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 5 Mar 2024 14:58:56 GMT Subject: [jdk22u] RFR: 8327059: os::Linux::print_proc_sys_info add swappiness information Message-ID: 8327059: os::Linux::print_proc_sys_info add swappiness information ------------- Commit messages: - Backport f3b15abcb7dcd00158df84818965fc1282dcc1d9 Changes: https://git.openjdk.org/jdk22u/pull/84/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=84&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327059 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/84.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/84/head:pull/84 PR: https://git.openjdk.org/jdk22u/pull/84 From serb at openjdk.org Tue Mar 5 15:13:00 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 5 Mar 2024 15:13:00 GMT Subject: [jdk11u] Integrated: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray In-Reply-To: <4SDweoeXnUzjtjgblce6aD_H5RRKvlEUMXxBXiTAXGE=.63ffb7c0-7faa-4dbc-9e24-3fd84ceeb917@github.com> References: <4SDweoeXnUzjtjgblce6aD_H5RRKvlEUMXxBXiTAXGE=.63ffb7c0-7faa-4dbc-9e24-3fd84ceeb917@github.com> Message-ID: On Wed, 28 Feb 2024 05:31:58 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [5a988a50](https://github.com/openjdk/jdk/commit/5a988a5087d0afbb577c6715fd5e1e44564888cb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexander Zvegintsev on 15 Feb 2024 and was reviewed by Jayathirth D V, Alexander Zuev, Prasanta Sadhukhan and Phil Race. > > Backport is not clean, in jdk11u-dev the "sun.desktop" property is used to pass the "desktop name" from native, see > https://bugs.openjdk.org/browse/JDK-8212701 > > tck-red-11 > > Thanks! This pull request has now been integrated. Changeset: 5c5687d4 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk11u/commit/5c5687d4abde9180556db67c8a21f865dbebf7e7 Stats: 94 lines in 2 files changed: 87 ins; 0 del; 7 mod 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray Reviewed-by: phh Backport-of: 5a988a5087d0afbb577c6715fd5e1e44564888cb ------------- PR: https://git.openjdk.org/jdk11u/pull/89 From shade at openjdk.org Tue Mar 5 16:03:51 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 5 Mar 2024 16:03:51 GMT Subject: [jdk21u-dev] RFR: 8320707: Virtual thread test updates In-Reply-To: References: Message-ID: On Tue, 5 Mar 2024 12:29:13 GMT, Aleksey Shipilev wrote: > Test-only backport that simplifies Loom maintenance. The original commit applies cleanly, but it does not work out of the box, because `VThreadPinner` uses FFM, which is a preview feature in JDK 21, made final in JDK 22. I believe it is safe to rely on FFM for these tests, and the only thing we need to do is to add `@enablePreview` in relevant tests. See the additional commits on top that do it. > > This would also make subsequent backports clean. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `jdk_loom hotspot_loom` > - [ ] Linux x86_64 server fastdebug, `all` GHA x86_32 tests are failing, I think we need #330 first. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/328#issuecomment-1979106313 From phh at openjdk.org Tue Mar 5 18:55:59 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 5 Mar 2024 18:55:59 GMT Subject: [jdk11u-dev] RFR: 8322511: JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id [v4] In-Reply-To: <426I6MDNxce_VFqi_lcS3TzcJF4RS0FtgWcD4ZWMW10=.464138b5-9749-4742-b43b-95e7f98ffe36@github.com> References: <426I6MDNxce_VFqi_lcS3TzcJF4RS0FtgWcD4ZWMW10=.464138b5-9749-4742-b43b-95e7f98ffe36@github.com> Message-ID: On Tue, 5 Mar 2024 03:14:01 GMT, Jiawei Tang wrote: >> Threads which are in the state of `is_attaching_via_jni` may have the NULL object as their `_threadObj` . >> So the JVM will crash when calling `JfrCheckpointThreadClosure::do_thread()`. > > Jiawei Tang has updated the pull request incrementally with one additional commit since the last revision: > > Update full name Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2413#pullrequestreview-1917879758 From mchung at openjdk.org Tue Mar 5 20:04:56 2024 From: mchung at openjdk.org (Mandy Chung) Date: Tue, 5 Mar 2024 20:04:56 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 12:52:28 GMT, Mar?a Arias de Reyna wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8280377 MethodHandleProxies does not correctly invoke default methods with varags > > I applied the same fix that was applied to version 19 in https://github.com/openjdk/jdk/commit/a183bfb436a7dd998e602c2d16486e88c390fca1 The backport looks good to me. This is the same fix for [JDK-8280377](https://bugs.openjdk.org/browse/JDK-8280377) and includes the regression test. Tier1-3 tests including this new regression test should provide adequate verification. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#issuecomment-1979535027 From liach at openjdk.org Tue Mar 5 20:52:54 2024 From: liach at openjdk.org (Chen Liang) Date: Tue, 5 Mar 2024 20:52:54 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: References: Message-ID: <1IG-8ElKDBuTbKoe47S4nY4en3kMnHC8c4EJ7bZDdaM=.c20ef6de-9b23-47a4-8f24-9bd204f2150a@github.com> On Mon, 26 Feb 2024 12:52:28 GMT, Mar?a Arias de Reyna wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8280377 MethodHandleProxies does not correctly invoke default methods with varags > > I applied the same fix that was applied to version 19 in https://github.com/openjdk/jdk/commit/a183bfb436a7dd998e602c2d16486e88c390fca1 The alternative backport fix is for JDK versions before 16 when Proxy.invokeDefault was not available, right? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#issuecomment-1979613469 From mchung at openjdk.org Tue Mar 5 20:55:47 2024 From: mchung at openjdk.org (Mandy Chung) Date: Tue, 5 Mar 2024 20:55:47 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: <1IG-8ElKDBuTbKoe47S4nY4en3kMnHC8c4EJ7bZDdaM=.c20ef6de-9b23-47a4-8f24-9bd204f2150a@github.com> References: <1IG-8ElKDBuTbKoe47S4nY4en3kMnHC8c4EJ7bZDdaM=.c20ef6de-9b23-47a4-8f24-9bd204f2150a@github.com> Message-ID: On Tue, 5 Mar 2024 20:50:06 GMT, Chen Liang wrote: > The alternative backport fix is for JDK versions before 16 when Proxy.invokeDefault was not available, right? Yes. `Proxy::invokeDefault` API was introduced in Java 16. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#issuecomment-1979617655 From jwilhelm at openjdk.org Tue Mar 5 23:21:13 2024 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Tue, 5 Mar 2024 23:21:13 GMT Subject: [jdk22u] RFR: 8327391: Add SipHash attribution file Message-ID: Clean backport ------------- Commit messages: - Backport fcf48ab3d36a7f8eed84e81c3e2445adcbc95374 Changes: https://git.openjdk.org/jdk22u/pull/85/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=85&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327391 Stats: 150 lines in 1 file changed: 150 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/85.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/85/head:pull/85 PR: https://git.openjdk.org/jdk22u/pull/85 From duke at openjdk.org Wed Mar 6 06:20:52 2024 From: duke at openjdk.org (Jiawei Tang) Date: Wed, 6 Mar 2024 06:20:52 GMT Subject: [jdk11u-dev] RFR: 8322511: JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id [v4] In-Reply-To: <426I6MDNxce_VFqi_lcS3TzcJF4RS0FtgWcD4ZWMW10=.464138b5-9749-4742-b43b-95e7f98ffe36@github.com> References: <426I6MDNxce_VFqi_lcS3TzcJF4RS0FtgWcD4ZWMW10=.464138b5-9749-4742-b43b-95e7f98ffe36@github.com> Message-ID: On Tue, 5 Mar 2024 03:14:01 GMT, Jiawei Tang wrote: >> Threads which are in the state of `is_attaching_via_jni` may have the NULL object as their `_threadObj` . >> So the JVM will crash when calling `JfrCheckpointThreadClosure::do_thread()`. > > Jiawei Tang has updated the pull request incrementally with one additional commit since the last revision: > > Update full name The results of related JFR testcases are all successful. TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/jdk/jfr 434 434 0 0 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2413#issuecomment-1980161892 From thartmann at openjdk.org Wed Mar 6 06:57:58 2024 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 6 Mar 2024 06:57:58 GMT Subject: [jdk22u] RFR: 8325313: Header format error in TestIntrinsicBailOut after JDK-8317299 Message-ID: <2uPyFrx17OusLS4uWSn7ACszXhwZXTbnkipQX1pU6eQ=.2c8bc81c-e2ee-4860-b0db-6f2bb2cf6caf@github.com> Hi all, This pull request contains a backport of commit [b75c134f](https://github.com/openjdk/jdk/commit/b75c134facc4dbd9f171024a12994dda818c5471) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Damon Fenacci on 6 Feb 2024 and was reviewed by Christian Hagedorn. Thanks! ------------- Commit messages: - Backport b75c134facc4dbd9f171024a12994dda818c5471 Changes: https://git.openjdk.org/jdk22u/pull/86/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=86&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325313 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/86.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/86/head:pull/86 PR: https://git.openjdk.org/jdk22u/pull/86 From goetz at openjdk.org Wed Mar 6 07:26:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 07:26:01 GMT Subject: [jdk21u-dev] RFR: Merge jdk21u:master Message-ID: Merge build tag 21.0.3+6 from jdk21u to jdk21u-dev ------------- Commit messages: - Merge - 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk21u-dev/pull/333/files Stats: 92 lines in 2 files changed: 85 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/333.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/333/head:pull/333 PR: https://git.openjdk.org/jdk21u-dev/pull/333 From goetz at openjdk.org Wed Mar 6 07:35:02 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 07:35:02 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:master Message-ID: Merge build tag 17.0.11+6 from jdk17u to jdk17u-dev ------------- Commit messages: - Merge - 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray - 8305900: Use loopback IP addresses in security policy files of httpclient tests The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk17u-dev/pull/2268/files Stats: 521 lines in 34 files changed: 278 ins; 38 del; 205 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2268.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2268/head:pull/2268 PR: https://git.openjdk.org/jdk17u-dev/pull/2268 From goetz at openjdk.org Wed Mar 6 07:41:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 07:41:56 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: Merge build tag 11.0.23+6 from jdk11u to jdk11u-dev ------------- Commit messages: - Merge - 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk11u-dev/pull/2583/files Stats: 94 lines in 2 files changed: 87 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2583.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2583/head:pull/2583 PR: https://git.openjdk.org/jdk11u-dev/pull/2583 From thartmann at openjdk.org Wed Mar 6 07:51:52 2024 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 6 Mar 2024 07:51:52 GMT Subject: [jdk22u] Integrated: 8325313: Header format error in TestIntrinsicBailOut after JDK-8317299 In-Reply-To: <2uPyFrx17OusLS4uWSn7ACszXhwZXTbnkipQX1pU6eQ=.2c8bc81c-e2ee-4860-b0db-6f2bb2cf6caf@github.com> References: <2uPyFrx17OusLS4uWSn7ACszXhwZXTbnkipQX1pU6eQ=.2c8bc81c-e2ee-4860-b0db-6f2bb2cf6caf@github.com> Message-ID: On Wed, 6 Mar 2024 06:52:33 GMT, Tobias Hartmann wrote: > Hi all, > > This pull request contains a backport of commit [b75c134f](https://github.com/openjdk/jdk/commit/b75c134facc4dbd9f171024a12994dda818c5471) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Damon Fenacci on 6 Feb 2024 and was reviewed by Christian Hagedorn. > > Thanks! This pull request has now been integrated. Changeset: 882978f6 Author: Tobias Hartmann URL: https://git.openjdk.org/jdk22u/commit/882978f646f27168d17a908a61c8eaa0c7a08481 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8325313: Header format error in TestIntrinsicBailOut after JDK-8317299 Backport-of: b75c134facc4dbd9f171024a12994dda818c5471 ------------- PR: https://git.openjdk.org/jdk22u/pull/86 From sroy at openjdk.org Wed Mar 6 08:04:58 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Wed, 6 Mar 2024 08:04:58 GMT Subject: [jdk22u] RFR: 8320005: Allow loading of shared objects with .a extension on AIX Message-ID: Hi all, This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. Thanks! ------------- Commit messages: - Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab Changes: https://git.openjdk.org/jdk22u/pull/87/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=87&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320005 Stats: 22 lines in 1 file changed: 20 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/87.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/87/head:pull/87 PR: https://git.openjdk.org/jdk22u/pull/87 From goetz at openjdk.org Wed Mar 6 08:23:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 08:23:55 GMT Subject: [jdk21u-dev] Integrated: Merge jdk21u:master In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 07:21:07 GMT, Goetz Lindenmaier wrote: > Merge build tag 21.0.3+6 from jdk21u to jdk21u-dev This pull request has now been integrated. Changeset: 930344ad Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/930344ad6fb9762fde0636d9042e3350ee90b9cf Stats: 92 lines in 2 files changed: 85 ins; 0 del; 7 mod Merge ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/333 From goetz at openjdk.org Wed Mar 6 08:35:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 08:35:52 GMT Subject: [jdk21u-dev] RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 In-Reply-To: References: Message-ID: <7ChA3LleB0acaPLY91xzVkbeEM1Y5qzLRDWCGgTA_Tc=.cd5fff0d-0b63-43fb-9b9e-60136b6f9b40@github.com> On Mon, 22 Jan 2024 11:14:08 GMT, SendaoYan wrote: > 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 > /approval JDK-8316563 "This PR only change the testcase, the testcase change has been verified. Please review this PR." You don't need a reeview as it is clean. Also, if you need a review, you should not request approval. But as this is clean and all good, I'll approve it. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/204#issuecomment-1980335482 From duke at openjdk.org Wed Mar 6 08:39:12 2024 From: duke at openjdk.org (lusou-zhangquan) Date: Wed, 6 Mar 2024 08:39:12 GMT Subject: [jdk21u-dev] RFR: 8324174: assert(m->is_entered(current)) failed: invariant Message-ID: Clean backport from master to fix the incorrect lock and unlock order problem of nested locks during deoptimization. ------------- Commit messages: - 8324174: assert(m->is_entered(current)) failed: invariant Changes: https://git.openjdk.org/jdk21u-dev/pull/334/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=334&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324174 Stats: 150 lines in 2 files changed: 148 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/334.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/334/head:pull/334 PR: https://git.openjdk.org/jdk21u-dev/pull/334 From goetz at openjdk.org Wed Mar 6 08:40:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 08:40:46 GMT Subject: [jdk21u-dev] RFR: 8294699: Launcher causes lingering busy cursor In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 17:03:09 GMT, Dan Lutker wrote: > Backport for parity with Oracle 21.0.4 Hi @lutkerd, your fix-request comment is meaningless, and you have failing tests. Please follow https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix. Removing the tag. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/327#issuecomment-1980343432 From goetz at openjdk.org Wed Mar 6 08:48:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 08:48:50 GMT Subject: [jdk21u-dev] RFR: 8325326: [PPC64] Don't relocate in case of allocation failure In-Reply-To: References: Message-ID: <3q_IlLI91-gnzBsQ_H8xofpCKU3boBDrwUEPYhAnk2o=.e0f551ef-ea56-4b37-8b90-6175fe10ed38@github.com> On Fri, 1 Mar 2024 15:47:13 GMT, Martin Doerr wrote: > Clean backport of [JDK-8325326](https://bugs.openjdk.org/browse/JDK-8325326). Hi @TheRealMDoerr , your tests are red. I checked them for you ... unrelated Risc-V build issue. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/311#issuecomment-1980358670 From goetz at openjdk.org Wed Mar 6 08:49:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 08:49:49 GMT Subject: [jdk21u-dev] RFR: 8325972: Add -x to bash for building with LOG=debug In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 03:20:27 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. @andrewlu, please check the tests. Removing tags in the meantime. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/315#issuecomment-1980361363 From sroy at openjdk.org Wed Mar 6 08:51:01 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Wed, 6 Mar 2024 08:51:01 GMT Subject: [jdk21u-dev] RFR: 8320005: Allow loading of shared objects with .a extension on AIX Message-ID: Hi all, This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. Thanks! ------------- Commit messages: - Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab Changes: https://git.openjdk.org/jdk21u-dev/pull/335/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=335&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320005 Stats: 22 lines in 1 file changed: 20 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/335.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/335/head:pull/335 PR: https://git.openjdk.org/jdk21u-dev/pull/335 From andrewlu at openjdk.org Wed Mar 6 09:03:12 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 6 Mar 2024 09:03:12 GMT Subject: [jdk11u-dev] RFR: 8248667: Need support for building native libraries located in the test/lib directory [v2] In-Reply-To: References: Message-ID: > Backport for JDK-8248194 and JDK-8248667 Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: fix error ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2580/files - new: https://git.openjdk.org/jdk11u-dev/pull/2580/files/8a7ec35f..6ce47de8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2580&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2580&range=00-01 Stats: 4 lines in 1 file changed: 2 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2580.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2580/head:pull/2580 PR: https://git.openjdk.org/jdk11u-dev/pull/2580 From rrich at openjdk.org Wed Mar 6 09:07:52 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 6 Mar 2024 09:07:52 GMT Subject: [jdk21u-dev] Integrated: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 14:49:21 GMT, Richard Reingruber wrote: > This changes `JVM_ENTRY_FROM_LEAF` to switch to `WXWrite` before transitioning to the vm. > This is needed on macos/aarch64 because there it is an [invariant of vm coding](https://github.com/openjdk/jdk/blob/0583f7357480c0500daa82f490b2fcc05f2fb65a/src/hotspot/share/runtime/interfaceSupport.inline.hpp#L253-L259) that a thread is in `WXWrite` mode. > > Without we can get similar crashes as described in the bug report when writing to the code cache. > Note that in jdk21 we cannot get the very same crash because the nmethod sweeper was removed in jdk20 with [JDK-8290025](https://bugs.openjdk.org/browse/JDK-8290025). > > Also `test/jdk/sun/nio/cs/FindDecoderBugs.java` fails with an assertion if the vm option `-XX:+AssertWXAtThreadSync` is set. > > Testing: > `test/jdk/sun/nio/cs/FindDecoderBugs.java` with `-XX:+AssertWXAtThreadSync` > > The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. This pull request has now been integrated. Changeset: ad1d3248 Author: Richard Reingruber URL: https://git.openjdk.org/jdk21u-dev/commit/ad1d32484a8130c9b641cff38c07e8544b3fd271 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 Reviewed-by: mdoerr ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/305 From goetz.lindenmaier at sap.com Wed Mar 6 09:08:26 2024 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Wed, 6 Mar 2024 09:08:26 +0000 Subject: [jdk-updates notice] Check GHA tests before labeling -fix-request Message-ID: Hi contributors to the jdk-updates projects You need to test changes you want to bring to the updates repositories before labeling -fix-request or using the /approval command. This includes passing the GHA tests. We currently see the GHA tests fail due to a build issue on Risc-V. This does not give you the right to just request approval. You must first assure the failure is only caused by this issue, and you must give a reason in the PR why you want to integrate your change anyways. If you fail to do this, I will just remove the -fix-request label when I check your change for approval. Check the tests, add a comment and request approval again. Also give the approval reason again: the comment in the JBS issue will be overwritten. I will not comment in each change that you need to check the tests, nor will I check them by myself. Scanning the approval request on a daily basis is a considerable effort, and I can not keep it up if a large amount of changes don't meet the criteria that are documented in How to contribute or backport a fix - How to contribute or backport a fix - OpenJDK Wiki Just for the records, it just happened that a change was pushed that broke the build which was overseen because the tests had not been checked. Best regards, Goetz. -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrewlu at openjdk.org Wed Mar 6 09:20:01 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 6 Mar 2024 09:20:01 GMT Subject: [jdk21u-dev] RFR: 8325972: Add -x to bash for building with LOG=debug [v2] In-Reply-To: References: Message-ID: <4DK7zLMlG248XUMHdzbFFsgO56EVCUxl8-71s1b6-SM=.194b148b-5398-46b8-b80f-0cea8df3b7bb@github.com> > I backport this for parity with 21.0.3-oracle. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-luchenlin-8668198c - Backport 8668198c26bdac412f0a9d1255ca74da860761c5 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/315/files - new: https://git.openjdk.org/jdk21u-dev/pull/315/files/253545f2..0fcc0a66 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=315&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=315&range=00-01 Stats: 316 lines in 16 files changed: 282 ins; 7 del; 27 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/315.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/315/head:pull/315 PR: https://git.openjdk.org/jdk21u-dev/pull/315 From andrewlu at openjdk.org Wed Mar 6 09:20:10 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 6 Mar 2024 09:20:10 GMT Subject: [jdk17u-dev] RFR: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053 [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.11-oracle. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into backport-luchenlin-e4803e0c - Merge branch 'openjdk:master' into backport-luchenlin-e4803e0c - Backport e4803e0cbf00da89b98c8703769edc403bb5055b ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2246/files - new: https://git.openjdk.org/jdk17u-dev/pull/2246/files/b5427231..382f7dd6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2246&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2246&range=01-02 Stats: 67 lines in 8 files changed: 55 ins; 6 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2246.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2246/head:pull/2246 PR: https://git.openjdk.org/jdk17u-dev/pull/2246 From andrewlu at openjdk.org Wed Mar 6 09:20:19 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 6 Mar 2024 09:20:19 GMT Subject: [jdk17u-dev] RFR: 8320303: Allow PassFailJFrame to accept single window creator [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.11-oracle. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into backport-luchenlin-83ffc1ac - Merge branch 'openjdk:master' into backport-luchenlin-83ffc1ac - Backport 83ffc1ac94b8893532d8663b9058592f1714d337 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2247/files - new: https://git.openjdk.org/jdk17u-dev/pull/2247/files/4cd78c02..1e898c25 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2247&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2247&range=01-02 Stats: 67 lines in 8 files changed: 55 ins; 6 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2247.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2247/head:pull/2247 PR: https://git.openjdk.org/jdk17u-dev/pull/2247 From andrewlu at openjdk.org Wed Mar 6 09:21:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 6 Mar 2024 09:21:06 GMT Subject: [jdk21u-dev] RFR: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.3-oracle. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-luchenlin-9f0e7da6 - Backport 9f0e7da64e21237322e55ca4f0e3639fa5d1c4ed ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/317/files - new: https://git.openjdk.org/jdk21u-dev/pull/317/files/f02b664f..859915b0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=317&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=317&range=00-01 Stats: 316 lines in 16 files changed: 282 ins; 7 del; 27 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/317.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/317/head:pull/317 PR: https://git.openjdk.org/jdk21u-dev/pull/317 From andrewlu at openjdk.org Wed Mar 6 09:21:15 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 6 Mar 2024 09:21:15 GMT Subject: [jdk17u-dev] RFR: 8325972: Add -x to bash for building with LOG=debug [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.11-oracle. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into andrewLu_backport_8325972 - Backport 8668198c26bdac412f0a9d1255ca74da860761c5 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2264/files - new: https://git.openjdk.org/jdk17u-dev/pull/2264/files/14732090..a6bd70f3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2264&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2264&range=00-01 Stats: 67 lines in 8 files changed: 55 ins; 6 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2264.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2264/head:pull/2264 PR: https://git.openjdk.org/jdk17u-dev/pull/2264 From andrewlu at openjdk.org Wed Mar 6 09:21:29 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 6 Mar 2024 09:21:29 GMT Subject: [jdk17u-dev] RFR: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.11-oracle. > No code change, only code line change in src/hotspot/share/opto/loopopts.cpp, so make it clean. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into andrewLu_backport_8326638 - Backport 9f0e7da64e21237322e55ca4f0e3639fa5d1c4ed ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2265/files - new: https://git.openjdk.org/jdk17u-dev/pull/2265/files/8f4b9d08..1735a69f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2265&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2265&range=00-01 Stats: 67 lines in 8 files changed: 55 ins; 6 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2265.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2265/head:pull/2265 PR: https://git.openjdk.org/jdk17u-dev/pull/2265 From goetz at openjdk.org Wed Mar 6 09:33:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 09:33:16 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master [v2] In-Reply-To: References: Message-ID: > Merge build tag 11.0.23+6 from jdk11u to jdk11u-dev Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision: - Merge - 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id Reviewed-by: mgronlun Backport-of: a885aab696777c99c8c4c5d9a46afc5fe0a4fe47 - 8326938: [11u] JDK-8214908 broke two CTW tests Reviewed-by: phh - 8281507: Two javac tests have bad jtreg `@clean` tags Reviewed-by: mbaesken Backport-of: 86723d4892485651bcae735ed13545ea89b9bb22 - 8314552: Fix javadoc tests to work with jtreg 7 Reviewed-by: phh Backport-of: e83046409d81d074cd68dc823e794a852ed93cee - 8323717: Introduce test keyword for tests that need external dependencies Reviewed-by: phh Backport-of: 12b89cd2eeb5c2c43a2ce425c96fc4f718e30514 - 8305962: update jcstress to 0.16 Backport-of: 292ee630ae32c3b50363b10ffa6090e57ffef1e8 - 8324723: GHA: Upgrade some actions to avoid deprecated Node 16 Reviewed-by: phh Backport-of: 951b5f8ecb9cd2a72b3904c110179afe487ada2b - 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs' Reviewed-by: fyang, gli Backport-of: 2f1c65486b1e584f9c4a2eb7af2414d032a02748 - 8294156: Allow PassFailJFrame.Builder to create test UI Backport-of: 42b9ac8a07b540f4d7955a778923d24a876451cc - ... and 5 more: https://git.openjdk.org/jdk11u-dev/compare/60642a21...0497bc02 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2583/files - new: https://git.openjdk.org/jdk11u-dev/pull/2583/files/0497bc02..0497bc02 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2583&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2583&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2583.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2583/head:pull/2583 PR: https://git.openjdk.org/jdk11u-dev/pull/2583 From goetz at openjdk.org Wed Mar 6 09:33:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 09:33:16 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 07:38:08 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.23+6 from jdk11u to jdk11u-dev This pull request has now been integrated. Changeset: 2a78f2f1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/2a78f2f1591e55caeba9442b3a199db726470ded Stats: 94 lines in 2 files changed: 87 ins; 0 del; 7 mod Merge ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2583 From goetz at openjdk.org Wed Mar 6 09:33:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 09:33:54 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:master In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 07:30:27 GMT, Goetz Lindenmaier wrote: > Merge build tag 17.0.11+6 from jdk17u to jdk17u-dev GHA failure: well known Risc-V issue. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2268#issuecomment-1980439662 From goetz at openjdk.org Wed Mar 6 09:33:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 09:33:54 GMT Subject: [jdk17u-dev] Integrated: Merge jdk17u:master In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 07:30:27 GMT, Goetz Lindenmaier wrote: > Merge build tag 17.0.11+6 from jdk17u to jdk17u-dev This pull request has now been integrated. Changeset: 47ec1340 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/47ec13400b09caae50dade51c986a017ed846032 Stats: 521 lines in 34 files changed: 278 ins; 38 del; 205 mod Merge ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2268 From shade at openjdk.org Wed Mar 6 09:59:48 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 6 Mar 2024 09:59:48 GMT Subject: [jdk21u-dev] RFR: 8320707: Virtual thread test updates In-Reply-To: References: Message-ID: On Tue, 5 Mar 2024 12:29:13 GMT, Aleksey Shipilev wrote: > Test-only backport that simplifies Loom maintenance. The original commit applies cleanly, but it does not work out of the box, because `VThreadPinner` uses FFM, which is a preview feature in JDK 21, made final in JDK 22. I believe it is safe to rely on FFM for these tests, and the only thing we need to do is to add `@enablePreview` in relevant tests. See the additional commits on top that do it. > > This would also make subsequent backports clean. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `jdk_loom hotspot_loom` > - [ ] Linux x86_64 server fastdebug, `all` Grr, the x86_32 thing does not work. Getting back to draft until I can figure it out. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/328#issuecomment-1980491787 From goetz at openjdk.org Wed Mar 6 10:55:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 10:55:53 GMT Subject: [jdk11u-dev] RFR: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h In-Reply-To: References: Message-ID: <3KVLVxJDnQJ5UBrGhs_cIWZHdLovjJsIEfXWm_P8Jjc=.387aa448-9697-4ac5-a56a-4b7b905b9a25@github.com> On Fri, 23 Feb 2024 03:03:38 GMT, lusou-zhangquan wrote: >> Compared with the origin commit in JDK-17, this backport is no clean for two reasons: >> 1. JDK11 doesn't have package handler `zypper` >> 2. JDK11 has the extra package handler `apk` > > @RealCLanger Could you please take a look at this PR? I port JDK-9271142 from JDK17 because the same problem happens when building JDK11 and this patch helps a lot. @lusou-zhangquan, next time please tell how you tested your change in the approval comment! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2538#issuecomment-1980596126 From goetz at openjdk.org Wed Mar 6 11:05:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 11:05:55 GMT Subject: [jdk11u-dev] RFR: 8322511: JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id [v4] In-Reply-To: References: <426I6MDNxce_VFqi_lcS3TzcJF4RS0FtgWcD4ZWMW10=.464138b5-9749-4742-b43b-95e7f98ffe36@github.com> Message-ID: On Wed, 6 Mar 2024 06:18:09 GMT, Jiawei Tang wrote: >> Jiawei Tang has updated the pull request incrementally with one additional commit since the last revision: >> >> Update full name > > The results of related JFR testcases are all successful. > > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/jdk/jfr 434 434 0 0 @jia-wei-tang, can you please add [11u] to the PR title as I did for the JBS issue? Thanks! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2413#issuecomment-1980614674 From duke at openjdk.org Wed Mar 6 11:18:51 2024 From: duke at openjdk.org (lusou-zhangquan) Date: Wed, 6 Mar 2024 11:18:51 GMT Subject: [jdk11u-dev] RFR: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h In-Reply-To: References: Message-ID: <4Ey6OURIVKqV89BFiNG7PXe6Xvgc8L2rDS09tc6Hxgo=.6dd2de79-3d10-48c8-91bc-6231b1a69dc2@github.com> On Fri, 23 Feb 2024 03:03:38 GMT, lusou-zhangquan wrote: >> Compared with the origin commit in JDK-17, this backport is no clean for two reasons: >> 1. JDK11 doesn't have package handler `zypper` >> 2. JDK11 has the extra package handler `apk` > > @RealCLanger Could you please take a look at this PR? I port JDK-9271142 from JDK17 because the same problem happens when building JDK11 and this patch helps a lot. > @lusou-zhangquan, next time please tell how you tested your change in the approval comment! Before creating this PR, I've tested this commit locally and package help messages was printed clearly. Sorry for the absent of test messages in approval comment, won't make the same mistake next time. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2538#issuecomment-1980639230 From duke at openjdk.org Wed Mar 6 11:53:53 2024 From: duke at openjdk.org (lusou-zhangquan) Date: Wed, 6 Mar 2024 11:53:53 GMT Subject: [jdk11u-dev] Integrated: 8271142: package help is not displayed for missing X11/extensions/Xrandr.h In-Reply-To: References: Message-ID: <9V0shjdbSNtrfp5qN71HGO8s3s9XONlEOLZXcGc6920=.eb444467-1a84-4b0a-9f5a-e86919dce38e@github.com> On Thu, 22 Feb 2024 03:23:06 GMT, lusou-zhangquan wrote: > Compared with the origin commit in JDK-17, this backport is no clean for two reasons: > 1. JDK11 doesn't have package handler `zypper` > 2. JDK11 has the extra package handler `apk` This pull request has now been integrated. Changeset: 6c0a88d9 Author: Zhang Quan Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/6c0a88d905ce068045cc3ff02891b48372b4c8c7 Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod 8271142: package help is not displayed for missing X11/extensions/Xrandr.h Reviewed-by: clanger Backport-of: b7f75c0a735f0cf40ae2288d1d0ae96a571a4155 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2538 From goetz at openjdk.org Wed Mar 6 12:05:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 12:05:51 GMT Subject: [jdk17u-dev] RFR: 8320712: Rewrite BadFactoryTest in pure Java In-Reply-To: References: Message-ID: <94PxUsse-ZT6G5oelez_w3RFqFdrl8JHANoJHjaNUtg=.bc55956f-ccde-4a26-8f2c-2f06f9621807@github.com> On Mon, 4 Mar 2024 16:18:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. GHA issue: Risc-V build failure, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2267#issuecomment-1980721430 From goetz at openjdk.org Wed Mar 6 12:07:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 12:07:47 GMT Subject: [jdk17u-dev] RFR: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 14:38:27 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > Omitted one file not in 17. Others clean. Will mark clean. GHA failure: Risc-V build issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2266#issuecomment-1980723539 From syan at openjdk.org Wed Mar 6 12:38:52 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 6 Mar 2024 12:38:52 GMT Subject: [jdk11u-dev] RFR: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout In-Reply-To: <1Zjz-eC7yl0EYJTgpFY8VYy_wIgJb9uWD4EMx1-Hn4g=.518cfe12-8919-4550-bf6b-b6dd4d904b08@github.com> References: <1Zjz-eC7yl0EYJTgpFY8VYy_wIgJb9uWD4EMx1-Hn4g=.518cfe12-8919-4550-bf6b-b6dd4d904b08@github.com> Message-ID: On Wed, 21 Feb 2024 12:15:28 GMT, SendaoYan wrote: > 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout [JDK-8309305](https://bugs.openjdk.org/browse/JDK-8309305) doesn't affect linux, I need some time to make a windows test environment to verify this backport. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2537#issuecomment-1980775437 From robm at openjdk.org Wed Mar 6 12:38:57 2024 From: robm at openjdk.org (Rob McKenna) Date: Wed, 6 Mar 2024 12:38:57 GMT Subject: [jdk22u] RFR: JDK-8327467: Bump version numbers for 22.0.2 Message-ID: Update version number for skara ------------- Commit messages: - JDK-8327467: Bump version numbers for 22.0.2 Changes: https://git.openjdk.org/jdk22u/pull/88/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=88&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327467 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/88.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/88/head:pull/88 PR: https://git.openjdk.org/jdk22u/pull/88 From syan at openjdk.org Wed Mar 6 12:41:53 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 6 Mar 2024 12:41:53 GMT Subject: [jdk11u-dev] RFR: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout In-Reply-To: <1Zjz-eC7yl0EYJTgpFY8VYy_wIgJb9uWD4EMx1-Hn4g=.518cfe12-8919-4550-bf6b-b6dd4d904b08@github.com> References: <1Zjz-eC7yl0EYJTgpFY8VYy_wIgJb9uWD4EMx1-Hn4g=.518cfe12-8919-4550-bf6b-b6dd4d904b08@github.com> Message-ID: <4cUGi_h1SQ-crBMn7kni0m6c-JXD-k53nNLq8TGy4jk=.088abf7b-7bc5-4df2-a6fc-40b881d5e89e@github.com> On Wed, 21 Feb 2024 12:15:28 GMT, SendaoYan wrote: > 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout Shoule I close this PR first. After I finish verify this backport on windows reopen this PR? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2537#issuecomment-1980782104 From syan at openjdk.org Wed Mar 6 12:41:54 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 6 Mar 2024 12:41:54 GMT Subject: [jdk11u-dev] Withdrawn: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout In-Reply-To: <1Zjz-eC7yl0EYJTgpFY8VYy_wIgJb9uWD4EMx1-Hn4g=.518cfe12-8919-4550-bf6b-b6dd4d904b08@github.com> References: <1Zjz-eC7yl0EYJTgpFY8VYy_wIgJb9uWD4EMx1-Hn4g=.518cfe12-8919-4550-bf6b-b6dd4d904b08@github.com> Message-ID: On Wed, 21 Feb 2024 12:15:28 GMT, SendaoYan wrote: > 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2537 From coffeys at openjdk.org Wed Mar 6 12:48:50 2024 From: coffeys at openjdk.org (Sean Coffey) Date: Wed, 6 Mar 2024 12:48:50 GMT Subject: [jdk22u] RFR: JDK-8327467: Bump version numbers for 22.0.2 In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 12:34:28 GMT, Rob McKenna wrote: > Update version number for skara Marked as reviewed by coffeys (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk22u/pull/88#pullrequestreview-1919644894 From sgehwolf at openjdk.org Wed Mar 6 13:00:55 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 6 Mar 2024 13:00:55 GMT Subject: [jdk11u-dev] RFR: 8322511: JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id [v4] In-Reply-To: <426I6MDNxce_VFqi_lcS3TzcJF4RS0FtgWcD4ZWMW10=.464138b5-9749-4742-b43b-95e7f98ffe36@github.com> References: <426I6MDNxce_VFqi_lcS3TzcJF4RS0FtgWcD4ZWMW10=.464138b5-9749-4742-b43b-95e7f98ffe36@github.com> Message-ID: On Tue, 5 Mar 2024 03:14:01 GMT, Jiawei Tang wrote: >> Threads which are in the state of `is_attaching_via_jni` may have the NULL object as their `_threadObj` . >> So the JVM will crash when calling `JfrCheckpointThreadClosure::do_thread()`. > > Jiawei Tang has updated the pull request incrementally with one additional commit since the last revision: > > Update full name Please also enable GHA testing on your fork and trigger test runs! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2413#issuecomment-1980813427 From goetz at openjdk.org Wed Mar 6 13:01:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 13:01:51 GMT Subject: [jdk11u-dev] RFR: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout In-Reply-To: <1Zjz-eC7yl0EYJTgpFY8VYy_wIgJb9uWD4EMx1-Hn4g=.518cfe12-8919-4550-bf6b-b6dd4d904b08@github.com> References: <1Zjz-eC7yl0EYJTgpFY8VYy_wIgJb9uWD4EMx1-Hn4g=.518cfe12-8919-4550-bf6b-b6dd4d904b08@github.com> Message-ID: <8ypv5oKuBGFzBTmegiGwFpH_0XeqLpTWt97oIlxrq3c=.b1c5cb4c-3fd0-46e0-bf97-e82eadce3f8e@github.com> On Wed, 21 Feb 2024 12:15:28 GMT, SendaoYan wrote: > 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout No, there is no need to close it. But you should not request approval if it is not ready. Maybe you want to make it a draft PR. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2537#issuecomment-1980814933 From syan at openjdk.org Wed Mar 6 13:04:49 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 6 Mar 2024 13:04:49 GMT Subject: [jdk11u-dev] RFR: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout In-Reply-To: <8ypv5oKuBGFzBTmegiGwFpH_0XeqLpTWt97oIlxrq3c=.b1c5cb4c-3fd0-46e0-bf97-e82eadce3f8e@github.com> References: <1Zjz-eC7yl0EYJTgpFY8VYy_wIgJb9uWD4EMx1-Hn4g=.518cfe12-8919-4550-bf6b-b6dd4d904b08@github.com> <8ypv5oKuBGFzBTmegiGwFpH_0XeqLpTWt97oIlxrq3c=.b1c5cb4c-3fd0-46e0-bf97-e82eadce3f8e@github.com> Message-ID: <30w9_o7xAxhWe7PZzlqTfKxVp1er1S7ZnmZPvlCqXI8=.c0ca0106-1431-45ce-9fad-6cb4484b6c88@github.com> On Wed, 6 Mar 2024 12:58:51 GMT, Goetz Lindenmaier wrote: > No, there is no need to close it. But you should not request approval if it is not ready. Maybe you want to make it a draft PR. OK. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2537#issuecomment-1980824158 From rrich at openjdk.org Wed Mar 6 13:25:54 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 6 Mar 2024 13:25:54 GMT Subject: [jdk17u-dev] RFR: 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range In-Reply-To: References: Message-ID: On Fri, 23 Feb 2024 10:34:12 GMT, Richard Reingruber wrote: > This backport is a transitive dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031 > > 8310031 requires 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel > and 8282094 requires this backport. > > 8310031 could be backported w/o this backport if 8282094 could be squashed into it because with 8310031 `ObjectStartArray::object_starts_in_range()` is not reached anymore from `PSCardTable::scavenge_contents_parallel()`. > > This backport applies cleanly but needs a trivial renaming (see 2nd commit). > > Risk is low: it's a small change. The changed method has just 2 callers of which one is for diagnostics. > > Manual testing on x86_64: > jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > > Local CI Testing: > The fix passed our CI testing (e.g. 2024-02-22): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. Thanks for review and approval! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2226#issuecomment-1980863879 From rrich at openjdk.org Wed Mar 6 13:25:54 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 6 Mar 2024 13:25:54 GMT Subject: [jdk17u-dev] Integrated: 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range In-Reply-To: References: Message-ID: <-qYscM6DZJbsUitDqXqUWXl8tyduXMpP2IHwMomwhjA=.489dac8e-1c5c-4423-815f-0f7bf0d78e94@github.com> On Fri, 23 Feb 2024 10:34:12 GMT, Richard Reingruber wrote: > This backport is a transitive dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031 > > 8310031 requires 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel > and 8282094 requires this backport. > > 8310031 could be backported w/o this backport if 8282094 could be squashed into it because with 8310031 `ObjectStartArray::object_starts_in_range()` is not reached anymore from `PSCardTable::scavenge_contents_parallel()`. > > This backport applies cleanly but needs a trivial renaming (see 2nd commit). > > Risk is low: it's a small change. The changed method has just 2 callers of which one is for diagnostics. > > Manual testing on x86_64: > jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > > Local CI Testing: > The fix passed our CI testing (e.g. 2024-02-22): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. This pull request has now been integrated. Changeset: dbf4a994 Author: Richard Reingruber URL: https://git.openjdk.org/jdk17u-dev/commit/dbf4a9946bdce1e24e0b87ef8561ce89c54a2863 Stats: 13 lines in 2 files changed: 9 ins; 0 del; 4 mod 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range Reviewed-by: phh, zgu Backport-of: 496baada1021eecae03e737afe838ad6d383cba9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2226 From rrich at openjdk.org Wed Mar 6 13:30:05 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 6 Mar 2024 13:30:05 GMT Subject: [jdk17u-dev] RFR: 8278893: Parallel: Remove GCWorkerDelayMillis [v2] In-Reply-To: References: Message-ID: > This backport is a dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031 > Applies cleanly. > No risk: only unused debug code is removed. > > Local CI Testing: > The fix passed our CI testing (e.g. 2024-02-23): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2227/files - new: https://git.openjdk.org/jdk17u-dev/pull/2227/files/080e0002..080e0002 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2227&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2227&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2227.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2227/head:pull/2227 PR: https://git.openjdk.org/jdk17u-dev/pull/2227 From robm at openjdk.org Wed Mar 6 13:55:55 2024 From: robm at openjdk.org (Rob McKenna) Date: Wed, 6 Mar 2024 13:55:55 GMT Subject: [jdk22u] Integrated: JDK-8327467: Bump version numbers for 22.0.2 In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 12:34:28 GMT, Rob McKenna wrote: > Update version number for skara This pull request has now been integrated. Changeset: 324d7ccf Author: Rob McKenna URL: https://git.openjdk.org/jdk22u/commit/324d7ccfad272ad70ecf18e979cf7c59f45e7009 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8327467: Bump version numbers for 22.0.2 Reviewed-by: coffeys ------------- PR: https://git.openjdk.org/jdk22u/pull/88 From rrich at openjdk.org Wed Mar 6 13:56:08 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 6 Mar 2024 13:56:08 GMT Subject: [jdk17u-dev] RFR: 8278893: Parallel: Remove GCWorkerDelayMillis [v3] In-Reply-To: References: Message-ID: > This backport is a dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031 > Applies cleanly. > No risk: only unused debug code is removed. > > Local CI Testing: > The fix passed our CI testing (e.g. 2024-02-23): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch 'master' into 8278893_backport_17 - 8278893: Parallel: Remove GCWorkerDelayMillis Reviewed-by: ayang, mli - Fix build - 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range Reviewed-by: sjohanss, tschatzl ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/2227/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2227&range=02 Stats: 21 lines in 3 files changed: 0 ins; 21 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2227.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2227/head:pull/2227 PR: https://git.openjdk.org/jdk17u-dev/pull/2227 From szaldana at openjdk.org Wed Mar 6 14:27:13 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 6 Mar 2024 14:27:13 GMT Subject: [jdk17u-dev] RFR: 8306040: HttpResponseInputStream.available() returns 1 on empty stream Message-ID: Hi all, This pull request contains a backport of commit [acaab6fd74f507bb6b18167505d88e505bdf24bd](https://github.com/openjdk/jdk/commit/acaab6fd74f507bb6b18167505d88e505bdf24bd) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. Testing: using the reproducer linked in the issue, I was able to verify the patch. I also ran the additional test case included in the original commit and all tests in ```test/jdk/java/net/httpclient/```. Note that patch is not clean because http tests and related classes have since been moved into a package of their own (namely ```/test/jdk/java/net/httpclient/lib```), which doesn?t exist in jdk 17. Only change introduced in my patch from the original commit: @@ -25,7 +25,7 @@ * @test * @bug 8306040 * @summary HttpResponseInputStream.available() returns 1 on empty stream - * @library /test/lib /test/jdk/java/net/httpclient/lib + * @library /test/lib * @run junit/othervm HttpInputStreamAvailableTest * */ ------------- Commit messages: - Backport acaab6fd74f507bb6b18167505d88e505bdf24bd Changes: https://git.openjdk.org/jdk17u-dev/pull/2263/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2263&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306040 Stats: 163 lines in 2 files changed: 161 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2263.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2263/head:pull/2263 PR: https://git.openjdk.org/jdk17u-dev/pull/2263 From szaldana at openjdk.org Wed Mar 6 14:27:13 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 6 Mar 2024 14:27:13 GMT Subject: [jdk17u-dev] RFR: 8306040: HttpResponseInputStream.available() returns 1 on empty stream In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 18:30:10 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [acaab6fd74f507bb6b18167505d88e505bdf24bd](https://github.com/openjdk/jdk/commit/acaab6fd74f507bb6b18167505d88e505bdf24bd) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > Testing: using the reproducer linked in the issue, I was able to verify the patch. > I also ran the additional test case included in the original commit and all tests in ```test/jdk/java/net/httpclient/```. > > Note that patch is not clean because http tests and related classes have since been moved into a package of their own (namely ```/test/jdk/java/net/httpclient/lib```), which doesn?t exist in jdk 17. > > Only change introduced in my patch from the original commit: > > @@ -25,7 +25,7 @@ > * @test > * @bug 8306040 > * @summary HttpResponseInputStream.available() returns 1 on empty stream > - * @library /test/lib /test/jdk/java/net/httpclient/lib > + * @library /test/lib > * @run junit/othervm HttpInputStreamAvailableTest > * > */ GHA failure: Unrelated Risk-V build issue. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2263#issuecomment-1980984508 From szaldana at openjdk.org Wed Mar 6 14:31:03 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 6 Mar 2024 14:31:03 GMT Subject: [jdk21u-dev] RFR: 8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test Message-ID: Hi all, This pull request contains a backport of commit [54f09d73](https://github.com/openjdk/jdk/commit/54f09d734584a71c648520664447f8395050adbe) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Jaikiran Pai on 23 Feb 2024 and was reviewed by Martin Buchholz and Lance Andersen. Thanks! ------------- Commit messages: - Backport 54f09d734584a71c648520664447f8395050adbe Changes: https://git.openjdk.org/jdk21u-dev/pull/331/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=331&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8278527 Stats: 76 lines in 2 files changed: 0 ins; 76 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/331.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/331/head:pull/331 PR: https://git.openjdk.org/jdk21u-dev/pull/331 From szaldana at openjdk.org Wed Mar 6 14:31:03 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 6 Mar 2024 14:31:03 GMT Subject: [jdk21u-dev] RFR: 8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test In-Reply-To: References: Message-ID: On Tue, 5 Mar 2024 18:45:20 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [54f09d73](https://github.com/openjdk/jdk/commit/54f09d734584a71c648520664447f8395050adbe) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 23 Feb 2024 and was reviewed by Martin Buchholz and Lance Andersen. > > Thanks! GHA failure: Unrelated Risk-V build issue. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/331#issuecomment-1980987189 From mbaesken at openjdk.org Wed Mar 6 14:53:50 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 6 Mar 2024 14:53:50 GMT Subject: [jdk22u] Integrated: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests In-Reply-To: <9CjUPPR5A0pwZI_jENaKt9x5Kc2la_55_UdBjnemTy8=.e1101dd6-a3ab-43b6-8ce0-50457b61e6ef@github.com> References: <9CjUPPR5A0pwZI_jENaKt9x5Kc2la_55_UdBjnemTy8=.e1101dd6-a3ab-43b6-8ce0-50457b61e6ef@github.com> Message-ID: <3VmbB_5rFdP2tMQeC1WWTZPJdJH_skegezyf3-92PXM=.e142c836-e20d-42ad-b91d-b330c34f2215@github.com> On Fri, 1 Mar 2024 12:56:50 GMT, Matthias Baesken wrote: > 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests This pull request has now been integrated. Changeset: d6fc2b17 Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/d6fc2b1796455c62f5fc7a2254cd1d2d89a57230 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests Backport-of: 9f4ec21f4793d4c5fc10f93a32140c26ec0eec00 ------------- PR: https://git.openjdk.org/jdk22u/pull/81 From rrich at openjdk.org Wed Mar 6 14:59:50 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 6 Mar 2024 14:59:50 GMT Subject: [jdk17u-dev] RFR: 8278893: Parallel: Remove GCWorkerDelayMillis [v3] In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 13:56:08 GMT, Richard Reingruber wrote: >> This backport is a dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031 >> Applies cleanly. >> No risk: only unused debug code is removed. >> >> Local CI Testing: >> The fix passed our CI testing (e.g. 2024-02-23): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). >> Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. > > Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' into 8278893_backport_17 > - 8278893: Parallel: Remove GCWorkerDelayMillis > > Reviewed-by: ayang, mli > - Fix build > - 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range > > Reviewed-by: sjohanss, tschatzl riscv64 build error is unrelated. See https://bugs.openjdk.org/browse/JDK-8326960 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2227#issuecomment-1981054197 From rrich at openjdk.org Wed Mar 6 15:04:52 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 6 Mar 2024 15:04:52 GMT Subject: [jdk17u-dev] RFR: 8278893: Parallel: Remove GCWorkerDelayMillis [v3] In-Reply-To: References: Message-ID: <0valTNy-BeIZ3yJQmd7D9KwrRMafAt8eZu0g5eSZNDA=.7150e1ae-ee18-4ea3-b9c1-c0bb8058bea3@github.com> On Wed, 6 Mar 2024 13:56:08 GMT, Richard Reingruber wrote: >> This backport is a dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031 >> Applies cleanly. >> No risk: only unused debug code is removed. >> >> Local CI Testing: >> The fix passed our CI testing (e.g. 2024-02-23): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). >> Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. > > Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' into 8278893_backport_17 > - 8278893: Parallel: Remove GCWorkerDelayMillis > > Reviewed-by: ayang, mli > - Fix build > - 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range > > Reviewed-by: sjohanss, tschatzl Windows debug build error. Looks like the javac server was unavailable but this cannot be caused by this pr. Connection attempt failed: Connection refused: no further information Giving up IOException caught during compilation: Could not connect to server after 10 attempts with timeout 4000 make[3]: *** [CompileDemos.gmk:161: /d/a/jdk17u-dev/jdk17u-dev/build/windows-x64/support/demos/classes/jfc/CodePointIM/_the.BUILD_DEMO_CodePointIM_batch] Error 1 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2227#issuecomment-1981067177 From shade at openjdk.org Wed Mar 6 15:20:51 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 6 Mar 2024 15:20:51 GMT Subject: [jdk22u] RFR: 8323519: Add applications/ctw/modules to Hotspot tiered testing In-Reply-To: <23_-PANrCo1rzKI31wY0gX7n8YPpEc7gA2GnqI68J-0=.29a34326-1f2a-4c59-9971-e797136560d4@github.com> References: <23_-PANrCo1rzKI31wY0gX7n8YPpEc7gA2GnqI68J-0=.29a34326-1f2a-4c59-9971-e797136560d4@github.com> Message-ID: On Thu, 29 Feb 2024 13:44:57 GMT, Aleksey Shipilev wrote: > Clean backport to improve testing. RISC-V failure is known environmental. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/78#issuecomment-1981106091 From shade at openjdk.org Wed Mar 6 15:20:51 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 6 Mar 2024 15:20:51 GMT Subject: [jdk22u] Integrated: 8323519: Add applications/ctw/modules to Hotspot tiered testing In-Reply-To: <23_-PANrCo1rzKI31wY0gX7n8YPpEc7gA2GnqI68J-0=.29a34326-1f2a-4c59-9971-e797136560d4@github.com> References: <23_-PANrCo1rzKI31wY0gX7n8YPpEc7gA2GnqI68J-0=.29a34326-1f2a-4c59-9971-e797136560d4@github.com> Message-ID: <8nEohNieUeHoTmHzrBmuVA91Et4cTSCSYVcLrr5LzsM=.d9f11544-51c1-4aa8-8428-1fb5fed92bbc@github.com> On Thu, 29 Feb 2024 13:44:57 GMT, Aleksey Shipilev wrote: > Clean backport to improve testing. This pull request has now been integrated. Changeset: 648a1616 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/648a1616a598b462c05fbf4373da59432306947a Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8323519: Add applications/ctw/modules to Hotspot tiered testing Backport-of: ba3c3bbd879eaf7532663663d73e21fafc65b574 ------------- PR: https://git.openjdk.org/jdk22u/pull/78 From goetz at openjdk.org Wed Mar 6 16:15:08 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 16:15:08 GMT Subject: [jdk17u-dev] RFR: 8291753: Add JFR event for GC CPU Time Message-ID: I backport this as proposed before in https://github.com/openjdk/jdk17u-dev/pull/1900. Prereq changes are already done. The backport has been tested by [releaseing it in SapMachine in 17.0.10](https://github.com/SAP/SapMachine/commit/[1d275fd954aaaa6b1f4623d547e3edff46b97e84](https://github.com/SAP/SapMachine/commit/1d275fd954aaaa6b1f4623d547e3edff46b97e84)). This patch here is identical to the one in SapMachine. It will go to 17.0.12 giving enough time to settle. The g1 files needed several trivial resolves due to context differences. Especially variable do_maximum_compaction was renamed to do_maximal_compaction. This appears several times in the context. Further trivial resolves in src/hotspot/share/gc/serial/defNewGeneration.hpp src/hotspot/share/gc/shared/gcTrace.hpp src/hotspot/share/gc/shared/genCollectedHeap.cpp src/jdk.jfr/share/conf/jfr/profile.jfc The whitespace fix is not needed in 17. Omitted. ------------- Commit messages: - Backport 14eb5ad0dc987ffe3621f4eeeebeb6b5a2cd691b Changes: https://git.openjdk.org/jdk17u-dev/pull/2270/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2270&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291753 Stats: 217 lines in 23 files changed: 163 ins; 2 del; 52 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2270.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2270/head:pull/2270 PR: https://git.openjdk.org/jdk17u-dev/pull/2270 From rrich at openjdk.org Wed Mar 6 16:28:52 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 6 Mar 2024 16:28:52 GMT Subject: [jdk17u-dev] Integrated: 8278893: Parallel: Remove GCWorkerDelayMillis In-Reply-To: References: Message-ID: <1W5HlxyFAX25FUNrNzodtFWylMzgl5GV_B_nqkSGYII=.db904a51-c081-4816-86ec-3df1b814ae40@github.com> On Fri, 23 Feb 2024 11:13:21 GMT, Richard Reingruber wrote: > This backport is a dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031 > Applies cleanly. > No risk: only unused debug code is removed. > > Local CI Testing: > The fix passed our CI testing (e.g. 2024-02-23): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. This pull request has now been integrated. Changeset: 5421bb65 Author: Richard Reingruber URL: https://git.openjdk.org/jdk17u-dev/commit/5421bb65d0a5deac28d196959d8d3950aea52d46 Stats: 21 lines in 3 files changed: 0 ins; 21 del; 0 mod 8278893: Parallel: Remove GCWorkerDelayMillis Backport-of: ff5d41762d5ba31e88c6cb9207a8ae57f34a69b0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2227 From rrich at openjdk.org Wed Mar 6 16:33:16 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 6 Mar 2024 16:33:16 GMT Subject: [jdk17u-dev] RFR: 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel [v2] In-Reply-To: References: Message-ID: <4Wlwea6MKN1tULI_mgltr5f8TuIJJ2TJ_o-XNcu8QNA=.59a9f4e6-4bb6-4f6f-85a3-76aafe0d2c45@github.com> > This backport is a dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031 > Applies cleanly. Only a trivial renaming is required. > Risk is medium. We've done the downstream backport already many weeks ago. > > I've tested on x86_64: > jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > > Local CI Testing: > The fix passed our CI testing (e.g. 2024-02-24): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2228/files - new: https://git.openjdk.org/jdk17u-dev/pull/2228/files/c64debe9..c64debe9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2228&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2228&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2228.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2228/head:pull/2228 PR: https://git.openjdk.org/jdk17u-dev/pull/2228 From aleonard at openjdk.org Wed Mar 6 17:03:59 2024 From: aleonard at openjdk.org (Andrew Leonard) Date: Wed, 6 Mar 2024 17:03:59 GMT Subject: [jdk21u-dev] RFR: 8326685: Linux builds not reproducible if two builds configured in different build folders Message-ID: Backports the debug symbol mapping fix to ensure two builds built in different build output directories are identical. ------------- Commit messages: - Backport 3b90ddfefea36d9f7f08ff11cd0cb099aa32b02b Changes: https://git.openjdk.org/jdk21u-dev/pull/336/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=336&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326685 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/336.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/336/head:pull/336 PR: https://git.openjdk.org/jdk21u-dev/pull/336 From rrich at openjdk.org Wed Mar 6 17:09:47 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 6 Mar 2024 17:09:47 GMT Subject: [jdk17u-dev] RFR: 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel [v2] In-Reply-To: <4Wlwea6MKN1tULI_mgltr5f8TuIJJ2TJ_o-XNcu8QNA=.59a9f4e6-4bb6-4f6f-85a3-76aafe0d2c45@github.com> References: <4Wlwea6MKN1tULI_mgltr5f8TuIJJ2TJ_o-XNcu8QNA=.59a9f4e6-4bb6-4f6f-85a3-76aafe0d2c45@github.com> Message-ID: On Wed, 6 Mar 2024 16:33:16 GMT, Richard Reingruber wrote: >> This backport is a dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031 >> Applies cleanly. Only a trivial renaming is required. >> Risk is medium. We've done the downstream backport already many weeks ago. >> >> I've tested on x86_64: >> jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" >> langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" >> >> Local CI Testing: >> The fix passed our CI testing (e.g. 2024-02-24): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). >> Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. > > Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. So I'm trying to merge master after integration of the dependent PR #2227. Why do I get conflicts?? The backport applied cleanly on #2227 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2228#issuecomment-1981370842 From rrich at openjdk.org Wed Mar 6 17:28:07 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Wed, 6 Mar 2024 17:28:07 GMT Subject: [jdk17u-dev] RFR: 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel [v3] In-Reply-To: References: Message-ID: > This backport is a dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031 > Applies cleanly. Only a trivial renaming is required. > Risk is medium. We've done the downstream backport already many weeks ago. > > I've tested on x86_64: > jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > > Local CI Testing: > The fix passed our CI testing (e.g. 2024-02-24): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge branch 'master' into 8282094_17u_backport - Fix build - 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel Reviewed-by: iwalulya, tschatzl - 8278893: Parallel: Remove GCWorkerDelayMillis Reviewed-by: ayang, mli - Fix build - 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range Reviewed-by: sjohanss, tschatzl ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/2228/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2228&range=02 Stats: 277 lines in 2 files changed: 103 ins; 101 del; 73 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2228.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2228/head:pull/2228 PR: https://git.openjdk.org/jdk17u-dev/pull/2228 From goetz at openjdk.org Wed Mar 6 18:46:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 6 Mar 2024 18:46:48 GMT Subject: [jdk17u-dev] RFR: 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel [v3] In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 17:28:07 GMT, Richard Reingruber wrote: >> This backport is a dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031 >> Applies cleanly. Only a trivial renaming is required. >> Risk is medium. We've done the downstream backport already many weeks ago. >> >> I've tested on x86_64: >> jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" >> langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" >> >> Local CI Testing: >> The fix passed our CI testing (e.g. 2024-02-24): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). >> Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. > > Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: > > - Merge branch 'master' into 8282094_17u_backport > - Fix build > - 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel > > Reviewed-by: iwalulya, tschatzl > - 8278893: Parallel: Remove GCWorkerDelayMillis > > Reviewed-by: ayang, mli > - Fix build > - 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range > > Reviewed-by: sjohanss, tschatzl Hi, this is because you merge two changes, the one that sits under this one and the copy of it that was pushed to jdk17u-dev. They are identical, but Github does not grok this. This is very annoying. I have seen errors before in the parts merged automatically. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2228#issuecomment-1981554251 From szaldana at openjdk.org Wed Mar 6 19:36:59 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 6 Mar 2024 19:36:59 GMT Subject: [jdk21u-dev] RFR: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters Message-ID: <-qKxc0To9o5aSuiwIrqcSe2UzM-L5qCRSo_pmGyX6oI=.40d264e6-6dfa-4484-b8db-8f306cc614db@github.com> Hi all, This pull request contains a backport of commit [82796bdebbf56b98ec97a6d572ed68c2842f60c6](https://github.com/openjdk/jdk/commit/82796bdebbf56b98ec97a6d572ed68c2842f60c6) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. Note, patch is not clean. The only difference between the original commit and this backport is the variable name ```utf16``` [(original commit)](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/String.java#L595) vs ```buf``` [(jdk21u state)](https://github.com/openjdk/jdk21u-dev/blob/master/src/java.base/share/classes/java/lang/String.java#L577). I coalesced those differences by keeping the ```buf``` variable name for jdk21u. Testing: Was able to verify behaviour with reproducer and added test case passes. Thanks! ------------- Commit messages: - Backport 82796bdebbf56b98ec97a6d572ed68c2842f60c6 Changes: https://git.openjdk.org/jdk21u-dev/pull/332/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=332&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320570 Stats: 82 lines in 2 files changed: 75 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/332.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/332/head:pull/332 PR: https://git.openjdk.org/jdk21u-dev/pull/332 From szaldana at openjdk.org Wed Mar 6 19:36:59 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 6 Mar 2024 19:36:59 GMT Subject: [jdk21u-dev] RFR: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters In-Reply-To: <-qKxc0To9o5aSuiwIrqcSe2UzM-L5qCRSo_pmGyX6oI=.40d264e6-6dfa-4484-b8db-8f306cc614db@github.com> References: <-qKxc0To9o5aSuiwIrqcSe2UzM-L5qCRSo_pmGyX6oI=.40d264e6-6dfa-4484-b8db-8f306cc614db@github.com> Message-ID: <6juYLVTfG9IQ01h79sDsoRSOSNUpyXeqLBIRMnAQc5Y=.4bb3c8c8-2b26-48ea-93c1-0103e98f703a@github.com> On Tue, 5 Mar 2024 19:02:47 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [82796bdebbf56b98ec97a6d572ed68c2842f60c6](https://github.com/openjdk/jdk/commit/82796bdebbf56b98ec97a6d572ed68c2842f60c6) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > Note, patch is not clean. > > The only difference between the original commit and this backport is the variable name ```utf16``` [(original commit)](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/String.java#L595) vs ```buf``` [(jdk21u state)](https://github.com/openjdk/jdk21u-dev/blob/master/src/java.base/share/classes/java/lang/String.java#L577). I coalesced those differences by keeping the ```buf``` variable name for jdk21u. > > > > Testing: Was able to verify behaviour with reproducer and added test case passes. > > Thanks! GHA failure: Unrelated Risk-V build issue. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/332#issuecomment-1980995778 From vpetko at openjdk.org Wed Mar 6 21:05:58 2024 From: vpetko at openjdk.org (Vladimir Petko) Date: Wed, 6 Mar 2024 21:05:58 GMT Subject: [jdk22u] RFR: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 08:32:03 GMT, Vladimir Petko wrote: > Hi all, > > This pull request contains a backport of commit [d1099033](https://github.com/openjdk/jdk/commit/d1099033ac63b9dd0dd6e3a7341db929e9e0e56e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alan Bateman on 8 Feb 2024 and was reviewed by Brian Burkhalter. > > This change fixes a bug in jruby[1] that broken pipeline functions of Open3[1][2]. > > Thanks! > > [1] https://github.com/jruby/jruby/issues/8069 > [2] https://bugs.launchpad.net/ubuntu/+source/jruby/+bug/2054943 @GoeLin Hi, I have removed fix request due to the broken RISCV sysroot . The error that I am getting: W: See /home/runner/work/jdk22u/jdk22u/sysroot/debootstrap/debootstrap.log for details (possibly the package /var/cache/apt/archives/libssl3t64_3.1.5-1.1_riscv64.deb is at fault) hints at RISCV being affected by time_t transition currently going on in Debian. This will be an issue for the next few weeks. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/79#issuecomment-1981772716 From erikj at openjdk.org Wed Mar 6 22:53:50 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Wed, 6 Mar 2024 22:53:50 GMT Subject: [jdk22u] RFR: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries Message-ID: Clean backport. ------------- Commit messages: - Backport 721bfee53af5bc2e2d67eebc7b82f09a642d5309 Changes: https://git.openjdk.org/jdk22u/pull/89/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=89&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326891 Stats: 22 lines in 2 files changed: 8 ins; 3 del; 11 mod Patch: https://git.openjdk.org/jdk22u/pull/89.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/89/head:pull/89 PR: https://git.openjdk.org/jdk22u/pull/89 From phh at openjdk.org Wed Mar 6 23:26:03 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 6 Mar 2024 23:26:03 GMT Subject: [jdk17u-dev] RFR: 8291753: Add JFR event for GC CPU Time In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 16:09:37 GMT, Goetz Lindenmaier wrote: > I backport this as proposed before in https://github.com/openjdk/jdk17u-dev/pull/1900. Prereq changes are already done. > > The backport has been tested by [releaseing it in SapMachine in 17.0.10](https://github.com/SAP/SapMachine/commit/[1d275fd954aaaa6b1f4623d547e3edff46b97e84](https://github.com/SAP/SapMachine/commit/1d275fd954aaaa6b1f4623d547e3edff46b97e84)). This patch here is identical to the one in SapMachine. It will go to 17.0.12 giving enough time to settle. > > The g1 files needed several trivial resolves due to context differences. Especially variable do_maximum_compaction was renamed to do_maximal_compaction. This appears several times in the context. > > Further trivial resolves in > src/hotspot/share/gc/serial/defNewGeneration.hpp > src/hotspot/share/gc/shared/gcTrace.hpp > src/hotspot/share/gc/shared/genCollectedHeap.cpp > > src/jdk.jfr/share/conf/jfr/profile.jfc > The whitespace fix is not needed in 17. Omitted. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2270#pullrequestreview-1921024576 From phh at openjdk.org Wed Mar 6 23:59:55 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 6 Mar 2024 23:59:55 GMT Subject: [jdk21u-dev] RFR: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters In-Reply-To: <-qKxc0To9o5aSuiwIrqcSe2UzM-L5qCRSo_pmGyX6oI=.40d264e6-6dfa-4484-b8db-8f306cc614db@github.com> References: <-qKxc0To9o5aSuiwIrqcSe2UzM-L5qCRSo_pmGyX6oI=.40d264e6-6dfa-4484-b8db-8f306cc614db@github.com> Message-ID: On Tue, 5 Mar 2024 19:02:47 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [82796bdebbf56b98ec97a6d572ed68c2842f60c6](https://github.com/openjdk/jdk/commit/82796bdebbf56b98ec97a6d572ed68c2842f60c6) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > Note, patch is not clean. > > The only difference between the original commit and this backport is the variable name ```utf16``` [(original commit)](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/String.java#L595) vs ```buf``` [(jdk21u state)](https://github.com/openjdk/jdk21u-dev/blob/master/src/java.base/share/classes/java/lang/String.java#L577). I coalesced those differences by keeping the ```buf``` variable name for jdk21u. > > > > Testing: Was able to verify behaviour with reproducer and added test case passes. > > Thanks! Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/332#pullrequestreview-1921056963 From aoqi at openjdk.org Thu Mar 7 00:53:58 2024 From: aoqi at openjdk.org (Ao Qi) Date: Thu, 7 Mar 2024 00:53:58 GMT Subject: [jdk11u-dev] RFR: 8267938: (sctp) SCTP channel factory methods should check platform support In-Reply-To: <5B0Nc8r20ZgoPOoXO2OLhPMnDVBLb17jWx72vJjANe8=.337e7793-25ac-4070-b51c-b8a258a9ead5@github.com> References: <5B0Nc8r20ZgoPOoXO2OLhPMnDVBLb17jWx72vJjANe8=.337e7793-25ac-4070-b51c-b8a258a9ead5@github.com> Message-ID: <2mqUYNEvO3ZqRwDjD3y0WXc61PcATBj1tji9kEbajLo=.10812d81-39ba-4d5a-839f-186c72dc008d@github.com> On Tue, 30 Jan 2024 04:58:31 GMT, Ao Qi wrote: > Hi all, > > I would like to backport [JDK-8267938](https://bugs.openjdk.org/browse/JDK-8267938). According to the bug description, 11(.0.11) is also affected. `java/net/SctpSanity.java` can reproduce this problem. The backport is clean except copyright year. GHA testing is passed. > > Additional testing, no regression introduced by this backport: > - [x] Linux x86_64 server release, `tier1 tier2 tier3` > - [x] Linux x86_64 server fastdebug, `tier1 tier2 tier3` > > Thanks! @GoeLin, thanks for the approval, and could you help to sponsor? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2500#issuecomment-1982139126 From duke at openjdk.org Thu Mar 7 01:27:57 2024 From: duke at openjdk.org (duke) Date: Thu, 7 Mar 2024 01:27:57 GMT Subject: [jdk11u-dev] Withdrawn: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader In-Reply-To: <6-YRvqmmwW7Y2c8JR0oZlTmhFhhU8dp8P20hBs8UXDY=.54b1acb9-1881-41a4-ad8a-00110c0401a9@github.com> References: <6-YRvqmmwW7Y2c8JR0oZlTmhFhhU8dp8P20hBs8UXDY=.54b1acb9-1881-41a4-ad8a-00110c0401a9@github.com> Message-ID: On Wed, 10 Jan 2024 19:48:06 GMT, Ben Taylor wrote: > Clean backport of [JDK-8319436](https://bugs.openjdk.org/browse/JDK-8319436) to resolve a regression introduced in 11.0.20. Included tests pass locally on linux x64. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2454 From syan at openjdk.org Thu Mar 7 03:10:58 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 7 Mar 2024 03:10:58 GMT Subject: [jdk17u-dev] Withdrawn: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test In-Reply-To: References: Message-ID: On Tue, 6 Feb 2024 08:44:55 GMT, SendaoYan wrote: > The option "-XX:LoopUnrollLimit=0" results in no unrolling and consequently no vectorization opportunities in the test code. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2194 From goetz at openjdk.org Thu Mar 7 07:28:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 07:28:54 GMT Subject: [jdk17u-dev] RFR: 8315677: Open source few swing JFileChooser and other tests In-Reply-To: References: Message-ID: <0hDT0j7srK0O-ROu4wIhJuXUh5WAB3jrZjIuA3DvPWY=.e202f8f2-4eab-4144-9e89-895f7937db65@github.com> On Wed, 28 Feb 2024 19:22:29 GMT, Amos Shi wrote: > Backport of [JDK-8315677](https://bugs.openjdk.org/browse/JDK-8315677) > > Testing > - Local: Test passed > - `bug4624353.java` - Test results: passed: 1 > - `bug4673161.java` - Test results: no tests selected > - `bug4782168.java` - Test results: passed: 1 > - `bug4822331.java` - Test results: passed: 1 > - `bug4191835.java` - Test results: passed: 1 > - Pipeline: > - Testing Machine: SAP nightlies passed on `2024-03-01,02,03` GHA failure: Riscv build issue. Unrelated. @amosshi, please check the tests before labeling!!! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2251#issuecomment-1982734896 From goetz at openjdk.org Thu Mar 7 07:44:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 07:44:53 GMT Subject: [jdk21u-dev] RFR: 8324174: assert(m->is_entered(current)) failed: invariant In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 08:33:05 GMT, lusou-zhangquan wrote: > Clean backport from master to fix the incorrect lock and unlock order problem of nested locks during deoptimization. Hi @lusou-zhangquan, please follow the instructions in https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix and also see yesterdays mail https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-March/030685.html ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/334#issuecomment-1982774909 From rrich at openjdk.org Thu Mar 7 07:58:56 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 7 Mar 2024 07:58:56 GMT Subject: [jdk17u-dev] RFR: 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel [v3] In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 17:28:07 GMT, Richard Reingruber wrote: >> This backport is a dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031 >> Applies cleanly. Only a trivial renaming is required. >> Risk is medium. We've done the downstream backport already many weeks ago. >> >> I've tested on x86_64: >> jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" >> langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" >> >> Local CI Testing: >> The fix passed our CI testing (e.g. 2024-02-24): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). >> Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. > > Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: > > - Merge branch 'master' into 8282094_17u_backport > - Fix build > - 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel > > Reviewed-by: iwalulya, tschatzl > - 8278893: Parallel: Remove GCWorkerDelayMillis > > Reviewed-by: ayang, mli > - Fix build > - 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range > > Reviewed-by: sjohanss, tschatzl Test failure is unrelated (https://bugs.openjdk.org/browse/JDK-8326960) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2228#issuecomment-1982822800 From goetz at openjdk.org Thu Mar 7 08:05:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 08:05:56 GMT Subject: [jdk11u-dev] RFR: 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 11:02:01 GMT, Sergey Nazarkin wrote: > I'd like to backport this changes as it fixes some custom launchers issue. The backport is not clean: > 1. [8234821](https://bugs.openjdk.org/browse/JDK-8234821) was not backported to jdk11, so *java_md_common.c* need manual adjusting. > 2. The test can't be started as it depends on whole jpackage test [pack](https://bugs.openjdk.org/browse/JDK-8268974). So I've removed it. > > The functionality was tested with simple > > cd ~/tools/bin > cp -r ~/jdk . > cp jdk/bin/java jdk/lib > jdk/lib/java -version > > > Without the patch it show the error > > Error: could not find libjava.so > Error: Could not find Java SE Runtime Environment. > > > jdk_tier2 is OK as well @snazarkin you need a review before requesting approval ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2578#issuecomment-1982841457 From andrewlu at openjdk.org Thu Mar 7 08:07:05 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 7 Mar 2024 08:07:05 GMT Subject: [jdk11u-dev] Integrated: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053 In-Reply-To: References: Message-ID: <-T5AnwN1Mbru02Uoyqz8zirLR0B8zDm5qBrFAsfDMyo=.50a05c13-a636-49fe-babc-1bb4aefa080a@github.com> On Wed, 28 Feb 2024 07:26:25 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. This pull request has now been integrated. Changeset: 4ef8db86 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/4ef8db867145f24062fe7c774653aadbebc4dc84 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053 Backport-of: e4803e0cbf00da89b98c8703769edc403bb5055b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2567 From andrewlu at openjdk.org Thu Mar 7 08:07:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 7 Mar 2024 08:07:06 GMT Subject: [jdk17u-dev] Integrated: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053 In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 07:26:12 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 30ead33d Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/30ead33ded77353ba007035c0796d79c6740b33e Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053 Backport-of: e4803e0cbf00da89b98c8703769edc403bb5055b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2246 From andrewlu at openjdk.org Thu Mar 7 08:09:59 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 7 Mar 2024 08:09:59 GMT Subject: [jdk17u-dev] Integrated: 8320303: Allow PassFailJFrame to accept single window creator In-Reply-To: References: Message-ID: <_07sOzIN64k3m7Qbf-1sl-FQQ8y4BtT8vFOotvdNwZs=.ce587c64-7c57-423c-b247-b19a8c524c58@github.com> On Wed, 28 Feb 2024 07:46:50 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 385731fa Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/385731faf9bf743862ae75dbd9a13e1781842d5a Stats: 152 lines in 1 file changed: 125 ins; 6 del; 21 mod 8320303: Allow PassFailJFrame to accept single window creator Backport-of: 83ffc1ac94b8893532d8663b9058592f1714d337 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2247 From andrewlu at openjdk.org Thu Mar 7 08:10:01 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 7 Mar 2024 08:10:01 GMT Subject: [jdk17u-dev] Integrated: 8325972: Add -x to bash for building with LOG=debug In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 05:36:26 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: f4236869 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/f42368691c8a7529b2fc70c09729cb890ce1f368 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8325972: Add -x to bash for building with LOG=debug Backport-of: 8668198c26bdac412f0a9d1255ca74da860761c5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2264 From andrewlu at openjdk.org Thu Mar 7 08:10:05 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 7 Mar 2024 08:10:05 GMT Subject: [jdk21u-dev] Integrated: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 09:09:51 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: e0718433 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/e071843318f81136a34f5a325a01a30bb1bfe19a Stats: 60 lines in 2 files changed: 57 ins; 0 del; 3 mod 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop Backport-of: 9f0e7da64e21237322e55ca4f0e3639fa5d1c4ed ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/317 From andrewlu at openjdk.org Thu Mar 7 08:10:05 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 7 Mar 2024 08:10:05 GMT Subject: [jdk11u-dev] Integrated: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop In-Reply-To: References: Message-ID: <_Vec32ynZM4joKqy9GQXjqoQdTz5mtCWbYaJsMObROc=.4bddea06-cf5a-41f4-91f5-1ed4f57b5e0f@github.com> On Mon, 4 Mar 2024 09:43:57 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. > No code change, only code line change in src/hotspot/share/opto/loopopts.cpp, so make it clean. This pull request has now been integrated. Changeset: bc14b9f1 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/bc14b9f12e00b16194e228b315bc08a878d314d4 Stats: 60 lines in 2 files changed: 57 ins; 0 del; 3 mod 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop Backport-of: 9f0e7da64e21237322e55ca4f0e3639fa5d1c4ed ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2581 From rehn at openjdk.org Thu Mar 7 08:10:06 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Thu, 7 Mar 2024 08:10:06 GMT Subject: [jdk22u] Integrated: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 08:32:20 GMT, Robbin Ehn wrote: > Hi all, > > This pull request contains a backport of commit [68eb5a1d](https://github.com/openjdk/jdk/commit/68eb5a1df5afdc011aa467f1c723a8792532dd3f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Robbin Ehn on 21 Feb 2024 and was reviewed by Fei Yang, Yadong Wang and Ludovic Henry. > > Thanks! This pull request has now been integrated. Changeset: cebe57d4 Author: Robbin Ehn URL: https://git.openjdk.org/jdk22u/commit/cebe57d4577f4ae32ce24c3f868c82488f2aa4fa Stats: 40 lines in 3 files changed: 39 ins; 0 del; 1 mod 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support Backport-of: 68eb5a1df5afdc011aa467f1c723a8792532dd3f ------------- PR: https://git.openjdk.org/jdk22u/pull/83 From rehn at openjdk.org Thu Mar 7 08:10:06 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Thu, 7 Mar 2024 08:10:06 GMT Subject: [jdk22u] RFR: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 08:32:20 GMT, Robbin Ehn wrote: > Hi all, > > This pull request contains a backport of commit [68eb5a1d](https://github.com/openjdk/jdk/commit/68eb5a1df5afdc011aa467f1c723a8792532dd3f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Robbin Ehn on 21 Feb 2024 and was reviewed by Fei Yang, Yadong Wang and Ludovic Henry. > > Thanks! Rv is failing due to env. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/83#issuecomment-1982849588 From andrewlu at openjdk.org Thu Mar 7 08:11:03 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 7 Mar 2024 08:11:03 GMT Subject: [jdk21u-dev] Integrated: 8325972: Add -x to bash for building with LOG=debug In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 03:20:27 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: bfaec80e Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/bfaec80e80ee51d6f9b0e91fe136d4d77a885d10 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8325972: Add -x to bash for building with LOG=debug Backport-of: 8668198c26bdac412f0a9d1255ca74da860761c5 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/315 From andrewlu at openjdk.org Thu Mar 7 08:11:08 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 7 Mar 2024 08:11:08 GMT Subject: [jdk11u-dev] Integrated: 8320303: Allow PassFailJFrame to accept single window creator In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 07:49:18 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. This pull request has now been integrated. Changeset: b425dff6 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/b425dff6bbec035b18606be45800e621219a15df Stats: 152 lines in 1 file changed: 125 ins; 6 del; 21 mod 8320303: Allow PassFailJFrame to accept single window creator Backport-of: 83ffc1ac94b8893532d8663b9058592f1714d337 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2568 From andrewlu at openjdk.org Thu Mar 7 08:11:08 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 7 Mar 2024 08:11:08 GMT Subject: [jdk11u-dev] Integrated: 8325972: Add -x to bash for building with LOG=debug In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 05:43:36 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. This pull request has now been integrated. Changeset: f3069d13 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/f3069d13d23301405b096db6d4843500a5f5fa56 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8325972: Add -x to bash for building with LOG=debug Backport-of: 8668198c26bdac412f0a9d1255ca74da860761c5 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2579 From andrewlu at openjdk.org Thu Mar 7 08:11:09 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 7 Mar 2024 08:11:09 GMT Subject: [jdk17u-dev] Integrated: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 09:42:28 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. > No code change, only code line change in src/hotspot/share/opto/loopopts.cpp, so make it clean. This pull request has now been integrated. Changeset: 3c05a028 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/3c05a0281d9086fcfe8f99438fd343ffffb82a07 Stats: 60 lines in 2 files changed: 57 ins; 0 del; 3 mod 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop Backport-of: 9f0e7da64e21237322e55ca4f0e3639fa5d1c4ed ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2265 From andrewlu at openjdk.org Thu Mar 7 08:11:29 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 7 Mar 2024 08:11:29 GMT Subject: [jdk21u-dev] RFR: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.3-oracle. > depends on backport for 8320303 Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-luchenlin-1f2922ad - Backport 1f2922ad8526d378ee7b616e5423ce56f20340db ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/291/files - new: https://git.openjdk.org/jdk21u-dev/pull/291/files/dc69b6ef..586f0531 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=291&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=291&range=00-01 Stats: 2664 lines in 89 files changed: 2157 ins; 145 del; 362 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/291.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/291/head:pull/291 PR: https://git.openjdk.org/jdk21u-dev/pull/291 From andrewlu at openjdk.org Thu Mar 7 08:12:17 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 7 Mar 2024 08:12:17 GMT Subject: [jdk17u-dev] RFR: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 17.0.11-oracle. > depends on backport for 8320303 Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-luchenlin-1f2922ad - Backport 1f2922ad8526d378ee7b616e5423ce56f20340db ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2231/files - new: https://git.openjdk.org/jdk17u-dev/pull/2231/files/09a53f0a..cc17af3f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2231&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2231&range=00-01 Stats: 3459 lines in 136 files changed: 2801 ins; 198 del; 460 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2231.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2231/head:pull/2231 PR: https://git.openjdk.org/jdk17u-dev/pull/2231 From andrewlu at openjdk.org Thu Mar 7 08:13:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 7 Mar 2024 08:13:40 GMT Subject: [jdk11u-dev] RFR: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.24-oracle. > depends on backport for 8320303 Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-luchenlin-1f2922ad - Backport 1f2922ad8526d378ee7b616e5423ce56f20340db ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2548/files - new: https://git.openjdk.org/jdk11u-dev/pull/2548/files/987ff158..26caf59e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2548&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2548&range=00-01 Stats: 72913 lines in 106 files changed: 3039 ins; 69671 del; 203 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2548.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2548/head:pull/2548 PR: https://git.openjdk.org/jdk11u-dev/pull/2548 From duke at openjdk.org Thu Mar 7 08:20:56 2024 From: duke at openjdk.org (Alexey Pavlyutkin) Date: Thu, 7 Mar 2024 08:20:56 GMT Subject: [jdk17u-dev] RFR: 8296343: CPVE thrown on missing content-length in OCSP response In-Reply-To: References: Message-ID: On Thu, 18 May 2023 15:59:18 GMT, Alexey Pavlyutkin wrote: > Hi! > > Here is backport of [JDK-8296343](https://bugs.openjdk.org/browse/JDK-8296343). The patch fixes CertPathValidatorException taking place if OCSP response does not contain `ContentLength` field. > > Original patch is applied cleanly. > > Verification/regression (amd64/20.04 LTS): `jdk_security` including newly added `test/jdk/sun/security/provider/certpath/OCSP/OCSPNoContentLength.java` Philip, sorry for long ping, I repent sincerely. I did not have a time for this because I have changed my employment and now JDK is only a side activity for me. IMHO it would be better if you raise a new ticket for this, but the most important here is to share how you reproduce the issue. If the issue is reproducible for the upstream? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1361#issuecomment-1982885548 From gcao at openjdk.org Thu Mar 7 08:49:01 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 7 Mar 2024 08:49:01 GMT Subject: [jdk22u] RFR: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations Message-ID: Hi, The same issue also exists in the JDK22U: I can reproduce it locally and use this clean patch can fix that issue, So I would like to backport this to JDK22U. This is a risc-v specific change. Backport is clean, risk is low. ### Tests - [x] Run tier1 tests on SiFive unmatched (release) ------------- Commit messages: - Backport a089ed2b9289eeda73bba47ac87e5bc81a4af9dc Changes: https://git.openjdk.org/jdk22u/pull/90/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=90&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326936 Stats: 49 lines in 1 file changed: 49 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/90.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/90/head:pull/90 PR: https://git.openjdk.org/jdk22u/pull/90 From rrich at openjdk.org Thu Mar 7 09:07:57 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 7 Mar 2024 09:07:57 GMT Subject: [jdk17u-dev] Integrated: 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel In-Reply-To: References: Message-ID: On Fri, 23 Feb 2024 13:36:01 GMT, Richard Reingruber wrote: > This backport is a dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031 > Applies cleanly. Only a trivial renaming is required. > Risk is medium. We've done the downstream backport already many weeks ago. > > I've tested on x86_64: > jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > > Local CI Testing: > The fix passed our CI testing (e.g. 2024-02-24): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. This pull request has now been integrated. Changeset: fa8a1599 Author: Richard Reingruber URL: https://git.openjdk.org/jdk17u-dev/commit/fa8a159933a1c5c4fb5f03b2b78eedc864881731 Stats: 277 lines in 2 files changed: 103 ins; 101 del; 73 mod 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel Reviewed-by: phh, zgu Backport-of: 22b93a31c99403996b6272b7c8eb0b9918988862 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2228 From rrich at openjdk.org Thu Mar 7 09:13:01 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 7 Mar 2024 09:13:01 GMT Subject: [jdk17u-dev] RFR: 8310031: Parallel: Implement better work distribution for large object arrays in old gen [v2] In-Reply-To: References: Message-ID: > I would like to backport this as a performance bug fix. > > We received bug reports from users which have some young pauses of 30s, and even up to 50s (normally <1s) running large Gerrit instances (200GB heap, 100 gc threads). > We have tried to tune ParallelGC. Reducing the number of gc threads helps to make the pause time spikes smaller but this makes average pause times longer. > > This pr depends on > https://github.com/openjdk/jdk17u-dev/pull/2226 > https://github.com/openjdk/jdk17u-dev/pull/2227 > https://github.com/openjdk/jdk17u-dev/pull/2228 > > All hunks except the following 2 applied after a trivial preparation change. > The 1st hunk of psCardTable.hpp did not apply because of different context. Resolved by inserting the new lines. > The 2nd hunk of psScavenge.cpp did not apply because of different context. Resolved by inserting the new lines. > Finally a few trivial changes are required (renaming and the like). > > Risk is medium. We've done the downstream backport already many weeks ago. > > I've tested on x86_64: > jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > > Local CI Testing: > The fix passed our CI testing (e.g. 2024-02-25): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2230/files - new: https://git.openjdk.org/jdk17u-dev/pull/2230/files/cf3280e7..cf3280e7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2230&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2230&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2230.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2230/head:pull/2230 PR: https://git.openjdk.org/jdk17u-dev/pull/2230 From rrich at openjdk.org Thu Mar 7 09:27:23 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 7 Mar 2024 09:27:23 GMT Subject: [jdk17u-dev] RFR: 8310031: Parallel: Implement better work distribution for large object arrays in old gen [v3] In-Reply-To: References: Message-ID: > I would like to backport this as a performance bug fix. > > We received bug reports from users which have some young pauses of 30s, and even up to 50s (normally <1s) running large Gerrit instances (200GB heap, 100 gc threads). > We have tried to tune ParallelGC. Reducing the number of gc threads helps to make the pause time spikes smaller but this makes average pause times longer. > > This pr depends on > https://github.com/openjdk/jdk17u-dev/pull/2226 > https://github.com/openjdk/jdk17u-dev/pull/2227 > https://github.com/openjdk/jdk17u-dev/pull/2228 > > All hunks except the following 2 applied after a trivial preparation change. > The 1st hunk of psCardTable.hpp did not apply because of different context. Resolved by inserting the new lines. > The 2nd hunk of psScavenge.cpp did not apply because of different context. Resolved by inserting the new lines. > Finally a few trivial changes are required (renaming and the like). > > Risk is medium. We've done the downstream backport already many weeks ago. > > I've tested on x86_64: > jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > > Local CI Testing: > The fix passed our CI testing (e.g. 2024-02-25): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits: - Merge branch 'master' into 8310031_17u_backport - Fix build - 8310031: Parallel: Implement better work distribution for large object arrays in old gen Co-authored-by: Albert Mingkun Yang Reviewed-by: tschatzl, ayang - Prepare - Fix build - 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel Reviewed-by: iwalulya, tschatzl - 8278893: Parallel: Remove GCWorkerDelayMillis Reviewed-by: ayang, mli - Fix build - 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range Reviewed-by: sjohanss, tschatzl ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/2230/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2230&range=02 Stats: 4341 lines in 168 files changed: 360 ins; 3317 del; 664 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2230.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2230/head:pull/2230 PR: https://git.openjdk.org/jdk17u-dev/pull/2230 From clanger at openjdk.org Thu Mar 7 09:28:54 2024 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 7 Mar 2024 09:28:54 GMT Subject: [jdk21u-dev] RFR: 8314828: Mark 3 jcmd command-line options test as vm.flagless In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 15:29:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. > > As 8312828 breaks the tests, I include follow-up 8316228. > Both are clean backports. Will mark as clean. You should add https://bugs.openjdk.org/browse/JDK-8316228 to this PR then, no? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/322#issuecomment-1983083919 From goetz at openjdk.org Thu Mar 7 09:28:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 09:28:56 GMT Subject: [jdk17u-dev] RFR: 8291753: Add JFR event for GC CPU Time In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 16:09:37 GMT, Goetz Lindenmaier wrote: > I backport this as proposed before in https://github.com/openjdk/jdk17u-dev/pull/1900. Prereq changes are already done. > > The backport has been tested by [releaseing it in SapMachine in 17.0.10](https://github.com/SAP/SapMachine/commit/[1d275fd954aaaa6b1f4623d547e3edff46b97e84](https://github.com/SAP/SapMachine/commit/1d275fd954aaaa6b1f4623d547e3edff46b97e84)). This patch here is identical to the one in SapMachine. It will go to 17.0.12 giving enough time to settle. > > The g1 files needed several trivial resolves due to context differences. Especially variable do_maximum_compaction was renamed to do_maximal_compaction. This appears several times in the context. > > Further trivial resolves in > src/hotspot/share/gc/serial/defNewGeneration.hpp > src/hotspot/share/gc/shared/gcTrace.hpp > src/hotspot/share/gc/shared/genCollectedHeap.cpp > > src/jdk.jfr/share/conf/jfr/profile.jfc > The whitespace fix is not needed in 17. Omitted. GHA failure: Risc-V build issue, unrelated. This change changes C++ code which would be good to be built in that test build. But the exact same code passed testing in #1900, so it should be fine. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2270#issuecomment-1983080682 From duke at openjdk.org Thu Mar 7 09:48:58 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Thu, 7 Mar 2024 09:48:58 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 12:52:28 GMT, Mar?a Arias de Reyna wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8280377 MethodHandleProxies does not correctly invoke default methods with varags > > I applied the same fix that was applied to version 19 in https://github.com/openjdk/jdk/commit/a183bfb436a7dd998e602c2d16486e88c390fca1 src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java line 206: > 204: if (isDefaultMethod(method)) { > 205: // no additional access check is performed > 206: return JLRA.invokeDefault(proxy, method, args, null); As defined at the end of the file, `JavaLangReflectAccess JLRA = SharedSecrets.getJavaLangReflectAccess();` which is an interface implemented by `ReflectAccess.java` (modified below) src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java line 323: > 321: } > 322: > 323: private static boolean hasDefaultMethods(Class intfc) { This piece of code is removed because it is no longer used. Now, instead of calling `callDefaultMethod(...)`, we are calling `Proxy.invokeDefault(...)` which is created on this same PR. src/java.base/share/classes/java/lang/reflect/InvocationHandler.java line 264: > 262: Objects.requireNonNull(proxy); > 263: Objects.requireNonNull(method); > 264: return Proxy.invokeDefault(proxy, method, args, Reflection.getCallerClass()); This is where we call the previously removed piece of code. src/java.base/share/classes/java/lang/reflect/InvocationHandler.java line 265: > 263: Objects.requireNonNull(proxy); > 264: Objects.requireNonNull(method); > 265: This removed piece of code is moved to `Proxy.invokeDefault` (which is now called at the end of this removed code). The code moved is mostly the same, except it checks if the caller object is null. If it is null, then it won't execute anything. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#discussion_r1515850117 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#discussion_r1515857242 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#discussion_r1515847162 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#discussion_r1515846116 From duke at openjdk.org Thu Mar 7 09:51:55 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Thu, 7 Mar 2024 09:51:55 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 12:52:28 GMT, Mar?a Arias de Reyna wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8280377 MethodHandleProxies does not correctly invoke default methods with varags > > I applied the same fix that was applied to version 19 in https://github.com/openjdk/jdk/commit/a183bfb436a7dd998e602c2d16486e88c390fca1 src/java.base/share/classes/java/lang/reflect/Proxy.java line 1323: > 1321: * if caller is non-null > 1322: */ > 1323: static Object invokeDefault(Object proxy, Method method, Object[] args, Class caller) This is the piece of code that will now unify calling methods both from `MethodHandleProxies` (where this code is copied from) and `ReflectAccess`, which was using a different way of calling methods. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#discussion_r1515862906 From goetz at openjdk.org Thu Mar 7 09:58:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 09:58:55 GMT Subject: [jdk21u-dev] RFR: 8314828: Mark 3 jcmd command-line options test as vm.flagless In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 15:29:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. > > As 8312828 breaks the tests, I include follow-up 8316228. > Both are clean backports. Will mark as clean. Yes, you are right, thanks for catching this! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/322#issuecomment-1983143616 From szaldana at openjdk.org Thu Mar 7 10:15:00 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Thu, 7 Mar 2024 10:15:00 GMT Subject: [jdk21u-dev] Integrated: 8315898: Open source swing JMenu tests In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 17:43:11 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [fecd2fd8](https://github.com/openjdk/jdk/commit/fecd2fd8f26d0e8905a519e30e9aa171683c9df1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Abhishek Kumar on 13 Sep 2023 and was reviewed by Sergey Bylokhov. > > Thanks! This pull request has now been integrated. Changeset: 555f824c Author: Sonia Zaldana Calles Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/555f824c763a6f5b72fc53edbc20bbdae3814d1b Stats: 357 lines in 6 files changed: 357 ins; 0 del; 0 mod 8315898: Open source swing JMenu tests Backport-of: fecd2fd8f26d0e8905a519e30e9aa171683c9df1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/314 From szaldana at openjdk.org Thu Mar 7 10:14:58 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Thu, 7 Mar 2024 10:14:58 GMT Subject: [jdk21u-dev] Integrated: 8315609: Open source few more swing text/html tests In-Reply-To: <2Ri7uMob-n0HrsvlthzX2UDp5nO_zk_gInJEkSgFqro=.04acb910-951c-4e90-9ef8-8db2bb950c4f@github.com> References: <2Ri7uMob-n0HrsvlthzX2UDp5nO_zk_gInJEkSgFqro=.04acb910-951c-4e90-9ef8-8db2bb950c4f@github.com> Message-ID: <6IP8KWuAj2RLk5Yhbq9BvwBrf9sTFxd5FdcHkBz6J7U=.e21b00b4-c443-4531-8ffa-de354b778ff2@github.com> On Fri, 1 Mar 2024 17:40:37 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [a04c6c1a](https://github.com/openjdk/jdk/commit/a04c6c1ac663a1eab7d45913940cb6ac0af2c11c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Prasanta Sadhukhan on 11 Sep 2023 and was reviewed by Jayathirth D V. > > Thanks! This pull request has now been integrated. Changeset: e8d25358 Author: Sonia Zaldana Calles Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/e8d2535856e47966b2db9c4f2ec5e31b552e14d5 Stats: 422 lines in 4 files changed: 422 ins; 0 del; 0 mod 8315609: Open source few more swing text/html tests Backport-of: a04c6c1ac663a1eab7d45913940cb6ac0af2c11c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/313 From shade at openjdk.org Thu Mar 7 10:15:33 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 7 Mar 2024 10:15:33 GMT Subject: [jdk21u-dev] RFR: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls Message-ID: This resolves a relatively rare, but potentially catastrophic bug in monitor deflation. It would be more prominent as we backport improvements in monitor deflation code like [JDK-8319048](https://bugs.openjdk.org/browse/JDK-8319048). The interaction between deflation thread that can be stopped at safepoint in the middle of deflation and the VM op that deflates monitors itself may corrupt the VM state. This series of backports moves all deflation to monitor deflation thread, avoiding the issue. There are 4 interconnected issues, which are backported here atomically: - **[JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757): VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls.** The core part, deferring deflation to monitor deflation thread. The new test needs `-XX:+UnlockExperimentalVMOptions` to gain access to `-XX:LockingMode`. Otherwise applies cleanly. It needs JDK-8320515 as the followup. - **[JDK-8319896](https://bugs.openjdk.org/browse/JDK-8319896): Remove monitor deflation from final audit.** Removes the remaining part that might call into deflation outside of monitor deflation thread. Applies cleanly. Makes JDK-8320515 backport clean. It needs JDK-8325437 as the followup. - **[JDK-8320515](https://bugs.openjdk.org/browse/JDK-8320515): assert(monitor->object_peek() != nullptr) failed**. Owned monitors should not have a dead object. Follow-up for JDK-8318757, fixes the JNI interaction problem. Does not apply cleanly due to minor conflict in `JtregNativeHotspot.gmk`. - **[JDK-8325437](https://bugs.openjdk.org/browse/JDK-8325437): Safepoint polling in monitor deflation can cause massive logs.** Followup for JDK-8319896, reducing the logs noise. @stefank -- it looks like you are tasked with backporting some of this to 21.0.4-oracle. Maybe you want to review this PR, which would also allow you to pick it up as commit later? :) Additional testing: - [x] Linux x86_64 server fastdebug, `all` tests pass ------------- Commit messages: - Clean JDK-8325437: Safepoint polling in monitor deflation can cause massive logs - Unclean JDK-8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object - Clean JDK-8319896: Remove monitor deflation from final audit - Unclean JDK-8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls Changes: https://git.openjdk.org/jdk21u-dev/pull/337/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=337&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318757 Stats: 819 lines in 17 files changed: 552 ins; 177 del; 90 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/337.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/337/head:pull/337 PR: https://git.openjdk.org/jdk21u-dev/pull/337 From shade at openjdk.org Thu Mar 7 10:15:33 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 7 Mar 2024 10:15:33 GMT Subject: [jdk21u-dev] RFR: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 19:12:00 GMT, Aleksey Shipilev wrote: > This resolves a relatively rare, but potentially catastrophic bug in monitor deflation. It would be more prominent as we backport improvements in monitor deflation code like [JDK-8319048](https://bugs.openjdk.org/browse/JDK-8319048). The interaction between deflation thread that can be stopped at safepoint in the middle of deflation and the VM op that deflates monitors itself may corrupt the VM state. > > This series of backports moves all deflation to monitor deflation thread, avoiding the issue. There are 4 interconnected issues, which are backported here atomically: > > - **[JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757): VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls.** The core part, deferring deflation to monitor deflation thread. The new test needs `-XX:+UnlockExperimentalVMOptions` to gain access to `-XX:LockingMode`. Otherwise applies cleanly. It needs JDK-8320515 as the followup. > - **[JDK-8319896](https://bugs.openjdk.org/browse/JDK-8319896): Remove monitor deflation from final audit.** Removes the remaining part that might call into deflation outside of monitor deflation thread. Applies cleanly. Makes JDK-8320515 backport clean. It needs JDK-8325437 as the followup. > - **[JDK-8320515](https://bugs.openjdk.org/browse/JDK-8320515): assert(monitor->object_peek() != nullptr) failed**. Owned monitors should not have a dead object. Follow-up for JDK-8318757, fixes the JNI interaction problem. Does not apply cleanly due to minor conflict in `JtregNativeHotspot.gmk`. > - **[JDK-8325437](https://bugs.openjdk.org/browse/JDK-8325437): Safepoint polling in monitor deflation can cause massive logs.** Followup for JDK-8319896, reducing the logs noise. > > @stefank -- it looks like you are tasked with backporting some of this to 21.0.4-oracle. Maybe you want to review this PR, which would also allow you to pick it up as commit later? :) > > Additional testing: > - [x] Linux x86_64 server fastdebug, `all` tests pass GHA RISC-V failure is known environmental issue. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/337#issuecomment-1983119827 From syan at openjdk.org Thu Mar 7 10:15:56 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 7 Mar 2024 10:15:56 GMT Subject: [jdk21u-dev] Integrated: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 In-Reply-To: References: Message-ID: On Mon, 22 Jan 2024 11:14:08 GMT, SendaoYan wrote: > 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 This pull request has now been integrated. Changeset: 5c3dfe46 Author: SendaoYan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/5c3dfe46a5832efb42ede781133addfe7f00a07e Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 Backport-of: 52814994efc4831fdbc1f796ed1db6ae88cb616c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/204 From syan at openjdk.org Thu Mar 7 10:17:57 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 7 Mar 2024 10:17:57 GMT Subject: [jdk21u-dev] Integrated: 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information In-Reply-To: References: Message-ID: On Sat, 24 Feb 2024 16:50:33 GMT, SendaoYan wrote: > The testcase implement and the commnet is unmatch. Just modify the comment. The risk is low. This pull request has now been integrated. Changeset: e328bf37 Author: SendaoYan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/e328bf37fc9c4b82ae92d307dcb04abe64645af9 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information Backport-of: 432756b6e51c903e2bff8b9c3028a4f2ea8973f4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/289 From shade at openjdk.org Thu Mar 7 10:19:18 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 7 Mar 2024 10:19:18 GMT Subject: [jdk21u-dev] RFR: 8327501: Common ForkJoinPool prevents class unloading in some cases Message-ID: The change is stabilizing in mainline, but it looks simple, so we start testing it for JDK 21 pickup here. Additional testing: - [ ] Linux x86_64 server fastdebug, `all` ------------- Commit messages: - Backport 53c4714aab2e072ba18631875dcaa3b2d5d22243 Changes: https://git.openjdk.org/jdk21u-dev/pull/338/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=338&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327501 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/338.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/338/head:pull/338 PR: https://git.openjdk.org/jdk21u-dev/pull/338 From goetz at openjdk.org Thu Mar 7 10:27:00 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 10:27:00 GMT Subject: [jdk21u-dev] Integrated: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 14:36:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 47c67bda Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/47c67bda68cfddad42eb5bdc3138f40d2d87a4db Stats: 0 lines in 5 files changed: 0 ins; 0 del; 0 mod 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader Backport-of: 57fc9a3e968cafe3b618a216630e703a39d5676e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/318 From goetz at openjdk.org Thu Mar 7 10:29:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 10:29:57 GMT Subject: [jdk21u-dev] Integrated: 8310070: Test: javax/net/ssl/DTLS/DTLSWontNegotiateV10.java timed out In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 14:50:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 22672926 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/22672926eabb6fcd8f7d08b7803c7eb87125a55a Stats: 44 lines in 1 file changed: 30 ins; 0 del; 14 mod 8310070: Test: javax/net/ssl/DTLS/DTLSWontNegotiateV10.java timed out Backport-of: af7f95e24ad5981c5de4b5dbf37da6f4f5e42129 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/319 From goetz at openjdk.org Thu Mar 7 10:30:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 10:30:56 GMT Subject: [jdk21u-dev] Integrated: 8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations In-Reply-To: References: Message-ID: <75E-YCR1VkhQw78CjarNXyAxE24xAo8sZkI5Hc7WGGU=.e650b03e-3c1d-4e86-aa83-0fd3c399660a@github.com> On Mon, 4 Mar 2024 15:16:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 45e20c5a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/45e20c5a5ca65bae64bbd33309a047fef5735f8f Stats: 58 lines in 1 file changed: 58 ins; 0 del; 0 mod 8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations Backport-of: 1664e793eb725d6328751657d5718df96175da29 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/320 From goetz at openjdk.org Thu Mar 7 10:32:00 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 10:32:00 GMT Subject: [jdk21u-dev] Integrated: 8314824: Fix serviceability/jvmti/8036666/GetObjectLockCount.java to use vm flags In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 15:21:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 5838aed2 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/5838aed21e1715be0e5eed00a0efed4d0332f44c Stats: 6 lines in 1 file changed: 3 ins; 2 del; 1 mod 8314824: Fix serviceability/jvmti/8036666/GetObjectLockCount.java to use vm flags Backport-of: 93e82c01460a70f214653a558d53c1c6180ae0d3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/321 From goetz at openjdk.org Thu Mar 7 10:32:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 10:32:58 GMT Subject: [jdk21u-dev] Integrated: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 15:33:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: e7994c1d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/e7994c1d6a74c8d9e1a7d0002a8a028e102bda54 Stats: 174 lines in 2 files changed: 59 ins; 93 del; 22 mod 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java Backport-of: 704c6ea16cabc217588f430fd3c302d6df5e9c19 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/323 From goetz at openjdk.org Thu Mar 7 10:36:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 10:36:55 GMT Subject: [jdk21u-dev] Integrated: 8319757: java/nio/channels/DatagramChannel/InterruptibleOrNot.java failed: wrong exception thrown In-Reply-To: <6C-xJSOIpRePAf2_agZaHShC1ZyHS4yluGlo_tIbiWI=.0009d0b1-101b-4764-a9c3-9fdf112ca2df@github.com> References: <6C-xJSOIpRePAf2_agZaHShC1ZyHS4yluGlo_tIbiWI=.0009d0b1-101b-4764-a9c3-9fdf112ca2df@github.com> Message-ID: On Mon, 4 Mar 2024 16:03:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 0b01febb Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/0b01febb9e8e1682b993e32e36a2e762d7e47301 Stats: 161 lines in 1 file changed: 55 ins; 29 del; 77 mod 8319757: java/nio/channels/DatagramChannel/InterruptibleOrNot.java failed: wrong exception thrown Backport-of: ace010b38a83e0c9b43aeeb6bc5c92d0886dc53f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/324 From goetz at openjdk.org Thu Mar 7 10:37:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 10:37:57 GMT Subject: [jdk21u-dev] Integrated: 8322477: order of subclasses in the permits clause can differ between compilations In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 15:36:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. > > src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java > I had to resolve because indentation is different. Changed coding is the same. This pull request has now been integrated. Changeset: d4823c21 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/d4823c21e106f22d00d9d86d49c38fc01f061e5c Stats: 107 lines in 9 files changed: 68 ins; 1 del; 38 mod 8322477: order of subclasses in the permits clause can differ between compilations Reviewed-by: mdoerr Backport-of: 5ba69e17340cf44194c080a38219c6e150418fcf ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/310 From rrich at openjdk.org Thu Mar 7 10:42:59 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 7 Mar 2024 10:42:59 GMT Subject: [jdk17u-dev] RFR: 8310031: Parallel: Implement better work distribution for large object arrays in old gen [v3] In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 09:27:23 GMT, Richard Reingruber wrote: >> I would like to backport this as a performance bug fix. >> >> We received bug reports from users which have some young pauses of 30s, and even up to 50s (normally <1s) running large Gerrit instances (200GB heap, 100 gc threads). >> We have tried to tune ParallelGC. Reducing the number of gc threads helps to make the pause time spikes smaller but this makes average pause times longer. >> >> This pr depends on >> https://github.com/openjdk/jdk17u-dev/pull/2226 >> https://github.com/openjdk/jdk17u-dev/pull/2227 >> https://github.com/openjdk/jdk17u-dev/pull/2228 >> >> All hunks except the following 2 applied after a trivial preparation change. >> The 1st hunk of psCardTable.hpp did not apply because of different context. Resolved by inserting the new lines. >> The 2nd hunk of psScavenge.cpp did not apply because of different context. Resolved by inserting the new lines. >> Finally a few trivial changes are required (renaming and the like). >> >> Risk is medium. We've done the downstream backport already many weeks ago. >> >> I've tested on x86_64: >> jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" >> langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" >> >> Local CI Testing: >> The fix passed our CI testing (e.g. 2024-02-25): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). >> Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. > > Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits: > > - Merge branch 'master' into 8310031_17u_backport > - Fix build > - 8310031: Parallel: Implement better work distribution for large object arrays in old gen > > Co-authored-by: Albert Mingkun Yang > Reviewed-by: tschatzl, ayang > - Prepare > - Fix build > - 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel > > Reviewed-by: iwalulya, tschatzl > - 8278893: Parallel: Remove GCWorkerDelayMillis > > Reviewed-by: ayang, mli > - Fix build > - 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range > > Reviewed-by: sjohanss, tschatzl That last merge commit [bb046068e082e93e93c7e16c954d5dd54d0feb3c](https://github.com/openjdk/jdk17u-dev/pull/2230/commits/bb046068e082e93e93c7e16c954d5dd54d0feb3c) was unfortunately incorrect. I've merge like this: `git merge -s ours master` but the `ours` strategy effectively discards the changes from master. Correct would be `git merge -X ours master`. This uses the default strategy `ort` with the option `ours`. This discards the version from master only in conflicting hunks. See https://git-scm.com/docs/merge-strategies I will replace the merge with a correct one (by a force pushing). Hope you are ok with that. My apologies. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2230#issuecomment-1983229567 From goetz at openjdk.org Thu Mar 7 10:44:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 10:44:56 GMT Subject: [jdk21u-dev] Integrated: 8323276: StressDirListings.java fails on AIX In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 16:10:41 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 40f0254b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/40f0254b435080cda6b3db02f979155f34b7cc1b Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8323276: StressDirListings.java fails on AIX Backport-of: e5aed6be7a184a86a32fa671d48e0781fab54183 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/325 From goetz at openjdk.org Thu Mar 7 10:46:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 10:46:55 GMT Subject: [jdk21u-dev] Integrated: 8320712: Rewrite BadFactoryTest in pure Java In-Reply-To: <7ejFjB-jV5MQ7F59Pd5wmuPqVV36cvH0keQdbTlj36M=.42a6a882-d0b8-4912-94e6-086d5d635207@github.com> References: <7ejFjB-jV5MQ7F59Pd5wmuPqVV36cvH0keQdbTlj36M=.42a6a882-d0b8-4912-94e6-086d5d635207@github.com> Message-ID: On Mon, 4 Mar 2024 16:14:46 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: ab6e0274 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/ab6e02744fed7d26b4b45ac3f10ebcdd5bb55a06 Stats: 86 lines in 2 files changed: 24 ins; 60 del; 2 mod 8320712: Rewrite BadFactoryTest in pure Java Backport-of: 66971600f7ba796ff5bb9714591c3faa0bb2249d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/326 From goetz at openjdk.org Thu Mar 7 10:47:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 10:47:56 GMT Subject: [jdk17u-dev] Integrated: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 14:38:27 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > Omitted one file not in 17. Others clean. Will mark clean. This pull request has now been integrated. Changeset: 48327c37 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/48327c37aa8db2edc07a37bbb2e05e4006f43b9f Stats: 0 lines in 4 files changed: 0 ins; 0 del; 0 mod 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader Backport-of: 57fc9a3e968cafe3b618a216630e703a39d5676e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2266 From syan at openjdk.org Thu Mar 7 10:48:58 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 7 Mar 2024 10:48:58 GMT Subject: [jdk17u-dev] Integrated: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 In-Reply-To: References: Message-ID: On Mon, 22 Jan 2024 11:08:59 GMT, SendaoYan wrote: > 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 This pull request has now been integrated. Changeset: 6e73b11a Author: SendaoYan Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/6e73b11a88599ac4851b6856591db6bb2712e5eb Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 Backport-of: 52814994efc4831fdbc1f796ed1db6ae88cb616c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2151 From goetz at openjdk.org Thu Mar 7 10:50:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 10:50:56 GMT Subject: [jdk17u-dev] Integrated: 8320712: Rewrite BadFactoryTest in pure Java In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 16:18:34 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. This pull request has now been integrated. Changeset: 08f1b350 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/08f1b35024044af3653dd0e2d8f137a97d9bcb4c Stats: 86 lines in 2 files changed: 24 ins; 60 del; 2 mod 8320712: Rewrite BadFactoryTest in pure Java Backport-of: 66971600f7ba796ff5bb9714591c3faa0bb2249d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2267 From luhenry at openjdk.org Thu Mar 7 10:51:57 2024 From: luhenry at openjdk.org (Ludovic Henry) Date: Thu, 7 Mar 2024 10:51:57 GMT Subject: [jdk21u-dev] RFR: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support [v2] In-Reply-To: References: <9QpsRx46Z81i8gfhceeZdBfhR7MZNutmsihst1_oBQ8=.d26e1de0-a67d-498e-9345-b5ee85113f24@github.com> <2u93YTZVH56weBZmTChM2qxlMDvyiWfS04RYr_gD4zQ=.2b9e11d0-78e1-4a06-aae6-5a86229ea8d0@github.com> Message-ID: On Thu, 29 Feb 2024 13:50:51 GMT, Fei Yang wrote: >> The linux-riscv64 fails on creating the sysroot which is completely unrelated to this change. I've merged `openjdk:master` again to trigger a new CI run and hoping it'll pass this time. > >> The linux-riscv64 fails on creating the sysroot which is completely unrelated to this change. I've merged `openjdk:master` again to trigger a new CI run and hoping it'll pass this time. > > Yeah, it's a GHA infrastructural issue. The Debian SID is broken for now: https://bugs.openjdk.org/browse/JDK-8326960 @RealFYang as the CI is still busted until Debian fixes it, we won't be able to get a green checks. Are you good to approve/merge this change? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/294#issuecomment-1983248259 From richard.reingruber at sap.com Thu Mar 7 10:53:31 2024 From: richard.reingruber at sap.com (Reingruber, Richard) Date: Thu, 7 Mar 2024 10:53:31 +0000 Subject: CFV: New JDK Updates Committer: Amos Shi In-Reply-To: References: Message-ID: Vote: yes Richard. From: jdk-updates-dev on behalf of Lindenmaier, Goetz Date: Friday, 23. February 2024 at 12:04 To: jdk-updates-dev at openjdk.org Subject: CFV: New JDK Updates Committer: Amos Shi I hereby nominate Amos Shi (ashi)[1] to JDK Updates Committer. Amos is an experienced Java developer and member of the SAP OpenJDK team. He is Author in the JDK Updates project. He is helping with SAPs effort to support 11u, 17u and 21u updates and has already contributed 50+ changes[2]. He has well deserved the Committer status which will also improve his productivity. Votes are due by 23:59 UTC on Friday, March 8th, 2024. Only current JDK Updates Committers (and above) [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Best regards, Goetz. [1] https://openjdk.org/census#ashi [2] https://github.com/openjdk/jdk11u-dev/commits?author=ashi at openjdk.org https://github.com/openjdk/jdk11u-dev/commits?author=amosshi https://github.com/openjdk/jdk17u-dev/commits?author=ashi at openjdk.org https://github.com/openjdk/jdk21u-dev/commits?author=ashi at openjdk.org [3] https://openjdk.java.net/census#jdk-updates [4] http://openjdk.java.net/projects/#committer-vote -------------- next part -------------- An HTML attachment was scrubbed... URL: From lutz.schmidt at sap.com Thu Mar 7 11:05:40 2024 From: lutz.schmidt at sap.com (Schmidt, Lutz) Date: Thu, 7 Mar 2024 11:05:40 +0000 Subject: CFV: New JDK Updates Committer: Amos Shi In-Reply-To: References: Message-ID: Vote: yes /Lutz From: jdk-updates-dev on behalf of Lindenmaier, Goetz Date: Friday, 23. February 2024 at 12:04 To: jdk-updates-dev at openjdk.org Subject: CFV: New JDK Updates Committer: Amos Shi I hereby nominate Amos Shi (ashi)[1] to JDK Updates Committer. Amos is an experienced Java developer and member of the SAP OpenJDK team. He is Author in the JDK Updates project. He is helping with SAPs effort to support 11u, 17u and 21u updates and has already contributed 50+ changes[2]. He has well deserved the Committer status which will also improve his productivity. Votes are due by 23:59 UTC on Friday, March 8th, 2024. Only current JDK Updates Committers (and above) [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Best regards, Goetz. [1] https://openjdk.org/census#ashi [2] https://github.com/openjdk/jdk11u-dev/commits?author=ashi at openjdk.org https://github.com/openjdk/jdk11u-dev/commits?author=amosshi https://github.com/openjdk/jdk17u-dev/commits?author=ashi at openjdk.org https://github.com/openjdk/jdk21u-dev/commits?author=ashi at openjdk.org [3] https://openjdk.java.net/census#jdk-updates [4] http://openjdk.java.net/projects/#committer-vote -------------- next part -------------- An HTML attachment was scrubbed... URL: From fyang at openjdk.org Thu Mar 7 11:21:56 2024 From: fyang at openjdk.org (Fei Yang) Date: Thu, 7 Mar 2024 11:21:56 GMT Subject: [jdk21u-dev] RFR: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support [v2] In-Reply-To: References: <9QpsRx46Z81i8gfhceeZdBfhR7MZNutmsihst1_oBQ8=.d26e1de0-a67d-498e-9345-b5ee85113f24@github.com> <2u93YTZVH56weBZmTChM2qxlMDvyiWfS04RYr_gD4zQ=.2b9e11d0-78e1-4a06-aae6-5a86229ea8d0@github.com> Message-ID: On Thu, 29 Feb 2024 13:50:51 GMT, Fei Yang wrote: >> The linux-riscv64 fails on creating the sysroot which is completely unrelated to this change. I've merged `openjdk:master` again to trigger a new CI run and hoping it'll pass this time. > >> The linux-riscv64 fails on creating the sysroot which is completely unrelated to this change. I've merged `openjdk:master` again to trigger a new CI run and hoping it'll pass this time. > > Yeah, it's a GHA infrastructural issue. The Debian SID is broken for now: https://bugs.openjdk.org/browse/JDK-8326960 > @RealFYang as the CI is still busted until Debian fixes it, we won't be able to get a green checks. Are you good to approve/merge this change? Yeah. I am OK assuming linux-riscv64 builds fine on your side. Debian SID is still not debootstrappable across all CPU platforms for now. The Debian people are busy sorting things out. I guess it might take weeks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/294#issuecomment-1983294762 From duke at openjdk.org Thu Mar 7 11:27:15 2024 From: duke at openjdk.org (Jiawei Tang) Date: Thu, 7 Mar 2024 11:27:15 GMT Subject: [jdk11u-dev] RFR: 8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id [v5] In-Reply-To: References: Message-ID: > Threads which are in the state of `is_attaching_via_jni` may have the NULL object as their `_threadObj` . > So the JVM will crash when calling `JfrCheckpointThreadClosure::do_thread()`. Jiawei Tang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into master - Update full name - 8322511: JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2413/files - new: https://git.openjdk.org/jdk11u-dev/pull/2413/files/0c58a66f..d9a69c9a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2413&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2413&range=03-04 Stats: 117697 lines in 923 files changed: 32483 ins; 76040 del; 9174 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2413.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2413/head:pull/2413 PR: https://git.openjdk.org/jdk11u-dev/pull/2413 From goetz at openjdk.org Thu Mar 7 11:44:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 11:44:56 GMT Subject: [jdk21u-dev] Integrated: 8314828: Mark 3 jcmd command-line options test as vm.flagless In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 15:29:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. > > As 8312828 breaks the tests, I include follow-up 8316228. > Both are clean backports. Will mark as clean. This pull request has now been integrated. Changeset: 315d051f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/315d051f6842120f233bb5b7dd488cabcd2e968d Stats: 6 lines in 3 files changed: 3 ins; 1 del; 2 mod 8314828: Mark 3 jcmd command-line options test as vm.flagless 8316228: jcmd tests are broken by 8314828 Backport-of: 23fab1181b6a053efc4661d5a10caa90b109aa06 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/322 From shade at openjdk.org Thu Mar 7 12:10:03 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 7 Mar 2024 12:10:03 GMT Subject: [jdk21u-dev] RFR: 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java Message-ID: Fixes the test when running with C1. Does not apply cleanly, because the relevant problemlist change is not applicable to jdk21u. We backported [JDK-8314838](https://bugs.openjdk.org/browse/JDK-8314838) to 21.0.3, which exposes us to this bug. Additional testing: - [x] MacOS AArch64 server fastdebug, C1, affected test fails without the patch, skipped with it - [x] MacOS AArch64 server fastdebug, C2, affected test passes with the patch ------------- Commit messages: - Backport 4a16d111b16e556f904fb80075631b8439a9482e Changes: https://git.openjdk.org/jdk21u-dev/pull/339/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=339&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318455 Stats: 7 lines in 2 files changed: 3 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/339.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/339/head:pull/339 PR: https://git.openjdk.org/jdk21u-dev/pull/339 From rrich at openjdk.org Thu Mar 7 12:28:26 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 7 Mar 2024 12:28:26 GMT Subject: [jdk17u-dev] RFR: 8310031: Parallel: Implement better work distribution for large object arrays in old gen [v4] In-Reply-To: References: Message-ID: > I would like to backport this as a performance bug fix. > > We received bug reports from users which have some young pauses of 30s, and even up to 50s (normally <1s) running large Gerrit instances (200GB heap, 100 gc threads). > We have tried to tune ParallelGC. Reducing the number of gc threads helps to make the pause time spikes smaller but this makes average pause times longer. > > This pr depends on > https://github.com/openjdk/jdk17u-dev/pull/2226 > https://github.com/openjdk/jdk17u-dev/pull/2227 > https://github.com/openjdk/jdk17u-dev/pull/2228 > > All hunks except the following 2 applied after a trivial preparation change. > The 1st hunk of psCardTable.hpp did not apply because of different context. Resolved by inserting the new lines. > The 2nd hunk of psScavenge.cpp did not apply because of different context. Resolved by inserting the new lines. > Finally a few trivial changes are required (renaming and the like). > > Risk is medium. We've done the downstream backport already many weeks ago. > > I've tested on x86_64: > jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > > Local CI Testing: > The fix passed our CI testing (e.g. 2024-02-25): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. Richard Reingruber has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Merge branch 'master' into 8310031_17u_backport ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2230/files - new: https://git.openjdk.org/jdk17u-dev/pull/2230/files/bb046068..c9211fb8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2230&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2230&range=02-03 Stats: 4006 lines in 163 files changed: 3246 ins; 182 del; 578 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2230.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2230/head:pull/2230 PR: https://git.openjdk.org/jdk17u-dev/pull/2230 From matthias.baesken at sap.com Thu Mar 7 12:33:51 2024 From: matthias.baesken at sap.com (Baesken, Matthias) Date: Thu, 7 Mar 2024 12:33:51 +0000 Subject: CFV: New JDK Updates Committer: Amos Shi In-Reply-To: References: Message-ID: Vote: yes Best regards, Matthias ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ From: jdk-updates-dev on behalf of Lindenmaier, Goetz Date: Friday, 23. February 2024 at 12:04 To: jdk-updates-dev at openjdk.org Subject: CFV: New JDK Updates Committer: Amos Shi I hereby nominate Amos Shi (ashi)[1] to JDK Updates Committer. Amos is an experienced Java developer and member of the SAP OpenJDK team. He is Author in the JDK Updates project. He is helping with SAPs effort to support 11u, 17u and 21u updates and has already contributed 50+ changes[2]. He has well deserved the Committer status which will also improve his productivity. Votes are due by 23:59 UTC on Friday, March 8th, 2024. Only current JDK Updates Committers (and above) [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Best regards, Goetz. From sroy at openjdk.org Thu Mar 7 12:44:10 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Thu, 7 Mar 2024 12:44:10 GMT Subject: [jdk17u-dev] RFR: 8320005: Allow loading of shared objects with .a extension on AIX Message-ID: Hi all, This pull request contains a backport of commit [b8ae4a8c](https://github.com/openjdk/jdk/commit/b8ae4a8c0985d1763ac48ba78943d8b992d7be77) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Joachim Kern on 11 Jan 2024 and was reviewed by Thomas Stuefe and Martin Doerr. Thanks! ------------- Commit messages: - Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab Changes: https://git.openjdk.org/jdk17u-dev/pull/2271/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2271&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320005 Stats: 1532 lines in 12 files changed: 1510 ins; 6 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2271.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2271/head:pull/2271 PR: https://git.openjdk.org/jdk17u-dev/pull/2271 From luhenry at openjdk.org Thu Mar 7 12:59:54 2024 From: luhenry at openjdk.org (Ludovic Henry) Date: Thu, 7 Mar 2024 12:59:54 GMT Subject: [jdk21u-dev] RFR: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support [v2] In-Reply-To: <9QpsRx46Z81i8gfhceeZdBfhR7MZNutmsihst1_oBQ8=.d26e1de0-a67d-498e-9345-b5ee85113f24@github.com> References: <9QpsRx46Z81i8gfhceeZdBfhR7MZNutmsihst1_oBQ8=.d26e1de0-a67d-498e-9345-b5ee85113f24@github.com> Message-ID: On Thu, 29 Feb 2024 12:39:20 GMT, Ludovic Henry wrote: >> 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support > > Ludovic Henry has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' of github.com:openjdk/jdk21u into backport-luhenry-68eb5a1d > - Backport 68eb5a1df5afdc011aa467f1c723a8792532dd3f I can confirm that it builds fine locally. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/294#issuecomment-1983453594 From goetz at openjdk.org Thu Mar 7 13:28:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 13:28:06 GMT Subject: [jdk17u-dev] RFR: 8256660: Disable DTLS 1.0 Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport 16744b34498e7aac59caef8c9b1a3d4d15f8c22e Changes: https://git.openjdk.org/jdk17u-dev/pull/2272/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2272&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256660 Stats: 56 lines in 3 files changed: 27 ins; 5 del; 24 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2272.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2272/head:pull/2272 PR: https://git.openjdk.org/jdk17u-dev/pull/2272 From goetz at openjdk.org Thu Mar 7 13:29:10 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 13:29:10 GMT Subject: [jdk17u-dev] RFR: 8301381: Verify DTLS 1.0 cannot be negotiated Message-ID: I backport this as follow-up of [JDK-8256660](https://bugs.openjdk.org/browse/JDK-8256660). ------------- Commit messages: - Backport 18e2446420d3376acaa2652d70474c2d3a85e2ac Changes: https://git.openjdk.org/jdk17u-dev/pull/2273/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2273&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301381 Stats: 320 lines in 1 file changed: 320 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2273.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2273/head:pull/2273 PR: https://git.openjdk.org/jdk17u-dev/pull/2273 From rrich at openjdk.org Thu Mar 7 13:42:57 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 7 Mar 2024 13:42:57 GMT Subject: [jdk17u-dev] RFR: 8310031: Parallel: Implement better work distribution for large object arrays in old gen [v4] In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 12:28:26 GMT, Richard Reingruber wrote: >> I would like to backport this as a performance bug fix. >> >> We received bug reports from users which have some young pauses of 30s, and even up to 50s (normally <1s) running large Gerrit instances (200GB heap, 100 gc threads). >> We have tried to tune ParallelGC. Reducing the number of gc threads helps to make the pause time spikes smaller but this makes average pause times longer. >> >> This pr depends on >> https://github.com/openjdk/jdk17u-dev/pull/2226 >> https://github.com/openjdk/jdk17u-dev/pull/2227 >> https://github.com/openjdk/jdk17u-dev/pull/2228 >> >> All hunks except the following 2 applied after a trivial preparation change. >> The 1st hunk of psCardTable.hpp did not apply because of different context. Resolved by inserting the new lines. >> The 2nd hunk of psScavenge.cpp did not apply because of different context. Resolved by inserting the new lines. >> Finally a few trivial changes are required (renaming and the like). >> >> Risk is medium. We've done the downstream backport already many weeks ago. >> >> I've tested on x86_64: >> jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" >> langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" >> >> Local CI Testing: >> The fix passed our CI testing (e.g. 2024-02-25): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). >> Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. > > Richard Reingruber has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Merge branch 'master' into 8310031_17u_backport Riscv64 build failure is unrelated (https://bugs.openjdk.org/browse/JDK-8326960) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2230#issuecomment-1983529871 From goetz at openjdk.org Thu Mar 7 13:59:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 13:59:11 GMT Subject: [jdk11u-dev] RFR: 8256660: Disable DTLS 1.0 Message-ID: <41yjdMURxPew-w2Mn4Q8dJHb3XxlYJ3ll8-12mJI_uI=.1ac37c01-240d-4189-913b-e76fc09e9888@github.com> I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 16744b34498e7aac59caef8c9b1a3d4d15f8c22e Changes: https://git.openjdk.org/jdk11u-dev/pull/2584/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2584&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256660 Stats: 56 lines in 3 files changed: 27 ins; 5 del; 24 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2584.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2584/head:pull/2584 PR: https://git.openjdk.org/jdk11u-dev/pull/2584 From mbaesken at openjdk.org Thu Mar 7 14:03:23 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 7 Mar 2024 14:03:23 GMT Subject: [jdk22u] RFR: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns Message-ID: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns ------------- Commit messages: - Backport d9ef16dbb6917a4fff7711b32f3dd87611560dd1 Changes: https://git.openjdk.org/jdk22u/pull/91/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=91&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326140 Stats: 99 lines in 1 file changed: 23 ins; 57 del; 19 mod Patch: https://git.openjdk.org/jdk22u/pull/91.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/91/head:pull/91 PR: https://git.openjdk.org/jdk22u/pull/91 From mbaesken at openjdk.org Thu Mar 7 14:05:03 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 7 Mar 2024 14:05:03 GMT Subject: [jdk21u-dev] RFR: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns Message-ID: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns ------------- Commit messages: - Backport d9ef16dbb6917a4fff7711b32f3dd87611560dd1 Changes: https://git.openjdk.org/jdk21u-dev/pull/340/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=340&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326140 Stats: 99 lines in 1 file changed: 23 ins; 57 del; 19 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/340.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/340/head:pull/340 PR: https://git.openjdk.org/jdk21u-dev/pull/340 From jwilhelm at openjdk.org Thu Mar 7 14:35:08 2024 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Thu, 7 Mar 2024 14:35:08 GMT Subject: [jdk22u] Integrated: 8327391: Add SipHash attribution file In-Reply-To: References: Message-ID: <6TlyCMwob16-50mDDVMQtjKbiXA0BT2vuZaZECT3Zyg=.6d5421df-f4f1-4bb0-b9ef-11956d3423b9@github.com> On Tue, 5 Mar 2024 23:14:59 GMT, Jesper Wilhelmsson wrote: > Clean backport This pull request has now been integrated. Changeset: 6ac93265 Author: Jesper Wilhelmsson URL: https://git.openjdk.org/jdk22u/commit/6ac9326537db8a067dfaa21d9cef104a43ed693e Stats: 150 lines in 1 file changed: 150 ins; 0 del; 0 mod 8327391: Add SipHash attribution file Backport-of: fcf48ab3d36a7f8eed84e81c3e2445adcbc95374 ------------- PR: https://git.openjdk.org/jdk22u/pull/85 From rrich at openjdk.org Thu Mar 7 15:03:57 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 7 Mar 2024 15:03:57 GMT Subject: [jdk17u-dev] RFR: 8310031: Parallel: Implement better work distribution for large object arrays in old gen [v4] In-Reply-To: References: Message-ID: <9drBTv7x4YNynK0YhqvFrt9kygNGPOJh6O5-0fGAR38=.b959002e-72e6-43af-89ae-c451ef8f10f3@github.com> On Thu, 7 Mar 2024 12:28:26 GMT, Richard Reingruber wrote: >> I would like to backport this as a performance bug fix. >> >> We received bug reports from users which have some young pauses of 30s, and even up to 50s (normally <1s) running large Gerrit instances (200GB heap, 100 gc threads). >> We have tried to tune ParallelGC. Reducing the number of gc threads helps to make the pause time spikes smaller but this makes average pause times longer. >> >> This pr depends on >> https://github.com/openjdk/jdk17u-dev/pull/2226 >> https://github.com/openjdk/jdk17u-dev/pull/2227 >> https://github.com/openjdk/jdk17u-dev/pull/2228 >> >> All hunks except the following 2 applied after a trivial preparation change. >> The 1st hunk of psCardTable.hpp did not apply because of different context. Resolved by inserting the new lines. >> The 2nd hunk of psScavenge.cpp did not apply because of different context. Resolved by inserting the new lines. >> Finally a few trivial changes are required (renaming and the like). >> >> Risk is medium. We've done the downstream backport already many weeks ago. >> >> I've tested on x86_64: >> jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" >> langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" >> >> Local CI Testing: >> The fix passed our CI testing (e.g. 2024-02-25): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). >> Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. > > Richard Reingruber has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Merge branch 'master' into 8310031_17u_backport Thanks, Richard. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2230#issuecomment-1983691062 From phh at openjdk.org Thu Mar 7 15:19:00 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 7 Mar 2024 15:19:00 GMT Subject: [jdk21u-dev] RFR: 8319876: Reduce memory consumption of VM_ThreadDump::doit In-Reply-To: <24gHo7dmt8Yjtp-6kIIYVZMlUPCNfXoDEDo3P0Q1yoM=.fd04c34b-3814-4703-8ad2-7c3f71f96f3b@github.com> References: <24gHo7dmt8Yjtp-6kIIYVZMlUPCNfXoDEDo3P0Q1yoM=.fd04c34b-3814-4703-8ad2-7c3f71f96f3b@github.com> Message-ID: On Fri, 1 Mar 2024 08:16:11 GMT, Long Yang wrote: > Hi, all > > Could I have a review of this backport. > > This pull request contains a backport of commit [8ec6b8de3bb3d7aeebdcb45d761b18cce3bab75e](https://github.com/openjdk/jdk/commit/8ec6b8de3bb3d7aeebdcb45d761b18cce3bab75e) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > This backport can significantly reduce the `RSS` during the execution of `ThreadMXBean.dumpAllThreads(boolean, boolean)`. > > On `jdk21u-dev`, if creates 4096 threads, and the stack depth of each thread is 256. > On the version that does not contain this backport, during the execution of `ThreadMXBean.dumpAllThreads(true, true)`, the `RSS` reaches about 5GiB. > On the version that contains this backport, the max `RSS` is about 300MiB. > > There is a difference between `jdk21u-dev` and `openjdk/jdk`. > On `openjdk/jdk`, `ThreadStackTrace::dump_stack_at_safepoint` will only be executed in `VMThread`. > But on `jdk21u-dev`, `ThreadStackTrace::dump_stack_at_safepoint` will be executed in `VMThread` or `RuntimeWorker`, so when creating `ResourceMark`, can not directedly specify `VMThread` like what `openjdk/jdk` does, but needs to read current thread. > > Testing: > I ran `tier1`, `tier2`, `tier3`, `tier4` on my host machine with the `jdk21u-dev` including this backport. > `tier1`, `tier2`, and `tier3` all passed. > Because my host does not have a `display device`, I added `export JTREG_KEYWORDS="!headful"` before running `tier4`. > Finally, some tests in `tier4` that depend on the printing device failed, and the rest were successful. > > The [GHA](https://github.com/yanglong1010/jdk21u-dev/actions/runs/8093195914/job/22116320956) failed in [linux-cross-compile, build(riscv64), Create sysroot]. > I've also seen others fail at this step as well (e.g. [link](https://github.com/openjdk-bots/jdk21u-dev/actions/runs/8077954001/job/22081472372)), it looks like there's an issue with the GHA's process. > > I would appreciate it if anyone could review this. > > Thanks! Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/307#pullrequestreview-1922736584 From shade at openjdk.org Thu Mar 7 15:47:12 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 7 Mar 2024 15:47:12 GMT Subject: [jdk21u-dev] RFR: 8319650: Improve heap dump performance with class metadata caching [v3] In-Reply-To: <_Ib2XP8lK31x6lHk8Dk-F5w6ZD_C-yX9cTlbnBaqfTk=.60c3387a-dd78-4f70-9622-ca79e6321848@github.com> References: <_Ib2XP8lK31x6lHk8Dk-F5w6ZD_C-yX9cTlbnBaqfTk=.60c3387a-dd78-4f70-9622-ca79e6321848@github.com> Message-ID: > Transplanted from https://github.com/openjdk/jdk21u/pull/388 > > Unclean backport to improve heap dump performance. The uncleanliness comes from [JDK-8306441](https://bugs.openjdk.org/browse/JDK-8306441) that does not exist in JDK 21, and which I don't think we want to backport at the moment. I had to add a few more `ResourceMark`-s near `HeapDumpWriter` to manage the cache allocations. > > Additional testing: > - [x] MacOS AArch64 server release, heap dump performance improved > - [x] Linux x86_64 server fastdebug, serviceability/ (contains heap dump tests) > - [x] Linux x86_64 server fastdebug, runtime/ErrorHandling (contains heap dump on failure tests) > - [x] Linux x86_64 server fastdebug, gc/epsilon (contains heap dump on failure tests) > - [x] Linux x86_64 server fastdebug, sun/tools/jhsdb (contains heap dump tests) Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into JDK-8319650-heapdump-cache-class - Merge branch 'master' into JDK-8319650-heapdump-cache-class - Backport 03db82818b905f21cb5ad1d56a687e238b4a6e33 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/8/files - new: https://git.openjdk.org/jdk21u-dev/pull/8/files/da6d93ed..4e13f967 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=8&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=8&range=01-02 Stats: 21239 lines in 764 files changed: 14109 ins; 4618 del; 2512 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/8.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/8/head:pull/8 PR: https://git.openjdk.org/jdk21u-dev/pull/8 From phh at openjdk.org Thu Mar 7 15:58:56 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 7 Mar 2024 15:58:56 GMT Subject: [jdk21u-dev] RFR: 8319650: Improve heap dump performance with class metadata caching [v3] In-Reply-To: References: <_Ib2XP8lK31x6lHk8Dk-F5w6ZD_C-yX9cTlbnBaqfTk=.60c3387a-dd78-4f70-9622-ca79e6321848@github.com> Message-ID: On Thu, 7 Mar 2024 15:47:12 GMT, Aleksey Shipilev wrote: >> Transplanted from https://github.com/openjdk/jdk21u/pull/388 >> >> Unclean backport to improve heap dump performance. The uncleanliness comes from [JDK-8306441](https://bugs.openjdk.org/browse/JDK-8306441) that does not exist in JDK 21, and which I don't think we want to backport at the moment. I had to add a few more `ResourceMark`-s near `HeapDumpWriter` to manage the cache allocations. >> >> Additional testing: >> - [x] MacOS AArch64 server release, heap dump performance improved >> - [x] Linux x86_64 server fastdebug, serviceability/ (contains heap dump tests) >> - [x] Linux x86_64 server fastdebug, runtime/ErrorHandling (contains heap dump on failure tests) >> - [x] Linux x86_64 server fastdebug, gc/epsilon (contains heap dump on failure tests) >> - [x] Linux x86_64 server fastdebug, sun/tools/jhsdb (contains heap dump tests) > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into JDK-8319650-heapdump-cache-class > - Merge branch 'master' into JDK-8319650-heapdump-cache-class > - Backport 03db82818b905f21cb5ad1d56a687e238b4a6e33 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/8#pullrequestreview-1922857230 From szaldana at openjdk.org Thu Mar 7 15:13:01 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Thu, 7 Mar 2024 15:13:01 GMT Subject: [jdk21u-dev] Integrated: 8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test In-Reply-To: References: Message-ID: <1zeat6lzynEVOImsy0Eu4f3wpUxzISYfE3c_oGNtcts=.e84bc4e2-4d30-4cd3-8c90-9258c32be0a4@github.com> On Tue, 5 Mar 2024 18:45:20 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [54f09d73](https://github.com/openjdk/jdk/commit/54f09d734584a71c648520664447f8395050adbe) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 23 Feb 2024 and was reviewed by Martin Buchholz and Lance Andersen. > > Thanks! This pull request has now been integrated. Changeset: c26cad30 Author: Sonia Zaldana Calles Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/c26cad30271780e72b1f7e25457760785bf7a8e3 Stats: 76 lines in 2 files changed: 0 ins; 76 del; 0 mod 8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test Backport-of: 54f09d734584a71c648520664447f8395050adbe ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/331 From aleonard at openjdk.org Thu Mar 7 15:20:57 2024 From: aleonard at openjdk.org (Andrew Leonard) Date: Thu, 7 Mar 2024 15:20:57 GMT Subject: [jdk21u-dev] RFR: 8326685: Linux builds not reproducible if two builds configured in different build folders In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 16:59:28 GMT, Andrew Leonard wrote: > Backports the debug symbol mapping fix to ensure two builds built in different build output directories are identical. linux-cross-compile(riscv) is broken for unrelated build issues it seems ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/336#issuecomment-1983736917 From goetz at openjdk.org Thu Mar 7 16:10:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 16:10:27 GMT Subject: [jdk17u-dev] RFR: 8319372: C2 compilation fails with "Bad immediate dominator info" Message-ID: I backport this for parity with 17.0.12-oracle. The change just removes one local optimization pattern in C2. The change did not apply well as there are differences in comment and whitespace, and a different error message. Code wise the outermost if() differs. As the inner pattern matching is the same, the problem exists similarly in 11. Tests pass. ------------- Commit messages: - Backport 7766785098816cfcdae3479540cdc866c1ed18ad Changes: https://git.openjdk.org/jdk17u-dev/pull/2274/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2274&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319372 Stats: 231 lines in 4 files changed: 171 ins; 60 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2274.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2274/head:pull/2274 PR: https://git.openjdk.org/jdk17u-dev/pull/2274 From rrich at openjdk.org Thu Mar 7 15:03:58 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Thu, 7 Mar 2024 15:03:58 GMT Subject: [jdk17u-dev] Integrated: 8310031: Parallel: Implement better work distribution for large object arrays in old gen In-Reply-To: References: Message-ID: On Sat, 24 Feb 2024 10:00:00 GMT, Richard Reingruber wrote: > I would like to backport this as a performance bug fix. > > We received bug reports from users which have some young pauses of 30s, and even up to 50s (normally <1s) running large Gerrit instances (200GB heap, 100 gc threads). > We have tried to tune ParallelGC. Reducing the number of gc threads helps to make the pause time spikes smaller but this makes average pause times longer. > > This pr depends on > https://github.com/openjdk/jdk17u-dev/pull/2226 > https://github.com/openjdk/jdk17u-dev/pull/2227 > https://github.com/openjdk/jdk17u-dev/pull/2228 > > All hunks except the following 2 applied after a trivial preparation change. > The 1st hunk of psCardTable.hpp did not apply because of different context. Resolved by inserting the new lines. > The 2nd hunk of psScavenge.cpp did not apply because of different context. Resolved by inserting the new lines. > Finally a few trivial changes are required (renaming and the like). > > Risk is medium. We've done the downstream backport already many weeks ago. > > I've tested on x86_64: > jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC" > > Local CI Testing: > The fix passed our CI testing (e.g. 2024-02-25): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. This pull request has now been integrated. Changeset: f221ff38 Author: Richard Reingruber URL: https://git.openjdk.org/jdk17u-dev/commit/f221ff38300b5513a06e5755469668ef83556a3a Stats: 334 lines in 5 files changed: 177 ins; 70 del; 87 mod 8310031: Parallel: Implement better work distribution for large object arrays in old gen Reviewed-by: phh Backport-of: 4bfe226870a15306b1e015c38fe3835f26b41fe6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2230 From fyang at openjdk.org Thu Mar 7 15:20:00 2024 From: fyang at openjdk.org (Fei Yang) Date: Thu, 7 Mar 2024 15:20:00 GMT Subject: [jdk21u-dev] RFR: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support [v2] In-Reply-To: <9QpsRx46Z81i8gfhceeZdBfhR7MZNutmsihst1_oBQ8=.d26e1de0-a67d-498e-9345-b5ee85113f24@github.com> References: <9QpsRx46Z81i8gfhceeZdBfhR7MZNutmsihst1_oBQ8=.d26e1de0-a67d-498e-9345-b5ee85113f24@github.com> Message-ID: On Thu, 29 Feb 2024 12:39:20 GMT, Ludovic Henry wrote: >> 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support > > Ludovic Henry has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' of github.com:openjdk/jdk21u into backport-luhenry-68eb5a1d > - Backport 68eb5a1df5afdc011aa467f1c723a8792532dd3f Marked as reviewed by fyang (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/294#pullrequestreview-1922738799 From phh at openjdk.org Thu Mar 7 16:39:58 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 7 Mar 2024 16:39:58 GMT Subject: [jdk17u-dev] RFR: 8319372: C2 compilation fails with "Bad immediate dominator info" In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 16:05:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > The change just removes one local optimization pattern in C2. > The change did not apply well as there are differences in comment > and whitespace, and a different error message. > > Code wise the outermost if() differs. > As the inner pattern matching is the same, the problem > exists similarly in 11. > > Tests pass. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2274#pullrequestreview-1922974266 From goetz.lindenmaier at sap.com Thu Mar 7 17:01:59 2024 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 7 Mar 2024 17:01:59 +0000 Subject: [11u heads up] Upgrade to jtreg 7.3.1 and enforce it Message-ID: Hi, 11u is currently using jtreg 6.1. We will upgrade jtreg to 7.3.1 and enforce this as minimum version by configure. Using latest jtreg makes testing jdk11 future-proof. Also, a row of tests recently backported needed changes because they would not work with jtreg 6.1. More of these will be encountered. We will backport "8292716 Configure should check that jtreg is of the required version" and later 8314495: Update to use jtreg 7.3.1. This will reach 11.0.24, i.e. the July update. The April update is not affected. Best regards, Goetz. -------------- next part -------------- An HTML attachment was scrubbed... URL: From goetz at openjdk.org Thu Mar 7 17:27:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 17:27:13 GMT Subject: [jdk11u-dev] RFR: 8292716: Configure should check that jtreg is of the required version Message-ID: <6OHALhQCeoDozdaMF0LJratZAMVTwjps5DPAUfJzeNU=.70b7a262-32d3-4bf1-aecc-cb9a0e708da8@github.com> I backport this as prereq to raise the jtreg version. I had to resolve one hunk due to context. This is based on the commit to 17 including a follow up. ------------- Commit messages: - Backport 9288072655a689c06a03f85c976bbd2f0744d3d5 Changes: https://git.openjdk.org/jdk11u-dev/pull/2585/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2585&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292716 Stats: 21 lines in 1 file changed: 21 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2585.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2585/head:pull/2585 PR: https://git.openjdk.org/jdk11u-dev/pull/2585 From phh at openjdk.org Thu Mar 7 17:33:58 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 7 Mar 2024 17:33:58 GMT Subject: [jdk11u-dev] RFR: 8292716: Configure should check that jtreg is of the required version In-Reply-To: <6OHALhQCeoDozdaMF0LJratZAMVTwjps5DPAUfJzeNU=.70b7a262-32d3-4bf1-aecc-cb9a0e708da8@github.com> References: <6OHALhQCeoDozdaMF0LJratZAMVTwjps5DPAUfJzeNU=.70b7a262-32d3-4bf1-aecc-cb9a0e708da8@github.com> Message-ID: On Thu, 7 Mar 2024 17:21:07 GMT, Goetz Lindenmaier wrote: > I backport this as prereq to raise the jtreg version. > > I had to resolve one hunk due to context. This is based on the commit to 17 including a follow up. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2585#pullrequestreview-1923090565 From shade at openjdk.org Thu Mar 7 18:06:58 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 7 Mar 2024 18:06:58 GMT Subject: [jdk11u-dev] RFR: 8292716: Configure should check that jtreg is of the required version In-Reply-To: <6OHALhQCeoDozdaMF0LJratZAMVTwjps5DPAUfJzeNU=.70b7a262-32d3-4bf1-aecc-cb9a0e708da8@github.com> References: <6OHALhQCeoDozdaMF0LJratZAMVTwjps5DPAUfJzeNU=.70b7a262-32d3-4bf1-aecc-cb9a0e708da8@github.com> Message-ID: On Thu, 7 Mar 2024 17:21:07 GMT, Goetz Lindenmaier wrote: > I backport this as prereq to raise the jtreg version. > > I had to resolve one hunk due to context. This is based on the commit to 17 including a follow up. This looks fine. Have you tested any simple tests with older jtreg? Have you tried building without jtreg? I guess we are not backporting the "clean" pre-requisites like [JDK-8292717](https://bugs.openjdk.org/browse/JDK-8292717)? ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2585#pullrequestreview-1923177390 From goetz at openjdk.org Thu Mar 7 19:06:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 7 Mar 2024 19:06:55 GMT Subject: [jdk11u-dev] RFR: 8292716: Configure should check that jtreg is of the required version In-Reply-To: <6OHALhQCeoDozdaMF0LJratZAMVTwjps5DPAUfJzeNU=.70b7a262-32d3-4bf1-aecc-cb9a0e708da8@github.com> References: <6OHALhQCeoDozdaMF0LJratZAMVTwjps5DPAUfJzeNU=.70b7a262-32d3-4bf1-aecc-cb9a0e708da8@github.com> Message-ID: On Thu, 7 Mar 2024 17:21:07 GMT, Goetz Lindenmaier wrote: > I backport this as prereq to raise the jtreg version. > > I had to resolve one hunk due to context. This is based on the commit to 17 including a follow up. Yes, I ran configure with 5.2, 6.2 and without jtreg. Works - or not - as expected. > I guess we are not backporting the "clean" pre-requisites Do you think we should? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2585#issuecomment-1984235082 From shade at openjdk.org Thu Mar 7 19:11:59 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 7 Mar 2024 19:11:59 GMT Subject: [jdk11u-dev] RFR: 8292716: Configure should check that jtreg is of the required version In-Reply-To: References: <6OHALhQCeoDozdaMF0LJratZAMVTwjps5DPAUfJzeNU=.70b7a262-32d3-4bf1-aecc-cb9a0e708da8@github.com> Message-ID: On Thu, 7 Mar 2024 19:04:38 GMT, Goetz Lindenmaier wrote: > > I guess we are not backporting the "clean" pre-requisites > > Do you think we should? I would do it for cleanliness reasons, i.e. to make sure other from-mainline backports fit in without fuzz. But I guess that would not help much, and would be a major hassle. So fine, let's do the jtreg update like so, and _then maybe_ whip up these 11u build system parts to mainline shape. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2585#issuecomment-1984242219 From phh at openjdk.org Thu Mar 7 20:02:54 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 7 Mar 2024 20:02:54 GMT Subject: [jdk21u-dev] RFR: 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java In-Reply-To: References: Message-ID: <0-dpcXXRWLhpAnlTC0C5vLcDjezqlB1dS0CT3knPdKk=.6969d556-9451-4e5c-82eb-5af232068889@github.com> On Thu, 7 Mar 2024 12:04:51 GMT, Aleksey Shipilev wrote: > Fixes the test when running with C1. Does not apply cleanly, because the relevant problemlist change is not applicable to jdk21u. We backported [JDK-8314838](https://bugs.openjdk.org/browse/JDK-8314838) to 21.0.3, which exposes us to this bug. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, C1, affected test fails without the patch, skipped with it > - [x] MacOS AArch64 server fastdebug, C2, affected test passes with the patch Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/339#pullrequestreview-1923417379 From aoqi at openjdk.org Thu Mar 7 20:10:00 2024 From: aoqi at openjdk.org (Ao Qi) Date: Thu, 7 Mar 2024 20:10:00 GMT Subject: [jdk11u-dev] Integrated: 8267938: (sctp) SCTP channel factory methods should check platform support In-Reply-To: <5B0Nc8r20ZgoPOoXO2OLhPMnDVBLb17jWx72vJjANe8=.337e7793-25ac-4070-b51c-b8a258a9ead5@github.com> References: <5B0Nc8r20ZgoPOoXO2OLhPMnDVBLb17jWx72vJjANe8=.337e7793-25ac-4070-b51c-b8a258a9ead5@github.com> Message-ID: On Tue, 30 Jan 2024 04:58:31 GMT, Ao Qi wrote: > Hi all, > > I would like to backport [JDK-8267938](https://bugs.openjdk.org/browse/JDK-8267938). According to the bug description, 11(.0.11) is also affected. `java/net/SctpSanity.java` can reproduce this problem. The backport is clean except copyright year. GHA testing is passed. > > Additional testing, no regression introduced by this backport: > - [x] Linux x86_64 server release, `tier1 tier2 tier3` > - [x] Linux x86_64 server fastdebug, `tier1 tier2 tier3` > > Thanks! This pull request has now been integrated. Changeset: 7b7fbdf6 Author: Ao Qi Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/7b7fbdf6159baceb83640786928d00b838be1a3a Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod 8267938: (sctp) SCTP channel factory methods should check platform support Backport-of: bd31653e6f99d4337e4af1f7f138d688ec99c19d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2500 From andrew.lu02 at sap.com Fri Mar 8 02:13:34 2024 From: andrew.lu02 at sap.com (Lu, Andrew) Date: Fri, 8 Mar 2024 02:13:34 +0000 Subject: CFV: New JDK Updates Committer: Amos Shi In-Reply-To: References: Message-ID: Vote: yes Thanks, Andrew From: jdk-updates-dev on behalf of Lindenmaier, Goetz Date: Friday, 23. February 2024 at 12:04 To: jdk-updates-dev at openjdk.org Subject: CFV: New JDK Updates Committer: Amos Shi I hereby nominate Amos Shi (ashi)[1] to JDK Updates Committer. Amos is an experienced Java developer and member of the SAP OpenJDK team. He is Author in the JDK Updates project. He is helping with SAPs effort to support 11u, 17u and 21u updates and has already contributed 50+ changes[2]. He has well deserved the Committer status which will also improve his productivity. Votes are due by 23:59 UTC on Friday, March 8th, 2024. Only current JDK Updates Committers (and above) [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Best regards, Goetz. [1] https://openjdk.org/census#ashi [2] https://github.com/openjdk/jdk11u-dev/commits?author=ashi at openjdk.org https://github.com/openjdk/jdk11u-dev/commits?author=amosshi https://github.com/openjdk/jdk17u-dev/commits?author=ashi at openjdk.org https://github.com/openjdk/jdk21u-dev/commits?author=ashi at openjdk.org [3] https://openjdk.java.net/census#jdk-updates [4] http://openjdk.java.net/projects/#committer-vote -------------- next part -------------- An HTML attachment was scrubbed... URL: From ashi at openjdk.org Fri Mar 8 02:21:21 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 8 Mar 2024 02:21:21 GMT Subject: [jdk11u-dev] RFR: 8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys Message-ID: Backport of [JDK-8218917](https://bugs.openjdk.org/browse/JDK-8218917) Testing - Local: Test passed - `AltGraphModifierTest.java`: Test results: no tests selected - `AltKeyBug.java`: Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 2044245c90810075fbead432ad92de8fcb8af68a Changes: https://git.openjdk.org/jdk11u-dev/pull/2587/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2587&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8218917 Stats: 123 lines in 3 files changed: 108 ins; 11 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2587.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2587/head:pull/2587 PR: https://git.openjdk.org/jdk11u-dev/pull/2587 From duke at openjdk.org Fri Mar 8 02:29:55 2024 From: duke at openjdk.org (Jiawei Tang) Date: Fri, 8 Mar 2024 02:29:55 GMT Subject: [jdk11u-dev] RFR: 8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id [v4] In-Reply-To: References: <426I6MDNxce_VFqi_lcS3TzcJF4RS0FtgWcD4ZWMW10=.464138b5-9749-4742-b43b-95e7f98ffe36@github.com> Message-ID: On Wed, 6 Mar 2024 11:02:54 GMT, Goetz Lindenmaier wrote: >> The results of related JFR testcases are all successful. >> >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/jdk/jfr 434 434 0 0 > > @jia-wei-tang, can you please add [11u] to the PR title as I did for the JBS issue? Thanks! @GoeLin I changed the title of the pr and triggered GHA tests. May you approve [JDK-8322511](https://bugs.openjdk.org/browse/JDK-8322511) ? Thanks a lot! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2413#issuecomment-1984935899 From mdoerr at openjdk.org Fri Mar 8 04:45:57 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 8 Mar 2024 04:45:57 GMT Subject: [jdk17u-dev] RFR: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM In-Reply-To: References: Message-ID: On Tue, 27 Feb 2024 21:23:22 GMT, Amos Shi wrote: > Backport of [JDK-8266242](https://bugs.openjdk.org/browse/JDK-8266242) > - `src/java.desktop/macosx/native/libawt_lwawt/awt/CGraphicsDevice.m` - clean backport > - `test/jdk/ProblemList.txt` - this file has been ignored because the line does not exist > > Testing > - Local: Test passed > - `CheckDisplayModes.java`: Test results: passed: 1 > > > MacBook Pro > 16-inch, 2021 > Chip Apple M1 Max > Memory: 32 GB > MacOS: 14.3.1 (23D60) > > > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies passed on `2024-03-01,02,03` LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2245#pullrequestreview-1924022099 From mdoerr at openjdk.org Fri Mar 8 04:55:57 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 8 Mar 2024 04:55:57 GMT Subject: [jdk17u-dev] RFR: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 23:39:50 GMT, Amos Shi wrote: > Backport of [JDK-8320943](https://bugs.openjdk.org/browse/JDK-8320943) > - This PR has two commits > - commit 1 is the backport of the original [commit](https://github.com/openjdk/jdk/commit/87516e29dc5015c4cab2c07c5539ad30f2768667) > - commit 2 is fixing the compile and runtime issue on Java 17. > - Compile issue fixed: on Java 17 the class is `jdk.test.lib.Platform` and `jdk.test.lib.OSVersion` > - Runtime issue fixed: on Java 17 there is no mime `wasm`, so we comment it out > - `wasm` exists in Java 21: https://github.com/openjdk/jdk21u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties > - `wasm` does not exists in Java 17: https://github.com/openjdk/jdk17u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties > - So this is an unclean backport > > Testing > - Local: Test passed on Mac > - `Basic.java` - Test results: passed: 1 > > Mac machine > > > MacBook Pro > 16-inch, 2021 > Chip: Apple M1 Max > MacOS: 14.3.1 (23D60) > > > Windows machine: > > > Device name W-PW05T4AD > Processor 12th Gen Intel(R) Core(TM) i7-12800H 2.40 GHz > Installed RAM 64.0 GB (63.7 GB usable) > System type 64-bit operating system, x64-based processor > > > - Pipeline: > - Testing Machine: SAP nightlies passed on `2024-03-01,02,03` LGTM. test/jdk/java/nio/file/Files/probeContentType/Basic.java line 188: > 186: exTypes.add(new ExType("xls", List.of("application/vnd.ms-excel"))); > 187: exTypes.add(new ExType("xlsx", List.of("application/vnd.openxmlformats-officedocument.spreadsheetml.sheet"))); > 188: // exTypes.add(new ExType("wasm", List.of("application/wasm"))); Ok, [JDK-8297609](https://bugs.openjdk.org/browse/JDK-8297609) is not in 17u. Can you add a comment explaining this, please? ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2254#pullrequestreview-1924028531 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2254#discussion_r1517164039 From mdoerr at openjdk.org Fri Mar 8 05:40:00 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 8 Mar 2024 05:40:00 GMT Subject: [jdk21u-dev] Integrated: 8325326: [PPC64] Don't relocate in case of allocation failure In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 15:47:13 GMT, Martin Doerr wrote: > Clean backport of [JDK-8325326](https://bugs.openjdk.org/browse/JDK-8325326). This pull request has now been integrated. Changeset: c4c4b22c Author: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/c4c4b22c0b3ff089ccbe4b3d795d6110ea1f7b37 Stats: 12 lines in 1 file changed: 6 ins; 2 del; 4 mod 8325326: [PPC64] Don't relocate in case of allocation failure Backport-of: 4388095cde20dec602ada9fe2977f1a359ceab91 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/311 From ashi at openjdk.org Fri Mar 8 05:41:04 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 8 Mar 2024 05:41:04 GMT Subject: [jdk21u-dev] Integrated: 8315677: Open source few swing JFileChooser and other tests In-Reply-To: References: Message-ID: <_JwzFOl1xhD96rTsg_douU2QqNYiA_vSiuoGM-cbDf8=.37a25e6c-25a7-4aa6-a618-432c55b8adb1@github.com> On Wed, 28 Feb 2024 19:22:44 GMT, Amos Shi wrote: > Backport of [JDK-8315677](https://bugs.openjdk.org/browse/JDK-8315677) > > Testing > - Local: Test passed > - `bug4624353.java` - Test results: passed: 1 > - `bug4673161.java` - Test results: no tests selected > - `bug4782168.java` - Test results: passed: 1 > - `bug4822331.java` - Test results: passed: 1 > - `bug4191835.java` - Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies passed on `2024-03-01,02,05` This pull request has now been integrated. Changeset: 9a8d91a9 Author: Amos Shi Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/9a8d91a99ff175c2e72538e2b82c777b04059e59 Stats: 360 lines in 5 files changed: 360 ins; 0 del; 0 mod 8315677: Open source few swing JFileChooser and other tests Backport-of: fe5ef5f20dcf647b4ca30963b42fa01449f0d9c0 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/300 From ashi at openjdk.org Fri Mar 8 05:42:00 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 8 Mar 2024 05:42:00 GMT Subject: [jdk21u-dev] Integrated: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination In-Reply-To: References: Message-ID: <5Og6gUr-UBfbk9lNhSqP_AaTfcX1yE5hf6nkM8hqWc4=.1b28cd21-d814-4e4d-84f5-fc923a33bfa6@github.com> On Wed, 28 Feb 2024 20:34:05 GMT, Amos Shi wrote: > Backport of [JDK-8317287](https://bugs.openjdk.org/browse/JDK-8317287) > > Testing > - Local: Test passed > - `InterJVMGetDropSuccessTest.java` - Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies passed on `2024-03-01,02,05` This pull request has now been integrated. Changeset: 8e439ba6 Author: Amos Shi Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/8e439ba64ac90610f9a3d03567648e2c432985bc Stats: 104 lines in 1 file changed: 40 ins; 38 del; 26 mod 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination Backport-of: cbfddf4e1d3ff8dddb95bcb9242b31c175b768fc ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/302 From ashi at openjdk.org Fri Mar 8 05:42:55 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 8 Mar 2024 05:42:55 GMT Subject: [jdk21u-dev] Integrated: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 01:26:41 GMT, Amos Shi wrote: > Backport of [JDK-8325137](https://bugs.openjdk.org/browse/JDK-8325137) > > Testing > - Local: Test passed > - `ThreadCpuTimeArray.java` - Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies passed on `2024-03-01,02,05` This pull request has now been integrated. Changeset: 066af443 Author: Amos Shi Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/066af44353e5bd3a35f9d3533c45f6e8ef0fd26f Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range Backport-of: 91d8dac9cff5689abcf2fc8950b15d284f933afd ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/303 From ashi at openjdk.org Fri Mar 8 05:45:04 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 8 Mar 2024 05:45:04 GMT Subject: [jdk21u-dev] Integrated: 8315834: Open source several Swing JSpinner related tests In-Reply-To: <45x1zcYp6Z4ky5o3CiRtMM4g7HDaJjux6CKP4VB_1lY=.6f697a5f-0bfc-49ae-b6ec-8e01bd13b09b@github.com> References: <45x1zcYp6Z4ky5o3CiRtMM4g7HDaJjux6CKP4VB_1lY=.6f697a5f-0bfc-49ae-b6ec-8e01bd13b09b@github.com> Message-ID: On Wed, 28 Feb 2024 20:06:08 GMT, Amos Shi wrote: > Backport of [JDK-8315834](https://bugs.openjdk.org/browse/JDK-8315834) > > Testing > - Local: Test passed > - `bug4522737.java` - Test results: passed: 1 > - `bug4656590.java` - Test results: passed: 1 > - `bug4680204.java` - Test results: passed: 1 > - `bug4862257.java` - Test results: passed: 1 > - `bug5104421.java` - Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies passed on `2024-03-01,02,05` This pull request has now been integrated. Changeset: 624e6034 Author: Amos Shi Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/624e6034a7c068a4338c72cf27df405e357e2cdd Stats: 370 lines in 5 files changed: 370 ins; 0 del; 0 mod 8315834: Open source several Swing JSpinner related tests Backport-of: 4a63eb05221c1829b157a025a4d35cdd77a9fe04 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/301 From duke at openjdk.org Fri Mar 8 06:40:19 2024 From: duke at openjdk.org (Long Yang) Date: Fri, 8 Mar 2024 06:40:19 GMT Subject: [jdk21u-dev] RFR: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate Message-ID: Hi, all Could I have a review of this backport. This pull request contains a backport of commit [8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb](https://github.com/openjdk/jdk/commit/8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. Testing: I ran test/jdk/jdk/jfr/event/os/TestCPULoad.java and passed. All GHA tests are passed (except linux-cross-compile, build(riscv64), Create sysroot. It looks like there's an issue with the GHA's process). ------------- Commit messages: - 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate Changes: https://git.openjdk.org/jdk21u-dev/pull/341/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=341&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326446 Stats: 30 lines in 1 file changed: 1 ins; 7 del; 22 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/341.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/341/head:pull/341 PR: https://git.openjdk.org/jdk21u-dev/pull/341 From gcao at openjdk.org Fri Mar 8 06:54:02 2024 From: gcao at openjdk.org (Gui Cao) Date: Fri, 8 Mar 2024 06:54:02 GMT Subject: [jdk22u] Integrated: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 08:43:12 GMT, Gui Cao wrote: > Hi, The same issue also exists in the JDK22U: I can reproduce it locally and use this clean patch can fix that issue, So I would like to backport this to JDK22U. Several related tests failed before this patch, including gc/shenandoah/TestSmallHeap.java, gc/metaspace/TestMetaspacePerfCounters.java#Shenandoah-64, etc. After the fix, it can passed normally. This is a risc-v specific change. Backport is clean, risk is low. > > I see that GHA linux-cross-compile / build (riscv64) fails, but I can build it successfully locally. GHA failure is infrastructural: https://bugs.openjdk.org/browse/JDK-8326960 This pull request has now been integrated. Changeset: cffdef15 Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/jdk22u/commit/cffdef1568b564373d71b5fda3d01c0bdb05dbdb Stats: 49 lines in 1 file changed: 49 ins; 0 del; 0 mod 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations Backport-of: a089ed2b9289eeda73bba47ac87e5bc81a4af9dc ------------- PR: https://git.openjdk.org/jdk22u/pull/90 From rmarchenko at openjdk.org Fri Mar 8 06:54:14 2024 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Fri, 8 Mar 2024 06:54:14 GMT Subject: [jdk17u-dev] RFR: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect Message-ID: The backport isn't clean. 1. Resolved a conflict in `src/hotspot/share/prims/jvmtiEventController.cpp` with an empty line. 2. Removed files as VThreads are not implemented in jdk17: - `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/libVThreadTest.cpp` - `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/VThreadTest.java` 3. Added new test: - `test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/Test.java` - `test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/libextcallback.c` - `test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/loadClass/Test2.java` Actually, backporting the fix only. The new test fails without the fix, and successfully passes with the fix. ------------- Commit messages: - Added test for the fix. - 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect Changes: https://git.openjdk.org/jdk17u-dev/pull/2276/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2276&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286490 Stats: 166 lines in 4 files changed: 164 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2276.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2276/head:pull/2276 PR: https://git.openjdk.org/jdk17u-dev/pull/2276 From duke at openjdk.org Fri Mar 8 07:43:21 2024 From: duke at openjdk.org (Long Yang) Date: Fri, 8 Mar 2024 07:43:21 GMT Subject: [jdk17u-dev] RFR: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate Message-ID: <8yDsUnG0HQVsCakGSjitm-ErWQvnkmKQqaF_cPGilEY=.20cc85c6-7e45-4256-b995-32034141df9c@github.com> Hi, all Could I have a review of this backport. This pull request contains a backport of commit [8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb](https://github.com/openjdk/jdk/commit/8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. Testing: I ran test/jdk/jdk/jfr/event/os/TestCPULoad.java and passed. All GHA tests are passed (except linux-cross-compile, build(riscv64), Create sysroot. It looks like there's an issue with the GHA's process). ------------- Commit messages: - 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate Changes: https://git.openjdk.org/jdk17u-dev/pull/2277/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2277&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326446 Stats: 40 lines in 1 file changed: 6 ins; 12 del; 22 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2277.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2277/head:pull/2277 PR: https://git.openjdk.org/jdk17u-dev/pull/2277 From andrewlu at openjdk.org Fri Mar 8 08:09:20 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 8 Mar 2024 08:09:20 GMT Subject: [jdk11u-dev] RFR: 8248667: Need support for building native libraries located in the test/lib directory [v3] In-Reply-To: References: Message-ID: > Backport for JDK-8248194 and JDK-8248667 Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: test ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2580/files - new: https://git.openjdk.org/jdk11u-dev/pull/2580/files/6ce47de8..5d11c737 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2580&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2580&range=01-02 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2580.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2580/head:pull/2580 PR: https://git.openjdk.org/jdk11u-dev/pull/2580 From rmarchenko at openjdk.org Fri Mar 8 09:09:00 2024 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Fri, 8 Mar 2024 09:09:00 GMT Subject: [jdk17u-dev] RFR: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect In-Reply-To: References: Message-ID: On Fri, 8 Mar 2024 06:47:16 GMT, Roman Marchenko wrote: > The backport isn't clean. > > 1. Resolved a conflict in `src/hotspot/share/prims/jvmtiEventController.cpp` with an empty line. > 2. Removed files as VThreads are not implemented in jdk17: > - `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/libVThreadTest.cpp` > - `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/VThreadTest.java` > 3. Added new test: > - `test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/Test.java` > - `test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/libextcallback.c` > - `test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/loadClass/Test2.java` > > Actually, backporting the fix only. > The new test fails without the fix, and successfully passes with the fix. GHA passed, but "linux-cross-compile / build (riscv64)" - seems like an infrastructure problem. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2276#issuecomment-1985316814 From adinn at redhat.com Fri Mar 8 09:22:28 2024 From: adinn at redhat.com (Andrew Dinn) Date: Fri, 8 Mar 2024 09:22:28 +0000 Subject: CFV: New JDK Updates Committer: Amos Shi In-Reply-To: References: Message-ID: Vote: yes On 08/03/2024 02:13, Lu, Andrew wrote: > Vote: yes > > Thanks, > Andrew > > *From: *jdk-updates-dev on behalf of > Lindenmaier, Goetz > *Date: *Friday, 23. February 2024 at 12:04 > *To: *jdk-updates-dev at openjdk.org > *Subject: *CFV: New JDK Updates Committer: Amos Shi > > I hereby nominate Amos Shi (ashi)[1] to JDK Updates Committer. > > Amos is an experienced Java developer and member of the SAP > > OpenJDK team. He is Author in the JDK Updates project. He is > > helping with SAPs effort to support 11u, 17u and 21u updates > > and has already contributed 50+ changes[2]. He has well deserved the > > Committer status which will also improve his productivity. > > Votes are due by 23:59 UTC on Friday, March 8th, 2024. > > Only current JDK Updates Committers (and above) [3] are eligible to vote > > on this nomination. > > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > > ? Goetz. > > [1] https://openjdk.org/census#ashi > > [2] > https://github.com/openjdk/jdk11u-dev/commits?author=ashi at openjdk.org > > > ??? https://github.com/openjdk/jdk11u-dev/commits?author=amosshi > > https://github.com/openjdk/jdk17u-dev/commits?author=ashi at openjdk.org > > > https://github.com/openjdk/jdk21u-dev/commits?author=ashi at openjdk.org > > > [3] https://openjdk.java.net/census#jdk-updates > > > [4] http://openjdk.java.net/projects/#committer-vote > > -- regards, Andrew Dinn ----------- Red Hat Distinguished Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill From snazarki at openjdk.org Fri Mar 8 09:23:58 2024 From: snazarki at openjdk.org (Sergey Nazarkin) Date: Fri, 8 Mar 2024 09:23:58 GMT Subject: [jdk17u-dev] RFR: 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used In-Reply-To: <-pNl27hnJvTUMD9biuEkMOrR2K1cmCvuG8EgiIObPTc=.0662dd66-97ca-445b-85fd-92c6bdd2e094@github.com> References: <-pNl27hnJvTUMD9biuEkMOrR2K1cmCvuG8EgiIObPTc=.0662dd66-97ca-445b-85fd-92c6bdd2e094@github.com> Message-ID: <5OvIHZxc_RkoycvH2j1KLm0uQKunWVUTkIc7aiQLq5I=.08906058-2b7e-4d72-b681-2f1cfee01ee6@github.com> On Thu, 29 Feb 2024 12:06:15 GMT, Sergey Nazarkin wrote: > I'd like to backport this changes as it fixes some custom launchers issue. Fix applies cleanly. > > The functionality was tested with the new test and manually > > cd ~/tools/bin > cp -r ~/jdk . > cp jdk/bin/java jdk/lib > jdk/lib/java -version > > > Without the patch JVM can't start > > Error: could not find libjava.so > Error: Could not find Java SE Runtime Environment. GHA failure: Risc-V build issue, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2257#issuecomment-1985337865 From rrich at openjdk.org Fri Mar 8 09:25:18 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Fri, 8 Mar 2024 09:25:18 GMT Subject: [jdk17u-dev] RFR: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 Message-ID: This pull request contains a backport of commit [ad1d3248](https://github.com/openjdk/jdk21u-dev/commit/ad1d32484a8130c9b641cff38c07e8544b3fd271) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. With the change the current thread switches to `WXWrite` mode before transitioning into the vm in `JVM_ENTRY_FROM_LEAF`. Testing: `test/jdk/sun/nio/cs/FindDecoderBugs.java` with `-XX:+AssertWXAtThreadSync` The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. Thanks! ------------- Commit messages: - Backport ad1d32484a8130c9b641cff38c07e8544b3fd271 Changes: https://git.openjdk.org/jdk17u-dev/pull/2269/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2269&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327036 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2269.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2269/head:pull/2269 PR: https://git.openjdk.org/jdk17u-dev/pull/2269 From rrich at openjdk.org Fri Mar 8 09:25:18 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Fri, 8 Mar 2024 09:25:18 GMT Subject: [jdk17u-dev] RFR: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 09:17:26 GMT, Richard Reingruber wrote: > This pull request contains a backport of commit [ad1d3248](https://github.com/openjdk/jdk21u-dev/commit/ad1d32484a8130c9b641cff38c07e8544b3fd271) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > With the change the current thread switches to `WXWrite` mode before transitioning into the vm in `JVM_ENTRY_FROM_LEAF`. > > Testing: > `test/jdk/sun/nio/cs/FindDecoderBugs.java` with `-XX:+AssertWXAtThreadSync` > > The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. > > Thanks! riscv64 build error is unrelated. See https://bugs.openjdk.org/browse/JDK-8326960 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2269#issuecomment-1981051399 From shipilev at amazon.de Fri Mar 8 09:30:41 2024 From: shipilev at amazon.de (Aleksey Shipilev) Date: Fri, 8 Mar 2024 10:30:41 +0100 Subject: CFV: New JDK Updates Committer: Amos Shi In-Reply-To: References: Message-ID: <14cc0b7c-c305-4912-b3ee-29ce5ad19900@amazon.de> Vote: yes On 23.02.24 12:04, Lindenmaier, Goetz wrote: > I hereby nominate Amos Shi (ashi)[1] to JDK Updates Committer. Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From andrewlu at openjdk.org Fri Mar 8 09:59:22 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 8 Mar 2024 09:59:22 GMT Subject: [jdk11u-dev] RFR: 8248667: Need support for building native libraries located in the test/lib directory [v4] In-Reply-To: References: Message-ID: <3zf-nu_uVIzooqpmZldScv_YsknIS5fjldLjDbFZanc=.4bb8feff-bdd0-4e9e-b34f-856564c6af9d@github.com> > Backport for JDK-8248194 and JDK-8248667 Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: fix the Asserts error ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2580/files - new: https://git.openjdk.org/jdk11u-dev/pull/2580/files/5d11c737..f3f3b1ca Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2580&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2580&range=02-03 Stats: 5 lines in 2 files changed: 2 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2580.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2580/head:pull/2580 PR: https://git.openjdk.org/jdk11u-dev/pull/2580 From andrewlu at openjdk.org Fri Mar 8 10:04:27 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 8 Mar 2024 10:04:27 GMT Subject: [jdk11u-dev] RFR: 8248667: Need support for building native libraries located in the test/lib directory [v5] In-Reply-To: References: Message-ID: > Backport for JDK-8248194 and JDK-8248667 > CoreUtil.java: > add this code to fix the "Output doesn't contain the location of core file" assert error. > if(crashOutputString.equals("")) { > return null; > } Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: revert back ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2580/files - new: https://git.openjdk.org/jdk11u-dev/pull/2580/files/f3f3b1ca..b720f1e4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2580&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2580&range=03-04 Stats: 5 lines in 1 file changed: 3 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2580.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2580/head:pull/2580 PR: https://git.openjdk.org/jdk11u-dev/pull/2580 From andrewlu at openjdk.org Fri Mar 8 10:10:24 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 8 Mar 2024 10:10:24 GMT Subject: [jdk11u-dev] RFR: 8248667: Need support for building native libraries located in the test/lib directory [v6] In-Reply-To: References: Message-ID: > Backport for JDK-8248194 and JDK-8248667 > CoreUtil.java: > add this code to fix the "Output doesn't contain the location of core file" assert error. > if(crashOutputString == null || crashOutputString.equals("")) { > return null; > } Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: revert back ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2580/files - new: https://git.openjdk.org/jdk11u-dev/pull/2580/files/b720f1e4..3c0fe6b8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2580&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2580&range=04-05 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2580.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2580/head:pull/2580 PR: https://git.openjdk.org/jdk11u-dev/pull/2580 From aph at openjdk.org Fri Mar 8 10:59:55 2024 From: aph at openjdk.org (Andrew Haley) Date: Fri, 8 Mar 2024 10:59:55 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 12:52:28 GMT, Mar?a Arias de Reyna wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8280377 MethodHandleProxies does not correctly invoke default methods with varags > > I applied the same fix that was applied to version 19 in https://github.com/openjdk/jdk/commit/a183bfb436a7dd998e602c2d16486e88c390fca1 OK, I see now. Thanks for the explanation. ------------- Marked as reviewed by aph (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2235#pullrequestreview-1924623405 From jkern at openjdk.org Fri Mar 8 14:00:01 2024 From: jkern at openjdk.org (Joachim Kern) Date: Fri, 8 Mar 2024 14:00:01 GMT Subject: [jdk22u] RFR: 8322943: runtime/CompressedOops/CompressedClassPointers.java fails on AIX Message-ID: Hi all, This pull request contains a backport of commit [997e615c](https://github.com/openjdk/jdk/commit/997e615c69f4445d92e164b814ea3358659e93dc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Joachim Kern on 8 Mar 2024 and was reviewed by Guoxiong Li and Thomas Stuefe. Thanks! ------------- Commit messages: - Backport 997e615c69f4445d92e164b814ea3358659e93dc Changes: https://git.openjdk.org/jdk22u/pull/92/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=92&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322943 Stats: 44 lines in 4 files changed: 26 ins; 7 del; 11 mod Patch: https://git.openjdk.org/jdk22u/pull/92.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/92/head:pull/92 PR: https://git.openjdk.org/jdk22u/pull/92 From mbaesken at openjdk.org Fri Mar 8 15:07:57 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 8 Mar 2024 15:07:57 GMT Subject: [jdk22u] Integrated: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 13:58:12 GMT, Matthias Baesken wrote: > 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns This pull request has now been integrated. Changeset: f5cfcbbc Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/f5cfcbbc192021218ab171604fecf4096d456be6 Stats: 99 lines in 1 file changed: 23 ins; 57 del; 19 mod 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns Backport-of: d9ef16dbb6917a4fff7711b32f3dd87611560dd1 ------------- PR: https://git.openjdk.org/jdk22u/pull/91 From erikj at openjdk.org Fri Mar 8 15:08:53 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Fri, 8 Mar 2024 15:08:53 GMT Subject: [jdk22u] Integrated: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 22:48:01 GMT, Erik Joelsson wrote: > Clean backport. This pull request has now been integrated. Changeset: f510fe81 Author: Erik Joelsson URL: https://git.openjdk.org/jdk22u/commit/f510fe81145b614d6da2d50154bb75cacc59ff98 Stats: 22 lines in 2 files changed: 8 ins; 3 del; 11 mod 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries Backport-of: 721bfee53af5bc2e2d67eebc7b82f09a642d5309 ------------- PR: https://git.openjdk.org/jdk22u/pull/89 From mbaesken at openjdk.org Fri Mar 8 15:08:59 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 8 Mar 2024 15:08:59 GMT Subject: [jdk22u] Integrated: 8327059: os::Linux::print_proc_sys_info add swappiness information In-Reply-To: References: Message-ID: On Tue, 5 Mar 2024 14:54:15 GMT, Matthias Baesken wrote: > 8327059: os::Linux::print_proc_sys_info add swappiness information This pull request has now been integrated. Changeset: 6b307d73 Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/6b307d731d7e9638a9c5aa725439db5b34bb900a Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8327059: os::Linux::print_proc_sys_info add swappiness information Backport-of: f3b15abcb7dcd00158df84818965fc1282dcc1d9 ------------- PR: https://git.openjdk.org/jdk22u/pull/84 From mbaesken at openjdk.org Fri Mar 8 15:27:54 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 8 Mar 2024 15:27:54 GMT Subject: [jdk22u] Integrated: 8324834: Use _LARGE_FILES on AIX In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 08:13:33 GMT, Matthias Baesken wrote: > 8324834: Use _LARGE_FILES on AIX This pull request has now been integrated. Changeset: fd113824 Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/fd113824c139523d91026b7684cd6b62661aef5d Stats: 21 lines in 4 files changed: 4 ins; 0 del; 17 mod 8324834: Use _LARGE_FILES on AIX Backport-of: 8e45182357f4990c86fd0b711a7a91887945480b ------------- PR: https://git.openjdk.org/jdk22u/pull/82 From szaldana at openjdk.org Fri Mar 8 15:51:25 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Fri, 8 Mar 2024 15:51:25 GMT Subject: [jdk17u-dev] RFR: 8315898: Open source swing JMenu tests Message-ID: Hi all, This pull request contains a backport of commit [fecd2fd8](https://github.com/openjdk/jdk/commit/fecd2fd8f26d0e8905a519e30e9aa171683c9df1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Abhishek Kumar on 13 Sep 2023 and was reviewed by Sergey Bylokhov. Thanks! ------------- Commit messages: - Backport fecd2fd8f26d0e8905a519e30e9aa171683c9df1 Changes: https://git.openjdk.org/jdk17u-dev/pull/2275/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2275&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315898 Stats: 357 lines in 6 files changed: 357 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2275.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2275/head:pull/2275 PR: https://git.openjdk.org/jdk17u-dev/pull/2275 From szaldana at openjdk.org Fri Mar 8 15:51:25 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Fri, 8 Mar 2024 15:51:25 GMT Subject: [jdk17u-dev] RFR: 8315898: Open source swing JMenu tests In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 19:07:04 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [fecd2fd8](https://github.com/openjdk/jdk/commit/fecd2fd8f26d0e8905a519e30e9aa171683c9df1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Abhishek Kumar on 13 Sep 2023 and was reviewed by Sergey Bylokhov. > > Thanks! GHA failure: Unrelated Risk-V build issue. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2275#issuecomment-1985926397 From szaldana at openjdk.org Fri Mar 8 15:53:15 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Fri, 8 Mar 2024 15:53:15 GMT Subject: [jdk11u-dev] RFR: 8219901: Noto fonts for East Asian countries cannot belong to CompositeFont Message-ID: Hi all, This pull request contains a backport of commit [189e938d](https://github.com/openjdk/jdk/commit/189e938d3ab6984581c83a5996281ec436e0ac2e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Toshio Nakamura on 2 Jun 2019 and was reviewed by Phil Race and Jayathirth D V. Testing: original issue test case passes, all tests in ```test/jdk/java/awt/font/``` pass and tier 1 with GHA. Thanks! ------------- Commit messages: - Backport 189e938d3ab6984581c83a5996281ec436e0ac2e Changes: https://git.openjdk.org/jdk11u-dev/pull/2586/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2586&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8219901 Stats: 137 lines in 3 files changed: 125 ins; 2 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2586.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2586/head:pull/2586 PR: https://git.openjdk.org/jdk11u-dev/pull/2586 From ashi at openjdk.org Fri Mar 8 18:31:21 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 8 Mar 2024 18:31:21 GMT Subject: [jdk17u-dev] RFR: 8305645: System Tray icons get corrupted when Windows primary monitor changes Message-ID: Backport of [JDK-8305645](https://bugs.openjdk.org/browse/JDK-8305645) Testing - Local: - Build on MacOS M1 succeeded - `TODO` re-test on Windows 11 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 6cd370e04b01c3033eb439de0f38e9b6d703c6f4 Changes: https://git.openjdk.org/jdk17u-dev/pull/2278/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2278&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305645 Stats: 16 lines in 2 files changed: 7 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2278.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2278/head:pull/2278 PR: https://git.openjdk.org/jdk17u-dev/pull/2278 From ashi at openjdk.org Fri Mar 8 18:31:27 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 8 Mar 2024 18:31:27 GMT Subject: [jdk21u-dev] RFR: 8305645: System Tray icons get corrupted when Windows primary monitor changes Message-ID: Backport of [JDK-8305645](https://bugs.openjdk.org/browse/JDK-8305645) Testing - Local: - Build on MacOS M1 succeeded - `TODO` re-test on Windows 11 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 6cd370e04b01c3033eb439de0f38e9b6d703c6f4 Changes: https://git.openjdk.org/jdk21u-dev/pull/343/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=343&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305645 Stats: 16 lines in 2 files changed: 7 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/343.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/343/head:pull/343 PR: https://git.openjdk.org/jdk21u-dev/pull/343 From ashi at openjdk.org Fri Mar 8 18:32:21 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 8 Mar 2024 18:32:21 GMT Subject: [jdk11u-dev] RFR: 8305645: System Tray icons get corrupted when Windows primary monitor changes Message-ID: Backport of [JDK-8305645](https://bugs.openjdk.org/browse/JDK-8305645) Testing - Local: - Build on MacOS M1 succeeded - `TODO` re-test on Windows 11 - Pipeline: - Testing Machine: ------------- Commit messages: - Backport 6cd370e04b01c3033eb439de0f38e9b6d703c6f4 Changes: https://git.openjdk.org/jdk11u-dev/pull/2589/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2589&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305645 Stats: 16 lines in 2 files changed: 7 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2589.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2589/head:pull/2589 PR: https://git.openjdk.org/jdk11u-dev/pull/2589 From ashi at openjdk.org Fri Mar 8 21:44:16 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 8 Mar 2024 21:44:16 GMT Subject: [jdk21u-dev] RFR: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters Message-ID: <0JwXa6rEhkFcwmiFf7JJ5KyRyhnX45wXnMwU6EEnwx8=.426d3188-cf6f-4916-a038-8fa2890c574b@github.com> Backport of [JDK-8320570](https://bugs.openjdk.org/browse/JDK-8320570) - `NegativeSize.java` - Clean backport - `String.java` - only 1 line change is unclean, the rest are clean. Details as bellow. - This PR contains 2 commits - The commit 1: is a clean backport part - The commit 2: is a manual fix of the following 1 line: - In the `jdk master` branch, the variable name is `utf16` - Well in `jdk21u-dev`, the varialbe name is `buf` - So we manully applied the following line @@ -592,7 +592,7 @@ this.coder = LATIN1; return; } - byte[] utf16 = new byte[length << 1]; + byte[] utf16 = StringUTF16.newBytesFor(length); StringLatin1.inflate(latin1, 0, utf16, 0, dp); dp = decodeUTF8_UTF16(latin1, sp, length, utf16, dp, true); if (dp != length) { - So this PR can be considered as `semantics clean` Testing - Local: Passed on MacOS M1 laptop - `test/jdk/java/lang/String/CompactString/NegativeSize.java` - Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Manual merge the line to jdk21u-dev - Backport 82796bdebbf56b98ec97a6d572ed68c2842f60c6 Changes: https://git.openjdk.org/jdk21u-dev/pull/344/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=344&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320570 Stats: 82 lines in 2 files changed: 75 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/344.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/344/head:pull/344 PR: https://git.openjdk.org/jdk21u-dev/pull/344 From duke at openjdk.org Fri Mar 8 22:06:15 2024 From: duke at openjdk.org (Robert Toyonaga) Date: Fri, 8 Mar 2024 22:06:15 GMT Subject: [jdk22u] RFR: 8326529: JFR: Test for CompilerCompile events fails due to time out Message-ID: This is a backport of https://github.com/openjdk/jdk/commit/4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 This backport limits compilation only to the test methods [TestCompileCompile](https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/compiler/TestCompilerCompile.java) cares about. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3046). ------------- Commit messages: - Backport 4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 Changes: https://git.openjdk.org/jdk22u/pull/93/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=93&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326529 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/93.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/93/head:pull/93 PR: https://git.openjdk.org/jdk22u/pull/93 From ashi at openjdk.org Fri Mar 8 23:06:04 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 8 Mar 2024 23:06:04 GMT Subject: [jdk17u-dev] RFR: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters Message-ID: Backport of [JDK-8320570](https://bugs.openjdk.org/browse/JDK-8320570) - `NegativeSize.java` - Clean backport - `String.java` - 3 sections change are unclean, the rest are clean. Details as bellow. - This PR contains 2 commits - The commit 1: is a clean backport part - The commit 2: is a manual fix of the following 3 sections, - Replace all `new byte[length << 1]` as `StringUTF16.newBytesFor(length)` @@ -592,7 +592,7 @@ this.coder = LATIN1; return; } - byte[] utf16 = new byte[length << 1]; + byte[] utf16 = StringUTF16.newBytesFor(length); StringLatin1.inflate(latin1, 0, utf16, 0, dp); dp = decodeUTF8_UTF16(latin1, sp, length, utf16, dp, true); if (dp != length) { @@ -601,7 +601,7 @@ this.value = utf16; this.coder = UTF16; } else { // !COMPACT_STRINGS - byte[] dst = new byte[length << 1]; + byte[] dst = StringUTF16.newBytesFor(length); int dp = decodeUTF8_UTF16(bytes, offset, offset + length, dst, 0, true); if (dp != length) { dst = Arrays.copyOf(dst, dp << 1); @@ -730,15 +730,15 @@ return new String(dst, LATIN1); } if (dp == 0) { - dst = new byte[length << 1]; + dst = StringUTF16.newBytesFor(length); } else { - byte[] buf = new byte[length << 1]; + byte[] buf = StringUTF16.newBytesFor(length); StringLatin1.inflate(dst, 0, buf, 0, dp); dst = buf; } dp = decodeUTF8_UTF16(bytes, offset, sl, dst, dp, false); } else { // !COMPACT_STRINGS - dst = new byte[length << 1]; + dst = StringUTF16.newBytesFor(length); dp = decodeUTF8_UTF16(bytes, offset, offset + length, dst, 0, false); } if (dp != length) { - So this PR can be considered as `semantics clean` Testing - Local: Passed on MacOS M1 laptop - `test/jdk/java/lang/String/CompactString/NegativeSize.java` - Test results: passed: 1 - Pipeline: - Testing Machine: ------------- Commit messages: - Manual merge the line to jdk17u-dev - Backport 82796bdebbf56b98ec97a6d572ed68c2842f60c6 Changes: https://git.openjdk.org/jdk17u-dev/pull/2279/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2279&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320570 Stats: 81 lines in 2 files changed: 75 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2279.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2279/head:pull/2279 PR: https://git.openjdk.org/jdk17u-dev/pull/2279 From mdoerr at openjdk.org Sat Mar 9 03:54:15 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Sat, 9 Mar 2024 03:54:15 GMT Subject: [jdk17u-dev] RFR: 8325326: [PPC64] Don't relocate in case of allocation failure Message-ID: Clean backport of [JDK-8325326](https://bugs.openjdk.org/browse/JDK-8325326). ------------- Commit messages: - Backport 4388095cde20dec602ada9fe2977f1a359ceab91 Changes: https://git.openjdk.org/jdk17u-dev/pull/2280/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2280&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325326 Stats: 12 lines in 1 file changed: 6 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2280.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2280/head:pull/2280 PR: https://git.openjdk.org/jdk17u-dev/pull/2280 From duke at openjdk.org Sat Mar 9 19:56:03 2024 From: duke at openjdk.org (Elif Aslan) Date: Sat, 9 Mar 2024 19:56:03 GMT Subject: [jdk17u-dev] RFR: 8303942: os::write should write completely In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 22:05:22 GMT, Paul Hohensee wrote: >> Hi all, >> >> This is not a clean backport and this pull request contains a backport of the closed bug [JDK-8273153](https://bugs.openjdk.org/browse/JDK-8273153) commit [ba5482d1a7a9](https://github.com/openjdk/jdk/commit/9732fbe428c3b6a5422cc94e7295ba5482d1a7a9). >> >> Ran jtreg tier-1 locally >> GHA [macos-x64 / test (hs/tier1 serviceability)] fails however it is infrastructure issue and unrelated from the current change. > > Hi, @elifaslan1. If you want to continue with this, I recommend splitting it into 3 backports, first [JDK-8273153](https://bugs.openjdk.org/browse/JDK-8273153), then [JDK-8303942](https://bugs.openjdk.org/browse/JDK-8303942), and finally [JDK-8316468](https://bugs.openjdk.org/browse/JDK-8316468). Much easier to review that way. First one is ready for approval: https://github.com/openjdk/jdk17u-dev/pull/2281 @phohensee ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1797#issuecomment-1986961402 From duke at openjdk.org Sat Mar 9 19:56:24 2024 From: duke at openjdk.org (Elif Aslan) Date: Sat, 9 Mar 2024 19:56:24 GMT Subject: [jdk17u-dev] RFR: 8273153: Consolidate file_exists into os:file_exists Message-ID: Clean backport to Consolidate file_exists into os:file_exists Additional testing in addition to GHA tests jtreg/tier2 ------------- Commit messages: - Backport 9732fbe428c3b6a5422cc94e7295ba5482d1a7a9 Changes: https://git.openjdk.org/jdk17u-dev/pull/2281/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2281&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273153 Stats: 26 lines in 4 files changed: 9 ins; 13 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2281.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2281/head:pull/2281 PR: https://git.openjdk.org/jdk17u-dev/pull/2281 From fyang at openjdk.org Mon Mar 11 01:37:57 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 11 Mar 2024 01:37:57 GMT Subject: [jdk21u-dev] RFR: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support [v2] In-Reply-To: References: <9QpsRx46Z81i8gfhceeZdBfhR7MZNutmsihst1_oBQ8=.d26e1de0-a67d-498e-9345-b5ee85113f24@github.com> Message-ID: On Thu, 7 Mar 2024 12:57:23 GMT, Ludovic Henry wrote: >> Ludovic Henry has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: >> >> - Merge branch 'master' of github.com:openjdk/jdk21u into backport-luhenry-68eb5a1d >> - Backport 68eb5a1df5afdc011aa467f1c723a8792532dd3f > > I can confirm that it builds fine locally. @luhenry : FYI: I think the GHA linux-cross-compile is back working again. So you might want to merge master and retrigger the GHA. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/294#issuecomment-1987476209 From andrewlu at openjdk.org Mon Mar 11 03:27:57 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 11 Mar 2024 03:27:57 GMT Subject: [jdk11u-dev] Withdrawn: 8248667: Need support for building native libraries located in the test/lib directory In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 08:34:05 GMT, Andrew Lu wrote: > Backport for JDK-8248194 and JDK-8248667 > CoreUtil.java: > add this code to fix the "Output doesn't contain the location of core file" assert error. > if(crashOutputString == null || crashOutputString.equals("")) { > return null; > } This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2580 From andrewlu at openjdk.org Mon Mar 11 05:11:10 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 11 Mar 2024 05:11:10 GMT Subject: [jdk11u-dev] RFR: 8248667: Need support for building native libraries located in the test/lib directory Message-ID: Backport for JDK-8248667 As make/Main.gmk still use the old format, make some change. ------------- Commit messages: - Backport 1356a0f1ac06b006a20ca9fa2306ef60aef5c16e Changes: https://git.openjdk.org/jdk11u-dev/pull/2590/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2590&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8248667 Stats: 150 lines in 4 files changed: 146 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2590.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2590/head:pull/2590 PR: https://git.openjdk.org/jdk11u-dev/pull/2590 From andrewlu at openjdk.org Mon Mar 11 05:30:08 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 11 Mar 2024 05:30:08 GMT Subject: [jdk11u-dev] RFR: 8248194: Need better support for running SA tests on core files Message-ID: Backport for JDK-8248194, depends on JDK-8248667 ------------- Commit messages: - Backport db2d4e8f5af1274d82242d3d86b922656954e1ef - Backport 1356a0f1ac06b006a20ca9fa2306ef60aef5c16e - Backport 1356a0f1ac06b006a20ca9fa2306ef60aef5c16e Changes: https://git.openjdk.org/jdk11u-dev/pull/2591/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2591&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8248194 Stats: 648 lines in 10 files changed: 471 ins; 137 del; 40 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2591.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2591/head:pull/2591 PR: https://git.openjdk.org/jdk11u-dev/pull/2591 From andrewlu at openjdk.org Mon Mar 11 05:43:18 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 11 Mar 2024 05:43:18 GMT Subject: [jdk21u-dev] RFR: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries Message-ID: <3Bjaw4xta4ORScO6-RPXThDta0guCRBb-HB99xC-aOc=.71cab34a-0ffb-488a-986b-682e4cdf97e4@github.com> I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 721bfee53af5bc2e2d67eebc7b82f09a642d5309 Changes: https://git.openjdk.org/jdk21u-dev/pull/345/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=345&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326891 Stats: 22 lines in 2 files changed: 8 ins; 3 del; 11 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/345.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/345/head:pull/345 PR: https://git.openjdk.org/jdk21u-dev/pull/345 From andrewlu at openjdk.org Mon Mar 11 05:44:04 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 11 Mar 2024 05:44:04 GMT Subject: [jdk17u-dev] RFR: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 721bfee53af5bc2e2d67eebc7b82f09a642d5309 Changes: https://git.openjdk.org/jdk17u-dev/pull/2282/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2282&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326891 Stats: 22 lines in 2 files changed: 8 ins; 3 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2282.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2282/head:pull/2282 PR: https://git.openjdk.org/jdk17u-dev/pull/2282 From andrewlu at openjdk.org Mon Mar 11 06:07:09 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 11 Mar 2024 06:07:09 GMT Subject: [jdk11u-dev] RFR: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 721bfee53af5bc2e2d67eebc7b82f09a642d5309 Changes: https://git.openjdk.org/jdk11u-dev/pull/2592/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2592&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326891 Stats: 22 lines in 2 files changed: 8 ins; 3 del; 11 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2592.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2592/head:pull/2592 PR: https://git.openjdk.org/jdk11u-dev/pull/2592 From andrewlu at openjdk.org Mon Mar 11 06:23:04 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 11 Mar 2024 06:23:04 GMT Subject: [jdk21u-dev] RFR: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport f1b73350c237021c04ceac2f29f1f378630bd651 Changes: https://git.openjdk.org/jdk21u-dev/pull/346/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=346&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320113 Stats: 45 lines in 1 file changed: 30 ins; 12 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/346.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/346/head:pull/346 PR: https://git.openjdk.org/jdk21u-dev/pull/346 From andrewlu at openjdk.org Mon Mar 11 06:24:03 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 11 Mar 2024 06:24:03 GMT Subject: [jdk17u-dev] RFR: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 Message-ID: <9KTGv8VgI2cva6TC1m8tvXDP67W8cqDtdadwn-fzrio=.2d79f885-30bd-4a28-9265-1ca424484d2d@github.com> I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport f1b73350c237021c04ceac2f29f1f378630bd651 Changes: https://git.openjdk.org/jdk17u-dev/pull/2283/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2283&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320113 Stats: 45 lines in 1 file changed: 30 ins; 12 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2283.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2283/head:pull/2283 PR: https://git.openjdk.org/jdk17u-dev/pull/2283 From andrewlu at openjdk.org Mon Mar 11 06:25:09 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 11 Mar 2024 06:25:09 GMT Subject: [jdk11u-dev] RFR: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport f1b73350c237021c04ceac2f29f1f378630bd651 Changes: https://git.openjdk.org/jdk11u-dev/pull/2593/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2593&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320113 Stats: 45 lines in 1 file changed: 30 ins; 12 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2593.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2593/head:pull/2593 PR: https://git.openjdk.org/jdk11u-dev/pull/2593 From goetz at openjdk.org Mon Mar 11 07:32:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Mar 2024 07:32:53 GMT Subject: [jdk21u-dev] RFR: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM In-Reply-To: References: Message-ID: On Tue, 27 Feb 2024 21:22:57 GMT, Amos Shi wrote: > Backport of [JDK-8266242](https://bugs.openjdk.org/browse/JDK-8266242) > > Testing > - ? Local: Test passed > - `CheckDisplayModes.java`: Test results: passed: 1 > > > MacBook Pro > 16-inch, 2021 > Chip Apple M1 Max > Memory: 32 GB > MacOS: 14.3.1 (23D60) > > > - ? Pipeline: All `GHA Sanity Checks` passed except `linux-cross-compile / build (riscv64)` > - ? It failed with message `Error: Unable to find an artifact with the name: bundles-linux-x64` > - ? This error is on Linux riscv64 - which not caused by current test case, because current PR is for `macOS 11 ARM` > - ? Testing Machine: SAP nightlies passed on `2024-03-01,02,05` Thanks for checking the tests! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/297#issuecomment-1987781140 From mbaesken at openjdk.org Mon Mar 11 08:11:59 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 11 Mar 2024 08:11:59 GMT Subject: [jdk21u-dev] Integrated: 8327059: os::Linux::print_proc_sys_info add swappiness information In-Reply-To: References: Message-ID: On Tue, 5 Mar 2024 14:45:07 GMT, Matthias Baesken wrote: > 8327059: os::Linux::print_proc_sys_info add swappiness information This pull request has now been integrated. Changeset: 83cc4cb5 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/83cc4cb50d1e10b72b81b246bc05d14601d35a33 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8327059: os::Linux::print_proc_sys_info add swappiness information Backport-of: f3b15abcb7dcd00158df84818965fc1282dcc1d9 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/329 From goetz.lindenmaier at sap.com Mon Mar 11 08:12:15 2024 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Mon, 11 Mar 2024 08:12:15 +0000 Subject: Result: New JDK Updates Committer: Amos Shi Message-ID: Voting [1] for Amos Shi (ashi [2]) is now closed. Yes: 11 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus [3], this is sufficient to approve the nomination. Best regards, Goetz. [1] https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-February/030182.html https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-March/030791.html [2] https://openjdk.org/census#ashi [3] https://openjdk.java.net/bylaws#three-vote-consensus -------------- next part -------------- An HTML attachment was scrubbed... URL: From lyang at openjdk.org Mon Mar 11 08:14:54 2024 From: lyang at openjdk.org (Long Yang) Date: Mon, 11 Mar 2024 08:14:54 GMT Subject: [jdk21u-dev] RFR: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate In-Reply-To: References: Message-ID: On Fri, 8 Mar 2024 06:35:43 GMT, Long Yang wrote: > Hi, all > > Could I have a review of this backport. > > This pull request contains a backport of commit [8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb](https://github.com/openjdk/jdk/commit/8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > Testing: I ran test/jdk/jdk/jfr/event/os/TestCPULoad.java and passed. All GHA tests are passed (except linux-cross-compile, build(riscv64), Create sysroot. It looks like there's an issue with the GHA's process). Could I have sponsor of this backport ? I would appreciate it very much. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/341#issuecomment-1987837837 From mbaesken at openjdk.org Mon Mar 11 08:17:56 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 11 Mar 2024 08:17:56 GMT Subject: [jdk21u-dev] Integrated: 8324834: Use _LARGE_FILES on AIX In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 08:18:25 GMT, Matthias Baesken wrote: > 8324834: Use _LARGE_FILES on AIX This pull request has now been integrated. Changeset: 3086ed88 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/3086ed886463ffe7250cc681c0f67f5aa5c47d6e Stats: 21 lines in 4 files changed: 4 ins; 0 del; 17 mod 8324834: Use _LARGE_FILES on AIX Backport-of: 8e45182357f4990c86fd0b711a7a91887945480b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/316 From lyang at openjdk.org Mon Mar 11 08:20:58 2024 From: lyang at openjdk.org (Long Yang) Date: Mon, 11 Mar 2024 08:20:58 GMT Subject: [jdk21u-dev] RFR: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate In-Reply-To: References: Message-ID: On Fri, 8 Mar 2024 06:35:43 GMT, Long Yang wrote: > Hi, all > > Could I have a review of this backport. > > This pull request contains a backport of commit [8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb](https://github.com/openjdk/jdk/commit/8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > Testing: I ran test/jdk/jdk/jfr/event/os/TestCPULoad.java and passed. All GHA tests are passed (except linux-cross-compile, build(riscv64), Create sysroot. It looks like there's an issue with the GHA's process). Thank you all. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/341#issuecomment-1987847939 From lyang at openjdk.org Mon Mar 11 08:20:59 2024 From: lyang at openjdk.org (Long Yang) Date: Mon, 11 Mar 2024 08:20:59 GMT Subject: [jdk21u-dev] Integrated: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate In-Reply-To: References: Message-ID: On Fri, 8 Mar 2024 06:35:43 GMT, Long Yang wrote: > Hi, all > > Could I have a review of this backport. > > This pull request contains a backport of commit [8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb](https://github.com/openjdk/jdk/commit/8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > Testing: I ran test/jdk/jdk/jfr/event/os/TestCPULoad.java and passed. All GHA tests are passed (except linux-cross-compile, build(riscv64), Create sysroot. It looks like there's an issue with the GHA's process). This pull request has now been integrated. Changeset: 50f447c5 Author: Long Yang Committer: Jie Fu URL: https://git.openjdk.org/jdk21u-dev/commit/50f447c5f4222ba81c366ea2710695f9e43f8624 Stats: 30 lines in 1 file changed: 1 ins; 7 del; 22 mod 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate Backport-of: 8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/341 From andrewlu at openjdk.org Mon Mar 11 08:24:01 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 11 Mar 2024 08:24:01 GMT Subject: [jdk17u-dev] RFR: 8314283: Support for NSS tests on aarch64 platforms Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 2a8016096000de5836251f2ca9bc8ad6479e6942 Changes: https://git.openjdk.org/jdk17u-dev/pull/2284/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2284&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314283 Stats: 41 lines in 2 files changed: 24 ins; 3 del; 14 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2284.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2284/head:pull/2284 PR: https://git.openjdk.org/jdk17u-dev/pull/2284 From mbaesken at openjdk.org Mon Mar 11 08:27:58 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 11 Mar 2024 08:27:58 GMT Subject: [jdk21u-dev] Integrated: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 14:01:08 GMT, Matthias Baesken wrote: > 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns This pull request has now been integrated. Changeset: c0b5fdf0 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/c0b5fdf0f23edaa6f82be2ff813777883e1eebf4 Stats: 99 lines in 1 file changed: 23 ins; 57 del; 19 mod 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns Backport-of: d9ef16dbb6917a4fff7711b32f3dd87611560dd1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/340 From luhenry at openjdk.org Mon Mar 11 08:30:09 2024 From: luhenry at openjdk.org (Ludovic Henry) Date: Mon, 11 Mar 2024 08:30:09 GMT Subject: [jdk21u-dev] RFR: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support [v3] In-Reply-To: References: Message-ID: > 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support Ludovic Henry has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' of github.com:openjdk/jdk21u into backport-luhenry-68eb5a1d - Merge branch 'master' of github.com:openjdk/jdk21u into backport-luhenry-68eb5a1d - Backport 68eb5a1df5afdc011aa467f1c723a8792532dd3f ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/294/files - new: https://git.openjdk.org/jdk21u-dev/pull/294/files/504dd88c..f4e25f80 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=294&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=294&range=01-02 Stats: 92 lines in 2 files changed: 85 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/294.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/294/head:pull/294 PR: https://git.openjdk.org/jdk21u-dev/pull/294 From andrewlu at openjdk.org Mon Mar 11 08:51:04 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 11 Mar 2024 08:51:04 GMT Subject: [jdk11u-dev] RFR: 8314283: Support for NSS tests on aarch64 platforms Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 2a8016096000de5836251f2ca9bc8ad6479e6942 Changes: https://git.openjdk.org/jdk11u-dev/pull/2594/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2594&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314283 Stats: 41 lines in 2 files changed: 24 ins; 3 del; 14 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2594.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2594/head:pull/2594 PR: https://git.openjdk.org/jdk11u-dev/pull/2594 From goetz at openjdk.org Mon Mar 11 08:55:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Mar 2024 08:55:54 GMT Subject: [jdk17u-dev] RFR: 8256660: Disable DTLS 1.0 In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 13:23:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. GHA-failure: known Risc-V infra issue. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2272#issuecomment-1987902400 From goetz at openjdk.org Mon Mar 11 08:56:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Mar 2024 08:56:54 GMT Subject: [jdk17u-dev] RFR: 8301381: Verify DTLS 1.0 cannot be negotiated In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 13:24:59 GMT, Goetz Lindenmaier wrote: > I backport this as follow-up of [JDK-8256660](https://bugs.openjdk.org/browse/JDK-8256660). GHA-failure: known Risc-V infra issue. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2273#issuecomment-1987905248 From goetz at openjdk.org Mon Mar 11 08:56:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Mar 2024 08:56:54 GMT Subject: [jdk17u-dev] RFR: 8319372: C2 compilation fails with "Bad immediate dominator info" In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 16:05:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > The change just removes one local optimization pattern in C2. > The change did not apply well as there are differences in comment > and whitespace, and a different error message. > > Code wise the outermost if() differs. > As the inner pattern matching is the same, the problem > exists similarly in 11. > > Tests pass. GHA-failure: known Risc-V infra issue. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2274#issuecomment-1987904995 From goetz at openjdk.org Mon Mar 11 09:07:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Mar 2024 09:07:56 GMT Subject: [jdk17u-dev] Integrated: 8291753: Add JFR event for GC CPU Time In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 16:09:37 GMT, Goetz Lindenmaier wrote: > I backport this as proposed before in https://github.com/openjdk/jdk17u-dev/pull/1900. Prereq changes are already done. > > The backport has been tested by [releaseing it in SapMachine in 17.0.10](https://github.com/SAP/SapMachine/commit/[1d275fd954aaaa6b1f4623d547e3edff46b97e84](https://github.com/SAP/SapMachine/commit/1d275fd954aaaa6b1f4623d547e3edff46b97e84)). This patch here is identical to the one in SapMachine. It will go to 17.0.12 giving enough time to settle. > > The g1 files needed several trivial resolves due to context differences. Especially variable do_maximum_compaction was renamed to do_maximal_compaction. This appears several times in the context. > > Further trivial resolves in > src/hotspot/share/gc/serial/defNewGeneration.hpp > src/hotspot/share/gc/shared/gcTrace.hpp > src/hotspot/share/gc/shared/genCollectedHeap.cpp > > src/jdk.jfr/share/conf/jfr/profile.jfc > The whitespace fix is not needed in 17. Omitted. This pull request has now been integrated. Changeset: 833e2bb5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/833e2bb504a69162f7f4b38255948b0c79ee7e61 Stats: 217 lines in 23 files changed: 163 ins; 2 del; 52 mod 8291753: Add JFR event for GC CPU Time Reviewed-by: phh Backport-of: 14eb5ad0dc987ffe3621f4eeeebeb6b5a2cd691b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2270 From shade at openjdk.org Mon Mar 11 09:19:56 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 11 Mar 2024 09:19:56 GMT Subject: [jdk22u] Integrated: 8325730: StringBuilder.toString allocation for the empty String In-Reply-To: References: Message-ID: On Tue, 27 Feb 2024 15:17:21 GMT, Aleksey Shipilev wrote: > Clean backport to fix the regression introduced in JDK 19. This pull request has now been integrated. Changeset: b2275aac Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/b2275aac15d49a74651ca0560c04ba0e800af48b Stats: 25 lines in 4 files changed: 20 ins; 0 del; 5 mod 8325730: StringBuilder.toString allocation for the empty String Backport-of: d2590c69b4efe5aa2b48b08070e0dbafb04ef202 ------------- PR: https://git.openjdk.org/jdk22u/pull/70 From shade at openjdk.org Mon Mar 11 09:21:58 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 11 Mar 2024 09:21:58 GMT Subject: [jdk21u-dev] Integrated: 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 12:04:51 GMT, Aleksey Shipilev wrote: > Fixes the test when running with C1. Does not apply cleanly, because the relevant problemlist change is not applicable to jdk21u. We backported [JDK-8314838](https://bugs.openjdk.org/browse/JDK-8314838) to 21.0.3, which exposes us to this bug. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, C1, affected test fails without the patch, skipped with it > - [x] MacOS AArch64 server fastdebug, C2, affected test passes with the patch This pull request has now been integrated. Changeset: a75d19de Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/a75d19dea5272d58b5954ce8cd790c2038567865 Stats: 7 lines in 2 files changed: 3 ins; 0 del; 4 mod 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java Reviewed-by: phh Backport-of: 4a16d111b16e556f904fb80075631b8439a9482e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/339 From ashi at openjdk.org Mon Mar 11 09:24:55 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Mar 2024 09:24:55 GMT Subject: [jdk21u-dev] Integrated: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM In-Reply-To: References: Message-ID: On Tue, 27 Feb 2024 21:22:57 GMT, Amos Shi wrote: > Backport of [JDK-8266242](https://bugs.openjdk.org/browse/JDK-8266242) > > Testing > - ? Local: Test passed > - `CheckDisplayModes.java`: Test results: passed: 1 > > > MacBook Pro > 16-inch, 2021 > Chip Apple M1 Max > Memory: 32 GB > MacOS: 14.3.1 (23D60) > > > - ? Pipeline: All `GHA Sanity Checks` passed except `linux-cross-compile / build (riscv64)` > - ? It failed with message `Error: Unable to find an artifact with the name: bundles-linux-x64` > - ? This error is on Linux riscv64 - which not caused by current test case, because current PR is for `macOS 11 ARM` > - ? Testing Machine: SAP nightlies passed on `2024-03-01,02,05` This pull request has now been integrated. Changeset: 8f080669 Author: Amos Shi Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/8f08066962e7f38d7303d4648c22a6aa210926f8 Stats: 14 lines in 2 files changed: 11 ins; 1 del; 2 mod 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM Backport-of: f7d6d7a04faa704155ee8df33e7d344bb962566f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/297 From ashi at openjdk.org Mon Mar 11 09:27:00 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Mar 2024 09:27:00 GMT Subject: [jdk17u-dev] Integrated: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range In-Reply-To: References: Message-ID: <9pp38egSD7qwH6-P-RnAbg5GqEOaW3ssV_eAA3QPeo4=.6d1e6790-9757-49db-9fa5-11b0985a75ba@github.com> On Thu, 29 Feb 2024 01:26:35 GMT, Amos Shi wrote: > Backport of [JDK-8325137](https://bugs.openjdk.org/browse/JDK-8325137) > > Testing > - Local: Test passed > - `ThreadCpuTimeArray.java` - Test results: passed: 1 > - ? Pipeline: All `GHA Sanity Checks` passed except `linux-cross-compile / build (riscv64)` > - ? It failed with message `Error: Unable to find an artifact with the name: bundles-linux-x64` > - Testing Machine: SAP nightlies passed on `2024-03-01,02,03` This pull request has now been integrated. Changeset: f196e021 Author: Amos Shi Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/f196e0217f783871a9b99969d54cb4fd91cca38d Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range Backport-of: 91d8dac9cff5689abcf2fc8950b15d284f933afd ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2255 From ashi at openjdk.org Mon Mar 11 09:28:58 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Mar 2024 09:28:58 GMT Subject: [jdk17u-dev] Integrated: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 20:34:11 GMT, Amos Shi wrote: > Backport of [JDK-8317287](https://bugs.openjdk.org/browse/JDK-8317287) > > Testing > - ? Local: Test passed on MacOS `14.4 (23E214)` on `Apple M1 Max` > - `InterJVMGetDropSuccessTest.java` - Test results: passed: 1 > - ? Pipeline: All `GHA Sanity Checks` passed except `linux-cross-compile / build (riscv64)` > - ? It failed with message `Create sysroot: W: Failure while installing base packages.` > - ? This error is on `Linux riscv64` - which not caused by current test case, because current PR is for `macOS` > - ? Testing Machine: SAP nightlies passed on `2024-03-01,02,03` This pull request has now been integrated. Changeset: e148b999 Author: Amos Shi Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/e148b999d7e769562aef1a619a27ea1bd8fb4d35 Stats: 104 lines in 1 file changed: 40 ins; 38 del; 26 mod 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination Backport-of: cbfddf4e1d3ff8dddb95bcb9242b31c175b768fc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2253 From ashi at openjdk.org Mon Mar 11 09:28:58 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Mar 2024 09:28:58 GMT Subject: [jdk17u-dev] Integrated: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM In-Reply-To: References: Message-ID: On Tue, 27 Feb 2024 21:23:22 GMT, Amos Shi wrote: > Backport of [JDK-8266242](https://bugs.openjdk.org/browse/JDK-8266242) > - `src/java.desktop/macosx/native/libawt_lwawt/awt/CGraphicsDevice.m` - clean backport > - `test/jdk/ProblemList.txt` - this file has been ignored because the line does not exist > > Testing > - Local: Test passed > - `CheckDisplayModes.java`: Test results: passed: 1 > > > MacBook Pro > 16-inch, 2021 > Chip Apple M1 Max > Memory: 32 GB > MacOS: 14.3.1 (23D60) > > > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies passed on `2024-03-01,02,03` This pull request has now been integrated. Changeset: 4ba565cb Author: Amos Shi Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/4ba565cbc76ed267a5abf9b68d2b9d62cf3fd2b9 Stats: 13 lines in 1 file changed: 11 ins; 0 del; 2 mod 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM Reviewed-by: mdoerr Backport-of: f7d6d7a04faa704155ee8df33e7d344bb962566f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2245 From ashi at openjdk.org Mon Mar 11 09:29:01 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Mar 2024 09:29:01 GMT Subject: [jdk17u-dev] Integrated: 8315677: Open source few swing JFileChooser and other tests In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 19:22:29 GMT, Amos Shi wrote: > Backport of [JDK-8315677](https://bugs.openjdk.org/browse/JDK-8315677) > > Testing > - Local: Test passed > - `bug4624353.java` - Test results: passed: 1 > - `bug4673161.java` - Test results: no tests selected > - `bug4782168.java` - Test results: passed: 1 > - `bug4822331.java` - Test results: passed: 1 > - `bug4191835.java` - Test results: passed: 1 > - Pipeline: > - Testing Machine: SAP nightlies passed on `2024-03-01,02,03` This pull request has now been integrated. Changeset: 61fed7b0 Author: Amos Shi Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/61fed7b06721711022c5c827ea5d268e4a7e906f Stats: 360 lines in 5 files changed: 360 ins; 0 del; 0 mod 8315677: Open source few swing JFileChooser and other tests Backport-of: fe5ef5f20dcf647b4ca30963b42fa01449f0d9c0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2251 From rrich at openjdk.org Mon Mar 11 09:33:58 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Mon, 11 Mar 2024 09:33:58 GMT Subject: [jdk17u-dev] Integrated: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 09:17:26 GMT, Richard Reingruber wrote: > This pull request contains a backport of commit [ad1d3248](https://github.com/openjdk/jdk21u-dev/commit/ad1d32484a8130c9b641cff38c07e8544b3fd271) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > With the change the current thread switches to `WXWrite` mode before transitioning into the vm in `JVM_ENTRY_FROM_LEAF`. > > Testing: > `test/jdk/sun/nio/cs/FindDecoderBugs.java` with `-XX:+AssertWXAtThreadSync` > > The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC). > Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le. > > Thanks! This pull request has now been integrated. Changeset: f38add6f Author: Richard Reingruber URL: https://git.openjdk.org/jdk17u-dev/commit/f38add6f8d9c07442e5f6bb5c280a2d907b38b24 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 Backport-of: ad1d32484a8130c9b641cff38c07e8544b3fd271 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2269 From varadam at openjdk.org Mon Mar 11 09:40:26 2024 From: varadam at openjdk.org (Varada M) Date: Mon, 11 Mar 2024 09:40:26 GMT Subject: [jdk11u-dev] RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [43956686](https://github.com/openjdk/jdk17u-dev/commit/43956686c924658ee2d7866e46ee9f10d9595c35) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > > The commit being backported was authored by Jaikiran Pai on 16 Feb 2024 and was reviewed by Paul Hohensee. > > Thanks! Varada M has updated the pull request incrementally with one additional commit since the last revision: Backport 43956686c924658ee2d7866e46ee9f10d9595c35 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2531/files - new: https://git.openjdk.org/jdk11u-dev/pull/2531/files/e8184334..b192d63e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2531&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2531&range=00-01 Stats: 57 lines in 1 file changed: 27 ins; 8 del; 22 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2531.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2531/head:pull/2531 PR: https://git.openjdk.org/jdk11u-dev/pull/2531 From duke at openjdk.org Mon Mar 11 09:57:59 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Mon, 11 Mar 2024 09:57:59 GMT Subject: [jdk11u-dev] RFR: 8261404: Class.getReflectionFactory() is not thread-safe In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 10:56:08 GMT, Mar?a Arias de Reyna wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8261404 > 8261404: Class.getReflectionFactory() is not thread-safe > > Original commit https://github.com/openjdk/jdk/commit/905b7639424a0fa80f81f734f6fdae1b5018a14a I thought I already did it, sorry for the delay. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2554#issuecomment-1988017850 From duke at openjdk.org Mon Mar 11 10:02:58 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Mon, 11 Mar 2024 10:02:58 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: References: Message-ID: <7lix2GjSO8nEmL8yb3sZC91jOd7WMxZxBGu5IM7Xj9s=.32eb4497-e41e-4815-945b-5e7c8577c05e@github.com> On Mon, 26 Feb 2024 12:52:28 GMT, Mar?a Arias de Reyna wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8280377 MethodHandleProxies does not correctly invoke default methods with varags > > I applied the same fix that was applied to version 19 in https://github.com/openjdk/jdk/commit/a183bfb436a7dd998e602c2d16486e88c390fca1 Although I miss the bot saying something ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#issuecomment-1988027000 From duke at openjdk.org Mon Mar 11 10:05:57 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Mon, 11 Mar 2024 10:05:57 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 12:52:28 GMT, Mar?a Arias de Reyna wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8280377 MethodHandleProxies does not correctly invoke default methods with varags > > I applied the same fix that was applied to version 19 in https://github.com/openjdk/jdk/commit/a183bfb436a7dd998e602c2d16486e88c390fca1 Is that what you needed, bot? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#issuecomment-1988033678 From sgehwolf at openjdk.org Mon Mar 11 11:03:56 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 11 Mar 2024 11:03:56 GMT Subject: [jdk21u-dev] RFR: 8326685: Linux builds not reproducible if two builds configured in different build folders In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 16:59:28 GMT, Andrew Leonard wrote: > Backports the debug symbol mapping fix to ensure two builds built in different build output directories are identical. Failing RISC-V cross compile build in GHA is an infra problem. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/336#issuecomment-1988170742 From aleonard at openjdk.org Mon Mar 11 11:03:57 2024 From: aleonard at openjdk.org (Andrew Leonard) Date: Mon, 11 Mar 2024 11:03:57 GMT Subject: [jdk21u-dev] Integrated: 8326685: Linux builds not reproducible if two builds configured in different build folders In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 16:59:28 GMT, Andrew Leonard wrote: > Backports the debug symbol mapping fix to ensure two builds built in different build output directories are identical. This pull request has now been integrated. Changeset: e2858b5c Author: Andrew Leonard Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk21u-dev/commit/e2858b5c98797111cbfa4d4f5e9c7a5944b8175b Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod 8326685: Linux builds not reproducible if two builds configured in different build folders Backport-of: 3b90ddfefea36d9f7f08ff11cd0cb099aa32b02b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/336 From duke at openjdk.org Mon Mar 11 11:19:57 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Mon, 11 Mar 2024 11:19:57 GMT Subject: [jdk11u-dev] Integrated: 8261404: Class.getReflectionFactory() is not thread-safe In-Reply-To: References: Message-ID: <0JsADCIPbWBh_h81mWBJrG3VbfBrSLagv0wo9K5pHeU=.6bf44fe1-7233-4897-bb8e-0a99b711f648@github.com> On Mon, 26 Feb 2024 10:56:08 GMT, Mar?a Arias de Reyna wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8261404 > 8261404: Class.getReflectionFactory() is not thread-safe > > Original commit https://github.com/openjdk/jdk/commit/905b7639424a0fa80f81f734f6fdae1b5018a14a This pull request has now been integrated. Changeset: a26445db Author: Mar?a Arias de Reyna Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/a26445db3b1a98f3e5bae11dcf12e2ab4a20ff74 Stats: 7 lines in 1 file changed: 2 ins; 1 del; 4 mod 8261404: Class.getReflectionFactory() is not thread-safe Backport-of: 905b7639424a0fa80f81f734f6fdae1b5018a14a ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2554 From rkannathpari at openjdk.org Mon Mar 11 11:57:00 2024 From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad) Date: Mon, 11 Mar 2024 11:57:00 GMT Subject: [jdk22u] Integrated: 8187759: Background not refreshed when painting over a transparent JFrame In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 12:43:18 GMT, Renjith Kannath Pariyangad wrote: > Backporting the fix which fixes Background painting issue over a transparent JFrame. > Clean backport. This pull request has now been integrated. Changeset: 244c1d8d Author: Renjith Kannath Pariyangad Committer: Alexey Ivanov URL: https://git.openjdk.org/jdk22u/commit/244c1d8daa95fe27d2b3e2f57c102b94928a7445 Stats: 219 lines in 2 files changed: 219 ins; 0 del; 0 mod 8187759: Background not refreshed when painting over a transparent JFrame Backport-of: 04d43c435d3ede519df169053dd9d724aa2312eb ------------- PR: https://git.openjdk.org/jdk22u/pull/77 From goetz at openjdk.org Mon Mar 11 12:01:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Mar 2024 12:01:56 GMT Subject: [jdk11u-dev] RFR: 8292716: Configure should check that jtreg is of the required version In-Reply-To: <6OHALhQCeoDozdaMF0LJratZAMVTwjps5DPAUfJzeNU=.70b7a262-32d3-4bf1-aecc-cb9a0e708da8@github.com> References: <6OHALhQCeoDozdaMF0LJratZAMVTwjps5DPAUfJzeNU=.70b7a262-32d3-4bf1-aecc-cb9a0e708da8@github.com> Message-ID: On Thu, 7 Mar 2024 17:21:07 GMT, Goetz Lindenmaier wrote: > I backport this as prereq to raise the jtreg version. > > I had to resolve one hunk due to context. This is based on the commit to 17 including a follow up. Hi, yeah, 8292717 does not apply well to 11 at all. It would probably take quite some backports to level up the 11u make files... We probably should keep them up to date right from the beginning of an updates release. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2585#issuecomment-1988276438 From ashi at openjdk.org Mon Mar 11 12:18:59 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Mar 2024 12:18:59 GMT Subject: [jdk11u-dev] Integrated: 8307083: Open source some drag and drop tests 3 In-Reply-To: References: Message-ID: On Tue, 27 Feb 2024 22:22:15 GMT, Amos Shi wrote: > Backport of [JDK-8307083](https://bugs.openjdk.org/browse/JDK-8307083) > > Testing > - Local: Test passed > - `MissedDragEnterTest.java`: Test results: passed: 1 > - `ModalDialogDeadlockTest.java`: Test results: passed: 1 > - `ModalDialogOnDragDeadlockTest.java`: Test results: passed: 1 > - `ModalDialogOnDropDeadlockTest.java`: Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies passed on `2024-03-01,03` This pull request has now been integrated. Changeset: fbac37b7 Author: Amos Shi Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk11u-dev/commit/fbac37b73ce517f64fd7e679f8fde09cf66ad8c3 Stats: 895 lines in 4 files changed: 895 ins; 0 del; 0 mod 8307083: Open source some drag and drop tests 3 Backport-of: 1b154e4fd361103936f976db72e04b73aa7b1077 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2565 From ashi at openjdk.org Mon Mar 11 12:19:58 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Mar 2024 12:19:58 GMT Subject: [jdk11u-dev] Integrated: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 20:34:18 GMT, Amos Shi wrote: > Backport of [JDK-8317287](https://bugs.openjdk.org/browse/JDK-8317287) > > Testing > - Local: Test passed > - `InterJVMGetDropSuccessTest.java` - Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies passed on `2024-03-01,03` This pull request has now been integrated. Changeset: 9b408561 Author: Amos Shi Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk11u-dev/commit/9b4085619fffd871a74cee7f93bac67cf42b9cc0 Stats: 104 lines in 1 file changed: 40 ins; 38 del; 26 mod 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination Backport-of: cbfddf4e1d3ff8dddb95bcb9242b31c175b768fc ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2573 From ashi at openjdk.org Mon Mar 11 12:20:04 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Mar 2024 12:20:04 GMT Subject: [jdk11u-dev] Integrated: 8306941: Open source several datatransfer and dnd AWT tests In-Reply-To: References: Message-ID: On Tue, 27 Feb 2024 22:23:47 GMT, Amos Shi wrote: > Backport of [JDK-8306941](https://bugs.openjdk.org/browse/JDK-8306941) > > Testing > - Local: Test passed > - `MimeFormatsTest.java`: Test results: no tests selected > - `RemoveFlavorListenerTest.java`: Test results: passed: 1 > - `AutoscrollStopTest.java`: Test results: passed: 1 > - `ButtonReleaseTest.java`: Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies passed on `2024-03-01,03` This pull request has now been integrated. Changeset: cf9aa9be Author: Amos Shi Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk11u-dev/commit/cf9aa9be1631de55da7329ce4a1cc9bddd425723 Stats: 831 lines in 4 files changed: 831 ins; 0 del; 0 mod 8306941: Open source several datatransfer and dnd AWT tests Backport-of: 3d3eaed9133dbe728ca8e00a626d33f7e35ba9ff ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2566 From ashi at openjdk.org Mon Mar 11 12:21:04 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Mar 2024 12:21:04 GMT Subject: [jdk11u-dev] Integrated: 8315677: Open source few swing JFileChooser and other tests In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 19:19:40 GMT, Amos Shi wrote: > Backport of [JDK-8315677](https://bugs.openjdk.org/browse/JDK-8315677) > > Testing > - Local: Test passed > - `bug4624353.java` - Test results: passed: 1 > - `bug4673161.java` - Test results: no tests selected > - `bug4782168.java` - Test results: passed: 1 > - `bug4822331.java` - Test results: passed: 1 > - `bug4191835.java` - Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies passed on `2024-03-01,03` This pull request has now been integrated. Changeset: eb5ef842 Author: Amos Shi Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk11u-dev/commit/eb5ef84294e314efb7f2b179b7f187831ddb524b Stats: 360 lines in 5 files changed: 360 ins; 0 del; 0 mod 8315677: Open source few swing JFileChooser and other tests Backport-of: fe5ef5f20dcf647b4ca30963b42fa01449f0d9c0 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2571 From ashi at openjdk.org Mon Mar 11 12:23:56 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Mar 2024 12:23:56 GMT Subject: [jdk11u-dev] Integrated: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range In-Reply-To: <-e-YGasZnwaNlAymXYN846nFWXvfwr5QavNeQbhWXOk=.6dc3340c-d18b-4987-925b-2299f05e67d5@github.com> References: <-e-YGasZnwaNlAymXYN846nFWXvfwr5QavNeQbhWXOk=.6dc3340c-d18b-4987-925b-2299f05e67d5@github.com> Message-ID: On Thu, 29 Feb 2024 01:26:27 GMT, Amos Shi wrote: > Backport of [JDK-8325137](https://bugs.openjdk.org/browse/JDK-8325137) > > Testing > - Local: Test passed > - `ThreadCpuTimeArray.java` - Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies passed on `2024-03-01,03` This pull request has now been integrated. Changeset: e6cec8f1 Author: Amos Shi Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk11u-dev/commit/e6cec8f1a81e32860200ebdcaf506c37935531ba Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range Backport-of: 91d8dac9cff5689abcf2fc8950b15d284f933afd ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2575 From goetz at openjdk.org Mon Mar 11 12:43:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Mar 2024 12:43:58 GMT Subject: [jdk17u-dev] Integrated: 8256660: Disable DTLS 1.0 In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 13:23:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. This pull request has now been integrated. Changeset: dd94e203 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/dd94e203b0fbeb1144bd44f9d0c7cda0cf680c0c Stats: 56 lines in 3 files changed: 27 ins; 5 del; 24 mod 8256660: Disable DTLS 1.0 Backport-of: 16744b34498e7aac59caef8c9b1a3d4d15f8c22e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2272 From goetz at openjdk.org Mon Mar 11 12:45:59 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Mar 2024 12:45:59 GMT Subject: [jdk17u-dev] Integrated: 8301381: Verify DTLS 1.0 cannot be negotiated In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 13:24:59 GMT, Goetz Lindenmaier wrote: > I backport this as follow-up of [JDK-8256660](https://bugs.openjdk.org/browse/JDK-8256660). This pull request has now been integrated. Changeset: 2d8a3a8f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/2d8a3a8fc68c46754999b67293ba3722c965b2ce Stats: 320 lines in 1 file changed: 320 ins; 0 del; 0 mod 8301381: Verify DTLS 1.0 cannot be negotiated Backport-of: 18e2446420d3376acaa2652d70474c2d3a85e2ac ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2273 From goetz at openjdk.org Mon Mar 11 12:46:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 11 Mar 2024 12:46:58 GMT Subject: [jdk17u-dev] Integrated: 8319372: C2 compilation fails with "Bad immediate dominator info" In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 16:05:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > The change just removes one local optimization pattern in C2. > The change did not apply well as there are differences in comment > and whitespace, and a different error message. > > Code wise the outermost if() differs. > As the inner pattern matching is the same, the problem > exists similarly in 11. > > Tests pass. This pull request has now been integrated. Changeset: f8cfa358 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f8cfa3588d20992221619deedd94616cdc4df6f8 Stats: 231 lines in 4 files changed: 171 ins; 60 del; 0 mod 8319372: C2 compilation fails with "Bad immediate dominator info" Reviewed-by: phh Backport-of: 7766785098816cfcdae3479540cdc866c1ed18ad ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2274 From evergizova at openjdk.org Mon Mar 11 12:51:01 2024 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Mon, 11 Mar 2024 12:51:01 GMT Subject: [jdk11u-dev] Integrated: 8314220: Configurable InlineCacheBuffer size In-Reply-To: References: Message-ID: On Mon, 29 Jan 2024 21:05:03 GMT, Ekaterina Vergizova wrote: > I'd like to backport JDK-8314220 to 11u. > It allows to configure IC buffer size to avoid multiple ICBufferFull safepoints and possible performance degradation. > > 17u patch applies almost cleanly except for: > - minor context difference in icBuffer.cpp > - different method for experimental flag declaration in globals.hpp (JDK-8243208 is not in 11u) > The changes reapplied manually. This pull request has now been integrated. Changeset: c8ca55ba Author: Ekaterina Vergizova URL: https://git.openjdk.org/jdk11u-dev/commit/c8ca55bafa8137f48ccb184539e8fa4e609faa09 Stats: 11 lines in 4 files changed: 8 ins; 2 del; 1 mod 8314220: Configurable InlineCacheBuffer size Reviewed-by: phh Backport-of: a40d8d97e84d88d1a65aba81bfc09339be95e427 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2498 From varadam at openjdk.org Mon Mar 11 13:07:58 2024 From: varadam at openjdk.org (Varada M) Date: Mon, 11 Mar 2024 13:07:58 GMT Subject: [jdk11u-dev] RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 14:11:35 GMT, Goetz Lindenmaier wrote: >> Hi all, >> >> This pull request contains a backport of commit [43956686](https://github.com/openjdk/jdk17u-dev/commit/43956686c924658ee2d7866e46ee9f10d9595c35) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. >> >> The commit being backported was authored by Jaikiran Pai on 16 Feb 2024 and was reviewed by Paul Hohensee. >> >> Thanks! > > https://github.com/openjdk/jdk11u-dev/pull/2553 solves a similar issue. Hi @GoeLin, can you please review the changes. Test is passing now with jtreg 6.1 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2531#issuecomment-1988398063 From luhenry at openjdk.org Mon Mar 11 13:16:57 2024 From: luhenry at openjdk.org (Ludovic Henry) Date: Mon, 11 Mar 2024 13:16:57 GMT Subject: [jdk21u-dev] Integrated: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support In-Reply-To: References: Message-ID: On Tue, 27 Feb 2024 09:04:02 GMT, Ludovic Henry wrote: > 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support This pull request has now been integrated. Changeset: d4e336d4 Author: Ludovic Henry Committer: Robbin Ehn URL: https://git.openjdk.org/jdk21u-dev/commit/d4e336d4b70de9a74c62ccde5d5eb447a3bd5d9a Stats: 40 lines in 3 files changed: 39 ins; 0 del; 1 mod 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support Reviewed-by: rehn, fyang Backport-of: 68eb5a1df5afdc011aa467f1c723a8792532dd3f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/294 From mbaesken at openjdk.org Mon Mar 11 13:54:10 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 11 Mar 2024 13:54:10 GMT Subject: [jdk17u-dev] RFR: 8299858: [Metrics] Swap memory limit reported incorrectly when too large Message-ID: 8299858: [Metrics] Swap memory limit reported incorrectly when too large ------------- Commit messages: - Backport 64ddf9536f55fb81956ebde6dfc0a3c4147af371 Changes: https://git.openjdk.org/jdk17u-dev/pull/2285/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2285&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299858 Stats: 68 lines in 3 files changed: 65 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2285.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2285/head:pull/2285 PR: https://git.openjdk.org/jdk17u-dev/pull/2285 From jkern at openjdk.org Mon Mar 11 16:38:06 2024 From: jkern at openjdk.org (Joachim Kern) Date: Mon, 11 Mar 2024 16:38:06 GMT Subject: [jdk22u] Integrated: 8322943: runtime/CompressedOops/CompressedClassPointers.java fails on AIX In-Reply-To: References: Message-ID: <1wQ5LuKsvHPv5xEV5iAejJrJqSIV4VJn0RT8cIw5lus=.7f3db019-76b1-4c90-9893-df5b92aa2c08@github.com> On Fri, 8 Mar 2024 13:54:43 GMT, Joachim Kern wrote: > Hi all, > > This pull request contains a backport of commit [997e615c](https://github.com/openjdk/jdk/commit/997e615c69f4445d92e164b814ea3358659e93dc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Joachim Kern on 8 Mar 2024 and was reviewed by Guoxiong Li and Thomas Stuefe. > > Thanks! This pull request has now been integrated. Changeset: 9b52a009 Author: Joachim Kern Committer: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/9b52a0093980ed245a51e859d4f9ed94d90796b3 Stats: 44 lines in 4 files changed: 26 ins; 7 del; 11 mod 8322943: runtime/CompressedOops/CompressedClassPointers.java fails on AIX Backport-of: 997e615c69f4445d92e164b814ea3358659e93dc ------------- PR: https://git.openjdk.org/jdk22u/pull/92 From dlutker at openjdk.org Mon Mar 11 17:18:26 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Mon, 11 Mar 2024 17:18:26 GMT Subject: [jdk21u-dev] RFR: 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi [v2] In-Reply-To: References: Message-ID: > Backporting to 21 which also has the same issue. > > Ran tier1, 2, 3, 4 on linux aarch64 with -XX:+UseShenandoahGC as well as jcstress quick. Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-lutkerd-5d414da5 - Backport 5d414da50459b7a1e6f0f537ff3b318854b2c427 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/306/files - new: https://git.openjdk.org/jdk21u-dev/pull/306/files/b14b74d6..b4c06430 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=306&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=306&range=00-01 Stats: 2973 lines in 91 files changed: 2304 ins; 374 del; 295 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/306.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/306/head:pull/306 PR: https://git.openjdk.org/jdk21u-dev/pull/306 From ashi at openjdk.org Mon Mar 11 18:49:39 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Mar 2024 18:49:39 GMT Subject: [jdk17u-dev] RFR: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch [v2] In-Reply-To: References: Message-ID: > Backport of [JDK-8320943](https://bugs.openjdk.org/browse/JDK-8320943) > - This PR has two commits > - commit 1 is the backport of the original [commit](https://github.com/openjdk/jdk/commit/87516e29dc5015c4cab2c07c5539ad30f2768667) > - commit 2 is fixing the compile and runtime issue on Java 17. > - Compile issue fixed: on Java 17 the class is `jdk.test.lib.Platform` and `jdk.test.lib.OSVersion` > - Runtime issue fixed: on Java 17 there is no mime `wasm`, so we comment it out > - `wasm` exists in Java 21: https://github.com/openjdk/jdk21u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties > - `wasm` does not exists in Java 17: https://github.com/openjdk/jdk17u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties > - ? after [JDK-8297609](https://bugs.openjdk.org/browse/JDK-8297609) back ported to 17, `wasm` will be available > - So this is an unclean backport > > Testing > - Local: Test passed on Mac > - `Basic.java` - Test results: passed: 1 > > Mac machine > > > MacBook Pro > 16-inch, 2021 > Chip: Apple M1 Max > MacOS: 14.3.1 (23D60) > > > Windows machine: > > > Device name W-PW05T4AD > Processor 12th Gen Intel(R) Core(TM) i7-12800H 2.40 GHz > Installed RAM 64.0 GB (63.7 GB usable) > System type 64-bit operating system, x64-based processor > > > - ? Pipeline: All `GHA Sanity Checks` passed except `linux-cross-compile / build (riscv64)` > - ? It failed with message `Error: Unable to find an artifact with the name: bundles-linux-x64` > - ? This error is on Linux riscv64 - which not caused by current test case, because current PR is for `Windows` > > - Testing Machine: SAP nightlies passed on `2024-03-01,02,03` Amos Shi has updated the pull request incrementally with one additional commit since the last revision: 8297609: Add notes for wasm type ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2254/files - new: https://git.openjdk.org/jdk17u-dev/pull/2254/files/806bbcbd..a9891365 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2254&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2254&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2254.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2254/head:pull/2254 PR: https://git.openjdk.org/jdk17u-dev/pull/2254 From ashi at openjdk.org Mon Mar 11 18:51:06 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Mar 2024 18:51:06 GMT Subject: [jdk11u-dev] RFR: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch [v2] In-Reply-To: <4KD2zLHjEowaGglqoYXSXrX2alwlX3Xqfsly2SsFXbk=.fb63924b-1b90-435f-af0b-41baffe5aef0@github.com> References: <4KD2zLHjEowaGglqoYXSXrX2alwlX3Xqfsly2SsFXbk=.fb63924b-1b90-435f-af0b-41baffe5aef0@github.com> Message-ID: > Backport of [JDK-8320943](https://bugs.openjdk.org/browse/JDK-8320943) > - This PR has two commits > - commit 1 is the backport of the original [commit](https://github.com/openjdk/jdk/commit/87516e29dc5015c4cab2c07c5539ad30f2768667) > - commit 2 is fixing the compile and runtime issue on Java 17. > - Compile issue fixed: on Java 17 the class is `jdk.test.lib.Platform` and `jdk.test.lib.OSVersion` > - Runtime issue fixed: on Java 17 there is no mime `wasm`, so we comment it out > - `wasm` exists in Java 21: https://github.com/openjdk/jdk21u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties > - `wasm` does not exists in Java 11: https://github.com/openjdk/jdk11u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties > - So this is an unclean back port from jdk, but should be clean from jdk17u-dev > > Testing > - Local: Test passed on Mac > - `Basic.java` - Test results: passed: 1 > > Mac machine > > > MacBook Pro > 16-inch, 2021 > Chip: Apple M1 Max > MacOS: 14.3.1 (23D60) > > > Windows machine: > > > Device name W-PW05T4AD > Processor 12th Gen Intel(R) Core(TM) i7-12800H 2.40 GHz > Installed RAM 64.0 GB (63.7 GB usable) > System type 64-bit operating system, x64-based processor > > > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies passed on `2024-03-01,03` Amos Shi has updated the pull request incrementally with one additional commit since the last revision: 8297609: Add notes for wasm type ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2574/files - new: https://git.openjdk.org/jdk11u-dev/pull/2574/files/a3fe6e46..fffc9434 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2574&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2574&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2574.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2574/head:pull/2574 PR: https://git.openjdk.org/jdk11u-dev/pull/2574 From ashi at openjdk.org Mon Mar 11 19:04:19 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Mar 2024 19:04:19 GMT Subject: [jdk17u-dev] RFR: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch [v2] In-Reply-To: References: Message-ID: On Fri, 8 Mar 2024 04:53:02 GMT, Martin Doerr wrote: >> Amos Shi has updated the pull request incrementally with one additional commit since the last revision: >> >> 8297609: Add notes for wasm type > > test/jdk/java/nio/file/Files/probeContentType/Basic.java line 188: > >> 186: exTypes.add(new ExType("xls", List.of("application/vnd.ms-excel"))); >> 187: exTypes.add(new ExType("xlsx", List.of("application/vnd.openxmlformats-officedocument.spreadsheetml.sheet"))); >> 188: // exTypes.add(new ExType("wasm", List.of("application/wasm"))); > > Ok, [JDK-8297609](https://bugs.openjdk.org/browse/JDK-8297609) is not in 17u. Can you add a comment explaining this, please? @TheRealMDoerr - Done ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2254#discussion_r1520285494 From ashi at openjdk.org Mon Mar 11 19:14:16 2024 From: ashi at openjdk.org (Amos Shi) Date: Mon, 11 Mar 2024 19:14:16 GMT Subject: [jdk11u-dev] RFR: 8248667: Need support for building native libraries located in the test/lib directory In-Reply-To: References: Message-ID: <6JwRUAuqhWswZ_aW2ESp9WbRvTefsqSjunJMmHvS5Pg=.713c89a8-dfff-4728-afbe-1bb33b66c695@github.com> On Mon, 11 Mar 2024 05:06:08 GMT, Andrew Lu wrote: > Backport for JDK-8248667 > As make/Main.gmk still use the old format, make some change. Others are clean. Related PR on the same 8248667 ticket: https://github.com/openjdk/jdk11u-dev/pull/2580 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2590#issuecomment-1989237899 From honkar at openjdk.org Mon Mar 11 20:10:25 2024 From: honkar at openjdk.org (Harshitha Onkar) Date: Mon, 11 Mar 2024 20:10:25 GMT Subject: [jdk22u] RFR: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653 Message-ID: Hi all, This pull request contains a backport of commit [d1e67636](https://github.com/openjdk/jdk/commit/d1e676360d5143cf12655ab1175a4a60bf402473) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Harshitha Onkar on 29 Jan 2024 and was reviewed by Phil Race and Tejesh R. Thanks! ------------- Commit messages: - Backport d1e676360d5143cf12655ab1175a4a60bf402473 Changes: https://git.openjdk.org/jdk22u/pull/94/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=94&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324733 Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/94.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/94/head:pull/94 PR: https://git.openjdk.org/jdk22u/pull/94 From prr at openjdk.org Mon Mar 11 20:27:12 2024 From: prr at openjdk.org (Phil Race) Date: Mon, 11 Mar 2024 20:27:12 GMT Subject: [jdk22u] RFR: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653 In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 20:04:53 GMT, Harshitha Onkar wrote: > Hi all, > > This pull request contains a backport of commit [d1e67636](https://github.com/openjdk/jdk/commit/d1e676360d5143cf12655ab1175a4a60bf402473) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Harshitha Onkar on 29 Jan 2024 and was reviewed by Phil Race and Tejesh R. > > Thanks! Marked as reviewed by prr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk22u/pull/94#pullrequestreview-1929164397 From duke at openjdk.org Mon Mar 11 21:53:19 2024 From: duke at openjdk.org (Jiawei Tang) Date: Mon, 11 Mar 2024 21:53:19 GMT Subject: [jdk11u-dev] Integrated: 8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id In-Reply-To: References: Message-ID: On Thu, 21 Dec 2023 08:19:32 GMT, Jiawei Tang wrote: > Threads which are in the state of `is_attaching_via_jni` may have the NULL object as their `_threadObj` . > So the JVM will crash when calling `JfrCheckpointThreadClosure::do_thread()`. This pull request has now been integrated. Changeset: 29f300eb Author: Jiawei Tang Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/29f300eb2ac4c038fad7f8e09eab8a53b69526c6 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2413 From phh at openjdk.org Mon Mar 11 22:21:13 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 11 Mar 2024 22:21:13 GMT Subject: [jdk17u-dev] RFR: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters In-Reply-To: References: Message-ID: <-0IpNfFxCKNoijRp7fdu1uWWRP5CZn0ZDX81UCgjPBo=.474cda8c-323d-4da0-b2a4-beee4e143454@github.com> On Fri, 8 Mar 2024 23:02:11 GMT, Amos Shi wrote: > Backport of [JDK-8320570](https://bugs.openjdk.org/browse/JDK-8320570) > - `NegativeSize.java` - Clean backport > - `String.java` - 3 sections change are unclean, the rest are clean. Details as bellow. > - This PR contains 2 commits > - The commit 1: is a clean backport part > - The commit 2: is a manual fix of the following 3 sections, > - Replace all `new byte[length << 1]` as `StringUTF16.newBytesFor(length)` > > > @@ -592,7 +592,7 @@ > this.coder = LATIN1; > return; > } > - byte[] utf16 = new byte[length << 1]; > + byte[] utf16 = StringUTF16.newBytesFor(length); > StringLatin1.inflate(latin1, 0, utf16, 0, dp); > dp = decodeUTF8_UTF16(latin1, sp, length, utf16, dp, true); > if (dp != length) { > > > > @@ -601,7 +601,7 @@ > this.value = utf16; > this.coder = UTF16; > } else { // !COMPACT_STRINGS > - byte[] dst = new byte[length << 1]; > + byte[] dst = StringUTF16.newBytesFor(length); > int dp = decodeUTF8_UTF16(bytes, offset, offset + length, dst, 0, true); > if (dp != length) { > dst = Arrays.copyOf(dst, dp << 1); > > > > @@ -730,15 +730,15 @@ > return new String(dst, LATIN1); > } > if (dp == 0) { > - dst = new byte[length << 1]; > + dst = StringUTF16.newBytesFor(length); > } else { > - byte[] buf = new byte[length << 1]; > + byte[] buf = StringUTF16.newBytesFor(length); > StringLatin1.inflate(dst, 0, buf, 0, dp); > dst = buf; > } > dp = decodeUTF8_UTF16(bytes, offset, sl, dst, dp, false); > } else { // !COMPACT_STRINGS > - dst = new byte[length << 1]; > + dst = StringUTF16.newBytesFor(length); > dp = decodeUTF8_UTF16(bytes, offset, offset + length, dst, 0, false); > } > if (dp != length) { > > > - So this PR can be considered as `semantics clean` > > > Testing > - Local: Passed on MacOS M1 laptop > - `test/jdk/java/lang/String/CompactString/NegativeSize.java` - Test results: passed: 1 > - Pipeline: > - Testing Machine: Marked as reviewed by phh (Reviewer). GHA failures appear to be infrastructure issues. ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2279#pullrequestreview-1929544388 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2279#issuecomment-1989543999 From phh at openjdk.org Mon Mar 11 22:23:13 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 11 Mar 2024 22:23:13 GMT Subject: [jdk21u-dev] RFR: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters In-Reply-To: <0JwXa6rEhkFcwmiFf7JJ5KyRyhnX45wXnMwU6EEnwx8=.426d3188-cf6f-4916-a038-8fa2890c574b@github.com> References: <0JwXa6rEhkFcwmiFf7JJ5KyRyhnX45wXnMwU6EEnwx8=.426d3188-cf6f-4916-a038-8fa2890c574b@github.com> Message-ID: On Fri, 8 Mar 2024 21:39:07 GMT, Amos Shi wrote: > Backport of [JDK-8320570](https://bugs.openjdk.org/browse/JDK-8320570) > - `NegativeSize.java` - Clean backport > - `String.java` - only 1 line change is unclean, the rest are clean. Details as bellow. > - This PR contains 2 commits > - The commit 1: is a clean backport part > - The commit 2: is a manual fix of the following 1 line: > - In the `jdk master` branch, the variable name is `utf16` > - Well in `jdk21u-dev`, the varialbe name is `buf` > - So we manully applied the following line > > > @@ -592,7 +592,7 @@ > this.coder = LATIN1; > return; > } > - byte[] utf16 = new byte[length << 1]; > + byte[] utf16 = StringUTF16.newBytesFor(length); > StringLatin1.inflate(latin1, 0, utf16, 0, dp); > dp = decodeUTF8_UTF16(latin1, sp, length, utf16, dp, true); > if (dp != length) { > > > > - So this PR can be considered as `semantics clean` > > > Testing > - Local: Passed on MacOS M1 laptop > - `test/jdk/java/lang/String/CompactString/NegativeSize.java` - Test results: passed: 1 > - Pipeline: > - Testing Machine: This PR duplicates https://github.com/openjdk/jdk21u-dev/pull/332. Please close it. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/344#issuecomment-1989547268 From szaldana at openjdk.org Mon Mar 11 22:25:23 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 11 Mar 2024 22:25:23 GMT Subject: [jdk21u-dev] Integrated: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters In-Reply-To: <-qKxc0To9o5aSuiwIrqcSe2UzM-L5qCRSo_pmGyX6oI=.40d264e6-6dfa-4484-b8db-8f306cc614db@github.com> References: <-qKxc0To9o5aSuiwIrqcSe2UzM-L5qCRSo_pmGyX6oI=.40d264e6-6dfa-4484-b8db-8f306cc614db@github.com> Message-ID: On Tue, 5 Mar 2024 19:02:47 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [82796bdebbf56b98ec97a6d572ed68c2842f60c6](https://github.com/openjdk/jdk/commit/82796bdebbf56b98ec97a6d572ed68c2842f60c6) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > Note, patch is not clean. > > The only difference between the original commit and this backport is the variable name ```utf16``` [(original commit)](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/String.java#L595) vs ```buf``` [(jdk21u state)](https://github.com/openjdk/jdk21u-dev/blob/master/src/java.base/share/classes/java/lang/String.java#L577). I coalesced those differences by keeping the ```buf``` variable name for jdk21u. > > > > Testing: Was able to verify behaviour with reproducer and added test case passes. > > Thanks! This pull request has now been integrated. Changeset: 779204c9 Author: Sonia Zaldana Calles Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/779204c941225f76aa85299bacfae59deccef082 Stats: 82 lines in 2 files changed: 75 ins; 0 del; 7 mod 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters Reviewed-by: phh Backport-of: 82796bdebbf56b98ec97a6d572ed68c2842f60c6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/332 From andrewlu at openjdk.org Tue Mar 12 02:20:22 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 02:20:22 GMT Subject: [jdk21u-dev] Integrated: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 06:13:34 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 7505194e Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/7505194e6b86fbda8af2eafb18b7667eec2d55ce Stats: 93 lines in 1 file changed: 93 ins; 0 del; 0 mod 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java Backport-of: 1f2922ad8526d378ee7b616e5423ce56f20340db ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/291 From andrewlu at openjdk.org Tue Mar 12 02:20:25 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 02:20:25 GMT Subject: [jdk17u-dev] Integrated: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 06:15:24 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: a14f8452 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/a14f8452974d58ab01e1b5ebadf73eb8cfcee9ff Stats: 93 lines in 1 file changed: 93 ins; 0 del; 0 mod 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java Backport-of: 1f2922ad8526d378ee7b616e5423ce56f20340db ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2231 From andrewlu at openjdk.org Tue Mar 12 02:25:20 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 02:25:20 GMT Subject: [jdk11u-dev] Integrated: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 06:17:30 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. This pull request has now been integrated. Changeset: 84ff9b3d Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/84ff9b3d1162b04cd4f0da8234e7755fe8568ebb Stats: 93 lines in 1 file changed: 93 ins; 0 del; 0 mod 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java Backport-of: 1f2922ad8526d378ee7b616e5423ce56f20340db ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2548 From andrewlu at openjdk.org Tue Mar 12 03:14:31 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 03:14:31 GMT Subject: [jdk21u-dev] RFR: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 8be3e39220cd64521f4e370011958e17e5fdeaf3 Changes: https://git.openjdk.org/jdk21u-dev/pull/347/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=347&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320129 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/347.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/347/head:pull/347 PR: https://git.openjdk.org/jdk21u-dev/pull/347 From andrewlu at openjdk.org Tue Mar 12 03:16:30 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 03:16:30 GMT Subject: [jdk17u-dev] RFR: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 8be3e39220cd64521f4e370011958e17e5fdeaf3 Changes: https://git.openjdk.org/jdk17u-dev/pull/2286/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2286&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320129 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2286.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2286/head:pull/2286 PR: https://git.openjdk.org/jdk17u-dev/pull/2286 From andrewlu at openjdk.org Tue Mar 12 03:19:17 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 03:19:17 GMT Subject: [jdk11u-dev] RFR: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 8be3e39220cd64521f4e370011958e17e5fdeaf3 Changes: https://git.openjdk.org/jdk11u-dev/pull/2597/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2597&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320129 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2597.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2597/head:pull/2597 PR: https://git.openjdk.org/jdk11u-dev/pull/2597 From alexsch at openjdk.org Tue Mar 12 07:14:21 2024 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Tue, 12 Mar 2024 07:14:21 GMT Subject: [jdk21u-dev] RFR: 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation Message-ID: 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation ------------- Commit messages: - Backport 91ffdfb1fcacbb95b93491d412e506695198946e Changes: https://git.openjdk.org/jdk21u-dev/pull/348/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=348&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320365 Stats: 20 lines in 1 file changed: 10 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/348.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/348/head:pull/348 PR: https://git.openjdk.org/jdk21u-dev/pull/348 From alexsch at openjdk.org Tue Mar 12 07:47:30 2024 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Tue, 12 Mar 2024 07:47:30 GMT Subject: [jdk21u-dev] RFR: 7001133: OutOfMemoryError by CustomMediaSizeName implementation Message-ID: The fix has been tested on Ubuntu and MacOS. The test `test/jdk/javax/print/CustomMediaSizeNameOOMETest.java` passes with the fix and fails without the fix. ------------- Commit messages: - Backport 10335f60f923aa4f315e64acb2bfd7bb06d47a1b Changes: https://git.openjdk.org/jdk21u-dev/pull/349/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=349&range=00 Issue: https://bugs.openjdk.org/browse/JDK-7001133 Stats: 173 lines in 5 files changed: 153 ins; 13 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/349.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/349/head:pull/349 PR: https://git.openjdk.org/jdk21u-dev/pull/349 From mbaesken at openjdk.org Tue Mar 12 08:50:34 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 12 Mar 2024 08:50:34 GMT Subject: [jdk22u] RFR: 8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case Message-ID: 8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case ------------- Commit messages: - Backport d0039960c4fdaf7704d06e1233865ea2e27a5d39 Changes: https://git.openjdk.org/jdk22u/pull/95/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=95&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325743 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/95.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/95/head:pull/95 PR: https://git.openjdk.org/jdk22u/pull/95 From goetz at openjdk.org Tue Mar 12 09:01:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 12 Mar 2024 09:01:20 GMT Subject: [jdk21u-dev] RFR: 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 07:10:07 GMT, Alexander Scherbatiy wrote: > 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation Hi @AlexanderScherbatiy please supply fix request comment as described in https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/348#issuecomment-1991078544 From mbaesken at openjdk.org Tue Mar 12 09:05:38 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 12 Mar 2024 09:05:38 GMT Subject: [jdk21u-dev] RFR: 8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case Message-ID: 8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case ------------- Commit messages: - Backport d0039960c4fdaf7704d06e1233865ea2e27a5d39 Changes: https://git.openjdk.org/jdk21u-dev/pull/350/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=350&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325743 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/350.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/350/head:pull/350 PR: https://git.openjdk.org/jdk21u-dev/pull/350 From andrewlu at openjdk.org Tue Mar 12 09:06:34 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 09:06:34 GMT Subject: [jdk17u-dev] RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 Message-ID: I backport this for parity with 17.0.11-oracle. depends on https://github.com/openjdk/jdk17u-dev/pull/2284 Follow 21-dev backport. ------------- Commit messages: - Backport 1f9b03e597d87679964e8772c6bea538c74feb2c - Backport 2a8016096000de5836251f2ca9bc8ad6479e6942 Changes: https://git.openjdk.org/jdk17u-dev/pull/2287/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2287&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319128 Stats: 83 lines in 6 files changed: 59 ins; 6 del; 18 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2287.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2287/head:pull/2287 PR: https://git.openjdk.org/jdk17u-dev/pull/2287 From shade at openjdk.org Tue Mar 12 09:08:34 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 12 Mar 2024 09:08:34 GMT Subject: [jdk21u-dev] RFR: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls [v2] In-Reply-To: References: Message-ID: > This resolves potentially catastrophic bug in monitor deflation. Thread dumps are routinely requested by profilers, so it is a real in-production risk. It would be more prominent as we backport improvements in monitor deflation code like [JDK-8319048](https://bugs.openjdk.org/browse/JDK-8319048). The interaction between deflation thread that can be stopped at safepoint in the middle of deflation and the VM op that deflates monitors itself may corrupt the VM state. > > This series of backports moves all deflation to monitor deflation thread, avoiding the issue. There are 4 interconnected issues, which are backported here atomically: > > - **[JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757): VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls.** The core part, deferring deflation to monitor deflation thread. The new test needs `-XX:+UnlockExperimentalVMOptions` to gain access to `-XX:LockingMode`. Otherwise applies cleanly. It needs JDK-8320515 as the followup. > - **[JDK-8319896](https://bugs.openjdk.org/browse/JDK-8319896): Remove monitor deflation from final audit.** Removes the remaining part that might call into deflation outside of monitor deflation thread. Applies cleanly. Makes JDK-8320515 backport clean. It needs JDK-8325437 as the followup. > - **[JDK-8320515](https://bugs.openjdk.org/browse/JDK-8320515): assert(monitor->object_peek() != nullptr) failed**. Owned monitors should not have a dead object. Follow-up for JDK-8318757, fixes the JNI interaction problem. Does not apply cleanly due to minor conflict in `JtregNativeHotspot.gmk`. > - **[JDK-8325437](https://bugs.openjdk.org/browse/JDK-8325437): Safepoint polling in monitor deflation can cause massive logs.** Followup for JDK-8319896, reducing the logs noise. > > @stefank -- it looks like you are tasked with backporting some of this to 21.0.4-oracle. Maybe you want to review this PR, which would also allow you to pick it up as commit later? :) > > Additional testing: > - [x] Linux x86_64 server fastdebug, `all` tests pass Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'master' into JDK-MULTI-deflation - Clean JDK-8325437: Safepoint polling in monitor deflation can cause massive logs Backport 52d497619e58a5677bc4a015b1bd87f600f23837 - Unclean JDK-8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object Conflicts in JtregNativeHotspot.gmk due to absent JDK-8311541 Reviewed-by: dholmes, ihse, sspitsyn, dcubed - Clean JDK-8319896: Remove monitor deflation from final audit Backport 369bbecc0dab389b523c09bc332fe1cf6394cb26 - Unclean JDK-8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls Needs -XX:+UnlockExperimentalVMOptions in new test Backport 87be6b69fe985eee01fc3344f9153d774db792c1 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/337/files - new: https://git.openjdk.org/jdk21u-dev/pull/337/files/b01c8a16..0706b0a5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=337&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=337&range=00-01 Stats: 3079 lines in 78 files changed: 2430 ins; 370 del; 279 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/337.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/337/head:pull/337 PR: https://git.openjdk.org/jdk21u-dev/pull/337 From goetz at openjdk.org Tue Mar 12 09:09:18 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 12 Mar 2024 09:09:18 GMT Subject: [jdk21u-dev] RFR: 8324646: Avoid Class.forName in SecureRandom constructor [v2] In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 13:53:21 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [8ef918d6](https://github.com/openjdk/jdk/commit/8ef918d6678437a5b351b172bb4cf144eeaa975f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev and Weijun Wang. >> >> Thanks! > > Oli Gillespie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into backport-olivergillespie-8ef918d6 > - Backport 8ef918d6678437a5b351b172bb4cf144eeaa975f @olivergillespie, please back port to 22, too, also, there are failing tests. removing the label ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/258#issuecomment-1991093040 From shade at openjdk.org Tue Mar 12 09:09:42 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 12 Mar 2024 09:09:42 GMT Subject: [jdk21u-dev] RFR: 8319650: Improve heap dump performance with class metadata caching [v4] In-Reply-To: <_Ib2XP8lK31x6lHk8Dk-F5w6ZD_C-yX9cTlbnBaqfTk=.60c3387a-dd78-4f70-9622-ca79e6321848@github.com> References: <_Ib2XP8lK31x6lHk8Dk-F5w6ZD_C-yX9cTlbnBaqfTk=.60c3387a-dd78-4f70-9622-ca79e6321848@github.com> Message-ID: <1aC3vtOh2uJ5OIPcdseKnCGIjxBU0Zy7y8i1gykSl78=.1c3a1233-81d6-488e-91d9-ef0358f552f5@github.com> > Transplanted from https://github.com/openjdk/jdk21u/pull/388 > > Unclean backport to improve heap dump performance. The uncleanliness comes from [JDK-8306441](https://bugs.openjdk.org/browse/JDK-8306441) that does not exist in JDK 21, and which I don't think we want to backport at the moment. I had to add a few more `ResourceMark`-s near `HeapDumpWriter` to manage the cache allocations. > > Additional testing: > - [x] MacOS AArch64 server release, heap dump performance improved > - [x] Linux x86_64 server fastdebug, serviceability/ (contains heap dump tests) > - [x] Linux x86_64 server fastdebug, runtime/ErrorHandling (contains heap dump on failure tests) > - [x] Linux x86_64 server fastdebug, gc/epsilon (contains heap dump on failure tests) > - [x] Linux x86_64 server fastdebug, sun/tools/jhsdb (contains heap dump tests) Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into JDK-8319650-heapdump-cache-class - Merge branch 'master' into JDK-8319650-heapdump-cache-class - Merge branch 'master' into JDK-8319650-heapdump-cache-class - Backport 03db82818b905f21cb5ad1d56a687e238b4a6e33 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/8/files - new: https://git.openjdk.org/jdk21u-dev/pull/8/files/4e13f967..6f08fd87 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=8&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=8&range=02-03 Stats: 1241 lines in 29 files changed: 1033 ins; 105 del; 103 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/8.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/8/head:pull/8 PR: https://git.openjdk.org/jdk21u-dev/pull/8 From shade at openjdk.org Tue Mar 12 09:09:50 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 12 Mar 2024 09:09:50 GMT Subject: [jdk21u-dev] RFR: 8318986: Improve GenericWaitBarrier performance [v3] In-Reply-To: References: Message-ID: > Clean backport to drastically improve safepoint performance under heavy load, fixing regression between JDK 11 and JDK 17. > > Additional testing: > - [x] Ad-hoc performance runs, expected improvements > - [x] MacOS AArch64 server fastdebug, `all` tests Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8318986-generic-wait-barrier - Backport 30462f9da40d3a7ec18fcf46e2154fabb5fd4753 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/70/files - new: https://git.openjdk.org/jdk21u-dev/pull/70/files/98149cc1..2aada3b9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=70&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=70&range=01-02 Stats: 3358 lines in 102 files changed: 2637 ins; 397 del; 324 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/70.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/70/head:pull/70 PR: https://git.openjdk.org/jdk21u-dev/pull/70 From shade at openjdk.org Tue Mar 12 09:10:50 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 12 Mar 2024 09:10:50 GMT Subject: [jdk21u-dev] RFR: 8327501: Common ForkJoinPool prevents class unloading in some cases [v2] In-Reply-To: References: Message-ID: > The change is stabilizing in mainline, but it looks simple, so we start testing it for JDK 21 pickup here. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `all` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8327501-fjp-classloader-leak - Backport 53c4714aab2e072ba18631875dcaa3b2d5d22243 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/338/files - new: https://git.openjdk.org/jdk21u-dev/pull/338/files/bce8bcfc..f17aeca1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=338&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=338&range=00-01 Stats: 3079 lines in 78 files changed: 2430 ins; 370 del; 279 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/338.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/338/head:pull/338 PR: https://git.openjdk.org/jdk21u-dev/pull/338 From goetz at openjdk.org Tue Mar 12 09:14:16 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 12 Mar 2024 09:14:16 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: References: Message-ID: <47M-EjUdhfKNt0IMFCTDN6jQppdOxuVPVC3Yb5u1gsI=.c7635419-d5cc-4557-88d6-36662cf4ce3f@github.com> On Tue, 5 Mar 2024 20:02:00 GMT, Mandy Chung wrote: > The backport looks good to me. This is the same fix for [JDK-8280377](https://bugs.openjdk.org/browse/JDK-8280377) and includes the regression test. Tier1-3 tests including this new regression test should provide adequate verification. Hi @Delawen, did you run some tests as e.g. proposed here? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#issuecomment-1991112365 From mbaesken at openjdk.org Tue Mar 12 09:16:28 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 12 Mar 2024 09:16:28 GMT Subject: [jdk22u] RFR: 8325432: enhance assert message "relocation addr must be in this section" Message-ID: 8325432: enhance assert message "relocation addr must be in this section" ------------- Commit messages: - Backport 3d3a8f0ebfafab6e67eb697ff0ec545bd9a51814 Changes: https://git.openjdk.org/jdk22u/pull/96/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=96&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325432 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/96.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/96/head:pull/96 PR: https://git.openjdk.org/jdk22u/pull/96 From andrewlu at openjdk.org Tue Mar 12 09:21:24 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 09:21:24 GMT Subject: [jdk11u-dev] RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 Message-ID: I backport this for parity with 11.0.24-oracle. depends on https://github.com/openjdk/jdk11u-dev/pull/2594 Follow 21-dev backport. test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java Backport to the origin file. ------------- Commit messages: - Backport 1f9b03e597d87679964e8772c6bea538c74feb2c - Backport 2a8016096000de5836251f2ca9bc8ad6479e6942 Changes: https://git.openjdk.org/jdk11u-dev/pull/2598/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2598&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319128 Stats: 83 lines in 6 files changed: 59 ins; 6 del; 18 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2598.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2598/head:pull/2598 PR: https://git.openjdk.org/jdk11u-dev/pull/2598 From mbaesken at openjdk.org Tue Mar 12 09:22:22 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 12 Mar 2024 09:22:22 GMT Subject: [jdk21u-dev] RFR: 8325432: enhance assert message "relocation addr must be in this section" Message-ID: 8325432: enhance assert message "relocation addr must be in this section" ------------- Commit messages: - Backport 3d3a8f0ebfafab6e67eb697ff0ec545bd9a51814 Changes: https://git.openjdk.org/jdk21u-dev/pull/351/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=351&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325432 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/351.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/351/head:pull/351 PR: https://git.openjdk.org/jdk21u-dev/pull/351 From andrewlu at openjdk.org Tue Mar 12 09:26:17 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 09:26:17 GMT Subject: [jdk21u-dev] Integrated: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 06:18:21 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: c8e9f1d5 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/c8e9f1d5d375b4594537147df05e28dda3347871 Stats: 45 lines in 1 file changed: 30 ins; 12 del; 3 mod 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 Backport-of: f1b73350c237021c04ceac2f29f1f378630bd651 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/346 From andrewlu at openjdk.org Tue Mar 12 09:26:16 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 09:26:16 GMT Subject: [jdk21u-dev] Integrated: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries In-Reply-To: <3Bjaw4xta4ORScO6-RPXThDta0guCRBb-HB99xC-aOc=.71cab34a-0ffb-488a-986b-682e4cdf97e4@github.com> References: <3Bjaw4xta4ORScO6-RPXThDta0guCRBb-HB99xC-aOc=.71cab34a-0ffb-488a-986b-682e4cdf97e4@github.com> Message-ID: <0b-AhoSpRlvBLI6Gems6HPEatHvsKyhQgpDw-nKFW8w=.df8a6323-30d4-47dc-9cbc-bf3c3f3f4877@github.com> On Mon, 11 Mar 2024 05:38:10 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 7f5afa18 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/7f5afa186af28396f9b24c9b6a880cb57ab5dbbe Stats: 22 lines in 2 files changed: 8 ins; 3 del; 11 mod 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries Backport-of: 721bfee53af5bc2e2d67eebc7b82f09a642d5309 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/345 From andrewlu at openjdk.org Tue Mar 12 09:26:22 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 09:26:22 GMT Subject: [jdk17u-dev] Integrated: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 In-Reply-To: <9KTGv8VgI2cva6TC1m8tvXDP67W8cqDtdadwn-fzrio=.2d79f885-30bd-4a28-9265-1ca424484d2d@github.com> References: <9KTGv8VgI2cva6TC1m8tvXDP67W8cqDtdadwn-fzrio=.2d79f885-30bd-4a28-9265-1ca424484d2d@github.com> Message-ID: On Mon, 11 Mar 2024 06:19:30 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: a22ac464 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/a22ac4643fdf3cc34022113334fc3e400e546482 Stats: 45 lines in 1 file changed: 30 ins; 12 del; 3 mod 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 Backport-of: f1b73350c237021c04ceac2f29f1f378630bd651 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2283 From andrewlu at openjdk.org Tue Mar 12 09:26:24 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 09:26:24 GMT Subject: [jdk11u-dev] Integrated: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 06:21:20 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. This pull request has now been integrated. Changeset: 21b88dba Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/21b88dba7fb33da2bc975cf7ac689ad5951ac90a Stats: 45 lines in 1 file changed: 30 ins; 12 del; 3 mod 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 Backport-of: f1b73350c237021c04ceac2f29f1f378630bd651 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2593 From andrewlu at openjdk.org Tue Mar 12 09:27:16 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 09:27:16 GMT Subject: [jdk11u-dev] Integrated: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 06:02:10 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. > Clean except the Copyright, so make it clean. This pull request has now been integrated. Changeset: 069fbd77 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/069fbd7770ecde71d9137df3c5ca378ffd6c0ae7 Stats: 22 lines in 2 files changed: 8 ins; 3 del; 11 mod 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries Backport-of: 721bfee53af5bc2e2d67eebc7b82f09a642d5309 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2592 From andrewlu at openjdk.org Tue Mar 12 09:27:21 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 09:27:21 GMT Subject: [jdk17u-dev] Integrated: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 05:39:18 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 0606e5ac Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/0606e5acb4c3cc84c72d9bbf8cba4adc0e58fac0 Stats: 22 lines in 2 files changed: 8 ins; 3 del; 11 mod 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries Backport-of: 721bfee53af5bc2e2d67eebc7b82f09a642d5309 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2282 From andrewlu at openjdk.org Tue Mar 12 09:28:16 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 09:28:16 GMT Subject: [jdk17u-dev] Integrated: 8314283: Support for NSS tests on aarch64 platforms In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 08:20:15 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 3433fdbf Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/3433fdbf1b8f17e42bbbb653ec7c97996734ecc7 Stats: 41 lines in 2 files changed: 24 ins; 3 del; 14 mod 8314283: Support for NSS tests on aarch64 platforms Backport-of: 2a8016096000de5836251f2ca9bc8ad6479e6942 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2284 From sgehwolf at openjdk.org Tue Mar 12 09:32:15 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 12 Mar 2024 09:32:15 GMT Subject: [jdk21u-dev] RFR: 8327501: Common ForkJoinPool prevents class unloading in some cases [v2] In-Reply-To: References: Message-ID: <2wBmyrfLiij-rq9PtiE2OEaua9bx6ORiq_nSGod3Vqk=.7f56115f-8aa5-447e-93ba-0c23b947a476@github.com> On Tue, 12 Mar 2024 09:10:50 GMT, Aleksey Shipilev wrote: >> The change is stabilizing in mainline, but it looks simple, so we start testing it for JDK 21 pickup here. >> >> Additional testing: >> - [x] Linux x86_64 server fastdebug, `all` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8327501-fjp-classloader-leak > - Backport 53c4714aab2e072ba18631875dcaa3b2d5d22243 Lets wait on getting this one backported until the compatibility impact wrt. setting the context class loader of a thread in the common pool is addressed. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/338#issuecomment-1991151488 From andrewlu at openjdk.org Tue Mar 12 09:33:35 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 09:33:35 GMT Subject: [jdk21u-dev] RFR: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 62c9530c056dbaaf65be0f43295af3d225326a4c Changes: https://git.openjdk.org/jdk21u-dev/pull/352/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=352&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324238 Stats: 38 lines in 1 file changed: 24 ins; 4 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/352.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/352/head:pull/352 PR: https://git.openjdk.org/jdk21u-dev/pull/352 From andrewlu at openjdk.org Tue Mar 12 09:35:24 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 09:35:24 GMT Subject: [jdk17u-dev] RFR: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 62c9530c056dbaaf65be0f43295af3d225326a4c Changes: https://git.openjdk.org/jdk17u-dev/pull/2288/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2288&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324238 Stats: 38 lines in 1 file changed: 24 ins; 4 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2288.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2288/head:pull/2288 PR: https://git.openjdk.org/jdk17u-dev/pull/2288 From andrewlu at openjdk.org Tue Mar 12 09:35:35 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 09:35:35 GMT Subject: [jdk11u-dev] RFR: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 62c9530c056dbaaf65be0f43295af3d225326a4c Changes: https://git.openjdk.org/jdk11u-dev/pull/2599/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2599&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324238 Stats: 38 lines in 1 file changed: 24 ins; 4 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2599.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2599/head:pull/2599 PR: https://git.openjdk.org/jdk11u-dev/pull/2599 From andrewlu at openjdk.org Tue Mar 12 09:39:36 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 12 Mar 2024 09:39:36 GMT Subject: [jdk17u-dev] RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 [v2] In-Reply-To: References: Message-ID: <3W-_4Fg6F6kbqXEm8ESLHOp0bWQaPSf2QvjVKyYZ65g=.dee2aee5-48c0-4492-a4af-e4467524adbb@github.com> > I backport this for parity with 17.0.11-oracle. > Follow 21-dev backport. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into andrewLu_backport_8319128_new # Conflicts: # test/jdk/sun/security/pkcs11/PKCS11Test.java - Backport 1f9b03e597d87679964e8772c6bea538c74feb2c - Backport 2a8016096000de5836251f2ca9bc8ad6479e6942 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2287/files - new: https://git.openjdk.org/jdk17u-dev/pull/2287/files/f0a3b1f7..2c6070b9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2287&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2287&range=00-01 Stats: 1464 lines in 44 files changed: 1225 ins; 120 del; 119 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2287.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2287/head:pull/2287 PR: https://git.openjdk.org/jdk17u-dev/pull/2287 From goetz at openjdk.org Tue Mar 12 10:17:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 12 Mar 2024 10:17:29 GMT Subject: [jdk17u] RFR: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 Message-ID: <4LPY3HzOnbjvI_ILaa3IU0Hn3D9BE483Z5CO92Qv3vU=.8888a222-5285-4936-8dd1-ced136a0c97e@github.com> Clean backport to fix regression of 17.0.9 ------------- Commit messages: - Backport f38add6f8d9c07442e5f6bb5c280a2d907b38b24 Changes: https://git.openjdk.org/jdk17u/pull/391/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=391&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327036 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u/pull/391.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/391/head:pull/391 PR: https://git.openjdk.org/jdk17u/pull/391 From stefank at openjdk.org Tue Mar 12 10:51:16 2024 From: stefank at openjdk.org (Stefan Karlsson) Date: Tue, 12 Mar 2024 10:51:16 GMT Subject: [jdk21u-dev] RFR: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls [v2] In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 09:08:34 GMT, Aleksey Shipilev wrote: >> This resolves potentially catastrophic bug in monitor deflation. Thread dumps are routinely requested by profilers, so it is a real in-production risk. It would be more prominent as we backport improvements in monitor deflation code like [JDK-8319048](https://bugs.openjdk.org/browse/JDK-8319048). The interaction between deflation thread that can be stopped at safepoint in the middle of deflation and the VM op that deflates monitors itself may corrupt the VM state. >> >> This series of backports moves all deflation to monitor deflation thread, avoiding the issue. There are 4 interconnected issues, which are backported here atomically: >> >> - **[JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757): VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls.** The core part, deferring deflation to monitor deflation thread. The new test needs `-XX:+UnlockExperimentalVMOptions` to gain access to `-XX:LockingMode`. Otherwise applies cleanly. It needs JDK-8320515 as the followup. >> - **[JDK-8319896](https://bugs.openjdk.org/browse/JDK-8319896): Remove monitor deflation from final audit.** Removes the remaining part that might call into deflation outside of monitor deflation thread. Applies cleanly. Makes JDK-8320515 backport clean. It needs JDK-8325437 as the followup. >> - **[JDK-8320515](https://bugs.openjdk.org/browse/JDK-8320515): assert(monitor->object_peek() != nullptr) failed**. Owned monitors should not have a dead object. Follow-up for JDK-8318757, fixes the JNI interaction problem. Does not apply cleanly due to minor conflict in `JtregNativeHotspot.gmk`. >> - **[JDK-8325437](https://bugs.openjdk.org/browse/JDK-8325437): Safepoint polling in monitor deflation can cause massive logs.** Followup for JDK-8319896, reducing the logs noise. >> >> @stefank -- it looks like you are tasked with backporting some of this to 21.0.4-oracle. Maybe you want to review this PR, which would also allow you to pick it up as commit later? :) >> >> Additional testing: >> - [x] Linux x86_64 server fastdebug, `all` tests pass > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'master' into JDK-MULTI-deflation > - Clean JDK-8325437: Safepoint polling in monitor deflation can cause massive logs > > Backport 52d497619e58a5677bc4a015b1bd87f600f23837 > - Unclean JDK-8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object > > Conflicts in JtregNativeHotspot.gmk due to absent JDK-8311541 > > Reviewed-by: dholmes, ihse, sspitsyn, dcubed > - Clean JDK-8319896: Remove monitor deflation from final audit > > Backport 369bbecc0dab389b523c09bc332fe1cf6394cb26 > - Unclean JDK-8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls > > Needs -XX:+UnlockExperimentalVMOptions in new test > > Backport 87be6b69fe985eee01fc3344f9153d774db792c1 > @stefank -- it looks like you are tasked with backporting some of this to 21.0.4-oracle. Maybe you want to review this PR, which would also allow you to pick it up as commit later? :) Yes, these are essentially the same patches that I've been testing for 21.0.4-oracle. ------------- Marked as reviewed by stefank (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/337#pullrequestreview-1930706131 From shade at openjdk.org Tue Mar 12 11:22:15 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 12 Mar 2024 11:22:15 GMT Subject: [jdk21u-dev] RFR: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls [v2] In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 10:48:23 GMT, Stefan Karlsson wrote: > > @stefank -- it looks like you are tasked with backporting some of this to 21.0.4-oracle. Maybe you want to review this PR, which would also allow you to pick it up as commit later? :) > > Yes, these are essentially the same patches that I've been testing for 21.0.4-oracle. OK, great, thanks for looking. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/337#issuecomment-1991412838 From mbaesken at openjdk.org Tue Mar 12 11:43:42 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 12 Mar 2024 11:43:42 GMT Subject: [jdk22u] RFR: 8326496: [test] checkHsErrFileContent support printing hserr in error case Message-ID: 8326496: [test] checkHsErrFileContent support printing hserr in error case ------------- Commit messages: - Backport a065eba56de01f4492123c6663ec0c3108d907a1 Changes: https://git.openjdk.org/jdk22u/pull/97/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=97&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326496 Stats: 63 lines in 2 files changed: 55 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk22u/pull/97.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/97/head:pull/97 PR: https://git.openjdk.org/jdk22u/pull/97 From mbaesken at openjdk.org Tue Mar 12 11:46:20 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 12 Mar 2024 11:46:20 GMT Subject: [jdk21u-dev] RFR: 8326496: [test] checkHsErrFileContent support printing hserr in error case Message-ID: 8326496: [test] checkHsErrFileContent support printing hserr in error case ------------- Commit messages: - Backport a065eba56de01f4492123c6663ec0c3108d907a1 Changes: https://git.openjdk.org/jdk21u-dev/pull/353/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=353&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326496 Stats: 63 lines in 2 files changed: 55 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/353.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/353/head:pull/353 PR: https://git.openjdk.org/jdk21u-dev/pull/353 From ogillespie at openjdk.org Tue Mar 12 11:47:28 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 12 Mar 2024 11:47:28 GMT Subject: [jdk21u-dev] RFR: 8324646: Avoid Class.forName in SecureRandom constructor [v3] In-Reply-To: References: Message-ID: <_-XyHBk-2GySpEp0Bp-Ti4HXPZFwf5lpgw_5SyuQiO8=.f7aa2b28-9fad-46bf-8d34-54d93602b682@github.com> > Hi all, > > This pull request contains a backport of commit [8ef918d6](https://github.com/openjdk/jdk/commit/8ef918d6678437a5b351b172bb4cf144eeaa975f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev and Weijun Wang. > > Thanks! Oli Gillespie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into backport-olivergillespie-8ef918d6 - Merge branch 'master' into backport-olivergillespie-8ef918d6 - Backport 8ef918d6678437a5b351b172bb4cf144eeaa975f ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/258/files - new: https://git.openjdk.org/jdk21u-dev/pull/258/files/39d16242..955b3a01 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=258&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=258&range=01-02 Stats: 3185 lines in 88 files changed: 2490 ins; 389 del; 306 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/258.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/258/head:pull/258 PR: https://git.openjdk.org/jdk21u-dev/pull/258 From ogillespie at openjdk.org Tue Mar 12 12:02:31 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 12 Mar 2024 12:02:31 GMT Subject: [jdk22u] RFR: 8324646: Avoid Class.forName in SecureRandom constructor Message-ID: <8221SG-dm8Iuqml37D_xTtqBqROKNSUo9rAICMI-RsM=.c7d9a702-0487-4775-8520-4ccdf0199a40@github.com> Hi all, This pull request contains a backport of commit [8ef918d6](https://github.com/openjdk/jdk/commit/8ef918d6678437a5b351b172bb4cf144eeaa975f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev and Weijun Wang. Thanks! ------------- Commit messages: - Backport 8ef918d6678437a5b351b172bb4cf144eeaa975f Changes: https://git.openjdk.org/jdk22u/pull/98/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=98&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324646 Stats: 61 lines in 2 files changed: 47 ins; 1 del; 13 mod Patch: https://git.openjdk.org/jdk22u/pull/98.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/98/head:pull/98 PR: https://git.openjdk.org/jdk22u/pull/98 From ogillespie at openjdk.org Tue Mar 12 12:03:20 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 12 Mar 2024 12:03:20 GMT Subject: [jdk22u] RFR: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG Message-ID: Hi all, This pull request contains a backport of commit [69b2674c](https://github.com/openjdk/jdk/commit/69b2674c6861fdb7d9f9cb39e07d50515c73e33a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev, Weijun Wang, Chen Liang and Valerie Peng. Thanks! ------------- Commit messages: - Backport 69b2674c6861fdb7d9f9cb39e07d50515c73e33a Changes: https://git.openjdk.org/jdk22u/pull/99/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=99&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324648 Stats: 16 lines in 1 file changed: 9 ins; 3 del; 4 mod Patch: https://git.openjdk.org/jdk22u/pull/99.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/99/head:pull/99 PR: https://git.openjdk.org/jdk22u/pull/99 From mdoerr at openjdk.org Tue Mar 12 12:08:20 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 12 Mar 2024 12:08:20 GMT Subject: [jdk17u-dev] RFR: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch [v2] In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 18:49:39 GMT, Amos Shi wrote: >> Backport of [JDK-8320943](https://bugs.openjdk.org/browse/JDK-8320943) >> - This PR has two commits >> - commit 1 is the backport of the original [commit](https://github.com/openjdk/jdk/commit/87516e29dc5015c4cab2c07c5539ad30f2768667) >> - commit 2 is fixing the compile and runtime issue on Java 17. >> - Compile issue fixed: on Java 17 the class is `jdk.test.lib.Platform` and `jdk.test.lib.OSVersion` >> - Runtime issue fixed: on Java 17 there is no mime `wasm`, so we comment it out >> - `wasm` exists in Java 21: https://github.com/openjdk/jdk21u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties >> - `wasm` does not exists in Java 17: https://github.com/openjdk/jdk17u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties >> - ? after [JDK-8297609](https://bugs.openjdk.org/browse/JDK-8297609) back ported to 17, `wasm` will be available >> - So this is an unclean backport >> >> Testing >> - Local: Test passed on Mac >> - `Basic.java` - Test results: passed: 1 >> >> Mac machine >> >> >> MacBook Pro >> 16-inch, 2021 >> Chip: Apple M1 Max >> MacOS: 14.3.1 (23D60) >> >> >> Windows machine: >> >> >> Device name W-PW05T4AD >> Processor 12th Gen Intel(R) Core(TM) i7-12800H 2.40 GHz >> Installed RAM 64.0 GB (63.7 GB usable) >> System type 64-bit operating system, x64-based processor >> >> >> - ? Pipeline: All `GHA Sanity Checks` passed except `linux-cross-compile / build (riscv64)` >> - ? It failed with message `Error: Unable to find an artifact with the name: bundles-linux-x64` >> - ? This error is on Linux riscv64 - which not caused by current test case, because current PR is for `Windows` >> >> - Testing Machine: SAP nightlies passed on `2024-03-01,02,03` > > Amos Shi has updated the pull request incrementally with one additional commit since the last revision: > > 8297609: Add notes for wasm type I would have spent a separate line, but ok. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2254#pullrequestreview-1930869193 From mdoerr at openjdk.org Tue Mar 12 12:18:22 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 12 Mar 2024 12:18:22 GMT Subject: [jdk21u-dev] Integrated: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 15:47:41 GMT, Martin Doerr wrote: > Clean backport of [JDK-8326101](https://bugs.openjdk.org/browse/JDK-8326101) from JDK 22u. This pull request has now been integrated. Changeset: 44fdfc7e Author: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/44fdfc7e91e66d16de89ba25e760e4e8a4deb871 Stats: 11 lines in 2 files changed: 9 ins; 0 del; 2 mod 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space Backport-of: e3ae81eeeee8e2b0063a576a90624dd927b512f0 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/312 From ogillespie at openjdk.org Tue Mar 12 12:24:14 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 12 Mar 2024 12:24:14 GMT Subject: [jdk22u] RFR: 8324646: Avoid Class.forName in SecureRandom constructor In-Reply-To: <8221SG-dm8Iuqml37D_xTtqBqROKNSUo9rAICMI-RsM=.c7d9a702-0487-4775-8520-4ccdf0199a40@github.com> References: <8221SG-dm8Iuqml37D_xTtqBqROKNSUo9rAICMI-RsM=.c7d9a702-0487-4775-8520-4ccdf0199a40@github.com> Message-ID: On Tue, 12 Mar 2024 11:57:31 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [8ef918d6](https://github.com/openjdk/jdk/commit/8ef918d6678437a5b351b172bb4cf144eeaa975f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev and Weijun Wang. > > Thanks! Benchmark results (`make test TEST=micro:org.openjdk.bench.java.security.SecureRandomBench`): Before: 2833 ? 61 ns/op After: 2229 ? 157 ns/op (note that this combines well with https://github.com/openjdk/jdk22u/pull/99 to bring the total down to ~100ns) ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/98#issuecomment-1991528182 From sroy at openjdk.org Tue Mar 12 12:26:18 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Tue, 12 Mar 2024 12:26:18 GMT Subject: [jdk21u-dev] Integrated: 8320005: Allow loading of shared objects with .a extension on AIX In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 08:45:34 GMT, Suchismith Roy wrote: > Hi all, > > This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. > > Thanks! This pull request has now been integrated. Changeset: c80be84c Author: Suchismith Roy Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/c80be84cdda88e83c32eae6e18f7dacc536e5383 Stats: 22 lines in 1 file changed: 20 ins; 1 del; 1 mod 8320005: Allow loading of shared objects with .a extension on AIX Backport-of: e85355ada4ac1061c49ee9f1247d37a437c7b5ab ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/335 From sroy at openjdk.org Tue Mar 12 12:26:21 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Tue, 12 Mar 2024 12:26:21 GMT Subject: [jdk22u] Integrated: 8320005: Allow loading of shared objects with .a extension on AIX In-Reply-To: References: Message-ID: <8dHhlJxtq0KbydLJICcoXBtUdTHz5nxr0gEqDd78pgk=.bafa19bc-c5f1-4985-a055-6e367541ec81@github.com> On Wed, 6 Mar 2024 08:00:07 GMT, Suchismith Roy wrote: > Hi all, > > This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. > > Thanks! This pull request has now been integrated. Changeset: 2e5c300b Author: Suchismith Roy Committer: Martin Doerr URL: https://git.openjdk.org/jdk22u/commit/2e5c300b31e461898efde5bc4f1265b0ecdcd5ac Stats: 22 lines in 1 file changed: 20 ins; 1 del; 1 mod 8320005: Allow loading of shared objects with .a extension on AIX Backport-of: e85355ada4ac1061c49ee9f1247d37a437c7b5ab ------------- PR: https://git.openjdk.org/jdk22u/pull/87 From mdoerr at openjdk.org Tue Mar 12 12:41:38 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 12 Mar 2024 12:41:38 GMT Subject: [jdk17u-dev] RFR: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space Message-ID: Clean backport of [JDK-8326101](https://bugs.openjdk.org/browse/JDK-8326101) from JDK 22u. ------------- Commit messages: - Backport e3ae81eeeee8e2b0063a576a90624dd927b512f0 Changes: https://git.openjdk.org/jdk17u-dev/pull/2289/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2289&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326101 Stats: 11 lines in 2 files changed: 9 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2289.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2289/head:pull/2289 PR: https://git.openjdk.org/jdk17u-dev/pull/2289 From mbaesken at openjdk.org Tue Mar 12 12:53:17 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 12 Mar 2024 12:53:17 GMT Subject: [jdk17u-dev] Integrated: 8299858: [Metrics] Swap memory limit reported incorrectly when too large In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 13:49:42 GMT, Matthias Baesken wrote: > 8299858: [Metrics] Swap memory limit reported incorrectly when too large This pull request has now been integrated. Changeset: b6325185 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/b6325185ed3bc5218289b3efc79289a20ee313d0 Stats: 68 lines in 3 files changed: 65 ins; 1 del; 2 mod 8299858: [Metrics] Swap memory limit reported incorrectly when too large Backport-of: 64ddf9536f55fb81956ebde6dfc0a3c4147af371 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2285 From szaldana at openjdk.org Tue Mar 12 13:20:23 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 12 Mar 2024 13:20:23 GMT Subject: [jdk11u-dev] RFR: 8219901: Noto fonts for East Asian countries cannot belong to CompositeFont In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 19:40:50 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [189e938d](https://github.com/openjdk/jdk/commit/189e938d3ab6984581c83a5996281ec436e0ac2e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Toshio Nakamura on 2 Jun 2019 and was reviewed by Phil Race and Jayathirth D V. > > Testing: original issue test case passes, all tests in ```test/jdk/java/awt/font/``` pass and tier 1 with GHA. > > > Thanks! Closing, as I missed regression introduced in [JDK-8264703](https://bugs.openjdk.org/browse/JDK-8264703). ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2586#issuecomment-1991631829 From szaldana at openjdk.org Tue Mar 12 13:20:23 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 12 Mar 2024 13:20:23 GMT Subject: [jdk11u-dev] Withdrawn: 8219901: Noto fonts for East Asian countries cannot belong to CompositeFont In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 19:40:50 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [189e938d](https://github.com/openjdk/jdk/commit/189e938d3ab6984581c83a5996281ec436e0ac2e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Toshio Nakamura on 2 Jun 2019 and was reviewed by Phil Race and Jayathirth D V. > > Testing: original issue test case passes, all tests in ```test/jdk/java/awt/font/``` pass and tier 1 with GHA. > > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2586 From goetz at openjdk.org Tue Mar 12 13:44:17 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 12 Mar 2024 13:44:17 GMT Subject: [jdk11u-dev] Integrated: 8292716: Configure should check that jtreg is of the required version In-Reply-To: <6OHALhQCeoDozdaMF0LJratZAMVTwjps5DPAUfJzeNU=.70b7a262-32d3-4bf1-aecc-cb9a0e708da8@github.com> References: <6OHALhQCeoDozdaMF0LJratZAMVTwjps5DPAUfJzeNU=.70b7a262-32d3-4bf1-aecc-cb9a0e708da8@github.com> Message-ID: On Thu, 7 Mar 2024 17:21:07 GMT, Goetz Lindenmaier wrote: > I backport this as prereq to raise the jtreg version. > > I had to resolve one hunk due to context. This is based on the commit to 17 including a follow up. This pull request has now been integrated. Changeset: 5cf250f1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/5cf250f14f78832d0b58de42c9c998ed49c040b8 Stats: 21 lines in 1 file changed: 21 ins; 0 del; 0 mod 8292716: Configure should check that jtreg is of the required version 8292763: JDK-8292716 breaks configure without jtreg Reviewed-by: phh, shade Backport-of: 9288072655a689c06a03f85c976bbd2f0744d3d5 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2585 From mbaesken at openjdk.org Tue Mar 12 13:48:23 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 12 Mar 2024 13:48:23 GMT Subject: [jdk17u-dev] RFR: 8324598: use mem_unit when working with sysinfo memory and swap related information Message-ID: 8324598: use mem_unit when working with sysinfo memory and swap related information ------------- Commit messages: - Backport 7a798d3cebea0915f8a73af57333b3488c2091af Changes: https://git.openjdk.org/jdk17u-dev/pull/2290/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2290&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324598 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2290.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2290/head:pull/2290 PR: https://git.openjdk.org/jdk17u-dev/pull/2290 From lucy at openjdk.org Tue Mar 12 13:51:21 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Tue, 12 Mar 2024 13:51:21 GMT Subject: [jdk11u-dev] RFR: 8314283: Support for NSS tests on aarch64 platforms In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 08:46:26 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. > test/jdk/sun/security/pkcs11/PKCS11Test.java > Clean except some added code lines are different. Looks good to me. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2594#pullrequestreview-1931119302 From lucy at openjdk.org Tue Mar 12 13:55:20 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Tue, 12 Mar 2024 13:55:20 GMT Subject: [jdk11u-dev] RFR: 8248667: Need support for building native libraries located in the test/lib directory In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 05:06:08 GMT, Andrew Lu wrote: > Backport for JDK-8248667 > As make/Main.gmk still use the old format, make some change. Others are clean. Looks good. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2590#pullrequestreview-1931132818 From tschatzl at openjdk.org Tue Mar 12 16:44:19 2024 From: tschatzl at openjdk.org (Thomas Schatzl) Date: Tue, 12 Mar 2024 16:44:19 GMT Subject: [jdk22u] Integrated: 8322484: 22-b26 Regression in J2dBench-bimg_misc-G1 (and more) on Windows-x64 and macOS-x64 In-Reply-To: References: Message-ID: On Tue, 30 Jan 2024 09:13:24 GMT, Thomas Schatzl wrote: > Hi all, > > This pull request contains a backport of commit [0d5f5e15](https://github.com/openjdk/jdk/commit/0d5f5e15d43f94a79c6133baecd5af217365d176) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Thomas Schatzl on 29 Jan 2024 and was reviewed by Kim Barrett and Albert Mingkun Yang. > > Applied cleanly. Thanks! > > Thomas This pull request has now been integrated. Changeset: a99aa0e2 Author: Thomas Schatzl URL: https://git.openjdk.org/jdk22u/commit/a99aa0e2b94ab3921220e456149a2468f3e87a5a Stats: 178 lines in 13 files changed: 157 ins; 2 del; 19 mod 8322484: 22-b26 Regression in J2dBench-bimg_misc-G1 (and more) on Windows-x64 and macOS-x64 Backport-of: 0d5f5e15d43f94a79c6133baecd5af217365d176 ------------- PR: https://git.openjdk.org/jdk22u/pull/36 From goetz at openjdk.org Tue Mar 12 17:08:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 12 Mar 2024 17:08:32 GMT Subject: [jdk21u-dev] RFR: 8326360: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3 Message-ID: I backport this to keep this external lib up to date and to match OracleJDK. Consists of three clean backports. I want to merge them here to limit the effort of further backporting: 8315117: Update Zlib Data Compression Library to Version 1.3 8324632: Update Zlib Data Compression Library to Version 1.3.1 8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1 Will mark clean. ------------- Commit messages: - Backport 8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1 - Backport 8324632: Update Zlib Data Compression Library to Version 1.3.1 - Backport 8315117: Update Zlib Data Compression Library to Version 1.3 Changes: https://git.openjdk.org/jdk21u-dev/pull/355/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=355&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326360 Stats: 2220 lines in 26 files changed: 609 ins; 1036 del; 575 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/355.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/355/head:pull/355 PR: https://git.openjdk.org/jdk21u-dev/pull/355 From honkar at openjdk.org Tue Mar 12 17:17:20 2024 From: honkar at openjdk.org (Harshitha Onkar) Date: Tue, 12 Mar 2024 17:17:20 GMT Subject: [jdk22u] RFR: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653 In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 20:24:43 GMT, Phil Race wrote: >> Hi all, >> >> This pull request contains a backport of commit [d1e67636](https://github.com/openjdk/jdk/commit/d1e676360d5143cf12655ab1175a4a60bf402473) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Harshitha Onkar on 29 Jan 2024 and was reviewed by Phil Race and Tejesh R. >> >> Thanks! > > Marked as reviewed by prr (Reviewer). @prrace Requires a sponsor to push changes on jdk22u ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/94#issuecomment-1992163971 From goetz at openjdk.org Tue Mar 12 18:15:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 12 Mar 2024 18:15:20 GMT Subject: [jdk21u-dev] RFR: 8324632: Update Zlib Data Compression Library to Version 1.3.1 In-Reply-To: References: Message-ID: <42YQrivsfIqsvqTRiJbiCZAW4h62eMEMgIoL0wm8bNY=.cbe318e2-8698-4afc-a3b9-bcf2db1b0ddc@github.com> On Tue, 12 Mar 2024 17:04:27 GMT, Goetz Lindenmaier wrote: > I backport this to keep this external lib up to date and to match OracleJDK. > > Consists of three clean backports. I want to merge them here to limit the effort of further backporting: > > 8315117: Update Zlib Data Compression Library to Version 1.3 > 8324632: Update Zlib Data Compression Library to Version 1.3.1 > 8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1 > > Will mark clean. GHA test failure on linux-x86: Could not reserve enough space for 2097152KB object heap Should be unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/355#issuecomment-1992270019 From ashi at openjdk.org Tue Mar 12 18:53:24 2024 From: ashi at openjdk.org (Amos Shi) Date: Tue, 12 Mar 2024 18:53:24 GMT Subject: [jdk11u-dev] Integrated: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 23:45:44 GMT, Amos Shi wrote: > Backport of [JDK-8290203](https://bugs.openjdk.org/browse/JDK-8290203) > - This is a Semantics clean pull request > > Testing > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies passed on `2024-03-06` This pull request has now been integrated. Changeset: 1b3c570c Author: Amos Shi Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/1b3c570c605cfdada5b3531071f0c3fd4d843f6f Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all Backport-of: ce36f6ea855a7ede02df969e6bb599ac36ac04fe ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2582 From szaldana at openjdk.org Tue Mar 12 18:57:25 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 12 Mar 2024 18:57:25 GMT Subject: [jdk17u-dev] Integrated: 8315898: Open source swing JMenu tests In-Reply-To: References: Message-ID: <5qZG5WvO1OjSLSeR4E7nZpDRGPvhiY_LULUK4w6GSWs=.0086a053-51c3-478b-84af-cfb42be8cfd3@github.com> On Thu, 7 Mar 2024 19:07:04 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [fecd2fd8](https://github.com/openjdk/jdk/commit/fecd2fd8f26d0e8905a519e30e9aa171683c9df1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Abhishek Kumar on 13 Sep 2023 and was reviewed by Sergey Bylokhov. > > Thanks! This pull request has now been integrated. Changeset: 49c260d5 Author: Sonia Zaldana Calles Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/49c260d5a29cce678eb3f27ee0726414120ba39d Stats: 357 lines in 6 files changed: 357 ins; 0 del; 0 mod 8315898: Open source swing JMenu tests Backport-of: fecd2fd8f26d0e8905a519e30e9aa171683c9df1 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2275 From dlutker at openjdk.org Tue Mar 12 22:02:34 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Tue, 12 Mar 2024 22:02:34 GMT Subject: [jdk21u-dev] RFR: 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi [v3] In-Reply-To: References: Message-ID: <0KHT-geTWSMAi70B1XpiNmfRFugmlpcYur58Pz9Xz_w=.7c636217-f3b2-4e3e-a08a-652de06d104b@github.com> > Backporting to 21 which also has the same issue. > > Ran tier1, 2, 3, 4 on linux aarch64 with -XX:+UseShenandoahGC as well as jcstress quick. Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 5d414da50459b7a1e6f0f537ff3b318854b2c427 ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/306/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=306&range=02 Stats: 100 lines in 4 files changed: 99 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/306.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/306/head:pull/306 PR: https://git.openjdk.org/jdk21u-dev/pull/306 From dlutker at openjdk.org Tue Mar 12 22:25:31 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Tue, 12 Mar 2024 22:25:31 GMT Subject: [jdk21u-dev] RFR: 8294699: Launcher causes lingering busy cursor [v2] In-Reply-To: References: Message-ID: > Backport for parity with Oracle 21.0.4 Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-lutkerd-d3df3eb5 - Backport d3df3eb5d7f5537ade917db7a36caba028f94111 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/327/files - new: https://git.openjdk.org/jdk21u-dev/pull/327/files/d801f1c6..880271e9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=327&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=327&range=00-01 Stats: 3218 lines in 89 files changed: 2519 ins; 390 del; 309 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/327.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/327/head:pull/327 PR: https://git.openjdk.org/jdk21u-dev/pull/327 From ashi at openjdk.org Wed Mar 13 01:33:20 2024 From: ashi at openjdk.org (Amos Shi) Date: Wed, 13 Mar 2024 01:33:20 GMT Subject: [jdk21u-dev] Withdrawn: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters In-Reply-To: <0JwXa6rEhkFcwmiFf7JJ5KyRyhnX45wXnMwU6EEnwx8=.426d3188-cf6f-4916-a038-8fa2890c574b@github.com> References: <0JwXa6rEhkFcwmiFf7JJ5KyRyhnX45wXnMwU6EEnwx8=.426d3188-cf6f-4916-a038-8fa2890c574b@github.com> Message-ID: On Fri, 8 Mar 2024 21:39:07 GMT, Amos Shi wrote: > Backport of [JDK-8320570](https://bugs.openjdk.org/browse/JDK-8320570) > - `NegativeSize.java` - Clean backport > - `String.java` - only 1 line change is unclean, the rest are clean. Details as bellow. > - This PR contains 2 commits > - The commit 1: is a clean backport part > - The commit 2: is a manual fix of the following 1 line: > - In the `jdk master` branch, the variable name is `utf16` > - Well in `jdk21u-dev`, the varialbe name is `buf` > - So we manully applied the following line > > > @@ -592,7 +592,7 @@ > this.coder = LATIN1; > return; > } > - byte[] utf16 = new byte[length << 1]; > + byte[] utf16 = StringUTF16.newBytesFor(length); > StringLatin1.inflate(latin1, 0, utf16, 0, dp); > dp = decodeUTF8_UTF16(latin1, sp, length, utf16, dp, true); > if (dp != length) { > > > > - So this PR can be considered as `semantics clean` > > > Testing > - Local: Passed on MacOS M1 laptop > - `test/jdk/java/lang/String/CompactString/NegativeSize.java` - Test results: passed: 1 > - Pipeline: > - Testing Machine: This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/344 From honkar at openjdk.org Wed Mar 13 03:09:19 2024 From: honkar at openjdk.org (Harshitha Onkar) Date: Wed, 13 Mar 2024 03:09:19 GMT Subject: [jdk22u] Integrated: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653 In-Reply-To: References: Message-ID: <6TlucQQiQDFwdhYg_SWBHsZO7BVsOHSarjfSrXxBmLQ=.fe9bb70b-b89d-4853-b774-86b65e881ce3@github.com> On Mon, 11 Mar 2024 20:04:53 GMT, Harshitha Onkar wrote: > Hi all, > > This pull request contains a backport of commit [d1e67636](https://github.com/openjdk/jdk/commit/d1e676360d5143cf12655ab1175a4a60bf402473) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Harshitha Onkar on 29 Jan 2024 and was reviewed by Phil Race and Tejesh R. > > Thanks! This pull request has now been integrated. Changeset: 0c6f3bd1 Author: Harshitha Onkar Committer: Phil Race URL: https://git.openjdk.org/jdk22u/commit/0c6f3bd1a4250125600af34fc8099601c7153128 Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653 Reviewed-by: prr Backport-of: d1e676360d5143cf12655ab1175a4a60bf402473 ------------- PR: https://git.openjdk.org/jdk22u/pull/94 From yan at openjdk.org Wed Mar 13 07:45:15 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 13 Mar 2024 07:45:15 GMT Subject: [jdk11u-dev] RFR: 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 11:02:01 GMT, Sergey Nazarkin wrote: > I'd like to backport this changes as it fixes some custom launchers issue. The backport is not clean: > 1. [8234821](https://bugs.openjdk.org/browse/JDK-8234821) was not backported to jdk11, so *java_md_common.c* need manual adjusting. > 2. The test can't be started as it depends on whole jpackage test [pack](https://bugs.openjdk.org/browse/JDK-8268974). So I've removed it. > > The functionality was tested with simple > > cd ~/tools/bin > cp -r ~/jdk . > cp jdk/bin/java jdk/lib > jdk/lib/java -version > > > Without the patch it show the error > > Error: could not find libjava.so > Error: Could not find Java SE Runtime Environment. > > > jdk_tier2 is OK as well Marked as reviewed by yan (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2578#pullrequestreview-1933354254 From clanger at openjdk.org Wed Mar 13 08:09:41 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 13 Mar 2024 08:09:41 GMT Subject: [jdk17u-dev] RFR: 8313307: java/util/Formatter/Padding.java fails on some Locales Message-ID: Hi all, This pull request contains a backport of [JDK-8313307](https://bugs.openjdk.org/browse/JDK-8313307), commit [bd634d2e](https://github.com/openjdk/jdk21u-dev/commit/bd634d2ec77f0208a2db54bc00567777ee7c8661) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. The commit being backported was authored by Aleksey Shipilev on 15 Aug 2023 and had no reviewers. Thanks! ------------- Commit messages: - Backport bd634d2ec77f0208a2db54bc00567777ee7c8661 Changes: https://git.openjdk.org/jdk17u-dev/pull/2291/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2291&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313307 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2291.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2291/head:pull/2291 PR: https://git.openjdk.org/jdk17u-dev/pull/2291 From mbaesken at openjdk.org Wed Mar 13 08:23:16 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 13 Mar 2024 08:23:16 GMT Subject: [jdk21u-dev] Integrated: 8325432: enhance assert message "relocation addr must be in this section" In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 09:16:31 GMT, Matthias Baesken wrote: > 8325432: enhance assert message "relocation addr must be in this section" This pull request has now been integrated. Changeset: da02da7d Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/da02da7dd34420f381ed2a9dea5672624033d0f4 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8325432: enhance assert message "relocation addr must be in this section" Backport-of: 3d3a8f0ebfafab6e67eb697ff0ec545bd9a51814 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/351 From mbaesken at openjdk.org Wed Mar 13 08:23:30 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 13 Mar 2024 08:23:30 GMT Subject: [jdk22u] Integrated: 8325432: enhance assert message "relocation addr must be in this section" In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 09:11:30 GMT, Matthias Baesken wrote: > 8325432: enhance assert message "relocation addr must be in this section" This pull request has now been integrated. Changeset: b8fa7110 Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/b8fa71105dd23983513eebce475f26be7ad2621e Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8325432: enhance assert message "relocation addr must be in this section" Backport-of: 3d3a8f0ebfafab6e67eb697ff0ec545bd9a51814 ------------- PR: https://git.openjdk.org/jdk22u/pull/96 From andrewlu at openjdk.org Wed Mar 13 08:25:17 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 13 Mar 2024 08:25:17 GMT Subject: [jdk21u-dev] Integrated: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 03:09:23 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 2a6688f6 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/2a6688f6cef382e6e5a5ed593f146755fb108b12 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX Backport-of: 8be3e39220cd64521f4e370011958e17e5fdeaf3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/347 From andrewlu at openjdk.org Wed Mar 13 08:25:17 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 13 Mar 2024 08:25:17 GMT Subject: [jdk17u-dev] Integrated: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 03:11:09 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 09ebd1cc Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/09ebd1cc11cf4581321172c59869e5a026770d97 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX Backport-of: 8be3e39220cd64521f4e370011958e17e5fdeaf3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2286 From andrewlu at openjdk.org Wed Mar 13 08:25:18 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 13 Mar 2024 08:25:18 GMT Subject: [jdk11u-dev] Integrated: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 03:13:22 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. This pull request has now been integrated. Changeset: a097faa9 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/a097faa97273b31400c356866f07319bd4be3194 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX Backport-of: 8be3e39220cd64521f4e370011958e17e5fdeaf3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2597 From andrewlu at openjdk.org Wed Mar 13 08:27:15 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 13 Mar 2024 08:27:15 GMT Subject: [jdk17u-dev] Integrated: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 08:59:10 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. > Follow 21-dev backport. This pull request has now been integrated. Changeset: 02ef1c72 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/02ef1c7264165434afe51fe675635593033edc56 Stats: 44 lines in 5 files changed: 35 ins; 3 del; 6 mod 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 8319136: Skip pkcs11 tests on linux-aarch64 Backport-of: 1f9b03e597d87679964e8772c6bea538c74feb2c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2287 From andrewlu at openjdk.org Wed Mar 13 08:34:16 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 13 Mar 2024 08:34:16 GMT Subject: [jdk11u-dev] Integrated: 8314283: Support for NSS tests on aarch64 platforms In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 08:46:26 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. > test/jdk/sun/security/pkcs11/PKCS11Test.java > Clean except some added code lines are different. This pull request has now been integrated. Changeset: 7de6f3f6 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/7de6f3f6ac1b2fe50a466b612718ed673aa70a19 Stats: 41 lines in 2 files changed: 24 ins; 3 del; 14 mod 8314283: Support for NSS tests on aarch64 platforms Reviewed-by: lucy Backport-of: 2a8016096000de5836251f2ca9bc8ad6479e6942 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2594 From andrewlu at openjdk.org Wed Mar 13 08:34:19 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 13 Mar 2024 08:34:19 GMT Subject: [jdk11u-dev] Integrated: 8248667: Need support for building native libraries located in the test/lib directory In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 05:06:08 GMT, Andrew Lu wrote: > Backport for JDK-8248667 > As make/Main.gmk still use the old format, make some change. Others are clean. This pull request has now been integrated. Changeset: 1d102e8f Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/1d102e8f8afab928195550534110213ee31ace2e Stats: 150 lines in 4 files changed: 146 ins; 1 del; 3 mod 8248667: Need support for building native libraries located in the test/lib directory Reviewed-by: lucy Backport-of: 1356a0f1ac06b006a20ca9fa2306ef60aef5c16e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2590 From andrewlu at openjdk.org Wed Mar 13 08:34:46 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 13 Mar 2024 08:34:46 GMT Subject: [jdk11u-dev] RFR: 8248194: Need better support for running SA tests on core files [v2] In-Reply-To: References: Message-ID: > Backport for JDK-8248194, depends on JDK-8248667 > test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java > There is only one test, so add the other core file test for the backport. > > test/lib/jdk/test/lib/SA/SATestUtils.java > the 'unzipCores' is not exist, no need to remove. > > Others clean. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into andrewLu_backport_8248194_new - Backport db2d4e8f5af1274d82242d3d86b922656954e1ef - Backport 1356a0f1ac06b006a20ca9fa2306ef60aef5c16e - Backport 1356a0f1ac06b006a20ca9fa2306ef60aef5c16e ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2591/files - new: https://git.openjdk.org/jdk11u-dev/pull/2591/files/1826ee64..b1295011 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2591&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2591&range=00-01 Stats: 2783 lines in 44 files changed: 2599 ins; 67 del; 117 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2591.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2591/head:pull/2591 PR: https://git.openjdk.org/jdk11u-dev/pull/2591 From goetz at openjdk.org Wed Mar 13 08:42:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 08:42:33 GMT Subject: [jdk17u] RFR: 8327391: Add SipHash attribution file Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport fcf48ab3d36a7f8eed84e81c3e2445adcbc95374 Changes: https://git.openjdk.org/jdk17u/pull/392/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=392&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327391 Stats: 150 lines in 1 file changed: 150 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u/pull/392.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/392/head:pull/392 PR: https://git.openjdk.org/jdk17u/pull/392 From goetz at openjdk.org Wed Mar 13 08:43:06 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 08:43:06 GMT Subject: [jdk21u] RFR: 8327391: Add SipHash attribution file Message-ID: I backport this for parity with 21.0.4-oracle. I backport this to 21.0.3 as in 17 and 11 it also reaches the April update. ------------- Commit messages: - Backport fcf48ab3d36a7f8eed84e81c3e2445adcbc95374 Changes: https://git.openjdk.org/jdk21u/pull/442/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=442&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327391 Stats: 150 lines in 1 file changed: 150 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/442.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/442/head:pull/442 PR: https://git.openjdk.org/jdk21u/pull/442 From goetz at openjdk.org Wed Mar 13 08:43:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 08:43:44 GMT Subject: [jdk11u] RFR: 8327391: Add SipHash attribution file Message-ID: <2ODj2IUVBNQLRtLNMKqYjvqSseX2feZBaXSHptmI5yU=.ae3cb36d-0f61-4938-9e21-c28e6ea06e7c@github.com> I backport this for parity with 11.0.23-oracle. ------------- Commit messages: - Backport fcf48ab3d36a7f8eed84e81c3e2445adcbc95374 Changes: https://git.openjdk.org/jdk11u/pull/90/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=90&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327391 Stats: 150 lines in 1 file changed: 150 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u/pull/90.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/90/head:pull/90 PR: https://git.openjdk.org/jdk11u/pull/90 From andrewlu at openjdk.org Wed Mar 13 08:49:41 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 13 Mar 2024 08:49:41 GMT Subject: [jdk11u-dev] RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.24-oracle. > > Follow 21-dev backport. > test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java > Backport to the origin file. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into andrewLu_backport_8319128 # Conflicts: # test/jdk/sun/security/pkcs11/PKCS11Test.java - Backport 1f9b03e597d87679964e8772c6bea538c74feb2c - Backport 2a8016096000de5836251f2ca9bc8ad6479e6942 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2598/files - new: https://git.openjdk.org/jdk11u-dev/pull/2598/files/63b585b8..200d1ed5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2598&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2598&range=00-01 Stats: 2892 lines in 46 files changed: 2721 ins; 65 del; 106 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2598.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2598/head:pull/2598 PR: https://git.openjdk.org/jdk11u-dev/pull/2598 From mbaesken at openjdk.org Wed Mar 13 08:55:20 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 13 Mar 2024 08:55:20 GMT Subject: [jdk22u] Integrated: 8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 08:44:32 GMT, Matthias Baesken wrote: > 8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case This pull request has now been integrated. Changeset: 6aa344a7 Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/6aa344a773a3743891afacf25304e42f13310378 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case Backport-of: d0039960c4fdaf7704d06e1233865ea2e27a5d39 ------------- PR: https://git.openjdk.org/jdk22u/pull/95 From mbaesken at openjdk.org Wed Mar 13 08:56:21 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 13 Mar 2024 08:56:21 GMT Subject: [jdk21u-dev] Integrated: 8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case In-Reply-To: References: Message-ID: <65nr8J4r247hVC-cFM5Ed5ZlAiMEz4PerFHfVvA5xTw=.bca61c83-1bc0-4154-8f9b-664363d3948e@github.com> On Tue, 12 Mar 2024 09:00:40 GMT, Matthias Baesken wrote: > 8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case This pull request has now been integrated. Changeset: d42da094 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/d42da094612e1651f2afcd08d16786b2f3bbdf43 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case Backport-of: d0039960c4fdaf7704d06e1233865ea2e27a5d39 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/350 From mbaesken at openjdk.org Wed Mar 13 09:02:14 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 13 Mar 2024 09:02:14 GMT Subject: [jdk17u-dev] Integrated: 8324598: use mem_unit when working with sysinfo memory and swap related information In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 13:44:08 GMT, Matthias Baesken wrote: > 8324598: use mem_unit when working with sysinfo memory and swap related information This pull request has now been integrated. Changeset: 64887254 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/64887254aef01956238d0975d0be3ed41e201bdd Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8324598: use mem_unit when working with sysinfo memory and swap related information Backport-of: 7a798d3cebea0915f8a73af57333b3488c2091af ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2290 From shade at openjdk.org Wed Mar 13 10:07:20 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 13 Mar 2024 10:07:20 GMT Subject: [jdk21u-dev] RFR: 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi [v3] In-Reply-To: <0KHT-geTWSMAi70B1XpiNmfRFugmlpcYur58Pz9Xz_w=.7c636217-f3b2-4e3e-a08a-652de06d104b@github.com> References: <0KHT-geTWSMAi70B1XpiNmfRFugmlpcYur58Pz9Xz_w=.7c636217-f3b2-4e3e-a08a-652de06d104b@github.com> Message-ID: On Tue, 12 Mar 2024 22:02:34 GMT, Dan Lutker wrote: >> Backporting to 21 which also has the same issue. >> >> Ran tier1, 2, 3, 4 on linux aarch64 with -XX:+UseShenandoahGC as well as jcstress quick. > > Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 5d414da50459b7a1e6f0f537ff3b318854b2c427 While the patch is still relatively new in mainline, I think this one is good to have earlier in 21u-dev. This is going to be additionally tested by our 21u pipelines, in addition to mainline testing. There is a GHA failure in x86_32 StringRepeat test, but it does not look relevant. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/306#pullrequestreview-1933668654 From ogillespie at openjdk.org Wed Mar 13 10:33:18 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Wed, 13 Mar 2024 10:33:18 GMT Subject: [jdk22u] RFR: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 11:57:59 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [69b2674c](https://github.com/openjdk/jdk/commit/69b2674c6861fdb7d9f9cb39e07d50515c73e33a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev, Weijun Wang, Chen Liang and Valerie Peng. > > Thanks! Benchmark results (make test TEST=micro:org.openjdk.bench.java.security.SecureRandomBench, pulling the benchmark from https://github.com/openjdk/jdk22u/pull/98): Before: 2972 ? 132 ns/op After: 490 ? 5 ns/op ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/99#issuecomment-1994058997 From mbaesken at openjdk.org Wed Mar 13 10:34:15 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 13 Mar 2024 10:34:15 GMT Subject: [jdk21u-dev] Integrated: 8326496: [test] checkHsErrFileContent support printing hserr in error case In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 11:41:57 GMT, Matthias Baesken wrote: > 8326496: [test] checkHsErrFileContent support printing hserr in error case This pull request has now been integrated. Changeset: 608c98de Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/608c98de87b0a2bce9e17395fe65f0f735ad0690 Stats: 63 lines in 2 files changed: 55 ins; 0 del; 8 mod 8326496: [test] checkHsErrFileContent support printing hserr in error case Backport-of: a065eba56de01f4492123c6663ec0c3108d907a1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/353 From mbaesken at openjdk.org Wed Mar 13 10:34:20 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 13 Mar 2024 10:34:20 GMT Subject: [jdk22u] Integrated: 8326496: [test] checkHsErrFileContent support printing hserr in error case In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 11:38:56 GMT, Matthias Baesken wrote: > 8326496: [test] checkHsErrFileContent support printing hserr in error case This pull request has now been integrated. Changeset: 82c3743e Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/82c3743eb06c7e329ffa737c1669ef41639e9d85 Stats: 63 lines in 2 files changed: 55 ins; 0 del; 8 mod 8326496: [test] checkHsErrFileContent support printing hserr in error case Backport-of: a065eba56de01f4492123c6663ec0c3108d907a1 ------------- PR: https://git.openjdk.org/jdk22u/pull/97 From ogillespie at openjdk.org Wed Mar 13 10:43:15 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Wed, 13 Mar 2024 10:43:15 GMT Subject: [jdk21u-dev] RFR: 8324646: Avoid Class.forName in SecureRandom constructor [v2] In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 09:06:08 GMT, Goetz Lindenmaier wrote: >> Oli Gillespie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: >> >> - Merge branch 'master' into backport-olivergillespie-8ef918d6 >> - Backport 8ef918d6678437a5b351b172bb4cf144eeaa975f > > @olivergillespie, please back port to 22, too, also, there are failing tests. removing the label Thanks, sorry @GoeLin for not understanding the backport procedure properly. I thought approval came first, before final testing/review etc., my mistake! Backport to 22 (approval requested): https://github.com/openjdk/jdk22u/pull/98 Tests are now passing after merging from master. Benchmark results (`make test TEST=micro:org.openjdk.bench.java.security.SecureRandomBench`): Before: 495 ? 6 ns/op After: 103 ? 1.6 ns/op Hopefully I didn't miss anything this time, so I'll request approval again - thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/258#issuecomment-1994079134 From goetz at openjdk.org Wed Mar 13 12:00:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 12:00:26 GMT Subject: [jdk17u-dev] RFR: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane Message-ID: <2DWL3Z0fm2fjAcCng0R8pH4VbpDCQfOPdYU74yObX3E=.82269e58-b000-4e05-adb4-c361dd04ec05@github.com> I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport 3b1062d45df69d4cf8479c6a65602bd2453ab885 Changes: https://git.openjdk.org/jdk17u-dev/pull/2292/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2292&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322239 Stats: 115 lines in 2 files changed: 111 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2292.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2292/head:pull/2292 PR: https://git.openjdk.org/jdk17u-dev/pull/2292 From goetz at openjdk.org Wed Mar 13 12:00:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 12:00:40 GMT Subject: [jdk21u-dev] RFR: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 3b1062d45df69d4cf8479c6a65602bd2453ab885 Changes: https://git.openjdk.org/jdk21u-dev/pull/356/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=356&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322239 Stats: 115 lines in 2 files changed: 111 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/356.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/356/head:pull/356 PR: https://git.openjdk.org/jdk21u-dev/pull/356 From goetz at openjdk.org Wed Mar 13 12:06:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 12:06:41 GMT Subject: [jdk11u-dev] RFR: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane Message-ID: I backport this for parity with 11.0.24-oracle. I resolved Copyright and import (actually unneeded) in JTabbedPane.java. ------------- Commit messages: - Backport 3b1062d45df69d4cf8479c6a65602bd2453ab885 Changes: https://git.openjdk.org/jdk11u-dev/pull/2601/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2601&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322239 Stats: 115 lines in 2 files changed: 111 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2601.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2601/head:pull/2601 PR: https://git.openjdk.org/jdk11u-dev/pull/2601 From jkern at openjdk.org Wed Mar 13 13:41:31 2024 From: jkern at openjdk.org (Joachim Kern) Date: Wed, 13 Mar 2024 13:41:31 GMT Subject: [jdk22u] RFR: 8327210: AIX: Delete obsolete parameter Use64KPagesThreshold Message-ID: As the configuration parameter Use64KPagesThreshold on AIX is not needed anymore, we remove it from the code. ------------- Commit messages: - Backport 0ae4fa71e425316a695cfd7e14835effd0cf23b9 Changes: https://git.openjdk.org/jdk22u/pull/100/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=100&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327210 Stats: 19 lines in 3 files changed: 0 ins; 14 del; 5 mod Patch: https://git.openjdk.org/jdk22u/pull/100.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/100/head:pull/100 PR: https://git.openjdk.org/jdk22u/pull/100 From goetz at openjdk.org Wed Mar 13 14:09:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 14:09:26 GMT Subject: [jdk21u-dev] RFR: 8321489: Update LCMS to 2.16 Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport dc7d3b182d226253ca246dd854c85c4dd964f10e Changes: https://git.openjdk.org/jdk21u-dev/pull/357/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=357&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321489 Stats: 1599 lines in 21 files changed: 1240 ins; 134 del; 225 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/357.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/357/head:pull/357 PR: https://git.openjdk.org/jdk21u-dev/pull/357 From goetz at openjdk.org Wed Mar 13 14:11:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 14:11:38 GMT Subject: [jdk17u-dev] RFR: 8321489: Update LCMS to 2.16 Message-ID: <24jzjOJGLtuRDg8IS30GyJFEUGgq1aN4qB8VGfC6N8s=.6202f82d-f37f-474f-a6a0-6834c264504e@github.com> I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport dc7d3b182d226253ca246dd854c85c4dd964f10e Changes: https://git.openjdk.org/jdk17u-dev/pull/2294/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2294&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321489 Stats: 1599 lines in 21 files changed: 1240 ins; 134 del; 225 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2294.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2294/head:pull/2294 PR: https://git.openjdk.org/jdk17u-dev/pull/2294 From goetz at openjdk.org Wed Mar 13 14:12:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 14:12:44 GMT Subject: [jdk11u-dev] RFR: 8321489: Update LCMS to 2.16 Message-ID: I backport this for parity with a1.0.24-oracle. ------------- Commit messages: - Backport dc7d3b182d226253ca246dd854c85c4dd964f10e Changes: https://git.openjdk.org/jdk11u-dev/pull/2602/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2602&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321489 Stats: 1599 lines in 21 files changed: 1240 ins; 134 del; 225 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2602.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2602/head:pull/2602 PR: https://git.openjdk.org/jdk11u-dev/pull/2602 From goetz at openjdk.org Wed Mar 13 15:02:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 15:02:53 GMT Subject: [jdk21u-dev] RFR: 8310234: Refactor Locale tests to use JUnit Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport dad7bd9efc7ca2c245f7e35267479670f93a53a8 Changes: https://git.openjdk.org/jdk21u-dev/pull/358/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=358&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310234 Stats: 1112 lines in 15 files changed: 605 ins; 507 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/358.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/358/head:pull/358 PR: https://git.openjdk.org/jdk21u-dev/pull/358 From goetz at openjdk.org Wed Mar 13 15:11:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 15:11:29 GMT Subject: [jdk17u-dev] RFR: 8285452: Add a new test library API to replace a file content using FileUtils.java Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport 0462d5a25258458ec7f40d76b9d910ee529f3647 Changes: https://git.openjdk.org/jdk17u-dev/pull/2295/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2295&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285452 Stats: 163 lines in 2 files changed: 162 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2295.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2295/head:pull/2295 PR: https://git.openjdk.org/jdk17u-dev/pull/2295 From goetz at openjdk.org Wed Mar 13 15:12:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 15:12:25 GMT Subject: [jdk17u-dev] RFR: 8289401: Add dump output to TestRawRSACipher.java Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport 7b3bf97760c8daf6c03aaa069660f5a3a3873f8c Changes: https://git.openjdk.org/jdk17u-dev/pull/2296/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2296&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289401 Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2296.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2296/head:pull/2296 PR: https://git.openjdk.org/jdk17u-dev/pull/2296 From goetz at openjdk.org Wed Mar 13 15:16:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 15:16:50 GMT Subject: [jdk21u-dev] RFR: 8310731: Configure a javax.net.ssl.SNIMatcher for the HTTP/1.1 test servers in java/net/httpclient tests Message-ID: <4Ne_rlwoImxZqx8lIsJ6ziMbxYIhyYeutTHhfGQIUN4=.887a2c36-dac1-4529-97c8-2173e7f3fb2a@github.com> I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 05e9c41eddf8961d1384c88ccedf993d86822a6b Changes: https://git.openjdk.org/jdk21u-dev/pull/359/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=359&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310731 Stats: 317 lines in 19 files changed: 264 ins; 24 del; 29 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/359.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/359/head:pull/359 PR: https://git.openjdk.org/jdk21u-dev/pull/359 From goetz at openjdk.org Wed Mar 13 15:25:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 15:25:43 GMT Subject: [jdk21u-dev] RFR: 8310818: Refactor more Locale tests to use JUnit Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 12e943091071b02b5756b57527a5f86a3d881cb8 Changes: https://git.openjdk.org/jdk21u-dev/pull/360/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=360&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310818 Stats: 1377 lines in 13 files changed: 681 ins; 686 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/360.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/360/head:pull/360 PR: https://git.openjdk.org/jdk21u-dev/pull/360 From goetz at openjdk.org Wed Mar 13 15:33:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 15:33:23 GMT Subject: [jdk21u-dev] RFR: 8314832: Few runtime/os tests ignore vm flags Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport fc3e8266929826f8e58bc76fe97423d76bc7be87 Changes: https://git.openjdk.org/jdk21u-dev/pull/361/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=361&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314832 Stats: 11 lines in 3 files changed: 11 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/361.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/361/head:pull/361 PR: https://git.openjdk.org/jdk21u-dev/pull/361 From goetz at openjdk.org Wed Mar 13 15:39:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 15:39:20 GMT Subject: [jdk21u-dev] RFR: 8313612: Use JUnit in lib-test/jdk tests Message-ID: <-Gg_wORlrVxm50Pmle6k521ION5j5WMD29vgZF0eJOE=.ef90654f-cee8-4721-b027-04e5ef2fc45f@github.com> I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport a35e96a3fae8722eea1d266beab22556c784241d Changes: https://git.openjdk.org/jdk21u-dev/pull/362/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=362&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313612 Stats: 301 lines in 5 files changed: 45 ins; 28 del; 228 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/362.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/362/head:pull/362 PR: https://git.openjdk.org/jdk21u-dev/pull/362 From goetz at openjdk.org Wed Mar 13 15:40:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 15:40:26 GMT Subject: [jdk17u-dev] RFR: 8290901: Reduce use of -source in langtools tests Message-ID: <8deWCAydsvndcv8Lmix5Kmwc_HgEGfUxLr2IN6R9CVM=.d9f6dfa6-ae9e-4f88-bb71-43e38b323468@github.com> I backport this for parity with 17.0.12-oracle. Applies clean except for patch of InstanceofTotalPattern.java which is a test that came with new feature "8282274: Compiler implementation for Pattern Matching for switch (Third Preview)". Will mark clean. ------------- Commit messages: - Backport cc2861a993c5c9926e4e9708d5b229c2a0072ca9 Changes: https://git.openjdk.org/jdk17u-dev/pull/2297/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2297&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290901 Stats: 126 lines in 80 files changed: 0 ins; 20 del; 106 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2297.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2297/head:pull/2297 PR: https://git.openjdk.org/jdk17u-dev/pull/2297 From goetz at openjdk.org Wed Mar 13 15:51:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 13 Mar 2024 15:51:41 GMT Subject: [jdk21u-dev] RFR: 8316559: Refactor some util/Calendar tests to JUnit Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 355811a996544c54cde9ff232450f5e5c8e1e632 Changes: https://git.openjdk.org/jdk21u-dev/pull/363/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=363&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316559 Stats: 813 lines in 10 files changed: 339 ins; 259 del; 215 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/363.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/363/head:pull/363 PR: https://git.openjdk.org/jdk21u-dev/pull/363 From wkemper at openjdk.org Wed Mar 13 16:11:17 2024 From: wkemper at openjdk.org (William Kemper) Date: Wed, 13 Mar 2024 16:11:17 GMT Subject: [jdk21u-dev] Integrated: 8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint In-Reply-To: References: Message-ID: On Thu, 25 Jan 2024 21:38:41 GMT, William Kemper wrote: > Trivial merge conflicts This pull request has now been integrated. Changeset: ad5a0878 Author: William Kemper Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/ad5a0878db6145fe041ef47be3f06ad734556403 Stats: 40 lines in 5 files changed: 31 ins; 1 del; 8 mod 8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint Reviewed-by: phh Backport-of: 808a03927c153581cbece93a4f5a4f8242b61ef5 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/217 From wkemper at openjdk.org Wed Mar 13 23:42:38 2024 From: wkemper at openjdk.org (William Kemper) Date: Wed, 13 Mar 2024 23:42:38 GMT Subject: [jdk22u] RFR: 8322503: Shenandoah: Clarify gc state usage Message-ID: <2p7vfWpajqutKf2QdTj9zTDfgwTzt1uIAJV6P6ob0m4=.689544e9-ac28-4243-b33e-a453f606c2d6@github.com> Clean backport. This is a follow up to https://bugs.openjdk.org/browse/JDK-8321815, which renames methods and changes comments and adds an assert for improved readability. ------------- Commit messages: - Backport 51238c4bdbce48f6b719f7dcfe5b7df8b8c6d85b Changes: https://git.openjdk.org/jdk22u/pull/101/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=101&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322503 Stats: 26 lines in 5 files changed: 8 ins; 0 del; 18 mod Patch: https://git.openjdk.org/jdk22u/pull/101.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/101/head:pull/101 PR: https://git.openjdk.org/jdk22u/pull/101 From wkemper at openjdk.org Thu Mar 14 00:22:52 2024 From: wkemper at openjdk.org (William Kemper) Date: Thu, 14 Mar 2024 00:22:52 GMT Subject: [jdk17u-dev] RFR: 8322503: Shenandoah: Clarify gc state usage Message-ID: <7RLSNRnEDJKCIGjfKBk2VBqAGWfXUIIXfFcK6B7-uZw=.402084c8-e1ce-4d62-b053-e877eedac955@github.com> Resolved trivial conflicts. ------------- Commit messages: - 8322503: Shenandoah: Clarify gc state usage Changes: https://git.openjdk.org/jdk17u-dev/pull/2298/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2298&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322503 Stats: 26 lines in 5 files changed: 8 ins; 0 del; 18 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2298.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2298/head:pull/2298 PR: https://git.openjdk.org/jdk17u-dev/pull/2298 From wkemper at openjdk.org Thu Mar 14 00:24:52 2024 From: wkemper at openjdk.org (William Kemper) Date: Thu, 14 Mar 2024 00:24:52 GMT Subject: [jdk21u-dev] RFR: 8322503: Shenandoah: Clarify gc state usage Message-ID: Resolved trivial conflicts ------------- Commit messages: - 8322503: Shenandoah: Clarify gc state usage Changes: https://git.openjdk.org/jdk21u-dev/pull/365/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=365&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322503 Stats: 26 lines in 5 files changed: 8 ins; 0 del; 18 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/365.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/365/head:pull/365 PR: https://git.openjdk.org/jdk21u-dev/pull/365 From syan at openjdk.org Thu Mar 14 01:39:42 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 14 Mar 2024 01:39:42 GMT Subject: [jdk17u-dev] RFR: 8327312: Problem list ReflectionCallerCacheTest.java due to 8324978 In-Reply-To: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> References: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> Message-ID: On Tue, 30 Jan 2024 16:25:52 GMT, SendaoYan wrote: > The testcase ReflectionCallerCacheTest.java run failed with -Xcomp, both on linux-x86_64 and linux-aarch64. > > And it run pass by jdk23 binary with the same testcase and the same jvm options(-Xcomp): > > ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/9ee1e9d2-96fc-4772-b11f-776a631515cd) > > > > Before we found the root cause of this failure, should we problem list this testcase in test/jdk/ProblemList-Xcomp.txt. Problem list this fail testcase to test/jdk/ProblemList-Xcomp.txt, the risk is low. Can anyone review this PR, thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2186#issuecomment-1996235065 From ashi at openjdk.org Thu Mar 14 08:06:42 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 14 Mar 2024 08:06:42 GMT Subject: [jdk17u-dev] Integrated: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 23:39:50 GMT, Amos Shi wrote: > Backport of [JDK-8320943](https://bugs.openjdk.org/browse/JDK-8320943) > - This PR has two commits > - commit 1 is the backport of the original [commit](https://github.com/openjdk/jdk/commit/87516e29dc5015c4cab2c07c5539ad30f2768667) > - commit 2 is fixing the compile and runtime issue on Java 17. > - Compile issue fixed: on Java 17 the class is `jdk.test.lib.Platform` and `jdk.test.lib.OSVersion` > - Runtime issue fixed: on Java 17 there is no mime `wasm`, so we comment it out > - `wasm` exists in Java 21: https://github.com/openjdk/jdk21u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties > - `wasm` does not exists in Java 17: https://github.com/openjdk/jdk17u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties > - ? after [JDK-8297609](https://bugs.openjdk.org/browse/JDK-8297609) back ported to 17, `wasm` will be available > - So this is an unclean backport > > Testing > - Local: Test passed on Mac > - `Basic.java` - Test results: passed: 1 > > Mac machine > > > MacBook Pro > 16-inch, 2021 > Chip: Apple M1 Max > MacOS: 14.3.1 (23D60) > > > Windows machine: > > > Device name W-PW05T4AD > Processor 12th Gen Intel(R) Core(TM) i7-12800H 2.40 GHz > Installed RAM 64.0 GB (63.7 GB usable) > System type 64-bit operating system, x64-based processor > > > - ? Pipeline: All `GHA Sanity Checks` passed except `linux-cross-compile / build (riscv64)` > - ? It failed with message `Error: Unable to find an artifact with the name: bundles-linux-x64` > - ? This error is on Linux riscv64 - which not caused by current test case, because current PR is for `Windows` > > - Testing Machine: SAP nightlies passed on `2024-03-01,02,03` This pull request has now been integrated. Changeset: 27cf2f40 Author: Amos Shi Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/27cf2f404857aa8c3b1679d0e67f0a3a37e7604b Stats: 65 lines in 1 file changed: 22 ins; 3 del; 40 mod 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch Reviewed-by: mdoerr Backport-of: 87516e29dc5015c4cab2c07c5539ad30f2768667 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2254 From ashi at openjdk.org Thu Mar 14 08:10:10 2024 From: ashi at openjdk.org (Amos Shi) Date: Thu, 14 Mar 2024 08:10:10 GMT Subject: [jdk17u-dev] RFR: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters [v2] In-Reply-To: References: Message-ID: > Backport of [JDK-8320570](https://bugs.openjdk.org/browse/JDK-8320570) > - `NegativeSize.java` - Clean backport > - `String.java` - 3 sections change are unclean, the rest are clean. Details as bellow. > - This PR contains 2 commits > - The commit 1: is a clean backport part > - The commit 2: is a manual fix of the following 3 sections, > - Replace all `new byte[length << 1]` as `StringUTF16.newBytesFor(length)` > > > @@ -592,7 +592,7 @@ > this.coder = LATIN1; > return; > } > - byte[] utf16 = new byte[length << 1]; > + byte[] utf16 = StringUTF16.newBytesFor(length); > StringLatin1.inflate(latin1, 0, utf16, 0, dp); > dp = decodeUTF8_UTF16(latin1, sp, length, utf16, dp, true); > if (dp != length) { > > > > @@ -601,7 +601,7 @@ > this.value = utf16; > this.coder = UTF16; > } else { // !COMPACT_STRINGS > - byte[] dst = new byte[length << 1]; > + byte[] dst = StringUTF16.newBytesFor(length); > int dp = decodeUTF8_UTF16(bytes, offset, offset + length, dst, 0, true); > if (dp != length) { > dst = Arrays.copyOf(dst, dp << 1); > > > > @@ -730,15 +730,15 @@ > return new String(dst, LATIN1); > } > if (dp == 0) { > - dst = new byte[length << 1]; > + dst = StringUTF16.newBytesFor(length); > } else { > - byte[] buf = new byte[length << 1]; > + byte[] buf = StringUTF16.newBytesFor(length); > StringLatin1.inflate(dst, 0, buf, 0, dp); > dst = buf; > } > dp = decodeUTF8_UTF16(bytes, offset, sl, dst, dp, false); > } else { // !COMPACT_STRINGS > - dst = new byte[length << 1]; > + dst = StringUTF16.newBytesFor(length); > dp = decodeUTF8_UTF16(bytes, offset, offset + length, dst, 0, false); > } > if (dp != length) { > > > - So this PR can be considered as `semantics clean` > > > Testing > - Local: > - Passed on MacOS M1 laptop > - `test/jdk/java/lang/String/CompactString/NegativeSize.java` - Test results: passed: 1 > - Passed on Windows 11 > - `test/jdk/java/lang/String/CompactString/NegativeSize.java` - Test results: passed: 1 > > Processor 12th Gen Intel(R) Core(TM) i7-12800H 2.40 GHz > Installed RAM 64.0 GB (63.7 GB usable) > System type 64-bit operating system, x64-ba... Amos Shi has updated the pull request incrementally with one additional commit since the last revision: Fix compile error: unmappable character for encoding windows-1252 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2279/files - new: https://git.openjdk.org/jdk17u-dev/pull/2279/files/2b4329e4..0bf1e5f0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2279&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2279&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2279.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2279/head:pull/2279 PR: https://git.openjdk.org/jdk17u-dev/pull/2279 From andrewlu at openjdk.org Thu Mar 14 09:06:47 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 14 Mar 2024 09:06:47 GMT Subject: [jdk17u-dev] Integrated: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 09:30:16 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 0b20589b Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/0b20589b9cc1df42dbbb0a2fa1e028cb223ea280 Stats: 38 lines in 1 file changed: 24 ins; 4 del; 10 mod 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg Backport-of: 62c9530c056dbaaf65be0f43295af3d225326a4c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2288 From andrewlu at openjdk.org Thu Mar 14 09:06:48 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 14 Mar 2024 09:06:48 GMT Subject: [jdk11u-dev] Integrated: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg In-Reply-To: References: Message-ID: <6CX3Tr1Dt1dEbASmxDQ9d9OTHTRjTJ0r5E6HGPdU0qY=.397375b7-c603-4585-9316-1171833b59e0@github.com> On Tue, 12 Mar 2024 09:30:42 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. This pull request has now been integrated. Changeset: 0f09d0ba Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/0f09d0ba6cf21e5b4b50e3827fb62c55be8953c7 Stats: 38 lines in 1 file changed: 24 ins; 4 del; 10 mod 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg Backport-of: 62c9530c056dbaaf65be0f43295af3d225326a4c ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2599 From andrewlu at openjdk.org Thu Mar 14 09:07:46 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 14 Mar 2024 09:07:46 GMT Subject: [jdk21u-dev] Integrated: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg In-Reply-To: References: Message-ID: <-cfTHryxuCV7JaJCqHhJAmSguKmIsnvcLyu18U2MCEQ=.2c930ee1-0a5d-489e-bc26-09416209b4d3@github.com> On Tue, 12 Mar 2024 09:28:29 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 93fd1a1d Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/93fd1a1d5c1e4627b28cf4cda931d1396a18c54b Stats: 38 lines in 1 file changed: 24 ins; 4 del; 10 mod 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg Backport-of: 62c9530c056dbaaf65be0f43295af3d225326a4c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/352 From shade at openjdk.org Thu Mar 14 09:19:46 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 14 Mar 2024 09:19:46 GMT Subject: [jdk21u-dev] RFR: 8322503: Shenandoah: Clarify gc state usage In-Reply-To: References: Message-ID: On Thu, 14 Mar 2024 00:19:19 GMT, William Kemper wrote: > Resolved trivial conflicts Looks good. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/365#pullrequestreview-1936117543 From shade at openjdk.org Thu Mar 14 09:19:46 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 14 Mar 2024 09:19:46 GMT Subject: [jdk17u-dev] RFR: 8322503: Shenandoah: Clarify gc state usage In-Reply-To: <7RLSNRnEDJKCIGjfKBk2VBqAGWfXUIIXfFcK6B7-uZw=.402084c8-e1ce-4d62-b053-e877eedac955@github.com> References: <7RLSNRnEDJKCIGjfKBk2VBqAGWfXUIIXfFcK6B7-uZw=.402084c8-e1ce-4d62-b053-e877eedac955@github.com> Message-ID: On Thu, 14 Mar 2024 00:19:06 GMT, William Kemper wrote: > Resolved trivial conflicts. Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2298#pullrequestreview-1936118846 From shade at openjdk.org Thu Mar 14 09:30:59 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 14 Mar 2024 09:30:59 GMT Subject: [jdk21u-dev] RFR: 8325730: StringBuilder.toString allocation for the empty String Message-ID: Clean backport to resolve the regression introduced in JDK 19. Additional testing: - [x] Linux x86_64 server fastdebug, `all` ------------- Commit messages: - Backport d2590c69b4efe5aa2b48b08070e0dbafb04ef202 Changes: https://git.openjdk.org/jdk21u-dev/pull/364/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=364&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325730 Stats: 25 lines in 4 files changed: 20 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/364.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/364/head:pull/364 PR: https://git.openjdk.org/jdk21u-dev/pull/364 From goetz at openjdk.org Thu Mar 14 09:41:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 09:41:38 GMT Subject: [jdk21u-dev] RFR: 8324174: assert(m->is_entered(current)) failed: invariant In-Reply-To: References: Message-ID: <9Ltayh8IptfjKfKNFl3FabVS6N1QeOAduuJXOFrEidE=.365e56ed-50fc-4bc6-b737-a0c7ab64074a@github.com> On Wed, 6 Mar 2024 08:33:05 GMT, lusou-zhangquan wrote: > Clean backport from master to fix the incorrect lock and unlock order problem of nested locks during deoptimization. Hi @lusou-zhangquan > Hi @lusou-zhangquan, please follow the instructions in https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix and also see yesterdays mail https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-March/030685.htm Please have a closer look at the link I posted above: _Test the patch: testing is very important. Your backport is very close to the customer, with few safety nets. In comparison, patches for the mainline head release get much more cooking time before seeing broad adoption. Don't rely on maintainers doing testing for you! You should know your patch best and must make sure it works and does not introduce regressions._ _"tier1" tests should pass at all times. Use "make run-test TEST=tier1" to run. You should test both debug- and release builds. Don't just test one of them! If your patch changes platform-dependent code, test your patch on as many of those platforms as you have available. If you cannot test every platform but feel that tests are needed, clearly state so in the PR or in the Fix Request. Maintainers then will strive to fill the testing holes for you. "tier2" provides a larger coverage if you have the resources to run it. Use "make run-test TEST=tier2" to run Run tests from the area that the patch affects, use "make run-test TEST=" to run specific tests New regression tests that come with the patch should pass Enabling GitHub Actions for your personal fork of the jdk11u-dev repository before publishing your branch will provide you with builds and a tier 1 test run via GitHub Actions on many platforms. If tests fail, analyze why they are failing and share this information._ Your testing is far from sufficient. As I understand you completely rely on GHA? That is not enough for such a change. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/334#issuecomment-1997028650 From goetz at openjdk.org Thu Mar 14 09:47:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 09:47:51 GMT Subject: [jdk21u] RFR: 8327391: Add SipHash attribution file In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 08:37:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. > > I backport this to 21.0.3 as in 17 and 11 it also reaches the April update. GHA failure: Could not reserve enough space for 2097152KB object heap on 32-bit linux. Unrelated! ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/442#issuecomment-1997041440 From andrewlu at openjdk.org Thu Mar 14 09:50:12 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 14 Mar 2024 09:50:12 GMT Subject: [jdk11u-dev] RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 [v3] In-Reply-To: References: Message-ID: <52tAQshOXkQ58paRjxEoHy7Itb_jLbFrPeNkGh9C6Xs=.1047f358-0c98-42bd-b017-13e1f58c5752@github.com> > I backport this for parity with 11.0.24-oracle. > > Follow 21-dev backport. > test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java > Backport to the origin file. Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: fix ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2598/files - new: https://git.openjdk.org/jdk11u-dev/pull/2598/files/200d1ed5..b9dc7d7e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2598&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2598&range=01-02 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2598.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2598/head:pull/2598 PR: https://git.openjdk.org/jdk11u-dev/pull/2598 From goetz at openjdk.org Thu Mar 14 09:50:45 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 09:50:45 GMT Subject: [jdk21u-dev] RFR: 8321489: Update LCMS to 2.16 In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 14:04:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: riscv compile failed, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/357#issuecomment-1997047042 From goetz at openjdk.org Thu Mar 14 09:51:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 09:51:44 GMT Subject: [jdk17u-dev] RFR: 8321489: Update LCMS to 2.16 In-Reply-To: <24jzjOJGLtuRDg8IS30GyJFEUGgq1aN4qB8VGfC6N8s=.6202f82d-f37f-474f-a6a0-6834c264504e@github.com> References: <24jzjOJGLtuRDg8IS30GyJFEUGgq1aN4qB8VGfC6N8s=.6202f82d-f37f-474f-a6a0-6834c264504e@github.com> Message-ID: On Wed, 13 Mar 2024 14:05:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. GHA failure: Risc-V compile setup failed, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2294#issuecomment-1997048243 From goetz at openjdk.org Thu Mar 14 09:52:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 09:52:43 GMT Subject: [jdk21u-dev] RFR: 8310731: Configure a javax.net.ssl.SNIMatcher for the HTTP/1.1 test servers in java/net/httpclient tests In-Reply-To: <4Ne_rlwoImxZqx8lIsJ6ziMbxYIhyYeutTHhfGQIUN4=.887a2c36-dac1-4529-97c8-2173e7f3fb2a@github.com> References: <4Ne_rlwoImxZqx8lIsJ6ziMbxYIhyYeutTHhfGQIUN4=.887a2c36-dac1-4529-97c8-2173e7f3fb2a@github.com> Message-ID: <6kuN_UpUFG9dCuSSPug1umgQTc1erXMQOV3zbARMq6U=.1184ff78-e231-4100-8416-3ca24df3bd41@github.com> On Wed, 13 Mar 2024 15:11:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: Risc-V compile setup failed, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/359#issuecomment-1997050543 From goetz at openjdk.org Thu Mar 14 09:56:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 09:56:41 GMT Subject: [jdk21u-dev] RFR: 8310234: Refactor Locale tests to use JUnit In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 14:56:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: Risc-V compile setup failed, unrelated. GHA failure: x86 WhiteBoxResizeTest.java, Could not reserve enough space for 2097152KB object heap, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/358#issuecomment-1997057281 From goetz at openjdk.org Thu Mar 14 09:56:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 09:56:46 GMT Subject: [jdk17u-dev] RFR: 8285452: Add a new test library API to replace a file content using FileUtils.java In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 15:06:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. GHA failure: Risc-V compile setup failed, unrelated. GHA failure: x86 StringRepeat.java, Could not reserve enough space for 2097152KB object heap, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2295#issuecomment-1997058911 From goetz at openjdk.org Thu Mar 14 09:57:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 09:57:40 GMT Subject: [jdk17u-dev] RFR: 8289401: Add dump output to TestRawRSACipher.java In-Reply-To: References: Message-ID: <_3S8L430_GrPYcs2YTBbOQJsfJJAJUq1wAYsfFoRB2Y=.a36d8ca9-10bb-45c3-99ea-f17bad681eda@github.com> On Wed, 13 Mar 2024 15:08:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. GHA failure: Risc-V compile setup failed, unrelated. GHA failure: x86 StringRepeat.java, Could not reserve enough space for 2097152KB object heap, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2296#issuecomment-1997060840 From goetz at openjdk.org Thu Mar 14 09:58:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 09:58:48 GMT Subject: [jdk21u-dev] RFR: 8310818: Refactor more Locale tests to use JUnit In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 15:20:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: Risc-V compile setup failed, unrelated. GHA failure: x86 WhiteBoxResizeTest.java, Could not reserve enough space for 2097152KB object heap, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/360#issuecomment-1997061805 From goetz at openjdk.org Thu Mar 14 09:59:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 09:59:40 GMT Subject: [jdk21u-dev] RFR: 8314832: Few runtime/os tests ignore vm flags In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 15:28:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: Risc-V compile setup failed, unrelated. GHA failure: x86 WhiteBoxResizeTest.java and StringRepeat.java, Could not reserve enough space for 2097152KB object heap, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/361#issuecomment-1997063913 From goetz at openjdk.org Thu Mar 14 10:00:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 10:00:46 GMT Subject: [jdk17u-dev] RFR: 8290901: Reduce use of -source in langtools tests In-Reply-To: <8deWCAydsvndcv8Lmix5Kmwc_HgEGfUxLr2IN6R9CVM=.d9f6dfa6-ae9e-4f88-bb71-43e38b323468@github.com> References: <8deWCAydsvndcv8Lmix5Kmwc_HgEGfUxLr2IN6R9CVM=.d9f6dfa6-ae9e-4f88-bb71-43e38b323468@github.com> Message-ID: On Wed, 13 Mar 2024 15:36:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > > Applies clean except for patch of InstanceofTotalPattern.java which is a test that came with new feature "8282274: Compiler implementation for Pattern Matching for switch (Third Preview)". > > Will mark clean. GHA failure: Risc-V compile setup failed, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2297#issuecomment-1997066653 From goetz at openjdk.org Thu Mar 14 10:00:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 10:00:47 GMT Subject: [jdk21u-dev] RFR: 8313612: Use JUnit in lib-test/jdk tests In-Reply-To: <-Gg_wORlrVxm50Pmle6k521ION5j5WMD29vgZF0eJOE=.ef90654f-cee8-4721-b027-04e5ef2fc45f@github.com> References: <-Gg_wORlrVxm50Pmle6k521ION5j5WMD29vgZF0eJOE=.ef90654f-cee8-4721-b027-04e5ef2fc45f@github.com> Message-ID: On Wed, 13 Mar 2024 15:34:08 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: Risc-V compile setup failed, unrelated. GHA failure: x86 WhiteBoxResizeTest.java, Could not reserve enough space for 2097152KB object heap, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/362#issuecomment-1997065501 From goetz at openjdk.org Thu Mar 14 10:01:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 10:01:49 GMT Subject: [jdk21u-dev] RFR: 8316559: Refactor some util/Calendar tests to JUnit In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 15:47:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: Risc-V compile setup failed, unrelated. GHA failure: x86 WhiteBoxResizeTest.java, Could not reserve enough space for 2097152KB object heap, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/363#issuecomment-1997068425 From snazarki at openjdk.org Thu Mar 14 10:16:45 2024 From: snazarki at openjdk.org (Sergey Nazarkin) Date: Thu, 14 Mar 2024 10:16:45 GMT Subject: [jdk17u-dev] Integrated: 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used In-Reply-To: <-pNl27hnJvTUMD9biuEkMOrR2K1cmCvuG8EgiIObPTc=.0662dd66-97ca-445b-85fd-92c6bdd2e094@github.com> References: <-pNl27hnJvTUMD9biuEkMOrR2K1cmCvuG8EgiIObPTc=.0662dd66-97ca-445b-85fd-92c6bdd2e094@github.com> Message-ID: <7B2ZyYSko2JdbDRv5wqc1zBS90V7Vfz2bhAwE-Z2_N4=.a7119285-0ea3-4f1e-bed7-d3c5b64fa58b@github.com> On Thu, 29 Feb 2024 12:06:15 GMT, Sergey Nazarkin wrote: > I'd like to backport this changes as it fixes some custom launchers issue. Fix applies cleanly. > > The functionality was tested with the new test and manually > > cd ~/tools/bin > cp -r ~/jdk . > cp jdk/bin/java jdk/lib > jdk/lib/java -version > > > Without the patch JVM can't start > > Error: could not find libjava.so > Error: Could not find Java SE Runtime Environment. This pull request has now been integrated. Changeset: c9b0307a Author: Sergey Nazarkin URL: https://git.openjdk.org/jdk17u-dev/commit/c9b0307a11731a3310f777f91a3a030ab207a941 Stats: 65 lines in 2 files changed: 58 ins; 1 del; 6 mod 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used Backport-of: 984003d5c969443abae2d889e92cba30da26e55f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2257 From duke at openjdk.org Thu Mar 14 11:06:42 2024 From: duke at openjdk.org (Richard Startin) Date: Thu, 14 Mar 2024 11:06:42 GMT Subject: [jdk17u-dev] Integrated: 8286740: JFR: Active Setting event emitted incorrectly In-Reply-To: References: Message-ID: On Fri, 16 Feb 2024 09:47:50 GMT, Richard Startin wrote: > jtreg_jfr passed [here](https://github.com/DataDog/openjdk-jdk17/actions/runs/7928014975) This pull request has now been integrated. Changeset: 4b9ab0dd Author: Richard Startin Committer: Jaroslav Bachorik URL: https://git.openjdk.org/jdk17u-dev/commit/4b9ab0dd9eea74d1d381db3c4f31b69609f752ad Stats: 64 lines in 7 files changed: 39 ins; 8 del; 17 mod 8286740: JFR: Active Setting event emitted incorrectly Reviewed-by: jbachorik Backport-of: 24cab0af32a1eaa4c594fb2a144386a6b7062981 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2210 From duke at openjdk.org Thu Mar 14 12:48:43 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Thu, 14 Mar 2024 12:48:43 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: <47M-EjUdhfKNt0IMFCTDN6jQppdOxuVPVC3Yb5u1gsI=.c7635419-d5cc-4557-88d6-36662cf4ce3f@github.com> References: <47M-EjUdhfKNt0IMFCTDN6jQppdOxuVPVC3Yb5u1gsI=.c7635419-d5cc-4557-88d6-36662cf4ce3f@github.com> Message-ID: On Tue, 12 Mar 2024 09:11:42 GMT, Goetz Lindenmaier wrote: > Hi @Delawen, did you run some tests as e.g. proposed here? To be completely honest, I am having issues running tier2+ tests on my laptop, I am looking for an external infra to run them. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#issuecomment-1997378214 From shade at openjdk.org Thu Mar 14 13:25:18 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 14 Mar 2024 13:25:18 GMT Subject: [jdk21u-dev] RFR: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared Message-ID: Unclean backport to match the codebases between mainline and JDK 21, simplifying maintenance. It also implicitly fixes [JDK-8323505](https://bugs.openjdk.org/browse/JDK-8323505), since this move includes a few touchups to the test. The uncleanliness comes from `MethodType.java` conflicts that does not have [JDK-8310849](https://bugs.openjdk.org/browse/JDK-8310849) in JDK 21. So it yields a few contextual conflicts. Since affected hunks are just removals, I removed them by hand. There is a follow-up, [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255), but it does not seem to affect anything yet, since there are no `ReferenceKeySet.add` calls anywhere in sight. We can backport that separately. Additional testing: - [x] MacOS AArch64 Server fastdebug, `jdk/internal/util` tests pass - [x] MacOS AArch64 Server fastdebug, `java/lang/invoke` tests pass - [x] Linux AArch64 Server fastdebug, `all` tests pass ------------- Commit messages: - Backport 6af0af593446bc33dc94bbf7334c325c4ac0ac0f Changes: https://git.openjdk.org/jdk21u-dev/pull/342/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=342&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310913 Stats: 1522 lines in 13 files changed: 887 ins; 627 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/342.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/342/head:pull/342 PR: https://git.openjdk.org/jdk21u-dev/pull/342 From shade at openjdk.org Thu Mar 14 13:25:18 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 14 Mar 2024 13:25:18 GMT Subject: [jdk21u-dev] RFR: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared In-Reply-To: References: Message-ID: <0U2HtSxsDsXQvwP8C_9xg7UXjXopqf1yTyK5xpES8IA=.6485d0f3-92dc-4ddd-80b4-8a270366449e@github.com> On Fri, 8 Mar 2024 09:26:11 GMT, Aleksey Shipilev wrote: > Unclean backport to match the codebases between mainline and JDK 21, simplifying maintenance. It also implicitly fixes [JDK-8323505](https://bugs.openjdk.org/browse/JDK-8323505), since this move includes a few touchups to the test. > > The uncleanliness comes from `MethodType.java` conflicts that does not have [JDK-8310849](https://bugs.openjdk.org/browse/JDK-8310849) in JDK 21. So it yields a few contextual conflicts. Since affected hunks are just removals, I removed them by hand. > > There is a follow-up, [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255), but it does not seem to affect anything yet, since there are no `ReferenceKeySet.add` calls anywhere in sight. We can backport that separately. > > Additional testing: > - [x] MacOS AArch64 Server fastdebug, `jdk/internal/util` tests pass > - [x] MacOS AArch64 Server fastdebug, `java/lang/invoke` tests pass > - [x] Linux AArch64 Server fastdebug, `all` tests pass RISC-V GHA failure is environmental. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/342#issuecomment-1997444949 From sgehwolf at openjdk.org Thu Mar 14 16:10:43 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 14 Mar 2024 16:10:43 GMT Subject: [jdk21u-dev] RFR: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls [v2] In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 09:08:34 GMT, Aleksey Shipilev wrote: >> This resolves potentially catastrophic bug in monitor deflation. Thread dumps are routinely requested by profilers, so it is a real in-production risk. It would be more prominent as we backport improvements in monitor deflation code like [JDK-8319048](https://bugs.openjdk.org/browse/JDK-8319048). The interaction between deflation thread that can be stopped at safepoint in the middle of deflation and the VM op that deflates monitors itself may corrupt the VM state. >> >> This series of backports moves all deflation to monitor deflation thread, avoiding the issue. There are 4 interconnected issues, which are backported here atomically: >> >> - **[JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757): VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls.** The core part, deferring deflation to monitor deflation thread. The new test needs `-XX:+UnlockExperimentalVMOptions` to gain access to `-XX:LockingMode`. Otherwise applies cleanly. It needs JDK-8320515 as the followup. >> - **[JDK-8319896](https://bugs.openjdk.org/browse/JDK-8319896): Remove monitor deflation from final audit.** Removes the remaining part that might call into deflation outside of monitor deflation thread. Applies cleanly. Makes JDK-8320515 backport clean. It needs JDK-8325437 as the followup. >> - **[JDK-8320515](https://bugs.openjdk.org/browse/JDK-8320515): assert(monitor->object_peek() != nullptr) failed**. Owned monitors should not have a dead object. Follow-up for JDK-8318757, fixes the JNI interaction problem. Does not apply cleanly due to minor conflict in `JtregNativeHotspot.gmk`. >> - **[JDK-8325437](https://bugs.openjdk.org/browse/JDK-8325437): Safepoint polling in monitor deflation can cause massive logs.** Followup for JDK-8319896, reducing the logs noise. >> >> @stefank -- it looks like you are tasked with backporting some of this to 21.0.4-oracle. Maybe you want to review this PR, which would also allow you to pick it up as commit later? :) >> >> Additional testing: >> - [x] Linux x86_64 server fastdebug, `all` tests pass > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'master' into JDK-MULTI-deflation > - Clean JDK-8325437: Safepoint polling in monitor deflation can cause massive logs > > Backport 52d497619e58a5677bc4a015b1bd87f600f23837 > - Unclean JDK-8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object > > Conflicts in JtregNativeHotspot.gmk due to absent JDK-8311541 > > Reviewed-by: dholmes, ihse, sspitsyn, dcubed > - Clean JDK-8319896: Remove monitor deflation from final audit > > Backport 369bbecc0dab389b523c09bc332fe1cf6394cb26 > - Unclean JDK-8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls > > Needs -XX:+UnlockExperimentalVMOptions in new test > > Backport 87be6b69fe985eee01fc3344f9153d774db792c1 @adinn Could you please review this as well? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/337#issuecomment-1997811873 From adinn at openjdk.org Thu Mar 14 16:15:51 2024 From: adinn at openjdk.org (Andrew Dinn) Date: Thu, 14 Mar 2024 16:15:51 GMT Subject: [jdk21u-dev] RFR: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls [v2] In-Reply-To: References: Message-ID: <37QrVzt-ywrnrEGZyd-x4BMTb4YJMn4nWds-HoGsesw=.ccd12899-063e-4f2b-a669-84583c86f33c@github.com> On Thu, 14 Mar 2024 16:08:10 GMT, Severin Gehwolf wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: >> >> - Merge branch 'master' into JDK-MULTI-deflation >> - Clean JDK-8325437: Safepoint polling in monitor deflation can cause massive logs >> >> Backport 52d497619e58a5677bc4a015b1bd87f600f23837 >> - Unclean JDK-8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object >> >> Conflicts in JtregNativeHotspot.gmk due to absent JDK-8311541 >> >> Reviewed-by: dholmes, ihse, sspitsyn, dcubed >> - Clean JDK-8319896: Remove monitor deflation from final audit >> >> Backport 369bbecc0dab389b523c09bc332fe1cf6394cb26 >> - Unclean JDK-8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls >> >> Needs -XX:+UnlockExperimentalVMOptions in new test >> >> Backport 87be6b69fe985eee01fc3344f9153d774db792c1 > > @adinn Could you please review this as well? Thanks. @jerboaa Sure, I'll take a look. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/337#issuecomment-1997821837 From sgehwolf at openjdk.org Thu Mar 14 16:23:45 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 14 Mar 2024 16:23:45 GMT Subject: [jdk21u-dev] RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn In-Reply-To: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> References: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> Message-ID: On Tue, 9 Jan 2024 16:46:27 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [d23f4f12](https://github.com/openjdk/jdk/commit/d23f4f12adf1ea26b8c340efe2c3854e50b68301) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Oli Gillespie on 4 Dec 2023 and was reviewed by Coleen Phillimore, Kim Barrett and Aleksey Shipilev. > > Thanks! @olivergillespie This looks like it'll need a backport of [JDK-8321276](https://bugs.openjdk.org/browse/JDK-8321276) as well? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/154#issuecomment-1997838352 From ogillespie at openjdk.org Thu Mar 14 16:45:47 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 14 Mar 2024 16:45:47 GMT Subject: [jdk21u-dev] RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn In-Reply-To: References: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> Message-ID: On Thu, 14 Mar 2024 16:20:56 GMT, Severin Gehwolf wrote: >> Hi all, >> >> This pull request contains a backport of commit [d23f4f12](https://github.com/openjdk/jdk/commit/d23f4f12adf1ea26b8c340efe2c3854e50b68301) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Oli Gillespie on 4 Dec 2023 and was reviewed by Coleen Phillimore, Kim Barrett and Aleksey Shipilev. >> >> Thanks! > > @olivergillespie This looks like it'll need a backport of [JDK-8321276](https://bugs.openjdk.org/browse/JDK-8321276) as well? @jerboaa Yes, thanks for catching, sorry I missed that. I'm not sure the procedure for dependent backports, and I don't have time this week to work on it - I'll try to do so next week if that's okay. I can re-request approval once I have it figured out. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/154#issuecomment-1997883239 From dlutker at openjdk.org Thu Mar 14 17:02:02 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Thu, 14 Mar 2024 17:02:02 GMT Subject: [jdk17u-dev] RFR: 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi Message-ID: Backport tto 17 which also has the issue. Ran tier1, 2, 3, 4 on linux aarch64 with -XX:+UseShenandoahGC as well as jcstress quick. ------------- Commit messages: - Merge branch 'openjdk:master' into backport-lutkerd-5d414da5 - Backport 5d414da50459b7a1e6f0f537ff3b318854b2c427 Changes: https://git.openjdk.org/jdk17u-dev/pull/2259/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2259&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325372 Stats: 100 lines in 4 files changed: 99 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2259.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2259/head:pull/2259 PR: https://git.openjdk.org/jdk17u-dev/pull/2259 From dlutker at openjdk.org Thu Mar 14 17:02:02 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Thu, 14 Mar 2024 17:02:02 GMT Subject: [jdk17u-dev] RFR: 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 23:19:38 GMT, Dan Lutker wrote: > Backport tto 17 which also has the issue. Ran tier1, 2, 3, 4 on linux aarch64 with -XX:+UseShenandoahGC as well as jcstress quick. Tier1 failure is an intermittent failure we've started seeing recently in GHA's across multiple projects command: main -Xmx2g StringRepeat 16777216 reason: User specified action: run main/othervm -Xmx2g StringRepeat 16777216 started: Thu Mar 14 03:14:02 UTC 2024 Mode: othervm [/othervm specified] finished: Thu Mar 14 03:14:02 UTC 2024 elapsed time (seconds): 0.01 configuration: STDOUT: Error occurred during initialization of VM Could not reserve enough space for 2097152KB object heap GHA failure: Risc-V compile setup failed, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2259#issuecomment-1997894129 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2259#issuecomment-1997913228 From shade at openjdk.org Thu Mar 14 17:12:44 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 14 Mar 2024 17:12:44 GMT Subject: [jdk21u-dev] RFR: 8322503: Shenandoah: Clarify gc state usage In-Reply-To: References: Message-ID: On Thu, 14 Mar 2024 00:19:19 GMT, William Kemper wrote: > Resolved trivial conflicts I agree GHA failures look unrelated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/365#issuecomment-1997940021 From wkemper at openjdk.org Thu Mar 14 17:12:45 2024 From: wkemper at openjdk.org (William Kemper) Date: Thu, 14 Mar 2024 17:12:45 GMT Subject: [jdk21u-dev] Integrated: 8322503: Shenandoah: Clarify gc state usage In-Reply-To: References: Message-ID: On Thu, 14 Mar 2024 00:19:19 GMT, William Kemper wrote: > Resolved trivial conflicts This pull request has now been integrated. Changeset: e3b6098b Author: William Kemper Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/e3b6098b4c97ca0f55ed1c160f6b7dc484cb3a12 Stats: 26 lines in 5 files changed: 8 ins; 0 del; 18 mod 8322503: Shenandoah: Clarify gc state usage Reviewed-by: shade Backport-of: 51238c4bdbce48f6b719f7dcfe5b7df8b8c6d85b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/365 From duke at openjdk.org Thu Mar 14 17:31:51 2024 From: duke at openjdk.org (Terry Chow) Date: Thu, 14 Mar 2024 17:31:51 GMT Subject: [jdk11u-dev] RFR: 8308593: Add KEEPALIVE Extended Socket Options Support for Windows In-Reply-To: References: Message-ID: On Fri, 10 Nov 2023 20:04:31 GMT, Terry Chow wrote: > This is an unclean backport of [JDK-8308593](https://bugs.openjdk.org/browse/JDK-8308593), which provides support for the keepalive extended socket options on Windows. > > The following changes are the differences from the original patch in order to get this backport working for 11u: > > make/lib/Lib-jdk.net.gmk -- Updated this script to support building extnet for Windows. > > src/jdk.net/share/classes/jdk/net/ExtendedSocketOptions.java -- Added a case to support returning an instance of WindowsSocketOptions in PlatformSocketOptions. > > src/java.base/windows/classes/java/net/PlainSocketImpl.java -- The Windows PlainSocketImpl class will need to have similar setOption/getOption methods as the Unix PlainSocketImpl class to support setting these extended socket options for Windows. > > Backport passed against Tier 1 tests and was manually verified to be working on Windows. Let me know how I can progress this towards integration. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2278#issuecomment-1997976811 From fferrari at openjdk.org Thu Mar 14 20:09:53 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Thu, 14 Mar 2024 20:09:53 GMT Subject: [jdk17u-dev] RFR: 8325254: CKA_TOKEN private and secret keys are not necessarily sensitive Message-ID: <6HgaJkMZkzWCJUrXzlAb_Nvr2vOOIATTkDrI24idMy0=.3e415a76-7c45-4249-a9c4-a5e1b4f5e974@github.com> Hi, this is a second take of #2223, the backport of [JDK-8325254: CKA_TOKEN private and secret keys are not necessarily sensitive](https://bugs.openjdk.org/browse/JDK-8325254), backed out by #2249. Even though the original patch applies cleanly to 17u, it introduces a dependency on `P11Util::isNSS()` from [JDK-8301553: Support Password-Based Cryptography in SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553). I only picked the `P11Util::isNSS()` changes since the whole PBE patch would require a deeper assessment and testing. ### Testing * Build `linux-x86_64-server-release` and `linux-x86_64-server-slowdebug` * Locally execute _SunPKCS11_ tests (`test/jdk/sun/security/pkcs11`) in both builds * Ensure all the patched lines have coverage by attaching a debugger during the execution * Locally execute `jdk:tier1` in both builds * Review GitHub Actions from [run 8285374490 on `backport-8325254 at franferrax/jdk17u-dev`](https://github.com/franferrax/jdk17u-dev/actions/runs/8285374490) * The only failure is due to [JDK-8326960: GHA: RISC-V linux-cross-compile is failing](https://bugs.openjdk.org/browse/JDK-8326960) Regards,\ Francisco ------------- Commit messages: - Backport 0f5f3c9b9718c610406088327401210486447462 Changes: https://git.openjdk.org/jdk17u-dev/pull/2299/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2299&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325254 Stats: 18 lines in 3 files changed: 10 ins; 4 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2299.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2299/head:pull/2299 PR: https://git.openjdk.org/jdk17u-dev/pull/2299 From goetz at openjdk.org Thu Mar 14 20:10:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:10:51 GMT Subject: [jdk21u-dev] Integrated: 8310234: Refactor Locale tests to use JUnit In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 14:56:59 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 58b3403a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/58b3403ada0610d0214db45c2d67e759db8de497 Stats: 1112 lines in 15 files changed: 605 ins; 507 del; 0 mod 8310234: Refactor Locale tests to use JUnit Backport-of: dad7bd9efc7ca2c245f7e35267479670f93a53a8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/358 From goetz at openjdk.org Thu Mar 14 20:11:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:11:52 GMT Subject: [jdk21u-dev] Integrated: 8310731: Configure a javax.net.ssl.SNIMatcher for the HTTP/1.1 test servers in java/net/httpclient tests In-Reply-To: <4Ne_rlwoImxZqx8lIsJ6ziMbxYIhyYeutTHhfGQIUN4=.887a2c36-dac1-4529-97c8-2173e7f3fb2a@github.com> References: <4Ne_rlwoImxZqx8lIsJ6ziMbxYIhyYeutTHhfGQIUN4=.887a2c36-dac1-4529-97c8-2173e7f3fb2a@github.com> Message-ID: On Wed, 13 Mar 2024 15:11:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 166aad07 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/166aad07e09a971073529ad52eb217f92ccf01c3 Stats: 317 lines in 19 files changed: 264 ins; 24 del; 29 mod 8310731: Configure a javax.net.ssl.SNIMatcher for the HTTP/1.1 test servers in java/net/httpclient tests Backport-of: 05e9c41eddf8961d1384c88ccedf993d86822a6b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/359 From goetz at openjdk.org Thu Mar 14 20:13:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:13:48 GMT Subject: [jdk21u-dev] Integrated: 8310818: Refactor more Locale tests to use JUnit In-Reply-To: References: Message-ID: <9wfnM3M5xi96nKLuSnBrwoJOjiMPF1LtP0-bO-pgMqI=.8c8ea503-ee50-45ad-b97e-92b40b8dc192@github.com> On Wed, 13 Mar 2024 15:20:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 0d3a4e29 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/0d3a4e294af98e0cb909f4b001aed50d518ce6d3 Stats: 1377 lines in 13 files changed: 681 ins; 686 del; 10 mod 8310818: Refactor more Locale tests to use JUnit Backport-of: 12e943091071b02b5756b57527a5f86a3d881cb8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/360 From goetz at openjdk.org Thu Mar 14 20:14:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:14:40 GMT Subject: [jdk21u-dev] Integrated: 8314832: Few runtime/os tests ignore vm flags In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 15:28:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 539b04ed Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/539b04edc43a19c49c7f9f52296c14ec26988350 Stats: 11 lines in 3 files changed: 11 ins; 0 del; 0 mod 8314832: Few runtime/os tests ignore vm flags Backport-of: fc3e8266929826f8e58bc76fe97423d76bc7be87 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/361 From goetz at openjdk.org Thu Mar 14 20:16:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:16:40 GMT Subject: [jdk21u-dev] Integrated: 8313612: Use JUnit in lib-test/jdk tests In-Reply-To: <-Gg_wORlrVxm50Pmle6k521ION5j5WMD29vgZF0eJOE=.ef90654f-cee8-4721-b027-04e5ef2fc45f@github.com> References: <-Gg_wORlrVxm50Pmle6k521ION5j5WMD29vgZF0eJOE=.ef90654f-cee8-4721-b027-04e5ef2fc45f@github.com> Message-ID: On Wed, 13 Mar 2024 15:34:08 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 390e647d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/390e647d4127f8c0f6ab0d271ec207318271c425 Stats: 301 lines in 5 files changed: 45 ins; 28 del; 228 mod 8313612: Use JUnit in lib-test/jdk tests Backport-of: a35e96a3fae8722eea1d266beab22556c784241d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/362 From goetz at openjdk.org Thu Mar 14 20:17:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:17:52 GMT Subject: [jdk21u-dev] Integrated: 8316559: Refactor some util/Calendar tests to JUnit In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 15:47:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: a69c4370 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/a69c4370a7b0f98c507dafe1621a17b4190f9e6a Stats: 813 lines in 10 files changed: 339 ins; 259 del; 215 mod 8316559: Refactor some util/Calendar tests to JUnit Backport-of: 355811a996544c54cde9ff232450f5e5c8e1e632 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/363 From goetz at openjdk.org Thu Mar 14 20:17:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:17:54 GMT Subject: [jdk17u-dev] Integrated: 8285452: Add a new test library API to replace a file content using FileUtils.java In-Reply-To: References: Message-ID: <7E_yMFOFlpggcAsIHZCggbxv5-EvVuXr0JsRgKgOY6U=.8765bbfd-5857-43d5-9eaf-c4090241a7dd@github.com> On Wed, 13 Mar 2024 15:06:37 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. This pull request has now been integrated. Changeset: 0499df3a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/0499df3ac10bf1c7e57d4902a155e69c9fee9a80 Stats: 163 lines in 2 files changed: 162 ins; 0 del; 1 mod 8285452: Add a new test library API to replace a file content using FileUtils.java Backport-of: 0462d5a25258458ec7f40d76b9d910ee529f3647 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2295 From goetz at openjdk.org Thu Mar 14 20:18:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:18:48 GMT Subject: [jdk17u-dev] Integrated: 8289401: Add dump output to TestRawRSACipher.java In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 15:08:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. This pull request has now been integrated. Changeset: dc608870 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/dc608870457b0c2a63394af73a5df5352134d938 Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod 8289401: Add dump output to TestRawRSACipher.java Backport-of: 7b3bf97760c8daf6c03aaa069660f5a3a3873f8c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2296 From goetz at openjdk.org Thu Mar 14 20:19:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:19:41 GMT Subject: [jdk21u-dev] Integrated: 8321489: Update LCMS to 2.16 In-Reply-To: References: Message-ID: <_C79kaEdqgtOp-639ixIryjYzCel1o9_UXWL_4AS7mU=.b10da130-2ace-4675-9d1c-4b82bf2bbb96@github.com> On Wed, 13 Mar 2024 14:04:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 5762df6f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/5762df6f816da7c5e76df54bc44c75e957ab46e2 Stats: 1599 lines in 21 files changed: 1240 ins; 134 del; 225 mod 8321489: Update LCMS to 2.16 Backport-of: dc7d3b182d226253ca246dd854c85c4dd964f10e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/357 From goetz at openjdk.org Thu Mar 14 20:19:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:19:50 GMT Subject: [jdk11u-dev] Integrated: 8321489: Update LCMS to 2.16 In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 14:06:32 GMT, Goetz Lindenmaier wrote: > I backport this for parity with a1.0.24-oracle. This pull request has now been integrated. Changeset: 2921ad6b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/2921ad6bb89c91ef7992a1eefa93e9a670512f54 Stats: 1599 lines in 21 files changed: 1240 ins; 134 del; 225 mod 8321489: Update LCMS to 2.16 Backport-of: dc7d3b182d226253ca246dd854c85c4dd964f10e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2602 From mbalao at openjdk.org Thu Mar 14 20:20:41 2024 From: mbalao at openjdk.org (Martin Balao) Date: Thu, 14 Mar 2024 20:20:41 GMT Subject: [jdk17u-dev] RFR: 8325254: CKA_TOKEN private and secret keys are not necessarily sensitive In-Reply-To: <6HgaJkMZkzWCJUrXzlAb_Nvr2vOOIATTkDrI24idMy0=.3e415a76-7c45-4249-a9c4-a5e1b4f5e974@github.com> References: <6HgaJkMZkzWCJUrXzlAb_Nvr2vOOIATTkDrI24idMy0=.3e415a76-7c45-4249-a9c4-a5e1b4f5e974@github.com> Message-ID: On Thu, 14 Mar 2024 20:05:23 GMT, Francisco Ferrari Bihurriet wrote: > Hi, this is a second take of #2223, the backport of [JDK-8325254: CKA_TOKEN private and secret keys are not necessarily sensitive](https://bugs.openjdk.org/browse/JDK-8325254), backed out by #2249. > > Even though the original patch applies cleanly to 17u, it introduces a dependency on `P11Util::isNSS()` from [JDK-8301553: Support Password-Based Cryptography in SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553). > > I only picked the `P11Util::isNSS()` changes since the whole PBE patch would require a deeper assessment and testing. > > ### Testing > > * Build `linux-x86_64-server-release` and `linux-x86_64-server-slowdebug` > * Locally execute _SunPKCS11_ tests (`test/jdk/sun/security/pkcs11`) in both builds > * Ensure all the patched lines have coverage by attaching a debugger during the execution > * Locally execute `jdk:tier1` in both builds > * Review GitHub Actions from [run 8285374490 on `backport-8325254 at franferrax/jdk17u-dev`](https://github.com/franferrax/jdk17u-dev/actions/runs/8285374490) > * The only failure is due to [JDK-8326960: GHA: RISC-V linux-cross-compile is failing](https://bugs.openjdk.org/browse/JDK-8326960) > > Regards,\ > Francisco Looks good to me. ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2299#pullrequestreview-1937645346 From goetz at openjdk.org Thu Mar 14 20:20:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:20:43 GMT Subject: [jdk17u-dev] Integrated: 8321489: Update LCMS to 2.16 In-Reply-To: <24jzjOJGLtuRDg8IS30GyJFEUGgq1aN4qB8VGfC6N8s=.6202f82d-f37f-474f-a6a0-6834c264504e@github.com> References: <24jzjOJGLtuRDg8IS30GyJFEUGgq1aN4qB8VGfC6N8s=.6202f82d-f37f-474f-a6a0-6834c264504e@github.com> Message-ID: On Wed, 13 Mar 2024 14:05:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. This pull request has now been integrated. Changeset: 807faa74 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/807faa7411cdfdc42bfa35317111c0634efd287a Stats: 1599 lines in 21 files changed: 1240 ins; 134 del; 225 mod 8321489: Update LCMS to 2.16 Backport-of: dc7d3b182d226253ca246dd854c85c4dd964f10e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2294 From goetz at openjdk.org Thu Mar 14 20:21:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:21:44 GMT Subject: [jdk21u-dev] Integrated: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 11:55:13 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 5431b82d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/5431b82d06878cb6a9d0875c971bc481b69dca0b Stats: 115 lines in 2 files changed: 111 ins; 0 del; 4 mod 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane Backport-of: 3b1062d45df69d4cf8479c6a65602bd2453ab885 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/356 From goetz at openjdk.org Thu Mar 14 20:21:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:21:47 GMT Subject: [jdk17u-dev] Integrated: 8290901: Reduce use of -source in langtools tests In-Reply-To: <8deWCAydsvndcv8Lmix5Kmwc_HgEGfUxLr2IN6R9CVM=.d9f6dfa6-ae9e-4f88-bb71-43e38b323468@github.com> References: <8deWCAydsvndcv8Lmix5Kmwc_HgEGfUxLr2IN6R9CVM=.d9f6dfa6-ae9e-4f88-bb71-43e38b323468@github.com> Message-ID: On Wed, 13 Mar 2024 15:36:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > > Applies clean except for patch of InstanceofTotalPattern.java which is a test that came with new feature "8282274: Compiler implementation for Pattern Matching for switch (Third Preview)". > > Will mark clean. This pull request has now been integrated. Changeset: 7d716fc5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7d716fc54fd7e6041e6c25379039bb281e7df7e7 Stats: 126 lines in 80 files changed: 0 ins; 20 del; 106 mod 8290901: Reduce use of -source in langtools tests Backport-of: cc2861a993c5c9926e4e9708d5b229c2a0072ca9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2297 From goetz at openjdk.org Thu Mar 14 20:21:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:21:52 GMT Subject: [jdk11u-dev] Integrated: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 12:02:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.24-oracle. > > I resolved Copyright and import (actually unneeded) in JTabbedPane.java. This pull request has now been integrated. Changeset: d1bdb255 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/d1bdb255745f5818339e6e0fdd5de1b291920b36 Stats: 115 lines in 2 files changed: 111 ins; 0 del; 4 mod 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane Backport-of: 3b1062d45df69d4cf8479c6a65602bd2453ab885 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2601 From goetz at openjdk.org Thu Mar 14 20:22:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:22:47 GMT Subject: [jdk17u-dev] Integrated: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane In-Reply-To: <2DWL3Z0fm2fjAcCng0R8pH4VbpDCQfOPdYU74yObX3E=.82269e58-b000-4e05-adb4-c361dd04ec05@github.com> References: <2DWL3Z0fm2fjAcCng0R8pH4VbpDCQfOPdYU74yObX3E=.82269e58-b000-4e05-adb4-c361dd04ec05@github.com> Message-ID: On Wed, 13 Mar 2024 11:55:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. This pull request has now been integrated. Changeset: 373714b5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/373714b5fc8956b8982a47021f710293c733e26a Stats: 115 lines in 2 files changed: 111 ins; 0 del; 4 mod 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane Backport-of: 3b1062d45df69d4cf8479c6a65602bd2453ab885 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2292 From goetz at openjdk.org Thu Mar 14 20:25:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 20:25:42 GMT Subject: [jdk21u-dev] Integrated: 8324632: Update Zlib Data Compression Library to Version 1.3.1 In-Reply-To: References: Message-ID: <97ZxOhBd140WpVt411JsMgiEbm7uuYLNcU1bHVi2Lxc=.6af52719-41e7-49cc-91ac-d5c1c8a625a1@github.com> On Tue, 12 Mar 2024 17:04:27 GMT, Goetz Lindenmaier wrote: > I backport this to keep this external lib up to date and to match OracleJDK. > > Consists of three clean backports. I want to merge them here to limit the effort of further backporting: > > 8315117: Update Zlib Data Compression Library to Version 1.3 > 8324632: Update Zlib Data Compression Library to Version 1.3.1 > 8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1 > > Will mark clean. This pull request has now been integrated. Changeset: 6d8d049e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/6d8d049e4a7c77d8aa8a5d71446de1deb64d96e9 Stats: 2220 lines in 26 files changed: 609 ins; 1036 del; 575 mod 8324632: Update Zlib Data Compression Library to Version 1.3.1 8315117: Update Zlib Data Compression Library to Version 1.3 8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1 Backport-of: b5c267fc8a0af50be9e3d1d09cdaa6bf4bb29851 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/355 From goetz at openjdk.org Thu Mar 14 21:12:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 14 Mar 2024 21:12:47 GMT Subject: [jdk17u-dev] RFR: 8283525: http://tools.ietf.org/html/* URLs return 404 Message-ID: I backport this for parity with 17.0.12-oracle. I backport the change in 21 which merged three related changes. I had to resolve ChangeLog. Unfortunately in 21, "8283525: http://tools.ietf.org/html/* URLs return 404" changed 'http' to https' in many files including this one, but this file should not be touched as it is not owned by our project. But might be clean anyways. ------------- Commit messages: - Backport 63fec5da27994b05a58ce1abcfe07a8ed8bc497b Changes: https://git.openjdk.org/jdk17u-dev/pull/2300/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2300&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283525 Stats: 2219 lines in 26 files changed: 609 ins; 1036 del; 574 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2300.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2300/head:pull/2300 PR: https://git.openjdk.org/jdk17u-dev/pull/2300 From dlutker at openjdk.org Thu Mar 14 22:21:43 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Thu, 14 Mar 2024 22:21:43 GMT Subject: [jdk21u-dev] Integrated: 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi In-Reply-To: References: Message-ID: <2r4L-tBR65y4er2fY7_kQ1plw_XLclMfK_YfUPRm-aI=.2636673f-916c-4467-9c6c-94bc6cd42221@github.com> On Thu, 29 Feb 2024 23:12:15 GMT, Dan Lutker wrote: > Backporting to 21 which also has the same issue. > > Ran tier1, 2, 3, 4 on linux aarch64 with -XX:+UseShenandoahGC as well as jcstress quick. This pull request has now been integrated. Changeset: cc65d0da Author: Dan Lutker Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/cc65d0da5384d85ecf241c5b089cae4f40df0c00 Stats: 100 lines in 4 files changed: 99 ins; 0 del; 1 mod 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi Reviewed-by: shade Backport-of: 5d414da50459b7a1e6f0f537ff3b318854b2c427 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/306 From lyang at openjdk.org Fri Mar 15 02:31:06 2024 From: lyang at openjdk.org (Long Yang) Date: Fri, 15 Mar 2024 02:31:06 GMT Subject: [jdk21u-dev] RFR: 8327799: JFR view: the "Park Until" field of jdk.ThreadPark is invalid if the parking method is not absolute Message-ID: Hi, all Could I have a review of this backport ? I would be very grateful. This pull request contains a backport of commit [6f8b0a33fa15f1dfc8b0c116375df0f90d9d8759](https://github.com/openjdk/jdk/commit/6f8b0a33fa15f1dfc8b0c116375df0f90d9d8759) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. This backport is clean. UNSAFE.park(true, System.currentTimeMillis() + 1000); UNSAFE.park(false, 2000L * 1000 * 1000); ``` bash jfr view jdk.ThreadPark test.jfr Java Thread Park Start Time Duration Event Thread Stack Trace Class Parked On Park Timeout Park Until Address of Object Pa... ---------- -------- ------------ ----------------------- --------------- ------------ ---------- ----------------------- 20:11:10 1.00 s main jdk.internal.misc.Un... N/A N/A 20:11:11 0x00000000 20:11:11 1.00 s main jdk.internal.misc.Un... N/A 1.00 s 08:05:43 0x00000000 If the parking method is not absolute (the second line of the Java code above), the real value of `until` field in JFR's `jdk.ThreadPark` event is `Long.MIN_VALUE`, which will be convert back to `java.time.Instant.MIN`, but `jfr view` displays this value as '08:05:43' of my timezone (the `Park Until` column above). This is somewhat misleading, better to show `N/A`. Testing: test/jdk/jdk/jfr/tool/TestView.java test/jdk/jdk/jfr/jcmd/TestJcmdView.java All passed. ------------- Commit messages: - 8327799: JFR view: the "Park Until" field of jdk.ThreadPark is invalid if the parking method is not absolute Changes: https://git.openjdk.org/jdk21u-dev/pull/366/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=366&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327799 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/366.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/366/head:pull/366 PR: https://git.openjdk.org/jdk21u-dev/pull/366 From ashi at openjdk.org Fri Mar 15 07:43:59 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 15 Mar 2024 07:43:59 GMT Subject: [jdk11u-dev] RFR: 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs Message-ID: Backport of [JDK-8061729](https://bugs.openjdk.org/browse/JDK-8061729) There are 3 commits in this PR - Commit 1. `git apply` clean backport from original commit. All files is clean, except `ProxyFromCache.java` - Commit 2. Manully apply changes to `ProxyFromCache.java`. the following lines in the file cannot be applied automatically, we manually merged the same change. @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2022, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,14 +25,22 @@ * @test * @bug 6498566 * @summary URL.openConnection(Proxy.NO_PROXY) may connect through a proxy. - * @modules java.base/sun.net.www * @library /test/lib * @run main/othervm ProxyFromCache */ -import java.net.*; -import java.io.*; -import sun.net.www.MessageHeader; +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.net.HttpURLConnection; +import java.net.InetAddress; +import java.net.InetSocketAddress; +import java.net.Proxy; +import java.net.ServerSocket; +import java.net.Socket; +import java.net.URL; + +import jdk.test.lib.net.HttpHeaderParser; import jdk.test.lib.net.URIBuilder; /* Creates a simple proxy and http server that just return 200 OK. - Commit 3. Fix compile error in `HttpHeaderParser.java`: the `switch case arrow` is not avaible in Java 11 Testing - Local: Passed on MacOS M1 laptop - `ProxyFromCache.java` - Test results: passed: 1 - `RequestURI.java` - Test results: passed: 1 - `CloseOptionHeader.java` - Test results: passed: 1 - `HttpHeaderParserTest.java` - Test results: passed: 1 - `NTLMTest.java` - Test results: passed: 1 - `NoNTLM.java` - Test results: passed: 1 - `RetryUponTimeout.java` - Test results: passed: 1 - `UserAgent.java` - Test results: passed: 1 - `B6226610.java` - Test results: passed: 1 - `TunnelProxy.java` - Not a test or directory containing tests: sun/net/www/protocol/https/HttpsURLConnection/TunnelProxy.java - `HttpHeaderParser.java` - Cannot determine test suite from test (is TEST.ROOT missing?): dev-8061729-11/test/lib/jdk/test/lib/net/HttpHeaderParser.java - Pipeline: All checks have passed - Testing Machine: SAP nightlies passed on `2024-03-13,14,15` ------------- Commit messages: - Fix pipeline issue: Whitespace errors - Fix compile error on Java 11: switch case arrow - ProxyFromCache.java manually apply - Backport 0f3d3ac32c9d163a5d91c6839d313111c72f1ad4 Changes: https://git.openjdk.org/jdk11u-dev/pull/2596/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2596&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8061729 Stats: 979 lines in 11 files changed: 922 ins; 11 del; 46 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2596.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2596/head:pull/2596 PR: https://git.openjdk.org/jdk11u-dev/pull/2596 From psadhukhan at openjdk.org Fri Mar 15 08:09:02 2024 From: psadhukhan at openjdk.org (Prasanta Sadhukhan) Date: Fri, 15 Mar 2024 08:09:02 GMT Subject: [jdk22u] RFR: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 Message-ID: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 ------------- Commit messages: - Backport 0d354503620eb7f6da7b1b8aa6143ba18ced8f12 Changes: https://git.openjdk.org/jdk22u/pull/102/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=102&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327040 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/102.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/102/head:pull/102 PR: https://git.openjdk.org/jdk22u/pull/102 From ashi at openjdk.org Fri Mar 15 08:27:41 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 15 Mar 2024 08:27:41 GMT Subject: [jdk11u-dev] Integrated: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch In-Reply-To: <4KD2zLHjEowaGglqoYXSXrX2alwlX3Xqfsly2SsFXbk=.fb63924b-1b90-435f-af0b-41baffe5aef0@github.com> References: <4KD2zLHjEowaGglqoYXSXrX2alwlX3Xqfsly2SsFXbk=.fb63924b-1b90-435f-af0b-41baffe5aef0@github.com> Message-ID: On Thu, 29 Feb 2024 00:08:48 GMT, Amos Shi wrote: > Backport of [JDK-8320943](https://bugs.openjdk.org/browse/JDK-8320943) > - This PR has two commits > - commit 1 is the backport of the original [commit](https://github.com/openjdk/jdk/commit/87516e29dc5015c4cab2c07c5539ad30f2768667) > - commit 2 is fixing the compile and runtime issue on Java 17. > - Compile issue fixed: on Java 17 the class is `jdk.test.lib.Platform` and `jdk.test.lib.OSVersion` > - Runtime issue fixed: on Java 17 there is no mime `wasm`, so we comment it out > - `wasm` exists in Java 21: https://github.com/openjdk/jdk21u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties > - `wasm` does not exists in Java 11: https://github.com/openjdk/jdk11u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties > - ? after [JDK-8297609](https://bugs.openjdk.org/browse/JDK-8297609) back ported to 17, `wasm` will be available > - So this is an unclean back port from jdk original commit > - Well it is **clean** against `jdk17u-dev` > - https://github.com/openjdk/jdk17u-dev/pull/2254 > > Testing > - Local: Test passed on Mac > - `Basic.java` - Test results: passed: 1 > > Mac machine > > > MacBook Pro > 16-inch, 2021 > Chip: Apple M1 Max > MacOS: 14.3.1 (23D60) > > > Windows machine: > > > Device name W-PW05T4AD > Processor 12th Gen Intel(R) Core(TM) i7-12800H 2.40 GHz > Installed RAM 64.0 GB (63.7 GB usable) > System type 64-bit operating system, x64-based processor > > > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies passed on `2024-03-01,03` This pull request has now been integrated. Changeset: 7ed3c3ef Author: Amos Shi Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/7ed3c3ef2c70f83fdb35561fc2d6cb5d4814a606 Stats: 65 lines in 1 file changed: 22 ins; 3 del; 40 mod 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch Backport-of: 27cf2f404857aa8c3b1679d0e67f0a3a37e7604b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2574 From duke at openjdk.org Fri Mar 15 08:48:45 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 15 Mar 2024 08:48:45 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: References: Message-ID: <51xH4-cUWDcKYEKGmJ9ZbEhRXUrzU8T0evhsbRF5js0=.04a47208-50df-4bc4-bce8-b7afaaa8fee7@github.com> On Mon, 26 Feb 2024 12:52:28 GMT, Mar?a Arias de Reyna wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8280377 MethodHandleProxies does not correctly invoke default methods with varags > > I applied the same fix that was applied to version 19 in https://github.com/openjdk/jdk/commit/a183bfb436a7dd998e602c2d16486e88c390fca1 @smlambert is using this PR branch for polishing the Trestle testing pipeline. The results are here: https://github.com/adoptium/aqa-tests/issues/5137#issuecomment-1997362685 Not all architectures pass, but (at least right now) not because of this PR, but because misconfigurations. // cc @GoeLin ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#issuecomment-1999186915 From goetz at openjdk.org Fri Mar 15 08:52:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Mar 2024 08:52:51 GMT Subject: [jdk17u] Integrated: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 In-Reply-To: <4LPY3HzOnbjvI_ILaa3IU0Hn3D9BE483Z5CO92Qv3vU=.8888a222-5285-4936-8dd1-ced136a0c97e@github.com> References: <4LPY3HzOnbjvI_ILaa3IU0Hn3D9BE483Z5CO92Qv3vU=.8888a222-5285-4936-8dd1-ced136a0c97e@github.com> Message-ID: On Tue, 12 Mar 2024 10:12:11 GMT, Goetz Lindenmaier wrote: > Clean backport to fix regression of 17.0.9 This pull request has now been integrated. Changeset: e100cf5d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u/commit/e100cf5d5466e8a3c93bf8f7a3b9b0683c3bf958 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 Backport-of: f38add6f8d9c07442e5f6bb5c280a2d907b38b24 ------------- PR: https://git.openjdk.org/jdk17u/pull/391 From goetz at openjdk.org Fri Mar 15 08:53:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Mar 2024 08:53:50 GMT Subject: [jdk11u] Integrated: 8327391: Add SipHash attribution file In-Reply-To: <2ODj2IUVBNQLRtLNMKqYjvqSseX2feZBaXSHptmI5yU=.ae3cb36d-0f61-4938-9e21-c28e6ea06e7c@github.com> References: <2ODj2IUVBNQLRtLNMKqYjvqSseX2feZBaXSHptmI5yU=.ae3cb36d-0f61-4938-9e21-c28e6ea06e7c@github.com> Message-ID: On Wed, 13 Mar 2024 08:38:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.23-oracle. This pull request has now been integrated. Changeset: bd29eb6e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u/commit/bd29eb6eec88a088703582318f790dff2432b7b7 Stats: 150 lines in 1 file changed: 150 ins; 0 del; 0 mod 8327391: Add SipHash attribution file Backport-of: fcf48ab3d36a7f8eed84e81c3e2445adcbc95374 ------------- PR: https://git.openjdk.org/jdk11u/pull/90 From goetz at openjdk.org Fri Mar 15 08:53:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Mar 2024 08:53:54 GMT Subject: [jdk21u] Integrated: 8327391: Add SipHash attribution file In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 08:37:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. > > I backport this to 21.0.3 as in 17 and 11 it also reaches the April update. This pull request has now been integrated. Changeset: 07fc6246 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u/commit/07fc624683c58b708486fb1dc8afa0c2cd85ce11 Stats: 150 lines in 1 file changed: 150 ins; 0 del; 0 mod 8327391: Add SipHash attribution file Backport-of: fcf48ab3d36a7f8eed84e81c3e2445adcbc95374 ------------- PR: https://git.openjdk.org/jdk21u/pull/442 From goetz at openjdk.org Fri Mar 15 09:00:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Mar 2024 09:00:46 GMT Subject: [jdk17u] Integrated: 8327391: Add SipHash attribution file In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 08:37:39 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 5fb5ba65 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u/commit/5fb5ba651db3f6428916ad9e49cf5ff3faaed509 Stats: 150 lines in 1 file changed: 150 ins; 0 del; 0 mod 8327391: Add SipHash attribution file Backport-of: fcf48ab3d36a7f8eed84e81c3e2445adcbc95374 ------------- PR: https://git.openjdk.org/jdk17u/pull/392 From goetz at openjdk.org Fri Mar 15 09:02:05 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Mar 2024 09:02:05 GMT Subject: [jdk11u-dev] RFR: 8292717: Clean up checking of testing requirements in configure Message-ID: I backport this because then 8314495 can be backported clean. Also brings 11 closer to 17. configure.ac:: I had to resolve two chunks. In one, I needed to omit the coding for JMH which is not supported by 11. jdk-options.m4, toolchanin.m4 Deleted function has different body, deleted by hand. lib-tests.m4: Copyright. The original change moves and renames three functions to lib-tests.m4. It does not change the implementation of these. So I modified the added code in lib-tests.m4 to have the unchanged function bodies that were deleted in the other files. ------------- Commit messages: - Backport 8292717 Changes: https://git.openjdk.org/jdk11u-dev/pull/2600/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2600&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292717 Stats: 363 lines in 4 files changed: 182 ins; 179 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2600.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2600/head:pull/2600 PR: https://git.openjdk.org/jdk11u-dev/pull/2600 From goetz at openjdk.org Fri Mar 15 09:11:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 15 Mar 2024 09:11:42 GMT Subject: [jdk17u-dev] RFR: 8324632: Update Zlib Data Compression Library to Version 1.3.1 In-Reply-To: References: Message-ID: On Thu, 14 Mar 2024 21:09:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > I backport the change in 21 which merged three related changes. > > I had to resolve ChangeLog. Unfortunately in 21, "8283525: http://tools.ietf.org/html/* URLs return 404" > changed 'http' to https' in many files including this one, but this file should not > be touched as it is not owned by our project. But might be clean anyways. GHA failures: x86: Could not reserve enough space for 2097152KB object heap in StringRepeat Riscv: build setup issue Both unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2300#issuecomment-1999224675 From lucy at openjdk.org Fri Mar 15 10:54:42 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 15 Mar 2024 10:54:42 GMT Subject: [jdk11u-dev] RFR: 8248194: Need better support for running SA tests on core files [v2] In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 08:34:46 GMT, Andrew Lu wrote: >> Backport for JDK-8248194, depends on JDK-8248667 >> test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java >> There is only one test, so add the other core file test for the backport. >> >> test/lib/jdk/test/lib/SA/SATestUtils.java >> the 'unzipCores' is not exist, no need to remove. >> test/lib/jdk/test/lib/apps/libLingeredApp.c >> has already been updated by >> https://github.com/openjdk/jdk11u-dev/pull/2590 >> >> Others clean. > > Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'openjdk:master' into andrewLu_backport_8248194_new > - Backport db2d4e8f5af1274d82242d3d86b922656954e1ef > - Backport 1356a0f1ac06b006a20ca9fa2306ef60aef5c16e > - Backport 1356a0f1ac06b006a20ca9fa2306ef60aef5c16e LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2591#pullrequestreview-1938646850 From lucy at openjdk.org Fri Mar 15 11:02:42 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 15 Mar 2024 11:02:42 GMT Subject: [jdk11u-dev] RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 [v3] In-Reply-To: <52tAQshOXkQ58paRjxEoHy7Itb_jLbFrPeNkGh9C6Xs=.1047f358-0c98-42bd-b017-13e1f58c5752@github.com> References: <52tAQshOXkQ58paRjxEoHy7Itb_jLbFrPeNkGh9C6Xs=.1047f358-0c98-42bd-b017-13e1f58c5752@github.com> Message-ID: On Thu, 14 Mar 2024 09:50:12 GMT, Andrew Lu wrote: >> I backport this for parity with 11.0.24-oracle. >> >> Follow 21-dev backport. >> test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java >> Backport to the origin file. >> >> test/jdk/sun/security/pkcs11/PKCS11Test.java >> add 'import jtreg.SkippedException;', it's missing. > > Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: > > fix LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2598#pullrequestreview-1938660695 From adinn at openjdk.org Fri Mar 15 14:35:39 2024 From: adinn at openjdk.org (Andrew Dinn) Date: Fri, 15 Mar 2024 14:35:39 GMT Subject: [jdk21u-dev] RFR: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls [v2] In-Reply-To: References: Message-ID: <-P0rj3WJYIBTAOyp8cMDGntU_uVkJVNk_SAnIB10OBM=.f466c496-f314-4721-b1bd-0bf474a7d0a4@github.com> On Tue, 12 Mar 2024 09:08:34 GMT, Aleksey Shipilev wrote: >> This resolves potentially catastrophic bug in monitor deflation. Thread dumps are routinely requested by profilers, so it is a real in-production risk. It would be more prominent as we backport improvements in monitor deflation code like [JDK-8319048](https://bugs.openjdk.org/browse/JDK-8319048). The interaction between deflation thread that can be stopped at safepoint in the middle of deflation and the VM op that deflates monitors itself may corrupt the VM state. >> >> This series of backports moves all deflation to monitor deflation thread, avoiding the issue. There are 4 interconnected issues, which are backported here atomically: >> >> - **[JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757): VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls.** The core part, deferring deflation to monitor deflation thread. The new test needs `-XX:+UnlockExperimentalVMOptions` to gain access to `-XX:LockingMode`. Otherwise applies cleanly. It needs JDK-8320515 as the followup. >> - **[JDK-8319896](https://bugs.openjdk.org/browse/JDK-8319896): Remove monitor deflation from final audit.** Removes the remaining part that might call into deflation outside of monitor deflation thread. Applies cleanly. Makes JDK-8320515 backport clean. It needs JDK-8325437 as the followup. >> - **[JDK-8320515](https://bugs.openjdk.org/browse/JDK-8320515): assert(monitor->object_peek() != nullptr) failed**. Owned monitors should not have a dead object. Follow-up for JDK-8318757, fixes the JNI interaction problem. Does not apply cleanly due to minor conflict in `JtregNativeHotspot.gmk`. >> - **[JDK-8325437](https://bugs.openjdk.org/browse/JDK-8325437): Safepoint polling in monitor deflation can cause massive logs.** Followup for JDK-8319896, reducing the logs noise. >> >> @stefank -- it looks like you are tasked with backporting some of this to 21.0.4-oracle. Maybe you want to review this PR, which would also allow you to pick it up as commit later? :) >> >> Additional testing: >> - [x] Linux x86_64 server fastdebug, `all` tests pass > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'master' into JDK-MULTI-deflation > - Clean JDK-8325437: Safepoint polling in monitor deflation can cause massive logs > > Backport 52d497619e58a5677bc4a015b1bd87f600f23837 > - Unclean JDK-8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object > > Conflicts in JtregNativeHotspot.gmk due to absent JDK-8311541 > > Reviewed-by: dholmes, ihse, sspitsyn, dcubed > - Clean JDK-8319896: Remove monitor deflation from final audit > > Backport 369bbecc0dab389b523c09bc332fe1cf6394cb26 > - Unclean JDK-8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls > > Needs -XX:+UnlockExperimentalVMOptions in new test > > Backport 87be6b69fe985eee01fc3344f9153d774db792c1 Backport looks good. The only thing to note is that we might want to follow this up with whatever is done to resolve [JDK-8320720](https://bugs.openjdk.org/browse/JDK-8320720). Marked as reviewed by adinn (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/337#pullrequestreview-1939085523 PR Review: https://git.openjdk.org/jdk21u-dev/pull/337#pullrequestreview-1939086494 From sgehwolf at openjdk.org Fri Mar 15 14:35:39 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 15 Mar 2024 14:35:39 GMT Subject: [jdk21u-dev] RFR: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls [v2] In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 09:08:34 GMT, Aleksey Shipilev wrote: >> This resolves potentially catastrophic bug in monitor deflation. Thread dumps are routinely requested by profilers, so it is a real in-production risk. It would be more prominent as we backport improvements in monitor deflation code like [JDK-8319048](https://bugs.openjdk.org/browse/JDK-8319048). The interaction between deflation thread that can be stopped at safepoint in the middle of deflation and the VM op that deflates monitors itself may corrupt the VM state. >> >> This series of backports moves all deflation to monitor deflation thread, avoiding the issue. There are 4 interconnected issues, which are backported here atomically: >> >> - **[JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757): VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls.** The core part, deferring deflation to monitor deflation thread. The new test needs `-XX:+UnlockExperimentalVMOptions` to gain access to `-XX:LockingMode`. Otherwise applies cleanly. It needs JDK-8320515 as the followup. >> - **[JDK-8319896](https://bugs.openjdk.org/browse/JDK-8319896): Remove monitor deflation from final audit.** Removes the remaining part that might call into deflation outside of monitor deflation thread. Applies cleanly. Makes JDK-8320515 backport clean. It needs JDK-8325437 as the followup. >> - **[JDK-8320515](https://bugs.openjdk.org/browse/JDK-8320515): assert(monitor->object_peek() != nullptr) failed**. Owned monitors should not have a dead object. Follow-up for JDK-8318757, fixes the JNI interaction problem. Does not apply cleanly due to minor conflict in `JtregNativeHotspot.gmk`. >> - **[JDK-8325437](https://bugs.openjdk.org/browse/JDK-8325437): Safepoint polling in monitor deflation can cause massive logs.** Followup for JDK-8319896, reducing the logs noise. >> >> @stefank -- it looks like you are tasked with backporting some of this to 21.0.4-oracle. Maybe you want to review this PR, which would also allow you to pick it up as commit later? :) >> >> Additional testing: >> - [x] Linux x86_64 server fastdebug, `all` tests pass > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'master' into JDK-MULTI-deflation > - Clean JDK-8325437: Safepoint polling in monitor deflation can cause massive logs > > Backport 52d497619e58a5677bc4a015b1bd87f600f23837 > - Unclean JDK-8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object > > Conflicts in JtregNativeHotspot.gmk due to absent JDK-8311541 > > Reviewed-by: dholmes, ihse, sspitsyn, dcubed > - Clean JDK-8319896: Remove monitor deflation from final audit > > Backport 369bbecc0dab389b523c09bc332fe1cf6394cb26 > - Unclean JDK-8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls > > Needs -XX:+UnlockExperimentalVMOptions in new test > > Backport 87be6b69fe985eee01fc3344f9153d774db792c1 Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/337#issuecomment-1999797472 From phh at openjdk.org Fri Mar 15 14:36:57 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 15 Mar 2024 14:36:57 GMT Subject: [jdk17u-dev] RFR: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters [v2] In-Reply-To: References: Message-ID: On Thu, 14 Mar 2024 08:10:10 GMT, Amos Shi wrote: >> Backport of [JDK-8320570](https://bugs.openjdk.org/browse/JDK-8320570) >> - `NegativeSize.java` - Clean backport >> - `String.java` - 3 sections change are unclean, the rest are clean. Details as bellow. >> - This PR contains 2 commits >> - The commit 1: is a clean backport part >> - The commit 2: is a manual fix of the following 3 sections, >> - Replace all `new byte[length << 1]` as `StringUTF16.newBytesFor(length)` >> >> >> @@ -592,7 +592,7 @@ >> this.coder = LATIN1; >> return; >> } >> - byte[] utf16 = new byte[length << 1]; >> + byte[] utf16 = StringUTF16.newBytesFor(length); >> StringLatin1.inflate(latin1, 0, utf16, 0, dp); >> dp = decodeUTF8_UTF16(latin1, sp, length, utf16, dp, true); >> if (dp != length) { >> >> >> >> @@ -601,7 +601,7 @@ >> this.value = utf16; >> this.coder = UTF16; >> } else { // !COMPACT_STRINGS >> - byte[] dst = new byte[length << 1]; >> + byte[] dst = StringUTF16.newBytesFor(length); >> int dp = decodeUTF8_UTF16(bytes, offset, offset + length, dst, 0, true); >> if (dp != length) { >> dst = Arrays.copyOf(dst, dp << 1); >> >> >> >> @@ -730,15 +730,15 @@ >> return new String(dst, LATIN1); >> } >> if (dp == 0) { >> - dst = new byte[length << 1]; >> + dst = StringUTF16.newBytesFor(length); >> } else { >> - byte[] buf = new byte[length << 1]; >> + byte[] buf = StringUTF16.newBytesFor(length); >> StringLatin1.inflate(dst, 0, buf, 0, dp); >> dst = buf; >> } >> dp = decodeUTF8_UTF16(bytes, offset, sl, dst, dp, false); >> } else { // !COMPACT_STRINGS >> - dst = new byte[length << 1]; >> + dst = StringUTF16.newBytesFor(length); >> dp = decodeUTF8_UTF16(bytes, offset, offset + length, dst, 0, false); >> } >> if (dp != length) { >> >> >> - ? So this PR can be considered as `semantics clean` >> >> >> Testing >> - Local: >> - Passed on MacOS M1 laptop >> - `test/jdk/java/lang/String/CompactString/NegativeSize.java` - Test results: passed: 1 >> - Passed on Windows 11 >> - `test/jdk/java/lang/String/CompactString/NegativeSize.java` - Test results: passed: 1 >> >> Process... > > Amos Shi has updated the pull request incrementally with one additional commit since the last revision: > > Fix compile error: unmappable character for encoding windows-1252 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2279#pullrequestreview-1939107886 From lucy at openjdk.org Fri Mar 15 15:32:01 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 15 Mar 2024 15:32:01 GMT Subject: [jdk11u-dev] RFR: 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 21:21:21 GMT, Amos Shi wrote: > Backport of [JDK-8061729](https://bugs.openjdk.org/browse/JDK-8061729) - `Test Case Only` > > There are 3 commits in this PR > - Commit 1. `git apply` clean backport from original commit. All files is clean, except `ProxyFromCache.java` > - Commit 2. Manully apply changes to `ProxyFromCache.java`. the following lines in the file cannot be applied automatically, we manually merged the same change. > > > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2006, 2019, Oracle and/or its affiliates. All rights reserved. > + * Copyright (c) 2006, 2022, Oracle and/or its affiliates. All rights reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -25,14 +25,22 @@ > * @test > * @bug 6498566 > * @summary URL.openConnection(Proxy.NO_PROXY) may connect through a proxy. > - * @modules java.base/sun.net.www > * @library /test/lib > * @run main/othervm ProxyFromCache > */ > > -import java.net.*; > -import java.io.*; > -import sun.net.www.MessageHeader; > +import java.io.IOException; > +import java.io.InputStream; > +import java.io.OutputStream; > +import java.net.HttpURLConnection; > +import java.net.InetAddress; > +import java.net.InetSocketAddress; > +import java.net.Proxy; > +import java.net.ServerSocket; > +import java.net.Socket; > +import java.net.URL; > + > +import jdk.test.lib.net.HttpHeaderParser; > import jdk.test.lib.net.URIBuilder; > > /* Creates a simple proxy and http server that just return 200 OK. > > > - Commit 3. Fix compile error in `HttpHeaderParser.java`: the `switch case arrow` is not avaible in Java 11 > > Testing > - Local: Passed on MacOS M1 laptop > - `ProxyFromCache.java` - Test results: passed: 1 > - `RequestURI.java` - Test results: passed: 1 > - `CloseOptionHeader.java` - Test results: passed: 1 > - `HttpHeaderParserTest.java` - Test results: passed: 1 > - `NTLMTest.java` - Test results: passed: 1 > - `NoNTLM.java` - Test results: passed: 1 > - `RetryUponTimeout.java` - Test results: passed: 1 > - `UserAgent.java` - Test results: passed: 1 > - `B6226610.java` - Test results: passed: 1 > - `TunnelProxy.java` - Not a test or directory containing tests: sun/net/www/protocol/https/HttpsURLConnection/TunnelProxy.java > - `HttpHeaderParser.java` - Cannot determine test suite from test (is TEST.ROOT missing?): dev-8061729-11/test/lib/jdk/test/lib/net/HttpHeaderParser.java > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies passed on `2024-03-13,14,15` LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2596#pullrequestreview-1939239595 From rob.mckenna at oracle.com Fri Mar 15 22:43:58 2024 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Fri, 15 Mar 2024 22:43:58 +0000 Subject: [Heads-up] Issue with MacOS 14.4 on Apple silicon Message-ID: Hi folks, Apple?s final release of the 14.4 update to macOS 14 Sonoma causes some Java applications on Apple silicon systems (M1/M2/M3) to terminate unexpectedly. The issue is not present on Intel-based systems, and it affects all supported Java releases. More information: https://bugs.openjdk.org/browse/JDK-8327860 -Rob From mdoerr at openjdk.org Sat Mar 16 22:27:36 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Sat, 16 Mar 2024 22:27:36 GMT Subject: [jdk17u-dev] Integrated: 8325326: [PPC64] Don't relocate in case of allocation failure In-Reply-To: References: Message-ID: On Sat, 9 Mar 2024 03:49:50 GMT, Martin Doerr wrote: > Clean backport of [JDK-8325326](https://bugs.openjdk.org/browse/JDK-8325326). This pull request has now been integrated. Changeset: b0e33862 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/b0e338620cddbaed8c265eacf4a2683771fdf7c7 Stats: 12 lines in 1 file changed: 6 ins; 2 del; 4 mod 8325326: [PPC64] Don't relocate in case of allocation failure Backport-of: 4388095cde20dec602ada9fe2977f1a359ceab91 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2280 From mdoerr at openjdk.org Sat Mar 16 22:27:38 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Sat, 16 Mar 2024 22:27:38 GMT Subject: [jdk17u-dev] Integrated: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 12:36:53 GMT, Martin Doerr wrote: > Clean backport of [JDK-8326101](https://bugs.openjdk.org/browse/JDK-8326101) from JDK 22u. This pull request has now been integrated. Changeset: fce02ad5 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/fce02ad5cb321bbcf63c8476cd28821b3e187e5b Stats: 11 lines in 2 files changed: 9 ins; 0 del; 2 mod 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space Backport-of: e3ae81eeeee8e2b0063a576a90624dd927b512f0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2289 From mdoerr at openjdk.org Sat Mar 16 22:28:43 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Sat, 16 Mar 2024 22:28:43 GMT Subject: [jdk11u-dev] RFR: 8325326: [PPC64] Don't relocate in case of allocation failure Message-ID: Clean backport of [JDK-8325326](https://bugs.openjdk.org/browse/JDK-8325326). ------------- Commit messages: - Backport 4388095cde20dec602ada9fe2977f1a359ceab91 Changes: https://git.openjdk.org/jdk11u-dev/pull/2603/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2603&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325326 Stats: 12 lines in 1 file changed: 6 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2603.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2603/head:pull/2603 PR: https://git.openjdk.org/jdk11u-dev/pull/2603 From mdoerr at openjdk.org Sat Mar 16 22:28:48 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Sat, 16 Mar 2024 22:28:48 GMT Subject: [jdk11u-dev] RFR: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space Message-ID: Backport of [JDK-8326101](https://bugs.openjdk.org/browse/JDK-8326101). Version from 22u applies cleanly, but 11u uses `NULL` instead of `nullptr` (replaced by 2nd commit). ------------- Commit messages: - 11u uses NULL instead of nullptr. - Backport e3ae81eeeee8e2b0063a576a90624dd927b512f0 Changes: https://git.openjdk.org/jdk11u-dev/pull/2604/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2604&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326101 Stats: 11 lines in 2 files changed: 9 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2604.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2604/head:pull/2604 PR: https://git.openjdk.org/jdk11u-dev/pull/2604 From andrewlu at openjdk.org Mon Mar 18 05:58:41 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 18 Mar 2024 05:58:41 GMT Subject: [jdk11u-dev] RFR: 8313206: PKCS11 tests silently skip execution Message-ID: 8313206: PKCS11 tests silently skip execution ------------- Commit messages: - Merge branch 'master' into andrewLu_backport_8313206 - Backport 7c4aaec0dc74badb8363c10d2a10a29e85ceb246 Changes: https://git.openjdk.org/jdk11u-dev/pull/2605/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2605&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313206 Stats: 343 lines in 9 files changed: 149 ins; 90 del; 104 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2605.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2605/head:pull/2605 PR: https://git.openjdk.org/jdk11u-dev/pull/2605 From andrewlu at openjdk.org Mon Mar 18 06:11:43 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 18 Mar 2024 06:11:43 GMT Subject: [jdk11u-dev] RFR: 8313206: PKCS11 tests silently skip execution [v2] In-Reply-To: References: Message-ID: <3MTfIujcUcpkUpAk9fe-s56S2efQ6nqCuT2SsPyAtdM=.4231aa43-7a39-4930-902d-b32d8e86a2e2@github.com> > 8313206: PKCS11 tests silently skip execution Andrew Lu has updated the pull request incrementally with two additional commits since the last revision: - Merge remote-tracking branch 'origin/andrewLu_backport_8313206' into andrewLu_backport_8313206 # Conflicts: # test/jdk/sun/security/pkcs11/PKCS11Test.java - Merge remote-tracking branch 'origin/master' into andrewLu_backport_8313206 # Conflicts: # test/jdk/sun/security/pkcs11/PKCS11Test.java ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2605/files - new: https://git.openjdk.org/jdk11u-dev/pull/2605/files/dca018f8..2e6a3a54 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2605&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2605&range=00-01 Stats: 28 lines in 1 file changed: 23 ins; 3 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2605.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2605/head:pull/2605 PR: https://git.openjdk.org/jdk11u-dev/pull/2605 From andrewlu at openjdk.org Mon Mar 18 06:50:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 18 Mar 2024 06:50:40 GMT Subject: [jdk11u-dev] RFR: 8210988: Improved handling of compiler warnings in the build Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 09a967ab8143c3d4b0824a0027edaf0e634686ec Changes: https://git.openjdk.org/jdk11u-dev/pull/2606/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2606&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8210988 Stats: 111 lines in 6 files changed: 72 ins; 14 del; 25 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2606.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2606/head:pull/2606 PR: https://git.openjdk.org/jdk11u-dev/pull/2606 From goetz at openjdk.org Mon Mar 18 07:02:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Mar 2024 07:02:31 GMT Subject: [jdk11u-dev] RFR: 8292717: Clean up checking of testing requirements in configure In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 14:39:48 GMT, Goetz Lindenmaier wrote: > I backport this because then 8314495 can be backported clean. Also brings 11 closer to 17. > > configure.ac:: > I had to resolve two chunks. In one, I needed to omit the coding for JMH which is not > supported by 11. > > jdk-options.m4, toolchanin.m4 > Deleted function has different body, deleted by hand. > > lib-tests.m4: Copyright. > > The original change moves and renames three > functions to lib-tests.m4. It does not change > the implementation of these. > So I modified the added code in lib-tests.m4 > to have the unchanged function bodies that > were deleted in the other files. Hi @shipilev, I figured it works smoothest if I backport in the order they arrived in 17. So I handled this one now. You might want to have a look, should be familiar :) Best, Goetz. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2600#issuecomment-2003057944 From pkumaraswamy at openjdk.org Mon Mar 18 07:23:40 2024 From: pkumaraswamy at openjdk.org (Prajwal Kumaraswamy) Date: Mon, 18 Mar 2024 07:23:40 GMT Subject: [jdk22u] RFR: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection Message-ID: This is a clean backport. I have verified the fix and results are attached here [x509_testing.zip](https://github.com/openjdk/jdk22u/files/14632318/x509_testing.zip) ------------- Commit messages: - Backport bdd1aebea379b63ae405827074530ef8e8a7c239 Changes: https://git.openjdk.org/jdk22u/pull/103/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=103&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312383 Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/103.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/103/head:pull/103 PR: https://git.openjdk.org/jdk22u/pull/103 From goetz at openjdk.org Mon Mar 18 07:44:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Mar 2024 07:44:42 GMT Subject: [jdk17u-dev] RFR: 8015739: Background of JInternalFrame is located out of JInternalFrame Message-ID: <5OL8KoWVV4kIPUWr-FQeVbda27IQ5Yjm_gO5gVx8Q6M=.74ebb34e-9594-4f92-a3a9-78e581ceaf3b@github.com> I backport this for parity with 17.0.12-oracle. Resolved Copyright, will mark clean if needed. ------------- Commit messages: - Backport f857f795a9fc8b116bfc6b039114051061950e28 Changes: https://git.openjdk.org/jdk17u-dev/pull/2301/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2301&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8015739 Stats: 408 lines in 2 files changed: 360 ins; 8 del; 40 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2301.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2301/head:pull/2301 PR: https://git.openjdk.org/jdk17u-dev/pull/2301 From shade at openjdk.org Mon Mar 18 09:02:43 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 18 Mar 2024 09:02:43 GMT Subject: [jdk21u-dev] RFR: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls [v2] In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 09:08:34 GMT, Aleksey Shipilev wrote: >> This resolves potentially catastrophic bug in monitor deflation. Thread dumps are routinely requested by profilers, so it is a real in-production risk. It would be more prominent as we backport improvements in monitor deflation code like [JDK-8319048](https://bugs.openjdk.org/browse/JDK-8319048). The interaction between deflation thread that can be stopped at safepoint in the middle of deflation and the VM op that deflates monitors itself may corrupt the VM state. >> >> This series of backports moves all deflation to monitor deflation thread, avoiding the issue. There are 4 interconnected issues, which are backported here atomically: >> >> - **[JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757): VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls.** The core part, deferring deflation to monitor deflation thread. The new test needs `-XX:+UnlockExperimentalVMOptions` to gain access to `-XX:LockingMode`. Otherwise applies cleanly. It needs JDK-8320515 as the followup. >> - **[JDK-8319896](https://bugs.openjdk.org/browse/JDK-8319896): Remove monitor deflation from final audit.** Removes the remaining part that might call into deflation outside of monitor deflation thread. Applies cleanly. Makes JDK-8320515 backport clean. It needs JDK-8325437 as the followup. >> - **[JDK-8320515](https://bugs.openjdk.org/browse/JDK-8320515): assert(monitor->object_peek() != nullptr) failed**. Owned monitors should not have a dead object. Follow-up for JDK-8318757, fixes the JNI interaction problem. Does not apply cleanly due to minor conflict in `JtregNativeHotspot.gmk`. >> - **[JDK-8325437](https://bugs.openjdk.org/browse/JDK-8325437): Safepoint polling in monitor deflation can cause massive logs.** Followup for JDK-8319896, reducing the logs noise. >> >> @stefank -- it looks like you are tasked with backporting some of this to 21.0.4-oracle. Maybe you want to review this PR, which would also allow you to pick it up as commit later? :) >> >> Additional testing: >> - [x] Linux x86_64 server fastdebug, `all` tests pass > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'master' into JDK-MULTI-deflation > - Clean JDK-8325437: Safepoint polling in monitor deflation can cause massive logs > > Backport 52d497619e58a5677bc4a015b1bd87f600f23837 > - Unclean JDK-8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object > > Conflicts in JtregNativeHotspot.gmk due to absent JDK-8311541 > > Reviewed-by: dholmes, ihse, sspitsyn, dcubed > - Clean JDK-8319896: Remove monitor deflation from final audit > > Backport 369bbecc0dab389b523c09bc332fe1cf6394cb26 > - Unclean JDK-8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls > > Needs -XX:+UnlockExperimentalVMOptions in new test > > Backport 87be6b69fe985eee01fc3344f9153d774db792c1 Thanks all! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/337#issuecomment-2003240192 From shade at openjdk.org Mon Mar 18 09:02:44 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 18 Mar 2024 09:02:44 GMT Subject: [jdk21u-dev] Integrated: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 19:12:00 GMT, Aleksey Shipilev wrote: > This resolves potentially catastrophic bug in monitor deflation. Thread dumps are routinely requested by profilers, so it is a real in-production risk. It would be more prominent as we backport improvements in monitor deflation code like [JDK-8319048](https://bugs.openjdk.org/browse/JDK-8319048). The interaction between deflation thread that can be stopped at safepoint in the middle of deflation and the VM op that deflates monitors itself may corrupt the VM state. > > This series of backports moves all deflation to monitor deflation thread, avoiding the issue. There are 4 interconnected issues, which are backported here atomically: > > - **[JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757): VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls.** The core part, deferring deflation to monitor deflation thread. The new test needs `-XX:+UnlockExperimentalVMOptions` to gain access to `-XX:LockingMode`. Otherwise applies cleanly. It needs JDK-8320515 as the followup. > - **[JDK-8319896](https://bugs.openjdk.org/browse/JDK-8319896): Remove monitor deflation from final audit.** Removes the remaining part that might call into deflation outside of monitor deflation thread. Applies cleanly. Makes JDK-8320515 backport clean. It needs JDK-8325437 as the followup. > - **[JDK-8320515](https://bugs.openjdk.org/browse/JDK-8320515): assert(monitor->object_peek() != nullptr) failed**. Owned monitors should not have a dead object. Follow-up for JDK-8318757, fixes the JNI interaction problem. Does not apply cleanly due to minor conflict in `JtregNativeHotspot.gmk`. > - **[JDK-8325437](https://bugs.openjdk.org/browse/JDK-8325437): Safepoint polling in monitor deflation can cause massive logs.** Followup for JDK-8319896, reducing the logs noise. > > @stefank -- it looks like you are tasked with backporting some of this to 21.0.4-oracle. Maybe you want to review this PR, which would also allow you to pick it up as commit later? :) > > Additional testing: > - [x] Linux x86_64 server fastdebug, `all` tests pass This pull request has now been integrated. Changeset: d1af31b6 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/d1af31b6098f4c55d05aa8693ff09f6dcc1e118a Stats: 819 lines in 17 files changed: 552 ins; 177 del; 90 mod 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls 8319896: Remove monitor deflation from final audit 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object 8325437: Safepoint polling in monitor deflation can cause massive logs Reviewed-by: stefank, adinn Backport-of: 87be6b69fe985eee01fc3344f9153d774db792c1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/337 From goetz at openjdk.org Mon Mar 18 09:14:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Mar 2024 09:14:41 GMT Subject: [jdk21u-dev] RFR: 8309757: com/sun/jdi/ReferrersTest.java fails with virtual test thread factory Message-ID: I backport this for parity with 21.0.4-oracle. Resolved ProblemList, will mark clean. ------------- Commit messages: - Backport d7251c1755779f8c4fdeac16ccb797ed45b1dfd4 Changes: https://git.openjdk.org/jdk21u-dev/pull/367/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=367&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309757 Stats: 5 lines in 2 files changed: 3 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/367.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/367/head:pull/367 PR: https://git.openjdk.org/jdk21u-dev/pull/367 From andrewlu at openjdk.org Mon Mar 18 09:18:01 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 18 Mar 2024 09:18:01 GMT Subject: [jdk21u-dev] RFR: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport bdd1aebea379b63ae405827074530ef8e8a7c239 Changes: https://git.openjdk.org/jdk21u-dev/pull/368/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=368&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312383 Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/368.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/368/head:pull/368 PR: https://git.openjdk.org/jdk21u-dev/pull/368 From pkumaraswamy at openjdk.org Mon Mar 18 10:10:33 2024 From: pkumaraswamy at openjdk.org (Prajwal Kumaraswamy) Date: Mon, 18 Mar 2024 10:10:33 GMT Subject: [jdk22u] Integrated: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 07:19:11 GMT, Prajwal Kumaraswamy wrote: > This is a clean backport. > > I have verified the fix and results are attached here > [x509_testing.zip](https://github.com/openjdk/jdk22u/files/14632318/x509_testing.zip) This pull request has now been integrated. Changeset: 2ec72f96 Author: Prajwal Kumaraswamy Committer: Sean Coffey URL: https://git.openjdk.org/jdk22u/commit/2ec72f96d2f6c14616dcf37b409679f7052f164a Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection Backport-of: bdd1aebea379b63ae405827074530ef8e8a7c239 ------------- PR: https://git.openjdk.org/jdk22u/pull/103 From shade at openjdk.org Mon Mar 18 10:10:38 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 18 Mar 2024 10:10:38 GMT Subject: [jdk11u-dev] RFR: 8292717: Clean up checking of testing requirements in configure In-Reply-To: References: Message-ID: <7zyYjPElgCDoH7NBJLGGgiPbjn5jhJ4PmIBZlRPBOF4=.e20cc73d-6f11-4ed9-bec5-3a1ed4d49d51@github.com> On Tue, 12 Mar 2024 14:39:48 GMT, Goetz Lindenmaier wrote: > I backport this because then 8314495 can be backported clean. Also brings 11 closer to 17. > > configure.ac:: > I had to resolve two chunks. In one, I needed to omit the coding for JMH which is not > supported by 11. > > jdk-options.m4, toolchanin.m4 > Deleted function has different body, deleted by hand. > > lib-tests.m4: Copyright. > > The original change moves and renames three > functions to lib-tests.m4. It does not change > the implementation of these. > So I modified the added code in lib-tests.m4 > to have the unchanged function bodies that > were deleted in the other files. This looks fine, thanks. It is generally hard to check that we have not introduced bugs while doing these move, but as long as they are mostly mechanical, I think we are safer. I don't see the `JTREG_MINIMUM_VERSION=6.1` hunk in the original commit (https://github.com/openjdk/jdk/commit/16593cf51c3d994ba4a6d28ab97e519dfd53f37b), but I guess we need to move it from `toolchain.m4` for 11u-dev. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2600#pullrequestreview-1942507071 From goetz at openjdk.org Mon Mar 18 10:11:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Mar 2024 10:11:31 GMT Subject: [jdk17u-dev] RFR: 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList Message-ID: <66_mtZaNYuLiXnzbFi0y9z_3o29tnnXKHiBCCw5Wni8=.dc3ddedf-2157-4724-b6e6-70adfc0cf4d9@github.com> I backport this for parity with 17.0.12-oracle. Resolved ProblemList, will mark clean. ------------- Commit messages: - Backport 8d29329138d44800ee4c0c02dacc01a06097de66 Changes: https://git.openjdk.org/jdk17u-dev/pull/2302/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2302&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312320 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2302.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2302/head:pull/2302 PR: https://git.openjdk.org/jdk17u-dev/pull/2302 From andrewlu at openjdk.org Mon Mar 18 10:12:42 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 18 Mar 2024 10:12:42 GMT Subject: [jdk17u-dev] RFR: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport bdd1aebea379b63ae405827074530ef8e8a7c239 Changes: https://git.openjdk.org/jdk17u-dev/pull/2303/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2303&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312383 Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2303.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2303/head:pull/2303 PR: https://git.openjdk.org/jdk17u-dev/pull/2303 From shade at openjdk.org Mon Mar 18 10:13:51 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 18 Mar 2024 10:13:51 GMT Subject: [jdk21u-dev] RFR: 8319048: Monitor deflation unlink phase prolongs time to safepoint Message-ID: Clean backport to improve TTSP under heavy monitor deflation, and provide better parity. Additional testing: - [x] Ad-hoc benchmarks show TTSP improvements - [x] MacOS AArch64 server fastdebug, `runtime/Monitor` passes - [ ] Linux AArch64 server fastdebug, `all` ------------- Commit messages: - Backport efc392259c64986bbbe880259e95b09058b9076a Changes: https://git.openjdk.org/jdk21u-dev/pull/369/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=369&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319048 Stats: 235 lines in 4 files changed: 221 ins; 0 del; 14 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/369.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/369/head:pull/369 PR: https://git.openjdk.org/jdk21u-dev/pull/369 From shade at openjdk.org Mon Mar 18 10:13:56 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 18 Mar 2024 10:13:56 GMT Subject: [jdk22u] RFR: 8325613: CTW: Stale method cleanup requires GC after Sweeper removal Message-ID: Clean backport to improve CTW testing times. Additional testing: - [x] Ad-hoc CTW time measurements for `java.base` demonstrate the same improvements as in mainline - [x] MacOS AArch64 server fastdebug, `applications/ctw/modules` passes ------------- Commit messages: - Backport 1281e18f1447848d7eb5e3bde508ac002b4c390d Changes: https://git.openjdk.org/jdk22u/pull/104/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=104&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325613 Stats: 26 lines in 2 files changed: 24 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/104.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/104/head:pull/104 PR: https://git.openjdk.org/jdk22u/pull/104 From shade at openjdk.org Mon Mar 18 10:15:56 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 18 Mar 2024 10:15:56 GMT Subject: [jdk21u-dev] RFR: 8325613: CTW: Stale method cleanup requires GC after Sweeper removal Message-ID: Clean backport to improve CTW testing times. Additional testing: - [x] Ad-hoc CTW time measurements for `java.base` demonstrate the same improvements as in mainline - [x] Linux x86_64 server fastdebug, large CTW runs pass with this patch applied - [x] MacOS AArch64 server fastdebug, `applications/ctw/modules` passes ------------- Commit messages: - Backport 1281e18f1447848d7eb5e3bde508ac002b4c390d Changes: https://git.openjdk.org/jdk21u-dev/pull/370/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=370&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325613 Stats: 26 lines in 2 files changed: 24 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/370.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/370/head:pull/370 PR: https://git.openjdk.org/jdk21u-dev/pull/370 From mdoerr at openjdk.org Mon Mar 18 10:30:36 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 18 Mar 2024 10:30:36 GMT Subject: [jdk11u-dev] RFR: 8292717: Clean up checking of testing requirements in configure In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 14:39:48 GMT, Goetz Lindenmaier wrote: > I backport this because then 8314495 can be backported clean. Also brings 11 closer to 17. > > configure.ac:: > I had to resolve two chunks. In one, I needed to omit the coding for JMH which is not > supported by 11. > > jdk-options.m4, toolchanin.m4 > Deleted function has different body, deleted by hand. > > lib-tests.m4: Copyright. > > The original change moves and renames three > functions to lib-tests.m4. It does not change > the implementation of these. > So I modified the added code in lib-tests.m4 > to have the unchanged function bodies that > were deleted in the other files. I think it's good. Feel free to add the empty line. make/autoconf/configure.ac line 235: > 233: > 234: JDKOPT_DETECT_INTREE_EC > 235: LIB_TESTS_ENABLE_DISABLE_FAILURE_HANDLER Original change inserts an empty line here. make/autoconf/lib-tests.m4 line 31: > 29: > 30: # Minimum supported version > 31: JTREG_MINIMUM_VERSION=6.1 Moving the stuff here from the deleted file is probably ok. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2600#pullrequestreview-1942527935 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2600#discussion_r1528264297 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2600#discussion_r1528268158 From mdoerr at openjdk.org Mon Mar 18 10:34:34 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 18 Mar 2024 10:34:34 GMT Subject: [jdk11u-dev] RFR: 8325326: [PPC64] Don't relocate in case of allocation failure In-Reply-To: References: Message-ID: On Fri, 15 Mar 2024 20:11:05 GMT, Martin Doerr wrote: > Clean backport of [JDK-8325326](https://bugs.openjdk.org/browse/JDK-8325326). GHA failure is obviously unrelated. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2603#issuecomment-2003522656 From duke at openjdk.org Mon Mar 18 10:57:29 2024 From: duke at openjdk.org (Robert Toyonaga) Date: Mon, 18 Mar 2024 10:57:29 GMT Subject: [jdk22u] Integrated: 8326529: JFR: Test for CompilerCompile events fails due to time out In-Reply-To: References: Message-ID: On Fri, 8 Mar 2024 21:47:18 GMT, Robert Toyonaga wrote: > This is a backport of https://github.com/openjdk/jdk/commit/4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 > > This backport limits compilation only to the test methods [TestCompileCompile](https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/compiler/TestCompilerCompile.java) cares about. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3046). This pull request has now been integrated. Changeset: 6c2eefce Author: Robert Toyonaga Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/6c2eefce48f95732ebfe6cd7ea9d997d67aab37e Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8326529: JFR: Test for CompilerCompile events fails due to time out Backport-of: 4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 ------------- PR: https://git.openjdk.org/jdk22u/pull/93 From wkemper at openjdk.org Mon Mar 18 11:01:27 2024 From: wkemper at openjdk.org (William Kemper) Date: Mon, 18 Mar 2024 11:01:27 GMT Subject: [jdk22u] Integrated: 8322503: Shenandoah: Clarify gc state usage In-Reply-To: <2p7vfWpajqutKf2QdTj9zTDfgwTzt1uIAJV6P6ob0m4=.689544e9-ac28-4243-b33e-a453f606c2d6@github.com> References: <2p7vfWpajqutKf2QdTj9zTDfgwTzt1uIAJV6P6ob0m4=.689544e9-ac28-4243-b33e-a453f606c2d6@github.com> Message-ID: On Wed, 13 Mar 2024 23:36:20 GMT, William Kemper wrote: > Clean backport. This is a follow up to https://bugs.openjdk.org/browse/JDK-8321815, which renames methods and changes comments and adds an assert for improved readability. This pull request has now been integrated. Changeset: afce5e62 Author: William Kemper Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/afce5e6229c597ab89ba153a88cfd03dbbae7b00 Stats: 26 lines in 5 files changed: 8 ins; 0 del; 18 mod 8322503: Shenandoah: Clarify gc state usage Backport-of: 51238c4bdbce48f6b719f7dcfe5b7df8b8c6d85b ------------- PR: https://git.openjdk.org/jdk22u/pull/101 From goetz at openjdk.org Mon Mar 18 11:31:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Mar 2024 11:31:44 GMT Subject: [jdk11u-dev] RFR: 8292717: Clean up checking of testing requirements in configure [v2] In-Reply-To: References: Message-ID: > I backport this because then 8314495 can be backported clean. Also brings 11 closer to 17. > > configure.ac:: > I had to resolve two chunks. In one, I needed to omit the coding for JMH which is not > supported by 11. > > jdk-options.m4, toolchanin.m4 > Deleted function has different body, deleted by hand. > > lib-tests.m4: Copyright. > > The original change moves and renames three > functions to lib-tests.m4. It does not change > the implementation of these. > So I modified the added code in lib-tests.m4 > to have the unchanged function bodies that > were deleted in the other files. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Add line break ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2600/files - new: https://git.openjdk.org/jdk11u-dev/pull/2600/files/2b85a35e..f1776f89 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2600&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2600&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2600.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2600/head:pull/2600 PR: https://git.openjdk.org/jdk11u-dev/pull/2600 From shade at openjdk.org Mon Mar 18 12:31:35 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 18 Mar 2024 12:31:35 GMT Subject: [jdk21u-dev] RFR: 8325613: CTW: Stale method cleanup requires GC after Sweeper removal In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 09:55:26 GMT, Aleksey Shipilev wrote: > Clean backport to improve CTW testing times. > > Additional testing: > - [x] Ad-hoc CTW time measurements for `java.base` demonstrate the same improvements as in mainline > - [x] Linux x86_64 server fastdebug, large CTW runs pass with this patch applied > - [x] MacOS AArch64 server fastdebug, `applications/ctw/modules` passes GHA test failures are environmental. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/370#issuecomment-2003782811 From goetz at openjdk.org Mon Mar 18 12:52:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Mar 2024 12:52:42 GMT Subject: [jdk21u-dev] RFR: 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 8d29329138d44800ee4c0c02dacc01a06097de66 Changes: https://git.openjdk.org/jdk21u-dev/pull/371/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=371&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312320 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/371.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/371/head:pull/371 PR: https://git.openjdk.org/jdk21u-dev/pull/371 From goetz at openjdk.org Mon Mar 18 12:56:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Mar 2024 12:56:35 GMT Subject: [jdk21u-dev] RFR: 8316696: Remove the testing base classes: IntlTest and CollatorTest Message-ID: <7T2mvkq0ivrmapqbc5gKp2PLH8eqIb_Bm-nLlyg9eNc=.bd0c0f76-7933-49db-a2b0-ce4bcff5475a@github.com> I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport b859da9c548fbd1463b336059d1c55312c7b7ba4 Changes: https://git.openjdk.org/jdk21u-dev/pull/372/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=372&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316696 Stats: 4465 lines in 79 files changed: 922 ins; 1081 del; 2462 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/372.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/372/head:pull/372 PR: https://git.openjdk.org/jdk21u-dev/pull/372 From goetz at openjdk.org Mon Mar 18 14:09:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Mar 2024 14:09:29 GMT Subject: [jdk21u-dev] RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn In-Reply-To: References: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> Message-ID: On Thu, 14 Mar 2024 16:43:26 GMT, Oli Gillespie wrote: >> @olivergillespie This looks like it'll need a backport of [JDK-8321276](https://bugs.openjdk.org/browse/JDK-8321276) as well? > > @jerboaa Yes, thanks for catching, sorry I missed that. I'm not sure the procedure for dependent backports, and I don't have time this week to work on it - I'll try to do so next week if that's okay. I can re-request approval once I have it figured out. @olivergillespie, you can includ JDK-8321276 in this change (push an extra commit, add the issue with the /issue command, get a review) If you backport this to 17, which I think is required, too, you can grab the commit from 21 and get both backported at once. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/154#issuecomment-2004017892 From goetz at openjdk.org Mon Mar 18 14:20:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Mar 2024 14:20:55 GMT Subject: [jdk21u-dev] RFR: 8288989: Make tests not depend on the source code Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 2838a916ab98cb0152f8b1e3f96eccca198af5e9 Changes: https://git.openjdk.org/jdk21u-dev/pull/373/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=373&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288989 Stats: 11 lines in 2 files changed: 8 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/373.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/373/head:pull/373 PR: https://git.openjdk.org/jdk21u-dev/pull/373 From goetz at openjdk.org Mon Mar 18 14:24:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Mar 2024 14:24:38 GMT Subject: [jdk21u-dev] RFR: 8322920: Some ProcessTools.execute* functions are declared to throw Throwable Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 868f8745faf70c915d8294ae8f85b2d6aa096900 Changes: https://git.openjdk.org/jdk21u-dev/pull/374/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=374&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322920 Stats: 6 lines in 1 file changed: 0 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/374.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/374/head:pull/374 PR: https://git.openjdk.org/jdk21u-dev/pull/374 From goetz at openjdk.org Mon Mar 18 14:44:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Mar 2024 14:44:55 GMT Subject: [jdk17u-dev] RFR: 8322920: Some ProcessTools.execute* functions are declared to throw Throwable Message-ID: I backport this to keep the testing tools up to date. Resolved Copyright, will mark clean. ------------- Commit messages: - Backport 868f8745faf70c915d8294ae8f85b2d6aa096900 Changes: https://git.openjdk.org/jdk17u-dev/pull/2304/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2304&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322920 Stats: 6 lines in 1 file changed: 0 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2304.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2304/head:pull/2304 PR: https://git.openjdk.org/jdk17u-dev/pull/2304 From goetz at openjdk.org Mon Mar 18 14:56:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 18 Mar 2024 14:56:51 GMT Subject: [jdk21u-dev] RFR: 8223696: java/net/httpclient/MaxStreams.java failed with didn't finish within the time-out Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 95310eab6ce73512b1afc0a7a26a396dd7b6cb7c Changes: https://git.openjdk.org/jdk21u-dev/pull/375/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=375&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8223696 Stats: 25 lines in 1 file changed: 6 ins; 15 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/375.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/375/head:pull/375 PR: https://git.openjdk.org/jdk21u-dev/pull/375 From duke at openjdk.org Mon Mar 18 15:45:41 2024 From: duke at openjdk.org (Robert Toyonaga) Date: Mon, 18 Mar 2024 15:45:41 GMT Subject: [jdk21u-dev] RFR: 8326529: JFR: Test for CompilerCompile events fails due to time out Message-ID: This is a backport of https://github.com/openjdk/jdk/commit/4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 This backport limits compilation only to the test methods [TestCompileCompile](https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/compiler/TestCompilerCompile.java) cares about. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3046). ------------- Commit messages: - Backport 4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 Changes: https://git.openjdk.org/jdk21u-dev/pull/376/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=376&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326529 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/376.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/376/head:pull/376 PR: https://git.openjdk.org/jdk21u-dev/pull/376 From ogillespie at openjdk.org Mon Mar 18 15:47:49 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Mon, 18 Mar 2024 15:47:49 GMT Subject: [jdk21u-dev] RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn [v2] In-Reply-To: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> References: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> Message-ID: > Hi all, > > This pull request contains a backport of commit [d23f4f12](https://github.com/openjdk/jdk/commit/d23f4f12adf1ea26b8c340efe2c3854e50b68301) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Oli Gillespie on 4 Dec 2023 and was reviewed by Coleen Phillimore, Kim Barrett and Aleksey Shipilev. > > Thanks! Oli Gillespie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - 8321276: runtime/cds/appcds/dynamicArchive/DynamicSharedSymbols.java failed with "'17 2: jdk/test/lib/apps ' missing from stdout/stderr" Reviewed-by: dcubed - Merge remote-tracking branch 'origin/master' into backport-olivergillespie-d23f4f12 - Backport d23f4f12adf1ea26b8c340efe2c3854e50b68301 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/154/files - new: https://git.openjdk.org/jdk21u-dev/pull/154/files/1b8c01ef..8315ce69 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=154&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=154&range=00-01 Stats: 22207 lines in 780 files changed: 14996 ins; 4592 del; 2619 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/154.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/154/head:pull/154 PR: https://git.openjdk.org/jdk21u-dev/pull/154 From ogillespie at openjdk.org Mon Mar 18 15:47:49 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Mon, 18 Mar 2024 15:47:49 GMT Subject: [jdk21u-dev] RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn In-Reply-To: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> References: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> Message-ID: On Tue, 9 Jan 2024 16:46:27 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [d23f4f12](https://github.com/openjdk/jdk/commit/d23f4f12adf1ea26b8c340efe2c3854e50b68301) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Oli Gillespie on 4 Dec 2023 and was reviewed by Coleen Phillimore, Kim Barrett and Aleksey Shipilev. > > Thanks! Thanks! I have added the fix for JDK-8321276 as a new commit. It applied cleanly. I confirmed that the test (`make test TEST=runtime/cds/appcds/dynamicArchive/DynamicSharedSymbols.java`) failed before, and passes after. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/154#issuecomment-2004265799 From shade at openjdk.org Mon Mar 18 16:06:40 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 18 Mar 2024 16:06:40 GMT Subject: [jdk17u-dev] RFR: 8318986: Improve GenericWaitBarrier performance Message-ID: Clean backport to drastically improve safepoint performance under heavy load, fixing regression between JDK 11 and JDK 17. Additional testing: - [x] Ad-hoc performance runs, expected improvements - [x] MacOS AArch64 server fastdebug, `tier{1,2,3}` ------------- Commit messages: - Merge branch 'master' into JDK-8318986-generic-wait-barrier - Backport 30462f9da40d3a7ec18fcf46e2154fabb5fd4753 Changes: https://git.openjdk.org/jdk17u-dev/pull/2041/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2041&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318986 Stats: 286 lines in 2 files changed: 225 ins; 12 del; 49 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2041.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2041/head:pull/2041 PR: https://git.openjdk.org/jdk17u-dev/pull/2041 From shade at openjdk.org Mon Mar 18 16:06:40 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 18 Mar 2024 16:06:40 GMT Subject: [jdk17u-dev] RFR: 8318986: Improve GenericWaitBarrier performance In-Reply-To: References: Message-ID: On Mon, 11 Dec 2023 17:39:49 GMT, Aleksey Shipilev wrote: > Clean backport to drastically improve safepoint performance under heavy load, fixing regression between JDK 11 and JDK 17. > > Additional testing: > - [x] Ad-hoc performance runs, expected improvements > - [x] MacOS AArch64 server fastdebug, `tier{1,2,3}` Not now, bot. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2041#issuecomment-1929124372 From duke at openjdk.org Mon Mar 18 16:14:45 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Mon, 18 Mar 2024 16:14:45 GMT Subject: [jdk11u-dev] RFR: 8261302: NMT: Improve malloc site table hashing Message-ID: This is the same fix that was applied in https://github.com/openjdk/jdk/commit/a3d6e371 for https://bugs.openjdk.org/browse/JDK-8261302 It simplifies the way of calculating the hash of a stack. ------------- Commit messages: - 8261302: NMT: Improve malloc site table hashing Changes: https://git.openjdk.org/jdk11u-dev/pull/2608/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2608&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8261302 Stats: 29 lines in 2 files changed: 9 ins; 16 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2608.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2608/head:pull/2608 PR: https://git.openjdk.org/jdk11u-dev/pull/2608 From stuefe at openjdk.org Mon Mar 18 16:28:34 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 18 Mar 2024 16:28:34 GMT Subject: [jdk11u-dev] RFR: 8261302: NMT: Improve malloc site table hashing In-Reply-To: References: Message-ID: <1H4j2o2Ediy-7a83VEjsc0-al9I8AlSLGdzDqCNd2Ao=.64084d3b-23c0-4b7c-9b1b-c397fcae0596@github.com> On Mon, 18 Mar 2024 16:09:59 GMT, Mar?a Arias de Reyna wrote: > This is the same fix that was applied in https://github.com/openjdk/jdk/commit/a3d6e371 for https://bugs.openjdk.org/browse/JDK-8261302 > > It simplifies the way of calculating the hash of a stack. Good. Please note that this also needs [JDK-8261520](https://bugs.openjdk.org/browse/JDK-8261520) as a follow-up. ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2608#pullrequestreview-1943594209 From ogillespie at openjdk.org Mon Mar 18 17:27:34 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Mon, 18 Mar 2024 17:27:34 GMT Subject: [jdk21u-dev] RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn [v2] In-Reply-To: References: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> Message-ID: On Mon, 18 Mar 2024 15:47:49 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [d23f4f12](https://github.com/openjdk/jdk/commit/d23f4f12adf1ea26b8c340efe2c3854e50b68301) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Oli Gillespie on 4 Dec 2023 and was reviewed by Coleen Phillimore, Kim Barrett and Aleksey Shipilev. >> >> Thanks! > > Oli Gillespie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - 8321276: runtime/cds/appcds/dynamicArchive/DynamicSharedSymbols.java failed with "'17 2: jdk/test/lib/apps ' missing from stdout/stderr" > > Reviewed-by: dcubed > - Merge remote-tracking branch 'origin/master' into backport-olivergillespie-d23f4f12 > - Backport d23f4f12adf1ea26b8c340efe2c3854e50b68301 @coleenp any chance you could review this as you were involved with the originals? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/154#issuecomment-2004517865 From duke at openjdk.org Mon Mar 18 18:41:31 2024 From: duke at openjdk.org (Robert Toyonaga) Date: Mon, 18 Mar 2024 18:41:31 GMT Subject: [jdk21u-dev] RFR: 8326529: JFR: Test for CompilerCompile events fails due to time out In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 15:41:33 GMT, Robert Toyonaga wrote: > This is a backport of https://github.com/openjdk/jdk/commit/4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 > > This backport limits compilation only to the test methods [TestCompileCompile](https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/compiler/TestCompilerCompile.java) cares about. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3046). It doesn't seem like the risc-v cross compile or the tier1 GHA test failure is related to the change here. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/376#issuecomment-2004665242 From shade at openjdk.org Mon Mar 18 19:05:32 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 18 Mar 2024 19:05:32 GMT Subject: [jdk17u-dev] RFR: 8318986: Improve GenericWaitBarrier performance In-Reply-To: References: Message-ID: On Mon, 11 Dec 2023 17:39:49 GMT, Aleksey Shipilev wrote: > Clean backport to drastically improve safepoint performance under heavy load, fixing regression between JDK 11 and JDK 17. > > Additional testing: > - [x] Ad-hoc performance runs, expected improvements > - [x] MacOS AArch64 server fastdebug, `tier{1,2,3}` GHA failures are environmental. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2041#issuecomment-2004710499 From coleenp at openjdk.org Mon Mar 18 21:04:12 2024 From: coleenp at openjdk.org (Coleen Phillimore) Date: Mon, 18 Mar 2024 21:04:12 GMT Subject: [jdk21u-dev] RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn [v2] In-Reply-To: References: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> Message-ID: On Mon, 18 Mar 2024 15:47:49 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [d23f4f12](https://github.com/openjdk/jdk/commit/d23f4f12adf1ea26b8c340efe2c3854e50b68301) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Oli Gillespie on 4 Dec 2023 and was reviewed by Coleen Phillimore, Kim Barrett and Aleksey Shipilev. >> >> Thanks! > > Oli Gillespie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - 8321276: runtime/cds/appcds/dynamicArchive/DynamicSharedSymbols.java failed with "'17 2: jdk/test/lib/apps ' missing from stdout/stderr" > > Reviewed-by: dcubed > - Merge remote-tracking branch 'origin/master' into backport-olivergillespie-d23f4f12 > - Backport d23f4f12adf1ea26b8c340efe2c3854e50b68301 Yes, this looks like a clean backport of the original fix. Thank you. ------------- Marked as reviewed by coleenp (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/154#pullrequestreview-1944190659 From andrewlu at openjdk.org Tue Mar 19 02:25:52 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 19 Mar 2024 02:25:52 GMT Subject: [jdk11u-dev] RFR: 8313206: PKCS11 tests silently skip execution [v3] In-Reply-To: References: Message-ID: > follow 17-dev backport. > test/jdk/sun/security/pkcs11/PKCS11Test.java > some added code lines are different, and add the format change in 'fetchNssLib'. > other's clean. Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: update ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2605/files - new: https://git.openjdk.org/jdk11u-dev/pull/2605/files/2e6a3a54..e2c5c0f4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2605&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2605&range=01-02 Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2605.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2605/head:pull/2605 PR: https://git.openjdk.org/jdk11u-dev/pull/2605 From andrewlu at openjdk.org Tue Mar 19 02:32:39 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 19 Mar 2024 02:32:39 GMT Subject: [jdk11u-dev] RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 [v4] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.24-oracle. > > Follow 21-dev backport. > test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java > Backport to the origin file. > > depends on https://github.com/openjdk/jdk11u-dev/pull/2605 Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: update ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2598/files - new: https://git.openjdk.org/jdk11u-dev/pull/2598/files/b9dc7d7e..ea863bf6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2598&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2598&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2598.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2598/head:pull/2598 PR: https://git.openjdk.org/jdk11u-dev/pull/2598 From andrewlu at openjdk.org Tue Mar 19 05:20:19 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 19 Mar 2024 05:20:19 GMT Subject: [jdk11u-dev] RFR: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport bdd1aebea379b63ae405827074530ef8e8a7c239 Changes: https://git.openjdk.org/jdk11u-dev/pull/2610/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2610&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312383 Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2610.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2610/head:pull/2610 PR: https://git.openjdk.org/jdk11u-dev/pull/2610 From andrewlu at openjdk.org Tue Mar 19 05:40:36 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 19 Mar 2024 05:40:36 GMT Subject: [jdk21u-dev] RFR: 8315663: Open source misc awt tests Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport a36f5a54ab4871739f2ccbabb684942fc3cadf20 Changes: https://git.openjdk.org/jdk21u-dev/pull/380/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=380&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315663 Stats: 263 lines in 3 files changed: 263 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/380.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/380/head:pull/380 PR: https://git.openjdk.org/jdk21u-dev/pull/380 From andrewlu at openjdk.org Tue Mar 19 05:41:44 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 19 Mar 2024 05:41:44 GMT Subject: [jdk17u-dev] RFR: 8315663: Open source misc awt tests Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport a36f5a54ab4871739f2ccbabb684942fc3cadf20 Changes: https://git.openjdk.org/jdk17u-dev/pull/2306/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2306&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315663 Stats: 263 lines in 3 files changed: 263 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2306.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2306/head:pull/2306 PR: https://git.openjdk.org/jdk17u-dev/pull/2306 From andrewlu at openjdk.org Tue Mar 19 05:42:59 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 19 Mar 2024 05:42:59 GMT Subject: [jdk11u-dev] RFR: 8315663: Open source misc awt tests Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport a36f5a54ab4871739f2ccbabb684942fc3cadf20 Changes: https://git.openjdk.org/jdk11u-dev/pull/2611/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2611&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315663 Stats: 263 lines in 3 files changed: 263 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2611.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2611/head:pull/2611 PR: https://git.openjdk.org/jdk11u-dev/pull/2611 From clanger at openjdk.org Tue Mar 19 07:11:36 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 19 Mar 2024 07:11:36 GMT Subject: [jdk22u] RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 Message-ID: Hi all, This pull request contains a backport of [JDK-8185862](https://bugs.openjdk.org/browse/JDK-8185862), commit [1ad3ebcf](https://github.com/openjdk/jdk/commit/1ad3ebcf11834ec1d119ee95c858d98fb7bc6e68) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Christoph Langer on 13 Mar 2024 and was reviewed by Alexey Ivanov and Phil Race. Thanks! ------------- Commit messages: - Backport 1ad3ebcf11834ec1d119ee95c858d98fb7bc6e68 Changes: https://git.openjdk.org/jdk22u/pull/105/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=105&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8185862 Stats: 149 lines in 9 files changed: 89 ins; 25 del; 35 mod Patch: https://git.openjdk.org/jdk22u/pull/105.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/105/head:pull/105 PR: https://git.openjdk.org/jdk22u/pull/105 From varadam at openjdk.org Tue Mar 19 07:15:25 2024 From: varadam at openjdk.org (Varada M) Date: Tue, 19 Mar 2024 07:15:25 GMT Subject: [jdk11u-dev] RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address [v2] In-Reply-To: References: Message-ID: <6OFx7YQcDcJ_huuNUGMl8qQbdoLnomBenz7mlQm4Nhw=.aeef0368-defd-4733-9da2-4dd9efa71419@github.com> On Mon, 11 Mar 2024 09:40:26 GMT, Varada M wrote: >> Hi all, >> >> This pull request contains a backport of commit [43956686](https://github.com/openjdk/jdk17u-dev/commit/43956686c924658ee2d7866e46ee9f10d9595c35) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. >> >> The commit being backported was authored by Jaikiran Pai on 16 Feb 2024 and was reviewed by Paul Hohensee. >> >> Thanks! > > Varada M has updated the pull request incrementally with one additional commit since the last revision: > > Backport 43956686c924658ee2d7866e46ee9f10d9595c35 @jaikiran @GoeLin Could you please review the code? Thank you, Varada ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2531#issuecomment-2006042275 From mbaesken at openjdk.org Tue Mar 19 08:14:21 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 19 Mar 2024 08:14:21 GMT Subject: [jdk11u-dev] RFR: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: On Fri, 15 Mar 2024 20:23:22 GMT, Martin Doerr wrote: > Backport of [JDK-8326101](https://bugs.openjdk.org/browse/JDK-8326101). Version from 22u applies cleanly, but 11u uses `NULL` instead of `nullptr` (replaced by 2nd commit). Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2604#pullrequestreview-1945464887 From mbaesken at openjdk.org Tue Mar 19 08:17:26 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 19 Mar 2024 08:17:26 GMT Subject: [jdk11u-dev] RFR: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: On Fri, 15 Mar 2024 20:23:22 GMT, Martin Doerr wrote: > Version from 22u applies cleanly, but 11u uses NULL instead of nullptr Searching through the 11u-dev sources, I find a lot of nullptr usages. So why not allow it in 11u(_dev) hotspot too ? Would make life easier for backporters. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2604#issuecomment-2006239123 From goetz at openjdk.org Tue Mar 19 08:18:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 08:18:22 GMT Subject: [jdk21u-dev] RFR: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread In-Reply-To: <38YcO6xMpFw4gP-fwqxSU0D9ioMMP2Xz_Xz7Lhgza5o=.46a47ec3-37bd-47f9-98ea-83f302deb30c@github.com> References: <38YcO6xMpFw4gP-fwqxSU0D9ioMMP2Xz_Xz7Lhgza5o=.46a47ec3-37bd-47f9-98ea-83f302deb30c@github.com> Message-ID: On Fri, 1 Mar 2024 08:39:09 GMT, Vladimir Petko wrote: >> @vpa1977 please also backport this to jdk22u. > >> @vpa1977 please also backport this to jdk22u. > I apologise for forgetting this. I have created https://github.com/openjdk/jdk22u/pull/79 . Hi @vpa1977 please have a look at https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix to write a proper fix request comment. Removed the tag for now. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/290#issuecomment-2006241803 From goetz at openjdk.org Tue Mar 19 08:22:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 08:22:26 GMT Subject: [jdk21u-dev] RFR: 8327799: JFR view: the "Park Until" field of jdk.ThreadPark is invalid if the parking method is not absolute In-Reply-To: References: Message-ID: On Fri, 15 Mar 2024 02:25:34 GMT, Long Yang wrote: > Hi, all > > Could I have a review of this backport ? I would be very grateful. > > This pull request contains a backport of commit [6f8b0a33fa15f1dfc8b0c116375df0f90d9d8759](https://github.com/openjdk/jdk/commit/6f8b0a33fa15f1dfc8b0c116375df0f90d9d8759) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > This backport is clean. > > > UNSAFE.park(true, System.currentTimeMillis() + 1000); > UNSAFE.park(false, 2000L * 1000 * 1000); > > > ``` bash > jfr view jdk.ThreadPark test.jfr > Java Thread Park > > Start Time Duration Event Thread Stack Trace Class Parked On Park Timeout Park Until Address of Object Pa... > ---------- -------- ------------ ----------------------- --------------- ------------ ---------- ----------------------- > 20:11:10 1.00 s main jdk.internal.misc.Un... N/A N/A 20:11:11 0x00000000 > 20:11:11 1.00 s main jdk.internal.misc.Un... N/A 1.00 s 08:05:43 0x00000000 > > > > If the parking method is not absolute (the second line of the Java code above), the real value of `until` field in JFR's `jdk.ThreadPark` event is `Long.MIN_VALUE`, which will be convert back to `java.time.Instant.MIN`, but `jfr view` displays this value as '08:05:43' of my timezone (the `Park Until` column above). This is somewhat misleading, better to show `N/A`. > > Testing: > test/jdk/jdk/jfr/tool/TestView.java > test/jdk/jdk/jfr/jcmd/TestJcmdView.java > > All passed. Thanks for this well documented backport!! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/366#issuecomment-2006254364 From lyang at openjdk.org Tue Mar 19 08:38:21 2024 From: lyang at openjdk.org (Long Yang) Date: Tue, 19 Mar 2024 08:38:21 GMT Subject: [jdk21u-dev] RFR: 8327799: JFR view: the "Park Until" field of jdk.ThreadPark is invalid if the parking method is not absolute In-Reply-To: References: Message-ID: On Fri, 15 Mar 2024 02:25:34 GMT, Long Yang wrote: > Hi, all > > Could I have a review of this backport ? I would be very grateful. > > This pull request contains a backport of commit [6f8b0a33fa15f1dfc8b0c116375df0f90d9d8759](https://github.com/openjdk/jdk/commit/6f8b0a33fa15f1dfc8b0c116375df0f90d9d8759) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > This backport is clean. > > > UNSAFE.park(true, System.currentTimeMillis() + 1000); > UNSAFE.park(false, 2000L * 1000 * 1000); > > > ``` bash > jfr view jdk.ThreadPark test.jfr > Java Thread Park > > Start Time Duration Event Thread Stack Trace Class Parked On Park Timeout Park Until Address of Object Pa... > ---------- -------- ------------ ----------------------- --------------- ------------ ---------- ----------------------- > 20:11:10 1.00 s main jdk.internal.misc.Un... N/A N/A 20:11:11 0x00000000 > 20:11:11 1.00 s main jdk.internal.misc.Un... N/A 1.00 s 08:05:43 0x00000000 > > > > If the parking method is not absolute (the second line of the Java code above), the real value of `until` field in JFR's `jdk.ThreadPark` event is `Long.MIN_VALUE`, which will be convert back to `java.time.Instant.MIN`, but `jfr view` displays this value as '08:05:43' of my timezone (the `Park Until` column above). This is somewhat misleading, better to show `N/A`. > > Testing: > test/jdk/jdk/jfr/tool/TestView.java > test/jdk/jdk/jfr/jcmd/TestJcmdView.java > > All passed. Thank you all. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/366#issuecomment-2006310226 From lyang at openjdk.org Tue Mar 19 08:38:22 2024 From: lyang at openjdk.org (Long Yang) Date: Tue, 19 Mar 2024 08:38:22 GMT Subject: [jdk21u-dev] Integrated: 8327799: JFR view: the "Park Until" field of jdk.ThreadPark is invalid if the parking method is not absolute In-Reply-To: References: Message-ID: On Fri, 15 Mar 2024 02:25:34 GMT, Long Yang wrote: > Hi, all > > Could I have a review of this backport ? I would be very grateful. > > This pull request contains a backport of commit [6f8b0a33fa15f1dfc8b0c116375df0f90d9d8759](https://github.com/openjdk/jdk/commit/6f8b0a33fa15f1dfc8b0c116375df0f90d9d8759) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > This backport is clean. > > > UNSAFE.park(true, System.currentTimeMillis() + 1000); > UNSAFE.park(false, 2000L * 1000 * 1000); > > > ``` bash > jfr view jdk.ThreadPark test.jfr > Java Thread Park > > Start Time Duration Event Thread Stack Trace Class Parked On Park Timeout Park Until Address of Object Pa... > ---------- -------- ------------ ----------------------- --------------- ------------ ---------- ----------------------- > 20:11:10 1.00 s main jdk.internal.misc.Un... N/A N/A 20:11:11 0x00000000 > 20:11:11 1.00 s main jdk.internal.misc.Un... N/A 1.00 s 08:05:43 0x00000000 > > > > If the parking method is not absolute (the second line of the Java code above), the real value of `until` field in JFR's `jdk.ThreadPark` event is `Long.MIN_VALUE`, which will be convert back to `java.time.Instant.MIN`, but `jfr view` displays this value as '08:05:43' of my timezone (the `Park Until` column above). This is somewhat misleading, better to show `N/A`. > > Testing: > test/jdk/jdk/jfr/tool/TestView.java > test/jdk/jdk/jfr/jcmd/TestJcmdView.java > > All passed. This pull request has now been integrated. Changeset: 2de8cfaa Author: Long Yang Committer: Jie Fu URL: https://git.openjdk.org/jdk21u-dev/commit/2de8cfaa2eb8eef614507d6b0e343cec83b9eebc Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8327799: JFR view: the "Park Until" field of jdk.ThreadPark is invalid if the parking method is not absolute Backport-of: 6f8b0a33fa15f1dfc8b0c116375df0f90d9d8759 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/366 From goetz at openjdk.org Tue Mar 19 08:39:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 08:39:22 GMT Subject: [jdk11u-dev] RFR: 8292717: Clean up checking of testing requirements in configure [v2] In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 11:31:44 GMT, Goetz Lindenmaier wrote: >> I backport this because then 8314495 can be backported clean. Also brings 11 closer to 17. >> >> configure.ac:: >> I had to resolve two chunks. In one, I needed to omit the coding for JMH which is not >> supported by 11. >> >> jdk-options.m4, toolchanin.m4 >> Deleted function has different body, deleted by hand. >> >> lib-tests.m4: Copyright. >> >> The original change moves and renames three >> functions to lib-tests.m4. It does not change >> the implementation of these. >> So I modified the added code in lib-tests.m4 >> to have the unchanged function bodies that >> were deleted in the other files. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Add line break GHA failure: StringRepeat.java: Could not reserve enough space for 2097152KB object heap ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2600#issuecomment-2006312358 From goetz at openjdk.org Tue Mar 19 08:41:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 08:41:21 GMT Subject: [jdk17u-dev] RFR: 8015739: Background of JInternalFrame is located out of JInternalFrame In-Reply-To: <5OL8KoWVV4kIPUWr-FQeVbda27IQ5Yjm_gO5gVx8Q6M=.74ebb34e-9594-4f92-a3a9-78e581ceaf3b@github.com> References: <5OL8KoWVV4kIPUWr-FQeVbda27IQ5Yjm_gO5gVx8Q6M=.74ebb34e-9594-4f92-a3a9-78e581ceaf3b@github.com> Message-ID: On Mon, 18 Mar 2024 07:40:51 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > Resolved Copyright, will mark clean if needed. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2301#issuecomment-2006318988 From goetz at openjdk.org Tue Mar 19 08:43:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 08:43:21 GMT Subject: [jdk17u-dev] RFR: 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList In-Reply-To: <66_mtZaNYuLiXnzbFi0y9z_3o29tnnXKHiBCCw5Wni8=.dc3ddedf-2157-4724-b6e6-70adfc0cf4d9@github.com> References: <66_mtZaNYuLiXnzbFi0y9z_3o29tnnXKHiBCCw5Wni8=.dc3ddedf-2157-4724-b6e6-70adfc0cf4d9@github.com> Message-ID: On Mon, 18 Mar 2024 09:23:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > Resolved ProblemList, will mark clean. GHA failure: WhiteBoxResizeTest,StringRepeat.java: Could not reserve enough space for 2097152KB object heap. Unrelated. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2302#issuecomment-2006326692 From goetz at openjdk.org Tue Mar 19 08:45:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 08:45:22 GMT Subject: [jdk21u-dev] RFR: 8309757: com/sun/jdi/ReferrersTest.java fails with virtual test thread factory In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 09:09:24 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. > > Resolved ProblemList, will mark clean. GHA failure: WhiteBoxResizeTest,StringRepeat.java: Could not reserve enough space for 2097152KB object heap. Unrelated. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/367#issuecomment-2006332014 From goetz at openjdk.org Tue Mar 19 08:46:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 08:46:22 GMT Subject: [jdk21u-dev] RFR: 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 12:47:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/371#issuecomment-2006334951 From goetz at openjdk.org Tue Mar 19 08:53:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 08:53:30 GMT Subject: [jdk21u-dev] RFR: 8316696: Remove the testing base classes: IntlTest and CollatorTest In-Reply-To: <7T2mvkq0ivrmapqbc5gKp2PLH8eqIb_Bm-nLlyg9eNc=.bd0c0f76-7933-49db-a2b0-ce4bcff5475a@github.com> References: <7T2mvkq0ivrmapqbc5gKp2PLH8eqIb_Bm-nLlyg9eNc=.bd0c0f76-7933-49db-a2b0-ce4bcff5475a@github.com> Message-ID: On Mon, 18 Mar 2024 12:51:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: StringRepeat.java: Could not reserve enough space for 2097152KB object heap. Unrelated. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/372#issuecomment-2006356992 From goetz at openjdk.org Tue Mar 19 08:55:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 08:55:21 GMT Subject: [jdk21u-dev] RFR: 8288989: Make tests not depend on the source code In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 14:15:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: WhiteBoxResizeTest,StringRepeat.java: Could not reserve enough space for 2097152KB object heap. Unrelated. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/373#issuecomment-2006367122 From goetz at openjdk.org Tue Mar 19 08:59:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 08:59:27 GMT Subject: [jdk21u-dev] RFR: 8322920: Some ProcessTools.execute* functions are declared to throw Throwable In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 14:19:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/374#issuecomment-2006378343 From goetz at openjdk.org Tue Mar 19 09:01:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 09:01:23 GMT Subject: [jdk17u-dev] RFR: 8322920: Some ProcessTools.execute* functions are declared to throw Throwable In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 14:39:01 GMT, Goetz Lindenmaier wrote: > I backport this to keep the testing tools up to date. > > Resolved Copyright, will mark clean. GHA failure: StringRepeat.java: Could not reserve enough space for 2097152KB object heap. Unrelated. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2304#issuecomment-2006384430 From goetz at openjdk.org Tue Mar 19 09:02:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 09:02:25 GMT Subject: [jdk21u-dev] RFR: 8223696: java/net/httpclient/MaxStreams.java failed with didn't finish within the time-out In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 14:51:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure mac: Error: Failed to FinalizeArtifact: Unable to make request: ECONNRESET. Unrelated GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/375#issuecomment-2006390640 From shade at openjdk.org Tue Mar 19 09:23:26 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 19 Mar 2024 09:23:26 GMT Subject: [jdk21u-dev] Integrated: 8325613: CTW: Stale method cleanup requires GC after Sweeper removal In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 09:55:26 GMT, Aleksey Shipilev wrote: > Clean backport to improve CTW testing times. > > Additional testing: > - [x] Ad-hoc CTW time measurements for `java.base` demonstrate the same improvements as in mainline > - [x] Linux x86_64 server fastdebug, large CTW runs pass with this patch applied > - [x] MacOS AArch64 server fastdebug, `applications/ctw/modules` passes This pull request has now been integrated. Changeset: 9e1840f9 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/9e1840f9524675591aa8c61a654a6bd6c616fd6e Stats: 26 lines in 2 files changed: 24 ins; 1 del; 1 mod 8325613: CTW: Stale method cleanup requires GC after Sweeper removal Backport-of: 1281e18f1447848d7eb5e3bde508ac002b4c390d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/370 From christoph.langer at sap.com Tue Mar 19 09:43:41 2024 From: christoph.langer at sap.com (Langer, Christoph) Date: Tue, 19 Mar 2024 09:43:41 +0000 Subject: [22u Communication] 22.0.1 will be closed for fixes on the 4th of March In-Reply-To: References: Message-ID: Hi Rob, can you confirm that https://github.com/openjdk/jdk22u/commit/aeb85fdceb19e0367733df46c67049493d907c66 is the cutoff commit in jdk22u for JDK 22.0.1? Thanks Christoph > -----Original Message----- > From: jdk-updates-dev On Behalf Of > Robert Mckenna > Sent: Montag, 26. Februar 2024 16:58 > To: jdk-updates-dev at openjdk.org > Subject: [22u Communication] 22.0.1 will be closed for fixes on the 4th of > March > > Resending with the correct subject! > > Please have all of your fixes pushed by the end of March 1st. > > -Rob From goetz at openjdk.org Tue Mar 19 10:11:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 10:11:29 GMT Subject: [jdk21u-dev] RFR: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap Message-ID: I backport this to stabilize the GHA tests. ------------- Commit messages: - Backport dde519dc2180742c119ac07221c2a149b9f06c18 Changes: https://git.openjdk.org/jdk21u-dev/pull/381/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=381&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328066 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/381.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/381/head:pull/381 PR: https://git.openjdk.org/jdk21u-dev/pull/381 From goetz at openjdk.org Tue Mar 19 10:11:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 10:11:46 GMT Subject: [jdk22u] RFR: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap Message-ID: I backport this to stabilize the GHA tests. ------------- Commit messages: - Backport dde519dc2180742c119ac07221c2a149b9f06c18 Changes: https://git.openjdk.org/jdk22u/pull/106/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=106&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328066 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/106.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/106/head:pull/106 PR: https://git.openjdk.org/jdk22u/pull/106 From goetz at openjdk.org Tue Mar 19 10:22:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 10:22:34 GMT Subject: [jdk17u-dev] RFR: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap Message-ID: I would like to backport this to 17 to avoid GHA failures. I had to resolve as some previous changes are not in 17 yet. I don't think excluding this considerably reduces the testing scope on x86, but I definitely want to avoid GHA failures due to this in the future. ------------- Commit messages: - Backport dde519dc2180742c119ac07221c2a149b9f06c18 Changes: https://git.openjdk.org/jdk17u-dev/pull/2307/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2307&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328066 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2307.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2307/head:pull/2307 PR: https://git.openjdk.org/jdk17u-dev/pull/2307 From ogillespie at openjdk.org Tue Mar 19 10:33:25 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 19 Mar 2024 10:33:25 GMT Subject: [jdk21u-dev] RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn [v2] In-Reply-To: References: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> Message-ID: On Mon, 18 Mar 2024 15:47:49 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [d23f4f12](https://github.com/openjdk/jdk/commit/d23f4f12adf1ea26b8c340efe2c3854e50b68301) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Oli Gillespie on 4 Dec 2023 and was reviewed by Coleen Phillimore, Kim Barrett and Aleksey Shipilev. >> >> Thanks! > > Oli Gillespie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - 8321276: runtime/cds/appcds/dynamicArchive/DynamicSharedSymbols.java failed with "'17 2: jdk/test/lib/apps ' missing from stdout/stderr" > > Reviewed-by: dcubed > - Merge remote-tracking branch 'origin/master' into backport-olivergillespie-d23f4f12 > - Backport d23f4f12adf1ea26b8c340efe2c3854e50b68301 2 GHA tests failing: 1. Unrelated WhiteBoxResizeTest, fixed by https://github.com/openjdk/jdk21u-dev/pull/381. 2. Unrelated riscv64 cross-compile build issue. Failing on other PRs. So I think it's ready to be checked for approval, @jerboaa. Thanks all. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/154#issuecomment-2006742008 From ogillespie at openjdk.org Tue Mar 19 11:36:26 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 19 Mar 2024 11:36:26 GMT Subject: [jdk21u-dev] Integrated: 8315559: Delay TempSymbol cleanup to avoid symbol table churn In-Reply-To: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> References: <3ztblEfllTFEMm8m7_n6ZpGjEr1Q32F2wKyR7yKVPrs=.565297fd-5958-44f0-81a2-09ad815b82a0@github.com> Message-ID: On Tue, 9 Jan 2024 16:46:27 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [d23f4f12](https://github.com/openjdk/jdk/commit/d23f4f12adf1ea26b8c340efe2c3854e50b68301) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Oli Gillespie on 4 Dec 2023 and was reviewed by Coleen Phillimore, Kim Barrett and Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: 06e4cf37 Author: Oli Gillespie Committer: Coleen Phillimore URL: https://git.openjdk.org/jdk21u-dev/commit/06e4cf37df286ea0b3c61ff09889b5761f3fb9d7 Stats: 136 lines in 5 files changed: 126 ins; 1 del; 9 mod 8315559: Delay TempSymbol cleanup to avoid symbol table churn 8321276: runtime/cds/appcds/dynamicArchive/DynamicSharedSymbols.java failed with "'17 2: jdk/test/lib/apps ' missing from stdout/stderr" Reviewed-by: coleenp Backport-of: d23f4f12adf1ea26b8c340efe2c3854e50b68301 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/154 From mdoerr at openjdk.org Tue Mar 19 12:53:30 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 19 Mar 2024 12:53:30 GMT Subject: [jdk11u-dev] RFR: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: On Fri, 15 Mar 2024 20:23:22 GMT, Martin Doerr wrote: > Backport of [JDK-8326101](https://bugs.openjdk.org/browse/JDK-8326101). Version from 22u applies cleanly, but 11u uses `NULL` instead of `nullptr` (replaced by 2nd commit). GHA test failure is obviously unrelated. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2604#issuecomment-2007088979 From mdoerr at openjdk.org Tue Mar 19 12:53:31 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 19 Mar 2024 12:53:31 GMT Subject: [jdk11u-dev] RFR: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 08:14:39 GMT, Matthias Baesken wrote: > > Version from 22u applies cleanly, but 11u uses NULL instead of nullptr > > Searching through the 11u-dev sources, I find a lot of nullptr usages. So why not allow it in 11u(_dev) hotspot too ? Would make life easier for backporters. The JDK allows usage of nullptr, but hotspot doesn't. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2604#issuecomment-2007092441 From goetz at openjdk.org Tue Mar 19 13:55:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 13:55:22 GMT Subject: [jdk21u-dev] Integrated: 8309757: com/sun/jdi/ReferrersTest.java fails with virtual test thread factory In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 09:09:24 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. > > Resolved ProblemList, will mark clean. This pull request has now been integrated. Changeset: b3e81769 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/b3e81769c17344e90b9eeb97d5ded30b43d3d467 Stats: 5 lines in 2 files changed: 3 ins; 1 del; 1 mod 8309757: com/sun/jdi/ReferrersTest.java fails with virtual test thread factory Backport-of: d7251c1755779f8c4fdeac16ccb797ed45b1dfd4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/367 From goetz at openjdk.org Tue Mar 19 13:56:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 13:56:26 GMT Subject: [jdk21u-dev] RFR: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap In-Reply-To: References: Message-ID: <4lgaq-sziVllLadXzyqx7UeJOOqxuTrU2Ju3PqBp8PQ=.f8d3b417-9515-4cec-9715-f06770673062@github.com> On Tue, 19 Mar 2024 10:06:55 GMT, Goetz Lindenmaier wrote: > I backport this to stabilize the GHA tests. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/381#issuecomment-2007243591 From mbaesken at openjdk.org Tue Mar 19 13:56:28 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 19 Mar 2024 13:56:28 GMT Subject: [jdk22u] RFR: 8328165: improve assert(idx < _maxlrg) failed: oob Message-ID: 8328165: improve assert(idx < _maxlrg) failed: oob ------------- Commit messages: - Backport d57bdd85ab5e45a2ecfce0c022da067ac30bb80d Changes: https://git.openjdk.org/jdk22u/pull/107/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=107&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328165 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/107.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/107/head:pull/107 PR: https://git.openjdk.org/jdk22u/pull/107 From goetz at openjdk.org Tue Mar 19 13:58:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 13:58:23 GMT Subject: [jdk21u-dev] Integrated: 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 12:47:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: dc6afd04 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/dc6afd04f89302d24a67fc7178200153f20139f7 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList Backport-of: 8d29329138d44800ee4c0c02dacc01a06097de66 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/371 From goetz at openjdk.org Tue Mar 19 13:59:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 13:59:27 GMT Subject: [jdk21u-dev] Integrated: 8316696: Remove the testing base classes: IntlTest and CollatorTest In-Reply-To: <7T2mvkq0ivrmapqbc5gKp2PLH8eqIb_Bm-nLlyg9eNc=.bd0c0f76-7933-49db-a2b0-ce4bcff5475a@github.com> References: <7T2mvkq0ivrmapqbc5gKp2PLH8eqIb_Bm-nLlyg9eNc=.bd0c0f76-7933-49db-a2b0-ce4bcff5475a@github.com> Message-ID: On Mon, 18 Mar 2024 12:51:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 81f621d8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/81f621d83def0adbb70d48c0eb3aaa4a43adc531 Stats: 4465 lines in 79 files changed: 922 ins; 1081 del; 2462 mod 8316696: Remove the testing base classes: IntlTest and CollatorTest Backport-of: b859da9c548fbd1463b336059d1c55312c7b7ba4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/372 From goetz at openjdk.org Tue Mar 19 14:01:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 14:01:22 GMT Subject: [jdk21u-dev] Integrated: 8288989: Make tests not depend on the source code In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 14:15:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 6632caa0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/6632caa01a9c5587ad2ed72e762e5402f776d478 Stats: 11 lines in 2 files changed: 8 ins; 0 del; 3 mod 8288989: Make tests not depend on the source code Backport-of: 2838a916ab98cb0152f8b1e3f96eccca198af5e9 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/373 From goetz at openjdk.org Tue Mar 19 14:03:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 14:03:33 GMT Subject: [jdk17u-dev] Integrated: 8015739: Background of JInternalFrame is located out of JInternalFrame In-Reply-To: <5OL8KoWVV4kIPUWr-FQeVbda27IQ5Yjm_gO5gVx8Q6M=.74ebb34e-9594-4f92-a3a9-78e581ceaf3b@github.com> References: <5OL8KoWVV4kIPUWr-FQeVbda27IQ5Yjm_gO5gVx8Q6M=.74ebb34e-9594-4f92-a3a9-78e581ceaf3b@github.com> Message-ID: <1C9iP59AXCuGcIAx8Q_0f0skINliNmi9yVQwWVOIezU=.82444bf8-60d2-41b7-967b-1771cec9e76e@github.com> On Mon, 18 Mar 2024 07:40:51 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > Resolved Copyright, will mark clean if needed. This pull request has now been integrated. Changeset: 7fb1fb0f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7fb1fb0fa6bfb8258ac0191611f445b83a23408e Stats: 408 lines in 2 files changed: 360 ins; 8 del; 40 mod 8015739: Background of JInternalFrame is located out of JInternalFrame Backport-of: f857f795a9fc8b116bfc6b039114051061950e28 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2301 From goetz at openjdk.org Tue Mar 19 14:05:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 14:05:24 GMT Subject: [jdk21u-dev] Integrated: 8322920: Some ProcessTools.execute* functions are declared to throw Throwable In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 14:19:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 700fd399 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/700fd39911864787e51fedc3134b15b1e3023d6b Stats: 6 lines in 1 file changed: 0 ins; 2 del; 4 mod 8322920: Some ProcessTools.execute* functions are declared to throw Throwable Backport-of: 868f8745faf70c915d8294ae8f85b2d6aa096900 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/374 From goetz at openjdk.org Tue Mar 19 14:07:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 14:07:23 GMT Subject: [jdk21u-dev] Integrated: 8223696: java/net/httpclient/MaxStreams.java failed with didn't finish within the time-out In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 14:51:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 196a851b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/196a851b13e5e5f8fcabcef9e71dec2997d388e8 Stats: 25 lines in 1 file changed: 6 ins; 15 del; 4 mod 8223696: java/net/httpclient/MaxStreams.java failed with didn't finish within the time-out Backport-of: 95310eab6ce73512b1afc0a7a26a396dd7b6cb7c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/375 From goetz at openjdk.org Tue Mar 19 14:08:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 14:08:23 GMT Subject: [jdk17u-dev] Integrated: 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList In-Reply-To: <66_mtZaNYuLiXnzbFi0y9z_3o29tnnXKHiBCCw5Wni8=.dc3ddedf-2157-4724-b6e6-70adfc0cf4d9@github.com> References: <66_mtZaNYuLiXnzbFi0y9z_3o29tnnXKHiBCCw5Wni8=.dc3ddedf-2157-4724-b6e6-70adfc0cf4d9@github.com> Message-ID: On Mon, 18 Mar 2024 09:23:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > Resolved ProblemList, will mark clean. This pull request has now been integrated. Changeset: f036fcfb Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f036fcfb82918a469faffc0b122d89f29d4c54f8 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList Backport-of: 8d29329138d44800ee4c0c02dacc01a06097de66 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2302 From goetz at openjdk.org Tue Mar 19 14:09:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 14:09:30 GMT Subject: [jdk17u-dev] Integrated: 8322920: Some ProcessTools.execute* functions are declared to throw Throwable In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 14:39:01 GMT, Goetz Lindenmaier wrote: > I backport this to keep the testing tools up to date. > > Resolved Copyright, will mark clean. This pull request has now been integrated. Changeset: 5fd79e96 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/5fd79e961dc370b312e7828a7d1bcc159a0e8635 Stats: 6 lines in 1 file changed: 0 ins; 2 del; 4 mod 8322920: Some ProcessTools.execute* functions are declared to throw Throwable Backport-of: 868f8745faf70c915d8294ae8f85b2d6aa096900 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2304 From goetz at openjdk.org Tue Mar 19 14:10:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 14:10:26 GMT Subject: [jdk21u-dev] Integrated: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 10:06:55 GMT, Goetz Lindenmaier wrote: > I backport this to stabilize the GHA tests. This pull request has now been integrated. Changeset: eb4f76e5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/eb4f76e5b8a0759c056e916fce167d895570b30e Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap Backport-of: dde519dc2180742c119ac07221c2a149b9f06c18 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/381 From duke at openjdk.org Tue Mar 19 14:13:24 2024 From: duke at openjdk.org (Robert Toyonaga) Date: Tue, 19 Mar 2024 14:13:24 GMT Subject: [jdk21u-dev] Integrated: 8326529: JFR: Test for CompilerCompile events fails due to time out In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 15:41:33 GMT, Robert Toyonaga wrote: > This is a backport of https://github.com/openjdk/jdk/commit/4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 > > This backport limits compilation only to the test methods [TestCompileCompile](https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/compiler/TestCompilerCompile.java) cares about. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3046). This pull request has now been integrated. Changeset: c8ddf40f Author: Robert Toyonaga Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/c8ddf40f1a535379216cbf023f768700588e95db Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8326529: JFR: Test for CompilerCompile events fails due to time out Backport-of: 4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/376 From goetz at openjdk.org Tue Mar 19 14:13:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 14:13:25 GMT Subject: [jdk11u-dev] Integrated: 8292717: Clean up checking of testing requirements in configure In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 14:39:48 GMT, Goetz Lindenmaier wrote: > I backport this because then 8314495 can be backported clean. Also brings 11 closer to 17. > > configure.ac:: > I had to resolve two chunks. In one, I needed to omit the coding for JMH which is not > supported by 11. > > jdk-options.m4, toolchanin.m4 > Deleted function has different body, deleted by hand. > > lib-tests.m4: Copyright. > > The original change moves and renames three > functions to lib-tests.m4. It does not change > the implementation of these. > So I modified the added code in lib-tests.m4 > to have the unchanged function bodies that > were deleted in the other files. This pull request has now been integrated. Changeset: cb1b9a64 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/cb1b9a64878e7751c785860c4466e41ad1df276f Stats: 364 lines in 4 files changed: 183 ins; 179 del; 2 mod 8292717: Clean up checking of testing requirements in configure Reviewed-by: shade, mdoerr Backport-of: 16593cf51c3d994ba4a6d28ab97e519dfd53f37b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2600 From goetz at openjdk.org Tue Mar 19 14:16:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 14:16:39 GMT Subject: [jdk11u-dev] RFR: 8015739: Background of JInternalFrame is located out of JInternalFrame Message-ID: I backport this because it fixes an obvious problem. The backport is based on the commit to 17. The test reproduces the issue and passes with the fix. I had to resolve due to context. I adapted the test to work with Java 11. ------------- Commit messages: - Backport ... Changes: https://git.openjdk.org/jdk11u-dev/pull/2607/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2607&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8015739 Stats: 407 lines in 2 files changed: 360 ins; 8 del; 39 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2607.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2607/head:pull/2607 PR: https://git.openjdk.org/jdk11u-dev/pull/2607 From ogillespie at openjdk.org Tue Mar 19 14:17:29 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 19 Mar 2024 14:17:29 GMT Subject: [jdk21u-dev] Integrated: 8324646: Avoid Class.forName in SecureRandom constructor In-Reply-To: References: Message-ID: On Tue, 13 Feb 2024 11:29:06 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [8ef918d6](https://github.com/openjdk/jdk/commit/8ef918d6678437a5b351b172bb4cf144eeaa975f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev and Weijun Wang. > > Thanks! This pull request has now been integrated. Changeset: eaa8ed99 Author: Oli Gillespie Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/eaa8ed99009b137a8337c2e4a8c65fa88df30b87 Stats: 61 lines in 2 files changed: 47 ins; 1 del; 13 mod 8324646: Avoid Class.forName in SecureRandom constructor Reviewed-by: shade Backport-of: 8ef918d6678437a5b351b172bb4cf144eeaa975f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/258 From ogillespie at openjdk.org Tue Mar 19 14:21:39 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 19 Mar 2024 14:21:39 GMT Subject: [jdk17u-dev] RFR: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG Message-ID: Hi all, This pull request contains a backport of commit [69b2674c](https://github.com/openjdk/jdk/commit/69b2674c6861fdb7d9f9cb39e07d50515c73e33a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev, Weijun Wang, Chen Liang and Valerie Peng. I had to manually resolve the copyright change, but apart from that it's clean. Benchmark results (`make test TEST=micro:org.openjdk.bench.java.security.SecureRandomBench`, using the benchmark from https://github.com/openjdk/jdk/pull/17559): Before: 2614 ? 127 ns/op After: 508 ? 7 ns/op ``` Thanks! ------------- Commit messages: - Backport 69b2674c6861fdb7d9f9cb39e07d50515c73e33a Changes: https://git.openjdk.org/jdk17u-dev/pull/2308/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2308&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324648 Stats: 16 lines in 1 file changed: 9 ins; 3 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2308.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2308/head:pull/2308 PR: https://git.openjdk.org/jdk17u-dev/pull/2308 From goetz at openjdk.org Tue Mar 19 14:32:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 14:32:46 GMT Subject: [jdk11u-dev] RFR: 8314495: Update to use jtreg 7.3.1 Message-ID: I backport this as announced in https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-March/030818.html Clean backport from 17 except for test/lib-test/TEST.ROOT. That file is not in 11. I added it for this change. I think it makes sense to have this in 11 as well. ------------- Commit messages: - Backport 75e14419d29c1dc98bd040490e93ae8f6eee4e43 Changes: https://git.openjdk.org/jdk11u-dev/pull/2612/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2612&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314495 Stats: 41 lines in 8 files changed: 32 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2612.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2612/head:pull/2612 PR: https://git.openjdk.org/jdk11u-dev/pull/2612 From shade at openjdk.org Tue Mar 19 14:58:22 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 19 Mar 2024 14:58:22 GMT Subject: [jdk11u-dev] RFR: 8314495: Update to use jtreg 7.3.1 In-Reply-To: References: Message-ID: <_Sk6cQdDwJU0dyZNDSPWMVMEKK389ePQJJUAnqy3baE=.198ea48b-b35c-47a7-80e8-d9ae929674f5@github.com> On Tue, 19 Mar 2024 14:27:01 GMT, Goetz Lindenmaier wrote: > I backport this as announced in https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-March/030818.html > > Clean backport from 17 except for test/lib-test/TEST.ROOT. > That file is not in 11. I added it for this change. I think it makes sense to have this in 11 as well. I don't think we should be adding lib-test here. It is a part of much larger [JDK-8211977](https://bugs.openjdk.org/browse/JDK-8211977). Otherwise looks good. ------------- Changes requested by shade (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2612#pullrequestreview-1946514037 From shade at openjdk.org Tue Mar 19 15:02:23 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 19 Mar 2024 15:02:23 GMT Subject: [jdk21u-dev] RFR: 8319048: Monitor deflation unlink phase prolongs time to safepoint In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 09:15:14 GMT, Aleksey Shipilev wrote: > Clean backport to improve TTSP under heavy monitor deflation, and provide better parity. > > Additional testing: > - [x] Ad-hoc benchmarks show TTSP improvements > - [x] MacOS AArch64 server fastdebug, `runtime/Monitor` passes > - [x] Linux x86_64 server fastdebug, `all` GHA failures are environmental. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/369#issuecomment-2007417018 From alexsch at openjdk.org Tue Mar 19 15:20:29 2024 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Tue, 19 Mar 2024 15:20:29 GMT Subject: [jdk21u-dev] Integrated: 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 07:10:07 GMT, Alexander Scherbatiy wrote: > `test/jdk/java/awt/print` and `test/jdk/javax/print` automated tests have been run on Ubuntu and MacOS to check the fix. > > All 63 automated tests passed on Ubuntu with the fix. > There are 2 failed by timeout tests on MacOS `java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java` and `java/awt/print/PrinterJob/Margins.java` and these tests fail without fix as well. This pull request has now been integrated. Changeset: 6b0cfd44 Author: Alexander Scherbatiy URL: https://git.openjdk.org/jdk21u-dev/commit/6b0cfd441eecafe0181aae830504c2922485f690 Stats: 20 lines in 1 file changed: 10 ins; 0 del; 10 mod 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation Backport-of: 91ffdfb1fcacbb95b93491d412e506695198946e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/348 From goetz at openjdk.org Tue Mar 19 15:25:44 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 15:25:44 GMT Subject: [jdk21u-dev] RFR: 8317631: Refactor ChoiceFormat tests to use JUnit Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 5e8d893c4809fdb30e01bdfe06b4f488f7bbef83 Changes: https://git.openjdk.org/jdk21u-dev/pull/382/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=382&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317631 Stats: 165 lines in 3 files changed: 90 ins; 38 del; 37 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/382.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/382/head:pull/382 PR: https://git.openjdk.org/jdk21u-dev/pull/382 From lucy at openjdk.org Tue Mar 19 15:29:25 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Tue, 19 Mar 2024 15:29:25 GMT Subject: [jdk17u-dev] RFR: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 10:18:25 GMT, Goetz Lindenmaier wrote: > I would like to backport this to 17 to avoid GHA failures. > I had to resolve as some previous changes are not in 17 yet. > I don't think excluding this considerably reduces the testing scope on x86, but I definitely want to avoid GHA failures due to this in the future. Looks good. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2307#pullrequestreview-1946611474 From szaldana at openjdk.org Tue Mar 19 15:36:36 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 19 Mar 2024 15:36:36 GMT Subject: [jdk21u-dev] RFR: 8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent of the zip command line Message-ID: Hi all, This PR contains a backport of [7004c2724d9b150112c66febb7f24b781ff379dd](https://github.com/openjdk/jdk/commit/7004c2724d9b150112c66febb7f24b781ff379dd). Testing: - [x] Modified test case passes. Thanks! ------------- Commit messages: - Backport 7004c2724d9b150112c66febb7f24b781ff379dd Changes: https://git.openjdk.org/jdk21u-dev/pull/377/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=377&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303972 Stats: 209 lines in 2 files changed: 90 ins; 44 del; 75 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/377.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/377/head:pull/377 PR: https://git.openjdk.org/jdk21u-dev/pull/377 From szaldana at openjdk.org Tue Mar 19 15:39:21 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 19 Mar 2024 15:39:21 GMT Subject: [jdk21u-dev] RFR: 8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent of the zip command line In-Reply-To: References: Message-ID: <5d1taDmOJm2m1eV5hqKIUW3E7t_kr2wI1wwh2_D_9ig=.5c85ab4f-3943-40a0-9441-0889fba249ad@github.com> On Mon, 18 Mar 2024 16:42:55 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This PR contains a backport of [7004c2724d9b150112c66febb7f24b781ff379dd](https://github.com/openjdk/jdk/commit/7004c2724d9b150112c66febb7f24b781ff379dd). > > Testing: > > - [x] Modified test case passes. > > Thanks! GHA Failures: - Unrelated RISC-V failure. - Unrelated test failures: ```java/util/HashMap/WhiteBoxResizeTest.java``` and ```java/lang/String/StringRepeat.java``` in ```jdk/tier1 part 1``` and ```jdk/tier1 part 2```. I'm seeing these failures across all PRs. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/377#issuecomment-2007516078 From szaldana at openjdk.org Tue Mar 19 15:45:53 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 19 Mar 2024 15:45:53 GMT Subject: [jdk21u-dev] RFR: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols Message-ID: Hi all, This pull request contains a backport of commit [6c0bebcc](https://github.com/openjdk/jdk/commit/6c0bebccb0092d9726eb89a054e023e92edf7ca6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Mandy Chung on 19 Jan 2024 and was reviewed by Jim Laskey. Testing: - [x] Added test case passes. Thanks! ------------- Commit messages: - Backport 6c0bebccb0092d9726eb89a054e023e92edf7ca6 Changes: https://git.openjdk.org/jdk21u-dev/pull/378/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=378&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8159927 Stats: 76 lines in 1 file changed: 76 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/378.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/378/head:pull/378 PR: https://git.openjdk.org/jdk21u-dev/pull/378 From szaldana at openjdk.org Tue Mar 19 15:45:53 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 19 Mar 2024 15:45:53 GMT Subject: [jdk21u-dev] RFR: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 16:46:58 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [6c0bebcc](https://github.com/openjdk/jdk/commit/6c0bebccb0092d9726eb89a054e023e92edf7ca6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Mandy Chung on 19 Jan 2024 and was reviewed by Jim Laskey. > > Testing: > - [x] Added test case passes. > > Thanks! GHA Failures: - Unrelated RISC-V failure. - Unrelated test failures: ```java/util/HashMap/WhiteBoxResizeTest.java``` in ```jdk/tier1 part 2```. I'm seeing these failures intermittently across all PRs. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/378#issuecomment-2007525746 From lucy at openjdk.org Tue Mar 19 15:49:23 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Tue, 19 Mar 2024 15:49:23 GMT Subject: [jdk11u-dev] RFR: 8015739: Background of JInternalFrame is located out of JInternalFrame In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 08:20:35 GMT, Goetz Lindenmaier wrote: > I backport this because it fixes an obvious problem. > The backport is based on the commit to 17. > The test reproduces the issue and passes with the fix. > > I had to resolve due to context. > I adapted the test to work with Java 11. LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2607#pullrequestreview-1946671449 From szaldana at openjdk.org Tue Mar 19 15:50:38 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 19 Mar 2024 15:50:38 GMT Subject: [jdk17u-dev] RFR: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols Message-ID: Hi all, This PR contains a backport of [6c0bebccb0092d9726eb89a054e023e92edf7ca6](https://github.com/openjdk/jdk/commit/6c0bebccb0092d9726eb89a054e023e92edf7ca6). Patch is not clean. Test won't build in 17 because it can't find ```import jdk.internal.util.OperatingSystem```. This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485). I've worked around that by removing the dependency to that utility function and checking the operating system with ```System.getProperty("os.name")```. Testing: - [x] Added test case passes Thanks! ------------- Commit messages: - Backport 6c0bebccb0092d9726eb89a054e023e92edf7ca6 Changes: https://git.openjdk.org/jdk17u-dev/pull/2305/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2305&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8159927 Stats: 75 lines in 1 file changed: 75 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2305.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2305/head:pull/2305 PR: https://git.openjdk.org/jdk17u-dev/pull/2305 From szaldana at openjdk.org Tue Mar 19 15:50:38 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 19 Mar 2024 15:50:38 GMT Subject: [jdk17u-dev] RFR: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 18:48:11 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This PR contains a backport of [6c0bebccb0092d9726eb89a054e023e92edf7ca6](https://github.com/openjdk/jdk/commit/6c0bebccb0092d9726eb89a054e023e92edf7ca6). > > Patch is not clean. Test won't build in 17 because it can't find ```import jdk.internal.util.OperatingSystem```. > > This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485). > > I've worked around that by removing the dependency to that utility function and checking the operating system with ```System.getProperty("os.name")```. > > Testing: > - [x] Added test case passes > > Thanks! GHA Failures: - Unrelated RISC-V failure. - Unrelated test failures: ```java/lang/String/StringRepeat.java``` in ```jdk/tier1 part1```. I'm seeing these failures intermittently across all PRs. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2305#issuecomment-2007535991 From lucy at openjdk.org Tue Mar 19 15:55:27 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Tue, 19 Mar 2024 15:55:27 GMT Subject: [jdk11u-dev] RFR: 8314495: Update to use jtreg 7.3.1 In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 14:27:01 GMT, Goetz Lindenmaier wrote: > I backport this as announced in https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-March/030818.html > > Clean backport from 17 except for test/lib-test/TEST.ROOT. > That file is not in 11. I added it for this change. I think it makes sense to have this in 11 as well. Looks good. My approval is not intended to overrule the request by @shipilev ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2612#pullrequestreview-1946687303 From szaldana at openjdk.org Tue Mar 19 15:55:48 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 19 Mar 2024 15:55:48 GMT Subject: [jdk11u-dev] RFR: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols Message-ID: Hi all, This PR contains a backport of [6c0bebccb0092d9726eb89a054e023e92edf7ca6](https://github.com/openjdk/jdk/commit/6c0bebccb0092d9726eb89a054e023e92edf7ca6). Patch is not clean. Test won't build in 11 because it can't find ```import jdk.internal.util.OperatingSystem```. This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485). I've worked around that by removing the dependency to that utility function and checking the operating system with ```System.getProperty("os.name")```. Testing: - [x] Added test passes. Thanks! ------------- Commit messages: - Backport 6c0bebccb0092d9726eb89a054e023e92edf7ca6 Changes: https://git.openjdk.org/jdk11u-dev/pull/2609/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2609&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8159927 Stats: 75 lines in 1 file changed: 75 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2609.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2609/head:pull/2609 PR: https://git.openjdk.org/jdk11u-dev/pull/2609 From szaldana at openjdk.org Tue Mar 19 15:59:46 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 19 Mar 2024 15:59:46 GMT Subject: [jdk21u-dev] RFR: 8324998: Add test cases for String.regionMatches comparing Turkic dotted/dotless I with uppercase latin I Message-ID: Hi all, This pull request contains a backport of commit [c3c1d5bd](https://github.com/openjdk/jdk/commit/c3c1d5bd12f80c6a720e431961e90b09c2d972f9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Eirik Bj?rsn?s on 30 Jan 2024 and was reviewed by Naoto Sato and Iris Clark. Testing: - [x] Modified test passes Thanks! ------------- Commit messages: - Backport c3c1d5bd12f80c6a720e431961e90b09c2d972f9 Changes: https://git.openjdk.org/jdk21u-dev/pull/379/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=379&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324998 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/379.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/379/head:pull/379 PR: https://git.openjdk.org/jdk21u-dev/pull/379 From szaldana at openjdk.org Tue Mar 19 15:59:46 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 19 Mar 2024 15:59:46 GMT Subject: [jdk21u-dev] RFR: 8324998: Add test cases for String.regionMatches comparing Turkic dotted/dotless I with uppercase latin I In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 19:12:57 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [c3c1d5bd](https://github.com/openjdk/jdk/commit/c3c1d5bd12f80c6a720e431961e90b09c2d972f9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Eirik Bj?rsn?s on 30 Jan 2024 and was reviewed by Naoto Sato and Iris Clark. > > Testing: > - [x] Modified test passes > > Thanks! GHA Failures: - Unrelated RISC-V failure. - Unrelated test failures: ```java/util/HashMap/WhiteBoxResizeTest.java``` and ```java/lang/String/StringRepeat.java``` in ```jdk/tier1 part 1``` and ```jdk/tier1 part 2```. I'm seeing these failures across all PRs. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/379#issuecomment-2007555105 From rob.mckenna at oracle.com Tue Mar 19 16:18:52 2024 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Tue, 19 Mar 2024 16:18:52 +0000 Subject: [External] : RE: [22u Communication] 22.0.1 will be closed for fixes on the 4th of March In-Reply-To: References: Message-ID: https://github.com/openjdk/jdk22u/commit/dd4dc386ab8ea59eaaee4a6c270202925ea85259 is the most recent common commit, however there have been two critical approvals (cherry picked): https://bugs.openjdk.org/browse/JDK-8325313 https://bugs.openjdk.org/browse/JDK-8317299 -Rob ________________________________________ From: Langer, Christoph Sent: Tuesday 19 March 2024 09:43 To: Robert Mckenna; jdk-updates-dev at openjdk.org Subject: [External] : RE: [22u Communication] 22.0.1 will be closed for fixes on the 4th of March Hi Rob, can you confirm that https://urldefense.com/v3/__https://github.com/openjdk/jdk22u/commit/aeb85fdceb19e0367733df46c67049493d907c66__;!!ACWV5N9M2RV99hQ!Mqh9zJZuBFESL2fi6HP6-Cwt3TCJkli0OEp5YnT76epBzYD9mR5iRCKimu7D2mNWvGmhCIyMSkJGz1M7TaCgS0YAUQ$ is the cutoff commit in jdk22u for JDK 22.0.1? Thanks Christoph > -----Original Message----- > From: jdk-updates-dev On Behalf Of > Robert Mckenna > Sent: Montag, 26. Februar 2024 16:58 > To: jdk-updates-dev at openjdk.org > Subject: [22u Communication] 22.0.1 will be closed for fixes on the 4th of > March > > Resending with the correct subject! > > Please have all of your fixes pushed by the end of March 1st. > > -Rob From alexsch at openjdk.org Tue Mar 19 17:39:25 2024 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Tue, 19 Mar 2024 17:39:25 GMT Subject: [jdk21u-dev] Integrated: 7001133: OutOfMemoryError by CustomMediaSizeName implementation In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 07:41:55 GMT, Alexander Scherbatiy wrote: > The fix has been tested on Ubuntu and MacOS. > The test `test/jdk/javax/print/CustomMediaSizeNameOOMETest.java` passes with the fix and fails without the fix. This pull request has now been integrated. Changeset: 93a4707f Author: Alexander Scherbatiy URL: https://git.openjdk.org/jdk21u-dev/commit/93a4707f13aafc08a131e24c3c5ccbbe189da529 Stats: 173 lines in 5 files changed: 153 ins; 13 del; 7 mod 7001133: OutOfMemoryError by CustomMediaSizeName implementation Backport-of: 10335f60f923aa4f315e64acb2bfd7bb06d47a1b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/349 From ogillespie at openjdk.org Tue Mar 19 18:49:48 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 19 Mar 2024 18:49:48 GMT Subject: [jdk17u-dev] RFR: 8324646: Avoid Class.forName in SecureRandom constructor Message-ID: <79nQABORrgdOnW8JCbHlq37nuwnVc3o6OmrswojMzho=.0358f4b7-1f03-4716-b945-98d1f887c0bc@github.com> Improve performance of SecureRandom constructor by backporting (both clean) two changes: 1. [JDK-8280970](https://bugs.openjdk.org/browse/JDK-8280970) removes some unused code in Provider.java. This is not really functionally needed, but it changes the same areas of code and makes the actual performance fix apply cleanly. 2. [JDK-8324646](https://bugs.openjdk.org/browse/JDK-8324646) is the actual performance fix - avoiding Class.forName calls in every construction. Note - because of the unused code still present in JDK17, there is actually an alternative fix which makes use of it, which is very simple: diff --git a/src/java.base/share/classes/java/security/Provider.java b/src/java.base/share/classes/java/security/Provider.java index af8ebeeda57..28bf642d0c8 100644 --- a/src/java.base/share/classes/java/security/Provider.java +++ b/src/java.base/share/classes/java/security/Provider.java @@ -1851,7 +1851,7 @@ public abstract class Provider extends Properties { null : constructorParameter.getClass(); } else { ctrParamClz = cap.constructorParameterClassName == null? - null : Class.forName(cap.constructorParameterClassName); + null : cap.getConstructorParameterClass(); // actually make use of the cached class! if (constructorParameter != null) { if (ctrParamClz == null) { throw new InvalidParameterException This has the same performance benefits as making the two backports. But, it means 17 will be diverged from later versions, and I think the backported fix is cleaner overall. Benchmark results (`make test TEST=micro:org.openjdk.bench.java.security.SecureRandomBench`): Before: 2614 ? 127 ns/op After: 2150 ? 116 ns/op ------------- Commit messages: - Backport 8ef918d6678437a5b351b172bb4cf144eeaa975f - Backport 63e11cfa3f887515ca36ab5147c3e6fa540978d3 Changes: https://git.openjdk.org/jdk17u-dev/pull/2310/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2310&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324646 Stats: 70 lines in 2 files changed: 47 ins; 10 del; 13 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2310.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2310/head:pull/2310 PR: https://git.openjdk.org/jdk17u-dev/pull/2310 From vpetko at openjdk.org Tue Mar 19 19:29:27 2024 From: vpetko at openjdk.org (Vladimir Petko) Date: Tue, 19 Mar 2024 19:29:27 GMT Subject: [jdk21u-dev] RFR: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread In-Reply-To: <38YcO6xMpFw4gP-fwqxSU0D9ioMMP2Xz_Xz7Lhgza5o=.46a47ec3-37bd-47f9-98ea-83f302deb30c@github.com> References: <38YcO6xMpFw4gP-fwqxSU0D9ioMMP2Xz_Xz7Lhgza5o=.46a47ec3-37bd-47f9-98ea-83f302deb30c@github.com> Message-ID: On Fri, 1 Mar 2024 08:39:09 GMT, Vladimir Petko wrote: >> @vpa1977 please also backport this to jdk22u. > >> @vpa1977 please also backport this to jdk22u. > I apologise for forgetting this. I have created https://github.com/openjdk/jdk22u/pull/79 . > Hi @vpa1977 please have a look at https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix to write a proper fix request comment. Removed the tag for now. Thank you!!! I have added the comment, but did not set the tag. Please advice if i should add more details before tagging the issue? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/290#issuecomment-2007960252 From goetz at openjdk.org Tue Mar 19 19:48:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 19:48:33 GMT Subject: [jdk21u-dev] RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 842b895f093e15ecd8aa0153d712f5f81cf1cf67 Changes: https://git.openjdk.org/jdk21u-dev/pull/383/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=383&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303891 Stats: 147 lines in 1 file changed: 75 ins; 10 del; 62 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/383.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/383/head:pull/383 PR: https://git.openjdk.org/jdk21u-dev/pull/383 From goetz at openjdk.org Tue Mar 19 20:08:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 20:08:40 GMT Subject: [jdk21u-dev] RFR: 8325908: Finish removal of IntlTest and CollatorTest Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 4c7b313e0dc917cdaffbb2ecc86d1347683acad0 Changes: https://git.openjdk.org/jdk21u-dev/pull/384/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=384&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325908 Stats: 93 lines in 7 files changed: 46 ins; 20 del; 27 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/384.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/384/head:pull/384 PR: https://git.openjdk.org/jdk21u-dev/pull/384 From goetz at openjdk.org Tue Mar 19 20:18:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 20:18:43 GMT Subject: [jdk17u-dev] RFR: 8295944: Move the Http2TestServer and related classes into a package of its own Message-ID: <8QL1KBFZDNOPtJfyTMcCxtTpN9HbNoV5kyPB6C9rZmg=.1abe1b82-dbba-4508-b528-58106e3a3f31@github.com> I backport this to simplify further backports. It's a refactoring of test infra. I had to do resolves of Copyright, imports, and @test descriptions. A row of tests are not in 17. In detail: test/jdk/java/net/httpclient/AsFileDownloadTest.java Needs resolve because earlier changes were al test/jdk/java/net/httpclient/AsyncExecutorShutdown.java Introduced in 19 by "8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task" This is a bug fix one wants to have in 17 at first sight, but it is a big change and it had several follow ups. So better don't backport as prerequisite. test/jdk/java/net/httpclient/CancelRequestTest.java Resolved Copyright. test/jdk/java/net/httpclient/CancelStreamedBodyTest.java Introduced in 20 by "294916: Cancelling a request must eventually cause its response body subscriber to be unregistered" This fix has many prereqs that would need to be backported. Omit. test/jdk/java/net/httpclient/DigestEchoClient.java Resolved Copyright. test/jdk/java/net/httpclient/ExecutorShutdown.java As above introduced by "8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task". Omit. test/jdk/java/net/httpclient/ExpectContinueTest.java Introduced in 20 by "8286171: HttpClient/2 : Expect:100-Continue blocks indefinitely when response is not 100" test/jdk/java/net/httpclient/HeadTest.java Resolved Copyright and imports. "8276559: (httpclient) Consider adding an HttpRequest.Builder.HEAD method to build a HEAD request." which came in 18 is a new feature with CSR that changed the imports. test/jdk/java/net/httpclient/HttpClientLocalAddrTest.java Introduced in 19 by "8209137: Add ability to bind to specific local address to HTTP client". A new feature. Omit. test/jdk/java/net/httpclient/ISO_8859_1_Test.java Resolved Copyright test/jdk/java/net/httpclient/MappingResponseSubscriber.java Resolved imports. test/jdk/java/net/httpclient/Response1xxTest.java Introduced in 20 by 8292044: HttpClient doesn't handle 102 or 103 properly. Omit. test/jdk/java/net/httpclient/SpecialHeadersTest.java Resolved due to context. test/jdk/java/net/httpclient/http2/IdleConnectionTimeoutTest.java Was added by 8288717: Add a means to close idle connections in HTTP/2 connection pool in 20. Omit. test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java Was added by 8263031: HttpClient throws Exception if it receives a Push Promise that is too large in 19. Omit. test/jdk/java/net/httpclient/http2/UserInfoTest.java Was added by 8292876: Do not include the deprecated userinfo component of the URI in HTTP/2 headers in 20. Omit. test/jdk/java/net/httpclient/httpclient-localaddr-security.policy Was added by 8209137: Add ability to bind to specific local address to HTTP client in 19. Omit. test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java Omitted Copyright, was already updated. test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchangeImpl.java test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServer.java test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServerConnection.java test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/OutgoingPushPromise.java Resolved Copyritht and in some the package statement. ------------- Commit messages: - Backport 8a47429dc065ad7645a40fa2350d043ef4606d92 Changes: https://git.openjdk.org/jdk17u-dev/pull/2311/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2311&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295944 Stats: 4602 lines in 125 files changed: 209 ins; 3982 del; 411 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2311.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2311/head:pull/2311 PR: https://git.openjdk.org/jdk17u-dev/pull/2311 From dlutker at openjdk.org Tue Mar 19 20:38:30 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Tue, 19 Mar 2024 20:38:30 GMT Subject: [jdk17u-dev] Integrated: 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 23:19:38 GMT, Dan Lutker wrote: > Backport tto 17 which also has the issue. Ran tier1, 2, 3, 4 on linux aarch64 with -XX:+UseShenandoahGC as well as jcstress quick. This pull request has now been integrated. Changeset: 5b8a2e55 Author: Dan Lutker Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/5b8a2e55660fe3fa8c42d2b4601f8c61a16b2763 Stats: 100 lines in 4 files changed: 99 ins; 0 del; 1 mod 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi Backport-of: 5d414da50459b7a1e6f0f537ff3b318854b2c427 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2259 From goetz at openjdk.org Tue Mar 19 20:47:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 19 Mar 2024 20:47:47 GMT Subject: [jdk17u-dev] RFR: 8297449: Update JInternalFrame Metal Border code Message-ID: I backport this as follow up of 8015739 ------------- Commit messages: - Backport 09629570f5d064dc2a5cd670de8d648156ac3991 Changes: https://git.openjdk.org/jdk17u-dev/pull/2312/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2312&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297449 Stats: 55 lines in 1 file changed: 17 ins; 22 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2312.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2312/head:pull/2312 PR: https://git.openjdk.org/jdk17u-dev/pull/2312 From phh at openjdk.org Tue Mar 19 23:52:25 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 19 Mar 2024 23:52:25 GMT Subject: [jdk17u-dev] RFR: 8324646: Avoid Class.forName in SecureRandom constructor In-Reply-To: <79nQABORrgdOnW8JCbHlq37nuwnVc3o6OmrswojMzho=.0358f4b7-1f03-4716-b945-98d1f887c0bc@github.com> References: <79nQABORrgdOnW8JCbHlq37nuwnVc3o6OmrswojMzho=.0358f4b7-1f03-4716-b945-98d1f887c0bc@github.com> Message-ID: On Tue, 19 Mar 2024 18:42:15 GMT, Oli Gillespie wrote: > Improve performance of SecureRandom constructor by backporting (both clean) two changes: > > 1. [JDK-8280970](https://bugs.openjdk.org/browse/JDK-8280970) removes some unused code in Provider.java. This is not really functionally needed, but it changes the same areas of code and makes the actual performance fix apply cleanly. > 2. [JDK-8324646](https://bugs.openjdk.org/browse/JDK-8324646) is the actual performance fix - avoiding Class.forName calls in every construction. > > Note - because of the unused code still present in JDK17, there is actually an alternative fix which makes use of it, which is very simple: > > > diff --git a/src/java.base/share/classes/java/security/Provider.java b/src/java.base/share/classes/java/security/Provider.java > index af8ebeeda57..28bf642d0c8 100644 > --- a/src/java.base/share/classes/java/security/Provider.java > +++ b/src/java.base/share/classes/java/security/Provider.java > @@ -1851,7 +1851,7 @@ public abstract class Provider extends Properties { > null : constructorParameter.getClass(); > } else { > ctrParamClz = cap.constructorParameterClassName == null? > - null : Class.forName(cap.constructorParameterClassName); > + null : cap.getConstructorParameterClass(); // actually make use of the cached class! > if (constructorParameter != null) { > if (ctrParamClz == null) { > throw new InvalidParameterException > > > This has the same performance benefits as making the two backports. But, it means 17 will be diverged from later versions, and I think the backported fix is cleaner overall. > > Benchmark results (`make test TEST=micro:org.openjdk.bench.java.security.SecureRandomBench`): > > > Before: 2614 ? 127 ns/op > After: 2150 ? 116 ns/op Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2310#pullrequestreview-1947623516 From psadhukhan at openjdk.org Wed Mar 20 05:19:28 2024 From: psadhukhan at openjdk.org (Prasanta Sadhukhan) Date: Wed, 20 Mar 2024 05:19:28 GMT Subject: [jdk22u] Integrated: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 In-Reply-To: References: Message-ID: On Fri, 15 Mar 2024 08:04:06 GMT, Prasanta Sadhukhan wrote: > 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 This pull request has now been integrated. Changeset: 98ea70db Author: Prasanta Sadhukhan URL: https://git.openjdk.org/jdk22u/commit/98ea70db2f6154fb5efc2e2774851ede7a8e1489 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 Backport-of: 0d354503620eb7f6da7b1b8aa6143ba18ced8f12 ------------- PR: https://git.openjdk.org/jdk22u/pull/102 From goetz at openjdk.org Wed Mar 20 07:32:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 07:32:53 GMT Subject: [jdk22u] RFR: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap Message-ID: I backport this to fix the GHA issue. ------------- Commit messages: - Backport eebcc2181fe27f6aa10559233c7c58882a146f56 Changes: https://git.openjdk.org/jdk22u/pull/108/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=108&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328524 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/108.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/108/head:pull/108 PR: https://git.openjdk.org/jdk22u/pull/108 From goetz at openjdk.org Wed Mar 20 07:36:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 07:36:20 GMT Subject: [jdk22u] RFR: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 10:06:26 GMT, Goetz Lindenmaier wrote: > I backport this to stabilize the GHA tests. GHA failure: StringRepeat.java: Could not reserve enough space for 2097152KB object heap. Unrelated. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/106#issuecomment-2008951015 From goetz at openjdk.org Wed Mar 20 07:37:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 07:37:30 GMT Subject: [jdk17u-dev] RFR: 8297449: Update JInternalFrame Metal Border code In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 20:43:47 GMT, Goetz Lindenmaier wrote: > I backport this as follow up of 8015739 GHA failure: StringRepeat.java: Could not reserve enough space for 2097152KB object heap. Unrelated. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2312#issuecomment-2008952326 From goetz at openjdk.org Wed Mar 20 07:38:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 07:38:32 GMT Subject: [jdk17u-dev] RFR: 8295944: Move the Http2TestServer and related classes into a package of its own In-Reply-To: <8QL1KBFZDNOPtJfyTMcCxtTpN9HbNoV5kyPB6C9rZmg=.1abe1b82-dbba-4508-b528-58106e3a3f31@github.com> References: <8QL1KBFZDNOPtJfyTMcCxtTpN9HbNoV5kyPB6C9rZmg=.1abe1b82-dbba-4508-b528-58106e3a3f31@github.com> Message-ID: On Tue, 19 Mar 2024 20:14:06 GMT, Goetz Lindenmaier wrote: > I backport this to simplify further backports. It's a refactoring of test infra. > > I had to do resolves of Copyright, imports, and @test descriptions. A row of tests are not in 17. > In detail: > > > test/jdk/java/net/httpclient/AsFileDownloadTest.java > Needs resolve because earlier changes were al > > test/jdk/java/net/httpclient/AsyncExecutorShutdown.java > Introduced in 19 by "8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task" > This is a bug fix one wants to have in 17 at first sight, but it is a big change > and it had several follow ups. So better don't backport as prerequisite. > > test/jdk/java/net/httpclient/CancelRequestTest.java > Resolved Copyright. > > test/jdk/java/net/httpclient/CancelStreamedBodyTest.java > Introduced in 20 by "294916: Cancelling a request must eventually cause its response body subscriber to be unregistered" > This fix has many prereqs that would need to be backported. Omit. > > test/jdk/java/net/httpclient/DigestEchoClient.java > Resolved Copyright. > > test/jdk/java/net/httpclient/ExecutorShutdown.java > As above introduced by "8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task". Omit. > > test/jdk/java/net/httpclient/ExpectContinueTest.java > Introduced in 20 by "8286171: HttpClient/2 : Expect:100-Continue blocks indefinitely when response is not 100" > > test/jdk/java/net/httpclient/HeadTest.java > Resolved Copyright and imports. > "8276559: (httpclient) Consider adding an HttpRequest.Builder.HEAD method to build a HEAD request." which came in 18 > is a new feature with CSR that changed the imports. > > test/jdk/java/net/httpclient/HttpClientLocalAddrTest.java > Introduced in 19 by "8209137: Add ability to bind to specific local address to HTTP client". A new > feature. Omit. > > test/jdk/java/net/httpclient/ISO_8859_1_Test.java > Resolved Copyright > > test/jdk/java/net/httpclient/MappingResponseSubscriber.java > Resolved imports. > > test/jdk/java/net/httpclient/Response1xxTest.java > Introduced in 20 by 8292044: HttpClient doesn't handle 102 or 103 properly. Omit. > > > test/jdk/java/net/httpclient/SpecialHeadersTest.java > Resolved due to context. > > test/jdk/java/net/httpclient/http2/IdleConnectionTimeoutTest.java > Was added by 8288717: Add a means to close idle connections in HTTP/2 connection pool in 20. Omit. > > test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java > Was added by 8263031: HttpClient throws Exception if it receives a Push Promise that is too large in 19. Omit. > > test/jdk/java/net/httpclient/http2/UserInfoTest... GHA failure: StringRepeat.java: Could not reserve enough space for 2097152KB object heap. Unrelated. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2311#issuecomment-2008954494 From goetz at openjdk.org Wed Mar 20 07:39:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 07:39:26 GMT Subject: [jdk21u-dev] RFR: 8325908: Finish removal of IntlTest and CollatorTest In-Reply-To: References: Message-ID: <9J8jmwsScDSZ8Dja2TX7zNoDhlrJjz6A6bpx8hYytlk=.f26ab014-40a9-4749-bbeb-ce3d5c0e4695@github.com> On Tue, 19 Mar 2024 20:02:42 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: StringRepeat.java: Could not reserve enough space for 2097152KB object heap. Unrelated. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/384#issuecomment-2008955172 From goetz at openjdk.org Wed Mar 20 07:40:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 07:40:25 GMT Subject: [jdk21u-dev] RFR: 8317631: Refactor ChoiceFormat tests to use JUnit In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 15:20:45 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/382#issuecomment-2008956544 From goetz at openjdk.org Wed Mar 20 07:40:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 07:40:28 GMT Subject: [jdk21u-dev] RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file In-Reply-To: References: Message-ID: <4nrXjDdgre7ARpL1vMIiUrYB08pzADR8NRI7eEbj3ME=.0192f98e-850d-4f17-badd-4f5c79089586@github.com> On Tue, 19 Mar 2024 19:43:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: StringRepeat.java: Could not reserve enough space for 2097152KB object heap. Unrelated. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/383#issuecomment-2008956090 From goetz at openjdk.org Wed Mar 20 07:41:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 07:41:22 GMT Subject: [jdk17u-dev] RFR: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 10:18:25 GMT, Goetz Lindenmaier wrote: > I would like to backport this to 17 to avoid GHA failures. > I had to resolve as some previous changes are not in 17 yet. > I don't think excluding this considerably reduces the testing scope on x86, but I definitely want to avoid GHA failures due to this in the future. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2307#issuecomment-2008956877 From goetz at openjdk.org Wed Mar 20 07:46:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 07:46:32 GMT Subject: [jdk21u-dev] RFR: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap Message-ID: I backport this to fix the GHA failures of this test. ------------- Commit messages: - Backport eebcc2181fe27f6aa10559233c7c58882a146f56 Changes: https://git.openjdk.org/jdk21u-dev/pull/385/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=385&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328524 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/385.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/385/head:pull/385 PR: https://git.openjdk.org/jdk21u-dev/pull/385 From goetz at openjdk.org Wed Mar 20 07:47:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 07:47:30 GMT Subject: [jdk17u-dev] RFR: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap Message-ID: I backport this to fix the GHA failures of this test. ------------- Commit messages: - Backport eebcc2181fe27f6aa10559233c7c58882a146f56 Changes: https://git.openjdk.org/jdk17u-dev/pull/2313/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2313&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328524 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2313.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2313/head:pull/2313 PR: https://git.openjdk.org/jdk17u-dev/pull/2313 From goetz at openjdk.org Wed Mar 20 07:47:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 07:47:46 GMT Subject: [jdk11u-dev] RFR: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap Message-ID: <8bkms4zqn32lIoA3Pg0_fZQaaH23PzPgje85NTtn23I=.31b70118-da6c-415a-8524-72a178752881@github.com> I backport this to fix the GHA failures of this test. ------------- Commit messages: - Backport eebcc2181fe27f6aa10559233c7c58882a146f56 Changes: https://git.openjdk.org/jdk11u-dev/pull/2613/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2613&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328524 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2613.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2613/head:pull/2613 PR: https://git.openjdk.org/jdk11u-dev/pull/2613 From shade at openjdk.org Wed Mar 20 07:59:25 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 20 Mar 2024 07:59:25 GMT Subject: [jdk17u-dev] RFR: 8324646: Avoid Class.forName in SecureRandom constructor In-Reply-To: <79nQABORrgdOnW8JCbHlq37nuwnVc3o6OmrswojMzho=.0358f4b7-1f03-4716-b945-98d1f887c0bc@github.com> References: <79nQABORrgdOnW8JCbHlq37nuwnVc3o6OmrswojMzho=.0358f4b7-1f03-4716-b945-98d1f887c0bc@github.com> Message-ID: <1epx_mb0Nxz2zfg_sa2nfERa3Zh8Ou4xPwFCcw0RVWY=.1e25af68-8563-45c1-9d48-5d9510817784@github.com> On Tue, 19 Mar 2024 18:42:15 GMT, Oli Gillespie wrote: > Improve performance of SecureRandom constructor by backporting (both clean) two changes: > > 1. [JDK-8280970](https://bugs.openjdk.org/browse/JDK-8280970) removes some unused code in Provider.java. This is not really functionally needed, but it changes the same areas of code and makes the actual performance fix apply cleanly. > 2. [JDK-8324646](https://bugs.openjdk.org/browse/JDK-8324646) is the actual performance fix - avoiding Class.forName calls in every construction. > > Note - because of the unused code still present in JDK17, there is actually an alternative fix which makes use of it, which is very simple: > > > diff --git a/src/java.base/share/classes/java/security/Provider.java b/src/java.base/share/classes/java/security/Provider.java > index af8ebeeda57..28bf642d0c8 100644 > --- a/src/java.base/share/classes/java/security/Provider.java > +++ b/src/java.base/share/classes/java/security/Provider.java > @@ -1851,7 +1851,7 @@ public abstract class Provider extends Properties { > null : constructorParameter.getClass(); > } else { > ctrParamClz = cap.constructorParameterClassName == null? > - null : Class.forName(cap.constructorParameterClassName); > + null : cap.getConstructorParameterClass(); // actually make use of the cached class! > if (constructorParameter != null) { > if (ctrParamClz == null) { > throw new InvalidParameterException > > > This has the same performance benefits as making the two backports. But, it means 17 will be diverged from later versions, and I think the backported fix is cleaner overall. > > Benchmark results (`make test TEST=micro:org.openjdk.bench.java.security.SecureRandomBench`): > > > Before: 2614 ? 127 ns/op > After: 2150 ? 116 ns/op Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2310#pullrequestreview-1948166326 From shade at openjdk.org Wed Mar 20 07:59:28 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 20 Mar 2024 07:59:28 GMT Subject: [jdk17u-dev] RFR: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 10:18:25 GMT, Goetz Lindenmaier wrote: > I would like to backport this to 17 to avoid GHA failures. > I had to resolve as some previous changes are not in 17 yet. > I don't think excluding this considerably reduces the testing scope on x86, but I definitely want to avoid GHA failures due to this in the future. Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2307#pullrequestreview-1948166804 From goetz at openjdk.org Wed Mar 20 08:03:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 08:03:41 GMT Subject: [jdk11u-dev] RFR: 8314495: Update to use jtreg 7.3.1 [v2] In-Reply-To: References: Message-ID: > I backport this as announced in https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-March/030818.html > > Clean backport from 17 except for test/lib-test/TEST.ROOT. > That file is not in 11. I added it for this change. I think it makes sense to have this in 11 as well. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Remove file as asked by Aleksey ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2612/files - new: https://git.openjdk.org/jdk11u-dev/pull/2612/files/f7d6f693..34275957 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2612&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2612&range=00-01 Stats: 32 lines in 1 file changed: 0 ins; 32 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2612.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2612/head:pull/2612 PR: https://git.openjdk.org/jdk11u-dev/pull/2612 From goetz at openjdk.org Wed Mar 20 08:03:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 08:03:41 GMT Subject: [jdk11u-dev] RFR: 8314495: Update to use jtreg 7.3.1 [v2] In-Reply-To: <_Sk6cQdDwJU0dyZNDSPWMVMEKK389ePQJJUAnqy3baE=.198ea48b-b35c-47a7-80e8-d9ae929674f5@github.com> References: <_Sk6cQdDwJU0dyZNDSPWMVMEKK389ePQJJUAnqy3baE=.198ea48b-b35c-47a7-80e8-d9ae929674f5@github.com> Message-ID: On Tue, 19 Mar 2024 14:56:11 GMT, Aleksey Shipilev wrote: >> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: >> >> Remove file as asked by Aleksey > > I don't think we should be adding lib-test here. It is a part of much larger [JDK-8211977](https://bugs.openjdk.org/browse/JDK-8211977). Otherwise looks good. Hi @shipilev, I removed the file as asked. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2612#issuecomment-2008983712 From shade at openjdk.org Wed Mar 20 08:08:29 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 20 Mar 2024 08:08:29 GMT Subject: [jdk11u-dev] RFR: 8314495: Update to use jtreg 7.3.1 [v2] In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 08:03:41 GMT, Goetz Lindenmaier wrote: >> I backport this as announced in https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-March/030818.html >> >> Clean backport from 17 except for test/lib-test/TEST.ROOT. >> That file is not in 11. I added it for this change. I think it makes sense to have this in 11 as well. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Remove file as asked by Aleksey Looks good! Let's do this. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2612#pullrequestreview-1948184248 From goetz at openjdk.org Wed Mar 20 08:22:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 08:22:25 GMT Subject: [jdk11u-dev] RFR: 8261302: NMT: Improve malloc site table hashing In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 16:09:59 GMT, Mar?a Arias de Reyna wrote: > This is the same fix that was applied in https://github.com/openjdk/jdk/commit/a3d6e371 for https://bugs.openjdk.org/browse/JDK-8261302 > > It simplifies the way of calculating the hash of a stack. Hi @Delawen, I don't see why this should be backported to a stable release as 11. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2608#issuecomment-2009008745 From stuefe at openjdk.org Wed Mar 20 08:57:26 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 20 Mar 2024 08:57:26 GMT Subject: [jdk11u-dev] RFR: 8261302: NMT: Improve malloc site table hashing In-Reply-To: References: Message-ID: <_ny2Kp7iL7owSh1b04gD8W24u_bpaYnZX3bkH-2P_Pk=.71c32d9c-ac0d-4730-b69f-b6ee88a11035@github.com> On Wed, 20 Mar 2024 08:19:48 GMT, Goetz Lindenmaier wrote: > Hi @Delawen, I don't see why this should be backported to a stable release as 11. Hi @GoeLin , this is part of a (smallish) chain of changes that would make NMT in 11 feature-equivalent to 21. Since NMT continues to be very important to us, and since the changes in general are low-risk, I suggested making these backports. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2608#issuecomment-2009061085 From goetz at openjdk.org Wed Mar 20 08:58:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 08:58:29 GMT Subject: [jdk21u-dev] Integrated: 8317631: Refactor ChoiceFormat tests to use JUnit In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 15:20:45 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: f17d3863 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/f17d3863c170ca3f979166801f6a16ac49fd257f Stats: 165 lines in 3 files changed: 90 ins; 38 del; 37 mod 8317631: Refactor ChoiceFormat tests to use JUnit Backport-of: 5e8d893c4809fdb30e01bdfe06b4f488f7bbef83 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/382 From mdoerr at openjdk.org Wed Mar 20 09:00:26 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 20 Mar 2024 09:00:26 GMT Subject: [jdk11u-dev] Integrated: 8325326: [PPC64] Don't relocate in case of allocation failure In-Reply-To: References: Message-ID: <4Wtn0m4GXO2Xcf_2HXBPJ5jFj_nsEdVULO2njPH-FUs=.32bd6184-4f60-4baa-86e9-cb8da8faeef4@github.com> On Fri, 15 Mar 2024 20:11:05 GMT, Martin Doerr wrote: > Clean backport of [JDK-8325326](https://bugs.openjdk.org/browse/JDK-8325326). This pull request has now been integrated. Changeset: 74822988 Author: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/74822988a3a8e468181d5c3649ec1a6de87aea00 Stats: 12 lines in 1 file changed: 6 ins; 2 del; 4 mod 8325326: [PPC64] Don't relocate in case of allocation failure Backport-of: 4388095cde20dec602ada9fe2977f1a359ceab91 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2603 From mdoerr at openjdk.org Wed Mar 20 09:01:29 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 20 Mar 2024 09:01:29 GMT Subject: [jdk11u-dev] Integrated: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: On Fri, 15 Mar 2024 20:23:22 GMT, Martin Doerr wrote: > Backport of [JDK-8326101](https://bugs.openjdk.org/browse/JDK-8326101). Version from 22u applies cleanly, but 11u uses `NULL` instead of `nullptr` (replaced by 2nd commit). This pull request has now been integrated. Changeset: c5ba4b5c Author: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/c5ba4b5c3e25364f826da96e17176c90d15d655e Stats: 11 lines in 2 files changed: 9 ins; 0 del; 2 mod 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space Reviewed-by: mbaesken Backport-of: e3ae81eeeee8e2b0063a576a90624dd927b512f0 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2604 From goetz at openjdk.org Wed Mar 20 09:02:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 09:02:23 GMT Subject: [jdk21u-dev] Integrated: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 07:42:21 GMT, Goetz Lindenmaier wrote: > I backport this to fix the GHA failures of this test. This pull request has now been integrated. Changeset: 6a89849e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/6a89849e11a84eade09b8e2984421248de21d397 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap Backport-of: eebcc2181fe27f6aa10559233c7c58882a146f56 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/385 From goetz at openjdk.org Wed Mar 20 09:02:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 09:02:27 GMT Subject: [jdk17u-dev] Integrated: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap In-Reply-To: References: Message-ID: <-rBoTJG_SQyCvQxgZaL-XnzzHVOEfE9wUm9VpGwon14=.72a3f9c2-13e0-4fd5-af4e-57eeeee62f05@github.com> On Tue, 19 Mar 2024 10:18:25 GMT, Goetz Lindenmaier wrote: > I would like to backport this to 17 to avoid GHA failures. > I had to resolve as some previous changes are not in 17 yet. > I don't think excluding this considerably reduces the testing scope on x86, but I definitely want to avoid GHA failures due to this in the future. This pull request has now been integrated. Changeset: d24d94b0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/d24d94b04a414dde6412a9da7cb2358e5392b5fb Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap Reviewed-by: lucy, shade Backport-of: dde519dc2180742c119ac07221c2a149b9f06c18 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2307 From goetz at openjdk.org Wed Mar 20 09:03:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 09:03:29 GMT Subject: [jdk17u-dev] Integrated: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap In-Reply-To: References: Message-ID: <15gZodVTWVU0E9QQxDr1exWmLpes8eVZW9brrHGG4AQ=.cacd7541-5e1c-4145-9682-dcdc3613c622@github.com> On Wed, 20 Mar 2024 07:42:25 GMT, Goetz Lindenmaier wrote: > I backport this to fix the GHA failures of this test. This pull request has now been integrated. Changeset: 02eec995 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/02eec99577aa42852bfc9b9a616b87efdf4b92b3 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap Backport-of: eebcc2181fe27f6aa10559233c7c58882a146f56 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2313 From goetz at openjdk.org Wed Mar 20 09:04:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 09:04:25 GMT Subject: [jdk11u-dev] Integrated: 8015739: Background of JInternalFrame is located out of JInternalFrame In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 08:20:35 GMT, Goetz Lindenmaier wrote: > I backport this because it fixes an obvious problem. > The backport is based on the commit to 17. > The test reproduces the issue and passes with the fix. > > I had to resolve due to context. > I adapted the test to work with Java 11. This pull request has now been integrated. Changeset: ac9d090a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/ac9d090a99c28986a8f20e4c58987ca69e425652 Stats: 407 lines in 2 files changed: 360 ins; 8 del; 39 mod 8015739: Background of JInternalFrame is located out of JInternalFrame Reviewed-by: lucy Backport-of: 7fb1fb0fa6bfb8258ac0191611f445b83a23408e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2607 From goetz at openjdk.org Wed Mar 20 09:04:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 09:04:28 GMT Subject: [jdk11u-dev] Integrated: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap In-Reply-To: <8bkms4zqn32lIoA3Pg0_fZQaaH23PzPgje85NTtn23I=.31b70118-da6c-415a-8524-72a178752881@github.com> References: <8bkms4zqn32lIoA3Pg0_fZQaaH23PzPgje85NTtn23I=.31b70118-da6c-415a-8524-72a178752881@github.com> Message-ID: On Wed, 20 Mar 2024 07:42:29 GMT, Goetz Lindenmaier wrote: > I backport this to fix the GHA failures of this test. This pull request has now been integrated. Changeset: 44825a00 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/44825a003b6b172015c7f374d9b5e90a20129489 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap Backport-of: eebcc2181fe27f6aa10559233c7c58882a146f56 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2613 From mbaesken at openjdk.org Wed Mar 20 09:08:27 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 20 Mar 2024 09:08:27 GMT Subject: [jdk17u-dev] RFR: 8324632: Update Zlib Data Compression Library to Version 1.3.1 In-Reply-To: References: Message-ID: <_uTpPTWOwifcBB4glU_653MYF-dQcWM7EfoL_HiF_70=.0803bf16-18c9-4326-9952-6cf097a970cf@github.com> On Thu, 14 Mar 2024 21:09:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > I backport the change in 21 which merged three related changes. > > I had to resolve ChangeLog. Unfortunately in 21, "8283525: http://tools.ietf.org/html/* URLs return 404" > changed 'http' to https' in many files including this one, but this file should not > be touched as it is not owned by our project. But might be clean anyways. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2300#pullrequestreview-1948291297 From goetz at openjdk.org Wed Mar 20 09:17:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 09:17:23 GMT Subject: [jdk21u-dev] RFR: Merge jdk21u:master Message-ID: Merge build tag 21.0.3+7 from jdk21u to jdk21u-dev ------------- Commit messages: - Merge - 8327391: Add SipHash attribution file The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk21u-dev/pull/386/files Stats: 150 lines in 1 file changed: 150 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/386.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/386/head:pull/386 PR: https://git.openjdk.org/jdk21u-dev/pull/386 From goetz at openjdk.org Wed Mar 20 09:23:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 09:23:23 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:master Message-ID: Merge build tag 17.0.11+7 from jdk17u to jdk17u-dev ------------- Commit messages: - Merge - 8327391: Add SipHash attribution file - 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk17u-dev/pull/2314/files Stats: 150 lines in 1 file changed: 150 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2314.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2314/head:pull/2314 PR: https://git.openjdk.org/jdk17u-dev/pull/2314 From goetz at openjdk.org Wed Mar 20 09:29:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 09:29:24 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: Merge build tag 11.0.23+7 from jdk11u to jdk11u-dev ------------- Commit messages: - Merge - 8327391: Add SipHash attribution file The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk11u-dev/pull/2614/files Stats: 150 lines in 1 file changed: 150 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2614.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2614/head:pull/2614 PR: https://git.openjdk.org/jdk11u-dev/pull/2614 From duke at openjdk.org Wed Mar 20 10:02:27 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Wed, 20 Mar 2024 10:02:27 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: References: Message-ID: On Mon, 26 Feb 2024 12:52:28 GMT, Mar?a Arias de Reyna wrote: > This is a backport of https://bugs.openjdk.org/browse/JDK-8280377 MethodHandleProxies does not correctly invoke default methods with varags > > I applied the same fix that was applied to version 19 in https://github.com/openjdk/jdk/commit/a183bfb436a7dd998e602c2d16486e88c390fca1 Do we need more testing here? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#issuecomment-2009172816 From goetz at openjdk.org Wed Mar 20 10:31:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 10:31:25 GMT Subject: [jdk21u-dev] Integrated: Merge jdk21u:master In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 09:13:16 GMT, Goetz Lindenmaier wrote: > Merge build tag 21.0.3+7 from jdk21u to jdk21u-dev This pull request has now been integrated. Changeset: 376f880a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/376f880a6dbf4110ae81d8c6088a2d9329c59985 Stats: 150 lines in 1 file changed: 150 ins; 0 del; 0 mod Merge ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/386 From goetz at openjdk.org Wed Mar 20 10:31:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 10:31:26 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 09:25:10 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.23+7 from jdk11u to jdk11u-dev This pull request has now been integrated. Changeset: a46d4440 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/a46d4440ee9a328d53f194245d79f124b7ceb80a Stats: 150 lines in 1 file changed: 150 ins; 0 del; 0 mod Merge ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2614 From goetz at openjdk.org Wed Mar 20 10:31:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 10:31:26 GMT Subject: [jdk17u-dev] Integrated: Merge jdk17u:master In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 09:19:25 GMT, Goetz Lindenmaier wrote: > Merge build tag 17.0.11+7 from jdk17u to jdk17u-dev This pull request has now been integrated. Changeset: e3ba201f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/e3ba201fe489d37d290338eff07bd85fbb0a4310 Stats: 150 lines in 1 file changed: 150 ins; 0 del; 0 mod Merge ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2314 From goetz at openjdk.org Wed Mar 20 13:31:22 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 13:31:22 GMT Subject: [jdk17u-dev] RFR: 8306040: HttpResponseInputStream.available() returns 1 on empty stream In-Reply-To: References: Message-ID: <_yqL3rRe0DyyhgiATqnKWqmZGrZjy-rQMYor0eLMo1Q=.c00ac03c-5251-4295-b501-6195bbad0b3d@github.com> On Wed, 6 Mar 2024 14:23:34 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This pull request contains a backport of commit [acaab6fd74f507bb6b18167505d88e505bdf24bd](https://github.com/openjdk/jdk/commit/acaab6fd74f507bb6b18167505d88e505bdf24bd) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. >> >> Testing: using the reproducer linked in the issue, I was able to verify the patch. >> I also ran the additional test case included in the original commit and all tests in ```test/jdk/java/net/httpclient/```. >> >> Note that patch is not clean because http tests and related classes have since been moved into a package of their own (namely ```/test/jdk/java/net/httpclient/lib```), which doesn?t exist in jdk 17. >> >> Only change introduced in my patch from the original commit: >> >> @@ -25,7 +25,7 @@ >> * @test >> * @bug 8306040 >> * @summary HttpResponseInputStream.available() returns 1 on empty stream >> - * @library /test/lib /test/jdk/java/net/httpclient/lib >> + * @library /test/lib >> * @run junit/othervm HttpInputStreamAvailableTest >> * >> */ > > GHA failure: Unrelated Risk-V build issue. Hi @SoniaZaldana, what about this change? It is pending for a long time now, and it should go to the July release please. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2263#issuecomment-2009566901 From szaldana at openjdk.org Wed Mar 20 13:33:43 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 20 Mar 2024 13:33:43 GMT Subject: [jdk21u-dev] RFR: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [6c0bebcc](https://github.com/openjdk/jdk/commit/6c0bebccb0092d9726eb89a054e023e92edf7ca6) and [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > Testing: > - [x] Added test case passes. > > Thanks! Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision: Backport 43c6f0b5880899b797fab2f851bd35be1c342439 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/378/files - new: https://git.openjdk.org/jdk21u-dev/pull/378/files/7b1d6a73..1e1f5f41 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=378&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=378&range=00-01 Stats: 48 lines in 1 file changed: 30 ins; 5 del; 13 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/378.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/378/head:pull/378 PR: https://git.openjdk.org/jdk21u-dev/pull/378 From szaldana at openjdk.org Wed Mar 20 13:58:50 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 20 Mar 2024 13:58:50 GMT Subject: [jdk21u-dev] RFR: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols [v3] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [6c0bebcc](https://github.com/openjdk/jdk/commit/6c0bebccb0092d9726eb89a054e023e92edf7ca6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > Testing: > - [x] Added test case passes. > > Thanks! Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision: Reverting JDK-8326591 commit ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/378/files - new: https://git.openjdk.org/jdk21u-dev/pull/378/files/1e1f5f41..e13c3725 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=378&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=378&range=01-02 Stats: 48 lines in 1 file changed: 5 ins; 30 del; 13 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/378.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/378/head:pull/378 PR: https://git.openjdk.org/jdk21u-dev/pull/378 From szaldana at openjdk.org Wed Mar 20 14:05:32 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Wed, 20 Mar 2024 14:05:32 GMT Subject: [jdk21u-dev] RFR: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols [v3] In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 13:58:50 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This pull request contains a backport of commit [6c0bebcc](https://github.com/openjdk/jdk/commit/6c0bebccb0092d9726eb89a054e023e92edf7ca6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> Testing: >> - [x] Added test case passes. >> >> Thanks! > > Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision: > > Reverting JDK-8326591 commit Just noting I mistakenly added the backport for [JDK-8326591](https://bugs.openjdk.org/browse/JDK-8326591). I reverted that after reviewing the backport guide which advised a separate PR. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/378#issuecomment-2009649536 From goetz at openjdk.org Wed Mar 20 14:04:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 14:04:51 GMT Subject: [jdk17u-dev] RFR: 8280546: Remove hard-coded 127.0.0.1 loopback address Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport b5de2cc9d36e1fad7d0bf70f7c83ff829e16b7f3 Changes: https://git.openjdk.org/jdk17u-dev/pull/2315/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2315&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280546 Stats: 5 lines in 2 files changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2315.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2315/head:pull/2315 PR: https://git.openjdk.org/jdk17u-dev/pull/2315 From duke at openjdk.org Wed Mar 20 14:58:22 2024 From: duke at openjdk.org (L Will Ahonen) Date: Wed, 20 Mar 2024 14:58:22 GMT Subject: [jdk21u-dev] RFR: 8294699: Launcher causes lingering busy cursor [v2] In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 22:25:31 GMT, Dan Lutker wrote: >> Backport for parity with Oracle 21.0.4 > > Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-lutkerd-d3df3eb5 > - Backport d3df3eb5d7f5537ade917db7a36caba028f94111 The failing tests are for linux-x86 but the backport only touches a single .cpp in the Windows components. I think the test failure is a false positive? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/327#issuecomment-2004038532 From stuefe at openjdk.org Wed Mar 20 15:04:29 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 20 Mar 2024 15:04:29 GMT Subject: [jdk17u-dev] RFR: 8306040: HttpResponseInputStream.available() returns 1 on empty stream In-Reply-To: References: Message-ID: <99zvyFrnqgALdByZPiEOtMk5bgLAu2cgVFADxGdgMoU=.cf6fb596-5f02-4652-b1a1-6d28d26db6ee@github.com> On Fri, 1 Mar 2024 18:30:10 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [acaab6fd74f507bb6b18167505d88e505bdf24bd](https://github.com/openjdk/jdk/commit/acaab6fd74f507bb6b18167505d88e505bdf24bd) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > Testing: using the reproducer linked in the issue, I was able to verify the patch. > I also ran the additional test case included in the original commit and all tests in ```test/jdk/java/net/httpclient/```. > > Note that patch is not clean because http tests and related classes have since been moved into a package of their own (namely ```/test/jdk/java/net/httpclient/lib```), which doesn?t exist in jdk 17. > > Only change introduced in my patch from the original commit: > > @@ -25,7 +25,7 @@ > * @test > * @bug 8306040 > * @summary HttpResponseInputStream.available() returns 1 on empty stream > - * @library /test/lib /test/jdk/java/net/httpclient/lib > + * @library /test/lib > * @run junit/othervm HttpInputStreamAvailableTest > * > */ LGTM ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2263#pullrequestreview-1949161378 From duke at openjdk.org Wed Mar 20 15:22:31 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Wed, 20 Mar 2024 15:22:31 GMT Subject: [jdk11u-dev] RFR: 8261302: NMT: Improve malloc site table hashing In-Reply-To: <_ny2Kp7iL7owSh1b04gD8W24u_bpaYnZX3bkH-2P_Pk=.71c32d9c-ac0d-4730-b69f-b6ee88a11035@github.com> References: <_ny2Kp7iL7owSh1b04gD8W24u_bpaYnZX3bkH-2P_Pk=.71c32d9c-ac0d-4730-b69f-b6ee88a11035@github.com> Message-ID: On Wed, 20 Mar 2024 08:55:14 GMT, Thomas Stuefe wrote: >> Hi @Delawen, I don't see why this should be backported to a stable release as 11. > >> Hi @Delawen, I don't see why this should be backported to a stable release as 11. > > Hi @GoeLin , this is part of a (smallish) chain of changes that would make NMT in 11 feature-equivalent to 21. Since NMT continues to be very important to us, and since the changes in general are low-risk, I suggested making these backports. I have a list of potential NMT improvements (following @tstuefe steps) that could be backported here. To me it makes sense to be as similar as JDK21, but of course this is not my call, so let me know if I should proceed. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2608#issuecomment-2009828512 From goetz at openjdk.org Wed Mar 20 16:29:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 16:29:34 GMT Subject: [jdk17u-dev] RFR: 8249693: java/nio/channels/FileChannel/FileExtensionAndMap.java uses @ignore w/o bug id Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport 819af69f408261f55af883ba015c1f6179236582 Changes: https://git.openjdk.org/jdk17u-dev/pull/2316/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2316&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8249693 Stats: 43 lines in 1 file changed: 37 ins; 1 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2316.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2316/head:pull/2316 PR: https://git.openjdk.org/jdk17u-dev/pull/2316 From goetz at openjdk.org Wed Mar 20 16:36:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 16:36:49 GMT Subject: [jdk17u-dev] RFR: 8305169: java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java -- test server didn't start in timely manner Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport 3f6a3545a255cbef3c3436ff26481f1cec4ccfc9 Changes: https://git.openjdk.org/jdk17u-dev/pull/2317/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2317&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305169 Stats: 28 lines in 2 files changed: 17 ins; 8 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2317.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2317/head:pull/2317 PR: https://git.openjdk.org/jdk17u-dev/pull/2317 From goetz at openjdk.org Wed Mar 20 16:39:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 16:39:43 GMT Subject: [jdk17u-dev] RFR: 8314832: Few runtime/os tests ignore vm flags Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport fc3e8266929826f8e58bc76fe97423d76bc7be87 Changes: https://git.openjdk.org/jdk17u-dev/pull/2318/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2318&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314832 Stats: 11 lines in 3 files changed: 11 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2318.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2318/head:pull/2318 PR: https://git.openjdk.org/jdk17u-dev/pull/2318 From goetz at openjdk.org Wed Mar 20 16:43:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 16:43:30 GMT Subject: [jdk11u-dev] RFR: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader In-Reply-To: <6-YRvqmmwW7Y2c8JR0oZlTmhFhhU8dp8P20hBs8UXDY=.54b1acb9-1881-41a4-ad8a-00110c0401a9@github.com> References: <6-YRvqmmwW7Y2c8JR0oZlTmhFhhU8dp8P20hBs8UXDY=.54b1acb9-1881-41a4-ad8a-00110c0401a9@github.com> Message-ID: On Wed, 10 Jan 2024 19:48:06 GMT, Ben Taylor wrote: > Clean backport of [JDK-8319436](https://bugs.openjdk.org/browse/JDK-8319436) to resolve a regression introduced in 11.0.20. Included tests pass locally on linux x64. Hi @benty-amzn, will you continue on this? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2454#issuecomment-2010023172 From btaylor at openjdk.org Wed Mar 20 17:46:29 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 20 Mar 2024 17:46:29 GMT Subject: [jdk11u-dev] RFR: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader In-Reply-To: <6-YRvqmmwW7Y2c8JR0oZlTmhFhhU8dp8P20hBs8UXDY=.54b1acb9-1881-41a4-ad8a-00110c0401a9@github.com> References: <6-YRvqmmwW7Y2c8JR0oZlTmhFhhU8dp8P20hBs8UXDY=.54b1acb9-1881-41a4-ad8a-00110c0401a9@github.com> Message-ID: On Wed, 10 Jan 2024 19:48:06 GMT, Ben Taylor wrote: > Clean backport of [JDK-8319436](https://bugs.openjdk.org/browse/JDK-8319436) to resolve a regression introduced in 11.0.20. I'll continue on this after #2612 is merged, which will prevent the need to rewrite the included junit test ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2454#issuecomment-2010213926 From clanger at openjdk.org Wed Mar 20 20:43:25 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 20 Mar 2024 20:43:25 GMT Subject: [jdk17u-dev] Integrated: 8313307: java/util/Formatter/Padding.java fails on some Locales In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 08:04:41 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8313307](https://bugs.openjdk.org/browse/JDK-8313307), commit [bd634d2e](https://github.com/openjdk/jdk21u-dev/commit/bd634d2ec77f0208a2db54bc00567777ee7c8661) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by Aleksey Shipilev on 15 Aug 2023 and had no reviewers. > > Thanks! This pull request has now been integrated. Changeset: c0d209cc Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/c0d209ccdd598ed3ca642a72201378d745ce64c4 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8313307: java/util/Formatter/Padding.java fails on some Locales Backport-of: bd634d2ec77f0208a2db54bc00567777ee7c8661 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2291 From goetz at openjdk.org Wed Mar 20 21:00:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 21:00:28 GMT Subject: [jdk11u-dev] RFR: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader In-Reply-To: <6-YRvqmmwW7Y2c8JR0oZlTmhFhhU8dp8P20hBs8UXDY=.54b1acb9-1881-41a4-ad8a-00110c0401a9@github.com> References: <6-YRvqmmwW7Y2c8JR0oZlTmhFhhU8dp8P20hBs8UXDY=.54b1acb9-1881-41a4-ad8a-00110c0401a9@github.com> Message-ID: On Wed, 10 Jan 2024 19:48:06 GMT, Ben Taylor wrote: > Clean backport of [JDK-8319436](https://bugs.openjdk.org/browse/JDK-8319436) to resolve a regression introduced in 11.0.20. That makes sense, thanks! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2454#issuecomment-2010622262 From goetz at openjdk.org Wed Mar 20 21:19:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 21:19:49 GMT Subject: [jdk21u-dev] RFR: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport bfbc41c1f177c7a2b8e91351ac41eaffaab2d8fc Changes: https://git.openjdk.org/jdk21u-dev/pull/387/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=387&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315741 Stats: 486 lines in 5 files changed: 486 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/387.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/387/head:pull/387 PR: https://git.openjdk.org/jdk21u-dev/pull/387 From wkemper at openjdk.org Wed Mar 20 21:20:58 2024 From: wkemper at openjdk.org (William Kemper) Date: Wed, 20 Mar 2024 21:20:58 GMT Subject: [jdk17u-dev] RFR: 8322503: Shenandoah: Clarify gc state usage [v2] In-Reply-To: <7RLSNRnEDJKCIGjfKBk2VBqAGWfXUIIXfFcK6B7-uZw=.402084c8-e1ce-4d62-b053-e877eedac955@github.com> References: <7RLSNRnEDJKCIGjfKBk2VBqAGWfXUIIXfFcK6B7-uZw=.402084c8-e1ce-4d62-b053-e877eedac955@github.com> Message-ID: > Resolved trivial conflicts. William Kemper has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'openjdk-17u-dev/master' into backport-jdk17u-dev-8322503 - 8322503: Shenandoah: Clarify gc state usage Reviewed-by: ysr, gli ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2298/files - new: https://git.openjdk.org/jdk17u-dev/pull/2298/files/47ec5420..baca5b34 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2298&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2298&range=00-01 Stats: 2940 lines in 131 files changed: 2291 ins; 184 del; 465 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2298.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2298/head:pull/2298 PR: https://git.openjdk.org/jdk17u-dev/pull/2298 From goetz at openjdk.org Wed Mar 20 21:22:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 21:22:53 GMT Subject: [jdk21u-dev] RFR: 8316164: Opensource JMenuBar manual test Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 8f4dfc443ba5820f5799fff1418d6632d502d57b Changes: https://git.openjdk.org/jdk21u-dev/pull/388/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=388&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316164 Stats: 128 lines in 1 file changed: 128 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/388.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/388/head:pull/388 PR: https://git.openjdk.org/jdk21u-dev/pull/388 From goetz at openjdk.org Wed Mar 20 21:28:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 21:28:30 GMT Subject: [jdk21u-dev] RFR: 8324236: compiler/ciReplay/TestInliningProtectionDomain.java failed with RuntimeException: should only dump inline information for ... expected true, was false Message-ID: <7_xw0C_jQryZIUZxTuyZmEtqz_yWfgxeC18UKSHy_j8=.189438b5-8646-4c76-8d50-daded0aaa0a1@github.com> I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 72ba8178a8271d4a04a0b789f28b23414b8989ed Changes: https://git.openjdk.org/jdk21u-dev/pull/389/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=389&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324236 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/389.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/389/head:pull/389 PR: https://git.openjdk.org/jdk21u-dev/pull/389 From goetz at openjdk.org Wed Mar 20 21:32:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 21:32:35 GMT Subject: [jdk21u-dev] RFR: 8326948: Force English locale for timeout formatting Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport e772e7817981b7b5c01b95245cf2022372494619 Changes: https://git.openjdk.org/jdk21u-dev/pull/390/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=390&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326948 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/390.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/390/head:pull/390 PR: https://git.openjdk.org/jdk21u-dev/pull/390 From goetz at openjdk.org Wed Mar 20 21:46:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 20 Mar 2024 21:46:35 GMT Subject: [jdk21u-dev] RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 9f7094079b6eb6b60b345955dba358a2d5c90931 Changes: https://git.openjdk.org/jdk21u-dev/pull/391/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=391&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327261 Stats: 24 lines in 2 files changed: 0 ins; 6 del; 18 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/391.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/391/head:pull/391 PR: https://git.openjdk.org/jdk21u-dev/pull/391 From andrewlu at openjdk.org Thu Mar 21 03:10:30 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 21 Mar 2024 03:10:30 GMT Subject: [jdk11u-dev] Integrated: 8248194: Need better support for running SA tests on core files In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 05:25:57 GMT, Andrew Lu wrote: > Backport for JDK-8248194, depends on JDK-8248667 > test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java > There is only one test, so add the other core file test for the backport. > > test/lib/jdk/test/lib/SA/SATestUtils.java > the 'unzipCores' is not exist, no need to remove. > test/lib/jdk/test/lib/apps/libLingeredApp.c > has already been updated by > https://github.com/openjdk/jdk11u-dev/pull/2590 > > Others clean. This pull request has now been integrated. Changeset: 6bcb8ac9 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/6bcb8ac9f966c552f7284957d8515c5abcf829a5 Stats: 498 lines in 6 files changed: 325 ins; 136 del; 37 mod 8248194: Need better support for running SA tests on core files Reviewed-by: lucy Backport-of: db2d4e8f5af1274d82242d3d86b922656954e1ef ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2591 From andrewlu at openjdk.org Thu Mar 21 05:39:31 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 21 Mar 2024 05:39:31 GMT Subject: [jdk11u-dev] RFR: 8270199: Most SA tests are skipped on macosx-aarch64 because all executables are signed Message-ID: I backport this for parity with 11.0.24-oracle. test/hotspot/jtreg/testlibrary_tests/TestMutuallyExclusivePlatformPredicates.java Backport to the origin file. Add backport to JDK-8241951, since it is modified after this backport. ------------- Commit messages: - Merge remote-tracking branch 'origin/master' into andrewLu_backport_8270199 - Backport 16e0ad0ad088af3ba1c9903ed8df60799a1ba651 - Backport 16e0ad0ad088af3ba1c9903ed8df60799a1ba651 - Merge remote-tracking branch 'origin/master' into andrewLu_backport_8270199 - Merge remote-tracking branch 'origin/master' into andrewLu_backport_8248194_new - Merge remote-tracking branch 'origin/master' into andrewLu_backport_8248194_new - Backport db2d4e8f5af1274d82242d3d86b922656954e1ef - Backport 1356a0f1ac06b006a20ca9fa2306ef60aef5c16e - Backport 1356a0f1ac06b006a20ca9fa2306ef60aef5c16e Changes: https://git.openjdk.org/jdk11u-dev/pull/2616/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2616&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8270199 Stats: 73 lines in 5 files changed: 35 ins; 19 del; 19 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2616.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2616/head:pull/2616 PR: https://git.openjdk.org/jdk11u-dev/pull/2616 From andrewlu at openjdk.org Thu Mar 21 08:18:38 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 21 Mar 2024 08:18:38 GMT Subject: [jdk11u-dev] RFR: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.24-oracle. > Clean except the method is not static here. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into andrewLu_backport_8312383_new - Backport bdd1aebea379b63ae405827074530ef8e8a7c239 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2610/files - new: https://git.openjdk.org/jdk11u-dev/pull/2610/files/766f4ec5..10e8227c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2610&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2610&range=00-01 Stats: 1443 lines in 16 files changed: 1033 ins; 325 del; 85 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2610.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2610/head:pull/2610 PR: https://git.openjdk.org/jdk11u-dev/pull/2610 From wkemper at openjdk.org Thu Mar 21 08:39:27 2024 From: wkemper at openjdk.org (William Kemper) Date: Thu, 21 Mar 2024 08:39:27 GMT Subject: [jdk17u-dev] Integrated: 8322503: Shenandoah: Clarify gc state usage In-Reply-To: <7RLSNRnEDJKCIGjfKBk2VBqAGWfXUIIXfFcK6B7-uZw=.402084c8-e1ce-4d62-b053-e877eedac955@github.com> References: <7RLSNRnEDJKCIGjfKBk2VBqAGWfXUIIXfFcK6B7-uZw=.402084c8-e1ce-4d62-b053-e877eedac955@github.com> Message-ID: <0qpSH7SSHkTq1Vb7FAzRtPqfGlrp0UraRGbqfCLSfO4=.c65d1c92-8bdb-46cc-8b6b-7ba9d6b87986@github.com> On Thu, 14 Mar 2024 00:19:06 GMT, William Kemper wrote: > Resolved trivial conflicts. This pull request has now been integrated. Changeset: aa2cdb3b Author: William Kemper Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/aa2cdb3bb4a3fbbaf5002a9d9d7d2354224e70be Stats: 26 lines in 5 files changed: 8 ins; 0 del; 18 mod 8322503: Shenandoah: Clarify gc state usage Reviewed-by: shade Backport-of: 51238c4bdbce48f6b719f7dcfe5b7df8b8c6d85b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2298 From goetz at openjdk.org Thu Mar 21 08:53:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 08:53:46 GMT Subject: [jdk17u-dev] RFR: 8295944: Move the Http2TestServer and related classes into a package of its own [v2] In-Reply-To: <8QL1KBFZDNOPtJfyTMcCxtTpN9HbNoV5kyPB6C9rZmg=.1abe1b82-dbba-4508-b528-58106e3a3f31@github.com> References: <8QL1KBFZDNOPtJfyTMcCxtTpN9HbNoV5kyPB6C9rZmg=.1abe1b82-dbba-4508-b528-58106e3a3f31@github.com> Message-ID: > I backport this to simplify further backports. It's a refactoring of test infra. > > I had to do resolves of Copyright, imports, and @test descriptions. A row of tests are not in 17. > In detail: > > > test/jdk/java/net/httpclient/AsFileDownloadTest.java > Needs resolve because earlier changes were al > > test/jdk/java/net/httpclient/AsyncExecutorShutdown.java > Introduced in 19 by "8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task" > This is a bug fix one wants to have in 17 at first sight, but it is a big change > and it had several follow ups. So better don't backport as prerequisite. > > test/jdk/java/net/httpclient/CancelRequestTest.java > Resolved Copyright. > > test/jdk/java/net/httpclient/CancelStreamedBodyTest.java > Introduced in 20 by "294916: Cancelling a request must eventually cause its response body subscriber to be unregistered" > This fix has many prereqs that would need to be backported. Omit. > > test/jdk/java/net/httpclient/DigestEchoClient.java > Resolved Copyright. > > test/jdk/java/net/httpclient/ExecutorShutdown.java > As above introduced by "8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task". Omit. > > test/jdk/java/net/httpclient/ExpectContinueTest.java > Introduced in 20 by "8286171: HttpClient/2 : Expect:100-Continue blocks indefinitely when response is not 100" > > test/jdk/java/net/httpclient/HeadTest.java > Resolved Copyright and imports. > "8276559: (httpclient) Consider adding an HttpRequest.Builder.HEAD method to build a HEAD request." which came in 18 > is a new feature with CSR that changed the imports. > > test/jdk/java/net/httpclient/HttpClientLocalAddrTest.java > Introduced in 19 by "8209137: Add ability to bind to specific local address to HTTP client". A new > feature. Omit. > > test/jdk/java/net/httpclient/ISO_8859_1_Test.java > Resolved Copyright > > test/jdk/java/net/httpclient/MappingResponseSubscriber.java > Resolved imports. > > test/jdk/java/net/httpclient/Response1xxTest.java > Introduced in 20 by 8292044: HttpClient doesn't handle 102 or 103 properly. Omit. > > > test/jdk/java/net/httpclient/SpecialHeadersTest.java > Resolved due to context. > > test/jdk/java/net/httpclient/http2/IdleConnectionTimeoutTest.java > Was added by 8288717: Add a means to close idle connections in HTTP/2 connection pool in 20. Omit. > > test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java > Was added by 8263031: HttpClient throws Exception if it receives a Push Promise that is too large in 19. Omit. > > test/jdk/java/net/httpclient/http2/UserInfoTest... Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Add forgotten files and one @build line ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2311/files - new: https://git.openjdk.org/jdk17u-dev/pull/2311/files/ca688e80..586e7b3c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2311&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2311&range=00-01 Stats: 3596 lines in 19 files changed: 3596 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2311.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2311/head:pull/2311 PR: https://git.openjdk.org/jdk17u-dev/pull/2311 From goetz at openjdk.org Thu Mar 21 09:11:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 09:11:21 GMT Subject: [jdk17u-dev] RFR: 8280546: Remove hard-coded 127.0.0.1 loopback address In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 14:00:07 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. GHA failure: Risc-V sysroot issue. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2315#issuecomment-2011694335 From goetz at openjdk.org Thu Mar 21 09:14:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 09:14:23 GMT Subject: [jdk11u-dev] RFR: 8314495: Update to use jtreg 7.3.1 [v2] In-Reply-To: References: Message-ID: <6-75uqxAk2UASdPuljQuk2c9WtMKHxVfjGGXyWiyYv0=.921a1c40-b866-44e5-bdb7-3f36d2231bc4@github.com> On Wed, 20 Mar 2024 08:03:41 GMT, Goetz Lindenmaier wrote: >> I backport this as announced in https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-March/030818.html >> >> Clean backport from 17 except for test/lib-test/TEST.ROOT. >> That file is not in 11. I added it for this change. I think it makes sense to have this in 11 as well. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Remove file as asked by Aleksey GHA failure: StringRepeat.java: Could not reserve enough space for 2097152KB object heap. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2612#issuecomment-2011699409 From goetz at openjdk.org Thu Mar 21 09:16:21 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 09:16:21 GMT Subject: [jdk17u-dev] RFR: 8314832: Few runtime/os tests ignore vm flags In-Reply-To: References: Message-ID: <-xrgbeAdqcn2CSJFyJZZIes5PFdY9StKMspo_gFopCI=.a42ab65f-f2b2-444e-94d0-c389b43bb0d0@github.com> On Wed, 20 Mar 2024 16:34:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. GHA failure: Risc-V sysroot issue. Unrelated. GHA failure: windows-aarch: Error: fatal: unable to access 'https://github.com/openjdk-bots/jdk17u-dev/': Recv failure: Connection was reset. Unrelated. GHA failure: linux-x86: Failed to fetch https://ppa.launchpadcontent.net/ubuntu-toolchain-r/test/ubuntu/dists/jammy/InRelease 503 Service Unavailable [IP: 185.125.190.80 443] Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2318#issuecomment-2011704247 From goetz at openjdk.org Thu Mar 21 09:18:20 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 09:18:20 GMT Subject: [jdk17u-dev] RFR: 8305169: java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java -- test server didn't start in timely manner In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 16:31:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. GHA failures: knwon and new infra issues. Unrelated ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2317#issuecomment-2011707591 From goetz at openjdk.org Thu Mar 21 09:19:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 09:19:24 GMT Subject: [jdk17u-dev] RFR: 8249693: java/nio/channels/FileChannel/FileExtensionAndMap.java uses @ignore w/o bug id In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 16:25:13 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. GHA issues: infra stuff, unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2316#issuecomment-2011710255 From goetz at openjdk.org Thu Mar 21 09:30:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 09:30:24 GMT Subject: [jdk17u-dev] RFR: 8306040: HttpResponseInputStream.available() returns 1 on empty stream In-Reply-To: References: Message-ID: On Fri, 1 Mar 2024 18:30:10 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [acaab6fd74f507bb6b18167505d88e505bdf24bd](https://github.com/openjdk/jdk/commit/acaab6fd74f507bb6b18167505d88e505bdf24bd) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > Testing: using the reproducer linked in the issue, I was able to verify the patch. > I also ran the additional test case included in the original commit and all tests in ```test/jdk/java/net/httpclient/```. > > Note that patch is not clean because http tests and related classes have since been moved into a package of their own (namely ```/test/jdk/java/net/httpclient/lib```), which doesn?t exist in jdk 17. > > Only change introduced in my patch from the original commit: > > @@ -25,7 +25,7 @@ > * @test > * @bug 8306040 > * @summary HttpResponseInputStream.available() returns 1 on empty stream > - * @library /test/lib /test/jdk/java/net/httpclient/lib > + * @library /test/lib > * @run junit/othervm HttpInputStreamAvailableTest > * > */ Thanks for finishing this! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2263#issuecomment-2011733517 From shade at openjdk.org Thu Mar 21 09:52:24 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 21 Mar 2024 09:52:24 GMT Subject: [jdk21u-dev] Integrated: 8319048: Monitor deflation unlink phase prolongs time to safepoint In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 09:15:14 GMT, Aleksey Shipilev wrote: > Clean backport to improve TTSP under heavy monitor deflation, and provide better parity. > > Additional testing: > - [x] Ad-hoc benchmarks show TTSP improvements > - [x] MacOS AArch64 server fastdebug, `runtime/Monitor` passes > - [x] Linux x86_64 server fastdebug, `all` This pull request has now been integrated. Changeset: cc918abe Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/cc918abe2f6e6a95c956d4f2a37e77d2f53eab36 Stats: 235 lines in 4 files changed: 221 ins; 0 del; 14 mod 8319048: Monitor deflation unlink phase prolongs time to safepoint Backport-of: efc392259c64986bbbe880259e95b09058b9076a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/369 From goetz at openjdk.org Thu Mar 21 10:04:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 10:04:27 GMT Subject: [jdk11u-dev] RFR: 8261302: NMT: Improve malloc site table hashing In-Reply-To: References: <_ny2Kp7iL7owSh1b04gD8W24u_bpaYnZX3bkH-2P_Pk=.71c32d9c-ac0d-4730-b69f-b6ee88a11035@github.com> Message-ID: On Wed, 20 Mar 2024 15:20:07 GMT, Mar?a Arias de Reyna wrote: >>> Hi @Delawen, I don't see why this should be backported to a stable release as 11. >> >> Hi @GoeLin , this is part of a (smallish) chain of changes that would make NMT in 11 feature-equivalent to 21. Since NMT continues to be very important to us, and since the changes in general are low-risk, I suggested making these backports. > > I have a list of potential NMT improvements (following @tstuefe steps) that could be backported here. To me it makes sense to be as similar as JDK21, but of course this is not my call, so let me know if I should proceed. @Delawen, @stuefe, can you please share the list of intended backports? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2608#issuecomment-2011800567 From goetz at openjdk.org Thu Mar 21 10:14:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 10:14:25 GMT Subject: [jdk17u-dev] RFR: 8249693: java/nio/channels/FileChannel/FileExtensionAndMap.java uses @ignore w/o bug id In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 16:25:13 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. In our nightly testing, this crashed on linuxaarch. This is very unexpected, especially given this change only modifies the test. Problematic frame: # v ~StubRoutines::forward_copy_longs ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2316#issuecomment-2011824402 From goetz at openjdk.org Thu Mar 21 10:20:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 10:20:49 GMT Subject: [jdk17u-dev] RFR: 8260540: serviceability/jdwp/AllModulesCommandTest.java failed with "Debuggee error: 'ERROR: transport error 202: bind failed: Address already in use'" Message-ID: I backport this for parity with 17.0.12-oracle. I had to resolve Debuggee.java. Several later changes were already backported, so I compared it with the last of these, where 21 and 17 should be equal again: '8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use"' ------------- Commit messages: - Backport 7a23c9cbb7d09c4e6c4e8d9b2f912e41d60fd05e Changes: https://git.openjdk.org/jdk17u-dev/pull/2319/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2319&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8260540 Stats: 134 lines in 7 files changed: 62 ins; 43 del; 29 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2319.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2319/head:pull/2319 PR: https://git.openjdk.org/jdk17u-dev/pull/2319 From duke at openjdk.org Thu Mar 21 10:36:23 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Thu, 21 Mar 2024 10:36:23 GMT Subject: [jdk11u-dev] RFR: 8261302: NMT: Improve malloc site table hashing In-Reply-To: References: <_ny2Kp7iL7owSh1b04gD8W24u_bpaYnZX3bkH-2P_Pk=.71c32d9c-ac0d-4730-b69f-b6ee88a11035@github.com> Message-ID: <_mRBD--u02aMlSXoQZN9uOTBLX54b7RsTifimUVugXg=.152aa67d-be4e-4fb3-a25f-3f122fad6e5c@github.com> On Thu, 21 Mar 2024 10:01:46 GMT, Goetz Lindenmaier wrote: >> I have a list of potential NMT improvements (following @tstuefe steps) that could be backported here. To me it makes sense to be as similar as JDK21, but of course this is not my call, so let me know if I should proceed. > > @Delawen, @stuefe, can you please share the list of intended backports? Here is the short version list @GoeLin To JDK11: The one with the opened PR with its follow-up: * JDK-8261302: NMT: Improve malloc site table hashing * JDK-8261520 Other related issues: * JDK-8261644: NMT: Simplifications and cleanups * JDK-8262165: NMT report should state how many callsites had been skipped * JDK-8256844: Make NMT late-initializable * JDK-8275320: NMT should perform buffer overrun checks * JDK-8277822: Remove debug-only heap overrun checks in os::malloc and friends * JDK-8281015: Further simplify NMT backend * JDK-8292072: repurpose Tracking overhead counter as global malloc counter * JDK-8297958: Display peak values * JDK-8317772: Make peak values available in release builds TO JDK17 and below: * JDK-8280583 (fixed in 19): Always build NMT * JDK-8281023 (fixed in 19): NMT integration into pp debug command does not work * JDK-8281460 (fixed in 19): Let ObjectMonitor have its own NMT category * JDK-8289182 (fixed in 20): MemTracker::baseline should return void * JDK-8289633 (fixed in 20): Forbid raw C-heap allocation functions in hotspot and fix findings hotspot integrated * JDK-8290868 (fixed in 20): MallocSiteTable statistics improvements * JDK-8290870 (fixed in 20): Increase MallocSiteTable size and allocate it only when needed * JDK-8291878 (fixed in 20): Diagnostic malloc limits * JDK-8292071 (fixed in 20): move MallocHeader to its own header and inline header checks * JDK-8292073 (fixed in 20): remove unused constructor parameter from MallocHeader * JDK-8293313: (fixed in 21): Add "Fake OOM" mode to MallocLimit * JDK-8302820 (fixed in 21): Remove costs for NMTPreInit when NMT is off * JDK-8292561 (fixed in 20): Make "ReplayCompiles" a diagnostic product switch * JDK-8319437 (fixed in 22, to check JDK21): should show library names in call stacks * JDK-8320061 (fixed in 22, to check JDK21): Multiple issues with peak accounting Maybe I should start with the ones associated with JDK17? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2608#issuecomment-2011879244 From volker.simonis at gmail.com Thu Mar 21 10:42:22 2024 From: volker.simonis at gmail.com (Volker Simonis) Date: Thu, 21 Mar 2024 11:42:22 +0100 Subject: Proposal: Branch github.com/openjdk/jdk for stabilization (instead of fork) In-Reply-To: References: Message-ID: Hi Iris, This proposal sounds interesting and reasonable.It would be especially beneficial if the JDK Updates Project (added to CC) would adopt this new model. I think what you mention with "Stabilization branches have been used successfully by the JDK Updates Project since April 2021 (for 16.0.1)" only applies to the first two updates of every feature release which are managed by Oracle. As far as I can see, the community-maintained update trains all do not use branches but instead *two* repositories ("jdkXXu" and "jdkXXu-dev"). I think we could save quite some local disc space if *all* update projects would be just branches in a single jdk-updates repository. One thing I can't overlook and where I'd like to get feedback from the experts is how such a change will affect the JBS integration and the GitHub privileges. Regarding JBS, will it still be possible to track all the different update releases if they are managed as branches and will this a large change? Regarding the GitHub privileges, will such a change have any impact on how update maintainers can push to the updates repositories/branches and how contributors will downport and integrate backports? Thank you and best regards, Volker On Wed, Mar 20, 2024 at 7:07?PM Iris Clark wrote: > > Hi. > > The source code for JDK main-line development has been managed in git since > September 2020 [0]. > > The jdk repository is always open for commits. In June and December, we fork > the main line into a stabilization repository [1]. Changes are backported > from the jdk repository into the stabilization repository, typically by the > Committer who contributed the change [2]. The stabilization repository is > archived when the release is delivered. > > We inherited the convention of forking repositories from Mercurial, which > originally had weak support for branches. Forking repositories entails some > disadvantages. Most notably, setting up a local branch tracking the "master" > branch in a stabilization repository is cumbersome, which makes diffs across > branches less convenient. Stabilization branches have been used successfully > by the JDK Updates Project since April 2021 (for 16.0.1). > > I propose that the JDK feature releases (e.g., JDK 23, JDK 24) use branches > rather than repositories for stabilization. The "master" branch will continue > to be the always-open default branch, used for main-line development. Instead > of a stabilization repository "jdk$N" (where $N is the version number of the > next release, e.g. "jdk23" or "jdk24"), we will use a stabilization branch > with the same name, "jdk$N". Changes will be backported from the master > branch via pull requests targeting the release-specific stabilization branch. > The stabilization branch will be locked when the release is delivered. > > I suggest that we adopt this proposal for JDK 23 RDP 1, June 2024. > > Concerns? > > Thanks, > Iris > > [0] https://mail.openjdk.org/pipermail/jdk-dev/2020-September/004694.html > [1] https://openjdk.org/jeps/3#rdp-1 > [2] https://mail.openjdk.org/pipermail/jdk-dev/2023-April/007612.html From sgehwolf at redhat.com Thu Mar 21 11:07:16 2024 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Thu, 21 Mar 2024 12:07:16 +0100 Subject: Proposal: Branch github.com/openjdk/jdk for stabilization (instead of fork) In-Reply-To: References: Message-ID: <7f95dd63bff94ca764d58226c2be464fe006f0e0.camel@redhat.com> On Thu, 2024-03-21 at 11:42 +0100, Volker Simonis wrote: > This proposal sounds interesting and reasonable.It would be especially > beneficial if the JDK Updates Project (added to CC) would adopt this > new model. We can consider it for jdk-updates at a later point. I don't think it's good to conflate those two at this point. Lets get mainline JDK development switched, first. See how it pans out for mainline and corresponding downstream consumers. Once we have that experience, we could model it for jdk-updates further down the line. Thanks, Severin From goetz at openjdk.org Thu Mar 21 12:27:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 12:27:26 GMT Subject: [jdk21u-dev] Integrated: 8303891: Speed up Zip64SizeTest using a small ZIP64 file In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 19:43:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 8ecc67bd Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/8ecc67bdb88319e7dc8c7daa4074e0b02df93cfb Stats: 147 lines in 1 file changed: 75 ins; 10 del; 62 mod 8303891: Speed up Zip64SizeTest using a small ZIP64 file 8259866: two java.util tests failed with "IOException: There is not enough space on the disk" Backport-of: 842b895f093e15ecd8aa0153d712f5f81cf1cf67 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/383 From goetz at openjdk.org Thu Mar 21 12:28:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 12:28:28 GMT Subject: [jdk17u-dev] Integrated: 8297449: Update JInternalFrame Metal Border code In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 20:43:47 GMT, Goetz Lindenmaier wrote: > I backport this as follow up of 8015739 This pull request has now been integrated. Changeset: 09f3890d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/09f3890dd0f09ed5d63389081aa703160eccc50f Stats: 55 lines in 1 file changed: 17 ins; 22 del; 16 mod 8297449: Update JInternalFrame Metal Border code Backport-of: 09629570f5d064dc2a5cd670de8d648156ac3991 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2312 From goetz at openjdk.org Thu Mar 21 12:31:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 12:31:27 GMT Subject: [jdk17u-dev] Integrated: 8305169: java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java -- test server didn't start in timely manner In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 16:31:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. This pull request has now been integrated. Changeset: a8a81286 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/a8a81286a7d5e8f76e946ef26bc68cd95cc6a09a Stats: 28 lines in 2 files changed: 17 ins; 8 del; 3 mod 8305169: java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java -- test server didn't start in timely manner Backport-of: 3f6a3545a255cbef3c3436ff26481f1cec4ccfc9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2317 From goetz at openjdk.org Thu Mar 21 12:31:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 12:31:31 GMT Subject: [jdk21u-dev] Integrated: 8325908: Finish removal of IntlTest and CollatorTest In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 20:02:42 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: d9539f59 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/d9539f599aef5667879e7357c42da550b180e344 Stats: 93 lines in 7 files changed: 46 ins; 20 del; 27 mod 8325908: Finish removal of IntlTest and CollatorTest Backport-of: 4c7b313e0dc917cdaffbb2ecc86d1347683acad0 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/384 From goetz at openjdk.org Thu Mar 21 12:33:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 12:33:33 GMT Subject: [jdk11u-dev] Integrated: 8314495: Update to use jtreg 7.3.1 In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 14:27:01 GMT, Goetz Lindenmaier wrote: > I backport this as announced in https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-March/030818.html > > Clean backport from 17 except for test/lib-test/TEST.ROOT. > That file is not in 11. I added it for this change. I think it makes sense to have this in 11 as well. This pull request has now been integrated. Changeset: 50d05032 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/50d0503294ceb77289786532c82a887f12fba425 Stats: 9 lines in 7 files changed: 0 ins; 0 del; 9 mod 8314495: Update to use jtreg 7.3.1 Reviewed-by: shade, lucy Backport-of: 75e14419d29c1dc98bd040490e93ae8f6eee4e43 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2612 From goetz at openjdk.org Thu Mar 21 12:33:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 12:33:33 GMT Subject: [jdk17u-dev] Integrated: 8324632: Update Zlib Data Compression Library to Version 1.3.1 In-Reply-To: References: Message-ID: On Thu, 14 Mar 2024 21:09:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > I backport the change in 21 which merged three related changes. > > I had to resolve ChangeLog. Unfortunately in 21, "8283525: http://tools.ietf.org/html/* URLs return 404" > changed 'http' to https' in many files including this one, but this file should not > be touched as it is not owned by our project. But might be clean anyways. This pull request has now been integrated. Changeset: 6359b284 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/6359b2843f83852561b925d3f1315eed5f4b9cda Stats: 2219 lines in 26 files changed: 609 ins; 1036 del; 574 mod 8324632: Update Zlib Data Compression Library to Version 1.3.1 8315117: Update Zlib Data Compression Library to Version 1.3 8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1 Reviewed-by: mbaesken Backport-of: 6d8d049e4a7c77d8aa8a5d71446de1deb64d96e9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2300 From goetz at openjdk.org Thu Mar 21 12:35:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 21 Mar 2024 12:35:24 GMT Subject: [jdk17u-dev] Integrated: 8314832: Few runtime/os tests ignore vm flags In-Reply-To: References: Message-ID: <3UXz4Rk1MrHQCKoEZ4W4LTi_fkZoF5JT7aD1XmwR93I=.a9c8735c-4df4-42ec-9049-943f09cdaf76@github.com> On Wed, 20 Mar 2024 16:34:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. This pull request has now been integrated. Changeset: 9922f220 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/9922f220ed957e64c6a48e6a1f0518282abeff6a Stats: 11 lines in 3 files changed: 11 ins; 0 del; 0 mod 8314832: Few runtime/os tests ignore vm flags Backport-of: fc3e8266929826f8e58bc76fe97423d76bc7be87 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2318 From shade at openjdk.org Thu Mar 21 12:35:30 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 21 Mar 2024 12:35:30 GMT Subject: [jdk11u-dev] RFR: 8299677: Formatter.format might take a long time to format an integer or floating-point [v6] In-Reply-To: References: <3x5WamE3lFZ4CXEdscr2c2R6vlUnFhYIWUnv9LPuejE=.d03415f3-4f22-4fb0-986c-326e03b15ba1@github.com> Message-ID: On Tue, 27 Feb 2024 21:06:20 GMT, Paul Hohensee wrote: >> Simple almost clean backport of a potential DOS attack vector fix. Backport from JDK 17 (see https://github.com/openjdk/jdk17u-dev/pull/1077) is clean. Copyright date conflict, plus changed >> >> Flags.contains(f, Flags.ZERO_PAD) >> >> to >> >> f.contains(Flags.ZERO_PAD) >> >> Passes new and old Formatter tests. > > Paul Hohensee has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 87 commits: > > - Merge branch 'master' into backport-8299677 > - 8306372: Open source AWT CardLayout and Checkbox tests > > Backport-of: 781d6d793ad4cecb774bcbcb362c726779408ffd > - 8314960: Add Certigna Root CA - 2 > > Backport-of: a44f8b059847135ecd0618cb04abbb0d2be1d2d0 > - Merge branch 'master' into backport-8299677 > - Merge master > - Merge master > - Merge branch 'master' into backport-8299677 > - 8303075: [11u] Add CompileClassWithDebugTest to ProblemList for 8303074 > > Reviewed-by: phh > - 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction > > Reviewed-by: phh > Backport-of: 4da45c430139fe66fab020c2f96686dc9cf26a97 > - 8273895: compiler/ciReplay/TestVMNoCompLevel.java fails due to wrong data size with TieredStopAtLevel=2,3 > > Backport-of: a561eac912740da6a5982c47558e13f34481219f > - ... and 77 more: https://git.openjdk.org/jdk11u-dev/compare/6e296a01...b13e668a Now that #2612 is in, we can re-merge from master and finalize this backport. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1667#issuecomment-2012163574 From kevin.rushforth at oracle.com Thu Mar 21 13:40:14 2024 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Thu, 21 Mar 2024 06:40:14 -0700 Subject: Proposal: Branch github.com/openjdk/jdk for stabilization (instead of fork) In-Reply-To: <7f95dd63bff94ca764d58226c2be464fe006f0e0.camel@redhat.com> References: <7f95dd63bff94ca764d58226c2be464fe006f0e0.camel@redhat.com> Message-ID: <84fe2513-d8a1-4a4d-ad1a-11871d395950@oracle.com> On 3/21/2024 4:07 AM, Severin Gehwolf wrote: > On Thu, 2024-03-21 at 11:42 +0100, Volker Simonis wrote: >> This proposal sounds interesting and reasonable.It would be especially >> beneficial if the JDK Updates Project (added to CC) would adopt this >> new model. > We can consider it for jdk-updates at a later point. I don't think it's > good to conflate those two at this point. Lets get mainline JDK > development switched, first. See how it pans out for mainline and > corresponding downstream consumers. > > Once we have that experience, we could model it for jdk-updates further > down the line. I agree. This proposal deliberately does not address update releases. Any changes to update releases would necessarily need a separate proposal with its own discussion. Waiting to see how it works in practice for the JDK Project seems wise. If and when the JDK Updates Project makes a proposal to switch to branches, the repository and branch structure -- specifically, whether to continue to have a per-release-family jdkNNu repo vs moving to a single jdk-updates repo -- would be a big part of that discussion. I have an opinion on that, based on experience with our internal update releases and with the GitHub workflow, but will leave it for that later discussion. -- Kevin -------------- next part -------------- An HTML attachment was scrubbed... URL: From shade at openjdk.org Thu Mar 21 15:45:21 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 21 Mar 2024 15:45:21 GMT Subject: [jdk22u] Integrated: 8325613: CTW: Stale method cleanup requires GC after Sweeper removal In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 09:52:07 GMT, Aleksey Shipilev wrote: > Clean backport to improve CTW testing times. > > Additional testing: > - [x] Ad-hoc CTW time measurements for `java.base` demonstrate the same improvements as in mainline > - [x] MacOS AArch64 server fastdebug, `applications/ctw/modules` passes This pull request has now been integrated. Changeset: 5ff2b5df Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/5ff2b5df54a0add36bf1da4536b81e6ab9a58c5e Stats: 26 lines in 2 files changed: 24 ins; 1 del; 1 mod 8325613: CTW: Stale method cleanup requires GC after Sweeper removal Backport-of: 1281e18f1447848d7eb5e3bde508ac002b4c390d ------------- PR: https://git.openjdk.org/jdk22u/pull/104 From mbaesken at openjdk.org Thu Mar 21 15:45:34 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 21 Mar 2024 15:45:34 GMT Subject: [jdk22u] Integrated: 8328165: improve assert(idx < _maxlrg) failed: oob In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 13:51:07 GMT, Matthias Baesken wrote: > 8328165: improve assert(idx < _maxlrg) failed: oob This pull request has now been integrated. Changeset: c90dd216 Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/c90dd216d77fc26bf7d54e31f4ec9263ca6a82e8 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8328165: improve assert(idx < _maxlrg) failed: oob Backport-of: d57bdd85ab5e45a2ecfce0c022da067ac30bb80d ------------- PR: https://git.openjdk.org/jdk22u/pull/107 From mbaesken at openjdk.org Thu Mar 21 15:55:44 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 21 Mar 2024 15:55:44 GMT Subject: [jdk21u-dev] RFR: 8328165: improve assert(idx < _maxlrg) failed: oob Message-ID: 8328165: improve assert(idx < _maxlrg) failed: oob ------------- Commit messages: - Backport d57bdd85ab5e45a2ecfce0c022da067ac30bb80d Changes: https://git.openjdk.org/jdk21u-dev/pull/392/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=392&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328165 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/392.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/392/head:pull/392 PR: https://git.openjdk.org/jdk21u-dev/pull/392 From shade at openjdk.org Thu Mar 21 17:22:36 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 21 Mar 2024 17:22:36 GMT Subject: [jdk17u-dev] RFR: 8319048: Monitor deflation unlink phase prolongs time to safepoint Message-ID: Unclean backport to eliminate another safepoint hiccup caused by monitor deflation. The uncleanliness comes mostly from `NULL` vs `nullptr` differences in affected hunks. I chose to accept the new version that uses `nullptr` consistently, even though some `NULL`-s might have been left alone. Additional testing: - [x] Linux x86_64 server fastdebug, `all` tests pass ------------- Commit messages: - Backport efc392259c64986bbbe880259e95b09058b9076a Changes: https://git.openjdk.org/jdk17u-dev/pull/2309/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2309&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319048 Stats: 240 lines in 4 files changed: 222 ins; 0 del; 18 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2309.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2309/head:pull/2309 PR: https://git.openjdk.org/jdk17u-dev/pull/2309 From mbalao at openjdk.org Fri Mar 22 00:55:30 2024 From: mbalao at openjdk.org (Martin Balao) Date: Fri, 22 Mar 2024 00:55:30 GMT Subject: [jdk11u-dev] RFR: 8317507: C2 compilation fails with "Exceeded _node_regs array" Message-ID: Hi, I'd like to propose this backport to 11u-dev. The 17u fix applies cleanly. I ran and debugged the test to make sure that it is triggering the faulty behavior. Thanks, Martin.- ------------- Commit messages: - 8317507: C2 compilation fails with "Exceeded _node_regs array" Changes: https://git.openjdk.org/jdk11u-dev/pull/2617/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2617&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317507 Stats: 602 lines in 2 files changed: 602 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2617.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2617/head:pull/2617 PR: https://git.openjdk.org/jdk11u-dev/pull/2617 From andrewlu at openjdk.org Fri Mar 22 02:15:32 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 22 Mar 2024 02:15:32 GMT Subject: [jdk11u-dev] Integrated: 8315663: Open source misc awt tests In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 05:37:19 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. This pull request has now been integrated. Changeset: 12a28633 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/12a28633d28e08884fafeb654bbc22af166f3651 Stats: 263 lines in 3 files changed: 263 ins; 0 del; 0 mod 8315663: Open source misc awt tests Backport-of: a36f5a54ab4871739f2ccbabb684942fc3cadf20 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2611 From andrewlu at openjdk.org Fri Mar 22 02:15:33 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 22 Mar 2024 02:15:33 GMT Subject: [jdk17u-dev] Integrated: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 09:30:27 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: 6700a499 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/6700a499a33ced0b3d581a936565e2a8fe68f0ee Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection Backport-of: bdd1aebea379b63ae405827074530ef8e8a7c239 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2303 From andrewlu at openjdk.org Fri Mar 22 02:15:35 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 22 Mar 2024 02:15:35 GMT Subject: [jdk17u-dev] Integrated: 8315663: Open source misc awt tests In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 05:35:30 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: d5544374 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/d5544374ba38b15e605846948292d7ae9b01de52 Stats: 263 lines in 3 files changed: 263 ins; 0 del; 0 mod 8315663: Open source misc awt tests Backport-of: a36f5a54ab4871739f2ccbabb684942fc3cadf20 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2306 From andrewlu at openjdk.org Fri Mar 22 02:15:36 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 22 Mar 2024 02:15:36 GMT Subject: [jdk21u-dev] Integrated: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 09:11:11 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 9228cdda Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/9228cdda841e8f53ff7d7653c891ba27eebf12a6 Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection Backport-of: bdd1aebea379b63ae405827074530ef8e8a7c239 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/368 From andrewlu at openjdk.org Fri Mar 22 02:15:36 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 22 Mar 2024 02:15:36 GMT Subject: [jdk21u-dev] Integrated: 8315663: Open source misc awt tests In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 05:33:56 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: bac3b94c Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/bac3b94c106a485b864b84d08109d4d7fa900a17 Stats: 263 lines in 3 files changed: 263 ins; 0 del; 0 mod 8315663: Open source misc awt tests Backport-of: a36f5a54ab4871739f2ccbabb684942fc3cadf20 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/380 From goetz at openjdk.org Fri Mar 22 07:06:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Mar 2024 07:06:27 GMT Subject: [jdk22u] Integrated: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 07:28:02 GMT, Goetz Lindenmaier wrote: > I backport this to fix the GHA issue. This pull request has now been integrated. Changeset: 5b3e5668 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk22u/commit/5b3e5668f2308aaa6770fcc01f38fa5ff32d9398 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap Backport-of: eebcc2181fe27f6aa10559233c7c58882a146f56 ------------- PR: https://git.openjdk.org/jdk22u/pull/108 From goetz at openjdk.org Fri Mar 22 07:06:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Mar 2024 07:06:30 GMT Subject: [jdk22u] Integrated: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap In-Reply-To: References: Message-ID: <70QAFfuFAUEEB1CSanQOtJRzN9ZfsuSa2KaY9C1PlQ8=.a5cd961f-2c58-405e-8b50-527b6a5a1202@github.com> On Tue, 19 Mar 2024 10:06:26 GMT, Goetz Lindenmaier wrote: > I backport this to stabilize the GHA tests. This pull request has now been integrated. Changeset: 089aad7d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk22u/commit/089aad7d94566d1ba708e47d04e1b3e9fd487aa3 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap Backport-of: dde519dc2180742c119ac07221c2a149b9f06c18 ------------- PR: https://git.openjdk.org/jdk22u/pull/106 From goetz at openjdk.org Fri Mar 22 08:02:13 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Mar 2024 08:02:13 GMT Subject: [jdk17u-dev] RFR: 8295944: Move the Http2TestServer and related classes into a package of its own [v3] In-Reply-To: <8QL1KBFZDNOPtJfyTMcCxtTpN9HbNoV5kyPB6C9rZmg=.1abe1b82-dbba-4508-b528-58106e3a3f31@github.com> References: <8QL1KBFZDNOPtJfyTMcCxtTpN9HbNoV5kyPB6C9rZmg=.1abe1b82-dbba-4508-b528-58106e3a3f31@github.com> Message-ID: > I backport this to simplify further backports. It's a refactoring of test infra. > > I had to do resolves of Copyright, imports, and @test descriptions. A row of tests are not in 17. > In detail: > > > test/jdk/java/net/httpclient/AsFileDownloadTest.java > Needs resolve because earlier changes were al > > test/jdk/java/net/httpclient/AsyncExecutorShutdown.java > Introduced in 19 by "8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task" > This is a bug fix one wants to have in 17 at first sight, but it is a big change > and it had several follow ups. So better don't backport as prerequisite. > > test/jdk/java/net/httpclient/CancelRequestTest.java > Resolved Copyright. > > test/jdk/java/net/httpclient/CancelStreamedBodyTest.java > Introduced in 20 by "294916: Cancelling a request must eventually cause its response body subscriber to be unregistered" > This fix has many prereqs that would need to be backported. Omit. > > test/jdk/java/net/httpclient/DigestEchoClient.java > Resolved Copyright. > > test/jdk/java/net/httpclient/ExecutorShutdown.java > As above introduced by "8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task". Omit. > > test/jdk/java/net/httpclient/ExpectContinueTest.java > Introduced in 20 by "8286171: HttpClient/2 : Expect:100-Continue blocks indefinitely when response is not 100" > > test/jdk/java/net/httpclient/HeadTest.java > Resolved Copyright and imports. > "8276559: (httpclient) Consider adding an HttpRequest.Builder.HEAD method to build a HEAD request." which came in 18 > is a new feature with CSR that changed the imports. > > test/jdk/java/net/httpclient/HttpClientLocalAddrTest.java > Introduced in 19 by "8209137: Add ability to bind to specific local address to HTTP client". A new > feature. Omit. > > test/jdk/java/net/httpclient/ISO_8859_1_Test.java > Resolved Copyright > > test/jdk/java/net/httpclient/MappingResponseSubscriber.java > Resolved imports. > > test/jdk/java/net/httpclient/Response1xxTest.java > Introduced in 20 by 8292044: HttpClient doesn't handle 102 or 103 properly. Omit. > > > test/jdk/java/net/httpclient/SpecialHeadersTest.java > Resolved due to context. > > test/jdk/java/net/httpclient/http2/IdleConnectionTimeoutTest.java > Was added by 8288717: Add a means to close idle connections in HTTP/2 connection pool in 20. Omit. > > test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java > Was added by 8263031: HttpClient throws Exception if it receives a Push Promise that is too large in 19. Omit. > > test/jdk/java/net/httpclient/http2/UserInfoTest... Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Adapt ConnectionReuseTest ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2311/files - new: https://git.openjdk.org/jdk17u-dev/pull/2311/files/586e7b3c..cb85d9f2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2311&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2311&range=01-02 Stats: 15 lines in 1 file changed: 5 ins; 5 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2311.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2311/head:pull/2311 PR: https://git.openjdk.org/jdk17u-dev/pull/2311 From pkoppula at openjdk.org Fri Mar 22 08:16:52 2024 From: pkoppula at openjdk.org (Prasadrao Koppula) Date: Fri, 22 Mar 2024 08:16:52 GMT Subject: [jdk22u] RFR: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message Message-ID: Clean backport ------------- Commit messages: - Backport d44aaa37f98dd383aebbec097427feb1f1c29b74 Changes: https://git.openjdk.org/jdk22u/pull/109/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=109&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326643 Stats: 294 lines in 2 files changed: 293 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/109.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/109/head:pull/109 PR: https://git.openjdk.org/jdk22u/pull/109 From goetz at openjdk.org Fri Mar 22 08:20:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Mar 2024 08:20:27 GMT Subject: [jdk17u-dev] RFR: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 15:45:08 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR contains a backport of [6c0bebccb0092d9726eb89a054e023e92edf7ca6](https://github.com/openjdk/jdk/commit/6c0bebccb0092d9726eb89a054e023e92edf7ca6). >> >> Patch is not clean. Test won't build in 17 because it can't find ```import jdk.internal.util.OperatingSystem```. >> >> This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485). >> >> I've worked around that by removing the dependency to that utility function and checking the operating system with ```System.getProperty("os.name")```. >> >> Testing: >> - [x] Added test case passes >> >> Thanks! > > GHA Failures: > > - Unrelated RISC-V failure. > - Unrelated test failures: ```java/lang/String/StringRepeat.java``` in ```jdk/tier1 part1```. I'm seeing these failures intermittently across all PRs. Hi @SoniaZaldana, did you see the comment in the JBS issue? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2305#issuecomment-2014586324 From goetz at openjdk.org Fri Mar 22 08:25:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Mar 2024 08:25:31 GMT Subject: [jdk11u-dev] RFR: 8261302: NMT: Improve malloc site table hashing In-Reply-To: <_mRBD--u02aMlSXoQZN9uOTBLX54b7RsTifimUVugXg=.152aa67d-be4e-4fb3-a25f-3f122fad6e5c@github.com> References: <_ny2Kp7iL7owSh1b04gD8W24u_bpaYnZX3bkH-2P_Pk=.71c32d9c-ac0d-4730-b69f-b6ee88a11035@github.com> <_mRBD--u02aMlSXoQZN9uOTBLX54b7RsTifimUVugXg=.152aa67d-be4e-4fb3-a25f-3f122fad6e5c@github.com> Message-ID: On Thu, 21 Mar 2024 10:33:33 GMT, Mar?a Arias de Reyna wrote: >> @Delawen, @stuefe, can you please share the list of intended backports? > > Here is the short version list @GoeLin > > To JDK11: > > The one with the opened PR with its follow-up: > * JDK-8261302: NMT: Improve malloc site table hashing > * JDK-8261520 > > Other related issues: > * JDK-8261644: NMT: Simplifications and cleanups > * JDK-8262165: NMT report should state how many callsites had been skipped > * JDK-8256844: Make NMT late-initializable > * JDK-8275320: NMT should perform buffer overrun checks > * JDK-8277822: Remove debug-only heap overrun checks in os::malloc and friends > * JDK-8281015: Further simplify NMT backend > * JDK-8292072: repurpose Tracking overhead counter as global malloc counter > * JDK-8297958: Display peak values > * JDK-8317772: Make peak values available in release builds > > TO JDK17 and below: > * JDK-8280583 (fixed in 19): Always build NMT > * JDK-8281023 (fixed in 19): NMT integration into pp debug command does not work > * JDK-8281460 (fixed in 19): Let ObjectMonitor have its own NMT category > * JDK-8289182 (fixed in 20): MemTracker::baseline should return void > * JDK-8289633 (fixed in 20): Forbid raw C-heap allocation functions in hotspot and fix findings hotspot integrated > * JDK-8290868 (fixed in 20): MallocSiteTable statistics improvements > * JDK-8290870 (fixed in 20): Increase MallocSiteTable size and allocate it only when needed > * JDK-8291878 (fixed in 20): Diagnostic malloc limits > * JDK-8292071 (fixed in 20): move MallocHeader to its own header and inline header checks > * JDK-8292073 (fixed in 20): remove unused constructor parameter from MallocHeader > * JDK-8293313: (fixed in 21): Add "Fake OOM" mode to MallocLimit > * JDK-8302820 (fixed in 21): Remove costs for NMTPreInit when NMT is off > * JDK-8292561 (fixed in 20): Make "ReplayCompiles" a diagnostic product switch > * JDK-8319437 (fixed in 22, to check JDK21): should show library names in call stacks > * JDK-8320061 (fixed in 22, to check JDK21): Multiple issues with peak accounting > > Maybe I should start with the ones associated with JDK17? Hi @Delawen, could you please edit the comment and add links to the bugIDs? You should start with 21. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2608#issuecomment-2014594544 From mbaesken at openjdk.org Fri Mar 22 08:29:23 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 22 Mar 2024 08:29:23 GMT Subject: [jdk21u-dev] Integrated: 8328165: improve assert(idx < _maxlrg) failed: oob In-Reply-To: References: Message-ID: On Thu, 21 Mar 2024 15:48:19 GMT, Matthias Baesken wrote: > 8328165: improve assert(idx < _maxlrg) failed: oob This pull request has now been integrated. Changeset: 77d6dfd8 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/77d6dfd854f3322a0cd5c89a7d96393703a918eb Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8328165: improve assert(idx < _maxlrg) failed: oob Backport-of: d57bdd85ab5e45a2ecfce0c022da067ac30bb80d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/392 From goetz at openjdk.org Fri Mar 22 08:37:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Mar 2024 08:37:28 GMT Subject: [jdk17u-dev] RFR: 8280546: Remove hard-coded 127.0.0.1 loopback address In-Reply-To: References: Message-ID: <315Wk8IGmJJQZYCMts4rEMhxfWjrhQnojlyDqDuKFvc=.af85c1c2-b2d7-4707-b676-3b5d525d8b4d@github.com> On Wed, 20 Mar 2024 14:00:07 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2315#issuecomment-2014610075 From goetz at openjdk.org Fri Mar 22 08:39:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Mar 2024 08:39:27 GMT Subject: [jdk21u-dev] RFR: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 21:14:45 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/387#issuecomment-2014613785 From goetz at openjdk.org Fri Mar 22 08:39:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Mar 2024 08:39:31 GMT Subject: [jdk17u-dev] RFR: 8249693: java/nio/channels/FileChannel/FileExtensionAndMap.java uses @ignore w/o bug id In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 16:25:13 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. GHA failure x86: tests passed, upload failed: Error: Failed to CreateArtifact: Unable to make request: ECONNRESET. Unrelated GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2316#issuecomment-2014613184 From goetz at openjdk.org Fri Mar 22 08:40:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Mar 2024 08:40:23 GMT Subject: [jdk21u-dev] RFR: 8326948: Force English locale for timeout formatting In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 21:27:44 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/390#issuecomment-2014614772 From goetz at openjdk.org Fri Mar 22 08:40:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Mar 2024 08:40:28 GMT Subject: [jdk21u-dev] RFR: 8316164: Opensource JMenuBar manual test In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 21:17:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/388#issuecomment-2014614112 From goetz at openjdk.org Fri Mar 22 08:40:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Mar 2024 08:40:23 GMT Subject: [jdk21u-dev] RFR: 8324236: compiler/ciReplay/TestInliningProtectionDomain.java failed with RuntimeException: should only dump inline information for ... expected true, was false In-Reply-To: <7_xw0C_jQryZIUZxTuyZmEtqz_yWfgxeC18UKSHy_j8=.189438b5-8646-4c76-8d50-daded0aaa0a1@github.com> References: <7_xw0C_jQryZIUZxTuyZmEtqz_yWfgxeC18UKSHy_j8=.189438b5-8646-4c76-8d50-daded0aaa0a1@github.com> Message-ID: On Wed, 20 Mar 2024 21:23:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/389#issuecomment-2014614480 From goetz at openjdk.org Fri Mar 22 08:40:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Mar 2024 08:40:28 GMT Subject: [jdk21u-dev] RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 21:42:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/391#issuecomment-2014615185 From goetz at openjdk.org Fri Mar 22 08:41:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Mar 2024 08:41:23 GMT Subject: [jdk17u-dev] RFR: 8260540: serviceability/jdwp/AllModulesCommandTest.java failed with "Debuggee error: 'ERROR: transport error 202: bind failed: Address already in use'" In-Reply-To: References: Message-ID: On Thu, 21 Mar 2024 10:15:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > > I had to resolve Debuggee.java. Several later changes were already > backported, so I compared it with the last of these, where 21 and > 17 should be equal again: '8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use"' GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2319#issuecomment-2014615485 From mbaesken at openjdk.org Fri Mar 22 09:07:49 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 22 Mar 2024 09:07:49 GMT Subject: [jdk17u-dev] RFR: 8327059: os::Linux::print_proc_sys_info add swappiness information Message-ID: 8327059: os::Linux::print_proc_sys_info add swappiness information ------------- Commit messages: - Backport f3b15abcb7dcd00158df84818965fc1282dcc1d9 Changes: https://git.openjdk.org/jdk17u-dev/pull/2320/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2320&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327059 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2320.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2320/head:pull/2320 PR: https://git.openjdk.org/jdk17u-dev/pull/2320 From duke at openjdk.org Fri Mar 22 09:21:29 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 22 Mar 2024 09:21:29 GMT Subject: [jdk11u-dev] RFR: 8261302: NMT: Improve malloc site table hashing In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 16:09:59 GMT, Mar?a Arias de Reyna wrote: > This is the same fix that was applied in https://github.com/openjdk/jdk/commit/a3d6e371 for https://bugs.openjdk.org/browse/JDK-8261302 > > It simplifies the way of calculating the hash of a stack. Starting with 21 then! Comment edited. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2608#issuecomment-2014673751 From lucy at openjdk.org Fri Mar 22 12:48:23 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 22 Mar 2024 12:48:23 GMT Subject: [jdk11u-dev] RFR: 8313206: PKCS11 tests silently skip execution [v3] In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 02:25:52 GMT, Andrew Lu wrote: >> follow 17-dev backport. >> test/jdk/sun/security/pkcs11/PKCS11Test.java >> some added code lines are different, and add the format change in 'fetchNssLib'. >> other's clean. > > Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: > > update LGTM. I see one failing test, though. Did you check if it is unrelated? ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2605#pullrequestreview-1954700288 From lucy at openjdk.org Fri Mar 22 12:58:27 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 22 Mar 2024 12:58:27 GMT Subject: [jdk11u-dev] RFR: 8210988: Improved handling of compiler warnings in the build In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 06:46:29 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. > All clean except some added lines are different. LGTM ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2606#pullrequestreview-1954722783 From lucy at openjdk.org Fri Mar 22 12:59:24 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 22 Mar 2024 12:59:24 GMT Subject: [jdk11u-dev] RFR: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection [v2] In-Reply-To: References: Message-ID: On Thu, 21 Mar 2024 08:18:38 GMT, Andrew Lu wrote: >> I backport this for parity with 11.0.24-oracle. >> Clean except the method is not static here. > > Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into andrewLu_backport_8312383_new > - Backport bdd1aebea379b63ae405827074530ef8e8a7c239 LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2610#pullrequestreview-1954724563 From goetz at openjdk.org Fri Mar 22 13:03:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Mar 2024 13:03:32 GMT Subject: [jdk11u-dev] RFR: 8324632: Update Zlib Data Compression Library to Version 1.3.1 Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 6359b2843f83852561b925d3f1315eed5f4b9cda Changes: https://git.openjdk.org/jdk11u-dev/pull/2618/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2618&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324632 Stats: 2219 lines in 26 files changed: 609 ins; 1036 del; 574 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2618.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2618/head:pull/2618 PR: https://git.openjdk.org/jdk11u-dev/pull/2618 From lucy at openjdk.org Fri Mar 22 13:07:28 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 22 Mar 2024 13:07:28 GMT Subject: [jdk11u-dev] RFR: 8270199: Most SA tests are skipped on macosx-aarch64 because all executables are signed In-Reply-To: References: Message-ID: On Thu, 21 Mar 2024 05:30:52 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. > test/hotspot/jtreg/testlibrary_tests/TestMutuallyExclusivePlatformPredicates.java > Backport to the origin file. > Add backport to JDK-8241951, since it is modified after this backport. Looks good. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2616#pullrequestreview-1954743672 From lucy at openjdk.org Fri Mar 22 14:00:22 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 22 Mar 2024 14:00:22 GMT Subject: [jdk17u-dev] RFR: 8260540: serviceability/jdwp/AllModulesCommandTest.java failed with "Debuggee error: 'ERROR: transport error 202: bind failed: Address already in use'" In-Reply-To: References: Message-ID: On Thu, 21 Mar 2024 10:15:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > > I had to resolve Debuggee.java. Several later changes were already > backported, so I compared it with the last of these, where 21 and > 17 should be equal again: '8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use"' LGTM ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2319#pullrequestreview-1954874927 From szaldana at openjdk.org Fri Mar 22 14:15:38 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Fri, 22 Mar 2024 14:15:38 GMT Subject: [jdk21u-dev] RFR: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used Message-ID: Hi all, This pull request contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439). Testing: - [x] Modified test case passes. Thanks! ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/378 Commit messages: - Backport 43c6f0b5880899b797fab2f851bd35be1c342439 Changes: https://git.openjdk.org/jdk21u-dev/pull/393/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=393&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326591 Stats: 48 lines in 1 file changed: 30 ins; 5 del; 13 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/393.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/393/head:pull/393 PR: https://git.openjdk.org/jdk21u-dev/pull/393 From szaldana at openjdk.org Fri Mar 22 14:15:53 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Fri, 22 Mar 2024 14:15:53 GMT Subject: [jdk17u-dev] RFR: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used Message-ID: Hi all, This PR contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439). Patch is not clean. Test won't build in 17 because it can't find ```import jdk.internal.util.OperatingSystem```. This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485). I've worked around that by removing the dependency to that utility function and checking the operating system with System.getProperty("os.name"). Testing: - [x] Modified test case passes Thanks! ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/2305 Commit messages: - Backport 43c6f0b5880899b797fab2f851bd35be1c342439 Changes: https://git.openjdk.org/jdk17u-dev/pull/2321/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2321&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326591 Stats: 48 lines in 1 file changed: 30 ins; 5 del; 13 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2321.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2321/head:pull/2321 PR: https://git.openjdk.org/jdk17u-dev/pull/2321 From szaldana at openjdk.org Fri Mar 22 14:16:26 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Fri, 22 Mar 2024 14:16:26 GMT Subject: [jdk17u-dev] RFR: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 08:18:15 GMT, Goetz Lindenmaier wrote: >> GHA Failures: >> >> - Unrelated RISC-V failure. >> - Unrelated test failures: ```java/lang/String/StringRepeat.java``` in ```jdk/tier1 part1```. I'm seeing these failures intermittently across all PRs. > > Hi @SoniaZaldana, did you see the comment in the JBS issue? Hi @GoeLin, I saw it. I added follow up PRs for both 17u and 21u. Thanks :) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2305#issuecomment-2015197909 From shade at openjdk.org Fri Mar 22 14:29:55 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 22 Mar 2024 14:29:55 GMT Subject: [jdk22u] RFR: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition Message-ID: <62V8Y32-CClWVKb2g-NNrIUP-CNLxB9SH8Td5WAil68=.3b1fde23-0e11-4275-896c-92611716eb0f@github.com> Makes GHA cross-compilation jobs clean again. Additional testing: - [ ] GHA ------------- Commit messages: - Backport f207aa94f9296932276c2952252b263efc793b3f Changes: https://git.openjdk.org/jdk22u/pull/110/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=110&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326960 Stats: 15 lines in 1 file changed: 14 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/110.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/110/head:pull/110 PR: https://git.openjdk.org/jdk22u/pull/110 From shade at openjdk.org Fri Mar 22 14:31:41 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 22 Mar 2024 14:31:41 GMT Subject: [jdk21u-dev] RFR: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition Message-ID: Makes GHA cross-compilation jobs clean again. Additional testing: - [ ] GHA ------------- Commit messages: - Backport f207aa94f9296932276c2952252b263efc793b3f Changes: https://git.openjdk.org/jdk21u-dev/pull/394/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=394&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326960 Stats: 15 lines in 1 file changed: 14 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/394.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/394/head:pull/394 PR: https://git.openjdk.org/jdk21u-dev/pull/394 From shade at openjdk.org Fri Mar 22 14:32:58 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 22 Mar 2024 14:32:58 GMT Subject: [jdk17u-dev] RFR: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition Message-ID: Makes GHA cross-compilation jobs clean again. Additional testing: - [ ] GHA ------------- Commit messages: - Backport f207aa94f9296932276c2952252b263efc793b3f Changes: https://git.openjdk.org/jdk17u-dev/pull/2322/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2322&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326960 Stats: 15 lines in 1 file changed: 14 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2322.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2322/head:pull/2322 PR: https://git.openjdk.org/jdk17u-dev/pull/2322 From goetz at openjdk.org Fri Mar 22 15:42:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 22 Mar 2024 15:42:34 GMT Subject: [jdk21u-dev] RFR: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition In-Reply-To: References: Message-ID: <0UBoiENfy74q7D3yzKpGGcAM--iZ087Zp1WNOAO_4E0=.116e62cc-2824-4721-980e-5b2c2b7b2e91@github.com> On Fri, 22 Mar 2024 14:25:42 GMT, Aleksey Shipilev wrote: > Makes GHA cross-compilation jobs clean again. > > Additional testing: > - [ ] GHA Perfect, thanks!!! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/394#issuecomment-2015365814 From roland at openjdk.org Fri Mar 22 15:52:32 2024 From: roland at openjdk.org (Roland Westrelin) Date: Fri, 22 Mar 2024 15:52:32 GMT Subject: [jdk11u-dev] RFR: 8317507: C2 compilation fails with "Exceeded _node_regs array" In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 00:50:04 GMT, Martin Balao wrote: > Hi, > > I'd like to propose this backport to 11u-dev. The 17u fix applies cleanly. I ran and debugged the test to make sure that it is triggering the faulty behavior. > > Thanks, > Martin.- Looks good to me. ------------- Marked as reviewed by roland (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2617#pullrequestreview-1955164140 From jwilhelm at openjdk.org Fri Mar 22 16:11:00 2024 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Fri, 22 Mar 2024 16:11:00 GMT Subject: [jdk22u] RFR: 8328812: Update and move siphash license Message-ID: Clean backport of fix in license file. ------------- Commit messages: - Backport ce7ebaa606f96fdfee66d300b56022d9903b5ae3 Changes: https://git.openjdk.org/jdk22u/pull/111/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=111&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328812 Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/111.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/111/head:pull/111 PR: https://git.openjdk.org/jdk22u/pull/111 From btaylor at openjdk.org Fri Mar 22 16:50:31 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 22 Mar 2024 16:50:31 GMT Subject: [jdk11u-dev] RFR: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader In-Reply-To: <6-YRvqmmwW7Y2c8JR0oZlTmhFhhU8dp8P20hBs8UXDY=.54b1acb9-1881-41a4-ad8a-00110c0401a9@github.com> References: <6-YRvqmmwW7Y2c8JR0oZlTmhFhhU8dp8P20hBs8UXDY=.54b1acb9-1881-41a4-ad8a-00110c0401a9@github.com> Message-ID: On Wed, 10 Jan 2024 19:48:06 GMT, Ben Taylor wrote: > Clean backport of [JDK-8319436](https://bugs.openjdk.org/browse/JDK-8319436) to resolve a regression introduced in 11.0.20. > Included test passes locally on linux x64 after the update to jtreg-7.3.1 Seems the bot doesn't want to reopen this, so I've created #2619 instead ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2454#issuecomment-2015494206 From btaylor at openjdk.org Fri Mar 22 16:51:39 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 22 Mar 2024 16:51:39 GMT Subject: [jdk11u-dev] RFR: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader Message-ID: <-xaaNFRNKQlOGYX5TePvEkIB1vBs2EZl2A7no7HNOL0=.5c6fa45e-7d64-4e03-97b7-da3cfe5fbed1@github.com> Clean backport of [JDK-8319436](https://bugs.openjdk.org/browse/JDK-8319436) to resolve a regression introduced in 11.0.20. Included test passes locally on linux x64 after the update to jtreg-7.3.1. ------------- Commit messages: - Backport 8eb6f617b3f8e2a990e4244af4e56287f9741b20 Changes: https://git.openjdk.org/jdk11u-dev/pull/2619/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2619&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319436 Stats: 143 lines in 2 files changed: 20 ins; 77 del; 46 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2619.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2619/head:pull/2619 PR: https://git.openjdk.org/jdk11u-dev/pull/2619 From duke at openjdk.org Fri Mar 22 19:23:47 2024 From: duke at openjdk.org (Robert Toyonaga) Date: Fri, 22 Mar 2024 19:23:47 GMT Subject: [jdk17u-dev] RFR: 8326529: JFR: Test for CompilerCompile events fails due to time out Message-ID: This is a backport of https://github.com/openjdk/jdk/commit/4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 This backport limits compilation only to the test methods [TestCompileCompile](https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/compiler/TestCompilerCompile.java) cares about. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3046). ------------- Commit messages: - Backport 4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 Changes: https://git.openjdk.org/jdk17u-dev/pull/2323/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2323&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326529 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2323.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2323/head:pull/2323 PR: https://git.openjdk.org/jdk17u-dev/pull/2323 From duke at openjdk.org Fri Mar 22 20:17:48 2024 From: duke at openjdk.org (Robert Toyonaga) Date: Fri, 22 Mar 2024 20:17:48 GMT Subject: [jdk22u] RFR: 8326521: JFR: CompilerPhase event test fails on windows 32 bit Message-ID: <4vJOeZM9G_v4P90M7xX9ZRmM0SW3FfIMgQmrDdaJSNE=.ee58b6a3-9505-41f4-bd9c-1f3adef4a1b0@github.com> This is a backport of https://github.com/openjdk/jdk/commit/96530bcc07514c3eda40fd6ffa74f197fe541dea On some systems (such as windows 32 bit) Hotspot only uses the C1 compiler in by design. The CompilerPhase JFR events are only emitted from C2 code. So the test `TestCompilerPhase` fails on some systems because it cannot generate the necessary CompilerPhase JFR events . This backport prevents `NeverActAsServerClassMachine` from being set during the test `TestCompilerPhase`, so that it isn't restricted to C1. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3045). ------------- Commit messages: - Backport 96530bcc07514c3eda40fd6ffa74f197fe541dea Changes: https://git.openjdk.org/jdk22u/pull/112/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=112&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326521 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/112.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/112/head:pull/112 PR: https://git.openjdk.org/jdk22u/pull/112 From duke at openjdk.org Sat Mar 23 03:17:24 2024 From: duke at openjdk.org (Korov) Date: Sat, 23 Mar 2024 03:17:24 GMT Subject: [jdk11u-dev] RFR: 8214245: Case insensitive matching doesn't work correctly for some character classes [v8] In-Reply-To: References: Message-ID: On Wed, 25 Oct 2023 20:54:12 GMT, Christoph Langer wrote: >> @RealCLanger Thank you very much for your help, I have changed the title. > > @Korov Sorry for being inactive on this one for so long. Are you still willing to follow up on this backport? In that case I would create the CSR now. Please let me know. Hello @RealCLanger , I'm very interested in continuing to work on this backport, Please help me create a CSR and tell me the relevant links. Thank you very much for your help. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2062#issuecomment-2016324533 From duke at openjdk.org Sat Mar 23 08:31:28 2024 From: duke at openjdk.org (Davide Perini) Date: Sat, 23 Mar 2024 08:31:28 GMT Subject: [jdk22u] RFR: 8325203: System.exit(0) kills the launched 3rd party application In-Reply-To: <_1zFjmPSdYV_KkWEL7UFCiDsb3H5se2HzGIuqShbIWY=.aec203ef-381a-4e42-b3a4-f66ea57dbe23@github.com> References: <_1zFjmPSdYV_KkWEL7UFCiDsb3H5se2HzGIuqShbIWY=.aec203ef-381a-4e42-b3a4-f66ea57dbe23@github.com> Message-ID: On Fri, 9 Feb 2024 18:47:13 GMT, Alexey Semenyuk wrote: > 8325203: System.exit(0) kills the launched 3rd party application @alexeysemenyukoracle I'm sorry if I quote you, may I ask if this fix has been released with the current JDK 22 release? ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/49#issuecomment-2011853284 From goetz at openjdk.org Sat Mar 23 19:11:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 23 Mar 2024 19:11:32 GMT Subject: [jdk21u-dev] RFR: 8319574: Exec/process tests should be marked as flagless Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 68110b7a82ae82e2485aec23aba5406d2a5c0327 Changes: https://git.openjdk.org/jdk21u-dev/pull/395/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=395&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319574 Stats: 22 lines in 14 files changed: 13 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/395.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/395/head:pull/395 PR: https://git.openjdk.org/jdk21u-dev/pull/395 From goetz at openjdk.org Sat Mar 23 19:11:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 23 Mar 2024 19:11:52 GMT Subject: [jdk21u-dev] RFR: 8319567: Update java/lang/invoke tests to support vm flags Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 1588dd934ce4e00a060e329b80f721d894559597 Changes: https://git.openjdk.org/jdk21u-dev/pull/396/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=396&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319567 Stats: 523 lines in 17 files changed: 89 ins; 304 del; 130 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/396.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/396/head:pull/396 PR: https://git.openjdk.org/jdk21u-dev/pull/396 From goetz at openjdk.org Sat Mar 23 19:23:33 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 23 Mar 2024 19:23:33 GMT Subject: [jdk21u-dev] RFR: 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 62b7c5eaed1e6ffd6f2c8371eb4cf01dd9d53a06 Changes: https://git.openjdk.org/jdk21u-dev/pull/397/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=397&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319647 Stats: 14 lines in 7 files changed: 7 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/397.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/397/head:pull/397 PR: https://git.openjdk.org/jdk21u-dev/pull/397 From goetz at openjdk.org Sat Mar 23 19:24:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 23 Mar 2024 19:24:49 GMT Subject: [jdk21u-dev] RFR: 8322858: compiler/c2/aarch64/TestFarJump.java fails on AArch64 due to unexpected PrintAssembly output Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 52a6c37558fa970f595067bc1bb5bc2b710c3876 Changes: https://git.openjdk.org/jdk21u-dev/pull/398/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=398&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322858 Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/398.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/398/head:pull/398 PR: https://git.openjdk.org/jdk21u-dev/pull/398 From goetz at openjdk.org Sat Mar 23 19:29:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 23 Mar 2024 19:29:51 GMT Subject: [jdk21u-dev] RFR: 8319571: Update jni/nullCaller/NullCallerTest.java to accept flags or mark as flagless Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport b78896b9aafcb15f453eaed6e154a5461581407b Changes: https://git.openjdk.org/jdk21u-dev/pull/399/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=399&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319571 Stats: 27 lines in 1 file changed: 1 ins; 21 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/399.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/399/head:pull/399 PR: https://git.openjdk.org/jdk21u-dev/pull/399 From goetz at openjdk.org Sat Mar 23 20:00:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 23 Mar 2024 20:00:47 GMT Subject: [jdk21u-dev] RFR: 8319651: Several network tests ignore vm flags when start java process Message-ID: <_1V-ObG8B4U4hITxY4G0KTZfGDBrV0D5blADEGK-fwI=.dd69edbd-a4d7-4b52-8aae-5f9e65723057@github.com> I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 9538f5d317972bbb82f7f2575819d35d2a5f8b91 Changes: https://git.openjdk.org/jdk21u-dev/pull/400/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=400&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319651 Stats: 123 lines in 14 files changed: 27 ins; 35 del; 61 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/400.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/400/head:pull/400 PR: https://git.openjdk.org/jdk21u-dev/pull/400 From goetz at openjdk.org Sat Mar 23 20:08:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 23 Mar 2024 20:08:48 GMT Subject: [jdk21u-dev] RFR: 8326824: Test: remove redundant test in compiler/vectorapi/reshape/utils/TestCastMethods.java Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 552411f832eb35d739c7978b8c1f8d0dfd4b2161 Changes: https://git.openjdk.org/jdk21u-dev/pull/401/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=401&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326824 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/401.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/401/head:pull/401 PR: https://git.openjdk.org/jdk21u-dev/pull/401 From goetz at openjdk.org Sat Mar 23 20:10:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 23 Mar 2024 20:10:32 GMT Subject: [jdk21u-dev] RFR: 8319648: java/lang/SecurityManager tests ignore vm flags Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 437cf354e2d1f7df79fa32265ccf86a0e84257b5 Changes: https://git.openjdk.org/jdk21u-dev/pull/402/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=402&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319648 Stats: 9 lines in 2 files changed: 1 ins; 3 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/402.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/402/head:pull/402 PR: https://git.openjdk.org/jdk21u-dev/pull/402 From andrewlu at openjdk.org Mon Mar 25 02:15:41 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 25 Mar 2024 02:15:41 GMT Subject: [jdk11u-dev] RFR: 8210988: Improved handling of compiler warnings in the build [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.24-oracle. > All clean except some added lines are different. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into andrewLu_backport_8210988 - Backport 09a967ab8143c3d4b0824a0027edaf0e634686ec ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2606/files - new: https://git.openjdk.org/jdk11u-dev/pull/2606/files/150567d8..383b9e3d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2606&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2606&range=00-01 Stats: 1714 lines in 25 files changed: 1296 ins; 325 del; 93 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2606.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2606/head:pull/2606 PR: https://git.openjdk.org/jdk11u-dev/pull/2606 From andrewlu at openjdk.org Mon Mar 25 02:16:32 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 25 Mar 2024 02:16:32 GMT Subject: [jdk11u-dev] RFR: 8313206: PKCS11 tests silently skip execution [v4] In-Reply-To: References: Message-ID: <_-EP5ZIRsUoQCcftPqa9b1q2EsiVVKf35NMEqFAwfFo=.c4485264-1cc3-4b63-a749-f3a191b42ed4@github.com> > follow 17-dev backport. > test/jdk/sun/security/pkcs11/PKCS11Test.java > some added code lines are different, and add the format change in 'fetchNssLib'. > other's clean. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge branch 'openjdk:master' into andrewLu_backport_8313206 - update - Merge remote-tracking branch 'origin/andrewLu_backport_8313206' into andrewLu_backport_8313206 # Conflicts: # test/jdk/sun/security/pkcs11/PKCS11Test.java - Merge branch 'master' into andrewLu_backport_8313206 - Merge remote-tracking branch 'origin/master' into andrewLu_backport_8313206 # Conflicts: # test/jdk/sun/security/pkcs11/PKCS11Test.java - Backport 7c4aaec0dc74badb8363c10d2a10a29e85ceb246 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/2605/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2605&range=03 Stats: 341 lines in 9 files changed: 159 ins; 83 del; 99 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2605.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2605/head:pull/2605 PR: https://git.openjdk.org/jdk11u-dev/pull/2605 From goetz at openjdk.org Mon Mar 25 07:17:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 07:17:25 GMT Subject: [jdk17u-dev] RFR: 8326529: JFR: Test for CompilerCompile events fails due to time out In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 19:18:00 GMT, Robert Toyonaga wrote: > This is a backport of https://github.com/openjdk/jdk/commit/4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 > > This backport limits compilation only to the test methods [TestCompileCompile](https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/compiler/TestCompilerCompile.java) cares about. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3046). @roberttoyonaga, did you check the failing tests? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2323#issuecomment-2017364596 From goetz at openjdk.org Mon Mar 25 07:18:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 07:18:25 GMT Subject: [jdk17u-dev] RFR: 8327059: os::Linux::print_proc_sys_info add swappiness information In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 09:03:31 GMT, Matthias Baesken wrote: > 8327059: os::Linux::print_proc_sys_info add swappiness information GHA-failure: Risc-V issue. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2320#issuecomment-2017365702 From goetz at openjdk.org Mon Mar 25 07:25:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 07:25:23 GMT Subject: [jdk11u-dev] RFR: 8210988: Improved handling of compiler warnings in the build [v2] In-Reply-To: References: Message-ID: On Mon, 25 Mar 2024 02:15:41 GMT, Andrew Lu wrote: >> I backport this for parity with 11.0.24-oracle. >> All clean except some added lines are different. > > Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into andrewLu_backport_8210988 > - Backport 09a967ab8143c3d4b0824a0027edaf0e634686ec Hi @luchenlin, @RealLucy, are you sure the build errors are unrelated? d:\a\jdk11u-dev\jdk11u-dev\src\hotspot\cpu\aarch64\register_aarch64.hpp(285): error C2220: the following warning is treated as an error d:\a\jdk11u-dev\jdk11u-dev\src\hotspot\cpu\aarch64\register_aarch64.hpp(285): warning C4146: unary minus operator applied to unsigned type, result still unsigned make[3]: *** [lib/CompileGtest.gmk:64: /d/a/jdk11u-dev/jdk11u-dev/build/windows-aarch64/hotspot/variant-server/libjvm/gtest/objs/BUILD_GTEST_LIBJVM_pch.obj] Error 1 make[2]: *** [make/Main.gmk:272: hotspot-server-libs] Error 2 Best regards, Goetz. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2606#issuecomment-2017373499 From andrewlu at openjdk.org Mon Mar 25 07:28:24 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 25 Mar 2024 07:28:24 GMT Subject: [jdk11u-dev] Integrated: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 05:15:03 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. > Clean except the method is not static here. This pull request has now been integrated. Changeset: c782d4c9 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/c782d4c9cd2a600029ba8c80c963fffedcde101d Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection Reviewed-by: lucy Backport-of: bdd1aebea379b63ae405827074530ef8e8a7c239 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2610 From andrewlu at openjdk.org Mon Mar 25 07:37:23 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 25 Mar 2024 07:37:23 GMT Subject: [jdk11u-dev] RFR: 8210988: Improved handling of compiler warnings in the build [v2] In-Reply-To: References: Message-ID: On Mon, 25 Mar 2024 07:23:03 GMT, Goetz Lindenmaier wrote: > Hi @luchenlin, @RealLucy, are you sure the build errors are unrelated? > > d:\a\jdk11u-dev\jdk11u-dev\src\hotspot\cpu\aarch64\register_aarch64.hpp(285): error C2220: the following warning is treated as an error d:\a\jdk11u-dev\jdk11u-dev\src\hotspot\cpu\aarch64\register_aarch64.hpp(285): warning C4146: unary minus operator applied to unsigned type, result still unsigned make[3]: *** [lib/CompileGtest.gmk:64: /d/a/jdk11u-dev/jdk11u-dev/build/windows-aarch64/hotspot/variant-server/libjvm/gtest/objs/BUILD_GTEST_LIBJVM_pch.obj] Error 1 make[2]: *** [make/Main.gmk:272: hotspot-server-libs] Error 2 > > Best regards, Goetz. Hi @GoeLin, not sure about this, is this like the related backport? https://bugs.openjdk.org/browse/JDK-8211081 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2606#issuecomment-2017387068 From andrewlu at openjdk.org Mon Mar 25 07:42:29 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 25 Mar 2024 07:42:29 GMT Subject: [jdk11u-dev] Integrated: 8270199: Most SA tests are skipped on macosx-aarch64 because all executables are signed In-Reply-To: References: Message-ID: On Thu, 21 Mar 2024 05:30:52 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. > test/hotspot/jtreg/testlibrary_tests/TestMutuallyExclusivePlatformPredicates.java > Backport to the origin file. > Add backport to JDK-8241951, since it is modified after this backport. This pull request has now been integrated. Changeset: 8c18317e Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/8c18317ef89886ffd7b917c89ab02e047b940c20 Stats: 73 lines in 5 files changed: 35 ins; 19 del; 19 mod 8270199: Most SA tests are skipped on macosx-aarch64 because all executables are signed 8241951: SA core file tests failed to find core file for signed binaries on OSX 10.15 Reviewed-by: lucy Backport-of: 16e0ad0ad088af3ba1c9903ed8df60799a1ba651 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2616 From andrewlu at openjdk.org Mon Mar 25 07:44:26 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 25 Mar 2024 07:44:26 GMT Subject: [jdk11u-dev] Withdrawn: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work In-Reply-To: References: Message-ID: <3QFRgJK1k6xk4YqSH6GKBh-c2NSjT9MbcrTRXf2GIJ8=.77cbb5ac-eecb-44ee-85c1-e64ccacef1b8@github.com> On Thu, 29 Feb 2024 08:00:48 GMT, Andrew Lu wrote: > Backport 8310380 > add backports for JDK-8270199, JDK-8248194, JDK-8248667 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2577 From andrewlu at openjdk.org Mon Mar 25 08:05:34 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 25 Mar 2024 08:05:34 GMT Subject: [jdk11u-dev] RFR: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work Message-ID: I backport this for parity with 11.0.24-oracle. test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java Backport to the origin file. Other's clean. ------------- Commit messages: - Backport 39c104df44f17c1d65e35becd4272f73e2c6610c Changes: https://git.openjdk.org/jdk11u-dev/pull/2620/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2620&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310380 Stats: 56 lines in 4 files changed: 37 ins; 12 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2620.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2620/head:pull/2620 PR: https://git.openjdk.org/jdk11u-dev/pull/2620 From goetz.lindenmaier at sap.com Mon Mar 25 08:17:44 2024 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Mon, 25 Mar 2024 08:17:44 +0000 Subject: [jdk11u-dev] RFR: 8210988: Improved handling of compiler warnings in the build [v2] In-Reply-To: References: Message-ID: Hi, The problematic coding is src\hotspot\cpu\aarch64\register_aarch64.hpp(285): uint32_t first = _bitset & -_bitset; It has moved in 17, but is unchanged. So there does not exist a fix directly in the C++ coding. This leaves two cases * We use a different compiler for 11 and 17 windows aarch64 builds * The warning is suppressed somehow in 17 Ahh... This is warning C4146, which you remove here: make/hotspot/lib/CompileGtest.gmk - DISABLED_WARNINGS_microsoft := 4146, \ Maybe you need to add it again below. (Instead, you add 4996)? Ev. compare with the original change. But this is the Gtest makefile, so unlikely that it helps. This looks strange, too: make/hotspot/lib/CompileJvm.gmk DISABLED_WARNINGS_microsoft := $(DISABLED_WARNINGS_microsoft), \ DISABLED_WARNINGS_microsoft := 4146, \ Doesn't this overwrite the first setting? Should it be DISABLED_WARNINGS_microsoft := $(DISABLED_WARNINGS_microsoft) 4146, \ Also compare with the original change, or the code in 17. Unfortunately we don't have a build for this platform locally, so you need to try with the GHA testing. Best regards, Goetz. > -----Original Message----- > From: jdk-updates-dev On Behalf Of > Andrew Lu > Sent: Monday, March 25, 2024 8:37 AM > To: jdk-updates-dev at openjdk.org > Subject: Re: [jdk11u-dev] RFR: 8210988: Improved handling of compiler > warnings in the build [v2] > > On Mon, 25 Mar 2024 07:23:03 GMT, Goetz Lindenmaier > wrote: > > > Hi @luchenlin, @RealLucy, are you sure the build errors are unrelated? > > > > d:\a\jdk11u-dev\jdk11u- > dev\src\hotspot\cpu\aarch64\register_aarch64.hpp(285): error C2220: the > following warning is treated as an error d:\a\jdk11u-dev\jdk11u- > dev\src\hotspot\cpu\aarch64\register_aarch64.hpp(285): warning C4146: > unary minus operator applied to unsigned type, result still unsigned make[3]: > *** [lib/CompileGtest.gmk:64: /d/a/jdk11u-dev/jdk11u-dev/build/windows- > aarch64/hotspot/variant- > server/libjvm/gtest/objs/BUILD_GTEST_LIBJVM_pch.obj] Error 1 make[2]: *** > [make/Main.gmk:272: hotspot-server-libs] Error 2 > > > > Best regards, Goetz. > > Hi @GoeLin, not sure about this, is this like the related backport? > https://bugs.openjdk.org/browse/JDK-8211081 > > ------------- > > PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2606#issuecomment- > 2017387068 From mbaesken at openjdk.org Mon Mar 25 08:27:28 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 25 Mar 2024 08:27:28 GMT Subject: [jdk17u-dev] Integrated: 8327059: os::Linux::print_proc_sys_info add swappiness information In-Reply-To: References: Message-ID: <0Vx3n1nYDxaBJy30seNpeedT9VtgMRZ943KiD_5QyB8=.ec46bd1e-5f6b-45fc-a6e3-f2af729752a6@github.com> On Fri, 22 Mar 2024 09:03:31 GMT, Matthias Baesken wrote: > 8327059: os::Linux::print_proc_sys_info add swappiness information This pull request has now been integrated. Changeset: 56ed749e Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/56ed749efb8996a8c57bae4fc4264acb05d5c902 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8327059: os::Linux::print_proc_sys_info add swappiness information Backport-of: f3b15abcb7dcd00158df84818965fc1282dcc1d9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2320 From goetz at openjdk.org Mon Mar 25 08:43:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 08:43:23 GMT Subject: [jdk21u-dev] RFR: 8319648: java/lang/SecurityManager tests ignore vm flags In-Reply-To: References: Message-ID: On Sat, 23 Mar 2024 20:05:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/402#issuecomment-2017476510 From goetz at openjdk.org Mon Mar 25 08:43:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 08:43:23 GMT Subject: [jdk21u-dev] RFR: 8319574: Exec/process tests should be marked as flagless In-Reply-To: References: Message-ID: On Sat, 23 Mar 2024 19:06:06 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/395#issuecomment-2017477474 From goetz at openjdk.org Mon Mar 25 08:43:30 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 08:43:30 GMT Subject: [jdk21u-dev] RFR: 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags In-Reply-To: References: Message-ID: On Sat, 23 Mar 2024 19:19:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/397#issuecomment-2017477174 From goetz at openjdk.org Mon Mar 25 08:43:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 08:43:34 GMT Subject: [jdk21u-dev] RFR: 8322858: compiler/c2/aarch64/TestFarJump.java fails on AArch64 due to unexpected PrintAssembly output In-Reply-To: References: Message-ID: On Sat, 23 Mar 2024 19:19:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/398#issuecomment-2017477037 From goetz at openjdk.org Mon Mar 25 08:43:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 08:43:34 GMT Subject: [jdk21u-dev] RFR: 8319651: Several network tests ignore vm flags when start java process In-Reply-To: <_1V-ObG8B4U4hITxY4G0KTZfGDBrV0D5blADEGK-fwI=.dd69edbd-a4d7-4b52-8aae-5f9e65723057@github.com> References: <_1V-ObG8B4U4hITxY4G0KTZfGDBrV0D5blADEGK-fwI=.dd69edbd-a4d7-4b52-8aae-5f9e65723057@github.com> Message-ID: On Sat, 23 Mar 2024 19:56:08 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/400#issuecomment-2017476803 From goetz at openjdk.org Mon Mar 25 08:43:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 08:43:36 GMT Subject: [jdk21u-dev] RFR: 8319571: Update jni/nullCaller/NullCallerTest.java to accept flags or mark as flagless In-Reply-To: References: Message-ID: On Sat, 23 Mar 2024 19:24:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/399#issuecomment-2017476922 From goetz at openjdk.org Mon Mar 25 08:43:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 08:43:35 GMT Subject: [jdk21u-dev] RFR: 8326824: Test: remove redundant test in compiler/vectorapi/reshape/utils/TestCastMethods.java In-Reply-To: References: Message-ID: On Sat, 23 Mar 2024 20:03:40 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/401#issuecomment-2017476681 From goetz at openjdk.org Mon Mar 25 08:43:36 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 08:43:36 GMT Subject: [jdk21u-dev] RFR: 8319567: Update java/lang/invoke tests to support vm flags In-Reply-To: References: Message-ID: On Sat, 23 Mar 2024 19:07:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure Risc-V compile setup problem. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/396#issuecomment-2017477296 From andrewlu at openjdk.org Mon Mar 25 08:49:32 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 25 Mar 2024 08:49:32 GMT Subject: [jdk11u-dev] Integrated: 8313206: PKCS11 tests silently skip execution In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 05:43:16 GMT, Andrew Lu wrote: > follow 17-dev backport. > test/jdk/sun/security/pkcs11/PKCS11Test.java > some added code lines are different, and add the format change in 'fetchNssLib'. > other's clean. This pull request has now been integrated. Changeset: f8225a42 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/f8225a424f763aaead44c98c2f51a9d3a009032e Stats: 341 lines in 9 files changed: 159 ins; 83 del; 99 mod 8313206: PKCS11 tests silently skip execution Reviewed-by: lucy Backport-of: 7c4aaec0dc74badb8363c10d2a10a29e85ceb246 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2605 From shade at openjdk.org Mon Mar 25 08:55:28 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 08:55:28 GMT Subject: [jdk21u-dev] Integrated: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 14:25:42 GMT, Aleksey Shipilev wrote: > Makes GHA cross-compilation jobs clean again. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 8c6e32dc Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/8c6e32dc0ee4fbba183e4bccd728ef46d39bde9a Stats: 15 lines in 1 file changed: 14 ins; 0 del; 1 mod 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition Backport-of: f207aa94f9296932276c2952252b263efc793b3f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/394 From shade at openjdk.org Mon Mar 25 08:55:29 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 08:55:29 GMT Subject: [jdk17u-dev] Integrated: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition In-Reply-To: References: Message-ID: <3QzGASmUq7iOw7FlsWd4CLL2IA5FpGnrZ6W0uTeywh0=.f62a6bd1-851c-41ee-9257-422ce00b0018@github.com> On Fri, 22 Mar 2024 14:28:20 GMT, Aleksey Shipilev wrote: > Makes GHA cross-compilation jobs clean again. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: b4d22f6f Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/b4d22f6f3522963e123d58e59c6d9680ad2bf1c9 Stats: 15 lines in 1 file changed: 14 ins; 0 del; 1 mod 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition Backport-of: f207aa94f9296932276c2952252b263efc793b3f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2322 From andrewlu at openjdk.org Mon Mar 25 09:06:46 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 25 Mar 2024 09:06:46 GMT Subject: [jdk11u-dev] RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 [v5] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.24-oracle. > > Follow 21-dev backport. > test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java > Backport to the origin file. > > depends on https://github.com/openjdk/jdk11u-dev/pull/2605 Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge remote-tracking branch 'origin/master' into andrewLu_backport_8319128 # Conflicts: # test/hotspot/jtreg/testlibrary_tests/TestMutuallyExclusivePlatformPredicates.java # test/jdk/sun/security/pkcs11/PKCS11Test.java - update - fix - Merge remote-tracking branch 'origin/master' into andrewLu_backport_8319128 # Conflicts: # test/jdk/sun/security/pkcs11/PKCS11Test.java - Backport 1f9b03e597d87679964e8772c6bea538c74feb2c - Backport 2a8016096000de5836251f2ca9bc8ad6479e6942 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/2598/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2598&range=04 Stats: 46 lines in 5 files changed: 35 ins; 3 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2598.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2598/head:pull/2598 PR: https://git.openjdk.org/jdk11u-dev/pull/2598 From andrewlu at openjdk.org Mon Mar 25 09:12:49 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 25 Mar 2024 09:12:49 GMT Subject: [jdk11u-dev] RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 [v6] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.24-oracle. > > Follow 21-dev backport. > test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java > Backport to the origin file. > > depends on https://github.com/openjdk/jdk11u-dev/pull/2605 Andrew Lu has updated the pull request incrementally with two additional commits since the last revision: - update - update ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2598/files - new: https://git.openjdk.org/jdk11u-dev/pull/2598/files/4b215d46..a7d2ae75 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2598&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2598&range=04-05 Stats: 14 lines in 1 file changed: 0 ins; 0 del; 14 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2598.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2598/head:pull/2598 PR: https://git.openjdk.org/jdk11u-dev/pull/2598 From andrewlu at openjdk.org Mon Mar 25 09:30:36 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 25 Mar 2024 09:30:36 GMT Subject: [jdk11u-dev] RFR: 8210988: Improved handling of compiler warnings in the build [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.24-oracle. > All clean except some added lines are different. Andrew Lu has updated the pull request incrementally with two additional commits since the last revision: - Merge remote-tracking branch 'origin/andrewLu_backport_8210988' into andrewLu_backport_8210988 - update ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2606/files - new: https://git.openjdk.org/jdk11u-dev/pull/2606/files/383b9e3d..dbd50f1d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2606&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2606&range=01-02 Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2606.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2606/head:pull/2606 PR: https://git.openjdk.org/jdk11u-dev/pull/2606 From andrewlu at openjdk.org Mon Mar 25 10:00:49 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 25 Mar 2024 10:00:49 GMT Subject: [jdk11u-dev] RFR: 8210988: Improved handling of compiler warnings in the build [v4] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.24-oracle. > All clean except some added lines are different. Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: update ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2606/files - new: https://git.openjdk.org/jdk11u-dev/pull/2606/files/dbd50f1d..ef761806 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2606&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2606&range=02-03 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2606.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2606/head:pull/2606 PR: https://git.openjdk.org/jdk11u-dev/pull/2606 From andrewlu at openjdk.org Mon Mar 25 10:20:37 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 25 Mar 2024 10:20:37 GMT Subject: [jdk11u-dev] RFR: 8210988: Improved handling of compiler warnings in the build [v5] In-Reply-To: References: Message-ID: <00-tMbWb0zAp-YrYIkV0icmxg8bULQ6VRC8UZXzaNss=.d7a4f2e6-a7d0-48ce-8159-201d14b05cff@github.com> > I backport this for parity with 11.0.24-oracle. > All clean except some added lines are different. Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: update ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2606/files - new: https://git.openjdk.org/jdk11u-dev/pull/2606/files/ef761806..110d8fe3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2606&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2606&range=03-04 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2606.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2606/head:pull/2606 PR: https://git.openjdk.org/jdk11u-dev/pull/2606 From shade at openjdk.org Mon Mar 25 10:23:41 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 10:23:41 GMT Subject: [jdk21u-dev] RFR: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared [v2] In-Reply-To: References: Message-ID: > Unclean backport to match the codebases between mainline and JDK 21, simplifying maintenance. It also implicitly fixes [JDK-8323505](https://bugs.openjdk.org/browse/JDK-8323505), since this move includes a few touchups to the test. > > The uncleanliness comes from `MethodType.java` conflicts that does not have [JDK-8310849](https://bugs.openjdk.org/browse/JDK-8310849) in JDK 21. So it yields a few contextual conflicts. Since affected hunks are just removals, I removed them by hand. > > There is a follow-up, [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255), but it does not seem to affect anything yet, since there are no `ReferenceKeySet.add` calls anywhere in sight. We can backport that separately. > > Additional testing: > - [x] MacOS AArch64 Server fastdebug, `jdk/internal/util` tests pass > - [x] MacOS AArch64 Server fastdebug, `java/lang/invoke` tests pass > - [x] Linux AArch64 Server fastdebug, `all` tests pass Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8310913-referenced-key-map - Backport 6af0af593446bc33dc94bbf7334c325c4ac0ac0f Reviewed-by: naoto, rriggs, mchung, liach ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/342/files - new: https://git.openjdk.org/jdk21u-dev/pull/342/files/d95e43c9..62409055 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=342&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=342&range=00-01 Stats: 14840 lines in 254 files changed: 6765 ins; 4045 del; 4030 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/342.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/342/head:pull/342 PR: https://git.openjdk.org/jdk21u-dev/pull/342 From shade at openjdk.org Mon Mar 25 10:28:38 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 10:28:38 GMT Subject: [jdk21u-dev] RFR: 8318986: Improve GenericWaitBarrier performance [v4] In-Reply-To: References: Message-ID: <30j07elSTq23q1Cgqqfbm8xUxpTEVeBS2XBT9ZFVFpE=.f033746c-236a-42c5-8074-0060ebb3ab76@github.com> > Clean backport to drastically improve safepoint performance under heavy load, fixing regression between JDK 11 and JDK 17. > > Additional testing: > - [x] Ad-hoc performance runs, expected improvements > - [x] MacOS AArch64 server fastdebug, `all` tests Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into JDK-8318986-generic-wait-barrier - Merge branch 'master' into JDK-8318986-generic-wait-barrier - Backport 30462f9da40d3a7ec18fcf46e2154fabb5fd4753 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/70/files - new: https://git.openjdk.org/jdk21u-dev/pull/70/files/2aada3b9..17d9b6e6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=70&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=70&range=02-03 Stats: 15035 lines in 265 files changed: 6918 ins; 4061 del; 4056 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/70.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/70/head:pull/70 PR: https://git.openjdk.org/jdk21u-dev/pull/70 From szaldana at openjdk.org Mon Mar 25 10:29:26 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 25 Mar 2024 10:29:26 GMT Subject: [jdk21u-dev] Integrated: 8324998: Add test cases for String.regionMatches comparing Turkic dotted/dotless I with uppercase latin I In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 19:12:57 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [c3c1d5bd](https://github.com/openjdk/jdk/commit/c3c1d5bd12f80c6a720e431961e90b09c2d972f9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Eirik Bj?rsn?s on 30 Jan 2024 and was reviewed by Naoto Sato and Iris Clark. > > Testing: > - [x] Modified test passes > > Thanks! This pull request has now been integrated. Changeset: 39f71787 Author: Sonia Zaldana Calles Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/39f717876ac18bc3c0aeb87b2b3de9b02ed808ed Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8324998: Add test cases for String.regionMatches comparing Turkic dotted/dotless I with uppercase latin I Backport-of: c3c1d5bd12f80c6a720e431961e90b09c2d972f9 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/379 From szaldana at openjdk.org Mon Mar 25 10:31:28 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 25 Mar 2024 10:31:28 GMT Subject: [jdk21u-dev] Integrated: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols In-Reply-To: References: Message-ID: <2u4TChcEQRDcv6l4-gFksPe2UPFs_yPIiUh7Neeo8Ho=.7c5e5a9b-b2b2-4027-aa05-a34c6016d3b7@github.com> On Mon, 18 Mar 2024 16:46:58 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of commit [6c0bebcc](https://github.com/openjdk/jdk/commit/6c0bebccb0092d9726eb89a054e023e92edf7ca6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > Testing: > - [x] Added test case passes. > > Thanks! This pull request has now been integrated. Changeset: 3050bf3b Author: Sonia Zaldana Calles Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/3050bf3bd034b6b68a9c8fe09060c4e0a5472785 Stats: 76 lines in 1 file changed: 76 ins; 0 del; 0 mod 8159927: Add a test to verify JMOD files created in the images do not have debug symbols Backport-of: 6c0bebccb0092d9726eb89a054e023e92edf7ca6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/378 From szaldana at openjdk.org Mon Mar 25 10:31:29 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 25 Mar 2024 10:31:29 GMT Subject: [jdk21u-dev] Integrated: 8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent of the zip command line In-Reply-To: References: Message-ID: <0o7M52EQXv47-5Axe8UrChRT-mJl0GRrfgHA7ujJ0Fo=.5f7bcf58-81fc-42bf-be07-8dbccdd87de2@github.com> On Mon, 18 Mar 2024 16:42:55 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This PR contains a backport of [7004c2724d9b150112c66febb7f24b781ff379dd](https://github.com/openjdk/jdk/commit/7004c2724d9b150112c66febb7f24b781ff379dd). > > Testing: > > - [x] Modified test case passes. > > Thanks! This pull request has now been integrated. Changeset: 5694ad27 Author: Sonia Zaldana Calles Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/5694ad27abe33d1283d2e0e43e064cdb5635de5e Stats: 209 lines in 2 files changed: 90 ins; 44 del; 75 mod 8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent of the zip command line 8301183: (zipfs) jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java failing with ZipException:R0 on OL9 Backport-of: 7004c2724d9b150112c66febb7f24b781ff379dd ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/377 From szaldana at openjdk.org Mon Mar 25 10:33:39 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 25 Mar 2024 10:33:39 GMT Subject: [jdk21u-dev] RFR: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439). > > Testing: > - [x] Modified test case passes. > > Thanks! Sonia Zaldana Calles has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/393/files - new: https://git.openjdk.org/jdk21u-dev/pull/393/files/d8d1a588..d8d1a588 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=393&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=393&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/393.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/393/head:pull/393 PR: https://git.openjdk.org/jdk21u-dev/pull/393 From shade at openjdk.org Mon Mar 25 11:54:39 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 11:54:39 GMT Subject: [jdk22u] RFR: 8328705: GHA: Cross-compilation jobs do not require build JDK Message-ID: <2YseZn6pE_E8qo5UAzKP3FkJZF6ZWTrgDIG9wmEUAW8=.b8fac737-a184-484a-bbad-855758ace8ee@github.com> Clean backport to improve GHA parallelism. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 29ba4b7d1e62a834c1693fe6ad383c19467afc81 Changes: https://git.openjdk.org/jdk22u/pull/113/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=113&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328705 Stats: 11 lines in 2 files changed: 0 ins; 10 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/113.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/113/head:pull/113 PR: https://git.openjdk.org/jdk22u/pull/113 From shade at openjdk.org Mon Mar 25 11:58:28 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 11:58:28 GMT Subject: [jdk21u-dev] RFR: 8328705: GHA: Cross-compilation jobs do not require build JDK Message-ID: Clean backport to improve GHA parallelism. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 29ba4b7d1e62a834c1693fe6ad383c19467afc81 Changes: https://git.openjdk.org/jdk21u-dev/pull/403/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=403&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328705 Stats: 11 lines in 2 files changed: 0 ins; 10 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/403.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/403/head:pull/403 PR: https://git.openjdk.org/jdk21u-dev/pull/403 From pminborg at openjdk.org Mon Mar 25 11:59:43 2024 From: pminborg at openjdk.org (Per Minborg) Date: Mon, 25 Mar 2024 11:59:43 GMT Subject: [jdk21u-dev] RFR: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment Message-ID: <8A1BNN5ZXTXFpI4cZh-25KKo_rEx7FJLl34OUQS7HTk=.938f856d-3520-4761-8491-76eb9e7f2025@github.com> Hi all, This pull request contains a backport of commit [93579c29](https://github.com/openjdk/jdk/commit/93579c29e3ba60a8bc16d712e7ffc733f324a223) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Per Minborg on 25 Mar 2024 and was reviewed by Maurizio Cimadamore. Thanks! ------------- Commit messages: - Backport 93579c29e3ba60a8bc16d712e7ffc733f324a223 Changes: https://git.openjdk.org/jdk21u-dev/pull/404/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=404&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323552 Stats: 35 lines in 2 files changed: 27 ins; 4 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/404.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/404/head:pull/404 PR: https://git.openjdk.org/jdk21u-dev/pull/404 From shade at openjdk.org Mon Mar 25 12:30:39 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 12:30:39 GMT Subject: [jdk17u-dev] RFR: 8328705: GHA: Cross-compilation jobs do not require build JDK Message-ID: Semi-clean backport to improve GHA parallelism. There is a contextual difference due jmod-compression-level support being missing in JDK 17, resolved by hand. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 29ba4b7d1e62a834c1693fe6ad383c19467afc81 Changes: https://git.openjdk.org/jdk17u-dev/pull/2324/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2324&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328705 Stats: 11 lines in 2 files changed: 0 ins; 10 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2324.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2324/head:pull/2324 PR: https://git.openjdk.org/jdk17u-dev/pull/2324 From shade at openjdk.org Mon Mar 25 12:31:21 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 12:31:21 GMT Subject: [jdk21u-dev] RFR: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment In-Reply-To: <8A1BNN5ZXTXFpI4cZh-25KKo_rEx7FJLl34OUQS7HTk=.938f856d-3520-4761-8491-76eb9e7f2025@github.com> References: <8A1BNN5ZXTXFpI4cZh-25KKo_rEx7FJLl34OUQS7HTk=.938f856d-3520-4761-8491-76eb9e7f2025@github.com> Message-ID: <-_e8s83zfS6DdvD11EWjPa7kLew_gQWyk1VAe1-sIlg=.38714ce2-de9e-4529-84ec-a2ec80c67107@github.com> On Mon, 25 Mar 2024 11:54:39 GMT, Per Minborg wrote: > Hi all, > > This pull request contains a backport of commit [93579c29](https://github.com/openjdk/jdk/commit/93579c29e3ba60a8bc16d712e7ffc733f324a223) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Per Minborg on 25 Mar 2024 and was reviewed by Maurizio Cimadamore. > > Thanks! Hey @minborg! Please enable GHA for your jdk21u-dev fork and trigger it :) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/404#issuecomment-2017893843 From shade at openjdk.org Mon Mar 25 12:37:53 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 12:37:53 GMT Subject: [jdk11u-dev] RFR: 8328705: GHA: Cross-compilation jobs do not require build JDK Message-ID: Semi-clean backport to improve GHA parallelism. There is a contextual difference due jmod-compression-level support being missing in JDK 11, resolved by hand. There is also a contextual difference in gtest support: JDK 11 does not have a hunk that downloads the gtest. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 29ba4b7d1e62a834c1693fe6ad383c19467afc81 Changes: https://git.openjdk.org/jdk11u-dev/pull/2621/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2621&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328705 Stats: 11 lines in 2 files changed: 0 ins; 10 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2621.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2621/head:pull/2621 PR: https://git.openjdk.org/jdk11u-dev/pull/2621 From szaldana at openjdk.org Mon Mar 25 13:19:48 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 25 Mar 2024 13:19:48 GMT Subject: [jdk21u-dev] RFR: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used [v3] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439). > > Testing: > - [x] Modified test case passes. > > Thanks! Sonia Zaldana Calles has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge master - Backport 43c6f0b5880899b797fab2f851bd35be1c342439 - Reverting JDK-8326591 commit - Backport 43c6f0b5880899b797fab2f851bd35be1c342439 - Backport 6c0bebccb0092d9726eb89a054e023e92edf7ca6 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/393/files - new: https://git.openjdk.org/jdk21u-dev/pull/393/files/d8d1a588..2a6020e4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=393&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=393&range=01-02 Stats: 6209 lines in 120 files changed: 2264 ins; 1227 del; 2718 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/393.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/393/head:pull/393 PR: https://git.openjdk.org/jdk21u-dev/pull/393 From szaldana at openjdk.org Mon Mar 25 13:34:25 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Mon, 25 Mar 2024 13:34:25 GMT Subject: [jdk21u-dev] Integrated: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 13:52:35 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This pull request contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439). > > Testing: > - [x] Modified test case passes. > > Thanks! This pull request has now been integrated. Changeset: 7d4a6fc0 Author: Sonia Zaldana Calles Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk21u-dev/commit/7d4a6fc01b45272fda1888c6ba0b974fe7995462 Stats: 48 lines in 1 file changed: 30 ins; 5 del; 13 mod 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used Backport-of: 43c6f0b5880899b797fab2f851bd35be1c342439 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/393 From kcr at openjdk.org Mon Mar 25 13:59:29 2024 From: kcr at openjdk.org (Kevin Rushforth) Date: Mon, 25 Mar 2024 13:59:29 GMT Subject: [jdk22u] RFR: 8325203: System.exit(0) kills the launched 3rd party application In-Reply-To: References: <_1zFjmPSdYV_KkWEL7UFCiDsb3H5se2HzGIuqShbIWY=.aec203ef-381a-4e42-b3a4-f66ea57dbe23@github.com> Message-ID: On Thu, 21 Mar 2024 10:24:27 GMT, Davide Perini wrote: > @alexeysemenyukoracle I'm sorry if I quote you, may I ask if this fix has been released with the current JDK 22 release? I'm not Alexey, but I can answer this. As can be seen in the [JBS issue](https://bugs.openjdk.org/browse/JDK-8325203), this fix was backported to JDK 22.0.1. The release date for 22.0.1 is April 16, 2024. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/49#issuecomment-2018064618 From duke at openjdk.org Mon Mar 25 14:08:29 2024 From: duke at openjdk.org (Robert Toyonaga) Date: Mon, 25 Mar 2024 14:08:29 GMT Subject: [jdk17u-dev] RFR: 8326529: JFR: Test for CompilerCompile events fails due to time out In-Reply-To: References: Message-ID: On Mon, 25 Mar 2024 07:15:14 GMT, Goetz Lindenmaier wrote: > did you check the failing tests? Hi @GoeLin, yes I had a look at them, but both don't seem to be related to these new changes. - `linux-cross-compile ` fails "while configuring base packages" for riscv. - `linux-x86 / test - Test (tier1)` fails on the test: `java/lang/String/StringRepeat.java` with an error message: ` Error occurred during initialization of VM Could not reserve enough space for 2097152KB object heap`. This seems like it's related to the environment not the PR itself. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2323#issuecomment-2018084481 From goetz at openjdk.org Mon Mar 25 14:30:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 14:30:28 GMT Subject: [jdk21u-dev] RFR: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm" Message-ID: <4QpZ-uWKC8N0puveOx-JCg3sRn_86eONpf6Q8BoUXLY=.62e7548c-dde4-4784-b006-d1fa943abec6@github.com> I backport this as we see the issue in our CI. ------------- Commit messages: - Backport 66520be7a752ebade6c88d164bc87c4bfcfce40a Changes: https://git.openjdk.org/jdk21u-dev/pull/406/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=406&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280056 Stats: 19 lines in 1 file changed: 9 ins; 4 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/406.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/406/head:pull/406 PR: https://git.openjdk.org/jdk21u-dev/pull/406 From goetz at openjdk.org Mon Mar 25 14:31:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 14:31:35 GMT Subject: [jdk17u-dev] RFR: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm" Message-ID: I backport this because we see it failing in our CI. ------------- Commit messages: - Backport 66520be7a752ebade6c88d164bc87c4bfcfce40a Changes: https://git.openjdk.org/jdk17u-dev/pull/2325/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2325&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280056 Stats: 19 lines in 1 file changed: 9 ins; 4 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2325.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2325/head:pull/2325 PR: https://git.openjdk.org/jdk17u-dev/pull/2325 From goetz at openjdk.org Mon Mar 25 14:34:26 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 14:34:26 GMT Subject: [jdk21u-dev] Integrated: 8316164: Opensource JMenuBar manual test In-Reply-To: References: Message-ID: <7rrhP4xh-z42I3wOx6p7TpzqUHFQBkOe2cx_S4gP95s=.272daed9-2df0-4ceb-aecd-c8c095cd55dc@github.com> On Wed, 20 Mar 2024 21:17:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 6b85c74f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/6b85c74f3bfc43e5ab2a3b90d7e8f1bfe927ba6c Stats: 128 lines in 1 file changed: 128 ins; 0 del; 0 mod 8316164: Opensource JMenuBar manual test Backport-of: 8f4dfc443ba5820f5799fff1418d6632d502d57b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/388 From goetz at openjdk.org Mon Mar 25 14:35:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 14:35:37 GMT Subject: [jdk21u-dev] Integrated: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 21:14:45 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: f96f632e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/f96f632e6a1aa23cd95767994d23d2f84be367c3 Stats: 486 lines in 5 files changed: 486 ins; 0 del; 0 mod 8315741: Open source few swing JFormattedTextField and JPopupMenu tests Backport-of: bfbc41c1f177c7a2b8e91351ac41eaffaab2d8fc ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/387 From duke at openjdk.org Mon Mar 25 14:37:24 2024 From: duke at openjdk.org (Davide Perini) Date: Mon, 25 Mar 2024 14:37:24 GMT Subject: [jdk22u] RFR: 8325203: System.exit(0) kills the launched 3rd party application In-Reply-To: <_1zFjmPSdYV_KkWEL7UFCiDsb3H5se2HzGIuqShbIWY=.aec203ef-381a-4e42-b3a4-f66ea57dbe23@github.com> References: <_1zFjmPSdYV_KkWEL7UFCiDsb3H5se2HzGIuqShbIWY=.aec203ef-381a-4e42-b3a4-f66ea57dbe23@github.com> Message-ID: On Fri, 9 Feb 2024 18:47:13 GMT, Alexey Semenyuk wrote: > 8325203: System.exit(0) kills the launched 3rd party application thanks Kevin, I really appreciate your work in the Java community. ? ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/49#issuecomment-2018147373 From goetz at openjdk.org Mon Mar 25 14:37:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 14:37:28 GMT Subject: [jdk21u-dev] Integrated: 8319574: Exec/process tests should be marked as flagless In-Reply-To: References: Message-ID: <__xputWoOLiwtmJr5H-E8CD2FcTANQSxtWMyZut0gs8=.28c3fbd7-4459-4057-bc69-9508fc59cb7b@github.com> On Sat, 23 Mar 2024 19:06:06 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: bb8b6463 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/bb8b64635c0dd932cf14f5c04052501b04262040 Stats: 22 lines in 14 files changed: 13 ins; 0 del; 9 mod 8319574: Exec/process tests should be marked as flagless Backport-of: 68110b7a82ae82e2485aec23aba5406d2a5c0327 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/395 From sroy at openjdk.org Mon Mar 25 15:24:55 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 25 Mar 2024 15:24:55 GMT Subject: [jdk17u-dev] RFR: 8320005: Allow loading of shared objects with .a extension on AIX Message-ID: <9DH5Cq2zcCu9YAMOlLEDVNbivc--6gm6hp8tMbhItW0=.6d29bcd2-a287-46ca-ada7-364feeb1ba8e@github.com> Hi all, This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. Thanks! ------------- Commit messages: - Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab Changes: https://git.openjdk.org/jdk17u-dev/pull/2326/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2326&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320005 Stats: 28 lines in 1 file changed: 25 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2326.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2326/head:pull/2326 PR: https://git.openjdk.org/jdk17u-dev/pull/2326 From mbaesken at openjdk.org Mon Mar 25 15:26:37 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 25 Mar 2024 15:26:37 GMT Subject: [jdk17u-dev] RFR: 8328165: improve assert(idx < _maxlrg) failed: oob Message-ID: 8328165: improve assert(idx < _maxlrg) failed: oob ------------- Commit messages: - Backport d57bdd85ab5e45a2ecfce0c022da067ac30bb80d Changes: https://git.openjdk.org/jdk17u-dev/pull/2327/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2327&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328165 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2327.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2327/head:pull/2327 PR: https://git.openjdk.org/jdk17u-dev/pull/2327 From shade at openjdk.org Mon Mar 25 15:27:23 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 15:27:23 GMT Subject: [jdk22u] Integrated: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition In-Reply-To: <62V8Y32-CClWVKb2g-NNrIUP-CNLxB9SH8Td5WAil68=.3b1fde23-0e11-4275-896c-92611716eb0f@github.com> References: <62V8Y32-CClWVKb2g-NNrIUP-CNLxB9SH8Td5WAil68=.3b1fde23-0e11-4275-896c-92611716eb0f@github.com> Message-ID: On Fri, 22 Mar 2024 14:24:44 GMT, Aleksey Shipilev wrote: > Makes GHA cross-compilation jobs clean again. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 14bd76f7 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/14bd76f71d99fd78a85e82107df69711059ec104 Stats: 15 lines in 1 file changed: 14 ins; 0 del; 1 mod 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition Backport-of: f207aa94f9296932276c2952252b263efc793b3f ------------- PR: https://git.openjdk.org/jdk22u/pull/110 From sroy at openjdk.org Mon Mar 25 15:29:42 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 25 Mar 2024 15:29:42 GMT Subject: [jdk17u-dev] RFR: 8320005: Allow loading of shared objects with .a extension on AIX [v2] In-Reply-To: <9DH5Cq2zcCu9YAMOlLEDVNbivc--6gm6hp8tMbhItW0=.6d29bcd2-a287-46ca-ada7-364feeb1ba8e@github.com> References: <9DH5Cq2zcCu9YAMOlLEDVNbivc--6gm6hp8tMbhItW0=.6d29bcd2-a287-46ca-ada7-364feeb1ba8e@github.com> Message-ID: > Hi all, > > This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. > > Thanks! Suchismith Roy has updated the pull request incrementally with two additional commits since the last revision: - restore lines - restore lines ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2326/files - new: https://git.openjdk.org/jdk17u-dev/pull/2326/files/d3d5cfe5..021a6c7b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2326&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2326&range=00-01 Stats: 7 lines in 1 file changed: 0 ins; 5 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2326.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2326/head:pull/2326 PR: https://git.openjdk.org/jdk17u-dev/pull/2326 From sroy at openjdk.org Mon Mar 25 15:33:46 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 25 Mar 2024 15:33:46 GMT Subject: [jdk17u-dev] RFR: 8320005: Allow loading of shared objects with .a extension on AIX [v3] In-Reply-To: <9DH5Cq2zcCu9YAMOlLEDVNbivc--6gm6hp8tMbhItW0=.6d29bcd2-a287-46ca-ada7-364feeb1ba8e@github.com> References: <9DH5Cq2zcCu9YAMOlLEDVNbivc--6gm6hp8tMbhItW0=.6d29bcd2-a287-46ca-ada7-364feeb1ba8e@github.com> Message-ID: > Hi all, > > This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. > > Thanks! Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: restore lines ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2326/files - new: https://git.openjdk.org/jdk17u-dev/pull/2326/files/021a6c7b..78aa4f02 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2326&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2326&range=01-02 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2326.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2326/head:pull/2326 PR: https://git.openjdk.org/jdk17u-dev/pull/2326 From sroy at openjdk.org Mon Mar 25 15:39:35 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 25 Mar 2024 15:39:35 GMT Subject: [jdk17u-dev] RFR: 8320005: Allow loading of shared objects with .a extension on AIX [v4] In-Reply-To: <9DH5Cq2zcCu9YAMOlLEDVNbivc--6gm6hp8tMbhItW0=.6d29bcd2-a287-46ca-ada7-364feeb1ba8e@github.com> References: <9DH5Cq2zcCu9YAMOlLEDVNbivc--6gm6hp8tMbhItW0=.6d29bcd2-a287-46ca-ada7-364feeb1ba8e@github.com> Message-ID: <9WY-RrxYlLfMV_vK52tjN2FIDulicJrhVuOOADDa5B8=.53e79a22-24f7-4297-acc6-bad60a39ae4f@github.com> > Hi all, > > This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. > > Thanks! Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: restore lines ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2326/files - new: https://git.openjdk.org/jdk17u-dev/pull/2326/files/78aa4f02..71aafe9f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2326&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2326&range=02-03 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2326.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2326/head:pull/2326 PR: https://git.openjdk.org/jdk17u-dev/pull/2326 From dlutker at openjdk.org Mon Mar 25 15:53:38 2024 From: dlutker at openjdk.org (Dan Lutker) Date: Mon, 25 Mar 2024 15:53:38 GMT Subject: [jdk21u-dev] RFR: 8294699: Launcher causes lingering busy cursor [v3] In-Reply-To: References: Message-ID: <-xuiI9CDGFI683_OPsFxcl4wB9HcO3_rkGUy2M5Vs8M=.80d8bad9-7aa7-45f3-a3d7-35ec27288fbe@github.com> > Backport for parity with Oracle 21.0.4 Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into backport-lutkerd-d3df3eb5 - Merge branch 'openjdk:master' into backport-lutkerd-d3df3eb5 - Backport d3df3eb5d7f5537ade917db7a36caba028f94111 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/327/files - new: https://git.openjdk.org/jdk21u-dev/pull/327/files/880271e9..44a08853 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=327&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=327&range=01-02 Stats: 15888 lines in 283 files changed: 7673 ins; 4089 del; 4126 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/327.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/327/head:pull/327 PR: https://git.openjdk.org/jdk21u-dev/pull/327 From clanger at openjdk.org Mon Mar 25 15:55:25 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 25 Mar 2024 15:55:25 GMT Subject: [jdk22u] Integrated: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 07:05:53 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8185862](https://bugs.openjdk.org/browse/JDK-8185862), commit [1ad3ebcf](https://github.com/openjdk/jdk/commit/1ad3ebcf11834ec1d119ee95c858d98fb7bc6e68) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Christoph Langer on 13 Mar 2024 and was reviewed by Alexey Ivanov and Phil Race. > > Thanks! This pull request has now been integrated. Changeset: dcca5daa Author: Christoph Langer URL: https://git.openjdk.org/jdk22u/commit/dcca5daaf7f51c6579369c6ba3430a3d7962dbf2 Stats: 149 lines in 9 files changed: 89 ins; 25 del; 35 mod 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 Backport-of: 1ad3ebcf11834ec1d119ee95c858d98fb7bc6e68 ------------- PR: https://git.openjdk.org/jdk22u/pull/105 From sroy at openjdk.org Mon Mar 25 16:14:57 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 25 Mar 2024 16:14:57 GMT Subject: [jdk17u-dev] RFR: 8320005: Allow loading of shared objects with .a extension on AIX [v5] In-Reply-To: <9DH5Cq2zcCu9YAMOlLEDVNbivc--6gm6hp8tMbhItW0=.6d29bcd2-a287-46ca-ada7-364feeb1ba8e@github.com> References: <9DH5Cq2zcCu9YAMOlLEDVNbivc--6gm6hp8tMbhItW0=.6d29bcd2-a287-46ca-ada7-364feeb1ba8e@github.com> Message-ID: > Hi all, > > This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. > > Thanks! Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: rename function ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2326/files - new: https://git.openjdk.org/jdk17u-dev/pull/2326/files/71aafe9f..6c527354 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2326&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2326&range=03-04 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2326.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2326/head:pull/2326 PR: https://git.openjdk.org/jdk17u-dev/pull/2326 From clanger at openjdk.org Mon Mar 25 16:17:33 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 25 Mar 2024 16:17:33 GMT Subject: [jdk21u-dev] RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 Message-ID: Hi all, This pull request contains a backport of [JDK-8185862](https://bugs.openjdk.org/browse/JDK-8185862) from commit [dcca5daa](https://github.com/openjdk/jdk22u/commit/dcca5daaf7f51c6579369c6ba3430a3d7962dbf2) from the [openjdk/jdk22u](https://git.openjdk.org/jdk22u) repository. I had to resolve a copyright in src\java.desktop\windows\native\libawt\windows\awt_Win32GraphicsDevice.cpp, will mark as clean. Thanks Christoph ------------- Commit messages: - Backport dcca5daaf7f51c6579369c6ba3430a3d7962dbf2 Changes: https://git.openjdk.org/jdk21u-dev/pull/407/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=407&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8185862 Stats: 149 lines in 9 files changed: 89 ins; 25 del; 35 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/407.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/407/head:pull/407 PR: https://git.openjdk.org/jdk21u-dev/pull/407 From clanger at openjdk.org Mon Mar 25 16:21:39 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 25 Mar 2024 16:21:39 GMT Subject: [jdk17u-dev] RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 Message-ID: Hi all, This pull request contains a backport of [JDK-8185862](https://bugs.openjdk.org/browse/JDK-8185862) from commit [dcca5daa](https://github.com/openjdk/jdk22u/commit/dcca5daaf7f51c6579369c6ba3430a3d7962dbf2) from the [openjdk/jdk22u](https://git.openjdk.org/jdk22u) repository. I had to resolve copyrights in awt_Win32GraphicsDevice.cpp and awt_Win32GraphicsEnv.cpp plus a comment diff in Devices.h due to missing [JDK-8301443](https://bugs.openjdk.org/browse/JDK-8301443), will mark as clean. Thanks Christoph ------------- Commit messages: - Backport dcca5daaf7f51c6579369c6ba3430a3d7962dbf2 Changes: https://git.openjdk.org/jdk17u-dev/pull/2328/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2328&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8185862 Stats: 150 lines in 9 files changed: 89 ins; 25 del; 36 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2328.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2328/head:pull/2328 PR: https://git.openjdk.org/jdk17u-dev/pull/2328 From clanger at openjdk.org Mon Mar 25 16:56:40 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 25 Mar 2024 16:56:40 GMT Subject: [jdk11u-dev] RFR: 8214245: Case insensitive matching doesn't work correctly for some character classes [v8] In-Reply-To: References: Message-ID: On Wed, 25 Oct 2023 20:54:12 GMT, Christoph Langer wrote: >> @RealCLanger Thank you very much for your help, I have changed the title. > > @Korov Sorry for being inactive on this one for so long. Are you still willing to follow up on this backport? In that case I would create the CSR now. Please let me know. > Hello @RealCLanger , I'm very interested in continuing to work on this backport, Please help me create a CSR and tell me the relevant links. Thank you very much for your help. OK, I now created a CSR for 11-pool: [JDK-8328951](https://bugs.openjdk.org/browse/JDK-8328951). The CSR will need a review from some OpenJDK reviewer, e.g. @phohensee or @GoeLin, would you mind taking a look? After CSR review, we have to wait whether it'll be approved before we can continue with this backport. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2062#issuecomment-2018464466 From clanger at openjdk.org Mon Mar 25 17:08:49 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 25 Mar 2024 17:08:49 GMT Subject: [jdk22u] RFR: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket Message-ID: Hi all, This pull request contains a backport of [JDK-8325579](https://bugs.openjdk.org/browse/JDK-8325579), commit [907e30ff](https://github.com/openjdk/jdk/commit/907e30ff00abd6cd4935987810d282f46ec07704) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Christoph Langer on 25 Mar 2024 and was reviewed by Daniel Fuchs and Aleksei Efimov. Thanks! ------------- Commit messages: - Backport 907e30ff00abd6cd4935987810d282f46ec07704 Changes: https://git.openjdk.org/jdk22u/pull/114/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=114&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325579 Stats: 245 lines in 3 files changed: 130 ins; 35 del; 80 mod Patch: https://git.openjdk.org/jdk22u/pull/114.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/114/head:pull/114 PR: https://git.openjdk.org/jdk22u/pull/114 From christoph.langer at sap.com Mon Mar 25 17:11:08 2024 From: christoph.langer at sap.com (Langer, Christoph) Date: Mon, 25 Mar 2024 17:11:08 +0000 Subject: Proposal: Branch github.com/openjdk/jdk for stabilization (instead of fork) In-Reply-To: <7f95dd63bff94ca764d58226c2be464fe006f0e0.camel@redhat.com> References: <7f95dd63bff94ca764d58226c2be464fe006f0e0.camel@redhat.com> Message-ID: Hi, yes, I agree, it seems like a good approach that has its benefits. Let's try it with the master versions first and then see whether it's also something we should adopt for the update releases. Best regards Christoph > -----Original Message----- > From: jdk-updates-dev On Behalf Of > Severin Gehwolf > Sent: Donnerstag, 21. M?rz 2024 12:07 > To: Volker Simonis ; Iris Clark > > Cc: jdk-dev ; jdk-updates-dev at openjdk.org > Subject: Re: Proposal: Branch github.com/openjdk/jdk for stabilization (instead > of fork) > > On Thu, 2024-03-21 at 11:42 +0100, Volker Simonis wrote: > > This proposal sounds interesting and reasonable.It would be especially > > beneficial if the JDK Updates Project (added to CC) would adopt this > > new model. > > We can consider it for jdk-updates at a later point. I don't think it's good to > conflate those two at this point. Lets get mainline JDK development switched, > first. See how it pans out for mainline and corresponding downstream > consumers. > > Once we have that experience, we could model it for jdk-updates further down > the line. > > Thanks, > Severin From goetz at openjdk.org Mon Mar 25 17:48:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 17:48:31 GMT Subject: [jdk21u-dev] Integrated: 8319567: Update java/lang/invoke tests to support vm flags In-Reply-To: References: Message-ID: On Sat, 23 Mar 2024 19:07:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 998ba93a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/998ba93aceda49759f2064cabbabe58f0919ad73 Stats: 523 lines in 17 files changed: 89 ins; 304 del; 130 mod 8319567: Update java/lang/invoke tests to support vm flags 8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java to accept vm flags 8319672: Several classloader tests ignore VM flags 8319676: A couple of jdk/modules/incubator/ tests ignore VM flags 8319677: Test jdk/internal/misc/VM/RuntimeArguments.java should be marked as flagless Backport-of: 1588dd934ce4e00a060e329b80f721d894559597 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/396 From goetz at openjdk.org Mon Mar 25 17:52:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 17:52:31 GMT Subject: [jdk21u-dev] Integrated: 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags In-Reply-To: References: Message-ID: On Sat, 23 Mar 2024 19:19:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: d59d00d5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/d59d00d50f19f666f828513068b2b621a8739ef2 Stats: 14 lines in 7 files changed: 7 ins; 0 del; 7 mod 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags Backport-of: 62b7c5eaed1e6ffd6f2c8371eb4cf01dd9d53a06 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/397 From shade at openjdk.org Mon Mar 25 17:54:27 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 17:54:27 GMT Subject: [jdk21u-dev] Integrated: 8328705: GHA: Cross-compilation jobs do not require build JDK In-Reply-To: References: Message-ID: <1fHftVpbakEG4e6uu20djIYeLfZ1D8t-evDr5P6csfY=.88257a68-c833-4b94-8db1-c5fb84e94564@github.com> On Mon, 25 Mar 2024 11:53:58 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA parallelism. > > Additional testing: > - [ ] GHA This pull request has now been integrated. Changeset: 438c41af Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/438c41afd05476c42cc4b81a8a93e04abe2ab9b7 Stats: 11 lines in 2 files changed: 0 ins; 10 del; 1 mod 8328705: GHA: Cross-compilation jobs do not require build JDK Backport-of: 29ba4b7d1e62a834c1693fe6ad383c19467afc81 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/403 From goetz at openjdk.org Mon Mar 25 17:54:27 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 17:54:27 GMT Subject: [jdk21u-dev] Integrated: 8322858: compiler/c2/aarch64/TestFarJump.java fails on AArch64 due to unexpected PrintAssembly output In-Reply-To: References: Message-ID: On Sat, 23 Mar 2024 19:19:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: dbb3dfdd Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/dbb3dfdd429bb10f7ba26e25c5754a041e56d195 Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod 8322858: compiler/c2/aarch64/TestFarJump.java fails on AArch64 due to unexpected PrintAssembly output Backport-of: 52a6c37558fa970f595067bc1bb5bc2b710c3876 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/398 From goetz at openjdk.org Mon Mar 25 17:55:32 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 17:55:32 GMT Subject: [jdk17u-dev] Integrated: 8260540: serviceability/jdwp/AllModulesCommandTest.java failed with "Debuggee error: 'ERROR: transport error 202: bind failed: Address already in use'" In-Reply-To: References: Message-ID: On Thu, 21 Mar 2024 10:15:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. > > > I had to resolve Debuggee.java. Several later changes were already > backported, so I compared it with the last of these, where 21 and > 17 should be equal again: '8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use"' This pull request has now been integrated. Changeset: d74ef51e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/d74ef51e07dc79c156d4fb960901efa1818e9994 Stats: 134 lines in 7 files changed: 62 ins; 43 del; 29 mod 8260540: serviceability/jdwp/AllModulesCommandTest.java failed with "Debuggee error: 'ERROR: transport error 202: bind failed: Address already in use'" Reviewed-by: lucy Backport-of: 7a23c9cbb7d09c4e6c4e8d9b2f912e41d60fd05e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2319 From goetz at openjdk.org Mon Mar 25 17:57:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 17:57:25 GMT Subject: [jdk21u-dev] Integrated: 8319571: Update jni/nullCaller/NullCallerTest.java to accept flags or mark as flagless In-Reply-To: References: Message-ID: On Sat, 23 Mar 2024 19:24:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 098656d1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/098656d11e4781bc70f091ca0aa6d40eec774f2c Stats: 27 lines in 1 file changed: 1 ins; 21 del; 5 mod 8319571: Update jni/nullCaller/NullCallerTest.java to accept flags or mark as flagless Backport-of: b78896b9aafcb15f453eaed6e154a5461581407b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/399 From goetz at openjdk.org Mon Mar 25 17:57:29 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 17:57:29 GMT Subject: [jdk17u-dev] Integrated: 8280546: Remove hard-coded 127.0.0.1 loopback address In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 14:00:07 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. This pull request has now been integrated. Changeset: 432210b4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/432210b42666029e2dd71d1cffa849da27124e25 Stats: 5 lines in 2 files changed: 3 ins; 0 del; 2 mod 8280546: Remove hard-coded 127.0.0.1 loopback address Backport-of: b5de2cc9d36e1fad7d0bf70f7c83ff829e16b7f3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2315 From goetz at openjdk.org Mon Mar 25 17:57:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 17:57:28 GMT Subject: [jdk11u-dev] Integrated: 8324632: Update Zlib Data Compression Library to Version 1.3.1 In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 12:57:46 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.24-oracle. This pull request has now been integrated. Changeset: 6aa72164 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/6aa721649d870354a79c3508343b14222e0edcfb Stats: 2219 lines in 26 files changed: 609 ins; 1036 del; 574 mod 8324632: Update Zlib Data Compression Library to Version 1.3.1 8315117: Update Zlib Data Compression Library to Version 1.3 8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1 Backport-of: 6359b2843f83852561b925d3f1315eed5f4b9cda ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2618 From goetz at openjdk.org Mon Mar 25 17:58:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 17:58:24 GMT Subject: [jdk21u-dev] Integrated: 8324236: compiler/ciReplay/TestInliningProtectionDomain.java failed with RuntimeException: should only dump inline information for ... expected true, was false In-Reply-To: <7_xw0C_jQryZIUZxTuyZmEtqz_yWfgxeC18UKSHy_j8=.189438b5-8646-4c76-8d50-daded0aaa0a1@github.com> References: <7_xw0C_jQryZIUZxTuyZmEtqz_yWfgxeC18UKSHy_j8=.189438b5-8646-4c76-8d50-daded0aaa0a1@github.com> Message-ID: On Wed, 20 Mar 2024 21:23:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 28367346 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/2836734607ab15e75b25e82908c2596d1bbff8ee Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8324236: compiler/ciReplay/TestInliningProtectionDomain.java failed with RuntimeException: should only dump inline information for ... expected true, was false Backport-of: 72ba8178a8271d4a04a0b789f28b23414b8989ed ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/389 From goetz at openjdk.org Mon Mar 25 17:59:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 17:59:25 GMT Subject: [jdk21u-dev] Integrated: 8319651: Several network tests ignore vm flags when start java process In-Reply-To: <_1V-ObG8B4U4hITxY4G0KTZfGDBrV0D5blADEGK-fwI=.dd69edbd-a4d7-4b52-8aae-5f9e65723057@github.com> References: <_1V-ObG8B4U4hITxY4G0KTZfGDBrV0D5blADEGK-fwI=.dd69edbd-a4d7-4b52-8aae-5f9e65723057@github.com> Message-ID: On Sat, 23 Mar 2024 19:56:08 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 1dfda33a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/1dfda33a1fce44fdd935c348d0aab3515a5599b0 Stats: 123 lines in 14 files changed: 27 ins; 35 del; 61 mod 8319651: Several network tests ignore vm flags when start java process Backport-of: 9538f5d317972bbb82f7f2575819d35d2a5f8b91 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/400 From goetz at openjdk.org Mon Mar 25 18:01:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 18:01:24 GMT Subject: [jdk21u-dev] Integrated: 8326948: Force English locale for timeout formatting In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 21:27:44 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: bb2ddc08 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/bb2ddc0818925af2dcb74a32a362fdf8e1a42493 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8326948: Force English locale for timeout formatting Backport-of: e772e7817981b7b5c01b95245cf2022372494619 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/390 From goetz at openjdk.org Mon Mar 25 18:01:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 18:01:24 GMT Subject: [jdk21u-dev] Integrated: 8326824: Test: remove redundant test in compiler/vectorapi/reshape/utils/TestCastMethods.java In-Reply-To: References: Message-ID: On Sat, 23 Mar 2024 20:03:40 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: aa1fe7a1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/aa1fe7a1201ed7884c33103af31ca11370224b55 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod 8326824: Test: remove redundant test in compiler/vectorapi/reshape/utils/TestCastMethods.java Backport-of: 552411f832eb35d739c7978b8c1f8d0dfd4b2161 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/401 From goetz at openjdk.org Mon Mar 25 18:03:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 18:03:23 GMT Subject: [jdk21u-dev] Integrated: 8319648: java/lang/SecurityManager tests ignore vm flags In-Reply-To: References: Message-ID: <7CRWX93zImsEKEv2CGx5dkrwZYAr0Fellafp4NpQjkE=.a6ab165e-8c10-41cf-8582-aff854e93006@github.com> On Sat, 23 Mar 2024 20:05:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: 660c00a7 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/660c00a7fc462378db703404c10d5166641d3ca7 Stats: 9 lines in 2 files changed: 1 ins; 3 del; 5 mod 8319648: java/lang/SecurityManager tests ignore vm flags Backport-of: 437cf354e2d1f7df79fa32265ccf86a0e84257b5 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/402 From goetz at openjdk.org Mon Mar 25 18:05:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 25 Mar 2024 18:05:24 GMT Subject: [jdk21u-dev] Integrated: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 21:42:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. This pull request has now been integrated. Changeset: c33815ad Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/c33815ad3c86bd38432f80877c0bc1ac1af15070 Stats: 24 lines in 2 files changed: 0 ins; 6 del; 18 mod 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases Backport-of: 9f7094079b6eb6b60b345955dba358a2d5c90931 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/391 From sroy at openjdk.org Mon Mar 25 18:09:35 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 25 Mar 2024 18:09:35 GMT Subject: [jdk11u-dev] RFR: 8320005: Allow loading of shared objects with .a extension on AIX Message-ID: Hi all, This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. Thanks! ------------- Commit messages: - Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab Changes: https://git.openjdk.org/jdk11u-dev/pull/2622/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2622&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320005 Stats: 22 lines in 1 file changed: 20 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2622.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2622/head:pull/2622 PR: https://git.openjdk.org/jdk11u-dev/pull/2622 From shade at openjdk.org Mon Mar 25 18:10:28 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 18:10:28 GMT Subject: [jdk17u-dev] Integrated: 8328705: GHA: Cross-compilation jobs do not require build JDK In-Reply-To: References: Message-ID: <_0wtZxZ9HZDRMmjv__ky6i3yeoLslSXLcYmkktPMMeU=.5126cd03-da7d-40cf-b34a-2fbe76f3d8f2@github.com> On Mon, 25 Mar 2024 12:26:32 GMT, Aleksey Shipilev wrote: > Semi-clean backport to improve GHA parallelism. There is a contextual difference due jmod-compression-level support being missing in JDK 17, resolved by hand. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 791be779 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/791be7794bdd042ef28c27d90ecde3a1e70776f5 Stats: 11 lines in 2 files changed: 0 ins; 10 del; 1 mod 8328705: GHA: Cross-compilation jobs do not require build JDK Backport-of: 29ba4b7d1e62a834c1693fe6ad383c19467afc81 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2324 From shade at openjdk.org Mon Mar 25 18:13:24 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 18:13:24 GMT Subject: [jdk11u-dev] Integrated: 8328705: GHA: Cross-compilation jobs do not require build JDK In-Reply-To: References: Message-ID: <3RkUa_ZhKOeT4VusYMFtrMn-O4Pavi55JMhE_XBtqsE=.0aed9892-c64a-4151-a2dc-0e8606198793@github.com> On Mon, 25 Mar 2024 12:33:24 GMT, Aleksey Shipilev wrote: > Semi-clean backport to improve GHA parallelism. There is a contextual difference due jmod-compression-level support being missing in JDK 11, resolved by hand. There is also a contextual difference in gtest support: JDK 11 does not have a hunk that downloads the gtest. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 37cfd480 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk11u-dev/commit/37cfd4808dead6e846a3626f6e7b50cc9e207d98 Stats: 11 lines in 2 files changed: 0 ins; 10 del; 1 mod 8328705: GHA: Cross-compilation jobs do not require build JDK Backport-of: 29ba4b7d1e62a834c1693fe6ad383c19467afc81 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2621 From shade at openjdk.org Mon Mar 25 18:23:43 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 18:23:43 GMT Subject: [jdk21u-dev] RFR: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 Message-ID: Fixes a recent GHA regression. Additional testing: - [ ] GHA, first run passes cross-builds - [ ] GHA, second run passes cross-builds ------------- Commit messages: - Backport 447436e18c754424a62af5135fb3a8973564091d Changes: https://git.openjdk.org/jdk21u-dev/pull/408/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=408&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328948 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/408.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/408/head:pull/408 PR: https://git.openjdk.org/jdk21u-dev/pull/408 From shade at openjdk.org Mon Mar 25 18:24:46 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 18:24:46 GMT Subject: [jdk22u] RFR: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 Message-ID: Fixes a recent GHA regression. Additional testing: - [ ] GHA, first run passes cross-builds - [ ] GHA, second run passes cross-builds ------------- Commit messages: - Backport 447436e18c754424a62af5135fb3a8973564091d Changes: https://git.openjdk.org/jdk22u/pull/115/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=115&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328948 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/115.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/115/head:pull/115 PR: https://git.openjdk.org/jdk22u/pull/115 From shade at openjdk.org Mon Mar 25 18:25:37 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 18:25:37 GMT Subject: [jdk17u-dev] RFR: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 Message-ID: Fixes a recent GHA regression. Additional testing: - [ ] GHA, first run passes cross-builds - [ ] GHA, second run passes cross-builds ------------- Commit messages: - Backport 447436e18c754424a62af5135fb3a8973564091d Changes: https://git.openjdk.org/jdk17u-dev/pull/2329/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2329&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328948 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2329.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2329/head:pull/2329 PR: https://git.openjdk.org/jdk17u-dev/pull/2329 From sroy at openjdk.org Mon Mar 25 18:32:24 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 25 Mar 2024 18:32:24 GMT Subject: [jdk17u-dev] Withdrawn: 8320005: Allow loading of shared objects with .a extension on AIX In-Reply-To: References: Message-ID: <1RLpm0SiIpRwKcc3LTjAcBbhhxF7XjzlcDbfRWzOhhs=.eaafe8c5-bce8-4506-ba56-b065564d22ac@github.com> On Thu, 7 Mar 2024 12:38:33 GMT, Suchismith Roy wrote: > Hi all, > > This pull request contains a backport of commit [b8ae4a8c](https://github.com/openjdk/jdk/commit/b8ae4a8c0985d1763ac48ba78943d8b992d7be77) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Joachim Kern on 11 Jan 2024 and was reviewed by Thomas Stuefe and Martin Doerr. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2271 From shade at openjdk.org Mon Mar 25 19:48:38 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 19:48:38 GMT Subject: [jdk22u] RFR: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 [v2] In-Reply-To: References: Message-ID: > Fixes a recent GHA regression. > > Additional testing: > - [x] GHA, first run passes cross-builds > - [ ] GHA, second run passes cross-builds Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Empty commit to trigger second GHA run ------------- Changes: - all: https://git.openjdk.org/jdk22u/pull/115/files - new: https://git.openjdk.org/jdk22u/pull/115/files/c977d7c4..ccc5ac25 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk22u&pr=115&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk22u&pr=115&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/115.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/115/head:pull/115 PR: https://git.openjdk.org/jdk22u/pull/115 From shade at openjdk.org Mon Mar 25 19:49:36 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 19:49:36 GMT Subject: [jdk21u-dev] RFR: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 [v2] In-Reply-To: References: Message-ID: > Fixes a recent GHA regression. > > Additional testing: > - [x] GHA, first run passes cross-builds > - [ ] GHA, second run passes cross-builds Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Empty commit to trigger second GHA run ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/408/files - new: https://git.openjdk.org/jdk21u-dev/pull/408/files/61a380f1..d6c9f7de Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=408&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=408&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/408.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/408/head:pull/408 PR: https://git.openjdk.org/jdk21u-dev/pull/408 From shade at openjdk.org Mon Mar 25 19:50:37 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 19:50:37 GMT Subject: [jdk17u-dev] RFR: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 [v2] In-Reply-To: References: Message-ID: > Fixes a recent GHA regression. > > Additional testing: > - [ ] GHA, first run passes cross-builds > - [ ] GHA, second run passes cross-builds Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Empty commit to trigger second GHA run ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2329/files - new: https://git.openjdk.org/jdk17u-dev/pull/2329/files/196fd489..81775e3b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2329&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2329&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2329.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2329/head:pull/2329 PR: https://git.openjdk.org/jdk17u-dev/pull/2329 From shade at openjdk.org Mon Mar 25 20:22:35 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 20:22:35 GMT Subject: [jdk21u-dev] RFR: 8328825: Google CAInterop test failures Message-ID: Clean backport to fix some of the current failures in `CAInterop` test. Additional testing: - [x] Affected subtests are now passing ------------- Commit messages: - Backport 70a15c73638f45b9ed629abc0ea2d86a324bf624 Changes: https://git.openjdk.org/jdk21u-dev/pull/409/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=409&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328825 Stats: 10 lines in 1 file changed: 0 ins; 5 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/409.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/409/head:pull/409 PR: https://git.openjdk.org/jdk21u-dev/pull/409 From shade at openjdk.org Mon Mar 25 20:46:37 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 20:46:37 GMT Subject: [jdk17u-dev] RFR: 8328825: Google CAInterop test failures Message-ID: <4IXMpRcnF4_u1ZRqv6Dt27rWMPgFNIL95SBt2nSw3rg=.d8bc051d-a2f7-49f5-a308-2aea9afa0297@github.com> Clean backport to fix some of the current failures in `CAInterop` test. Additional testing: - [x] Affected subtests are now passing ------------- Commit messages: - Backport 70a15c73638f45b9ed629abc0ea2d86a324bf624 Changes: https://git.openjdk.org/jdk17u-dev/pull/2330/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2330&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328825 Stats: 10 lines in 1 file changed: 0 ins; 5 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2330.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2330/head:pull/2330 PR: https://git.openjdk.org/jdk17u-dev/pull/2330 From jwilhelm at openjdk.org Mon Mar 25 21:34:28 2024 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Mon, 25 Mar 2024 21:34:28 GMT Subject: [jdk22u] Integrated: 8328812: Update and move siphash license In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 16:06:01 GMT, Jesper Wilhelmsson wrote: > Clean backport of fix in license file. This pull request has now been integrated. Changeset: 2c00048a Author: Jesper Wilhelmsson URL: https://git.openjdk.org/jdk22u/commit/2c00048af3ebd82002caddca1b3c0e96558233bf Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod 8328812: Update and move siphash license Backport-of: ce7ebaa606f96fdfee66d300b56022d9903b5ae3 ------------- PR: https://git.openjdk.org/jdk22u/pull/111 From btaylor at openjdk.org Mon Mar 25 23:29:33 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 25 Mar 2024 23:29:33 GMT Subject: [jdk11u-dev] Integrated: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader In-Reply-To: <-xaaNFRNKQlOGYX5TePvEkIB1vBs2EZl2A7no7HNOL0=.5c6fa45e-7d64-4e03-97b7-da3cfe5fbed1@github.com> References: <-xaaNFRNKQlOGYX5TePvEkIB1vBs2EZl2A7no7HNOL0=.5c6fa45e-7d64-4e03-97b7-da3cfe5fbed1@github.com> Message-ID: On Fri, 22 Mar 2024 16:47:16 GMT, Ben Taylor wrote: > Clean backport of [JDK-8319436](https://bugs.openjdk.org/browse/JDK-8319436) to resolve a regression introduced in 11.0.20. > Included test passes locally on linux x64 after the update to jtreg-7.3.1. This pull request has now been integrated. Changeset: b7f78a39 Author: Ben Taylor URL: https://git.openjdk.org/jdk11u-dev/commit/b7f78a39c2c11e351a927da97455efa112b70d1c Stats: 143 lines in 2 files changed: 20 ins; 77 del; 46 mod 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader Backport-of: 8eb6f617b3f8e2a990e4244af4e56287f9741b20 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2619 From btaylor at openjdk.org Mon Mar 25 23:37:52 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 25 Mar 2024 23:37:52 GMT Subject: [jdk11u-dev] RFR: 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned Message-ID: Clean backport of JDK-8273831 to fix a regression that can leave an orphaned thread. Verified with included test. ------------- Commit messages: - Backport 687567822a5380fb7d8c5b54ae548b2a5c848187 Changes: https://git.openjdk.org/jdk11u-dev/pull/2623/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2623&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273831 Stats: 120 lines in 3 files changed: 104 ins; 3 del; 13 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2623.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2623/head:pull/2623 PR: https://git.openjdk.org/jdk11u-dev/pull/2623 From syan at openjdk.org Tue Mar 26 01:25:37 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 26 Mar 2024 01:25:37 GMT Subject: [jdk11u-dev] RFR: 8328825: Google CAInterop test failures Message-ID: Clean backport to fix some of the current failures in CAInterop test. Additional testing: - [ ] Affected subtests are now passing ------------- Commit messages: - Backport 70a15c73638f45b9ed629abc0ea2d86a324bf624 Changes: https://git.openjdk.org/jdk11u-dev/pull/2624/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2624&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328825 Stats: 10 lines in 1 file changed: 0 ins; 5 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2624.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2624/head:pull/2624 PR: https://git.openjdk.org/jdk11u-dev/pull/2624 From duke at openjdk.org Tue Mar 26 01:52:29 2024 From: duke at openjdk.org (Korov) Date: Tue, 26 Mar 2024 01:52:29 GMT Subject: [jdk11u-dev] RFR: 8214245: Case insensitive matching doesn't work correctly for some character classes [v8] In-Reply-To: References: Message-ID: <-OZ7GvZ_7U44NjkIBrbmcCxYCl6s6YDhol1fhCsU4d0=.41cffa6b-6a0a-457a-8861-43a0686ef70c@github.com> On Mon, 25 Mar 2024 16:53:36 GMT, Christoph Langer wrote: > > Hello @RealCLanger , I'm very interested in continuing to work on this backport, Please help me create a CSR and tell me the relevant links. Thank you very much for your help. > > OK, I now created a CSR for 11-pool: [JDK-8328951](https://bugs.openjdk.org/browse/JDK-8328951). The CSR will need a review from some OpenJDK reviewer, e.g. @phohensee or @GoeLin, would you mind taking a look? > > After CSR review, we have to wait whether it'll be approved before we can continue with this backport. Thats great, thanks for your help. I will continue to pay attention to the progress of CSR. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2062#issuecomment-2019241147 From duke at openjdk.org Tue Mar 26 02:21:45 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Tue, 26 Mar 2024 02:21:45 GMT Subject: [jdk21u-dev] RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump Message-ID: Hi all, I'd like to backport JDK-8313710 to jdk21u-dev. I confirmed that the fixes are reflected in the documentation and that all of the jdk_jfr tests passed. Thanks. ------------- Commit messages: - Merge branch 'openjdk:master' into JDK-8313710 - 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump Changes: https://git.openjdk.org/jdk21u-dev/pull/410/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=410&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313710 Stats: 113 lines in 2 files changed: 0 ins; 0 del; 113 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/410.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/410/head:pull/410 PR: https://git.openjdk.org/jdk21u-dev/pull/410 From andrewlu at openjdk.org Tue Mar 26 07:21:54 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 26 Mar 2024 07:21:54 GMT Subject: [jdk11u-dev] RFR: 8210988: Improved handling of compiler warnings in the build [v6] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.24-oracle. > make/hotspot/lib/CompileGtest.gmk > ?DISABLED_WARNINGS_microsoft := $(DISABLED_WARNINGS_microsoft) \ > 4146, \? > make/hotspot/lib/CompileJvm.gmk > DISABLED_WARNINGS_microsoft := 4146, \ > > The DISABLED_WARNINGS_microsoft change to 4146 as in src\hotspot\cpu\aarch64\register_aarch64.hpp(285) > 'uint32_t first = _bitset & -_bitset' remains. Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: update ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2606/files - new: https://git.openjdk.org/jdk11u-dev/pull/2606/files/110d8fe3..f5e90cd4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2606&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2606&range=04-05 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2606.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2606/head:pull/2606 PR: https://git.openjdk.org/jdk11u-dev/pull/2606 From andrewlu at openjdk.org Tue Mar 26 07:24:38 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 26 Mar 2024 07:24:38 GMT Subject: [jdk17u-dev] RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 1f43fa0f8b0f956b41015e0ebc257e15a11ad99b Changes: https://git.openjdk.org/jdk17u-dev/pull/2331/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2331&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326661 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2331.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2331/head:pull/2331 PR: https://git.openjdk.org/jdk17u-dev/pull/2331 From goetz at openjdk.org Tue Mar 26 07:51:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 26 Mar 2024 07:51:24 GMT Subject: [jdk11u-dev] RFR: 8261302: NMT: Improve malloc site table hashing In-Reply-To: References: Message-ID: <6EWYjBwO3TOI65Gqi_xDxQqp7ihyq44U6Wn-PvDqKH8=.9f21684a-00a7-4071-a102-8992b94970fb@github.com> On Fri, 22 Mar 2024 09:18:36 GMT, Mar?a Arias de Reyna wrote: >> This is the same fix that was applied in https://github.com/openjdk/jdk/commit/a3d6e371 for https://bugs.openjdk.org/browse/JDK-8261302 >> >> It simplifies the way of calculating the hash of a stack. > > Starting with 21 then! > > Comment edited. Hi @Delawen, after checking with the fellow maintainers we decided this is too much for 11. Thomas agreed, too. Thanks for engaging in OpenJDK anyways! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2608#issuecomment-2019629030 From andrewlu at openjdk.org Tue Mar 26 08:02:43 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 26 Mar 2024 08:02:43 GMT Subject: [jdk11u-dev] RFR: 8310923: Refactor Currency tests to use JUnit Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport e848d9471f5de86e5ac157b710cd7371f12f0024 - Backport e848d9471f5de86e5ac157b710cd7371f12f0024 Changes: https://git.openjdk.org/jdk11u-dev/pull/2625/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2625&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310923 Stats: 1089 lines in 9 files changed: 436 ins; 372 del; 281 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2625.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2625/head:pull/2625 PR: https://git.openjdk.org/jdk11u-dev/pull/2625 From shade at openjdk.org Tue Mar 26 08:21:25 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 26 Mar 2024 08:21:25 GMT Subject: [jdk21u-dev] Integrated: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 In-Reply-To: References: Message-ID: On Mon, 25 Mar 2024 18:19:32 GMT, Aleksey Shipilev wrote: > Fixes a recent GHA regression. > > Additional testing: > - [x] GHA, first run passes cross-builds > - [x] GHA, second run passes cross-builds This pull request has now been integrated. Changeset: a2557bbe Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/a2557bbe1ac3c5231f76df21c1bb6bd4d9840c80 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 Backport-of: 447436e18c754424a62af5135fb3a8973564091d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/408 From shade at openjdk.org Tue Mar 26 08:21:30 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 26 Mar 2024 08:21:30 GMT Subject: [jdk17u-dev] Integrated: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 In-Reply-To: References: Message-ID: On Mon, 25 Mar 2024 18:21:00 GMT, Aleksey Shipilev wrote: > Fixes a recent GHA regression. > > Additional testing: > - [x] GHA, first run passes cross-builds > - [x] GHA, second run passes cross-builds This pull request has now been integrated. Changeset: 533e1b17 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/533e1b17939882cd485718e5397c74ff9392d9de Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 Backport-of: 447436e18c754424a62af5135fb3a8973564091d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2329 From duke at openjdk.org Tue Mar 26 09:06:37 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Tue, 26 Mar 2024 09:06:37 GMT Subject: [jdk21u-dev] RFR: 8319437: NMT should show library names in call stacks Message-ID: This is a backport of https://bugs.openjdk.org/browse/JDK-8319437 as it was solved in JDK22. Example of output running IntellijIDEA with this piece of code: $ jcmd 23808 VM.native_memory detail | grep " in " [0x00007f9db6e3420f]JavaMain+0x8f in libjli.so [0x00007f9db6e3420f]JavaMain+0x8f in libjli.so [0x00007f9db6e3420f]JavaMain+0x8f in libjli.so [0x00007f9db6e3420f]JavaMain+0x8f in libjli.so [0x00007f9db54d05b7]Java_java_lang_ProcessImpl_forkAndExec+0x157 in libjava.so [0x00007f9db6e3420f]JavaMain+0x8f in libjli.so [0x00007f9db6e37e49]ThreadJavaMain+0x9 in libjli.so [0x00007f9db6e3420f]JavaMain+0x8f in libjli.so [0x00007f9db54cdb5d]Java_java_lang_ClassLoader_defineClass0+0x14d in libjava.so [0x00007f9db54cd405]Java_java_lang_Class_forName0+0xd5 in libjava.so [0x00007f9db54cd7d1]Java_java_lang_ClassLoader_defineClass1+0x181 in libjava.so [0x00007f9db54cd405]Java_java_lang_Class_forName0+0xd5 in libjava.so [0x00007f9db54cdcab]Java_java_lang_ClassLoader_findBootstrapClass+0xab in libjava.so [0x00007f9db6e3420f]JavaMain+0x8f in libjli.so [0x00007f9db6e3420f]JavaMain+0x8f in libjli.so [0x00007f9db6e3420f]JavaMain+0x8f in libjli.so [0x00007f9db6e37e49]ThreadJavaMain+0x9 in libjli.so [0x00007f9db6e3420f]JavaMain+0x8f in libjli.so [0x00007f9d76848bd5]load_class_global+0x25 in libverify.so [0x00007f9d768498e8]merge_fullinfo_types+0x388 in libverify.so [0x00007f9db6e3420f]JavaMain+0x8f in libjli.so [0x00007f9db6e3420f]JavaMain+0x8f in libjli.so [0x00007f9db54cdcab]Java_java_lang_ClassLoader_findBootstrapClass+0xab in libjava.so [0x00007f9d3bf609a6]Java_sun_java2d_loops_GraphicsPrimitiveMgr_initIDs+0x1c6 in libawt.so [0x00007f9db6e3420f]JavaMain+0x8f in libjli.so [0x00007f9db6e37e49]ThreadJavaMain+0x9 in libjli.so [0x00007f9db6e3420f]JavaMain+0x8f in libjli.so [0x00007f9db54d05b7]Java_java_lang_ProcessImpl_forkAndExec+0x157 in libjava.so [0x00007f9db6e3420f]JavaMain+0x8f in libjli.so ------------- Commit messages: - Backport e33b6c10f8d3244ec2f4204cd4de404e0e0686eb Changes: https://git.openjdk.org/jdk21u-dev/pull/405/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=405&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319437 Stats: 21 lines in 1 file changed: 15 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/405.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/405/head:pull/405 PR: https://git.openjdk.org/jdk21u-dev/pull/405 From andrewlu at openjdk.org Tue Mar 26 09:27:00 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 26 Mar 2024 09:27:00 GMT Subject: [jdk11u-dev] RFR: 8310923: Refactor Currency tests to use JUnit [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.24-oracle. > Clean except some code lines are different, so make it clean. Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: fix ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2625/files - new: https://git.openjdk.org/jdk11u-dev/pull/2625/files/1335bfab..50ac2bea Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2625&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2625&range=00-01 Stats: 16 lines in 2 files changed: 4 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2625.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2625/head:pull/2625 PR: https://git.openjdk.org/jdk11u-dev/pull/2625 From shade at openjdk.org Tue Mar 26 11:08:22 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 26 Mar 2024 11:08:22 GMT Subject: [jdk21u-dev] Integrated: 8328825: Google CAInterop test failures In-Reply-To: References: Message-ID: On Mon, 25 Mar 2024 20:13:00 GMT, Aleksey Shipilev wrote: > Clean backport to fix some of the current failures in `CAInterop` test. > > Additional testing: > - [x] Affected subtests are now passing This pull request has now been integrated. Changeset: f2a013bd Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/f2a013bd33910a04352d605f811263b55fc02676 Stats: 10 lines in 1 file changed: 0 ins; 5 del; 5 mod 8328825: Google CAInterop test failures Backport-of: 70a15c73638f45b9ed629abc0ea2d86a324bf624 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/409 From sroy at openjdk.org Tue Mar 26 11:11:30 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Tue, 26 Mar 2024 11:11:30 GMT Subject: [jdk17u-dev] Withdrawn: 8320005: Allow loading of shared objects with .a extension on AIX In-Reply-To: <9DH5Cq2zcCu9YAMOlLEDVNbivc--6gm6hp8tMbhItW0=.6d29bcd2-a287-46ca-ada7-364feeb1ba8e@github.com> References: <9DH5Cq2zcCu9YAMOlLEDVNbivc--6gm6hp8tMbhItW0=.6d29bcd2-a287-46ca-ada7-364feeb1ba8e@github.com> Message-ID: On Mon, 25 Mar 2024 15:20:44 GMT, Suchismith Roy wrote: > Hi all, > > This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2326 From sroy at openjdk.org Tue Mar 26 11:34:50 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Tue, 26 Mar 2024 11:34:50 GMT Subject: [jdk17u-dev] RFR: 8320005: Allow loading of shared objects with .a extension on AIX Message-ID: Hi all, This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. Thanks! ------------- Commit messages: - Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab Changes: https://git.openjdk.org/jdk17u-dev/pull/2332/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2332&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320005 Stats: 24 lines in 1 file changed: 20 ins; 3 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2332.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2332/head:pull/2332 PR: https://git.openjdk.org/jdk17u-dev/pull/2332 From goetz at openjdk.org Tue Mar 26 13:31:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 26 Mar 2024 13:31:48 GMT Subject: [jdk17u-dev] RFR: 8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use" Message-ID: <0y_lyWjWarcVVIUuATp7OGhcK1RlzlIub-TAVjavC3w=.a5f1ef0e-363c-475b-b532-adc4d3625496@github.com> I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport b62e7420450dad5a807a5afa0f65f6632b344e29 Changes: https://git.openjdk.org/jdk17u-dev/pull/2333/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2333&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8213714 Stats: 146 lines in 4 files changed: 63 ins; 53 del; 30 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2333.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2333/head:pull/2333 PR: https://git.openjdk.org/jdk17u-dev/pull/2333 From lucy at openjdk.org Tue Mar 26 16:30:27 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Tue, 26 Mar 2024 16:30:27 GMT Subject: [jdk17u-dev] RFR: 8295944: Move the Http2TestServer and related classes into a package of its own [v3] In-Reply-To: References: <8QL1KBFZDNOPtJfyTMcCxtTpN9HbNoV5kyPB6C9rZmg=.1abe1b82-dbba-4508-b528-58106e3a3f31@github.com> Message-ID: On Fri, 22 Mar 2024 08:02:13 GMT, Goetz Lindenmaier wrote: >> I backport this to simplify further backports. It's a refactoring of test infra. >> >> I had to do resolves of Copyright, imports, and @test descriptions. A row of tests are not in 17. >> In detail: >> >> >> test/jdk/java/net/httpclient/AsFileDownloadTest.java >> Needs resolve because earlier changes were al >> >> test/jdk/java/net/httpclient/AsyncExecutorShutdown.java >> Introduced in 19 by "8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task" >> This is a bug fix one wants to have in 17 at first sight, but it is a big change >> and it had several follow ups. So better don't backport as prerequisite. >> >> test/jdk/java/net/httpclient/CancelRequestTest.java >> Resolved Copyright. >> >> test/jdk/java/net/httpclient/CancelStreamedBodyTest.java >> Introduced in 20 by "294916: Cancelling a request must eventually cause its response body subscriber to be unregistered" >> This fix has many prereqs that would need to be backported. Omit. >> >> test/jdk/java/net/httpclient/DigestEchoClient.java >> Resolved Copyright. >> >> test/jdk/java/net/httpclient/ExecutorShutdown.java >> As above introduced by "8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task". Omit. >> >> test/jdk/java/net/httpclient/ExpectContinueTest.java >> Introduced in 20 by "8286171: HttpClient/2 : Expect:100-Continue blocks indefinitely when response is not 100" >> >> test/jdk/java/net/httpclient/HeadTest.java >> Resolved Copyright and imports. >> "8276559: (httpclient) Consider adding an HttpRequest.Builder.HEAD method to build a HEAD request." which came in 18 >> is a new feature with CSR that changed the imports. >> >> test/jdk/java/net/httpclient/HttpClientLocalAddrTest.java >> Introduced in 19 by "8209137: Add ability to bind to specific local address to HTTP client". A new >> feature. Omit. >> >> test/jdk/java/net/httpclient/ISO_8859_1_Test.java >> Resolved Copyright >> >> test/jdk/java/net/httpclient/MappingResponseSubscriber.java >> Resolved imports. >> >> test/jdk/java/net/httpclient/Response1xxTest.java >> Introduced in 20 by 8292044: HttpClient doesn't handle 102 or 103 properly. Omit. >> >> >> test/jdk/java/net/httpclient/SpecialHeadersTest.java >> Resolved due to context. >> >> test/jdk/java/net/httpclient/http2/IdleConnectionTimeoutTest.java >> Was added by 8288717: Add a means to close idle connections in HTTP/2 connection pool in 20. Omit. >> >> test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java >> Was added by 8263031: HttpClient throws Excep... > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Adapt ConnectionReuseTest LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2311#pullrequestreview-1961041115 From honkar at openjdk.org Tue Mar 26 17:12:49 2024 From: honkar at openjdk.org (Harshitha Onkar) Date: Tue, 26 Mar 2024 17:12:49 GMT Subject: [jdk22u] RFR: JDK-8328988 : [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653 Message-ID: The following test, java/awt/LightweightComponent/LightweightEventTest/LightweightEventTest.java fails on macOS 14 on jdk22 & older. The reason for failure on macOS 14 is documented here - [JDK-8322653](https://bugs.openjdk.org/browse/JDK-8322653). Since CI tests are being extended to run on macOS 14 this test needs to be problem-listed. ------------- Commit messages: - LightweightEventTest pListed on macOS Changes: https://git.openjdk.org/jdk22u/pull/116/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=116&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328988 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/116.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/116/head:pull/116 PR: https://git.openjdk.org/jdk22u/pull/116 From honkar at openjdk.org Tue Mar 26 17:20:29 2024 From: honkar at openjdk.org (Harshitha Onkar) Date: Tue, 26 Mar 2024 17:20:29 GMT Subject: [jdk22u] RFR: JDK-8328988 : [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653 In-Reply-To: References: Message-ID: On Tue, 26 Mar 2024 17:06:28 GMT, Harshitha Onkar wrote: > The following test, java/awt/LightweightComponent/LightweightEventTest/LightweightEventTest.java fails on macOS 14 on jdk22 & older. The reason for failure on macOS 14 is documented here - [JDK-8322653](https://bugs.openjdk.org/browse/JDK-8322653). > > Since CI testing is being extended to run on macOS 14, it is necessary to problem-list this test. @prrace Can you please approve this problem-listing PR when you get a chance? ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/116#issuecomment-2021036069 From prr at openjdk.org Tue Mar 26 18:10:27 2024 From: prr at openjdk.org (Phil Race) Date: Tue, 26 Mar 2024 18:10:27 GMT Subject: [jdk22u] RFR: JDK-8328988 : [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653 In-Reply-To: References: Message-ID: On Tue, 26 Mar 2024 17:06:28 GMT, Harshitha Onkar wrote: > The following test, java/awt/LightweightComponent/LightweightEventTest/LightweightEventTest.java fails on macOS 14 on jdk22 & older. The reason for failure on macOS 14 is documented here - [JDK-8322653](https://bugs.openjdk.org/browse/JDK-8322653). > > Since CI testing is being extended to run on macOS 14, it is necessary to problem-list this test. Marked as reviewed by prr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk22u/pull/116#pullrequestreview-1961328809 From andrew at openjdk.org Wed Mar 27 00:27:25 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 27 Mar 2024 00:27:25 GMT Subject: [jdk11u-dev] RFR: 8317507: C2 compilation fails with "Exceeded _node_regs array" In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 00:50:04 GMT, Martin Balao wrote: > Hi, > > I'd like to propose this backport to 11u-dev. The 17u fix applies cleanly. I ran and debugged the test to make sure that it is triggering the faulty behavior. > > Thanks, > Martin.- Confirmed clean. The PR title needs to be "Backport a5818972c16bd883d768ff2fb23a8aa9e0142c65" so this is correctly detected as a backport. ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2617#pullrequestreview-1962012918 From andrew at openjdk.org Wed Mar 27 00:55:33 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 27 Mar 2024 00:55:33 GMT Subject: [jdk11u-dev] RFR: 8317507: C2 compilation fails with "Exceeded _node_regs array" In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 00:50:04 GMT, Martin Balao wrote: > Hi, > > I'd like to propose this backport to 11u-dev. The 17u fix applies cleanly. I ran and debugged the test to make sure that it is triggering the faulty behavior. > > Thanks, > Martin.- Marked as reviewed by andrew (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2617#pullrequestreview-1962032469 From andrewlu at openjdk.org Wed Mar 27 02:14:38 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 27 Mar 2024 02:14:38 GMT Subject: [jdk21u-dev] RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 1f43fa0f8b0f956b41015e0ebc257e15a11ad99b Changes: https://git.openjdk.org/jdk21u-dev/pull/411/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=411&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326661 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/411.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/411/head:pull/411 PR: https://git.openjdk.org/jdk21u-dev/pull/411 From andrewlu at openjdk.org Wed Mar 27 02:39:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 27 Mar 2024 02:39:40 GMT Subject: [jdk11u-dev] RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 1f43fa0f8b0f956b41015e0ebc257e15a11ad99b Changes: https://git.openjdk.org/jdk11u-dev/pull/2626/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2626&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326661 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2626.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2626/head:pull/2626 PR: https://git.openjdk.org/jdk11u-dev/pull/2626 From mbalao at openjdk.org Wed Mar 27 03:25:28 2024 From: mbalao at openjdk.org (Martin Balao) Date: Wed, 27 Mar 2024 03:25:28 GMT Subject: [jdk11u-dev] Integrated: 8317507: C2 compilation fails with "Exceeded _node_regs array" In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 00:50:04 GMT, Martin Balao wrote: > Hi, > > I'd like to propose this backport to 11u-dev. The 17u fix applies cleanly. I ran and debugged the test to make sure that it is triggering the faulty behavior. > > Thanks, > Martin.- This pull request has now been integrated. Changeset: d98b4607 Author: Martin Balao URL: https://git.openjdk.org/jdk11u-dev/commit/d98b4607e73d74b4b4f77c5e6363486241156926 Stats: 602 lines in 2 files changed: 602 ins; 0 del; 0 mod 8317507: C2 compilation fails with "Exceeded _node_regs array" Reviewed-by: roland, andrew Backport-of: a5818972c16bd883d768ff2fb23a8aa9e0142c65 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2617 From duke at openjdk.org Wed Mar 27 08:48:31 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Wed, 27 Mar 2024 08:48:31 GMT Subject: [jdk11u-dev] RFR: 8261302: NMT: Improve malloc site table hashing In-Reply-To: References: Message-ID: <_F06EEAWjkoELMVElHvU6MiGA7pMKXlkcLW3vo-yP68=.3a8dd337-d55a-4ab3-94de-a292fc8b0fd3@github.com> On Mon, 18 Mar 2024 16:09:59 GMT, Mar?a Arias de Reyna wrote: > This is the same fix that was applied in https://github.com/openjdk/jdk/commit/a3d6e371 for https://bugs.openjdk.org/browse/JDK-8261302 > > It simplifies the way of calculating the hash of a stack. No problem, I will focus on newer versions of OpenJDK :) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2608#issuecomment-2022226108 From duke at openjdk.org Wed Mar 27 08:48:31 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Wed, 27 Mar 2024 08:48:31 GMT Subject: [jdk11u-dev] Withdrawn: 8261302: NMT: Improve malloc site table hashing In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 16:09:59 GMT, Mar?a Arias de Reyna wrote: > This is the same fix that was applied in https://github.com/openjdk/jdk/commit/a3d6e371 for https://bugs.openjdk.org/browse/JDK-8261302 > > It simplifies the way of calculating the hash of a stack. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2608 From goetz at openjdk.org Wed Mar 27 09:07:59 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 09:07:59 GMT Subject: [jdk17u-dev] RFR: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains Message-ID: I had to do some trivial resolves. I add some refactorings from "8262912: ciReplay: replay does not simulate unresolved classes" to the edited test files to make the test compile. I also had to fix the path to WhiteBox. I also added two methods to query names to ciEnv from "8271911: replay compilations of methods which use JSR292 (easy cases)". this calls further into dyno_name(). I disabled this, it is not needed as long as 8262912 is not backported. Test reproduces the issue as expected. ------------- Commit messages: - Make hotspot compile by adding accessors from 8271911 - Make test compile with parts from 88262912 - Backport 5bb1992b8408a0d196b1afa308bc00d007458dbd Changes: https://git.openjdk.org/jdk17u-dev/pull/2334/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2334&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8275868 Stats: 466 lines in 6 files changed: 461 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2334.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2334/head:pull/2334 PR: https://git.openjdk.org/jdk17u-dev/pull/2334 From goetz at openjdk.org Wed Mar 27 09:16:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 09:16:42 GMT Subject: [jdk17u-dev] RFR: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868 Message-ID: I had to do a trivial resolve in ciReplay and adapt the path to WhiteBox in the test. Follow up for 8275868. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/2334 Commit messages: - Backport a1f4c428ba1b78a4e18afb87c94a5c731a5aa706 Changes: https://git.openjdk.org/jdk17u-dev/pull/2335/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2335&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8276227 Stats: 81 lines in 2 files changed: 80 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2335.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2335/head:pull/2335 PR: https://git.openjdk.org/jdk17u-dev/pull/2335 From shade at openjdk.org Wed Mar 27 09:19:26 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 27 Mar 2024 09:19:26 GMT Subject: [jdk17u-dev] RFR: 8328825: Google CAInterop test failures In-Reply-To: <4IXMpRcnF4_u1ZRqv6Dt27rWMPgFNIL95SBt2nSw3rg=.d8bc051d-a2f7-49f5-a308-2aea9afa0297@github.com> References: <4IXMpRcnF4_u1ZRqv6Dt27rWMPgFNIL95SBt2nSw3rg=.d8bc051d-a2f7-49f5-a308-2aea9afa0297@github.com> Message-ID: On Mon, 25 Mar 2024 20:41:21 GMT, Aleksey Shipilev wrote: > Clean backport to fix some of the current failures in `CAInterop` test. > > Additional testing: > - [x] Affected subtests are now passing Thanks! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2330#issuecomment-2022278718 From shade at openjdk.org Wed Mar 27 09:19:26 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 27 Mar 2024 09:19:26 GMT Subject: [jdk17u-dev] Integrated: 8328825: Google CAInterop test failures In-Reply-To: <4IXMpRcnF4_u1ZRqv6Dt27rWMPgFNIL95SBt2nSw3rg=.d8bc051d-a2f7-49f5-a308-2aea9afa0297@github.com> References: <4IXMpRcnF4_u1ZRqv6Dt27rWMPgFNIL95SBt2nSw3rg=.d8bc051d-a2f7-49f5-a308-2aea9afa0297@github.com> Message-ID: On Mon, 25 Mar 2024 20:41:21 GMT, Aleksey Shipilev wrote: > Clean backport to fix some of the current failures in `CAInterop` test. > > Additional testing: > - [x] Affected subtests are now passing This pull request has now been integrated. Changeset: 91ac0856 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/91ac08560269176c58b43109f9235b86217a897b Stats: 10 lines in 1 file changed: 0 ins; 5 del; 5 mod 8328825: Google CAInterop test failures Backport-of: 70a15c73638f45b9ed629abc0ea2d86a324bf624 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2330 From goetz at openjdk.org Wed Mar 27 10:05:24 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 10:05:24 GMT Subject: [jdk17u-dev] Integrated: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm" In-Reply-To: References: Message-ID: On Mon, 25 Mar 2024 14:26:31 GMT, Goetz Lindenmaier wrote: > I backport this because we see it failing in our CI. This pull request has now been integrated. Changeset: f52725d4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f52725d4dd2c81242d47437e382b053086290097 Stats: 19 lines in 1 file changed: 9 ins; 4 del; 6 mod 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm" Backport-of: 66520be7a752ebade6c88d164bc87c4bfcfce40a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2325 From goetz at openjdk.org Wed Mar 27 10:05:28 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 10:05:28 GMT Subject: [jdk21u-dev] Integrated: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm" In-Reply-To: <4QpZ-uWKC8N0puveOx-JCg3sRn_86eONpf6Q8BoUXLY=.62e7548c-dde4-4784-b006-d1fa943abec6@github.com> References: <4QpZ-uWKC8N0puveOx-JCg3sRn_86eONpf6Q8BoUXLY=.62e7548c-dde4-4784-b006-d1fa943abec6@github.com> Message-ID: On Mon, 25 Mar 2024 14:25:20 GMT, Goetz Lindenmaier wrote: > I backport this as we see the issue in our CI. This pull request has now been integrated. Changeset: e3f36477 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/e3f36477d4a8b2831580fde423fdd748f367e93e Stats: 19 lines in 1 file changed: 9 ins; 4 del; 6 mod 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm" Backport-of: 66520be7a752ebade6c88d164bc87c4bfcfce40a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/406 From andrewlu at openjdk.org Wed Mar 27 10:05:47 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 27 Mar 2024 10:05:47 GMT Subject: [jdk21u-dev] RFR: 8323994: gtest runner repeats test name for every single gtest assertion Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 1aae980c549741cf5fc5ca51f3c299285bafa49d Changes: https://git.openjdk.org/jdk21u-dev/pull/412/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=412&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323994 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/412.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/412/head:pull/412 PR: https://git.openjdk.org/jdk21u-dev/pull/412 From andrewlu at openjdk.org Wed Mar 27 10:06:37 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 27 Mar 2024 10:06:37 GMT Subject: [jdk17u-dev] RFR: 8323994: gtest runner repeats test name for every single gtest assertion Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 1aae980c549741cf5fc5ca51f3c299285bafa49d Changes: https://git.openjdk.org/jdk17u-dev/pull/2336/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2336&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323994 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2336.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2336/head:pull/2336 PR: https://git.openjdk.org/jdk17u-dev/pull/2336 From goetz at openjdk.org Wed Mar 27 10:42:35 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 10:42:35 GMT Subject: [jdk11u-dev] RFR: 8320005: Allow loading of shared objects with .a extension on AIX In-Reply-To: References: Message-ID: On Mon, 25 Mar 2024 18:04:06 GMT, Suchismith Roy wrote: > Hi all, > > This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. > > Thanks! Hi @suchismith1993, I removed your label, please first backport to 17. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2622#issuecomment-2022438964 From goetz at openjdk.org Wed Mar 27 11:44:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 11:44:55 GMT Subject: [jdk11u-dev] RFR: 8256660: Disable DTLS 1.0 [v2] In-Reply-To: <41yjdMURxPew-w2Mn4Q8dJHb3XxlYJ3ll8-12mJI_uI=.1ac37c01-240d-4189-913b-e76fc09e9888@github.com> References: <41yjdMURxPew-w2Mn4Q8dJHb3XxlYJ3ll8-12mJI_uI=.1ac37c01-240d-4189-913b-e76fc09e9888@github.com> Message-ID: > I backport this for parity with 11.0.24-oracle. > > Trivial resolve in java.security Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'upstream/master' into goetz_backport_8256660 - Backport 16744b34498e7aac59caef8c9b1a3d4d15f8c22e ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2584/files - new: https://git.openjdk.org/jdk11u-dev/pull/2584/files/f00ba25f..70c4afd6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2584&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2584&range=00-01 Stats: 9460 lines in 125 files changed: 6564 ins; 1723 del; 1173 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2584.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2584/head:pull/2584 PR: https://git.openjdk.org/jdk11u-dev/pull/2584 From goetz at openjdk.org Wed Mar 27 12:24:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 12:24:53 GMT Subject: [jdk11u-dev] RFR: 8243010: Test support: Customizable Hex Printer Message-ID: I backport this to streamline the jdk11u testing suite. makes later backports cleaner. Only trivial adaptions needed: test/jdk/sun/security/pkcs/pkcs8/PKCS8Test.java Copyright test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketKeyLimit.java Copyright, line break. I had to adapt a switch statement to Java 11. See extra commit. ------------- Commit messages: - Adapt to Jva 11 - Backport bdf672659cee13d95abc246de7cde469cf8fc07d Changes: https://git.openjdk.org/jdk11u-dev/pull/2627/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2627&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8243010 Stats: 1662 lines in 15 files changed: 1604 ins; 16 del; 42 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2627.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2627/head:pull/2627 PR: https://git.openjdk.org/jdk11u-dev/pull/2627 From sroy at openjdk.org Wed Mar 27 12:32:30 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Wed, 27 Mar 2024 12:32:30 GMT Subject: [jdk11u-dev] RFR: 8320005: Allow loading of shared objects with .a extension on AIX In-Reply-To: References: Message-ID: On Wed, 27 Mar 2024 10:39:33 GMT, Goetz Lindenmaier wrote: >> Hi all, >> >> This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. >> >> Thanks! > > Hi @suchismith1993, I removed your label, please first backport to 17. @GoeLin the backport for jdk17-udev is already there for review. For multiple line changes i think it went in for a review. https://github.com/openjdk/jdk17u-dev/pull/2332/ ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2622#issuecomment-2022648756 From sroy at openjdk.org Wed Mar 27 12:32:50 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Wed, 27 Mar 2024 12:32:50 GMT Subject: [jdk17u-dev] RFR: 8320005: Allow loading of shared objects with .a extension on AIX [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. > > Thanks! Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: Update os_aix.cpp Restore comments. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2332/files - new: https://git.openjdk.org/jdk17u-dev/pull/2332/files/8d9ee5a8..463e01bd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2332&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2332&range=00-01 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2332.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2332/head:pull/2332 PR: https://git.openjdk.org/jdk17u-dev/pull/2332 From goetz at openjdk.org Wed Mar 27 12:50:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 12:50:51 GMT Subject: [jdk11u-dev] RFR: 8243010: Test support: Customizable Hex Printer [v2] In-Reply-To: References: Message-ID: > I backport this to streamline the jdk11u testing suite. makes later backports cleaner. > > Only trivial adaptions needed: > test/jdk/sun/security/pkcs/pkcs8/PKCS8Test.java > Copyright > test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketKeyLimit.java > Copyright, line break. > > I had to adapt a switch statement to Java 11. See extra commit. > > I adapted TEST.ROOT to require 7.3.1 which is standard for 11 currently Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Add forgotten file ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2627/files - new: https://git.openjdk.org/jdk11u-dev/pull/2627/files/5346405c..539d3ced Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2627&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2627&range=00-01 Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2627.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2627/head:pull/2627 PR: https://git.openjdk.org/jdk11u-dev/pull/2627 From goetz at openjdk.org Wed Mar 27 13:02:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 13:02:39 GMT Subject: [jdk11u-dev] RFR: 8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out Message-ID: <15e1slDE63kZeQx1rSjc15mj36IuSCSug8wUhuWPhoo=.0ec1e737-4d53-4f99-bdfa-8e1d939b9855@github.com> I backport this to streamline the tests in 11. The patch applies clean, but I had to adapt it to Java 11. DTLSOverDatagram.java is refactored to use recoreds, I just reverted this. I also removed -> from switch statments. ------------- Commit messages: - Adapt to Java 11 - Backport 79adc16fd8ba47a8d9438f3467f92ab241766c1d - Add forgotten file - Adapt to Jva 11 - Backport bdf672659cee13d95abc246de7cde469cf8fc07d Changes: https://git.openjdk.org/jdk11u-dev/pull/2628/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2628&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8264152 Stats: 1946 lines in 18 files changed: 1690 ins; 120 del; 136 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2628.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2628/head:pull/2628 PR: https://git.openjdk.org/jdk11u-dev/pull/2628 From goetz at openjdk.org Wed Mar 27 13:14:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 13:14:41 GMT Subject: [jdk11u-dev] RFR: 8297798: Timeout with DTLSOverDatagram test template Message-ID: <6ckoY9233HkIPZKjcRkv-uqWbQnCIArjTQdixVjDJ4Q=.18ee4c9c-00b8-4a6d-8174-7532f7e4d9bf@github.com> I backport this to streamline testing based on the change in 17. I had to resolve DTLSOverDatagram because the code in 11 uses classes, where the code in 17 uses records. The added code is identical in 11 and 17. Tests pass. ------------- Commit messages: - Backport 23457a664ce00de33fdb6846ff31f489e6dd2177 - Adapt to Java 11 - Backport 79adc16fd8ba47a8d9438f3467f92ab241766c1d - Add forgotten file - Adapt to Jva 11 - Backport bdf672659cee13d95abc246de7cde469cf8fc07d Changes: https://git.openjdk.org/jdk11u-dev/pull/2629/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2629&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297798 Stats: 2102 lines in 19 files changed: 1699 ins; 205 del; 198 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2629.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2629/head:pull/2629 PR: https://git.openjdk.org/jdk11u-dev/pull/2629 From goetz at openjdk.org Wed Mar 27 13:24:49 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 13:24:49 GMT Subject: [jdk11u-dev] RFR: 8297798: Timeout with DTLSOverDatagram test template [v2] In-Reply-To: <6ckoY9233HkIPZKjcRkv-uqWbQnCIArjTQdixVjDJ4Q=.18ee4c9c-00b8-4a6d-8174-7532f7e4d9bf@github.com> References: <6ckoY9233HkIPZKjcRkv-uqWbQnCIArjTQdixVjDJ4Q=.18ee4c9c-00b8-4a6d-8174-7532f7e4d9bf@github.com> Message-ID: > I backport this to streamline testing based on the change in 17. > > I had to resolve DTLSOverDatagram because the code in 11 uses classes, where the code in 17 uses records. > The added code is identical in 11 and 17. > > Tests pass. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2629/files - new: https://git.openjdk.org/jdk11u-dev/pull/2629/files/10191f66..10191f66 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2629&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2629&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2629.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2629/head:pull/2629 PR: https://git.openjdk.org/jdk11u-dev/pull/2629 From mbaesken at openjdk.org Wed Mar 27 13:52:27 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 27 Mar 2024 13:52:27 GMT Subject: [jdk11u-dev] RFR: 8243010: Test support: Customizable Hex Printer [v2] In-Reply-To: References: Message-ID: On Wed, 27 Mar 2024 12:50:51 GMT, Goetz Lindenmaier wrote: >> I backport this to streamline the jdk11u testing suite. makes later backports cleaner. >> >> Only trivial adaptions needed: >> test/jdk/sun/security/pkcs/pkcs8/PKCS8Test.java >> Copyright >> test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketKeyLimit.java >> Copyright, line break. >> >> I had to adapt a switch statement to Java 11. See extra commit. >> >> I adapted TEST.ROOT to require 7.3.1 which is standard for 11 currently > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Add forgotten file LGTM ------------- Marked as reviewed by mbaesken (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2627#pullrequestreview-1963395354 From mbaesken at openjdk.org Wed Mar 27 13:56:23 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 27 Mar 2024 13:56:23 GMT Subject: [jdk11u-dev] RFR: 8297798: Timeout with DTLSOverDatagram test template [v2] In-Reply-To: References: <6ckoY9233HkIPZKjcRkv-uqWbQnCIArjTQdixVjDJ4Q=.18ee4c9c-00b8-4a6d-8174-7532f7e4d9bf@github.com> Message-ID: <4DkL3DtVi14TiwZgzelR0lo3Os4puvw0tuGdSEiNtr0=.db32f0d8-a1d3-40a3-ab80-eca91006a6da@github.com> On Wed, 27 Mar 2024 13:24:49 GMT, Goetz Lindenmaier wrote: >> I backport this to streamline testing based on the change in 17. >> >> I had to resolve DTLSOverDatagram because the code in 11 uses classes, where the code in 17 uses records. >> The added code is identical in 11 and 17. >> >> Tests pass. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2629#pullrequestreview-1963407110 From lucy at openjdk.org Wed Mar 27 15:00:31 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Wed, 27 Mar 2024 15:00:31 GMT Subject: [jdk11u-dev] RFR: 8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out In-Reply-To: <15e1slDE63kZeQx1rSjc15mj36IuSCSug8wUhuWPhoo=.0ec1e737-4d53-4f99-bdfa-8e1d939b9855@github.com> References: <15e1slDE63kZeQx1rSjc15mj36IuSCSug8wUhuWPhoo=.0ec1e737-4d53-4f99-bdfa-8e1d939b9855@github.com> Message-ID: On Wed, 27 Mar 2024 12:58:53 GMT, Goetz Lindenmaier wrote: > I backport this to streamline the tests in 11. > > The patch applies clean, but I had to adapt it to Java 11. > > DTLSOverDatagram.java is refactored to use recoreds, I just reverted this. > I also removed -> from switch statments. LGTM. Rather huge backport. Please make sure all tests complete OK. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2628#pullrequestreview-1963610549 From mdoerr at openjdk.org Wed Mar 27 15:05:25 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 27 Mar 2024 15:05:25 GMT Subject: [jdk17u-dev] RFR: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains In-Reply-To: References: Message-ID: On Wed, 27 Mar 2024 09:01:21 GMT, Goetz Lindenmaier wrote: > I had to do some trivial resolves. > > I add some refactorings from "8262912: ciReplay: replay does not simulate unresolved classes" > to the edited test files to make the test compile. I also had to fix the path to WhiteBox. > > I also added two methods to query names to ciEnv from > "8271911: replay compilations of methods which use JSR292 (easy cases)". > this calls further into dyno_name(). I disabled this, it is not needed as long as 8262912 is not backported. > > Test reproduces the issue as expected. > > For follow up 8276227 see dependent pull request. Looks basically good. Please see my suggestions. src/hotspot/share/ci/ciEnv.cpp line 1201: > 1199: // Returns the class name as a fallback if no location is found. > 1200: const char *ciEnv::replay_name(const InstanceKlass* ik) const { > 1201: const char* name = nullptr; // dyno_name(ik); I'd appreciate to have a comment why `dyno_name(ik)` is commented out. Maybe "JDK-8271911 is not in JDK 17, so we fall back to using the class name below." test/hotspot/jtreg/compiler/ciReplay/CiReplayBase.java line 163: > 161: if (needCoreDump) { > 162: // CiReplayBase$TestMain needs to be quoted because of shell eval > 163: options.add("-XX:CompileOnly='" + TestMain.class.getName() + "::" + getTestMethod() + "'"); Shouldn't we use your new `getTestClass()` from your 2nd commit? test/hotspot/jtreg/compiler/ciReplay/CiReplayBase.java line 169: > 167: ProcessTools.createTestJvm(options.toArray(new String[0])))); > 168: } else { > 169: options.add("-XX:CompileOnly=" + TestMain.class.getName() + "::" + getTestMethod()); Same here. ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2334#pullrequestreview-1963604200 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2334#discussion_r1541295591 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2334#discussion_r1541285548 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2334#discussion_r1541286687 From mdoerr at openjdk.org Wed Mar 27 15:23:27 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 27 Mar 2024 15:23:27 GMT Subject: [jdk17u-dev] RFR: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868 In-Reply-To: References: Message-ID: <18FqH7-guFNUzfQz5koZQCZDbk6ZsnTOEAm-bAneaq0=.c8706e85-7573-429f-952d-51c831c97aaf@github.com> On Wed, 27 Mar 2024 09:12:20 GMT, Goetz Lindenmaier wrote: > I had to do a trivial resolve in ciReplay and adapt the path to WhiteBox in the test. > > Follow up for 8275868. LGTM. Please consider inserting the empty line before integrating. src/hotspot/share/ci/ciReplay.cpp line 696: > 694: // in signatures of inlinees. This ensures that inlining can be done as stated in the replay file. > 695: _protection_domain = Handle(_thread, k->protection_domain()); > 696: } Original change inserts an empty line, here. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2335#pullrequestreview-1963675159 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2335#discussion_r1541328403 From duke at openjdk.org Wed Mar 27 15:29:48 2024 From: duke at openjdk.org (Soumadipta Roy) Date: Wed, 27 Mar 2024 15:29:48 GMT Subject: [jdk17u-dev] RFR: 8316608: Enable parallelism in vmTestbase/gc/vector tests Message-ID: <3jyXivh0ru7nb35uraGo0ZvdrzmgQ6ilO006FrAXs_M=.42b79163-48ae-440b-aa10-e3197cd71026@github.com> Backporting the fix for https://bugs.openjdk.org/browse/JDK-8316608 merged as part of openjdk/jdk#16028. https://github.com/openjdk/jdk/commit/f61499c73fe03e2e3680d7f58a84183364c5c5ac.patch could be applied cleanly. Run details on AL2_x86_64: before: 3518.69s user 84.97s system 840% cpu 7:08.71 total after: 6176.30s user 112.25s system 3753% cpu 2:47.54 total before: 1373.06s user 135.80s system 373% cpu 6:44.35 total after: 4479.07s user 305.63s system 3370% cpu 2:21.95 total ------------- Commit messages: - Backport f61499c73fe03e2e3680d7f58a84183364c5c5ac Changes: https://git.openjdk.org/jdk17u-dev/pull/2337/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2337&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316608 Stats: 299 lines in 13 files changed: 0 ins; 299 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2337.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2337/head:pull/2337 PR: https://git.openjdk.org/jdk17u-dev/pull/2337 From goetz at openjdk.org Wed Mar 27 15:46:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 15:46:43 GMT Subject: [jdk17u-dev] RFR: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains [v2] In-Reply-To: References: Message-ID: > I had to do some trivial resolves. > > I add some refactorings from "8262912: ciReplay: replay does not simulate unresolved classes" > to the edited test files to make the test compile. I also had to fix the path to WhiteBox. > > I also added two methods to query names to ciEnv from > "8271911: replay compilations of methods which use JSR292 (easy cases)". > this calls further into dyno_name(). I disabled this, it is not needed as long as 8262912 is not backported. > > Test reproduces the issue as expected. > > For follow up 8276227 see dependent pull request. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Add comment. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2334/files - new: https://git.openjdk.org/jdk17u-dev/pull/2334/files/60bf4ada..a7b0185e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2334&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2334&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2334.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2334/head:pull/2334 PR: https://git.openjdk.org/jdk17u-dev/pull/2334 From goetz at openjdk.org Wed Mar 27 15:46:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 15:46:43 GMT Subject: [jdk17u-dev] RFR: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains [v2] In-Reply-To: References: Message-ID: <-Sq5s1_zCTd4s6LJ4Y70DP6FLzu1HG6E2uWM9DwsEkw=.c06297b7-fe0c-4c87-9a30-1962162c1af9@github.com> On Wed, 27 Mar 2024 14:55:56 GMT, Martin Doerr wrote: >> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: >> >> Add comment. > > test/hotspot/jtreg/compiler/ciReplay/CiReplayBase.java line 163: > >> 161: if (needCoreDump) { >> 162: // CiReplayBase$TestMain needs to be quoted because of shell eval >> 163: options.add("-XX:CompileOnly='" + TestMain.class.getName() + "::" + getTestMethod() + "'"); > > Shouldn't we use your new `getTestClass()` from your 2nd commit? I wanted to leave that to the potential backport of 8262912. It's not needed for the purpose of this change. Same below. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2334#discussion_r1541370091 From goetz at openjdk.org Wed Mar 27 15:50:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 15:50:48 GMT Subject: [jdk17u-dev] RFR: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868 [v2] In-Reply-To: References: Message-ID: > I had to do a trivial resolve in ciReplay and adapt the path to WhiteBox in the test. > > Follow up for 8275868. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Add empty line ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2335/files - new: https://git.openjdk.org/jdk17u-dev/pull/2335/files/83ace890..372116be Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2335&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2335&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2335.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2335/head:pull/2335 PR: https://git.openjdk.org/jdk17u-dev/pull/2335 From goetz at openjdk.org Wed Mar 27 15:50:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 15:50:48 GMT Subject: [jdk17u-dev] RFR: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868 [v2] In-Reply-To: <18FqH7-guFNUzfQz5koZQCZDbk6ZsnTOEAm-bAneaq0=.c8706e85-7573-429f-952d-51c831c97aaf@github.com> References: <18FqH7-guFNUzfQz5koZQCZDbk6ZsnTOEAm-bAneaq0=.c8706e85-7573-429f-952d-51c831c97aaf@github.com> Message-ID: On Wed, 27 Mar 2024 15:20:15 GMT, Martin Doerr wrote: >> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: >> >> Add empty line > > src/hotspot/share/ci/ciReplay.cpp line 696: > >> 694: // in signatures of inlinees. This ensures that inlining can be done as stated in the replay file. >> 695: _protection_domain = Handle(_thread, k->protection_domain()); >> 696: } > > Original change inserts an empty line, here. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2335#discussion_r1541376441 From duke at openjdk.org Wed Mar 27 15:55:42 2024 From: duke at openjdk.org (Elif Aslan) Date: Wed, 27 Mar 2024 15:55:42 GMT Subject: [jdk17u-dev] RFR: 8325567: jspawnhelper without args fails with segfault Message-ID: Clean backport.Testing is in progress ------------- Commit messages: - Backport 262747094670b00ac63463a059074afa9b81d8a4 Changes: https://git.openjdk.org/jdk17u-dev/pull/2339/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2339&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325567 Stats: 62 lines in 2 files changed: 62 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2339.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2339/head:pull/2339 PR: https://git.openjdk.org/jdk17u-dev/pull/2339 From mdoerr at openjdk.org Wed Mar 27 15:56:24 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 27 Mar 2024 15:56:24 GMT Subject: [jdk17u-dev] RFR: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains [v2] In-Reply-To: References: Message-ID: <2tKbXKrzpPqP8pOkGtJpdSq8-3Up1ak2A_NaxMdTno4=.00cb2612-a6f7-402b-9b36-d6c8b2f5aa08@github.com> On Wed, 27 Mar 2024 15:46:43 GMT, Goetz Lindenmaier wrote: >> I had to do some trivial resolves. >> >> I add some refactorings from "8262912: ciReplay: replay does not simulate unresolved classes" >> to the edited test files to make the test compile. I also had to fix the path to WhiteBox. >> >> I also added two methods to query names to ciEnv from >> "8271911: replay compilations of methods which use JSR292 (easy cases)". >> this calls further into dyno_name(). I disabled this, it is not needed as long as 8262912 is not backported. >> >> Test reproduces the issue as expected. >> >> For follow up 8276227 see dependent pull request. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Add comment. Ok. Thanks for the update. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2334#pullrequestreview-1963766598 From duke at openjdk.org Wed Mar 27 15:56:39 2024 From: duke at openjdk.org (Elif Aslan) Date: Wed, 27 Mar 2024 15:56:39 GMT Subject: [jdk17u-dev] RFR: 8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests Message-ID: Clean backport. Testing is in progress ------------- Commit messages: - Backport 29d462a07239a57b83850b9a8662573291fdbdf7 Changes: https://git.openjdk.org/jdk17u-dev/pull/2341/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2341&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318727 Stats: 943 lines in 41 files changed: 0 ins; 943 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2341.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2341/head:pull/2341 PR: https://git.openjdk.org/jdk17u-dev/pull/2341 From duke at openjdk.org Wed Mar 27 15:57:38 2024 From: duke at openjdk.org (Elif Aslan) Date: Wed, 27 Mar 2024 15:57:38 GMT Subject: [jdk17u-dev] RFR: 8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac Message-ID: Clean backport. Testing is in progress ------------- Commit messages: - Backport cc1800fa4de3c1369efd46f5ca967ea82763f5d5 Changes: https://git.openjdk.org/jdk17u-dev/pull/2340/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2340&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327998 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2340.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2340/head:pull/2340 PR: https://git.openjdk.org/jdk17u-dev/pull/2340 From duke at openjdk.org Wed Mar 27 15:59:35 2024 From: duke at openjdk.org (Elif Aslan) Date: Wed, 27 Mar 2024 15:59:35 GMT Subject: [jdk21u-dev] RFR: 8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac Message-ID: <58W_9C0vjKtPcMD_5YFV-oSsFqKlBXlkmxHlqC9G-UQ=.dcd196ff-6738-47ef-87c3-347a2d4ae263@github.com> Clean backport. Testing is in progress ------------- Commit messages: - Backport cc1800fa4de3c1369efd46f5ca967ea82763f5d5 Changes: https://git.openjdk.org/jdk21u-dev/pull/415/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=415&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327998 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/415.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/415/head:pull/415 PR: https://git.openjdk.org/jdk21u-dev/pull/415 From duke at openjdk.org Wed Mar 27 15:59:45 2024 From: duke at openjdk.org (Elif Aslan) Date: Wed, 27 Mar 2024 15:59:45 GMT Subject: [jdk21u-dev] RFR: 8325567: jspawnhelper without args fails with segfault Message-ID: Clean backport. Testing is in progress ------------- Commit messages: - Backport 262747094670b00ac63463a059074afa9b81d8a4 Changes: https://git.openjdk.org/jdk21u-dev/pull/414/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=414&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325567 Stats: 62 lines in 2 files changed: 62 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/414.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/414/head:pull/414 PR: https://git.openjdk.org/jdk21u-dev/pull/414 From duke at openjdk.org Wed Mar 27 16:00:45 2024 From: duke at openjdk.org (Elif Aslan) Date: Wed, 27 Mar 2024 16:00:45 GMT Subject: [jdk21u-dev] RFR: 8311823: JFR: Uninitialized EventEmitter::_thread_id field Message-ID: Clean backport. Testing is in progress ------------- Commit messages: - Backport 9688ec2d0d9fd830d993454ea093b68b0f85ebe7 Changes: https://git.openjdk.org/jdk21u-dev/pull/417/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=417&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311823 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/417.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/417/head:pull/417 PR: https://git.openjdk.org/jdk21u-dev/pull/417 From duke at openjdk.org Wed Mar 27 16:00:49 2024 From: duke at openjdk.org (Elif Aslan) Date: Wed, 27 Mar 2024 16:00:49 GMT Subject: [jdk21u-dev] RFR: 8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests Message-ID: Clean backport. Testing is in progress ------------- Commit messages: - Backport 29d462a07239a57b83850b9a8662573291fdbdf7 Changes: https://git.openjdk.org/jdk21u-dev/pull/416/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=416&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318727 Stats: 943 lines in 41 files changed: 0 ins; 943 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/416.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/416/head:pull/416 PR: https://git.openjdk.org/jdk21u-dev/pull/416 From duke at openjdk.org Wed Mar 27 16:17:57 2024 From: duke at openjdk.org (Soumadipta Roy) Date: Wed, 27 Mar 2024 16:17:57 GMT Subject: [jdk21u] RFR: 8316608: Enable parallelism in vmTestbase/gc/vector tests Message-ID: <1T7dQ3DzxiirIvp-UQMM8UPXyhKbh8L-5JdEPmwXDYw=.74496685-1e5f-4a8b-832d-c819dbd8ad17@github.com> Backporting the fix for https://bugs.openjdk.org/browse/JDK-8316608 merged as part of openjdk/jdk#16028. https://github.com/openjdk/jdk/commit/f61499c73fe03e2e3680d7f58a84183364c5c5ac.patch could be applied cleanly. Run details on AL2_x86_64: #Fastdebug before: 3518.69s user 84.97s system 840% cpu 7:08.71 total after: 2241.98s user 61.99s system 2617% cpu 1:28.03 total #Release before: 1367.16s user 134.95s system 371% cpu 6:44.67 total after: 1206.90s user 114.48s system 2548% cpu 51.848 total ------------- Commit messages: - Backport f61499c73fe03e2e3680d7f58a84183364c5c5ac Changes: https://git.openjdk.org/jdk21u/pull/443/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=443&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316608 Stats: 299 lines in 13 files changed: 0 ins; 299 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/443.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/443/head:pull/443 PR: https://git.openjdk.org/jdk21u/pull/443 From sgehwolf at openjdk.org Wed Mar 27 16:20:28 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 27 Mar 2024 16:20:28 GMT Subject: [jdk17u-dev] RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 09:59:57 GMT, Mar?a Arias de Reyna wrote: > Do we need more testing here? I don't think we do. We [have positive tier 1-3 results](https://github.com/adoptium/aqa-tests/issues/5137#issuecomment-1997362685) and the regression test. It fixes a real bug. Patch is reviewed, even though it's clean. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2235#issuecomment-2023176510 From shade at openjdk.org Wed Mar 27 16:25:23 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 27 Mar 2024 16:25:23 GMT Subject: [jdk21u] RFR: 8316608: Enable parallelism in vmTestbase/gc/vector tests In-Reply-To: <1T7dQ3DzxiirIvp-UQMM8UPXyhKbh8L-5JdEPmwXDYw=.74496685-1e5f-4a8b-832d-c819dbd8ad17@github.com> References: <1T7dQ3DzxiirIvp-UQMM8UPXyhKbh8L-5JdEPmwXDYw=.74496685-1e5f-4a8b-832d-c819dbd8ad17@github.com> Message-ID: On Wed, 27 Mar 2024 16:11:17 GMT, Soumadipta Roy wrote: > Backporting the fix for https://bugs.openjdk.org/browse/JDK-8316608 merged as part of openjdk/jdk#16028. > https://github.com/openjdk/jdk/commit/f61499c73fe03e2e3680d7f58a84183364c5c5ac.patch could be applied cleanly. > > Run details on AL2_x86_64: > > #Fastdebug > before: 3518.69s user 84.97s system 840% cpu 7:08.71 total > after: 2241.98s user 61.99s system 2617% cpu 1:28.03 total > > #Release > before: 1367.16s user 134.95s system 371% cpu 6:44.67 total > after: 1206.90s user 114.48s system 2548% cpu 51.848 total Hold on, this is a wrong repository. I think the PR should go to jdk21u-dev, not jdk21u :) ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/443#issuecomment-2023187430 From sgehwolf at openjdk.org Wed Mar 27 16:25:24 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 27 Mar 2024 16:25:24 GMT Subject: [jdk21u] RFR: 8316608: Enable parallelism in vmTestbase/gc/vector tests In-Reply-To: References: <1T7dQ3DzxiirIvp-UQMM8UPXyhKbh8L-5JdEPmwXDYw=.74496685-1e5f-4a8b-832d-c819dbd8ad17@github.com> Message-ID: On Wed, 27 Mar 2024 16:21:48 GMT, Aleksey Shipilev wrote: > Hold on, this is a wrong repository. I think the PR should go to jdk21u-dev, not jdk21u :) Indeed. This doesn't qualify as a critical fix. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/443#issuecomment-2023191729 From duke at openjdk.org Wed Mar 27 16:33:33 2024 From: duke at openjdk.org (Soumadipta Roy) Date: Wed, 27 Mar 2024 16:33:33 GMT Subject: [jdk21u] Withdrawn: 8316608: Enable parallelism in vmTestbase/gc/vector tests In-Reply-To: <1T7dQ3DzxiirIvp-UQMM8UPXyhKbh8L-5JdEPmwXDYw=.74496685-1e5f-4a8b-832d-c819dbd8ad17@github.com> References: <1T7dQ3DzxiirIvp-UQMM8UPXyhKbh8L-5JdEPmwXDYw=.74496685-1e5f-4a8b-832d-c819dbd8ad17@github.com> Message-ID: On Wed, 27 Mar 2024 16:11:17 GMT, Soumadipta Roy wrote: > Backporting the fix for https://bugs.openjdk.org/browse/JDK-8316608 merged as part of openjdk/jdk#16028. > https://github.com/openjdk/jdk/commit/f61499c73fe03e2e3680d7f58a84183364c5c5ac.patch could be applied cleanly. > > Run details on AL2_x86_64: > > #Fastdebug > before: 3518.69s user 84.97s system 840% cpu 7:08.71 total > after: 2241.98s user 61.99s system 2617% cpu 1:28.03 total > > #Release > before: 1367.16s user 134.95s system 371% cpu 6:44.67 total > after: 1206.90s user 114.48s system 2548% cpu 51.848 total This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u/pull/443 From duke at openjdk.org Wed Mar 27 16:38:32 2024 From: duke at openjdk.org (Soumadipta Roy) Date: Wed, 27 Mar 2024 16:38:32 GMT Subject: [jdk21u-dev] RFR: 8316608: Enable parallelism in vmTestbase/gc/vector tests Message-ID: <6l55_q6dcVfgIccVifLYF05APsRgXz7rKoNfyiHPg70=.a2b82839-65c9-4a52-a762-2dd73e1a5f3a@github.com> Backporting the fix for https://bugs.openjdk.org/browse/JDK-8316608 merged as part of openjdk/jdk#16028. https://github.com/openjdk/jdk/commit/f61499c73fe03e2e3680d7f58a84183364c5c5ac.patch could be applied cleanly. Run details on AL2_x86_64: #Fastdebug before: 3518.69s user 84.97s system 840% cpu 7:08.71 total after: 2241.98s user 61.99s system 2617% cpu 1:28.03 total #Release before: 1367.16s user 134.95s system 371% cpu 6:44.67 total after: 1206.90s user 114.48s system 2548% cpu 51.848 total ------------- Commit messages: - Backport f61499c73fe03e2e3680d7f58a84183364c5c5ac Changes: https://git.openjdk.org/jdk21u-dev/pull/418/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=418&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316608 Stats: 299 lines in 13 files changed: 0 ins; 299 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/418.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/418/head:pull/418 PR: https://git.openjdk.org/jdk21u-dev/pull/418 From goetz at openjdk.org Wed Mar 27 16:39:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 27 Mar 2024 16:39:42 GMT Subject: [jdk17u-dev] RFR: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868 [v3] In-Reply-To: References: Message-ID: > I had to do a trivial resolve in ciReplay and adapt the path to WhiteBox in the test. > > Follow up for 8275868. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Fix whitespace ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2335/files - new: https://git.openjdk.org/jdk17u-dev/pull/2335/files/372116be..3a3124b2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2335&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2335&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2335.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2335/head:pull/2335 PR: https://git.openjdk.org/jdk17u-dev/pull/2335 From btaylor at openjdk.org Wed Mar 27 17:25:31 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 27 Mar 2024 17:25:31 GMT Subject: [jdk11u-dev] Integrated: 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned In-Reply-To: References: Message-ID: On Mon, 25 Mar 2024 23:33:14 GMT, Ben Taylor wrote: > Clean backport of JDK-8273831 to fix a regression that can leave an orphaned thread. Verified with included test. This pull request has now been integrated. Changeset: 41179534 Author: Ben Taylor URL: https://git.openjdk.org/jdk11u-dev/commit/4117953453635dbaea56add47a6fde5eb3f1258d Stats: 120 lines in 3 files changed: 104 ins; 3 del; 13 mod 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned Backport-of: 687567822a5380fb7d8c5b54ae548b2a5c848187 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2623 From duke at openjdk.org Wed Mar 27 17:31:40 2024 From: duke at openjdk.org (Soumadipta Roy) Date: Wed, 27 Mar 2024 17:31:40 GMT Subject: [jdk11u-dev] RFR: 8316608: Enable parallelism in vmTestbase/gc/vector tests Message-ID: Backporting the fix for https://bugs.openjdk.org/browse/JDK-8316608 merged as part of openjdk/jdk#16028. https://github.com/openjdk/jdk/commit/f61499c73fe03e2e3680d7f58a84183364c5c5ac.patch could be applied cleanly. Run details on AL2_x86_64: Fastdebug before: 4741.91s user 91.12s system 588% cpu 13:41.56 total after: 3451.17s user 43.90s system 3196% cpu 1:49.33 total Release 11 before: 2905.04s user 93.12s system 394% cpu 12:39.98 total after: 2745.40s user 57.49s system 3319% cpu 1:24.43 total ------------- Commit messages: - Backport f61499c73fe03e2e3680d7f58a84183364c5c5ac Changes: https://git.openjdk.org/jdk11u-dev/pull/2630/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2630&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316608 Stats: 299 lines in 13 files changed: 0 ins; 299 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2630.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2630/head:pull/2630 PR: https://git.openjdk.org/jdk11u-dev/pull/2630 From zhao.song at oracle.com Wed Mar 27 18:12:40 2024 From: zhao.song at oracle.com (Zhao Song) Date: Wed, 27 Mar 2024 18:12:40 +0000 Subject: Upcoming Enhancement to SKARA: CSR Check for Backport Pull Requests Message-ID: Hi All, There is an upcoming enhancement [1] to SKARA. The Skara bot will check if a CSR is potentially required for a backport pull request. Specifically, in a backport pull request, if any associated issues have a resolved CSR for a different fix version, the Skara bot will automatically add the "csr" label to the pull request and post a comment. If the "csr" label is applied to your pull request, your pull request will be blocked from integration until it is handled. To handle the "csr" label, you can either go through the CSR process [2], or reviewers of the project can issue the command "/csr unneeded" [3] to remove this requirement. Thanks, Zhao [1]https://bugs.openjdk.org/browse/SKARA-2198 [2]https://wiki.openjdk.org/display/csr/Main [3]https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/csr -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrewlu at openjdk.org Thu Mar 28 02:11:41 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 28 Mar 2024 02:11:41 GMT Subject: [jdk11u-dev] Integrated: 8210988: Improved handling of compiler warnings in the build In-Reply-To: References: Message-ID: On Mon, 18 Mar 2024 06:46:29 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. > make/hotspot/lib/CompileGtest.gmk > ?DISABLED_WARNINGS_microsoft := $(DISABLED_WARNINGS_microsoft) \ > 4146, \? > make/hotspot/lib/CompileJvm.gmk > DISABLED_WARNINGS_microsoft := $(DISABLED_WARNINGS_microsoft) 4146, \ > > The DISABLED_WARNINGS_microsoft change to 4146 as in src\hotspot\cpu\aarch64\register_aarch64.hpp(285) > 'uint32_t first = _bitset & -_bitset' remains. This pull request has now been integrated. Changeset: 29a08f77 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/29a08f77e8b1f98ffc6b34b5f3ecebad1424a712 Stats: 112 lines in 6 files changed: 72 ins; 15 del; 25 mod 8210988: Improved handling of compiler warnings in the build Reviewed-by: lucy Backport-of: 09a967ab8143c3d4b0824a0027edaf0e634686ec ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2606 From syan at openjdk.org Thu Mar 28 02:53:36 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 28 Mar 2024 02:53:36 GMT Subject: [jdk21u-dev] RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" Message-ID: Clean backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). Only change the testcase, the change has been verified, the risk is low. ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/a971b851-bc31-407a-b66e-0d8189deee9f) ------------- Commit messages: - Backport b6233c3de773fb57b23704f1fec05d8b2d9c11c0 Changes: https://git.openjdk.org/jdk21u-dev/pull/419/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=419&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321925 Stats: 23 lines in 1 file changed: 13 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/419.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/419/head:pull/419 PR: https://git.openjdk.org/jdk21u-dev/pull/419 From syan at openjdk.org Thu Mar 28 03:16:53 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 28 Mar 2024 03:16:53 GMT Subject: [jdk17u-dev] RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" Message-ID: <_wlIzpJsJthuDmb6fBJnltFyd3YG6Fp9-X7NjHKGcuI=.616d0b06-ef07-47dd-b1e0-bd2884b2dd71@github.com> Clean backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). Only change the testcase, the change has been verified, the risk is low. ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/17ae2a82-e34d-4713-b30d-6248fd04476d) ------------- Commit messages: - Backport b6233c3de773fb57b23704f1fec05d8b2d9c11c0 Changes: https://git.openjdk.org/jdk17u-dev/pull/2342/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2342&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321925 Stats: 23 lines in 1 file changed: 13 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2342.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2342/head:pull/2342 PR: https://git.openjdk.org/jdk17u-dev/pull/2342 From syan at openjdk.org Thu Mar 28 03:47:25 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 28 Mar 2024 03:47:25 GMT Subject: [jdk11u-dev] RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" Message-ID: Backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). The origin PR use `int nextInt(int origin, int bound)`, but the jdk11 do not have this API. So I change `int nextInt(int origin, int bound)` to `nextInt(bound - origin) + origin`. Only change the testcase, the change has been verified, the risk is low. ![image](https://github.com/openjdk/jdk11u-dev/assets/24123821/63c82beb-1c90-45b0-b8b7-6419cf111252) ------------- Commit messages: - Backport b6233c3de773fb57b23704f1fec05d8b2d9c11c0 Changes: https://git.openjdk.org/jdk11u-dev/pull/2631/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2631&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321925 Stats: 23 lines in 1 file changed: 13 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2631.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2631/head:pull/2631 PR: https://git.openjdk.org/jdk11u-dev/pull/2631 From duke at openjdk.org Thu Mar 28 04:04:38 2024 From: duke at openjdk.org (lusou-zhangquan) Date: Thu, 28 Mar 2024 04:04:38 GMT Subject: [jdk21u-dev] Withdrawn: 8324174: assert(m->is_entered(current)) failed: invariant In-Reply-To: References: Message-ID: On Wed, 6 Mar 2024 08:33:05 GMT, lusou-zhangquan wrote: > Clean backport from master to fix the incorrect lock and unlock order problem of nested locks during deoptimization. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/334 From andrewlu at openjdk.org Thu Mar 28 07:43:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 28 Mar 2024 07:43:06 GMT Subject: [jdk11u-dev] RFR: 8310923: Refactor Currency tests to use JUnit [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.24-oracle. > Clean except some code lines are different, so make it clean. Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: fix ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2625/files - new: https://git.openjdk.org/jdk11u-dev/pull/2625/files/50ac2bea..14c60deb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2625&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2625&range=01-02 Stats: 17 lines in 1 file changed: 1 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2625.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2625/head:pull/2625 PR: https://git.openjdk.org/jdk11u-dev/pull/2625 From andrewlu at openjdk.org Thu Mar 28 07:46:37 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 28 Mar 2024 07:46:37 GMT Subject: [jdk11u-dev] Withdrawn: 8310923: Refactor Currency tests to use JUnit In-Reply-To: References: Message-ID: On Tue, 26 Mar 2024 07:56:51 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. > Clean except some code lines are different, so make it clean. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2625 From andrewlu at openjdk.org Thu Mar 28 07:50:42 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 28 Mar 2024 07:50:42 GMT Subject: [jdk11u-dev] RFR: 8310923: Refactor Currency tests to use JUnit Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - fix - fix - Backport e848d9471f5de86e5ac157b710cd7371f12f0024 - Backport e848d9471f5de86e5ac157b710cd7371f12f0024 Changes: https://git.openjdk.org/jdk11u-dev/pull/2632/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2632&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310923 Stats: 1091 lines in 9 files changed: 439 ins; 370 del; 282 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2632.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2632/head:pull/2632 PR: https://git.openjdk.org/jdk11u-dev/pull/2632 From andrewlu at openjdk.org Thu Mar 28 07:55:46 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 28 Mar 2024 07:55:46 GMT Subject: [jdk11u-dev] RFR: 8323994: gtest runner repeats test name for every single gtest assertion Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 1aae980c549741cf5fc5ca51f3c299285bafa49d Changes: https://git.openjdk.org/jdk11u-dev/pull/2633/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2633&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323994 Stats: 128 lines in 2 files changed: 109 ins; 10 del; 9 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2633.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2633/head:pull/2633 PR: https://git.openjdk.org/jdk11u-dev/pull/2633 From andrewlu at openjdk.org Thu Mar 28 08:01:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 28 Mar 2024 08:01:40 GMT Subject: [jdk17u-dev] Integrated: 8323994: gtest runner repeats test name for every single gtest assertion In-Reply-To: References: Message-ID: <7mjHZGR1AztZHDYaN7E-dnjImy83Fsry_z05wwz8aTc=.50f24301-a4d0-44b1-bd4b-6938c67fd05f@github.com> On Wed, 27 Mar 2024 10:01:54 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: b2938564 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/b293856485ca3ccf4301a87df34ccfd31a6afb71 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod 8323994: gtest runner repeats test name for every single gtest assertion Backport-of: 1aae980c549741cf5fc5ca51f3c299285bafa49d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2336 From andrewlu at openjdk.org Thu Mar 28 08:02:33 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 28 Mar 2024 08:02:33 GMT Subject: [jdk21u-dev] Integrated: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS In-Reply-To: References: Message-ID: On Wed, 27 Mar 2024 02:10:03 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 77519962 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/7751996220f2d814f2da7cc1618a6f20f1c5be00 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS Backport-of: 1f43fa0f8b0f956b41015e0ebc257e15a11ad99b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/411 From andrewlu at openjdk.org Thu Mar 28 08:02:37 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 28 Mar 2024 08:02:37 GMT Subject: [jdk21u-dev] Integrated: 8323994: gtest runner repeats test name for every single gtest assertion In-Reply-To: References: Message-ID: On Wed, 27 Mar 2024 10:01:12 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 0bfb53c8 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/0bfb53c878d8222ad9836f9e960d7433ed66a2aa Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod 8323994: gtest runner repeats test name for every single gtest assertion Backport-of: 1aae980c549741cf5fc5ca51f3c299285bafa49d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/412 From andrewlu at openjdk.org Thu Mar 28 08:03:38 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 28 Mar 2024 08:03:38 GMT Subject: [jdk11u-dev] Integrated: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS In-Reply-To: References: Message-ID: On Wed, 27 Mar 2024 02:34:54 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. This pull request has now been integrated. Changeset: 518e7971 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/518e79717d2ce0ae345d61300fd28d0df8a5f553 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS Backport-of: 1f43fa0f8b0f956b41015e0ebc257e15a11ad99b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2626 From andrewlu at openjdk.org Thu Mar 28 08:03:39 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 28 Mar 2024 08:03:39 GMT Subject: [jdk17u-dev] Integrated: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS In-Reply-To: References: Message-ID: On Tue, 26 Mar 2024 07:19:58 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.11-oracle. This pull request has now been integrated. Changeset: f6c87d8f Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/f6c87d8f33d5b5aad55f367bf516733471afca65 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS Backport-of: 1f43fa0f8b0f956b41015e0ebc257e15a11ad99b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2331 From andrewlu at openjdk.org Thu Mar 28 08:10:53 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 28 Mar 2024 08:10:53 GMT Subject: [jdk11u-dev] RFR: 8310923: Refactor Currency tests to use JUnit [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.24-oracle. > test/jdk/java/util/Currency/ValidateISO4217.java > due to the https://github.com/openjdk/jdk11u-dev/pull/2532 > the missing part was backported to this file here > > test/jdk/java/util/Currency/CurrencyTest.java > due to the private static method was not allowed here such as 'private static Stream fundsCodes()', > add '@TestInstance(TestInstance.Lifecycle.PER_CLASS)' Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: fix ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2632/files - new: https://git.openjdk.org/jdk11u-dev/pull/2632/files/14c60deb..02566012 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2632&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2632&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2632.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2632/head:pull/2632 PR: https://git.openjdk.org/jdk11u-dev/pull/2632 From goetz at openjdk.org Thu Mar 28 08:11:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 08:11:47 GMT Subject: [jdk11u-dev] RFR: 8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out [v2] In-Reply-To: <15e1slDE63kZeQx1rSjc15mj36IuSCSug8wUhuWPhoo=.0ec1e737-4d53-4f99-bdfa-8e1d939b9855@github.com> References: <15e1slDE63kZeQx1rSjc15mj36IuSCSug8wUhuWPhoo=.0ec1e737-4d53-4f99-bdfa-8e1d939b9855@github.com> Message-ID: > I backport this to streamline the tests in 11. > > The patch applies clean, but I had to adapt it to Java 11. > > DTLSOverDatagram.java is refactored to use recoreds, I just reverted this. > I also removed -> from switch statments. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2628/files - new: https://git.openjdk.org/jdk11u-dev/pull/2628/files/d08f6938..d08f6938 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2628&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2628&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2628.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2628/head:pull/2628 PR: https://git.openjdk.org/jdk11u-dev/pull/2628 From goetz at openjdk.org Thu Mar 28 10:29:37 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 10:29:37 GMT Subject: [jdk11u-dev] Integrated: 8243010: Test support: Customizable Hex Printer In-Reply-To: References: Message-ID: On Wed, 27 Mar 2024 12:19:31 GMT, Goetz Lindenmaier wrote: > I backport this to streamline the jdk11u testing suite. makes later backports cleaner. > > Only trivial adaptions needed: > test/jdk/sun/security/pkcs/pkcs8/PKCS8Test.java > Copyright > test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketKeyLimit.java > Copyright, line break. > > I had to adapt a switch statement to Java 11. See extra commit. > > I adapted TEST.ROOT to require 7.3.1 which is standard for 11 currently This pull request has now been integrated. Changeset: 741b3400 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/741b3400f1ab5feb1143128fe5779c0b9cd3f73a Stats: 1671 lines in 16 files changed: 1613 ins; 16 del; 42 mod 8243010: Test support: Customizable Hex Printer Reviewed-by: mbaesken Backport-of: bdf672659cee13d95abc246de7cde469cf8fc07d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2627 From goetz at openjdk.org Thu Mar 28 10:29:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 10:29:38 GMT Subject: [jdk17u-dev] Integrated: 8295944: Move the Http2TestServer and related classes into a package of its own In-Reply-To: <8QL1KBFZDNOPtJfyTMcCxtTpN9HbNoV5kyPB6C9rZmg=.1abe1b82-dbba-4508-b528-58106e3a3f31@github.com> References: <8QL1KBFZDNOPtJfyTMcCxtTpN9HbNoV5kyPB6C9rZmg=.1abe1b82-dbba-4508-b528-58106e3a3f31@github.com> Message-ID: On Tue, 19 Mar 2024 20:14:06 GMT, Goetz Lindenmaier wrote: > I backport this to simplify further backports. It's a refactoring of test infra. > > I had to do resolves of Copyright, imports, and @test descriptions. A row of tests are not in 17. > In detail: > > > test/jdk/java/net/httpclient/AsFileDownloadTest.java > Needs resolve because earlier changes were al > > test/jdk/java/net/httpclient/AsyncExecutorShutdown.java > Introduced in 19 by "8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task" > This is a bug fix one wants to have in 17 at first sight, but it is a big change > and it had several follow ups. So better don't backport as prerequisite. > > test/jdk/java/net/httpclient/CancelRequestTest.java > Resolved Copyright. > > test/jdk/java/net/httpclient/CancelStreamedBodyTest.java > Introduced in 20 by "294916: Cancelling a request must eventually cause its response body subscriber to be unregistered" > This fix has many prereqs that would need to be backported. Omit. > > test/jdk/java/net/httpclient/DigestEchoClient.java > Resolved Copyright. > > test/jdk/java/net/httpclient/ExecutorShutdown.java > As above introduced by "8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task". Omit. > > test/jdk/java/net/httpclient/ExpectContinueTest.java > Introduced in 20 by "8286171: HttpClient/2 : Expect:100-Continue blocks indefinitely when response is not 100" > > test/jdk/java/net/httpclient/HeadTest.java > Resolved Copyright and imports. > "8276559: (httpclient) Consider adding an HttpRequest.Builder.HEAD method to build a HEAD request." which came in 18 > is a new feature with CSR that changed the imports. > > test/jdk/java/net/httpclient/HttpClientLocalAddrTest.java > Introduced in 19 by "8209137: Add ability to bind to specific local address to HTTP client". A new > feature. Omit. > > test/jdk/java/net/httpclient/ISO_8859_1_Test.java > Resolved Copyright > > test/jdk/java/net/httpclient/MappingResponseSubscriber.java > Resolved imports. > > test/jdk/java/net/httpclient/Response1xxTest.java > Introduced in 20 by 8292044: HttpClient doesn't handle 102 or 103 properly. Omit. > > > test/jdk/java/net/httpclient/SpecialHeadersTest.java > Resolved due to context. > > test/jdk/java/net/httpclient/http2/IdleConnectionTimeoutTest.java > Was added by 8288717: Add a means to close idle connections in HTTP/2 connection pool in 20. Omit. > > test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java > Was added by 8263031: HttpClient throws Exception if it receives a Push Promise that is too large in 19. Omit. > > test/jdk/java/net/httpclient/http2/UserInfoTest... This pull request has now been integrated. Changeset: 0dce546e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/0dce546e48f1706025e17e0d160d58c2d2538858 Stats: 1137 lines in 126 files changed: 256 ins; 433 del; 448 mod 8295944: Move the Http2TestServer and related classes into a package of its own Reviewed-by: lucy Backport-of: 8a47429dc065ad7645a40fa2350d043ef4606d92 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2311 From goetz at openjdk.org Thu Mar 28 10:30:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 10:30:34 GMT Subject: [jdk17u-dev] Integrated: 8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use" In-Reply-To: <0y_lyWjWarcVVIUuATp7OGhcK1RlzlIub-TAVjavC3w=.a5f1ef0e-363c-475b-b532-adc4d3625496@github.com> References: <0y_lyWjWarcVVIUuATp7OGhcK1RlzlIub-TAVjavC3w=.a5f1ef0e-363c-475b-b532-adc4d3625496@github.com> Message-ID: On Tue, 26 Mar 2024 13:26:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.12-oracle. This pull request has now been integrated. Changeset: 9b9573fa Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/9b9573faec0f08e838c75fdbe19135bb896a0ff4 Stats: 146 lines in 4 files changed: 63 ins; 53 del; 30 mod 8213714: AttachingConnector/attach/attach001 failed due to "bind failed: Address already in use" Backport-of: b62e7420450dad5a807a5afa0f65f6632b344e29 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2333 From goetz at openjdk.org Thu Mar 28 10:39:46 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 10:39:46 GMT Subject: [jdk11u-dev] RFR: 8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out [v3] In-Reply-To: <15e1slDE63kZeQx1rSjc15mj36IuSCSug8wUhuWPhoo=.0ec1e737-4d53-4f99-bdfa-8e1d939b9855@github.com> References: <15e1slDE63kZeQx1rSjc15mj36IuSCSug8wUhuWPhoo=.0ec1e737-4d53-4f99-bdfa-8e1d939b9855@github.com> Message-ID: > I backport this to streamline the tests in 11. > > The patch applies clean, but I had to adapt it to Java 11. > > DTLSOverDatagram.java is refactored to use recoreds, I just reverted this. > I also removed -> from switch statments. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge branch 'master' into goetz_backport_8264152 - Adapt to Java 11 - Backport 79adc16fd8ba47a8d9438f3467f92ab241766c1d - Add forgotten file - Adapt to Jva 11 - Backport bdf672659cee13d95abc246de7cde469cf8fc07d ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/2628/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2628&range=02 Stats: 278 lines in 3 files changed: 79 ins; 106 del; 93 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2628.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2628/head:pull/2628 PR: https://git.openjdk.org/jdk11u-dev/pull/2628 From goetz at openjdk.org Thu Mar 28 11:10:48 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 11:10:48 GMT Subject: [jdk21u-dev] RFR: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport d44aaa37f98dd383aebbec097427feb1f1c29b74 Changes: https://git.openjdk.org/jdk21u-dev/pull/420/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=420&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326643 Stats: 294 lines in 2 files changed: 293 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/420.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/420/head:pull/420 PR: https://git.openjdk.org/jdk21u-dev/pull/420 From goetz at openjdk.org Thu Mar 28 11:23:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 11:23:40 GMT Subject: [jdk17u-dev] RFR: 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC Message-ID: <7Nol-JBWasGNX0jUsF1_ARM2AYxmkucJ3EQH8ShH4mw=.69d02289-4997-4038-a70e-817c393120d5@github.com> I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport 28796cbd1d15de678b80295418f5d1f9f59176a6 Changes: https://git.openjdk.org/jdk17u-dev/pull/2343/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2343&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8163921 Stats: 11 lines in 2 files changed: 0 ins; 1 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2343.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2343/head:pull/2343 PR: https://git.openjdk.org/jdk17u-dev/pull/2343 From lucy at openjdk.org Thu Mar 28 13:16:33 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Thu, 28 Mar 2024 13:16:33 GMT Subject: [jdk11u-dev] RFR: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work In-Reply-To: References: Message-ID: On Mon, 25 Mar 2024 08:00:08 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. > > test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java > Backport to the origin file. > Other's clean. Marked as reviewed by lucy (Reviewer). LGTM. ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2620#pullrequestreview-1966191236 Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2620#pullrequestreview-1966192762 From goetz at openjdk.org Thu Mar 28 13:24:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 13:24:41 GMT Subject: [jdk11u-dev] RFR: 8280546: Remove hard-coded 127.0.0.1 loopback address Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport b5de2cc9d36e1fad7d0bf70f7c83ff829e16b7f3 Changes: https://git.openjdk.org/jdk11u-dev/pull/2634/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2634&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280546 Stats: 5 lines in 2 files changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2634.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2634/head:pull/2634 PR: https://git.openjdk.org/jdk11u-dev/pull/2634 From shade at openjdk.org Thu Mar 28 15:00:45 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 28 Mar 2024 15:00:45 GMT Subject: [jdk22u] Integrated: 8328705: GHA: Cross-compilation jobs do not require build JDK In-Reply-To: <2YseZn6pE_E8qo5UAzKP3FkJZF6ZWTrgDIG9wmEUAW8=.b8fac737-a184-484a-bbad-855758ace8ee@github.com> References: <2YseZn6pE_E8qo5UAzKP3FkJZF6ZWTrgDIG9wmEUAW8=.b8fac737-a184-484a-bbad-855758ace8ee@github.com> Message-ID: <0ebHjydg2QGti1woZ35X2R5P7jJYL3en4JzFd0O3B9c=.a112608c-0131-4d7c-8ce4-fe1ac1722e39@github.com> On Mon, 25 Mar 2024 11:50:05 GMT, Aleksey Shipilev wrote: > Clean backport to improve GHA parallelism. > > Additional testing: > - [ ] GHA This pull request has now been integrated. Changeset: 88887450 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/88887450a075ef987e08a2088c5513f55223f60a Stats: 11 lines in 2 files changed: 0 ins; 10 del; 1 mod 8328705: GHA: Cross-compilation jobs do not require build JDK Backport-of: 29ba4b7d1e62a834c1693fe6ad383c19467afc81 ------------- PR: https://git.openjdk.org/jdk22u/pull/113 From shade at openjdk.org Thu Mar 28 15:00:46 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 28 Mar 2024 15:00:46 GMT Subject: [jdk22u] Integrated: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 In-Reply-To: References: Message-ID: On Mon, 25 Mar 2024 18:18:35 GMT, Aleksey Shipilev wrote: > Fixes a recent GHA regression. > > Additional testing: > - [x] GHA, first run passes cross-builds > - [x] GHA, second run passes cross-builds This pull request has now been integrated. Changeset: ba80d42a Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/ba80d42adaf55c6c216272869d3147e8731c5a3f Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 Backport-of: 447436e18c754424a62af5135fb3a8973564091d ------------- PR: https://git.openjdk.org/jdk22u/pull/115 From mbaesken at openjdk.org Thu Mar 28 15:41:00 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 28 Mar 2024 15:41:00 GMT Subject: [jdk17u-dev] RFR: 8275334: Move class loading Events to a separate section in hs_err files Message-ID: 8275334: Move class loading Events to a separate section in hs_err files ------------- Commit messages: - Backport bb7dacdc78ad50797900e7e9610a1ed8e7ab1b00 Changes: https://git.openjdk.org/jdk17u-dev/pull/2344/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2344&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8275334 Stats: 20 lines in 3 files changed: 19 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2344.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2344/head:pull/2344 PR: https://git.openjdk.org/jdk17u-dev/pull/2344 From goetz at openjdk.org Thu Mar 28 17:55:47 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 17:55:47 GMT Subject: [jdk17u-dev] RFR: 8297645: Drop the test/jdk/java/net/httpclient/reactivestreams-tck-tests/TckDriver.java test Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport 6d0fbb2c49d904ac353b4a2ebc694e3d1609bd76 Changes: https://git.openjdk.org/jdk17u-dev/pull/2345/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2345&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297645 Stats: 10085 lines in 58 files changed: 0 ins; 10085 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2345.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2345/head:pull/2345 PR: https://git.openjdk.org/jdk17u-dev/pull/2345 From goetz at openjdk.org Thu Mar 28 17:55:51 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 17:55:51 GMT Subject: [jdk17u-dev] RFR: 8296137: diags-examples.xml is broken Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport f8b2574ebc32fa0e62dbaa0f2447757ff83c320f Changes: https://git.openjdk.org/jdk17u-dev/pull/2346/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2346&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296137 Stats: 12 lines in 2 files changed: 6 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2346.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2346/head:pull/2346 PR: https://git.openjdk.org/jdk17u-dev/pull/2346 From duke at openjdk.org Thu Mar 28 18:14:34 2024 From: duke at openjdk.org (Elif Aslan) Date: Thu, 28 Mar 2024 18:14:34 GMT Subject: [jdk17u-dev] Integrated: 8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac In-Reply-To: References: Message-ID: On Wed, 27 Mar 2024 15:51:56 GMT, Elif Aslan wrote: > Clean backport to enable running JspawnhelperProtocol.java on MacOS. > > GHA tested. > Additionally ran the test on macos. > > > Test report is stored in build/macosx-x86_64-server-fastdebug/test-results/jtreg_test_jdk_java_lang_ProcessBuilder_JspawnhelperProtocol_java > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Finished building target 'test' in configuration 'macosx-x86_64-server-fastdebug' This pull request has now been integrated. Changeset: a6180f72 Author: Elif Aslan Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/a6180f720c61d9ca137eed11b8aec40f5233df8d Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac Backport-of: cc1800fa4de3c1369efd46f5ca967ea82763f5d5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2340 From duke at openjdk.org Thu Mar 28 18:14:39 2024 From: duke at openjdk.org (Elif Aslan) Date: Thu, 28 Mar 2024 18:14:39 GMT Subject: [jdk21u-dev] Integrated: 8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac In-Reply-To: <58W_9C0vjKtPcMD_5YFV-oSsFqKlBXlkmxHlqC9G-UQ=.dcd196ff-6738-47ef-87c3-347a2d4ae263@github.com> References: <58W_9C0vjKtPcMD_5YFV-oSsFqKlBXlkmxHlqC9G-UQ=.dcd196ff-6738-47ef-87c3-347a2d4ae263@github.com> Message-ID: On Wed, 27 Mar 2024 15:54:25 GMT, Elif Aslan wrote: > Clean backport to enable running JspawnhelperProtocol.java on MacOS. > > GHA tested. > Additionally ran the test on macos. > > > Test report is stored in build/macosx-x86_64-server-fastdebug/test-results/jtreg_test_jdk_java_lang_ProcessBuilder_JspawnhelperProtocol_java > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Finished building target 'test' in configuration 'macosx-x86_64-server-fastdebug' This pull request has now been integrated. Changeset: c263bc5e Author: Elif Aslan Committer: Paul Hohensee URL: https://git.openjdk.org/jdk21u-dev/commit/c263bc5ee771a3784fc2044f362592891ba1ca53 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac Backport-of: cc1800fa4de3c1369efd46f5ca967ea82763f5d5 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/415 From goetz at openjdk.org Thu Mar 28 18:34:50 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 18:34:50 GMT Subject: [jdk21u-dev] RFR: 8309752: com/sun/jdi/SetLocalWhileThreadInNative.java fails with virtual test thread factory due to OpaqueFrameException Message-ID: <92GIYnU-V9jgE_7TaYKh8eJS8U0NGvxM-XMpf3ZZoxY=.6712187b-8beb-4e7b-a552-43b15f9ee2e4@github.com> I backport this for parity with 21.0.4-oracle. Resolved ProblemList, will mark clean. ------------- Commit messages: - Backport 1612b6dc6e7075e1c0c82d0e92910051c8066fe5 Changes: https://git.openjdk.org/jdk21u-dev/pull/421/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=421&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309752 Stats: 11 lines in 2 files changed: 7 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/421.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/421/head:pull/421 PR: https://git.openjdk.org/jdk21u-dev/pull/421 From goetz at openjdk.org Thu Mar 28 18:42:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 18:42:39 GMT Subject: [jdk21u-dev] RFR: 8315485: (fs) Move java/nio/file/Path/Misc.java tests into java/nio/file/Path/PathOps.java Message-ID: I backport this for parity with 21.0.4-oracle. I resolved the first chunk. ------------- Commit messages: - Backport 8dfde28b289cbb53173f0ab759156088bbaf74f1 Changes: https://git.openjdk.org/jdk21u-dev/pull/422/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=422&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315485 Stats: 149 lines in 2 files changed: 59 ins; 88 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/422.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/422/head:pull/422 PR: https://git.openjdk.org/jdk21u-dev/pull/422 From goetz at openjdk.org Thu Mar 28 19:16:55 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 19:16:55 GMT Subject: [jdk17u-dev] RFR: 8163229: several regression tests have a main method that is never executed Message-ID: I backport this for parity with 17.0.12-oracle. Clean except for one file that is not in 17 (added by JEP 405: Record Patterns.). Will mark clean. ------------- Commit messages: - Backport 382fe51b6d7eba7094afa070032bedaa9ffc0633 Changes: https://git.openjdk.org/jdk17u-dev/pull/2347/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2347&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8163229 Stats: 188 lines in 127 files changed: 0 ins; 72 del; 116 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2347.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2347/head:pull/2347 PR: https://git.openjdk.org/jdk17u-dev/pull/2347 From goetz at openjdk.org Thu Mar 28 19:17:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 19:17:40 GMT Subject: [jdk17u-dev] RFR: 8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect" Message-ID: <1qibaM96-__7LUiGacybK6ZOK8lNG9Qxdyz64gVd3Cc=.eec3b3b7-ff97-4c7d-a5dd-25c1f4dd3e44@github.com> I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport 0dce5b811d64ac17b9580d6a2d8eca1df70990a1 Changes: https://git.openjdk.org/jdk17u-dev/pull/2348/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2348&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296610 Stats: 60 lines in 2 files changed: 30 ins; 0 del; 30 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2348.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2348/head:pull/2348 PR: https://git.openjdk.org/jdk17u-dev/pull/2348 From goetz at openjdk.org Thu Mar 28 19:23:52 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 19:23:52 GMT Subject: [jdk17u-dev] RFR: 8297292: java/nio/channels/FileChannel/FileExtensionAndMap.java is too slow Message-ID: <61hsPMlmmcA3m6D-Cj6lvHvN0KEVDFmB_O3fxbShfDE=.7a224f63-2743-4068-8b13-c3ba56a9384f@github.com> I backport this for parity with 17.0.12-oracle. Skipped ProblemList patch, file was not problemlisted. Deleted the file by hand, patch did not apply As this only deletes a test, I will mark it clean. ------------- Commit messages: - Backport 84e47996e88cf640e5e9d5ab4be8a640c67afbf5 Changes: https://git.openjdk.org/jdk17u-dev/pull/2349/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2349&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297292 Stats: 203 lines in 1 file changed: 0 ins; 203 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2349.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2349/head:pull/2349 PR: https://git.openjdk.org/jdk17u-dev/pull/2349 From goetz at openjdk.org Thu Mar 28 20:03:42 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 20:03:42 GMT Subject: [jdk17u-dev] RFR: 8303457: Introduce convenience test library APIs for creating test servers for tests in test/jdk/java/net/httpclient Message-ID: I backport this for parity with 17.0.12-oracle. test/jdk/java/net/httpclient/CancelRequestTest.java test/jdk/java/net/httpclient/HeadTest.java Resolved imports. Omitted files: test/jdk/java/net/httpclient/AsyncExecutorShutdown.java test/jdk/java/net/httpclient/CancelStreamedBodyTest.java test/jdk/java/net/httpclient/ExecutorShutdown.java test/jdk/java/net/httpclient/ExpectContinueTest.java test/jdk/java/net/httpclient/Response1xxTest.java All these already had to be omitted in https://github.com/openjdk/jdk17u-dev/pull/2311, they all came with new features or other changes that should not be backported as prereq. ------------- Commit messages: - Backport 72de24e59a80a38ea4ea6a8a3f966f555987ac86 Changes: https://git.openjdk.org/jdk17u-dev/pull/2350/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2350&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303457 Stats: 491 lines in 41 files changed: 165 ins; 143 del; 183 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2350.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2350/head:pull/2350 PR: https://git.openjdk.org/jdk17u-dev/pull/2350 From goetz at openjdk.org Thu Mar 28 20:07:39 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 28 Mar 2024 20:07:39 GMT Subject: [jdk21u-dev] RFR: 8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false" Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 5207443b360cfe3ee9c53ece55da3464c13f6a9f Changes: https://git.openjdk.org/jdk21u-dev/pull/423/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=423&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317965 Stats: 108 lines in 2 files changed: 16 ins; 73 del; 19 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/423.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/423/head:pull/423 PR: https://git.openjdk.org/jdk21u-dev/pull/423 From andrewlu at openjdk.org Fri Mar 29 02:59:59 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 29 Mar 2024 02:59:59 GMT Subject: [jdk17u-dev] RFR: 8328812: Update and move siphash license Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport ce7ebaa606f96fdfee66d300b56022d9903b5ae3 Changes: https://git.openjdk.org/jdk17u-dev/pull/2351/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2351&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328812 Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2351.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2351/head:pull/2351 PR: https://git.openjdk.org/jdk17u-dev/pull/2351 From andrewlu at openjdk.org Fri Mar 29 03:08:05 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 29 Mar 2024 03:08:05 GMT Subject: [jdk11u-dev] RFR: 8328812: Update and move siphash license Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport ce7ebaa606f96fdfee66d300b56022d9903b5ae3 Changes: https://git.openjdk.org/jdk11u-dev/pull/2635/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2635&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328812 Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2635.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2635/head:pull/2635 PR: https://git.openjdk.org/jdk11u-dev/pull/2635 From andrewlu at openjdk.org Fri Mar 29 03:07:55 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 29 Mar 2024 03:07:55 GMT Subject: [jdk21u-dev] RFR: 8328812: Update and move siphash license Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport ce7ebaa606f96fdfee66d300b56022d9903b5ae3 Changes: https://git.openjdk.org/jdk21u-dev/pull/424/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=424&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328812 Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/424.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/424/head:pull/424 PR: https://git.openjdk.org/jdk21u-dev/pull/424 From andrewlu at openjdk.org Fri Mar 29 05:13:57 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 29 Mar 2024 05:13:57 GMT Subject: [jdk11u-dev] RFR: 8306714: Open source few Swing event and AbstractAction tests Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 31a73b0d7088d10a5ffb5541d66806a92b681ef9 Changes: https://git.openjdk.org/jdk11u-dev/pull/2636/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2636&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306714 Stats: 329 lines in 6 files changed: 329 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2636.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2636/head:pull/2636 PR: https://git.openjdk.org/jdk11u-dev/pull/2636 From andrewlu at openjdk.org Fri Mar 29 05:14:57 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 29 Mar 2024 05:14:57 GMT Subject: [jdk17u-dev] RFR: 8306714: Open source few Swing event and AbstractAction tests Message-ID: <2NIkq0nuN1Xh6Ymo7z7d3VnAzVUWzGH5v6vqxea-8Js=.e17dc967-2f6a-44a0-b5bc-06622260eefe@github.com> I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 31a73b0d7088d10a5ffb5541d66806a92b681ef9 Changes: https://git.openjdk.org/jdk17u-dev/pull/2352/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2352&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306714 Stats: 329 lines in 6 files changed: 329 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2352.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2352/head:pull/2352 PR: https://git.openjdk.org/jdk17u-dev/pull/2352 From andrewlu at openjdk.org Fri Mar 29 07:03:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 29 Mar 2024 07:03:06 GMT Subject: [jdk11u-dev] RFR: 8305943: Open source few AWT Focus related tests Message-ID: <2hFQRkYKxmJtRXxEWVFVNVc4JlTGyXe5cOdK_HCWwYg=.52209cfa-90e2-4a66-95ec-47b3a4160910@github.com> I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 64ed816ad9f1a9773c9865a013e89b709a130e9c Changes: https://git.openjdk.org/jdk11u-dev/pull/2637/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2637&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305943 Stats: 765 lines in 5 files changed: 765 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2637.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2637/head:pull/2637 PR: https://git.openjdk.org/jdk11u-dev/pull/2637 From andrewlu at openjdk.org Fri Mar 29 07:03:11 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 29 Mar 2024 07:03:11 GMT Subject: [jdk17u-dev] RFR: 8305943: Open source few AWT Focus related tests Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 64ed816ad9f1a9773c9865a013e89b709a130e9c Changes: https://git.openjdk.org/jdk17u-dev/pull/2353/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2353&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305943 Stats: 765 lines in 5 files changed: 765 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2353.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2353/head:pull/2353 PR: https://git.openjdk.org/jdk17u-dev/pull/2353 From andrewlu at openjdk.org Fri Mar 29 07:06:01 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 29 Mar 2024 07:06:01 GMT Subject: [jdk17u-dev] RFR: 8305942: Open source several AWT Focus related tests Message-ID: I backport this for parity with 17.0.11-oracle. ------------- Commit messages: - Backport 8346ae2bc1152f13bc77c643252d84e2043ffe0b Changes: https://git.openjdk.org/jdk17u-dev/pull/2354/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2354&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305942 Stats: 831 lines in 6 files changed: 831 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2354.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2354/head:pull/2354 PR: https://git.openjdk.org/jdk17u-dev/pull/2354 From andrewlu at openjdk.org Fri Mar 29 07:08:12 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 29 Mar 2024 07:08:12 GMT Subject: [jdk11u-dev] RFR: 8305942: Open source several AWT Focus related tests Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 8346ae2bc1152f13bc77c643252d84e2043ffe0b Changes: https://git.openjdk.org/jdk11u-dev/pull/2638/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2638&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305942 Stats: 831 lines in 6 files changed: 831 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2638.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2638/head:pull/2638 PR: https://git.openjdk.org/jdk11u-dev/pull/2638 From duke at openjdk.org Fri Mar 29 07:12:35 2024 From: duke at openjdk.org (xiaotaonan) Date: Fri, 29 Mar 2024 07:12:35 GMT Subject: [jdk21u-dev] RFR: 8326487: ZipFileSystem.getPath("").getFileName() returns null instead of an empty string In-Reply-To: References: Message-ID: <4cjyupj-IT2aSmFjwzPVtGWDSFALXUy1tTaw8H0fuI8=.c0f53158-8e3b-4cee-a5e2-bf9946c6dcde@github.com> On Tue, 27 Feb 2024 09:03:47 GMT, Alan Bateman wrote: >> In the scenario of using ZipFileSystem, when getPath("").getFileName() returns null, change getPath("").getNameCount() to 0. > > This will require discussion for the main-line before looking at update releases. Too early to be creating PRs for update releases. @AlanBateman @jerboaa @cushon @parttimenerd Can someone help me review the commit? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/293#issuecomment-2026786274 From goetz at openjdk.org Fri Mar 29 08:04:41 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 29 Mar 2024 08:04:41 GMT Subject: [jdk17u-dev] Integrated: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains In-Reply-To: References: Message-ID: On Wed, 27 Mar 2024 09:01:21 GMT, Goetz Lindenmaier wrote: > I had to do some trivial resolves. > > I add some refactorings from "8262912: ciReplay: replay does not simulate unresolved classes" > to the edited test files to make the test compile. I also had to fix the path to WhiteBox. > > I also added two methods to query names to ciEnv from > "8271911: replay compilations of methods which use JSR292 (easy cases)". > this calls further into dyno_name(). I disabled this, it is not needed as long as 8262912 is not backported. > > Test reproduces the issue as expected. > > For follow up 8276227 see dependent pull request. This pull request has now been integrated. Changeset: ba77d0ba Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/ba77d0baed6c3a28f9b8c8ea3db1b8a1a95f9c1f Stats: 467 lines in 6 files changed: 462 ins; 0 del; 5 mod 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains Reviewed-by: mdoerr Backport-of: 5bb1992b8408a0d196b1afa308bc00d007458dbd ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2334 From goetz at openjdk.org Fri Mar 29 08:10:56 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 29 Mar 2024 08:10:56 GMT Subject: [jdk17u-dev] RFR: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868 [v4] In-Reply-To: References: Message-ID: > I had to do a trivial resolve in ciReplay and adapt the path to WhiteBox in the test. > > Follow up for 8275868. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Merge branch 'master' into goetz_backport_8276227 - Fix whitespace - Add empty line - Backport a1f4c428ba1b78a4e18afb87c94a5c731a5aa706 - Make hotspot compile by adding accessors from 8271911 - Make test compile with parts from 88262912 - Backport 5bb1992b8408a0d196b1afa308bc00d007458dbd ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/2335/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2335&range=03 Stats: 82 lines in 2 files changed: 81 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2335.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2335/head:pull/2335 PR: https://git.openjdk.org/jdk17u-dev/pull/2335 From andrewlu at openjdk.org Fri Mar 29 08:27:52 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 29 Mar 2024 08:27:52 GMT Subject: [jdk11u-dev] RFR: 8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 29d462a07239a57b83850b9a8662573291fdbdf7 Changes: https://git.openjdk.org/jdk11u-dev/pull/2639/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2639&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318727 Stats: 943 lines in 41 files changed: 0 ins; 943 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2639.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2639/head:pull/2639 PR: https://git.openjdk.org/jdk11u-dev/pull/2639 From sgehwolf at openjdk.org Fri Mar 29 10:18:39 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 29 Mar 2024 10:18:39 GMT Subject: [jdk21u-dev] RFR: 8326487: ZipFileSystem.getPath("").getFileName() returns null instead of an empty string In-Reply-To: <4cjyupj-IT2aSmFjwzPVtGWDSFALXUy1tTaw8H0fuI8=.c0f53158-8e3b-4cee-a5e2-bf9946c6dcde@github.com> References: <4cjyupj-IT2aSmFjwzPVtGWDSFALXUy1tTaw8H0fuI8=.c0f53158-8e3b-4cee-a5e2-bf9946c6dcde@github.com> Message-ID: On Fri, 29 Mar 2024 07:09:31 GMT, xiaotaonan wrote: >> This will require discussion for the main-line before looking at update releases. Too early to be creating PRs for update releases. > > @AlanBateman @jerboaa @cushon @parttimenerd Can someone help me review the commit? @xiaotaonan This is the wrong repository to get reviews. The bug needs to get fixed in JDK mainline first and then backported. Submit a PR here if you want: https://github.com/openjdk/jdk/pulls Once the fix is there (JDK 23 currently), we can consider backporting. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/293#issuecomment-2027024920 From sgehwolf at openjdk.org Fri Mar 29 10:18:39 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 29 Mar 2024 10:18:39 GMT Subject: [jdk21u-dev] RFR: 8326487: ZipFileSystem.getPath("").getFileName() returns null instead of an empty string In-Reply-To: References: Message-ID: On Tue, 27 Feb 2024 08:51:14 GMT, xiaotaonan wrote: > In the scenario of using ZipFileSystem, when getPath("").getFileName() returns null, change getPath("").getNameCount() to 0. Please close this PR. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/293#issuecomment-2027025180 From aivanov at openjdk.org Fri Mar 29 16:38:55 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 29 Mar 2024 16:38:55 GMT Subject: [jdk22u] RFR: 8323801: tag doesn't strikethrough the text Message-ID: <7UshewKkg2FkaCHnOhx51X7_Vaoca-wy6oMTUEnX64E=.ed94f4ef-0e41-4918-ba8e-f42677b1f320@github.com> Backport [JDK-8323801](https://bugs.openjdk.org/browse/JDK-8323801): _<s> tag doesn't strikethrough the text_. The patch applies cleanly. ------------- Commit messages: - Backport 80b63b67293970936d57ae4375ad76cd2b11a333 Changes: https://git.openjdk.org/jdk22u/pull/117/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=117&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323801 Stats: 127 lines in 2 files changed: 117 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk22u/pull/117.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/117/head:pull/117 PR: https://git.openjdk.org/jdk22u/pull/117 From andrew at openjdk.org Fri Mar 29 16:48:34 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Mar 2024 16:48:34 GMT Subject: [jdk11u-dev] RFR: 8286705: GCC 12 reports use-after-free potential bugs In-Reply-To: References: Message-ID: On Sat, 17 Feb 2024 20:32:14 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [0e4bece5](https://github.com/openjdk/jdk/commit/0e4bece5b5143b8505496ea7430bbfa11e151aff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Yasumasa Suenaga on 15 May 2022 and was reviewed by Kim Barrett. > > The backport to `parse_manifest.c` applied cleanly. The patch as a whole doesn't apply cleanly as it also patches `src/jdk.jpackage/linux/native/applauncher/LinuxPackage.c` and `jpackage` is not part of 11u. > > It fixes a `use-after-free` warning which prevents GCC 12+ from building 11u without `--disable-warnings-as-errors`. > > Thanks! Oh this got approved. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2524#issuecomment-2027472871 From andrew at openjdk.org Fri Mar 29 16:48:35 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Mar 2024 16:48:35 GMT Subject: [jdk11u-dev] Integrated: 8286705: GCC 12 reports use-after-free potential bugs In-Reply-To: References: Message-ID: On Sat, 17 Feb 2024 20:32:14 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [0e4bece5](https://github.com/openjdk/jdk/commit/0e4bece5b5143b8505496ea7430bbfa11e151aff) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Yasumasa Suenaga on 15 May 2022 and was reviewed by Kim Barrett. > > The backport to `parse_manifest.c` applied cleanly. The patch as a whole doesn't apply cleanly as it also patches `src/jdk.jpackage/linux/native/applauncher/LinuxPackage.c` and `jpackage` is not part of 11u. > > It fixes a `use-after-free` warning which prevents GCC 12+ from building 11u without `--disable-warnings-as-errors`. > > Thanks! This pull request has now been integrated. Changeset: 5d4de366 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk11u-dev/commit/5d4de366d7092aefc26246ab1a4039f8bd30d7fa Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod 8286705: GCC 12 reports use-after-free potential bugs Reviewed-by: phh Backport-of: 0e4bece5b5143b8505496ea7430bbfa11e151aff ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2524 From andrew at openjdk.org Fri Mar 29 16:52:37 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Mar 2024 16:52:37 GMT Subject: [jdk17u-dev] RFR: 8286045: Use ForceGC for cleaner test cases In-Reply-To: References: Message-ID: On Sat, 25 Nov 2023 18:45:24 GMT, Andrew John Hughes wrote: > [JDK-8286045](https://bugs.openjdk.org/browse/JDK-8286045) is a test fix which aims to make GC usage within test cases more reliable by using the `ForceGC` library added by [JDK-8238358](https://bugs.openjdk.org/browse/JDK-8238358). > > It adjusts three test cases: > > * `test/jdk/javax/security/auth/callback/PasswordCallback/CheckCleanerBound.java` > * `test/jdk/sun/security/jgss/GssContextCleanup.java` > * `test/jdk/sun/security/jgss/GssNameCleanup.java` > > The two `jgss` tests are introduced by a finalization cleanup, [JDK-8284490](https://bugs.openjdk.org/browse/JDK-8284490): "Remove finalizer method in java.security.jgss", which is not in 17u, so this backport only includes the changes to `CheckCleanerBound.java`, which was introduced in the 2023-10 security update. > > The changes to `CheckCleanerBound.java` apply cleanly, but the test still fails as `CheckCleanerBound.java` never received the changes in the backport of [JDK-8285796](https://bugs.openjdk.org/browse/JDK-8285796) as this backport was introduced in 17u about a week before `CheckCleanerBound.java`. With that additional fragment cherry-picked from the trunk version of 8285796, the test passes. > > Finally, we drop the `ProblemList.txt` addition made by [JDK-8285785](https://bugs.openjdk.org/browse/JDK-8285785) as the test now passes. I was waiting for it to be approved. It seems it has been, though there is nothing on the PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1987#issuecomment-2027477040 From andrew at openjdk.org Fri Mar 29 16:52:38 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Mar 2024 16:52:38 GMT Subject: [jdk17u-dev] Integrated: 8286045: Use ForceGC for cleaner test cases In-Reply-To: References: Message-ID: On Sat, 25 Nov 2023 18:45:24 GMT, Andrew John Hughes wrote: > [JDK-8286045](https://bugs.openjdk.org/browse/JDK-8286045) is a test fix which aims to make GC usage within test cases more reliable by using the `ForceGC` library added by [JDK-8238358](https://bugs.openjdk.org/browse/JDK-8238358). > > It adjusts three test cases: > > * `test/jdk/javax/security/auth/callback/PasswordCallback/CheckCleanerBound.java` > * `test/jdk/sun/security/jgss/GssContextCleanup.java` > * `test/jdk/sun/security/jgss/GssNameCleanup.java` > > The two `jgss` tests are introduced by a finalization cleanup, [JDK-8284490](https://bugs.openjdk.org/browse/JDK-8284490): "Remove finalizer method in java.security.jgss", which is not in 17u, so this backport only includes the changes to `CheckCleanerBound.java`, which was introduced in the 2023-10 security update. > > The changes to `CheckCleanerBound.java` apply cleanly, but the test still fails as `CheckCleanerBound.java` never received the changes in the backport of [JDK-8285796](https://bugs.openjdk.org/browse/JDK-8285796) as this backport was introduced in 17u about a week before `CheckCleanerBound.java`. With that additional fragment cherry-picked from the trunk version of 8285796, the test passes. > > Finally, we drop the `ProblemList.txt` addition made by [JDK-8285785](https://bugs.openjdk.org/browse/JDK-8285785) as the test now passes. This pull request has now been integrated. Changeset: d2df108b Author: Andrew John Hughes URL: https://git.openjdk.org/jdk17u-dev/commit/d2df108b386c336bf78225d0d1ef647395532c43 Stats: 18 lines in 2 files changed: 5 ins; 10 del; 3 mod 8286045: Use ForceGC for cleaner test cases Reviewed-by: mbaesken, yan Backport-of: 7eb15593e18a923bbc18c8d596cff87d87019640 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1987 From goetz at openjdk.org Fri Mar 29 20:30:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 29 Mar 2024 20:30:38 GMT Subject: [jdk17u-dev] RFR: 8286045: Use ForceGC for cleaner test cases In-Reply-To: References: Message-ID: On Sat, 25 Nov 2023 18:45:24 GMT, Andrew John Hughes wrote: > [JDK-8286045](https://bugs.openjdk.org/browse/JDK-8286045) is a test fix which aims to make GC usage within test cases more reliable by using the `ForceGC` library added by [JDK-8238358](https://bugs.openjdk.org/browse/JDK-8238358). > > It adjusts three test cases: > > * `test/jdk/javax/security/auth/callback/PasswordCallback/CheckCleanerBound.java` > * `test/jdk/sun/security/jgss/GssContextCleanup.java` > * `test/jdk/sun/security/jgss/GssNameCleanup.java` > > The two `jgss` tests are introduced by a finalization cleanup, [JDK-8284490](https://bugs.openjdk.org/browse/JDK-8284490): "Remove finalizer method in java.security.jgss", which is not in 17u, so this backport only includes the changes to `CheckCleanerBound.java`, which was introduced in the 2023-10 security update. > > The changes to `CheckCleanerBound.java` apply cleanly, but the test still fails as `CheckCleanerBound.java` never received the changes in the backport of [JDK-8285796](https://bugs.openjdk.org/browse/JDK-8285796) as this backport was introduced in 17u about a week before `CheckCleanerBound.java`. With that additional fragment cherry-picked from the trunk version of 8285796, the test passes. > > Finally, we drop the `ProblemList.txt` addition made by [JDK-8285785](https://bugs.openjdk.org/browse/JDK-8285785) as the test now passes. > I was waiting for it to be approved. It seems it has been, though there is nothing on the PR. /integrate Yes there was. It get's a green "ready" label if it is approved. See this message: @[openjdk](https://github.com/apps/openjdk) openjdk bot added [ready](https://github.com/openjdk/jdk17u-dev/labels/ready) and removed [approval](https://github.com/openjdk/jdk17u-dev/labels/approval) labels [on Jan 6](https://github.com/openjdk/jdk17u-dev/pull/1987#event-11407915626) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1987#issuecomment-2027705644 From goetz at openjdk.org Fri Mar 29 21:05:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 29 Mar 2024 21:05:38 GMT Subject: [jdk17u-dev] Integrated: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868 In-Reply-To: References: Message-ID: On Wed, 27 Mar 2024 09:12:20 GMT, Goetz Lindenmaier wrote: > I had to do a trivial resolve in ciReplay and adapt the path to WhiteBox in the test. > > Follow up for 8275868. This pull request has now been integrated. Changeset: 4ced080f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/4ced080f1e5acc1fe4f0117833038cd056864bf9 Stats: 82 lines in 2 files changed: 81 ins; 0 del; 1 mod 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868 Reviewed-by: mdoerr Backport-of: a1f4c428ba1b78a4e18afb87c94a5c731a5aa706 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2335 From abakhtin at openjdk.org Fri Mar 29 21:22:58 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 29 Mar 2024 21:22:58 GMT Subject: [jdk11u-dev] RFR: 8287596: Reorg jdk.test.lib.util.ForceGC Message-ID: Hello I'd like to backport this enhancement to fix regression in java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java caused by JDK-8300727. The backport of JDK-8300727 requires JDK-8287596 to be applied first. The main differences from the JDK17 patch are the following: - Reference::refersTo() is introduced in JDK16. Reference::get is used instead - test/jdk/java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java in JDK11 does not use ForceGC. Skipped - no test/jdk/java/lang/invoke/defineHiddenClass/UnloadingTest.java in JDK11 - This patch also includes JDK-8261851 changes as part of the test/jdk/java/lang/reflect/callerCache/ReflectionCallerCacheTest.java patch All related jtreg tests passed. ------------- Commit messages: - Backport 82a8bd7e92a1867b0c82f051361938be8610428d Changes: https://git.openjdk.org/jdk11u-dev/pull/2640/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2640&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287596 Stats: 105 lines in 4 files changed: 18 ins; 62 del; 25 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2640.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2640/head:pull/2640 PR: https://git.openjdk.org/jdk11u-dev/pull/2640 From goetz at openjdk.org Fri Mar 29 21:30:03 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 29 Mar 2024 21:30:03 GMT Subject: [jdk21u-dev] RFR: 8315605: G1: Add number of nmethods in code roots scanning statistics Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 7ef059a75cdd2e96421a165ea1dd8391381bd7b5 Changes: https://git.openjdk.org/jdk21u-dev/pull/425/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=425&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315605 Stats: 39 lines in 3 files changed: 38 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/425.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/425/head:pull/425 PR: https://git.openjdk.org/jdk21u-dev/pull/425 From goetz at openjdk.org Fri Mar 29 21:35:53 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 29 Mar 2024 21:35:53 GMT Subject: [jdk21u-dev] RFR: 8316002: Remove unnecessary seen_dead_loader in ClassLoaderDataGraph::do_unloading Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 50158f393e0b077b22886f44624ff23e65dedeb8 Changes: https://git.openjdk.org/jdk21u-dev/pull/426/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=426&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316002 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/426.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/426/head:pull/426 PR: https://git.openjdk.org/jdk21u-dev/pull/426 From goetz at openjdk.org Fri Mar 29 21:39:43 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 29 Mar 2024 21:39:43 GMT Subject: [jdk21u-dev] RFR: 8315998: Remove dead ClassLoaderDataGraphKlassIteratorStatic Message-ID: I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 347beb21aa856cebdcf4407eac59f1cad46376c1 Changes: https://git.openjdk.org/jdk21u-dev/pull/427/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=427&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8315998 Stats: 95 lines in 5 files changed: 0 ins; 95 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/427.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/427/head:pull/427 PR: https://git.openjdk.org/jdk21u-dev/pull/427 From goetz at openjdk.org Fri Mar 29 21:46:02 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 29 Mar 2024 21:46:02 GMT Subject: [jdk21u-dev] RFR: 8316670: Remove effectively unused nmethodBucket::_count Message-ID: <_cy897KidIFvGQNV5i_dA-Jf_j7Y7Do2DvF-AdAdvOA=.635e9691-7d4b-4166-bab4-c4fc9a2e7736@github.com> I backport this for parity with 21.0.4-oracle. ------------- Commit messages: - Backport 837783c2d333627bfcbef00fc67024aff847bd9f Changes: https://git.openjdk.org/jdk21u-dev/pull/428/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=428&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316670 Stats: 43 lines in 2 files changed: 1 ins; 25 del; 17 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/428.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/428/head:pull/428 PR: https://git.openjdk.org/jdk21u-dev/pull/428 From goetz at openjdk.org Sat Mar 30 09:11:34 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 30 Mar 2024 09:11:34 GMT Subject: [jdk11u-dev] Integrated: 8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out In-Reply-To: <15e1slDE63kZeQx1rSjc15mj36IuSCSug8wUhuWPhoo=.0ec1e737-4d53-4f99-bdfa-8e1d939b9855@github.com> References: <15e1slDE63kZeQx1rSjc15mj36IuSCSug8wUhuWPhoo=.0ec1e737-4d53-4f99-bdfa-8e1d939b9855@github.com> Message-ID: On Wed, 27 Mar 2024 12:58:53 GMT, Goetz Lindenmaier wrote: > I backport this to streamline the tests in 11. > > The patch applies clean, but I had to adapt it to Java 11. > > DTLSOverDatagram.java is refactored to use recoreds, I just reverted this. > I also removed -> from switch statments. This pull request has now been integrated. Changeset: 979daf54 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/979daf54de3a9244f9316ea1fc18b7a615835680 Stats: 278 lines in 3 files changed: 79 ins; 106 del; 93 mod 8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out Reviewed-by: lucy Backport-of: 79adc16fd8ba47a8d9438f3467f92ab241766c1d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2628 From goetz at openjdk.org Sat Mar 30 09:15:40 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 30 Mar 2024 09:15:40 GMT Subject: [jdk21u-dev] RFR: 8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false" In-Reply-To: References: Message-ID: On Thu, 28 Mar 2024 20:03:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. GHA failure: RuntimeException: Unable to load b.jar. Probably caused by this PR, need to check. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/423#issuecomment-2027985500 From goetz at openjdk.org Sat Mar 30 09:25:54 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 30 Mar 2024 09:25:54 GMT Subject: [jdk11u-dev] RFR: 8297798: Timeout with DTLSOverDatagram test template [v3] In-Reply-To: <6ckoY9233HkIPZKjcRkv-uqWbQnCIArjTQdixVjDJ4Q=.18ee4c9c-00b8-4a6d-8174-7532f7e4d9bf@github.com> References: <6ckoY9233HkIPZKjcRkv-uqWbQnCIArjTQdixVjDJ4Q=.18ee4c9c-00b8-4a6d-8174-7532f7e4d9bf@github.com> Message-ID: > I backport this to streamline testing based on the change in 17. > > I had to resolve DTLSOverDatagram because the code in 11 uses classes, where the code in 17 uses records. > The added code is identical in 11 and 17. > > Tests pass. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Merge branch 'master' into goetz_backport_8297798 - Backport 23457a664ce00de33fdb6846ff31f489e6dd2177 - Adapt to Java 11 - Backport 79adc16fd8ba47a8d9438f3467f92ab241766c1d - Add forgotten file - Adapt to Jva 11 - Backport bdf672659cee13d95abc246de7cde469cf8fc07d ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/2629/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2629&range=02 Stats: 181 lines in 2 files changed: 28 ins; 104 del; 49 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2629.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2629/head:pull/2629 PR: https://git.openjdk.org/jdk11u-dev/pull/2629 From goetz at openjdk.org Sat Mar 30 15:14:38 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 30 Mar 2024 15:14:38 GMT Subject: [jdk11u-dev] Integrated: 8297798: Timeout with DTLSOverDatagram test template In-Reply-To: <6ckoY9233HkIPZKjcRkv-uqWbQnCIArjTQdixVjDJ4Q=.18ee4c9c-00b8-4a6d-8174-7532f7e4d9bf@github.com> References: <6ckoY9233HkIPZKjcRkv-uqWbQnCIArjTQdixVjDJ4Q=.18ee4c9c-00b8-4a6d-8174-7532f7e4d9bf@github.com> Message-ID: On Wed, 27 Mar 2024 13:09:19 GMT, Goetz Lindenmaier wrote: > I backport this to streamline testing based on the change in 17. > > I had to resolve DTLSOverDatagram because the code in 11 uses classes, where the code in 17 uses records. > The added code is identical in 11 and 17. > > Tests pass. This pull request has now been integrated. Changeset: 00736021 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/00736021bc6b769dfc6d99dfa5079b4d9427aadd Stats: 181 lines in 2 files changed: 28 ins; 104 del; 49 mod 8297798: Timeout with DTLSOverDatagram test template Reviewed-by: mbaesken Backport-of: 23457a664ce00de33fdb6846ff31f489e6dd2177 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2629