[jdk17u-dev] RFR: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs

Patrick Zhang qpzhang at openjdk.org
Fri Mar 1 09:26:55 UTC 2024


On Thu, 29 Feb 2024 10:36:36 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Hi,
>> 
>> This pull request contains a backport of commit [9936aeea](https://github.com/openjdk/jdk/commit/9936aeea32b71509151099e6d28905e0322b2bc2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>> 
>> Not a clean merge to 17u-dev. 
>> Manually resolved the merging conflicts due to line differences on `enum Ampere_CPU_Model` and `Feature_Flag`, removed redundant changes in order to limit the update to the code changes only from commit [9936aeea]. This can also lower the risk and limit the functionality impact to to particular Ampere new CPU cores Ampere-1/1A/1B. Same scope as that of the commit [9936aeea].
>> 
>> Passed pre-submit tests, ran Jtreg `tier1`, `tier2`, and `gtest` tests, no related issue found with the patch, also tested:
>> `make run-test TEST="jtreg:hotspot/jtreg/compiler/onSpinWait*" `
>> `make run-test TEST="micro:ThreadOnSpinWait*"`
>> 
>> Thanks for review.
>
> Ok.

Thanks for your view @adinn , 

I noticed that the check-box of "**Change must be properly reviewed (1 review required)**" is still blank. Probably I need an "Approve" on it, before moving forward to ask for 17u-dev maintainer's approval of the integration, right? or Is there any code change required on this PR? Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2202#issuecomment-1972821743


More information about the jdk-updates-dev mailing list