[jdk21u-dev] RFR: 8322477: order of subclasses in the permits clause can differ between compilations

[Martin Doerr]

On Fri, 1 Mar 2024 15:36:14 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I backport this for parity with 21.0.4-oracle.
> 
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java
> I had to resolve because indentation is different. Changed coding is the same.

Looks basically good. Only one minor thing below. https://bugs.openjdk.org/browse/JDK-8319987 would only resolve one trivial diff. Is that planned to be backported for 21.0.4, too? If nobody wants to backport that one very soon, I don't think we have to wait.

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 5495:

> 5493:                 if (!c.type.isCompound()) {
> 5494:                     for (ClassSymbol supertypeSym : sealedSupers) {
> 5495:                        if (!supertypeSym.isPermittedSubclass(c.type.tsym)) {

Indentation is off by one.

-------------

PR Review: https://git.openjdk.org/jdk21u-dev/pull/310#pullrequestreview-1914806586
PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/310#discussion_r1511464758