[jdk17u-dev] RFR: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch

[Martin Doerr]

On Wed, 28 Feb 2024 23:39:50 GMT, Amos Shi <ashi at openjdk.org> wrote:

> Backport of [JDK-8320943](https://bugs.openjdk.org/browse/JDK-8320943)
> - This PR has two commits
>   - commit 1 is the backport of the original [commit](https://github.com/openjdk/jdk/commit/87516e29dc5015c4cab2c07c5539ad30f2768667)
>   - commit 2 is fixing the compile and runtime issue on Java 17.
>     - Compile issue fixed: on Java 17 the class is `jdk.test.lib.Platform` and `jdk.test.lib.OSVersion`
>     - Runtime issue fixed: on Java 17 there is no mime `wasm`, so we comment it out
>       - `wasm` exists in Java 21: https://github.com/openjdk/jdk21u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties
>       - `wasm` does not exists in Java 17: https://github.com/openjdk/jdk17u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties 
> - So this is an unclean backport
> 
> Testing
> - Local: Test passed on Mac
>   - `Basic.java` - Test results: passed: 1
> 
> Mac machine
> 
> 
> MacBook Pro
> 16-inch, 2021
> Chip: Apple M1 Max
> MacOS: 14.3.1 (23D60)
> 
> 
> Windows machine: 
> 
> 
> Device name	W-PW05T4AD
> Processor	12th Gen Intel(R) Core(TM) i7-12800H   2.40 GHz
> Installed RAM	64.0 GB (63.7 GB usable)
> System type	64-bit operating system, x64-based processor
> 
> 
> - Pipeline: 
> - Testing Machine: SAP nightlies passed on `2024-03-01,02,03`

LGTM.

test/jdk/java/nio/file/Files/probeContentType/Basic.java line 188:

> 186:         exTypes.add(new ExType("xls", List.of("application/vnd.ms-excel")));
> 187:         exTypes.add(new ExType("xlsx", List.of("application/vnd.openxmlformats-officedocument.spreadsheetml.sheet")));
> 188:         // exTypes.add(new ExType("wasm", List.of("application/wasm")));

Ok, [JDK-8297609](https://bugs.openjdk.org/browse/JDK-8297609) is not in 17u. Can you add a comment explaining this, please?

-------------

PR Review: https://git.openjdk.org/jdk17u-dev/pull/2254#pullrequestreview-1924028531
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2254#discussion_r1517164039