[jdk17u-dev] RFR: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch [v2]

Martin Doerr mdoerr at openjdk.org
Tue Mar 12 12:08:20 UTC 2024


On Mon, 11 Mar 2024 18:49:39 GMT, Amos Shi <ashi at openjdk.org> wrote:

>> Backport of [JDK-8320943](https://bugs.openjdk.org/browse/JDK-8320943)
>> - This PR has two commits
>>   - commit 1 is the backport of the original [commit](https://github.com/openjdk/jdk/commit/87516e29dc5015c4cab2c07c5539ad30f2768667)
>>   - commit 2 is fixing the compile and runtime issue on Java 17.
>>     - Compile issue fixed: on Java 17 the class is `jdk.test.lib.Platform` and `jdk.test.lib.OSVersion`
>>     - Runtime issue fixed: on Java 17 there is no mime `wasm`, so we comment it out
>>       - `wasm` exists in Java 21: https://github.com/openjdk/jdk21u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties
>>       - `wasm` does not exists in Java 17: https://github.com/openjdk/jdk17u-dev/blob/master/src/java.base/windows/classes/sun/net/www/content-types.properties 
>>     - ✅ after [JDK-8297609](https://bugs.openjdk.org/browse/JDK-8297609) back ported to 17, `wasm` will be available
>> - So this is an unclean backport
>> 
>> Testing
>> - Local: Test passed on Mac
>>   - `Basic.java` - Test results: passed: 1
>> 
>> Mac machine
>> 
>> 
>> MacBook Pro
>> 16-inch, 2021
>> Chip: Apple M1 Max
>> MacOS: 14.3.1 (23D60)
>> 
>> 
>> Windows machine: 
>> 
>> 
>> Device name	W-PW05T4AD
>> Processor	12th Gen Intel(R) Core(TM) i7-12800H   2.40 GHz
>> Installed RAM	64.0 GB (63.7 GB usable)
>> System type	64-bit operating system, x64-based processor
>> 
>> 
>> - 💛 Pipeline: All `GHA Sanity Checks` passed except `linux-cross-compile / build (riscv64)`
>>   - ❌ It failed with message `Error: Unable to find an artifact with the name: bundles-linux-x64`
>>   - ✅ This error is on Linux riscv64 - which not caused by current test case, because current PR is for `Windows`
>> 
>> - Testing Machine: SAP nightlies passed on `2024-03-01,02,03`
>
> Amos Shi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8297609: Add notes for wasm type

I would have spent a separate line, but ok.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/2254#pullrequestreview-1930869193


More information about the jdk-updates-dev mailing list