[jdk21u-dev] RFR: 8324646: Avoid Class.forName in SecureRandom constructor [v2]

[Oli Gillespie]

On Tue, 12 Mar 2024 09:06:08 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Oli Gillespie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'master' into backport-olivergillespie-8ef918d6
>>  - Backport 8ef918d6678437a5b351b172bb4cf144eeaa975f
>
> @olivergillespie, please back port to 22, too, also, there are failing tests. removing the label

Thanks, sorry @GoeLin for not understanding the backport procedure properly. I thought approval came first, before final testing/review etc., my mistake!

Backport to 22 (approval requested): https://github.com/openjdk/jdk22u/pull/98

Tests are now passing after merging from master.

Benchmark results (`make test TEST=micro:org.openjdk.bench.java.security.SecureRandomBench`):


Before: 495 ± 6 ns/op
 After:  103 ± 1.6 ns/op


Hopefully I didn't miss anything this time, so I'll request approval again - thanks.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/258#issuecomment-1994079134