[jdk21u-dev] RFR: 8324174: assert(m->is_entered(current)) failed: invariant

[Goetz Lindenmaier]

On Wed, 6 Mar 2024 08:33:05 GMT, lusou-zhangquan <duke at openjdk.org> wrote:

> Clean backport from master to fix the incorrect lock and unlock order problem of nested locks during deoptimization.

Hi @lusou-zhangquan

> Hi @lusou-zhangquan, please follow the instructions in https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix and also see yesterdays mail https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-March/030685.htm


Please have a closer look at the link I posted above:

_Test the patch: testing is very important. Your backport is very close to the customer, with few safety nets. In comparison, patches for the mainline head release get much more cooking time before seeing broad adoption. Don't rely on maintainers doing testing for you! You should know your patch best and must make sure it works and does not introduce regressions._

_"tier1" tests should pass at all times. Use "make run-test TEST=tier1" to run. You should test both debug- and release builds. Don't just test one of them!
        If your patch changes platform-dependent code, test your patch on as many of those platforms as you have available. If you cannot test every platform but feel that tests are needed, clearly state so in the PR or in the Fix Request. Maintainers then will strive to fill the testing holes for you.
    "tier2" provides a larger coverage if you have the resources to run it. Use "make run-test TEST=tier2" to run
    Run tests from the area that the patch affects, use "make run-test TEST=<path-to-tests>" to run specific tests
    New regression tests that come with the patch should pass
    Enabling GitHub Actions for your personal fork of the jdk11u-dev repository before publishing your branch will provide you with builds and a tier 1 test run via GitHub Actions on many platforms.  If tests fail, analyze why they are failing and share this information._

Your testing is far from sufficient. As I understand you completely rely on GHA?  That is not enough for such a change.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/334#issuecomment-1997028650