[jdk17u-dev] RFR: 8295944: Move the Http2TestServer and related classes into a package of its own [v3]

[Lutz Schmidt]

On Fri, 22 Mar 2024 08:02:13 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I backport this to simplify further backports. It's a refactoring of test infra.
>> 
>> I had to do resolves of Copyright, imports, and @test descriptions. A row of tests are not in 17.
>> In detail:
>> 
>> 
>> test/jdk/java/net/httpclient/AsFileDownloadTest.java
>> Needs resolve because earlier changes were al
>> 
>> test/jdk/java/net/httpclient/AsyncExecutorShutdown.java
>> Introduced in 19 by "8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task"
>> This is a bug fix one wants to have in 17 at first sight, but it is a big change
>> and it had several follow ups. So better don't backport as prerequisite.
>> 
>> test/jdk/java/net/httpclient/CancelRequestTest.java
>> Resolved Copyright.
>> 
>> test/jdk/java/net/httpclient/CancelStreamedBodyTest.java
>> Introduced in 20 by "294916: Cancelling a request must eventually cause its response body subscriber to be unregistered"
>> This fix has many prereqs that would need to be backported. Omit.
>> 
>> test/jdk/java/net/httpclient/DigestEchoClient.java
>> Resolved Copyright.
>> 
>> test/jdk/java/net/httpclient/ExecutorShutdown.java
>> As above introduced by "8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task". Omit.
>> 
>> test/jdk/java/net/httpclient/ExpectContinueTest.java
>> Introduced in 20 by "8286171: HttpClient/2 : Expect:100-Continue blocks indefinitely when response is not 100"
>> 
>> test/jdk/java/net/httpclient/HeadTest.java
>> Resolved Copyright and imports.
>> "8276559: (httpclient) Consider adding an HttpRequest.Builder.HEAD method to build a HEAD request." which came in 18
>> is a new feature with CSR that changed the imports.
>> 
>> test/jdk/java/net/httpclient/HttpClientLocalAddrTest.java
>> Introduced in 19 by "8209137: Add ability to bind to specific local address to HTTP client". A new
>> feature. Omit.
>> 
>> test/jdk/java/net/httpclient/ISO_8859_1_Test.java
>> Resolved Copyright
>> 
>> test/jdk/java/net/httpclient/MappingResponseSubscriber.java
>> Resolved imports.
>> 
>> test/jdk/java/net/httpclient/Response1xxTest.java
>> Introduced in 20 by 8292044: HttpClient doesn't handle 102 or 103 properly. Omit.
>> 
>> 
>> test/jdk/java/net/httpclient/SpecialHeadersTest.java
>> Resolved due to context.
>> 
>> test/jdk/java/net/httpclient/http2/IdleConnectionTimeoutTest.java
>> Was added by 8288717: Add a means to close idle connections in HTTP/2 connection pool in 20. Omit.
>> 
>> test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java
>> Was added by 8263031: HttpClient throws Excep...
>
> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adapt ConnectionReuseTest

LGTM.

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/2311#pullrequestreview-1961041115