From fyang at openjdk.org Wed May 1 02:13:00 2024 From: fyang at openjdk.org (Fei Yang) Date: Wed, 1 May 2024 02:13:00 GMT Subject: [jdk22u] RFR: 8330094: RISC-V: Save and restore FRM in the call stub In-Reply-To: <2dRQpml8PB-IKbqJCV6891dqfJ3HQXD14EZNENS-qSQ=.6b677c69-8336-46d4-a01b-149ef2365a47@github.com> References: <2dRQpml8PB-IKbqJCV6891dqfJ3HQXD14EZNENS-qSQ=.6b677c69-8336-46d4-a01b-149ef2365a47@github.com> Message-ID: On Tue, 30 Apr 2024 13:25:35 GMT, Gui Cao wrote: > Hi, The same issue also exists in jdk22u. So I would like to backport [JDK-8330094](https://bugs.openjdk.org/browse/JDK-8330094) to jdk22u. With this change, we save and restore the default floating-point control state when we enter and leave Java code, ensuring that we are still Java compatible if we're called via the JNI invocation interface with a weird FP control state. RISC-V specific change, risk is low. > The backport is not clean because jdk22u has no [JDK-8321021](https://bugs.openjdk.org/browse/JDK-8321021) > > ### Testing > > - [x] Run tier1-3 tests on SOPHON SG2042 (release) LGTM. ------------- Marked as reviewed by fyang (Reviewer). PR Review: https://git.openjdk.org/jdk22u/pull/174#pullrequestreview-2032920021 From fyang at openjdk.org Wed May 1 02:14:58 2024 From: fyang at openjdk.org (Fei Yang) Date: Wed, 1 May 2024 02:14:58 GMT Subject: [jdk21u-dev] RFR: 8330094: RISC-V: Save and restore FRM in the call stub In-Reply-To: <2B3vamwo55G57VwribFkgwhRjNv1He6Lrm3U37dpfeU=.1136238d-1e6f-4656-a3d4-72a61fbc2339@github.com> References: <2B3vamwo55G57VwribFkgwhRjNv1He6Lrm3U37dpfeU=.1136238d-1e6f-4656-a3d4-72a61fbc2339@github.com> Message-ID: On Tue, 30 Apr 2024 13:08:50 GMT, Gui Cao wrote: > Hi, The same issue also exists in JDK21u. So I would like to backport [JDK-8330094](https://bugs.openjdk.org/browse/JDK-8330094) to jdk21u-dev. With this change, we save and restore the default floating-point control state when we enter and leave Java code, ensuring that we are still Java compatible if we're called via the JNI invocation interface with a weird FP control state. RISC-V specific change, risk is low. > The backport is not clean because jdk21u-dev has no [JDK-8321021](https://bugs.openjdk.org/browse/JDK-8321021) > > ### Testing > > - [x] Run tier1-3 tests on SOPHON SG2042 (release) LGTM. ------------- Marked as reviewed by fyang (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/545#pullrequestreview-2032922879 From fyang at openjdk.org Wed May 1 02:20:56 2024 From: fyang at openjdk.org (Fei Yang) Date: Wed, 1 May 2024 02:20:56 GMT Subject: [jdk17u-dev] RFR: 8330094: RISC-V: Save and restore FRM in the call stub In-Reply-To: References: Message-ID: On Tue, 30 Apr 2024 13:10:18 GMT, Gui Cao wrote: > Hi, The same issue also exists in JDK17u. So I would like to backport [JDK-8330094](https://bugs.openjdk.org/browse/JDK-8330094) to jdk17u-dev. With this change, we save and restore the default floating-point control state when we enter and leave Java code, ensuring that we are still Java compatible if we're called via the JNI invocation interface with a weird FP control state. RISC-V specific change, risk is low. > The backport is not clean because jdk17u-dev has no [JDK-8321021](https://bugs.openjdk.org/browse/JDK-8321021) > > ### Testing > > - [x] Run tier1-3 tests on SOPHON SG2042 (release) LGTM. ------------- Marked as reviewed by fyang (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2442#pullrequestreview-2032929025 From gcao at openjdk.org Wed May 1 03:09:27 2024 From: gcao at openjdk.org (Gui Cao) Date: Wed, 1 May 2024 03:09:27 GMT Subject: [jdk22u] RFR: 8330094: RISC-V: Save and restore FRM in the call stub [v2] In-Reply-To: <2dRQpml8PB-IKbqJCV6891dqfJ3HQXD14EZNENS-qSQ=.6b677c69-8336-46d4-a01b-149ef2365a47@github.com> References: <2dRQpml8PB-IKbqJCV6891dqfJ3HQXD14EZNENS-qSQ=.6b677c69-8336-46d4-a01b-149ef2365a47@github.com> Message-ID: > Hi, The same issue also exists in jdk22u. So I would like to backport [JDK-8330094](https://bugs.openjdk.org/browse/JDK-8330094) to jdk22u. With this change, we save and restore the default floating-point control state when we enter and leave Java code, ensuring that we are still Java compatible if we're called via the JNI invocation interface with a weird FP control state. RISC-V specific change, risk is low. > The backport is not clean because jdk22u has no [JDK-8321021](https://bugs.openjdk.org/browse/JDK-8321021) > > ### Testing > > - [x] Run tier1-3 tests on SOPHON SG2042 (release) Gui Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'upstream/master' into backport-JDK-8330094 - Backport 8330094: RISC-V: Save and restore FRM in the call stub ------------- Changes: - all: https://git.openjdk.org/jdk22u/pull/174/files - new: https://git.openjdk.org/jdk22u/pull/174/files/5ee0a979..4be7be7e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk22u&pr=174&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk22u&pr=174&range=00-01 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk22u/pull/174.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/174/head:pull/174 PR: https://git.openjdk.org/jdk22u/pull/174 From lucy at openjdk.org Wed May 1 11:01:57 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Wed, 1 May 2024 11:01:57 GMT Subject: [jdk22u] RFR: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space [v2] In-Reply-To: <4Uahqbvc2H5u7vIDQPJYBnpZJiccHggXL5_oOTbDEiQ=.65ae14ae-c4d5-40fc-ba23-da2e65bbcde2@github.com> References: <5abItkURdsTlX7DSg5uYhLYmY6MVklqwC8qCrggfBwI=.272d02f6-0554-4b8a-a6f2-5c4a08a13b39@github.com> <4Uahqbvc2H5u7vIDQPJYBnpZJiccHggXL5_oOTbDEiQ=.65ae14ae-c4d5-40fc-ba23-da2e65bbcde2@github.com> Message-ID: On Tue, 30 Apr 2024 12:21:40 GMT, Amit Kumar wrote: >> Hi all, >> >> This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. >> >> Thanks! > > Amit Kumar has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport d5f3d5c8cc347ae384dea25b1a55ed57204d1af3 LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk22u/pull/170#pullrequestreview-2033455285 From lucy at openjdk.org Wed May 1 11:05:55 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Wed, 1 May 2024 11:05:55 GMT Subject: [jdk22u] RFR: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: <5abItkURdsTlX7DSg5uYhLYmY6MVklqwC8qCrggfBwI=.272d02f6-0554-4b8a-a6f2-5c4a08a13b39@github.com> Message-ID: On Tue, 30 Apr 2024 12:16:37 GMT, Amit Kumar wrote: >> Hi all, >> >> This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. >> >> Thanks! > > NULL to nullptr change wasn't backported. So I got merge conflict in those lines. I'm marking it as clean, if it's not right, I'll be happy to go for formal review as well. > > cc: @RealLucy :-) > @offamitkumar Only OpenJDK [Committers](https://openjdk.org/bylaws#committer) can use the `/clean` command Sorry. My advice was wrong. I wasn't aware you need to be committer (in the jdk-updates project) to use /clean. Was a borderline case anyway for forced clean status. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/170#issuecomment-2088293646 From aivanov at openjdk.org Wed May 1 12:05:29 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Wed, 1 May 2024 12:05:29 GMT Subject: [jdk22u] RFR: 8331142: Add test for number of loader threads in BasicDirectoryModel Message-ID: Provides a regression test for [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in BasicDirectoryModel.validateFileCache_ which is backported to 22u. ------------- Commit messages: - Backport b2fb5ea13ba5087411410519213fc953ecc44618 Changes: https://git.openjdk.org/jdk22u/pull/175/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=175&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331142 Stats: 276 lines in 1 file changed: 276 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/175.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/175/head:pull/175 PR: https://git.openjdk.org/jdk22u/pull/175 From aivanov at openjdk.org Wed May 1 12:17:16 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Wed, 1 May 2024 12:17:16 GMT Subject: [jdk22u] RFR: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java Message-ID: Backporting [JDK-8329510](https://bugs.openjdk.org/browse/JDK-8329510) which updates the bugid under which `javax/swing/JFileChooser/8194044/FileSystemRootTest.java` is problem-listed. ------------- Commit messages: - Backport 747582484ce89e16661ef917a89adb52f5adc2e6 Changes: https://git.openjdk.org/jdk22u/pull/176/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=176&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329510 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/176.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/176/head:pull/176 PR: https://git.openjdk.org/jdk22u/pull/176 From prappo at openjdk.org Wed May 1 12:43:09 2024 From: prappo at openjdk.org (Pavel Rappo) Date: Wed, 1 May 2024 12:43:09 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v5] In-Reply-To: References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: On Mon, 29 Apr 2024 13:10:42 GMT, Pavel Rappo wrote: > What are the reasons that the option type was changed from that of the original commit? In the original commit it was eXtended, in this backport it is standard. @yukikimmura, @RealCLanger, @phohensee, if there are no reasons for that change in option type, then I believe it should be reverted. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1805#issuecomment-2088409079 From clanger at openjdk.org Wed May 1 15:21:04 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 1 May 2024 15:21:04 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v5] In-Reply-To: References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: On Wed, 1 May 2024 12:40:10 GMT, Pavel Rappo wrote: > > What are the reasons that the option type was changed from that of the original commit? In the original commit it was eXtended, in this backport it is standard. > > @yukikimmura, @RealCLanger, @phohensee, if there are no reasons for that change in option type, then I believe it should be reverted. @pavelrappo I was not involved in the review, I just discovered an issue with the test afterwards. However, I also can't see what exeactly you mean with the option type. Could you please elaborate this a bit more? Thanks ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1805#issuecomment-2088620469 From prappo at openjdk.org Wed May 1 15:38:02 2024 From: prappo at openjdk.org (Pavel Rappo) Date: Wed, 1 May 2024 15:38:02 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v5] In-Reply-To: References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: On Wed, 1 May 2024 12:40:10 GMT, Pavel Rappo wrote: >> What are the reasons that the option type was changed from that of the original commit? In the original commit it was eXtended, in this backport it is standard. > >> What are the reasons that the option type was changed from that of the original commit? In the original commit it was eXtended, in this backport it is standard. > > @yukikimmura, @RealCLanger, @phohensee, if there are no reasons for that change in option type, then I believe it should be reverted. > @pavelrappo I was not involved in the review, I just discovered an issue with the test afterwards. However, I also can't see what exeactly you mean with the option type. Could you please elaborate this a bit more? Thanks In the original commit, the new option is defined like this: new XOption(resources, "--legal-notices", 1) In this backport, the new option is defined like this: new Option(resources, "--legal-notices", 1) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1805#issuecomment-2088644279 From kyukihiro at openjdk.org Wed May 1 15:48:01 2024 From: kyukihiro at openjdk.org (Kimura Yukihiro) Date: Wed, 1 May 2024 15:48:01 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v5] In-Reply-To: References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: On Wed, 29 Mar 2023 06:42:36 GMT, Kimura Yukihiro wrote: >> I would like to backport >> JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. >> The original patch does not apply cleanly to 11u. >> Because the original patch has switch expressions which can not be used in 11u, >> and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. >> There is no risk, because the logic around the changes is the same as jdk17. >> I confirmed the following test and all langtool tests. >> test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java >> >> Could anyone review the fix please? > > Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: > > Revert backport e9f3e325c274f19b0f6eceea2367708e3be689e To the best of my recollection, I didn't intentionally change "XOption" to "Option." I believe it's a bug. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1805#issuecomment-2088658604 From prappo at openjdk.org Wed May 1 16:27:56 2024 From: prappo at openjdk.org (Pavel Rappo) Date: Wed, 1 May 2024 16:27:56 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v5] In-Reply-To: References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: On Wed, 1 May 2024 15:45:30 GMT, Kimura Yukihiro wrote: > To the best of my recollection, I didn't intentionally change "XOption" to "Option." I believe it's a bug. While this backport could've used `git range-diff` or some other tool to catch that issue, the original bug could've also provided a better test. Could you please publish a PR to fix the option type in jdk11u? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1805#issuecomment-2088722176 From aivanov at openjdk.org Wed May 1 17:01:16 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Wed, 1 May 2024 17:01:16 GMT Subject: [jdk22u] RFR: 8331142: Add test for number of loader threads in BasicDirectoryModel [v2] In-Reply-To: References: Message-ID: <-kSh2ZBKc8YcCFHA7bA97NOQgfrfV5cv8B-7EI3dfV8=.84d1c4dd-1641-4334-9499-7c0d0f89796e@github.com> > Provides a regression test for [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in BasicDirectoryModel.validateFileCache_ which is backported to 22u. Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision: 8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only Reviewed-by: prr ------------- Changes: - all: https://git.openjdk.org/jdk22u/pull/175/files - new: https://git.openjdk.org/jdk22u/pull/175/files/b5972e32..cae9ec53 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk22u&pr=175&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk22u&pr=175&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/175.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/175/head:pull/175 PR: https://git.openjdk.org/jdk22u/pull/175 From prr at openjdk.org Wed May 1 17:43:58 2024 From: prr at openjdk.org (Phil Race) Date: Wed, 1 May 2024 17:43:58 GMT Subject: [jdk22u] RFR: 8331142: Add test for number of loader threads in BasicDirectoryModel [v2] In-Reply-To: <-kSh2ZBKc8YcCFHA7bA97NOQgfrfV5cv8B-7EI3dfV8=.84d1c4dd-1641-4334-9499-7c0d0f89796e@github.com> References: <-kSh2ZBKc8YcCFHA7bA97NOQgfrfV5cv8B-7EI3dfV8=.84d1c4dd-1641-4334-9499-7c0d0f89796e@github.com> Message-ID: On Wed, 1 May 2024 17:01:16 GMT, Alexey Ivanov wrote: >> Provides a regression test for [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in BasicDirectoryModel.validateFileCache_ which is backported to 22u. > > Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision: > > 8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only > > Reviewed-by: prr Marked as reviewed by prr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk22u/pull/175#pullrequestreview-2034074908 From clanger at openjdk.org Wed May 1 17:48:05 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 1 May 2024 17:48:05 GMT Subject: [jdk22u] RFR: 8330523: Reduce runtime and improve efficiency of KeepAliveTest Message-ID: Hi all, This pull request contains a backport of [JDK-8330523](https://bugs.openjdk.org/browse/JDK-8330523), commit [16c7dcdb](https://github.com/openjdk/jdk/commit/16c7dcdb04a7c220684a20eb4a0da4505ae03813) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Christoph Langer on 27 Apr 2024 and was reviewed by Daniel Jeli?ski. Thanks! ------------- Commit messages: - Backport 16c7dcdb04a7c220684a20eb4a0da4505ae03813 Changes: https://git.openjdk.org/jdk22u/pull/177/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=177&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330523 Stats: 1230 lines in 1 file changed: 75 ins; 1012 del; 143 mod Patch: https://git.openjdk.org/jdk22u/pull/177.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/177/head:pull/177 PR: https://git.openjdk.org/jdk22u/pull/177 From clanger at openjdk.org Wed May 1 20:54:01 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 1 May 2024 20:54:01 GMT Subject: [jdk22u] RFR: 8330815: Use pattern matching for instanceof in KeepAliveCache Message-ID: <-70UJBlXsqy-YIoJ_YkIJyBXO8bcyFNeNC_yIkBqd0k=.c4838c1b-1015-43db-954a-a2830efb8986@github.com> Hi all, This pull request contains a backport of [JDK-8330815](https://bugs.openjdk.org/browse/JDK-8330815), commit [e818ab60](https://github.com/openjdk/jdk/commit/e818ab60a0c1dac277b8b15301cdfb7d439ed26c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Christoph Langer on 25 Apr 2024 and was reviewed by Jaikiran Pai and Daniel Jeli?ski. Thanks! ------------- Commit messages: - Backport e818ab60a0c1dac277b8b15301cdfb7d439ed26c Changes: https://git.openjdk.org/jdk22u/pull/178/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=178&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330815 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk22u/pull/178.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/178/head:pull/178 PR: https://git.openjdk.org/jdk22u/pull/178 From duke at openjdk.org Wed May 1 22:13:21 2024 From: duke at openjdk.org (Chad Rakoczy) Date: Wed, 1 May 2024 22:13:21 GMT Subject: [jdk21u-dev] RFR: 8325621: Improve jspawnhelper version checks Message-ID: <9zGCFY6H1ttbTVYikQOg0uJPj-ks9skbBLj_LXRkUS8=.ec494a74-36a6-436f-9bcf-bd48d7a1b1e2@github.com> Backport of [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621) Clean backport to update jspawnhelper to check that JDK version and jspawnhelper version are the same. Updates test to include check for version. GHA tests pass including the updated test. Risk is low: touches the production code paths but only passes an additional argument to jspawnhelper ------------- Commit messages: - Backport a232e8fb4e6e9e2e9a5285bf01c93b8d1d995f04 Changes: https://git.openjdk.org/jdk21u-dev/pull/547/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=547&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325621 Stats: 59 lines in 5 files changed: 47 ins; 4 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/547.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/547/head:pull/547 PR: https://git.openjdk.org/jdk21u-dev/pull/547 From kyukihiro at openjdk.org Wed May 1 22:50:09 2024 From: kyukihiro at openjdk.org (Kimura Yukihiro) Date: Wed, 1 May 2024 22:50:09 GMT Subject: [jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v5] In-Reply-To: References: <_a9Q9fFLkNQ1iA_UG2domwnbThVuY3uKz7aj9uPzDeE=.c94b7267-6300-403d-a7f3-c109e74a3125@github.com> Message-ID: On Wed, 29 Mar 2023 06:42:36 GMT, Kimura Yukihiro wrote: >> I would like to backport >> JDK-8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence. >> The original patch does not apply cleanly to 11u. >> Because the original patch has switch expressions which can not be used in 11u, >> and it has the Class jdk.javadoc.internal.doclets.formats.html.HtmlOptions which is not defined in 11u. >> There is no risk, because the logic around the changes is the same as jdk17. >> I confirmed the following test and all langtool tests. >> test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java >> >> Could anyone review the fix please? > > Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: > > Revert backport e9f3e325c274f19b0f6eceea2367708e3be689e Thank you for your comment and for pointing this out. Yes, I will make this correction. However, due to the long holiday in Japan, the office where I do my development work is closed, which will cause a slight delay in starting work. Thanks, Kimura Yukihiro ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1805#issuecomment-2089251594 From goetz at openjdk.org Thu May 2 08:27:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 2 May 2024 08:27:58 GMT Subject: [jdk21u-dev] RFR: 8328938: C2 SuperWord: disable vectorization for large stride and scale [v2] In-Reply-To: References: Message-ID: On Thu, 18 Apr 2024 15:57:49 GMT, Aleksey Shipilev wrote: >> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: >> >> Check if stride is actually con before touching iv_stride > > Thanks! Hi @shipilev, does the backport to 22 require a third version? Or would it be clean, or would the 21 version work for 22? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/495#issuecomment-2089886217 From shade at openjdk.org Thu May 2 08:30:02 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 2 May 2024 08:30:02 GMT Subject: [jdk21u-dev] Integrated: 8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks In-Reply-To: References: Message-ID: <31VQuoO9l59FNyosPPUE9H7rm2RRQpiTAbtBK9Oy9uM=.9ec82551-2e0e-4a3c-ad6e-dba460af5269@github.com> On Thu, 11 Apr 2024 06:45:44 GMT, Aleksey Shipilev wrote: > Clean backport to improve C2 reliability. > > Additional testing: > - [x] New test DOES NOT fail without the patch, passes with it > - [x] Linux x86_64 server fastdebug, `all` tests > - [x] Linux x86_64 server fastdebug, 100K Fuzzer tests > - [x] Linux x86_64 server fastdebug, Maven CTW tests This pull request has now been integrated. Changeset: 38920780 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/3892078094735be9d8074d23ce3d70201cd60445 Stats: 71 lines in 3 files changed: 62 ins; 0 del; 9 mod 8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks 8329163: C2: possible overflow in PhaseIdealLoop::extract_long_range_checks() Backport-of: cb2a6713596548d76c03912709656172b0bbcc76 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/488 From goetz at openjdk.org Thu May 2 08:34:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 2 May 2024 08:34:58 GMT Subject: [jdk21u-dev] RFR: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 16:44:26 GMT, Amit Kumar wrote: >>> There were conflicts in the copyright header. >> >> Ahh, >> Copyright header conflicts are considered negligible if only the years don't resolve. In that case, you can force the state to "clean" by adding the "/clean" tag. But only then. > >>you can force the state to "clean" by adding the "/clean" tag. > > ohh, thanks, I didn't know that it is possible to mark PR forcefully clean. I had missed it while looking at bot-commands. Hi @offamitkumar, you changed the Oracle Copyright. This is not part of the original change. Please revert that and the change will be clean. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/537#issuecomment-2089895663 From goetz at openjdk.org Thu May 2 08:34:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 2 May 2024 08:34:58 GMT Subject: [jdk21u-dev] RFR: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking In-Reply-To: References: Message-ID: On Fri, 26 Apr 2024 16:34:25 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [47df1459](https://github.com/openjdk/jdk/commit/47df14590c003ccb1607ec0edfe999fcf2aebd86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 10 Apr 2024 and was reviewed by Lutz Schmidt and Martin Doerr. > > Thanks! > > Benchmarking: > > ./build/linux-s390x-server-release/jdk/bin/java -Xms4g -Xmx4g -jar dacapo-9.12-MR1-bach.jar h2 -s huge -t 1 -n 1 > > Without the patch: > > ===== DaCapo 9.12-MR1 h2 PASSED in 209768 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 197472 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 222872 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 215725 msec ===== > > > with patch: > ===== DaCapo 9.12-MR1 h2 PASSED in 171055 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 169696 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 174032 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 167271 msec ===== The copyright dates must be the max of the date in the 21u repo and the date in the patch backported. No other changes to the copyright should be made. Also, please enable the GHA tests on your repo. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/537#issuecomment-2089897354 PR Comment: https://git.openjdk.org/jdk21u-dev/pull/537#issuecomment-2089898228 From burban at openjdk.org Thu May 2 08:50:57 2024 From: burban at openjdk.org (Bernhard Urban-Forster) Date: Thu, 2 May 2024 08:50:57 GMT Subject: [jdk21u-dev] RFR: 8326974: ODR violation in macroAssembler_aarch64.cpp In-Reply-To: References: Message-ID: On Fri, 26 Apr 2024 12:17:41 GMT, Bernhard Urban-Forster wrote: > This pull request contains a backport of commit [b972997a](https://github.com/openjdk/jdk/commit/b972997af76a506ffd79ee8c6043e7a8db836b33) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew Haley on 1 Mar 2024 and was reviewed by Andrew Dinn, Aleksey Shipilev and Guoxiong Li. > > Thanks! Thank you for sponsoring Aleksey! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/534#issuecomment-2089926366 From burban at openjdk.org Thu May 2 08:51:09 2024 From: burban at openjdk.org (Bernhard Urban-Forster) Date: Thu, 2 May 2024 08:51:09 GMT Subject: [jdk22u] RFR: 8326974: ODR violation in macroAssembler_aarch64.cpp In-Reply-To: References: Message-ID: On Thu, 25 Apr 2024 19:28:08 GMT, Bernhard Urban-Forster wrote: > This pull request contains a backport of commit [b972997a](https://github.com/openjdk/jdk/commit/b972997af76a506ffd79ee8c6043e7a8db836b33) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Andrew Haley on 1 Mar 2024 and was reviewed by Andrew Dinn, Aleksey Shipilev and Guoxiong Li. > > Thanks! Thank you for sponsoring Aleksey! ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/169#issuecomment-2089925990 From goetz at openjdk.org Thu May 2 08:56:59 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 2 May 2024 08:56:59 GMT Subject: [jdk21u-dev] RFR: 8330011: [s390x] update block-comments to make code consistent In-Reply-To: References: Message-ID: On Sat, 27 Apr 2024 05:54:18 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [01bda278](https://github.com/openjdk/jdk/commit/01bda278d6a498ca89c0bc5218680cd51a04e9d3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 17 Apr 2024 and was reviewed by Lutz Schmidt. > > Thanks! Hi Amit, here also tests are missing. Also, please elaborate on the Risk in your fix-request comments. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/539#issuecomment-2089936996 From amitkumar at openjdk.org Thu May 2 08:59:09 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Thu, 2 May 2024 08:59:09 GMT Subject: [jdk21u-dev] RFR: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [47df1459](https://github.com/openjdk/jdk/commit/47df14590c003ccb1607ec0edfe999fcf2aebd86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 10 Apr 2024 and was reviewed by Lutz Schmidt and Martin Doerr. > > Thanks! > > Benchmarking: > > ./build/linux-s390x-server-release/jdk/bin/java -Xms4g -Xmx4g -jar dacapo-9.12-MR1-bach.jar h2 -s huge -t 1 -n 1 > > Without the patch: > > ===== DaCapo 9.12-MR1 h2 PASSED in 209768 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 197472 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 222872 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 215725 msec ===== > > > with patch: > ===== DaCapo 9.12-MR1 h2 PASSED in 171055 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 169696 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 174032 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 167271 msec ===== Amit Kumar has updated the pull request incrementally with one additional commit since the last revision: revert oracle copyright headers ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/537/files - new: https://git.openjdk.org/jdk21u-dev/pull/537/files/50b25633..6d3ea211 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=537&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=537&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/537.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/537/head:pull/537 PR: https://git.openjdk.org/jdk21u-dev/pull/537 From amitkumar at openjdk.org Thu May 2 08:59:09 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Thu, 2 May 2024 08:59:09 GMT Subject: [jdk21u-dev] RFR: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 16:44:26 GMT, Amit Kumar wrote: >>> There were conflicts in the copyright header. >> >> Ahh, >> Copyright header conflicts are considered negligible if only the years don't resolve. In that case, you can force the state to "clean" by adding the "/clean" tag. But only then. > >>you can force the state to "clean" by adding the "/clean" tag. > > ohh, thanks, I didn't know that it is possible to mark PR forcefully clean. I had missed it while looking at bot-commands. >Hi @offamitkumar, you changed the Oracle Copyright. This is not part of the original change. Please revert that and the change will be clean. Nice, Thank you, Goetz ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/537#issuecomment-2089940800 From amitkumar at openjdk.org Thu May 2 09:01:59 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Thu, 2 May 2024 09:01:59 GMT Subject: [jdk21u-dev] RFR: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking In-Reply-To: References: Message-ID: On Fri, 26 Apr 2024 16:34:25 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [47df1459](https://github.com/openjdk/jdk/commit/47df14590c003ccb1607ec0edfe999fcf2aebd86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 10 Apr 2024 and was reviewed by Lutz Schmidt and Martin Doerr. > > Thanks! > > Benchmarking: > > ./build/linux-s390x-server-release/jdk/bin/java -Xms4g -Xmx4g -jar dacapo-9.12-MR1-bach.jar h2 -s huge -t 1 -n 1 > > Without the patch: > > ===== DaCapo 9.12-MR1 h2 PASSED in 209768 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 197472 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 222872 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 215725 msec ===== > > > with patch: > ===== DaCapo 9.12-MR1 h2 PASSED in 171055 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 169696 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 174032 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 167271 msec ===== Initially I thought that patch will be considered "clean" only if there are no merge-conflicts. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/537#issuecomment-2089944486 From goetz at openjdk.org Thu May 2 09:06:57 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 2 May 2024 09:06:57 GMT Subject: [jdk21u-dev] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 17:58:06 GMT, SendaoYan wrote: > Hi, > This is clean backport of JDK-8331164, to fixed download failure when the URL needed to be redirected. > Only change devkit shell script, the risk is low. Hi @sendaoYan , The fix request comment is missing. Please backport to 22 first. Think about waiting for October release started on May 29. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/543#issuecomment-2089953311 From ogillespie at openjdk.org Thu May 2 09:22:00 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 2 May 2024 09:22:00 GMT Subject: [jdk17u-dev] RFR: 8324646: Avoid Class.forName in SecureRandom constructor [v2] In-Reply-To: References: <79nQABORrgdOnW8JCbHlq37nuwnVc3o6OmrswojMzho=.0358f4b7-1f03-4716-b945-98d1f887c0bc@github.com> Message-ID: On Wed, 3 Apr 2024 08:43:26 GMT, Oli Gillespie wrote: >> Improve performance of SecureRandom constructor by backporting (both clean) two changes: >> >> 1. [JDK-8280970](https://bugs.openjdk.org/browse/JDK-8280970) removes some unused code in Provider.java. This is not really functionally needed, but it changes the same areas of code and makes the actual performance fix apply cleanly. >> 2. [JDK-8324646](https://bugs.openjdk.org/browse/JDK-8324646) is the actual performance fix - avoiding Class.forName calls in every construction. >> >> Note - because of the unused code still present in JDK17, there is actually an alternative fix which makes use of it, which is very simple: >> >> >> diff --git a/src/java.base/share/classes/java/security/Provider.java b/src/java.base/share/classes/java/security/Provider.java >> index af8ebeeda57..28bf642d0c8 100644 >> --- a/src/java.base/share/classes/java/security/Provider.java >> +++ b/src/java.base/share/classes/java/security/Provider.java >> @@ -1851,7 +1851,7 @@ public abstract class Provider extends Properties { >> null : constructorParameter.getClass(); >> } else { >> ctrParamClz = cap.constructorParameterClassName == null? >> - null : Class.forName(cap.constructorParameterClassName); >> + null : cap.getConstructorParameterClass(); // actually make use of the cached class! >> if (constructorParameter != null) { >> if (ctrParamClz == null) { >> throw new InvalidParameterException >> >> >> This has the same performance benefits as making the two backports. But, it means 17 will be diverged from later versions, and I think the backported fix is cleaner overall. >> >> Benchmark results (`make test TEST=micro:org.openjdk.bench.java.security.SecureRandomBench`): >> >> >> Before: 2614 ? 127 ns/op >> After: 2150 ? 116 ns/op > > Oli Gillespie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into backport-8324646-class-for-name-3 > - Backport 8ef918d6678437a5b351b172bb4cf144eeaa975f > - Backport 63e11cfa3f887515ca36ab5147c3e6fa540978d3 Waiting for next release to ask approval, since this is similar in nature to https://bugs.openjdk.org/browse/JDK-8324648. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2310#issuecomment-2089991306 From ogillespie at openjdk.org Thu May 2 09:23:02 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 2 May 2024 09:23:02 GMT Subject: [jdk17u-dev] RFR: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG [v2] In-Reply-To: References: Message-ID: <7FqkLKjLgfcJAR4s4VHQH3j19nv69QgCH3c8XphtzEg=.56137636-74a2-4132-9404-bf42c985d02d@github.com> On Wed, 3 Apr 2024 08:44:39 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [69b2674c](https://github.com/openjdk/jdk/commit/69b2674c6861fdb7d9f9cb39e07d50515c73e33a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Oli Gillespie on 9 Feb 2024 and was reviewed by Aleksey Shipilev, Weijun Wang, Chen Liang and Valerie Peng. >> >> I had to manually resolve the copyright change, but apart from that it's clean. >> >> Benchmark results (`make test TEST=micro:org.openjdk.bench.java.security.SecureRandomBench`, using the benchmark from https://github.com/openjdk/jdk/pull/17559): >> >> >> Before: 2614 ? 127 ns/op >> After: 508 ? 7 ns/op >> ``` >> >> Thanks! > > Oli Gillespie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into backport-8324648-nsme > - Backport 69b2674c6861fdb7d9f9cb39e07d50515c73e33a Waiting for next release for approval as requested. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2308#issuecomment-2089991811 From amitkumar at openjdk.org Thu May 2 09:35:29 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Thu, 2 May 2024 09:35:29 GMT Subject: [jdk21u-dev] RFR: 8330011: [s390x] update block-comments to make code consistent [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [01bda278](https://github.com/openjdk/jdk/commit/01bda278d6a498ca89c0bc5218680cd51a04e9d3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 17 Apr 2024 and was reviewed by Lutz Schmidt. > > Thanks! Amit Kumar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into backport-offamitkumar-01bda278 - Backport 01bda278d6a498ca89c0bc5218680cd51a04e9d3 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/539/files - new: https://git.openjdk.org/jdk21u-dev/pull/539/files/5b91fd15..596a9d0d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=539&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=539&range=00-01 Stats: 1040 lines in 125 files changed: 501 ins; 228 del; 311 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/539.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/539/head:pull/539 PR: https://git.openjdk.org/jdk21u-dev/pull/539 From shade at openjdk.org Thu May 2 09:35:55 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 2 May 2024 09:35:55 GMT Subject: [jdk21u-dev] RFR: 8328938: C2 SuperWord: disable vectorization for large stride and scale [v2] In-Reply-To: References: Message-ID: On Thu, 18 Apr 2024 15:57:49 GMT, Aleksey Shipilev wrote: >> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: >> >> Check if stride is actually con before touching iv_stride > > Thanks! > Hi @shipilev, does the backport to 22 require a third version? Or would it be clean, or would the 21 version work for 22? Yes, JDK 22 version would be a third variant. Neither JDK 23 nor JDK 21 version works there cleanly. So I would prefer to just leave JDK 22 be. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/495#issuecomment-2090017252 From goetz.lindenmaier at sap.com Thu May 2 10:14:10 2024 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 2 May 2024 10:14:10 +0000 Subject: SAP will terminate efforts in jdk11u after the October release 11.0.25 Message-ID: Dear OpenJDK updates community! I want to announce that SAP steps back from the jdk11u updates project after the October 2024 release 11.0.25. All our customer and internal usages of SapMachine 11 will have been moved to SapMachine 17 or 21 so that we can terminate support of SapMachine 11 by December 2024 as previously announced. We will have helped Red Hat, the lead of the jdk11u updates project, to maintain OpenJDK 11u through 23 releases, all the way from 11.0.3 to 11.0.25 by then. We want to thank Red Hat to have us in the project, and also Oracle and everybody from the community in helping maintain 11u so far. In detail we will terminate our efforts to * backport fixes to jdk11u * tag releases of jdk11u * approve backport requests * bundle and push the embargoed security changes * testing of the OpenJDK 11u repositories * update the project related wiki pages after the October 11.0.25 release. We will still be available to help with changes in the ppc port or any issues where we can help with our experience in OpenJDK wrt. jdk11u. Also we will help to take care of 11.0.25 during its lifetime, i.e., in case a patch release is necessary. But for now there is still some work to do to get 11.0.24 and 11.0.25 out of the door! Naturally, we will continue our support of the jdk17u and jdk21u updates projects. Best regards, Goetz. -------------- next part -------------- An HTML attachment was scrubbed... URL: From goetz at openjdk.org Thu May 2 11:20:11 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 2 May 2024 11:20:11 GMT Subject: [jdk21u-dev] RFR: 8310228: Improve error reporting for uncaught native exceptions on Windows [v3] In-Reply-To: <680TRW-ipLTBYJ7-KQxshXyOKLB82yCnA_Tn2FOWpHY=.ce8dd5bc-9238-4034-a067-d0a74d65e9ac@github.com> References: <680TRW-ipLTBYJ7-KQxshXyOKLB82yCnA_Tn2FOWpHY=.ce8dd5bc-9238-4034-a067-d0a74d65e9ac@github.com> Message-ID: > A bugfix useful for windows. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into backport-GoeLin-38bf1192 - Adapt to 8321713 - Merge branch 'openjdk:master' into backport-GoeLin-38bf1192 - Backport 38bf1192b637cf3513cb25ac21f513bfb51cb55b ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/510/files - new: https://git.openjdk.org/jdk21u-dev/pull/510/files/7f33808c..569a244f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=510&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=510&range=01-02 Stats: 356 lines in 35 files changed: 275 ins; 32 del; 49 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/510.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/510/head:pull/510 PR: https://git.openjdk.org/jdk21u-dev/pull/510 From goetz at openjdk.org Thu May 2 11:20:12 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 2 May 2024 11:20:12 GMT Subject: [jdk21u-dev] RFR: 8310228: Improve error reporting for uncaught native exceptions on Windows [v2] In-Reply-To: References: <680TRW-ipLTBYJ7-KQxshXyOKLB82yCnA_Tn2FOWpHY=.ce8dd5bc-9238-4034-a067-d0a74d65e9ac@github.com> Message-ID: On Mon, 29 Apr 2024 09:32:24 GMT, Goetz Lindenmaier wrote: >> A bugfix useful for windows. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Adapt to 8321713 > - Merge branch 'openjdk:master' into backport-GoeLin-38bf1192 > - Backport 38bf1192b637cf3513cb25ac21f513bfb51cb55b Hi @stuefe, good point windows is essential here :) I restarted the tests. After the report of @Rigner I'm not so sure I should proceed with this. What do you think, is this useful for 21? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/510#issuecomment-2090246659 From goetz at openjdk.org Thu May 2 11:35:01 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 2 May 2024 11:35:01 GMT Subject: [jdk21u-dev] RFR: 8317007: Add bulk removal of dead nmethods during class unloading Message-ID: <_ru1bYUSOaylnCMA1-yLX3xwsC1ZfU_gUOvhfqvJmVs=.a1779d4d-9e54-4449-9b30-98b91fe9cb63@github.com> I backport this for parity with 21.0.4-oracle. Clean patch on top of 8317809. ------------- Depends on: https://git.openjdk.org/jdk21u-dev/pull/505 Commit messages: - Backport f55381950266088cc0284754b16663675867ac87 Changes: https://git.openjdk.org/jdk21u-dev/pull/548/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=548&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317007 Stats: 194 lines in 27 files changed: 129 ins; 43 del; 22 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/548.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/548/head:pull/548 PR: https://git.openjdk.org/jdk21u-dev/pull/548 From sgehwolf at openjdk.org Thu May 2 11:49:56 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 2 May 2024 11:49:56 GMT Subject: [jdk21u-dev] RFR: 8317809: Insertion of free code blobs into code cache can be very slow during class unloading [v2] In-Reply-To: References: Message-ID: On Tue, 23 Apr 2024 07:40:07 GMT, Goetz Lindenmaier wrote: >> Big change, but only two resolves needed: >> >> src/hotspot/share/gc/g1/g1ConcurrentMark.cpp >> The context differs because "8309538: G1: Move total collection increment from Cleanup to Remark" >> is only in 22 >> >> src/hotspot/share/gc/serial/genMarkSweep.cpp >> Resolved adding an #include. >> >> SAP nightly testing passed. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'openjdk:master' into goetz_backport_8317809-keep > - Merge branch 'openjdk:master' into goetz_backport_8317809-keep > - Merge branch 'openjdk:master' into goetz_backport_8317809-keep > - Resolved hunks > - Backport 30817b742300f10f566e6aee3a8c1f8af4ab3083 @adinn Could you please review this? Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/505#issuecomment-2090302673 From lucy at openjdk.org Thu May 2 12:07:02 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Thu, 2 May 2024 12:07:02 GMT Subject: [jdk11u-dev] RFR: 8310818: Refactor more Locale tests to use JUnit In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 10:02:31 GMT, Andrew Lu wrote: > This PR contains a backport of > https://github.com/openjdk/jdk/commit/12e943091071b02b5756b57527a5f86a3d881cb8 > Patch is not clean, this class test/jdk/java/util/Locale/ISO639.java contains the Text Blocks > System.out.printf(""" > Arguments.of("%s","%s","%s"), > """, iso639_1, iso639_2B, iso639_2T); > But in jdk11 the Text Blocks is not supported, I modified the code to > System.out.printf("Arguments.of("%s","%s","%s"),\n", iso639_1, iso639_2B, iso639_2T); > Other than these the rest of the code is clean. LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2693#pullrequestreview-2035561029 From shade at openjdk.org Thu May 2 12:29:56 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 2 May 2024 12:29:56 GMT Subject: [jdk21u-dev] Integrated: 8328822: C2: "negative trip count?" assert failure in profile predicate code In-Reply-To: References: Message-ID: <89BSFe3k9eS0qI_Kq3arP5ijpy2NKTy3XfsDBbj-06E=.93b587bb-d574-4aaf-81fd-38436de96e50@github.com> On Fri, 12 Apr 2024 11:54:44 GMT, Aleksey Shipilev wrote: > Simple corner case fix in C2. > > Additional testing: > - [x] New regression test fails without the fix, passes with it > - [x] Linux x86_64 server fastdebug, `all` > - [x] Linux x86_64 server fastdebug, 100K Fuzzer tests > - [x] Linux x86_64 server fastdebug, Maven CTW tests This pull request has now been integrated. Changeset: 87d5da4f Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/87d5da4f4f61bde5125b2534cd059a5772f991b7 Stats: 65 lines in 2 files changed: 64 ins; 0 del; 1 mod 8328822: C2: "negative trip count?" assert failure in profile predicate code Backport-of: 2ceeb6c00135310b7bdabacb92d26d81de525240 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/497 From adinn at openjdk.org Thu May 2 12:36:53 2024 From: adinn at openjdk.org (Andrew Dinn) Date: Thu, 2 May 2024 12:36:53 GMT Subject: [jdk21u-dev] RFR: 8317809: Insertion of free code blobs into code cache can be very slow during class unloading [v2] In-Reply-To: References: Message-ID: <1KcGPM_PFJOvG_DWnUCfuDoZbMO-2D9P8WXKA9n-eJs=.7d15e2ea-4f63-4b55-becc-47b3ec9f5b87@github.com> On Tue, 23 Apr 2024 07:40:07 GMT, Goetz Lindenmaier wrote: >> Big change, but only two resolves needed: >> >> src/hotspot/share/gc/g1/g1ConcurrentMark.cpp >> The context differs because "8309538: G1: Move total collection increment from Cleanup to Remark" >> is only in 22 >> >> src/hotspot/share/gc/serial/genMarkSweep.cpp >> Resolved adding an #include. >> >> SAP nightly testing passed. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'openjdk:master' into goetz_backport_8317809-keep > - Merge branch 'openjdk:master' into goetz_backport_8317809-keep > - Merge branch 'openjdk:master' into goetz_backport_8317809-keep > - Resolved hunks > - Backport 30817b742300f10f566e6aee3a8c1f8af4ab3083 Marked as reviewed by adinn (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/505#pullrequestreview-2035620467 From adinn at openjdk.org Thu May 2 12:36:54 2024 From: adinn at openjdk.org (Andrew Dinn) Date: Thu, 2 May 2024 12:36:54 GMT Subject: [jdk21u-dev] RFR: 8317809: Insertion of free code blobs into code cache can be very slow during class unloading [v2] In-Reply-To: References: Message-ID: On Thu, 2 May 2024 11:46:57 GMT, Severin Gehwolf wrote: >> Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: >> >> - Merge branch 'openjdk:master' into goetz_backport_8317809-keep >> - Merge branch 'openjdk:master' into goetz_backport_8317809-keep >> - Merge branch 'openjdk:master' into goetz_backport_8317809-keep >> - Resolved hunks >> - Backport 30817b742300f10f566e6aee3a8c1f8af4ab3083 > > @adinn Could you please review this? Thanks! @jerboaa Looks ok to me. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/505#issuecomment-2090387932 From shade at openjdk.org Thu May 2 12:41:22 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 2 May 2024 12:41:22 GMT Subject: [jdk22u] RFR: 8328822: C2: "negative trip count?" assert failure in profile predicate code Message-ID: Simple corner case fix in C2. Additional testing: - [x] New regression test fails without the fix, passes with it ------------- Commit messages: - Backport 2ceeb6c00135310b7bdabacb92d26d81de525240 Changes: https://git.openjdk.org/jdk22u/pull/179/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=179&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328822 Stats: 65 lines in 2 files changed: 64 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/179.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/179/head:pull/179 PR: https://git.openjdk.org/jdk22u/pull/179 From lucy at openjdk.org Thu May 2 12:52:01 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Thu, 2 May 2024 12:52:01 GMT Subject: [jdk11u-dev] RFR: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer In-Reply-To: References: Message-ID: On Tue, 30 Apr 2024 09:23:08 GMT, Andrew Lu wrote: > As the description in testing.html and testing.md is added in JDK-8231351, so backport for it together. > some small change is not in testing.html, so ignore it. > test/jdk/ProblemList.txt > remain the > "sun/security/tools/keytool/NssTest.java 8204203 linux-all,windows-all" > others clean. LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2694#pullrequestreview-2035654489 From jvernee at openjdk.org Thu May 2 12:53:54 2024 From: jvernee at openjdk.org (Jorn Vernee) Date: Thu, 2 May 2024 12:53:54 GMT Subject: [jdk21u-dev] RFR: 8310228: Improve error reporting for uncaught native exceptions on Windows In-Reply-To: References: <680TRW-ipLTBYJ7-KQxshXyOKLB82yCnA_Tn2FOWpHY=.ce8dd5bc-9238-4034-a067-d0a74d65e9ac@github.com> Message-ID: On Sat, 20 Apr 2024 14:55:21 GMT, Rigner wrote: > Hey, sorry if it's not the right place for this, but I felt like I could add some more information to this bug. > > I've been having this issue locally when trying to migrate some native code to Java 21+. I can even reproduce it on Java 22 / 23 when native code is throwing an `Access Violation (C0000005)`. > > Did we have confirmation that the issue was properly fixed for all cases with that commit ? > > Here's my WinDbg output on Java 23 (same for 21/22): > > ``` > ModLoad: 00007ff8`5fcf0000 00007ff8`5fd5a000 C:\Windows\system32\mswsock.dll > ModLoad: 00007ff8`5f9b0000 00007ff8`5f9eb000 C:\Windows\SYSTEM32\iphlpapi.dll > ModLoad: 00007ff8`5ff50000 00007ff8`5ff68000 C:\Windows\SYSTEM32\CRYPTSP.dll > ModLoad: 00007ff8`5f5d0000 00007ff8`5f604000 C:\Windows\system32\rsaenh.dll > ModLoad: 00007ff8`309c0000 00007ff8`309de000 C:\Program Files\Java\jdk-23\bin\java.dll > ModLoad: 00007ff8`61980000 00007ff8`61aab000 C:\Windows\System32\ole32.dll > ModLoad: 00007ff8`61d70000 00007ff8`620c3000 C:\Windows\System32\combase.dll > (f61c.10030): Access violation - code c0000005 (first chance) > First chance exceptions are reported before any exception handling. > This exception may be expected and handled. > 000001f4`0d33094e 8b06 mov eax,dword ptr [rsi] ds:00000000`00000000=???????? > 0:004> g > ModLoad: 00007ff8`5e630000 00007ff8`5edce000 C:\Windows\SYSTEM32\windows.storage.dll > ModLoad: 00007ff8`5ff10000 00007ff8`5ff3e000 C:\Windows\SYSTEM32\Wldp.dll > ModLoad: 00007ff8`610c0000 00007ff8`6118d000 C:\Windows\System32\OLEAUT32.dll > ModLoad: 00007ff8`61510000 00007ff8`615bd000 C:\Windows\System32\SHCORE.dll > ModLoad: 00007ff8`625e0000 00007ff8`62635000 C:\Windows\System32\shlwapi.dll > ModLoad: 00007ff8`604f0000 00007ff8`60515000 C:\Windows\SYSTEM32\profapi.dll > ModLoad: 00007fff`f4350000 00007fff`f4427000 C:\Program Files\Java\jdk-23\bin\jsvml.dll > (f61c.10030): Stack overflow - code c00000fd (first chance) > First chance exceptions are reported before any exception handling. > This exception may be expected and handled. > jvm!verify+0x89e57: > 00007fff`845598b7 e8b4b30d00 call jvm!AsyncGetCallTrace+0xcf5e0 (00007fff`84634c70) > ``` > > That native code is working fine for Java 8 / 17 btw. If I modify the test code to throw an `EXCEPTION_ACCESS_VIOLATION` I still see an hs_err log being produced, just not containing the text "Internal Error". This matches what I remember from the debugging I did around the original fix as well. The access violation in your log is expected, FWIW. It is always thrown at VM startup. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/510#issuecomment-2090427520 From mbaesken at openjdk.org Thu May 2 13:51:06 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 2 May 2024 13:51:06 GMT Subject: [jdk11u-dev] RFR: 8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows In-Reply-To: References: Message-ID: On Fri, 26 Apr 2024 21:36:32 GMT, Amos Shi wrote: > Backport of [JDK-8253980](https://bugs.openjdk.org/browse/JDK-8253980) > - This PR contains two commits > - Commit 1: is a de facto clean back port of original commit > - `bug7158712.java` is a **clean** `git apply` > - `ProblemList.txt` is a manual change based on original commit, can be `considered as clean` > - Commit 2 > - A line `popup.show()` has been added to avoid the test case failure with message: > - **IllegalComponentStateException: component must be showing on the screen to determine its location** > > Testing > - Local: Test passed > - `bug7158712.java`: Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies `SKIPPED` on `2024-04-28` > - Automated jtreg test: jtreg_jdk_tier4 > - `javax/swing/plaf/synth/7158712/bug7158712.java`: `SKIPPED` [Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub ? - [0 msec] Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2688#pullrequestreview-2027704855 From mbaesken at openjdk.org Thu May 2 13:51:07 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 2 May 2024 13:51:07 GMT Subject: [jdk11u-dev] RFR: 8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows In-Reply-To: References: Message-ID: On Fri, 26 Apr 2024 21:37:45 GMT, Amos Shi wrote: >> Backport of [JDK-8253980](https://bugs.openjdk.org/browse/JDK-8253980) >> - This PR contains two commits >> - Commit 1: is a de facto clean back port of original commit >> - `bug7158712.java` is a **clean** `git apply` >> - `ProblemList.txt` is a manual change based on original commit, can be `considered as clean` >> - Commit 2 >> - A line `popup.show()` has been added to avoid the test case failure with message: >> - **IllegalComponentStateException: component must be showing on the screen to determine its location** >> >> Testing >> - Local: Test passed >> - `bug7158712.java`: Test results: passed: 1 >> - Pipeline: All checks have passed >> - Testing Machine: SAP nightlies `SKIPPED` on `2024-04-28` >> - Automated jtreg test: jtreg_jdk_tier4 >> - `javax/swing/plaf/synth/7158712/bug7158712.java`: `SKIPPED` [Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub ? - [0 msec] > > test/jdk/javax/swing/plaf/synth/7158712/bug7158712.java line 110: > >> 108: BasicComboPopup popup = (BasicComboPopup) comboBox.getAccessibleContext().getAccessibleChild(0); >> 109: popup.show(); >> 110: > > Adding this line to fix the following test case failure: > - **IllegalComponentStateException: component must be showing on the screen to determine its location** > > > java.lang.reflect.InvocationTargetException > at java.desktop/java.awt.EventQueue.invokeAndWait(EventQueue.java:1367) > at java.desktop/java.awt.EventQueue.invokeAndWait(EventQueue.java:1342) > at java.desktop/javax.swing.SwingUtilities.invokeAndWait(SwingUtilities.java:1480) > at bug7158712.main(bug7158712.java:105) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.lang.reflect.Method.invoke(Method.java:566) > at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138) > at java.base/java.lang.Thread.run(Thread.java:829) > Caused by: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location > at java.desktop/java.awt.Component.getLocationOnScreen_NoTreeLock(Component.java:2101) > at java.desktop/java.awt.Component.getLocationOnScreen(Component.java:2075) > at bug7158712$3.run(bug7158712.java:110) > at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:303) > at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:770) > at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721) > at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715) > at java.base/java.security.AccessController.doPrivileged(Native Method) > at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85) > at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:740) > at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203) > at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124) > at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113) > at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109) > at java.desktop/java.awt.EventDispatchThre... Why is the `popup.show()` not needed in higher releases ? Is there maybe some other backport missing? ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2688#discussion_r1582620085 From syan at openjdk.org Thu May 2 13:56:00 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 2 May 2024 13:56:00 GMT Subject: [jdk21u-dev] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: References: Message-ID: On Thu, 2 May 2024 09:03:50 GMT, Goetz Lindenmaier wrote: > Hi @sendaoYan , The fix request comment is missing. Please backport to 22 first. Think about waiting for October release started on May 29. OK, thanks for the advice. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/543#issuecomment-2090559163 From syan at openjdk.org Thu May 2 14:05:06 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 2 May 2024 14:05:06 GMT Subject: [jdk22u] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected Message-ID: Hi, This is clean backport of JDK-8331164, to fixed download failure when the URL needed to be redirected. Only change devkit shell script, the risk is low. ------------- Commit messages: - Backport eb88343fb763ee89010b7a9879638152decc6892 Changes: https://git.openjdk.org/jdk22u/pull/180/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=180&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331164 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/180.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/180/head:pull/180 PR: https://git.openjdk.org/jdk22u/pull/180 From tschatzl at openjdk.org Thu May 2 14:12:01 2024 From: tschatzl at openjdk.org (Thomas Schatzl) Date: Thu, 2 May 2024 14:12:01 GMT Subject: [jdk21u-dev] RFR: 8317809: Insertion of free code blobs into code cache can be very slow during class unloading [v2] In-Reply-To: References: Message-ID: On Fri, 26 Apr 2024 08:09:04 GMT, Goetz Lindenmaier wrote: > Especially as you had to backout ([JDK-8329524](https://bugs.openjdk.org/browse/JDK-8329524)/[JDK-8329530](https://bugs.openjdk.org/browse/JDK-8329530)) your first backport, is there a subtle adaption needed I missed? The backport was due to wrongly resolving the hunk in g1ConcurrentMark.cpp. Afaict that issue has been resolved correctly. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/505#issuecomment-2090593073 From zgu at openjdk.org Thu May 2 14:16:59 2024 From: zgu at openjdk.org (Zhengyu Gu) Date: Thu, 2 May 2024 14:16:59 GMT Subject: [jdk21u-dev] RFR: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded In-Reply-To: References: Message-ID: On Tue, 30 Apr 2024 14:39:47 GMT, Zhengyu Gu wrote: > Backport [JDK-8328744](https://bugs.openjdk.org/browse/JDK-8328744) to 21u, as it is a p2 bug. Approved ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/546#issuecomment-2090602658 From zgu at openjdk.org Thu May 2 14:17:00 2024 From: zgu at openjdk.org (Zhengyu Gu) Date: Thu, 2 May 2024 14:17:00 GMT Subject: [jdk21u-dev] Integrated: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded In-Reply-To: References: Message-ID: On Tue, 30 Apr 2024 14:39:47 GMT, Zhengyu Gu wrote: > Backport [JDK-8328744](https://bugs.openjdk.org/browse/JDK-8328744) to 21u, as it is a p2 bug. This pull request has now been integrated. Changeset: a4d8d061 Author: Zhengyu Gu URL: https://git.openjdk.org/jdk21u-dev/commit/a4d8d061a8a694502a085b444a480fa3211a07dc Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded Backport-of: bf8146eac24ba8e00d1794ef7134ecf2476cf897 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/546 From goetz at openjdk.org Thu May 2 15:29:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 2 May 2024 15:29:58 GMT Subject: [jdk21u-dev] RFR: 8317809: Insertion of free code blobs into code cache can be very slow during class unloading [v2] In-Reply-To: References: Message-ID: On Thu, 2 May 2024 14:09:10 GMT, Thomas Schatzl wrote: >> @tschatzl would you mind to take a look at this change? >> >> Especially as you had to backout ([JDK-8329524](https://bugs.openjdk.org/browse/JDK-8329524)/[JDK-8329530](https://bugs.openjdk.org/browse/JDK-8329530)) your first backport, is there a subtle adaption needed I missed? >> >> Thanks! Goetz. > >> Especially as you had to backout ([JDK-8329524](https://bugs.openjdk.org/browse/JDK-8329524)/[JDK-8329530](https://bugs.openjdk.org/browse/JDK-8329530)) your first backport, is there a subtle adaption needed I missed? > > The backport was due to wrongly resolving the hunk in g1ConcurrentMark.cpp. Afaict that issue has been resolved correctly. Thanks for having a look, @tschatzl! Thanks for the review, @adinn. Best regards, Goetz. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/505#issuecomment-2090807506 From duke at openjdk.org Thu May 2 16:27:56 2024 From: duke at openjdk.org (Rigner) Date: Thu, 2 May 2024 16:27:56 GMT Subject: [jdk21u-dev] RFR: 8310228: Improve error reporting for uncaught native exceptions on Windows In-Reply-To: References: <680TRW-ipLTBYJ7-KQxshXyOKLB82yCnA_Tn2FOWpHY=.ce8dd5bc-9238-4034-a067-d0a74d65e9ac@github.com> Message-ID: <9RRDfVCTQ0o-6kT9KlccrXF7A071GXeFFUHf-YVEE6w=.12763dba-c58a-4802-b267-0164a444311e@github.com> On Thu, 2 May 2024 12:51:35 GMT, Jorn Vernee wrote: > If I modify the test code to throw an `EXCEPTION_ACCESS_VIOLATION` I still see an hs_err log being produced, just not containing the text "Internal Error". This matches what I remember from the debugging I did around the original fix as well. > > The access violation in your log is expected, FWIW. It is always thrown at VM startup. That makes sense since I was not able to debug that specific access violation. I was able to pinpoint the cause of my crash, was because of some JNI `FindClass()` calls early in the startup, while some internal JDK classes were loaded (Calling `FindClass()` in agent `ClassFileLoadHook` hook to load a class as early as possible, works fine on JDK <= 17 but crashes on 18+ _(don't ask me why we're doing this, I know it's awful)_). I'm not sure what signal / exception is actually being thrown but it's definitely triggering a stack overflow in the error reporting, so maybe one specific error isn't handled properly ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/510#issuecomment-2090959476 From shade at openjdk.org Thu May 2 17:53:53 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 2 May 2024 17:53:53 GMT Subject: [jdk22u] Integrated: 8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0 In-Reply-To: <1G8O0V8HOXFUVbf6ohT24365yYJ12FHGv3YrQYUwLjI=.b7e55118-53bb-4e76-bde6-40a2af2baa46@github.com> References: <1G8O0V8HOXFUVbf6ohT24365yYJ12FHGv3YrQYUwLjI=.b7e55118-53bb-4e76-bde6-40a2af2baa46@github.com> Message-ID: On Mon, 29 Apr 2024 08:54:54 GMT, Aleksey Shipilev wrote: > Fixes the JDK 21 regression. Simple fix. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `jdk/jshell` passes This pull request has now been integrated. Changeset: d2e1ea47 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/d2e1ea47c4409578e1577de28d4f84f107ed598f Stats: 16 lines in 2 files changed: 0 ins; 0 del; 16 mod 8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0 Backport-of: 87e864bf21d71daae4e001ec4edbb4ef1f60c36d ------------- PR: https://git.openjdk.org/jdk22u/pull/172 From stuefe at openjdk.org Thu May 2 18:39:56 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 2 May 2024 18:39:56 GMT Subject: [jdk21u-dev] RFR: 8310228: Improve error reporting for uncaught native exceptions on Windows [v3] In-Reply-To: References: <680TRW-ipLTBYJ7-KQxshXyOKLB82yCnA_Tn2FOWpHY=.ce8dd5bc-9238-4034-a067-d0a74d65e9ac@github.com> Message-ID: <7_INcdZJ812nY5M8VH9I4T6IMp4fdWcLxazxQBOZjoA=.768b0a24-3a24-4197-954a-d6442edb3c18@github.com> On Thu, 2 May 2024 11:20:11 GMT, Goetz Lindenmaier wrote: >> A bugfix useful for windows. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-GoeLin-38bf1192 > - Adapt to 8321713 > - Merge branch 'openjdk:master' into backport-GoeLin-38bf1192 > - Backport 38bf1192b637cf3513cb25ac21f513bfb51cb55b > Hi @Stuefe, good point windows is essential here :) I restarted the tests. After the report of @Rigner I'm not so sure I should proceed with this. What do you think, is this useful for 21? @GoeLin The fix seems correct, seems low risk and is somewhat useful. AFAIU, the bug is: An uncaught signal that is not handled specially by the JVM (eg implicit null pointer segfaults) should lead to a proper hs-err file. But it can lead to incorrect or torn hs-err files, the latter if we run out of stack. AFAIU this happens more or less randomly, depending on the content of the SSE control register at the time of the crash. Seeing that the risk is low, and that we were historically plagued by bad hs-err files on windows, I would fix it in 21. Possibly even in 17. @Rigner @JornVernee maybe discuss follow-up issues in the JBS section of the original bug, or its original PR? These discussions are valuable and should not get lost in this backport PR. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/510#issuecomment-2091245058 From duke at openjdk.org Thu May 2 19:22:06 2024 From: duke at openjdk.org (Chad Rakoczy) Date: Thu, 2 May 2024 19:22:06 GMT Subject: [jdk22u] RFR: 8325621: Improve jspawnhelper version checks Message-ID: Backport of [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621) Clean backport to update jspawnhelper to check that JDK version and jspawnhelper version are the same. Updates test to include check for version. GHA tests pass including the updated test. Risk is low: touches the production code paths but only passes an additional argument to jspawnhelper ------------- Commit messages: - Backport a232e8fb4e6e9e2e9a5285bf01c93b8d1d995f04 Changes: https://git.openjdk.org/jdk22u/pull/181/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=181&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325621 Stats: 59 lines in 5 files changed: 47 ins; 4 del; 8 mod Patch: https://git.openjdk.org/jdk22u/pull/181.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/181/head:pull/181 PR: https://git.openjdk.org/jdk22u/pull/181 From ashi at openjdk.org Fri May 3 00:42:57 2024 From: ashi at openjdk.org (Amos Shi) Date: Fri, 3 May 2024 00:42:57 GMT Subject: [jdk11u-dev] RFR: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used [v4] In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 16:07:23 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439). >> >> Patch is not clean. Test won't build in 11 because it can't find ```import jdk.internal.util.OperatingSystem```. >> >> This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485). >> >> I've worked around that by removing the dependency to that utility function and checking the operating system with ```test/lib/jdk/test/lib/Platform.java```. >> >> Testing: >> - [x] Modified test case passes >> >> Thanks! > > Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision: > > Using test/lib/jdk/test/lib/Platform.java instead of System.getProperty Testing Machine: SAP nightlies passed on 2024-05-02 - Automated jtreg test: jtreg_jdk_tier1 - `jdk/modules/etc/JmodExcludedFiles.java`: SUCCESSFUL GitHub ?? - [221 msec] ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2679#issuecomment-2091960154 From amitkumar at openjdk.org Fri May 3 05:28:58 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Fri, 3 May 2024 05:28:58 GMT Subject: [jdk22u] RFR: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space [v2] In-Reply-To: <4Uahqbvc2H5u7vIDQPJYBnpZJiccHggXL5_oOTbDEiQ=.65ae14ae-c4d5-40fc-ba23-da2e65bbcde2@github.com> References: <5abItkURdsTlX7DSg5uYhLYmY6MVklqwC8qCrggfBwI=.272d02f6-0554-4b8a-a6f2-5c4a08a13b39@github.com> <4Uahqbvc2H5u7vIDQPJYBnpZJiccHggXL5_oOTbDEiQ=.65ae14ae-c4d5-40fc-ba23-da2e65bbcde2@github.com> Message-ID: On Tue, 30 Apr 2024 12:21:40 GMT, Amit Kumar wrote: >> Hi all, >> >> This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. >> >> Thanks! > > Amit Kumar has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport d5f3d5c8cc347ae384dea25b1a55ed57204d1af3 Thanks Lutz for review, ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/170#issuecomment-2092309427 From amitkumar at openjdk.org Fri May 3 05:51:27 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Fri, 3 May 2024 05:51:27 GMT Subject: [jdk21u-dev] RFR: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space Message-ID: Hi all, This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. Thanks! ------------- Commit messages: - Backport d5f3d5c8cc347ae384dea25b1a55ed57204d1af3 Changes: https://git.openjdk.org/jdk21u-dev/pull/549/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=549&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326201 Stats: 6 lines in 2 files changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/549.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/549/head:pull/549 PR: https://git.openjdk.org/jdk21u-dev/pull/549 From goetz at openjdk.org Fri May 3 06:26:04 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 3 May 2024 06:26:04 GMT Subject: [jdk21u-dev] Integrated: 8317809: Insertion of free code blobs into code cache can be very slow during class unloading In-Reply-To: References: Message-ID: On Tue, 16 Apr 2024 09:47:42 GMT, Goetz Lindenmaier wrote: > Big change, but only two resolves needed: > > src/hotspot/share/gc/g1/g1ConcurrentMark.cpp > The context differs because "8309538: G1: Move total collection increment from Cleanup to Remark" > is only in 22 > > src/hotspot/share/gc/serial/genMarkSweep.cpp > Resolved adding an #include. > > SAP nightly testing passed. This pull request has now been integrated. Changeset: 3bb8eeed Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/3bb8eeed4817d490a1089aa567434af3f303c4f8 Stats: 483 lines in 28 files changed: 352 ins; 87 del; 44 mod 8317809: Insertion of free code blobs into code cache can be very slow during class unloading Reviewed-by: phh, adinn Backport-of: 30817b742300f10f566e6aee3a8c1f8af4ab3083 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/505 From goetz at openjdk.org Fri May 3 06:28:25 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 3 May 2024 06:28:25 GMT Subject: [jdk21u-dev] RFR: 8317007: Add bulk removal of dead nmethods during class unloading [v2] In-Reply-To: <_ru1bYUSOaylnCMA1-yLX3xwsC1ZfU_gUOvhfqvJmVs=.a1779d4d-9e54-4449-9b30-98b91fe9cb63@github.com> References: <_ru1bYUSOaylnCMA1-yLX3xwsC1ZfU_gUOvhfqvJmVs=.a1779d4d-9e54-4449-9b30-98b91fe9cb63@github.com> Message-ID: > I backport this for parity with 21.0.4-oracle. > > Clean patch on top of 8317809. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Backport f55381950266088cc0284754b16663675867ac87 - Merge branch 'openjdk:master' into goetz_backport_8317809-keep - Merge branch 'openjdk:master' into goetz_backport_8317809-keep - Merge branch 'openjdk:master' into goetz_backport_8317809-keep - Resolved hunks - Backport 30817b742300f10f566e6aee3a8c1f8af4ab3083 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/548/files - new: https://git.openjdk.org/jdk21u-dev/pull/548/files/e7ac49a9..e7ac49a9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=548&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=548&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/548.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/548/head:pull/548 PR: https://git.openjdk.org/jdk21u-dev/pull/548 From goetz at openjdk.org Fri May 3 06:50:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 3 May 2024 06:50:09 GMT Subject: [jdk21u-dev] RFR: 8317007: Add bulk removal of dead nmethods during class unloading [v2] In-Reply-To: References: <_ru1bYUSOaylnCMA1-yLX3xwsC1ZfU_gUOvhfqvJmVs=.a1779d4d-9e54-4449-9b30-98b91fe9cb63@github.com> Message-ID: On Fri, 3 May 2024 06:28:25 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 21.0.4-oracle. >> >> Clean patch on top of 8317809. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. I force-pushed because I prepared a new clean patch on my local repo. Instead, I would have had to resolve a hand full of files which is error-prone. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/548#issuecomment-2092404381 From goetz at openjdk.org Fri May 3 06:50:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 3 May 2024 06:50:09 GMT Subject: [jdk21u-dev] RFR: 8317007: Add bulk removal of dead nmethods during class unloading [v3] In-Reply-To: <_ru1bYUSOaylnCMA1-yLX3xwsC1ZfU_gUOvhfqvJmVs=.a1779d4d-9e54-4449-9b30-98b91fe9cb63@github.com> References: <_ru1bYUSOaylnCMA1-yLX3xwsC1ZfU_gUOvhfqvJmVs=.a1779d4d-9e54-4449-9b30-98b91fe9cb63@github.com> Message-ID: > I backport this for parity with 21.0.4-oracle. > > Clean patch on top of 8317809. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport f55381950266088cc0284754b16663675867ac87 ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/548/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=548&range=02 Stats: 194 lines in 27 files changed: 129 ins; 43 del; 22 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/548.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/548/head:pull/548 PR: https://git.openjdk.org/jdk21u-dev/pull/548 From jkern at openjdk.org Fri May 3 08:42:00 2024 From: jkern at openjdk.org (Joachim Kern) Date: Fri, 3 May 2024 08:42:00 GMT Subject: [jdk22u] Integrated: 8329850: [AIX] Allow loading of different members of same shared library archive In-Reply-To: <2NQNM1egAWSh6cid6j7YjvjBUNzW1yDNho_zlMJIu-0=.aa2c843d-8210-4480-bb4c-0f57ad261ce6@github.com> References: <2NQNM1egAWSh6cid6j7YjvjBUNzW1yDNho_zlMJIu-0=.aa2c843d-8210-4480-bb4c-0f57ad261ce6@github.com> Message-ID: On Mon, 29 Apr 2024 15:03:42 GMT, Joachim Kern wrote: > Hi all, > > This pull request contains a backport of commit [cfd19f01](https://github.com/openjdk/jdk/commit/cfd19f017681a7aded67937c5132263bbcc7be6f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Joachim Kern on 26 Apr 2024 and was reviewed by Martin Doerr, Matthias Baesken and Thomas Stuefe. > > Thanks! This pull request has now been integrated. Changeset: e96e6abf Author: Joachim Kern Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/e96e6abf541e1baa49655bacf42f1285d4cbb5ff Stats: 24 lines in 1 file changed: 17 ins; 0 del; 7 mod 8329850: [AIX] Allow loading of different members of same shared library archive Backport-of: cfd19f017681a7aded67937c5132263bbcc7be6f ------------- PR: https://git.openjdk.org/jdk22u/pull/173 From amitkumar at openjdk.org Fri May 3 08:42:59 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Fri, 3 May 2024 08:42:59 GMT Subject: [jdk22u] Integrated: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: <5abItkURdsTlX7DSg5uYhLYmY6MVklqwC8qCrggfBwI=.272d02f6-0554-4b8a-a6f2-5c4a08a13b39@github.com> References: <5abItkURdsTlX7DSg5uYhLYmY6MVklqwC8qCrggfBwI=.272d02f6-0554-4b8a-a6f2-5c4a08a13b39@github.com> Message-ID: <6kPUKRgEHBGpSvf1Dqqciggb1OjRwYUsCu0jppnxajA=.fe235084-44b8-4057-94b7-057e50ae404c@github.com> On Fri, 26 Apr 2024 16:51:26 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. > > Thanks! This pull request has now been integrated. Changeset: 5c154833 Author: Amit Kumar Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/5c154833637a8714000d76730d6cdef847545e93 Stats: 9 lines in 2 files changed: 3 ins; 0 del; 6 mod 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space Reviewed-by: lucy Backport-of: d5f3d5c8cc347ae384dea25b1a55ed57204d1af3 ------------- PR: https://git.openjdk.org/jdk22u/pull/170 From stuefe at openjdk.org Fri May 3 08:44:03 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 3 May 2024 08:44:03 GMT Subject: [jdk21u-dev] RFR: 8310228: Improve error reporting for uncaught native exceptions on Windows [v3] In-Reply-To: References: <680TRW-ipLTBYJ7-KQxshXyOKLB82yCnA_Tn2FOWpHY=.ce8dd5bc-9238-4034-a067-d0a74d65e9ac@github.com> Message-ID: On Thu, 2 May 2024 11:20:11 GMT, Goetz Lindenmaier wrote: >> A bugfix useful for windows. > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-GoeLin-38bf1192 > - Adapt to 8321713 > - Merge branch 'openjdk:master' into backport-GoeLin-38bf1192 > - Backport 38bf1192b637cf3513cb25ac21f513bfb51cb55b P.S. with "somewhat useful" - not a native speaker - I meant it is useful but not an urgent fix. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/510#issuecomment-2092567595 From clanger at openjdk.org Fri May 3 09:33:19 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 3 May 2024 09:33:19 GMT Subject: [jdk21u-dev] RFR: 8331639: [21u]: Bump GHA bootstrap JDK to 21.0.3 Message-ID: <-6dkMCxUCy_YVQE62OLyNT3-Lh21_Gg40zVgUQRmDNo=.e28cfe96-8d53-4732-8e67-88d6eb70380d@github.com> >From time to time the GHA bootstrap JDK in the update releases should be bumped. So let's take the current verion 21.0.3 from Temurin. ------------- Commit messages: - JDK-8331639 Changes: https://git.openjdk.org/jdk21u-dev/pull/550/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=550&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331639 Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/550.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/550/head:pull/550 PR: https://git.openjdk.org/jdk21u-dev/pull/550 From clanger at openjdk.org Fri May 3 09:36:24 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 3 May 2024 09:36:24 GMT Subject: [jdk17u-dev] RFR: 8331641: [17u]: Bump GHA bootstrap JDK to 17.0.11 Message-ID: <5wRkRSGpaMakayJ-_8_jrQCqYBCidCo3Ss16-p_E6u4=.c20fe122-73fb-46de-8389-21fa1c88f799@github.com> >From time to time the GHA bootstrap JDK in the update releases should be bumped. So let's take the current verion 17.0.11 from Temurin. ------------- Commit messages: - JDK-8331641 Changes: https://git.openjdk.org/jdk17u-dev/pull/2444/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2444&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331641 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2444.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2444/head:pull/2444 PR: https://git.openjdk.org/jdk17u-dev/pull/2444 From clanger at openjdk.org Fri May 3 09:40:19 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 3 May 2024 09:40:19 GMT Subject: [jdk11u-dev] RFR: 8331643: [11u]: Bump GHA bootstrap JDK to 11.0.23 Message-ID: >From time to time the GHA bootstrap JDK in the update releases should be bumped. So let's take the current verion 11.0.23 from Temurin. ------------- Commit messages: - JDK-8331643 Changes: https://git.openjdk.org/jdk11u-dev/pull/2697/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2697&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331643 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2697.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2697/head:pull/2697 PR: https://git.openjdk.org/jdk11u-dev/pull/2697 From duke at openjdk.org Fri May 3 09:45:18 2024 From: duke at openjdk.org (Johny Jose) Date: Fri, 3 May 2024 09:45:18 GMT Subject: [jdk22u] RFR: 8330748: ByteArrayOutputStream.writeTo(OutputStream) pins carrier Message-ID: clean backport of https://github.com/openjdk/jdk/commit/819f3d6fc70ff6fe54ac5f9033c17c3dd4326aa5 ------------- Commit messages: - Backport 819f3d6fc70ff6fe54ac5f9033c17c3dd4326aa5 Changes: https://git.openjdk.org/jdk22u/pull/182/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=182&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330748 Stats: 142 lines in 2 files changed: 139 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk22u/pull/182.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/182/head:pull/182 PR: https://git.openjdk.org/jdk22u/pull/182 From sgehwolf at openjdk.org Fri May 3 10:04:52 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 May 2024 10:04:52 GMT Subject: [jdk21u-dev] RFR: 8331639: [21u]: Bump GHA bootstrap JDK to 21.0.3 In-Reply-To: <-6dkMCxUCy_YVQE62OLyNT3-Lh21_Gg40zVgUQRmDNo=.e28cfe96-8d53-4732-8e67-88d6eb70380d@github.com> References: <-6dkMCxUCy_YVQE62OLyNT3-Lh21_Gg40zVgUQRmDNo=.e28cfe96-8d53-4732-8e67-88d6eb70380d@github.com> Message-ID: On Fri, 3 May 2024 09:28:43 GMT, Christoph Langer wrote: > From time to time the GHA bootstrap JDK in the update releases should be bumped. So let's take the current verion 21.0.3 from Temurin. LGTM. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/550#pullrequestreview-2037813499 From sgehwolf at openjdk.org Fri May 3 10:05:59 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 May 2024 10:05:59 GMT Subject: [jdk17u-dev] RFR: 8331641: [17u]: Bump GHA bootstrap JDK to 17.0.11 In-Reply-To: <5wRkRSGpaMakayJ-_8_jrQCqYBCidCo3Ss16-p_E6u4=.c20fe122-73fb-46de-8389-21fa1c88f799@github.com> References: <5wRkRSGpaMakayJ-_8_jrQCqYBCidCo3Ss16-p_E6u4=.c20fe122-73fb-46de-8389-21fa1c88f799@github.com> Message-ID: On Fri, 3 May 2024 09:32:09 GMT, Christoph Langer wrote: > From time to time the GHA bootstrap JDK in the update releases should be bumped. So let's take the current verion 17.0.11 from Temurin. LGTM ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2444#pullrequestreview-2037814606 From sgehwolf at openjdk.org Fri May 3 10:06:59 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 May 2024 10:06:59 GMT Subject: [jdk11u-dev] RFR: 8331643: [11u]: Bump GHA bootstrap JDK to 11.0.23 In-Reply-To: References: Message-ID: <7-PSaLzqi3w-pjC__yH422C9qMDBrAb728I1I8gNUrU=.87b8c9b8-2c8c-41de-8597-95240d07171c@github.com> On Fri, 3 May 2024 09:35:06 GMT, Christoph Langer wrote: > From time to time the GHA bootstrap JDK in the update releases should be bumped. So let's take the current verion 11.0.23 from Temurin. LGTM. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2697#pullrequestreview-2037815815 From goetz at openjdk.org Fri May 3 10:39:59 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 3 May 2024 10:39:59 GMT Subject: [jdk21u-dev] RFR: 8310228: Improve error reporting for uncaught native exceptions on Windows [v3] In-Reply-To: References: <680TRW-ipLTBYJ7-KQxshXyOKLB82yCnA_Tn2FOWpHY=.ce8dd5bc-9238-4034-a067-d0a74d65e9ac@github.com> Message-ID: On Fri, 3 May 2024 08:41:36 GMT, Thomas Stuefe wrote: >> Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: >> >> - Merge branch 'openjdk:master' into backport-GoeLin-38bf1192 >> - Adapt to 8321713 >> - Merge branch 'openjdk:master' into backport-GoeLin-38bf1192 >> - Backport 38bf1192b637cf3513cb25ac21f513bfb51cb55b > > P.S. with "somewhat useful" - not a native speaker - I meant it is useful but not an urgent fix. Hi @tstuefe, thanks for your opinion. I will request approval. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/510#issuecomment-2092743798 From clanger at openjdk.org Fri May 3 13:46:00 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 3 May 2024 13:46:00 GMT Subject: [jdk17u-dev] RFR: 8331641: [17u]: Bump GHA bootstrap JDK to 17.0.11 In-Reply-To: <5wRkRSGpaMakayJ-_8_jrQCqYBCidCo3Ss16-p_E6u4=.c20fe122-73fb-46de-8389-21fa1c88f799@github.com> References: <5wRkRSGpaMakayJ-_8_jrQCqYBCidCo3Ss16-p_E6u4=.c20fe122-73fb-46de-8389-21fa1c88f799@github.com> Message-ID: On Fri, 3 May 2024 09:32:09 GMT, Christoph Langer wrote: > From time to time the GHA bootstrap JDK in the update releases should be bumped. So let's take the current verion 17.0.11 from Temurin. test issue linuxx64 seems unrelated ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2444#issuecomment-2093052597 From syan at openjdk.org Fri May 3 16:17:14 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 3 May 2024 16:17:14 GMT Subject: [jdk22u] RFR: 8331331: :tier1 target explanation in doc/testing.md is incorrect Message-ID: Hi, This is clean backport of [JDK-8331331](https://bugs.openjdk.org/browse/JDK-8331331), fixed the incorrect explanation :tier1 target in doc/testing.md. No risk. ------------- Commit messages: - Backport 04271dfe7a262379944e2a2cf83a98a3a1b78a74 Changes: https://git.openjdk.org/jdk22u/pull/183/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=183&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331331 Stats: 8 lines in 2 files changed: 1 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk22u/pull/183.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/183/head:pull/183 PR: https://git.openjdk.org/jdk22u/pull/183 From syan at openjdk.org Fri May 3 16:18:09 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 3 May 2024 16:18:09 GMT Subject: [jdk21u-dev] RFR: 8331331: :tier1 target explanation in doc/testing.md is incorrect Message-ID: Hi, This is clean backport of [JDK-8331331](https://bugs.openjdk.org/browse/JDK-8331331), fixed the incorrect explanation :tier1 target in doc/testing.md. No risk. ------------- Commit messages: - Backport 04271dfe7a262379944e2a2cf83a98a3a1b78a74 Changes: https://git.openjdk.org/jdk21u-dev/pull/551/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=551&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331331 Stats: 8 lines in 2 files changed: 1 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/551.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/551/head:pull/551 PR: https://git.openjdk.org/jdk21u-dev/pull/551 From bpb at openjdk.org Fri May 3 16:19:02 2024 From: bpb at openjdk.org (Brian Burkhalter) Date: Fri, 3 May 2024 16:19:02 GMT Subject: [jdk22u] RFR: 8330748: ByteArrayOutputStream.writeTo(OutputStream) pins carrier In-Reply-To: References: Message-ID: On Fri, 3 May 2024 09:40:00 GMT, Johny Jose wrote: > clean backport of https://github.com/openjdk/jdk/commit/819f3d6fc70ff6fe54ac5f9033c17c3dd4326aa5 Matches the original ------------- Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk22u/pull/182#pullrequestreview-2038506618 From sgehwolf at openjdk.org Fri May 3 16:20:58 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 May 2024 16:20:58 GMT Subject: [jdk17u-dev] RFR: 8331641: [17u]: Bump GHA bootstrap JDK to 17.0.11 In-Reply-To: <5wRkRSGpaMakayJ-_8_jrQCqYBCidCo3Ss16-p_E6u4=.c20fe122-73fb-46de-8389-21fa1c88f799@github.com> References: <5wRkRSGpaMakayJ-_8_jrQCqYBCidCo3Ss16-p_E6u4=.c20fe122-73fb-46de-8389-21fa1c88f799@github.com> Message-ID: On Fri, 3 May 2024 09:32:09 GMT, Christoph Langer wrote: > From time to time the GHA bootstrap JDK in the update releases should be bumped. So let's take the current verion 17.0.11 from Temurin. Agreed. Looks infra related: linux-x64 / test (hs/tier1 compiler part 3) Failed to CreateArtifact: Failed to make request after 5 attempts: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2444#issuecomment-2093326109 From andrew at openjdk.org Fri May 3 20:23:06 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 3 May 2024 20:23:06 GMT Subject: [jdk17u-ri] RFR: 8297878: KEM: Implementation [v4] In-Reply-To: References: Message-ID: On Thu, 18 Apr 2024 18:09:35 GMT, Weijun Wang wrote: >> This is the KEM API backport to Java SE 17 MR 1. >> >> The `src` files are identical to those in the current `jdk` repo except for the change made to `KEM.java` at https://github.com/openjdk/jdk/commit/59c2aff1edffb66762bbbe5e310913f87953be5b#diff-7bee547996d0de5692181a509bdf509276c7eb9351722580fd6aee7975745e67. >> >> _Update: There are javadoc changes to all the `src` files in following commits._ >> >> The `RSA_KEM` code is modified because `DerOutputStream` lacks several methods in JDK 17. >> >> `Proc` is updated like in JDK 21 to support for some internal interop testing. The test files for `Proc` are also backported. >> >> This change does not contain the DHKEM implementation in the original JDK 21 change. >> >> This change also covers JDK-8322971 which fixed a follow-on P3 bug of the initial KEM work. > > Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: > > update tags of inner types > 8322971 > @gnu-andrew I backported the 3 issues in a single PR because [JDK-8305846](https://bugs.openjdk.org/browse/JDK-8305846) was originally created to support the RSA-KEM interop test. I understand the change for it looks a little strange without any usage of it here. I hope grouping them together will make further backport - if exists - simpler. > We usually try and avoid it for more complex patches. It makes it easier for the person backporting, but harder for reviewers who have to pick it apart again. > For the year of `Provider.java`, I just updated it to _now_. Ok, we usually avoid this as it creates differences from the original commit which may then break further backports. > > Yes, `getKemImpl` exists because after JDK-8322971 one cannot load a KEM impl from an unsigned security provider in Oracle JDK. This is a little different from OpenJDK. Ah, ok, so it's necessary after 8322971. ------------- PR Comment: https://git.openjdk.org/jdk17u-ri/pull/1#issuecomment-2093708258 From duke at openjdk.org Fri May 3 22:14:08 2024 From: duke at openjdk.org (Terry Chow) Date: Fri, 3 May 2024 22:14:08 GMT Subject: [jdk11u-dev] RFR: 8308593: Add KEEPALIVE Extended Socket Options Support for Windows In-Reply-To: References: Message-ID: On Fri, 10 Nov 2023 20:04:31 GMT, Terry Chow wrote: > This is an unclean backport of [JDK-8308593](https://bugs.openjdk.org/browse/JDK-8308593), which provides support for the keepalive extended socket options on Windows. > > The following changes are the differences from the original patch in order to get this backport working for 11u: > > make/lib/Lib-jdk.net.gmk -- Updated this script to support building extnet for Windows. > > src/jdk.net/share/classes/jdk/net/ExtendedSocketOptions.java -- Added a case to support returning an instance of WindowsSocketOptions in PlatformSocketOptions. > > src/java.base/windows/classes/java/net/PlainSocketImpl.java -- The Windows PlainSocketImpl class will need to have similar setOption/getOption methods as the Unix PlainSocketImpl class to support setting these extended socket options for Windows. > > Backport passed against Tier 1 tests and was manually verified to be working on Windows. Commenting for activity. Let me know how I can progress this towards integration. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2278#issuecomment-2093826278 From amitkumar at openjdk.org Sat May 4 05:41:55 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Sat, 4 May 2024 05:41:55 GMT Subject: [jdk21u-dev] RFR: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: On Fri, 3 May 2024 05:36:49 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. > > Thanks! @RealLucy please sponsor ? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/549#issuecomment-2094034608 From amitkumar at openjdk.org Sat May 4 05:49:13 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Sat, 4 May 2024 05:49:13 GMT Subject: [jdk17u-dev] RFR: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space Message-ID: Hi all, This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. Thanks! ------------- Commit messages: - Backport d5f3d5c8cc347ae384dea25b1a55ed57204d1af3 Changes: https://git.openjdk.org/jdk17u-dev/pull/2446/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2446&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326201 Stats: 6 lines in 2 files changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2446.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2446/head:pull/2446 PR: https://git.openjdk.org/jdk17u-dev/pull/2446 From amitkumar at openjdk.org Sat May 4 06:16:59 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Sat, 4 May 2024 06:16:59 GMT Subject: [jdk21u-dev] RFR: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking In-Reply-To: References: Message-ID: On Thu, 2 May 2024 08:31:55 GMT, Goetz Lindenmaier wrote: >> Hi all, >> >> This pull request contains a backport of commit [47df1459](https://github.com/openjdk/jdk/commit/47df14590c003ccb1607ec0edfe999fcf2aebd86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Amit Kumar on 10 Apr 2024 and was reviewed by Lutz Schmidt and Martin Doerr. >> >> Thanks! >> >> Benchmarking: >> >> ./build/linux-s390x-server-release/jdk/bin/java -Xms4g -Xmx4g -jar dacapo-9.12-MR1-bach.jar h2 -s huge -t 1 -n 1 >> >> Without the patch: >> >> ===== DaCapo 9.12-MR1 h2 PASSED in 209768 msec ===== >> ===== DaCapo 9.12-MR1 h2 PASSED in 197472 msec ===== >> ===== DaCapo 9.12-MR1 h2 PASSED in 222872 msec ===== >> ===== DaCapo 9.12-MR1 h2 PASSED in 215725 msec ===== >> >> >> with patch: >> ===== DaCapo 9.12-MR1 h2 PASSED in 171055 msec ===== >> ===== DaCapo 9.12-MR1 h2 PASSED in 169696 msec ===== >> ===== DaCapo 9.12-MR1 h2 PASSED in 174032 msec ===== >> ===== DaCapo 9.12-MR1 h2 PASSED in 167271 msec ===== > > Also, please enable the GHA tests on your repo. You can restart the tests either in the actions tab or by merging head into your PR branch. Thanks @GoeLin @RealLucy for advice & review. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/537#issuecomment-2094043765 From clanger at openjdk.org Sat May 4 06:33:59 2024 From: clanger at openjdk.org (Christoph Langer) Date: Sat, 4 May 2024 06:33:59 GMT Subject: [jdk17u-dev] Integrated: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket In-Reply-To: References: Message-ID: On Thu, 11 Apr 2024 15:50:23 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of commit [fbb424f9](https://github.com/openjdk/jdk21u-dev/commit/fbb424f95d73e99c7a533ed5dae8fbb6d13dc93b) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > The commit being backported was authored by Christoph Langer on 11 Apr 2024 and had no reviewers. > > Applies clean except for the copyright years in module-info.java. Will mark clean, hence. > > Thanks! This pull request has now been integrated. Changeset: 32bf1f41 Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/32bf1f4169fd07291d608323c143832ad48e531e Stats: 245 lines in 3 files changed: 130 ins; 35 del; 80 mod 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket Backport-of: fbb424f95d73e99c7a533ed5dae8fbb6d13dc93b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2396 From gcao at openjdk.org Sat May 4 07:28:57 2024 From: gcao at openjdk.org (Gui Cao) Date: Sat, 4 May 2024 07:28:57 GMT Subject: [jdk21u-dev] RFR: 8330094: RISC-V: Save and restore FRM in the call stub In-Reply-To: References: <2B3vamwo55G57VwribFkgwhRjNv1He6Lrm3U37dpfeU=.1136238d-1e6f-4656-a3d4-72a61fbc2339@github.com> Message-ID: On Wed, 1 May 2024 02:12:43 GMT, Fei Yang wrote: >> Hi, The same issue also exists in JDK21u. So I would like to backport [JDK-8330094](https://bugs.openjdk.org/browse/JDK-8330094) to jdk21u-dev. With this change, we save and restore the default floating-point control state when we enter and leave Java code, ensuring that we are still Java compatible if we're called via the JNI invocation interface with a weird FP control state. RISC-V specific change, risk is low. >> The backport is not clean because jdk21u-dev has no [JDK-8321021](https://bugs.openjdk.org/browse/JDK-8321021) >> >> ### Testing >> >> - [x] Run tier1-3 tests on SOPHON SG2042 (release) > > LGTM. @RealFYang @jerboaa : Thanks for the review. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/545#issuecomment-2094062585 From gcao at openjdk.org Sat May 4 07:29:52 2024 From: gcao at openjdk.org (Gui Cao) Date: Sat, 4 May 2024 07:29:52 GMT Subject: [jdk17u-dev] RFR: 8330094: RISC-V: Save and restore FRM in the call stub In-Reply-To: References: Message-ID: <5UsEW701ZXPTZU_HnqD3uTpMrvqlQ8k0yWfdJIA8NAA=.640f4d22-258c-4d2c-8355-3bbb0e640510@github.com> On Wed, 1 May 2024 02:17:59 GMT, Fei Yang wrote: >> Hi, The same issue also exists in JDK17u. So I would like to backport [JDK-8330094](https://bugs.openjdk.org/browse/JDK-8330094) to jdk17u-dev. With this change, we save and restore the default floating-point control state when we enter and leave Java code, ensuring that we are still Java compatible if we're called via the JNI invocation interface with a weird FP control state. RISC-V specific change, risk is low. >> The backport is not clean because jdk17u-dev only has partial vector api instruct, this backport-related instruct does not exist in jdk17u-dev. >> >> ### Testing >> >> - [x] Run tier1-3 tests on SOPHON SG2042 (release) > > LGTM. @RealFYang : Thanks for the review. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2442#issuecomment-2094062761 From gcao at openjdk.org Sat May 4 07:29:56 2024 From: gcao at openjdk.org (Gui Cao) Date: Sat, 4 May 2024 07:29:56 GMT Subject: [jdk22u] RFR: 8330094: RISC-V: Save and restore FRM in the call stub [v2] In-Reply-To: References: <2dRQpml8PB-IKbqJCV6891dqfJ3HQXD14EZNENS-qSQ=.6b677c69-8336-46d4-a01b-149ef2365a47@github.com> Message-ID: On Wed, 1 May 2024 02:10:11 GMT, Fei Yang wrote: >> Gui Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: >> >> - Merge remote-tracking branch 'upstream/master' into backport-JDK-8330094 >> - Backport 8330094: RISC-V: Save and restore FRM in the call stub > > LGTM. @RealFYang : Thanks for the review. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/174#issuecomment-2094062800 From gcao at openjdk.org Sun May 5 04:25:54 2024 From: gcao at openjdk.org (Gui Cao) Date: Sun, 5 May 2024 04:25:54 GMT Subject: [jdk22u] Integrated: 8330094: RISC-V: Save and restore FRM in the call stub In-Reply-To: <2dRQpml8PB-IKbqJCV6891dqfJ3HQXD14EZNENS-qSQ=.6b677c69-8336-46d4-a01b-149ef2365a47@github.com> References: <2dRQpml8PB-IKbqJCV6891dqfJ3HQXD14EZNENS-qSQ=.6b677c69-8336-46d4-a01b-149ef2365a47@github.com> Message-ID: On Tue, 30 Apr 2024 13:25:35 GMT, Gui Cao wrote: > Hi, The same issue also exists in jdk22u. So I would like to backport [JDK-8330094](https://bugs.openjdk.org/browse/JDK-8330094) to jdk22u. With this change, we save and restore the default floating-point control state when we enter and leave Java code, ensuring that we are still Java compatible if we're called via the JNI invocation interface with a weird FP control state. RISC-V specific change, risk is low. > The backport is not clean because jdk22u has no [JDK-8321021](https://bugs.openjdk.org/browse/JDK-8321021) > > ### Testing > > - [x] Run tier1-3 tests on SOPHON SG2042 (release) This pull request has now been integrated. Changeset: beb06e1e Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/jdk22u/commit/beb06e1e722150370ca1ee800894fec77666640e Stats: 34 lines in 3 files changed: 21 ins; 9 del; 4 mod 8330094: RISC-V: Save and restore FRM in the call stub Reviewed-by: fyang Backport-of: b0496096dc8d7dc7acf28aa006141a3ecea446de ------------- PR: https://git.openjdk.org/jdk22u/pull/174 From gcao at openjdk.org Sun May 5 04:30:02 2024 From: gcao at openjdk.org (Gui Cao) Date: Sun, 5 May 2024 04:30:02 GMT Subject: [jdk21u-dev] Integrated: 8330094: RISC-V: Save and restore FRM in the call stub In-Reply-To: <2B3vamwo55G57VwribFkgwhRjNv1He6Lrm3U37dpfeU=.1136238d-1e6f-4656-a3d4-72a61fbc2339@github.com> References: <2B3vamwo55G57VwribFkgwhRjNv1He6Lrm3U37dpfeU=.1136238d-1e6f-4656-a3d4-72a61fbc2339@github.com> Message-ID: On Tue, 30 Apr 2024 13:08:50 GMT, Gui Cao wrote: > Hi, The same issue also exists in JDK21u. So I would like to backport [JDK-8330094](https://bugs.openjdk.org/browse/JDK-8330094) to jdk21u-dev. With this change, we save and restore the default floating-point control state when we enter and leave Java code, ensuring that we are still Java compatible if we're called via the JNI invocation interface with a weird FP control state. RISC-V specific change, risk is low. > The backport is not clean because jdk21u-dev has no [JDK-8321021](https://bugs.openjdk.org/browse/JDK-8321021) > > ### Testing > > - [x] Run tier1-3 tests on SOPHON SG2042 (release) This pull request has now been integrated. Changeset: 835d016a Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/jdk21u-dev/commit/835d016ade123a053c283589da472a96a4afae1e Stats: 34 lines in 3 files changed: 21 ins; 9 del; 4 mod 8330094: RISC-V: Save and restore FRM in the call stub Reviewed-by: fyang Backport-of: b0496096dc8d7dc7acf28aa006141a3ecea446de ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/545 From gcao at openjdk.org Sun May 5 04:32:01 2024 From: gcao at openjdk.org (Gui Cao) Date: Sun, 5 May 2024 04:32:01 GMT Subject: [jdk17u-dev] Integrated: 8330094: RISC-V: Save and restore FRM in the call stub In-Reply-To: References: Message-ID: On Tue, 30 Apr 2024 13:10:18 GMT, Gui Cao wrote: > Hi, The same issue also exists in JDK17u. So I would like to backport [JDK-8330094](https://bugs.openjdk.org/browse/JDK-8330094) to jdk17u-dev. With this change, we save and restore the default floating-point control state when we enter and leave Java code, ensuring that we are still Java compatible if we're called via the JNI invocation interface with a weird FP control state. RISC-V specific change, risk is low. > The backport is not clean because jdk17u-dev only has partial vector api instruct, this backport-related instruct does not exist in jdk17u-dev. > > ### Testing > > - [x] Run tier1-3 tests on SOPHON SG2042 (release) This pull request has now been integrated. Changeset: 68a2d935 Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/jdk17u-dev/commit/68a2d93588b1b3cdf1a8c8eb135581ede97c8ac3 Stats: 25 lines in 2 files changed: 21 ins; 0 del; 4 mod 8330094: RISC-V: Save and restore FRM in the call stub Reviewed-by: fyang Backport-of: b0496096dc8d7dc7acf28aa006141a3ecea446de ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2442 From syan at openjdk.org Sun May 5 09:58:21 2024 From: syan at openjdk.org (SendaoYan) Date: Sun, 5 May 2024 09:58:21 GMT Subject: [jdk17u-dev] RFR: 8331331: :tier1 target explanation in doc/testing.md is incorrect Message-ID: Hi, This is backport of [JDK-8331331](https://bugs.openjdk.org/browse/JDK-8331331). The `doc/testing.html` can not backport cleanly because of it's a prefixed patch [JDK-8295663](https://bugs.openjdk.org/browse/JDK-8295663). $ make CONF=linux-x86_64-server-release -n test-tier1 &> test-tier1.log $ grep "Running test " test-tier1.log Running test 'jtreg:test/hotspot/jtreg:tier1' Running test 'jtreg:test/jdk:tier1' Running test 'jtreg:test/langtools:tier1' Running test 'jtreg:test/jaxp:tier1' Running test 'jtreg:test/lib-test:tier1' ------------- Commit messages: - Backport 04271dfe7a262379944e2a2cf83a98a3a1b78a74 Changes: https://git.openjdk.org/jdk17u-dev/pull/2447/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2447&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331331 Stats: 6 lines in 2 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2447.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2447/head:pull/2447 PR: https://git.openjdk.org/jdk17u-dev/pull/2447 From lmao at openjdk.org Mon May 6 02:33:57 2024 From: lmao at openjdk.org (Liang Mao) Date: Mon, 6 May 2024 02:33:57 GMT Subject: [jdk21u-dev] RFR: 8319376: ParallelGC: Forwarded objects found during heap inspection In-Reply-To: References: Message-ID: <-8A53oLbjC5jQKaxp6Qytbl-N9M8yw61Gz3r_BBljVk=.b77030d2-cb11-486a-82c2-119cdc8fec2a@github.com> On Tue, 30 Apr 2024 09:43:58 GMT, Liang Mao wrote: > Clean backport of fixing the potential self forwarding object in heap inspection of Parallel GC Could any committers help with the integration? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/544#issuecomment-2095097108 From jkern at openjdk.org Mon May 6 06:32:58 2024 From: jkern at openjdk.org (Joachim Kern) Date: Mon, 6 May 2024 06:32:58 GMT Subject: [jdk21u-dev] Integrated: 8329850: [AIX] Allow loading of different members of same shared library archive In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 15:19:28 GMT, Joachim Kern wrote: > Hi all, > > This pull request contains a backport of commit [cfd19f01](https://github.com/openjdk/jdk/commit/cfd19f017681a7aded67937c5132263bbcc7be6f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Joachim Kern on 26 Apr 2024 and was reviewed by Martin Doerr, Matthias Baesken and Thomas Stuefe. > > Thanks! This pull request has now been integrated. Changeset: d459ae9d Author: Joachim Kern Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/d459ae9dc922d045ea38837f260f60e685e3b368 Stats: 24 lines in 1 file changed: 17 ins; 0 del; 7 mod 8329850: [AIX] Allow loading of different members of same shared library archive Backport-of: cfd19f017681a7aded67937c5132263bbcc7be6f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/542 From andrewlu at openjdk.org Mon May 6 07:44:01 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 6 May 2024 07:44:01 GMT Subject: [jdk11u-dev] Integrated: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer In-Reply-To: References: Message-ID: On Tue, 30 Apr 2024 09:23:08 GMT, Andrew Lu wrote: > As the description in testing.html and testing.md is added in JDK-8231351, so backport for it together. > some small change is not in testing.html, so ignore it. > test/jdk/ProblemList.txt > remain the > "sun/security/tools/keytool/NssTest.java 8204203 linux-all,windows-all" > others clean. This pull request has now been integrated. Changeset: 1da8fd84 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/1da8fd845cbed721ecc418d44573dd66743b639c Stats: 141 lines in 7 files changed: 25 ins; 89 del; 27 mod 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer 8231351: Add notes for PKCS11 tests in the test doc Reviewed-by: lucy Backport-of: 6ce0ebb858d3112f136e12d3ad595f805f6871a0 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2694 From andrewlu at openjdk.org Mon May 6 07:44:03 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 6 May 2024 07:44:03 GMT Subject: [jdk11u-dev] Integrated: 8310818: Refactor more Locale tests to use JUnit In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 10:02:31 GMT, Andrew Lu wrote: > This PR contains a backport of > https://github.com/openjdk/jdk/commit/12e943091071b02b5756b57527a5f86a3d881cb8 > Patch is not clean, this class test/jdk/java/util/Locale/ISO639.java contains the Text Blocks > System.out.printf(""" > Arguments.of("%s","%s","%s"), > """, iso639_1, iso639_2B, iso639_2T); > But in jdk11 the Text Blocks is not supported, I modified the code to > System.out.printf("Arguments.of("%s","%s","%s"),\n", iso639_1, iso639_2B, iso639_2T); > Other than these the rest of the code is clean. This pull request has now been integrated. Changeset: 3f636f30 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/3f636f30f9f040a8d320a4be7c2122fb22fd00bf Stats: 1939 lines in 13 files changed: 679 ins; 1250 del; 10 mod 8310818: Refactor more Locale tests to use JUnit Reviewed-by: lucy Backport-of: 989e0bfe59d67f6a751e8b187caabbd0fd8c8f81 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2693 From clanger at openjdk.org Mon May 6 07:56:04 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 6 May 2024 07:56:04 GMT Subject: [jdk11u-dev] RFR: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException Message-ID: The backport of [JDK-8248194](https://bugs.openjdk.org/browse/JDK-8248194) introduced the testing of core files in test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java. This can cause issues which we are seeing on MacOS arm64. With this backport, these seem to be gone. The fix does not exactly fit into the 11u-dev codebase, so I had to make several adpatations. ------------- Commit messages: - 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException Changes: https://git.openjdk.org/jdk11u-dev/pull/2698/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2698&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293563 Stats: 23 lines in 6 files changed: 14 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2698.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2698/head:pull/2698 PR: https://git.openjdk.org/jdk11u-dev/pull/2698 From shade at openjdk.org Mon May 6 08:09:53 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 6 May 2024 08:09:53 GMT Subject: [jdk21u-dev] Integrated: 8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0 In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 08:55:52 GMT, Aleksey Shipilev wrote: > Fixes the JDK 21 regression. Simple fix. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `jdk/jshell` passes This pull request has now been integrated. Changeset: 021372c7 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/021372c76d583e29cf2abf4b932e31321adf4295 Stats: 16 lines in 2 files changed: 0 ins; 0 del; 16 mod 8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0 Backport-of: 87e864bf21d71daae4e001ec4edbb4ef1f60c36d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/540 From syan at openjdk.org Mon May 6 08:16:01 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 6 May 2024 08:16:01 GMT Subject: [jdk21u-dev] Integrated: 8331331: :tier1 target explanation in doc/testing.md is incorrect In-Reply-To: References: Message-ID: On Fri, 3 May 2024 16:12:39 GMT, SendaoYan wrote: > Hi, > This is clean backport of [JDK-8331331](https://bugs.openjdk.org/browse/JDK-8331331), fixed the incorrect explanation :tier1 target in doc/testing.md. No risk. This pull request has now been integrated. Changeset: 3770c28c Author: SendaoYan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/3770c28c05f279ed1a3854c6f70e7e1bbee6ff0e Stats: 8 lines in 2 files changed: 1 ins; 0 del; 7 mod 8331331: :tier1 target explanation in doc/testing.md is incorrect Backport-of: 04271dfe7a262379944e2a2cf83a98a3a1b78a74 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/551 From amitkumar at openjdk.org Mon May 6 08:17:58 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 6 May 2024 08:17:58 GMT Subject: [jdk21u-dev] Integrated: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: <0l0WB9m_Dw7B0S9giJJ3nfRX-oPS5Y3yLabuiHVqbvs=.68962f0b-72f3-441a-ab40-27603ef626ad@github.com> On Fri, 3 May 2024 05:36:49 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. > > Thanks! This pull request has now been integrated. Changeset: abbad928 Author: Amit Kumar Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/abbad928945d0679745e0997d804c44fe394d3db Stats: 6 lines in 2 files changed: 3 ins; 0 del; 3 mod 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space Backport-of: d5f3d5c8cc347ae384dea25b1a55ed57204d1af3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/549 From amitkumar at openjdk.org Mon May 6 08:19:55 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 6 May 2024 08:19:55 GMT Subject: [jdk21u-dev] Integrated: 8330011: [s390x] update block-comments to make code consistent In-Reply-To: References: Message-ID: On Sat, 27 Apr 2024 05:54:18 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [01bda278](https://github.com/openjdk/jdk/commit/01bda278d6a498ca89c0bc5218680cd51a04e9d3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 17 Apr 2024 and was reviewed by Lutz Schmidt. > > Thanks! This pull request has now been integrated. Changeset: 3ff53596 Author: Amit Kumar Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/3ff535969372b5d01517eff3d03528df13bf300e Stats: 30 lines in 2 files changed: 2 ins; 0 del; 28 mod 8330011: [s390x] update block-comments to make code consistent Reviewed-by: lucy Backport-of: 01bda278d6a498ca89c0bc5218680cd51a04e9d3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/539 From syan at openjdk.org Mon May 6 08:22:00 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 6 May 2024 08:22:00 GMT Subject: [jdk21u-dev] RFR: 8331331: :tier1 target explanation in doc/testing.md is incorrect In-Reply-To: References: Message-ID: On Fri, 3 May 2024 16:12:39 GMT, SendaoYan wrote: > Hi, > This is clean backport of [JDK-8331331](https://bugs.openjdk.org/browse/JDK-8331331), fixed the incorrect explanation :tier1 target in doc/testing.md. No risk. > /sponsor @shipilev Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/551#issuecomment-2095432453 From mbaesken at openjdk.org Mon May 6 08:27:57 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 6 May 2024 08:27:57 GMT Subject: [jdk11u-dev] RFR: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException In-Reply-To: References: Message-ID: On Mon, 6 May 2024 07:45:41 GMT, Christoph Langer wrote: > The backport of [JDK-8248194](https://bugs.openjdk.org/browse/JDK-8248194) introduced the testing of core files in test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java. This can cause issues which we are seeing on MacOS arm64. With this backport, these seem to be gone. > > The fix does not exactly fit into the 11u-dev codebase, so I had to make several adpatations. When comparing to 17u-dev https://github.com/openjdk/jdk17u-dev/pull/1903/files I still see the 8269982 exclusions for macosx-aarch64 in the problem list. Why is that ? E.g. TestJmapCore.java. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2698#issuecomment-2095441376 From amitkumar at openjdk.org Mon May 6 08:30:59 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 6 May 2024 08:30:59 GMT Subject: [jdk21u-dev] Integrated: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking In-Reply-To: References: Message-ID: On Fri, 26 Apr 2024 16:34:25 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [47df1459](https://github.com/openjdk/jdk/commit/47df14590c003ccb1607ec0edfe999fcf2aebd86) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 10 Apr 2024 and was reviewed by Lutz Schmidt and Martin Doerr. > > Thanks! > > Benchmarking: > > ./build/linux-s390x-server-release/jdk/bin/java -Xms4g -Xmx4g -jar dacapo-9.12-MR1-bach.jar h2 -s huge -t 1 -n 1 > > Without the patch: > > ===== DaCapo 9.12-MR1 h2 PASSED in 209768 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 197472 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 222872 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 215725 msec ===== > > > with patch: > ===== DaCapo 9.12-MR1 h2 PASSED in 171055 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 169696 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 174032 msec ===== > ===== DaCapo 9.12-MR1 h2 PASSED in 167271 msec ===== This pull request has now been integrated. Changeset: 91598828 Author: Amit Kumar Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/915988281c47bd03d334d98701fcbabda67318a7 Stats: 78 lines in 1 file changed: 32 ins; 14 del; 32 mod 8310513: [s390x] Intrinsify recursive ObjectMonitor locking Reviewed-by: lucy Backport-of: 47df14590c003ccb1607ec0edfe999fcf2aebd86 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/537 From clanger at openjdk.org Mon May 6 08:31:20 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 6 May 2024 08:31:20 GMT Subject: [jdk11u-dev] RFR: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket Message-ID: Hi all, This pull request contains a backport of [JDK-8325579](https://bugs.openjdk.org/browse/JDK-8325579), commit [32bf1f41](https://github.com/openjdk/jdk17u-dev/commit/32bf1f4169fd07291d608323c143832ad48e531e) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. The commit being backported was authored by Christoph Langer on 4 May 2024 and had no reviewers. Thanks! ------------- Commit messages: - Backport 32bf1f4169fd07291d608323c143832ad48e531e Changes: https://git.openjdk.org/jdk11u-dev/pull/2699/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2699&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325579 Stats: 246 lines in 3 files changed: 130 ins; 34 del; 82 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2699.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2699/head:pull/2699 PR: https://git.openjdk.org/jdk11u-dev/pull/2699 From shade at openjdk.org Mon May 6 08:41:01 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 6 May 2024 08:41:01 GMT Subject: [jdk21u-dev] RFR: 8328938: C2 SuperWord: disable vectorization for large stride and scale [v2] In-Reply-To: References: Message-ID: On Wed, 17 Apr 2024 09:42:33 GMT, Aleksey Shipilev wrote: >> Unclean backport to prevent accidents in C2 loop optimizations. The patch is unclean, because JDK 21u misses major SuperWord refactorings. I applied the hunk by hand in the similar place, and also used `slp->iv_stride()` in one place to get this thing to work. >> >> @eme64, if you want to take a look at this? >> >> Additional testing: >> - [x] New regression test fails without the patch, passes with it >> - [x] Linux x86_64 server fastdebug, `all` >> - [x] Linux x86_64 server fastdebug, 100K Fuzzer tests >> - [x] Linux x86_64 server fastdebug, Maven CTW > > Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: > > Check if stride is actually con before touching iv_stride Thanks all! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/495#issuecomment-2095460596 From shade at openjdk.org Mon May 6 08:41:02 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 6 May 2024 08:41:02 GMT Subject: [jdk21u-dev] Integrated: 8328938: C2 SuperWord: disable vectorization for large stride and scale In-Reply-To: References: Message-ID: <3hYW4TxHjf_UH-yKYbQ8cH9q3diPSOSPUXcsCNx5SdM=.33dfd15e-e156-43b5-9946-ec1e414656e5@github.com> On Fri, 12 Apr 2024 08:04:17 GMT, Aleksey Shipilev wrote: > Unclean backport to prevent accidents in C2 loop optimizations. The patch is unclean, because JDK 21u misses major SuperWord refactorings. I applied the hunk by hand in the similar place, and also used `slp->iv_stride()` in one place to get this thing to work. > > @eme64, if you want to take a look at this? > > Additional testing: > - [x] New regression test fails without the patch, passes with it > - [x] Linux x86_64 server fastdebug, `all` > - [x] Linux x86_64 server fastdebug, 100K Fuzzer tests > - [x] Linux x86_64 server fastdebug, Maven CTW This pull request has now been integrated. Changeset: 2b858f5b Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/2b858f5bdee5bcb29ef6ecf995400b390a2cb91f Stats: 272 lines in 2 files changed: 272 ins; 0 del; 0 mod 8328938: C2 SuperWord: disable vectorization for large stride and scale Reviewed-by: epeter, simonis Backport-of: 2931458711244e20eb7845a1aefcf6ed4206bce1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/495 From clanger at openjdk.org Mon May 6 08:41:53 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 6 May 2024 08:41:53 GMT Subject: [jdk21u-dev] Integrated: 8331639: [21u]: Bump GHA bootstrap JDK to 21.0.3 In-Reply-To: <-6dkMCxUCy_YVQE62OLyNT3-Lh21_Gg40zVgUQRmDNo=.e28cfe96-8d53-4732-8e67-88d6eb70380d@github.com> References: <-6dkMCxUCy_YVQE62OLyNT3-Lh21_Gg40zVgUQRmDNo=.e28cfe96-8d53-4732-8e67-88d6eb70380d@github.com> Message-ID: On Fri, 3 May 2024 09:28:43 GMT, Christoph Langer wrote: > From time to time the GHA bootstrap JDK in the update releases should be bumped. So let's take the current verion 21.0.3 from Temurin. This pull request has now been integrated. Changeset: 16ba673e Author: Christoph Langer URL: https://git.openjdk.org/jdk21u-dev/commit/16ba673e14038ed19b95e345b823316ff58a2182 Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod 8331639: [21u]: Bump GHA bootstrap JDK to 21.0.3 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/550 From clanger at openjdk.org Mon May 6 08:42:54 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 6 May 2024 08:42:54 GMT Subject: [jdk11u-dev] Integrated: 8331643: [11u]: Bump GHA bootstrap JDK to 11.0.23 In-Reply-To: References: Message-ID: <8bdvxPeFluKV1VdMEgvF-9ky5IpBqI03STYcHGUd3AE=.b9ddd636-dec5-4e31-8b5f-de761bbf0a29@github.com> On Fri, 3 May 2024 09:35:06 GMT, Christoph Langer wrote: > From time to time the GHA bootstrap JDK in the update releases should be bumped. So let's take the current verion 11.0.23 from Temurin. This pull request has now been integrated. Changeset: b7822c39 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/b7822c39d323e470ea63289cf72c6a5ec43e6107 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod 8331643: [11u]: Bump GHA bootstrap JDK to 11.0.23 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2697 From clanger at openjdk.org Mon May 6 08:43:02 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 6 May 2024 08:43:02 GMT Subject: [jdk17u-dev] Integrated: 8331641: [17u]: Bump GHA bootstrap JDK to 17.0.11 In-Reply-To: <5wRkRSGpaMakayJ-_8_jrQCqYBCidCo3Ss16-p_E6u4=.c20fe122-73fb-46de-8389-21fa1c88f799@github.com> References: <5wRkRSGpaMakayJ-_8_jrQCqYBCidCo3Ss16-p_E6u4=.c20fe122-73fb-46de-8389-21fa1c88f799@github.com> Message-ID: On Fri, 3 May 2024 09:32:09 GMT, Christoph Langer wrote: > From time to time the GHA bootstrap JDK in the update releases should be bumped. So let's take the current verion 17.0.11 from Temurin. This pull request has now been integrated. Changeset: d2982c67 Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/d2982c673053bdea8bc122230a4d57eda76832ef Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod 8331641: [17u]: Bump GHA bootstrap JDK to 17.0.11 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2444 From rrich at openjdk.org Mon May 6 08:53:54 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Mon, 6 May 2024 08:53:54 GMT Subject: [jdk21u-dev] RFR: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared [v2] In-Reply-To: References: Message-ID: <7Gy_cdbAaG8fy-d8lDYhKDDCzWQXZqAmexEIIr9IsB4=.998c1f37-0db6-415c-b13a-3217edb3a78e@github.com> On Mon, 25 Mar 2024 10:23:41 GMT, Aleksey Shipilev wrote: >> Unclean backport to match the codebases between mainline and JDK 21, simplifying maintenance. It also implicitly fixes [JDK-8323505](https://bugs.openjdk.org/browse/JDK-8323505), since this move includes a few touchups to the test. >> >> The uncleanliness comes from `MethodType.java` conflicts that does not have [JDK-8310849](https://bugs.openjdk.org/browse/JDK-8310849) in JDK 21. So it yields a few contextual conflicts. Since affected hunks are just removals, I removed them by hand. >> >> There is a follow-up, [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255), but it does not seem to affect anything yet, since there are no `ReferenceKeySet.add` calls anywhere in sight. We can backport that separately. >> >> Additional testing: >> - [x] MacOS AArch64 Server fastdebug, `jdk/internal/util` tests pass >> - [x] MacOS AArch64 Server fastdebug, `java/lang/invoke` tests pass >> - [x] Linux AArch64 Server fastdebug, `all` tests pass > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8310913-referenced-key-map > - Backport 6af0af593446bc33dc94bbf7334c325c4ac0ac0f > > Reviewed-by: naoto, rriggs, mchung, liach > There is a follow-up, [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255), but it does not seem to affect anything yet, since there are no ReferenceKeySet.add calls anywhere in sight. We can backport that separately. Don't you think that will be forgotten? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/342#issuecomment-2095486221 From shade at openjdk.org Mon May 6 09:00:54 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 6 May 2024 09:00:54 GMT Subject: [jdk21u-dev] RFR: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared [v2] In-Reply-To: <7Gy_cdbAaG8fy-d8lDYhKDDCzWQXZqAmexEIIr9IsB4=.998c1f37-0db6-415c-b13a-3217edb3a78e@github.com> References: <7Gy_cdbAaG8fy-d8lDYhKDDCzWQXZqAmexEIIr9IsB4=.998c1f37-0db6-415c-b13a-3217edb3a78e@github.com> Message-ID: On Mon, 6 May 2024 08:51:30 GMT, Richard Reingruber wrote: > > There is a follow-up, [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255), but it does not seem to affect anything yet, since there are no ReferenceKeySet.add calls anywhere in sight. We can backport that separately. > > Don't you think that will be forgotten? Not sure what do you mean. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/342#issuecomment-2095497287 From rrich at openjdk.org Mon May 6 09:10:58 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Mon, 6 May 2024 09:10:58 GMT Subject: [jdk21u-dev] RFR: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared [v2] In-Reply-To: References: <7Gy_cdbAaG8fy-d8lDYhKDDCzWQXZqAmexEIIr9IsB4=.998c1f37-0db6-415c-b13a-3217edb3a78e@github.com> Message-ID: On Mon, 6 May 2024 08:57:54 GMT, Aleksey Shipilev wrote: > > > There is a follow-up, [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255), but it does not seem to affect anything yet, since there are no ReferenceKeySet.add calls anywhere in sight. We can backport that separately. > > > > > > Don't you think that will be forgotten? > > Not sure what do you mean. Likely a misunderstanding on my side: I thought you did not want to backport [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255) until `ReferenceKeySet` is referenced. But you're going to do the backport soon after this backport, correct? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/342#issuecomment-2095516264 From lyang at openjdk.org Mon May 6 09:16:01 2024 From: lyang at openjdk.org (Long Yang) Date: Mon, 6 May 2024 09:16:01 GMT Subject: [jdk17u-dev] RFR: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate In-Reply-To: References: <8yDsUnG0HQVsCakGSjitm-ErWQvnkmKQqaF_cPGilEY=.20cc85c6-7e45-4256-b995-32034141df9c@github.com> Message-ID: <3H7HN0YfsfMOUjA_BwkEh6z8Xkl3yjKNyCdhxA1SxdU=.51c17d67-761c-4372-8221-798b46784564@github.com> On Fri, 19 Apr 2024 10:04:44 GMT, Long Yang wrote: >> Hi, all >> >> Could I have a review of this backport. >> >> This pull request contains a backport of commit [8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb](https://github.com/openjdk/jdk/commit/8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. >> >> Testing: I ran test/jdk/jdk/jfr/event/os/TestCPULoad.java and passed. All GHA tests are passed (except linux-cross-compile, build(riscv64), Create sysroot. It looks like there's an issue with the GHA's process). > > Sure, I'll deal with it next week > @yanglong1010, could you please first do the 22u backport? Thanks. Hi, @GoeLin I don't know if you can handle the [approval request](https://github.com/openjdk/jdk22u/pull/161) for 22u. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2277#issuecomment-2095524205 From shade at openjdk.org Mon May 6 09:17:25 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 6 May 2024 09:17:25 GMT Subject: [jdk21u-dev] RFR: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared [v3] In-Reply-To: References: Message-ID: > Unclean backport to match the codebases between mainline and JDK 21, simplifying maintenance. It also implicitly fixes [JDK-8323505](https://bugs.openjdk.org/browse/JDK-8323505), since this move includes a few touchups to the test. > > The uncleanliness comes from `MethodType.java` conflicts that does not have [JDK-8310849](https://bugs.openjdk.org/browse/JDK-8310849) in JDK 21. So it yields a few contextual conflicts. Since affected hunks are just removals, I removed them by hand. > > There is a follow-up, [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255), but it does not seem to affect anything yet, since there are no `ReferenceKeySet.add` calls anywhere in sight. We can backport that separately. > > Additional testing: > - [x] MacOS AArch64 Server fastdebug, `jdk/internal/util` tests pass > - [x] MacOS AArch64 Server fastdebug, `java/lang/invoke` tests pass > - [x] Linux AArch64 Server fastdebug, `all` tests pass Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into JDK-8310913-referenced-key-map - Merge branch 'master' into JDK-8310913-referenced-key-map - Backport 6af0af593446bc33dc94bbf7334c325c4ac0ac0f Reviewed-by: naoto, rriggs, mchung, liach ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/342/files - new: https://git.openjdk.org/jdk21u-dev/pull/342/files/62409055..46a84f54 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=342&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=342&range=01-02 Stats: 14614 lines in 600 files changed: 8578 ins; 3639 del; 2397 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/342.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/342/head:pull/342 PR: https://git.openjdk.org/jdk21u-dev/pull/342 From shade at openjdk.org Mon May 6 09:17:25 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 6 May 2024 09:17:25 GMT Subject: [jdk21u-dev] RFR: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared [v2] In-Reply-To: References: <7Gy_cdbAaG8fy-d8lDYhKDDCzWQXZqAmexEIIr9IsB4=.998c1f37-0db6-415c-b13a-3217edb3a78e@github.com> Message-ID: On Mon, 6 May 2024 09:08:39 GMT, Richard Reingruber wrote: > Likely a misunderstanding on my side: I thought you did not want to backport [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255) until `ReferenceKeySet` is referenced. But you're going to do the backport soon after this backport, correct? Yes. I was merely pointing out that we don't _have_ to backport JDK-8325255 along with JDK-8310913 atomically, because it technically does not break anything yet. Otherwise we would need to cobble together JDK-8325255 and JDK-8310913 into an atomic integration to avoid any breakage window. We can just sequence it for inclusion a bit later. Since you are here, maybe you would like to Review this PR? I jumped a gun a little here and got approval before RFR was formally reviewed, and I still cannot integrate :) I'll pull from master momentarily. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/342#issuecomment-2095524462 From clanger at openjdk.org Mon May 6 09:22:09 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 6 May 2024 09:22:09 GMT Subject: [jdk11u-dev] RFR: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException [v2] In-Reply-To: References: Message-ID: > The backport of [JDK-8248194](https://bugs.openjdk.org/browse/JDK-8248194) introduced the testing of core files in test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java. This can cause issues which we are seeing on MacOS arm64. With this backport, these seem to be gone. > > The fix does not exactly fit into the 11u-dev codebase, so I had to make several adpatations. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Remove issue 8269982 from exclude list - Merge branch 'master' into JDK-8293563 - 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException Reviewed-by: lucy Backport-of: 76f1865124025ee6f788a50e1377b82fd577548f (cherry picked from commit 5eeb41a7294f56bc258a154c043bc540cb8de5c4) ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2698/files - new: https://git.openjdk.org/jdk11u-dev/pull/2698/files/5cdad3f3..a81424e9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2698&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2698&range=00-01 Stats: 9 lines in 2 files changed: 0 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2698.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2698/head:pull/2698 PR: https://git.openjdk.org/jdk11u-dev/pull/2698 From rrich at openjdk.org Mon May 6 09:28:03 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Mon, 6 May 2024 09:28:03 GMT Subject: [jdk21u-dev] RFR: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared [v3] In-Reply-To: References: Message-ID: On Mon, 6 May 2024 09:17:25 GMT, Aleksey Shipilev wrote: >> Unclean backport to match the codebases between mainline and JDK 21, simplifying maintenance. It also implicitly fixes [JDK-8323505](https://bugs.openjdk.org/browse/JDK-8323505), since this move includes a few touchups to the test. >> >> The uncleanliness comes from `MethodType.java` conflicts that does not have [JDK-8310849](https://bugs.openjdk.org/browse/JDK-8310849) in JDK 21. So it yields a few contextual conflicts. Since affected hunks are just removals, I removed them by hand. >> >> There is a follow-up, [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255), but it does not seem to affect anything yet, since there are no `ReferenceKeySet.add` calls anywhere in sight. We can backport that separately. >> >> Additional testing: >> - [x] MacOS AArch64 Server fastdebug, `jdk/internal/util` tests pass >> - [x] MacOS AArch64 Server fastdebug, `java/lang/invoke` tests pass >> - [x] Linux AArch64 Server fastdebug, `all` tests pass > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into JDK-8310913-referenced-key-map > - Merge branch 'master' into JDK-8310913-referenced-key-map > - Backport 6af0af593446bc33dc94bbf7334c325c4ac0ac0f > > Reviewed-by: naoto, rriggs, mchung, liach This inquiry is part of my review :) I'm going to approve now... ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/342#issuecomment-2095545633 From rrich at openjdk.org Mon May 6 09:31:00 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Mon, 6 May 2024 09:31:00 GMT Subject: [jdk21u-dev] RFR: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared [v3] In-Reply-To: References: Message-ID: On Mon, 6 May 2024 09:17:25 GMT, Aleksey Shipilev wrote: >> Unclean backport to match the codebases between mainline and JDK 21, simplifying maintenance. It also implicitly fixes [JDK-8323505](https://bugs.openjdk.org/browse/JDK-8323505), since this move includes a few touchups to the test. >> >> The uncleanliness comes from `MethodType.java` conflicts that does not have [JDK-8310849](https://bugs.openjdk.org/browse/JDK-8310849) in JDK 21. So it yields a few contextual conflicts. Since affected hunks are just removals, I removed them by hand. >> >> There is a follow-up, [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255), but it does not seem to affect anything yet, since there are no `ReferenceKeySet.add` calls anywhere in sight. We can backport that separately. >> >> Additional testing: >> - [x] MacOS AArch64 Server fastdebug, `jdk/internal/util` tests pass >> - [x] MacOS AArch64 Server fastdebug, `java/lang/invoke` tests pass >> - [x] Linux AArch64 Server fastdebug, `all` tests pass > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into JDK-8310913-referenced-key-map > - Merge branch 'master' into JDK-8310913-referenced-key-map > - Backport 6af0af593446bc33dc94bbf7334c325c4ac0ac0f > > Reviewed-by: naoto, rriggs, mchung, liach The backport looks good. Please make sure not to forget the follow-up [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255). Cheers, Richard. ------------- Marked as reviewed by rrich (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/342#pullrequestreview-2040355466 From clanger at openjdk.org Mon May 6 09:35:55 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 6 May 2024 09:35:55 GMT Subject: [jdk11u-dev] RFR: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException In-Reply-To: References: Message-ID: On Mon, 6 May 2024 08:25:12 GMT, Matthias Baesken wrote: > When comparing to 17u-dev https://github.com/openjdk/jdk17u-dev/pull/1903/files I still see the 8269982 exclusions for macosx-aarch64 in the problem list. Why is that ? E.g. TestJmapCore.java. Good catch. Makes sense to remove this bug id in the three places where it currently appears. All of these tests have been addressed with this change. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2698#issuecomment-2095559325 From andrewlu at openjdk.org Mon May 6 09:38:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 6 May 2024 09:38:06 GMT Subject: [jdk11u-dev] RFR: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02 Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 62e6dfafc81a1bffb10943a961a030449534b51f Changes: https://git.openjdk.org/jdk11u-dev/pull/2700/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2700&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313702 Stats: 12 lines in 2 files changed: 9 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2700.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2700/head:pull/2700 PR: https://git.openjdk.org/jdk11u-dev/pull/2700 From shade at openjdk.org Mon May 6 09:44:23 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 6 May 2024 09:44:23 GMT Subject: [jdk21u-dev] RFR: 8320370: NMT: Change MallocMemorySnapshot to simplify code. Message-ID: Clean backport to improve NMT initialization and provide cleanliness for other backports. Additional testing: - [x] MacOS AArch64 server fastdebug, `runtime/NMT` ------------- Commit messages: - Backport a7f60164063bdf95437326e7550fd65ff91b5566 Changes: https://git.openjdk.org/jdk21u-dev/pull/552/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=552&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320370 Stats: 19 lines in 5 files changed: 0 ins; 12 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/552.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/552/head:pull/552 PR: https://git.openjdk.org/jdk21u-dev/pull/552 From shade at openjdk.org Mon May 6 09:56:53 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 6 May 2024 09:56:53 GMT Subject: [jdk21u-dev] RFR: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared [v3] In-Reply-To: References: Message-ID: <1QSs-meUlQHvvKeWM-QPmGwVSRae6dvBNIAlO9MYeSA=.ebae527d-73e9-41d3-bc81-76be6d961c09@github.com> On Mon, 6 May 2024 09:28:12 GMT, Richard Reingruber wrote: > The backport looks good. Thanks! I am re-running tests now, and will integrate once they turn up green. > Please make sure not to forget the follow-up [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255). Yes, I plan to propose it after integrating this one. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/342#issuecomment-2095598755 From aph at openjdk.org Mon May 6 10:07:06 2024 From: aph at openjdk.org (Andrew Haley) Date: Mon, 6 May 2024 10:07:06 GMT Subject: [jdk11u-dev] RFR: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException [v2] In-Reply-To: References: Message-ID: On Mon, 6 May 2024 09:22:09 GMT, Christoph Langer wrote: >> The backport of [JDK-8248194](https://bugs.openjdk.org/browse/JDK-8248194) introduced the testing of core files in test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java. This can cause issues which we are seeing on MacOS arm64. With this backport, these seem to be gone. >> >> The fix does not exactly fit into the 11u-dev codebase, so I had to make several adpatations. > > Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Remove issue 8269982 from exclude list > - Merge branch 'master' into JDK-8293563 > - 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException > > Reviewed-by: lucy > Backport-of: 76f1865124025ee6f788a50e1377b82fd577548f > (cherry picked from commit 5eeb41a7294f56bc258a154c043bc540cb8de5c4) The last time I tried, I couldn't get core files at all without doing a ton of fiddly config, turning off SIP, etc. Did you have to do any of that? Perhaps it's no longer a problem. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2698#issuecomment-2095617202 From clanger at openjdk.org Mon May 6 10:19:00 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 6 May 2024 10:19:00 GMT Subject: [jdk11u-dev] RFR: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException [v2] In-Reply-To: References: Message-ID: On Mon, 6 May 2024 10:04:06 GMT, Andrew Haley wrote: > The last time I tried, I couldn't get core files at all without doing a ton of fiddly config, turning off SIP, etc. Did you have to do any of that? Perhaps it's no longer a problem. Hm, when current jdk11u-dev hits our ci, the MacOS arm64 test is failing with exceptions like: sun.jvm.hotspot.oops.UnknownOopException at jdk.hotspot.agent/sun.jvm.hotspot.oops.ObjectHeap.newOop(ObjectHeap.java:266) at jdk.hotspot.agent/sun.jvm.hotspot.runtime.JavaThread.getThreadObj(JavaThread.java:359) at jdk.hotspot.agent/sun.jvm.hotspot.runtime.JavaThread.getCurrentParkBlocker(JavaThread.java:411) at jdk.hotspot.agent/sun.jvm.hotspot.runtime.DeadlockDetector.print(DeadlockDetector.java:82) at jdk.hotspot.agent/sun.jvm.hotspot.runtime.DeadlockDetector.print(DeadlockDetector.java:39) at jdk.hotspot.agent/sun.jvm.hotspot.tools.StackTrace.run(StackTrace.java:62) at jdk.hotspot.agent/sun.jvm.hotspot.CommandProcessor$24.doit(CommandProcessor.java:1066) at jdk.hotspot.agent/sun.jvm.hotspot.CommandProcessor.executeCommand(CommandProcessor.java:1974) at jdk.hotspot.agent/sun.jvm.hotspot.CommandProcessor.executeCommand(CommandProcessor.java:1944) at jdk.hotspot.agent/sun.jvm.hotspot.CommandProcessor.run(CommandProcessor.java:1824) at jdk.hotspot.agent/sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:99) at jdk.hotspot.agent/sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:40) at jdk.hotspot.agent/sun.jvm.hotspot.SALauncher.runCLHSDB(SALauncher.java:224) at jdk.hotspot.agent/sun.jvm.hotspot.SALauncher.main(SALauncher.java:522) And with this modification it goes away. That's all I can say... ? The failing tests are hotspot / serviceability/sa/ClhsdbFindPC.java#id1 hotspot / serviceability/sa/ClhsdbFindPC.java#id3 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2698#issuecomment-2095638229 From mbaesken at openjdk.org Mon May 6 11:44:53 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 6 May 2024 11:44:53 GMT Subject: [jdk11u-dev] RFR: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException In-Reply-To: References: Message-ID: <7xPvPkAkWKvOba8DNXBVv602LleRFLTNnZ5XRAFKd1c=.f434cf16-cd50-48ec-a847-935c5b1dcdb1@github.com> On Mon, 6 May 2024 09:32:55 GMT, Christoph Langer wrote: > > When comparing to 17u-dev https://github.com/openjdk/jdk17u-dev/pull/1903/files I still see the 8269982 exclusions for macosx-aarch64 in the problem list. Why is that ? E.g. TestJmapCore.java. > > Good catch. Makes sense to remove this bug id in the three places where it currently appears. All of these tests have been addressed with this change. You removed the bug-number 8269982, but not the references macosx-aarch64, why is that ? Please compare to https://github.com/openjdk/jdk17u-dev/pull/1903/files . ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2698#issuecomment-2095817549 From duke at openjdk.org Mon May 6 11:51:54 2024 From: duke at openjdk.org (Alexandru C. Moraru) Date: Mon, 6 May 2024 11:51:54 GMT Subject: [jdk21u-dev] Integrated: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition In-Reply-To: References: Message-ID: On Fri, 26 Apr 2024 12:39:02 GMT, Alexandru C. Moraru wrote: > Clean backport to pass the correct string so that waitForDeduplication does not always wait for 10 seconds before proceeding. This pull request has now been integrated. Changeset: 7a400f2a Author: Alexandru C. Moraru Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/7a400f2a5945139efaa9323231df83cc592c68fb Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod 8309890: TestStringDeduplicationInterned.java waits for the wrong condition Backport-of: 63fe413d93861c79af5587859f01822980969c24 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/535 From mbaesken at openjdk.org Mon May 6 12:40:22 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 6 May 2024 12:40:22 GMT Subject: [jdk21u-dev] RFR: 8329663: hs_err file event log entry for thread adding/removing should print current thread Message-ID: <0c7opBedL7ik4Mo8-Lb5tkYlGOkhPnG4hG5kF_UZV4A=.7fdee911-83ea-47a2-8386-2e1f6a0fdca1@github.com> 8329663: hs_err file event log entry for thread adding/removing should print current thread ------------- Commit messages: - Backport 3ebf8c9359da2f45e4cefb7be2276d33c30979aa Changes: https://git.openjdk.org/jdk21u-dev/pull/553/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=553&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329663 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/553.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/553/head:pull/553 PR: https://git.openjdk.org/jdk21u-dev/pull/553 From mbaesken at openjdk.org Mon May 6 13:19:15 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 6 May 2024 13:19:15 GMT Subject: [jdk21u-dev] RFR: 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp Message-ID: Backport of 8330524 ------------- Commit messages: - Backport 252c62a66dd955a5d22f307544f38cc0dd4f2550 Changes: https://git.openjdk.org/jdk21u-dev/pull/554/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=554&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330524 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/554.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/554/head:pull/554 PR: https://git.openjdk.org/jdk21u-dev/pull/554 From mbaesken at openjdk.org Mon May 6 13:25:06 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 6 May 2024 13:25:06 GMT Subject: [jdk21u-dev] RFR: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN Message-ID: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN ------------- Commit messages: - Backport 5af6b45eefd227e3e046ca22a404ae8a23174160 Changes: https://git.openjdk.org/jdk21u-dev/pull/555/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=555&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330615 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/555.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/555/head:pull/555 PR: https://git.openjdk.org/jdk21u-dev/pull/555 From mbaesken at openjdk.org Mon May 6 13:59:01 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 6 May 2024 13:59:01 GMT Subject: [jdk21u-dev] RFR: 8331167: UBSan enabled build fails in adlc on macOS Message-ID: 8331167: UBSan enabled build fails in adlc on macOS ------------- Commit messages: - Backport 4edac349a5d695ce7923344ad5ad0400842241eb Changes: https://git.openjdk.org/jdk21u-dev/pull/556/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=556&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331167 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/556.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/556/head:pull/556 PR: https://git.openjdk.org/jdk21u-dev/pull/556 From clanger at openjdk.org Mon May 6 15:20:17 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 6 May 2024 15:20:17 GMT Subject: [jdk11u-dev] RFR: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException [v3] In-Reply-To: References: Message-ID: > The backport of [JDK-8248194](https://bugs.openjdk.org/browse/JDK-8248194) introduced the testing of core files in test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java. This can cause issues which we are seeing on MacOS arm64. With this backport, these seem to be gone. > > The fix does not exactly fit into the 11u-dev codebase, so I had to make several adpatations. Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: reenable some tests on macos-aarch64 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2698/files - new: https://git.openjdk.org/jdk11u-dev/pull/2698/files/a81424e9..c0eea458 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2698&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2698&range=01-02 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2698.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2698/head:pull/2698 PR: https://git.openjdk.org/jdk11u-dev/pull/2698 From clanger at openjdk.org Mon May 6 15:20:17 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 6 May 2024 15:20:17 GMT Subject: [jdk11u-dev] RFR: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException In-Reply-To: <7xPvPkAkWKvOba8DNXBVv602LleRFLTNnZ5XRAFKd1c=.f434cf16-cd50-48ec-a847-935c5b1dcdb1@github.com> References: <7xPvPkAkWKvOba8DNXBVv602LleRFLTNnZ5XRAFKd1c=.f434cf16-cd50-48ec-a847-935c5b1dcdb1@github.com> Message-ID: On Mon, 6 May 2024 11:41:52 GMT, Matthias Baesken wrote: > You removed the bug-number 8269982, but not the references macosx-aarch64, why is that ? Please compare to https://github.com/openjdk/jdk17u-dev/pull/1903/files . You could be right, the other bug ids all refer to non macos-aarch64 problems. So let's try and enable the tests for macos-aarch64. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2698#issuecomment-2096281547 From mbaesken at openjdk.org Mon May 6 15:27:07 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 6 May 2024 15:27:07 GMT Subject: [jdk11u-dev] RFR: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException In-Reply-To: References: <7xPvPkAkWKvOba8DNXBVv602LleRFLTNnZ5XRAFKd1c=.f434cf16-cd50-48ec-a847-935c5b1dcdb1@github.com> Message-ID: <-PnBE7Z80N1suQx9uBM3MXZiOBoaA-XvH0iovZzl-r8=.7689491c-71c6-47f4-b7a5-367625db0405@github.com> On Mon, 6 May 2024 15:17:38 GMT, Christoph Langer wrote: > So let's try and enable the tests for macos-aarch64. Change looks okay to me otherwise. Should we wait for some additional test outcomes after the macos-aarch64 reenabling ? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2698#issuecomment-2096291609 From clanger at openjdk.org Mon May 6 15:27:07 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 6 May 2024 15:27:07 GMT Subject: [jdk11u-dev] RFR: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException In-Reply-To: <-PnBE7Z80N1suQx9uBM3MXZiOBoaA-XvH0iovZzl-r8=.7689491c-71c6-47f4-b7a5-367625db0405@github.com> References: <7xPvPkAkWKvOba8DNXBVv602LleRFLTNnZ5XRAFKd1c=.f434cf16-cd50-48ec-a847-935c5b1dcdb1@github.com> <-PnBE7Z80N1suQx9uBM3MXZiOBoaA-XvH0iovZzl-r8=.7689491c-71c6-47f4-b7a5-367625db0405@github.com> Message-ID: On Mon, 6 May 2024 15:22:44 GMT, Matthias Baesken wrote: > > So let's try and enable the tests for macos-aarch64. > > Change looks okay to me otherwise. Should we wait for some additional test outcomes after the macos-aarch64 reenabling ? Yes, let's wait for GHA and SAP nightlies. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2698#issuecomment-2096294359 From mbaesken at openjdk.org Mon May 6 15:33:53 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 6 May 2024 15:33:53 GMT Subject: [jdk11u-dev] RFR: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket In-Reply-To: References: Message-ID: On Mon, 6 May 2024 08:25:43 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8325579](https://bugs.openjdk.org/browse/JDK-8325579), commit [32bf1f41](https://github.com/openjdk/jdk17u-dev/commit/32bf1f4169fd07291d608323c143832ad48e531e) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > > The commit being backported was authored by Christoph Langer on 4 May 2024 and had no reviewers. > > Thanks! Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2699#pullrequestreview-2041059779 From pminborg at openjdk.org Mon May 6 19:30:59 2024 From: pminborg at openjdk.org (Per Minborg) Date: Mon, 6 May 2024 19:30:59 GMT Subject: [jdk22u] RFR: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment In-Reply-To: References: Message-ID: <3imXGqTxn_sI9pgTyqt_W5qABpX-X1VaAEtdHhrqxnU=.505ae687-01a6-44fa-9251-4fe2c08efcf5@github.com> On Mon, 8 Apr 2024 07:08:33 GMT, Per Minborg wrote: > Hi all, > > This pull request contains a backport of commit [93579c29](https://github.com/openjdk/jdk/commit/93579c29e3ba60a8bc16d712e7ffc733f324a223) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Per Minborg on 25 Mar 2024 and was reviewed by Maurizio Cimadamore. > > Thanks! Please review this PR. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/131#issuecomment-2096752807 From pminborg at openjdk.org Mon May 6 19:40:58 2024 From: pminborg at openjdk.org (Per Minborg) Date: Mon, 6 May 2024 19:40:58 GMT Subject: [jdk22u] RFR: 8330176: Typo in Linker javadoc In-Reply-To: <5cXupfSrZm-O0_NLcnstadk0j-DCv2qGpvYXxQpXWME=.d052add3-be50-4abf-9139-1fdfa4f5e92b@github.com> References: <5cXupfSrZm-O0_NLcnstadk0j-DCv2qGpvYXxQpXWME=.d052add3-be50-4abf-9139-1fdfa4f5e92b@github.com> Message-ID: On Mon, 15 Apr 2024 14:16:42 GMT, Per Minborg wrote: > Hi all, > > This pull request contains a backport of commit [60d88b7a](https://github.com/openjdk/jdk/commit/60d88b7ae2945724ab4db44207e3390bcff172c0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Per Minborg on 15 Apr 2024 and was reviewed by Maurizio Cimadamore. > > Thanks! Could we get maintainer approval? ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/142#issuecomment-2096771743 From kcr at openjdk.org Mon May 6 20:00:06 2024 From: kcr at openjdk.org (Kevin Rushforth) Date: Mon, 6 May 2024 20:00:06 GMT Subject: [jdk22u] RFR: 8330176: Typo in Linker javadoc In-Reply-To: References: <5cXupfSrZm-O0_NLcnstadk0j-DCv2qGpvYXxQpXWME=.d052add3-be50-4abf-9139-1fdfa4f5e92b@github.com> Message-ID: <1BRnlGwWvaGDABkKSxuRXbbhmnnASMXvkuebSGrv1BM=.5e4c23ab-5c2b-41be-8ae6-4a75e8a4c646@github.com> On Mon, 6 May 2024 19:38:39 GMT, Per Minborg wrote: > Could we get maintainer approval? You first need to request it, either using the Skara `/approval request REASON FOR THE REQUEST` command, or by adding the appropriate label / comment in JBS. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/142#issuecomment-2096801117 From mdoerr at openjdk.org Mon May 6 21:07:27 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 6 May 2024 21:07:27 GMT Subject: [jdk17u-dev] RFR: 8272315: Improve assert_different_registers Message-ID: Clean backport of [JDK-8272315](https://bugs.openjdk.org/browse/JDK-8272315). It's only an enhancement, but it is required for other changes. E.g. the "Represent Registers as values" changes which were done for GCC 11 support like [JDK-8297445](https://bugs.openjdk.org/browse/JDK-8297445) don't build without it: `no known conversion for argument 1 from 'Register' to 'AbstractRegister' {aka 'AbstractRegisterImpl*'}` ------------- Commit messages: - Backport 93cab7d07d56fef6973ce8ac2e8232e8f3b185dd Changes: https://git.openjdk.org/jdk17u-dev/pull/2448/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2448&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272315 Stats: 257 lines in 1 file changed: 0 ins; 246 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2448.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2448/head:pull/2448 PR: https://git.openjdk.org/jdk17u-dev/pull/2448 From amitkumar at openjdk.org Tue May 7 04:40:14 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Tue, 7 May 2024 04:40:14 GMT Subject: [jdk17u-dev] RFR: 8298413: [s390] CPUInfoTest fails due to uppercase feature string Message-ID: Hi all, This pull request contains a backport of commit [9dad874f](https://github.com/openjdk/jdk/commit/9dad874ff9f03f5891aa8b37e7826a67c851f06d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 7 Feb 2023 and was reviewed by Martin Doerr and Lutz Schmidt. Thanks! ------------- Commit messages: - Backport 9dad874ff9f03f5891aa8b37e7826a67c851f06d Changes: https://git.openjdk.org/jdk17u-dev/pull/2449/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2449&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298413 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2449.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2449/head:pull/2449 PR: https://git.openjdk.org/jdk17u-dev/pull/2449 From amitkumar at openjdk.org Tue May 7 05:15:52 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Tue, 7 May 2024 05:15:52 GMT Subject: [jdk17u-dev] RFR: 8298413: [s390] CPUInfoTest fails due to uppercase feature string In-Reply-To: References: Message-ID: On Tue, 7 May 2024 04:35:29 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [9dad874f](https://github.com/openjdk/jdk/commit/9dad874ff9f03f5891aa8b37e7826a67c851f06d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 7 Feb 2023 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! I have done testing on s390x and test is passing on JDK17u-dev without any issue. I guess if I backport https://github.com/openjdk/jdk/pull/8142 then it could be `clean`. But I'm not sure. @RealLucy would you please review this one and look if I should backport the PR I mentioned above ? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2449#issuecomment-2097460339 From clanger at openjdk.org Tue May 7 05:45:01 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 7 May 2024 05:45:01 GMT Subject: [jdk11u-dev] RFR: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException [v3] In-Reply-To: References: Message-ID: On Mon, 6 May 2024 15:20:17 GMT, Christoph Langer wrote: >> The backport of [JDK-8248194](https://bugs.openjdk.org/browse/JDK-8248194) introduced the testing of core files in test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java. This can cause issues which we are seeing on MacOS arm64. With this backport, these seem to be gone. >> >> The fix does not exactly fit into the 11u-dev codebase, so I had to make several adpatations. > > Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: > > reenable some tests on macos-aarch64 Testing looks good. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2698#issuecomment-2097489735 From mbaesken at openjdk.org Tue May 7 07:02:01 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 7 May 2024 07:02:01 GMT Subject: [jdk11u-dev] RFR: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException [v3] In-Reply-To: References: Message-ID: On Mon, 6 May 2024 15:20:17 GMT, Christoph Langer wrote: >> The backport of [JDK-8248194](https://bugs.openjdk.org/browse/JDK-8248194) introduced the testing of core files in test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java. This can cause issues which we are seeing on MacOS arm64. With this backport, these seem to be gone. >> >> The fix does not exactly fit into the 11u-dev codebase, so I had to make several adpatations. > > Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: > > reenable some tests on macos-aarch64 Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2698#pullrequestreview-2042222508 From mbaesken at openjdk.org Tue May 7 07:26:09 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 7 May 2024 07:26:09 GMT Subject: [jdk22u] RFR: 8329663: hs_err file event log entry for thread adding/removing should print current thread Message-ID: 8329663: hs_err file event log entry for thread adding/removing should print current thread ------------- Commit messages: - Backport 3ebf8c9359da2f45e4cefb7be2276d33c30979aa Changes: https://git.openjdk.org/jdk22u/pull/184/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=184&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329663 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/184.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/184/head:pull/184 PR: https://git.openjdk.org/jdk22u/pull/184 From mbaesken at openjdk.org Tue May 7 07:32:05 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 7 May 2024 07:32:05 GMT Subject: [jdk22u] RFR: 8331167: UBSan enabled build fails in adlc on macOS Message-ID: 8331167: UBSan enabled build fails in adlc on macOS ------------- Commit messages: - Backport 4edac349a5d695ce7923344ad5ad0400842241eb Changes: https://git.openjdk.org/jdk22u/pull/185/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=185&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331167 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/185.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/185/head:pull/185 PR: https://git.openjdk.org/jdk22u/pull/185 From syan at openjdk.org Tue May 7 07:38:00 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 7 May 2024 07:38:00 GMT Subject: [jdk21u-dev] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: References: Message-ID: On Thu, 2 May 2024 09:03:50 GMT, Goetz Lindenmaier wrote: >> Hi, >> This is clean backport of JDK-8331164, to fixed download failure when the URL needed to be redirected. >> Only change devkit shell script, the risk is low. > > Hi @sendaoYan , > The fix request comment is missing. Please backport to 22 first. Think about waiting for October release started on May 29. @GoeLin Thanks for the approve. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/543#issuecomment-2097642913 From syan at openjdk.org Tue May 7 07:38:00 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 7 May 2024 07:38:00 GMT Subject: [jdk17u-dev] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 17:58:25 GMT, SendaoYan wrote: > Hi, > This is clean backport of JDK-8331164, to fixed download failure when the URL needed to be redirected. > Only change devkit shell script, the risk is low. @GoeLin Thanks for the approve. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2441#issuecomment-2097642854 From mbaesken at openjdk.org Tue May 7 07:55:20 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 7 May 2024 07:55:20 GMT Subject: [jdk22u] RFR: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN Message-ID: <2KkUZItFZG2QFpVF4Br4ROtoImCcFMcoxnpKctJC-vk=.d8a5eaef-caad-47f4-bdbf-0e089a72438c@github.com> 8330615: avoid signed integer overflows in zip_util.c readCen / hashN ------------- Commit messages: - Backport 5af6b45eefd227e3e046ca22a404ae8a23174160 Changes: https://git.openjdk.org/jdk22u/pull/186/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=186&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330615 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/186.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/186/head:pull/186 PR: https://git.openjdk.org/jdk22u/pull/186 From rrich at openjdk.org Tue May 7 07:58:01 2024 From: rrich at openjdk.org (Richard Reingruber) Date: Tue, 7 May 2024 07:58:01 GMT Subject: [jdk11u-dev] RFR: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout In-Reply-To: References: Message-ID: On Tue, 30 Apr 2024 21:44:04 GMT, Amos Shi wrote: > Backport of [JDK-8269258](https://bugs.openjdk.org/browse/JDK-8269258), a pre-required dependency to [JDK-8327989](https://bugs.openjdk.org/browse/JDK-8327989) > - This PR contains 3 commits > - Commit 1 - is the `git apply` from the original commit > - Commit 2 - is the manual merge based on the `.rej` files. This commit can be `considered as clean` > - `ManyRequests.java.rej` > - `ManyRequestsLegacy.java.rej` > - Commit 3 - converts the `record` type to `class` > - Record type was added in `Java 14` via `JEP 359` > > Contents > - `ManyRequests.java.rej` content > > @@ -54,13 +55,18 @@ > import java.net.http.HttpClient.Builder; > import java.net.http.HttpRequest; > import java.net.http.HttpRequest.BodyPublishers; > +import java.net.http.HttpResponse; > import java.net.http.HttpResponse.BodyHandlers; > import java.time.Duration; > import java.util.Arrays; > import java.util.Formatter; > import java.util.HashMap; > import java.util.LinkedList; > +import java.util.Map; > import java.util.Random; > +import java.util.concurrent.CompletionException; > +import java.util.concurrent.CompletionStage; > +import java.util.concurrent.ConcurrentHashMap; > import java.util.concurrent.ExecutorService; > import java.util.concurrent.Executors; > import java.util.concurrent.ThreadFactory; > @@ -100,14 +116,14 @@ > } > > //static final int REQUESTS = 1000; > - static final int REQUESTS = 20; > + static final int REQUESTS = MAX_COUNT; > static final boolean INSERT_DELAY = Boolean.getBoolean("test.insertDelay"); > static final int CHUNK_SIZE = Math.max(0, > Integer.parseInt(System.getProperty("test.chunkSize", "0"))); > static final boolean XFIXED = Boolean.getBoolean("test.XFixed"); > > static class TestEchoHandler extends EchoHandler { > - final Random rand = jdk.test.lib.RandomFactory.getRandom(); > + final Random rand = RANDOM; > @Override > public void handle(HttpExchange e) throws IOException { > System.out.println("Server: received " + e.getRequestURI()); > > - `ManyRequestsLegacy.java.rej` content > > @@ -73,12 +80,20 @@ > import java.util.Random; > import java.util.logging.Logger; > import java.util.logging.Level; > + > +import jdk.test.lib.Platform; > +import jdk.test.lib.RandomFactory; > import jdk.test.lib.net.SimpleSSLContext; > import static java.net.Proxy.NO_PROXY; > > public class ManyRequestsLegacy { > > - volatile static int counter = 0; > + static final int MAX_COUNT = 20; > + static final int MAX_LIMIT = 40; > + static final AtomicInteger COUNT = ... Looks good to me. Cheers, Richard. ------------- Marked as reviewed by rrich (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2696#pullrequestreview-2042358307 From goetz at openjdk.org Tue May 7 08:21:58 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 7 May 2024 08:21:58 GMT Subject: [jdk21u-dev] Integrated: 8310228: Improve error reporting for uncaught native exceptions on Windows In-Reply-To: <680TRW-ipLTBYJ7-KQxshXyOKLB82yCnA_Tn2FOWpHY=.ce8dd5bc-9238-4034-a067-d0a74d65e9ac@github.com> References: <680TRW-ipLTBYJ7-KQxshXyOKLB82yCnA_Tn2FOWpHY=.ce8dd5bc-9238-4034-a067-d0a74d65e9ac@github.com> Message-ID: On Fri, 19 Apr 2024 10:08:17 GMT, Goetz Lindenmaier wrote: > A bugfix useful for windows. This pull request has now been integrated. Changeset: ed2f5a8d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/ed2f5a8d6497e1a32e382b32a686f70be2e3a9fe Stats: 155 lines in 4 files changed: 133 ins; 15 del; 7 mod 8310228: Improve error reporting for uncaught native exceptions on Windows Reviewed-by: stuefe Backport-of: 38bf1192b637cf3513cb25ac21f513bfb51cb55b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/510 From goetz at openjdk.org Tue May 7 08:23:04 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 7 May 2024 08:23:04 GMT Subject: [jdk21u-dev] Integrated: 8317007: Add bulk removal of dead nmethods during class unloading In-Reply-To: <_ru1bYUSOaylnCMA1-yLX3xwsC1ZfU_gUOvhfqvJmVs=.a1779d4d-9e54-4449-9b30-98b91fe9cb63@github.com> References: <_ru1bYUSOaylnCMA1-yLX3xwsC1ZfU_gUOvhfqvJmVs=.a1779d4d-9e54-4449-9b30-98b91fe9cb63@github.com> Message-ID: <8xcZ6-ugNfWrIup82huuPjVMTqlcxyjZryW7EtD88gk=.19277dd3-c8f5-4757-ac20-a5dae2d4b3c4@github.com> On Thu, 2 May 2024 11:29:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 21.0.4-oracle. > > Clean patch on top of 8317809. This pull request has now been integrated. Changeset: 92b43c57 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk21u-dev/commit/92b43c570eb3a83dff23f757d2805d9b2a44a738 Stats: 194 lines in 27 files changed: 129 ins; 43 del; 22 mod 8317007: Add bulk removal of dead nmethods during class unloading Backport-of: f55381950266088cc0284754b16663675867ac87 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/548 From stuefe at openjdk.org Tue May 7 08:28:01 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 7 May 2024 08:28:01 GMT Subject: [jdk22u] RFR: 8329663: hs_err file event log entry for thread adding/removing should print current thread In-Reply-To: References: Message-ID: On Tue, 7 May 2024 07:19:09 GMT, Matthias Baesken wrote: > 8329663: hs_err file event log entry for thread adding/removing should print current thread Makes sense ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk22u/pull/184#pullrequestreview-2042423629 From mdoerr at openjdk.org Tue May 7 08:37:59 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 7 May 2024 08:37:59 GMT Subject: [jdk17u-dev] RFR: 8272315: Improve assert_different_registers In-Reply-To: References: Message-ID: On Mon, 6 May 2024 21:02:04 GMT, Martin Doerr wrote: > Clean backport of [JDK-8272315](https://bugs.openjdk.org/browse/JDK-8272315). It's only an enhancement, but it is required for other changes. E.g. the "Represent Registers as values" changes which were done for GCC 11 support like [JDK-8297445](https://bugs.openjdk.org/browse/JDK-8297445) don't build without it: `no known conversion for argument 1 from 'Register' to 'AbstractRegister' {aka 'AbstractRegisterImpl*'}` GHA test failure is unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2448#issuecomment-2097751966 From clanger at openjdk.org Tue May 7 08:41:00 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 7 May 2024 08:41:00 GMT Subject: [jdk11u-dev] Integrated: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException In-Reply-To: References: Message-ID: On Mon, 6 May 2024 07:45:41 GMT, Christoph Langer wrote: > The backport of [JDK-8248194](https://bugs.openjdk.org/browse/JDK-8248194) introduced the testing of core files in test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java. This can cause issues which we are seeing on MacOS arm64. With this backport, these seem to be gone. > > The fix does not exactly fit into the 11u-dev codebase, so I had to make several adpatations. This pull request has now been integrated. Changeset: 4202063c Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/4202063c1b663cd0ed16209d54b257faf637cd08 Stats: 26 lines in 7 files changed: 14 ins; 0 del; 12 mod 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException Reviewed-by: mbaesken Backport-of: 5eeb41a7294f56bc258a154c043bc540cb8de5c4 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2698 From clanger at openjdk.org Tue May 7 08:44:54 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 7 May 2024 08:44:54 GMT Subject: [jdk11u-dev] Integrated: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket In-Reply-To: References: Message-ID: On Mon, 6 May 2024 08:25:43 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8325579](https://bugs.openjdk.org/browse/JDK-8325579), commit [32bf1f41](https://github.com/openjdk/jdk17u-dev/commit/32bf1f4169fd07291d608323c143832ad48e531e) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > > The commit being backported was authored by Christoph Langer on 4 May 2024 and had no reviewers. > > Thanks! This pull request has now been integrated. Changeset: c542dc91 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/c542dc913a765e9f7ab3ab47d51d5633f8716b9b Stats: 246 lines in 3 files changed: 130 ins; 34 del; 82 mod 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket Reviewed-by: mbaesken Backport-of: 32bf1f4169fd07291d608323c143832ad48e531e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2699 From shade at openjdk.org Tue May 7 08:51:52 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 7 May 2024 08:51:52 GMT Subject: [jdk21u-dev] RFR: 8320370: NMT: Change MallocMemorySnapshot to simplify code. In-Reply-To: References: Message-ID: On Mon, 6 May 2024 09:38:18 GMT, Aleksey Shipilev wrote: > Clean backport to improve NMT initialization and provide cleanliness for other backports. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `runtime/NMT` I think bots do not treat this backport as clean, because the afftected files were moved from `services` to `nmt`. So I need a formal review for this. @tstuefe, maybe? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/552#issuecomment-2097779530 From lucy at openjdk.org Tue May 7 09:15:53 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Tue, 7 May 2024 09:15:53 GMT Subject: [jdk17u-dev] RFR: 8298413: [s390] CPUInfoTest fails due to uppercase feature string In-Reply-To: References: Message-ID: On Tue, 7 May 2024 04:35:29 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [9dad874f](https://github.com/openjdk/jdk/commit/9dad874ff9f03f5891aa8b37e7826a67c851f06d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 7 Feb 2023 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! LGTM. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2449#pullrequestreview-2042548960 From lucy at openjdk.org Tue May 7 09:36:58 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Tue, 7 May 2024 09:36:58 GMT Subject: [jdk17u-dev] RFR: 8298413: [s390] CPUInfoTest fails due to uppercase feature string In-Reply-To: References: Message-ID: On Tue, 7 May 2024 04:35:29 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [9dad874f](https://github.com/openjdk/jdk/commit/9dad874ff9f03f5891aa8b37e7826a67c851f06d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 7 Feb 2023 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! >I guess if I backport [openjdk/jdk#8142](https://github.com/openjdk/jdk/pull/8142) then it could be `clean`. But I'm not sure. > You should never consider backporting such a huge, and unrelated, change just to achieve cleanliness of such a trivial backport. The effort you have to invest is way higher than the benefit you get. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2449#issuecomment-2097869040 From shade at openjdk.org Tue May 7 09:50:59 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 7 May 2024 09:50:59 GMT Subject: [jdk21u-dev] Integrated: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared In-Reply-To: References: Message-ID: On Fri, 8 Mar 2024 09:26:11 GMT, Aleksey Shipilev wrote: > Unclean backport to match the codebases between mainline and JDK 21, simplifying maintenance. It also implicitly fixes [JDK-8323505](https://bugs.openjdk.org/browse/JDK-8323505), since this move includes a few touchups to the test. > > The uncleanliness comes from `MethodType.java` conflicts that does not have [JDK-8310849](https://bugs.openjdk.org/browse/JDK-8310849) in JDK 21. So it yields a few contextual conflicts. Since affected hunks are just removals, I removed them by hand. > > There is a follow-up, [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255), but it does not seem to affect anything yet, since there are no `ReferenceKeySet.add` calls anywhere in sight. We can backport that separately. > > Additional testing: > - [x] MacOS AArch64 Server fastdebug, `jdk/internal/util` tests pass > - [x] MacOS AArch64 Server fastdebug, `java/lang/invoke` tests pass > - [x] Linux AArch64 Server fastdebug, `all` tests pass This pull request has now been integrated. Changeset: ec6b3260 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/ec6b32601095017a2641f4b82143e83bef5f37b6 Stats: 1522 lines in 13 files changed: 887 ins; 627 del; 8 mod 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared Reviewed-by: rrich Backport-of: 6af0af593446bc33dc94bbf7334c325c4ac0ac0f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/342 From shade at openjdk.org Tue May 7 10:16:18 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 7 May 2024 10:16:18 GMT Subject: [jdk21u-dev] RFR: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test Message-ID: <6v18T3HimaJWMmqKlHbFjU0O_VEhzXsUUKfMfRKYhcs=.10add37d-acad-42ef-a5fb-f0484ceab54e@github.com> Clean backport, follow up for recent [JDK-8310913](https://bugs.openjdk.org/browse/JDK-8310913) integration. Nothing AFAICS is using the affected method except the test itself. Additional testing: - [x] New regression test fails without the fix, passes with it ------------- Commit messages: - Backport a7461de231da20ed78a7c6ad8275f1bafbfa556c Changes: https://git.openjdk.org/jdk21u-dev/pull/557/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=557&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325255 Stats: 33 lines in 3 files changed: 32 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/557.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/557/head:pull/557 PR: https://git.openjdk.org/jdk21u-dev/pull/557 From fmatte at openjdk.org Tue May 7 10:29:23 2024 From: fmatte at openjdk.org (Fairoz Matte) Date: Tue, 7 May 2024 10:29:23 GMT Subject: [jdk22u] RFR: 8322726: C2: Unloaded signature class kills argument value Message-ID: <7Mcb5LYSw_pxRnt_PCkP8-CeSx8AlKzQt4zNyzRY6H0=.db0cc31f-e452-468a-9e12-ae87c121ef4c@github.com> 8322726: C2: Unloaded signature class kills argument value Reviewed-by: kvn, dlong, thartmann ------------- Commit messages: - 8322726: C2: Unloaded signature class kills argument value Changes: https://git.openjdk.org/jdk22u/pull/187/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=187&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322726 Stats: 181 lines in 5 files changed: 168 ins; 0 del; 13 mod Patch: https://git.openjdk.org/jdk22u/pull/187.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/187/head:pull/187 PR: https://git.openjdk.org/jdk22u/pull/187 From clanger at openjdk.org Tue May 7 10:52:15 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 7 May 2024 10:52:15 GMT Subject: [jdk11u-dev] RFR: 8331790: [11u] Remove problemlist entries after backport of JDK-8228649 Message-ID: [JDK-8228649](https://bugs.openjdk.org/browse/JDK-8228649) had already been backported to 11.0.5. [JDK-8211767](https://bugs.openjdk.org/browse/JDK-8211767) was marked as duplicate of the former but in the hotspot problemlist we still find exclusions referring to it. So it seems we can drop them. ------------- Commit messages: - JDK-8331790 Changes: https://git.openjdk.org/jdk11u-dev/pull/2701/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2701&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331790 Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2701.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2701/head:pull/2701 PR: https://git.openjdk.org/jdk11u-dev/pull/2701 From amitkumar at openjdk.org Tue May 7 11:06:02 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Tue, 7 May 2024 11:06:02 GMT Subject: [jdk17u-dev] RFR: 8298413: [s390] CPUInfoTest fails due to uppercase feature string In-Reply-To: References: Message-ID: On Tue, 7 May 2024 09:34:04 GMT, Lutz Schmidt wrote: >You should never consider backporting such a huge, and unrelated, change just to achieve cleanliness of such a trivial backport. The effort you have to invest is way higher than the benefit you get. Sure. Thank you. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2449#issuecomment-2098130147 From kyukihiro at openjdk.org Tue May 7 11:22:04 2024 From: kyukihiro at openjdk.org (Kimura Yukihiro) Date: Tue, 7 May 2024 11:22:04 GMT Subject: [jdk11u-dev] RFR: 8331750: [11u] JDK-8259530 is not backported correctly to 11u Message-ID: This bug fix addresses the issue reported in https://github.com/openjdk/jdk11u-dev/pull/1805#issuecomment-2082702728. I have confirmed that the fix passes the following tests: - test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java - All langtool tests Could someone please review the fix? Thanks, Kimura Yukihiro ------------- Commit messages: - 8331750:[11u] JDK-8259530 is not backported correctly to 11u Changes: https://git.openjdk.org/jdk11u-dev/pull/2702/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2702&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331750 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2702.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2702/head:pull/2702 PR: https://git.openjdk.org/jdk11u-dev/pull/2702 From shade at openjdk.org Tue May 7 11:27:55 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 7 May 2024 11:27:55 GMT Subject: [jdk22u] Integrated: 8328822: C2: "negative trip count?" assert failure in profile predicate code In-Reply-To: References: Message-ID: On Thu, 2 May 2024 12:35:32 GMT, Aleksey Shipilev wrote: > Simple corner case fix in C2. > > Additional testing: > - [x] New regression test fails without the fix, passes with it This pull request has now been integrated. Changeset: e77a0478 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/e77a0478c92692283e3b6bad2ef261438e359f52 Stats: 65 lines in 2 files changed: 64 ins; 0 del; 1 mod 8328822: C2: "negative trip count?" assert failure in profile predicate code Backport-of: 2ceeb6c00135310b7bdabacb92d26d81de525240 ------------- PR: https://git.openjdk.org/jdk22u/pull/179 From lmao at openjdk.org Tue May 7 13:21:03 2024 From: lmao at openjdk.org (Liang Mao) Date: Tue, 7 May 2024 13:21:03 GMT Subject: [jdk21u-dev] Integrated: 8319376: ParallelGC: Forwarded objects found during heap inspection In-Reply-To: References: Message-ID: On Tue, 30 Apr 2024 09:43:58 GMT, Liang Mao wrote: > Clean backport of fixing the potential self forwarding object in heap inspection of Parallel GC This pull request has now been integrated. Changeset: 41fda4a5 Author: Liang Mao Committer: Zhengyu Gu URL: https://git.openjdk.org/jdk21u-dev/commit/41fda4a528e1b1a0620445392fb8a1579b3c32f2 Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod 8319376: ParallelGC: Forwarded objects found during heap inspection Backport-of: 59e9981ec21258b8aa5f93cb1fb9b0ccf9f846af ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/544 From lmao at openjdk.org Tue May 7 13:24:01 2024 From: lmao at openjdk.org (Liang Mao) Date: Tue, 7 May 2024 13:24:01 GMT Subject: [jdk21u-dev] Integrated: 8314573: G1: Heap resizing at Remark does not take existing eden regions into account In-Reply-To: References: Message-ID: <-WSv2jILvRbHQofrOUWn25D2uFXoOuYn8k05SOXWuOQ=.97c00de3-b7a6-48f5-ae8d-d399e8f22bca@github.com> On Mon, 1 Apr 2024 08:57:42 GMT, Liang Mao wrote: > Clean backport of fix of G1 Heap resizing heuristics at remark > > Additional testing: > - [x] Linux aarch64 server release/fastdebug, test/hotspot/jtreg/gc with +UseG1GC This pull request has now been integrated. Changeset: 93d091ad Author: Liang Mao Committer: Zhengyu Gu URL: https://git.openjdk.org/jdk21u-dev/commit/93d091ad35cccc9c7010ae6481a61feee7830e92 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod 8314573: G1: Heap resizing at Remark does not take existing eden regions into account Backport-of: 762b652912939b37fbd68955617705c62b9fc3a5 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/429 From aivanov at openjdk.org Tue May 7 13:24:58 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Tue, 7 May 2024 13:24:58 GMT Subject: [jdk22u] Integrated: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java In-Reply-To: References: Message-ID: On Wed, 1 May 2024 12:13:09 GMT, Alexey Ivanov wrote: > Backporting [JDK-8329510](https://bugs.openjdk.org/browse/JDK-8329510) which updates the bugid under which `javax/swing/JFileChooser/8194044/FileSystemRootTest.java` is problem-listed. This pull request has now been integrated. Changeset: f3f8176a Author: Alexey Ivanov URL: https://git.openjdk.org/jdk22u/commit/f3f8176a9f6f7d1ff6ad3696ff8db1d27682c5b1 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java Backport-of: 747582484ce89e16661ef917a89adb52f5adc2e6 ------------- PR: https://git.openjdk.org/jdk22u/pull/176 From duke at openjdk.org Tue May 7 15:09:09 2024 From: duke at openjdk.org (Johny Jose) Date: Tue, 7 May 2024 15:09:09 GMT Subject: [jdk22u] Integrated: 8330748: ByteArrayOutputStream.writeTo(OutputStream) pins carrier In-Reply-To: References: Message-ID: <8bg15YlHyRJ7gfgRJKxqIE6tUEFkS2Gpdv2EknlvGgQ=.72266d0f-754d-4a01-947a-7bbd9bd63410@github.com> On Fri, 3 May 2024 09:40:00 GMT, Johny Jose wrote: > clean backport of https://github.com/openjdk/jdk/commit/819f3d6fc70ff6fe54ac5f9033c17c3dd4326aa5 This pull request has now been integrated. Changeset: e4a1a7bd Author: Johny Jose URL: https://git.openjdk.org/jdk22u/commit/e4a1a7bd1f101cb33af25fa0aa3ee55f7d065b1f Stats: 142 lines in 2 files changed: 139 ins; 0 del; 3 mod 8330748: ByteArrayOutputStream.writeTo(OutputStream) pins carrier Reviewed-by: bpb, coffeys, jpai Backport-of: 819f3d6fc70ff6fe54ac5f9033c17c3dd4326aa5 ------------- PR: https://git.openjdk.org/jdk22u/pull/182 From clanger at openjdk.org Tue May 7 15:14:53 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 7 May 2024 15:14:53 GMT Subject: [jdk22u] Integrated: 8330815: Use pattern matching for instanceof in KeepAliveCache In-Reply-To: <-70UJBlXsqy-YIoJ_YkIJyBXO8bcyFNeNC_yIkBqd0k=.c4838c1b-1015-43db-954a-a2830efb8986@github.com> References: <-70UJBlXsqy-YIoJ_YkIJyBXO8bcyFNeNC_yIkBqd0k=.c4838c1b-1015-43db-954a-a2830efb8986@github.com> Message-ID: <7PD5Tdph9iz2xYwV30LOhOkkwSHyofANQN-vj7UL6qA=.348056d0-d0bd-4e4a-8912-579ae8627fd5@github.com> On Wed, 1 May 2024 20:49:07 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8330815](https://bugs.openjdk.org/browse/JDK-8330815), commit [e818ab60](https://github.com/openjdk/jdk/commit/e818ab60a0c1dac277b8b15301cdfb7d439ed26c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Christoph Langer on 25 Apr 2024 and was reviewed by Jaikiran Pai and Daniel Jeli?ski. > > Thanks! This pull request has now been integrated. Changeset: 0ec3c0b1 Author: Christoph Langer URL: https://git.openjdk.org/jdk22u/commit/0ec3c0b1e698f7ad39b4da2edb062721e4670f58 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8330815: Use pattern matching for instanceof in KeepAliveCache Backport-of: e818ab60a0c1dac277b8b15301cdfb7d439ed26c ------------- PR: https://git.openjdk.org/jdk22u/pull/178 From clanger at openjdk.org Tue May 7 15:14:58 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 7 May 2024 15:14:58 GMT Subject: [jdk22u] Integrated: 8330523: Reduce runtime and improve efficiency of KeepAliveTest In-Reply-To: References: Message-ID: On Wed, 1 May 2024 17:42:28 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8330523](https://bugs.openjdk.org/browse/JDK-8330523), commit [16c7dcdb](https://github.com/openjdk/jdk/commit/16c7dcdb04a7c220684a20eb4a0da4505ae03813) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Christoph Langer on 27 Apr 2024 and was reviewed by Daniel Jeli?ski. > > Thanks! This pull request has now been integrated. Changeset: 8eac95ec Author: Christoph Langer URL: https://git.openjdk.org/jdk22u/commit/8eac95ec3cd4b215556d788b9ade7a6e2f9deaa3 Stats: 1230 lines in 1 file changed: 75 ins; 1012 del; 143 mod 8330523: Reduce runtime and improve efficiency of KeepAliveTest Backport-of: 16c7dcdb04a7c220684a20eb4a0da4505ae03813 ------------- PR: https://git.openjdk.org/jdk22u/pull/177 From mbaesken at openjdk.org Tue May 7 15:24:04 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 7 May 2024 15:24:04 GMT Subject: [jdk22u] RFR: 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp Message-ID: <0udL507qVEU60WzjYGFcpSzOkb7G9ye4v5fub5Ux4Js=.96a749d2-9469-405b-b3f7-a1078ba3d392@github.com> Backport of 8330524 ------------- Commit messages: - Backport 252c62a66dd955a5d22f307544f38cc0dd4f2550 Changes: https://git.openjdk.org/jdk22u/pull/188/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=188&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330524 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/188.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/188/head:pull/188 PR: https://git.openjdk.org/jdk22u/pull/188 From zgu at openjdk.org Tue May 7 17:05:04 2024 From: zgu at openjdk.org (Zhengyu Gu) Date: Tue, 7 May 2024 17:05:04 GMT Subject: [jdk17u-dev] RFR: 8319713: Parallel: Remove PSAdaptiveSizePolicy::should_full_GC Message-ID: Backport this patch to jdk17u, as a prerequisite for clean backport of [JDK-8328744](https://bugs.openjdk.org/browse/JDK-8328744), which is a p2 bug. ------------- Commit messages: - Backport 4bcda602668835c35e2ac6ff6702d15cd249bc2a Changes: https://git.openjdk.org/jdk17u-dev/pull/2450/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2450&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319713 Stats: 24 lines in 3 files changed: 0 ins; 23 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2450.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2450/head:pull/2450 PR: https://git.openjdk.org/jdk17u-dev/pull/2450 From clanger at openjdk.org Tue May 7 21:26:23 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 7 May 2024 21:26:23 GMT Subject: [jdk21u-dev] RFR: 8330523: Reduce runtime and improve efficiency of KeepAliveTest Message-ID: Hi all, This pull request contains a backport of [JDK-8330523](https://bugs.openjdk.org/browse/JDK-8330523), commit [8eac95ec](https://github.com/openjdk/jdk22u/commit/8eac95ec3cd4b215556d788b9ade7a6e2f9deaa3) from the [openjdk/jdk22u](https://git.openjdk.org/jdk22u) repository. The commit being backported was authored by Christoph Langer on 7 May 2024 and had no reviewers. Thanks! ------------- Commit messages: - Backport 8eac95ec3cd4b215556d788b9ade7a6e2f9deaa3 Changes: https://git.openjdk.org/jdk21u-dev/pull/558/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=558&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330523 Stats: 1230 lines in 1 file changed: 75 ins; 1012 del; 143 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/558.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/558/head:pull/558 PR: https://git.openjdk.org/jdk21u-dev/pull/558 From clanger at openjdk.org Tue May 7 21:27:21 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 7 May 2024 21:27:21 GMT Subject: [jdk21u-dev] RFR: 8330815: Use pattern matching for instanceof in KeepAliveCache Message-ID: <013Kb3I6xQuLZhTEQmfjxfuLXKwUzhjagAC33C7_x2s=.11ff3445-bb06-4364-8657-f4e4ced8478c@github.com> Hi all, This pull request contains a backport of [JDK-8330815](https://bugs.openjdk.org/browse/JDK-8330815), commit [0ec3c0b1](https://github.com/openjdk/jdk22u/commit/0ec3c0b1e698f7ad39b4da2edb062721e4670f58) from the [openjdk/jdk22u](https://git.openjdk.org/jdk22u) repository. The commit being backported was authored by Christoph Langer on 7 May 2024 and had no reviewers. Thanks! ------------- Commit messages: - Backport 0ec3c0b1e698f7ad39b4da2edb062721e4670f58 Changes: https://git.openjdk.org/jdk21u-dev/pull/559/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=559&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330815 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/559.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/559/head:pull/559 PR: https://git.openjdk.org/jdk21u-dev/pull/559 From andrewlu at openjdk.org Wed May 8 02:01:02 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 8 May 2024 02:01:02 GMT Subject: [jdk11u-dev] Integrated: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02 In-Reply-To: References: Message-ID: On Mon, 6 May 2024 09:33:05 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. This pull request has now been integrated. Changeset: b9cb5721 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/b9cb5721c999093aaf8e40677e2bac919dab879e Stats: 12 lines in 2 files changed: 9 ins; 0 del; 3 mod 8313702: Update IANA Language Subtag Registry to Version 2023-08-02 Backport-of: 62e6dfafc81a1bffb10943a961a030449534b51f ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2700 From ashi at openjdk.org Wed May 8 06:03:01 2024 From: ashi at openjdk.org (Amos Shi) Date: Wed, 8 May 2024 06:03:01 GMT Subject: [jdk11u-dev] Integrated: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar In-Reply-To: References: Message-ID: On Tue, 30 Apr 2024 18:57:20 GMT, Amos Shi wrote: > Backport of [JDK-8283349](https://bugs.openjdk.org/browse/JDK-8283349) > > Testing > - Local: Test passed > - `AddNodeChangeListener.java`: Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies SKIPPED on `2024-05-02` > - Automated jtreg test: jtreg_jdk_tier1 > - `java/util/prefs/AddNodeChangeListener.java`: SKIPPED[Filter: Keywords - Not matching the given keyword expression: `(((!headful)&(!printer)&(!intermittent))) & !manual & !ignore`] GitHub ? - [0 msec] This pull request has now been integrated. Changeset: 4c81a1ca Author: Amos Shi URL: https://git.openjdk.org/jdk11u-dev/commit/4c81a1ca3856b76cd851cd236844765db468144c Stats: 70 lines in 1 file changed: 30 ins; 17 del; 23 mod 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar Backport-of: 656cba7af376d6460202591230ac95d2366de9f3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2695 From ashi at openjdk.org Wed May 8 06:03:04 2024 From: ashi at openjdk.org (Amos Shi) Date: Wed, 8 May 2024 06:03:04 GMT Subject: [jdk11u-dev] Integrated: 8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows In-Reply-To: References: Message-ID: <2HYbQltu5GvhlUhF2M3jRzuePq4nRARwDfGfFXyH4HI=.086dbae2-af31-4304-b33d-31e08d894722@github.com> On Fri, 26 Apr 2024 21:36:32 GMT, Amos Shi wrote: > Backport of [JDK-8253980](https://bugs.openjdk.org/browse/JDK-8253980) > - This PR contains two commits > - Commit 1: is a de facto clean back port of original commit > - `bug7158712.java` is a **clean** `git apply` > - `ProblemList.txt` is a manual change based on original commit, can be `considered as clean` > - Commit 2 > - A line `popup.show()` has been added to avoid the test case failure with message: > - **IllegalComponentStateException: component must be showing on the screen to determine its location** > > Testing > - Local: Test passed > - `bug7158712.java`: Test results: passed: 1 > - Pipeline: All checks have passed > - Testing Machine: SAP nightlies `SKIPPED` on `2024-04-28` > - Automated jtreg test: jtreg_jdk_tier4 > - `javax/swing/plaf/synth/7158712/bug7158712.java`: `SKIPPED` [Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub ? - [0 msec] This pull request has now been integrated. Changeset: 6b225d5a Author: Amos Shi URL: https://git.openjdk.org/jdk11u-dev/commit/6b225d5a632496431550ebd31379660384fc2eaf Stats: 15 lines in 2 files changed: 8 ins; 1 del; 6 mod 8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows Reviewed-by: mbaesken Backport-of: bdd5782a67ac4b72a7dab5ea6eee3b38a864ffbf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2688 From ashi at openjdk.org Wed May 8 06:04:59 2024 From: ashi at openjdk.org (Amos Shi) Date: Wed, 8 May 2024 06:04:59 GMT Subject: [jdk11u-dev] Integrated: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout In-Reply-To: References: Message-ID: On Tue, 30 Apr 2024 21:44:04 GMT, Amos Shi wrote: > Backport of [JDK-8269258](https://bugs.openjdk.org/browse/JDK-8269258), a pre-required dependency to [JDK-8327989](https://bugs.openjdk.org/browse/JDK-8327989) > - This PR contains 3 commits > - Commit 1 - is the `git apply` from the original commit > - Commit 2 - is the manual merge based on the `.rej` files. This commit can be `considered as clean` > - `ManyRequests.java.rej` > - `ManyRequestsLegacy.java.rej` > - Commit 3 - converts the `record` type to `class` > - Record type was added in `Java 14` via `JEP 359` > > Contents > - `ManyRequests.java.rej` content > > @@ -54,13 +55,18 @@ > import java.net.http.HttpClient.Builder; > import java.net.http.HttpRequest; > import java.net.http.HttpRequest.BodyPublishers; > +import java.net.http.HttpResponse; > import java.net.http.HttpResponse.BodyHandlers; > import java.time.Duration; > import java.util.Arrays; > import java.util.Formatter; > import java.util.HashMap; > import java.util.LinkedList; > +import java.util.Map; > import java.util.Random; > +import java.util.concurrent.CompletionException; > +import java.util.concurrent.CompletionStage; > +import java.util.concurrent.ConcurrentHashMap; > import java.util.concurrent.ExecutorService; > import java.util.concurrent.Executors; > import java.util.concurrent.ThreadFactory; > @@ -100,14 +116,14 @@ > } > > //static final int REQUESTS = 1000; > - static final int REQUESTS = 20; > + static final int REQUESTS = MAX_COUNT; > static final boolean INSERT_DELAY = Boolean.getBoolean("test.insertDelay"); > static final int CHUNK_SIZE = Math.max(0, > Integer.parseInt(System.getProperty("test.chunkSize", "0"))); > static final boolean XFIXED = Boolean.getBoolean("test.XFixed"); > > static class TestEchoHandler extends EchoHandler { > - final Random rand = jdk.test.lib.RandomFactory.getRandom(); > + final Random rand = RANDOM; > @Override > public void handle(HttpExchange e) throws IOException { > System.out.println("Server: received " + e.getRequestURI()); > > - `ManyRequestsLegacy.java.rej` content > > @@ -73,12 +80,20 @@ > import java.util.Random; > import java.util.logging.Logger; > import java.util.logging.Level; > + > +import jdk.test.lib.Platform; > +import jdk.test.lib.RandomFactory; > import jdk.test.lib.net.SimpleSSLContext; > import static java.net.Proxy.NO_PROXY; > > public class ManyRequestsLegacy { > > - volatile static int counter = 0; > + static final int MAX_COUNT = 20; > + static final int MAX_LIMIT = 40; > + static final AtomicInteger COUNT = ... This pull request has now been integrated. Changeset: 665e1cd4 Author: Amos Shi URL: https://git.openjdk.org/jdk11u-dev/commit/665e1cd4f976abf89a32c12a96642cbab2c5d157 Stats: 319 lines in 3 files changed: 203 ins; 36 del; 80 mod 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout Reviewed-by: rrich Backport-of: 37921e30803449c06b4d542fdfeed9928cce8a7d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2696 From mbaesken at openjdk.org Wed May 8 07:32:59 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 8 May 2024 07:32:59 GMT Subject: [jdk11u-dev] RFR: 8331790: [11u] Remove problemlist entries after backport of JDK-8228649 In-Reply-To: References: Message-ID: On Tue, 7 May 2024 10:46:00 GMT, Christoph Langer wrote: > [JDK-8228649](https://bugs.openjdk.org/browse/JDK-8228649) had already been backported to 11.0.5. [JDK-8211767](https://bugs.openjdk.org/browse/JDK-8211767) was marked as duplicate of the former but in the hotspot problemlist we still find exclusions referring to it. So it seems we can drop them. seems to be okay; but I still see 8211767 in the ProblemList of 17u-dev too so I wonder if it is still relevant there ? ------------- Marked as reviewed by mbaesken (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2701#pullrequestreview-2044852060 From clanger at openjdk.org Wed May 8 08:05:58 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 8 May 2024 08:05:58 GMT Subject: [jdk11u-dev] RFR: 8331790: [11u] Remove problemlist entries after backport of JDK-8228649 In-Reply-To: References: Message-ID: On Wed, 8 May 2024 07:30:18 GMT, Matthias Baesken wrote: > seems to be okay; but I still see 8211767 in the ProblemList of 17u-dev too so I wonder if it is still relevant there ? Good observation. I've addressed this here: https://github.com/openjdk/jdk17u-dev/pull/2451 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2701#issuecomment-2099987119 From clanger at openjdk.org Wed May 8 08:08:22 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 8 May 2024 08:08:22 GMT Subject: [jdk17u-dev] RFR: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list Message-ID: Hi all, This pull request contains a backport of [012dafee](https://github.com/openjdk/jdk21u-dev/commit/012dafee5bc035a2eb27ac5efab9658ade92bf90) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. It did not apply since in jdk17u-dev the test was problemlisted with another bugid. Thanks! ------------- Commit messages: - Backport 012dafee5bc035a2eb27ac5efab9658ade92bf90 Changes: https://git.openjdk.org/jdk17u-dev/pull/2451/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2451&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297082 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2451.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2451/head:pull/2451 PR: https://git.openjdk.org/jdk17u-dev/pull/2451 From mbaesken at openjdk.org Wed May 8 08:08:22 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 8 May 2024 08:08:22 GMT Subject: [jdk17u-dev] RFR: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list In-Reply-To: References: Message-ID: On Wed, 8 May 2024 08:01:22 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [012dafee](https://github.com/openjdk/jdk21u-dev/commit/012dafee5bc035a2eb27ac5efab9658ade92bf90) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > It did not apply since in jdk17u-dev the test was problemlisted with another bugid. > > Thanks! Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2451#pullrequestreview-2044945484 From goetz at openjdk.org Wed May 8 08:42:23 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 8 May 2024 08:42:23 GMT Subject: [jdk17u-dev] RFR: 8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed Message-ID: I omit the test from this change. The test heavily depends on features only available in 21. I tried to get it working in 20 because that has virtual threads, but there are more things missing. ------------- Commit messages: - Backport b6ecca126846f9c53d554ff061cfe9b7b20a4d12 Changes: https://git.openjdk.org/jdk17u-dev/pull/2445/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2445&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280113 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2445.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2445/head:pull/2445 PR: https://git.openjdk.org/jdk17u-dev/pull/2445 From mbaesken at openjdk.org Wed May 8 08:42:23 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 8 May 2024 08:42:23 GMT Subject: [jdk17u-dev] RFR: 8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed In-Reply-To: References: Message-ID: On Fri, 3 May 2024 14:49:06 GMT, Goetz Lindenmaier wrote: > I omit the test from this change. > The test heavily depends on features only available in 21. > I tried to get it working in 20 because that has virtual threads, > but there are more things missing. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2445#pullrequestreview-2040191597 From duke at openjdk.org Wed May 8 11:10:18 2024 From: duke at openjdk.org (Alexandru C. Moraru) Date: Wed, 8 May 2024 11:10:18 GMT Subject: [jdk17u-dev] RFR: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests Message-ID: Clean backport to improve tests performance. ------------- Commit messages: - Backport 4421951d8f1c6fb16255851a803252fe96a453e5 Changes: https://git.openjdk.org/jdk17u-dev/pull/2452/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2452&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316142 Stats: 828 lines in 36 files changed: 0 ins; 828 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2452.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2452/head:pull/2452 PR: https://git.openjdk.org/jdk17u-dev/pull/2452 From goetz at openjdk.org Wed May 8 11:56:02 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 8 May 2024 11:56:02 GMT Subject: [jdk21u-dev] RFR: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test In-Reply-To: <6v18T3HimaJWMmqKlHbFjU0O_VEhzXsUUKfMfRKYhcs=.10add37d-acad-42ef-a5fb-f0484ceab54e@github.com> References: <6v18T3HimaJWMmqKlHbFjU0O_VEhzXsUUKfMfRKYhcs=.10add37d-acad-42ef-a5fb-f0484ceab54e@github.com> Message-ID: On Tue, 7 May 2024 10:09:57 GMT, Aleksey Shipilev wrote: > Clean backport, follow up for recent [JDK-8310913](https://bugs.openjdk.org/browse/JDK-8310913) integration. Nothing AFAICS is using the affected method except the test itself. > > Additional testing: > - [x] New regression test fails without the fix, passes with it Please have a look at 22.... ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/557#issuecomment-2100407225 From shade at openjdk.org Wed May 8 12:02:07 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 8 May 2024 12:02:07 GMT Subject: [jdk21u-dev] RFR: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test In-Reply-To: References: <6v18T3HimaJWMmqKlHbFjU0O_VEhzXsUUKfMfRKYhcs=.10add37d-acad-42ef-a5fb-f0484ceab54e@github.com> Message-ID: <03qLZuVBPotEjSvfhdaWa9uJT4c-YZ4tJGLTrrGnNro=.1cfc9c00-a82e-4148-95d8-a5e6de3ca039@github.com> On Wed, 8 May 2024 11:53:41 GMT, Goetz Lindenmaier wrote: > Please have a look at 22.... Right. I missed that the original [JDK-8310913](https://bugs.openjdk.org/browse/JDK-8310913) is in 22. Here: https://github.com/openjdk/jdk22u/pull/189 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/557#issuecomment-2100416044 From shade at openjdk.org Wed May 8 12:04:06 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 8 May 2024 12:04:06 GMT Subject: [jdk22u] RFR: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test Message-ID: Clean backport to fix a corner case. ------------- Commit messages: - Backport a7461de231da20ed78a7c6ad8275f1bafbfa556c Changes: https://git.openjdk.org/jdk22u/pull/189/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=189&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325255 Stats: 33 lines in 3 files changed: 32 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/189.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/189/head:pull/189 PR: https://git.openjdk.org/jdk22u/pull/189 From amitkumar at openjdk.org Wed May 8 12:11:53 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Wed, 8 May 2024 12:11:53 GMT Subject: [jdk17u-dev] RFR: 8298413: [s390] CPUInfoTest fails due to uppercase feature string In-Reply-To: References: Message-ID: <5f913N06yDdCBjHrq3DUgjxllpHAi1nTYZsEIySY1i0=.747e0f7e-55bd-4b95-88a0-9a2aface7bf7@github.com> On Tue, 7 May 2024 04:35:29 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [9dad874f](https://github.com/openjdk/jdk/commit/9dad874ff9f03f5891aa8b37e7826a67c851f06d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 7 Feb 2023 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! Thanks Lutz for review. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2449#issuecomment-2100432615 From amitkumar at openjdk.org Wed May 8 12:41:59 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Wed, 8 May 2024 12:41:59 GMT Subject: [jdk17u-dev] Integrated: 8298413: [s390] CPUInfoTest fails due to uppercase feature string In-Reply-To: References: Message-ID: On Tue, 7 May 2024 04:35:29 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [9dad874f](https://github.com/openjdk/jdk/commit/9dad874ff9f03f5891aa8b37e7826a67c851f06d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 7 Feb 2023 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! This pull request has now been integrated. Changeset: e9748977 Author: Amit Kumar Committer: Lutz Schmidt URL: https://git.openjdk.org/jdk17u-dev/commit/e97489774f0b893ed173be05e5d848ee2af76775 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod 8298413: [s390] CPUInfoTest fails due to uppercase feature string Reviewed-by: lucy Backport-of: 9dad874ff9f03f5891aa8b37e7826a67c851f06d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2449 From duke at openjdk.org Wed May 8 13:05:07 2024 From: duke at openjdk.org (Alexandru C. Moraru) Date: Wed, 8 May 2024 13:05:07 GMT Subject: [jdk11u-dev] RFR: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests Message-ID: Clean backport to improve tests performance. ------------- Commit messages: - Backport 4421951d8f1c6fb16255851a803252fe96a453e5 Changes: https://git.openjdk.org/jdk11u-dev/pull/2703/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2703&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316142 Stats: 828 lines in 36 files changed: 0 ins; 828 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2703.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2703/head:pull/2703 PR: https://git.openjdk.org/jdk11u-dev/pull/2703 From vlivanov at openjdk.org Wed May 8 13:48:57 2024 From: vlivanov at openjdk.org (Vladimir Ivanov) Date: Wed, 8 May 2024 13:48:57 GMT Subject: [jdk22u] RFR: 8322726: C2: Unloaded signature class kills argument value In-Reply-To: <7Mcb5LYSw_pxRnt_PCkP8-CeSx8AlKzQt4zNyzRY6H0=.db0cc31f-e452-468a-9e12-ae87c121ef4c@github.com> References: <7Mcb5LYSw_pxRnt_PCkP8-CeSx8AlKzQt4zNyzRY6H0=.db0cc31f-e452-468a-9e12-ae87c121ef4c@github.com> Message-ID: <-l3_nv-kLr2YZ24mnajZVtDEYUrXJmEJKMFgZNQEq1w=.e19b8324-5fd0-4c9c-9178-002e930c7dae@github.com> On Tue, 7 May 2024 10:24:03 GMT, Fairoz Matte wrote: > 8322726: C2: Unloaded signature class kills argument value > Reviewed-by: kvn, dlong, thartmann Marked as reviewed by vlivanov (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk22u/pull/187#pullrequestreview-2045716100 From mdoerr at openjdk.org Wed May 8 13:57:59 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 8 May 2024 13:57:59 GMT Subject: [jdk17u-dev] Integrated: 8272315: Improve assert_different_registers In-Reply-To: References: Message-ID: On Mon, 6 May 2024 21:02:04 GMT, Martin Doerr wrote: > Clean backport of [JDK-8272315](https://bugs.openjdk.org/browse/JDK-8272315). It's only an enhancement, but it is required for other changes. E.g. the "Represent Registers as values" changes which were done for GCC 11 support like [JDK-8297445](https://bugs.openjdk.org/browse/JDK-8297445) don't build without it: `no known conversion for argument 1 from 'Register' to 'AbstractRegister' {aka 'AbstractRegisterImpl*'}` This pull request has now been integrated. Changeset: 5a3c6686 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/5a3c668646c363f2a2028e4aede63eef524ad5fd Stats: 257 lines in 1 file changed: 0 ins; 246 del; 11 mod 8272315: Improve assert_different_registers Backport-of: 93cab7d07d56fef6973ce8ac2e8232e8f3b185dd ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2448 From stuefe at openjdk.org Wed May 8 15:18:00 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 8 May 2024 15:18:00 GMT Subject: [jdk22u] RFR: 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095 Message-ID: Trivial, but somewhat urgent fix to a jdk-22-only problem brought by an unclean backport of https://bugs.openjdk.org/browse/JDK-8325095. ------------- Commit messages: - start Changes: https://git.openjdk.org/jdk22u/pull/190/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=190&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331894 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/190.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/190/head:pull/190 PR: https://git.openjdk.org/jdk22u/pull/190 From duke at openjdk.org Wed May 8 16:07:05 2024 From: duke at openjdk.org (Chad Rakoczy) Date: Wed, 8 May 2024 16:07:05 GMT Subject: [jdk22u] Integrated: 8325621: Improve jspawnhelper version checks In-Reply-To: References: Message-ID: On Thu, 2 May 2024 19:14:54 GMT, Chad Rakoczy wrote: > Backport of [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621) > > Clean backport to update jspawnhelper to check that JDK version and jspawnhelper version are the same. Updates test to include check for version. GHA tests pass including the updated test. Risk is low: touches the production code paths but only passes an additional argument to jspawnhelper This pull request has now been integrated. Changeset: 7b1ae122 Author: Chad Rakoczy Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/7b1ae122cd0a784b9f844b96512ab805b9d30f6f Stats: 59 lines in 5 files changed: 47 ins; 4 del; 8 mod 8325621: Improve jspawnhelper version checks Backport-of: a232e8fb4e6e9e2e9a5285bf01c93b8d1d995f04 ------------- PR: https://git.openjdk.org/jdk22u/pull/181 From stuefe at openjdk.org Wed May 8 16:08:53 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 8 May 2024 16:08:53 GMT Subject: [jdk22u] RFR: 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095 In-Reply-To: References: Message-ID: On Wed, 8 May 2024 14:21:21 GMT, Thomas Stuefe wrote: > Trivial, but somewhat urgent fix to a jdk-22-only problem brought by an unclean backport of https://bugs.openjdk.org/browse/JDK-8325095. @shipilev maybe? ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/190#issuecomment-2100918630 From kvn at openjdk.org Wed May 8 16:15:51 2024 From: kvn at openjdk.org (Vladimir Kozlov) Date: Wed, 8 May 2024 16:15:51 GMT Subject: [jdk22u] RFR: 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095 In-Reply-To: References: Message-ID: On Wed, 8 May 2024 14:21:21 GMT, Thomas Stuefe wrote: > Trivial, but somewhat urgent fix to a jdk-22-only problem brought by an unclean backport of https://bugs.openjdk.org/browse/JDK-8325095. Looks good. Yes, it is strange that this change was not included. I see that JDK 17u backport has the same issue. ------------- Marked as reviewed by kvn (Reviewer). PR Review: https://git.openjdk.org/jdk22u/pull/190#pullrequestreview-2046097730 From stuefe at openjdk.org Wed May 8 16:24:56 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 8 May 2024 16:24:56 GMT Subject: [jdk22u] RFR: 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095 In-Reply-To: References: Message-ID: On Wed, 8 May 2024 16:13:40 GMT, Vladimir Kozlov wrote: >> Trivial, but somewhat urgent fix to a jdk-22-only problem brought by an unclean backport of https://bugs.openjdk.org/browse/JDK-8325095. > > Looks good. > > Yes, it is strange that this change was not included. Thank you, @vnkozlov. I'll wait till the GHAs are thru, then push. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/190#issuecomment-2100944440 From kvn at openjdk.org Wed May 8 16:24:57 2024 From: kvn at openjdk.org (Vladimir Kozlov) Date: Wed, 8 May 2024 16:24:57 GMT Subject: [jdk22u] RFR: 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095 In-Reply-To: References: Message-ID: On Wed, 8 May 2024 14:21:21 GMT, Thomas Stuefe wrote: > Trivial, but somewhat urgent fix to a jdk-22-only problem brought by an unclean backport of https://bugs.openjdk.org/browse/JDK-8325095. This code was added by [JDK-8317683](https://bugs.openjdk.org/browse/JDK-8317683) in JDK 22. So only this JDK is affected. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/190#issuecomment-2100946711 From jlu at openjdk.org Wed May 8 17:21:07 2024 From: jlu at openjdk.org (Justin Lu) Date: Wed, 8 May 2024 17:21:07 GMT Subject: [jdk17u-ri] Integrated: 8285497: Add system property for Java SE specification maintenance version In-Reply-To: References: Message-ID: On Thu, 18 Apr 2024 15:44:10 GMT, Justin Lu wrote: > Please review this PR which is a backport of adding the "java.specification.maintenance.version" system property. > The property is initialized with a value of 1, which corresponds with the Java SE 17 Maintenance Release 1. > > Note that the only change in this backport is the uncommenting of the system property in `VersionProps.java.template`. And as such, the copyright year is updated to 2024, not the original backport year. > > For reference, the approved CSR: https://bugs.openjdk.org/browse/JDK-8330418 This pull request has now been integrated. Changeset: c2c9e7fb Author: Justin Lu URL: https://git.openjdk.org/jdk17u-ri/commit/c2c9e7fb8c857e40bc43b4053c2633825d4fb68e Stats: 22 lines in 4 files changed: 19 ins; 0 del; 3 mod 8285497: Add system property for Java SE specification maintenance version Reviewed-by: lancea, iris, prr, andrew Backport-of: 59ef76a365eafe40d8d68b4d5e028f0e731abd01 ------------- PR: https://git.openjdk.org/jdk17u-ri/pull/2 From duke at openjdk.org Wed May 8 17:23:16 2024 From: duke at openjdk.org (Elif Aslan) Date: Wed, 8 May 2024 17:23:16 GMT Subject: [jdk17u-dev] RFR: 8325567: jspawnhelper without args fails with segfault [v2] In-Reply-To: References: Message-ID: > Clean backport.Testing is in progress Elif Aslan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8325567 - Backport 262747094670b00ac63463a059074afa9b81d8a4 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2339/files - new: https://git.openjdk.org/jdk17u-dev/pull/2339/files/8a953b7e..3e34b357 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2339&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2339&range=00-01 Stats: 29481 lines in 872 files changed: 11985 ins; 15276 del; 2220 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2339.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2339/head:pull/2339 PR: https://git.openjdk.org/jdk17u-dev/pull/2339 From azvegint at openjdk.org Wed May 8 17:30:09 2024 From: azvegint at openjdk.org (Alexander Zvegintsev) Date: Wed, 8 May 2024 17:30:09 GMT Subject: [jdk17u-ri] Integrated: 8307779: Relax the java.awt.Robot specification In-Reply-To: <_ZbmuFbvQb_QOkRzcbYHpNr1ad6akSb0zayzoIRnpJo=.94981b42-b4b2-4e4b-90f5-c76ea55ea035@github.com> References: <_ZbmuFbvQb_QOkRzcbYHpNr1ad6akSb0zayzoIRnpJo=.94981b42-b4b2-4e4b-90f5-c76ea55ea035@github.com> Message-ID: On Thu, 18 Apr 2024 21:13:04 GMT, Alexander Zvegintsev wrote: > Please review the doc only backport PR of https://github.com/openjdk/jdk/pull/13809. > > It is clean backport of original commit + build failure fix. > > CSR: [JDK-8330603](https://bugs.openjdk.org/browse/JDK-8330603) This pull request has now been integrated. Changeset: fadce2ff Author: Alexander Zvegintsev URL: https://git.openjdk.org/jdk17u-ri/commit/fadce2ff8a1613dba0df01777a1c8b82202a46a9 Stats: 80 lines in 1 file changed: 72 ins; 1 del; 7 mod 8307779: Relax the java.awt.Robot specification Reviewed-by: prr, iris, andrew Backport-of: 21aa057fafd88f4dd677bbf7c99a7eabb6b18409 ------------- PR: https://git.openjdk.org/jdk17u-ri/pull/3 From azvegint at openjdk.org Wed May 8 17:32:02 2024 From: azvegint at openjdk.org (Alexander Zvegintsev) Date: Wed, 8 May 2024 17:32:02 GMT Subject: [jdk11u-ri] Integrated: 8307779: Relax the java.awt.Robot specification In-Reply-To: References: Message-ID: On Wed, 24 Apr 2024 18:10:47 GMT, Alexander Zvegintsev wrote: > Please review the doc only backport PR of https://github.com/openjdk/jdk/pull/13809. > > It is backport of the original commit + build failure fix. > > CSR: [JDK-8331036](https://bugs.openjdk.org/browse/JDK-8331036) This pull request has now been integrated. Changeset: 42eb6847 Author: Alexander Zvegintsev URL: https://git.openjdk.org/jdk11u-ri/commit/42eb684707287a41a9922519de6b08aff1d83eae Stats: 81 lines in 1 file changed: 73 ins; 1 del; 7 mod 8307779: Relax the java.awt.Robot specification Reviewed-by: prr, iris, andrew Backport-of: 21aa057fafd88f4dd677bbf7c99a7eabb6b18409 ------------- PR: https://git.openjdk.org/jdk11u-ri/pull/10 From jlu at openjdk.org Wed May 8 17:33:09 2024 From: jlu at openjdk.org (Justin Lu) Date: Wed, 8 May 2024 17:33:09 GMT Subject: [jdk11u-ri] Integrated: 8330416: Update system property for Java SE specification maintenance version In-Reply-To: References: Message-ID: On Thu, 18 Apr 2024 15:44:11 GMT, Justin Lu wrote: > Please review this PR which updates the "java.specification.maintenance.version" system property value from 2 to 3. This corresponds with the Java SE 11 Maintenance Release 3. This pull request has now been integrated. Changeset: 22fe35f2 Author: Justin Lu Committer: Alexander Zvegintsev URL: https://git.openjdk.org/jdk11u-ri/commit/22fe35f286c71e01945cacc95ef090cadf1c3d99 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8330416: Update system property for Java SE specification maintenance version Reviewed-by: lancea, sgehwolf, iris, prr, andrew ------------- PR: https://git.openjdk.org/jdk11u-ri/pull/9 From duke at openjdk.org Wed May 8 21:03:55 2024 From: duke at openjdk.org (Elif Aslan) Date: Wed, 8 May 2024 21:03:55 GMT Subject: [jdk17u-dev] RFR: 8325567: jspawnhelper without args fails with segfault [v2] In-Reply-To: References: Message-ID: <9lIZkrvfJYJtYytmOBvqO6bbKjwDJkcoAawc3a_XR-Y=.3a7aeefb-6132-4619-b5fa-6abd7cae0914@github.com> On Wed, 8 May 2024 17:23:16 GMT, Elif Aslan wrote: >> Clean backport.Testing is in progress > > Elif Aslan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8325567 > - Backport 262747094670b00ac63463a059074afa9b81d8a4 The test does not work reliably, because JDK-8233725 bugfix is missing. I'll look into backporting that one first. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2339#issuecomment-2101455528 From duke at openjdk.org Wed May 8 23:55:56 2024 From: duke at openjdk.org (duke) Date: Wed, 8 May 2024 23:55:56 GMT Subject: [jdk22u] Withdrawn: 8327210: AIX: Delete obsolete parameter Use64KPagesThreshold In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 13:37:04 GMT, Joachim Kern wrote: > As the configuration parameter Use64KPagesThreshold on AIX is not needed anymore, we remove it from the code. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk22u/pull/100 From duke at openjdk.org Wed May 8 23:56:56 2024 From: duke at openjdk.org (duke) Date: Wed, 8 May 2024 23:56:56 GMT Subject: [jdk22u] Withdrawn: 8326112: Javadoc snippet for Linker.Option.captureCallState is wrong In-Reply-To: <8X7G6tFa3GSQ4pox_m0EtvzMrPqZEHdSVnf-s2utEf4=.cf071477-505f-4572-ba66-2cb270c9529e@github.com> References: <8X7G6tFa3GSQ4pox_m0EtvzMrPqZEHdSVnf-s2utEf4=.cf071477-505f-4572-ba66-2cb270c9529e@github.com> Message-ID: On Mon, 19 Feb 2024 15:02:20 GMT, Per Minborg wrote: > Hi all, > > This pull request contains a backport of commit [82609b1e](https://github.com/openjdk/jdk/commit/82609b1ebceb658c612c7ed58959cb159a77d4df) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Per Minborg on 19 Feb 2024 and was reviewed by Jorn Vernee. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk22u/pull/59 From duke at openjdk.org Wed May 8 23:56:57 2024 From: duke at openjdk.org (duke) Date: Wed, 8 May 2024 23:56:57 GMT Subject: [jdk22u] Withdrawn: 8322040: Missing array bounds check in ClassReader.parameter In-Reply-To: References: Message-ID: <2sGwm35UOUXYYTNXf1u2E9D6mfKJohAUrlOOsvm53QA=.b55e9fe4-22d0-4aa9-823a-17e53c66a1a8@github.com> On Tue, 19 Dec 2023 16:47:29 GMT, Liam Miller-Cushon wrote: > Hi, > > This is a backport of [JDK-8322040: Missing array bounds check in ClassReader.parameter](https://bugs.openjdk.org/browse/JDK-8322040). > > The fix applied cleanly. The test required updating due to changes in the Class-File API. The modified test fails without the patch, and passes with it. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk22u/pull/4 From duke at openjdk.org Thu May 9 00:23:58 2024 From: duke at openjdk.org (duke) Date: Thu, 9 May 2024 00:23:58 GMT Subject: [jdk17u-dev] Withdrawn: 8324123: aarch64: fix prfm literal encoding in assembler In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 07:55:03 GMT, Liang Mao wrote: > Unclean backport of fixing aarch64 PRFM (literal) encoding. > > Additional testing: > - [x] Linux aarch64 server fastdebug, tier1 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2256 From duke at openjdk.org Thu May 9 00:24:58 2024 From: duke at openjdk.org (duke) Date: Thu, 9 May 2024 00:24:58 GMT Subject: [jdk17u-dev] Withdrawn: 8326487: ZipFileSystem.getPath("").getFileName() returns null instead of an empty string In-Reply-To: References: Message-ID: On Tue, 27 Feb 2024 08:51:09 GMT, xiaotaonan wrote: > In the scenario of using ZipFileSystem, when getPath("").getFileName() returns null, change getPath("").getNameCount() to 0. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2242 From duke at openjdk.org Thu May 9 00:26:58 2024 From: duke at openjdk.org (duke) Date: Thu, 9 May 2024 00:26:58 GMT Subject: [jdk17u-dev] Withdrawn: 8318696: Do not use LFS64 symbols on Linux In-Reply-To: References: Message-ID: On Wed, 24 Jan 2024 14:04:27 GMT, Matthias Baesken wrote: > Backport 8318696 from jdk21u-dev This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2173 From duke at openjdk.org Thu May 9 00:28:05 2024 From: duke at openjdk.org (duke) Date: Thu, 9 May 2024 00:28:05 GMT Subject: [jdk17u-dev] Withdrawn: 8286447: [Linux] AWT should start in Headless mode if headful AWT library not installed In-Reply-To: <-9qNHiwn7V3nTaQOijDyyl6q7U1T6JUMJl7fYe0zb2c=.eef4a1e4-2397-40b2-96cf-a80467fbe5dc@github.com> References: <-9qNHiwn7V3nTaQOijDyyl6q7U1T6JUMJl7fYe0zb2c=.eef4a1e4-2397-40b2-96cf-a80467fbe5dc@github.com> Message-ID: On Mon, 22 Jan 2024 07:54:31 GMT, Ludovic Henry wrote: > Backport applied cleanly. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2150 From duke at openjdk.org Thu May 9 00:28:03 2024 From: duke at openjdk.org (duke) Date: Thu, 9 May 2024 00:28:03 GMT Subject: [jdk17u-dev] Withdrawn: 8324234: Use reserved IP for java.net testing In-Reply-To: References: Message-ID: On Mon, 22 Jan 2024 07:46:34 GMT, Ludovic Henry wrote: > Some tests like test/jdk/java/net/Socket/B8312065.java use specific IPs (like 192.168.255.255) taking the assumption that the address is not going to be assigned. This doesn't always hold true, as 192.168.255.255 for example is a valid address. > > [RFC 5737](https://www.rfc-editor.org/rfc/rfc5737) defines specific ranges of IP addresses that may are reserved for these exact purpose and that will never be assigned. Let's make sure to use an IP in this range, like 192.0.2.1 for example. > > The specific test test/jdk/java/net/Socket/B8312065.java was introduced with https://git.openjdk.org/jdk17u-dev/pull/1639. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2149 From duke at openjdk.org Thu May 9 00:28:58 2024 From: duke at openjdk.org (duke) Date: Thu, 9 May 2024 00:28:58 GMT Subject: [jdk17u-dev] Withdrawn: 8318474: Fix memory reporter for thread_count In-Reply-To: References: Message-ID: <1uvYwnKIMa3DJRpztDryetrTvDk5VMiQRYiIUQFtFrk=.ee343f55-4e91-429c-b89a-c5b63f680808@github.com> On Wed, 27 Dec 2023 07:34:48 GMT, Evgeny Ignatenko wrote: > 8318474: Fix memory reporter for thread_count This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2085 From duke at openjdk.org Thu May 9 00:29:58 2024 From: duke at openjdk.org (duke) Date: Thu, 9 May 2024 00:29:58 GMT Subject: [jdk17u-dev] Withdrawn: 8315362: NMT: summary diff reports threads count incorrectly In-Reply-To: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> References: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> Message-ID: <7zRd6cHBoBdGEDRRWdDmzPBaL5BmpbWy3CeIK_bY1ak=.dbb4e4b2-7b76-461d-a860-ed4192b40e9b@github.com> On Wed, 27 Dec 2023 07:31:16 GMT, Evgeny Ignatenko wrote: > 8315362: NMT: summary diff reports threads count incorrectly This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2084 From duke at openjdk.org Thu May 9 00:30:54 2024 From: duke at openjdk.org (duke) Date: Thu, 9 May 2024 00:30:54 GMT Subject: [jdk17u-dev] Withdrawn: 8318078: ADLC: pass ASSERT and PRODUCT flags In-Reply-To: <8QTmSBUL7yHgxLt0S5A3ZWUcz28z5ET2VbAVyJxyRBQ=.91929890-0d30-4c35-b3b2-59b7bd0d74ea@github.com> References: <8QTmSBUL7yHgxLt0S5A3ZWUcz28z5ET2VbAVyJxyRBQ=.91929890-0d30-4c35-b3b2-59b7bd0d74ea@github.com> Message-ID: On Mon, 11 Dec 2023 14:17:16 GMT, Aleksey Shipilev wrote: > Clean backport to make sure the asserts work in `.ad` files. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `hotspot:tier1` > - [ ] linux-aarch64-server-fastdebug, `tier1` > - [ ] linux-x86_64-server-fastdebug, `tier1` This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2034 From mdoerr at openjdk.org Thu May 9 00:45:18 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 9 May 2024 00:45:18 GMT Subject: [jdk17u-dev] RFR: 8297445: PPC64: Represent Registers as values Message-ID: Backport of [JDK-8297445](https://bugs.openjdk.org/browse/JDK-8297445). Fixes GCC11 build warnings ([JDK-8297426](https://bugs.openjdk.org/browse/JDK-8297426)). ------------- Commit messages: - Remove obsolete stuff. - 8297445: PPC64: Represent Registers as values Changes: https://git.openjdk.org/jdk17u-dev/pull/2454/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2454&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297445 Stats: 861 lines in 15 files changed: 163 ins; 466 del; 232 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2454.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2454/head:pull/2454 PR: https://git.openjdk.org/jdk17u-dev/pull/2454 From syan at openjdk.org Thu May 9 02:11:58 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 9 May 2024 02:11:58 GMT Subject: [jdk21u-dev] RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" In-Reply-To: References: Message-ID: On Thu, 28 Mar 2024 02:45:17 GMT, SendaoYan wrote: > Hi, > > Clean backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). Only change the testcase, the change has been verified, the risk is low. > > ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/a971b851-bc31-407a-b66e-0d8189deee9f) > > Thanks, > -sendao Hi, ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/419#issuecomment-2101801616 From syan at openjdk.org Thu May 9 02:12:03 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 9 May 2024 02:12:03 GMT Subject: [jdk11u-dev] RFR: 8328825: Google CAInterop test failures In-Reply-To: References: Message-ID: On Tue, 26 Mar 2024 01:21:50 GMT, SendaoYan wrote: > Hi, > > Clean backport to fix some of the current failures in CAInterop test. > > Additional testing: > > - [x] Affected subtests are now passing > > ![image](https://github.com/openjdk/jdk11u-dev/assets/24123821/f08fa697-41f6-4365-b0f5-64d8df5f114f) > > Thanks, > -sendao Hi, ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2624#issuecomment-2101801306 From stuefe at openjdk.org Thu May 9 05:03:52 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 9 May 2024 05:03:52 GMT Subject: [jdk22u] RFR: 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095 In-Reply-To: References: Message-ID: On Wed, 8 May 2024 14:21:21 GMT, Thomas Stuefe wrote: > Trivial, but somewhat urgent fix to a jdk-22-only problem brought by an unclean backport of https://bugs.openjdk.org/browse/JDK-8325095. All GHAs are green. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/190#issuecomment-2101938057 From lmao at openjdk.org Thu May 9 05:56:14 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 9 May 2024 05:56:14 GMT Subject: [jdk21u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM Message-ID: Clean backport of fixing rare long hand shake while mutator threads in heavy contention on ShenandoahLock. Additional testing: - [x] Linux aarch64 server fastdebug, hotspot/jtreg/tier1 with +UseShenandoahGC ------------- Commit messages: - Backport 492e8bf563135d27b46fde198880e62d5f1940e8 Changes: https://git.openjdk.org/jdk21u-dev/pull/560/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=560&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325587 Stats: 67 lines in 3 files changed: 48 ins; 1 del; 18 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/560.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/560/head:pull/560 PR: https://git.openjdk.org/jdk21u-dev/pull/560 From amitkumar at openjdk.org Thu May 9 06:03:57 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Thu, 9 May 2024 06:03:57 GMT Subject: [jdk17u-dev] RFR: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: <0tg0UbZwG0qhxnY6YEeiox9dxNnY7QxD3zJUkPLU33M=.f56b650e-e844-4517-b24a-3c1a7f40f178@github.com> On Sat, 4 May 2024 05:44:38 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. > > Thanks! @RealLucy due to copyright changes diff, I think, this one didn't get marked clean. Would you please review it :-) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2446#issuecomment-2101997292 From rmarchenko at openjdk.org Thu May 9 06:07:54 2024 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Thu, 9 May 2024 06:07:54 GMT Subject: [jdk17u-dev] RFR: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect In-Reply-To: References: Message-ID: On Fri, 8 Mar 2024 06:47:16 GMT, Roman Marchenko wrote: > This is a backport of JDK-8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect. > > Backporting this because this issue can be reproduced in JDK17 as well. > > The backport isn't clean: > 1. Resolved a conflict in `src/hotspot/share/prims/jvmtiEventController.cpp` with an empty line. > 2. Removed files as VThreads are not implemented in jdk17: > - `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/libVThreadTest.cpp` > - `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/VThreadTest.java` > 3. Added new test: > - `test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/Test.java` > - `test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/libextcallback.c` > - `test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/loadClass/Test2.java` > > Actually, backporting the fix only. > The new test fails without the fix, and successfully passes with the fix. Up ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2276#issuecomment-2102001807 From andrewlu at openjdk.org Thu May 9 06:49:21 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 9 May 2024 06:49:21 GMT Subject: [jdk17u-dev] RFR: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException Message-ID: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException ------------- Commit messages: - Backport 510003cfe33c34e62735c9fd49178d86b69b89ed Changes: https://git.openjdk.org/jdk17u-dev/pull/2455/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2455&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8042380 Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2455.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2455/head:pull/2455 PR: https://git.openjdk.org/jdk17u-dev/pull/2455 From andrewlu at openjdk.org Thu May 9 06:50:26 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 9 May 2024 06:50:26 GMT Subject: [jdk11u-dev] RFR: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException Message-ID: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException ------------- Commit messages: - Backport 510003cfe33c34e62735c9fd49178d86b69b89ed Changes: https://git.openjdk.org/jdk11u-dev/pull/2705/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2705&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8042380 Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2705.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2705/head:pull/2705 PR: https://git.openjdk.org/jdk11u-dev/pull/2705 From clanger at openjdk.org Thu May 9 09:40:54 2024 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 9 May 2024 09:40:54 GMT Subject: [jdk21u-dev] Integrated: 8330523: Reduce runtime and improve efficiency of KeepAliveTest In-Reply-To: References: Message-ID: On Tue, 7 May 2024 21:21:08 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8330523](https://bugs.openjdk.org/browse/JDK-8330523), commit [8eac95ec](https://github.com/openjdk/jdk22u/commit/8eac95ec3cd4b215556d788b9ade7a6e2f9deaa3) from the [openjdk/jdk22u](https://git.openjdk.org/jdk22u) repository. > > The commit being backported was authored by Christoph Langer on 7 May 2024 and had no reviewers. > > Thanks! This pull request has now been integrated. Changeset: c12dfc35 Author: Christoph Langer URL: https://git.openjdk.org/jdk21u-dev/commit/c12dfc3571235bb57b2287e06c0cebb764f47a9a Stats: 1230 lines in 1 file changed: 75 ins; 1012 del; 143 mod 8330523: Reduce runtime and improve efficiency of KeepAliveTest Backport-of: 8eac95ec3cd4b215556d788b9ade7a6e2f9deaa3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/558 From clanger at openjdk.org Thu May 9 09:41:02 2024 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 9 May 2024 09:41:02 GMT Subject: [jdk17u-dev] Integrated: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list In-Reply-To: References: Message-ID: On Wed, 8 May 2024 08:01:22 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [012dafee](https://github.com/openjdk/jdk21u-dev/commit/012dafee5bc035a2eb27ac5efab9658ade92bf90) from the [openjdk/jdk21u-dev](https://git.openjdk.org/jdk21u-dev) repository. > > It did not apply since in jdk17u-dev the test was problemlisted with another bugid. > > Thanks! This pull request has now been integrated. Changeset: e552509b Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/e552509bcbbba5562219355841cf3dedd7daaeb8 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list Reviewed-by: mbaesken Backport-of: 012dafee5bc035a2eb27ac5efab9658ade92bf90 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2451 From clanger at openjdk.org Thu May 9 09:41:01 2024 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 9 May 2024 09:41:01 GMT Subject: [jdk21u-dev] Integrated: 8330815: Use pattern matching for instanceof in KeepAliveCache In-Reply-To: <013Kb3I6xQuLZhTEQmfjxfuLXKwUzhjagAC33C7_x2s=.11ff3445-bb06-4364-8657-f4e4ced8478c@github.com> References: <013Kb3I6xQuLZhTEQmfjxfuLXKwUzhjagAC33C7_x2s=.11ff3445-bb06-4364-8657-f4e4ced8478c@github.com> Message-ID: On Tue, 7 May 2024 21:21:26 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8330815](https://bugs.openjdk.org/browse/JDK-8330815), commit [0ec3c0b1](https://github.com/openjdk/jdk22u/commit/0ec3c0b1e698f7ad39b4da2edb062721e4670f58) from the [openjdk/jdk22u](https://git.openjdk.org/jdk22u) repository. > > The commit being backported was authored by Christoph Langer on 7 May 2024 and had no reviewers. > > Thanks! This pull request has now been integrated. Changeset: ddecbe52 Author: Christoph Langer URL: https://git.openjdk.org/jdk21u-dev/commit/ddecbe52018fdb7556b04b20e8529eb430d3aa75 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8330815: Use pattern matching for instanceof in KeepAliveCache Backport-of: 0ec3c0b1e698f7ad39b4da2edb062721e4670f58 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/559 From stuefe at openjdk.org Thu May 9 10:28:53 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 9 May 2024 10:28:53 GMT Subject: [jdk21u-dev] RFR: 8320370: NMT: Change MallocMemorySnapshot to simplify code. In-Reply-To: References: Message-ID: On Mon, 6 May 2024 09:38:18 GMT, Aleksey Shipilev wrote: > Clean backport to improve NMT initialization and provide cleanliness for other backports. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `runtime/NMT` Looks fine. ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/552#pullrequestreview-2047650752 From duke at openjdk.org Thu May 9 11:44:55 2024 From: duke at openjdk.org (duke) Date: Thu, 9 May 2024 11:44:55 GMT Subject: [jdk11u-dev] Withdrawn: 8326487: ZipFileSystem.getPath("").getFileName() returns null instead of an empty string In-Reply-To: References: Message-ID: On Tue, 27 Feb 2024 08:51:02 GMT, xiaotaonan wrote: > In the scenario of using ZipFileSystem, when getPath("").getFileName() returns null, change getPath("").getNameCount() to 0. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2560 From duke at openjdk.org Thu May 9 11:46:02 2024 From: duke at openjdk.org (duke) Date: Thu, 9 May 2024 11:46:02 GMT Subject: [jdk11u-dev] Withdrawn: 8306408: Fix the format of several tables in building.md In-Reply-To: References: Message-ID: On Tue, 20 Feb 2024 15:32:47 GMT, Zdenek Zambersky wrote: > Backport fixing several tables in `doc/building.md`, so they would display correctly in GitHub. Changes to `doc/building.html` were done manually, as there are some differences to table contents. Also table in `Oracle Solaris Studio` section was fixed, which is missing in newer jdks. > > File `doc/building.html` was regenerated (pandoc used was one [created by current jdk17u devkit](https://github.com/openjdk/jdk17u-dev/blob/3285292597efd34176465df0b0394cc4a99605eb/make/devkit/createPandocBundle.sh), as this one seems to have be used previously -> no unrelated format changes). > > Interestingly update of `doc/building.html` also removed one paragraph (about C99 standard). However, it turns out, this was accidentally included in [JDK-8226910](https://bugs.openjdk.org/browse/JDK-8226910) backport to jdk11u-dev. Paragraph is from [JDK-8224087](https://bugs.openjdk.org/browse/JDK-8224087), which has not been backported to jdk11u-dev. (So paragraph should never been there in first place.) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2533 From syan at openjdk.org Thu May 9 12:52:53 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 9 May 2024 12:52:53 GMT Subject: [jdk17u-dev] RFR: 8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978 In-Reply-To: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> References: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> Message-ID: On Tue, 30 Jan 2024 16:25:52 GMT, SendaoYan wrote: > Hi, > > The testcase ReflectionCallerCacheTest.java run failed with -Xcomp, both on linux-x86_64 and linux-aarch64. > > And it run pass by jdk23 binary with the same testcase and the same jvm options(-Xcomp): > > ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/9ee1e9d2-96fc-4772-b11f-776a631515cd) > > > Before we found the root cause of this failure, should we problem list this testcase in test/jdk/ProblemList-Xcomp.txt. > > Thanks, > -sendao Hi, Problem list this fail testcase to test/jdk/ProblemList-Xcomp.txt, the risk is low. Can anyone review this PR, thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2186#issuecomment-2102600941 From duke at openjdk.org Thu May 9 16:37:06 2024 From: duke at openjdk.org (Elif Aslan) Date: Thu, 9 May 2024 16:37:06 GMT Subject: [jdk17u-dev] RFR: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time Message-ID: Clean backport to fix ProcessTools.startProcess() bug. See original PR explanation [here](https://github.com/openjdk/jdk/pull/13594) I need this backport to be merged to able to complete [this](https://github.com/openjdk/jdk17u-dev/pull/2339) backport request. Additional testing: macos-x86_64-server-release tier2 ------------- Commit messages: - Backport of 2e340e855b760e381793107f2a4d74095bd40199 Changes: https://git.openjdk.org/jdk17u-dev/pull/2456/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2456&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8233725 Stats: 211 lines in 3 files changed: 199 ins; 2 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2456.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2456/head:pull/2456 PR: https://git.openjdk.org/jdk17u-dev/pull/2456 From amitkumar at openjdk.org Thu May 9 19:16:07 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Thu, 9 May 2024 19:16:07 GMT Subject: [jdk17u-dev] RFR: 8307423: [s390x] Represent Registers as values Message-ID: Hi all, This pull request contains a backport of commit [8bbd264c](https://github.com/openjdk/jdk/commit/8bbd264c6e4b4045a218f11ae6b5b4f395bc2aa9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 8 May 2023 and was reviewed by Martin Doerr and Lutz Schmidt. Thanks! ------------- Commit messages: - removes register_definitions_s390 & updates vmStructs - Merge branch 'openjdk:master' into backport-offamitkumar-8bbd264c - extra space - update - Backport 8bbd264c6e4b4045a218f11ae6b5b4f395bc2aa9 Changes: https://git.openjdk.org/jdk17u-dev/pull/2453/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2453&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307423 Stats: 518 lines in 10 files changed: 83 ins; 261 del; 174 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2453.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2453/head:pull/2453 PR: https://git.openjdk.org/jdk17u-dev/pull/2453 From duke at openjdk.org Thu May 9 22:07:07 2024 From: duke at openjdk.org (Elif Aslan) Date: Thu, 9 May 2024 22:07:07 GMT Subject: [jdk17u-dev] RFR: 8325567: jspawnhelper without args fails with segfault [v2] In-Reply-To: References: Message-ID: On Wed, 8 May 2024 17:23:16 GMT, Elif Aslan wrote: >> Clean backport.Testing is in progress > > Elif Aslan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8325567 > - Backport 262747094670b00ac63463a059074afa9b81d8a4 Here is the backport PR: https://github.com/openjdk/jdk17u-dev/pull/2456 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2339#issuecomment-2103487088 From duke at openjdk.org Thu May 9 22:21:06 2024 From: duke at openjdk.org (Elif Aslan) Date: Thu, 9 May 2024 22:21:06 GMT Subject: [jdk17u-dev] RFR: 8273153: Consolidate file_exists into os:file_exists In-Reply-To: References: Message-ID: On Sat, 9 Mar 2024 19:51:43 GMT, Elif Aslan wrote: > Clean backport to Consolidate file_exists into os:file_exists > This backport is required to close [this](https://github.com/openjdk/jdk/commit/9732fbe428c3b6a5422cc94e7295ba5482d1a7a9) backport clean. > > Additional testing in addition to GHA tests > > jtreg/tier2 Hello @GoeLin, please see my comment above. Thank you ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2281#issuecomment-2103501777 From amitkumar at openjdk.org Fri May 10 03:39:11 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Fri, 10 May 2024 03:39:11 GMT Subject: [jdk17u-dev] RFR: 8307423: [s390x] Represent Registers as values In-Reply-To: References: Message-ID: On Wed, 8 May 2024 14:30:21 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [8bbd264c](https://github.com/openjdk/jdk/commit/8bbd264c6e4b4045a218f11ae6b5b4f395bc2aa9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 8 May 2023 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! I ran tier1 test and no new failure appeared. @RealLucy please review. Initially it was clean patch but I had to delete `register_definitions_s390.cpp` and following that a minor change in `vmStruct.cpp`. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2453#issuecomment-2103798636 From clanger at openjdk.org Fri May 10 05:32:12 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 10 May 2024 05:32:12 GMT Subject: [jdk11u-dev] Integrated: 8331790: [11u] Remove problemlist entries after backport of JDK-8228649 In-Reply-To: References: Message-ID: On Tue, 7 May 2024 10:46:00 GMT, Christoph Langer wrote: > [JDK-8228649](https://bugs.openjdk.org/browse/JDK-8228649) had already been backported to 11.0.5. [JDK-8211767](https://bugs.openjdk.org/browse/JDK-8211767) was marked as duplicate of the former but in the hotspot problemlist we still find exclusions referring to it. So it seems we can drop them. This pull request has now been integrated. Changeset: 91fe4e6a Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/91fe4e6a39f2e5d3513dde889847ec8c20c4724a Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod 8331790: [11u] Remove problemlist entries after backport of JDK-8228649 Reviewed-by: mbaesken ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2701 From goetz at openjdk.org Fri May 10 06:39:09 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 10 May 2024 06:39:09 GMT Subject: [jdk21u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: References: Message-ID: On Thu, 9 May 2024 05:51:03 GMT, Liang Mao wrote: > Clean backport of fixing rare long hand shake while mutator threads in heavy contention on ShenandoahLock. > > Additional testing: > - [x] Linux aarch64 server fastdebug, hotspot/jtreg/tier1 with +UseShenandoahGC Please backport to 22 first. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/560#issuecomment-2103961991 From mbaesken at openjdk.org Fri May 10 06:44:09 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 10 May 2024 06:44:09 GMT Subject: [jdk22u] Integrated: 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp In-Reply-To: <0udL507qVEU60WzjYGFcpSzOkb7G9ye4v5fub5Ux4Js=.96a749d2-9469-405b-b3f7-a1078ba3d392@github.com> References: <0udL507qVEU60WzjYGFcpSzOkb7G9ye4v5fub5Ux4Js=.96a749d2-9469-405b-b3f7-a1078ba3d392@github.com> Message-ID: On Tue, 7 May 2024 15:19:08 GMT, Matthias Baesken wrote: > Backport of 8330524 This pull request has now been integrated. Changeset: fc18e8a8 Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/fc18e8a8c2ffc2108783e8b325fe2c9a6f51cdfa Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp Backport-of: 252c62a66dd955a5d22f307544f38cc0dd4f2550 ------------- PR: https://git.openjdk.org/jdk22u/pull/188 From mbaesken at openjdk.org Fri May 10 06:44:12 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 10 May 2024 06:44:12 GMT Subject: [jdk21u-dev] Integrated: 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp In-Reply-To: References: Message-ID: On Mon, 6 May 2024 13:14:48 GMT, Matthias Baesken wrote: > Backport of 8330524 This pull request has now been integrated. Changeset: e3a9226e Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/e3a9226e0d481ea1ad9747ec9d40f40bbcb650f3 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp Backport-of: 252c62a66dd955a5d22f307544f38cc0dd4f2550 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/554 From andrewlu at openjdk.org Fri May 10 07:13:11 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 10 May 2024 07:13:11 GMT Subject: [jdk17u-dev] Integrated: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException In-Reply-To: References: Message-ID: On Thu, 9 May 2024 06:45:02 GMT, Andrew Lu wrote: > 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException This pull request has now been integrated. Changeset: 97cc1771 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/97cc17719d01122399d1d5ea9bed02af321b27e6 Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException Backport-of: 510003cfe33c34e62735c9fd49178d86b69b89ed ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2455 From andrewlu at openjdk.org Fri May 10 07:13:15 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 10 May 2024 07:13:15 GMT Subject: [jdk11u-dev] Integrated: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException In-Reply-To: References: Message-ID: On Thu, 9 May 2024 06:45:12 GMT, Andrew Lu wrote: > 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException This pull request has now been integrated. Changeset: 4b67c4ec Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/4b67c4ecd5a10a89397688b0c81a177729510863 Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException Backport-of: 510003cfe33c34e62735c9fd49178d86b69b89ed ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2705 From lmao at openjdk.org Fri May 10 07:41:09 2024 From: lmao at openjdk.org (Liang Mao) Date: Fri, 10 May 2024 07:41:09 GMT Subject: [jdk22u] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM Message-ID: <1pUPgnbRaHJRzDtyfw1NJp2v9GP555PFzVf2-RyyMTc=.0ce4d64d-005e-44de-94a8-9ee76fedd11a@github.com> Clean backport of fixing rare long hand shake while mutator threads in heavy contention on ShenandoahLock. ------------- Commit messages: - Backport 492e8bf563135d27b46fde198880e62d5f1940e8 Changes: https://git.openjdk.org/jdk22u/pull/192/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=192&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325587 Stats: 67 lines in 3 files changed: 48 ins; 1 del; 18 mod Patch: https://git.openjdk.org/jdk22u/pull/192.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/192/head:pull/192 PR: https://git.openjdk.org/jdk22u/pull/192 From goetz at openjdk.org Fri May 10 09:22:31 2024 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 10 May 2024 09:22:31 GMT Subject: [jdk17u-dev] Integrated: 8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed In-Reply-To: References: Message-ID: On Fri, 3 May 2024 14:49:06 GMT, Goetz Lindenmaier wrote: > I omit the test from this change. > The test heavily depends on features only available in 21. > I tried to get it working in 20 because that has virtual threads, > but there are more things missing. This pull request has now been integrated. Changeset: 4504b163 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/4504b16390fc8c00542fdc43625e0e03a8cbc7c7 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed Reviewed-by: mbaesken Backport-of: b6ecca126846f9c53d554ff061cfe9b7b20a4d12 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2445 From mbaesken at openjdk.org Fri May 10 11:10:51 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 10 May 2024 11:10:51 GMT Subject: [jdk17u-dev] RFR: 8297445: PPC64: Represent Registers as values In-Reply-To: References: Message-ID: On Thu, 9 May 2024 00:36:30 GMT, Martin Doerr wrote: > Backport of [JDK-8297445](https://bugs.openjdk.org/browse/JDK-8297445). Fixes GCC 11 build warnings ([JDK-8297426](https://bugs.openjdk.org/browse/JDK-8297426)). > > Backport requires manual integration mainly due to unrelated context differences, but is easy to resolve. > One hunk in templateTable_ppc_64.cpp (monitorenter) is already there. > > Some obsolete stuff needs to get removed (see 2nd commit). `RegisterImpl::number_of_registers` is not an important constant for the SA. The x86 version of this change simply removed it (`declare_constant(RegisterImpl::number_of_registers)`): https://github.com/openjdk/jdk/commit/755ecf6b7384e67ccb51c4498f94336631db690d > I have kept it for the platforms which didn't backport the change. (x86 doesn't need the backport for GCC 11.) Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2454#pullrequestreview-2049855093 From clanger at openjdk.org Fri May 10 11:37:53 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 10 May 2024 11:37:53 GMT Subject: [jdk11u-dev] RFR: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list Message-ID: <_xaZxc4yPXuEHeRjtnUx3serjzw0U26DHWbkRnNSXKo=.ca8e5ded-d318-47b2-bea6-031fc3efc7c0@github.com> Remove an obsolete problem list entry for ppc. Change had to be fitted into jdk11u, since lists diverge. ------------- Commit messages: - Backport e552509bcbbba5562219355841cf3dedd7daaeb8 Changes: https://git.openjdk.org/jdk11u-dev/pull/2706/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2706&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297082 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2706.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2706/head:pull/2706 PR: https://git.openjdk.org/jdk11u-dev/pull/2706 From mbaesken at openjdk.org Fri May 10 11:50:22 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 10 May 2024 11:50:22 GMT Subject: [jdk11u-dev] RFR: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list In-Reply-To: <_xaZxc4yPXuEHeRjtnUx3serjzw0U26DHWbkRnNSXKo=.ca8e5ded-d318-47b2-bea6-031fc3efc7c0@github.com> References: <_xaZxc4yPXuEHeRjtnUx3serjzw0U26DHWbkRnNSXKo=.ca8e5ded-d318-47b2-bea6-031fc3efc7c0@github.com> Message-ID: On Fri, 10 May 2024 11:32:29 GMT, Christoph Langer wrote: > Remove an obsolete problem list entry for ppc. Change had to be fitted into jdk11u, since lists diverge. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2706#pullrequestreview-2049914246 From mbaesken at openjdk.org Fri May 10 12:39:24 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 10 May 2024 12:39:24 GMT Subject: [jdk22u] RFR: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing Message-ID: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing ------------- Commit messages: - Backport 377f2e538ae0fc94fc5483700a3ae70175017741 Changes: https://git.openjdk.org/jdk22u/pull/195/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=195&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329862 Stats: 46 lines in 2 files changed: 8 ins; 36 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/195.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/195/head:pull/195 PR: https://git.openjdk.org/jdk22u/pull/195 From duke at openjdk.org Fri May 10 12:44:23 2024 From: duke at openjdk.org (Alexandru C. Moraru) Date: Fri, 10 May 2024 12:44:23 GMT Subject: [jdk17u-dev] Integrated: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests In-Reply-To: References: Message-ID: On Wed, 8 May 2024 11:05:08 GMT, Alexandru C. Moraru wrote: > Clean backport to improve tests performance. This pull request has now been integrated. Changeset: 8f68f8f0 Author: Alexandru C. Moraru Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/8f68f8f019bca842b4bdf366f3c364b25983fd9e Stats: 828 lines in 36 files changed: 0 ins; 828 del; 0 mod 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests Backport-of: 4421951d8f1c6fb16255851a803252fe96a453e5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2452 From duke at openjdk.org Fri May 10 12:44:27 2024 From: duke at openjdk.org (Alexandru C. Moraru) Date: Fri, 10 May 2024 12:44:27 GMT Subject: [jdk11u-dev] Integrated: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests In-Reply-To: References: Message-ID: On Wed, 8 May 2024 13:01:05 GMT, Alexandru C. Moraru wrote: > Clean backport to improve tests performance. This pull request has now been integrated. Changeset: 6d3a41fe Author: Alexandru C. Moraru Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/6d3a41fec7a53cff7aa94641597328dca5e38d08 Stats: 828 lines in 36 files changed: 0 ins; 828 del; 0 mod 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests Backport-of: 4421951d8f1c6fb16255851a803252fe96a453e5 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2703 From stuefe at openjdk.org Fri May 10 14:14:55 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 10 May 2024 14:14:55 GMT Subject: [jdk22u] RFR: 8331344: No compiler replay file with CompilerCommand MemLimit Message-ID: Hi all, This pull request contains a backport of commit [389f6fe9](https://github.com/openjdk/jdk/commit/389f6fe97c348e28d8573fe4754138d2a0bd6c0d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Thomas Stuefe on 2 May 2024 and was reviewed by Vladimir Kozlov and Ashutosh Mehra. Thanks! ------------- Commit messages: - Backport 389f6fe97c348e28d8573fe4754138d2a0bd6c0d Changes: https://git.openjdk.org/jdk22u/pull/191/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=191&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331344 Stats: 29 lines in 3 files changed: 27 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/191.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/191/head:pull/191 PR: https://git.openjdk.org/jdk22u/pull/191 From stuefe at openjdk.org Fri May 10 14:15:06 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 10 May 2024 14:15:06 GMT Subject: [jdk22u] RFR: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default Message-ID: Hi all, See comment in original issue. We'd like to backport this to 22 and 21. This pull request contains a backport of commit [d2d37c91](https://github.com/openjdk/jdk/commit/d2d37c913e5b55f7aec2c7a6b5a2328348ded223) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Thomas Stuefe on 10 May 2024 and was reviewed by Andrew Haley and Ioi Lam. Thanks! ------------- Commit messages: - Backport d2d37c913e5b55f7aec2c7a6b5a2328348ded223 Changes: https://git.openjdk.org/jdk22u/pull/193/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=193&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331942 Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/193.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/193/head:pull/193 PR: https://git.openjdk.org/jdk22u/pull/193 From stuefe at openjdk.org Fri May 10 14:31:18 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 10 May 2024 14:31:18 GMT Subject: [jdk21u-dev] RFR: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default Message-ID: Hi all, This pull request contains a backport of commit [d2d37c91](https://github.com/openjdk/jdk/commit/d2d37c913e5b55f7aec2c7a6b5a2328348ded223) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Thomas Stuefe on 10 May 2024 and was reviewed by Andrew Haley and Ioi Lam. Thanks! ------------- Commit messages: - Backport d2d37c913e5b55f7aec2c7a6b5a2328348ded223 Changes: https://git.openjdk.org/jdk21u-dev/pull/561/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=561&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331942 Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/561.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/561/head:pull/561 PR: https://git.openjdk.org/jdk21u-dev/pull/561 From stuefe at openjdk.org Fri May 10 15:00:13 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 10 May 2024 15:00:13 GMT Subject: [jdk22u] RFR: 8330027: Identity hashes of archived objects must be based on a reproducible random seed Message-ID: This fixes an issue with CDS archive reproducibility that can happen under rare circumstances. See original JBS issue for details. I had to manually resolve the hunk in src/hotspot/share/cds/heapShared.cpp because both - 8251330: Reorder CDS archived heap to speed up relocation - 8329431: Improve speed of writing CDS heap objects were missing. Resolve was trivial. ------------- Commit messages: - 8330027: Identity hashes of archived objects must be based on a reproducible random seed Changes: https://git.openjdk.org/jdk22u/pull/194/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=194&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330027 Stats: 14 lines in 3 files changed: 4 ins; 7 del; 3 mod Patch: https://git.openjdk.org/jdk22u/pull/194.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/194/head:pull/194 PR: https://git.openjdk.org/jdk22u/pull/194 From lucy at openjdk.org Fri May 10 17:05:16 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 10 May 2024 17:05:16 GMT Subject: [jdk17u-dev] RFR: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: On Sat, 4 May 2024 05:44:38 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. > > Thanks! Looks good. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2446#pullrequestreview-2050499628 From lucy at openjdk.org Fri May 10 17:35:12 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 10 May 2024 17:35:12 GMT Subject: [jdk17u-dev] RFR: 8307423: [s390x] Represent Registers as values In-Reply-To: References: Message-ID: On Wed, 8 May 2024 14:30:21 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [8bbd264c](https://github.com/openjdk/jdk/commit/8bbd264c6e4b4045a218f11ae6b5b4f395bc2aa9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 8 May 2023 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! Looks good. A lot of tedious work! Thank you. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2453#pullrequestreview-2050548028 From phh at openjdk.org Sat May 11 03:35:06 2024 From: phh at openjdk.org (Paul Hohensee) Date: Sat, 11 May 2024 03:35:06 GMT Subject: [jdk22u] RFR: 8330027: Identity hashes of archived objects must be based on a reproducible random seed In-Reply-To: References: Message-ID: On Fri, 10 May 2024 10:47:35 GMT, Thomas Stuefe wrote: > This fixes an issue with CDS archive reproducibility that can happen under rare circumstances. See original JBS issue for details. > > I had to manually resolve the hunk in src/hotspot/share/cds/heapShared.cpp because both > - 8251330: Reorder CDS archived heap to speed up relocation > - 8329431: Improve speed of writing CDS heap objects > were missing. > > Resolve was trivial. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk22u/pull/194#pullrequestreview-2051063018 From phh at openjdk.org Sat May 11 03:52:10 2024 From: phh at openjdk.org (Paul Hohensee) Date: Sat, 11 May 2024 03:52:10 GMT Subject: [jdk17u-dev] RFR: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect In-Reply-To: References: Message-ID: On Fri, 8 Mar 2024 06:47:16 GMT, Roman Marchenko wrote: > This is a backport of JDK-8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect. > > Backporting this because this issue can be reproduced in JDK17 as well. > > The backport isn't clean: > 1. Resolved a conflict in `src/hotspot/share/prims/jvmtiEventController.cpp` with an empty line. > 2. Removed files as VThreads are not implemented in jdk17: > - `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/libVThreadTest.cpp` > - `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/VThreadTest.java` > 3. Added new test: > - `test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/Test.java` > - `test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/libextcallback.c` > - `test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/loadClass/Test2.java` > > Actually, backporting the fix only. > The new test fails without the fix, and successfully passes with the fix. Marked as reviewed by phh (Reviewer). GHA failure is an infrastructure issue. ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2276#pullrequestreview-2051066564 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2276#issuecomment-2105523155 From stuefe at openjdk.org Sat May 11 05:28:07 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Sat, 11 May 2024 05:28:07 GMT Subject: [jdk21u-dev] RFR: 8330027: Identity hashes of archived objects must be based on a reproducible random seed Message-ID: This fixes an issue with CDS archive reproducibility that can happen under rare circumstances. See original JBS issue for details. I had to manually resolve the hunk in src/hotspot/share/cds/heapShared.cpp because both 8251330: Reorder CDS archived heap to speed up relocation 8329431: Improve speed of writing CDS heap objects were missing. I also had to change `CDSConfig::is_dumping_static_archive()` - which only exists in JDK 22 and later - to the technically equal `DumpSharedSpaces`. ------------- Commit messages: - 8330027: Identity hashes of archived objects must be based on a reproducible random seed Changes: https://git.openjdk.org/jdk21u-dev/pull/562/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=562&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330027 Stats: 13 lines in 3 files changed: 3 ins; 7 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/562.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/562/head:pull/562 PR: https://git.openjdk.org/jdk21u-dev/pull/562 From rkannathpari at openjdk.org Sat May 11 06:05:31 2024 From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad) Date: Sat, 11 May 2024 06:05:31 GMT Subject: [jdk22u] RFR: 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma Message-ID: Hi all, This pull request contains a backport of commit [ffa33d7b](https://github.com/openjdk/jdk/commit/ffa33d7b807bfef6ff05c9adba869dddf813cf68) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Artem Semenov on 17 Jan 2024 and was reviewed by Alexander Zuev. Thanks! ------------- Commit messages: - Backport ffa33d7b807bfef6ff05c9adba869dddf813cf68 Changes: https://git.openjdk.org/jdk22u/pull/196/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=196&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317771 Stats: 65 lines in 1 file changed: 64 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/196.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/196/head:pull/196 PR: https://git.openjdk.org/jdk22u/pull/196 From jkratochvil at openjdk.org Sun May 12 14:15:00 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Sun, 12 May 2024 14:15:00 GMT Subject: [jdk22u] RFR: 8328997: Remove unnecessary template parameter lists in GrowableArray Message-ID: It is needed to build OpenJDK-22 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) (this [backport](https://github.com/openjdk/jdk22u/pull/197)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk22u/pull/198)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) ([backport](https://github.com/openjdk/jdk22u/pull/199)). Git cherry-pick was not clean but it was a non-issue. ------------- Commit messages: - 8328997: Remove unnecessary template parameter lists in GrowableArray Changes: https://git.openjdk.org/jdk22u/pull/197/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=197&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328997 Stats: 16 lines in 1 file changed: 0 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk22u/pull/197.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/197/head:pull/197 PR: https://git.openjdk.org/jdk22u/pull/197 From jkratochvil at openjdk.org Sun May 12 14:15:19 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Sun, 12 May 2024 14:15:19 GMT Subject: [jdk22u] RFR: 8331352: error: template-id not allowed for constructor/destructor in C++20 Message-ID: <6IxK3y3YUu5gyL_tSMIYKmdYtCbyAYrUhpbzP5ceGRk=.e7d265d0-4def-4ef2-9910-da4430ede614@github.com> It is needed to build OpenJDK-22 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk22u/pull/197)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) (this [backport](https://github.com/openjdk/jdk22u/pull/198)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) ([backport](https://github.com/openjdk/jdk22u/pull/199)). Git cherry-pick was clean. ------------- Commit messages: - 8331352: error: template-id not allowed for constructor/destructor in C++20 Changes: https://git.openjdk.org/jdk22u/pull/198/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=198&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331352 Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk22u/pull/198.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/198/head:pull/198 PR: https://git.openjdk.org/jdk22u/pull/198 From jkratochvil at openjdk.org Sun May 12 14:18:28 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Sun, 12 May 2024 14:18:28 GMT Subject: [jdk22u] RFR: 8324243: Compilation failures in java.desktop module with gcc 14 Message-ID: It is needed to build OpenJDK-22 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk22u/pull/197)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk22u/pull/198)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) (this [backport](https://github.com/openjdk/jdk22u/pull/199)). Git cherry-pick was clean. ------------- Commit messages: - 8324243: Compilation failures in java.desktop module with gcc 14 Changes: https://git.openjdk.org/jdk22u/pull/199/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=199&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324243 Stats: 6 lines in 4 files changed: 2 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk22u/pull/199.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/199/head:pull/199 PR: https://git.openjdk.org/jdk22u/pull/199 From andrewlu at openjdk.org Mon May 13 05:28:27 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 13 May 2024 05:28:27 GMT Subject: [jdk17u-dev] RFR: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError Message-ID: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError ------------- Commit messages: - Backport f12200cd11c2b689618cde1902db941ee23fbf80 Changes: https://git.openjdk.org/jdk17u-dev/pull/2457/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2457&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8267796 Stats: 157 lines in 4 files changed: 65 ins; 55 del; 37 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2457.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2457/head:pull/2457 PR: https://git.openjdk.org/jdk17u-dev/pull/2457 From andrewlu at openjdk.org Mon May 13 05:54:37 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 13 May 2024 05:54:37 GMT Subject: [jdk11u-dev] RFR: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError Message-ID: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError ------------- Commit messages: - Backport f12200cd11c2b689618cde1902db941ee23fbf80 - Backport f12200cd11c2b689618cde1902db941ee23fbf80 Changes: https://git.openjdk.org/jdk11u-dev/pull/2707/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2707&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8267796 Stats: 157 lines in 4 files changed: 65 ins; 55 del; 37 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2707.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2707/head:pull/2707 PR: https://git.openjdk.org/jdk11u-dev/pull/2707 From andrewlu at openjdk.org Mon May 13 08:31:33 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 13 May 2024 08:31:33 GMT Subject: [jdk17u-dev] RFR: 8280835: jdk/javadoc/tool/CheckManPageOptions.java depends on source hierarchy Message-ID: 8280835: jdk/javadoc/tool/CheckManPageOptions.java depends on source hierarchy ------------- Commit messages: - Backport 6d242e406539e97bdd4da82c478db901942b770f Changes: https://git.openjdk.org/jdk17u-dev/pull/2458/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2458&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280835 Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2458.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2458/head:pull/2458 PR: https://git.openjdk.org/jdk17u-dev/pull/2458 From shade at openjdk.org Mon May 13 08:56:20 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 13 May 2024 08:56:20 GMT Subject: [jdk22u] RFR: 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095 In-Reply-To: References: Message-ID: On Wed, 8 May 2024 14:21:21 GMT, Thomas Stuefe wrote: > Trivial, but somewhat urgent fix to a jdk-22-only problem brought by an unclean backport of https://bugs.openjdk.org/browse/JDK-8325095. Ouch. So I missed this hunk during jdk22u backport? Looks good. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk22u/pull/190#pullrequestreview-2052086784 From shade at openjdk.org Mon May 13 08:59:27 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 13 May 2024 08:59:27 GMT Subject: [jdk21u-dev] RFR: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) In-Reply-To: References: Message-ID: On Wed, 21 Feb 2024 12:26:40 GMT, SendaoYan wrote: > Hi, > > Clean backport of [JDK-8311964](https://github.com/openjdk/jdk/pull/14942). Backport has been verified as bellow. Only change the testcases, the risk is low. > > > There 3 testcases run complaint "Unrecognized VM option" with linux-x86-client-release jdk before this PR. LoopUnswitching, OptimizeFill and StressCCP are all C2 flags. > test command: > > rm -rf tmp/ ; jtreg -v:fail,error -nr -w tmp -jdk:build/linux-x86-client-release/images/jdk/ test/hotspot/jtreg/compiler/loopopts/TestBackedgeLoadArrayFillMain.java test/hotspot/jtreg/compiler/loopopts/TestInfiniteLoopWithUnmergedBackedgesMain.java test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckCmpUOverflowVsSub.java 2>&1 | grep "Unrecognized VM option" > > ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/f4bd5f9e-cefd-4e28-9a19-2f85d59b4dfe) > > > After this PR, there 3 testcases won't be selected when the test jdk is linux-x86-client. > ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/eba2a2b2-e164-452b-b7b2-cf4953cec7d4) > > > Thanks, > -sendao I think is PR base is too old, bot says there are 318 commits ahead of it. Can you please merge from master to see if it still works? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/279#issuecomment-2107018645 From duke at openjdk.org Mon May 13 09:04:22 2024 From: duke at openjdk.org (Chad Rakoczy) Date: Mon, 13 May 2024 09:04:22 GMT Subject: [jdk21u-dev] Integrated: 8325621: Improve jspawnhelper version checks In-Reply-To: <9zGCFY6H1ttbTVYikQOg0uJPj-ks9skbBLj_LXRkUS8=.ec494a74-36a6-436f-9bcf-bd48d7a1b1e2@github.com> References: <9zGCFY6H1ttbTVYikQOg0uJPj-ks9skbBLj_LXRkUS8=.ec494a74-36a6-436f-9bcf-bd48d7a1b1e2@github.com> Message-ID: On Wed, 1 May 2024 22:05:45 GMT, Chad Rakoczy wrote: > Backport of [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621) > > Clean backport to update jspawnhelper to check that JDK version and jspawnhelper version are the same. Updates test to include check for version. GHA tests pass including the updated test. Risk is low: touches the production code paths but only passes an additional argument to jspawnhelper This pull request has now been integrated. Changeset: fa874b3d Author: Chad Rakoczy Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/fa874b3d901cce493426a7a7df52cace9de3857c Stats: 59 lines in 5 files changed: 47 ins; 4 del; 8 mod 8325621: Improve jspawnhelper version checks Backport-of: a232e8fb4e6e9e2e9a5285bf01c93b8d1d995f04 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/547 From shade at openjdk.org Mon May 13 09:04:28 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 13 May 2024 09:04:28 GMT Subject: [jdk21u-dev] RFR: 8320370: NMT: Change MallocMemorySnapshot to simplify code. In-Reply-To: References: Message-ID: On Mon, 6 May 2024 09:38:18 GMT, Aleksey Shipilev wrote: > Clean backport to improve NMT initialization and provide cleanliness for other backports. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `runtime/NMT` Thank you! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/552#issuecomment-2107027791 From shade at openjdk.org Mon May 13 09:04:28 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 13 May 2024 09:04:28 GMT Subject: [jdk21u-dev] Integrated: 8320370: NMT: Change MallocMemorySnapshot to simplify code. In-Reply-To: References: Message-ID: On Mon, 6 May 2024 09:38:18 GMT, Aleksey Shipilev wrote: > Clean backport to improve NMT initialization and provide cleanliness for other backports. > > Additional testing: > - [x] MacOS AArch64 server fastdebug, `runtime/NMT` This pull request has now been integrated. Changeset: 153de5ae Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/153de5aeba5bd8378b5a625d482ece524453e5f7 Stats: 19 lines in 5 files changed: 0 ins; 12 del; 7 mod 8320370: NMT: Change MallocMemorySnapshot to simplify code. Reviewed-by: stuefe Backport-of: a7f60164063bdf95437326e7550fd65ff91b5566 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/552 From shade at openjdk.org Mon May 13 09:06:40 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 13 May 2024 09:06:40 GMT Subject: [jdk21u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: References: Message-ID: On Thu, 9 May 2024 05:51:03 GMT, Liang Mao wrote: > Clean backport of fixing rare long hand shake while mutator threads in heavy contention on ShenandoahLock. > > Additional testing: > - [x] Linux aarch64 server fastdebug, hotspot/jtreg/tier1 with +UseShenandoahGC Too early for 21u-dev anyway; there are follow-up improvements that we want to resolve first, and then backport all of them at once, so that JDK 21 is not in some intermediate state. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/560#issuecomment-2107033593 From syan at openjdk.org Mon May 13 09:08:40 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:08:40 GMT Subject: [jdk21u-dev] RFR: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) [v2] In-Reply-To: References: Message-ID: > Hi, > > Clean backport of [JDK-8311964](https://github.com/openjdk/jdk/pull/14942). Backport has been verified as bellow. Only change the testcases, the risk is low. > > > There 3 testcases run complaint "Unrecognized VM option" with linux-x86-client-release jdk before this PR. LoopUnswitching, OptimizeFill and StressCCP are all C2 flags. > test command: > > rm -rf tmp/ ; jtreg -v:fail,error -nr -w tmp -jdk:build/linux-x86-client-release/images/jdk/ test/hotspot/jtreg/compiler/loopopts/TestBackedgeLoadArrayFillMain.java test/hotspot/jtreg/compiler/loopopts/TestInfiniteLoopWithUnmergedBackedgesMain.java test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckCmpUOverflowVsSub.java 2>&1 | grep "Unrecognized VM option" > > ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/f4bd5f9e-cefd-4e28-9a19-2f85d59b4dfe) > > > After this PR, there 3 testcases won't be selected when the test jdk is linux-x86-client. > ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/eba2a2b2-e164-452b-b7b2-cf4953cec7d4) > > > Thanks, > -sendao SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-sendaoYan-024133b0 - Backport 024133b089d911dcc3ea70dfdaa6b150b14a9eb4 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/279/files - new: https://git.openjdk.org/jdk21u-dev/pull/279/files/93cbcc4f..02c1674e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=279&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=279&range=00-01 Stats: 41337 lines in 1199 files changed: 23390 ins; 10174 del; 7773 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/279.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/279/head:pull/279 PR: https://git.openjdk.org/jdk21u-dev/pull/279 From syan at openjdk.org Mon May 13 09:12:37 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:12:37 GMT Subject: [jdk17u-dev] RFR: 8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978 [v2] In-Reply-To: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> References: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> Message-ID: <47TaHX6tKXZI6qfwPw9BsLJ2oVSprqiNDihO5j3Myew=.fb645815-995c-44eb-b9fb-1c69c5532e3a@github.com> > Hi, > > The testcase ReflectionCallerCacheTest.java run failed with -Xcomp, both on linux-x86_64 and linux-aarch64. > > And it run pass by jdk23 binary with the same testcase and the same jvm options(-Xcomp): > > ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/9ee1e9d2-96fc-4772-b11f-776a631515cd) > > > Before we found the root cause of this failure, should we problem list this testcase in test/jdk/ProblemList-Xcomp.txt. > > Thanks, > -sendao SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into jbs8324978 - 8324978: java/lang/reflect/callerCache/ReflectionCallerCacheTest.java run fail with -Xcomp: Class AccessTest$PublicStaticFinalField not unloaded! Signed-off-by: sendaoYan ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2186/files - new: https://git.openjdk.org/jdk17u-dev/pull/2186/files/8e12a85c..355a4d9b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2186&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2186&range=00-01 Stats: 44694 lines in 1339 files changed: 21896 ins; 18300 del; 4498 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2186.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2186/head:pull/2186 PR: https://git.openjdk.org/jdk17u-dev/pull/2186 From syan at openjdk.org Mon May 13 09:14:07 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:14:07 GMT Subject: [jdk21u-dev] RFR: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) In-Reply-To: References: Message-ID: On Mon, 13 May 2024 08:56:33 GMT, Aleksey Shipilev wrote: > I think is PR base is too old, bot says there are 318 commits ahead of it. Can you please merge from master to see if it still works? I have merged from master just now. Thanks for the advice. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/279#issuecomment-2107048929 From shade at openjdk.org Mon May 13 09:18:19 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 13 May 2024 09:18:19 GMT Subject: [jdk17u-dev] RFR: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) In-Reply-To: References: Message-ID: On Wed, 21 Feb 2024 12:26:43 GMT, SendaoYan wrote: > Hi, > > Clean backport of [JDK-8311964](https://github.com/openjdk/jdk/pull/14942). Backport has been verified as bellow. Only change the testcases, the risk is low. > > > There 3 testcases run complaint "Unrecognized VM option" with linux-x86-client-release jdk before this PR. LoopUnswitching, OptimizeFill and StressCCP are all C2 flags. > test command: > > rm -rf tmp/ ; jtreg -v:fail,error -nr -w tmp -jdk:build/linux-x86-client-release/images/jdk/ test/hotspot/jtreg/compiler/loopopts/TestBackedgeLoadArrayFillMain.java test/hotspot/jtreg/compiler/loopopts/TestInfiniteLoopWithUnmergedBackedgesMain.java test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckCmpUOverflowVsSub.java 2>&1 | grep "Unrecognized VM option" > > ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/b63a86f6-1e02-4de9-ba05-eade92287df6) > > > Thanks, > -sendao > > After this PR, there 3 testcases won't be selected when the test jdk is linux-x86-client. > ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/79915d83-047a-452e-81da-184b8a970fc0) Same thing here: please merge from current master to get an up-to-date test run. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2216#issuecomment-2107059504 From duke at openjdk.org Mon May 13 09:20:24 2024 From: duke at openjdk.org (Alexandru C. Moraru) Date: Mon, 13 May 2024 09:20:24 GMT Subject: [jdk17u-dev] Integrated: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition In-Reply-To: References: Message-ID: On Fri, 26 Apr 2024 13:55:36 GMT, Alexandru C. Moraru wrote: > Clean backport to pass the correct string so that waitForDeduplication does not always wait for 10 seconds before proceeding. This pull request has now been integrated. Changeset: 20c2511f Author: Alexandru C. Moraru Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/20c2511f54bbae0d41f8750f5e02c6b59630d66f Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod 8309890: TestStringDeduplicationInterned.java waits for the wrong condition Backport-of: 63fe413d93861c79af5587859f01822980969c24 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2432 From syan at openjdk.org Mon May 13 09:27:27 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:27:27 GMT Subject: [jdk17u-dev] RFR: 8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978 [v3] In-Reply-To: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> References: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> Message-ID: > Hi, > > The testcase ReflectionCallerCacheTest.java run failed with -Xcomp, both on linux-x86_64 and linux-aarch64. > > And it run pass by jdk23 binary with the same testcase and the same jvm options(-Xcomp): > > ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/9ee1e9d2-96fc-4772-b11f-776a631515cd) > > > Before we found the root cause of this failure, should we problem list this testcase in test/jdk/ProblemList-Xcomp.txt. > > Thanks, > -sendao SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into jbs8324978 - Merge branch 'openjdk:master' into jbs8324978 - 8324978: java/lang/reflect/callerCache/ReflectionCallerCacheTest.java run fail with -Xcomp: Class AccessTest$PublicStaticFinalField not unloaded! Signed-off-by: sendaoYan ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2186/files - new: https://git.openjdk.org/jdk17u-dev/pull/2186/files/355a4d9b..9b76542d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2186&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2186&range=01-02 Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2186.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2186/head:pull/2186 PR: https://git.openjdk.org/jdk17u-dev/pull/2186 From syan at openjdk.org Mon May 13 09:27:38 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:27:38 GMT Subject: [jdk17u-dev] RFR: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) [v2] In-Reply-To: References: Message-ID: > Hi, > > Clean backport of [JDK-8311964](https://github.com/openjdk/jdk/pull/14942). Backport has been verified as bellow. Only change the testcases, the risk is low. > > > There 3 testcases run complaint "Unrecognized VM option" with linux-x86-client-release jdk before this PR. LoopUnswitching, OptimizeFill and StressCCP are all C2 flags. > test command: > > rm -rf tmp/ ; jtreg -v:fail,error -nr -w tmp -jdk:build/linux-x86-client-release/images/jdk/ test/hotspot/jtreg/compiler/loopopts/TestBackedgeLoadArrayFillMain.java test/hotspot/jtreg/compiler/loopopts/TestInfiniteLoopWithUnmergedBackedgesMain.java test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckCmpUOverflowVsSub.java 2>&1 | grep "Unrecognized VM option" > > ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/b63a86f6-1e02-4de9-ba05-eade92287df6) > > > Thanks, > -sendao > > After this PR, there 3 testcases won't be selected when the test jdk is linux-x86-client. > ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/79915d83-047a-452e-81da-184b8a970fc0) SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-sendaoYan-024133b0 - Backport 024133b089d911dcc3ea70dfdaa6b150b14a9eb4 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2216/files - new: https://git.openjdk.org/jdk17u-dev/pull/2216/files/f7041a67..a6523b69 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2216&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2216&range=00-01 Stats: 43016 lines in 1317 files changed: 20896 ins; 17902 del; 4218 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2216.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2216/head:pull/2216 PR: https://git.openjdk.org/jdk17u-dev/pull/2216 From syan at openjdk.org Mon May 13 09:27:38 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:27:38 GMT Subject: [jdk17u-dev] RFR: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) In-Reply-To: References: Message-ID: On Mon, 13 May 2024 09:15:43 GMT, Aleksey Shipilev wrote: > Same thing here: please merge from current master to get an up-to-date test run. Thanks, I will check all mine PRs right now. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2216#issuecomment-2107075609 From syan at openjdk.org Mon May 13 09:30:31 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:30:31 GMT Subject: [jdk11u-dev] RFR: 8328825: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: > Hi, > > Clean backport to fix some of the current failures in CAInterop test. > > Additional testing: > > - [x] Affected subtests are now passing > > ![image](https://github.com/openjdk/jdk11u-dev/assets/24123821/f08fa697-41f6-4365-b0f5-64d8df5f114f) > > Thanks, > -sendao SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-sendaoYan-70a15c73 - Backport 70a15c73638f45b9ed629abc0ea2d86a324bf624 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2624/files - new: https://git.openjdk.org/jdk11u-dev/pull/2624/files/a273e433..4161bdea Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2624&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2624&range=00-01 Stats: 19125 lines in 395 files changed: 12347 ins; 4324 del; 2454 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2624.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2624/head:pull/2624 PR: https://git.openjdk.org/jdk11u-dev/pull/2624 From syan at openjdk.org Mon May 13 09:32:49 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:32:49 GMT Subject: [jdk21u-dev] RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" [v2] In-Reply-To: References: Message-ID: > Hi, > > Clean backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). Only change the testcase, the change has been verified, the risk is low. > > ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/a971b851-bc31-407a-b66e-0d8189deee9f) > > Thanks, > -sendao SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-sendaoYan-b6233c3d - Backport b6233c3de773fb57b23704f1fec05d8b2d9c11c0 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/419/files - new: https://git.openjdk.org/jdk21u-dev/pull/419/files/e440478f..4fdd7c80 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=419&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=419&range=00-01 Stats: 16070 lines in 562 files changed: 8896 ins; 4907 del; 2267 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/419.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/419/head:pull/419 PR: https://git.openjdk.org/jdk21u-dev/pull/419 From syan at openjdk.org Mon May 13 09:36:40 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:36:40 GMT Subject: [jdk17u-dev] RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" [v2] In-Reply-To: <_wlIzpJsJthuDmb6fBJnltFyd3YG6Fp9-X7NjHKGcuI=.616d0b06-ef07-47dd-b1e0-bd2884b2dd71@github.com> References: <_wlIzpJsJthuDmb6fBJnltFyd3YG6Fp9-X7NjHKGcuI=.616d0b06-ef07-47dd-b1e0-bd2884b2dd71@github.com> Message-ID: > Hi, > > Clean backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). Only change the testcase, the change has been verified, the risk is low. > > ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/17ae2a82-e34d-4713-b30d-6248fd04476d) > > Thanks, > -sendao SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-sendaoYan-b6233c3d - Backport b6233c3de773fb57b23704f1fec05d8b2d9c11c0 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2342/files - new: https://git.openjdk.org/jdk17u-dev/pull/2342/files/783b0427..dfa99758 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2342&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2342&range=00-01 Stats: 30297 lines in 910 files changed: 11981 ins; 16105 del; 2211 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2342.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2342/head:pull/2342 PR: https://git.openjdk.org/jdk17u-dev/pull/2342 From syan at openjdk.org Mon May 13 09:38:10 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:38:10 GMT Subject: [jdk11u-dev] RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" [v2] In-Reply-To: References: Message-ID: > Hi, > > Backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). > > The origin PR use `int nextInt(int origin, int bound)` [link](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html#nextInt(int,int)) , but the jdk11 do not have this API. So I change `int nextInt(int origin, int bound)` to `nextInt(bound - origin) + origin` [link](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/Random.html#nextInt(int)). > > Only change the testcase, the change has been verified, the risk is low. > > ![image](https://github.com/openjdk/jdk11u-dev/assets/24123821/63c82beb-1c90-45b0-b8b7-6419cf111252) > > Thanks, > -sendao SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into jbs8321925 - Backport b6233c3de773fb57b23704f1fec05d8b2d9c11c0 Signed-off-by: sendaoYan ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2631/files - new: https://git.openjdk.org/jdk11u-dev/pull/2631/files/84c0d822..548f51d8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2631&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2631&range=00-01 Stats: 18291 lines in 385 files changed: 11569 ins; 4306 del; 2416 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2631.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2631/head:pull/2631 PR: https://git.openjdk.org/jdk11u-dev/pull/2631 From syan at openjdk.org Mon May 13 09:38:11 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:38:11 GMT Subject: [jdk11u-dev] RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" In-Reply-To: References: Message-ID: On Thu, 28 Mar 2024 03:42:08 GMT, SendaoYan wrote: > Hi, > > Backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). > > The origin PR use `int nextInt(int origin, int bound)` [link](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html#nextInt(int,int)) , but the jdk11 do not have this API. So I change `int nextInt(int origin, int bound)` to `nextInt(bound - origin) + origin` [link](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/Random.html#nextInt(int)). > > Only change the testcase, the change has been verified, the risk is low. > > ![image](https://github.com/openjdk/jdk11u-dev/assets/24123821/63c82beb-1c90-45b0-b8b7-6419cf111252) > > Thanks, > -sendao Hi, can anyone review this PR. thanks. Backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). Only change the testcase, the change has been verified, the risk is low. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2631#issuecomment-2107100021 From syan at openjdk.org Mon May 13 09:39:44 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:39:44 GMT Subject: [jdk17u-dev] RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v2] In-Reply-To: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> References: <_Z8VF_8iVSgs_GyiCDau6U8BzRt-RSAmH0fWDv4pYAA=.592301a8-d4d6-444a-bfbf-a0701d925612@github.com> Message-ID: > Hi, > This is backport of [JDK-8290023](https://bugs.openjdk.org/browse/JDK-8290023), this PR is prefixed PR of backport > [JDK-8293503](https://github.com/openjdk/jdk17u-dev/pull/2431 ) > > Only change the testcase, the change has been verify on below binary: > > - [x] linux x64 release > - [x] linux x64 fastdebug > - [x] linux x86 release > - [x] linux x86 fastdebug > [linux-x64-fastdebug.log](https://github.com/openjdk/jdk17u-dev/files/15142005/linux-x64-fastdebug.log) > [linux-x64-release.log](https://github.com/openjdk/jdk17u-dev/files/15142006/linux-x64-release.log) > [linux-x86-fastdebug.log](https://github.com/openjdk/jdk17u-dev/files/15142007/linux-x86-fastdebug.log) > [linux-x86-release.log](https://github.com/openjdk/jdk17u-dev/files/15142009/linux-x86-release.log) > > It's not clean backport: > 1. test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java has PR `8210708` before `8290023` jdk20 > 2. There is no test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java in jdk17u-dev > 3. test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java has been backported `8298073` and `8241293` after `8290023` in jdk17u-dev > 4. test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java has PR `8284161` before `8290023` in jdk20 SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into jbs8290023 - Backport 2583feb21bf5419afc3c1953d964cf89d65fe8a2 Signed-off-by: sendaoYan ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2438/files - new: https://git.openjdk.org/jdk17u-dev/pull/2438/files/62282790..13b8a714 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2438&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2438&range=00-01 Stats: 2422 lines in 75 files changed: 1100 ins; 1152 del; 170 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2438.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2438/head:pull/2438 PR: https://git.openjdk.org/jdk17u-dev/pull/2438 From syan at openjdk.org Mon May 13 09:39:53 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:39:53 GMT Subject: [jdk17u-dev] RFR: 8293503: gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 failed assertGreaterThanOrEqual: expected MMM >= NNN [v2] In-Reply-To: References: Message-ID: > Hi, > Backport of JDK-[8293503](https://bugs.openjdk.org/browse/JDK-8293503), to fix the [intermittent failure](https://github.com/openjdk-bots/jdk17u-dev/actions/runs/8841821807/job/24280514750) of TestMetaspacePerfCounters.java. > This PR add a proper barrier inbetween two measurements. Only change the testcase, the change has been verify on below binary: > > - [x] linux x64 release > - [x] linux x64 fastdebug > - [x] linux x86 release > - [x] linux x86 fastdebug SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into jbs8293503 - Backport 04d7b7d5747d887e12797df8ca3f7608d73d41ff ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2431/files - new: https://git.openjdk.org/jdk17u-dev/pull/2431/files/8cce5c8d..fe16685c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2431&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2431&range=00-01 Stats: 2422 lines in 75 files changed: 1100 ins; 1152 del; 170 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2431.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2431/head:pull/2431 PR: https://git.openjdk.org/jdk17u-dev/pull/2431 From andrewlu at openjdk.org Mon May 13 09:40:37 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 13 May 2024 09:40:37 GMT Subject: [jdk11u-dev] RFR: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently Message-ID: <8338P7RPoyvINiPbJ_bQYw-Psbu6wMrY6a7L3vCbbq8=.401c8a99-f117-4d7d-bd6e-28da05f8f259@github.com> 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently ------------- Commit messages: - Backport f50df105912858198809b50432ef5a4ab184528d Changes: https://git.openjdk.org/jdk11u-dev/pull/2708/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2708&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299023 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2708.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2708/head:pull/2708 PR: https://git.openjdk.org/jdk11u-dev/pull/2708 From andrewlu at openjdk.org Mon May 13 09:40:32 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 13 May 2024 09:40:32 GMT Subject: [jdk17u-dev] RFR: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently Message-ID: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently ------------- Commit messages: - Backport f50df105912858198809b50432ef5a4ab184528d Changes: https://git.openjdk.org/jdk17u-dev/pull/2459/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2459&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299023 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2459.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2459/head:pull/2459 PR: https://git.openjdk.org/jdk17u-dev/pull/2459 From andrewlu at openjdk.org Mon May 13 09:40:47 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 13 May 2024 09:40:47 GMT Subject: [jdk21u-dev] RFR: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently Message-ID: <6UxOd2FSHJW1t1z9m4G38t_strDxEGt9cvwx1KsUMvY=.8bf009eb-2eb9-4355-9b01-275a801449b9@github.com> 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently ------------- Commit messages: - Backport f50df105912858198809b50432ef5a4ab184528d Changes: https://git.openjdk.org/jdk21u-dev/pull/563/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=563&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299023 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/563.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/563/head:pull/563 PR: https://git.openjdk.org/jdk21u-dev/pull/563 From syan at openjdk.org Mon May 13 09:42:40 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:42:40 GMT Subject: [jdk17u-dev] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 17:58:25 GMT, SendaoYan wrote: > Hi, > This is clean backport of JDK-8331164, to fixed download failure when the URL needed to be redirected. > Only change devkit shell script, the risk is low. After May 29, I will try to merge this PR. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2441#issuecomment-2107109588 From syan at openjdk.org Mon May 13 09:42:42 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:42:42 GMT Subject: [jdk21u-dev] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected [v2] In-Reply-To: References: Message-ID: > Hi, > This is clean backport of JDK-8331164, to fixed download failure when the URL needed to be redirected. > Only change devkit shell script, the risk is low. SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-sendaoYan-eb88343f - Backport eb88343fb763ee89010b7a9879638152decc6892 ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/543/files - new: https://git.openjdk.org/jdk21u-dev/pull/543/files/d25af0c6..29121c6b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=543&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=543&range=00-01 Stats: 4355 lines in 106 files changed: 2144 ins; 1846 del; 365 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/543.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/543/head:pull/543 PR: https://git.openjdk.org/jdk21u-dev/pull/543 From syan at openjdk.org Mon May 13 09:42:42 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:42:42 GMT Subject: [jdk21u-dev] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 17:58:06 GMT, SendaoYan wrote: > Hi, > This is clean backport of JDK-8331164, to fixed download failure when the URL needed to be redirected. > Only change devkit shell script, the risk is low. After May 29, I will try to merge this PR. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/543#issuecomment-2107109378 From syan at openjdk.org Mon May 13 09:44:40 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 09:44:40 GMT Subject: [jdk22u] RFR: 8331331: :tier1 target explanation in doc/testing.md is incorrect [v2] In-Reply-To: References: Message-ID: <7MD4Yb43D0eENPGHBbuQ2EKDVnLmeVugx-D9MfIkSFE=.555fbcd8-0518-43fc-a390-93981caa5e8c@github.com> > Hi, > This is clean backport of [JDK-8331331](https://bugs.openjdk.org/browse/JDK-8331331), fixed the incorrect explanation :tier1 target in doc/testing.md. No risk. SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-sendaoYan-04271dfe - Backport 04271dfe7a262379944e2a2cf83a98a3a1b78a74 ------------- Changes: - all: https://git.openjdk.org/jdk22u/pull/183/files - new: https://git.openjdk.org/jdk22u/pull/183/files/38fe94a0..0116306c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk22u&pr=183&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk22u&pr=183&range=00-01 Stats: 1537 lines in 16 files changed: 346 ins; 1025 del; 166 mod Patch: https://git.openjdk.org/jdk22u/pull/183.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/183/head:pull/183 PR: https://git.openjdk.org/jdk22u/pull/183 From lmao at openjdk.org Mon May 13 10:26:27 2024 From: lmao at openjdk.org (Liang Mao) Date: Mon, 13 May 2024 10:26:27 GMT Subject: [jdk17u-dev] RFR: 8305819: LogConfigurationTest intermittently fails on AArch64 Message-ID: Hi all, This pull request contains a backport of commit [911cc7cb](https://github.com/openjdk/jdk/commit/911cc7cb07ed44b24b4c20977d7d6e475bd1b234) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. It fixed a logging crash due to arm weak memory model. The commit being backported was authored by gaogao-mem on 15 May 2023 and was reviewed by Andrew Haley, David Holmes and Xin Liu. The conflicts only come from the difference of "NULL" and "nullptr". Additional testing: - [x] Verified the test case in original PR. Thanks! ------------- Commit messages: - Backport 911cc7cb07ed44b24b4c20977d7d6e475bd1b234 Changes: https://git.openjdk.org/jdk17u-dev/pull/2460/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2460&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305819 Stats: 19 lines in 2 files changed: 10 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2460.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2460/head:pull/2460 PR: https://git.openjdk.org/jdk17u-dev/pull/2460 From mdoerr at openjdk.org Mon May 13 10:44:17 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 13 May 2024 10:44:17 GMT Subject: [jdk17u-dev] Integrated: 8297445: PPC64: Represent Registers as values In-Reply-To: References: Message-ID: On Thu, 9 May 2024 00:36:30 GMT, Martin Doerr wrote: > Backport of [JDK-8297445](https://bugs.openjdk.org/browse/JDK-8297445). Fixes GCC 11 build warnings ([JDK-8297426](https://bugs.openjdk.org/browse/JDK-8297426)). > > Backport requires manual integration mainly due to unrelated context differences, but is easy to resolve. > One hunk in templateTable_ppc_64.cpp (monitorenter, https://github.com/openjdk/jdk17u-dev/commit/0f2da83f79bdccff6dfb823238f971d6eb495ab8) is already there. > > Some obsolete stuff needs to get removed (see 2nd commit). `RegisterImpl::number_of_registers` is not an important constant for the SA. The x86 version of this change simply removed it (`declare_constant(RegisterImpl::number_of_registers)`): https://github.com/openjdk/jdk/commit/755ecf6b7384e67ccb51c4498f94336631db690d > I have kept it for the platforms which didn't backport the change. (x86 doesn't need the backport for GCC 11.) This pull request has now been integrated. Changeset: 16579f86 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/16579f8658b6422131dd3ca35e7276eb6c477c12 Stats: 861 lines in 15 files changed: 163 ins; 466 del; 232 mod 8297445: PPC64: Represent Registers as values Reviewed-by: mbaesken Backport-of: 9c77e41b81ebd28bd92ea7adad605981a5519046 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2454 From mdoerr at openjdk.org Mon May 13 10:48:13 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 13 May 2024 10:48:13 GMT Subject: [jdk17u-dev] RFR: 8307423: [s390x] Represent Registers as values In-Reply-To: References: Message-ID: On Wed, 8 May 2024 14:30:21 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [8bbd264c](https://github.com/openjdk/jdk/commit/8bbd264c6e4b4045a218f11ae6b5b4f395bc2aa9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 8 May 2023 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! Please merge and make sure it the change in [vmStructs.cpp](https://github.com/openjdk/jdk17u-dev/pull/2453#diff-7d448441e80a0b784429d5d8aee343fcb131c224b8ec7bc70ea636f78d561ecd) works on both platforms: `NOT_S390( NOT_PPC64(`. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2453#issuecomment-2107246020 From mdoerr at openjdk.org Mon May 13 10:50:24 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 13 May 2024 10:50:24 GMT Subject: [jdk17u-dev] RFR: 8302907: [PPC64] Use more constexpr in class Register Message-ID: <8Vho7Uljh_bLxfLCftow2j5e4PivQaXmQZ0mB8N4mG8=.341f7dae-c176-4425-8d71-4acf1a48d3ec@github.com> Clean backport of [JDK-8302907](https://bugs.openjdk.org/browse/JDK-8302907). ------------- Commit messages: - Backport 180b94c73e9ad17d57650d4c985d4104289052a9 Changes: https://git.openjdk.org/jdk17u-dev/pull/2461/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2461&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302907 Stats: 17 lines in 1 file changed: 0 ins; 0 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2461.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2461/head:pull/2461 PR: https://git.openjdk.org/jdk17u-dev/pull/2461 From digital-connectivity-dev at man-es.com Mon May 13 11:02:48 2024 From: digital-connectivity-dev at man-es.com (digital-connectivity-dev) Date: Mon, 13 May 2024 11:02:48 +0000 Subject: Requesting backport of JDK-8308144 Uncontrolled memory consumption in SSLFlowDelegate.Reader Message-ID: Hello, we have been affected by the JDK bug "Uncontrolled memory consumption in SSLFlowDelegate.Reader" that was reported and fixed here: https://bugs.openjdk.org/browse/JDK-8308144 This resulted in an OOM Exception and program crash for us when downloading a large file (~2Gb) running in an environment with limited heap memory (~500Mb). Aside from documentation and tests, the patch committed last November to correct the issue was one line long. However, the fix was only made to JDK 22 and 23: https://github.com/openjdk/jdk/pull/16704 We did not understand the low priority of the issue (P4) as we see no way around the problem and we would have to wait until 2025 for the next LTS release with this fix. We would greatly appreciate it if this fix could instead be backported to earlier LTS JDKs, ideally including JDK 17. Would someone be able to do this for us? We would be uncomfortable attempting to merge this ourselves. If so, would it plausibly make the July release? Many thanks. MAN Energy Solutions SE Vorsitzender des Aufsichtsrates: Gunnar Kilian Vorstand: Dr. Uwe Lauber (Vorsitzender), J?rgen Kl?pffer, Martin Oetjen, Ingrid Rieken, Dr. Gunnar Stiesch Sitz der Gesellschaft: Augsburg Registergericht: Amtsgericht Augsburg, HRB 22056 This e-mail (including any attachments) is confidential and may be privileged. If you have received it by mistake, please notify the sender by e-mail and delete it from your system. Any unauthorized use or dissemination of this e-mail or its contents in whole or in part is strictly prohibited. Please note that e-mails are susceptible to change. MAN Energy Solutions SE (including its group companies) shall not be liable for the improper or incomplete transmission of the information contained in this communication nor for any delay in its receipt. MAN Energy Solutions SE (or its group companies) does not guarantee that the integrity of this communication has been maintained nor that this communication is free of viruses, interceptions or interference. -------------- next part -------------- An HTML attachment was scrubbed... URL: From chagedorn at openjdk.org Mon May 13 11:38:09 2024 From: chagedorn at openjdk.org (Christian Hagedorn) Date: Mon, 13 May 2024 11:38:09 GMT Subject: [jdk22u] RFR: 8322726: C2: Unloaded signature class kills argument value In-Reply-To: <7Mcb5LYSw_pxRnt_PCkP8-CeSx8AlKzQt4zNyzRY6H0=.db0cc31f-e452-468a-9e12-ae87c121ef4c@github.com> References: <7Mcb5LYSw_pxRnt_PCkP8-CeSx8AlKzQt4zNyzRY6H0=.db0cc31f-e452-468a-9e12-ae87c121ef4c@github.com> Message-ID: On Tue, 7 May 2024 10:24:03 GMT, Fairoz Matte wrote: > 8322726: C2: Unloaded signature class kills argument value > Reviewed-by: kvn, dlong, thartmann Marked as reviewed by chagedorn (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk22u/pull/187#pullrequestreview-2052433615 From fmatte at openjdk.org Mon May 13 11:46:13 2024 From: fmatte at openjdk.org (Fairoz Matte) Date: Mon, 13 May 2024 11:46:13 GMT Subject: [jdk22u] Integrated: 8322726: C2: Unloaded signature class kills argument value In-Reply-To: <7Mcb5LYSw_pxRnt_PCkP8-CeSx8AlKzQt4zNyzRY6H0=.db0cc31f-e452-468a-9e12-ae87c121ef4c@github.com> References: <7Mcb5LYSw_pxRnt_PCkP8-CeSx8AlKzQt4zNyzRY6H0=.db0cc31f-e452-468a-9e12-ae87c121ef4c@github.com> Message-ID: On Tue, 7 May 2024 10:24:03 GMT, Fairoz Matte wrote: > 8322726: C2: Unloaded signature class kills argument value > Reviewed-by: kvn, dlong, thartmann This pull request has now been integrated. Changeset: 7629aa63 Author: Fairoz Matte Committer: Christian Hagedorn URL: https://git.openjdk.org/jdk22u/commit/7629aa6301f1c9f3757559d14e7110d7fddb4a3d Stats: 181 lines in 5 files changed: 168 ins; 0 del; 13 mod 8322726: C2: Unloaded signature class kills argument value Reviewed-by: vlivanov, chagedorn Backport-of: fa02667d838f08cac7d41dfb4c3e8056ae6165cc ------------- PR: https://git.openjdk.org/jdk22u/pull/187 From amitkumar at openjdk.org Mon May 13 11:47:42 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 13 May 2024 11:47:42 GMT Subject: [jdk17u-dev] RFR: 8307423: [s390x] Represent Registers as values [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [8bbd264c](https://github.com/openjdk/jdk/commit/8bbd264c6e4b4045a218f11ae6b5b4f395bc2aa9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 8 May 2023 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! Amit Kumar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - fixes merge conflict in vmStructs.cpp - removes register_definitions_s390 & updates vmStructs - Merge branch 'openjdk:master' into backport-offamitkumar-8bbd264c - extra space - update - Backport 8bbd264c6e4b4045a218f11ae6b5b4f395bc2aa9 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/2453/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2453&range=01 Stats: 518 lines in 10 files changed: 83 ins; 261 del; 174 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2453.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2453/head:pull/2453 PR: https://git.openjdk.org/jdk17u-dev/pull/2453 From amitkumar at openjdk.org Mon May 13 11:50:04 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 13 May 2024 11:50:04 GMT Subject: [jdk17u-dev] RFR: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: <3sopKEQKellFGi5cq2Rp5RqpWY2ZDtuNY_T622lgcpI=.213df8b1-bff4-40ac-aee2-26d84981d0ff@github.com> On Fri, 10 May 2024 17:02:08 GMT, Lutz Schmidt wrote: >> Hi all, >> >> This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. >> >> Thanks! > > Looks good. Thank you @RealLucy for review. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2446#issuecomment-2107362486 From amitkumar at openjdk.org Mon May 13 12:18:33 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 13 May 2024 12:18:33 GMT Subject: [jdk17u-dev] Integrated: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: On Sat, 4 May 2024 05:44:38 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. > > Thanks! This pull request has now been integrated. Changeset: 606c542e Author: Amit Kumar Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/606c542e7f9cb629e030463f07994e665f6212a2 Stats: 6 lines in 2 files changed: 3 ins; 0 del; 3 mod 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space Reviewed-by: lucy Backport-of: d5f3d5c8cc347ae384dea25b1a55ed57204d1af3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2446 From syan at openjdk.org Mon May 13 12:24:20 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 12:24:20 GMT Subject: [jdk17u-dev] Integrated: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) In-Reply-To: References: Message-ID: On Wed, 21 Feb 2024 12:26:43 GMT, SendaoYan wrote: > Hi, > > Clean backport of [JDK-8311964](https://github.com/openjdk/jdk/pull/14942). Backport has been verified as bellow. Only change the testcases, the risk is low. > > > There 3 testcases run complaint "Unrecognized VM option" with linux-x86-client-release jdk before this PR. LoopUnswitching, OptimizeFill and StressCCP are all C2 flags. > test command: > > rm -rf tmp/ ; jtreg -v:fail,error -nr -w tmp -jdk:build/linux-x86-client-release/images/jdk/ test/hotspot/jtreg/compiler/loopopts/TestBackedgeLoadArrayFillMain.java test/hotspot/jtreg/compiler/loopopts/TestInfiniteLoopWithUnmergedBackedgesMain.java test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckCmpUOverflowVsSub.java 2>&1 | grep "Unrecognized VM option" > > ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/b63a86f6-1e02-4de9-ba05-eade92287df6) > > > Thanks, > -sendao > > After this PR, there 3 testcases won't be selected when the test jdk is linux-x86-client. > ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/79915d83-047a-452e-81da-184b8a970fc0) This pull request has now been integrated. Changeset: ce1fb026 Author: SendaoYan Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/ce1fb0265b3edf904ea00b190957e8a70371a080 Stats: 3 lines in 3 files changed: 3 ins; 0 del; 0 mod 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) Backport-of: 024133b089d911dcc3ea70dfdaa6b150b14a9eb4 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2216 From syan at openjdk.org Mon May 13 12:32:19 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 12:32:19 GMT Subject: [jdk17u-dev] RFR: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) [v2] In-Reply-To: References: Message-ID: On Mon, 13 May 2024 09:27:38 GMT, SendaoYan wrote: >> Hi, >> >> Clean backport of [JDK-8311964](https://github.com/openjdk/jdk/pull/14942). Backport has been verified as bellow. Only change the testcases, the risk is low. >> >> >> There 3 testcases run complaint "Unrecognized VM option" with linux-x86-client-release jdk before this PR. LoopUnswitching, OptimizeFill and StressCCP are all C2 flags. >> test command: >> >> rm -rf tmp/ ; jtreg -v:fail,error -nr -w tmp -jdk:build/linux-x86-client-release/images/jdk/ test/hotspot/jtreg/compiler/loopopts/TestBackedgeLoadArrayFillMain.java test/hotspot/jtreg/compiler/loopopts/TestInfiniteLoopWithUnmergedBackedgesMain.java test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckCmpUOverflowVsSub.java 2>&1 | grep "Unrecognized VM option" >> >> ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/b63a86f6-1e02-4de9-ba05-eade92287df6) >> >> >> Thanks, >> -sendao >> >> After this PR, there 3 testcases won't be selected when the test jdk is linux-x86-client. >> ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/79915d83-047a-452e-81da-184b8a970fc0) > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-024133b0 > - Backport 024133b089d911dcc3ea70dfdaa6b150b14a9eb4 > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2216#issuecomment-2107447844 From syan at openjdk.org Mon May 13 12:46:08 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 12:46:08 GMT Subject: [jdk17u-dev] RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" [v2] In-Reply-To: References: <_wlIzpJsJthuDmb6fBJnltFyd3YG6Fp9-X7NjHKGcuI=.616d0b06-ef07-47dd-b1e0-bd2884b2dd71@github.com> Message-ID: On Mon, 13 May 2024 09:36:40 GMT, SendaoYan wrote: >> Hi, >> >> Clean backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). Only change the testcase, the change has been verified, the risk is low. >> >> ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/17ae2a82-e34d-4713-b30d-6248fd04476d) >> >> Thanks, >> -sendao > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-b6233c3d > - Backport b6233c3de773fb57b23704f1fec05d8b2d9c11c0 > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2342#issuecomment-2107476879 From syan at openjdk.org Mon May 13 12:46:08 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 12:46:08 GMT Subject: [jdk17u-dev] Integrated: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" In-Reply-To: <_wlIzpJsJthuDmb6fBJnltFyd3YG6Fp9-X7NjHKGcuI=.616d0b06-ef07-47dd-b1e0-bd2884b2dd71@github.com> References: <_wlIzpJsJthuDmb6fBJnltFyd3YG6Fp9-X7NjHKGcuI=.616d0b06-ef07-47dd-b1e0-bd2884b2dd71@github.com> Message-ID: On Thu, 28 Mar 2024 03:12:22 GMT, SendaoYan wrote: > Hi, > > Clean backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). Only change the testcase, the change has been verified, the risk is low. > > ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/17ae2a82-e34d-4713-b30d-6248fd04476d) > > Thanks, > -sendao This pull request has now been integrated. Changeset: bf4b15ce Author: SendaoYan Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/bf4b15ce080bfdf1dd818233cd1ef6ac0519294d Stats: 23 lines in 1 file changed: 13 ins; 0 del; 10 mod 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" Backport-of: b6233c3de773fb57b23704f1fec05d8b2d9c11c0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2342 From mdoerr at openjdk.org Mon May 13 12:48:14 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 13 May 2024 12:48:14 GMT Subject: [jdk17u-dev] RFR: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used [v4] In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 15:54:17 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439). >> >> Patch is not clean. Test won't build in 17 because it can't find ```import jdk.internal.util.OperatingSystem```. >> >> This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485). >> >> I've worked around that by removing the dependency to that utility function and checking the operating system with ```test/lib/jdk/test/lib/Platform.java```. >> >> Testing: >> - [x] Modified test case passes >> >> Thanks! > > Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision: > > Using test/lib/jdk/test/lib/Platform.java instead of System.getProperty LGTM. Thanks for backporting it! ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2321#pullrequestreview-2052597624 From mdoerr at openjdk.org Mon May 13 12:54:37 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 13 May 2024 12:54:37 GMT Subject: [jdk11u-dev] RFR: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used [v4] In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 16:07:23 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439). >> >> Patch is not clean. Test won't build in 11 because it can't find ```import jdk.internal.util.OperatingSystem```. >> >> This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485). >> >> I've worked around that by removing the dependency to that utility function and checking the operating system with ```test/lib/jdk/test/lib/Platform.java```. >> >> Testing: >> - [x] Modified test case passes >> >> Thanks! > > Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision: > > Using test/lib/jdk/test/lib/Platform.java instead of System.getProperty LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2679#pullrequestreview-2052611133 From clanger at openjdk.org Mon May 13 13:02:12 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 13 May 2024 13:02:12 GMT Subject: [jdk17u-dev] RFR: 8330523: Reduce runtime and improve efficiency of KeepAliveTest Message-ID: Backport this test improvement. I only had to do minor resolvation. ------------- Commit messages: - Backport c12dfc3571235bb57b2287e06c0cebb764f47a9a Changes: https://git.openjdk.org/jdk17u-dev/pull/2463/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2463&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330523 Stats: 1230 lines in 1 file changed: 75 ins; 1012 del; 143 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2463.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2463/head:pull/2463 PR: https://git.openjdk.org/jdk17u-dev/pull/2463 From clanger at openjdk.org Mon May 13 13:03:17 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 13 May 2024 13:03:17 GMT Subject: [jdk17u-dev] RFR: 8330815: Use pattern matching for instanceof in KeepAliveCache Message-ID: Nearly clean backport from 21u-dev, only copyright conflicts. Will mark as clean. ------------- Commit messages: - Backport ddecbe52018fdb7556b04b20e8529eb430d3aa75 Changes: https://git.openjdk.org/jdk17u-dev/pull/2464/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2464&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330815 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2464.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2464/head:pull/2464 PR: https://git.openjdk.org/jdk17u-dev/pull/2464 From syan at openjdk.org Mon May 13 13:12:35 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 13:12:35 GMT Subject: [jdk11u-dev] RFR: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c Message-ID: <0eSK5ocjyerxsBrXiW1q3tUKbTwRFoVzB_FdgqUOhM4=.40028621-3da5-49de-bd20-56a256089ee6@github.com> Hi, This is backport of [JDK-8293887](https://bugs.openjdk.org/browse/JDK-8293887). It's not clean backport, because the file `make/lib/CoreLibraries.gmk` has been moved to `make/modules/java.base/lib/CoreLibraries.gmk` Testing list: - [ ] linux x64 gcc10 - [ ] linux x64 gcc13 - [ ] linux aarch64 gcc10 - [ ] linux aarch64 gcc13 - [ ] linux riscv64 gcc13 ------------- Commit messages: - Backport 02ea338177df781912dc782e32200eaf4731a0da Changes: https://git.openjdk.org/jdk11u-dev/pull/2709/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2709&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293887 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2709.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2709/head:pull/2709 PR: https://git.openjdk.org/jdk11u-dev/pull/2709 From amitkumar at openjdk.org Mon May 13 13:56:16 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 13 May 2024 13:56:16 GMT Subject: [jdk17u-dev] RFR: 8307423: [s390x] Represent Registers as values [v2] In-Reply-To: References: Message-ID: On Mon, 13 May 2024 11:47:42 GMT, Amit Kumar wrote: >> Hi all, >> >> This pull request contains a backport of commit [8bbd264c](https://github.com/openjdk/jdk/commit/8bbd264c6e4b4045a218f11ae6b5b4f395bc2aa9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Amit Kumar on 8 May 2023 and was reviewed by Martin Doerr and Lutz Schmidt. >> >> Thanks! > > Amit Kumar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: > > - fixes merge conflict in vmStructs.cpp > - removes register_definitions_s390 & updates vmStructs > - Merge branch 'openjdk:master' into backport-offamitkumar-8bbd264c > - extra space > - update > - Backport 8bbd264c6e4b4045a218f11ae6b5b4f395bc2aa9 I ran tier1 test again after the code change, on fastdebug build. Result is good there and GHA also looks good. Thanks @RealLucy for review and Martin in resolving merge conflict :-) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2453#issuecomment-2107641058 From amitkumar at openjdk.org Mon May 13 14:30:06 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 13 May 2024 14:30:06 GMT Subject: [jdk17u-dev] Integrated: 8307423: [s390x] Represent Registers as values In-Reply-To: References: Message-ID: <2wTbCzgmcNqdM8g94rgRyqGowpYJ4fl3Oi2To0ZN-1E=.01483bf6-74c0-4d1b-aac6-44c69ceff8ae@github.com> On Wed, 8 May 2024 14:30:21 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [8bbd264c](https://github.com/openjdk/jdk/commit/8bbd264c6e4b4045a218f11ae6b5b4f395bc2aa9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 8 May 2023 and was reviewed by Martin Doerr and Lutz Schmidt. > > Thanks! This pull request has now been integrated. Changeset: f789e384 Author: Amit Kumar Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/f789e384e55feaf10a08846e1f667c97367d317b Stats: 518 lines in 10 files changed: 83 ins; 261 del; 174 mod 8307423: [s390x] Represent Registers as values Reviewed-by: lucy Backport-of: 8bbd264c6e4b4045a218f11ae6b5b4f395bc2aa9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2453 From amitkumar at openjdk.org Mon May 13 14:54:27 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 13 May 2024 14:54:27 GMT Subject: [jdk11u-dev] RFR: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space Message-ID: Hi all, This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. Thanks! ------------- Commit messages: - Backport d5f3d5c8cc347ae384dea25b1a55ed57204d1af3 Changes: https://git.openjdk.org/jdk11u-dev/pull/2704/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2704&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326201 Stats: 6 lines in 2 files changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2704.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2704/head:pull/2704 PR: https://git.openjdk.org/jdk11u-dev/pull/2704 From amitkumar at openjdk.org Mon May 13 14:54:27 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Mon, 13 May 2024 14:54:27 GMT Subject: [jdk11u-dev] RFR: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: On Thu, 9 May 2024 06:16:16 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. > > Thanks! I performed build tier1 test on fastdebug-vm. Didn't see any new failure appearing. @RealLucy would you please review this, This time we will end backporting saga for this issue ;-) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2704#issuecomment-2107844474 From jkratochvil at openjdk.org Mon May 13 15:02:58 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Mon, 13 May 2024 15:02:58 GMT Subject: [jdk21u-dev] RFR: 8324243: Compilation failures in java.desktop module with gcc 14 Message-ID: <4YR8gxLaYwgKPBg2auSeHV8uwS-99KRizsqLxYWU7TU=.96b556cc-3b7a-4a24-ac7c-29950b5b38bd@github.com> It is needed to build OpenJDK-21 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk21u-dev/pull/564)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk21u-dev/pull/565)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) (this [backport](https://github.com/openjdk/jdk21u-dev/pull/566)). Git cherry-pick was clean. ------------- Commit messages: - 8324243: Compilation failures in java.desktop module with gcc 14 Changes: https://git.openjdk.org/jdk21u-dev/pull/566/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=566&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324243 Stats: 6 lines in 4 files changed: 2 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/566.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/566/head:pull/566 PR: https://git.openjdk.org/jdk21u-dev/pull/566 From jkratochvil at openjdk.org Mon May 13 15:03:03 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Mon, 13 May 2024 15:03:03 GMT Subject: [jdk21u-dev] RFR: 8331352: error: template-id not allowed for constructor/destructor in C++20 Message-ID: It is needed to build OpenJDK-21 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk21u-dev/pull/564)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) (this [backport](https://github.com/openjdk/jdk21u-dev/pull/565)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) ([backport](https://github.com/openjdk/jdk21u-dev/pull/566)). Git cherry-pick was clean. ------------- Commit messages: - 8331352: error: template-id not allowed for constructor/destructor in C++20 Changes: https://git.openjdk.org/jdk21u-dev/pull/565/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=565&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331352 Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/565.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/565/head:pull/565 PR: https://git.openjdk.org/jdk21u-dev/pull/565 From jkratochvil at openjdk.org Mon May 13 15:02:44 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Mon, 13 May 2024 15:02:44 GMT Subject: [jdk21u-dev] RFR: 8328997: Remove unnecessary template parameter lists in GrowableArray Message-ID: It is needed to build OpenJDK-21 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) (this [backport](https://github.com/openjdk/jdk21u-dev/pull/564)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk21u-dev/pull/565)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) ([backport](https://github.com/openjdk/jdk21u-dev/pull/566)). Git cherry-pick was not clean but it was a non-issue. ------------- Commit messages: - 8328997: Remove unnecessary template parameter lists in GrowableArray Changes: https://git.openjdk.org/jdk21u-dev/pull/564/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=564&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328997 Stats: 16 lines in 1 file changed: 0 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/564.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/564/head:pull/564 PR: https://git.openjdk.org/jdk21u-dev/pull/564 From zgu at openjdk.org Mon May 13 15:11:28 2024 From: zgu at openjdk.org (Zhengyu Gu) Date: Mon, 13 May 2024 15:11:28 GMT Subject: [jdk22u] RFR: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx Message-ID: Clean backport ------------- Commit messages: - Backport aca1e8365bf0f64bf18caf798bbca1d25b3c4117 Changes: https://git.openjdk.org/jdk22u/pull/200/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=200&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329223 Stats: 11 lines in 1 file changed: 6 ins; 3 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/200.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/200/head:pull/200 PR: https://git.openjdk.org/jdk22u/pull/200 From rmarchenko at openjdk.org Mon May 13 17:03:19 2024 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Mon, 13 May 2024 17:03:19 GMT Subject: [jdk17u-dev] Integrated: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect In-Reply-To: References: Message-ID: On Fri, 8 Mar 2024 06:47:16 GMT, Roman Marchenko wrote: > This is a backport of JDK-8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect. > > Backporting this because this issue can be reproduced in JDK17 as well. > > The backport isn't clean: > 1. Resolved a conflict in `src/hotspot/share/prims/jvmtiEventController.cpp` with an empty line. > 2. Removed files as VThreads are not implemented in jdk17: > - `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/libVThreadTest.cpp` > - `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/VThreadTest.java` > 3. Added new test: > - `test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/Test.java` > - `test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/libextcallback.c` > - `test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/loadClass/Test2.java` > > Actually, backporting the fix only. > The new test fails without the fix, and successfully passes with the fix. This pull request has now been integrated. Changeset: e2791f33 Author: Roman Marchenko Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/e2791f3304768729fbc665886f9c406fb3d1bf39 Stats: 166 lines in 4 files changed: 164 ins; 0 del; 2 mod 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect Reviewed-by: phh Backport-of: a0cccb54791d954bf08da5aac9b9794e370617c8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2276 From lucy at openjdk.org Mon May 13 17:52:26 2024 From: lucy at openjdk.org (Lutz Schmidt) Date: Mon, 13 May 2024 17:52:26 GMT Subject: [jdk11u-dev] RFR: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: On Thu, 9 May 2024 06:16:16 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. > > Thanks! Looks good. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2704#pullrequestreview-2053349047 From duke at openjdk.org Mon May 13 18:14:32 2024 From: duke at openjdk.org (Robert Toyonaga) Date: Mon, 13 May 2024 18:14:32 GMT Subject: [jdk11u-dev] RFR: 8326521: JFR: CompilerPhase event test fails on windows 32 bit Message-ID: This is a backport of https://github.com/openjdk/jdk/commit/96530bcc07514c3eda40fd6ffa74f197fe541dea On some systems (such as windows 32 bit) Hotspot only uses the C1 compiler in by design. The CompilerPhase JFR events are only emitted from C2 code. So the test TestCompilerPhase fails on some systems because it cannot generate the necessary CompilerPhase JFR events . This backport prevents `NeverActAsServerClassMachine` from being set during the test TestCompilerPhase, so that it isn't restricted to C1. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3045). Testing: running test/jdk/jdk/jfr/event/compiler/TestCompilerPhase.java test passes. ------------- Commit messages: - Backport 96530bcc07514c3eda40fd6ffa74f197fe541dea Changes: https://git.openjdk.org/jdk11u-dev/pull/2710/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2710&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326521 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2710.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2710/head:pull/2710 PR: https://git.openjdk.org/jdk11u-dev/pull/2710 From syan at openjdk.org Mon May 13 19:58:03 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 19:58:03 GMT Subject: [jdk11u-dev] Integrated: 8328825: Google CAInterop test failures In-Reply-To: References: Message-ID: On Tue, 26 Mar 2024 01:21:50 GMT, SendaoYan wrote: > Hi, > > Clean backport to fix some of the current failures in CAInterop test. > > Additional testing: > > - [x] Affected subtests are now passing > > ![image](https://github.com/openjdk/jdk11u-dev/assets/24123821/f08fa697-41f6-4365-b0f5-64d8df5f114f) > > Thanks, > -sendao This pull request has now been integrated. Changeset: 4714685d Author: SendaoYan Committer: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/4714685d6e4bfda3573ae82fa4bfc687460f4b75 Stats: 10 lines in 1 file changed: 0 ins; 5 del; 5 mod 8328825: Google CAInterop test failures Backport-of: 70a15c73638f45b9ed629abc0ea2d86a324bf624 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2624 From mdoerr at openjdk.org Mon May 13 20:06:12 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 13 May 2024 20:06:12 GMT Subject: [jdk17u-dev] RFR: 8302907: [PPC64] Use more constexpr in class Register In-Reply-To: <8Vho7Uljh_bLxfLCftow2j5e4PivQaXmQZ0mB8N4mG8=.341f7dae-c176-4425-8d71-4acf1a48d3ec@github.com> References: <8Vho7Uljh_bLxfLCftow2j5e4PivQaXmQZ0mB8N4mG8=.341f7dae-c176-4425-8d71-4acf1a48d3ec@github.com> Message-ID: On Mon, 13 May 2024 10:46:42 GMT, Martin Doerr wrote: > Clean backport of [JDK-8302907](https://bugs.openjdk.org/browse/JDK-8302907). GHA failure is unrelated. This PR only touches one PPC64 file. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2461#issuecomment-2108696046 From mdoerr at openjdk.org Mon May 13 20:33:08 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 13 May 2024 20:33:08 GMT Subject: [jdk11u-dev] RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" [v2] In-Reply-To: References: Message-ID: On Mon, 13 May 2024 09:38:10 GMT, SendaoYan wrote: >> Hi, >> >> Backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). >> >> The origin PR use `int nextInt(int origin, int bound)` [link](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html#nextInt(int,int)) , but the jdk11 do not have this API. So I change `int nextInt(int origin, int bound)` to `nextInt(bound - origin) + origin` [link](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/Random.html#nextInt(int)). >> >> Only change the testcase, the change has been verified, the risk is low. >> >> ![image](https://github.com/openjdk/jdk11u-dev/assets/24123821/63c82beb-1c90-45b0-b8b7-6419cf111252) >> >> Thanks, >> -sendao > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8321925 > - Backport b6233c3de773fb57b23704f1fec05d8b2d9c11c0 > > Signed-off-by: sendaoYan LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2631#pullrequestreview-2053740050 From mdoerr at openjdk.org Mon May 13 20:37:42 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 13 May 2024 20:37:42 GMT Subject: [jdk21u-dev] RFR: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment In-Reply-To: <8A1BNN5ZXTXFpI4cZh-25KKo_rEx7FJLl34OUQS7HTk=.938f856d-3520-4761-8491-76eb9e7f2025@github.com> References: <8A1BNN5ZXTXFpI4cZh-25KKo_rEx7FJLl34OUQS7HTk=.938f856d-3520-4761-8491-76eb9e7f2025@github.com> Message-ID: On Mon, 25 Mar 2024 11:54:39 GMT, Per Minborg wrote: > Hi all, > > This pull request contains a backport of commit [93579c29](https://github.com/openjdk/jdk/commit/93579c29e3ba60a8bc16d712e7ffc733f324a223) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Per Minborg on 25 Mar 2024 and was reviewed by Maurizio Cimadamore. > > Thanks! Ok, this is basically a clean backport + Copyright header fix. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/404#pullrequestreview-2053758603 From syan at openjdk.org Mon May 13 20:37:47 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 20:37:47 GMT Subject: [jdk21u-dev] Integrated: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" In-Reply-To: References: Message-ID: On Thu, 28 Mar 2024 02:45:17 GMT, SendaoYan wrote: > Hi, > > Clean backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). Only change the testcase, the change has been verified, the risk is low. > > ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/a971b851-bc31-407a-b66e-0d8189deee9f) > > Thanks, > -sendao This pull request has now been integrated. Changeset: bddd6a7f Author: SendaoYan Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/bddd6a7f61ba99fdebbb9f6f3aa275923fe53bc3 Stats: 23 lines in 1 file changed: 13 ins; 0 del; 10 mod 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" Backport-of: b6233c3de773fb57b23704f1fec05d8b2d9c11c0 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/419 From syan at openjdk.org Mon May 13 20:37:49 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 13 May 2024 20:37:49 GMT Subject: [jdk21u-dev] Integrated: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) In-Reply-To: References: Message-ID: On Wed, 21 Feb 2024 12:26:40 GMT, SendaoYan wrote: > Hi, > > Clean backport of [JDK-8311964](https://github.com/openjdk/jdk/pull/14942). Backport has been verified as bellow. Only change the testcases, the risk is low. > > > There 3 testcases run complaint "Unrecognized VM option" with linux-x86-client-release jdk before this PR. LoopUnswitching, OptimizeFill and StressCCP are all C2 flags. > test command: > > rm -rf tmp/ ; jtreg -v:fail,error -nr -w tmp -jdk:build/linux-x86-client-release/images/jdk/ test/hotspot/jtreg/compiler/loopopts/TestBackedgeLoadArrayFillMain.java test/hotspot/jtreg/compiler/loopopts/TestInfiniteLoopWithUnmergedBackedgesMain.java test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckCmpUOverflowVsSub.java 2>&1 | grep "Unrecognized VM option" > > ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/f4bd5f9e-cefd-4e28-9a19-2f85d59b4dfe) > > > After this PR, there 3 testcases won't be selected when the test jdk is linux-x86-client. > ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/eba2a2b2-e164-452b-b7b2-cf4953cec7d4) > > > Thanks, > -sendao This pull request has now been integrated. Changeset: fbb0f4c4 Author: SendaoYan Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/fbb0f4c46446ab50a632b7d73244e5c334eb60c5 Stats: 3 lines in 3 files changed: 3 ins; 0 del; 0 mod 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) Backport-of: 024133b089d911dcc3ea70dfdaa6b150b14a9eb4 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/279 From mdoerr at openjdk.org Mon May 13 20:39:11 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 13 May 2024 20:39:11 GMT Subject: [jdk21u-dev] RFR: 8330027: Identity hashes of archived objects must be based on a reproducible random seed In-Reply-To: References: Message-ID: On Fri, 10 May 2024 14:58:37 GMT, Thomas Stuefe wrote: > This fixes an issue with CDS archive reproducibility that can happen under rare circumstances. See original JBS issue for details. > > I had to manually resolve the hunk in src/hotspot/share/cds/heapShared.cpp because both > > 8251330: Reorder CDS archived heap to speed up relocation > 8329431: Improve speed of writing CDS heap objects > were missing. > > I also had to change `CDSConfig::is_dumping_static_archive()` - which only exists in JDK 22 and later - to the technically equal `DumpSharedSpaces`. LGTM. I suggest removing the empty line, too. src/hotspot/share/cds/heapShared.cpp line 279: > 277: count_allocation(obj->size()); > 278: ArchiveHeapWriter::add_source_obj(obj); > 279: Original change removes the empty line here. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/562#pullrequestreview-2053771991 PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/562#discussion_r1599052253 From jkratochvil at openjdk.org Mon May 13 20:49:12 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Mon, 13 May 2024 20:49:12 GMT Subject: [jdk22u] Integrated: 8328997: Remove unnecessary template parameter lists in GrowableArray In-Reply-To: References: Message-ID: On Sun, 12 May 2024 14:06:51 GMT, Jan Kratochvil wrote: > It is needed to build OpenJDK-22 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). > It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) (this [backport](https://github.com/openjdk/jdk22u/pull/197)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk22u/pull/198)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) ([backport](https://github.com/openjdk/jdk22u/pull/199)). > Git cherry-pick was not clean but it was a non-issue. This pull request has now been integrated. Changeset: ccef462e Author: Jan Kratochvil Committer: Martin Doerr URL: https://git.openjdk.org/jdk22u/commit/ccef462e5742ec2bbe015f3a90e5628b5251d9c9 Stats: 16 lines in 1 file changed: 0 ins; 0 del; 16 mod 8328997: Remove unnecessary template parameter lists in GrowableArray Backport-of: 3d2283800acee58dbf046c8b401a5a144ab65ed1 ------------- PR: https://git.openjdk.org/jdk22u/pull/197 From jkratochvil at openjdk.org Mon May 13 20:50:07 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Mon, 13 May 2024 20:50:07 GMT Subject: [jdk22u] Integrated: 8331352: error: template-id not allowed for constructor/destructor in C++20 In-Reply-To: <6IxK3y3YUu5gyL_tSMIYKmdYtCbyAYrUhpbzP5ceGRk=.e7d265d0-4def-4ef2-9910-da4430ede614@github.com> References: <6IxK3y3YUu5gyL_tSMIYKmdYtCbyAYrUhpbzP5ceGRk=.e7d265d0-4def-4ef2-9910-da4430ede614@github.com> Message-ID: <88Oq-RqNOTsI4cV297BTeD9em92vLQPnkO79-Wlm6jE=.5df85f5b-8b64-4966-b21f-046561be5fc9@github.com> On Sun, 12 May 2024 14:07:39 GMT, Jan Kratochvil wrote: > It is needed to build OpenJDK-22 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). > It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk22u/pull/197)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) (this [backport](https://github.com/openjdk/jdk22u/pull/198)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) ([backport](https://github.com/openjdk/jdk22u/pull/199)). > Git cherry-pick was clean. This pull request has now been integrated. Changeset: 2ec7dbf1 Author: Jan Kratochvil Committer: Martin Doerr URL: https://git.openjdk.org/jdk22u/commit/2ec7dbf18e7d6bd746a82d61cd787d6344d3314e Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod 8331352: error: template-id not allowed for constructor/destructor in C++20 Backport-of: 45792c5829fb1d5ee016c4a1fd6badb5d2b4239c ------------- PR: https://git.openjdk.org/jdk22u/pull/198 From jkratochvil at openjdk.org Mon May 13 20:50:07 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Mon, 13 May 2024 20:50:07 GMT Subject: [jdk22u] Integrated: 8324243: Compilation failures in java.desktop module with gcc 14 In-Reply-To: References: Message-ID: On Sun, 12 May 2024 14:08:16 GMT, Jan Kratochvil wrote: > It is needed to build OpenJDK-22 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). > It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk22u/pull/197)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk22u/pull/198)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) (this [backport](https://github.com/openjdk/jdk22u/pull/199)). > Git cherry-pick was clean. This pull request has now been integrated. Changeset: 9486b7c2 Author: Jan Kratochvil Committer: Martin Doerr URL: https://git.openjdk.org/jdk22u/commit/9486b7c2303acd07b304a8bb9169d9e7d0acbf48 Stats: 6 lines in 4 files changed: 2 ins; 0 del; 4 mod 8324243: Compilation failures in java.desktop module with gcc 14 Backport-of: 8e5f6ddb68572c0cc8b6e256e423706f6f7cec94 ------------- PR: https://git.openjdk.org/jdk22u/pull/199 From mdoerr at openjdk.org Mon May 13 21:07:10 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 13 May 2024 21:07:10 GMT Subject: [jdk17u-dev] RFR: 8305819: LogConfigurationTest intermittently fails on AArch64 In-Reply-To: References: Message-ID: <4thky77GQU_pK83KLiaVcWtMyVCE-iaw-T3LBxy7fr4=.81fc6c24-1b46-4982-abe8-b330ea1cef2e@github.com> On Mon, 13 May 2024 10:20:31 GMT, Liang Mao wrote: > Hi all, > > This pull request contains a backport of commit [911cc7cb](https://github.com/openjdk/jdk/commit/911cc7cb07ed44b24b4c20977d7d6e475bd1b234) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > > It fixed a logging crash due to arm weak memory model. > > The commit being backported was authored by gaogao-mem on 15 May 2023 and was reviewed by Andrew Haley, David Holmes and Xin Liu. > > The conflicts only come from the difference of "NULL" and "nullptr". > > Additional testing: > - [x] Verified the test case in original PR. > > Thanks! LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2460#pullrequestreview-2053825537 From syan at openjdk.org Tue May 14 01:57:29 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 14 May 2024 01:57:29 GMT Subject: [jdk22u] RFR: 8322078: ZipSourceCache.testKeySourceMapping() test fails with The process cannot access the file because it is being used by another process Message-ID: Hi all, This is clean backport of [JDK-8322078](https://bugs.openjdk.org/browse/JDK-8322078). The risk is low. ------------- Commit messages: - Backport f6fe39ff1168d27f4d0ea3e4c7f3f17ecae9e1ab Changes: https://git.openjdk.org/jdk22u/pull/201/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=201&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322078 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/201.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/201/head:pull/201 PR: https://git.openjdk.org/jdk22u/pull/201 From syan at openjdk.org Tue May 14 02:29:07 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 14 May 2024 02:29:07 GMT Subject: [jdk22u] RFR: 8331331: :tier1 target explanation in doc/testing.md is incorrect [v2] In-Reply-To: <7MD4Yb43D0eENPGHBbuQ2EKDVnLmeVugx-D9MfIkSFE=.555fbcd8-0518-43fc-a390-93981caa5e8c@github.com> References: <7MD4Yb43D0eENPGHBbuQ2EKDVnLmeVugx-D9MfIkSFE=.555fbcd8-0518-43fc-a390-93981caa5e8c@github.com> Message-ID: On Mon, 13 May 2024 09:44:40 GMT, SendaoYan wrote: >> Hi, >> This is clean backport of [JDK-8331331](https://bugs.openjdk.org/browse/JDK-8331331), fixed the incorrect explanation :tier1 target in doc/testing.md. No risk. > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-04271dfe > - Backport 04271dfe7a262379944e2a2cf83a98a3a1b78a74 The GHA test [runner](https://github.com/openjdk-bots/jdk22u/actions/runs/9060702404/job/24896412402) complains `java/util/zip/ZipFile/ZipSourceCache.java` intermittent fails on windows-x64. This failure unreleated to this PR. I creat a new [PR](https://github.com/openjdk/jdk22u/pull/201) to fix this intermittent failure. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/183#issuecomment-2109156209 From syan at openjdk.org Tue May 14 02:44:12 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 14 May 2024 02:44:12 GMT Subject: [jdk11u-dev] RFR: 8328825: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: On Mon, 13 May 2024 09:30:31 GMT, SendaoYan wrote: >> Hi, >> >> Clean backport to fix some of the current failures in CAInterop test. >> >> Additional testing: >> >> - [x] Affected subtests are now passing >> >> ![image](https://github.com/openjdk/jdk11u-dev/assets/24123821/f08fa697-41f6-4365-b0f5-64d8df5f114f) >> >> Thanks, >> -sendao > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-70a15c73 > - Backport 70a15c73638f45b9ed629abc0ea2d86a324bf624 > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2624#issuecomment-2109169918 From syan at openjdk.org Tue May 14 02:45:09 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 14 May 2024 02:45:09 GMT Subject: [jdk21u-dev] RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" [v2] In-Reply-To: References: Message-ID: On Mon, 13 May 2024 09:32:49 GMT, SendaoYan wrote: >> Hi, >> >> Clean backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). Only change the testcase, the change has been verified, the risk is low. >> >> ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/a971b851-bc31-407a-b66e-0d8189deee9f) >> >> Thanks, >> -sendao > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-b6233c3d > - Backport b6233c3de773fb57b23704f1fec05d8b2d9c11c0 > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/419#issuecomment-2109171049 From syan at openjdk.org Tue May 14 02:46:18 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 14 May 2024 02:46:18 GMT Subject: [jdk21u-dev] RFR: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) [v2] In-Reply-To: References: Message-ID: <3z2Z3OyttrkvSalxtoAamlbH7I9fSuj6TDoQo8ryCQ4=.4f8fbfa1-0479-465d-98af-da4593da48c6@github.com> On Mon, 13 May 2024 09:08:40 GMT, SendaoYan wrote: >> Hi, >> >> Clean backport of [JDK-8311964](https://github.com/openjdk/jdk/pull/14942). Backport has been verified as bellow. Only change the testcases, the risk is low. >> >> >> There 3 testcases run complaint "Unrecognized VM option" with linux-x86-client-release jdk before this PR. LoopUnswitching, OptimizeFill and StressCCP are all C2 flags. >> test command: >> >> rm -rf tmp/ ; jtreg -v:fail,error -nr -w tmp -jdk:build/linux-x86-client-release/images/jdk/ test/hotspot/jtreg/compiler/loopopts/TestBackedgeLoadArrayFillMain.java test/hotspot/jtreg/compiler/loopopts/TestInfiniteLoopWithUnmergedBackedgesMain.java test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckCmpUOverflowVsSub.java 2>&1 | grep "Unrecognized VM option" >> >> ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/f4bd5f9e-cefd-4e28-9a19-2f85d59b4dfe) >> >> >> After this PR, there 3 testcases won't be selected when the test jdk is linux-x86-client. >> ![image](https://github.com/openjdk/jdk21u-dev/assets/24123821/eba2a2b2-e164-452b-b7b2-cf4953cec7d4) >> >> >> Thanks, >> -sendao > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-024133b0 > - Backport 024133b089d911dcc3ea70dfdaa6b150b14a9eb4 > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/279#issuecomment-2109171681 From syan at openjdk.org Tue May 14 02:47:14 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 14 May 2024 02:47:14 GMT Subject: [jdk11u-dev] RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" [v2] In-Reply-To: References: Message-ID: On Mon, 13 May 2024 20:24:37 GMT, Martin Doerr wrote: > LGTM. Thanks for the review. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2631#issuecomment-2109172702 From andrewlu at openjdk.org Tue May 14 03:19:18 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 14 May 2024 03:19:18 GMT Subject: [jdk17u-dev] RFR: 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed out Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport b9df827adc92cb1fc65f6b1efdf82dcae00a4e2d Changes: https://git.openjdk.org/jdk17u-dev/pull/2465/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2465&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309871 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2465.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2465/head:pull/2465 PR: https://git.openjdk.org/jdk17u-dev/pull/2465 From andrewlu at openjdk.org Tue May 14 03:20:18 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 14 May 2024 03:20:18 GMT Subject: [jdk21u-dev] RFR: 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed out Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport b9df827adc92cb1fc65f6b1efdf82dcae00a4e2d Changes: https://git.openjdk.org/jdk21u-dev/pull/568/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=568&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309871 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/568.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/568/head:pull/568 PR: https://git.openjdk.org/jdk21u-dev/pull/568 From jkratochvil at openjdk.org Tue May 14 05:17:11 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Tue, 14 May 2024 05:17:11 GMT Subject: [jdk17u-dev] RFR: 8328997: Remove unnecessary template parameter lists in GrowableArray Message-ID: <3ZSIQ-8yKrtnA6hgvKM4r_nA3BRkit14PejA7KtHrqA=.d5fea582-1122-41e8-8c3f-1e79d94f2455@github.com> It is needed to build OpenJDK-17 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) (this [backport](https://github.com/openjdk/jdk17u-dev/pull/2466)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2467)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2468)). Git cherry-pick was not clean but it was easy to apply. ------------- Commit messages: - 8328997: Remove unnecessary template parameter lists in GrowableArray Changes: https://git.openjdk.org/jdk17u-dev/pull/2466/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2466&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328997 Stats: 13 lines in 1 file changed: 0 ins; 0 del; 13 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2466.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2466/head:pull/2466 PR: https://git.openjdk.org/jdk17u-dev/pull/2466 From jkratochvil at openjdk.org Tue May 14 05:19:09 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Tue, 14 May 2024 05:19:09 GMT Subject: [jdk17u-dev] RFR: 8331352: error: template-id not allowed for constructor/destructor in C++20 Message-ID: It is needed to build OpenJDK-17 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2466)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) (this [backport](https://github.com/openjdk/jdk17u-dev/pull/2467)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2468)). Git cherry-pick was not clean but it was easy to apply. ------------- Commit messages: - 8331352: error: template-id not allowed for constructor/destructor in C++20 Changes: https://git.openjdk.org/jdk17u-dev/pull/2467/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2467&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331352 Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2467.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2467/head:pull/2467 PR: https://git.openjdk.org/jdk17u-dev/pull/2467 From jkratochvil at openjdk.org Tue May 14 05:20:32 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Tue, 14 May 2024 05:20:32 GMT Subject: [jdk17u-dev] RFR: 8324243: Compilation failures in java.desktop module with gcc 14 Message-ID: It is needed to build OpenJDK-17 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2466)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2467)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) (this [backport](https://github.com/openjdk/jdk17u-dev/pull/2468)). Git cherry-pick was not clean but it was easy to apply. ------------- Commit messages: - 8324243: Compilation failures in java.desktop module with gcc 14 Changes: https://git.openjdk.org/jdk17u-dev/pull/2468/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2468&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324243 Stats: 5 lines in 4 files changed: 1 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2468.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2468/head:pull/2468 PR: https://git.openjdk.org/jdk17u-dev/pull/2468 From syan at openjdk.org Tue May 14 06:56:29 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 14 May 2024 06:56:29 GMT Subject: [jdk21u-dev] RFR: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all Message-ID: Hi all, This is backport of [JDK-8331466](https://bugs.openjdk.org/browse/JDK-8331466). This backport is not clean because the line number of `8227120` has changed from 127 to 137. Only change the Problemlist.txt, the risk is low. Thanks sendao ------------- Commit messages: - Backport 440782e0160f867f08afbec0abf48d557a522c72 Changes: https://git.openjdk.org/jdk21u-dev/pull/569/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=569&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331466 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/569.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/569/head:pull/569 PR: https://git.openjdk.org/jdk21u-dev/pull/569 From syan at openjdk.org Tue May 14 07:05:10 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 14 May 2024 07:05:10 GMT Subject: [jdk17u-dev] RFR: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all Message-ID: <3Qw1EXiVffglLZU5_ME7Cv3tjfmXCCN8G1GPbgXg8sI=.bf0d1b6d-ef0b-46d9-adf0-2afb8306fc73@github.com> Hi all, This is backport of [JDK-8331466](https://bugs.openjdk.org/browse/JDK-8331466). This backport is not clean because the line number of 8227120 has changed from 115 to 137, and it's a previous problemlist for `aix-ppc64`. Only change the Problemlist.txt, the risk is low. Thanks sendao ------------- Commit messages: - Backport 440782e0160f867f08afbec0abf48d557a522c72 Changes: https://git.openjdk.org/jdk17u-dev/pull/2469/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2469&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331466 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2469.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2469/head:pull/2469 PR: https://git.openjdk.org/jdk17u-dev/pull/2469 From stuefe at openjdk.org Tue May 14 07:23:12 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 14 May 2024 07:23:12 GMT Subject: [jdk22u] RFR: 8330027: Identity hashes of archived objects must be based on a reproducible random seed In-Reply-To: References: Message-ID: On Fri, 10 May 2024 10:47:35 GMT, Thomas Stuefe wrote: > This fixes an issue with CDS archive reproducibility that can happen under rare circumstances. See original JBS issue for details. > > I had to manually resolve the hunk in src/hotspot/share/cds/heapShared.cpp because both > - 8251330: Reorder CDS archived heap to speed up relocation > - 8329431: Improve speed of writing CDS heap objects > were missing. > > Resolve was trivial. Got approval. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/194#issuecomment-2109459466 From stuefe at openjdk.org Tue May 14 07:23:30 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 14 May 2024 07:23:30 GMT Subject: [jdk21u-dev] RFR: 8330027: Identity hashes of archived objects must be based on a reproducible random seed [v2] In-Reply-To: References: Message-ID: On Mon, 13 May 2024 20:36:50 GMT, Martin Doerr wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision: >> >> Update heapShared.cpp > > LGTM. I suggest removing the empty line, too. Thanks @TheRealMDoerr ! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/562#issuecomment-2109457469 From stuefe at openjdk.org Tue May 14 07:23:30 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 14 May 2024 07:23:30 GMT Subject: [jdk21u-dev] RFR: 8330027: Identity hashes of archived objects must be based on a reproducible random seed [v2] In-Reply-To: References: Message-ID: > This fixes an issue with CDS archive reproducibility that can happen under rare circumstances. See original JBS issue for details. > > I had to manually resolve the hunk in src/hotspot/share/cds/heapShared.cpp because both > > 8251330: Reorder CDS archived heap to speed up relocation > 8329431: Improve speed of writing CDS heap objects > were missing. > > I also had to change `CDSConfig::is_dumping_static_archive()` - which only exists in JDK 22 and later - to the technically equal `DumpSharedSpaces`. Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision: Update heapShared.cpp ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/562/files - new: https://git.openjdk.org/jdk21u-dev/pull/562/files/155bb08c..a2f6ffc5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=562&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=562&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/562.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/562/head:pull/562 PR: https://git.openjdk.org/jdk21u-dev/pull/562 From stuefe at openjdk.org Tue May 14 07:23:12 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 14 May 2024 07:23:12 GMT Subject: [jdk22u] Integrated: 8330027: Identity hashes of archived objects must be based on a reproducible random seed In-Reply-To: References: Message-ID: <2NfLB87AzdTzuE7DO92EZr1kc36wTp25oCfu8IzQ-sU=.c4f63069-115d-4f0f-9c45-c6a7480eed40@github.com> On Fri, 10 May 2024 10:47:35 GMT, Thomas Stuefe wrote: > This fixes an issue with CDS archive reproducibility that can happen under rare circumstances. See original JBS issue for details. > > I had to manually resolve the hunk in src/hotspot/share/cds/heapShared.cpp because both > - 8251330: Reorder CDS archived heap to speed up relocation > - 8329431: Improve speed of writing CDS heap objects > were missing. > > Resolve was trivial. This pull request has now been integrated. Changeset: 9b3187f8 Author: Thomas Stuefe URL: https://git.openjdk.org/jdk22u/commit/9b3187f85e375d289c183b010347533ec992224a Stats: 14 lines in 3 files changed: 4 ins; 7 del; 3 mod 8330027: Identity hashes of archived objects must be based on a reproducible random seed Reviewed-by: phh Backport-of: 9f43ce5a725b212cec0f3cd17491c4bada953676 ------------- PR: https://git.openjdk.org/jdk22u/pull/194 From stuefe at openjdk.org Tue May 14 07:25:09 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 14 May 2024 07:25:09 GMT Subject: [jdk22u] RFR: 8331344: No compiler replay file with CompilerCommand MemLimit In-Reply-To: References: Message-ID: <1Y54Q3Me376eD7o9pW78S08yFEz5uhPszgvHen0v0x0=.4e84dfd8-acd5-48aa-b265-13221e69e8de@github.com> On Thu, 9 May 2024 10:15:37 GMT, Thomas Stuefe wrote: > Hi all, > > This pull request contains a backport of commit [389f6fe9](https://github.com/openjdk/jdk/commit/389f6fe97c348e28d8573fe4754138d2a0bd6c0d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Thomas Stuefe on 2 May 2024 and was reviewed by Vladimir Kozlov and Ashutosh Mehra. > > Thanks! Got approval. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/191#issuecomment-2109463128 From stuefe at openjdk.org Tue May 14 07:25:09 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 14 May 2024 07:25:09 GMT Subject: [jdk22u] Integrated: 8331344: No compiler replay file with CompilerCommand MemLimit In-Reply-To: References: Message-ID: On Thu, 9 May 2024 10:15:37 GMT, Thomas Stuefe wrote: > Hi all, > > This pull request contains a backport of commit [389f6fe9](https://github.com/openjdk/jdk/commit/389f6fe97c348e28d8573fe4754138d2a0bd6c0d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Thomas Stuefe on 2 May 2024 and was reviewed by Vladimir Kozlov and Ashutosh Mehra. > > Thanks! This pull request has now been integrated. Changeset: 61792bc2 Author: Thomas Stuefe URL: https://git.openjdk.org/jdk22u/commit/61792bc2297444df79adef78a1e3bcafaf61e305 Stats: 29 lines in 3 files changed: 27 ins; 1 del; 1 mod 8331344: No compiler replay file with CompilerCommand MemLimit Backport-of: 389f6fe97c348e28d8573fe4754138d2a0bd6c0d ------------- PR: https://git.openjdk.org/jdk22u/pull/191 From syan at openjdk.org Tue May 14 08:17:32 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 14 May 2024 08:17:32 GMT Subject: [jdk17u-dev] RFR: 8314835: gtest wrappers should be marked as flagless Message-ID: Hi all, This is backport of [JDK-8314835](https://bugs.openjdk.org/browse/JDK-8314835), to make releated tests as flagless. The backport is not clean, because the file `test/hotspot/jtreg/gtest/NativeHeapTrimmerGtest.java` has subsequent backport [JDK-8325496](https://bugs.openjdk.org/browse/JDK-8325496) Only change the testcases, the risk is low. Thanks, -sendao ------------- Commit messages: - Backport 1ea6463fbb95258725ed4a11621ec662859a76e0 Changes: https://git.openjdk.org/jdk17u-dev/pull/2470/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2470&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314835 Stats: 7 lines in 3 files changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2470.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2470/head:pull/2470 PR: https://git.openjdk.org/jdk17u-dev/pull/2470 From andrewlu at openjdk.org Tue May 14 08:23:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 14 May 2024 08:23:06 GMT Subject: [jdk17u-dev] Integrated: 8280835: jdk/javadoc/tool/CheckManPageOptions.java depends on source hierarchy In-Reply-To: References: Message-ID: On Mon, 13 May 2024 08:25:42 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. This pull request has now been integrated. Changeset: e0dba38e Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/e0dba38e6bdcf0f9589d6bf2fa9a8ea0887696c3 Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod 8280835: jdk/javadoc/tool/CheckManPageOptions.java depends on source hierarchy Backport-of: 6d242e406539e97bdd4da82c478db901942b770f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2458 From andrewlu at openjdk.org Tue May 14 08:23:07 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 14 May 2024 08:23:07 GMT Subject: [jdk17u-dev] Integrated: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError In-Reply-To: References: Message-ID: On Mon, 13 May 2024 05:23:24 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. This pull request has now been integrated. Changeset: 8f0fa106 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/8f0fa10670c1c2e9c41cf6cd62582f1e4cb763e9 Stats: 157 lines in 4 files changed: 65 ins; 55 del; 37 mod 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError Backport-of: f12200cd11c2b689618cde1902db941ee23fbf80 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2457 From amitkumar at openjdk.org Tue May 14 08:27:09 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Tue, 14 May 2024 08:27:09 GMT Subject: [jdk11u-dev] RFR: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: On Mon, 13 May 2024 17:49:52 GMT, Lutz Schmidt wrote: >> Hi all, >> >> This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. >> >> Thanks! > > Looks good. thank you @RealLucy for the review :-) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2704#issuecomment-2109576948 From mbaesken at openjdk.org Tue May 14 08:29:13 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 14 May 2024 08:29:13 GMT Subject: [jdk22u] Integrated: 8329663: hs_err file event log entry for thread adding/removing should print current thread In-Reply-To: References: Message-ID: On Tue, 7 May 2024 07:19:09 GMT, Matthias Baesken wrote: > 8329663: hs_err file event log entry for thread adding/removing should print current thread This pull request has now been integrated. Changeset: cbfaf286 Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/cbfaf28625d1938cb2decb93a0db8b98d41a66a3 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8329663: hs_err file event log entry for thread adding/removing should print current thread Reviewed-by: stuefe Backport-of: 3ebf8c9359da2f45e4cefb7be2276d33c30979aa ------------- PR: https://git.openjdk.org/jdk22u/pull/184 From syan at openjdk.org Tue May 14 08:29:50 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 14 May 2024 08:29:50 GMT Subject: [jdk22u] RFR: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all Message-ID: <-FdTbs36sjrZcSnw2fKXFbup9nh5-k0MzqYsQN9f7WU=.5e1ead90-2e63-4dcc-a8a5-aa04a0fa03a9@github.com> Hi all, This is clean backport of [JDK-8331466](https://bugs.openjdk.org/browse/JDK-8331466). Only change the Problemlist.txt, the risk is low. ------------- Commit messages: - Backport 440782e0160f867f08afbec0abf48d557a522c72 Changes: https://git.openjdk.org/jdk22u/pull/202/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=202&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331466 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/202.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/202/head:pull/202 PR: https://git.openjdk.org/jdk22u/pull/202 From syan at openjdk.org Tue May 14 08:33:15 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 14 May 2024 08:33:15 GMT Subject: [jdk11u-dev] Integrated: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" In-Reply-To: References: Message-ID: <5MYgBY9bORMU8L4jDvEFeBDcu8fqKH85l8QmFJgzs20=.0a914fe2-3c42-4f92-8170-5bf768ac8e31@github.com> On Thu, 28 Mar 2024 03:42:08 GMT, SendaoYan wrote: > Hi, > > Backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). > > The origin PR use `int nextInt(int origin, int bound)` [link](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html#nextInt(int,int)) , but the jdk11 do not have this API. So I change `int nextInt(int origin, int bound)` to `nextInt(bound - origin) + origin` [link](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/Random.html#nextInt(int)). > > Only change the testcase, the change has been verified, the risk is low. > > ![image](https://github.com/openjdk/jdk11u-dev/assets/24123821/63c82beb-1c90-45b0-b8b7-6419cf111252) > > Thanks, > -sendao This pull request has now been integrated. Changeset: 270f3cfb Author: SendaoYan Committer: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/270f3cfb3da7ef15e5fbbc3ea1d0d7cd3e3cf802 Stats: 23 lines in 1 file changed: 13 ins; 0 del; 10 mod 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" Reviewed-by: mdoerr Backport-of: b6233c3de773fb57b23704f1fec05d8b2d9c11c0 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2631 From syan at openjdk.org Tue May 14 08:42:12 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 14 May 2024 08:42:12 GMT Subject: [jdk11u-dev] RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" [v2] In-Reply-To: References: Message-ID: On Mon, 13 May 2024 09:38:10 GMT, SendaoYan wrote: >> Hi, >> >> Backport of [JDK-8321925](https://bugs.openjdk.org/browse/JDK-8321925). >> >> The origin PR use `int nextInt(int origin, int bound)` [link](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html#nextInt(int,int)) , but the jdk11 do not have this API. So I change `int nextInt(int origin, int bound)` to `nextInt(bound - origin) + origin` [link](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/Random.html#nextInt(int)). >> >> Only change the testcase, the change has been verified, the risk is low. >> >> ![image](https://github.com/openjdk/jdk11u-dev/assets/24123821/63c82beb-1c90-45b0-b8b7-6419cf111252) >> >> Thanks, >> -sendao > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8321925 > - Backport b6233c3de773fb57b23704f1fec05d8b2d9c11c0 > > Signed-off-by: sendaoYan > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2631#issuecomment-2109610140 From clanger at openjdk.org Tue May 14 08:46:02 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 14 May 2024 08:46:02 GMT Subject: [jdk17u-dev] RFR: 8330815: Use pattern matching for instanceof in KeepAliveCache In-Reply-To: References: Message-ID: <8WGd73u2evyujtC8vcezVuv9GK8gwK9z0KZ_eAEIM48=.15435d80-17ac-43f5-9818-20c031bb0e7e@github.com> On Mon, 13 May 2024 12:59:18 GMT, Christoph Langer wrote: > Nearly clean backport from 21u-dev, only copyright conflicts. macos-x64 build issue seems infrastructure related. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2464#issuecomment-2109618168 From shade at openjdk.org Tue May 14 09:03:09 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 14 May 2024 09:03:09 GMT Subject: [jdk22u] Integrated: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test In-Reply-To: References: Message-ID: On Wed, 8 May 2024 11:59:05 GMT, Aleksey Shipilev wrote: > Clean backport to fix a corner case. This pull request has now been integrated. Changeset: 2cb2e6ba Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/2cb2e6ba93f56ce975faa3f79fb7eb14396d38c9 Stats: 33 lines in 3 files changed: 32 ins; 0 del; 1 mod 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test Backport-of: a7461de231da20ed78a7c6ad8275f1bafbfa556c ------------- PR: https://git.openjdk.org/jdk22u/pull/189 From shade at openjdk.org Tue May 14 09:04:03 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 14 May 2024 09:04:03 GMT Subject: [jdk22u] RFR: 8331331: :tier1 target explanation in doc/testing.md is incorrect [v2] In-Reply-To: <7MD4Yb43D0eENPGHBbuQ2EKDVnLmeVugx-D9MfIkSFE=.555fbcd8-0518-43fc-a390-93981caa5e8c@github.com> References: <7MD4Yb43D0eENPGHBbuQ2EKDVnLmeVugx-D9MfIkSFE=.555fbcd8-0518-43fc-a390-93981caa5e8c@github.com> Message-ID: <8gR1Z9ki2BujTFgc4nDlvUW0vTRBDafguHkgtRQOR4M=.de49efc9-0ac7-45f7-a54f-905f25193561@github.com> On Mon, 13 May 2024 09:44:40 GMT, SendaoYan wrote: >> Hi, >> This is clean backport of [JDK-8331331](https://bugs.openjdk.org/browse/JDK-8331331), fixed the incorrect explanation :tier1 target in doc/testing.md. No risk. > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-04271dfe > - Backport 04271dfe7a262379944e2a2cf83a98a3a1b78a74 I believe GHA failures are environmental. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/183#issuecomment-2109658921 From syan at openjdk.org Tue May 14 09:04:04 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 14 May 2024 09:04:04 GMT Subject: [jdk22u] Integrated: 8331331: :tier1 target explanation in doc/testing.md is incorrect In-Reply-To: References: Message-ID: On Fri, 3 May 2024 16:12:22 GMT, SendaoYan wrote: > Hi, > This is clean backport of [JDK-8331331](https://bugs.openjdk.org/browse/JDK-8331331), fixed the incorrect explanation :tier1 target in doc/testing.md. No risk. This pull request has now been integrated. Changeset: dd5581cc Author: SendaoYan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/dd5581cca9420b2540ac14c6ab99ac3f94fa7b3f Stats: 8 lines in 2 files changed: 1 ins; 0 del; 7 mod 8331331: :tier1 target explanation in doc/testing.md is incorrect Backport-of: 04271dfe7a262379944e2a2cf83a98a3a1b78a74 ------------- PR: https://git.openjdk.org/jdk22u/pull/183 From jkratochvil at openjdk.org Tue May 14 09:08:06 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Tue, 14 May 2024 09:08:06 GMT Subject: [jdk21u-dev] Integrated: 8324243: Compilation failures in java.desktop module with gcc 14 In-Reply-To: <4YR8gxLaYwgKPBg2auSeHV8uwS-99KRizsqLxYWU7TU=.96b556cc-3b7a-4a24-ac7c-29950b5b38bd@github.com> References: <4YR8gxLaYwgKPBg2auSeHV8uwS-99KRizsqLxYWU7TU=.96b556cc-3b7a-4a24-ac7c-29950b5b38bd@github.com> Message-ID: On Mon, 13 May 2024 14:56:04 GMT, Jan Kratochvil wrote: > It is needed to build OpenJDK-21 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). > It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk21u-dev/pull/564)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk21u-dev/pull/565)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) (this [backport](https://github.com/openjdk/jdk21u-dev/pull/566)). > Git cherry-pick was clean. This pull request has now been integrated. Changeset: 035e3144 Author: Jan Kratochvil Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/035e3144674d494919283941a2e1f3f6dddefaeb Stats: 6 lines in 4 files changed: 2 ins; 0 del; 4 mod 8324243: Compilation failures in java.desktop module with gcc 14 Backport-of: 8e5f6ddb68572c0cc8b6e256e423706f6f7cec94 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/566 From shade at openjdk.org Tue May 14 09:12:02 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 14 May 2024 09:12:02 GMT Subject: [jdk17u-dev] RFR: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time In-Reply-To: References: Message-ID: On Thu, 9 May 2024 16:32:05 GMT, Elif Aslan wrote: > Clean backport to fix ProcessTools.startProcess() bug. > > See original PR explanation [here](https://github.com/openjdk/jdk/pull/13594) > > I need this backport to be merged to able to complete [this](https://github.com/openjdk/jdk17u-dev/pull/2339) backport request. > > Additional testing: macos-x86_64-server-release tier2 There is a recorded followup for this change: [JDK-8306946](https://bugs.openjdk.org/browse/JDK-8306946) -- do we need to add it here? Does the affected test fail in JDK 17 tree with this PR applied? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2456#issuecomment-2109677798 From syan at openjdk.org Tue May 14 09:17:07 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 14 May 2024 09:17:07 GMT Subject: [jdk22u] RFR: 8331331: :tier1 target explanation in doc/testing.md is incorrect [v2] In-Reply-To: <7MD4Yb43D0eENPGHBbuQ2EKDVnLmeVugx-D9MfIkSFE=.555fbcd8-0518-43fc-a390-93981caa5e8c@github.com> References: <7MD4Yb43D0eENPGHBbuQ2EKDVnLmeVugx-D9MfIkSFE=.555fbcd8-0518-43fc-a390-93981caa5e8c@github.com> Message-ID: On Mon, 13 May 2024 09:44:40 GMT, SendaoYan wrote: >> Hi, >> This is clean backport of [JDK-8331331](https://bugs.openjdk.org/browse/JDK-8331331), fixed the incorrect explanation :tier1 target in doc/testing.md. No risk. > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-04271dfe > - Backport 04271dfe7a262379944e2a2cf83a98a3a1b78a74 > I believe GHA failures are environmental. > > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/183#issuecomment-2109689700 From mbaesken at openjdk.org Tue May 14 09:22:08 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 14 May 2024 09:22:08 GMT Subject: [jdk22u] Integrated: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN In-Reply-To: <2KkUZItFZG2QFpVF4Br4ROtoImCcFMcoxnpKctJC-vk=.d8a5eaef-caad-47f4-bdbf-0e089a72438c@github.com> References: <2KkUZItFZG2QFpVF4Br4ROtoImCcFMcoxnpKctJC-vk=.d8a5eaef-caad-47f4-bdbf-0e089a72438c@github.com> Message-ID: On Tue, 7 May 2024 07:50:43 GMT, Matthias Baesken wrote: > 8330615: avoid signed integer overflows in zip_util.c readCen / hashN This pull request has now been integrated. Changeset: 5550682a Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/5550682a8a5d17d620467cb628c685937140a047 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8330615: avoid signed integer overflows in zip_util.c readCen / hashN Backport-of: 5af6b45eefd227e3e046ca22a404ae8a23174160 ------------- PR: https://git.openjdk.org/jdk22u/pull/186 From mbaesken at openjdk.org Tue May 14 09:24:03 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 14 May 2024 09:24:03 GMT Subject: [jdk22u] Integrated: 8331167: UBSan enabled build fails in adlc on macOS In-Reply-To: References: Message-ID: On Tue, 7 May 2024 07:27:02 GMT, Matthias Baesken wrote: > 8331167: UBSan enabled build fails in adlc on macOS This pull request has now been integrated. Changeset: bb3651fb Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/bb3651fbaa9f5ee244bc09da2f23c50171dc0f59 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8331167: UBSan enabled build fails in adlc on macOS Backport-of: 4edac349a5d695ce7923344ad5ad0400842241eb ------------- PR: https://git.openjdk.org/jdk22u/pull/185 From mdoerr at openjdk.org Tue May 14 09:34:05 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 14 May 2024 09:34:05 GMT Subject: [jdk17u-dev] Integrated: 8302907: [PPC64] Use more constexpr in class Register In-Reply-To: <8Vho7Uljh_bLxfLCftow2j5e4PivQaXmQZ0mB8N4mG8=.341f7dae-c176-4425-8d71-4acf1a48d3ec@github.com> References: <8Vho7Uljh_bLxfLCftow2j5e4PivQaXmQZ0mB8N4mG8=.341f7dae-c176-4425-8d71-4acf1a48d3ec@github.com> Message-ID: On Mon, 13 May 2024 10:46:42 GMT, Martin Doerr wrote: > Clean backport of [JDK-8302907](https://bugs.openjdk.org/browse/JDK-8302907). This pull request has now been integrated. Changeset: d2b9c01b Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/d2b9c01b37386e62c41e02902a94220246ba7851 Stats: 17 lines in 1 file changed: 0 ins; 0 del; 17 mod 8302907: [PPC64] Use more constexpr in class Register Backport-of: 180b94c73e9ad17d57650d4c985d4104289052a9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2461 From stuefe at openjdk.org Tue May 14 09:44:05 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 14 May 2024 09:44:05 GMT Subject: [jdk22u] RFR: 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095 In-Reply-To: References: Message-ID: On Mon, 13 May 2024 08:52:59 GMT, Aleksey Shipilev wrote: > Ouch. So I missed this hunk during jdk22u backport? And I have not noticed, because -- in contrast to jdk21u backport -- I have not ran the full test suite for jdk22u, only the basic sanity tests around the change, in order to save testing time. > > Looks good, thanks for fixing. Sure, no problem. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/190#issuecomment-2109748818 From pkumaraswamy at openjdk.org Tue May 14 10:59:31 2024 From: pkumaraswamy at openjdk.org (Prajwal Kumaraswamy) Date: Tue, 14 May 2024 10:59:31 GMT Subject: [jdk22u] RFR: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit Message-ID: This is a clean backport of JDK-8261433, Internal test are green ------------- Commit messages: - Backport 7c2c24fc0511b36132952c96be46eea5904a53c5 Changes: https://git.openjdk.org/jdk22u/pull/203/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=203&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8261433 Stats: 242 lines in 5 files changed: 165 ins; 22 del; 55 mod Patch: https://git.openjdk.org/jdk22u/pull/203.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/203/head:pull/203 PR: https://git.openjdk.org/jdk22u/pull/203 From clanger at openjdk.org Tue May 14 11:53:31 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 14 May 2024 11:53:31 GMT Subject: [jdk17u-dev] RFR: 8330523: Reduce runtime and improve efficiency of KeepAliveTest [v2] In-Reply-To: References: Message-ID: > Backport this test improvement. I only had to do minor resolvation. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Adaptations for 17 - Merge branch 'master' into backport-RealCLanger-c12dfc35 - Backport c12dfc3571235bb57b2287e06c0cebb764f47a9a ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2463/files - new: https://git.openjdk.org/jdk17u-dev/pull/2463/files/45f4e6cc..9489fc4f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2463&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2463&range=00-01 Stats: 852 lines in 20 files changed: 319 ins; 316 del; 217 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2463.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2463/head:pull/2463 PR: https://git.openjdk.org/jdk17u-dev/pull/2463 From mbaesken at openjdk.org Tue May 14 11:56:01 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 14 May 2024 11:56:01 GMT Subject: [jdk22u] Integrated: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing In-Reply-To: References: Message-ID: On Fri, 10 May 2024 12:33:11 GMT, Matthias Baesken wrote: > 8329862: libjli GetApplicationHome cleanups and enhance jli tracing This pull request has now been integrated. Changeset: c3e90844 Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/c3e90844a72cf79cbc7dc5fe6ee234839d0b4f2b Stats: 46 lines in 2 files changed: 8 ins; 36 del; 2 mod 8329862: libjli GetApplicationHome cleanups and enhance jli tracing Backport-of: 377f2e538ae0fc94fc5483700a3ae70175017741 ------------- PR: https://git.openjdk.org/jdk22u/pull/195 From mbaesken at openjdk.org Tue May 14 12:04:29 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 14 May 2024 12:04:29 GMT Subject: [jdk21u-dev] RFR: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing Message-ID: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing ------------- Commit messages: - Backport 377f2e538ae0fc94fc5483700a3ae70175017741 Changes: https://git.openjdk.org/jdk21u-dev/pull/570/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=570&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329862 Stats: 46 lines in 2 files changed: 8 ins; 36 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/570.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/570/head:pull/570 PR: https://git.openjdk.org/jdk21u-dev/pull/570 From aph at openjdk.org Tue May 14 12:10:09 2024 From: aph at openjdk.org (Andrew Haley) Date: Tue, 14 May 2024 12:10:09 GMT Subject: [jdk11u-dev] RFR: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c In-Reply-To: <0eSK5ocjyerxsBrXiW1q3tUKbTwRFoVzB_FdgqUOhM4=.40028621-3da5-49de-bd20-56a256089ee6@github.com> References: <0eSK5ocjyerxsBrXiW1q3tUKbTwRFoVzB_FdgqUOhM4=.40028621-3da5-49de-bd20-56a256089ee6@github.com> Message-ID: On Mon, 13 May 2024 13:07:12 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8293887](https://bugs.openjdk.org/browse/JDK-8293887). It's not clean backport, because the file `make/lib/CoreLibraries.gmk` has been moved to `make/modules/java.base/lib/CoreLibraries.gmk` > > Thanks! > > > Make test list: > > - [x] linux x64 gcc10 > - [x] linux x64 gcc13 > - [x] linux aarch64 gcc10 > - [x] linux aarch64 gcc13 > - [x] linux riscv64 gcc13 > > > [make-linux-aarch64-gcc10.log](https://github.com/openjdk/jdk11u-dev/files/15295807/make-linux-aarch64-gcc10.log) > [make-linux-aarch64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295808/make-linux-aarch64-gcc13.log) > [make-linux-x64-gcc10.log](https://github.com/openjdk/jdk11u-dev/files/15295809/make-linux-x64-gcc10.log) > [make-linux-x64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295810/make-linux-x64-gcc13.log) > [make-linux-riscv64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295880/make-linux-riscv64-gcc13.log) > > linux riscv64 gcc13 build jdk11u-dev failure because other reasons, the `k_rem_pio2.c` file not longer compile fail after this PR. Thanks. ------------- Marked as reviewed by aph (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2709#pullrequestreview-2055157387 From mbaesken at openjdk.org Tue May 14 12:11:30 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 14 May 2024 12:11:30 GMT Subject: [jdk22u] RFR: 8331298: avoid alignment checks in UBSAN enabled build Message-ID: 8331298: avoid alignment checks in UBSAN enabled build ------------- Commit messages: - Backport 60b61e588c1252b4b1fbc64d0f818a85670f7146 Changes: https://git.openjdk.org/jdk22u/pull/204/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=204&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331298 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/204.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/204/head:pull/204 PR: https://git.openjdk.org/jdk22u/pull/204 From digital-connectivity-dev at man-es.com Tue May 14 12:59:23 2024 From: digital-connectivity-dev at man-es.com (digital-connectivity-dev) Date: Tue, 14 May 2024 12:59:23 +0000 Subject: [jdk17u-dev] Requesting backport of JDK-8308144 Uncontrolled memory consumption in SSLFlowDelegate.Reader In-Reply-To: References: Message-ID: Hello, we have been affected by the JDK bug "Uncontrolled memory consumption in SSLFlowDelegate.Reader" that was reported and fixed here: https://bugs.openjdk.org/browse/JDK-8308144 This resulted in an OOM Exception and program crash for us when downloading a large file (~2Gb) running in an environment with limited heap memory (~500Mb). Aside from documentation and tests, the patch committed last November to correct the issue was one line long. However, the fix was only made to JDK 22 and 23: https://github.com/openjdk/jdk/pull/16704 We did not understand the low priority of the issue (P4) as we see no way around the problem and we would have to wait until 2025 for the next LTS release with this fix. We would greatly appreciate it if this fix could instead be backported to earlier LTS JDKs, ideally including JDK 17. Would someone be able to do this for us? We would be uncomfortable attempting to merge this ourselves. If so, would it plausibly make the July release? (Sorry for the repost, the tag was missing in the thread name) Many thanks. MAN Energy Solutions SE Vorsitzender des Aufsichtsrates: Gunnar Kilian Vorstand: Dr. Uwe Lauber (Vorsitzender), J?rgen Kl?pffer, Martin Oetjen, Ingrid Rieken, Dr. Gunnar Stiesch Sitz der Gesellschaft: Augsburg Registergericht: Amtsgericht Augsburg, HRB 22056 This e-mail (including any attachments) is confidential and may be privileged. If you have received it by mistake, please notify the sender by e-mail and delete it from your system. Any unauthorized use or dissemination of this e-mail or its contents in whole or in part is strictly prohibited. Please note that e-mails are susceptible to change. MAN Energy Solutions SE (including its group companies) shall not be liable for the improper or incomplete transmission of the information contained in this communication nor for any delay in its receipt. MAN Energy Solutions SE (or its group companies) does not guarantee that the integrity of this communication has been maintained nor that this communication is free of viruses, interceptions or interference. -------------- next part -------------- An HTML attachment was scrubbed... URL: From szaldana at openjdk.org Tue May 14 14:18:12 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 14 May 2024 14:18:12 GMT Subject: [jdk17u-dev] Integrated: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 14:05:48 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This PR contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439). > > Patch is not clean. Test won't build in 17 because it can't find ```import jdk.internal.util.OperatingSystem```. > > This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485). > > I've worked around that by removing the dependency to that utility function and checking the operating system with ```test/lib/jdk/test/lib/Platform.java```. > > Testing: > - [x] Modified test case passes > > Thanks! This pull request has now been integrated. Changeset: 68caeca1 Author: Sonia Zaldana Calles Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/68caeca1a5f265ca30a7e6d2a62127d458a3473e Stats: 50 lines in 1 file changed: 32 ins; 5 del; 13 mod 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used Reviewed-by: mdoerr Backport-of: 43c6f0b5880899b797fab2f851bd35be1c342439 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2321 From phh at openjdk.org Tue May 14 15:28:04 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 14 May 2024 15:28:04 GMT Subject: [jdk11u-dev] RFR: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c In-Reply-To: <0eSK5ocjyerxsBrXiW1q3tUKbTwRFoVzB_FdgqUOhM4=.40028621-3da5-49de-bd20-56a256089ee6@github.com> References: <0eSK5ocjyerxsBrXiW1q3tUKbTwRFoVzB_FdgqUOhM4=.40028621-3da5-49de-bd20-56a256089ee6@github.com> Message-ID: <41gJOqxs2UBoQki1nAewy_D4oCmmkcyCCt7DM2Ivtto=.80b8ed40-4edc-41dd-aa72-5806f4ed94a3@github.com> On Mon, 13 May 2024 13:07:12 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8293887](https://bugs.openjdk.org/browse/JDK-8293887). It's not clean backport, because the file `make/lib/CoreLibraries.gmk` has been moved to `make/modules/java.base/lib/CoreLibraries.gmk` > > Thanks! > > > Make test list: > > - [x] linux x64 gcc10 > - [x] linux x64 gcc13 > - [x] linux aarch64 gcc10 > - [x] linux aarch64 gcc13 > - [x] linux riscv64 gcc13 > > > [make-linux-aarch64-gcc10.log](https://github.com/openjdk/jdk11u-dev/files/15295807/make-linux-aarch64-gcc10.log) > [make-linux-aarch64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295808/make-linux-aarch64-gcc13.log) > [make-linux-x64-gcc10.log](https://github.com/openjdk/jdk11u-dev/files/15295809/make-linux-x64-gcc10.log) > [make-linux-x64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295810/make-linux-x64-gcc13.log) > [make-linux-riscv64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295880/make-linux-riscv64-gcc13.log) > > linux riscv64 gcc13 build jdk11u-dev failure because other reasons, the `k_rem_pio2.c` file not longer compile fail after this PR. Clean backport from 17u, net of file location change. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2709#pullrequestreview-2055744150 From syan at openjdk.org Tue May 14 15:37:04 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 14 May 2024 15:37:04 GMT Subject: [jdk11u-dev] RFR: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c In-Reply-To: <0eSK5ocjyerxsBrXiW1q3tUKbTwRFoVzB_FdgqUOhM4=.40028621-3da5-49de-bd20-56a256089ee6@github.com> References: <0eSK5ocjyerxsBrXiW1q3tUKbTwRFoVzB_FdgqUOhM4=.40028621-3da5-49de-bd20-56a256089ee6@github.com> Message-ID: <5wd7QLbgs-jjlQy9gqL8xgl9uQDih2gyR_pfeSiuZak=.bc474a6e-a2fb-442e-bb58-0837252759e1@github.com> On Mon, 13 May 2024 13:07:12 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8293887](https://bugs.openjdk.org/browse/JDK-8293887). It's not clean backport, because the file `make/lib/CoreLibraries.gmk` has been moved to `make/modules/java.base/lib/CoreLibraries.gmk` > > Thanks! > > > Make test list: > > - [x] linux x64 gcc10 > - [x] linux x64 gcc13 > - [x] linux aarch64 gcc10 > - [x] linux aarch64 gcc13 > - [x] linux riscv64 gcc13 > > > [make-linux-aarch64-gcc10.log](https://github.com/openjdk/jdk11u-dev/files/15295807/make-linux-aarch64-gcc10.log) > [make-linux-aarch64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295808/make-linux-aarch64-gcc13.log) > [make-linux-x64-gcc10.log](https://github.com/openjdk/jdk11u-dev/files/15295809/make-linux-x64-gcc10.log) > [make-linux-x64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295810/make-linux-x64-gcc13.log) > [make-linux-riscv64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295880/make-linux-riscv64-gcc13.log) > > linux riscv64 gcc13 build jdk11u-dev failure because other reasons, the `k_rem_pio2.c` file not longer compile fail after this PR. Thanks all for the review and approved. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2709#issuecomment-2110547332 From amitkumar at openjdk.org Tue May 14 16:27:11 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Tue, 14 May 2024 16:27:11 GMT Subject: [jdk11u-dev] Integrated: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space In-Reply-To: References: Message-ID: On Thu, 9 May 2024 06:16:16 GMT, Amit Kumar wrote: > Hi all, > > This pull request contains a backport of commit [d5f3d5c8](https://github.com/openjdk/jdk/commit/d5f3d5c8cc347ae384dea25b1a55ed57204d1af3) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Amit Kumar on 21 Feb 2024 and was reviewed by Lutz Schmidt and Martin Doerr. > > Thanks! This pull request has now been integrated. Changeset: 42f70422 Author: Amit Kumar Committer: Lutz Schmidt URL: https://git.openjdk.org/jdk11u-dev/commit/42f70422f10472aa67ca86bfbac25a5d5c314ec2 Stats: 6 lines in 2 files changed: 3 ins; 0 del; 3 mod 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space Reviewed-by: lucy Backport-of: d5f3d5c8cc347ae384dea25b1a55ed57204d1af3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2704 From andrewlu at openjdk.org Wed May 15 07:05:15 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 15 May 2024 07:05:15 GMT Subject: [jdk11u-dev] RFR: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16 Message-ID: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16 ------------- Commit messages: - Backport 3460807ba6d8419b679c857ccfdc68c4a06a3ac9 Changes: https://git.openjdk.org/jdk11u-dev/pull/2711/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2711&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318322 Stats: 53 lines in 2 files changed: 50 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2711.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2711/head:pull/2711 PR: https://git.openjdk.org/jdk11u-dev/pull/2711 From andrewlu at openjdk.org Wed May 15 08:40:18 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Wed, 15 May 2024 08:40:18 GMT Subject: [jdk21u-dev] Integrated: 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed out In-Reply-To: References: Message-ID: On Tue, 14 May 2024 03:14:47 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 5b5d778e Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/5b5d778e43b9e31e2319a5ccb4c059cad0fa1388 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed out Backport-of: b9df827adc92cb1fc65f6b1efdf82dcae00a4e2d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/568 From mbaesken at openjdk.org Wed May 15 09:13:08 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 15 May 2024 09:13:08 GMT Subject: [jdk17u-dev] RFR: 8330523: Reduce runtime and improve efficiency of KeepAliveTest [v2] In-Reply-To: References: Message-ID: On Tue, 14 May 2024 11:53:31 GMT, Christoph Langer wrote: >> This is a backport of a test improvement. I had to resolve some minor conflicts and make some small adaptions. > > Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Adaptations for 17 > - Merge branch 'master' into backport-RealCLanger-c12dfc35 > - Backport c12dfc3571235bb57b2287e06c0cebb764f47a9a Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2463#pullrequestreview-2057380394 From shade at openjdk.org Wed May 15 09:19:04 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 15 May 2024 09:19:04 GMT Subject: [jdk21u-dev] Integrated: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test In-Reply-To: <6v18T3HimaJWMmqKlHbFjU0O_VEhzXsUUKfMfRKYhcs=.10add37d-acad-42ef-a5fb-f0484ceab54e@github.com> References: <6v18T3HimaJWMmqKlHbFjU0O_VEhzXsUUKfMfRKYhcs=.10add37d-acad-42ef-a5fb-f0484ceab54e@github.com> Message-ID: <9wWpTvBmutJdeEq38YSY25wi2-TNoPNXgfSR1NrpALw=.db87a77b-8a39-4160-a947-b6dbf1db9390@github.com> On Tue, 7 May 2024 10:09:57 GMT, Aleksey Shipilev wrote: > Clean backport, follow up for recent [JDK-8310913](https://bugs.openjdk.org/browse/JDK-8310913) integration. Nothing AFAICS is using the affected method except the test itself. > > Additional testing: > - [x] New regression test fails without the fix, passes with it This pull request has now been integrated. Changeset: 2429a900 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/2429a900447789af4f4a371c7b67b4d906ae27db Stats: 33 lines in 3 files changed: 32 ins; 0 del; 1 mod 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test Backport-of: a7461de231da20ed78a7c6ad8275f1bafbfa556c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/557 From stuefe at openjdk.org Wed May 15 10:17:18 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 15 May 2024 10:17:18 GMT Subject: [jdk21u-dev] Integrated: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default In-Reply-To: References: Message-ID: <4Xsnx3tVDNN_hUon25IEj57Q2jd-ZO6ZnW98mh7aVL4=.cc58b875-abed-4c8b-a257-3bf9c47d1d28@github.com> On Fri, 10 May 2024 10:27:35 GMT, Thomas Stuefe wrote: > Hi all, > > This pull request contains a backport of commit [d2d37c91](https://github.com/openjdk/jdk/commit/d2d37c913e5b55f7aec2c7a6b5a2328348ded223) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Thomas Stuefe on 10 May 2024 and was reviewed by Andrew Haley and Ioi Lam. > > Thanks! This pull request has now been integrated. Changeset: 59ca0093 Author: Thomas Stuefe URL: https://git.openjdk.org/jdk21u-dev/commit/59ca0093a82483726ca1a1f021d3d80c804c585b Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default Backport-of: d2d37c913e5b55f7aec2c7a6b5a2328348ded223 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/561 From stuefe at openjdk.org Wed May 15 10:17:27 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 15 May 2024 10:17:27 GMT Subject: [jdk22u] Integrated: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default In-Reply-To: References: Message-ID: On Fri, 10 May 2024 10:27:14 GMT, Thomas Stuefe wrote: > Hi all, > > See comment in original issue. We'd like to backport this to 22 and 21. > > This pull request contains a backport of commit [d2d37c91](https://github.com/openjdk/jdk/commit/d2d37c913e5b55f7aec2c7a6b5a2328348ded223) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Thomas Stuefe on 10 May 2024 and was reviewed by Andrew Haley and Ioi Lam. > > Thanks! This pull request has now been integrated. Changeset: 0f3b3fa4 Author: Thomas Stuefe URL: https://git.openjdk.org/jdk22u/commit/0f3b3fa4a073b13140154cd577268aec9218c143 Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default Backport-of: d2d37c913e5b55f7aec2c7a6b5a2328348ded223 ------------- PR: https://git.openjdk.org/jdk22u/pull/193 From mdoerr at openjdk.org Wed May 15 10:47:37 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 15 May 2024 10:47:37 GMT Subject: [jdk21u-dev] RFR: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader Message-ID: Clean backport of [JDK-8308144](https://bugs.openjdk.org/browse/JDK-8308144). ------------- Commit messages: - Backport 099a8f5b2f924fddd43ff72f3f7c6f34b6c15b0f Changes: https://git.openjdk.org/jdk21u-dev/pull/571/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=571&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308144 Stats: 662 lines in 3 files changed: 642 ins; 0 del; 20 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/571.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/571/head:pull/571 PR: https://git.openjdk.org/jdk21u-dev/pull/571 From mdoerr at openjdk.org Wed May 15 10:49:39 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 15 May 2024 10:49:39 GMT Subject: [jdk17u-dev] RFR: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader Message-ID: Clean backport of [JDK-8308144](https://bugs.openjdk.org/browse/JDK-8308144). ------------- Commit messages: - Backport 099a8f5b2f924fddd43ff72f3f7c6f34b6c15b0f Changes: https://git.openjdk.org/jdk17u-dev/pull/2472/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2472&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308144 Stats: 662 lines in 3 files changed: 642 ins; 0 del; 20 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2472.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2472/head:pull/2472 PR: https://git.openjdk.org/jdk17u-dev/pull/2472 From jkratochvil at openjdk.org Wed May 15 11:08:05 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Wed, 15 May 2024 11:08:05 GMT Subject: [jdk21u-dev] Integrated: 8331352: error: template-id not allowed for constructor/destructor in C++20 In-Reply-To: References: Message-ID: On Mon, 13 May 2024 14:54:25 GMT, Jan Kratochvil wrote: > It is needed to build OpenJDK-21 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). > It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk21u-dev/pull/564)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) (this [backport](https://github.com/openjdk/jdk21u-dev/pull/565)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) ([backport](https://github.com/openjdk/jdk21u-dev/pull/566)). > Git cherry-pick was clean. This pull request has now been integrated. Changeset: 87318f87 Author: Jan Kratochvil Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/87318f8783e26cb204792166155b6714312fef07 Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod 8331352: error: template-id not allowed for constructor/destructor in C++20 Backport-of: 45792c5829fb1d5ee016c4a1fd6badb5d2b4239c ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/565 From jkratochvil at openjdk.org Wed May 15 11:09:16 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Wed, 15 May 2024 11:09:16 GMT Subject: [jdk21u-dev] Integrated: 8328997: Remove unnecessary template parameter lists in GrowableArray In-Reply-To: References: Message-ID: <46WJgGfftKM-cq6L_aknf23gDG69h3jYfJbCzsbWHDQ=.2b2e8bdd-8ad4-4733-9353-bbfe5691d66f@github.com> On Mon, 13 May 2024 14:48:52 GMT, Jan Kratochvil wrote: > It is needed to build OpenJDK-21 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). > It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) (this [backport](https://github.com/openjdk/jdk21u-dev/pull/564)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk21u-dev/pull/565)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) ([backport](https://github.com/openjdk/jdk21u-dev/pull/566)). > Git cherry-pick was not clean but it was a non-issue. This pull request has now been integrated. Changeset: fdb82f42 Author: Jan Kratochvil Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/fdb82f42f1b6f51ad0c54a08e0b9346d65a70643 Stats: 16 lines in 1 file changed: 0 ins; 0 del; 16 mod 8328997: Remove unnecessary template parameter lists in GrowableArray Backport-of: 3d2283800acee58dbf046c8b401a5a144ab65ed1 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/564 From mbaesken at openjdk.org Wed May 15 11:40:31 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 15 May 2024 11:40:31 GMT Subject: [jdk21u-dev] RFR: 8312218: Print additional debug information when hitting assert(in_hash) Message-ID: 8312218: Print additional debug information when hitting assert(in_hash) ------------- Commit messages: - Backport 7cbab1f39636f3cf32f1276bc46feaa8107a14e6 Changes: https://git.openjdk.org/jdk21u-dev/pull/572/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=572&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312218 Stats: 10 lines in 1 file changed: 9 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/572.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/572/head:pull/572 PR: https://git.openjdk.org/jdk21u-dev/pull/572 From clanger at openjdk.org Wed May 15 11:43:37 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 15 May 2024 11:43:37 GMT Subject: [jdk22u] RFR: 8330814: Cleanups for KeepAliveCache tests Message-ID: Hi all, This pull request contains a backport of [JDK-8330814](https://bugs.openjdk.org/browse/JDK-8330814), commit [a5005c87](https://github.com/openjdk/jdk/commit/a5005c87c4d5598eb54e9824105767d833f9660b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Christoph Langer on 15 May 2024 and was reviewed by Jaikiran Pai and Daniel Fuchs. Thanks! ------------- Commit messages: - Backport a5005c87c4d5598eb54e9824105767d833f9660b Changes: https://git.openjdk.org/jdk22u/pull/207/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=207&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330814 Stats: 290 lines in 5 files changed: 113 ins; 69 del; 108 mod Patch: https://git.openjdk.org/jdk22u/pull/207.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/207/head:pull/207 PR: https://git.openjdk.org/jdk22u/pull/207 From mbaesken at openjdk.org Wed May 15 11:44:07 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 15 May 2024 11:44:07 GMT Subject: [jdk21u-dev] Integrated: 8331167: UBSan enabled build fails in adlc on macOS In-Reply-To: References: Message-ID: On Mon, 6 May 2024 13:54:22 GMT, Matthias Baesken wrote: > 8331167: UBSan enabled build fails in adlc on macOS This pull request has now been integrated. Changeset: 30f0779c Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/30f0779c73c030d1f4cd94baf750c70b82b62f73 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8331167: UBSan enabled build fails in adlc on macOS Backport-of: 4edac349a5d695ce7923344ad5ad0400842241eb ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/556 From mbaesken at openjdk.org Wed May 15 11:47:07 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 15 May 2024 11:47:07 GMT Subject: [jdk21u-dev] Integrated: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN In-Reply-To: References: Message-ID: On Mon, 6 May 2024 13:20:46 GMT, Matthias Baesken wrote: > 8330615: avoid signed integer overflows in zip_util.c readCen / hashN This pull request has now been integrated. Changeset: 9b8f9887 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/9b8f98871a66bde6db87d76758b149d8a2c601e4 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8330615: avoid signed integer overflows in zip_util.c readCen / hashN Backport-of: 5af6b45eefd227e3e046ca22a404ae8a23174160 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/555 From mbaesken at openjdk.org Wed May 15 11:51:36 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 15 May 2024 11:51:36 GMT Subject: [jdk21u-dev] Integrated: 8329663: hs_err file event log entry for thread adding/removing should print current thread In-Reply-To: <0c7opBedL7ik4Mo8-Lb5tkYlGOkhPnG4hG5kF_UZV4A=.7fdee911-83ea-47a2-8386-2e1f6a0fdca1@github.com> References: <0c7opBedL7ik4Mo8-Lb5tkYlGOkhPnG4hG5kF_UZV4A=.7fdee911-83ea-47a2-8386-2e1f6a0fdca1@github.com> Message-ID: On Mon, 6 May 2024 12:36:02 GMT, Matthias Baesken wrote: > 8329663: hs_err file event log entry for thread adding/removing should print current thread This pull request has now been integrated. Changeset: 87fe0d28 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/87fe0d28ed581b107917ffcbb9ec29e6dbb906d3 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8329663: hs_err file event log entry for thread adding/removing should print current thread Backport-of: 3ebf8c9359da2f45e4cefb7be2276d33c30979aa ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/553 From mdoerr at openjdk.org Wed May 15 12:27:45 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 15 May 2024 12:27:45 GMT Subject: [jdk11u-dev] RFR: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError In-Reply-To: References: Message-ID: <6VPzQk4240f5PLliuomhrVgwtnwS7DX_68X0ZBdZ8RY=.c7de31dd-188b-44ec-b162-5ba6496d7141@github.com> On Mon, 13 May 2024 05:23:34 GMT, Andrew Lu wrote: > This PR contains a backport of > https://github.com/openjdk/jdk/commit/12e943091071b02b5756b57527a5f86a3d881cb8 > Patch is not clean, this file test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/hs201t002.cpp has changed by other commits, I ignored these commits and only change code for this issue. > Other than that the rest of the code is clean. LGTM. Please fix the Copyright header. test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java line 2: > 1: /* > 2: * Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved. Should be "Copyright (c) 2018, 2022" (see original change). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2707#pullrequestreview-2057841112 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2707#discussion_r1601537813 From stuefe at openjdk.org Wed May 15 12:47:14 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 15 May 2024 12:47:14 GMT Subject: [jdk17u-dev] RFR: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default Message-ID: Hi all, This pull request contains a backport of commit [d2d37c91](https://github.com/openjdk/jdk/commit/d2d37c913e5b55f7aec2c7a6b5a2328348ded223) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Thomas Stuefe on 10 May 2024 and was reviewed by Andrew Haley and Ioi Lam. Thanks! ------------- Commit messages: - Backport d2d37c913e5b55f7aec2c7a6b5a2328348ded223 Changes: https://git.openjdk.org/jdk17u-dev/pull/2471/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2471&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331942 Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2471.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2471/head:pull/2471 PR: https://git.openjdk.org/jdk17u-dev/pull/2471 From mdoerr at openjdk.org Wed May 15 12:53:17 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 15 May 2024 12:53:17 GMT Subject: [jdk17u-dev] RFR: 8328997: Remove unnecessary template parameter lists in GrowableArray In-Reply-To: <3ZSIQ-8yKrtnA6hgvKM4r_nA3BRkit14PejA7KtHrqA=.d5fea582-1122-41e8-8c3f-1e79d94f2455@github.com> References: <3ZSIQ-8yKrtnA6hgvKM4r_nA3BRkit14PejA7KtHrqA=.d5fea582-1122-41e8-8c3f-1e79d94f2455@github.com> Message-ID: On Tue, 14 May 2024 05:12:54 GMT, Jan Kratochvil wrote: > It is needed to build OpenJDK-17 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). > It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) (this [backport](https://github.com/openjdk/jdk17u-dev/pull/2466)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2467)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2468)). > Git cherry-pick was not clean but it was easy to apply. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2466#pullrequestreview-2057919156 From mbaesken at openjdk.org Wed May 15 12:55:11 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 15 May 2024 12:55:11 GMT Subject: [jdk11u-dev] Withdrawn: 8324598: use mem_unit when working with sysinfo memory and swap related information In-Reply-To: References: Message-ID: On Fri, 5 Apr 2024 12:44:59 GMT, Matthias Baesken wrote: > Backport of 8324598 ; this backport does not change [src/java.base/linux/native/libjava/CgroupMetrics.c](https://github.com/openjdk/jdk/commit/7a798d3cebea0915f8a73af57333b3488c2091af#diff-e8dee60b11f369a261076ab88cda5bf76ecb720b3937b2e27a1ed64aff2b1729) > > because the adjusted coding in this file is not in jdk11u-dev This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2642 From mdoerr at openjdk.org Wed May 15 12:59:29 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 15 May 2024 12:59:29 GMT Subject: [jdk17u-dev] RFR: 8331352: error: template-id not allowed for constructor/destructor in C++20 In-Reply-To: References: Message-ID: On Tue, 14 May 2024 05:14:33 GMT, Jan Kratochvil wrote: > It is needed to build OpenJDK-17 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). > It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2466)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) (this [backport](https://github.com/openjdk/jdk17u-dev/pull/2467)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2468)). > Git cherry-pick was not clean but it was easy to apply. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2467#pullrequestreview-2057933717 From mdoerr at openjdk.org Wed May 15 13:13:11 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 15 May 2024 13:13:11 GMT Subject: [jdk17u-dev] RFR: 8324243: Compilation failures in java.desktop module with gcc 14 In-Reply-To: References: Message-ID: <2ehvkjrw7WyR9AgBFuA4i1X4L29VL30iptCW7Q02FlI=.899db2a4-573f-4552-9e85-5c4b832a6231@github.com> On Tue, 14 May 2024 05:15:33 GMT, Jan Kratochvil wrote: > It is needed to build OpenJDK-17 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). > It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2466)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2467)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) (this [backport](https://github.com/openjdk/jdk17u-dev/pull/2468)). > Git cherry-pick was not clean but it was easy to apply. make/modules/java.desktop/lib/Awt2dLibraries.gmk line 473: > 471: HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := reorder delete-non-virtual-dtor strict-overflow \ > 472: maybe-uninitialized class-memaccess unused-result extra use-after-free noexcept-type \ > 473: expansion-to-defined dangling-reference calloc-transposed-args Can you include https://github.com/openjdk/jdk/commit/ec79ab4b3cd89c2c0a9c8550cd62433bd6d45266, please, such that the code looks like the upstream version? And consider using "/issue add JDK-8319268". GCC8 should still be supported. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2468#discussion_r1601617775 From thartmann at openjdk.org Wed May 15 13:36:10 2024 From: thartmann at openjdk.org (Tobias Hartmann) Date: Wed, 15 May 2024 13:36:10 GMT Subject: [jdk22u] RFR: 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095 In-Reply-To: References: Message-ID: <6GZysl2aK2mUvKC2KprNnrvaSR0Rv85igZEQ9DW-VE0=.8b7c3788-368f-4104-86b1-edc39514a5c3@github.com> On Tue, 14 May 2024 09:41:14 GMT, Thomas Stuefe wrote: >> Ouch. So I missed this hunk during jdk22u backport? And I have not noticed, because -- in contrast to jdk21u backport -- I have not ran the full test suite for jdk22u, only the basic sanity tests around the change, in order to save testing time. >> >> Looks good, thanks for fixing. > >> Ouch. So I missed this hunk during jdk22u backport? And I have not noticed, because -- in contrast to jdk21u backport -- I have not ran the full test suite for jdk22u, only the basic sanity tests around the change, in order to save testing time. >> >> Looks good, thanks for fixing. > > Sure, no problem. @tstuefe Could you please integrate this soon? The failures generate a lot of noise in our testing. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/190#issuecomment-2112548920 From mbaesken at openjdk.org Wed May 15 14:36:29 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 15 May 2024 14:36:29 GMT Subject: [jdk21u-dev] RFR: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections Message-ID: Backport 8329605 ------------- Commit messages: - Backport 397d94831033e91c7a849774bf4e80d8f1c8ec66 Changes: https://git.openjdk.org/jdk21u-dev/pull/573/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=573&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329605 Stats: 40 lines in 6 files changed: 32 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/573.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/573/head:pull/573 PR: https://git.openjdk.org/jdk21u-dev/pull/573 From shade at openjdk.org Wed May 15 17:26:12 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 15 May 2024 17:26:12 GMT Subject: [jdk17u-dev] RFR: 8318986: Improve GenericWaitBarrier performance In-Reply-To: References: Message-ID: On Mon, 11 Dec 2023 17:39:49 GMT, Aleksey Shipilev wrote: > Clean backport to drastically improve safepoint performance under heavy load, fixing regression between JDK 11 and JDK 17. > > Additional testing: > - [x] Ad-hoc performance runs, expected improvements > - [x] MacOS AArch64 server fastdebug, `tier{1,2,3}` Not now, bot. We are planning this for October LTS release. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2041#issuecomment-2113073806 From shade at openjdk.org Wed May 15 17:26:21 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 15 May 2024 17:26:21 GMT Subject: [jdk22u] RFR: 8327501: Common ForkJoinPool prevents class unloading in some cases Message-ID: <9Ds1-y9mXpO_EHnIHx2UFKWROoZKm3ExBC_9vCRjNp4=.6580d530-405d-4091-a872-ec26f1a935cd@github.com> First change fixes the regression since JDK 19. Second change fixes the regression from the fix. Additional testing: - [x] Linux x86_64 server fastdebug, `all` ------------- Commit messages: - Backport 28216aa971ea65938117107542152abd532a5384 - Backport 53c4714aab2e072ba18631875dcaa3b2d5d22243 Changes: https://git.openjdk.org/jdk22u/pull/206/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=206&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327501 Stats: 11 lines in 2 files changed: 8 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/206.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/206/head:pull/206 PR: https://git.openjdk.org/jdk22u/pull/206 From shade at openjdk.org Wed May 15 17:26:21 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 15 May 2024 17:26:21 GMT Subject: [jdk22u] RFR: 8327501: Common ForkJoinPool prevents class unloading in some cases In-Reply-To: <9Ds1-y9mXpO_EHnIHx2UFKWROoZKm3ExBC_9vCRjNp4=.6580d530-405d-4091-a872-ec26f1a935cd@github.com> References: <9Ds1-y9mXpO_EHnIHx2UFKWROoZKm3ExBC_9vCRjNp4=.6580d530-405d-4091-a872-ec26f1a935cd@github.com> Message-ID: On Wed, 15 May 2024 09:32:31 GMT, Aleksey Shipilev wrote: > First change fixes the regression since JDK 19. Second change fixes the regression from the fix. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `all` Both backports are clean. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/206#issuecomment-2112031202 From rhalade at openjdk.org Wed May 15 20:29:23 2024 From: rhalade at openjdk.org (Rajan Halade) Date: Wed, 15 May 2024 20:29:23 GMT Subject: [jdk22u] RFR: 8316138: Add GlobalSign 2 TLS root certificates Message-ID: Backport to JDK 22u ------------- Commit messages: - Backport 4083255440cfbf39b9683ea88a433d71ec6111e7 Changes: https://git.openjdk.org/jdk22u/pull/209/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=209&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316138 Stats: 94 lines in 4 files changed: 91 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk22u/pull/209.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/209/head:pull/209 PR: https://git.openjdk.org/jdk22u/pull/209 From jkratochvil at openjdk.org Thu May 16 01:38:09 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Thu, 16 May 2024 01:38:09 GMT Subject: [jdk17u-dev] RFR: 8324243: Compilation failures in java.desktop module with gcc 14 In-Reply-To: <2ehvkjrw7WyR9AgBFuA4i1X4L29VL30iptCW7Q02FlI=.899db2a4-573f-4552-9e85-5c4b832a6231@github.com> References: <2ehvkjrw7WyR9AgBFuA4i1X4L29VL30iptCW7Q02FlI=.899db2a4-573f-4552-9e85-5c4b832a6231@github.com> Message-ID: On Wed, 15 May 2024 13:10:39 GMT, Martin Doerr wrote: >> It is needed to build OpenJDK-17 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). >> It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2466)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2467)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) (this [backport](https://github.com/openjdk/jdk17u-dev/pull/2468)). >> Git cherry-pick was not clean but it was easy to apply. > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 473: > >> 471: HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := reorder delete-non-virtual-dtor strict-overflow \ >> 472: maybe-uninitialized class-memaccess unused-result extra use-after-free noexcept-type \ >> 473: expansion-to-defined dangling-reference calloc-transposed-args > > Can you include https://github.com/openjdk/jdk/commit/ec79ab4b3cd89c2c0a9c8550cd62433bd6d45266, please, such that the code looks like the upstream version? > And consider using "/issue add JDK-8319268". GCC8 should still be supported. I would like to backport it separately. The list of versions affected is different and moreover I do not have the problem reproducible. I have tried devtoolset-8-gcc-8.3.1-3.2.el7.x86_64 (CentOS-7) and gcc-8.3.0.tar.xz (rebuilt from source). I have tried to build this branch https://github.com/jankratochvil/jdk17u-dev/tree/8324243 . ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2468#discussion_r1602431025 From jkratochvil at openjdk.org Thu May 16 02:01:26 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Thu, 16 May 2024 02:01:26 GMT Subject: [jdk17u-dev] RFR: 8319268: Build failure with GCC8.3.1 after 8313643 Message-ID: It has been requested in https://github.com/openjdk/jdk17u-dev/pull/2468#discussion_r1601617775 but I do not have this problem reproducible. I have tried devtoolset-8-gcc-8.3.1-3.2.el7.x86_64 (CentOS-7) and gcc-8.3.0.tar.xz (rebuilt from source). ------------- Commit messages: - 8319268: Build failure with GCC8.3.1 after 8313643 Changes: https://git.openjdk.org/jdk17u-dev/pull/2475/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2475&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319268 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2475.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2475/head:pull/2475 PR: https://git.openjdk.org/jdk17u-dev/pull/2475 From andrewlu at openjdk.org Thu May 16 02:05:11 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 16 May 2024 02:05:11 GMT Subject: [jdk21u-dev] Integrated: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently In-Reply-To: <6UxOd2FSHJW1t1z9m4G38t_strDxEGt9cvwx1KsUMvY=.8bf009eb-2eb9-4355-9b01-275a801449b9@github.com> References: <6UxOd2FSHJW1t1z9m4G38t_strDxEGt9cvwx1KsUMvY=.8bf009eb-2eb9-4355-9b01-275a801449b9@github.com> Message-ID: On Mon, 13 May 2024 09:34:40 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 6b0467c4 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/6b0467c4736b9bda7fc7650f510754ef91be79f0 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently Backport-of: f50df105912858198809b50432ef5a4ab184528d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/563 From andrewlu at openjdk.org Thu May 16 02:06:09 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 16 May 2024 02:06:09 GMT Subject: [jdk17u-dev] Integrated: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently In-Reply-To: References: Message-ID: On Mon, 13 May 2024 09:34:56 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. This pull request has now been integrated. Changeset: db04c7b8 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/db04c7b85eedc089b504a03a6db9163a709e54c3 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently Backport-of: f50df105912858198809b50432ef5a4ab184528d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2459 From andrewlu at openjdk.org Thu May 16 02:06:16 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 16 May 2024 02:06:16 GMT Subject: [jdk11u-dev] Integrated: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently In-Reply-To: <8338P7RPoyvINiPbJ_bQYw-Psbu6wMrY6a7L3vCbbq8=.401c8a99-f117-4d7d-bd6e-28da05f8f259@github.com> References: <8338P7RPoyvINiPbJ_bQYw-Psbu6wMrY6a7L3vCbbq8=.401c8a99-f117-4d7d-bd6e-28da05f8f259@github.com> Message-ID: On Mon, 13 May 2024 09:35:07 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. This pull request has now been integrated. Changeset: 59224f7d Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/59224f7ddfa9a874422f9c9ef3d5ccb211feb3ae Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently Backport-of: f50df105912858198809b50432ef5a4ab184528d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2708 From andrewlu at openjdk.org Thu May 16 02:14:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 16 May 2024 02:14:06 GMT Subject: [jdk17u-dev] Withdrawn: 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed out In-Reply-To: References: Message-ID: On Tue, 14 May 2024 03:15:42 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2465 From lmao at openjdk.org Thu May 16 02:52:04 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 16 May 2024 02:52:04 GMT Subject: [jdk17u-dev] RFR: 8305819: LogConfigurationTest intermittently fails on AArch64 In-Reply-To: References: Message-ID: On Mon, 13 May 2024 10:20:31 GMT, Liang Mao wrote: > Hi all, > > This pull request contains a backport of commit [911cc7cb](https://github.com/openjdk/jdk/commit/911cc7cb07ed44b24b4c20977d7d6e475bd1b234) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > > It fixed a logging crash due to arm weak memory model. > > The commit being backported was authored by gaogao-mem on 15 May 2023 and was reviewed by Andrew Haley, David Holmes and Xin Liu. > > The conflicts only come from the difference of "NULL" and "nullptr". > > Additional testing: > - [x] Verified the test case in original PR. > > Thanks! Could committers please help to sponsor? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2460#issuecomment-2113915487 From andrewlu at openjdk.org Thu May 16 05:35:13 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 16 May 2024 05:35:13 GMT Subject: [jdk21u-dev] RFR: 8320715: Improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16 Message-ID: <_xE7rHuZa0bf4gRMxlJU3wXAbITIaYA68XqzwEawqGw=.a1d6c563-929c-4efa-aa6f-af284a3a0e7b@github.com> I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 5dcf3a56cb425c3419273636729d2d83603be0d2 Changes: https://git.openjdk.org/jdk21u-dev/pull/577/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=577&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320715 Stats: 44 lines in 3 files changed: 28 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/577.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/577/head:pull/577 PR: https://git.openjdk.org/jdk21u-dev/pull/577 From mbaesken at openjdk.org Thu May 16 07:12:05 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 16 May 2024 07:12:05 GMT Subject: [jdk17u-dev] RFR: 8319268: Build failure with GCC8.3.1 after 8313643 In-Reply-To: References: Message-ID: On Thu, 16 May 2024 01:56:35 GMT, Jan Kratochvil wrote: > It has been requested in https://github.com/openjdk/jdk17u-dev/pull/2468#discussion_r1601617775 but I do not have this problem reproducible. > I have tried devtoolset-8-gcc-8.3.1-3.2.el7.x86_64 (CentOS-7) and gcc-8.3.0.tar.xz (rebuilt from source). Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2475#pullrequestreview-2059782122 From stuefe at openjdk.org Thu May 16 07:21:13 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 16 May 2024 07:21:13 GMT Subject: [jdk17u-dev] Integrated: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default In-Reply-To: References: Message-ID: <6KLp5BM4U0ZLDpmNzFcMl-CCtEMQ2jMJ0gCYjiHy_A8=.ae6f1823-6c59-411b-b08b-9b1878512978@github.com> On Wed, 15 May 2024 10:25:58 GMT, Thomas Stuefe wrote: > Hi all, > > This pull request contains a backport of commit [d2d37c91](https://github.com/openjdk/jdk/commit/d2d37c913e5b55f7aec2c7a6b5a2328348ded223) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Thomas Stuefe on 10 May 2024 and was reviewed by Andrew Haley and Ioi Lam. > > Thanks! This pull request has now been integrated. Changeset: 0a3445e0 Author: Thomas Stuefe URL: https://git.openjdk.org/jdk17u-dev/commit/0a3445e0b8bb42f0b761f78efbaca33f9433b8e5 Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default Backport-of: d2d37c913e5b55f7aec2c7a6b5a2328348ded223 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2471 From andrewlu at openjdk.org Thu May 16 07:35:11 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 16 May 2024 07:35:11 GMT Subject: [jdk11u-dev] Integrated: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16 In-Reply-To: References: Message-ID: On Wed, 15 May 2024 07:01:35 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. This pull request has now been integrated. Changeset: 2ff4d4ed Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/2ff4d4edfb5a069ac74cb65c974d5861e6147be6 Stats: 53 lines in 2 files changed: 50 ins; 0 del; 3 mod 8318322: Update IANA Language Subtag Registry to Version 2023-10-16 Backport-of: 3460807ba6d8419b679c857ccfdc68c4a06a3ac9 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2711 From mbaesken at openjdk.org Thu May 16 07:35:36 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 16 May 2024 07:35:36 GMT Subject: [jdk22u] RFR: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections Message-ID: Backport 8329605 ------------- Commit messages: - Backport 397d94831033e91c7a849774bf4e80d8f1c8ec66 Changes: https://git.openjdk.org/jdk22u/pull/211/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=211&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329605 Stats: 40 lines in 6 files changed: 32 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk22u/pull/211.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/211/head:pull/211 PR: https://git.openjdk.org/jdk22u/pull/211 From andrewlu at openjdk.org Thu May 16 07:51:39 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 16 May 2024 07:51:39 GMT Subject: [jdk11u-dev] RFR: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError [v2] In-Reply-To: References: Message-ID: <_hZAPItPYR45euaU4syHvLxzScNfSzgyxt7v3aOH1oE=.d80930ea-51ff-48ce-8e25-12eb4b621f7a@github.com> > This PR contains a backport of > https://github.com/openjdk/jdk/commit/12e943091071b02b5756b57527a5f86a3d881cb8 > Patch is not clean, this file test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/hs201t002.cpp has changed by other commits, I ignored these commits and only change code for this issue. > Other than that the rest of the code is clean. Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: Backport f12200cd11c2b689618cde1902db941ee23fbf80 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2707/files - new: https://git.openjdk.org/jdk11u-dev/pull/2707/files/9608604c..02c85c5e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2707&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2707&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2707.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2707/head:pull/2707 PR: https://git.openjdk.org/jdk11u-dev/pull/2707 From andrewlu at openjdk.org Thu May 16 08:12:09 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 16 May 2024 08:12:09 GMT Subject: [jdk11u-dev] RFR: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError [v2] In-Reply-To: <6VPzQk4240f5PLliuomhrVgwtnwS7DX_68X0ZBdZ8RY=.c7de31dd-188b-44ec-b162-5ba6496d7141@github.com> References: <6VPzQk4240f5PLliuomhrVgwtnwS7DX_68X0ZBdZ8RY=.c7de31dd-188b-44ec-b162-5ba6496d7141@github.com> Message-ID: On Wed, 15 May 2024 12:24:04 GMT, Martin Doerr wrote: > LGTM. Please fix the Copyright header. @TheRealMDoerr it's fixed, please check, thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2707#issuecomment-2114381324 From mdoerr at openjdk.org Thu May 16 08:30:05 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 16 May 2024 08:30:05 GMT Subject: [jdk11u-dev] RFR: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError [v2] In-Reply-To: <_hZAPItPYR45euaU4syHvLxzScNfSzgyxt7v3aOH1oE=.d80930ea-51ff-48ce-8e25-12eb4b621f7a@github.com> References: <_hZAPItPYR45euaU4syHvLxzScNfSzgyxt7v3aOH1oE=.d80930ea-51ff-48ce-8e25-12eb4b621f7a@github.com> Message-ID: On Thu, 16 May 2024 07:51:39 GMT, Andrew Lu wrote: >> This PR contains a backport of >> https://github.com/openjdk/jdk/commit/12e943091071b02b5756b57527a5f86a3d881cb8 >> Patch is not clean, this file test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/hs201t002.cpp has changed by other commits, I ignored these commits and only change code for this issue. >> Other than that the rest of the code is clean. > > Andrew Lu has updated the pull request incrementally with one additional commit since the last revision: > > Backport f12200cd11c2b689618cde1902db941ee23fbf80 Thanks! ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2707#pullrequestreview-2059980719 From lmao at openjdk.org Thu May 16 08:33:06 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 16 May 2024 08:33:06 GMT Subject: [jdk17u-dev] Integrated: 8305819: LogConfigurationTest intermittently fails on AArch64 In-Reply-To: References: Message-ID: On Mon, 13 May 2024 10:20:31 GMT, Liang Mao wrote: > Hi all, > > This pull request contains a backport of commit [911cc7cb](https://github.com/openjdk/jdk/commit/911cc7cb07ed44b24b4c20977d7d6e475bd1b234) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > > It fixed a logging crash due to arm weak memory model. > > The commit being backported was authored by gaogao-mem on 15 May 2023 and was reviewed by Andrew Haley, David Holmes and Xin Liu. > > The conflicts only come from the difference of "NULL" and "nullptr". > > Additional testing: > - [x] Verified the test case in original PR. > > Thanks! This pull request has now been integrated. Changeset: 18bb8dab Author: Liang Mao Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/18bb8dab659f5b57eb0acfa6c18eaaa8ca9ff55f Stats: 19 lines in 2 files changed: 10 ins; 0 del; 9 mod 8305819: LogConfigurationTest intermittently fails on AArch64 Reviewed-by: mdoerr Backport-of: 911cc7cb07ed44b24b4c20977d7d6e475bd1b234 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2460 From mdoerr at openjdk.org Thu May 16 08:35:05 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 16 May 2024 08:35:05 GMT Subject: [jdk17u-dev] RFR: 8324243: Compilation failures in java.desktop module with gcc 14 In-Reply-To: References: <2ehvkjrw7WyR9AgBFuA4i1X4L29VL30iptCW7Q02FlI=.899db2a4-573f-4552-9e85-5c4b832a6231@github.com> Message-ID: On Thu, 16 May 2024 01:32:10 GMT, Jan Kratochvil wrote: >> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 473: >> >>> 471: HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := reorder delete-non-virtual-dtor strict-overflow \ >>> 472: maybe-uninitialized class-memaccess unused-result extra use-after-free noexcept-type \ >>> 473: expansion-to-defined dangling-reference calloc-transposed-args >> >> Can you include https://github.com/openjdk/jdk/commit/ec79ab4b3cd89c2c0a9c8550cd62433bd6d45266, please, such that the code looks like the upstream version? >> And consider using "/issue add JDK-8319268". GCC8 should still be supported. > > I would like to backport it separately. The list of versions affected is different and moreover I do not have the problem reproducible. I have tried devtoolset-8-gcc-8.3.1-3.2.el7.x86_64 (CentOS-7) and gcc-8.3.0.tar.xz (rebuilt from source). I have tried to build this branch https://github.com/jankratochvil/jdk17u-dev/tree/8324243 . > Filed as https://github.com/openjdk/jdk17u-dev/pull/2475 . Even better. Thanks! This should make this backport clean and no longer require a review. And it will make future backports which touch this code clean, too. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2468#discussion_r1602870828 From sgehwolf at openjdk.org Thu May 16 08:36:12 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 16 May 2024 08:36:12 GMT Subject: [jdk22u] Integrated: 8329961: Buffer overflow in os::Linux::kernel_version In-Reply-To: <225NeOYls-590KVHWORVkKFfrYSZnNzDSBZSfDgnE-U=.c0cf7241-1e35-46d7-bd88-8735c8b06fa9@github.com> References: <225NeOYls-590KVHWORVkKFfrYSZnNzDSBZSfDgnE-U=.c0cf7241-1e35-46d7-bd88-8735c8b06fa9@github.com> Message-ID: On Fri, 12 Apr 2024 12:38:47 GMT, Severin Gehwolf wrote: > Follow-up fix to [JDK-8321075](https://bugs.openjdk.org/browse/JDK-8321075) which is in 22.0.2. Should be low risk and avoids the potential buffer-overrun. This pull request has now been integrated. Changeset: f5ce46f2 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk22u/commit/f5ce46f27e5489234d1305e0573e42898c9e9e32 Stats: 10 lines in 1 file changed: 0 ins; 7 del; 3 mod 8329961: Buffer overflow in os::Linux::kernel_version Backport-of: 279ed0ddd505fb3052b818f755b4b220ed5557e6 ------------- PR: https://git.openjdk.org/jdk22u/pull/141 From mdoerr at openjdk.org Thu May 16 09:01:06 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 16 May 2024 09:01:06 GMT Subject: [jdk21u-dev] RFR: 8312218: Print additional debug information when hitting assert(in_hash) In-Reply-To: References: Message-ID: On Wed, 15 May 2024 11:35:02 GMT, Matthias Baesken wrote: > 8312218: Print additional debug information when hitting assert(in_hash) GHA test failure is unrelated. (Also seen in other PRs.) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/572#issuecomment-2114584146 From mdoerr at openjdk.org Thu May 16 09:02:04 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 16 May 2024 09:02:04 GMT Subject: [jdk21u-dev] RFR: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader In-Reply-To: References: Message-ID: <16SwGl03dNJ0K4Wm_U1hqO8Q-QXuGSzxIC-3G6wGVps=.7510b222-8594-4aac-b445-051f2f57b2b6@github.com> On Wed, 15 May 2024 10:42:24 GMT, Martin Doerr wrote: > Clean backport of [JDK-8308144](https://bugs.openjdk.org/browse/JDK-8308144). GHA test failure is unrelated. (Also seen in other PRs.) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/571#issuecomment-2114588209 From duke at openjdk.org Thu May 16 09:49:07 2024 From: duke at openjdk.org (Robert Toyonaga) Date: Thu, 16 May 2024 09:49:07 GMT Subject: [jdk11u-dev] Integrated: 8326521: JFR: CompilerPhase event test fails on windows 32 bit In-Reply-To: References: Message-ID: On Mon, 13 May 2024 18:07:41 GMT, Robert Toyonaga wrote: > This is a backport of https://github.com/openjdk/jdk/commit/96530bcc07514c3eda40fd6ffa74f197fe541dea > > On some systems (such as windows 32 bit) Hotspot only uses the C1 compiler in by design. The CompilerPhase JFR events are only emitted from C2 code. So the test TestCompilerPhase fails on some systems because it cannot generate the necessary CompilerPhase JFR events . > > This backport prevents `NeverActAsServerClassMachine` from being set during the test TestCompilerPhase, so that it isn't restricted to C1. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3045). > > Testing: running test/jdk/jdk/jfr/event/compiler/TestCompilerPhase.java test passes. This pull request has now been integrated. Changeset: ece9b2cd Author: Robert Toyonaga Committer: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/ece9b2cd3ba498d36832bc168237c3d60ecb4d4a Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8326521: JFR: CompilerPhase event test fails on windows 32 bit Backport-of: 96530bcc07514c3eda40fd6ffa74f197fe541dea ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2710 From clanger at openjdk.org Thu May 16 10:22:10 2024 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 16 May 2024 10:22:10 GMT Subject: [jdk11u-dev] Integrated: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list In-Reply-To: <_xaZxc4yPXuEHeRjtnUx3serjzw0U26DHWbkRnNSXKo=.ca8e5ded-d318-47b2-bea6-031fc3efc7c0@github.com> References: <_xaZxc4yPXuEHeRjtnUx3serjzw0U26DHWbkRnNSXKo=.ca8e5ded-d318-47b2-bea6-031fc3efc7c0@github.com> Message-ID: On Fri, 10 May 2024 11:32:29 GMT, Christoph Langer wrote: > Remove an obsolete problem list entry for ppc. Change had to be fitted into jdk11u, since lists diverge. This pull request has now been integrated. Changeset: 2a804f54 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/2a804f54aa8f921942e98557770446b06c19c1aa Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list Reviewed-by: mbaesken Backport-of: e552509bcbbba5562219355841cf3dedd7daaeb8 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2706 From clanger at openjdk.org Thu May 16 10:24:08 2024 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 16 May 2024 10:24:08 GMT Subject: [jdk17u-dev] Integrated: 8330523: Reduce runtime and improve efficiency of KeepAliveTest In-Reply-To: References: Message-ID: On Mon, 13 May 2024 12:56:26 GMT, Christoph Langer wrote: > This is a backport of a test improvement. I had to resolve some minor conflicts and make some small adaptions. This pull request has now been integrated. Changeset: 98038b3d Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/98038b3dfd8984c28a37646de6b1cdaa4c7ae6a3 Stats: 1242 lines in 1 file changed: 87 ins; 1023 del; 132 mod 8330523: Reduce runtime and improve efficiency of KeepAliveTest Reviewed-by: mbaesken Backport-of: c12dfc3571235bb57b2287e06c0cebb764f47a9a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2463 From mbaesken at openjdk.org Thu May 16 10:52:15 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 16 May 2024 10:52:15 GMT Subject: [jdk21u-dev] RFR: 8331298: avoid alignment checks in UBSAN enabled build Message-ID: <2uLV1DkZYmRwuADkOTBtGaHC5pKXzExnPKaYpOV7FbM=.e16d0404-16c9-4f0c-8f91-4724e15c4870@github.com> 8331298: avoid alignment checks in UBSAN enabled build ------------- Commit messages: - Backport 60b61e588c1252b4b1fbc64d0f818a85670f7146 Changes: https://git.openjdk.org/jdk21u-dev/pull/579/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=579&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331298 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/579.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/579/head:pull/579 PR: https://git.openjdk.org/jdk21u-dev/pull/579 From mbaesken at openjdk.org Thu May 16 11:01:19 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 16 May 2024 11:01:19 GMT Subject: [jdk22u] RFR: 8330464: hserr generic events - add entry for the before_exit calls Message-ID: 8330464: hserr generic events - add entry for the before_exit calls ------------- Commit messages: - Backport 45ed97f15b96071e5d6b6d21e8f0129eda5aa447 Changes: https://git.openjdk.org/jdk22u/pull/212/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=212&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330464 Stats: 7 lines in 2 files changed: 3 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk22u/pull/212.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/212/head:pull/212 PR: https://git.openjdk.org/jdk22u/pull/212 From jkratochvil at openjdk.org Thu May 16 11:24:09 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Thu, 16 May 2024 11:24:09 GMT Subject: [jdk17u-dev] Integrated: 8319268: Build failure with GCC8.3.1 after 8313643 In-Reply-To: References: Message-ID: On Thu, 16 May 2024 01:56:35 GMT, Jan Kratochvil wrote: > It has been requested in https://github.com/openjdk/jdk17u-dev/pull/2468#discussion_r1601617775 but I do not have this problem reproducible. > I have tried devtoolset-8-gcc-8.3.1-3.2.el7.x86_64 (CentOS-7) and gcc-8.3.0.tar.xz (rebuilt from source). This pull request has now been integrated. Changeset: 2440b242 Author: Jan Kratochvil Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/2440b2422c34c08c324362ce54471241e5e6dd7c Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8319268: Build failure with GCC8.3.1 after 8313643 Reviewed-by: mbaesken Backport-of: ec79ab4b3cd89c2c0a9c8550cd62433bd6d45266 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2475 From jkratochvil at openjdk.org Thu May 16 11:25:06 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Thu, 16 May 2024 11:25:06 GMT Subject: [jdk17u-dev] Integrated: 8328997: Remove unnecessary template parameter lists in GrowableArray In-Reply-To: <3ZSIQ-8yKrtnA6hgvKM4r_nA3BRkit14PejA7KtHrqA=.d5fea582-1122-41e8-8c3f-1e79d94f2455@github.com> References: <3ZSIQ-8yKrtnA6hgvKM4r_nA3BRkit14PejA7KtHrqA=.d5fea582-1122-41e8-8c3f-1e79d94f2455@github.com> Message-ID: On Tue, 14 May 2024 05:12:54 GMT, Jan Kratochvil wrote: > It is needed to build OpenJDK-17 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). > It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) (this [backport](https://github.com/openjdk/jdk17u-dev/pull/2466)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2467)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2468)). > Git cherry-pick was not clean but it was easy to apply. This pull request has now been integrated. Changeset: d17fa034 Author: Jan Kratochvil Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/d17fa034f72d914f9b2d30fe7eadef80f2159478 Stats: 13 lines in 1 file changed: 0 ins; 0 del; 13 mod 8328997: Remove unnecessary template parameter lists in GrowableArray Reviewed-by: mdoerr Backport-of: 3d2283800acee58dbf046c8b401a5a144ab65ed1 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2466 From jkratochvil at openjdk.org Thu May 16 11:26:05 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Thu, 16 May 2024 11:26:05 GMT Subject: [jdk17u-dev] Integrated: 8331352: error: template-id not allowed for constructor/destructor in C++20 In-Reply-To: References: Message-ID: On Tue, 14 May 2024 05:14:33 GMT, Jan Kratochvil wrote: > It is needed to build OpenJDK-17 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). > It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2466)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) (this [backport](https://github.com/openjdk/jdk17u-dev/pull/2467)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2468)). > Git cherry-pick was not clean but it was easy to apply. This pull request has now been integrated. Changeset: 261ad5e5 Author: Jan Kratochvil Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/261ad5e52debe47440270de59683e1ea6cfcc0a9 Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod 8331352: error: template-id not allowed for constructor/destructor in C++20 Reviewed-by: mdoerr Backport-of: 45792c5829fb1d5ee016c4a1fd6badb5d2b4239c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2467 From avieirov at redhat.com Thu May 16 11:33:00 2024 From: avieirov at redhat.com (Antonio Vieiro) Date: Thu, 16 May 2024 13:33:00 +0200 Subject: JDK <= 11 tests may fail when built with "--with-zlib=system" Message-ID: Hi all, The files generated with "jar" and "pack200" may have different sizes depending if OpenJDK was compiled with "--with-zlib=system" or "--with-zlib=bundled", even though the files are correctly compressed. As a consequence the tests "DeflateIn_InflateOut" and "PackTestZip64" in "java.base", which use the generated file size at different stages, may fail when "--with-zlib=system" is used. This is indeed the case in Fedora 40, where tier1 tests fail [4], [5] because of these tests. ### DeflateIn_InflateOut The problem with the "DeflateIn_InflateOut" test could be solved by backporting https://bugs.openjdk.org/browse/JDK-8240226 (which better handles the sizes of the generated files) to OpenJDK 11 and earlier. ### PackTestZip64 The PackTestZip64 test [2] uses the generated "pack200" tool to repack, pack and unpack a "golden.jar" file [3] (probably generated with --with-zlib=bundled), and expects that the resulting size of the file is equal to the original size of "golden.jar". File sizes are indeed equal if "pack200" was compiled with "--with-zlib=bundled" (so the repacking, packing and unpacking produces the very same golden.jar file). But when "pack200" is built with "--with-zlib=system" the repacking, packing and unpacking of golden.jar is being performed with the system library and may produce a golden.jar file that is equivalent to the original golden.jar file, although the length of the file is different. ## Proposed solution To ensure that OpenJDK 11 and earlier can be tested in a variety of systems with "--with-zlib=system" we could backport JDK-8240226 and we will need to create a bug for the PackTestZip64 test. The PackTestZip64 could be either: - Ignored - Updated to verify the integrity of the resulting files, instead of just checking the sizes of the files. Would it be possible to open a bug for PackTestZip64 so we can fix & backport it? Thanks, Antonio [1] https://fedoraproject.org/wiki/Changes/ZlibNGTransition [2] https://github.com/openjdk/jdk11u/blob/master/test/jdk/tools/pack200/PackTestZip64.java#L116 [3] https://github.com/openjdk/jdk11u/blob/42f70422f10472aa67ca86bfbac25a5d5c314ec2/test/jdk/tools/pack200/pack200-verifier/data/golden.jar [4] /home/avieirov/REPOS/OPENJDK/jdk11u-dev/build/linux-x86_64-normal-server-release/images/jdk/bin/unpack200 tools.pack.gz tools_native.jar Warning: The unpack200 tool is deprecated, and is planned for removal in a future JDK release. STDERR: java.io.IOException: Files are differ starting at position: 43630 at PackTestZip64.compareTwoFiles(PackTestZip64.java:117) at PackTestZip64.testPacking(PackTestZip64.java:89) at PackTestZip64.main(PackTestZip64.java:48) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333) at java.base/java.lang.Thread.run(Thread.java:829) JavaTest Message: Test threw exception: java.io.IOException JavaTest Message: shutting down test TEST RESULT: Failed. Execution failed: `main' threw exception: java.io.IOException: Files are differ starting at position: 43630 [5] https://bugzilla.redhat.com/show_bug.cgi?id=2280757 From mbaesken at openjdk.org Thu May 16 11:59:14 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 16 May 2024 11:59:14 GMT Subject: [jdk22u] RFR: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms Message-ID: <4wYNLFIS2epPtZCKdiAzOOf4CplfVvFDkPbl00CT7Rg=.f063bcb9-64d7-4546-875c-41b092853f3a@github.com> 8331031: unify os::dont_yield and os::naked_yield across Posix platforms ------------- Commit messages: - Backport c9442014e561f8e1cb43a0e9f18a9a5ae2a7a2da Changes: https://git.openjdk.org/jdk22u/pull/213/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=213&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331031 Stats: 45 lines in 4 files changed: 8 ins; 37 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/213.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/213/head:pull/213 PR: https://git.openjdk.org/jdk22u/pull/213 From jkratochvil at openjdk.org Thu May 16 12:25:13 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Thu, 16 May 2024 12:25:13 GMT Subject: [jdk17u-dev] RFR: 8324243: Compilation failures in java.desktop module with gcc 14 [v2] In-Reply-To: References: Message-ID: > It is needed to build OpenJDK-17 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). > It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2466)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2467)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) (this [backport](https://github.com/openjdk/jdk17u-dev/pull/2468)). > Git cherry-pick was not clean but it was easy to apply. Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'devmaster' into 8324243 - 8324243: Compilation failures in java.desktop module with gcc 14 Reviewed-by: jwaters, ihse, kbarrett, prr ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/2468/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2468&range=01 Stats: 6 lines in 4 files changed: 2 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2468.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2468/head:pull/2468 PR: https://git.openjdk.org/jdk17u-dev/pull/2468 From jkratochvil at openjdk.org Thu May 16 12:25:13 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Thu, 16 May 2024 12:25:13 GMT Subject: [jdk17u-dev] RFR: 8324243: Compilation failures in java.desktop module with gcc 14 [v2] In-Reply-To: References: <2ehvkjrw7WyR9AgBFuA4i1X4L29VL30iptCW7Q02FlI=.899db2a4-573f-4552-9e85-5c4b832a6231@github.com> Message-ID: <5rnlGcLu5potDOk3t1sbd2ErcJtlKpPxYpEMZmQI9fc=.446a4bd9-0de8-48f4-a37f-c19d5adb9531@github.com> On Thu, 16 May 2024 08:32:04 GMT, Martin Doerr wrote: >> I would like to backport it separately. The list of versions affected is different and moreover I do not have the problem reproducible. I have tried devtoolset-8-gcc-8.3.1-3.2.el7.x86_64 (CentOS-7) and gcc-8.3.0.tar.xz (rebuilt from source). I have tried to build this branch https://github.com/jankratochvil/jdk17u-dev/tree/8324243 . >> Filed as https://github.com/openjdk/jdk17u-dev/pull/2475 . > > Even better. Thanks! This should make this backport clean and no longer require a review. And it will make future backports which touch this code clean, too. Now it should look like: https://github.com/openjdk/jdk/commit/8e5f6ddb68572c0cc8b6e256e423706f6f7cec94 It was later reformatted a bit but that is a different patch: https://github.com/openjdk/jdk/commit/d292aabf05edf41e14eca1976142f63c7b54779e#diff-c75e2d581b3730cf900075cedb66ac72eaba40fbbd92eaac5710161830b572b4 ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2468#discussion_r1603239812 From clanger at openjdk.org Thu May 16 13:38:04 2024 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 16 May 2024 13:38:04 GMT Subject: [jdk17u-dev] Integrated: 8330815: Use pattern matching for instanceof in KeepAliveCache In-Reply-To: References: Message-ID: On Mon, 13 May 2024 12:59:18 GMT, Christoph Langer wrote: > Nearly clean backport from 21u-dev, only copyright conflicts. This pull request has now been integrated. Changeset: fed9693f Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/fed9693f6d956f0cd37478cc186f8316c1ba8b59 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8330815: Use pattern matching for instanceof in KeepAliveCache Backport-of: ddecbe52018fdb7556b04b20e8529eb430d3aa75 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2464 From jkratochvil at openjdk.org Thu May 16 13:55:17 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Thu, 16 May 2024 13:55:17 GMT Subject: [jdk17u-dev] RFR: 8324243: Compilation failures in java.desktop module with gcc 14 [v3] In-Reply-To: References: Message-ID: > It is needed to build OpenJDK-17 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). > It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2466)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2467)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) (this [backport](https://github.com/openjdk/jdk17u-dev/pull/2468)). > Git cherry-pick was not clean but it was easy to apply. Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision: Fix whitespace ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2468/files - new: https://git.openjdk.org/jdk17u-dev/pull/2468/files/0c19f678..bd9788c5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2468&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2468&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2468.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2468/head:pull/2468 PR: https://git.openjdk.org/jdk17u-dev/pull/2468 From syan at openjdk.org Thu May 16 14:12:02 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 16 May 2024 14:12:02 GMT Subject: [jdk22u] RFR: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all In-Reply-To: <-FdTbs36sjrZcSnw2fKXFbup9nh5-k0MzqYsQN9f7WU=.5e1ead90-2e63-4dcc-a8a5-aa04a0fa03a9@github.com> References: <-FdTbs36sjrZcSnw2fKXFbup9nh5-k0MzqYsQN9f7WU=.5e1ead90-2e63-4dcc-a8a5-aa04a0fa03a9@github.com> Message-ID: On Tue, 14 May 2024 08:21:38 GMT, SendaoYan wrote: > Hi all, > This is clean backport of [JDK-8331466](https://bugs.openjdk.org/browse/JDK-8331466). Only change the Problemlist.txt, the risk is low. The GHA test runner report a windows-x64 jtreg failure `java/util/zip/ZipFile/ZipSourceCache.java`, which has been recored in [JDK-8322078](https://bugs.openjdk.org/browse/JDK-8322078). I have been created a [backport](https://github.com/openjdk/jdk22u/pull/201) to fix this issue. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/202#issuecomment-2115356540 From mdoerr at openjdk.org Thu May 16 14:17:05 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 16 May 2024 14:17:05 GMT Subject: [jdk17u-dev] RFR: 8324243: Compilation failures in java.desktop module with gcc 14 [v3] In-Reply-To: References: Message-ID: On Thu, 16 May 2024 13:55:17 GMT, Jan Kratochvil wrote: >> It is needed to build OpenJDK-17 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). >> It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2466)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2467)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) (this [backport](https://github.com/openjdk/jdk17u-dev/pull/2468)). >> Git cherry-pick was not clean but it was easy to apply. > > Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision: > > Fix whitespace Thanks! Looks good, now. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2468#pullrequestreview-2060909059 From stuefe at openjdk.org Thu May 16 15:20:08 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 16 May 2024 15:20:08 GMT Subject: [jdk22u] RFR: 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095 In-Reply-To: <6GZysl2aK2mUvKC2KprNnrvaSR0Rv85igZEQ9DW-VE0=.8b7c3788-368f-4104-86b1-edc39514a5c3@github.com> References: <6GZysl2aK2mUvKC2KprNnrvaSR0Rv85igZEQ9DW-VE0=.8b7c3788-368f-4104-86b1-edc39514a5c3@github.com> Message-ID: On Wed, 15 May 2024 13:33:37 GMT, Tobias Hartmann wrote: >>> Ouch. So I missed this hunk during jdk22u backport? And I have not noticed, because -- in contrast to jdk21u backport -- I have not ran the full test suite for jdk22u, only the basic sanity tests around the change, in order to save testing time. >>> >>> Looks good, thanks for fixing. >> >> Sure, no problem. > > @tstuefe Could you please integrate this soon? The failures generate a lot of noise in our testing. Thanks! @TobiHartmann oops, sorry! I thought I had already. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/190#issuecomment-2115529331 From stuefe at openjdk.org Thu May 16 15:20:09 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 16 May 2024 15:20:09 GMT Subject: [jdk22u] Integrated: 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095 In-Reply-To: References: Message-ID: On Wed, 8 May 2024 14:21:21 GMT, Thomas Stuefe wrote: > Trivial, but somewhat urgent fix to a jdk-22-only problem brought by an unclean backport of https://bugs.openjdk.org/browse/JDK-8325095. This pull request has now been integrated. Changeset: f1eba2c8 Author: Thomas Stuefe URL: https://git.openjdk.org/jdk22u/commit/f1eba2c8f97165fc6cdd2df9fffa198f8e296cd3 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8331894: [jdk22] compiler/print/CompileCommandMemLimit.java fails after backporting JDK-8325095 Reviewed-by: kvn, shade ------------- PR: https://git.openjdk.org/jdk22u/pull/190 From rhalade at openjdk.org Thu May 16 18:01:07 2024 From: rhalade at openjdk.org (Rajan Halade) Date: Thu, 16 May 2024 18:01:07 GMT Subject: [jdk22u] Integrated: 8316138: Add GlobalSign 2 TLS root certificates In-Reply-To: References: Message-ID: On Wed, 15 May 2024 20:24:12 GMT, Rajan Halade wrote: > Backport to JDK 22u This pull request has now been integrated. Changeset: 51772640 Author: Rajan Halade URL: https://git.openjdk.org/jdk22u/commit/51772640f739425679ef589287fa06e75d7f963c Stats: 94 lines in 4 files changed: 91 ins; 0 del; 3 mod 8316138: Add GlobalSign 2 TLS root certificates Backport-of: 4083255440cfbf39b9683ea88a433d71ec6111e7 ------------- PR: https://git.openjdk.org/jdk22u/pull/209 From zgu at openjdk.org Thu May 16 20:14:11 2024 From: zgu at openjdk.org (Zhengyu Gu) Date: Thu, 16 May 2024 20:14:11 GMT Subject: [jdk22u] RFR: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx In-Reply-To: References: Message-ID: On Mon, 13 May 2024 15:07:13 GMT, Zhengyu Gu wrote: > Clean backport Approved ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/200#issuecomment-2116094473 From zgu at openjdk.org Thu May 16 20:14:12 2024 From: zgu at openjdk.org (Zhengyu Gu) Date: Thu, 16 May 2024 20:14:12 GMT Subject: [jdk22u] Integrated: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx In-Reply-To: References: Message-ID: On Mon, 13 May 2024 15:07:13 GMT, Zhengyu Gu wrote: > Clean backport This pull request has now been integrated. Changeset: 9e3344e2 Author: Zhengyu Gu URL: https://git.openjdk.org/jdk22u/commit/9e3344e20ab80925a89d31bea73263f30e4e4594 Stats: 11 lines in 1 file changed: 6 ins; 3 del; 2 mod 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx Backport-of: aca1e8365bf0f64bf18caf798bbca1d25b3c4117 ------------- PR: https://git.openjdk.org/jdk22u/pull/200 From dhanalla at openjdk.org Thu May 16 20:21:43 2024 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Thu, 16 May 2024 20:21:43 GMT Subject: [jdk11u-dev] RFR: 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match" Message-ID: backport of c0dce25756911ce49e7d8b034d5f12a25fc3c81d ------------- Commit messages: - backport 8236917: TestInstanceKlassSize.java fails with The size computed by SA for java.lang.Object does not match - 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match" Changes: https://git.openjdk.org/jdk11u-dev/pull/2712/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2712&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8236917 Stats: 5 lines in 2 files changed: 1 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2712.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2712/head:pull/2712 PR: https://git.openjdk.org/jdk11u-dev/pull/2712 From serb at openjdk.org Thu May 16 21:46:16 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 16 May 2024 21:46:16 GMT Subject: [jdk22u] RFR: 8332253: Linux arm32 build fails after 8292591 Message-ID: Hi all, This pull request contains a backport of commit [95f79c67](https://github.com/openjdk/jdk/commit/95f79c678737fb8de9ed45c516761d4d818869ef) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 16 May 2024 and was reviewed by Thomas Stuefe, David Holmes and Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport 95f79c678737fb8de9ed45c516761d4d818869ef Changes: https://git.openjdk.org/jdk22u/pull/210/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=210&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332253 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/210.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/210/head:pull/210 PR: https://git.openjdk.org/jdk22u/pull/210 From serb at openjdk.org Thu May 16 21:46:23 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 16 May 2024 21:46:23 GMT Subject: [jdk21u-dev] RFR: 8332253: Linux arm32 build fails after 8292591 Message-ID: Hi all, This pull request contains a backport of commit [95f79c67](https://github.com/openjdk/jdk/commit/95f79c678737fb8de9ed45c516761d4d818869ef) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 16 May 2024 and was reviewed by Thomas Stuefe, David Holmes and Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport 95f79c678737fb8de9ed45c516761d4d818869ef Changes: https://git.openjdk.org/jdk21u-dev/pull/576/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=576&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332253 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/576.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/576/head:pull/576 PR: https://git.openjdk.org/jdk21u-dev/pull/576 From mdoerr at openjdk.org Thu May 16 21:55:12 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 16 May 2024 21:55:12 GMT Subject: [jdk21u-dev] Integrated: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader In-Reply-To: References: Message-ID: On Wed, 15 May 2024 10:42:24 GMT, Martin Doerr wrote: > Clean backport of [JDK-8308144](https://bugs.openjdk.org/browse/JDK-8308144). This pull request has now been integrated. Changeset: 0a2e2e70 Author: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/0a2e2e707dce937cd134f07a692084449247db5b Stats: 662 lines in 3 files changed: 642 ins; 0 del; 20 mod 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader Backport-of: 099a8f5b2f924fddd43ff72f3f7c6f34b6c15b0f ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/571 From martin.doerr at sap.com Thu May 16 22:04:43 2024 From: martin.doerr at sap.com (Doerr, Martin) Date: Thu, 16 May 2024 22:04:43 +0000 Subject: AW: [jdk17u-dev] Requesting backport of JDK-8308144 Uncontrolled memory consumption in SSLFlowDelegate.Reader In-Reply-To: References: Message-ID: Hello, we are shipping the fix with JDK 21.0.4 in July. JDK 17 will probably follow in the October update. Best regards, Martin Von: jdk-updates-dev im Auftrag von digital-connectivity-dev Datum: Dienstag, 14. Mai 2024 um 15:00 An: jdk-updates-dev at openjdk.org Betreff: [jdk17u-dev] Requesting backport of JDK-8308144 Uncontrolled memory consumption in SSLFlowDelegate.Reader Some people who received this message don't often get email from digital-connectivity-dev at man-es.com. Learn why this is important Hello, we have been affected by the JDK bug ?Uncontrolled memory consumption in SSLFlowDelegate.Reader? that was reported and fixed here: https://bugs.openjdk.org/browse/JDK-8308144 This resulted in an OOM Exception and program crash for us when downloading a large file (~2Gb) running in an environment with limited heap memory (~500Mb). Aside from documentation and tests, the patch committed last November to correct the issue was one line long. However, the fix was only made to JDK 22 and 23: https://github.com/openjdk/jdk/pull/16704 We did not understand the low priority of the issue (P4) as we see no way around the problem and we would have to wait until 2025 for the next LTS release with this fix. We would greatly appreciate it if this fix could instead be backported to earlier LTS JDKs, ideally including JDK 17. Would someone be able to do this for us? We would be uncomfortable attempting to merge this ourselves. If so, would it plausibly make the July release? (Sorry for the repost, the tag was missing in the thread name) Many thanks. MAN Energy Solutions SE Vorsitzender des Aufsichtsrates: Gunnar Kilian Vorstand: Dr. Uwe Lauber (Vorsitzender), J?rgen Kl?pffer, Martin Oetjen, Ingrid Rieken, Dr. Gunnar Stiesch Sitz der Gesellschaft: Augsburg Registergericht: Amtsgericht Augsburg, HRB 22056 This e-mail (including any attachments) is confidential and may be privileged. If you have received it by mistake, please notify the sender by e-mail and delete it from your system. Any unauthorized use or dissemination of this e-mail or its contents in whole or in part is strictly prohibited. Please note that e-mails are susceptible to change. MAN Energy Solutions SE (including its group companies) shall not be liable for the improper or incomplete transmission of the information contained in this communication nor for any delay in its receipt. MAN Energy Solutions SE (or its group companies) does not guarantee that the integrity of this communication has been maintained nor that this communication is free of viruses, interceptions or interference. -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrewlu at openjdk.org Fri May 17 05:37:27 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 17 May 2024 05:37:27 GMT Subject: [jdk21u-dev] RFR: 8321107: Add more test cases for JDK-8319372 Message-ID: <2UKKkB-lLUGoq-23zKHQvxAvVZiKBCIPvKwjAraInIY=.51b549b8-f359-448f-bb24-ae3b992032c3@github.com> I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport ecd335d8f42757d332f217e220e1a9db8c48c8d6 Changes: https://git.openjdk.org/jdk21u-dev/pull/582/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=582&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321107 Stats: 134 lines in 1 file changed: 134 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/582.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/582/head:pull/582 PR: https://git.openjdk.org/jdk21u-dev/pull/582 From andrewlu at openjdk.org Fri May 17 05:41:20 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 17 May 2024 05:41:20 GMT Subject: [jdk17u-dev] RFR: 8321107: Add more test cases for JDK-8319372 Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport ecd335d8f42757d332f217e220e1a9db8c48c8d6 Changes: https://git.openjdk.org/jdk17u-dev/pull/2476/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2476&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321107 Stats: 134 lines in 1 file changed: 134 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2476.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2476/head:pull/2476 PR: https://git.openjdk.org/jdk17u-dev/pull/2476 From mbaesken at openjdk.org Fri May 17 06:41:14 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 17 May 2024 06:41:14 GMT Subject: [jdk22u] Integrated: 8331298: avoid alignment checks in UBSAN enabled build In-Reply-To: References: Message-ID: On Tue, 14 May 2024 12:05:49 GMT, Matthias Baesken wrote: > 8331298: avoid alignment checks in UBSAN enabled build This pull request has now been integrated. Changeset: 6e66ee15 Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/6e66ee15b13c9ef92ba54db7c39aa57fc60733f3 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8331298: avoid alignment checks in UBSAN enabled build Backport-of: 60b61e588c1252b4b1fbc64d0f818a85670f7146 ------------- PR: https://git.openjdk.org/jdk22u/pull/204 From mbaesken at openjdk.org Fri May 17 07:49:04 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 17 May 2024 07:49:04 GMT Subject: [jdk21u-dev] RFR: 8312218: Print additional debug information when hitting assert(in_hash) In-Reply-To: References: Message-ID: On Wed, 15 May 2024 11:35:02 GMT, Matthias Baesken wrote: > 8312218: Print additional debug information when hitting assert(in_hash) linux-x64 upload failure seems to be unrelated. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/572#issuecomment-2116948766 From mbaesken at openjdk.org Fri May 17 07:49:04 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 17 May 2024 07:49:04 GMT Subject: [jdk21u-dev] Integrated: 8312218: Print additional debug information when hitting assert(in_hash) In-Reply-To: References: Message-ID: On Wed, 15 May 2024 11:35:02 GMT, Matthias Baesken wrote: > 8312218: Print additional debug information when hitting assert(in_hash) This pull request has now been integrated. Changeset: f953b8a1 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/f953b8a1daf823ea895aa99f99e2a10626e1397c Stats: 10 lines in 1 file changed: 9 ins; 0 del; 1 mod 8312218: Print additional debug information when hitting assert(in_hash) Backport-of: 7cbab1f39636f3cf32f1276bc46feaa8107a14e6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/572 From mbaesken at openjdk.org Fri May 17 07:57:10 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 17 May 2024 07:57:10 GMT Subject: [jdk21u-dev] Integrated: 8331298: avoid alignment checks in UBSAN enabled build In-Reply-To: <2uLV1DkZYmRwuADkOTBtGaHC5pKXzExnPKaYpOV7FbM=.e16d0404-16c9-4f0c-8f91-4724e15c4870@github.com> References: <2uLV1DkZYmRwuADkOTBtGaHC5pKXzExnPKaYpOV7FbM=.e16d0404-16c9-4f0c-8f91-4724e15c4870@github.com> Message-ID: On Thu, 16 May 2024 10:47:22 GMT, Matthias Baesken wrote: > 8331298: avoid alignment checks in UBSAN enabled build This pull request has now been integrated. Changeset: 9047499a Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/9047499a46447986e27e81927e7be222ad6b8406 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8331298: avoid alignment checks in UBSAN enabled build Backport-of: 60b61e588c1252b4b1fbc64d0f818a85670f7146 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/579 From andrewlu at openjdk.org Fri May 17 08:08:10 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 17 May 2024 08:08:10 GMT Subject: [jdk21u-dev] Integrated: 8320715: Improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16 In-Reply-To: <_xE7rHuZa0bf4gRMxlJU3wXAbITIaYA68XqzwEawqGw=.a1d6c563-929c-4efa-aa6f-af284a3a0e7b@github.com> References: <_xE7rHuZa0bf4gRMxlJU3wXAbITIaYA68XqzwEawqGw=.a1d6c563-929c-4efa-aa6f-af284a3a0e7b@github.com> Message-ID: On Thu, 16 May 2024 05:30:42 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 2dc90b51 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/2dc90b51516e0a04878dd0f5e9a6a704977a36f7 Stats: 44 lines in 3 files changed: 28 ins; 0 del; 16 mod 8320715: Improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16 Backport-of: 5dcf3a56cb425c3419273636729d2d83603be0d2 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/577 From andrewlu at openjdk.org Fri May 17 08:10:11 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 17 May 2024 08:10:11 GMT Subject: [jdk11u-dev] Integrated: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError In-Reply-To: References: Message-ID: <6QHi5rqEn56BiJKOcE1C3pjzHJ70gT4aHG5outnI_9c=.603a9afa-2677-457d-8bf2-22bddbd061a9@github.com> On Mon, 13 May 2024 05:23:34 GMT, Andrew Lu wrote: > This PR contains a backport of > https://github.com/openjdk/jdk/commit/12e943091071b02b5756b57527a5f86a3d881cb8 > Patch is not clean, this file test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/hs201t002.cpp has changed by other commits, I ignored these commits and only change code for this issue. > Other than that the rest of the code is clean. This pull request has now been integrated. Changeset: 1d6965fd Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/1d6965fd4eba8c22589f1833e3a1639f05ada771 Stats: 157 lines in 4 files changed: 65 ins; 55 del; 37 mod 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError Reviewed-by: mdoerr Backport-of: f12200cd11c2b689618cde1902db941ee23fbf80 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2707 From jkratochvil at openjdk.org Fri May 17 08:29:12 2024 From: jkratochvil at openjdk.org (Jan Kratochvil) Date: Fri, 17 May 2024 08:29:12 GMT Subject: [jdk17u-dev] Integrated: 8324243: Compilation failures in java.desktop module with gcc 14 In-Reply-To: References: Message-ID: <8EXksCKg1RWECpVF3RkweXnXXLQrL9pGF5C2BhPam_k=.c5fe3f9c-e791-4b70-a5f4-626850e0efa3@github.com> On Tue, 14 May 2024 05:15:33 GMT, Jan Kratochvil wrote: > It is needed to build OpenJDK-17 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64). > It needs all of [JDK-8328997](https://bugs.openjdk.org/browse/JDK-8328997) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2466)), [JDK-8331352](https://bugs.openjdk.org/browse/JDK-8331352) ([backport](https://github.com/openjdk/jdk17u-dev/pull/2467)) and [JDK-8324243](https://bugs.openjdk.org/browse/JDK-8324243) (this [backport](https://github.com/openjdk/jdk17u-dev/pull/2468)). > Git cherry-pick was not clean but it was easy to apply. This pull request has now been integrated. Changeset: 0e524e2f Author: Jan Kratochvil Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/0e524e2f476835885b34e221e64d8e12a9a1d792 Stats: 6 lines in 4 files changed: 2 ins; 0 del; 4 mod 8324243: Compilation failures in java.desktop module with gcc 14 Reviewed-by: mdoerr Backport-of: 8e5f6ddb68572c0cc8b6e256e423706f6f7cec94 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2468 From lmao at openjdk.org Fri May 17 08:47:29 2024 From: lmao at openjdk.org (Liang Mao) Date: Fri, 17 May 2024 08:47:29 GMT Subject: [jdk21u-dev] RFR: 8329840: Fix ZPhysicalMemorySegment::_end type Message-ID: Clean backport of fixing type of ZPhysicalMemorySegment::_end type ------------- Commit messages: - Backport b4ddddeff1ce4293c88a9ab8ad3ca9d3b0e2352e Changes: https://git.openjdk.org/jdk21u-dev/pull/583/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=583&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329840 Stats: 56 lines in 4 files changed: 49 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/583.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/583/head:pull/583 PR: https://git.openjdk.org/jdk21u-dev/pull/583 From andrewlu at openjdk.org Fri May 17 08:53:41 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 17 May 2024 08:53:41 GMT Subject: [jdk21u-dev] RFR: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 9731b1c8b02d957985f4fb40acd93fb67747a9f0 Changes: https://git.openjdk.org/jdk21u-dev/pull/584/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=584&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327137 Stats: 273 lines in 1 file changed: 273 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/584.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/584/head:pull/584 PR: https://git.openjdk.org/jdk21u-dev/pull/584 From andrewlu at openjdk.org Fri May 17 08:57:19 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 17 May 2024 08:57:19 GMT Subject: [jdk17u-dev] RFR: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport 9731b1c8b02d957985f4fb40acd93fb67747a9f0 Changes: https://git.openjdk.org/jdk17u-dev/pull/2477/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2477&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327137 Stats: 273 lines in 1 file changed: 273 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2477.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2477/head:pull/2477 PR: https://git.openjdk.org/jdk17u-dev/pull/2477 From andrewlu at openjdk.org Fri May 17 08:59:39 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 17 May 2024 08:59:39 GMT Subject: [jdk11u-dev] RFR: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 9731b1c8b02d957985f4fb40acd93fb67747a9f0 Changes: https://git.openjdk.org/jdk11u-dev/pull/2713/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2713&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327137 Stats: 273 lines in 1 file changed: 273 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2713.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2713/head:pull/2713 PR: https://git.openjdk.org/jdk11u-dev/pull/2713 From lmao at openjdk.org Fri May 17 09:10:14 2024 From: lmao at openjdk.org (Liang Mao) Date: Fri, 17 May 2024 09:10:14 GMT Subject: [jdk21u-dev] RFR: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads Message-ID: <1p8tz83C090_7tXTOq2k2REmG0usw4ivORdZAFBfo6M=.4a2ae875-43fb-43ae-b483-8adaef4aa858@github.com> Clean backport of fixing crash on Threads::print_on() . ------------- Commit messages: - Backport c1cfb43d8de8d0eed01b9bb6aa1202dc7cbff007 Changes: https://git.openjdk.org/jdk21u-dev/pull/585/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=585&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329109 Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/585.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/585/head:pull/585 PR: https://git.openjdk.org/jdk21u-dev/pull/585 From duke at openjdk.org Fri May 17 10:06:30 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 17 May 2024 10:06:30 GMT Subject: [jdk21u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates Message-ID: Backport from https://bugs.openjdk.org/browse/JDK-8316138 ------------- Commit messages: - Backport 4083255440cfbf39b9683ea88a433d71ec6111e7 Changes: https://git.openjdk.org/jdk21u-dev/pull/581/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=581&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316138 Stats: 94 lines in 4 files changed: 91 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/581.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/581/head:pull/581 PR: https://git.openjdk.org/jdk21u-dev/pull/581 From duke at openjdk.org Fri May 17 10:06:30 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 17 May 2024 10:06:30 GMT Subject: [jdk21u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates In-Reply-To: References: Message-ID: <9as_RAxE6kZLe9FJRmSS6inycCzGjoUN2jep2Eyyg9E=.512bb76f-b0f3-4df0-9352-8e107cb0271d@github.com> On Thu, 16 May 2024 14:40:19 GMT, Mar?a Arias de Reyna wrote: > Backport from https://bugs.openjdk.org/browse/JDK-8316138 $ make test TEST="jdk_security" | grep VerifyCACerts Passed: sun/security/lib/cacerts/VerifyCACerts.java ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/581#issuecomment-2117203134 From duke at openjdk.org Fri May 17 10:13:11 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 17 May 2024 10:13:11 GMT Subject: [jdk21u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates In-Reply-To: References: Message-ID: On Thu, 16 May 2024 14:40:19 GMT, Mar?a Arias de Reyna wrote: > Backport from https://bugs.openjdk.org/browse/JDK-8316138 @jerboaa Can you review this? There is still a test running in MacOS that failed yesterday, but I think it is not related to my change. The test that checks the certificates runs properly on my local machine: $ make test TEST="jdk_security" | grep VerifyCACerts Passed: sun/security/lib/cacerts/VerifyCACerts.java``` ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/581#issuecomment-2117220163 From syan at openjdk.org Fri May 17 10:33:14 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 17 May 2024 10:33:14 GMT Subject: [jdk22u] Integrated: 8322078: ZipSourceCache.testKeySourceMapping() test fails with The process cannot access the file because it is being used by another process In-Reply-To: References: Message-ID: On Tue, 14 May 2024 01:52:57 GMT, SendaoYan wrote: > Hi all, > > This is clean backport of [JDK-8322078](https://bugs.openjdk.org/browse/JDK-8322078). The change has been verified on windows-x64. The risk is low. This pull request has now been integrated. Changeset: 01d0fdad Author: SendaoYan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/01d0fdadeb0043c179b3822430021f3b3bdf5285 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8322078: ZipSourceCache.testKeySourceMapping() test fails with The process cannot access the file because it is being used by another process Backport-of: f6fe39ff1168d27f4d0ea3e4c7f3f17ecae9e1ab ------------- PR: https://git.openjdk.org/jdk22u/pull/201 From syan at openjdk.org Fri May 17 10:35:08 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 17 May 2024 10:35:08 GMT Subject: [jdk22u] Integrated: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all In-Reply-To: <-FdTbs36sjrZcSnw2fKXFbup9nh5-k0MzqYsQN9f7WU=.5e1ead90-2e63-4dcc-a8a5-aa04a0fa03a9@github.com> References: <-FdTbs36sjrZcSnw2fKXFbup9nh5-k0MzqYsQN9f7WU=.5e1ead90-2e63-4dcc-a8a5-aa04a0fa03a9@github.com> Message-ID: On Tue, 14 May 2024 08:21:38 GMT, SendaoYan wrote: > Hi all, > This is clean backport of [JDK-8331466](https://bugs.openjdk.org/browse/JDK-8331466). Only change the Problemlist.txt, the risk is low. This pull request has now been integrated. Changeset: fdb8491a Author: SendaoYan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/fdb8491a15648da99dd5dc07c7f0df10b5a152d3 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all Backport-of: 440782e0160f867f08afbec0abf48d557a522c72 ------------- PR: https://git.openjdk.org/jdk22u/pull/202 From mdoerr at openjdk.org Fri May 17 10:38:33 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 17 May 2024 10:38:33 GMT Subject: [jdk21u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates Message-ID: Clean backport of [JDK-8316138](https://bugs.openjdk.org/browse/JDK-8316138). ------------- Commit messages: - Backport 4083255440cfbf39b9683ea88a433d71ec6111e7 Changes: https://git.openjdk.org/jdk21u-dev/pull/586/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=586&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316138 Stats: 94 lines in 4 files changed: 91 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/586.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/586/head:pull/586 PR: https://git.openjdk.org/jdk21u-dev/pull/586 From syan at openjdk.org Fri May 17 10:44:02 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 17 May 2024 10:44:02 GMT Subject: [jdk22u] RFR: 8322078: ZipSourceCache.testKeySourceMapping() test fails with The process cannot access the file because it is being used by another process In-Reply-To: References: Message-ID: On Tue, 14 May 2024 01:52:57 GMT, SendaoYan wrote: > Hi all, > > This is clean backport of [JDK-8322078](https://bugs.openjdk.org/browse/JDK-8322078). The change has been verified on windows-x64. The risk is low. > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/201#issuecomment-2117281451 From mdoerr at openjdk.org Fri May 17 10:54:06 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 17 May 2024 10:54:06 GMT Subject: [jdk21u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates In-Reply-To: References: Message-ID: On Fri, 17 May 2024 10:32:37 GMT, Martin Doerr wrote: > Clean backport of [JDK-8316138](https://bugs.openjdk.org/browse/JDK-8316138). There's another PR: https://github.com/openjdk/jdk21u-dev/pull/581 ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/586#issuecomment-2117304645 From mdoerr at openjdk.org Fri May 17 10:54:07 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 17 May 2024 10:54:07 GMT Subject: [jdk21u-dev] Withdrawn: 8316138: Add GlobalSign 2 TLS root certificates In-Reply-To: References: Message-ID: On Fri, 17 May 2024 10:32:37 GMT, Martin Doerr wrote: > Clean backport of [JDK-8316138](https://bugs.openjdk.org/browse/JDK-8316138). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/586 From duke at openjdk.org Fri May 17 11:13:14 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 17 May 2024 11:13:14 GMT Subject: [jdk17u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates Message-ID: Backport for https://bugs.openjdk.org/browse/JDK-8316138 Related to https://github.com/openjdk/jdk21u-dev/pull/581 Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. ------------- Commit messages: - Backport 4083255440cfbf39b9683ea88a433d71ec6111e7 Changes: https://git.openjdk.org/jdk17u-dev/pull/2479/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2479&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316138 Stats: 94 lines in 4 files changed: 91 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2479.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2479/head:pull/2479 PR: https://git.openjdk.org/jdk17u-dev/pull/2479 From duke at openjdk.org Fri May 17 11:13:14 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 17 May 2024 11:13:14 GMT Subject: [jdk17u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates In-Reply-To: References: Message-ID: On Fri, 17 May 2024 11:04:55 GMT, Mar?a Arias de Reyna wrote: > Backport for https://bugs.openjdk.org/browse/JDK-8316138 > > Related to https://github.com/openjdk/jdk21u-dev/pull/581 > > Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. @TheRealMDoerr redid #2478 because force pushing does not suit well with the jdk bot :) But here we are. $ make test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java" Building target 'test' in configuration 'linux-x86_64-server-release' Creating jdk image Creating CDS archive for jdk image Creating CDS-NOCOOPS archive for jdk image Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run: * jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' Passed: sun/security/lib/cacerts/VerifyCACerts.java Test results: passed: 1 Report written to /home/delawen/git/jdk17u-dev/build/linux-x86_64-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html Results written to /home/delawen/git/jdk17u-dev/build/linux-x86_64-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' Test report is stored in build/linux-x86_64-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java 1 1 0 0 ============================== TEST SUCCESS Finished building target 'test' in configuration 'linux-x86_64-server-release' @jerboaa Here is the backport of the certificates for JDK17 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2479#issuecomment-2117332487 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2479#issuecomment-2117337099 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2479#issuecomment-2117339910 From mdoerr at openjdk.org Fri May 17 11:16:07 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 17 May 2024 11:16:07 GMT Subject: [jdk17u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates In-Reply-To: References: Message-ID: On Fri, 17 May 2024 11:04:55 GMT, Mar?a Arias de Reyna wrote: > Backport for https://bugs.openjdk.org/browse/JDK-8316138 > > Related to https://github.com/openjdk/jdk21u-dev/pull/581 > > Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. LGTM. Thanks for backporting it! We want to ship it with 17.0.12. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2479#pullrequestreview-2063037526 From sgehwolf at openjdk.org Fri May 17 11:53:03 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 17 May 2024 11:53:03 GMT Subject: [jdk21u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates In-Reply-To: References: Message-ID: On Fri, 17 May 2024 10:10:47 GMT, Mar?a Arias de Reyna wrote: >> Backport from https://bugs.openjdk.org/browse/JDK-8316138 > > @jerboaa Can you review this? There is still a test running in MacOS that failed yesterday, but I think it is not related to my change. > > The test that checks the certificates runs properly on my local machine: > > $ make test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java" > Building target 'test' in configuration 'linux-x86_64-server-release' > Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run: > * jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java > > Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' > Passed: sun/security/lib/cacerts/VerifyCACerts.java > Test results: passed: 1 > Report written to /home/delawen/git/jdk21u-dev/build/linux-x86_64-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html > Results written to /home/delawen/git/jdk21u-dev/build/linux-x86_64-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java > Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' > Test report is stored in build/linux-x86_64-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Finished building target 'test' in configuration 'linux-x86_64-server-release' @Delawen Please also run the CA tests in `CertPathValidator/certification` test. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/581#issuecomment-2117425132 From duke at openjdk.org Fri May 17 13:40:11 2024 From: duke at openjdk.org (duke) Date: Fri, 17 May 2024 13:40:11 GMT Subject: [jdk21u-dev] Withdrawn: 8325730: StringBuilder.toString allocation for the empty String In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 19:21:42 GMT, Aleksey Shipilev wrote: > Clean backport to resolve the regression introduced in JDK 19. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `all` This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/364 From duke at openjdk.org Fri May 17 13:48:23 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 17 May 2024 13:48:23 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates Message-ID: Backport for https://bugs.openjdk.org/browse/JDK-8316138 Related to https://github.com/openjdk/jdk21u-dev/pull/581 and https://github.com/openjdk/jdk17u-dev/pull/2479 Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. ]$ make run-test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java" Building target 'run-test' in configuration 'linux-x86_64-normal-server-release' Skip building of Graal unit tests because 3rd party libraries directory is not specified Skip building of Graal unit tests because 3rd party libraries directory is not specified Creating jdk image Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run: * jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' Passed: sun/security/lib/cacerts/VerifyCACerts.java Test results: passed: 1 Report written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html Results written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' Test report is stored in build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java 1 1 0 0 ============================== TEST SUCCESS Finished building target 'run-test' in configuration 'linux-x86_64-normal-server-release' ------------- Commit messages: - Backport 4083255440cfbf39b9683ea88a433d71ec6111e7 Changes: https://git.openjdk.org/jdk11u-dev/pull/2715/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2715&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316138 Stats: 93 lines in 4 files changed: 90 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2715.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2715/head:pull/2715 PR: https://git.openjdk.org/jdk11u-dev/pull/2715 From duke at openjdk.org Fri May 17 14:10:18 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 17 May 2024 14:10:18 GMT Subject: [jdk21u-dev] Integrated: 8316138: Add GlobalSign 2 TLS root certificates In-Reply-To: References: Message-ID: On Thu, 16 May 2024 14:40:19 GMT, Mar?a Arias de Reyna wrote: > Backport from https://bugs.openjdk.org/browse/JDK-8316138 This pull request has now been integrated. Changeset: ff295b7f Author: Mar?a Arias de Reyna Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk21u-dev/commit/ff295b7fc417d4ce690d70015a1633ded67eceaa Stats: 94 lines in 4 files changed: 91 ins; 0 del; 3 mod 8316138: Add GlobalSign 2 TLS root certificates Backport-of: 4083255440cfbf39b9683ea88a433d71ec6111e7 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/581 From duke at openjdk.org Fri May 17 14:14:12 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 17 May 2024 14:14:12 GMT Subject: [jdk17u-dev] Integrated: 8316138: Add GlobalSign 2 TLS root certificates In-Reply-To: References: Message-ID: <98fD9eH2lAtwJsmoR2GBk-tyUl9SJh7gmOfxCtEjrB4=.7d9e8546-e19f-44c3-a921-a7e44a41031a@github.com> On Fri, 17 May 2024 11:04:55 GMT, Mar?a Arias de Reyna wrote: > Backport for https://bugs.openjdk.org/browse/JDK-8316138 > > Related to https://github.com/openjdk/jdk21u-dev/pull/581 > > Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. This pull request has now been integrated. Changeset: 95f8dc0d Author: Mar?a Arias de Reyna Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk17u-dev/commit/95f8dc0df2c4bd5d63d05b053ec6541d57ce0876 Stats: 94 lines in 4 files changed: 91 ins; 0 del; 3 mod 8316138: Add GlobalSign 2 TLS root certificates Reviewed-by: mdoerr Backport-of: 4083255440cfbf39b9683ea88a433d71ec6111e7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2479 From duke at openjdk.org Fri May 17 14:15:09 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 17 May 2024 14:15:09 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates In-Reply-To: References: Message-ID: On Fri, 17 May 2024 13:41:43 GMT, Mar?a Arias de Reyna wrote: > Backport for https://bugs.openjdk.org/browse/JDK-8316138 > > Related to https://github.com/openjdk/jdk21u-dev/pull/581 and https://github.com/openjdk/jdk17u-dev/pull/2479 > > Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. > > > ]$ make run-test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java" > Building target 'run-test' in configuration 'linux-x86_64-normal-server-release' > Skip building of Graal unit tests because 3rd party libraries directory is not specified > Skip building of Graal unit tests because 3rd party libraries directory is not specified > Creating jdk image > Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run: > * jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java > > Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' > Passed: sun/security/lib/cacerts/VerifyCACerts.java > Test results: passed: 1 > Report written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html > Results written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java > Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' > Test report is stored in build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Finished building target 'run-test' in configuration 'linux-x86_64-normal-server-release' @jerboaa @TheRealMDoerr Similar to the previous PR now in JDK 11 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2715#issuecomment-2117700825 From sgehwolf at openjdk.org Fri May 17 14:25:09 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 17 May 2024 14:25:09 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates In-Reply-To: References: Message-ID: On Fri, 17 May 2024 13:41:43 GMT, Mar?a Arias de Reyna wrote: > Backport for https://bugs.openjdk.org/browse/JDK-8316138 > > Related to https://github.com/openjdk/jdk21u-dev/pull/581 and https://github.com/openjdk/jdk17u-dev/pull/2479 > > Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. > > > ]$ make run-test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java" > Building target 'run-test' in configuration 'linux-x86_64-normal-server-release' > Skip building of Graal unit tests because 3rd party libraries directory is not specified > Skip building of Graal unit tests because 3rd party libraries directory is not specified > Creating jdk image > Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run: > * jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java > > Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' > Passed: sun/security/lib/cacerts/VerifyCACerts.java > Test results: passed: 1 > Report written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html > Results written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java > Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' > Test report is stored in build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Finished building target 'run-test' in configuration 'linux-x86_64-normal-server-release' test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java line 659: > 657: case "globalsignr46" -> > 658: new CATestURLs("https://valid.r46.roots.globalsign.com", > 659: "https://revoked.r46.roots.globalsign.com"); Does this compile? Switch expressions are JDK 14+. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2715#discussion_r1605097245 From duke at openjdk.org Fri May 17 14:32:22 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 17 May 2024 14:32:22 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v2] In-Reply-To: References: Message-ID: > Backport for https://bugs.openjdk.org/browse/JDK-8316138 > > Related to https://github.com/openjdk/jdk21u-dev/pull/581 and https://github.com/openjdk/jdk17u-dev/pull/2479 > > Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. > > > ]$ make run-test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java" > Building target 'run-test' in configuration 'linux-x86_64-normal-server-release' > Skip building of Graal unit tests because 3rd party libraries directory is not specified > Skip building of Graal unit tests because 3rd party libraries directory is not specified > Creating jdk image > Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run: > * jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java > > Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' > Passed: sun/security/lib/cacerts/VerifyCACerts.java > Test results: passed: 1 > Report written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html > Results written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java > Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' > Test report is stored in build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Finished building target 'run-test' in configuration 'linux-x86_64-normal-server-release' Mar?a Arias de Reyna has updated the pull request incrementally with one additional commit since the last revision: Fix switch expression that is too new for this JDK ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2715/files - new: https://git.openjdk.org/jdk11u-dev/pull/2715/files/6804bf3b..c75901fc Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2715&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2715&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2715.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2715/head:pull/2715 PR: https://git.openjdk.org/jdk11u-dev/pull/2715 From duke at openjdk.org Fri May 17 14:32:22 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 17 May 2024 14:32:22 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v2] In-Reply-To: References: Message-ID: On Fri, 17 May 2024 14:22:35 GMT, Severin Gehwolf wrote: >> Mar?a Arias de Reyna has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix switch expression that is too new for this JDK > > test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java line 659: > >> 657: case "globalsignr46" -> >> 658: new CATestURLs("https://valid.r46.roots.globalsign.com", >> 659: "https://revoked.r46.roots.globalsign.com"); > > Does this compile? Switch expressions are JDK 14+. It did compile for me... maybe I compiled it with the wrong JDK! ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2715#discussion_r1605101082 From duke at openjdk.org Fri May 17 14:32:22 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 17 May 2024 14:32:22 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v2] In-Reply-To: References: Message-ID: On Fri, 17 May 2024 14:25:12 GMT, Mar?a Arias de Reyna wrote: >> test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java line 659: >> >>> 657: case "globalsignr46" -> >>> 658: new CATestURLs("https://valid.r46.roots.globalsign.com", >>> 659: "https://revoked.r46.roots.globalsign.com"); >> >> Does this compile? Switch expressions are JDK 14+. > > It did compile for me... maybe I compiled it with the wrong JDK! Sent another commit that fixed it. I compiled it with `--with-boot-jdk=` option pointing to a `openjdk 11.0.19 2023-04-18` That should have failed, right? ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2715#discussion_r1605107480 From syan at openjdk.org Fri May 17 14:40:09 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 17 May 2024 14:40:09 GMT Subject: [jdk22u] RFR: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all In-Reply-To: <-FdTbs36sjrZcSnw2fKXFbup9nh5-k0MzqYsQN9f7WU=.5e1ead90-2e63-4dcc-a8a5-aa04a0fa03a9@github.com> References: <-FdTbs36sjrZcSnw2fKXFbup9nh5-k0MzqYsQN9f7WU=.5e1ead90-2e63-4dcc-a8a5-aa04a0fa03a9@github.com> Message-ID: On Tue, 14 May 2024 08:21:38 GMT, SendaoYan wrote: > Hi all, > This is clean backport of [JDK-8331466](https://bugs.openjdk.org/browse/JDK-8331466). Only change the Problemlist.txt, the risk is low. > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/202#issuecomment-2117752675 From duke at openjdk.org Fri May 17 14:42:24 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 17 May 2024 14:42:24 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v3] In-Reply-To: References: Message-ID: > Backport for https://bugs.openjdk.org/browse/JDK-8316138 > > Related to https://github.com/openjdk/jdk21u-dev/pull/581 and https://github.com/openjdk/jdk17u-dev/pull/2479 > > Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. > > > ]$ make run-test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java" > Building target 'run-test' in configuration 'linux-x86_64-normal-server-release' > Skip building of Graal unit tests because 3rd party libraries directory is not specified > Skip building of Graal unit tests because 3rd party libraries directory is not specified > Creating jdk image > Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run: > * jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java > > Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' > Passed: sun/security/lib/cacerts/VerifyCACerts.java > Test results: passed: 1 > Report written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html > Results written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java > Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' > Test report is stored in build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Finished building target 'run-test' in configuration 'linux-x86_64-normal-server-release' Mar?a Arias de Reyna has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Fix switch expression that is too new for this JDK ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2715/files - new: https://git.openjdk.org/jdk11u-dev/pull/2715/files/c75901fc..c6325117 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2715&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2715&range=01-02 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2715.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2715/head:pull/2715 PR: https://git.openjdk.org/jdk11u-dev/pull/2715 From mdoerr at openjdk.org Fri May 17 14:42:24 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 17 May 2024 14:42:24 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v3] In-Reply-To: References: Message-ID: On Fri, 17 May 2024 14:39:53 GMT, Mar?a Arias de Reyna wrote: >> Backport for https://bugs.openjdk.org/browse/JDK-8316138 >> >> Related to https://github.com/openjdk/jdk21u-dev/pull/581 and https://github.com/openjdk/jdk17u-dev/pull/2479 >> >> Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. >> >> >> ]$ make run-test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java" >> Building target 'run-test' in configuration 'linux-x86_64-normal-server-release' >> Skip building of Graal unit tests because 3rd party libraries directory is not specified >> Skip building of Graal unit tests because 3rd party libraries directory is not specified >> Creating jdk image >> Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run: >> * jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java >> >> Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' >> Passed: sun/security/lib/cacerts/VerifyCACerts.java >> Test results: passed: 1 >> Report written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html >> Results written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java >> Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' >> Test report is stored in build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Finished building target 'run-test' in configuration 'linux-x86_64-normal-server-release' > > Mar?a Arias de Reyna has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Fix switch expression that is too new for this JDK This version looks good. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2715#pullrequestreview-2063619275 From duke at openjdk.org Fri May 17 14:42:25 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Fri, 17 May 2024 14:42:25 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v2] In-Reply-To: References: Message-ID: <8YH8-sQZMte7NMJRwGfOpdZjSbVvo8y_Jfczp503Y5s=.127746b8-47a3-4741-b65e-c704dc54d14b@github.com> On Fri, 17 May 2024 14:32:22 GMT, Mar?a Arias de Reyna wrote: >> Backport for https://bugs.openjdk.org/browse/JDK-8316138 >> >> Related to https://github.com/openjdk/jdk21u-dev/pull/581 and https://github.com/openjdk/jdk17u-dev/pull/2479 >> >> Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. >> >> >> ]$ make run-test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java" >> Building target 'run-test' in configuration 'linux-x86_64-normal-server-release' >> Skip building of Graal unit tests because 3rd party libraries directory is not specified >> Skip building of Graal unit tests because 3rd party libraries directory is not specified >> Creating jdk image >> Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run: >> * jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java >> >> Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' >> Passed: sun/security/lib/cacerts/VerifyCACerts.java >> Test results: passed: 1 >> Report written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html >> Results written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java >> Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' >> Test report is stored in build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Finished building target 'run-test' in configuration 'linux-x86_64-normal-server-release' > > Mar?a Arias de Reyna has updated the pull request incrementally with one additional commit since the last revision: > > Fix switch expression that is too new for this JDK My bad, I force pushed the second commit. The review check is lost. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2715#issuecomment-2117748275 From sgehwolf at openjdk.org Fri May 17 15:13:04 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 17 May 2024 15:13:04 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v3] In-Reply-To: References: Message-ID: On Fri, 17 May 2024 14:29:39 GMT, Mar?a Arias de Reyna wrote: >> It did compile for me... maybe I compiled it with the wrong JDK! > > Sent another commit that fixed it. I compiled it with `--with-boot-jdk=` option pointing to a `openjdk 11.0.19 2023-04-18` That should have failed, right? Yes. But unless you run the test it won't get compiled. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2715#discussion_r1605160921 From sgehwolf at openjdk.org Fri May 17 15:13:04 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 17 May 2024 15:13:04 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v3] In-Reply-To: References: Message-ID: On Fri, 17 May 2024 15:09:17 GMT, Severin Gehwolf wrote: >> Sent another commit that fixed it. I compiled it with `--with-boot-jdk=` option pointing to a `openjdk 11.0.19 2023-04-18` That should have failed, right? > > Yes. But unless you run the test it won't get compiled. make run-test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java test/jdk/security/infra/java/security/cert/CertPathValidator" ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2715#discussion_r1605163109 From clanger at openjdk.org Fri May 17 16:39:10 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 May 2024 16:39:10 GMT Subject: [jdk21u-dev] RFR: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads In-Reply-To: <1p8tz83C090_7tXTOq2k2REmG0usw4ivORdZAFBfo6M=.4a2ae875-43fb-43ae-b483-8adaef4aa858@github.com> References: <1p8tz83C090_7tXTOq2k2REmG0usw4ivORdZAFBfo6M=.4a2ae875-43fb-43ae-b483-8adaef4aa858@github.com> Message-ID: <4ROczlXQYGCJGtk4VVqdu3RCB6nQOvYZCU0_h30cs0Y=.756365aa-22b6-499a-9ca7-99910de89766@github.com> On Fri, 17 May 2024 09:05:54 GMT, Liang Mao wrote: > Clean backport of fixing crash on Threads::print_on() . @mmyxym, could you please backport this to jdk22u first? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/585#issuecomment-2117972439 From clanger at openjdk.org Fri May 17 16:40:10 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 May 2024 16:40:10 GMT Subject: [jdk21u-dev] RFR: 8329840: Fix ZPhysicalMemorySegment::_end type In-Reply-To: References: Message-ID: On Fri, 17 May 2024 08:37:24 GMT, Liang Mao wrote: > Clean backport of fixing type of ZPhysicalMemorySegment::_end type Same here, please bring to 22u first. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/583#issuecomment-2117975268 From clanger at openjdk.org Fri May 17 16:43:00 2024 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 May 2024 16:43:00 GMT Subject: [jdk22u] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: <1pUPgnbRaHJRzDtyfw1NJp2v9GP555PFzVf2-RyyMTc=.0ce4d64d-005e-44de-94a8-9ee76fedd11a@github.com> References: <1pUPgnbRaHJRzDtyfw1NJp2v9GP555PFzVf2-RyyMTc=.0ce4d64d-005e-44de-94a8-9ee76fedd11a@github.com> Message-ID: <9OA75hEgO6gg1KjViuR_OmjfxpCNCLF_fSIQt8YjdOQ=.ce318bd3-ed39-4ee8-8b7c-5d45f2f4cb8a@github.com> On Fri, 10 May 2024 07:33:03 GMT, Liang Mao wrote: > Clean backport of fixing rare long hand shake while mutator threads in heavy contention on ShenandoahLock. @mmyxym would you mind integrating this to proceed with further backports? ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/192#issuecomment-2117980225 From aivanov at openjdk.org Fri May 17 18:59:08 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 17 May 2024 18:59:08 GMT Subject: [jdk22u] RFR: 8331142: Add test for number of loader threads in BasicDirectoryModel [v2] In-Reply-To: <-kSh2ZBKc8YcCFHA7bA97NOQgfrfV5cv8B-7EI3dfV8=.84d1c4dd-1641-4334-9499-7c0d0f89796e@github.com> References: <-kSh2ZBKc8YcCFHA7bA97NOQgfrfV5cv8B-7EI3dfV8=.84d1c4dd-1641-4334-9499-7c0d0f89796e@github.com> Message-ID: On Wed, 1 May 2024 17:01:16 GMT, Alexey Ivanov wrote: >> Provides a regression test for [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in BasicDirectoryModel.validateFileCache_ which is backported to 22u. > > Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision: > > 8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only > > Reviewed-by: prr The test proved to be unstable on Windows too, the test is modified by [JDK-8331999](https://bugs.openjdk.org/browse/JDK-8331999). It is _safer_ not to integrate this PR to avoid bringing new test failures. If deemed necessary, the PR could updated with JDK-8331999. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/175#issuecomment-2118209027 From aivanov at openjdk.org Fri May 17 18:59:09 2024 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 17 May 2024 18:59:09 GMT Subject: [jdk22u] Withdrawn: 8331142: Add test for number of loader threads in BasicDirectoryModel In-Reply-To: References: Message-ID: On Wed, 1 May 2024 12:00:44 GMT, Alexey Ivanov wrote: > Provides a regression test for [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in BasicDirectoryModel.validateFileCache_ which is backported to 22u. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk22u/pull/175 From btaylor at openjdk.org Fri May 17 19:48:36 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 17 May 2024 19:48:36 GMT Subject: [jdk21u-dev] RFR: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx Message-ID: Clean backport of a low-risk change to address unexpected behavior with Parallel GC when Xms == Xmx Passes local tier-1 testing on linux x86_64 ------------- Commit messages: - Backport aca1e8365bf0f64bf18caf798bbca1d25b3c4117 Changes: https://git.openjdk.org/jdk21u-dev/pull/587/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=587&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329223 Stats: 11 lines in 1 file changed: 6 ins; 3 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/587.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/587/head:pull/587 PR: https://git.openjdk.org/jdk21u-dev/pull/587 From btaylor at openjdk.org Fri May 17 19:48:26 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Fri, 17 May 2024 19:48:26 GMT Subject: [jdk17u-dev] RFR: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx Message-ID: <0F-_Xn1bw9oSoNxK3bCnabZuaZ0T3xEmNSpmjOH4VyQ=.31cf320f-a2c2-48ce-abd8-5fa2d4a46cd7@github.com> Clean backport of a low-risk change to address unexpected behavior with Parallel GC when Xms == Xmx Passes local tier-1 testing on linux x86_64 ------------- Commit messages: - Backport aca1e8365bf0f64bf18caf798bbca1d25b3c4117 Changes: https://git.openjdk.org/jdk17u-dev/pull/2480/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2480&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329223 Stats: 11 lines in 1 file changed: 6 ins; 3 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2480.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2480/head:pull/2480 PR: https://git.openjdk.org/jdk17u-dev/pull/2480 From mdoerr at openjdk.org Fri May 17 20:02:19 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 17 May 2024 20:02:19 GMT Subject: [jdk11u-dev] RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address [v3] In-Reply-To: <0AJfOYp_RqpCHn9T6l0if17Rr7X34Zw884PYxoU6AwI=.00de08af-c9d9-42d3-87fc-f0979d91a0c4@github.com> References: <0AJfOYp_RqpCHn9T6l0if17Rr7X34Zw884PYxoU6AwI=.00de08af-c9d9-42d3-87fc-f0979d91a0c4@github.com> Message-ID: On Thu, 18 Apr 2024 09:20:05 GMT, Varada M wrote: >> Hi all, >> >> This pull request contains a backport of commit [43956686](https://github.com/openjdk/jdk17u-dev/commit/43956686c924658ee2d7866e46ee9f10d9595c35) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. >> >> The commit being backported was authored by Jaikiran Pai on 16 Feb 2024 and was reviewed by Paul Hohensee. >> >> Thanks! > > Varada M has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Backport 43956686c924658ee2d7866e46ee9f10d9595c35 > - Backport 43956686c924658ee2d7866e46ee9f10d9595c35 > - Backport 43956686c924658ee2d7866e46ee9f10d9595c35 This PR is clean and can apply for maintainer approval. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2531#issuecomment-2118302977 From serb at openjdk.org Fri May 17 22:21:28 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 17 May 2024 22:21:28 GMT Subject: [jdk21u-dev] RFR: 8331746: Create a test to verify that the cmm id is not ignored Message-ID: <2yg20WCO75AzWSjqt6-dcoxg0bftF2P5CsjaIJWGoc8=.f889ad53-33be-41c7-ac8a-4002cd110dfa@github.com> Hi all, This pull request contains a backport of commit [7c750fd9](https://github.com/openjdk/jdk/commit/7c750fd95b83d0a93b0cce681dcfbbae1f220fdd) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 17 May 2024 and was reviewed by Phil Race, Dmitry Markov and Alexey Ivanov. Thanks! ------------- Commit messages: - Backport 7c750fd95b83d0a93b0cce681dcfbbae1f220fdd Changes: https://git.openjdk.org/jdk21u-dev/pull/588/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=588&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331746 Stats: 69 lines in 1 file changed: 69 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/588.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/588/head:pull/588 PR: https://git.openjdk.org/jdk21u-dev/pull/588 From zgu at openjdk.org Fri May 17 22:34:36 2024 From: zgu at openjdk.org (Zhengyu Gu) Date: Fri, 17 May 2024 22:34:36 GMT Subject: [jdk22u] RFR: 8272364: Parallel GC adaptive size policy may shrink the heap below MinHeapSize Message-ID: Clean back port. ------------- Commit messages: - Backport 6bef0474c8b8773d0d20c0f25c36a2ce9cdbd7e8 Changes: https://git.openjdk.org/jdk22u/pull/214/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=214&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272364 Stats: 100 lines in 2 files changed: 100 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/214.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/214/head:pull/214 PR: https://git.openjdk.org/jdk22u/pull/214 From serb at openjdk.org Fri May 17 23:26:18 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 17 May 2024 23:26:18 GMT Subject: [jdk17u-dev] RFR: 8331746: Create a test to verify that the cmm id is not ignored Message-ID: Hi all, This pull request contains a backport of commit [7c750fd9](https://github.com/openjdk/jdk/commit/7c750fd95b83d0a93b0cce681dcfbbae1f220fdd) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 17 May 2024 and was reviewed by Phil Race, Dmitry Markov and Alexey Ivanov. Thanks! ------------- Commit messages: - Backport 7c750fd95b83d0a93b0cce681dcfbbae1f220fdd Changes: https://git.openjdk.org/jdk17u-dev/pull/2481/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2481&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331746 Stats: 69 lines in 1 file changed: 69 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2481.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2481/head:pull/2481 PR: https://git.openjdk.org/jdk17u-dev/pull/2481 From serb at openjdk.org Sat May 18 00:43:22 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 18 May 2024 00:43:22 GMT Subject: [jdk11u-dev] RFR: 8331746: Create a test to verify that the cmm id is not ignored Message-ID: Hi all, This pull request contains a backport of commit [7c750fd9](https://github.com/openjdk/jdk/commit/7c750fd95b83d0a93b0cce681dcfbbae1f220fdd) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 17 May 2024 and was reviewed by Phil Race, Dmitry Markov and Alexey Ivanov. Thanks! ------------- Commit messages: - Backport 7c750fd95b83d0a93b0cce681dcfbbae1f220fdd Changes: https://git.openjdk.org/jdk11u-dev/pull/2716/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2716&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331746 Stats: 69 lines in 1 file changed: 69 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2716.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2716/head:pull/2716 PR: https://git.openjdk.org/jdk11u-dev/pull/2716 From lmao at openjdk.org Mon May 20 02:46:13 2024 From: lmao at openjdk.org (Liang Mao) Date: Mon, 20 May 2024 02:46:13 GMT Subject: [jdk22u] RFR: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads Message-ID: Clean backport of fixing crash on Threads::print_on() . ------------- Commit messages: - Backport c1cfb43d8de8d0eed01b9bb6aa1202dc7cbff007 Changes: https://git.openjdk.org/jdk22u/pull/215/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=215&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329109 Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/215.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/215/head:pull/215 PR: https://git.openjdk.org/jdk22u/pull/215 From lmao at openjdk.org Mon May 20 02:54:11 2024 From: lmao at openjdk.org (Liang Mao) Date: Mon, 20 May 2024 02:54:11 GMT Subject: [jdk22u] RFR: 8329840: Fix ZPhysicalMemorySegment::_end type Message-ID: Clean backport of fixing type of ZPhysicalMemorySegment::_end type ------------- Commit messages: - Backport b4ddddeff1ce4293c88a9ab8ad3ca9d3b0e2352e Changes: https://git.openjdk.org/jdk22u/pull/216/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=216&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329840 Stats: 56 lines in 4 files changed: 49 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk22u/pull/216.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/216/head:pull/216 PR: https://git.openjdk.org/jdk22u/pull/216 From duke at openjdk.org Mon May 20 06:48:16 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Mon, 20 May 2024 06:48:16 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v3] In-Reply-To: References: Message-ID: <8-yvBKVFTvM6OcQ7YgEuKPQUzmdfKm4uoLMfDJ0LqHg=.7154815e-002c-451f-b07c-ccfb75bd07a5@github.com> On Fri, 17 May 2024 15:10:47 GMT, Severin Gehwolf wrote: >> Yes. But unless you run the test it won't get compiled. > > make run-test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java test/jdk/security/infra/java/security/cert/CertPathValidator" Then I don't know what happened, because I `make clean` `make images` and `make run-test TEST='...file.java'`. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2715#discussion_r1606323207 From duke at openjdk.org Mon May 20 06:48:16 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Mon, 20 May 2024 06:48:16 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v3] In-Reply-To: <8-yvBKVFTvM6OcQ7YgEuKPQUzmdfKm4uoLMfDJ0LqHg=.7154815e-002c-451f-b07c-ccfb75bd07a5@github.com> References: <8-yvBKVFTvM6OcQ7YgEuKPQUzmdfKm4uoLMfDJ0LqHg=.7154815e-002c-451f-b07c-ccfb75bd07a5@github.com> Message-ID: <0LXREUqoUcbvQCL2WTZccGAdeCJ4gUHbJqY9alHaHGw=.9e73a1c7-b77d-4cf3-b0eb-4e84d981be46@github.com> On Mon, 20 May 2024 06:45:11 GMT, Mar?a Arias de Reyna wrote: >> make run-test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java test/jdk/security/infra/java/security/cert/CertPathValidator" > > Then I don't know what happened, because I `make clean` `make images` and `make run-test TEST='...file.java'`. In any case, the code is changed. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2715#discussion_r1606323600 From andrewlu at openjdk.org Mon May 20 08:13:37 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 20 May 2024 08:13:37 GMT Subject: [jdk17u-dev] RFR: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport 5045839cb2095105a5c6c9eebc633a78b1e3213e Changes: https://git.openjdk.org/jdk17u-dev/pull/2482/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2482&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323635 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2482.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2482/head:pull/2482 PR: https://git.openjdk.org/jdk17u-dev/pull/2482 From andrewlu at openjdk.org Mon May 20 08:21:32 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 20 May 2024 08:21:32 GMT Subject: [jdk21u-dev] RFR: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 5045839cb2095105a5c6c9eebc633a78b1e3213e - Backport 5045839cb2095105a5c6c9eebc633a78b1e3213e Changes: https://git.openjdk.org/jdk21u-dev/pull/589/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=589&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323635 Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/589.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/589/head:pull/589 PR: https://git.openjdk.org/jdk21u-dev/pull/589 From andrewlu at openjdk.org Mon May 20 08:34:34 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 20 May 2024 08:34:34 GMT Subject: [jdk11u-dev] RFR: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 5045839cb2095105a5c6c9eebc633a78b1e3213e Changes: https://git.openjdk.org/jdk11u-dev/pull/2717/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2717&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323635 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2717.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2717/head:pull/2717 PR: https://git.openjdk.org/jdk11u-dev/pull/2717 From duke at openjdk.org Mon May 20 08:57:06 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Mon, 20 May 2024 08:57:06 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v3] In-Reply-To: <0LXREUqoUcbvQCL2WTZccGAdeCJ4gUHbJqY9alHaHGw=.9e73a1c7-b77d-4cf3-b0eb-4e84d981be46@github.com> References: <8-yvBKVFTvM6OcQ7YgEuKPQUzmdfKm4uoLMfDJ0LqHg=.7154815e-002c-451f-b07c-ccfb75bd07a5@github.com> <0LXREUqoUcbvQCL2WTZccGAdeCJ4gUHbJqY9alHaHGw=.9e73a1c7-b77d-4cf3-b0eb-4e84d981be46@github.com> Message-ID: On Mon, 20 May 2024 06:45:38 GMT, Mar?a Arias de Reyna wrote: >> Then I don't know what happened, because I `make clean` `make images` and `make run-test TEST='...file.java'`. > > In any case, the code is changed. I also had `--disable-warnings-as-errors` as a flag while building. Maybe that was it. I removed it just in case. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2715#discussion_r1606464679 From lmao at openjdk.org Mon May 20 09:49:05 2024 From: lmao at openjdk.org (Liang Mao) Date: Mon, 20 May 2024 09:49:05 GMT Subject: [jdk22u] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: <1pUPgnbRaHJRzDtyfw1NJp2v9GP555PFzVf2-RyyMTc=.0ce4d64d-005e-44de-94a8-9ee76fedd11a@github.com> References: <1pUPgnbRaHJRzDtyfw1NJp2v9GP555PFzVf2-RyyMTc=.0ce4d64d-005e-44de-94a8-9ee76fedd11a@github.com> Message-ID: <7TJrBvFwbRKOJjI0Rl9pTWutmKlM0V5VaJjIApUcaAc=.89f4aa55-25d0-4ba1-8e6b-c0b392bfff8f@github.com> On Fri, 10 May 2024 07:33:03 GMT, Liang Mao wrote: > Clean backport of fixing rare long hand shake while mutator threads in heavy contention on ShenandoahLock. @shipilev ?shall I integrate this into 22u? ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/192#issuecomment-2120085913 From duke at openjdk.org Mon May 20 10:05:08 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Mon, 20 May 2024 10:05:08 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v3] In-Reply-To: References: <8-yvBKVFTvM6OcQ7YgEuKPQUzmdfKm4uoLMfDJ0LqHg=.7154815e-002c-451f-b07c-ccfb75bd07a5@github.com> <0LXREUqoUcbvQCL2WTZccGAdeCJ4gUHbJqY9alHaHGw=.9e73a1c7-b77d-4cf3-b0eb-4e84d981be46@github.com> Message-ID: <5oJUZmGJ1RrgE0MfYh8i8AgC3ZpxA4Rk-W_TPkHVOMo=.86c7daef-0f33-48e9-affb-8163336e1b5a@github.com> On Mon, 20 May 2024 08:52:49 GMT, Mar?a Arias de Reyna wrote: >> In any case, the code is changed. > > I also had `--disable-warnings-as-errors` as a flag while building. Maybe that was it. I removed it just in case. That was it, it won't happen again :) After removing the ` --disable-warnings-as-errors` flag, it throws an error: /home/delawen/git/jdk11u-dev/test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java:664: error: illegal start of expression case "globalsignr46" -> ^ ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2715#discussion_r1606542314 From mdoerr at openjdk.org Mon May 20 13:17:08 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 20 May 2024 13:17:08 GMT Subject: [jdk17u-dev] RFR: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel In-Reply-To: References: Message-ID: On Fri, 17 May 2024 08:51:22 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. Nightly test got error: Exception in Basic L&F File Loading Thread: class java.util.ConcurrentModificationException java.util.ConcurrentModificationException at java.base/java.util.AbstractList$SubList.checkForComodification(AbstractList.java:904) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2477#issuecomment-2120439933 From mdoerr at openjdk.org Mon May 20 13:19:08 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 20 May 2024 13:19:08 GMT Subject: [jdk11u-dev] RFR: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel In-Reply-To: References: Message-ID: On Fri, 17 May 2024 08:54:16 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. ConcurrentModification.java:187: error: ';' expected Records are not supported in JDK 11. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2713#issuecomment-2120442419 From zgu at openjdk.org Mon May 20 14:40:01 2024 From: zgu at openjdk.org (Zhengyu Gu) Date: Mon, 20 May 2024 14:40:01 GMT Subject: [jdk22u] Withdrawn: 8272364: Parallel GC adaptive size policy may shrink the heap below MinHeapSize In-Reply-To: References: Message-ID: On Fri, 17 May 2024 22:29:40 GMT, Zhengyu Gu wrote: > 8272364: Parallel GC adaptive size policy may shrink the heap below MinHeapSize This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk22u/pull/214 From zgu at openjdk.org Mon May 20 18:30:17 2024 From: zgu at openjdk.org (Zhengyu Gu) Date: Mon, 20 May 2024 18:30:17 GMT Subject: [jdk22u] RFR: 8272364: Parallel GC adaptive size policy may shrink the heap below MinHeapSize Message-ID: The backport is not clean. The conflict is in the new test, which uses new API introduced by JDK-8321812 in 23. The issue is resolved by fall back to use old API in 22. This risk of the backport is low and shrinking heap below minimum heap size is an unpleasant surpprise. ------------- Commit messages: - cleanup - Backport 6bef0474c8b8773d0d20c0f25c36a2ce9cdbd7e8 Changes: https://git.openjdk.org/jdk22u/pull/217/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=217&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272364 Stats: 101 lines in 2 files changed: 101 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/217.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/217/head:pull/217 PR: https://git.openjdk.org/jdk22u/pull/217 From andrew at openjdk.org Tue May 21 03:30:13 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 21 May 2024 03:30:13 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v3] In-Reply-To: References: Message-ID: <7UivEl-VXDmTEqNwHxvErfWjXTu3Yn-gquyi5WJcpQc=.28bba6b0-a999-4961-9fb0-bcb323eaed8f@github.com> On Fri, 17 May 2024 14:42:24 GMT, Mar?a Arias de Reyna wrote: >> Backport for https://bugs.openjdk.org/browse/JDK-8316138 >> >> Related to https://github.com/openjdk/jdk21u-dev/pull/581 and https://github.com/openjdk/jdk17u-dev/pull/2479 >> >> Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. >> >> >> ]$ make run-test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java" >> Building target 'run-test' in configuration 'linux-x86_64-normal-server-release' >> Skip building of Graal unit tests because 3rd party libraries directory is not specified >> Skip building of Graal unit tests because 3rd party libraries directory is not specified >> Creating jdk image >> Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run: >> * jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java >> >> Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' >> Passed: sun/security/lib/cacerts/VerifyCACerts.java >> Test results: passed: 1 >> Report written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html >> Results written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java >> Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' >> Test report is stored in build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Finished building target 'run-test' in configuration 'linux-x86_64-normal-server-release' > > Mar?a Arias de Reyna has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Fix switch expression that is too new for this JDK Current version looks good to me. Matches 17u with the exception of the change to the `switch` statements. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2715#pullrequestreview-2067418988 From andrew at openjdk.org Tue May 21 03:40:08 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 21 May 2024 03:40:08 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v3] In-Reply-To: References: Message-ID: On Fri, 17 May 2024 14:42:24 GMT, Mar?a Arias de Reyna wrote: >> Backport for https://bugs.openjdk.org/browse/JDK-8316138 >> >> Related to https://github.com/openjdk/jdk21u-dev/pull/581 and https://github.com/openjdk/jdk17u-dev/pull/2479 >> >> Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. >> >> >> ]$ make run-test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java" >> Building target 'run-test' in configuration 'linux-x86_64-normal-server-release' >> Skip building of Graal unit tests because 3rd party libraries directory is not specified >> Skip building of Graal unit tests because 3rd party libraries directory is not specified >> Creating jdk image >> Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run: >> * jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java >> >> Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' >> Passed: sun/security/lib/cacerts/VerifyCACerts.java >> Test results: passed: 1 >> Report written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html >> Results written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java >> Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' >> Test report is stored in build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Finished building target 'run-test' in configuration 'linux-x86_64-normal-server-release' > > Mar?a Arias de Reyna has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Fix switch expression that is too new for this JDK The [8u backport](https://github.com/openjdk/jdk8u-dev/pull/502) makes a good point that `-Dcom.sun.security.ocsp.useget=false` is of no use here without [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638). I would thus remove those lines as in the 8u version. Also, when comparing with 8u, I noticed that the 11u version only is missing a newline between the new `case` statements and the earlier ones: 17u: ~~~ "https://revoked.root-e1.certainly.com"); + case "globalsignr46" -> + new CATestURLs("https://valid.r46.roots.globalsign.com", + "https://revoked.r46.roots.globalsign.com"); + case "globalsigne46" -> + new CATestURLs("https://valid.e46.roots.globalsign.com", + "https://revoked.e46.roots.globalsign.com"); + default -> throw new RuntimeException("No test setup found for: " + alias); ~~~ 11u: ~~~ "https://revoked.root-e1.certainly.com"); + case "globalsignr46": + return new CATestURLs("https://valid.r46.roots.globalsign.com", + "https://revoked.r46.roots.globalsign.com"); + case "globalsigne46": + return new CATestURLs("https://valid.e46.roots.globalsign.com", + "https://revoked.e46.roots.globalsign.com"); default: throw new RuntimeException("No test setup found for: " + alias); ~~~ It would be good if all three backports matched. ------------- Changes requested by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2715#pullrequestreview-2067432089 From andrewlu at openjdk.org Tue May 21 06:46:38 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 21 May 2024 06:46:38 GMT Subject: [jdk17u-dev] RFR: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules Message-ID: <1naU4Vkh6iVf_7tjxKmSTtfA96f7hMSBCHvN3zQ8Xqk=.42858c96-8195-4b35-b9af-e08570b50afe@github.com> I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport e7c83ea948f8b2cd7caf7e59d3cf6b087807dba7 Changes: https://git.openjdk.org/jdk17u-dev/pull/2483/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2483&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312194 Stats: 38 lines in 1 file changed: 0 ins; 38 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2483.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2483/head:pull/2483 PR: https://git.openjdk.org/jdk17u-dev/pull/2483 From andrewlu at openjdk.org Tue May 21 06:46:42 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 21 May 2024 06:46:42 GMT Subject: [jdk11u-dev] RFR: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport e7c83ea948f8b2cd7caf7e59d3cf6b087807dba7 Changes: https://git.openjdk.org/jdk11u-dev/pull/2718/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2718&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312194 Stats: 38 lines in 1 file changed: 0 ins; 38 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2718.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2718/head:pull/2718 PR: https://git.openjdk.org/jdk11u-dev/pull/2718 From andrewlu at openjdk.org Tue May 21 06:47:23 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 21 May 2024 06:47:23 GMT Subject: [jdk21u-dev] RFR: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport e7c83ea948f8b2cd7caf7e59d3cf6b087807dba7 Changes: https://git.openjdk.org/jdk21u-dev/pull/590/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=590&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312194 Stats: 38 lines in 1 file changed: 0 ins; 38 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/590.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/590/head:pull/590 PR: https://git.openjdk.org/jdk21u-dev/pull/590 From andrewlu at openjdk.org Tue May 21 07:05:29 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 21 May 2024 07:05:29 GMT Subject: [jdk21u-dev] RFR: 8319338: tools/jpackage/share/RuntimeImageTest.java fails with -XX:+UseZGC Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport e9eb8b98f4dd949c8a0f501189471e11b837d936 Changes: https://git.openjdk.org/jdk21u-dev/pull/591/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=591&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319338 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/591.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/591/head:pull/591 PR: https://git.openjdk.org/jdk21u-dev/pull/591 From andrewlu at openjdk.org Tue May 21 07:06:14 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 21 May 2024 07:06:14 GMT Subject: [jdk17u-dev] RFR: 8319338: tools/jpackage/share/RuntimeImageTest.java fails with -XX:+UseZGC Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport e9eb8b98f4dd949c8a0f501189471e11b837d936 Changes: https://git.openjdk.org/jdk17u-dev/pull/2484/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2484&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319338 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2484.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2484/head:pull/2484 PR: https://git.openjdk.org/jdk17u-dev/pull/2484 From andrewlu at openjdk.org Tue May 21 08:01:31 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 21 May 2024 08:01:31 GMT Subject: [jdk17u-dev] RFR: 8320681: [macos] Test tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java timed out on macOS Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport a657aa38a56056211a9d2773b30e8fe1a89c128e Changes: https://git.openjdk.org/jdk17u-dev/pull/2485/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2485&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320681 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2485.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2485/head:pull/2485 PR: https://git.openjdk.org/jdk17u-dev/pull/2485 From andrewlu at openjdk.org Tue May 21 08:02:35 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 21 May 2024 08:02:35 GMT Subject: [jdk21u-dev] RFR: 8320681: [macos] Test tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java timed out on macOS Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport a657aa38a56056211a9d2773b30e8fe1a89c128e Changes: https://git.openjdk.org/jdk21u-dev/pull/592/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=592&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320681 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/592.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/592/head:pull/592 PR: https://git.openjdk.org/jdk21u-dev/pull/592 From duke at openjdk.org Tue May 21 08:10:40 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Tue, 21 May 2024 08:10:40 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v4] In-Reply-To: References: Message-ID: > Backport for https://bugs.openjdk.org/browse/JDK-8316138 > > Related to https://github.com/openjdk/jdk21u-dev/pull/581 and https://github.com/openjdk/jdk17u-dev/pull/2479 > > Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. > > > ]$ make run-test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java" > Building target 'run-test' in configuration 'linux-x86_64-normal-server-release' > Skip building of Graal unit tests because 3rd party libraries directory is not specified > Skip building of Graal unit tests because 3rd party libraries directory is not specified > Creating jdk image > Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run: > * jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java > > Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' > Passed: sun/security/lib/cacerts/VerifyCACerts.java > Test results: passed: 1 > Report written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html > Results written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java > Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' > Test report is stored in build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Finished building target 'run-test' in configuration 'linux-x86_64-normal-server-release' Mar?a Arias de Reyna has updated the pull request incrementally with one additional commit since the last revision: Removing -Dcom.sun.security.ocsp.useget=false because it is of no use here without JDK-8328638 Adding white line between switch case statements as in JDK 17 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2715/files - new: https://git.openjdk.org/jdk11u-dev/pull/2715/files/c6325117..afeeaf66 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2715&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2715&range=02-03 Stats: 3 lines in 1 file changed: 1 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2715.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2715/head:pull/2715 PR: https://git.openjdk.org/jdk11u-dev/pull/2715 From duke at openjdk.org Tue May 21 08:18:09 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Tue, 21 May 2024 08:18:09 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v3] In-Reply-To: References: Message-ID: On Tue, 21 May 2024 03:37:29 GMT, Andrew John Hughes wrote: >> Mar?a Arias de Reyna has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: >> >> Fix switch expression that is too new for this JDK > > The [8u backport](https://github.com/openjdk/jdk8u-dev/pull/502) makes a good point that `-Dcom.sun.security.ocsp.useget=false` is of no use here without [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638). I would thus remove those lines as in the 8u version. > > Also, when comparing with 8u, I noticed that the 11u version only is missing a newline between the new `case` statements and the earlier ones: > > 17u: > ~~~ > "https://revoked.root-e1.certainly.com"); > > + case "globalsignr46" -> > + new CATestURLs("https://valid.r46.roots.globalsign.com", > + "https://revoked.r46.roots.globalsign.com"); > + case "globalsigne46" -> > + new CATestURLs("https://valid.e46.roots.globalsign.com", > + "https://revoked.e46.roots.globalsign.com"); > + > default -> throw new RuntimeException("No test setup found for: " + alias); > ~~~ > > 11u: > ~~~ > "https://revoked.root-e1.certainly.com"); > + case "globalsignr46": > + return new CATestURLs("https://valid.r46.roots.globalsign.com", > + "https://revoked.r46.roots.globalsign.com"); > + case "globalsigne46": > + return new CATestURLs("https://valid.e46.roots.globalsign.com", > + "https://revoked.e46.roots.globalsign.com"); > > default: throw new RuntimeException("No test setup found for: " + alias); > ~~~ > > It would be good if all three backports matched. @gnu-andrew Changes pushed and the test run locally. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2715#issuecomment-2122035667 From clanger at openjdk.org Tue May 21 08:27:14 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 21 May 2024 08:27:14 GMT Subject: [jdk21u-dev] RFR: 8331746: Create a test to verify that the cmm id is not ignored In-Reply-To: <2yg20WCO75AzWSjqt6-dcoxg0bftF2P5CsjaIJWGoc8=.f889ad53-33be-41c7-ac8a-4002cd110dfa@github.com> References: <2yg20WCO75AzWSjqt6-dcoxg0bftF2P5CsjaIJWGoc8=.f889ad53-33be-41c7-ac8a-4002cd110dfa@github.com> Message-ID: On Fri, 17 May 2024 19:48:48 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [7c750fd9](https://github.com/openjdk/jdk/commit/7c750fd95b83d0a93b0cce681dcfbbae1f220fdd) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 17 May 2024 and was reviewed by Phil Race, Dmitry Markov and Alexey Ivanov. > > Thanks! @mrserb would you mind bringing this to jdk22u first? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/588#issuecomment-2122053212 From pkumaraswamy at openjdk.org Tue May 21 08:27:15 2024 From: pkumaraswamy at openjdk.org (Prajwal Kumaraswamy) Date: Tue, 21 May 2024 08:27:15 GMT Subject: [jdk22u] Integrated: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit In-Reply-To: References: Message-ID: On Tue, 14 May 2024 10:53:39 GMT, Prajwal Kumaraswamy wrote: > This is a clean backport of JDK-8261433, Internal test are green This pull request has now been integrated. Changeset: 98362090 Author: Prajwal Kumaraswamy Committer: Sean Coffey URL: https://git.openjdk.org/jdk22u/commit/98362090b32d86c0b1fb21ccdd29dd5c2000ede7 Stats: 242 lines in 5 files changed: 165 ins; 22 del; 55 mod 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit Backport-of: 7c2c24fc0511b36132952c96be46eea5904a53c5 ------------- PR: https://git.openjdk.org/jdk22u/pull/203 From clanger at openjdk.org Tue May 21 08:29:04 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 21 May 2024 08:29:04 GMT Subject: [jdk21u-dev] RFR: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx In-Reply-To: References: Message-ID: <1fq4_uAOag7_0iX2Xg1-F2SW42Bz3WE_NbWMnh_Onm8=.f1920603-e78b-445c-9886-53e011224007@github.com> On Fri, 17 May 2024 19:43:04 GMT, Ben Taylor wrote: > Clean backport of a low-risk change to address unexpected behavior with Parallel GC when Xms == Xmx > Passes local tier-1 testing on linux x86_64 @benty-amzn the approval request is still missing. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/587#issuecomment-2122057262 From shade at openjdk.org Tue May 21 08:30:19 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 21 May 2024 08:30:19 GMT Subject: [jdk17u-dev] RFR: 8177107: Reduce memory footprint of java.lang.reflect.Constructor/Method Message-ID: Clean backport to improve memory footprint in reflection-heavy applications. Additional testing: - [x] Linux AArch64 server fastdebug, `java/lang/reflect` - [ ] Linux AArch64 server fastdebug, `all` ------------- Commit messages: - Backport a385142398eee102ff1a53d848230dc95c4ebd37 Changes: https://git.openjdk.org/jdk17u-dev/pull/2486/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2486&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8177107 Stats: 22 lines in 4 files changed: 14 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2486.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2486/head:pull/2486 PR: https://git.openjdk.org/jdk17u-dev/pull/2486 From clanger at openjdk.org Tue May 21 08:33:42 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 21 May 2024 08:33:42 GMT Subject: [jdk22u] Integrated: 8330814: Cleanups for KeepAliveCache tests In-Reply-To: References: Message-ID: <2aXuMJ2Di2vSm8Eqdyg064miH765ydezK-ivkU-qrow=.b0dfb7bb-1d8a-4baa-977f-dba379898d65@github.com> On Wed, 15 May 2024 11:38:01 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8330814](https://bugs.openjdk.org/browse/JDK-8330814), commit [a5005c87](https://github.com/openjdk/jdk/commit/a5005c87c4d5598eb54e9824105767d833f9660b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Christoph Langer on 15 May 2024 and was reviewed by Jaikiran Pai and Daniel Fuchs. > > Thanks! This pull request has now been integrated. Changeset: 1e173f9d Author: Christoph Langer URL: https://git.openjdk.org/jdk22u/commit/1e173f9d17e4a42e758217ac98aec4356acac0fa Stats: 290 lines in 5 files changed: 113 ins; 69 del; 108 mod 8330814: Cleanups for KeepAliveCache tests Backport-of: a5005c87c4d5598eb54e9824105767d833f9660b ------------- PR: https://git.openjdk.org/jdk22u/pull/207 From shade at openjdk.org Tue May 21 08:35:12 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 21 May 2024 08:35:12 GMT Subject: [jdk22u] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: <9OA75hEgO6gg1KjViuR_OmjfxpCNCLF_fSIQt8YjdOQ=.ce318bd3-ed39-4ee8-8b7c-5d45f2f4cb8a@github.com> References: <1pUPgnbRaHJRzDtyfw1NJp2v9GP555PFzVf2-RyyMTc=.0ce4d64d-005e-44de-94a8-9ee76fedd11a@github.com> <9OA75hEgO6gg1KjViuR_OmjfxpCNCLF_fSIQt8YjdOQ=.ce318bd3-ed39-4ee8-8b7c-5d45f2f4cb8a@github.com> Message-ID: On Fri, 17 May 2024 16:40:11 GMT, Christoph Langer wrote: >> Clean backport of fixing rare long hand shake while mutator threads in heavy contention on ShenandoahLock. > > @mmyxym would you mind integrating this to proceed with further backports? Yeah, I guess it is fine for 22u: early exposure to fixes, and all that. What further backports you had in mind, @RealCLanger? ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/192#issuecomment-2122068997 From clanger at openjdk.org Tue May 21 08:42:02 2024 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 21 May 2024 08:42:02 GMT Subject: [jdk22u] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: <9OA75hEgO6gg1KjViuR_OmjfxpCNCLF_fSIQt8YjdOQ=.ce318bd3-ed39-4ee8-8b7c-5d45f2f4cb8a@github.com> References: <1pUPgnbRaHJRzDtyfw1NJp2v9GP555PFzVf2-RyyMTc=.0ce4d64d-005e-44de-94a8-9ee76fedd11a@github.com> <9OA75hEgO6gg1KjViuR_OmjfxpCNCLF_fSIQt8YjdOQ=.ce318bd3-ed39-4ee8-8b7c-5d45f2f4cb8a@github.com> Message-ID: <-eNjBqHK7xGDdgrfBgfyOWlXCN-I-ueAYA094zvEsn0=.1ef5daef-05fe-40b9-879c-03864507d81a@github.com> On Fri, 17 May 2024 16:40:11 GMT, Christoph Langer wrote: >> Clean backport of fixing rare long hand shake while mutator threads in heavy contention on ShenandoahLock. > > @mmyxym would you mind integrating this to proceed with further backports? > Yeah, I guess it is fine for 22u: early exposure to fixes, and all that. What further backports you had in mind, @RealCLanger? I can see that a backport to 21u is already requested - so I wanted to see this in 22u first. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/192#issuecomment-2122084758 From lmao at openjdk.org Tue May 21 09:31:06 2024 From: lmao at openjdk.org (Liang Mao) Date: Tue, 21 May 2024 09:31:06 GMT Subject: [jdk22u] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: References: <1pUPgnbRaHJRzDtyfw1NJp2v9GP555PFzVf2-RyyMTc=.0ce4d64d-005e-44de-94a8-9ee76fedd11a@github.com> <9OA75hEgO6gg1KjViuR_OmjfxpCNCLF_fSIQt8YjdOQ=.ce318bd3-ed39-4ee8-8b7c-5d45f2f4cb8a@github.com> Message-ID: On Tue, 21 May 2024 08:32:06 GMT, Aleksey Shipilev wrote: >> @mmyxym would you mind integrating this to proceed with further backports? > > Yeah, I guess it is fine for 22u: early exposure to fixes, and all that. What further backports you had in mind, @RealCLanger? Sure I can do the further related backports. Are JDK-8331405 and JDK-8331411 sufficient? @shipilev ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/192#issuecomment-2122186276 From mdoerr at openjdk.org Tue May 21 09:45:07 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 21 May 2024 09:45:07 GMT Subject: [jdk22u] RFR: 8272364: Parallel GC adaptive size policy may shrink the heap below MinHeapSize In-Reply-To: References: Message-ID: On Mon, 20 May 2024 18:25:59 GMT, Zhengyu Gu wrote: > The backport is not clean. > > The conflict is in the new test, which uses new API introduced by JDK-8321812 in 23. The issue is resolved by fall back to use old API in 22. > > This risk of the backport is low and shrinking heap below minimum heap size is an unpleasant surpprise. This change causes test errors [JDK-8331675](https://bugs.openjdk.org/browse/JDK-8331675). Shouldn't they get addressed first? ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/217#issuecomment-2122212272 From andrewlu at openjdk.org Tue May 21 09:59:13 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 21 May 2024 09:59:13 GMT Subject: [jdk21u-dev] Integrated: 8321107: Add more test cases for JDK-8319372 In-Reply-To: <2UKKkB-lLUGoq-23zKHQvxAvVZiKBCIPvKwjAraInIY=.51b549b8-f359-448f-bb24-ae3b992032c3@github.com> References: <2UKKkB-lLUGoq-23zKHQvxAvVZiKBCIPvKwjAraInIY=.51b549b8-f359-448f-bb24-ae3b992032c3@github.com> Message-ID: On Fri, 17 May 2024 05:31:59 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: c44d4e93 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/c44d4e936f82c502af5745cf1a6495045731b369 Stats: 134 lines in 1 file changed: 134 ins; 0 del; 0 mod 8321107: Add more test cases for JDK-8319372 Backport-of: ecd335d8f42757d332f217e220e1a9db8c48c8d6 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/582 From mdoerr at openjdk.org Tue May 21 10:35:06 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 21 May 2024 10:35:06 GMT Subject: [jdk21u-dev] RFR: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 In-Reply-To: References: Message-ID: On Mon, 20 May 2024 08:08:56 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. > This PR contains a backport of > https://github.com/openjdk/jdk/commit/5045839cb2095105a5c6c9eebc633a78b1e3213e > Patch is not clean, this file test/hotspot/jtreg/gc/g1/TestHumongousAllocConcurrentStart.java has changed by the commit > https://github.com/openjdk/jdk/commit/1d1cd32bc355a33448d8f15555e142570bb49c21 > , I ignored this commits and only change code for this issue. Oracle has also backported [JDK-8321812](https://bugs.openjdk.org/browse/JDK-8321812). I think it would be better to backport that one first to reduce merge conflicts. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/589#issuecomment-2122310324 From shade at openjdk.org Tue May 21 12:08:09 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 21 May 2024 12:08:09 GMT Subject: [jdk22u] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: References: <1pUPgnbRaHJRzDtyfw1NJp2v9GP555PFzVf2-RyyMTc=.0ce4d64d-005e-44de-94a8-9ee76fedd11a@github.com> <9OA75hEgO6gg1KjViuR_OmjfxpCNCLF_fSIQt8YjdOQ=.ce318bd3-ed39-4ee8-8b7c-5d45f2f4cb8a@github.com> Message-ID: On Tue, 21 May 2024 08:32:06 GMT, Aleksey Shipilev wrote: >> @mmyxym would you mind integrating this to proceed with further backports? > > Yeah, I guess it is fine for 22u: early exposure to fixes, and all that. What further backports you had in mind, @RealCLanger? > Sure I can do the further related backports. Are JDK-8331405 and JDK-8331411 sufficient? @shipilev We caught a little regression with JDK-8331405 today, investigating. This is why I think we need to wait a bit with 21u backports. This particular one for 22u is fine, but not others. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/192#issuecomment-2122483522 From sgehwolf at openjdk.org Tue May 21 12:42:08 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 21 May 2024 12:42:08 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v4] In-Reply-To: References: Message-ID: On Tue, 21 May 2024 08:10:40 GMT, Mar?a Arias de Reyna wrote: >> Backport for https://bugs.openjdk.org/browse/JDK-8316138 >> >> Related to https://github.com/openjdk/jdk21u-dev/pull/581 and https://github.com/openjdk/jdk17u-dev/pull/2479 >> >> Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. >> >> >> ]$ make run-test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java" >> Building target 'run-test' in configuration 'linux-x86_64-normal-server-release' >> Skip building of Graal unit tests because 3rd party libraries directory is not specified >> Skip building of Graal unit tests because 3rd party libraries directory is not specified >> Creating jdk image >> Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run: >> * jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java >> >> Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' >> Passed: sun/security/lib/cacerts/VerifyCACerts.java >> Test results: passed: 1 >> Report written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html >> Results written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java >> Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' >> Test report is stored in build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> Finished building target 'run-test' in configuration 'linux-x86_64-normal-server-release' > > Mar?a Arias de Reyna has updated the pull request incrementally with one additional commit since the last revision: > > Removing -Dcom.sun.security.ocsp.useget=false because it is of no use here without JDK-8328638 > Adding white line between switch case statements as in JDK 17 Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2715#pullrequestreview-2068521940 From mbaesken at openjdk.org Tue May 21 13:17:03 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 21 May 2024 13:17:03 GMT Subject: [jdk22u] Integrated: 8330464: hserr generic events - add entry for the before_exit calls In-Reply-To: References: Message-ID: On Thu, 16 May 2024 10:57:02 GMT, Matthias Baesken wrote: > 8330464: hserr generic events - add entry for the before_exit calls This pull request has now been integrated. Changeset: f539469c Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/f539469ccf2fca281637e2e3fbbc51e9baf66973 Stats: 7 lines in 2 files changed: 3 ins; 0 del; 4 mod 8330464: hserr generic events - add entry for the before_exit calls Backport-of: 45ed97f15b96071e5d6b6d21e8f0129eda5aa447 ------------- PR: https://git.openjdk.org/jdk22u/pull/212 From mbaesken at openjdk.org Tue May 21 13:17:08 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 21 May 2024 13:17:08 GMT Subject: [jdk22u] Integrated: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms In-Reply-To: <4wYNLFIS2epPtZCKdiAzOOf4CplfVvFDkPbl00CT7Rg=.f063bcb9-64d7-4546-875c-41b092853f3a@github.com> References: <4wYNLFIS2epPtZCKdiAzOOf4CplfVvFDkPbl00CT7Rg=.f063bcb9-64d7-4546-875c-41b092853f3a@github.com> Message-ID: <6yXDxPWIExAu7WgZMTWJ7oH19iXefIYRIBW0N9Slsz4=.810d1155-3415-48ca-8efd-51135f70d91e@github.com> On Thu, 16 May 2024 11:52:53 GMT, Matthias Baesken wrote: > 8331031: unify os::dont_yield and os::naked_yield across Posix platforms This pull request has now been integrated. Changeset: da980f9e Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/da980f9e578d69b3021c0f310600e69170800461 Stats: 45 lines in 4 files changed: 8 ins; 37 del; 0 mod 8331031: unify os::dont_yield and os::naked_yield across Posix platforms Backport-of: c9442014e561f8e1cb43a0e9f18a9a5ae2a7a2da ------------- PR: https://git.openjdk.org/jdk22u/pull/213 From mbaesken at openjdk.org Tue May 21 13:19:04 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 21 May 2024 13:19:04 GMT Subject: [jdk22u] Integrated: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections In-Reply-To: References: Message-ID: On Thu, 16 May 2024 07:30:22 GMT, Matthias Baesken wrote: > Backport 8329605 This pull request has now been integrated. Changeset: 45418239 Author: Matthias Baesken URL: https://git.openjdk.org/jdk22u/commit/45418239e81a058317dd932458858283f406fa48 Stats: 40 lines in 6 files changed: 32 ins; 0 del; 8 mod 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections Backport-of: 397d94831033e91c7a849774bf4e80d8f1c8ec66 ------------- PR: https://git.openjdk.org/jdk22u/pull/211 From mbaesken at openjdk.org Tue May 21 13:24:23 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 21 May 2024 13:24:23 GMT Subject: [jdk21u-dev] RFR: 8330464: hserr generic events - add entry for the before_exit calls Message-ID: <1EXjQJK5DI79UhDDbVX8pNZAqYasLLkafUcvrwCoCQ0=.a48b47e8-b263-4841-9e68-a176ad91bcb9@github.com> 8330464: hserr generic events - add entry for the before_exit calls ------------- Commit messages: - Backport 45ed97f15b96071e5d6b6d21e8f0129eda5aa447 Changes: https://git.openjdk.org/jdk21u-dev/pull/593/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=593&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330464 Stats: 7 lines in 2 files changed: 3 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/593.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/593/head:pull/593 PR: https://git.openjdk.org/jdk21u-dev/pull/593 From sgehwolf at openjdk.org Tue May 21 15:40:11 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 21 May 2024 15:40:11 GMT Subject: [jdk11u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates [v3] In-Reply-To: References: Message-ID: On Tue, 21 May 2024 08:15:10 GMT, Mar?a Arias de Reyna wrote: >> The [8u backport](https://github.com/openjdk/jdk8u-dev/pull/502) makes a good point that `-Dcom.sun.security.ocsp.useget=false` is of no use here without [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638). I would thus remove those lines as in the 8u version. >> >> Also, when comparing with 8u, I noticed that the 11u version only is missing a newline between the new `case` statements and the earlier ones: >> >> 17u: >> ~~~ >> "https://revoked.root-e1.certainly.com"); >> >> + case "globalsignr46" -> >> + new CATestURLs("https://valid.r46.roots.globalsign.com", >> + "https://revoked.r46.roots.globalsign.com"); >> + case "globalsigne46" -> >> + new CATestURLs("https://valid.e46.roots.globalsign.com", >> + "https://revoked.e46.roots.globalsign.com"); >> + >> default -> throw new RuntimeException("No test setup found for: " + alias); >> ~~~ >> >> 11u: >> ~~~ >> "https://revoked.root-e1.certainly.com"); >> + case "globalsignr46": >> + return new CATestURLs("https://valid.r46.roots.globalsign.com", >> + "https://revoked.r46.roots.globalsign.com"); >> + case "globalsigne46": >> + return new CATestURLs("https://valid.e46.roots.globalsign.com", >> + "https://revoked.e46.roots.globalsign.com"); >> >> default: throw new RuntimeException("No test setup found for: " + alias); >> ~~~ >> >> It would be good if all three backports matched. > > @gnu-andrew Changes pushed and the test run locally. @Delawen Please ask for approval using the `/approval` command before you integrate. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2715#issuecomment-2122908985 From duke at openjdk.org Tue May 21 15:57:34 2024 From: duke at openjdk.org (fitzsim) Date: Tue, 21 May 2024 15:57:34 GMT Subject: [jdk17u-dev] RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls Message-ID: I propose backporting the fix for `8286781` to `jdk17u`. I tested the changes on `jdk17u-dev` `master`, on `Fedora 38` `x86-64`, `slowdebug` and `fastdebug` configurations. The test was to run `IdealGraphVisualizer`, per `jdk17u-dev/src/utils/IdealGraphVisualizer/README.md`, then run, e.g.: ./build/linux-x86_64-server-fastdebug/jdk/bin/java -XX:+PrintIdealGraph -XX:PrintIdealGraphLevel=1 -classpath ~/source/hello-java Hello I needed extra JVM arguments in `jdk17u-dev/src/utils/IdealGraphVisualizer/application/target/idealgraphvisualizer/bin/idealgraphvisualizer` to make the visualizer utility work on 17: --jdkhome '"$jdkhome"' \ -J--add-opens=java.base/java.net=ALL-UNNAMED \ -J--add-opens=java.base/java.security=ALL-UNNAMED \ -J--add-opens=java.base/java.lang=ALL-UNNAMED \ -J--add-opens=java.desktop/sun.awt=ALL-UNNAMED \ -J--add-opens=java.desktop/javax.swing.plaf.synth=ALL-UNNAMED \ -J--add-opens=java.desktop/javax.swing=ALL-UNNAMED \ -J--add-exports=java.desktop/com.sun.java.swing.plaf.gtk=ALL-UNNAMED \ --clusters '"$clusters"' \ Networking between the test and the utility worked fine with the backport applied. ------------- Commit messages: - 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls Changes: https://git.openjdk.org/jdk17u-dev/pull/2487/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2487&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286781 Stats: 39 lines in 5 files changed: 13 ins; 16 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2487.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2487/head:pull/2487 PR: https://git.openjdk.org/jdk17u-dev/pull/2487 From duke at openjdk.org Tue May 21 16:02:08 2024 From: duke at openjdk.org (fitzsim) Date: Tue, 21 May 2024 16:02:08 GMT Subject: [jdk17u-dev] RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls In-Reply-To: References: Message-ID: On Tue, 21 May 2024 15:49:26 GMT, fitzsim wrote: > I propose backporting the fix for `8286781` to `jdk17u`. > > I tested the changes on `jdk17u-dev` `master`, on `Fedora 38` `x86-64`, `slowdebug` and `fastdebug` configurations. The test was to run `IdealGraphVisualizer`, per `jdk17u-dev/src/utils/IdealGraphVisualizer/README.md`, then run, e.g.: > > > ./build/linux-x86_64-server-fastdebug/jdk/bin/java -XX:+PrintIdealGraph -XX:PrintIdealGraphLevel=1 -classpath ~/source/hello-java Hello > > > I needed extra JVM arguments in `jdk17u-dev/src/utils/IdealGraphVisualizer/application/target/idealgraphvisualizer/bin/idealgraphvisualizer` to make the visualizer utility work on 17: > > > --jdkhome '"$jdkhome"' \ > -J--add-opens=java.base/java.net=ALL-UNNAMED \ > -J--add-opens=java.base/java.security=ALL-UNNAMED \ > -J--add-opens=java.base/java.lang=ALL-UNNAMED \ > -J--add-opens=java.desktop/sun.awt=ALL-UNNAMED \ > -J--add-opens=java.desktop/javax.swing.plaf.synth=ALL-UNNAMED \ > -J--add-opens=java.desktop/javax.swing=ALL-UNNAMED \ > -J--add-exports=java.desktop/com.sun.java.swing.plaf.gtk=ALL-UNNAMED \ > --clusters '"$clusters"' \ > > > Networking between the test and the utility worked fine with the backport applied. I have not tested this on Windows yet. I did not realize testing is not configured on jdk17u-dev. I will try to at least get the pre-submit tests run on my private repo (or some other way). ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2487#issuecomment-2122952070 From mdoerr at openjdk.org Tue May 21 17:07:07 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 21 May 2024 17:07:07 GMT Subject: [jdk17u-dev] RFR: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel In-Reply-To: References: Message-ID: On Fri, 17 May 2024 08:51:22 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. I think we need to postpone this one. [JDK-8327137](https://bugs.openjdk.org/browse/JDK-8327137) has related issues which will also need to get ready for backport. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2477#issuecomment-2123066624 From mdoerr at openjdk.org Tue May 21 17:09:03 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 21 May 2024 17:09:03 GMT Subject: [jdk11u-dev] RFR: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel In-Reply-To: References: Message-ID: On Fri, 17 May 2024 08:54:16 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. I think we need to postpone this one. [JDK-8327137](https://bugs.openjdk.org/browse/JDK-8327137) has related issues which will also need to get ready for backport. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2713#issuecomment-2123070993 From mdoerr at openjdk.org Tue May 21 19:37:18 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 21 May 2024 19:37:18 GMT Subject: [jdk21u-dev] RFR: 8321812: Update GC tests to use execute[Limited]TestJava Message-ID: <6XPAgF2OxVYW7-cv_vLtsWxmu9nO7aYzmmmz4rR13cs=.ba07d215-6781-49c5-bf7b-01211fcc2ad6@github.com> Mostly clean backport of [JDK-8321812](https://bugs.openjdk.org/browse/JDK-8321812). Manual integration was needed in the following files, but trivial to resolve: test/hotspot/jtreg/gc/arguments/TestSmallInitialHeapWithLargePageAndNUMA.java test/hotspot/jtreg/gc/g1/TestEvacuationFailure.java test/hotspot/jtreg/gc/g1/TestGCLogMessages.java test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java test/hotspot/jtreg/gc/logging/TestMetaSpaceLog.java TestAllocationFailure.java was renamed from TestEvacuationFailure.java by [JDK-8319313](https://bugs.openjdk.org/browse/JDK-8319313). Skipped hunks which belong to https://github.com/openjdk/jdk/commit/38cfb220ddadbb401cc15f313aadb8234f626210 (not in 21). ------------- Commit messages: - Backport 1d1cd32bc355a33448d8f15555e142570bb49c21 Changes: https://git.openjdk.org/jdk21u-dev/pull/594/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=594&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321812 Stats: 655 lines in 129 files changed: 30 ins; 218 del; 407 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/594.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/594/head:pull/594 PR: https://git.openjdk.org/jdk21u-dev/pull/594 From syan at openjdk.org Tue May 21 20:23:03 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 21 May 2024 20:23:03 GMT Subject: [jdk21u-dev] Integrated: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all In-Reply-To: References: Message-ID: On Tue, 14 May 2024 06:50:49 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8331466](https://bugs.openjdk.org/browse/JDK-8331466). This backport is not clean because the line number of `8227120` has changed from 127 to 137. Only change the Problemlist.txt, the risk is low. > > Thanks > sendao This pull request has now been integrated. Changeset: 8ff81635 Author: SendaoYan Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/8ff816356a313e1e0fefd3b3737c73b29b56e70f Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all Backport-of: 440782e0160f867f08afbec0abf48d557a522c72 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/569 From mdoerr at openjdk.org Tue May 21 20:28:10 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 21 May 2024 20:28:10 GMT Subject: [jdk11u-dev] RFR: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used [v4] In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 16:07:23 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439). >> >> Patch is not clean. Test won't build in 11 because it can't find ```import jdk.internal.util.OperatingSystem```. >> >> This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485). >> >> I've worked around that by removing the dependency to that utility function and checking the operating system with ```test/lib/jdk/test/lib/Platform.java```. >> >> Testing: >> - [x] Modified test case passes >> >> Thanks! > > Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision: > > Using test/lib/jdk/test/lib/Platform.java instead of System.getProperty This one is ready for integration. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2679#issuecomment-2123384011 From serb at openjdk.org Tue May 21 20:33:09 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 21 May 2024 20:33:09 GMT Subject: [jdk22u] Integrated: 8332253: Linux arm32 build fails after 8292591 In-Reply-To: References: Message-ID: On Thu, 16 May 2024 03:18:26 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [95f79c67](https://github.com/openjdk/jdk/commit/95f79c678737fb8de9ed45c516761d4d818869ef) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 16 May 2024 and was reviewed by Thomas Stuefe, David Holmes and Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: b0cd6106 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk22u/commit/b0cd6106b0408a3402bf390ed0d0f09084da9291 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8332253: Linux arm32 build fails after 8292591 Backport-of: 95f79c678737fb8de9ed45c516761d4d818869ef ------------- PR: https://git.openjdk.org/jdk22u/pull/210 From serb at openjdk.org Tue May 21 20:42:09 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 21 May 2024 20:42:09 GMT Subject: [jdk21u-dev] Integrated: 8332253: Linux arm32 build fails after 8292591 In-Reply-To: References: Message-ID: On Thu, 16 May 2024 03:18:48 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [95f79c67](https://github.com/openjdk/jdk/commit/95f79c678737fb8de9ed45c516761d4d818869ef) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 16 May 2024 and was reviewed by Thomas Stuefe, David Holmes and Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: a1e0c5db Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk21u-dev/commit/a1e0c5db7407bc7d58aa55f64e3f813f2eccc6ea Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8332253: Linux arm32 build fails after 8292591 Backport-of: 95f79c678737fb8de9ed45c516761d4d818869ef ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/576 From szaldana at openjdk.org Tue May 21 20:49:10 2024 From: szaldana at openjdk.org (Sonia Zaldana Calles) Date: Tue, 21 May 2024 20:49:10 GMT Subject: [jdk11u-dev] Integrated: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used In-Reply-To: References: Message-ID: On Tue, 23 Apr 2024 14:21:28 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This PR contains a backport of [43c6f0b5880899b797fab2f851bd35be1c342439](https://github.com/openjdk/jdk/commit/43c6f0b5880899b797fab2f851bd35be1c342439). > > Patch is not clean. Test won't build in 11 because it can't find ```import jdk.internal.util.OperatingSystem```. > > This class was introduced in 21 as part of [JDK-8303485](https://bugs.openjdk.org/browse/JDK-8303485). > > I've worked around that by removing the dependency to that utility function and checking the operating system with ```test/lib/jdk/test/lib/Platform.java```. > > Testing: > - [x] Modified test case passes > > Thanks! This pull request has now been integrated. Changeset: b8ee2aa1 Author: Sonia Zaldana Calles Committer: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/b8ee2aa15ab538f5a0623b391e1c64e5e63e167a Stats: 50 lines in 1 file changed: 32 ins; 5 del; 13 mod 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used Reviewed-by: mdoerr Backport-of: 43c6f0b5880899b797fab2f851bd35be1c342439 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2679 From serb at openjdk.org Wed May 22 00:26:17 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 22 May 2024 00:26:17 GMT Subject: [jdk22u] RFR: 8331746: Create a test to verify that the cmm id is not ignored Message-ID: Hi all, This pull request contains a backport of commit [7c750fd9](https://github.com/openjdk/jdk/commit/7c750fd95b83d0a93b0cce681dcfbbae1f220fdd) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 17 May 2024 and was reviewed by Phil Race, Dmitry Markov and Alexey Ivanov. Thanks! ------------- Commit messages: - Backport 7c750fd95b83d0a93b0cce681dcfbbae1f220fdd Changes: https://git.openjdk.org/jdk22u/pull/218/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=218&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331746 Stats: 69 lines in 1 file changed: 69 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/218.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/218/head:pull/218 PR: https://git.openjdk.org/jdk22u/pull/218 From lmao at openjdk.org Wed May 22 03:19:08 2024 From: lmao at openjdk.org (Liang Mao) Date: Wed, 22 May 2024 03:19:08 GMT Subject: [jdk22u] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: <1pUPgnbRaHJRzDtyfw1NJp2v9GP555PFzVf2-RyyMTc=.0ce4d64d-005e-44de-94a8-9ee76fedd11a@github.com> References: <1pUPgnbRaHJRzDtyfw1NJp2v9GP555PFzVf2-RyyMTc=.0ce4d64d-005e-44de-94a8-9ee76fedd11a@github.com> Message-ID: On Fri, 10 May 2024 07:33:03 GMT, Liang Mao wrote: > Clean backport of fixing rare long hand shake while mutator threads in heavy contention on ShenandoahLock. Could committers please help to sponsor? ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/192#issuecomment-2123792615 From lmao at openjdk.org Wed May 22 05:08:09 2024 From: lmao at openjdk.org (Liang Mao) Date: Wed, 22 May 2024 05:08:09 GMT Subject: [jdk22u] Integrated: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: <1pUPgnbRaHJRzDtyfw1NJp2v9GP555PFzVf2-RyyMTc=.0ce4d64d-005e-44de-94a8-9ee76fedd11a@github.com> References: <1pUPgnbRaHJRzDtyfw1NJp2v9GP555PFzVf2-RyyMTc=.0ce4d64d-005e-44de-94a8-9ee76fedd11a@github.com> Message-ID: On Fri, 10 May 2024 07:33:03 GMT, Liang Mao wrote: > Clean backport of fixing rare long hand shake while mutator threads in heavy contention on ShenandoahLock. This pull request has now been integrated. Changeset: ae8dae9d Author: Liang Mao Committer: Christoph Langer URL: https://git.openjdk.org/jdk22u/commit/ae8dae9d655efcfe14cbce62c2d98a8cab45765d Stats: 67 lines in 3 files changed: 48 ins; 1 del; 18 mod 8325587: Shenandoah: ShenandoahLock should allow blocking in VM Backport-of: 492e8bf563135d27b46fde198880e62d5f1940e8 ------------- PR: https://git.openjdk.org/jdk22u/pull/192 From syan at openjdk.org Wed May 22 06:49:09 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 22 May 2024 06:49:09 GMT Subject: [jdk21u-dev] RFR: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all In-Reply-To: References: Message-ID: On Tue, 14 May 2024 06:50:49 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8331466](https://bugs.openjdk.org/browse/JDK-8331466). This backport is not clean because the line number of `8227120` has changed from 127 to 137. Only change the Problemlist.txt, the risk is low. > > Thanks > sendao > /sponsor Thanks for the approve and sponsor. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/569#issuecomment-2123994816 From mbaesken at openjdk.org Wed May 22 08:07:01 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 22 May 2024 08:07:01 GMT Subject: [jdk21u-dev] RFR: 8321812: Update GC tests to use execute[Limited]TestJava In-Reply-To: <6XPAgF2OxVYW7-cv_vLtsWxmu9nO7aYzmmmz4rR13cs=.ba07d215-6781-49c5-bf7b-01211fcc2ad6@github.com> References: <6XPAgF2OxVYW7-cv_vLtsWxmu9nO7aYzmmmz4rR13cs=.ba07d215-6781-49c5-bf7b-01211fcc2ad6@github.com> Message-ID: On Tue, 21 May 2024 16:35:16 GMT, Martin Doerr wrote: > Mostly clean backport of [JDK-8321812](https://bugs.openjdk.org/browse/JDK-8321812). > Manual integration was needed in the following files, but trivial to resolve: > test/hotspot/jtreg/gc/arguments/TestSmallInitialHeapWithLargePageAndNUMA.java > test/hotspot/jtreg/gc/g1/TestEvacuationFailure.java > test/hotspot/jtreg/gc/g1/TestGCLogMessages.java > test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java > test/hotspot/jtreg/gc/logging/TestMetaSpaceLog.java > TestAllocationFailure.java was renamed from TestEvacuationFailure.java by [JDK-8319313](https://bugs.openjdk.org/browse/JDK-8319313). > Skipped hunks which belong to https://github.com/openjdk/jdk/commit/38cfb220ddadbb401cc15f313aadb8234f626210 (not in 21). Marked as reviewed by mbaesken (Reviewer). test/hotspot/jtreg/gc/testlibrary/Helpers.java first hunk throws Exception now (not IOException) see javadoc ; but this is wrong already in the original change not the backport so a separate JBS issue should be filed . ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/594#pullrequestreview-2070435251 PR Comment: https://git.openjdk.org/jdk21u-dev/pull/594#issuecomment-2124130545 From mdoerr at openjdk.org Wed May 22 08:19:07 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 22 May 2024 08:19:07 GMT Subject: [jdk21u-dev] RFR: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel In-Reply-To: References: Message-ID: On Fri, 17 May 2024 08:47:12 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. We should postpone this one. There are more backports needed. We got: Exception in Basic L&F File Loading Thread: class java.util.ConcurrentModificationException java.util.ConcurrentModificationException at java.base/java.util.AbstractList$SubList.checkForComodification(AbstractList.java:906) ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/584#issuecomment-2124156027 From duke at openjdk.org Wed May 22 09:58:16 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Wed, 22 May 2024 09:58:16 GMT Subject: [jdk11u-dev] Integrated: 8316138: Add GlobalSign 2 TLS root certificates In-Reply-To: References: Message-ID: On Fri, 17 May 2024 13:41:43 GMT, Mar?a Arias de Reyna wrote: > Backport for https://bugs.openjdk.org/browse/JDK-8316138 > > Related to https://github.com/openjdk/jdk21u-dev/pull/581 and https://github.com/openjdk/jdk17u-dev/pull/2479 > > Changes since the original commit: the checksum for the certificates and the folder where the certs are stored. > > > ]$ make run-test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java" > Building target 'run-test' in configuration 'linux-x86_64-normal-server-release' > Skip building of Graal unit tests because 3rd party libraries directory is not specified > Skip building of Graal unit tests because 3rd party libraries directory is not specified > Creating jdk image > Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run: > * jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java > > Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' > Passed: sun/security/lib/cacerts/VerifyCACerts.java > Test results: passed: 1 > Report written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html > Results written to /home/delawen/git/jdk11u-dev/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java > Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java' > Test report is stored in build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java > 1 1 0 0 > ============================== > TEST SUCCESS > > Finished building target 'run-test' in configuration 'linux-x86_64-normal-server-release' This pull request has now been integrated. Changeset: b7596f3f Author: Mar?a Arias de Reyna Committer: Martin Doerr URL: https://git.openjdk.org/jdk11u-dev/commit/b7596f3f9d0b442628272459f3f22b3d36634967 Stats: 92 lines in 4 files changed: 89 ins; 0 del; 3 mod 8316138: Add GlobalSign 2 TLS root certificates Reviewed-by: mdoerr, sgehwolf Backport-of: 4083255440cfbf39b9683ea88a433d71ec6111e7 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2715 From christoph.langer at sap.com Wed May 22 13:59:56 2024 From: christoph.langer at sap.com (Langer, Christoph) Date: Wed, 22 May 2024 13:59:56 +0000 Subject: [21u, 17u, 11u reminder]: Rampdown starts Tuesday, May 28, 18:00 CET. Message-ID: Hi, I would like to remind everybody who is working on jdk 21, 17 and 11 updates that Rampdown for the July releases 21.0.4, 17.0.12 and 11.0.24 starts next Tuesday, May 28, at 18:00 CET. At that point in time the last merge from jdk<*>u-dev to jdk<*>u will take place. Please integrate all changes you want to get in before that date. Changes targeting the aforementioned releases during rampdown will have a higher bar, must be requested with jdk<*>u-critical-request tags, and they need to be opened directly to the respective jdk<*>u repositories. Best regards Christoph See also: https://wiki.openjdk.org/display/JDKUpdates/JDK+21u https://wiki.openjdk.org/display/JDKUpdates/JDK+17u https://wiki.openjdk.org/display/JDKUpdates/JDK11u -------------- next part -------------- An HTML attachment was scrubbed... URL: From clanger at openjdk.org Wed May 22 14:31:23 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 22 May 2024 14:31:23 GMT Subject: [jdk21u-dev] RFR: 8330814: Cleanups for KeepAliveCache tests Message-ID: <1GSSSzfdq7x31HZqDqVOUcehcj2tFydff2Hlprns5qk=.a803a60c-d001-4910-b161-5cb8249bed84@github.com> Hi all, This pull request contains a backport of [JDK-8330814](https://bugs.openjdk.org/browse/JDK-8330814), commit [1e173f9d](https://github.com/openjdk/jdk22u/commit/1e173f9d17e4a42e758217ac98aec4356acac0fa) from the [openjdk/jdk22u](https://git.openjdk.org/jdk22u) repository. The commit being backported was authored by Christoph Langer on 21 May 2024 and had no reviewers. Thanks! ------------- Commit messages: - Backport 1e173f9d17e4a42e758217ac98aec4356acac0fa Changes: https://git.openjdk.org/jdk21u-dev/pull/595/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=595&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330814 Stats: 290 lines in 5 files changed: 113 ins; 69 del; 108 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/595.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/595/head:pull/595 PR: https://git.openjdk.org/jdk21u-dev/pull/595 From andrew at openjdk.org Wed May 22 15:31:10 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 22 May 2024 15:31:10 GMT Subject: [jdk17u-dev] RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls In-Reply-To: References: Message-ID: <2Qyn1fxpeXeDq0e5YqibAZTc0-hiFHJBIAiYVFS_4Lc=.5143ae0d-2bb6-41f8-aab0-6d980464a2b4@github.com> On Tue, 21 May 2024 15:49:26 GMT, fitzsim wrote: > I propose backporting the fix for `8286781` to `jdk17u`. > > I tested the changes on `jdk17u-dev` `master`, on `Fedora 38` `x86-64`, `slowdebug` and `fastdebug` configurations. The test was to run `IdealGraphVisualizer`, per `jdk17u-dev/src/utils/IdealGraphVisualizer/README.md`, then run, e.g.: > > > ./build/linux-x86_64-server-fastdebug/jdk/bin/java -XX:+PrintIdealGraph -XX:PrintIdealGraphLevel=1 -classpath ~/source/hello-java Hello > > > I needed extra JVM arguments in `jdk17u-dev/src/utils/IdealGraphVisualizer/application/target/idealgraphvisualizer/bin/idealgraphvisualizer` to make the visualizer utility work on 17: > > > --jdkhome '"$jdkhome"' \ > -J--add-opens=java.base/java.net=ALL-UNNAMED \ > -J--add-opens=java.base/java.security=ALL-UNNAMED \ > -J--add-opens=java.base/java.lang=ALL-UNNAMED \ > -J--add-opens=java.desktop/sun.awt=ALL-UNNAMED \ > -J--add-opens=java.desktop/javax.swing.plaf.synth=ALL-UNNAMED \ > -J--add-opens=java.desktop/javax.swing=ALL-UNNAMED \ > -J--add-exports=java.desktop/com.sun.java.swing.plaf.gtk=ALL-UNNAMED \ > --clusters '"$clusters"' \ > > > Networking between the test and the utility worked fine with the backport applied. Backport is mostly clean. The changes to remove `-D_WINSOCK_DEPRECATED_NO_WARNINGS` from `make/autoconf/flags-cflags.m4` is absent, as [JDK-8286262](https://bugs.openjdk.org/browse/JDK-8286262) is not present in 17u and it doesn't make sense to backport this kind of change. The only other difference is the `nullptr` vs `NULL` in some of the removed code, which again it doesn't make sense to backport to LTS releases. As regards running the tool, you may want to look at backporting [JDK-8279068](https://bugs.openjdk.org/browse/JDK-8279068). Despite the title "IGV: Update to work with JDK 16 and 17", it was only added to 19 and later. I can't comment on the other Maven changes in there, but I do see the `add-opens` changes being added. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2487#pullrequestreview-2071617754 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2487#issuecomment-2125088264 From andrew at openjdk.org Wed May 22 15:31:11 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 22 May 2024 15:31:11 GMT Subject: [jdk17u-dev] RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls In-Reply-To: References: Message-ID: On Tue, 21 May 2024 15:59:24 GMT, fitzsim wrote: > I have not tested this on Windows yet. I did not realize testing is not configured on jdk17u-dev. I will try to at least get the pre-submit tests run on my private repo (or some other way). You need to manually enable tests on every new repository you fork. It's a pain and easily forgotten. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2487#issuecomment-2125074769 From duke at openjdk.org Wed May 22 15:31:11 2024 From: duke at openjdk.org (fitzsim) Date: Wed, 22 May 2024 15:31:11 GMT Subject: [jdk17u-dev] RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls In-Reply-To: References: Message-ID: On Wed, 22 May 2024 15:22:19 GMT, Andrew John Hughes wrote: >> I have not tested this on Windows yet. I did not realize testing is not configured on jdk17u-dev. I will try to at least get the pre-submit tests run on my private repo (or some other way). > >> I have not tested this on Windows yet. I did not realize testing is not configured on jdk17u-dev. I will try to at least get the pre-submit tests run on my private repo (or some other way). > > You need to manually enable tests on every new repository you fork. It's a pain and easily forgotten. Thank you for reviewing @gnu-andrew. I enabled Actions on my fork of the `jdk17u-dev` repository and they are running now. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2487#issuecomment-2125084127 From duke at openjdk.org Wed May 22 15:58:10 2024 From: duke at openjdk.org (fitzsim) Date: Wed, 22 May 2024 15:58:10 GMT Subject: [jdk17u-dev] RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls In-Reply-To: <2Qyn1fxpeXeDq0e5YqibAZTc0-hiFHJBIAiYVFS_4Lc=.5143ae0d-2bb6-41f8-aab0-6d980464a2b4@github.com> References: <2Qyn1fxpeXeDq0e5YqibAZTc0-hiFHJBIAiYVFS_4Lc=.5143ae0d-2bb6-41f8-aab0-6d980464a2b4@github.com> Message-ID: On Wed, 22 May 2024 15:28:41 GMT, Andrew John Hughes wrote: > As regards running the tool, you may want to look at backporting [JDK-8279068](https://bugs.openjdk.org/browse/JDK-8279068). Good idea; I opened #2488. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2487#issuecomment-2125143667 From duke at openjdk.org Wed May 22 15:58:37 2024 From: duke at openjdk.org (fitzsim) Date: Wed, 22 May 2024 15:58:37 GMT Subject: [jdk17u-dev] RFR: 8279068: IGV: Update to work with JDK 16 and 17 Message-ID: I propose the following backport to `jdk17u-dev`: 8279068: IGV: Update to work with JDK 16 and 17 Reviewed-by: kvn, neliasso, chagedorn Backport-of: 7bcca7692b62a37f70c757694f6acff0295371cc This is a mostly-clean backport to 17. I had to move and apply manually these two lines: --- src/utils/IdealGraphVisualizer/pom.xml +++ src/utils/IdealGraphVisualizer/pom.xml @@ -110,11 +131,12 @@ View - RELEASE123 + RELEASE126 1.0.2 4.6 3.8.1 3.2.0 + 3.0.0 4.13.2 1.14 1.3.26 With this backport `mvn install; sh igv.sh` works fine for me on `x86-64 Fedora 38`, `fastdebug` build, without needing to add JVM options to the `idealgraphviewer` wrapper script, which I needed to do when testing #2487. ------------- Commit messages: - 8279068: IGV: Update to work with JDK 16 and 17 Changes: https://git.openjdk.org/jdk17u-dev/pull/2488/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2488&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8279068 Stats: 142 lines in 22 files changed: 121 ins; 0 del; 21 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2488.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2488/head:pull/2488 PR: https://git.openjdk.org/jdk17u-dev/pull/2488 From duke at openjdk.org Wed May 22 17:46:06 2024 From: duke at openjdk.org (fitzsim) Date: Wed, 22 May 2024 17:46:06 GMT Subject: [jdk17u-dev] RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls In-Reply-To: References: Message-ID: On Tue, 21 May 2024 15:49:26 GMT, fitzsim wrote: > I propose backporting the fix for `8286781` to `jdk17u`. > > I tested the changes on `jdk17u-dev` `master`, on `Fedora 38` `x86-64`, `slowdebug` and `fastdebug` configurations. The test was to run `IdealGraphVisualizer`, per `jdk17u-dev/src/utils/IdealGraphVisualizer/README.md`, then run, e.g.: > > > ./build/linux-x86_64-server-fastdebug/jdk/bin/java -XX:+PrintIdealGraph -XX:PrintIdealGraphLevel=1 -classpath ~/source/hello-java Hello > > > I needed extra JVM arguments in `jdk17u-dev/src/utils/IdealGraphVisualizer/application/target/idealgraphvisualizer/bin/idealgraphvisualizer` to make the visualizer utility work on 17: > > > --jdkhome '"$jdkhome"' \ > -J--add-opens=java.base/java.net=ALL-UNNAMED \ > -J--add-opens=java.base/java.security=ALL-UNNAMED \ > -J--add-opens=java.base/java.lang=ALL-UNNAMED \ > -J--add-opens=java.desktop/sun.awt=ALL-UNNAMED \ > -J--add-opens=java.desktop/javax.swing.plaf.synth=ALL-UNNAMED \ > -J--add-opens=java.desktop/javax.swing=ALL-UNNAMED \ > -J--add-exports=java.desktop/com.sun.java.swing.plaf.gtk=ALL-UNNAMED \ > --clusters '"$clusters"' \ > > > Networking between the test and the utility worked fine with the backport applied. All the automated builds passed. I do not currently have access to `Windows` or `macOS` environments to test `IdealGraphVisualizer` on those operating systems though, however, since it is the same network connection code and it built on both those operating systems, I expect connecting to the visualizer will work. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2487#issuecomment-2125405363 From duke at openjdk.org Wed May 22 18:13:07 2024 From: duke at openjdk.org (Elif Aslan) Date: Wed, 22 May 2024 18:13:07 GMT Subject: [jdk17u-dev] RFR: 8273153: Consolidate file_exists into os:file_exists In-Reply-To: References: Message-ID: On Sat, 9 Mar 2024 19:51:43 GMT, Elif Aslan wrote: > Clean backport to Consolidate file_exists into os:file_exists > This backport is required to close [this](https://github.com/openjdk/jdk/commit/9732fbe428c3b6a5422cc94e7295ba5482d1a7a9) backport clean. > > Additional testing in addition to GHA tests > > jtreg/tier2 This backport is going to fix a crash seen in Amazon production @GoeLin . I am going to add this to my approval request to pass it to JBS issue.. TIA ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2281#issuecomment-2125451737 From clanger at openjdk.org Wed May 22 21:13:11 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 22 May 2024 21:13:11 GMT Subject: [jdk21u-dev] RFR: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules In-Reply-To: References: Message-ID: On Tue, 21 May 2024 06:41:35 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. > ?applications/ctw/modules/jdk_crypto_ec.java 8312194 generic-all? not in test/hotspot/jtreg/ProblemList.txt, > so make it clean Hm, I'm not sure if backporting this makes sense since the jdk.crypto.ec module was emptied only in JDK22... ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/590#issuecomment-2125751502 From mdoerr at openjdk.org Wed May 22 21:41:11 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 22 May 2024 21:41:11 GMT Subject: [jdk21u-dev] RFR: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules In-Reply-To: References: Message-ID: On Tue, 21 May 2024 06:41:35 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. > ?applications/ctw/modules/jdk_crypto_ec.java 8312194 generic-all? not in test/hotspot/jtreg/ProblemList.txt, > so make it clean I don't know why Oracle has backported it, but I'd prefer to follow. Does keeping it have any advantage? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/590#issuecomment-2125799578 From duke at openjdk.org Wed May 22 21:59:09 2024 From: duke at openjdk.org (Elif Aslan) Date: Wed, 22 May 2024 21:59:09 GMT Subject: [jdk17u-dev] Integrated: 8273153: Consolidate file_exists into os:file_exists In-Reply-To: References: Message-ID: On Sat, 9 Mar 2024 19:51:43 GMT, Elif Aslan wrote: > Clean backport to Consolidate file_exists into os:file_exists > This backport is required to close [this](https://github.com/openjdk/jdk/commit/9732fbe428c3b6a5422cc94e7295ba5482d1a7a9) backport clean. > > Additional testing in addition to GHA tests > > jtreg/tier2 This pull request has now been integrated. Changeset: 6264c70c Author: Elif Aslan Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/6264c70c66dfa7b90061d8138038c5d1aa022692 Stats: 26 lines in 4 files changed: 9 ins; 13 del; 4 mod 8273153: Consolidate file_exists into os:file_exists Backport-of: 9732fbe428c3b6a5422cc94e7295ba5482d1a7a9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2281 From andrew at openjdk.org Wed May 22 23:24:06 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 22 May 2024 23:24:06 GMT Subject: [jdk17u-dev] RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls In-Reply-To: References: Message-ID: On Tue, 21 May 2024 15:49:26 GMT, fitzsim wrote: > I propose backporting the fix for `8286781` to `jdk17u`. > > I tested the changes on `jdk17u-dev` `master`, on `Fedora 38` `x86-64`, `slowdebug` and `fastdebug` configurations. The test was to run `IdealGraphVisualizer`, per `jdk17u-dev/src/utils/IdealGraphVisualizer/README.md`, then run, e.g.: > > > ./build/linux-x86_64-server-fastdebug/jdk/bin/java -XX:+PrintIdealGraph -XX:PrintIdealGraphLevel=1 -classpath ~/source/hello-java Hello > > > I needed extra JVM arguments in `jdk17u-dev/src/utils/IdealGraphVisualizer/application/target/idealgraphvisualizer/bin/idealgraphvisualizer` to make the visualizer utility work on 17: > > > --jdkhome '"$jdkhome"' \ > -J--add-opens=java.base/java.net=ALL-UNNAMED \ > -J--add-opens=java.base/java.security=ALL-UNNAMED \ > -J--add-opens=java.base/java.lang=ALL-UNNAMED \ > -J--add-opens=java.desktop/sun.awt=ALL-UNNAMED \ > -J--add-opens=java.desktop/javax.swing.plaf.synth=ALL-UNNAMED \ > -J--add-opens=java.desktop/javax.swing=ALL-UNNAMED \ > -J--add-exports=java.desktop/com.sun.java.swing.plaf.gtk=ALL-UNNAMED \ > --clusters '"$clusters"' \ > > > Networking between the test and the utility worked fine with the backport applied. I don't think it's reasonable to expect every patch submission to be tested on every possible platform. Those who want to produce builds on that platform and have the resources to do so should be regularly testing and maintaining it. Full testing this patch on every platform would also mean running the visualiser on AIX and Solaris, which aren't even tested by GHA. Where those platforms have been broken by changes in the past, those who build on them have submitted patches to fix them. I see it as a bigger issue that the visualiser doesn't even work out of the box on 17 at present and no-one has moved to fix this so far. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2487#issuecomment-2125934282 From syan at openjdk.org Thu May 23 01:41:16 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 23 May 2024 01:41:16 GMT Subject: [jdk21u-dev] RFR: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM Message-ID: Hi all, This clean backport of [JDK-8332490](https://bugs.openjdk.org/browse/JDK-8332490), to closes the InflaterInputStream when the reads complete. The change has been verified. Only change the JMH testcase, no risk. ------------- Commit messages: - Backport 98f6a80852383dcbdad7292b7d269a8547d54d45 Changes: https://git.openjdk.org/jdk21u-dev/pull/596/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=596&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332490 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/596.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/596/head:pull/596 PR: https://git.openjdk.org/jdk21u-dev/pull/596 From syan at openjdk.org Thu May 23 01:41:28 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 23 May 2024 01:41:28 GMT Subject: [jdk22u] RFR: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM Message-ID: Hi all, This clean backport of [JDK-8332490](https://bugs.openjdk.org/browse/JDK-8332490), to closes the InflaterInputStream when the reads complete. The change has been verified. Only change the JMH testcase, no risk. ------------- Commit messages: - Backport 98f6a80852383dcbdad7292b7d269a8547d54d45 Changes: https://git.openjdk.org/jdk22u/pull/219/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=219&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332490 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/219.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/219/head:pull/219 PR: https://git.openjdk.org/jdk22u/pull/219 From andrewlu at openjdk.org Thu May 23 02:03:04 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 23 May 2024 02:03:04 GMT Subject: [jdk21u-dev] Integrated: 8319338: tools/jpackage/share/RuntimeImageTest.java fails with -XX:+UseZGC In-Reply-To: References: Message-ID: On Tue, 21 May 2024 07:01:23 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: acff39d9 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/acff39d922f588dc56ade4369ad11cf717911dec Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8319338: tools/jpackage/share/RuntimeImageTest.java fails with -XX:+UseZGC Backport-of: e9eb8b98f4dd949c8a0f501189471e11b837d936 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/591 From lmao at openjdk.org Thu May 23 03:44:00 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 23 May 2024 03:44:00 GMT Subject: [jdk22u] RFR: 8329840: Fix ZPhysicalMemorySegment::_end type In-Reply-To: References: Message-ID: On Mon, 20 May 2024 02:46:21 GMT, Liang Mao wrote: > Clean backport of fixing type of ZPhysicalMemorySegment::_end type Could committers please help to sponsor? ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/216#issuecomment-2126174245 From lmao at openjdk.org Thu May 23 03:44:08 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 23 May 2024 03:44:08 GMT Subject: [jdk22u] RFR: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads In-Reply-To: References: Message-ID: <9RtjK1dtxQ8iY4owGkG3i_NVjHVPtTKJaif4pxBIcgM=.a3e7b7a4-7069-40a3-8a1c-6ef763a6d109@github.com> On Mon, 20 May 2024 02:42:16 GMT, Liang Mao wrote: > Clean backport of fixing crash on Threads::print_on() . Could committers please help to sponsor? ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/215#issuecomment-2126174181 From andrewlu at openjdk.org Thu May 23 06:18:38 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 23 May 2024 06:18:38 GMT Subject: [jdk11u-dev] RFR: 8307091: A few client tests intermittently throw ConcurrentModificationException Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 465bdd9e416cacc6cc7dd91a29cc84adf2eaf1ed Changes: https://git.openjdk.org/jdk11u-dev/pull/2720/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2720&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307091 Stats: 18 lines in 1 file changed: 8 ins; 2 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2720.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2720/head:pull/2720 PR: https://git.openjdk.org/jdk11u-dev/pull/2720 From andrewlu at openjdk.org Thu May 23 06:18:43 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 23 May 2024 06:18:43 GMT Subject: [jdk17u-dev] RFR: 8307091: A few client tests intermittently throw ConcurrentModificationException Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport 465bdd9e416cacc6cc7dd91a29cc84adf2eaf1ed Changes: https://git.openjdk.org/jdk17u-dev/pull/2489/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2489&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307091 Stats: 18 lines in 1 file changed: 8 ins; 2 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2489.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2489/head:pull/2489 PR: https://git.openjdk.org/jdk17u-dev/pull/2489 From clanger at openjdk.org Thu May 23 08:34:08 2024 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 23 May 2024 08:34:08 GMT Subject: [jdk21u-dev] RFR: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules In-Reply-To: References: Message-ID: On Tue, 21 May 2024 06:41:35 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. > ?applications/ctw/modules/jdk_crypto_ec.java 8312194 generic-all? not in test/hotspot/jtreg/ProblemList.txt, > so make it clean OK but then let's just backport it to the releases where Oracle has it as well. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/590#issuecomment-2126534387 From lmao at openjdk.org Thu May 23 08:41:04 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 23 May 2024 08:41:04 GMT Subject: [jdk22u] Integrated: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads In-Reply-To: References: Message-ID: On Mon, 20 May 2024 02:42:16 GMT, Liang Mao wrote: > Clean backport of fixing crash on Threads::print_on() . This pull request has now been integrated. Changeset: a3e51ecc Author: Liang Mao Committer: Christoph Langer URL: https://git.openjdk.org/jdk22u/commit/a3e51eccb2cda81663cf94d98bc8e1d4a6f52b1e Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod 8329109: Threads::print_on() tries to print CPU time for terminated GC threads Backport-of: c1cfb43d8de8d0eed01b9bb6aa1202dc7cbff007 ------------- PR: https://git.openjdk.org/jdk22u/pull/215 From lmao at openjdk.org Thu May 23 08:42:11 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 23 May 2024 08:42:11 GMT Subject: [jdk22u] Integrated: 8329840: Fix ZPhysicalMemorySegment::_end type In-Reply-To: References: Message-ID: On Mon, 20 May 2024 02:46:21 GMT, Liang Mao wrote: > Clean backport of fixing type of ZPhysicalMemorySegment::_end type This pull request has now been integrated. Changeset: e32e05bc Author: Liang Mao Committer: Christoph Langer URL: https://git.openjdk.org/jdk22u/commit/e32e05bc63723d13be4766c82c96c6f38818b780 Stats: 56 lines in 4 files changed: 49 ins; 0 del; 7 mod 8329840: Fix ZPhysicalMemorySegment::_end type Backport-of: b4ddddeff1ce4293c88a9ab8ad3ca9d3b0e2352e ------------- PR: https://git.openjdk.org/jdk22u/pull/216 From lmao at openjdk.org Thu May 23 08:46:03 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 23 May 2024 08:46:03 GMT Subject: [jdk21u-dev] RFR: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads In-Reply-To: <1p8tz83C090_7tXTOq2k2REmG0usw4ivORdZAFBfo6M=.4a2ae875-43fb-43ae-b483-8adaef4aa858@github.com> References: <1p8tz83C090_7tXTOq2k2REmG0usw4ivORdZAFBfo6M=.4a2ae875-43fb-43ae-b483-8adaef4aa858@github.com> Message-ID: On Fri, 17 May 2024 09:05:54 GMT, Liang Mao wrote: > Clean backport of fixing crash on Threads::print_on() . Could committers please help to sponsor? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/585#issuecomment-2126558357 From lmao at openjdk.org Thu May 23 08:50:09 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 23 May 2024 08:50:09 GMT Subject: [jdk21u-dev] Integrated: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads In-Reply-To: <1p8tz83C090_7tXTOq2k2REmG0usw4ivORdZAFBfo6M=.4a2ae875-43fb-43ae-b483-8adaef4aa858@github.com> References: <1p8tz83C090_7tXTOq2k2REmG0usw4ivORdZAFBfo6M=.4a2ae875-43fb-43ae-b483-8adaef4aa858@github.com> Message-ID: On Fri, 17 May 2024 09:05:54 GMT, Liang Mao wrote: > Clean backport of fixing crash on Threads::print_on() . This pull request has now been integrated. Changeset: fe4a2ae5 Author: Liang Mao Committer: Christoph Langer URL: https://git.openjdk.org/jdk21u-dev/commit/fe4a2ae57072126f674b32c8e7cd719faf317c60 Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod 8329109: Threads::print_on() tries to print CPU time for terminated GC threads Backport-of: c1cfb43d8de8d0eed01b9bb6aa1202dc7cbff007 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/585 From lmao at openjdk.org Thu May 23 08:50:14 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 23 May 2024 08:50:14 GMT Subject: [jdk21u-dev] RFR: 8329840: Fix ZPhysicalMemorySegment::_end type In-Reply-To: References: Message-ID: <7TDYt4GGH4tAOclR_tgehRSkVhID1FKmdd_qnErF4gk=.aedc2d3e-2f8c-4c30-93e9-6eb7d27b3aaf@github.com> On Fri, 17 May 2024 08:37:24 GMT, Liang Mao wrote: > Clean backport of fixing type of ZPhysicalMemorySegment::_end type Could committers please help to sponsor? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/583#issuecomment-2126562081 From lmao at openjdk.org Thu May 23 08:50:15 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 23 May 2024 08:50:15 GMT Subject: [jdk21u-dev] Integrated: 8329840: Fix ZPhysicalMemorySegment::_end type In-Reply-To: References: Message-ID: On Fri, 17 May 2024 08:37:24 GMT, Liang Mao wrote: > Clean backport of fixing type of ZPhysicalMemorySegment::_end type This pull request has now been integrated. Changeset: cdfe2f44 Author: Liang Mao Committer: Christoph Langer URL: https://git.openjdk.org/jdk21u-dev/commit/cdfe2f44f672d7d2b2bef96552336cc30932197d Stats: 56 lines in 4 files changed: 49 ins; 0 del; 7 mod 8329840: Fix ZPhysicalMemorySegment::_end type Backport-of: b4ddddeff1ce4293c88a9ab8ad3ca9d3b0e2352e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/583 From lmao at openjdk.org Thu May 23 09:02:17 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 23 May 2024 09:02:17 GMT Subject: [jdk21u-dev] RFR: 8330576: ZYoungCompactionLimit should have range check Message-ID: Backport of fixing range check of ZYoungCompactionLimit. ------------- Commit messages: - Backport c4f5c5140a85818152c6e17414a36deabe491f7b Changes: https://git.openjdk.org/jdk21u-dev/pull/597/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=597&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330576 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/597.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/597/head:pull/597 PR: https://git.openjdk.org/jdk21u-dev/pull/597 From lmao at openjdk.org Thu May 23 09:04:29 2024 From: lmao at openjdk.org (Liang Mao) Date: Thu, 23 May 2024 09:04:29 GMT Subject: [jdk22u] RFR: 8330576: ZYoungCompactionLimit should have range check Message-ID: Backport of fixing range check of ZYoungCompactionLimit. ------------- Commit messages: - Backport c4f5c5140a85818152c6e17414a36deabe491f7b Changes: https://git.openjdk.org/jdk22u/pull/220/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=220&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330576 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/220.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/220/head:pull/220 PR: https://git.openjdk.org/jdk22u/pull/220 From andrewlu at openjdk.org Thu May 23 09:22:20 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 23 May 2024 09:22:20 GMT Subject: [jdk17u-dev] Integrated: 8321107: Add more test cases for JDK-8319372 In-Reply-To: References: Message-ID: On Fri, 17 May 2024 05:32:07 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. This pull request has now been integrated. Changeset: e00211b6 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/e00211b618891a2ff5dd938126c3bd694e8a9442 Stats: 134 lines in 1 file changed: 134 ins; 0 del; 0 mod 8321107: Add more test cases for JDK-8319372 Backport-of: ecd335d8f42757d332f217e220e1a9db8c48c8d6 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2476 From andrewlu at openjdk.org Thu May 23 09:24:05 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 23 May 2024 09:24:05 GMT Subject: [jdk21u-dev] Integrated: 8320681: [macos] Test tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java timed out on macOS In-Reply-To: References: Message-ID: On Tue, 21 May 2024 07:56:47 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has now been integrated. Changeset: 201e663e Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/201e663ee2714ae848c8abbbe51684f50dc2defc Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8320681: [macos] Test tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java timed out on macOS Backport-of: a657aa38a56056211a9d2773b30e8fe1a89c128e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/592 From andrewlu at openjdk.org Thu May 23 09:24:07 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 23 May 2024 09:24:07 GMT Subject: [jdk21u-dev] Integrated: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules In-Reply-To: References: Message-ID: On Tue, 21 May 2024 06:41:35 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. > ?applications/ctw/modules/jdk_crypto_ec.java 8312194 generic-all? not in test/hotspot/jtreg/ProblemList.txt, > so make it clean This pull request has now been integrated. Changeset: a4d2a5aa Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/a4d2a5aaca511e66e41524d4037f930e36e323e1 Stats: 38 lines in 1 file changed: 0 ins; 38 del; 0 mod 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules Backport-of: e7c83ea948f8b2cd7caf7e59d3cf6b087807dba7 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/590 From andrewlu at openjdk.org Thu May 23 09:24:07 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 23 May 2024 09:24:07 GMT Subject: [jdk17u-dev] Integrated: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules In-Reply-To: <1naU4Vkh6iVf_7tjxKmSTtfA96f7hMSBCHvN3zQ8Xqk=.42858c96-8195-4b35-b9af-e08570b50afe@github.com> References: <1naU4Vkh6iVf_7tjxKmSTtfA96f7hMSBCHvN3zQ8Xqk=.42858c96-8195-4b35-b9af-e08570b50afe@github.com> Message-ID: On Tue, 21 May 2024 06:41:50 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. > ?applications/ctw/modules/jdk_crypto_ec.java 8312194 generic-all? not in test/hotspot/jtreg/ProblemList.txt, > so make it clean This pull request has now been integrated. Changeset: a6400010 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/a64000108dc775574ddf8cbbcdc9cfa3975bcdde Stats: 38 lines in 1 file changed: 0 ins; 38 del; 0 mod 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules Backport-of: e7c83ea948f8b2cd7caf7e59d3cf6b087807dba7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2483 From andrewlu at openjdk.org Thu May 23 09:24:14 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 23 May 2024 09:24:14 GMT Subject: [jdk11u-dev] Integrated: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules In-Reply-To: References: Message-ID: On Tue, 21 May 2024 06:42:02 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. > ?applications/ctw/modules/jdk_crypto_ec.java 8312194 generic-all? not in test/hotspot/jtreg/ProblemList.txt, > so make it clean This pull request has now been integrated. Changeset: 35333744 Author: Andrew Lu URL: https://git.openjdk.org/jdk11u-dev/commit/35333744a8f3cf25c95ee691791b00098dde9a44 Stats: 38 lines in 1 file changed: 0 ins; 38 del; 0 mod 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules Backport-of: e7c83ea948f8b2cd7caf7e59d3cf6b087807dba7 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2718 From andrewlu at openjdk.org Thu May 23 09:24:18 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 23 May 2024 09:24:18 GMT Subject: [jdk17u-dev] Integrated: 8319338: tools/jpackage/share/RuntimeImageTest.java fails with -XX:+UseZGC In-Reply-To: References: Message-ID: On Tue, 21 May 2024 07:01:34 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. This pull request has now been integrated. Changeset: a632247d Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/a632247d38bb176359d2465712ceb8352b69cb39 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8319338: tools/jpackage/share/RuntimeImageTest.java fails with -XX:+UseZGC Backport-of: e9eb8b98f4dd949c8a0f501189471e11b837d936 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2484 From mdoerr at openjdk.org Thu May 23 09:28:03 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 23 May 2024 09:28:03 GMT Subject: [jdk21u-dev] Integrated: 8321812: Update GC tests to use execute[Limited]TestJava In-Reply-To: <6XPAgF2OxVYW7-cv_vLtsWxmu9nO7aYzmmmz4rR13cs=.ba07d215-6781-49c5-bf7b-01211fcc2ad6@github.com> References: <6XPAgF2OxVYW7-cv_vLtsWxmu9nO7aYzmmmz4rR13cs=.ba07d215-6781-49c5-bf7b-01211fcc2ad6@github.com> Message-ID: On Tue, 21 May 2024 16:35:16 GMT, Martin Doerr wrote: > Mostly clean backport of [JDK-8321812](https://bugs.openjdk.org/browse/JDK-8321812). > Manual integration was needed in the following files, but trivial to resolve: > test/hotspot/jtreg/gc/arguments/TestSmallInitialHeapWithLargePageAndNUMA.java > test/hotspot/jtreg/gc/g1/TestEvacuationFailure.java > test/hotspot/jtreg/gc/g1/TestGCLogMessages.java > test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java > test/hotspot/jtreg/gc/logging/TestMetaSpaceLog.java > TestAllocationFailure.java was renamed from TestEvacuationFailure.java by [JDK-8319313](https://bugs.openjdk.org/browse/JDK-8319313). > Skipped hunks which belong to https://github.com/openjdk/jdk/commit/38cfb220ddadbb401cc15f313aadb8234f626210 (not in 21). This pull request has now been integrated. Changeset: 9035981e Author: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/9035981eca6df3a102c76453019d82a145756933 Stats: 655 lines in 129 files changed: 30 ins; 218 del; 407 mod 8321812: Update GC tests to use execute[Limited]TestJava Reviewed-by: mbaesken Backport-of: 1d1cd32bc355a33448d8f15555e142570bb49c21 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/594 From mdoerr at openjdk.org Thu May 23 10:00:07 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 23 May 2024 10:00:07 GMT Subject: [jdk17u-dev] RFR: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 In-Reply-To: References: Message-ID: On Mon, 20 May 2024 08:09:16 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. > This PR contains a backport of > https://github.com/openjdk/jdk/commit/5045839cb2095105a5c6c9eebc633a78b1e3213e > Patch is not clean, this file test/hotspot/jtreg/gc/g1/TestHumongousAllocConcurrentStart.java has changed by the commit > https://github.com/openjdk/jdk/commit/d52a995f35de26c2cc4074297a75141e4a363e1b > , I ignored this commits and only change code for this issue. Is JDK17 affected by this problem? `make run-test TEST="test/hotspot/jtreg/gc/g1/TestHumongousAllocConcurrentStart.java" JTREG="VM_OPTIONS=-XX:TieredStopAtLevel=3` has passed without the fix: ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/hotspot/jtreg/gc/g1/TestHumongousAllocConcurrentStart.java 1 1 0 0 ============================== TEST SUCCESS ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2482#issuecomment-2126703924 From duke at openjdk.org Thu May 23 10:57:33 2024 From: duke at openjdk.org (Xiaolong Peng) Date: Thu, 23 May 2024 10:57:33 GMT Subject: [jdk21u-dev] RFR: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC Message-ID: <2Kxv67UXNf7X4hFhoDZZR1dBP-gHQpNHckUzLs0rjrw=.3d94c1d3-bc7a-418b-8e53-148929d555bb@github.com> 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC ------------- Commit messages: - Backport 80ccc989a892e4d9f4e2c9395a100cfabbdcda64 Changes: https://git.openjdk.org/jdk21u-dev/pull/575/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=575&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328075 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/575.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/575/head:pull/575 PR: https://git.openjdk.org/jdk21u-dev/pull/575 From duke at openjdk.org Thu May 23 10:58:38 2024 From: duke at openjdk.org (Xiaolong Peng) Date: Thu, 23 May 2024 10:58:38 GMT Subject: [jdk22u] RFR: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC Message-ID: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC ------------- Commit messages: - Backport 80ccc989a892e4d9f4e2c9395a100cfabbdcda64 Changes: https://git.openjdk.org/jdk22u/pull/205/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=205&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328075 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk22u/pull/205.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/205/head:pull/205 PR: https://git.openjdk.org/jdk22u/pull/205 From duke at openjdk.org Thu May 23 10:59:33 2024 From: duke at openjdk.org (Xiaolong Peng) Date: Thu, 23 May 2024 10:59:33 GMT Subject: [jdk17u-dev] RFR: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC Message-ID: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC ------------- Commit messages: - Backport 80ccc989a892e4d9f4e2c9395a100cfabbdcda64 Changes: https://git.openjdk.org/jdk17u-dev/pull/2474/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2474&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328075 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2474.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2474/head:pull/2474 PR: https://git.openjdk.org/jdk17u-dev/pull/2474 From duke at openjdk.org Thu May 23 11:26:28 2024 From: duke at openjdk.org (Rinku Kumar Maurya) Date: Thu, 23 May 2024 11:26:28 GMT Subject: [jdk17u-dev] RFR: 8289643: File descriptor leak with ProcessBuilder.startPipeline Message-ID: clean backport to fix file descriptor leak with ProcessBuilder.startPipeline. When using ProcessBuilder.startPipeline the pipes (or pipe if only 2 ProcessBuilder instance used) created are never closed. with changes :- ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java 1 1 0 0 ============================== TEST SUCCESS without changes :- ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java 1 0 1 0 ============================== TEST FAILURE with expected output :- test PipelineLeaksFD.checkForLeaks(java.util.ImmutableCollections$ListN at 44d1a216): failure java.lang.AssertionError: More or fewer pipes than expected ... ------------- Commit messages: - Backport 620c8a045f92126c2552347b9f369405ab2d6d36 Changes: https://git.openjdk.org/jdk17u-dev/pull/2462/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2462&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289643 Stats: 144 lines in 2 files changed: 143 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2462.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2462/head:pull/2462 PR: https://git.openjdk.org/jdk17u-dev/pull/2462 From mbaesken at openjdk.org Thu May 23 12:29:07 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 23 May 2024 12:29:07 GMT Subject: [jdk21u-dev] Integrated: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections In-Reply-To: References: Message-ID: <5EVpvq9ClpzwQp55vL3cs4uee1KMOE4_uk-GYFSbbNo=.bd3a1265-988e-4e78-b7ca-014352ad0131@github.com> On Wed, 15 May 2024 14:30:43 GMT, Matthias Baesken wrote: > Backport 8329605 This pull request has now been integrated. Changeset: 20da646c Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/20da646c37a2170eebffb9fd2eb36814d805f63c Stats: 40 lines in 6 files changed: 32 ins; 0 del; 8 mod 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections Backport-of: 397d94831033e91c7a849774bf4e80d8f1c8ec66 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/573 From mbaesken at openjdk.org Thu May 23 12:30:07 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 23 May 2024 12:30:07 GMT Subject: [jdk21u-dev] Integrated: 8330464: hserr generic events - add entry for the before_exit calls In-Reply-To: <1EXjQJK5DI79UhDDbVX8pNZAqYasLLkafUcvrwCoCQ0=.a48b47e8-b263-4841-9e68-a176ad91bcb9@github.com> References: <1EXjQJK5DI79UhDDbVX8pNZAqYasLLkafUcvrwCoCQ0=.a48b47e8-b263-4841-9e68-a176ad91bcb9@github.com> Message-ID: On Tue, 21 May 2024 13:19:14 GMT, Matthias Baesken wrote: > 8330464: hserr generic events - add entry for the before_exit calls This pull request has now been integrated. Changeset: d9860963 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/d9860963022402b11110adb62801a2d69432d30e Stats: 7 lines in 2 files changed: 3 ins; 0 del; 4 mod 8330464: hserr generic events - add entry for the before_exit calls Backport-of: 45ed97f15b96071e5d6b6d21e8f0129eda5aa447 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/593 From mbaesken at openjdk.org Thu May 23 13:22:27 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 23 May 2024 13:22:27 GMT Subject: [jdk21u-dev] RFR: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms Message-ID: <4E2JpbICmqgvcOyQ0_zA5YjLA6iDw2kLLjS4i6NSZes=.5079f142-002e-46e3-8ce6-1f5b77c228d6@github.com> Backport 8331031 ------------- Commit messages: - Backport c9442014e561f8e1cb43a0e9f18a9a5ae2a7a2da Changes: https://git.openjdk.org/jdk21u-dev/pull/598/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=598&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331031 Stats: 45 lines in 4 files changed: 8 ins; 37 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/598.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/598/head:pull/598 PR: https://git.openjdk.org/jdk21u-dev/pull/598 From ogillespie at openjdk.org Thu May 23 15:06:03 2024 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 23 May 2024 15:06:03 GMT Subject: [jdk17u-dev] RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn In-Reply-To: References: Message-ID: On Mon, 22 Apr 2024 15:35:14 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [d23f4f12](https://github.com/openjdk/jdk/commit/d23f4f12adf1ea26b8c340efe2c3854e50b68301) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Oli Gillespie on 4 Dec 2023 and was reviewed by Coleen Phillimore, Kim Barrett and Aleksey Shipilev. > > Thanks! > > The backport is not clean. `symbolHandle` does not exist in 17, so I put the same functionality in `symbolTable` where `TempNewSymbol` resides for 17. The functionality itself is essentially identical, with the other change being that `maybe_decrement_refcount` helper also does not exist, so I just added a null check. > `test/hotspot/gtest/classfile/test_placeholders.cpp` does not exist, so it didn't need to be fixed. `test_symbolTable.cpp` failed as expected before fixing, and applied cleanly. > > > Testing on the original benchmark confirms this fixes the performance regression: > > java -Xmx1G -Xms1G -XX:+AlwaysPreTouch -jar dacapo-9.120-MR1.jar --size large --iterations 30 pmd > > Before: > ... > ===== DaCapo 9.12-MR1 pmd PASSED in 1072 msec ===== > > After: > ... > ===== DaCapo 9.12-MR1 pmd PASSED in 1013 msec ===== (keepalive) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2424#issuecomment-2127370609 From duke at openjdk.org Thu May 23 19:37:29 2024 From: duke at openjdk.org (Elif Aslan) Date: Thu, 23 May 2024 19:37:29 GMT Subject: [jdk17u-dev] RFR: 8303942: os::write should write completely Message-ID: This is not a clean backport. There were multiple merge conflicts related to undefined parameters and existing methods. This backport is required to address a crash observed in Amazon production. Please refer to the related [PR](https://github.com/openjdk/jdk17u-dev/pull/2281), which has already been merged. In addition to GHA Tier 1, runtime hotspot, JFR, and hotspot GC tests have been run on macOS. TEST TOTAL PASS FAIL ERROR jtreg:test/hotspot/jtreg:hotspot_runtime 880 880 0 0 ============================== TEST SUCCESS Finished building target 'test' in configuration 'macosx-x86_64-server-release' ------------- Commit messages: - Backport of bddf48380e658df630fecad5eda40106a24b6e1c - Backport of bddf48380e658df630fecad5eda40106a24b6e1c Changes: https://git.openjdk.org/jdk17u-dev/pull/2490/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2490&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303942 Stats: 93 lines in 10 files changed: 38 ins; 24 del; 31 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2490.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2490/head:pull/2490 PR: https://git.openjdk.org/jdk17u-dev/pull/2490 From phh at openjdk.org Thu May 23 20:28:06 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 23 May 2024 20:28:06 GMT Subject: [jdk17u-dev] RFR: 8303942: os::write should write completely In-Reply-To: References: Message-ID: <6rZjuzdq367vKkC_eb4uKPEK5ExNid547KnzuHm_l3s=.e5857525-5f46-4b29-a6db-dfc249296791@github.com> On Thu, 23 May 2024 19:33:35 GMT, Elif Aslan wrote: > This is not a clean backport. There were multiple merge conflicts related to undefined parameters and existing methods. This backport is required to address a crash observed in Amazon production. Please refer to the related [PR](https://github.com/openjdk/jdk17u-dev/pull/2281), which has already been merged. > > > In addition to GHA Tier 1, runtime hotspot, JFR, and hotspot GC tests have been run on macOS. > > > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:hotspot_runtime 880 880 0 0 > ============================== > TEST SUCCESS > > Finished building target 'test' in configuration 'macosx-x86_64-server-release' Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2490#pullrequestreview-2074930669 From btaylor at openjdk.org Thu May 23 20:32:10 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 23 May 2024 20:32:10 GMT Subject: [jdk21u-dev] Integrated: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx In-Reply-To: References: Message-ID: On Fri, 17 May 2024 19:43:04 GMT, Ben Taylor wrote: > Clean backport of a low-risk change to address unexpected behavior with Parallel GC when Xms == Xmx > Passes local tier-1 testing on linux x86_64 This pull request has now been integrated. Changeset: 4b1d95c7 Author: Ben Taylor URL: https://git.openjdk.org/jdk21u-dev/commit/4b1d95c73ca503e18636129a77c0d6c49aae4821 Stats: 11 lines in 1 file changed: 6 ins; 3 del; 2 mod 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx Backport-of: aca1e8365bf0f64bf18caf798bbca1d25b3c4117 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/587 From duke at openjdk.org Thu May 23 21:20:09 2024 From: duke at openjdk.org (fitzsim) Date: Thu, 23 May 2024 21:20:09 GMT Subject: [jdk17u-dev] Integrated: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls In-Reply-To: References: Message-ID: On Tue, 21 May 2024 15:49:26 GMT, fitzsim wrote: > I propose backporting the fix for `8286781` to `jdk17u`. > > I tested the changes on `jdk17u-dev` `master`, on `Fedora 38` `x86-64`, `slowdebug` and `fastdebug` configurations. The test was to run `IdealGraphVisualizer`, per `jdk17u-dev/src/utils/IdealGraphVisualizer/README.md`, then run, e.g.: > > > ./build/linux-x86_64-server-fastdebug/jdk/bin/java -XX:+PrintIdealGraph -XX:PrintIdealGraphLevel=1 -classpath ~/source/hello-java Hello > > > I needed extra JVM arguments in `jdk17u-dev/src/utils/IdealGraphVisualizer/application/target/idealgraphvisualizer/bin/idealgraphvisualizer` to make the visualizer utility work on 17: > > > --jdkhome '"$jdkhome"' \ > -J--add-opens=java.base/java.net=ALL-UNNAMED \ > -J--add-opens=java.base/java.security=ALL-UNNAMED \ > -J--add-opens=java.base/java.lang=ALL-UNNAMED \ > -J--add-opens=java.desktop/sun.awt=ALL-UNNAMED \ > -J--add-opens=java.desktop/javax.swing.plaf.synth=ALL-UNNAMED \ > -J--add-opens=java.desktop/javax.swing=ALL-UNNAMED \ > -J--add-exports=java.desktop/com.sun.java.swing.plaf.gtk=ALL-UNNAMED \ > --clusters '"$clusters"' \ > > > Networking between the test and the utility worked fine with the backport applied. This pull request has now been integrated. Changeset: 4071b8c9 Author: Thomas Fitzsimmons Committer: Andrew John Hughes URL: https://git.openjdk.org/jdk17u-dev/commit/4071b8c9be8e763d48bab1a5b8d57729a4f1307b Stats: 39 lines in 5 files changed: 13 ins; 16 del; 10 mod 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls Reviewed-by: andrew Backport-of: d7298245d6759f62e253b5cf0df975db17fdbf82 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2487 From duke at openjdk.org Thu May 23 22:17:05 2024 From: duke at openjdk.org (fitzsim) Date: Thu, 23 May 2024 22:17:05 GMT Subject: [jdk17u-dev] RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls In-Reply-To: References: Message-ID: On Wed, 22 May 2024 23:21:21 GMT, Andrew John Hughes wrote: >> I propose backporting the fix for `8286781` to `jdk17u`. >> >> I tested the changes on `jdk17u-dev` `master`, on `Fedora 38` `x86-64`, `slowdebug` and `fastdebug` configurations. The test was to run `IdealGraphVisualizer`, per `jdk17u-dev/src/utils/IdealGraphVisualizer/README.md`, then run, e.g.: >> >> >> ./build/linux-x86_64-server-fastdebug/jdk/bin/java -XX:+PrintIdealGraph -XX:PrintIdealGraphLevel=1 -classpath ~/source/hello-java Hello >> >> >> I needed extra JVM arguments in `jdk17u-dev/src/utils/IdealGraphVisualizer/application/target/idealgraphvisualizer/bin/idealgraphvisualizer` to make the visualizer utility work on 17: >> >> >> --jdkhome '"$jdkhome"' \ >> -J--add-opens=java.base/java.net=ALL-UNNAMED \ >> -J--add-opens=java.base/java.security=ALL-UNNAMED \ >> -J--add-opens=java.base/java.lang=ALL-UNNAMED \ >> -J--add-opens=java.desktop/sun.awt=ALL-UNNAMED \ >> -J--add-opens=java.desktop/javax.swing.plaf.synth=ALL-UNNAMED \ >> -J--add-opens=java.desktop/javax.swing=ALL-UNNAMED \ >> -J--add-exports=java.desktop/com.sun.java.swing.plaf.gtk=ALL-UNNAMED \ >> --clusters '"$clusters"' \ >> >> >> Networking between the test and the utility worked fine with the backport applied. > > I don't think it's reasonable to expect every patch submission to be tested on every possible platform. Those who want to produce builds on that platform and have the resources to do so should be regularly testing and maintaining it. Full testing this patch on every platform would also mean running the visualiser on AIX and Solaris, which aren't even tested by GHA. Where those platforms have been broken by changes in the past, those who build on them have submitted patches to fix them. > > I see it as a bigger issue that the visualiser doesn't even work out of the box on 17 at present and no-one has moved to fix this so far. Thank you, @gnu-andrew. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2487#issuecomment-2128118585 From duke at openjdk.org Thu May 23 23:19:19 2024 From: duke at openjdk.org (Elif Aslan) Date: Thu, 23 May 2024 23:19:19 GMT Subject: [jdk11u-dev] RFR: 8273153: Consolidate file_exists into os:file_exists Message-ID: This is not a clean backport. There was a merge conflict on os.cpp due to diverged os::split_path method for this reason os::file_exists method was manually added. This backport is required to address a crash observed in Amazon production. tier2 tests were run in addition to GHA ------------- Commit messages: - Backport of 9732fbe428c3b6a5422cc94e7295ba5482d1a7a9 Changes: https://git.openjdk.org/jdk11u-dev/pull/2721/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2721&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273153 Stats: 26 lines in 4 files changed: 9 ins; 13 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2721.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2721/head:pull/2721 PR: https://git.openjdk.org/jdk11u-dev/pull/2721 From syan at openjdk.org Fri May 24 01:05:19 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 24 May 2024 01:05:19 GMT Subject: [jdk22u] RFR: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes Message-ID: <_UgzXWq-gEb6q3QawmMraBp_G7CLmrCrWBYAUkZQC8M=.39ac8b28-37d7-49ed-bb95-40e882832a81@github.com> Hi all, This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk. ------------- Commit messages: - Backport 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb Changes: https://git.openjdk.org/jdk22u/pull/221/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=221&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316328 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/221.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/221/head:pull/221 PR: https://git.openjdk.org/jdk22u/pull/221 From syan at openjdk.org Fri May 24 01:06:27 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 24 May 2024 01:06:27 GMT Subject: [jdk17u-dev] RFR: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes Message-ID: Hi all, This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk. ------------- Commit messages: - Backport 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb Changes: https://git.openjdk.org/jdk17u-dev/pull/2491/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2491&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316328 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2491.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2491/head:pull/2491 PR: https://git.openjdk.org/jdk17u-dev/pull/2491 From syan at openjdk.org Fri May 24 01:06:31 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 24 May 2024 01:06:31 GMT Subject: [jdk11u-dev] RFR: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes Message-ID: Hi all, This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk. ------------- Commit messages: - Backport 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb Changes: https://git.openjdk.org/jdk11u-dev/pull/2722/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2722&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316328 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2722.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2722/head:pull/2722 PR: https://git.openjdk.org/jdk11u-dev/pull/2722 From syan at openjdk.org Fri May 24 01:07:24 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 24 May 2024 01:07:24 GMT Subject: [jdk21u-dev] RFR: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes Message-ID: Hi all, This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk. ------------- Commit messages: - Backport 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb Changes: https://git.openjdk.org/jdk21u-dev/pull/599/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=599&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316328 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/599.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/599/head:pull/599 PR: https://git.openjdk.org/jdk21u-dev/pull/599 From syan at openjdk.org Fri May 24 02:15:01 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 24 May 2024 02:15:01 GMT Subject: [jdk21u-dev] RFR: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes In-Reply-To: References: Message-ID: On Fri, 24 May 2024 01:01:19 GMT, SendaoYan wrote: > Hi all, > This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk. Duplicated. Sorry for that. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/599#issuecomment-2128360172 From syan at openjdk.org Fri May 24 02:15:02 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 24 May 2024 02:15:02 GMT Subject: [jdk21u-dev] Withdrawn: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes In-Reply-To: References: Message-ID: On Fri, 24 May 2024 01:01:19 GMT, SendaoYan wrote: > Hi all, > This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/599 From syan at openjdk.org Fri May 24 02:16:05 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 24 May 2024 02:16:05 GMT Subject: [jdk22u] RFR: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes In-Reply-To: <_UgzXWq-gEb6q3QawmMraBp_G7CLmrCrWBYAUkZQC8M=.39ac8b28-37d7-49ed-bb95-40e882832a81@github.com> References: <_UgzXWq-gEb6q3QawmMraBp_G7CLmrCrWBYAUkZQC8M=.39ac8b28-37d7-49ed-bb95-40e882832a81@github.com> Message-ID: On Fri, 24 May 2024 01:00:42 GMT, SendaoYan wrote: > Hi all, > This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk. Duplicated. Sorry for that. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/221#issuecomment-2128360803 From syan at openjdk.org Fri May 24 02:16:11 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 24 May 2024 02:16:11 GMT Subject: [jdk11u-dev] RFR: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes In-Reply-To: References: Message-ID: On Fri, 24 May 2024 01:01:13 GMT, SendaoYan wrote: > Hi all, > This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk. Duplicated. Sorry for that. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2722#issuecomment-2128360724 From syan at openjdk.org Fri May 24 02:16:05 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 24 May 2024 02:16:05 GMT Subject: [jdk22u] Withdrawn: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes In-Reply-To: <_UgzXWq-gEb6q3QawmMraBp_G7CLmrCrWBYAUkZQC8M=.39ac8b28-37d7-49ed-bb95-40e882832a81@github.com> References: <_UgzXWq-gEb6q3QawmMraBp_G7CLmrCrWBYAUkZQC8M=.39ac8b28-37d7-49ed-bb95-40e882832a81@github.com> Message-ID: On Fri, 24 May 2024 01:00:42 GMT, SendaoYan wrote: > Hi all, > This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk22u/pull/221 From syan at openjdk.org Fri May 24 02:16:12 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 24 May 2024 02:16:12 GMT Subject: [jdk17u-dev] RFR: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes In-Reply-To: References: Message-ID: On Fri, 24 May 2024 01:01:16 GMT, SendaoYan wrote: > Hi all, > This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk. Duplicated. Sorry for that. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2491#issuecomment-2128360619 From syan at openjdk.org Fri May 24 02:16:11 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 24 May 2024 02:16:11 GMT Subject: [jdk11u-dev] Withdrawn: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes In-Reply-To: References: Message-ID: <9TML35yh497q2CcJ68sFumiwB0TNiCKCUhCw6IE8vnw=.3ab7d6d2-04cb-478e-847a-389c2cc4c594@github.com> On Fri, 24 May 2024 01:01:13 GMT, SendaoYan wrote: > Hi all, > This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2722 From syan at openjdk.org Fri May 24 02:16:12 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 24 May 2024 02:16:12 GMT Subject: [jdk17u-dev] Withdrawn: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes In-Reply-To: References: Message-ID: On Fri, 24 May 2024 01:01:16 GMT, SendaoYan wrote: > Hi all, > This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2491 From andrewlu at openjdk.org Fri May 24 02:37:28 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 24 May 2024 02:37:28 GMT Subject: [jdk21u-dev] RFR: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 21.0.3-oracle. > This PR contains a backport of > https://github.com/openjdk/jdk/commit/5045839cb2095105a5c6c9eebc633a78b1e3213e > Patch is not clean, this file test/hotspot/jtreg/gc/g1/TestHumongousAllocConcurrentStart.java has changed by the commit > https://github.com/openjdk/jdk/commit/1d1cd32bc355a33448d8f15555e142570bb49c21 > , I ignored this commits and only change code for this issue. Andrew Lu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge branch 'master' into backport_8323635 - Backport 5045839cb2095105a5c6c9eebc633a78b1e3213e - Backport 5045839cb2095105a5c6c9eebc633a78b1e3213e ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/589/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=589&range=01 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/589.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/589/head:pull/589 PR: https://git.openjdk.org/jdk21u-dev/pull/589 From serb at openjdk.org Fri May 24 04:31:11 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 24 May 2024 04:31:11 GMT Subject: [jdk22u] RFR: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes Message-ID: Hi all, This pull request contains a backport of commit [9b1d6d66](https://github.com/openjdk/jdk/commit/9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 23 May 2024 and was reviewed by Paul Hohensee, Aleksey Shipilev and Erik Gahlin. Thanks! ------------- Commit messages: - Backport 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb Changes: https://git.openjdk.org/jdk22u/pull/222/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=222&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316328 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/222.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/222/head:pull/222 PR: https://git.openjdk.org/jdk22u/pull/222 From serb at openjdk.org Fri May 24 04:31:30 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 24 May 2024 04:31:30 GMT Subject: [jdk21u-dev] RFR: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes Message-ID: Hi all, This pull request contains a backport of commit [9b1d6d66](https://github.com/openjdk/jdk/commit/9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 23 May 2024 and was reviewed by Paul Hohensee, Aleksey Shipilev and Erik Gahlin. Thanks! ------------- Commit messages: - Backport 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb Changes: https://git.openjdk.org/jdk21u-dev/pull/600/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=600&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316328 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/600.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/600/head:pull/600 PR: https://git.openjdk.org/jdk21u-dev/pull/600 From serb at openjdk.org Fri May 24 04:32:19 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 24 May 2024 04:32:19 GMT Subject: [jdk11u-dev] RFR: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes Message-ID: Hi all, This pull request contains a backport of commit [9b1d6d66](https://github.com/openjdk/jdk/commit/9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 23 May 2024 and was reviewed by Paul Hohensee, Aleksey Shipilev and Erik Gahlin. Thanks! ------------- Commit messages: - Backport 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb Changes: https://git.openjdk.org/jdk11u-dev/pull/2723/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2723&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316328 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2723.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2723/head:pull/2723 PR: https://git.openjdk.org/jdk11u-dev/pull/2723 From serb at openjdk.org Fri May 24 04:32:30 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 24 May 2024 04:32:30 GMT Subject: [jdk17u-dev] RFR: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes Message-ID: Hi all, This pull request contains a backport of commit [9b1d6d66](https://github.com/openjdk/jdk/commit/9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 23 May 2024 and was reviewed by Paul Hohensee, Aleksey Shipilev and Erik Gahlin. Thanks! ------------- Commit messages: - Backport 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb Changes: https://git.openjdk.org/jdk17u-dev/pull/2492/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2492&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316328 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2492.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2492/head:pull/2492 PR: https://git.openjdk.org/jdk17u-dev/pull/2492 From andrewlu at openjdk.org Fri May 24 07:01:13 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 24 May 2024 07:01:13 GMT Subject: [jdk17u-dev] RFR: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport 0d354503620eb7f6da7b1b8aa6143ba18ced8f12 Changes: https://git.openjdk.org/jdk17u-dev/pull/2493/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2493&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327040 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2493.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2493/head:pull/2493 PR: https://git.openjdk.org/jdk17u-dev/pull/2493 From andrewlu at openjdk.org Fri May 24 07:01:29 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 24 May 2024 07:01:29 GMT Subject: [jdk21u-dev] RFR: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 0d354503620eb7f6da7b1b8aa6143ba18ced8f12 Changes: https://git.openjdk.org/jdk21u-dev/pull/602/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=602&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327040 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/602.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/602/head:pull/602 PR: https://git.openjdk.org/jdk21u-dev/pull/602 From andrewlu at openjdk.org Fri May 24 07:02:16 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 24 May 2024 07:02:16 GMT Subject: [jdk11u-dev] RFR: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 Message-ID: <5drBSrGP68EhpFc9NC7BCEKVmezJxJhz_6wLEyH57zA=.cebfdc9a-a3d8-493f-9a3e-9472f1c01a50@github.com> I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 0d354503620eb7f6da7b1b8aa6143ba18ced8f12 Changes: https://git.openjdk.org/jdk11u-dev/pull/2724/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2724&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327040 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2724.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2724/head:pull/2724 PR: https://git.openjdk.org/jdk11u-dev/pull/2724 From duke at openjdk.org Sat May 25 05:28:12 2024 From: duke at openjdk.org (duke) Date: Sat, 25 May 2024 05:28:12 GMT Subject: [jdk11u-dev] Withdrawn: 8287596: Reorg jdk.test.lib.util.ForceGC In-Reply-To: References: Message-ID: On Fri, 29 Mar 2024 21:17:08 GMT, Alexey Bakhtin wrote: > Hello > I'd like to backport this enhancement to fix regression in java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java caused by JDK-8300727. The backport of JDK-8300727 requires JDK-8287596 to be applied first. > > The main differences from the JDK17 patch are the following: > - Reference::refersTo() is introduced in JDK16. Reference::get is used instead > - test/jdk/java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java in JDK11 does not use ForceGC. Skipped > - no test/jdk/java/lang/invoke/defineHiddenClass/UnloadingTest.java in JDK11 > - This patch also includes JDK-8261851 changes as part of the test/jdk/java/lang/reflect/callerCache/ReflectionCallerCacheTest.java patch > > All related jtreg tests passed. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2640 From rob.mckenna at oracle.com Sat May 25 19:01:03 2024 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Sat, 25 May 2024 19:01:03 +0000 Subject: [22u Communication] 22.0.2 will be closed for fixes on the 2nd of June Message-ID: Please try to have your fixes pushed by the end of June 1st. Thanks, -Rob From vpetko at openjdk.org Sun May 26 22:10:20 2024 From: vpetko at openjdk.org (Vladimir Petko) Date: Sun, 26 May 2024 22:10:20 GMT Subject: [jdk21u-dev] RFR: 8295111: dpkg appears to have problems resolving symbolically linked native libraries Message-ID: Hi all, This pull request contains a backport of commit [32946e18](https://github.com/openjdk/jdk/commit/32946e1882e9b22c983cbba3c6bda3cc7295946a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alexey Semenyuk on 18 Apr 2024 and was reviewed by Alexander Matveev. This change fixes an issue caused by usrmerge on Debian-based systems - dpkg -S does not return a package containing a symlinked shared library in /lib, e.g. dpkg -S /lib/x86_64-linux-gnu/libmd.so.0 # dpkg-query: no path found matching pattern /lib/x86_64-linux-gnu/libmd.so.0 The fix calls toRealPath() to resolve an actual path to the file before dpkg call and falls back to the old behaviour if the dpkg call fails. The change is tested by jpackage set of jtreg tests and should be low risk. jpackage tests pass: ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/tools/jpackage 61 61 0 0 ============================== TEST SUCCESS Thanks !!! ------------- Commit messages: - Backport 32946e1882e9b22c983cbba3c6bda3cc7295946a Changes: https://git.openjdk.org/jdk21u-dev/pull/601/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=601&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295111 Stats: 44 lines in 1 file changed: 19 ins; 3 del; 22 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/601.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/601/head:pull/601 PR: https://git.openjdk.org/jdk21u-dev/pull/601 From lyang at openjdk.org Mon May 27 02:37:08 2024 From: lyang at openjdk.org (Long Yang) Date: Mon, 27 May 2024 02:37:08 GMT Subject: [jdk22u] Integrated: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate In-Reply-To: References: Message-ID: <1yYv46OUPEtlvsM_rHCJaH1hJoJFBJvQYYEVP85JNKo=.05df5662-4d33-4e37-9fda-9d6890e71a18@github.com> On Tue, 23 Apr 2024 08:06:03 GMT, Long Yang wrote: > Hi all > > Could I have a review of this backport. > > This pull request contains a backport of commit [8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb](https://github.com/openjdk/jdk/commit/8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > This backport is clean. > > Testing: I ran test/jdk/jdk/jfr/event/os/TestCPULoad.java and passed. This pull request has now been integrated. Changeset: 5a659b7d Author: Long Yang Committer: Jie Fu URL: https://git.openjdk.org/jdk22u/commit/5a659b7d28205f3ed2d7dfebdf970d0f9e1b4123 Stats: 30 lines in 1 file changed: 1 ins; 7 del; 22 mod 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate Backport-of: 8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb ------------- PR: https://git.openjdk.org/jdk22u/pull/161 From lyang at openjdk.org Mon May 27 02:40:02 2024 From: lyang at openjdk.org (Long Yang) Date: Mon, 27 May 2024 02:40:02 GMT Subject: [jdk22u] RFR: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate [v3] In-Reply-To: References: Message-ID: On Sun, 28 Apr 2024 03:19:41 GMT, Long Yang wrote: >> Hi all >> >> Could I have a review of this backport. >> >> This pull request contains a backport of commit [8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb](https://github.com/openjdk/jdk/commit/8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. >> >> This backport is clean. >> >> Testing: I ran test/jdk/jdk/jfr/event/os/TestCPULoad.java and passed. > > Long Yang has updated the pull request incrementally with two additional commits since the last revision: > > - trigger GHA > - trigger GHA Thank you all ~ ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/161#issuecomment-2132540751 From lyang at openjdk.org Mon May 27 03:06:12 2024 From: lyang at openjdk.org (Long Yang) Date: Mon, 27 May 2024 03:06:12 GMT Subject: [jdk17u-dev] RFR: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate In-Reply-To: References: <8yDsUnG0HQVsCakGSjitm-ErWQvnkmKQqaF_cPGilEY=.20cc85c6-7e45-4256-b995-32034141df9c@github.com> Message-ID: On Fri, 19 Apr 2024 08:03:43 GMT, Goetz Lindenmaier wrote: >> Gentle ping. I would be very grateful if anyone could help with the review. > > @yanglong1010, could you please first do the 22u backport? Thanks. @GoeLin The 22u backport has been done. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2277#issuecomment-2132559523 From andrewlu at openjdk.org Mon May 27 08:03:30 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 08:03:30 GMT Subject: [jdk17u-dev] RFR: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out Message-ID: I backport this for parity with 17.0.12-oracle. ------------- Commit messages: - Backport 929af9ed037bcc098043d7b7b8d303744a6d4360 Changes: https://git.openjdk.org/jdk17u-dev/pull/2495/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2495&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307788 Stats: 10 lines in 5 files changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2495.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2495/head:pull/2495 PR: https://git.openjdk.org/jdk17u-dev/pull/2495 From andrewlu at openjdk.org Mon May 27 08:04:22 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 08:04:22 GMT Subject: [jdk11u-dev] RFR: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out Message-ID: I backport this for parity with 11.0.24-oracle. ------------- Commit messages: - Backport 929af9ed037bcc098043d7b7b8d303744a6d4360 Changes: https://git.openjdk.org/jdk11u-dev/pull/2726/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2726&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307788 Stats: 10 lines in 5 files changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2726.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2726/head:pull/2726 PR: https://git.openjdk.org/jdk11u-dev/pull/2726 From andrewlu at openjdk.org Mon May 27 08:04:33 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 08:04:33 GMT Subject: [jdk21u-dev] RFR: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out Message-ID: I backport this for parity with 21.0.3-oracle. ------------- Commit messages: - Backport 929af9ed037bcc098043d7b7b8d303744a6d4360 Changes: https://git.openjdk.org/jdk21u-dev/pull/604/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=604&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307788 Stats: 10 lines in 5 files changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/604.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/604/head:pull/604 PR: https://git.openjdk.org/jdk21u-dev/pull/604 From shade at openjdk.org Mon May 27 08:30:09 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 27 May 2024 08:30:09 GMT Subject: [jdk17u-dev] RFR: 8303942: os::write should write completely In-Reply-To: References: Message-ID: <7lzTqp2NTU1afqR5JVX5H1kiBv6pntU4X9q4FG18Zes=.b871857b-e2c5-4c88-93b1-c0eea87f44c3@github.com> On Thu, 23 May 2024 19:33:35 GMT, Elif Aslan wrote: > This is not a clean backport. There were multiple merge conflicts related to undefined parameters and existing methods. This backport is required to address a crash observed in Amazon production. Please refer to the related [PR](https://github.com/openjdk/jdk17u-dev/pull/2281), which has already been merged. > > > In addition to GHA Tier 1, runtime hotspot, JFR, and hotspot GC tests have been run on macOS. > > > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:hotspot_runtime 880 880 0 0 > ============================== > TEST SUCCESS > > Finished building target 'test' in configuration 'macosx-x86_64-server-release' There is a P2 regression from this fix: [JDK-8316468](https://bugs.openjdk.org/browse/JDK-8316468). It needs to go in this PR as well to avoid non-atomic breakage of 17u-dev. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2490#issuecomment-2132935645 From shade at openjdk.org Mon May 27 08:33:03 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 27 May 2024 08:33:03 GMT Subject: [jdk17u-dev] Integrated: 8177107: Reduce memory footprint of java.lang.reflect.Constructor/Method In-Reply-To: References: Message-ID: On Tue, 21 May 2024 08:25:25 GMT, Aleksey Shipilev wrote: > Clean backport to improve memory footprint in reflection-heavy applications. > > Additional testing: > - [x] Linux AArch64 server fastdebug, `java/lang/reflect` > - [x] Linux x86_64 server fastdebug, `all` This pull request has now been integrated. Changeset: 060c2504 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/060c2504c90318cdc3582204fd88a664c58dd9fd Stats: 22 lines in 4 files changed: 14 ins; 0 del; 8 mod 8177107: Reduce memory footprint of java.lang.reflect.Constructor/Method Backport-of: a385142398eee102ff1a53d848230dc95c4ebd37 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2486 From andrewlu at openjdk.org Mon May 27 08:42:11 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 08:42:11 GMT Subject: [jdk17u-dev] RFR: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 In-Reply-To: References: Message-ID: On Mon, 20 May 2024 08:09:16 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. > This PR contains a backport of > https://github.com/openjdk/jdk/commit/5045839cb2095105a5c6c9eebc633a78b1e3213e > Patch is not clean, this file test/hotspot/jtreg/gc/g1/TestHumongousAllocConcurrentStart.java has changed by the commit > https://github.com/openjdk/jdk/commit/d52a995f35de26c2cc4074297a75141e4a363e1b > , I ignored this commits and only change code for this issue. Not reproduced in 17. We can reopen it if needed. Not reproduced in 17. We can reopen it if needed. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2482#issuecomment-2132963159 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2482#issuecomment-2132963529 From andrewlu at openjdk.org Mon May 27 08:42:13 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 08:42:13 GMT Subject: [jdk11u-dev] RFR: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 In-Reply-To: References: Message-ID: On Mon, 20 May 2024 08:30:26 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. > This PR contains a backport of > https://github.com/openjdk/jdk/commit/5045839cb2095105a5c6c9eebc633a78b1e3213e > Patch is not clean, this file test/hotspot/jtreg/gc/g1/TestHumongousAllocInitialMark.java has changed by the commit > https://github.com/openjdk/jdk/commit/d52a995f35de26c2cc4074297a75141e4a363e1b > , I ignored this commits and only change code for this issue. Not reproduced in 11. We can reopen it if needed. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2717#issuecomment-2132963999 From andrewlu at openjdk.org Mon May 27 08:42:14 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 08:42:14 GMT Subject: [jdk11u-dev] Withdrawn: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 In-Reply-To: References: Message-ID: <6dOTtxveGNzKKxlJW10q8nVvt7EJ_M4lbugugvB6kfI=.b983636b-c3b1-4eaa-b2c7-847301d9ce71@github.com> On Mon, 20 May 2024 08:30:26 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. > This PR contains a backport of > https://github.com/openjdk/jdk/commit/5045839cb2095105a5c6c9eebc633a78b1e3213e > Patch is not clean, this file test/hotspot/jtreg/gc/g1/TestHumongousAllocInitialMark.java has changed by the commit > https://github.com/openjdk/jdk/commit/d52a995f35de26c2cc4074297a75141e4a363e1b > , I ignored this commits and only change code for this issue. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2717 From andrewlu at openjdk.org Mon May 27 08:42:12 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 08:42:12 GMT Subject: [jdk17u-dev] Withdrawn: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 In-Reply-To: References: Message-ID: On Mon, 20 May 2024 08:09:16 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. > This PR contains a backport of > https://github.com/openjdk/jdk/commit/5045839cb2095105a5c6c9eebc633a78b1e3213e > Patch is not clean, this file test/hotspot/jtreg/gc/g1/TestHumongousAllocConcurrentStart.java has changed by the commit > https://github.com/openjdk/jdk/commit/d52a995f35de26c2cc4074297a75141e4a363e1b > , I ignored this commits and only change code for this issue. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2482 From andrewlu at openjdk.org Mon May 27 08:47:07 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 08:47:07 GMT Subject: [jdk11u-dev] Withdrawn: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 In-Reply-To: <5drBSrGP68EhpFc9NC7BCEKVmezJxJhz_6wLEyH57zA=.cebfdc9a-a3d8-493f-9a3e-9472f1c01a50@github.com> References: <5drBSrGP68EhpFc9NC7BCEKVmezJxJhz_6wLEyH57zA=.cebfdc9a-a3d8-493f-9a3e-9472f1c01a50@github.com> Message-ID: On Fri, 24 May 2024 06:57:05 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2724 From andrewlu at openjdk.org Mon May 27 08:47:09 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 08:47:09 GMT Subject: [jdk17u-dev] Withdrawn: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 In-Reply-To: References: Message-ID: On Fri, 24 May 2024 06:56:56 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2493 From andrewlu at openjdk.org Mon May 27 08:48:02 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 08:48:02 GMT Subject: [jdk17u-dev] Withdrawn: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out In-Reply-To: References: Message-ID: On Mon, 27 May 2024 07:58:22 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2495 From andrewlu at openjdk.org Mon May 27 08:48:08 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 08:48:08 GMT Subject: [jdk11u-dev] Withdrawn: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out In-Reply-To: References: Message-ID: <5t9UoV-vQxtCfhcMk28SyHuv7qqztJUZRH02A8N7T8s=.0ed78d40-0813-408b-91a1-cc0e9d26bcee@github.com> On Mon, 27 May 2024 07:58:42 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2726 From clanger at openjdk.org Mon May 27 09:15:02 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 27 May 2024 09:15:02 GMT Subject: [jdk17u-dev] RFR: 8303942: os::write should write completely In-Reply-To: <7lzTqp2NTU1afqR5JVX5H1kiBv6pntU4X9q4FG18Zes=.b871857b-e2c5-4c88-93b1-c0eea87f44c3@github.com> References: <7lzTqp2NTU1afqR5JVX5H1kiBv6pntU4X9q4FG18Zes=.b871857b-e2c5-4c88-93b1-c0eea87f44c3@github.com> Message-ID: On Mon, 27 May 2024 08:27:39 GMT, Aleksey Shipilev wrote: > There is a P2 regression from this fix: [JDK-8316468](https://bugs.openjdk.org/browse/JDK-8316468). It needs to go in this PR as well to avoid non-atomic breakage of 17u-dev. Yes, please add this fix in here and request approval. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2490#issuecomment-2133029642 From andrewlu at openjdk.org Mon May 27 09:35:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 09:35:06 GMT Subject: [jdk17u-dev] Integrated: 8320681: [macos] Test tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java timed out on macOS In-Reply-To: References: Message-ID: On Tue, 21 May 2024 07:57:09 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: 6c3a188d Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/6c3a188d47aa738bf8faaabb10fb56b4989fc1cb Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8320681: [macos] Test tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java timed out on macOS Backport-of: a657aa38a56056211a9d2773b30e8fe1a89c128e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2485 From andrewlu at openjdk.org Mon May 27 09:37:07 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 09:37:07 GMT Subject: [jdk11u-dev] Withdrawn: 8307091: A few client tests intermittently throw ConcurrentModificationException In-Reply-To: References: Message-ID: On Thu, 23 May 2024 06:13:56 GMT, Andrew Lu wrote: > Due to JDK-8327137 and JDK-8323670 depends on this, so i will backport this first, and then backport the others. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2720 From andrewlu at openjdk.org Mon May 27 09:37:08 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 09:37:08 GMT Subject: [jdk17u-dev] Withdrawn: 8307091: A few client tests intermittently throw ConcurrentModificationException In-Reply-To: References: Message-ID: On Thu, 23 May 2024 06:13:27 GMT, Andrew Lu wrote: > Due to JDK-8327137 and JDK-8323670 depends on this, so i will backport this first, and then backport the others. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2489 From andrewlu at openjdk.org Mon May 27 09:39:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 09:39:06 GMT Subject: [jdk17u-dev] RFR: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel In-Reply-To: References: Message-ID: On Fri, 17 May 2024 08:51:22 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. postpone this one due to some related issues. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2477#issuecomment-2133076604 From andrewlu at openjdk.org Mon May 27 09:39:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 09:39:06 GMT Subject: [jdk21u-dev] RFR: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel In-Reply-To: References: Message-ID: <3hIKZGyRQ-CYG2NgZO_phy0Qm2nciVZs66X27KQMvw4=.d930b8f1-0734-4530-883d-bb9fff40bcf2@github.com> On Fri, 17 May 2024 08:47:12 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. postpone this one due to some related issues. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/584#issuecomment-2133076827 From andrewlu at openjdk.org Mon May 27 09:39:07 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 09:39:07 GMT Subject: [jdk11u-dev] RFR: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel In-Reply-To: References: Message-ID: On Fri, 17 May 2024 08:54:16 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. postpone this one due to some related issues. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2713#issuecomment-2133076307 From andrewlu at openjdk.org Mon May 27 09:39:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 09:39:06 GMT Subject: [jdk21u-dev] Withdrawn: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel In-Reply-To: References: Message-ID: On Fri, 17 May 2024 08:47:12 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.3-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/584 From andrewlu at openjdk.org Mon May 27 09:39:07 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 09:39:07 GMT Subject: [jdk17u-dev] Withdrawn: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel In-Reply-To: References: Message-ID: <9u4RrvX8kasbJnkGidR_iVHwZOAnoyLqzK8_ta2Aag4=.68fdaba9-f95f-48a9-a495-e971ac2ffd49@github.com> On Fri, 17 May 2024 08:51:22 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.12-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2477 From andrewlu at openjdk.org Mon May 27 09:39:07 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Mon, 27 May 2024 09:39:07 GMT Subject: [jdk11u-dev] Withdrawn: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel In-Reply-To: References: Message-ID: On Fri, 17 May 2024 08:54:16 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.24-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2713 From mbaesken at openjdk.org Mon May 27 10:20:08 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 27 May 2024 10:20:08 GMT Subject: [jdk21u-dev] Integrated: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms In-Reply-To: <4E2JpbICmqgvcOyQ0_zA5YjLA6iDw2kLLjS4i6NSZes=.5079f142-002e-46e3-8ce6-1f5b77c228d6@github.com> References: <4E2JpbICmqgvcOyQ0_zA5YjLA6iDw2kLLjS4i6NSZes=.5079f142-002e-46e3-8ce6-1f5b77c228d6@github.com> Message-ID: On Thu, 23 May 2024 13:08:46 GMT, Matthias Baesken wrote: > Backport 8331031 This pull request has now been integrated. Changeset: 00d3ca21 Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/00d3ca21cc5d5b9c4a3a17cab8f0b44e08b46c9f Stats: 45 lines in 4 files changed: 8 ins; 37 del; 0 mod 8331031: unify os::dont_yield and os::naked_yield across Posix platforms Backport-of: c9442014e561f8e1cb43a0e9f18a9a5ae2a7a2da ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/598 From mdoerr at openjdk.org Mon May 27 12:55:07 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 27 May 2024 12:55:07 GMT Subject: [jdk21u-dev] RFR: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment In-Reply-To: <8A1BNN5ZXTXFpI4cZh-25KKo_rEx7FJLl34OUQS7HTk=.938f856d-3520-4761-8491-76eb9e7f2025@github.com> References: <8A1BNN5ZXTXFpI4cZh-25KKo_rEx7FJLl34OUQS7HTk=.938f856d-3520-4761-8491-76eb9e7f2025@github.com> Message-ID: On Mon, 25 Mar 2024 11:54:39 GMT, Per Minborg wrote: > Hi all, > > This pull request contains a backport of commit [93579c29](https://github.com/openjdk/jdk/commit/93579c29e3ba60a8bc16d712e7ffc733f324a223) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Per Minborg on 25 Mar 2024 and was reviewed by Maurizio Cimadamore. > > Thanks! This one is ready for integration. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/404#issuecomment-2133422156 From mdoerr at openjdk.org Mon May 27 12:55:12 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 27 May 2024 12:55:12 GMT Subject: [jdk21u-dev] RFR: 8330027: Identity hashes of archived objects must be based on a reproducible random seed [v2] In-Reply-To: References: Message-ID: <0AARfJfwWs_vtbNL8RoQKvZdIn5KDFrU6qpFgQ5hmvM=.642d1d41-0d16-4b53-b8f3-ce3c70266c01@github.com> On Tue, 14 May 2024 07:23:30 GMT, Thomas Stuefe wrote: >> This fixes an issue with CDS archive reproducibility that can happen under rare circumstances. See original JBS issue for details. >> >> I had to manually resolve the hunk in src/hotspot/share/cds/heapShared.cpp because both >> >> 8251330: Reorder CDS archived heap to speed up relocation >> 8329431: Improve speed of writing CDS heap objects >> were missing. >> >> I also had to change `CDSConfig::is_dumping_static_archive()` - which only exists in JDK 22 and later - to the technically equal `DumpSharedSpaces`. > > Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision: > > Update heapShared.cpp Marked as reviewed by mdoerr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/562#pullrequestreview-2080861053 From mdoerr at openjdk.org Mon May 27 13:18:03 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 27 May 2024 13:18:03 GMT Subject: [jdk17u-dev] RFR: 8315362: NMT: summary diff reports threads count incorrectly In-Reply-To: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> References: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> Message-ID: On Wed, 27 Dec 2023 07:31:16 GMT, Evgeny Ignatenko wrote: > 8315362: NMT: summary diff reports threads count incorrectly This PR shouldn't differ from the 21u version: https://github.com/openjdk/jdk21u/commit/31c759dd7ef69449e225c3e656d8f522e1124852 I currently see the following diffs: < + _thread_count ++; --- > + _thread_count++; < + output.shouldContain("Baseline succeeded"); --- > + output.shouldContain("Baseline taken"); ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2084#issuecomment-2133464382 From duke at openjdk.org Mon May 27 13:59:25 2024 From: duke at openjdk.org (Rinku Kumar Maurya) Date: Mon, 27 May 2024 13:59:25 GMT Subject: [jdk17u-dev] RFR: 8289643: File descriptor leak with ProcessBuilder.startPipeline [v2] In-Reply-To: References: Message-ID: <5WY5_82QqBv8dEP8E_ihGdgNNJiHv7San_jkXumUTlA=.505772eb-1beb-4f93-bcff-6043709751b0@github.com> > clean backport to fix file descriptor leak with ProcessBuilder.startPipeline. When using ProcessBuilder.startPipeline the pipes (or pipe if only 2 ProcessBuilder instance used) created are never closed. > > > with changes :- > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java > 1 1 0 0 > ============================== > TEST SUCCESS > > > without changes :- > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java > 1 0 1 0 > ============================== > TEST FAILURE > > with expected output :- > test PipelineLeaksFD.checkForLeaks(java.util.ImmutableCollections$ListN at 44d1a216): failure > java.lang.AssertionError: More or fewer pipes than expected > ... Rinku Kumar Maurya has updated the pull request incrementally with one additional commit since the last revision: Backport 226b8e680a82096b3d268703872d30182c10e326 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2462/files - new: https://git.openjdk.org/jdk17u-dev/pull/2462/files/0603c6ed..3d18ffad Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2462&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2462&range=00-01 Stats: 11 lines in 1 file changed: 7 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2462.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2462/head:pull/2462 PR: https://git.openjdk.org/jdk17u-dev/pull/2462 From duke at openjdk.org Mon May 27 13:59:25 2024 From: duke at openjdk.org (Rinku Kumar Maurya) Date: Mon, 27 May 2024 13:59:25 GMT Subject: [jdk17u-dev] RFR: 8289643: File descriptor leak with ProcessBuilder.startPipeline In-Reply-To: References: Message-ID: <1EqlYM6O--GQdEJsKEXTpzYNe7_h0JypN6VujEhHw28=.72696160-2677-4d9a-8915-8878ea262e51@github.com> On Mon, 13 May 2024 11:40:09 GMT, Rinku Kumar Maurya wrote: > clean backport to fix file descriptor leak with ProcessBuilder.startPipeline. When using ProcessBuilder.startPipeline the pipes (or pipe if only 2 ProcessBuilder instance used) created are never closed. > > > with changes :- > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java > 1 1 0 0 > ============================== > TEST SUCCESS > > > without changes :- > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java > 1 0 1 0 > ============================== > TEST FAILURE > > with expected output :- > test PipelineLeaksFD.checkForLeaks(java.util.ImmutableCollections$ListN at 44d1a216): failure > java.lang.AssertionError: More or fewer pipes than expected > ... unclean backport of commit 226b8e680a82096b3d268703872d30182c10e326 which fixes intermittent failures observed for the newly added test. Changes in `test/jdk/ProblemList-Xcomp.txt` were causing conflicts but they are not needed with this new backport as addition and removal of problem-list entry is a no-op change and file contents remain unchanged. Ran test again : with changes :- ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java 1 1 0 0 ============================== TEST SUCCESS without changes :- ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java 1 0 1 0 ============================== TEST FAILURE with expected output :- test PipelineLeaksFD.checkForLeaks(java.util.ImmutableCollections$ListN at 44d1a216): failure java.lang.AssertionError: More or fewer pipes than expected ... ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2462#issuecomment-2133536103 From shade at openjdk.org Mon May 27 15:13:07 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 27 May 2024 15:13:07 GMT Subject: [jdk17u-dev] RFR: 8289643: File descriptor leak with ProcessBuilder.startPipeline [v2] In-Reply-To: <5WY5_82QqBv8dEP8E_ihGdgNNJiHv7San_jkXumUTlA=.505772eb-1beb-4f93-bcff-6043709751b0@github.com> References: <5WY5_82QqBv8dEP8E_ihGdgNNJiHv7San_jkXumUTlA=.505772eb-1beb-4f93-bcff-6043709751b0@github.com> Message-ID: On Mon, 27 May 2024 13:59:25 GMT, Rinku Kumar Maurya wrote: >> clean backport to fix file descriptor leak with ProcessBuilder.startPipeline. When using ProcessBuilder.startPipeline the pipes (or pipe if only 2 ProcessBuilder instance used) created are never closed. >> >> >> with changes :- >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> >> without changes :- >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java >> 1 0 1 0 >> ============================== >> TEST FAILURE >> >> with expected output :- >> test PipelineLeaksFD.checkForLeaks(java.util.ImmutableCollections$ListN at 44d1a216): failure >> java.lang.AssertionError: More or fewer pipes than expected >> ... > > Rinku Kumar Maurya has updated the pull request incrementally with one additional commit since the last revision: > > Backport 226b8e680a82096b3d268703872d30182c10e326 You also need to say `/issue add JDK-8290885` to record this PR fixes that additional issue as well. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2462#issuecomment-2133671579 From shade at openjdk.org Mon May 27 15:18:05 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 27 May 2024 15:18:05 GMT Subject: [jdk17u-dev] RFR: 8289643: File descriptor leak with ProcessBuilder.startPipeline [v2] In-Reply-To: <5WY5_82QqBv8dEP8E_ihGdgNNJiHv7San_jkXumUTlA=.505772eb-1beb-4f93-bcff-6043709751b0@github.com> References: <5WY5_82QqBv8dEP8E_ihGdgNNJiHv7San_jkXumUTlA=.505772eb-1beb-4f93-bcff-6043709751b0@github.com> Message-ID: On Mon, 27 May 2024 13:59:25 GMT, Rinku Kumar Maurya wrote: >> clean backport to fix file descriptor leak with ProcessBuilder.startPipeline. When using ProcessBuilder.startPipeline the pipes (or pipe if only 2 ProcessBuilder instance used) created are never closed. >> >> >> with changes :- >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> >> without changes :- >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java >> 1 0 1 0 >> ============================== >> TEST FAILURE >> >> with expected output :- >> test PipelineLeaksFD.checkForLeaks(java.util.ImmutableCollections$ListN at 44d1a216): failure >> java.lang.AssertionError: More or fewer pipes than expected >> ... > > Rinku Kumar Maurya has updated the pull request incrementally with one additional commit since the last revision: > > Backport 226b8e680a82096b3d268703872d30182c10e326 ...and now also `/approval 8290885 request ` for approval for that one. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2462#issuecomment-2133679996 From mdoerr at openjdk.org Mon May 27 15:41:23 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 27 May 2024 15:41:23 GMT Subject: [jdk17u-dev] RFR: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation Message-ID: Basically clean backport of [JDK-8313873](https://bugs.openjdk.org/browse/JDK-8313873). ------------- Commit messages: - Backport 486fa08d4b22243443d39efa34c78d7e9eb44775 Changes: https://git.openjdk.org/jdk17u-dev/pull/2496/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2496&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313873 Stats: 36 lines in 2 files changed: 27 ins; 3 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2496.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2496/head:pull/2496 PR: https://git.openjdk.org/jdk17u-dev/pull/2496 From mdoerr at openjdk.org Mon May 27 15:41:23 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 27 May 2024 15:41:23 GMT Subject: [jdk17u-dev] RFR: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation In-Reply-To: References: Message-ID: <61NNI8BZSxwhcO5up3z7vtCdvVBLnlJZ41vcy6BgKHE=.498d3ff9-e934-4e0f-ac8a-75711ccd010a@github.com> On Mon, 27 May 2024 15:36:49 GMT, Martin Doerr wrote: > Basically clean backport of [JDK-8313873](https://bugs.openjdk.org/browse/JDK-8313873). Applies cleanly except Copyright year update. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2496#issuecomment-2133713986 From shade at openjdk.org Mon May 27 15:45:01 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 27 May 2024 15:45:01 GMT Subject: [jdk17u-dev] RFR: 8289643: File descriptor leak with ProcessBuilder.startPipeline [v2] In-Reply-To: <5WY5_82QqBv8dEP8E_ihGdgNNJiHv7San_jkXumUTlA=.505772eb-1beb-4f93-bcff-6043709751b0@github.com> References: <5WY5_82QqBv8dEP8E_ihGdgNNJiHv7San_jkXumUTlA=.505772eb-1beb-4f93-bcff-6043709751b0@github.com> Message-ID: On Mon, 27 May 2024 13:59:25 GMT, Rinku Kumar Maurya wrote: >> clean backport to fix file descriptor leak with ProcessBuilder.startPipeline. When using ProcessBuilder.startPipeline the pipes (or pipe if only 2 ProcessBuilder instance used) created are never closed. >> >> >> with changes :- >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java >> 1 1 0 0 >> ============================== >> TEST SUCCESS >> >> >> without changes :- >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java >> 1 0 1 0 >> ============================== >> TEST FAILURE >> >> with expected output :- >> test PipelineLeaksFD.checkForLeaks(java.util.ImmutableCollections$ListN at 44d1a216): failure >> java.lang.AssertionError: More or fewer pipes than expected >> ... > > Rinku Kumar Maurya has updated the pull request incrementally with one additional commit since the last revision: > > Backport 226b8e680a82096b3d268703872d30182c10e326 Looks fine. Wait for maintainer approval, and then I can sponsor. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2462#pullrequestreview-2081188958 From mdoerr at openjdk.org Mon May 27 16:10:28 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 27 May 2024 16:10:28 GMT Subject: [jdk17u-dev] RFR: 8294699: Launcher causes lingering busy cursor Message-ID: <5ce92hmPjG7i7s2iPb7c7MIDhgDjfjxDjGhpAFnAE10=.211e57d0-235b-41aa-a668-26c07223bbc9@github.com> Clean backport of [JDK-8294699](https://bugs.openjdk.org/browse/JDK-8294699). ------------- Commit messages: - Backport d3df3eb5d7f5537ade917db7a36caba028f94111 Changes: https://git.openjdk.org/jdk17u-dev/pull/2497/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2497&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294699 Stats: 78 lines in 1 file changed: 76 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2497.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2497/head:pull/2497 PR: https://git.openjdk.org/jdk17u-dev/pull/2497 From duke at openjdk.org Mon May 27 16:31:13 2024 From: duke at openjdk.org (fitzsim) Date: Mon, 27 May 2024 16:31:13 GMT Subject: [jdk22u] RFR: 8332174: Remove two unpaired RLO Unicode characters from ff_Adlm.xml Message-ID: I would like to have this patch applied to `jdk22u`, and then backport it to `21`, `17`, `11` and `8`. This will eliminate an issue reported by `rpminspect`. ------------- Commit messages: - 8332174: Remove two unpaired RLO Unicode characters from ff_Adlm.xml Changes: https://git.openjdk.org/jdk22u/pull/223/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=223&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332174 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/223.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/223/head:pull/223 PR: https://git.openjdk.org/jdk22u/pull/223 From dholmes at openjdk.org Mon May 27 22:04:16 2024 From: dholmes at openjdk.org (David Holmes) Date: Mon, 27 May 2024 22:04:16 GMT Subject: [jdk22u] RFR: 8329958: Windows x86 build fails: downcallLinker.cpp(36) redefinition Message-ID: Trivial backport to fix Windows 32-bit build issue. Thanks. ------------- Commit messages: - Backport 86eb5d9f3be30ff9df1318f18ab73c7129c978f6 Changes: https://git.openjdk.org/jdk22u/pull/224/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=224&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329958 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk22u/pull/224.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/224/head:pull/224 PR: https://git.openjdk.org/jdk22u/pull/224 From vpetko at openjdk.org Mon May 27 22:18:02 2024 From: vpetko at openjdk.org (Vladimir Petko) Date: Mon, 27 May 2024 22:18:02 GMT Subject: [jdk21u-dev] Integrated: 8295111: dpkg appears to have problems resolving symbolically linked native libraries In-Reply-To: References: Message-ID: On Fri, 24 May 2024 03:41:09 GMT, Vladimir Petko wrote: > Hi all, > > This pull request contains a backport of commit [32946e18](https://github.com/openjdk/jdk/commit/32946e1882e9b22c983cbba3c6bda3cc7295946a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexey Semenyuk on 18 Apr 2024 and was reviewed by Alexander Matveev. > > This change fixes an issue caused by usrmerge on Debian-based systems - dpkg -S does not return a package containing a symlinked shared library in /lib, e.g. > > dpkg -S /lib/x86_64-linux-gnu/libmd.so.0 > # dpkg-query: no path found matching pattern /lib/x86_64-linux-gnu/libmd.so.0 > > > The fix calls toRealPath() to resolve an actual path to the file before dpkg call and falls back to the old behaviour if the dpkg call fails. > > The change is tested by jpackage set of jtreg tests and should be low risk. > > > jpackage tests pass: > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/tools/jpackage 61 61 0 0 > ============================== > TEST SUCCESS > > > > Thanks !!! This pull request has now been integrated. Changeset: 58c19a60 Author: Vladimir Petko Committer: Christoph Langer URL: https://git.openjdk.org/jdk21u-dev/commit/58c19a60512086a23975a4d7e595905fdbde540a Stats: 44 lines in 1 file changed: 19 ins; 3 del; 22 mod 8295111: dpkg appears to have problems resolving symbolically linked native libraries Backport-of: 32946e1882e9b22c983cbba3c6bda3cc7295946a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/601 From clanger at openjdk.org Mon May 27 22:22:24 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 27 May 2024 22:22:24 GMT Subject: [jdk21u-dev] RFR: 8331266: Bump update version for OpenJDK: jdk-21.0.5 Message-ID: Bump version for 21.0.5 ------------- Commit messages: - Version bump 21.0.5 Changes: https://git.openjdk.org/jdk21u-dev/pull/605/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=605&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331266 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/605.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/605/head:pull/605 PR: https://git.openjdk.org/jdk21u-dev/pull/605 From clanger at openjdk.org Mon May 27 22:26:18 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 27 May 2024 22:26:18 GMT Subject: [jdk17u-dev] RFR: 8331265: Bump update version for OpenJDK: jdk-17.0.13 Message-ID: Version bump 17.0.13 ------------- Commit messages: - Version bump 17.0.13 Changes: https://git.openjdk.org/jdk17u-dev/pull/2498/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2498&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331265 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2498.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2498/head:pull/2498 PR: https://git.openjdk.org/jdk17u-dev/pull/2498 From clanger at openjdk.org Mon May 27 22:34:07 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 27 May 2024 22:34:07 GMT Subject: [jdk17u-dev] RFR: 8314835: gtest wrappers should be marked as flagless In-Reply-To: References: Message-ID: <_q5Nfnyc_ulnUw5RI_IYwpRMw6H8WljbBpclhdP7ROg=.1b3093b6-511e-45dc-b426-3334cc78f551@github.com> On Tue, 14 May 2024 08:12:31 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8314835](https://bugs.openjdk.org/browse/JDK-8314835), to make releated tests as flagless. > The backport is not clean, because the file `test/hotspot/jtreg/gtest/NativeHeapTrimmerGtest.java` has subsequent backport [JDK-8325496](https://bugs.openjdk.org/browse/JDK-8325496) > Only change the testcases, the risk is low. > > Thanks, > -sendao @sendaoYan would you consider to integrate this today to have it in 17.0.12? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2470#issuecomment-2134107923 From clanger at openjdk.org Mon May 27 22:36:11 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 27 May 2024 22:36:11 GMT Subject: [jdk11u-dev] RFR: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c In-Reply-To: <5wd7QLbgs-jjlQy9gqL8xgl9uQDih2gyR_pfeSiuZak=.bc474a6e-a2fb-442e-bb58-0837252759e1@github.com> References: <0eSK5ocjyerxsBrXiW1q3tUKbTwRFoVzB_FdgqUOhM4=.40028621-3da5-49de-bd20-56a256089ee6@github.com> <5wd7QLbgs-jjlQy9gqL8xgl9uQDih2gyR_pfeSiuZak=.bc474a6e-a2fb-442e-bb58-0837252759e1@github.com> Message-ID: On Tue, 14 May 2024 15:34:44 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8293887](https://bugs.openjdk.org/browse/JDK-8293887). It's not clean backport, because the file `make/lib/CoreLibraries.gmk` has been moved to `make/modules/java.base/lib/CoreLibraries.gmk` >> >> Thanks! >> >> >> Make test list: >> >> - [x] linux x64 gcc10 >> - [x] linux x64 gcc13 >> - [x] linux aarch64 gcc10 >> - [x] linux aarch64 gcc13 >> - [x] linux riscv64 gcc13 >> >> >> [make-linux-aarch64-gcc10.log](https://github.com/openjdk/jdk11u-dev/files/15295807/make-linux-aarch64-gcc10.log) >> [make-linux-aarch64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295808/make-linux-aarch64-gcc13.log) >> [make-linux-x64-gcc10.log](https://github.com/openjdk/jdk11u-dev/files/15295809/make-linux-x64-gcc10.log) >> [make-linux-x64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295810/make-linux-x64-gcc13.log) >> [make-linux-riscv64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295880/make-linux-riscv64-gcc13.log) >> >> linux riscv64 gcc13 build jdk11u-dev failure because other reasons, the `k_rem_pio2.c` file not longer compile fail after this PR. > > Thanks all for the review and approved. @sendaoYan would you mind to integrate this today to have it in 11.0.24? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2709#issuecomment-2134108934 From clanger at openjdk.org Mon May 27 22:42:32 2024 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 27 May 2024 22:42:32 GMT Subject: [jdk11u-dev] RFR: 8331263: Bump update version for OpenJDK: jdk-11.0.25 Message-ID: Bump for 11.0.25 ------------- Commit messages: - JDK-8331263 Changes: https://git.openjdk.org/jdk11u-dev/pull/2727/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2727&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331263 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2727.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2727/head:pull/2727 PR: https://git.openjdk.org/jdk11u-dev/pull/2727 From andrewlu at openjdk.org Tue May 28 02:03:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 28 May 2024 02:03:06 GMT Subject: [jdk21u-dev] Integrated: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 In-Reply-To: References: Message-ID: <-lQF3V9HAbq1xi3SKEM0sN3YZeAQxLX1qVXWyLWBpUg=.87a823ba-7026-41c4-bb1b-901cb03e81bb@github.com> On Mon, 20 May 2024 08:08:56 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. > This PR contains a backport of > https://github.com/openjdk/jdk/commit/5045839cb2095105a5c6c9eebc633a78b1e3213e > Patch is not clean, this file test/hotspot/jtreg/gc/g1/TestHumongousAllocConcurrentStart.java has changed by the commit > https://github.com/openjdk/jdk/commit/1d1cd32bc355a33448d8f15555e142570bb49c21 > , I ignored this commits and only change code for this issue. This pull request has now been integrated. Changeset: a0376cd8 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/a0376cd8f86731f7b8aa455eb36a2e4465fe0a6b Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 Backport-of: 5045839cb2095105a5c6c9eebc633a78b1e3213e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/589 From syan at openjdk.org Tue May 28 02:46:07 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 02:46:07 GMT Subject: [jdk17u-dev] RFR: 8314835: gtest wrappers should be marked as flagless In-Reply-To: <_q5Nfnyc_ulnUw5RI_IYwpRMw6H8WljbBpclhdP7ROg=.1b3093b6-511e-45dc-b426-3334cc78f551@github.com> References: <_q5Nfnyc_ulnUw5RI_IYwpRMw6H8WljbBpclhdP7ROg=.1b3093b6-511e-45dc-b426-3334cc78f551@github.com> Message-ID: On Mon, 27 May 2024 22:31:51 GMT, Christoph Langer wrote: > @sendaoYan would you consider to integrate this today to have it in 17.0.12? Sorry, I did not notice that the `jdk17u-fix-yes` label has been added. Integrate right now. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2470#issuecomment-2134257798 From syan at openjdk.org Tue May 28 02:50:05 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 02:50:05 GMT Subject: [jdk11u-dev] RFR: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c In-Reply-To: <5wd7QLbgs-jjlQy9gqL8xgl9uQDih2gyR_pfeSiuZak=.bc474a6e-a2fb-442e-bb58-0837252759e1@github.com> References: <0eSK5ocjyerxsBrXiW1q3tUKbTwRFoVzB_FdgqUOhM4=.40028621-3da5-49de-bd20-56a256089ee6@github.com> <5wd7QLbgs-jjlQy9gqL8xgl9uQDih2gyR_pfeSiuZak=.bc474a6e-a2fb-442e-bb58-0837252759e1@github.com> Message-ID: On Tue, 14 May 2024 15:34:44 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8293887](https://bugs.openjdk.org/browse/JDK-8293887). It's not clean backport, because the file `make/lib/CoreLibraries.gmk` has been moved to `make/modules/java.base/lib/CoreLibraries.gmk` >> >> Thanks! >> >> >> Make test list: >> >> - [x] linux x64 gcc10 >> - [x] linux x64 gcc13 >> - [x] linux aarch64 gcc10 >> - [x] linux aarch64 gcc13 >> - [x] linux riscv64 gcc13 >> >> >> [make-linux-aarch64-gcc10.log](https://github.com/openjdk/jdk11u-dev/files/15295807/make-linux-aarch64-gcc10.log) >> [make-linux-aarch64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295808/make-linux-aarch64-gcc13.log) >> [make-linux-x64-gcc10.log](https://github.com/openjdk/jdk11u-dev/files/15295809/make-linux-x64-gcc10.log) >> [make-linux-x64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295810/make-linux-x64-gcc13.log) >> [make-linux-riscv64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295880/make-linux-riscv64-gcc13.log) >> >> linux riscv64 gcc13 build jdk11u-dev failure because other reasons, the `k_rem_pio2.c` file not longer compile fail after this PR. > > Thanks all for the review and approved. > @sendaoYan would you mind to integrate this today to have it in 11.0.24? Sorry, I didn't notice that the `jdk17u-fix-yes` label has been added. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2709#issuecomment-2134259817 From syan at openjdk.org Tue May 28 02:53:29 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 02:53:29 GMT Subject: [jdk17u-dev] RFR: 8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978 [v4] In-Reply-To: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> References: <3urRyb3quVez41YitywGmtP5uuiPUSqkgJH9-WjyPxs=.1a04291f-dc37-40f5-b168-8c988814847a@github.com> Message-ID: > Hi, > > The testcase ReflectionCallerCacheTest.java run failed with -Xcomp, both on linux-x86_64 and linux-aarch64. > > And it run pass by jdk23 binary with the same testcase and the same jvm options(-Xcomp): > > ![image](https://github.com/openjdk/jdk17u-dev/assets/24123821/9ee1e9d2-96fc-4772-b11f-776a631515cd) > > > Before we found the root cause of this failure, should we problem list this testcase in test/jdk/ProblemList-Xcomp.txt. > > Thanks, > -sendao SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into jbs8324978 - Merge branch 'openjdk:master' into jbs8324978 - Merge branch 'openjdk:master' into jbs8324978 - 8324978: java/lang/reflect/callerCache/ReflectionCallerCacheTest.java run fail with -Xcomp: Class AccessTest$PublicStaticFinalField not unloaded! Signed-off-by: sendaoYan ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2186/files - new: https://git.openjdk.org/jdk17u-dev/pull/2186/files/9b76542d..5d38e4e7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2186&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2186&range=02-03 Stats: 3453 lines in 75 files changed: 904 ins; 1877 del; 672 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2186.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2186/head:pull/2186 PR: https://git.openjdk.org/jdk17u-dev/pull/2186 From syan at openjdk.org Tue May 28 03:27:28 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 03:27:28 GMT Subject: [jdk17u-dev] RFR: 8288568: Reduce runtime of java.security microbenchmarks Message-ID: Hi all, I backport this parity with 17.0.13-oracle. Only change the jmh testcases, the risk is low. ------------- Commit messages: - Backport a28ab7b62abcfce56425d62d5a8162d8f1623393 Changes: https://git.openjdk.org/jdk17u-dev/pull/2499/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2499&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288568 Stats: 49 lines in 10 files changed: 25 ins; 3 del; 21 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2499.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2499/head:pull/2499 PR: https://git.openjdk.org/jdk17u-dev/pull/2499 From syan at openjdk.org Tue May 28 03:41:17 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 03:41:17 GMT Subject: [jdk21u-dev] RFR: 8318479: [jmh] the test security.CacheBench failed for multiple threads run Message-ID: Hi all, This is backport parity with 21.0.5-oracle, remove the hardcoded maximum heap size, to avoid OOM fail with 100+ threads. ------------- Commit messages: - Backport 1535528cb119195b44244e8ee6bc0f913caa9270 Changes: https://git.openjdk.org/jdk21u-dev/pull/606/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=606&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318479 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/606.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/606/head:pull/606 PR: https://git.openjdk.org/jdk21u-dev/pull/606 From syan at openjdk.org Tue May 28 03:57:09 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 03:57:09 GMT Subject: [jdk17u-dev] RFR: 8318479: [jmh] the test security.CacheBench failed for multiple threads run Message-ID: Hi all, This is backport of [JDK-8318479](https://bugs.openjdk.org/browse/JDK-8318479) parity with 17.0.13-oracle, which remove the hardcoded maximum heap size, to avoid OOM fail with 100+ threads. It's not clean because of it has a prefixed bakport [JDK-8288568](https://github.com/openjdk/jdk17u-dev/pull/2499) Only change the jmh testcase, no risk. ------------- Commit messages: - Backport 1535528cb119195b44244e8ee6bc0f913caa9270 Changes: https://git.openjdk.org/jdk17u-dev/pull/2500/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2500&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318479 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2500.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2500/head:pull/2500 PR: https://git.openjdk.org/jdk17u-dev/pull/2500 From syan at openjdk.org Tue May 28 05:20:08 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 05:20:08 GMT Subject: [jdk17u-dev] Integrated: 8314835: gtest wrappers should be marked as flagless In-Reply-To: References: Message-ID: On Tue, 14 May 2024 08:12:31 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8314835](https://bugs.openjdk.org/browse/JDK-8314835), to make releated tests as flagless. > The backport is not clean, because the file `test/hotspot/jtreg/gtest/NativeHeapTrimmerGtest.java` has subsequent backport [JDK-8325496](https://bugs.openjdk.org/browse/JDK-8325496) > Only change the testcases, the risk is low. > > Thanks, > -sendao This pull request has now been integrated. Changeset: 69e67363 Author: SendaoYan Committer: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/69e67363d784d90dc259cd1aeb383f5c72a724b9 Stats: 7 lines in 3 files changed: 6 ins; 0 del; 1 mod 8314835: gtest wrappers should be marked as flagless Backport-of: 1ea6463fbb95258725ed4a11621ec662859a76e0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2470 From syan at openjdk.org Tue May 28 05:20:04 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 05:20:04 GMT Subject: [jdk11u-dev] Integrated: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c In-Reply-To: <0eSK5ocjyerxsBrXiW1q3tUKbTwRFoVzB_FdgqUOhM4=.40028621-3da5-49de-bd20-56a256089ee6@github.com> References: <0eSK5ocjyerxsBrXiW1q3tUKbTwRFoVzB_FdgqUOhM4=.40028621-3da5-49de-bd20-56a256089ee6@github.com> Message-ID: On Mon, 13 May 2024 13:07:12 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8293887](https://bugs.openjdk.org/browse/JDK-8293887). It's not clean backport, because the file `make/lib/CoreLibraries.gmk` has been moved to `make/modules/java.base/lib/CoreLibraries.gmk` > > Thanks! > > > Make test list: > > - [x] linux x64 gcc10 > - [x] linux x64 gcc13 > - [x] linux aarch64 gcc10 > - [x] linux aarch64 gcc13 > - [x] linux riscv64 gcc13 > > > [make-linux-aarch64-gcc10.log](https://github.com/openjdk/jdk11u-dev/files/15295807/make-linux-aarch64-gcc10.log) > [make-linux-aarch64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295808/make-linux-aarch64-gcc13.log) > [make-linux-x64-gcc10.log](https://github.com/openjdk/jdk11u-dev/files/15295809/make-linux-x64-gcc10.log) > [make-linux-x64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295810/make-linux-x64-gcc13.log) > [make-linux-riscv64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295880/make-linux-riscv64-gcc13.log) > > linux riscv64 gcc13 build jdk11u-dev failure because other reasons, the `k_rem_pio2.c` file not longer compile fail after this PR. This pull request has now been integrated. Changeset: 8a489e58 Author: SendaoYan Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/8a489e58b37611f4088efe19b2a43a9e54f7866d Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c Reviewed-by: aph, phh Backport-of: 02ea338177df781912dc782e32200eaf4731a0da ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2709 From syan at openjdk.org Tue May 28 06:12:03 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 06:12:03 GMT Subject: [jdk17u-dev] RFR: 8314835: gtest wrappers should be marked as flagless In-Reply-To: References: Message-ID: On Tue, 14 May 2024 08:12:31 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8314835](https://bugs.openjdk.org/browse/JDK-8314835), to make releated tests as flagless. > The backport is not clean, because the file `test/hotspot/jtreg/gtest/NativeHeapTrimmerGtest.java` has subsequent backport [JDK-8325496](https://bugs.openjdk.org/browse/JDK-8325496) > Only change the testcases, the risk is low. > > Thanks, > -sendao > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2470#issuecomment-2134416004 From syan at openjdk.org Tue May 28 06:12:12 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 06:12:12 GMT Subject: [jdk11u-dev] RFR: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c In-Reply-To: <0eSK5ocjyerxsBrXiW1q3tUKbTwRFoVzB_FdgqUOhM4=.40028621-3da5-49de-bd20-56a256089ee6@github.com> References: <0eSK5ocjyerxsBrXiW1q3tUKbTwRFoVzB_FdgqUOhM4=.40028621-3da5-49de-bd20-56a256089ee6@github.com> Message-ID: On Mon, 13 May 2024 13:07:12 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8293887](https://bugs.openjdk.org/browse/JDK-8293887). It's not clean backport, because the file `make/lib/CoreLibraries.gmk` has been moved to `make/modules/java.base/lib/CoreLibraries.gmk` > > Thanks! > > > Make test list: > > - [x] linux x64 gcc10 > - [x] linux x64 gcc13 > - [x] linux aarch64 gcc10 > - [x] linux aarch64 gcc13 > - [x] linux riscv64 gcc13 > > > [make-linux-aarch64-gcc10.log](https://github.com/openjdk/jdk11u-dev/files/15295807/make-linux-aarch64-gcc10.log) > [make-linux-aarch64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295808/make-linux-aarch64-gcc13.log) > [make-linux-x64-gcc10.log](https://github.com/openjdk/jdk11u-dev/files/15295809/make-linux-x64-gcc10.log) > [make-linux-x64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295810/make-linux-x64-gcc13.log) > [make-linux-riscv64-gcc13.log](https://github.com/openjdk/jdk11u-dev/files/15295880/make-linux-riscv64-gcc13.log) > > linux riscv64 gcc13 build jdk11u-dev failure because other reasons, the `k_rem_pio2.c` file not longer compile fail after this PR. > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2709#issuecomment-2134415707 From mbaesken at openjdk.org Tue May 28 07:17:11 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 28 May 2024 07:17:11 GMT Subject: [jdk21u-dev] Integrated: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing In-Reply-To: References: Message-ID: On Tue, 14 May 2024 11:59:42 GMT, Matthias Baesken wrote: > 8329862: libjli GetApplicationHome cleanups and enhance jli tracing This pull request has now been integrated. Changeset: 2e327a9a Author: Matthias Baesken URL: https://git.openjdk.org/jdk21u-dev/commit/2e327a9a98ecef6c55120cc9fdee7b5aca7aa7cd Stats: 46 lines in 2 files changed: 8 ins; 36 del; 2 mod 8329862: libjli GetApplicationHome cleanups and enhance jli tracing Backport-of: 377f2e538ae0fc94fc5483700a3ae70175017741 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/570 From stuefe at openjdk.org Tue May 28 07:44:04 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 28 May 2024 07:44:04 GMT Subject: [jdk17u-dev] RFR: 8314835: gtest wrappers should be marked as flagless In-Reply-To: References: Message-ID: On Tue, 14 May 2024 08:12:31 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8314835](https://bugs.openjdk.org/browse/JDK-8314835), to make releated tests as flagless. > The backport is not clean, because the file `test/hotspot/jtreg/gtest/NativeHeapTrimmerGtest.java` has subsequent backport [JDK-8325496](https://bugs.openjdk.org/browse/JDK-8325496) > Only change the testcases, the risk is low. > > Thanks, > -sendao Hi, about this and similar "flagless" backports. Why is this backported, and how does it affect test execution? What does flagless do, exactly? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2470#issuecomment-2134548182 From syan at openjdk.org Tue May 28 08:06:05 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 08:06:05 GMT Subject: [jdk17u-dev] RFR: 8314835: gtest wrappers should be marked as flagless In-Reply-To: References: Message-ID: On Tue, 28 May 2024 07:41:27 GMT, Thomas Stuefe wrote: > Hi, about this and similar "flagless" backports. Why is this backported, and how does it affect test execution? What does flagless do, exactly? If the testcase mark as `@requires vm.flagless`, then this testcase will not been selected by jtreg when gived jvm non-default jvm options. That means this testcase not suitable for run with non-default jvm options. Take `gtest/AsyncLogGtest.java` as an example: Do jtreg list with default jvm options: > jtreg -l test/hotspot/jtreg/gtest/AsyncLogGtest.java Testsuite: /home/yansendao/git/jdk/test/hotspot/jtreg gtest/AsyncLogGtest.java Tests found: 1 Do jtreg list with jvm options -Xcomp, it says not tests found: > jtreg -l -Xcomp test/hotspot/jtreg/gtest/AsyncLogGtest.java Testsuite: /home/yansendao/git/jdk/test/hotspot/jtreg Tests found: 0 The testcases which mark as `@requires vm.flagless` not suitable for run with non-default jvm options, that means these testcases will only run with default jvm options. These testcases will run failed when it's not mark as `@requires vm.flagless` when run with some non-default jvm options. The "flagless" backport make these testcases more robustness. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2470#issuecomment-2134586655 From stuefe at openjdk.org Tue May 28 08:24:09 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 28 May 2024 08:24:09 GMT Subject: [jdk17u-dev] RFR: 8314835: gtest wrappers should be marked as flagless In-Reply-To: References: Message-ID: On Tue, 28 May 2024 08:03:26 GMT, SendaoYan wrote: > > Hi, about this and similar "flagless" backports. Why is this backported, and how does it affect test execution? What does flagless do, exactly? > > If the testcase mark as `@requires vm.flagless`, then this testcase will not been selected by jtreg when gived jvm non-default jvm options. That means this testcase not suitable for run with non-default jvm options. > > Take `gtest/AsyncLogGtest.java` as an example: Do jtreg list with default jvm options: > > ``` > > jtreg -l test/hotspot/jtreg/gtest/AsyncLogGtest.java > Testsuite: /home/yansendao/git/jdk/test/hotspot/jtreg > gtest/AsyncLogGtest.java > Tests found: 1 > ``` > > Do jtreg list with jvm options -Xcomp, it says not tests found: > > ``` > > jtreg -l -Xcomp test/hotspot/jtreg/gtest/AsyncLogGtest.java > Testsuite: /home/yansendao/git/jdk/test/hotspot/jtreg > Tests found: 0 > ``` > > The testcases which mark as `@requires vm.flagless` not suitable for run with non-default jvm options, that means these testcases will only run with default jvm options. These testcases will run failed when it's not mark as `@requires vm.flagless` when run with some non-default jvm options. The "flagless" backport make these testcases more robustness. Interesting, thanks for the clear and concise explanation! BTW, I was not aware that one could give VM options directly to jtreg. Is `jtreg -XX:+abc" the same as `jtreg '-vmoption=-XX:abc'` ? I also realize that these questions should have been raised at the original PR. I guess the "flagless" concept assumes that there is always a standard run with no options, and only additional runs specify options. If you want to always specify certain options, e.g. certain paranoia flags, or increase logging, this would unexpectedly omit a bunch of tests. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2470#issuecomment-2134621304 From mdoerr at openjdk.org Tue May 28 08:28:01 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 28 May 2024 08:28:01 GMT Subject: [jdk17u-dev] RFR: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation In-Reply-To: References: Message-ID: On Mon, 27 May 2024 15:36:49 GMT, Martin Doerr wrote: > Basically clean backport of [JDK-8313873](https://bugs.openjdk.org/browse/JDK-8313873). GHA pre-submit failure is unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2496#issuecomment-2134630015 From mdoerr at openjdk.org Tue May 28 08:29:07 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 28 May 2024 08:29:07 GMT Subject: [jdk17u-dev] RFR: 8294699: Launcher causes lingering busy cursor In-Reply-To: <5ce92hmPjG7i7s2iPb7c7MIDhgDjfjxDjGhpAFnAE10=.211e57d0-235b-41aa-a668-26c07223bbc9@github.com> References: <5ce92hmPjG7i7s2iPb7c7MIDhgDjfjxDjGhpAFnAE10=.211e57d0-235b-41aa-a668-26c07223bbc9@github.com> Message-ID: On Mon, 27 May 2024 16:05:57 GMT, Martin Doerr wrote: > Clean backport of [JDK-8294699](https://bugs.openjdk.org/browse/JDK-8294699). GHA pre-submit failure is unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2497#issuecomment-2134631692 From duke at openjdk.org Tue May 28 08:35:08 2024 From: duke at openjdk.org (Rinku Kumar Maurya) Date: Tue, 28 May 2024 08:35:08 GMT Subject: [jdk17u-dev] Integrated: 8289643: File descriptor leak with ProcessBuilder.startPipeline In-Reply-To: References: Message-ID: <94XqHFzc3V-x90XYMY_EXwCFM0m1hsDRH0K5AMJUafs=.900542e6-7e6a-4c59-b761-0c941f556b88@github.com> On Mon, 13 May 2024 11:40:09 GMT, Rinku Kumar Maurya wrote: > clean backport to fix file descriptor leak with ProcessBuilder.startPipeline. When using ProcessBuilder.startPipeline the pipes (or pipe if only 2 ProcessBuilder instance used) created are never closed. > > > with changes :- > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java > 1 1 0 0 > ============================== > TEST SUCCESS > > > without changes :- > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java > 1 0 1 0 > ============================== > TEST FAILURE > > with expected output :- > test PipelineLeaksFD.checkForLeaks(java.util.ImmutableCollections$ListN at 44d1a216): failure > java.lang.AssertionError: More or fewer pipes than expected > ... This pull request has now been integrated. Changeset: d1e31f6f Author: Rinku Kumar Maurya Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/d1e31f6f6a455572c2d5b6f118ce54fa040e0e82 Stats: 150 lines in 2 files changed: 149 ins; 0 del; 1 mod 8289643: File descriptor leak with ProcessBuilder.startPipeline 8290885: java/lang/ProcessBuilder/PipelineLeaksFD.java fail: More or fewer pipes than expected Reviewed-by: shade Backport-of: 620c8a045f92126c2552347b9f369405ab2d6d36 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2462 From andrewlu at openjdk.org Tue May 28 08:37:24 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 28 May 2024 08:37:24 GMT Subject: [jdk17u-dev] RFR: 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified Message-ID: 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified ------------- Commit messages: - Backport 1b0dd7c254dc1a087874c8726d8d26b9a41d4145 Changes: https://git.openjdk.org/jdk17u-dev/pull/2502/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2502&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310108 Stats: 18 lines in 4 files changed: 18 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2502.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2502/head:pull/2502 PR: https://git.openjdk.org/jdk17u-dev/pull/2502 From andrewlu at openjdk.org Tue May 28 08:37:29 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 28 May 2024 08:37:29 GMT Subject: [jdk21u-dev] RFR: 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified Message-ID: 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified ------------- Commit messages: - Backport 1b0dd7c254dc1a087874c8726d8d26b9a41d4145 Changes: https://git.openjdk.org/jdk21u-dev/pull/607/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=607&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310108 Stats: 18 lines in 4 files changed: 18 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/607.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/607/head:pull/607 PR: https://git.openjdk.org/jdk21u-dev/pull/607 From shade at openjdk.org Tue May 28 08:46:28 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 28 May 2024 08:46:28 GMT Subject: [jdk22u] RFR: 8331714: Make OopMapCache installation lock-free Message-ID: Clean backport to improve internal locking. Makes future backports clean. Additional testing: - [ ] GHA - [ ] Linux x86_64 fastdebug `hotspot_gc` ------------- Commit messages: - Backport a2584a8341b2dc9c102abd373a890b2108d3f57e Changes: https://git.openjdk.org/jdk22u/pull/225/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=225&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331714 Stats: 12 lines in 3 files changed: 1 ins; 3 del; 8 mod Patch: https://git.openjdk.org/jdk22u/pull/225.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/225/head:pull/225 PR: https://git.openjdk.org/jdk22u/pull/225 From shade at openjdk.org Tue May 28 08:59:31 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 28 May 2024 08:59:31 GMT Subject: [jdk21u-dev] RFR: 8331714: Make OopMapCache installation lock-free Message-ID: Clean backport to improve internal locking. Also makes future backports clean. Additional testing: - [ ] Linux x86_64 fastdebug `all` ------------- Commit messages: - Backport a2584a8341b2dc9c102abd373a890b2108d3f57e Changes: https://git.openjdk.org/jdk21u-dev/pull/608/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=608&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331714 Stats: 12 lines in 3 files changed: 1 ins; 3 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/608.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/608/head:pull/608 PR: https://git.openjdk.org/jdk21u-dev/pull/608 From mdoerr at openjdk.org Tue May 28 09:05:04 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 28 May 2024 09:05:04 GMT Subject: [jdk21u-dev] RFR: 8331266: Bump update version for OpenJDK: jdk-21.0.5 In-Reply-To: References: Message-ID: On Mon, 27 May 2024 22:15:06 GMT, Christoph Langer wrote: > Bump version for 21.0.5 Marked as reviewed by mdoerr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/605#pullrequestreview-2082185600 From mdoerr at openjdk.org Tue May 28 09:05:04 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 28 May 2024 09:05:04 GMT Subject: [jdk17u-dev] RFR: 8331265: Bump update version for OpenJDK: jdk-17.0.13 In-Reply-To: References: Message-ID: On Mon, 27 May 2024 22:22:30 GMT, Christoph Langer wrote: > Version bump 17.0.13 Marked as reviewed by mdoerr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2498#pullrequestreview-2082185798 From mdoerr at openjdk.org Tue May 28 09:05:10 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 28 May 2024 09:05:10 GMT Subject: [jdk11u-dev] RFR: 8331263: Bump update version for OpenJDK: jdk-11.0.25 In-Reply-To: References: Message-ID: On Mon, 27 May 2024 22:37:09 GMT, Christoph Langer wrote: > Bump for 11.0.25 Marked as reviewed by mdoerr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2727#pullrequestreview-2082186618 From sgehwolf at openjdk.org Tue May 28 09:09:03 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 28 May 2024 09:09:03 GMT Subject: [jdk21u-dev] RFR: 8331266: Bump update version for OpenJDK: jdk-21.0.5 In-Reply-To: References: Message-ID: On Mon, 27 May 2024 22:15:06 GMT, Christoph Langer wrote: > Bump version for 21.0.5 Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/605#pullrequestreview-2082194764 From sgehwolf at openjdk.org Tue May 28 09:11:03 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 28 May 2024 09:11:03 GMT Subject: [jdk17u-dev] RFR: 8331265: Bump update version for OpenJDK: jdk-17.0.13 In-Reply-To: References: Message-ID: On Mon, 27 May 2024 22:22:30 GMT, Christoph Langer wrote: > Version bump 17.0.13 Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2498#pullrequestreview-2082198221 From sgehwolf at openjdk.org Tue May 28 09:12:03 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 28 May 2024 09:12:03 GMT Subject: [jdk11u-dev] RFR: 8331263: Bump update version for OpenJDK: jdk-11.0.25 In-Reply-To: References: Message-ID: On Mon, 27 May 2024 22:37:09 GMT, Christoph Langer wrote: > Bump for 11.0.25 Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2727#pullrequestreview-2082202271 From shade at openjdk.org Tue May 28 09:12:15 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 28 May 2024 09:12:15 GMT Subject: [jdk21u-dev] RFR: 8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs Message-ID: Unclean backport to avoid confusion on `is_gc_active` flag. The code shapes in JDK 21 are a bit different due to multiple refactorings in later JDKs. I applied renames by hand where needed. Additional testing: - [ ] Linux x86_64 fastdebug, `all` ------------- Commit messages: - Backport 1eec30a6c03b7f4028405dc9bdb4d2a663b3987d Changes: https://git.openjdk.org/jdk21u-dev/pull/609/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=609&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331573 Stats: 63 lines in 27 files changed: 0 ins; 2 del; 61 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/609.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/609/head:pull/609 PR: https://git.openjdk.org/jdk21u-dev/pull/609 From syan at openjdk.org Tue May 28 09:44:11 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 09:44:11 GMT Subject: [jdk17u-dev] RFR: 8314835: gtest wrappers should be marked as flagless In-Reply-To: References: Message-ID: On Tue, 14 May 2024 08:12:31 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8314835](https://bugs.openjdk.org/browse/JDK-8314835), to make releated tests as flagless. > The backport is not clean, because the file `test/hotspot/jtreg/gtest/NativeHeapTrimmerGtest.java` has subsequent backport [JDK-8325496](https://bugs.openjdk.org/browse/JDK-8325496) > Only change the testcases, the risk is low. > > Thanks, > -sendao I think `jtreg -XX:+abc` same as `jtreg -vmoption:"-XX:+abc"` ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2470#issuecomment-2134781427 From andrewlu at openjdk.org Tue May 28 10:09:29 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 28 May 2024 10:09:29 GMT Subject: [jdk21u-dev] RFR: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab Message-ID: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab ------------- Commit messages: - Backport db5613af89a2d4ab5a8998ad1d43384778974866 Changes: https://git.openjdk.org/jdk21u-dev/pull/611/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=611&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317288 Stats: 80 lines in 1 file changed: 28 ins; 6 del; 46 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/611.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/611/head:pull/611 PR: https://git.openjdk.org/jdk21u-dev/pull/611 From andrewlu at openjdk.org Tue May 28 10:09:32 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 28 May 2024 10:09:32 GMT Subject: [jdk17u-dev] RFR: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab Message-ID: <2-5aDesW7cArGfpYlC5zwsBiYBUlIO6ytRl-RBvU0-Q=.31221b27-35a9-48c4-a6a4-a5470e20f40f@github.com> 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab ------------- Commit messages: - Backport db5613af89a2d4ab5a8998ad1d43384778974866 Changes: https://git.openjdk.org/jdk17u-dev/pull/2503/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2503&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317288 Stats: 80 lines in 1 file changed: 28 ins; 6 del; 46 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2503.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2503/head:pull/2503 PR: https://git.openjdk.org/jdk17u-dev/pull/2503 From andrewlu at openjdk.org Tue May 28 10:09:36 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Tue, 28 May 2024 10:09:36 GMT Subject: [jdk11u-dev] RFR: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab Message-ID: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab ------------- Commit messages: - Backport db5613af89a2d4ab5a8998ad1d43384778974866 Changes: https://git.openjdk.org/jdk11u-dev/pull/2728/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2728&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317288 Stats: 80 lines in 1 file changed: 28 ins; 6 del; 46 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2728.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2728/head:pull/2728 PR: https://git.openjdk.org/jdk11u-dev/pull/2728 From duke at openjdk.org Tue May 28 11:41:10 2024 From: duke at openjdk.org (Evgeny Ignatenko) Date: Tue, 28 May 2024 11:41:10 GMT Subject: [jdk17u-dev] RFR: 8315362: NMT: summary diff reports threads count incorrectly In-Reply-To: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> References: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> Message-ID: On Wed, 27 Dec 2023 07:31:16 GMT, Evgeny Ignatenko wrote: > 8315362: NMT: summary diff reports threads count incorrectly > This PR shouldn't differ from the 21u version: [openjdk/jdk21u at 31c759d](https://github.com/openjdk/jdk21u/commit/31c759dd7ef69449e225c3e656d8f522e1124852) I currently see the following diffs: > > ```diff > < + _thread_count ++; > --- > > + _thread_count++; > ``` > > ```diff > < + output.shouldContain("Baseline succeeded"); > --- > > + output.shouldContain("Baseline taken"); > ``` For _thread_count is a good catch, but we need to modify the test like this because JDK-8289182 was not backported to the JDK 17 and `jcmd VM.native_memory baseline` outputs `Baseline succeeded` not `Baseline taken` ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2084#issuecomment-2135003335 From duke at openjdk.org Tue May 28 11:44:36 2024 From: duke at openjdk.org (Evgeny Ignatenko) Date: Tue, 28 May 2024 11:44:36 GMT Subject: [jdk17u-dev] RFR: 8315362: NMT: summary diff reports threads count incorrectly [v2] In-Reply-To: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> References: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> Message-ID: > 8315362: NMT: summary diff reports threads count incorrectly Evgeny Ignatenko has updated the pull request incrementally with one additional commit since the last revision: Fix inconsistency with patch at jdk21 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2084/files - new: https://git.openjdk.org/jdk17u-dev/pull/2084/files/d4ccc8b1..fbe0e219 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2084&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2084&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2084.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2084/head:pull/2084 PR: https://git.openjdk.org/jdk17u-dev/pull/2084 From syan at openjdk.org Tue May 28 11:55:02 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 11:55:02 GMT Subject: [jdk22u] RFR: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM In-Reply-To: References: Message-ID: On Thu, 23 May 2024 01:36:48 GMT, SendaoYan wrote: > Hi all, > This clean backport of [JDK-8332490](https://bugs.openjdk.org/browse/JDK-8332490), to closes the InflaterInputStream when the reads complete. The change has been verified. Only change the JMH testcase, no risk. Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/219#issuecomment-2135029302 From mdoerr at openjdk.org Tue May 28 12:02:03 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 28 May 2024 12:02:03 GMT Subject: [jdk17u-dev] RFR: 8315362: NMT: summary diff reports threads count incorrectly [v2] In-Reply-To: References: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> Message-ID: On Tue, 28 May 2024 11:44:36 GMT, Evgeny Ignatenko wrote: >> 8315362: NMT: summary diff reports threads count incorrectly > > Evgeny Ignatenko has updated the pull request incrementally with one additional commit since the last revision: > > Fix inconsistency with patch at jdk21 Ok. LGTM. Should be adapted if https://github.com/openjdk/jdk17u-dev/pull/2415 gets approved and integrated. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/2084#pullrequestreview-2082579859 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2084#issuecomment-2135043227 From duke at openjdk.org Tue May 28 12:40:11 2024 From: duke at openjdk.org (Evgeny Ignatenko) Date: Tue, 28 May 2024 12:40:11 GMT Subject: [jdk17u-dev] RFR: 8315362: NMT: summary diff reports threads count incorrectly [v2] In-Reply-To: References: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> Message-ID: On Tue, 28 May 2024 11:59:55 GMT, Martin Doerr wrote: >> Evgeny Ignatenko has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix inconsistency with patch at jdk21 > > Should be adapted if https://github.com/openjdk/jdk17u-dev/pull/2415 gets approved and integrated. Thank you @TheRealMDoerr! Can I please ask you to take a look to the follow up fix backport https://github.com/openjdk/jdk17u-dev/pull/2085? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2084#issuecomment-2135115003 From mdoerr at openjdk.org Tue May 28 13:03:08 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 28 May 2024 13:03:08 GMT Subject: [jdk17u-dev] RFR: 8315362: NMT: summary diff reports threads count incorrectly [v2] In-Reply-To: References: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> Message-ID: <5oMs0Wm4lA1O1Xpf512BLJX546Tjv7VB1A9CE5eaz_M=.8b1b6c4d-82ab-4796-8ae7-3a38edf4363e@github.com> On Tue, 28 May 2024 11:44:36 GMT, Evgeny Ignatenko wrote: >> 8315362: NMT: summary diff reports threads count incorrectly > > Evgeny Ignatenko has updated the pull request incrementally with one additional commit since the last revision: > > Fix inconsistency with patch at jdk21 https://github.com/openjdk/jdk17u-dev/pull/2085 is clean and trivial. It doesn't need a review. However, all backports need maintainer approvals (see https://wiki.openjdk.org/display/JDKUpdates/JDK+17u). We typically describe in the approval request the motivation for doing the backport, how risky it is and how we tested it. Having said this, please enable GitHub Actions to get automatic tests running on your PRs. I have requested approval for https://github.com/openjdk/jdk17u-dev/pull/2415, so that one should get integrated first and this one become a clean backport of the JDK 21 version. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2084#issuecomment-2135160597 From syan at openjdk.org Tue May 28 14:36:17 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 14:36:17 GMT Subject: [jdk22u] Integrated: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM In-Reply-To: References: Message-ID: On Thu, 23 May 2024 01:36:48 GMT, SendaoYan wrote: > Hi all, > This clean backport of [JDK-8332490](https://bugs.openjdk.org/browse/JDK-8332490), to closes the InflaterInputStream when the reads complete. The change has been verified. Only change the JMH testcase, no risk. This pull request has now been integrated. Changeset: b96b4f67 Author: SendaoYan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/b96b4f67f232d9affeb7fa73b6b0d8628d8f89a8 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM Backport-of: 98f6a80852383dcbdad7292b7d269a8547d54d45 ------------- PR: https://git.openjdk.org/jdk22u/pull/219 From syan at openjdk.org Tue May 28 14:39:10 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 14:39:10 GMT Subject: [jdk22u] RFR: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM In-Reply-To: References: Message-ID: On Thu, 23 May 2024 01:36:48 GMT, SendaoYan wrote: > Hi all, > This clean backport of [JDK-8332490](https://bugs.openjdk.org/browse/JDK-8332490), to closes the InflaterInputStream when the reads complete. The change has been verified. Only change the JMH testcase, no risk. > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/219#issuecomment-2135395552 From shade at openjdk.org Tue May 28 14:42:04 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 28 May 2024 14:42:04 GMT Subject: [jdk22u] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: References: Message-ID: On Thu, 2 May 2024 13:59:45 GMT, SendaoYan wrote: > Hi, > This is clean backport of JDK-8331164, to fixed download failure when the URL needed to be redirected. > Only change devkit shell script, the risk is low. Still want to integrate it for 22.0.2 tree, @sendaoYan? ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/180#issuecomment-2135404040 From shade at openjdk.org Tue May 28 14:42:05 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 28 May 2024 14:42:05 GMT Subject: [jdk22u] Integrated: 8327501: Common ForkJoinPool prevents class unloading in some cases In-Reply-To: <9Ds1-y9mXpO_EHnIHx2UFKWROoZKm3ExBC_9vCRjNp4=.6580d530-405d-4091-a872-ec26f1a935cd@github.com> References: <9Ds1-y9mXpO_EHnIHx2UFKWROoZKm3ExBC_9vCRjNp4=.6580d530-405d-4091-a872-ec26f1a935cd@github.com> Message-ID: On Wed, 15 May 2024 09:32:31 GMT, Aleksey Shipilev wrote: > First change fixes the regression since JDK 19. Second change fixes the regression from the fix. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `all` This pull request has now been integrated. Changeset: 3663b2d6 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/3663b2d6430bdca2c2ef19ffe3fbecb6bed95448 Stats: 11 lines in 2 files changed: 8 ins; 2 del; 1 mod 8327501: Common ForkJoinPool prevents class unloading in some cases 8328366: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 Backport-of: 53c4714aab2e072ba18631875dcaa3b2d5d22243 ------------- PR: https://git.openjdk.org/jdk22u/pull/206 From shade at openjdk.org Tue May 28 14:42:08 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 28 May 2024 14:42:08 GMT Subject: [jdk22u] RFR: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment In-Reply-To: References: Message-ID: On Mon, 8 Apr 2024 07:08:33 GMT, Per Minborg wrote: > Hi all, > > This pull request contains a backport of commit [93579c29](https://github.com/openjdk/jdk/commit/93579c29e3ba60a8bc16d712e7ffc733f324a223) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Per Minborg on 25 Mar 2024 and was reviewed by Maurizio Cimadamore. > > Thanks! This PR is clean, so it does not nominally requires review. You have maintainer approval for it, so it can go in. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk22u/pull/131#pullrequestreview-2083037560 From asmehra at openjdk.org Tue May 28 15:05:20 2024 From: asmehra at openjdk.org (Ashutosh Mehra) Date: Tue, 28 May 2024 15:05:20 GMT Subject: [jdk21u-dev] RFR: 8330275: Crash in XMark::follow_array Message-ID: Backport of [JDK-8330275](https://bugs.openjdk.org/browse/JDK-8330275) to fix crash in ZGC. ------------- Commit messages: - Backport 42b1d858d15fd06de9ce41b08b430b12724652e9 Changes: https://git.openjdk.org/jdk21u-dev/pull/612/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=612&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330275 Stats: 10 lines in 2 files changed: 4 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/612.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/612/head:pull/612 PR: https://git.openjdk.org/jdk21u-dev/pull/612 From syan at openjdk.org Tue May 28 15:08:00 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 15:08:00 GMT Subject: [jdk22u] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: References: Message-ID: On Tue, 28 May 2024 14:39:55 GMT, Aleksey Shipilev wrote: > Still want to integrate it for 22.0.2 tree, @sendaoYan? I think it's all fine, integrate after 22.0.2 or for 22.0.2 both OK for me. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/180#issuecomment-2135462672 From shade at openjdk.org Tue May 28 15:11:06 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 28 May 2024 15:11:06 GMT Subject: [jdk22u] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: References: Message-ID: On Tue, 28 May 2024 15:05:25 GMT, SendaoYan wrote: > I think it's all fine, integrate after 22.0.2 or for 22.0.2 both OK for me. I don't expect 22.0.3 would happen, as STS x.0.2 is likely the last release in the train. So it is really your call if you want to integrate it now, or leave it. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/180#issuecomment-2135468901 From syan at openjdk.org Tue May 28 15:15:06 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 15:15:06 GMT Subject: [jdk22u] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: References: Message-ID: On Tue, 28 May 2024 15:08:04 GMT, Aleksey Shipilev wrote: > > I think it's all fine, integrate after 22.0.2 or for 22.0.2 both OK for me. > > I don't expect 22.0.3 would happen, as STS x.0.2 is likely the last release in the train. So it is really your call if you want to integrate it now, or leave it. Help me integrate it now. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/180#issuecomment-2135481257 From duke at openjdk.org Tue May 28 15:24:29 2024 From: duke at openjdk.org (Rinku Kumar Maurya) Date: Tue, 28 May 2024 15:24:29 GMT Subject: [jdk17u-dev] RFR: 8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant" Message-ID: <6p2GXeiaitURhthFgjjfqEFtZhqf3ta63UxvQ8Qc834=.1bc254c1-b873-46ce-a445-1d9e4f62ed66@github.com> clean backport to remove assertion which assumes artifact is not serialized and only `JfrRecorderThread` can perform serialization of artifacts marked during the window between rotate() and end_recording(), which is not true because a GC thread during unloading process will serialize (in-memory checkpoint entry) the class loaders associated with the unloaded classes. We should remove this assertion and let the code fall through and explicitly clear the serialize and transient meta bits. ------------- Commit messages: - Backport ffa34ed429079827c9b0acb843288fde4b7fa53d Changes: https://git.openjdk.org/jdk17u-dev/pull/2504/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2504&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8265919 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2504.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2504/head:pull/2504 PR: https://git.openjdk.org/jdk17u-dev/pull/2504 From shade at openjdk.org Tue May 28 15:53:09 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 28 May 2024 15:53:09 GMT Subject: [jdk22u] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: References: Message-ID: <2qiu0fUo2j9wI12Bd1f8556F8wUYBDU4qFXULIIiND8=.e8d04037-2723-4b26-8cce-527cd74e748c@github.com> On Tue, 28 May 2024 15:12:35 GMT, SendaoYan wrote: > Help me integrate it now. Thanks. Sure, integrate and I'll sponsor. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/180#issuecomment-2135589431 From syan at openjdk.org Tue May 28 15:58:04 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 15:58:04 GMT Subject: [jdk22u] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: <2qiu0fUo2j9wI12Bd1f8556F8wUYBDU4qFXULIIiND8=.e8d04037-2723-4b26-8cce-527cd74e748c@github.com> References: <2qiu0fUo2j9wI12Bd1f8556F8wUYBDU4qFXULIIiND8=.e8d04037-2723-4b26-8cce-527cd74e748c@github.com> Message-ID: On Tue, 28 May 2024 15:50:53 GMT, Aleksey Shipilev wrote: > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/180#issuecomment-2135597215 From syan at openjdk.org Tue May 28 15:58:04 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 28 May 2024 15:58:04 GMT Subject: [jdk22u] Integrated: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: References: Message-ID: <63G-wie4UMObSksD4MQ5v-oOOvPQUNVn8SuFvxaUitk=.d66b40f8-3da9-415b-8a8e-ceec9dda4172@github.com> On Thu, 2 May 2024 13:59:45 GMT, SendaoYan wrote: > Hi, > This is clean backport of JDK-8331164, to fixed download failure when the URL needed to be redirected. > Only change devkit shell script, the risk is low. This pull request has now been integrated. Changeset: 851922da Author: SendaoYan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/851922da81e799aed379cfc034a8978d9a1f1d45 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8331164: createJMHBundle.sh download jars fail when url needed to be redirected Backport-of: eb88343fb763ee89010b7a9879638152decc6892 ------------- PR: https://git.openjdk.org/jdk22u/pull/180 From duke at openjdk.org Tue May 28 16:21:29 2024 From: duke at openjdk.org (Xiaolong Peng) Date: Tue, 28 May 2024 16:21:29 GMT Subject: [jdk22u] RFR: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC [v2] In-Reply-To: References: Message-ID: > 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision: Update full name ------------- Changes: - all: https://git.openjdk.org/jdk22u/pull/205/files - new: https://git.openjdk.org/jdk22u/pull/205/files/40c977f6..e7a631c6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk22u&pr=205&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk22u&pr=205&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/205.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/205/head:pull/205 PR: https://git.openjdk.org/jdk22u/pull/205 From stuefe at openjdk.org Tue May 28 16:35:02 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 28 May 2024 16:35:02 GMT Subject: [jdk21u-dev] RFR: 8330275: Crash in XMark::follow_array In-Reply-To: References: Message-ID: On Tue, 28 May 2024 14:59:47 GMT, Ashutosh Mehra wrote: > Backport of [JDK-8330275](https://bugs.openjdk.org/browse/JDK-8330275) to fix crash in ZGC. +1 ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/612#pullrequestreview-2083365907 From sgehwolf at openjdk.org Tue May 28 16:50:12 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 28 May 2024 16:50:12 GMT Subject: [jdk21u-dev] RFR: 8330275: Crash in XMark::follow_array In-Reply-To: References: Message-ID: <8IB_R9FjWNuVNQk4KbnkXXVEmgbq97VKivU2g7LyKNU=.340602dd-ebee-41e1-8f45-526ee05a97eb@github.com> On Tue, 28 May 2024 14:59:47 GMT, Ashutosh Mehra wrote: > Backport of [JDK-8330275](https://bugs.openjdk.org/browse/JDK-8330275) to fix crash in ZGC. Please create a backport for `jdk22u` as well. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/612#issuecomment-2135705061 From btaylor at openjdk.org Tue May 28 17:15:08 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Tue, 28 May 2024 17:15:08 GMT Subject: [jdk17u-dev] Integrated: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx In-Reply-To: <0F-_Xn1bw9oSoNxK3bCnabZuaZ0T3xEmNSpmjOH4VyQ=.31cf320f-a2c2-48ce-abd8-5fa2d4a46cd7@github.com> References: <0F-_Xn1bw9oSoNxK3bCnabZuaZ0T3xEmNSpmjOH4VyQ=.31cf320f-a2c2-48ce-abd8-5fa2d4a46cd7@github.com> Message-ID: On Fri, 17 May 2024 19:43:06 GMT, Ben Taylor wrote: > Clean backport of a low-risk change to address unexpected behavior with Parallel GC when Xms == Xmx > Passes local tier-1 testing on linux x86_64 This pull request has now been integrated. Changeset: f4da0e7a Author: Ben Taylor URL: https://git.openjdk.org/jdk17u-dev/commit/f4da0e7a58261a25ca11783c62f4a6f53718103e Stats: 11 lines in 1 file changed: 6 ins; 3 del; 2 mod 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx Backport-of: aca1e8365bf0f64bf18caf798bbca1d25b3c4117 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2480 From serb at openjdk.org Tue May 28 17:26:10 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 28 May 2024 17:26:10 GMT Subject: [jdk22u] Integrated: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes In-Reply-To: References: Message-ID: On Fri, 24 May 2024 02:33:46 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [9b1d6d66](https://github.com/openjdk/jdk/commit/9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 23 May 2024 and was reviewed by Paul Hohensee, Aleksey Shipilev and Erik Gahlin. > > Thanks! This pull request has now been integrated. Changeset: 3ed85b91 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk22u/commit/3ed85b9187a8fb3187028a27412b33b0420d198f Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes Backport-of: 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb ------------- PR: https://git.openjdk.org/jdk22u/pull/222 From asmehra at openjdk.org Tue May 28 17:35:24 2024 From: asmehra at openjdk.org (Ashutosh Mehra) Date: Tue, 28 May 2024 17:35:24 GMT Subject: [jdk22u] RFR: 8330275: Crash in XMark::follow_array Message-ID: <3KqDzS3pRPJVH5ZmBONeP4J5Oe9SNna4ZxpIGWU9q-w=.92f6d88b-ce3a-42b9-b33c-44c9da3fd996@github.com> Backport of [JDK-8330275](https://bugs.openjdk.org/browse/JDK-8330275) to fix crash in ZGC. ------------- Commit messages: - Backport 42b1d858d15fd06de9ce41b08b430b12724652e9 Changes: https://git.openjdk.org/jdk22u/pull/226/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=226&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330275 Stats: 10 lines in 2 files changed: 4 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk22u/pull/226.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/226/head:pull/226 PR: https://git.openjdk.org/jdk22u/pull/226 From serb at openjdk.org Tue May 28 17:59:07 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 28 May 2024 17:59:07 GMT Subject: [jdk22u] Integrated: 8331746: Create a test to verify that the cmm id is not ignored In-Reply-To: References: Message-ID: On Tue, 21 May 2024 22:31:33 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [7c750fd9](https://github.com/openjdk/jdk/commit/7c750fd95b83d0a93b0cce681dcfbbae1f220fdd) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 17 May 2024 and was reviewed by Phil Race, Dmitry Markov and Alexey Ivanov. > > Thanks! This pull request has now been integrated. Changeset: f867d977 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk22u/commit/f867d9779228b18e71b42697432f676a89138c16 Stats: 69 lines in 1 file changed: 69 ins; 0 del; 0 mod 8331746: Create a test to verify that the cmm id is not ignored Backport-of: 7c750fd95b83d0a93b0cce681dcfbbae1f220fdd ------------- PR: https://git.openjdk.org/jdk22u/pull/218 From sgehwolf at openjdk.org Tue May 28 18:27:08 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 28 May 2024 18:27:08 GMT Subject: [jdk21u-dev] RFR: 8330275: Crash in XMark::follow_array In-Reply-To: References: Message-ID: On Tue, 28 May 2024 14:59:47 GMT, Ashutosh Mehra wrote: > Backport of [JDK-8330275](https://bugs.openjdk.org/browse/JDK-8330275) to fix crash in ZGC. GHA failure on mac os x (on x86_64) seems infra related. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/612#issuecomment-2135866122 From asmehra at openjdk.org Tue May 28 18:39:04 2024 From: asmehra at openjdk.org (Ashutosh Mehra) Date: Tue, 28 May 2024 18:39:04 GMT Subject: [jdk21u-dev] RFR: 8330275: Crash in XMark::follow_array In-Reply-To: References: Message-ID: <79YkHm-jsjFPqoBKPeB1KehnepFuu_lOJXOnIRmGsP8=.354f9e19-c638-45b8-b1c0-261018d271d0@github.com> On Tue, 28 May 2024 18:24:39 GMT, Severin Gehwolf wrote: >> Backport of [JDK-8330275](https://bugs.openjdk.org/browse/JDK-8330275) to fix crash in ZGC. > > GHA failure on mac os x (on x86_64) seems infra related. @jerboaa @tstuefe thank you for approving it. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/612#issuecomment-2135880548 From duke at openjdk.org Tue May 28 18:39:08 2024 From: duke at openjdk.org (Xiaolong Peng) Date: Tue, 28 May 2024 18:39:08 GMT Subject: [jdk22u] Integrated: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC In-Reply-To: References: Message-ID: On Tue, 14 May 2024 23:34:25 GMT, Xiaolong Peng wrote: > 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC This pull request has now been integrated. Changeset: 70bd2c74 Author: Xiaolong Peng Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/70bd2c742e296a8b4d04b54e8ccc3786777bc1b4 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC Backport-of: 80ccc989a892e4d9f4e2c9395a100cfabbdcda64 ------------- PR: https://git.openjdk.org/jdk22u/pull/205 From asmehra at openjdk.org Tue May 28 18:39:05 2024 From: asmehra at openjdk.org (Ashutosh Mehra) Date: Tue, 28 May 2024 18:39:05 GMT Subject: [jdk21u-dev] Integrated: 8330275: Crash in XMark::follow_array In-Reply-To: References: Message-ID: On Tue, 28 May 2024 14:59:47 GMT, Ashutosh Mehra wrote: > Backport of [JDK-8330275](https://bugs.openjdk.org/browse/JDK-8330275) to fix crash in ZGC. This pull request has now been integrated. Changeset: 60402f88 Author: Ashutosh Mehra Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk21u-dev/commit/60402f88b569064cd140d782e1846988cff6e8cb Stats: 10 lines in 2 files changed: 4 ins; 0 del; 6 mod 8330275: Crash in XMark::follow_array Reviewed-by: stuefe Backport-of: 42b1d858d15fd06de9ce41b08b430b12724652e9 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/612 From asmehra at openjdk.org Tue May 28 18:45:28 2024 From: asmehra at openjdk.org (Ashutosh Mehra) Date: Tue, 28 May 2024 18:45:28 GMT Subject: [jdk21u-dev] RFR: 8333093: Incorrect comment in zAddress_aarch64.cpp Message-ID: Hi all, This pull request contains a backport of commit [51ae08f7](https://github.com/openjdk/jdk/commit/51ae08f72b879bc611177ea643cd88e36185d9e8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Ashutosh Mehra on 28 May 2024 and was reviewed by Stefan Karlsson. It is a trivial change to fix the comments. Thanks! ------------- Commit messages: - Backport 51ae08f72b879bc611177ea643cd88e36185d9e8 Changes: https://git.openjdk.org/jdk21u-dev/pull/613/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=613&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333093 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/613.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/613/head:pull/613 PR: https://git.openjdk.org/jdk21u-dev/pull/613 From duke at openjdk.org Tue May 28 18:57:27 2024 From: duke at openjdk.org (Elif Aslan) Date: Tue, 28 May 2024 18:57:27 GMT Subject: [jdk17u-dev] RFR: 8303942: os::write should write completely [v2] In-Reply-To: References: Message-ID: > This is not a clean backport. There were multiple merge conflicts related to undefined parameters and existing methods. This backport is required to address a crash observed in Amazon production. Please refer to the related [PR](https://github.com/openjdk/jdk17u-dev/pull/2281), which has already been merged. > > > In addition to GHA Tier 1, runtime hotspot, JFR, and hotspot GC tests have been run on macOS. > > > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:hotspot_runtime 880 880 0 0 > ============================== > TEST SUCCESS > > Finished building target 'test' in configuration 'macosx-x86_64-server-release' Elif Aslan has updated the pull request incrementally with one additional commit since the last revision: backport of 7ce5bd159024e70f5a997c47ed2ce962d6e6091b ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2490/files - new: https://git.openjdk.org/jdk17u-dev/pull/2490/files/808e194c..fd5be8a9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2490&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2490&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2490.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2490/head:pull/2490 PR: https://git.openjdk.org/jdk17u-dev/pull/2490 From duke at openjdk.org Tue May 28 19:20:13 2024 From: duke at openjdk.org (Elif Aslan) Date: Tue, 28 May 2024 19:20:13 GMT Subject: [jdk11u-dev] Integrated: 8273153: Consolidate file_exists into os:file_exists In-Reply-To: References: Message-ID: On Thu, 23 May 2024 23:12:50 GMT, Elif Aslan wrote: > This is not a clean backport. There was a merge conflict on os.cpp due to diverged os::split_path method for this reason os::file_exists method was manually added. > This backport is required to address a crash observed in Amazon production. > > tier2 tests were run in addition to GHA This pull request has now been integrated. Changeset: 47fd86ca Author: Elif Aslan Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/47fd86ca1c51280629b9f2b86b659c91ffeee22a Stats: 26 lines in 4 files changed: 9 ins; 13 del; 4 mod 8273153: Consolidate file_exists into os:file_exists Backport-of: 9732fbe428c3b6a5422cc94e7295ba5482d1a7a9 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2721 From mdoerr at openjdk.org Tue May 28 20:08:11 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 28 May 2024 20:08:11 GMT Subject: [jdk17u-dev] Integrated: 8294699: Launcher causes lingering busy cursor In-Reply-To: <5ce92hmPjG7i7s2iPb7c7MIDhgDjfjxDjGhpAFnAE10=.211e57d0-235b-41aa-a668-26c07223bbc9@github.com> References: <5ce92hmPjG7i7s2iPb7c7MIDhgDjfjxDjGhpAFnAE10=.211e57d0-235b-41aa-a668-26c07223bbc9@github.com> Message-ID: On Mon, 27 May 2024 16:05:57 GMT, Martin Doerr wrote: > Clean backport of [JDK-8294699](https://bugs.openjdk.org/browse/JDK-8294699). This pull request has now been integrated. Changeset: 0cfee92c Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/0cfee92c2974aaf8fe387e3393702e58c2917f18 Stats: 78 lines in 1 file changed: 76 ins; 0 del; 2 mod 8294699: Launcher causes lingering busy cursor Backport-of: d3df3eb5d7f5537ade917db7a36caba028f94111 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2497 From mdoerr at openjdk.org Tue May 28 20:19:16 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 28 May 2024 20:19:16 GMT Subject: [jdk17u-dev] RFR: 8325203: System.exit(0) kills the launched 3rd party application Message-ID: Clean backport of [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) from JDK 21. ------------- Commit messages: - Backport b9ca2532287b02388cd6f9e69b02a86713fc5b88 Changes: https://git.openjdk.org/jdk17u-dev/pull/2505/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2505&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325203 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2505.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2505/head:pull/2505 PR: https://git.openjdk.org/jdk17u-dev/pull/2505 From vpetko at openjdk.org Tue May 28 20:38:25 2024 From: vpetko at openjdk.org (Vladimir Petko) Date: Tue, 28 May 2024 20:38:25 GMT Subject: [jdk17u-dev] RFR: 8295111: dpkg appears to have problems resolving symbolically linked native libraries Message-ID: Hi all, This pull request contains a backport of commit [32946e18](https://github.com/openjdk/jdk/commit/32946e1882e9b22c983cbba3c6bda3cc7295946a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alexey Semenyuk on 18 Apr 2024 and was reviewed by Alexander Matveev. The backport had a conflict in the copyright header that was resolved manually. This change fixes an issue caused by usrmerge on Debian-based systems - dpkg -S does not return a package containing a symlinked shared library in /lib, e.g. dpkg -S /lib/x86_64-linux-gnu/libmd.so.0 # dpkg-query: no path found matching pattern /lib/x86_64-linux-gnu/libmd.so.0 The fix calls toRealPath() to resolve an actual path to the file before dpkg call and falls back to the old behaviour if the dpkg call fails. The change is tested by jpackage set of jtreg tests and should be low risk. jpackage tests pass (Ubuntu 24.04): ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/tools/jpackage 55 55 0 0 ============================== TEST SUCCESS Thanks! ------------- Commit messages: - Backport 32946e1882e9b22c983cbba3c6bda3cc7295946a Changes: https://git.openjdk.org/jdk17u-dev/pull/2501/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2501&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295111 Stats: 43 lines in 1 file changed: 19 ins; 3 del; 21 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2501.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2501/head:pull/2501 PR: https://git.openjdk.org/jdk17u-dev/pull/2501 From mdoerr at openjdk.org Tue May 28 20:53:26 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 28 May 2024 20:53:26 GMT Subject: [jdk21u-dev] RFR: 8320692: Null icon returned for .exe without custom icon Message-ID: <_ld4qBjyoFaDyB_eMu8idvNS70U5rZ894Biqw2maYBM=.cbeb8b6d-27a1-42c1-9ace-f4fd5ebcf306@github.com> Clean backport of [JDK-8320692](https://bugs.openjdk.org/browse/JDK-8320692). ------------- Commit messages: - Backport 6212264cc6fe428e8d15b7f33e2979c081e432d7 Changes: https://git.openjdk.org/jdk21u-dev/pull/614/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=614&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320692 Stats: 282 lines in 2 files changed: 280 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/614.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/614/head:pull/614 PR: https://git.openjdk.org/jdk21u-dev/pull/614 From serb at openjdk.org Tue May 28 22:53:27 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 28 May 2024 22:53:27 GMT Subject: [jdk21u-dev] RFR: 8311666: Disabled tests in test/jdk/sun/java2d/marlin Message-ID: Hi all, This pull request contains a backport of commit [b285ed72](https://github.com/openjdk/jdk/commit/b285ed72aebe2d802fa9c071372cea6c09870b9a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Liam Miller-Cushon on 10 Jul 2023 and was reviewed by Phil Race. Thanks! ------------- Commit messages: - Backport b285ed72aebe2d802fa9c071372cea6c09870b9a Changes: https://git.openjdk.org/jdk21u-dev/pull/603/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=603&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311666 Stats: 18 lines in 3 files changed: 17 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/603.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/603/head:pull/603 PR: https://git.openjdk.org/jdk21u-dev/pull/603 From dholmes at openjdk.org Tue May 28 23:19:04 2024 From: dholmes at openjdk.org (David Holmes) Date: Tue, 28 May 2024 23:19:04 GMT Subject: [jdk22u] Integrated: 8329958: Windows x86 build fails: downcallLinker.cpp(36) redefinition In-Reply-To: References: Message-ID: On Mon, 27 May 2024 21:59:55 GMT, David Holmes wrote: > Trivial backport to fix Windows 32-bit build issue. > > Thanks. This pull request has now been integrated. Changeset: 66cdc14c Author: David Holmes URL: https://git.openjdk.org/jdk22u/commit/66cdc14c70d337390aa4e3e303d7baaf13c132fb Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8329958: Windows x86 build fails: downcallLinker.cpp(36) redefinition Backport-of: 86eb5d9f3be30ff9df1318f18ab73c7129c978f6 ------------- PR: https://git.openjdk.org/jdk22u/pull/224 From serb at openjdk.org Tue May 28 23:31:13 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 28 May 2024 23:31:13 GMT Subject: [jdk17u-dev] RFR: 8311666: Disabled tests in test/jdk/sun/java2d/marlin Message-ID: Hi all, This pull request contains a backport of commit [b285ed72](https://github.com/openjdk/jdk/commit/b285ed72aebe2d802fa9c071372cea6c09870b9a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Liam Miller-Cushon on 10 Jul 2023 and was reviewed by Phil Race. Thanks! ------------- Commit messages: - Backport b285ed72aebe2d802fa9c071372cea6c09870b9a Changes: https://git.openjdk.org/jdk17u-dev/pull/2494/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2494&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311666 Stats: 18 lines in 3 files changed: 17 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2494.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2494/head:pull/2494 PR: https://git.openjdk.org/jdk17u-dev/pull/2494 From serb at openjdk.org Wed May 29 00:15:25 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 29 May 2024 00:15:25 GMT Subject: [jdk11u-dev] RFR: 8311666: Disabled tests in test/jdk/sun/java2d/marlin Message-ID: Hi all, This pull request contains a backport of commit [b285ed72](https://github.com/openjdk/jdk/commit/b285ed72aebe2d802fa9c071372cea6c09870b9a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Liam Miller-Cushon on 10 Jul 2023 and was reviewed by Phil Race. Thanks! ------------- Commit messages: - Backport b285ed72aebe2d802fa9c071372cea6c09870b9a Changes: https://git.openjdk.org/jdk11u-dev/pull/2725/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2725&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8311666 Stats: 18 lines in 3 files changed: 17 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2725.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2725/head:pull/2725 PR: https://git.openjdk.org/jdk11u-dev/pull/2725 From lmao at openjdk.org Wed May 29 01:43:08 2024 From: lmao at openjdk.org (Liang Mao) Date: Wed, 29 May 2024 01:43:08 GMT Subject: [jdk22u] RFR: 8330576: ZYoungCompactionLimit should have range check In-Reply-To: References: Message-ID: On Thu, 23 May 2024 08:59:12 GMT, Liang Mao wrote: > Backport of fixing range check of ZYoungCompactionLimit. Could committers please help to sponsor? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/220#issuecomment-2136363462 From mdoerr at openjdk.org Wed May 29 06:59:12 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 29 May 2024 06:59:12 GMT Subject: [jdk21u-dev] Integrated: 8320692: Null icon returned for .exe without custom icon In-Reply-To: <_ld4qBjyoFaDyB_eMu8idvNS70U5rZ894Biqw2maYBM=.cbeb8b6d-27a1-42c1-9ace-f4fd5ebcf306@github.com> References: <_ld4qBjyoFaDyB_eMu8idvNS70U5rZ894Biqw2maYBM=.cbeb8b6d-27a1-42c1-9ace-f4fd5ebcf306@github.com> Message-ID: On Tue, 28 May 2024 20:47:42 GMT, Martin Doerr wrote: > Clean backport of [JDK-8320692](https://bugs.openjdk.org/browse/JDK-8320692). This pull request has now been integrated. Changeset: 2971cb57 Author: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/2971cb5769121b47ac8c8db1078d67680a19341f Stats: 282 lines in 2 files changed: 280 ins; 0 del; 2 mod 8320692: Null icon returned for .exe without custom icon Backport-of: 6212264cc6fe428e8d15b7f33e2979c081e432d7 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/614 From mdoerr at openjdk.org Wed May 29 07:00:23 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 29 May 2024 07:00:23 GMT Subject: [jdk17u-dev] Integrated: 8325203: System.exit(0) kills the launched 3rd party application In-Reply-To: References: Message-ID: On Tue, 28 May 2024 20:14:47 GMT, Martin Doerr wrote: > Clean backport of [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) from JDK 21. This pull request has now been integrated. Changeset: c9d83d39 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/c9d83d392f3809bf536afdcb52142ee6916acff0 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8325203: System.exit(0) kills the launched 3rd party application Backport-of: b9ca2532287b02388cd6f9e69b02a86713fc5b88 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2505 From shade at openjdk.org Wed May 29 07:03:09 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 29 May 2024 07:03:09 GMT Subject: [jdk17u-dev] RFR: 8303942: os::write should write completely [v2] In-Reply-To: References: Message-ID: On Tue, 28 May 2024 18:57:27 GMT, Elif Aslan wrote: >> This is not a clean backport. There were multiple merge conflicts related to undefined parameters and existing methods. This backport is required to address a crash observed in Amazon production. Please refer to the related [PR](https://github.com/openjdk/jdk17u-dev/pull/2281), which has already been merged. >> >> >> In addition to GHA Tier 1, runtime hotspot, JFR, and hotspot GC tests have been run on macOS. >> >> >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/hotspot/jtreg:hotspot_runtime 880 880 0 0 >> ============================== >> TEST SUCCESS >> >> Finished building target 'test' in configuration 'macosx-x86_64-server-release' >> >> Additinonally, added clean backport of [JDK-8316468] (https://github.com/openjdk/jdk/commit/7ce5bd159024e70f5a997c47ed2ce962d6e6091b) >> >> After new commit reran runtime hotspot tests and they all passed > > Elif Aslan has updated the pull request incrementally with one additional commit since the last revision: > > backport of 7ce5bd159024e70f5a997c47ed2ce962d6e6091b You need to say `/issue add JDK-8316468` to record that this PR includes both fixes. Then also request the approval for that one with `/approval 8316468 request ...` ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2490#issuecomment-2136678226 From lmao at openjdk.org Wed May 29 07:06:13 2024 From: lmao at openjdk.org (Liang Mao) Date: Wed, 29 May 2024 07:06:13 GMT Subject: [jdk22u] Integrated: 8330576: ZYoungCompactionLimit should have range check In-Reply-To: References: Message-ID: <92VvXwPvDCeey3S5ipUl7f5rhv6sYSSlOWgdJF4oLhU=.9f599445-6b18-4b95-930f-9e434715fbf6@github.com> On Thu, 23 May 2024 08:59:12 GMT, Liang Mao wrote: > Backport of fixing range check of ZYoungCompactionLimit. This pull request has now been integrated. Changeset: ca393c83 Author: Liang Mao Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/ca393c836b1ffc433e0b26929e67199fd195e992 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8330576: ZYoungCompactionLimit should have range check Backport-of: c4f5c5140a85818152c6e17414a36deabe491f7b ------------- PR: https://git.openjdk.org/jdk22u/pull/220 From stefank at openjdk.org Wed May 29 07:32:02 2024 From: stefank at openjdk.org (Stefan Karlsson) Date: Wed, 29 May 2024 07:32:02 GMT Subject: [jdk22u] RFR: 8330275: Crash in XMark::follow_array In-Reply-To: <3KqDzS3pRPJVH5ZmBONeP4J5Oe9SNna4ZxpIGWU9q-w=.92f6d88b-ce3a-42b9-b33c-44c9da3fd996@github.com> References: <3KqDzS3pRPJVH5ZmBONeP4J5Oe9SNna4ZxpIGWU9q-w=.92f6d88b-ce3a-42b9-b33c-44c9da3fd996@github.com> Message-ID: On Tue, 28 May 2024 17:29:19 GMT, Ashutosh Mehra wrote: > Backport of [JDK-8330275](https://bugs.openjdk.org/browse/JDK-8330275) to fix crash in ZGC. This backports the incorrect comment from the original changeset. Don't you want to update them before pushing? ------------- Marked as reviewed by stefank (Reviewer). PR Review: https://git.openjdk.org/jdk22u/pull/226#pullrequestreview-2084528904 From stefank at openjdk.org Wed May 29 07:56:07 2024 From: stefank at openjdk.org (Stefan Karlsson) Date: Wed, 29 May 2024 07:56:07 GMT Subject: [jdk21u-dev] RFR: 8333093: Incorrect comment in zAddress_aarch64.cpp In-Reply-To: References: Message-ID: On Tue, 28 May 2024 18:39:05 GMT, Ashutosh Mehra wrote: > Hi all, > > This pull request contains a backport of commit [51ae08f7](https://github.com/openjdk/jdk/commit/51ae08f72b879bc611177ea643cd88e36185d9e8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Ashutosh Mehra on 28 May 2024 and was reviewed by Stefan Karlsson. > > It is a trivial change to fix the comments. > > Thanks! Marked as reviewed by stefank (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/613#pullrequestreview-2084592254 From clanger at openjdk.org Wed May 29 08:13:09 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 29 May 2024 08:13:09 GMT Subject: [jdk21u-dev] Integrated: 8331266: Bump update version for OpenJDK: jdk-21.0.5 In-Reply-To: References: Message-ID: On Mon, 27 May 2024 22:15:06 GMT, Christoph Langer wrote: > Bump version for 21.0.5 This pull request has now been integrated. Changeset: b7c70068 Author: Christoph Langer URL: https://git.openjdk.org/jdk21u-dev/commit/b7c70068972049a9c0900141afba9b47b38c718e Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8331266: Bump update version for OpenJDK: jdk-21.0.5 Reviewed-by: mdoerr, sgehwolf ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/605 From clanger at openjdk.org Wed May 29 08:44:12 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 29 May 2024 08:44:12 GMT Subject: [jdk17u-dev] Integrated: 8331265: Bump update version for OpenJDK: jdk-17.0.13 In-Reply-To: References: Message-ID: On Mon, 27 May 2024 22:22:30 GMT, Christoph Langer wrote: > Version bump 17.0.13 This pull request has now been integrated. Changeset: 1ead7a7f Author: Christoph Langer URL: https://git.openjdk.org/jdk17u-dev/commit/1ead7a7fdeb6ddbbe3ad0896b7d492929ef9b7a3 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8331265: Bump update version for OpenJDK: jdk-17.0.13 Reviewed-by: mdoerr, sgehwolf ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2498 From clanger at openjdk.org Wed May 29 08:54:07 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 29 May 2024 08:54:07 GMT Subject: [jdk11u-dev] Integrated: 8331263: Bump update version for OpenJDK: jdk-11.0.25 In-Reply-To: References: Message-ID: On Mon, 27 May 2024 22:37:09 GMT, Christoph Langer wrote: > Bump for 11.0.25 This pull request has now been integrated. Changeset: c35d30d6 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/c35d30d6fecabcb10cd2011fca39ddee219337b0 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod 8331263: Bump update version for OpenJDK: jdk-11.0.25 Reviewed-by: mdoerr, sgehwolf ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/2727 From sgehwolf at openjdk.org Wed May 29 09:26:04 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 29 May 2024 09:26:04 GMT Subject: [jdk21u-dev] RFR: 8333093: Incorrect comment in zAddress_aarch64.cpp In-Reply-To: References: Message-ID: On Tue, 28 May 2024 18:39:05 GMT, Ashutosh Mehra wrote: > Hi all, > > This pull request contains a backport of commit [51ae08f7](https://github.com/openjdk/jdk/commit/51ae08f72b879bc611177ea643cd88e36185d9e8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Ashutosh Mehra on 28 May 2024 and was reviewed by Stefan Karlsson. > > It is a trivial change to fix the comments. > > Thanks! Please create a `jdk22u` backport as well to keep it in sync. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/613#issuecomment-2136951556 From clanger at openjdk.org Wed May 29 09:36:05 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 29 May 2024 09:36:05 GMT Subject: [jdk21u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: References: Message-ID: <5ks7XwpgCoSKpilewOYPtG8h2iOh4rMK7TZIrbYLOhk=.74939de8-c0cf-4509-ac6a-4077776a66c7@github.com> On Mon, 13 May 2024 09:03:48 GMT, Aleksey Shipilev wrote: > Too early for 21u-dev anyway; there are follow-up improvements that we want to resolve first, and then backport all of them at once, so that JDK 21 is not in some intermediate state. Rampdown for 21.0.4 started. So, @shipilev, is it time now to approve this for 21.0.5 or shall we wait? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/560#issuecomment-2136972165 From lmao at openjdk.org Wed May 29 09:39:04 2024 From: lmao at openjdk.org (Liang Mao) Date: Wed, 29 May 2024 09:39:04 GMT Subject: [jdk21u-dev] RFR: 8330576: ZYoungCompactionLimit should have range check In-Reply-To: References: Message-ID: On Thu, 23 May 2024 08:57:14 GMT, Liang Mao wrote: > Backport of fixing range check of ZYoungCompactionLimit. Hi, could committers please help to sponsor? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/597#issuecomment-2136976677 From syan at openjdk.org Wed May 29 09:41:10 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 29 May 2024 09:41:10 GMT Subject: [jdk21u-dev] RFR: 8318479: [jmh] the test security.CacheBench failed for multiple threads run In-Reply-To: References: Message-ID: On Tue, 28 May 2024 03:34:13 GMT, SendaoYan wrote: > Hi all, > This is backport parity with 21.0.5-oracle, remove the hardcoded maximum heap size, to avoid OOM fail with 100+ threads. Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/606#issuecomment-2136980946 From syan at openjdk.org Wed May 29 09:42:07 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 29 May 2024 09:42:07 GMT Subject: [jdk21u-dev] RFR: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM In-Reply-To: References: Message-ID: On Thu, 23 May 2024 01:37:00 GMT, SendaoYan wrote: > Hi all, > This clean backport of [JDK-8332490](https://bugs.openjdk.org/browse/JDK-8332490), to closes the InflaterInputStream when the reads complete. The change has been verified. Only change the JMH testcase, no risk. Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/596#issuecomment-2136984154 From shade at openjdk.org Wed May 29 09:42:04 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 29 May 2024 09:42:04 GMT Subject: [jdk21u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: References: Message-ID: <9PBix-WlwGJ-C6uYYf-yFAiFTJdDwBOjEIY0oFD9gQY=.6753e10c-1ee5-471f-a0ca-140ac053cb5a@github.com> On Mon, 13 May 2024 09:03:48 GMT, Aleksey Shipilev wrote: >> Clean backport of fixing rare long hand shake while mutator threads in heavy contention on ShenandoahLock. >> >> Additional testing: >> - [x] Linux aarch64 server fastdebug, hotspot/jtreg/tier1 with +UseShenandoahGC > > Too early for 21u-dev anyway; there are follow-up improvements that we want to resolve first, and then backport all of them at once, so that JDK 21 is not in some intermediate state. > Rampdown for 21.0.4 started. So, @shipilev, is it time now to approve this for 21.0.5 or shall we wait? We are working on [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411), I would instead prefer wait for that to complete and then backport both back to back. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/560#issuecomment-2136983553 From christoph.langer at sap.com Wed May 29 10:05:04 2024 From: christoph.langer at sap.com (Langer, Christoph) Date: Wed, 29 May 2024 10:05:04 +0000 Subject: [21u, 17u, 11u communication] Update releases for 21.0.4, 17.0.12 and 11.0.24 now in rampdown Message-ID: Hi, as per the communicated timelines ([0], [1], [2]), the upcoming OpenJDK July 2024 update releases are now in rampdown. That means pull requests to the jdk21u, jdk17u or jdk11u repository and jdk<*>u-critical-request labels are now needed for (important) late fixes to these shipments. The jdk21u-dev, jdk17u-dev and jdk11u-dev repositories are now open for commits targeting the October 2024 updates 21.0.5, 17.0.13 and 11.0.25. Cheers Christoph [0] https://wiki.openjdk.org/display/JDKUpdates/JDK+21u [1] https://wiki.openjdk.org/display/JDKUpdates/JDK+17u [2] https://wiki.openjdk.org/display/JDKUpdates/JDK11u -------------- next part -------------- An HTML attachment was scrubbed... URL: From clanger at openjdk.org Wed May 29 10:09:02 2024 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 29 May 2024 10:09:02 GMT Subject: [jdk21u-dev] RFR: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM In-Reply-To: <9PBix-WlwGJ-C6uYYf-yFAiFTJdDwBOjEIY0oFD9gQY=.6753e10c-1ee5-471f-a0ca-140ac053cb5a@github.com> References: <9PBix-WlwGJ-C6uYYf-yFAiFTJdDwBOjEIY0oFD9gQY=.6753e10c-1ee5-471f-a0ca-140ac053cb5a@github.com> Message-ID: On Wed, 29 May 2024 09:39:37 GMT, Aleksey Shipilev wrote: > > Rampdown for 21.0.4 started. So, @shipilev, is it time now to approve this for 21.0.5 or shall we wait? > > We are working on [JDK-8331411](https://bugs.openjdk.org/browse/JDK-8331411), I would instead prefer wait for that to complete and then backport both back to back. OK, then I'll remove the fix-request label for now. Please re-request when this is ready. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/560#issuecomment-2137040247 From mdoerr at openjdk.org Wed May 29 10:15:04 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 29 May 2024 10:15:04 GMT Subject: [jdk17u-dev] RFR: 8315362: NMT: summary diff reports threads count incorrectly [v2] In-Reply-To: References: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> Message-ID: On Tue, 28 May 2024 11:44:36 GMT, Evgeny Ignatenko wrote: >> 8315362: NMT: summary diff reports threads count incorrectly > > Evgeny Ignatenko has updated the pull request incrementally with one additional commit since the last revision: > > Fix inconsistency with patch at jdk21 Both PRs got maintainer approval. Please change to "Baseline taken" once https://github.com/openjdk/jdk17u-dev/pull/2415 is integrated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2084#issuecomment-2137051707 From mdoerr at openjdk.org Wed May 29 10:28:11 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 29 May 2024 10:28:11 GMT Subject: [jdk17u-dev] Integrated: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader In-Reply-To: References: Message-ID: On Wed, 15 May 2024 10:44:58 GMT, Martin Doerr wrote: > Clean backport of [JDK-8308144](https://bugs.openjdk.org/browse/JDK-8308144). This pull request has now been integrated. Changeset: cc3f0e52 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/cc3f0e52bfee9d96c464ae55999e834717aa3772 Stats: 662 lines in 3 files changed: 642 ins; 0 del; 20 mod 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader Backport-of: 099a8f5b2f924fddd43ff72f3f7c6f34b6c15b0f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2472 From mdoerr at openjdk.org Wed May 29 10:30:08 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 29 May 2024 10:30:08 GMT Subject: [jdk17u-dev] Integrated: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation In-Reply-To: References: Message-ID: On Mon, 27 May 2024 15:36:49 GMT, Martin Doerr wrote: > Basically clean backport of [JDK-8313873](https://bugs.openjdk.org/browse/JDK-8313873). This pull request has now been integrated. Changeset: 24aa1e1f Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/24aa1e1f1835c83cbf5cfeda56186511a3bd0100 Stats: 36 lines in 2 files changed: 27 ins; 3 del; 6 mod 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation Backport-of: 486fa08d4b22243443d39efa34c78d7e9eb44775 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2496 From duke at openjdk.org Wed May 29 10:31:13 2024 From: duke at openjdk.org (Rinku Kumar Maurya) Date: Wed, 29 May 2024 10:31:13 GMT Subject: [jdk17u-dev] Integrated: 8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant" In-Reply-To: <6p2GXeiaitURhthFgjjfqEFtZhqf3ta63UxvQ8Qc834=.1bc254c1-b873-46ce-a445-1d9e4f62ed66@github.com> References: <6p2GXeiaitURhthFgjjfqEFtZhqf3ta63UxvQ8Qc834=.1bc254c1-b873-46ce-a445-1d9e4f62ed66@github.com> Message-ID: On Tue, 28 May 2024 15:18:58 GMT, Rinku Kumar Maurya wrote: > clean backport to remove assertion which asserts artifact is not serialized and assumes only `JfrRecorderThread` can perform serialization of artifacts marked during the window between rotate() and end_recording(), which is not true because a GC thread during class unloading process will serialize the class loaders associated with the unloaded classes. We should remove this assertion and let the code fall through and explicitly clear the serialize and transient meta bits. This pull request has now been integrated. Changeset: 787cf27a Author: Rinku Kumar Maurya Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/787cf27a8bb19c58bfa5bd17bf433ddaa99117d7 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod 8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant" Backport-of: ffa34ed429079827c9b0acb843288fde4b7fa53d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2504 From syan at openjdk.org Wed May 29 10:32:05 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 29 May 2024 10:32:05 GMT Subject: [jdk21u-dev] Integrated: 8318479: [jmh] the test security.CacheBench failed for multiple threads run In-Reply-To: References: Message-ID: On Tue, 28 May 2024 03:34:13 GMT, SendaoYan wrote: > Hi all, > This is backport parity with 21.0.5-oracle, remove the hardcoded maximum heap size, to avoid OOM fail with 100+ threads. This pull request has now been integrated. Changeset: 9fcb4cdd Author: SendaoYan Committer: Christoph Langer URL: https://git.openjdk.org/jdk21u-dev/commit/9fcb4cdd5dd47e1679d660d4c90d6a1938552b0b Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8318479: [jmh] the test security.CacheBench failed for multiple threads run Backport-of: 1535528cb119195b44244e8ee6bc0f913caa9270 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/606 From lmao at openjdk.org Wed May 29 10:32:06 2024 From: lmao at openjdk.org (Liang Mao) Date: Wed, 29 May 2024 10:32:06 GMT Subject: [jdk21u-dev] Integrated: 8330576: ZYoungCompactionLimit should have range check In-Reply-To: References: Message-ID: On Thu, 23 May 2024 08:57:14 GMT, Liang Mao wrote: > Backport of fixing range check of ZYoungCompactionLimit. This pull request has now been integrated. Changeset: a3b14cfc Author: Liang Mao Committer: Christoph Langer URL: https://git.openjdk.org/jdk21u-dev/commit/a3b14cfcb219a5b4407c8e6ea8f388162925adfa Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8330576: ZYoungCompactionLimit should have range check Backport-of: c4f5c5140a85818152c6e17414a36deabe491f7b ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/597 From syan at openjdk.org Wed May 29 10:32:08 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 29 May 2024 10:32:08 GMT Subject: [jdk21u-dev] Integrated: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM In-Reply-To: References: Message-ID: On Thu, 23 May 2024 01:37:00 GMT, SendaoYan wrote: > Hi all, > This clean backport of [JDK-8332490](https://bugs.openjdk.org/browse/JDK-8332490), to closes the InflaterInputStream when the reads complete. The change has been verified. Only change the JMH testcase, no risk. This pull request has now been integrated. Changeset: 171a4c6a Author: SendaoYan Committer: Christoph Langer URL: https://git.openjdk.org/jdk21u-dev/commit/171a4c6ab626dc4d50996c9e635ddcf39e21aa60 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM Backport-of: 98f6a80852383dcbdad7292b7d269a8547d54d45 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/596 From syan at openjdk.org Wed May 29 10:39:02 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 29 May 2024 10:39:02 GMT Subject: [jdk17u-dev] RFR: 8288568: Reduce runtime of java.security microbenchmarks In-Reply-To: References: Message-ID: On Tue, 28 May 2024 03:22:41 GMT, SendaoYan wrote: > Hi all, > I backport this parity with 17.0.13-oracle. Only change the jmh testcases, the risk is low. Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2499#issuecomment-2137094770 From syan at openjdk.org Wed May 29 10:40:04 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 29 May 2024 10:40:04 GMT Subject: [jdk21u-dev] RFR: 8318479: [jmh] the test security.CacheBench failed for multiple threads run In-Reply-To: References: Message-ID: On Tue, 28 May 2024 03:34:13 GMT, SendaoYan wrote: > Hi all, > This is backport parity with 21.0.5-oracle, remove the hardcoded maximum heap size, to avoid OOM fail with 100+ threads. > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/606#issuecomment-2137096353 From syan at openjdk.org Wed May 29 10:40:04 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 29 May 2024 10:40:04 GMT Subject: [jdk21u-dev] RFR: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM In-Reply-To: References: Message-ID: <-0c50CVsQN_tNubr3-4kEdJY--1HwaD3Ca56cF0wEIw=.67ff45bd-08cc-4601-8f39-5319d3d29d43@github.com> On Thu, 23 May 2024 01:37:00 GMT, SendaoYan wrote: > Hi all, > This clean backport of [JDK-8332490](https://bugs.openjdk.org/browse/JDK-8332490), to closes the InflaterInputStream when the reads complete. The change has been verified. Only change the JMH testcase, no risk. > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/596#issuecomment-2137096660 From shade at openjdk.org Wed May 29 11:47:04 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 29 May 2024 11:47:04 GMT Subject: [jdk21u-dev] Integrated: 8331714: Make OopMapCache installation lock-free In-Reply-To: References: Message-ID: On Tue, 28 May 2024 08:54:54 GMT, Aleksey Shipilev wrote: > Clean backport to improve internal locking. Also makes future backports clean. > > Additional testing: > - [x] Linux x86_64 fastdebug `all` This pull request has now been integrated. Changeset: fb7713d3 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/fb7713d3dd7c4181088b4201994cad836ba774a7 Stats: 12 lines in 3 files changed: 1 ins; 3 del; 8 mod 8331714: Make OopMapCache installation lock-free Backport-of: a2584a8341b2dc9c102abd373a890b2108d3f57e ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/608 From shade at openjdk.org Wed May 29 11:55:36 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 29 May 2024 11:55:36 GMT Subject: [jdk17u-dev] RFR: 8318986: Improve GenericWaitBarrier performance [v2] In-Reply-To: References: Message-ID: > Clean backport to drastically improve safepoint performance under heavy load, fixing regression between JDK 11 and JDK 17. > > Additional testing: > - [x] Ad-hoc performance runs, expected improvements > - [x] MacOS AArch64 server fastdebug, `tier{1,2,3}` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into JDK-8318986-generic-wait-barrier - Merge branch 'master' into JDK-8318986-generic-wait-barrier - Backport 30462f9da40d3a7ec18fcf46e2154fabb5fd4753 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2041/files - new: https://git.openjdk.org/jdk17u-dev/pull/2041/files/5db67531..6a7c9ca7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2041&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2041&range=00-01 Stats: 38087 lines in 1057 files changed: 15394 ins; 19097 del; 3596 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2041.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2041/head:pull/2041 PR: https://git.openjdk.org/jdk17u-dev/pull/2041 From syan at openjdk.org Wed May 29 12:49:04 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 29 May 2024 12:49:04 GMT Subject: [jdk17u-dev] RFR: 8288568: Reduce runtime of java.security microbenchmarks In-Reply-To: References: Message-ID: On Tue, 28 May 2024 03:22:41 GMT, SendaoYan wrote: > Hi all, > I backport this parity with 17.0.13-oracle. Only change the jmh testcases, the risk is low. > /sponsor Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2499#issuecomment-2137330654 From lyang at openjdk.org Wed May 29 12:49:07 2024 From: lyang at openjdk.org (Long Yang) Date: Wed, 29 May 2024 12:49:07 GMT Subject: [jdk17u-dev] Integrated: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate In-Reply-To: <8yDsUnG0HQVsCakGSjitm-ErWQvnkmKQqaF_cPGilEY=.20cc85c6-7e45-4256-b995-32034141df9c@github.com> References: <8yDsUnG0HQVsCakGSjitm-ErWQvnkmKQqaF_cPGilEY=.20cc85c6-7e45-4256-b995-32034141df9c@github.com> Message-ID: On Fri, 8 Mar 2024 07:38:57 GMT, Long Yang wrote: > Hi, all > > Could I have a review of this backport. > > This pull request contains a backport of commit [8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb](https://github.com/openjdk/jdk/commit/8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > Testing: I ran test/jdk/jdk/jfr/event/os/TestCPULoad.java and passed. All GHA tests are passed (except linux-cross-compile, build(riscv64), Create sysroot. It looks like there's an issue with the GHA's process). This pull request has now been integrated. Changeset: 2d834b36 Author: Long Yang Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/2d834b36ec68890befc21d93b667d07cbf3c007a Stats: 40 lines in 1 file changed: 6 ins; 12 del; 22 mod 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate Reviewed-by: phh Backport-of: 8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2277 From syan at openjdk.org Wed May 29 12:49:05 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 29 May 2024 12:49:05 GMT Subject: [jdk17u-dev] Integrated: 8288568: Reduce runtime of java.security microbenchmarks In-Reply-To: References: Message-ID: On Tue, 28 May 2024 03:22:41 GMT, SendaoYan wrote: > Hi all, > I backport this parity with 17.0.13-oracle. Only change the jmh testcases, the risk is low. This pull request has now been integrated. Changeset: e85eecbe Author: SendaoYan Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/e85eecbea09e68fcac68a39901a58ddf41fa9dbd Stats: 49 lines in 10 files changed: 25 ins; 3 del; 21 mod 8288568: Reduce runtime of java.security microbenchmarks Backport-of: a28ab7b62abcfce56425d62d5a8162d8f1623393 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2499 From syan at openjdk.org Wed May 29 12:58:15 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 29 May 2024 12:58:15 GMT Subject: [jdk17u-dev] RFR: 8318479: [jmh] the test security.CacheBench failed for multiple threads run [v2] In-Reply-To: References: Message-ID: <7q3jVXzXvVVkU83BYzLaxU42s_x9c5WM0e7K8W4p2Mg=.0edb8e09-77b2-46bc-9a34-0216cc88c02a@github.com> > Hi all, > This is backport of [JDK-8318479](https://bugs.openjdk.org/browse/JDK-8318479) parity with 17.0.13-oracle, which remove the hardcoded maximum heap size, to avoid OOM fail with 100+ threads. > It's not clean because of it has a prefixed bakport [JDK-8288568](https://github.com/openjdk/jdk17u-dev/pull/2499) > Only change the jmh testcase, no risk. SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 1535528cb119195b44244e8ee6bc0f913caa9270 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/2500/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2500&range=01 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2500.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2500/head:pull/2500 PR: https://git.openjdk.org/jdk17u-dev/pull/2500 From fmatte at openjdk.org Wed May 29 13:06:30 2024 From: fmatte at openjdk.org (Fairoz Matte) Date: Wed, 29 May 2024 13:06:30 GMT Subject: [jdk22u] RFR: 8331885: C2: meet between unloaded and speculative types is not symmetric Message-ID: 8331885: C2: meet between unloaded and speculative types is not symmetric Reviewed-by: roland, thartmann ------------- Commit messages: - 8331885: C2: meet between unloaded and speculative types is not symmetric Changes: https://git.openjdk.org/jdk22u/pull/228/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=228&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331885 Stats: 20 lines in 3 files changed: 12 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk22u/pull/228.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/228/head:pull/228 PR: https://git.openjdk.org/jdk22u/pull/228 From syan at openjdk.org Wed May 29 13:08:08 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 29 May 2024 13:08:08 GMT Subject: [jdk17u-dev] RFR: 8318479: [jmh] the test security.CacheBench failed for multiple threads run [v2] In-Reply-To: <7q3jVXzXvVVkU83BYzLaxU42s_x9c5WM0e7K8W4p2Mg=.0edb8e09-77b2-46bc-9a34-0216cc88c02a@github.com> References: <7q3jVXzXvVVkU83BYzLaxU42s_x9c5WM0e7K8W4p2Mg=.0edb8e09-77b2-46bc-9a34-0216cc88c02a@github.com> Message-ID: On Wed, 29 May 2024 12:58:15 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8318479](https://bugs.openjdk.org/browse/JDK-8318479) parity with 17.0.13-oracle, which remove the hardcoded maximum heap size, to avoid OOM fail with 100+ threads. >> It's not clean because of it has a prefixed bakport [JDK-8288568](https://github.com/openjdk/jdk17u-dev/pull/2499) >> Only change the jmh testcase, no risk. > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Backport 1535528cb119195b44244e8ee6bc0f913caa9270 Duplicate to https://github.com/openjdk/jdk17u-dev/pull/2506. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2500#issuecomment-2137369267 From syan at openjdk.org Wed May 29 13:08:09 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 29 May 2024 13:08:09 GMT Subject: [jdk17u-dev] Withdrawn: 8318479: [jmh] the test security.CacheBench failed for multiple threads run In-Reply-To: References: Message-ID: On Tue, 28 May 2024 03:53:32 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8318479](https://bugs.openjdk.org/browse/JDK-8318479) parity with 17.0.13-oracle, which remove the hardcoded maximum heap size, to avoid OOM fail with 100+ threads. > It's not clean because of it has a prefixed bakport [JDK-8288568](https://github.com/openjdk/jdk17u-dev/pull/2499) > Only change the jmh testcase, no risk. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2500 From syan at openjdk.org Wed May 29 13:08:26 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 29 May 2024 13:08:26 GMT Subject: [jdk17u-dev] RFR: 8318479: [jmh] the test security.CacheBench failed for multiple threads run Message-ID: Hi all, This is backport of [JDK-8318479](https://bugs.openjdk.org/browse/JDK-8318479) parity with 17.0.13-oracle, which remove the hardcoded maximum heap size, to avoid OOM fail with 100+ threads. Only change the jmh testcase, no risk. ------------- Commit messages: - Backport 1535528cb119195b44244e8ee6bc0f913caa9270 Changes: https://git.openjdk.org/jdk17u-dev/pull/2506/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2506&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318479 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2506.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2506/head:pull/2506 PR: https://git.openjdk.org/jdk17u-dev/pull/2506 From mdoerr at openjdk.org Wed May 29 13:31:04 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 29 May 2024 13:31:04 GMT Subject: [jdk17u-dev] RFR: 8289182: NMT: MemTracker::baseline should return void In-Reply-To: References: Message-ID: On Tue, 16 Apr 2024 13:48:00 GMT, Mar?a Arias de Reyna wrote: > This backport does not introduce any new feature or bug fixing, but it removes dead code. Before the backport, MemTracker::baseline() always returned true. Now, it returns void and all the conditionals that depended on that result are simplified. This one is ready for integration. Another PR is waiting for it. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2415#issuecomment-2137419036 From asmehra at openjdk.org Wed May 29 13:46:06 2024 From: asmehra at openjdk.org (Ashutosh Mehra) Date: Wed, 29 May 2024 13:46:06 GMT Subject: [jdk22u] RFR: 8330275: Crash in XMark::follow_array In-Reply-To: References: <3KqDzS3pRPJVH5ZmBONeP4J5Oe9SNna4ZxpIGWU9q-w=.92f6d88b-ce3a-42b9-b33c-44c9da3fd996@github.com> Message-ID: On Wed, 29 May 2024 07:29:49 GMT, Stefan Karlsson wrote: > This backports the incorrect comment from the original changeset. Don't you want to update them before pushing? The comments were fixed in separate PR which I am going to backport as well. ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/226#issuecomment-2137452944 From duke at openjdk.org Wed May 29 13:53:04 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Wed, 29 May 2024 13:53:04 GMT Subject: [jdk17u-dev] RFR: 8289182: NMT: MemTracker::baseline should return void In-Reply-To: References: Message-ID: <2c5JWrqWjclRlcyWI-jNZ88jtL98yFRswT2voreF-LQ=.75e362dd-acce-46c7-8e75-130192d5c629@github.com> On Tue, 16 Apr 2024 13:48:00 GMT, Mar?a Arias de Reyna wrote: > This backport does not introduce any new feature or bug fixing, but it removes dead code. Before the backport, MemTracker::baseline() always returned true. Now, it returns void and all the conditionals that depended on that result are simplified. Ok :) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2415#issuecomment-2137467813 From duke at openjdk.org Wed May 29 13:58:05 2024 From: duke at openjdk.org (=?UTF-8?B?TWFyw61h?= Arias de Reyna) Date: Wed, 29 May 2024 13:58:05 GMT Subject: [jdk17u-dev] Integrated: 8289182: NMT: MemTracker::baseline should return void In-Reply-To: References: Message-ID: <8Ctzj25CrWROgKa1Zzc875wqWk4e-g4A2-ZI5J8e74w=.ffeec666-f93f-48fb-8d25-9fc466855945@github.com> On Tue, 16 Apr 2024 13:48:00 GMT, Mar?a Arias de Reyna wrote: > This backport does not introduce any new feature or bug fixing, but it removes dead code. Before the backport, MemTracker::baseline() always returned true. Now, it returns void and all the conditionals that depended on that result are simplified. This pull request has now been integrated. Changeset: 8faeefc1 Author: Mar?a Arias de Reyna Committer: Thomas Stuefe URL: https://git.openjdk.org/jdk17u-dev/commit/8faeefc1509a5b890bdae852472c318c64dc0772 Stats: 47 lines in 8 files changed: 0 ins; 11 del; 36 mod 8289182: NMT: MemTracker::baseline should return void Backport-of: b96ba19807845739b36274efb168dd048db819a3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2415 From mdoerr at openjdk.org Wed May 29 14:00:29 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 29 May 2024 14:00:29 GMT Subject: [jdk21u-dev] RFR: 8326106: Write and clear stack trace table outside of safepoint Message-ID: <_pRL95LV9P4wjMaelSboQb3iEm4AC9H5O7q_qDSN2U0=.94220f25-8ed4-41df-8035-7230b7c65d4e@github.com> Clean backport of [JDK-8326106](https://bugs.openjdk.org/browse/JDK-8326106). ------------- Commit messages: - Backport a776104e210db212c4e32894844d3c0cbaac53c3 Changes: https://git.openjdk.org/jdk21u-dev/pull/615/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=615&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326106 Stats: 17 lines in 3 files changed: 4 ins; 7 del; 6 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/615.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/615/head:pull/615 PR: https://git.openjdk.org/jdk21u-dev/pull/615 From asmehra at openjdk.org Wed May 29 14:02:06 2024 From: asmehra at openjdk.org (Ashutosh Mehra) Date: Wed, 29 May 2024 14:02:06 GMT Subject: [jdk21u-dev] Integrated: 8333093: Incorrect comment in zAddress_aarch64.cpp In-Reply-To: References: Message-ID: <_CjLgPtFjfxhtJWNZpEsD6RdtmXIuDuGLkkOPDZTSJg=.10c59179-5290-4d4e-a5b3-cc93712e74f1@github.com> On Tue, 28 May 2024 18:39:05 GMT, Ashutosh Mehra wrote: > Hi all, > > This pull request contains a backport of commit [51ae08f7](https://github.com/openjdk/jdk/commit/51ae08f72b879bc611177ea643cd88e36185d9e8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Ashutosh Mehra on 28 May 2024 and was reviewed by Stefan Karlsson. > > It is a trivial change to fix the comments. > > Thanks! This pull request has now been integrated. Changeset: aa66422e Author: Ashutosh Mehra Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/aa66422e3acc804e85f3b0dd6662f75040004a96 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8333093: Incorrect comment in zAddress_aarch64.cpp Reviewed-by: stefank Backport-of: 51ae08f72b879bc611177ea643cd88e36185d9e8 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/613 From duke at openjdk.org Wed May 29 14:04:39 2024 From: duke at openjdk.org (Evgeny Ignatenko) Date: Wed, 29 May 2024 14:04:39 GMT Subject: [jdk17u-dev] RFR: 8315362: NMT: summary diff reports threads count incorrectly [v3] In-Reply-To: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> References: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> Message-ID: > 8315362: NMT: summary diff reports threads count incorrectly Evgeny Ignatenko has updated the pull request incrementally with one additional commit since the last revision: Adjust test to make it clean backport ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2084/files - new: https://git.openjdk.org/jdk17u-dev/pull/2084/files/fbe0e219..afc89786 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2084&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2084&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2084.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2084/head:pull/2084 PR: https://git.openjdk.org/jdk17u-dev/pull/2084 From duke at openjdk.org Wed May 29 14:11:35 2024 From: duke at openjdk.org (Evgeny Ignatenko) Date: Wed, 29 May 2024 14:11:35 GMT Subject: [jdk17u-dev] RFR: 8315362: NMT: summary diff reports threads count incorrectly [v4] In-Reply-To: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> References: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> Message-ID: <29geqiegEUHtoQCR4yX3Eba10K48d9RJZ6sA5xP7EBQ=.c147fb4d-8a66-4b00-b621-427c41239cde@github.com> > 8315362: NMT: summary diff reports threads count incorrectly Evgeny Ignatenko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge master - Adjust test to make it clean backport - Fix inconsistency with patch at jdk21 - Backport 37aed6f46d19a48b7bceffde61b529a69a6abf54 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/2084/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2084&range=03 Stats: 86 lines in 5 files changed: 73 ins; 11 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2084.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2084/head:pull/2084 PR: https://git.openjdk.org/jdk17u-dev/pull/2084 From duke at openjdk.org Wed May 29 14:16:05 2024 From: duke at openjdk.org (Evgeny Ignatenko) Date: Wed, 29 May 2024 14:16:05 GMT Subject: [jdk17u-dev] RFR: 8315362: NMT: summary diff reports threads count incorrectly [v2] In-Reply-To: References: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> Message-ID: On Wed, 29 May 2024 10:12:18 GMT, Martin Doerr wrote: >> Evgeny Ignatenko has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix inconsistency with patch at jdk21 > > Both PRs got maintainer approval. Please change to "Baseline taken" once https://github.com/openjdk/jdk17u-dev/pull/2415 is integrated. @TheRealMDoerr test is adjusted ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2084#issuecomment-2137521998 From mdoerr at openjdk.org Wed May 29 14:41:09 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 29 May 2024 14:41:09 GMT Subject: [jdk17u-dev] RFR: 8293798: Fix test bugs due to incompatibility with -XX:+AlwaysIncrementalInline Message-ID: Backport of [JDK-8293798](https://bugs.openjdk.org/browse/JDK-8293798). Skipped Decompile.java which belongs to [JDK-8275908](https://bugs.openjdk.java.net/browse/JDK-8275908) which is not in 17. ------------- Commit messages: - Backport 12e3510f63b46db1559d240a331d66f15fe91363 Changes: https://git.openjdk.org/jdk17u-dev/pull/2508/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2508&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293798 Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2508.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2508/head:pull/2508 PR: https://git.openjdk.org/jdk17u-dev/pull/2508 From mdoerr at openjdk.org Wed May 29 15:04:39 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 29 May 2024 15:04:39 GMT Subject: [jdk21u-dev] RFR: 8312229: Crash involving yield, switch and anonymous classes Message-ID: <6N_SqFMAcPPdpe_Ev6bnxcGLAqwGUF0i69wnYpHq0Nw=.2e8f21be-b4dc-44d1-b572-ff386e416787@github.com> Clean backport of [JDK-8312229](https://bugs.openjdk.org/browse/JDK-8312229). ------------- Commit messages: - Backport 1f81e5b19ebfb7cd1b5a01d6cf79efda7e827c35 Changes: https://git.openjdk.org/jdk21u-dev/pull/616/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=616&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312229 Stats: 53 lines in 2 files changed: 51 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/616.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/616/head:pull/616 PR: https://git.openjdk.org/jdk21u-dev/pull/616 From mdoerr at openjdk.org Wed May 29 15:10:26 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 29 May 2024 15:10:26 GMT Subject: [jdk21u-dev] RFR: 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04 Message-ID: Basically clean backport of [JDK-8305825](https://bugs.openjdk.org/browse/JDK-8305825). Skipped these removals from the ProblemList because they are not problem listed in 21: javax/swing/JTree/8003400/Test8003400.java 8309734 linux-all javax/swing/JTable/7124218/SelectEditTableCell.java 8309734 linux-all javax/swing/JFileChooser/JFileChooserSetLocationTest.java 8309734 linux-all ------------- Commit messages: - Backport 632a3c56e0626b4c4f79c8cb3d2ae312668d63fc Changes: https://git.openjdk.org/jdk21u-dev/pull/617/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=617&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305825 Stats: 39 lines in 8 files changed: 23 ins; 3 del; 13 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/617.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/617/head:pull/617 PR: https://git.openjdk.org/jdk21u-dev/pull/617 From duke at openjdk.org Wed May 29 15:53:21 2024 From: duke at openjdk.org (Antonio Vieiro) Date: Wed, 29 May 2024 15:53:21 GMT Subject: [jdk11u-dev] RFR: 8240226: DeflateIn_InflateOut.java test incorrectly assumes size of compressed file Message-ID: A backport of https://bugs.openjdk.org/browse/JDK-8240226 JDK-8240226 contains a small fix to `DeflateIn_InflateOut.java` that makes the test pass when `--with-zlib=system` and the system zlib library is zlib-cloudflare. This fix is also required for the test to pass in Fedora 40 with the (system wide default) ZLib-ng library. Tested with both DEBUG and RELEASE builds in Fedora 40. Let me know if updating the copyright year is required. ------------- Commit messages: - Backport b38f3cf3bdde596c07c00106e8a60263ee6cb374 Changes: https://git.openjdk.org/jdk11u-dev/pull/2719/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2719&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8240226 Stats: 5 lines in 1 file changed: 2 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2719.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2719/head:pull/2719 PR: https://git.openjdk.org/jdk11u-dev/pull/2719 From mdoerr at openjdk.org Wed May 29 16:22:17 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 29 May 2024 16:22:17 GMT Subject: [jdk21u-dev] RFR: 8319773: Avoid inflating monitors when installing hash codes for LM_LIGHTWEIGHT Message-ID: Clean backport of [JDK-8319773](https://bugs.openjdk.org/browse/JDK-8319773). ------------- Commit messages: - Backport 65a0672791f868556776fc435b37319ed69f7c84 Changes: https://git.openjdk.org/jdk21u-dev/pull/618/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=618&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319773 Stats: 76 lines in 4 files changed: 29 ins; 23 del; 24 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/618.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/618/head:pull/618 PR: https://git.openjdk.org/jdk21u-dev/pull/618 From mdoerr at openjdk.org Wed May 29 16:33:28 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 29 May 2024 16:33:28 GMT Subject: [jdk21u-dev] RFR: 8324668: JDWP process management needs more efficient file descriptor handling Message-ID: Clean backport of [JDK-8324668](https://bugs.openjdk.org/browse/JDK-8324668). ------------- Commit messages: - Backport a6632487863db5ff3136cdcc76b7440c15ce6be9 Changes: https://git.openjdk.org/jdk21u-dev/pull/619/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=619&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324668 Stats: 121 lines in 1 file changed: 106 ins; 12 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/619.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/619/head:pull/619 PR: https://git.openjdk.org/jdk21u-dev/pull/619 From mdoerr at openjdk.org Wed May 29 16:38:16 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 29 May 2024 16:38:16 GMT Subject: [jdk21u-dev] RFR: 8323670: A few client tests intermittently throw ConcurrentModificationException Message-ID: Clean backport of [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670). ------------- Commit messages: - Backport 70e7cdcb9ecedd455cf701b5c7ad05286ac0067d Changes: https://git.openjdk.org/jdk21u-dev/pull/620/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=620&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323670 Stats: 48 lines in 1 file changed: 6 ins; 4 del; 38 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/620.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/620/head:pull/620 PR: https://git.openjdk.org/jdk21u-dev/pull/620 From duke at openjdk.org Wed May 29 18:17:31 2024 From: duke at openjdk.org (Elif Aslan) Date: Wed, 29 May 2024 18:17:31 GMT Subject: [jdk17u-dev] RFR: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time [v2] In-Reply-To: References: Message-ID: > Clean backport to fix ProcessTools.startProcess() bug. > > See original PR explanation [here](https://github.com/openjdk/jdk/pull/13594) > > I need this backport to be merged to able to complete [this](https://github.com/openjdk/jdk17u-dev/pull/2339) backport request. > > Additional testing: macos-x86_64-server-release tier2 Elif Aslan has updated the pull request incrementally with one additional commit since the last revision: backport of 64ac9a05e85020d24e33ba55cffa1bd9b269218a ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2456/files - new: https://git.openjdk.org/jdk17u-dev/pull/2456/files/6248f07e..eae13b4e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2456&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2456&range=00-01 Stats: 63 lines in 2 files changed: 29 ins; 18 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2456.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2456/head:pull/2456 PR: https://git.openjdk.org/jdk17u-dev/pull/2456 From duke at openjdk.org Wed May 29 18:17:31 2024 From: duke at openjdk.org (Elif Aslan) Date: Wed, 29 May 2024 18:17:31 GMT Subject: [jdk17u-dev] RFR: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time In-Reply-To: References: Message-ID: On Thu, 9 May 2024 16:32:05 GMT, Elif Aslan wrote: > Clean backport to fix ProcessTools.startProcess() bug. > > See original PR explanation [here](https://github.com/openjdk/jdk/pull/13594) > > I need this backport to be merged to able to complete [this](https://github.com/openjdk/jdk17u-dev/pull/2339) backport request. > > Additional testing: macos-x86_64-server-release tier2 Yes, JspawnhelperWarnings.java test passes when I apply the regarding commit. I ll add the issue here as well ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2456#issuecomment-2137995630 From serb at openjdk.org Wed May 29 20:57:05 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 29 May 2024 20:57:05 GMT Subject: [jdk21u-dev] Integrated: 8331746: Create a test to verify that the cmm id is not ignored In-Reply-To: <2yg20WCO75AzWSjqt6-dcoxg0bftF2P5CsjaIJWGoc8=.f889ad53-33be-41c7-ac8a-4002cd110dfa@github.com> References: <2yg20WCO75AzWSjqt6-dcoxg0bftF2P5CsjaIJWGoc8=.f889ad53-33be-41c7-ac8a-4002cd110dfa@github.com> Message-ID: <0H0kwrfYZcWA5XlV20nFcLGI4ZSmY7eRsBIUrUqNhDw=.16a9c97c-661d-4f6e-9b72-9c789140de49@github.com> On Fri, 17 May 2024 19:48:48 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [7c750fd9](https://github.com/openjdk/jdk/commit/7c750fd95b83d0a93b0cce681dcfbbae1f220fdd) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 17 May 2024 and was reviewed by Phil Race, Dmitry Markov and Alexey Ivanov. > > Thanks! This pull request has now been integrated. Changeset: 0d0cf839 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk21u-dev/commit/0d0cf83961fc82627ef3516b2dd3393b6530c8c1 Stats: 69 lines in 1 file changed: 69 ins; 0 del; 0 mod 8331746: Create a test to verify that the cmm id is not ignored Backport-of: 7c750fd95b83d0a93b0cce681dcfbbae1f220fdd ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/588 From duke at openjdk.org Wed May 29 22:25:29 2024 From: duke at openjdk.org (Xiaolong Peng) Date: Wed, 29 May 2024 22:25:29 GMT Subject: [jdk17u-dev] RFR: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC [v2] In-Reply-To: References: Message-ID: > 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision: Update full name ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/2474/files - new: https://git.openjdk.org/jdk17u-dev/pull/2474/files/214c6c1c..a5bbae4f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2474&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2474&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2474.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2474/head:pull/2474 PR: https://git.openjdk.org/jdk17u-dev/pull/2474 From duke at openjdk.org Wed May 29 22:25:36 2024 From: duke at openjdk.org (Xiaolong Peng) Date: Wed, 29 May 2024 22:25:36 GMT Subject: [jdk21u-dev] RFR: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC [v2] In-Reply-To: <2Kxv67UXNf7X4hFhoDZZR1dBP-gHQpNHckUzLs0rjrw=.3d94c1d3-bc7a-418b-8e53-148929d555bb@github.com> References: <2Kxv67UXNf7X4hFhoDZZR1dBP-gHQpNHckUzLs0rjrw=.3d94c1d3-bc7a-418b-8e53-148929d555bb@github.com> Message-ID: > 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision: Update full name ------------- Changes: - all: https://git.openjdk.org/jdk21u-dev/pull/575/files - new: https://git.openjdk.org/jdk21u-dev/pull/575/files/4435c6d6..c061eba9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=575&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=575&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/575.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/575/head:pull/575 PR: https://git.openjdk.org/jdk21u-dev/pull/575 From serb at openjdk.org Wed May 29 22:54:02 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 29 May 2024 22:54:02 GMT Subject: [jdk21u-dev] Integrated: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes In-Reply-To: References: Message-ID: On Fri, 24 May 2024 02:33:49 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [9b1d6d66](https://github.com/openjdk/jdk/commit/9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 23 May 2024 and was reviewed by Paul Hohensee, Aleksey Shipilev and Erik Gahlin. > > Thanks! This pull request has now been integrated. Changeset: 56fdca38 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk21u-dev/commit/56fdca38bc7cd4af852a461931e280c9595c5a4e Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes Backport-of: 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/600 From phh at openjdk.org Thu May 30 00:07:04 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 30 May 2024 00:07:04 GMT Subject: [jdk17u-dev] RFR: 8303942: os::write should write completely [v2] In-Reply-To: References: Message-ID: <_cHdMEoOi8T9VXfnzPp8xejnBJyquVFIfTRDGInbJF8=.6dc4c3e1-9880-4bfb-8c04-5bee07a180b3@github.com> On Tue, 28 May 2024 18:57:27 GMT, Elif Aslan wrote: >> This is not a clean backport. There were multiple merge conflicts related to undefined parameters and existing methods. This backport is required to address a crash observed in Amazon production. Please refer to the related [PR](https://github.com/openjdk/jdk17u-dev/pull/2281), which has already been merged. >> >> >> In addition to GHA Tier 1, runtime hotspot, JFR, and hotspot GC tests have been run on macOS. >> >> >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/hotspot/jtreg:hotspot_runtime 880 880 0 0 >> ============================== >> TEST SUCCESS >> >> Finished building target 'test' in configuration 'macosx-x86_64-server-release' >> >> Additinonally, added clean backport of [JDK-8316468] (https://github.com/openjdk/jdk/commit/7ce5bd159024e70f5a997c47ed2ce962d6e6091b) >> >> After new commit reran runtime hotspot tests and they all passed > > Elif Aslan has updated the pull request incrementally with one additional commit since the last revision: > > backport of 7ce5bd159024e70f5a997c47ed2ce962d6e6091b Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2490#pullrequestreview-2086867393 From serb at openjdk.org Thu May 30 01:47:05 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 30 May 2024 01:47:05 GMT Subject: [jdk21u-dev] Integrated: 8311666: Disabled tests in test/jdk/sun/java2d/marlin In-Reply-To: References: Message-ID: On Fri, 24 May 2024 21:02:33 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [b285ed72](https://github.com/openjdk/jdk/commit/b285ed72aebe2d802fa9c071372cea6c09870b9a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Liam Miller-Cushon on 10 Jul 2023 and was reviewed by Phil Race. > > Thanks! This pull request has now been integrated. Changeset: 87670e7a Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk21u-dev/commit/87670e7aea399655886ead400ab6cdcc0fe0075f Stats: 18 lines in 3 files changed: 17 ins; 1 del; 0 mod 8311666: Disabled tests in test/jdk/sun/java2d/marlin Backport-of: b285ed72aebe2d802fa9c071372cea6c09870b9a ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/603 From lyang at openjdk.org Thu May 30 02:01:13 2024 From: lyang at openjdk.org (Long Yang) Date: Thu, 30 May 2024 02:01:13 GMT Subject: [jdk17u-dev] RFR: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate In-Reply-To: <8yDsUnG0HQVsCakGSjitm-ErWQvnkmKQqaF_cPGilEY=.20cc85c6-7e45-4256-b995-32034141df9c@github.com> References: <8yDsUnG0HQVsCakGSjitm-ErWQvnkmKQqaF_cPGilEY=.20cc85c6-7e45-4256-b995-32034141df9c@github.com> Message-ID: On Fri, 8 Mar 2024 07:38:57 GMT, Long Yang wrote: > Hi, all > > Could I have a review of this backport. > > This pull request contains a backport of commit [8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb](https://github.com/openjdk/jdk/commit/8dbd4b391f7deb1a46a5f07f0bc46f23d6715ddb) from the [openjdk/jdk](https://github.com/openjdk/jdk) repository. > > Testing: I ran test/jdk/jdk/jfr/event/os/TestCPULoad.java and passed. All GHA tests are passed (except linux-cross-compile, build(riscv64), Create sysroot. It looks like there's an issue with the GHA's process). Thank you all ~ ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2277#issuecomment-2138534370 From andrewlu at openjdk.org Thu May 30 02:02:05 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 30 May 2024 02:02:05 GMT Subject: [jdk21u-dev] Integrated: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab In-Reply-To: References: Message-ID: On Tue, 28 May 2024 10:04:39 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. This pull request has now been integrated. Changeset: 97c01b1c Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/97c01b1cacf4c1f79bc37f206f7ef2c4a06420f5 Stats: 80 lines in 1 file changed: 28 ins; 6 del; 46 mod 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab Backport-of: db5613af89a2d4ab5a8998ad1d43384778974866 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/611 From andrewlu at openjdk.org Thu May 30 02:02:11 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 30 May 2024 02:02:11 GMT Subject: [jdk21u-dev] Integrated: 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified In-Reply-To: References: Message-ID: On Tue, 28 May 2024 08:31:53 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. This pull request has now been integrated. Changeset: 9326d882 Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/9326d8829e6028a88adeca74fdc1a786e8b93e5a Stats: 18 lines in 4 files changed: 18 ins; 0 del; 0 mod 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified Backport-of: 1b0dd7c254dc1a087874c8726d8d26b9a41d4145 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/607 From andrewlu at openjdk.org Thu May 30 02:03:09 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 30 May 2024 02:03:09 GMT Subject: [jdk21u-dev] Integrated: 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out In-Reply-To: References: Message-ID: On Mon, 27 May 2024 07:57:58 GMT, Andrew Lu wrote: > I backport this for parity with 21.0.5-oracle. This pull request has now been integrated. Changeset: 9971c63e Author: Andrew Lu URL: https://git.openjdk.org/jdk21u-dev/commit/9971c63ef8b3cf5b060c853b11fe81a1905ee655 Stats: 10 lines in 5 files changed: 0 ins; 0 del; 10 mod 8307788: vmTestbase/gc/gctests/LargeObjects/large003/TestDescription.java timed out Backport-of: 929af9ed037bcc098043d7b7b8d303744a6d4360 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/604 From serb at openjdk.org Thu May 30 03:56:24 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 30 May 2024 03:56:24 GMT Subject: [jdk21u-dev] RFR: 8325763: Revert properties: vm.opt.x.* Message-ID: Hi all, This pull request contains a backport of commit [0aaec975](https://github.com/openjdk/jdk/commit/0aaec97527ddf2b229a9dd6beaa7ff55c635dee5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Leo Korinth on 16 Feb 2024 and was reviewed by Albert Mingkun Yang and Stefan Karlsson. Thanks! ------------- Commit messages: - Merge branch 'openjdk:master' into backport-mrserb-0aaec975 - Backport 0aaec97527ddf2b229a9dd6beaa7ff55c635dee5 Changes: https://git.openjdk.org/jdk21u-dev/pull/621/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=621&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325763 Stats: 40 lines in 6 files changed: 0 ins; 27 del; 13 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/621.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/621/head:pull/621 PR: https://git.openjdk.org/jdk21u-dev/pull/621 From serb at openjdk.org Thu May 30 05:07:31 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 30 May 2024 05:07:31 GMT Subject: [jdk22u] RFR: 8325763: Revert properties: vm.opt.x.* Message-ID: Hi all, This pull request contains a backport of commit [0aaec975](https://github.com/openjdk/jdk/commit/0aaec97527ddf2b229a9dd6beaa7ff55c635dee5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Leo Korinth on 16 Feb 2024 and was reviewed by Albert Mingkun Yang and Stefan Karlsson. Thanks! ------------- Commit messages: - Backport 0aaec97527ddf2b229a9dd6beaa7ff55c635dee5 Changes: https://git.openjdk.org/jdk22u/pull/229/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=229&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325763 Stats: 40 lines in 6 files changed: 0 ins; 27 del; 13 mod Patch: https://git.openjdk.org/jdk22u/pull/229.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/229/head:pull/229 PR: https://git.openjdk.org/jdk22u/pull/229 From serb at openjdk.org Thu May 30 07:06:08 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 30 May 2024 07:06:08 GMT Subject: [jdk22u] RFR: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+ Message-ID: <618MdIz0vKLe9oVP1nzqoGFuAbiaocMoVE9rIgzu7Eo=.b159d66c-14e8-4ff2-b104-dce25f194c6e@github.com> Hi all, This pull request contains a backport of commit [eb60822a](https://github.com/openjdk/jdk/commit/eb60822a45ecd076484e707b2dd1049ed9d8079b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Abhishek Kumar on 19 Apr 2024 and was reviewed by Damon Nguyen, Jayathirth D V, Tejesh R and Sergey Bylokhov. Thanks! ------------- Commit messages: - Backport eb60822a45ecd076484e707b2dd1049ed9d8079b Changes: https://git.openjdk.org/jdk22u/pull/230/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=230&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310072 Stats: 66 lines in 1 file changed: 19 ins; 33 del; 14 mod Patch: https://git.openjdk.org/jdk22u/pull/230.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/230/head:pull/230 PR: https://git.openjdk.org/jdk22u/pull/230 From serb at openjdk.org Thu May 30 07:14:30 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 30 May 2024 07:14:30 GMT Subject: [jdk21u-dev] RFR: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+ Message-ID: Hi all, This pull request contains a backport of commit [eb60822a](https://github.com/openjdk/jdk/commit/eb60822a45ecd076484e707b2dd1049ed9d8079b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Abhishek Kumar on 19 Apr 2024 and was reviewed by Damon Nguyen, Jayathirth D V, Tejesh R and Sergey Bylokhov. Thanks! ------------- Commit messages: - Backport eb60822a45ecd076484e707b2dd1049ed9d8079b Changes: https://git.openjdk.org/jdk21u-dev/pull/622/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=622&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310072 Stats: 66 lines in 1 file changed: 19 ins; 33 del; 14 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/622.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/622/head:pull/622 PR: https://git.openjdk.org/jdk21u-dev/pull/622 From vpetko at openjdk.org Thu May 30 07:38:09 2024 From: vpetko at openjdk.org (Vladimir Petko) Date: Thu, 30 May 2024 07:38:09 GMT Subject: [jdk17u-dev] Integrated: 8295111: dpkg appears to have problems resolving symbolically linked native libraries In-Reply-To: References: Message-ID: On Tue, 28 May 2024 05:17:56 GMT, Vladimir Petko wrote: > Hi all, > > This pull request contains a backport of commit [32946e18](https://github.com/openjdk/jdk/commit/32946e1882e9b22c983cbba3c6bda3cc7295946a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexey Semenyuk on 18 Apr 2024 and was reviewed by Alexander Matveev. > > The backport had a conflict in the copyright header that was resolved manually. > > This change fixes an issue caused by usrmerge on Debian-based systems - dpkg -S does not return a package containing a symlinked shared library in /lib, e.g. > > dpkg -S /lib/x86_64-linux-gnu/libmd.so.0 > # dpkg-query: no path found matching pattern /lib/x86_64-linux-gnu/libmd.so.0 > > The fix calls toRealPath() to resolve an actual path to the file before dpkg call and falls back to the old behaviour if the dpkg call fails. > > The change is tested by jpackage set of jtreg tests and should be low risk. > > jpackage tests pass (Ubuntu 24.04): > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/jdk/tools/jpackage 55 55 0 0 > ============================== > TEST SUCCESS > > > Thanks! This pull request has now been integrated. Changeset: dcb2c351 Author: Vladimir Petko Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/dcb2c35151a846b7c44045235b389baf9713885c Stats: 43 lines in 1 file changed: 19 ins; 3 del; 21 mod 8295111: dpkg appears to have problems resolving symbolically linked native libraries Backport-of: 32946e1882e9b22c983cbba3c6bda3cc7295946a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2501 From shade at openjdk.org Thu May 30 07:39:06 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 30 May 2024 07:39:06 GMT Subject: [jdk17u-dev] RFR: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time [v2] In-Reply-To: References: Message-ID: <2LUONAnWSY56C_EOVhkaaV3Xc5sAM7XWksxgeStTnug=.6627f635-be70-4366-bd04-31e3fc89ae58@github.com> On Wed, 29 May 2024 18:17:31 GMT, Elif Aslan wrote: >> Clean backport to fix ProcessTools.startProcess() bug. >> >> See original PR explanation [here](https://github.com/openjdk/jdk/pull/13594) >> >> I need this backport to be merged to able to complete [this](https://github.com/openjdk/jdk17u-dev/pull/2339) backport request. >> >> Additional testing: macos-x86_64-server-release tier2 > > Elif Aslan has updated the pull request incrementally with one additional commit since the last revision: > > backport of 64ac9a05e85020d24e33ba55cffa1bd9b269218a Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2456#pullrequestreview-2087470928 From shade at openjdk.org Thu May 30 07:39:14 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 30 May 2024 07:39:14 GMT Subject: [jdk17u-dev] RFR: 8318986: Improve GenericWaitBarrier performance [v2] In-Reply-To: References: Message-ID: <2Kusm0-H-ZSBk3JrcYtwr34Z-DheXng0upWBWB1IAV4=.54144d2a-c17b-4601-b866-239ad1a42cf3@github.com> On Wed, 29 May 2024 11:55:36 GMT, Aleksey Shipilev wrote: >> Clean backport to drastically improve safepoint performance under heavy load, fixing regression between JDK 11 and JDK 17. >> >> Additional testing: >> - [x] Ad-hoc performance runs, expected improvements >> - [x] MacOS AArch64 server fastdebug, `tier{1,2,3}` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into JDK-8318986-generic-wait-barrier > - Merge branch 'master' into JDK-8318986-generic-wait-barrier > - Backport 30462f9da40d3a7ec18fcf46e2154fabb5fd4753 Re-ran `tier{1,2,3}` on MacOS AArch64, looks fine. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2041#issuecomment-2138868424 From shade at openjdk.org Thu May 30 07:39:15 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 30 May 2024 07:39:15 GMT Subject: [jdk17u-dev] Integrated: 8318986: Improve GenericWaitBarrier performance In-Reply-To: References: Message-ID: On Mon, 11 Dec 2023 17:39:49 GMT, Aleksey Shipilev wrote: > Clean backport to drastically improve safepoint performance under heavy load, fixing regression between JDK 11 and JDK 17. > > Additional testing: > - [x] Ad-hoc performance runs, expected improvements > - [x] MacOS AArch64 server fastdebug, `tier{1,2,3}` This pull request has now been integrated. Changeset: 515bc9a2 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/515bc9a264c1e44cfcada0405a74ab2fba428e10 Stats: 286 lines in 2 files changed: 225 ins; 12 del; 49 mod 8318986: Improve GenericWaitBarrier performance Backport-of: 30462f9da40d3a7ec18fcf46e2154fabb5fd4753 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2041 From andrewlu at openjdk.org Thu May 30 08:18:17 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 30 May 2024 08:18:17 GMT Subject: [jdk21u-dev] RFR: 8310201: Reduce verbose locale output in -XshowSettings launcher option Message-ID: I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport f6e23ae4519f8eb877ae28a0bfbb4820c9718f91 Changes: https://git.openjdk.org/jdk21u-dev/pull/623/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=623&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310201 Stats: 22 lines in 2 files changed: 15 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/623.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/623/head:pull/623 PR: https://git.openjdk.org/jdk21u-dev/pull/623 From andrewlu at openjdk.org Thu May 30 08:18:34 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 30 May 2024 08:18:34 GMT Subject: [jdk17u-dev] RFR: 8310201: Reduce verbose locale output in -XshowSettings launcher option Message-ID: I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport f6e23ae4519f8eb877ae28a0bfbb4820c9718f91 Changes: https://git.openjdk.org/jdk17u-dev/pull/2509/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2509&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310201 Stats: 22 lines in 2 files changed: 15 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2509.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2509/head:pull/2509 PR: https://git.openjdk.org/jdk17u-dev/pull/2509 From andrewlu at openjdk.org Thu May 30 08:18:40 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Thu, 30 May 2024 08:18:40 GMT Subject: [jdk11u-dev] RFR: 8310201: Reduce verbose locale output in -XshowSettings launcher option Message-ID: I backport this for parity with 11.0.25-oracle. ------------- Commit messages: - Backport f6e23ae4519f8eb877ae28a0bfbb4820c9718f91 Changes: https://git.openjdk.org/jdk11u-dev/pull/2730/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2730&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310201 Stats: 22 lines in 2 files changed: 15 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2730.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2730/head:pull/2730 PR: https://git.openjdk.org/jdk11u-dev/pull/2730 From pminborg at openjdk.org Thu May 30 08:54:09 2024 From: pminborg at openjdk.org (Per Minborg) Date: Thu, 30 May 2024 08:54:09 GMT Subject: [jdk21u-dev] RFR: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment In-Reply-To: References: <8A1BNN5ZXTXFpI4cZh-25KKo_rEx7FJLl34OUQS7HTk=.938f856d-3520-4761-8491-76eb9e7f2025@github.com> Message-ID: On Mon, 27 May 2024 12:52:24 GMT, Martin Doerr wrote: > This one is ready for integration. It appears [JDK-8323552](https://bugs.openjdk.org/browse/JDK-8323552) is not approved by the maintainer. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/404#issuecomment-2139072407 From pminborg at openjdk.org Thu May 30 11:45:09 2024 From: pminborg at openjdk.org (Per Minborg) Date: Thu, 30 May 2024 11:45:09 GMT Subject: [jdk22u] Integrated: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment In-Reply-To: References: Message-ID: <9mnKFwbj3rLvyOa92z3ynhNPfgg91fpHqIdFLX1y7pg=.a01dd011-dee7-45a7-a5d1-f97dc0be3095@github.com> On Mon, 8 Apr 2024 07:08:33 GMT, Per Minborg wrote: > Hi all, > > This pull request contains a backport of commit [93579c29](https://github.com/openjdk/jdk/commit/93579c29e3ba60a8bc16d712e7ffc733f324a223) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Per Minborg on 25 Mar 2024 and was reviewed by Maurizio Cimadamore. > > Thanks! This pull request has now been integrated. Changeset: 91a2e753 Author: Per Minborg Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/91a2e7536ac4a0fef84ebb53663496eb2d60d237 Stats: 34 lines in 2 files changed: 27 ins; 4 del; 3 mod 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment Reviewed-by: shade Backport-of: 93579c29e3ba60a8bc16d712e7ffc733f324a223 ------------- PR: https://git.openjdk.org/jdk22u/pull/131 From shade at openjdk.org Thu May 30 11:50:08 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 30 May 2024 11:50:08 GMT Subject: [jdk21u-dev] RFR: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment In-Reply-To: References: <8A1BNN5ZXTXFpI4cZh-25KKo_rEx7FJLl34OUQS7HTk=.938f856d-3520-4761-8491-76eb9e7f2025@github.com> Message-ID: On Thu, 30 May 2024 08:51:15 GMT, Per Minborg wrote: > It appears [JDK-8323552](https://bugs.openjdk.org/browse/JDK-8323552) is not approved by the maintainer. Looks like Christoph wanted 22u backport first. Feel free to re-request the approval. Probably just put `jdk21u-fix-request` label back? ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/404#issuecomment-2139380243 From mdoerr at openjdk.org Thu May 30 12:15:04 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 30 May 2024 12:15:04 GMT Subject: [jdk21u-dev] RFR: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment In-Reply-To: <8A1BNN5ZXTXFpI4cZh-25KKo_rEx7FJLl34OUQS7HTk=.938f856d-3520-4761-8491-76eb9e7f2025@github.com> References: <8A1BNN5ZXTXFpI4cZh-25KKo_rEx7FJLl34OUQS7HTk=.938f856d-3520-4761-8491-76eb9e7f2025@github.com> Message-ID: <-AmIpf6kzyuLYw4EW7dTAhOUTCmc5LF6VYHsy0DeBYQ=.da0e9fa4-d31f-42c1-8371-a199cfb4e3b3@github.com> On Mon, 25 Mar 2024 11:54:39 GMT, Per Minborg wrote: > Hi all, > > This pull request contains a backport of commit [93579c29](https://github.com/openjdk/jdk/commit/93579c29e3ba60a8bc16d712e7ffc733f324a223) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Per Minborg on 25 Mar 2024 and was reviewed by Maurizio Cimadamore. > > Thanks! Right, the approval has been revoked. I have rerequested it by adding the label. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/404#issuecomment-2139420583 From shade at openjdk.org Thu May 30 13:14:12 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 30 May 2024 13:14:12 GMT Subject: [jdk22u] Integrated: 8331714: Make OopMapCache installation lock-free In-Reply-To: References: Message-ID: On Tue, 28 May 2024 08:42:21 GMT, Aleksey Shipilev wrote: > Clean backport to improve internal locking. Makes future backports clean. > > Additional testing: > - [x] GHA > - [x] Linux x86_64 fastdebug `hotspot_gc` This pull request has now been integrated. Changeset: d7d718dc Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/d7d718dcb5a55cb36ce27165fbd3874b3da2e55e Stats: 12 lines in 3 files changed: 1 ins; 3 del; 8 mod 8331714: Make OopMapCache installation lock-free Backport-of: a2584a8341b2dc9c102abd373a890b2108d3f57e ------------- PR: https://git.openjdk.org/jdk22u/pull/225 From asmehra at openjdk.org Thu May 30 14:19:17 2024 From: asmehra at openjdk.org (Ashutosh Mehra) Date: Thu, 30 May 2024 14:19:17 GMT Subject: [jdk22u] Integrated: 8330275: Crash in XMark::follow_array In-Reply-To: <3KqDzS3pRPJVH5ZmBONeP4J5Oe9SNna4ZxpIGWU9q-w=.92f6d88b-ce3a-42b9-b33c-44c9da3fd996@github.com> References: <3KqDzS3pRPJVH5ZmBONeP4J5Oe9SNna4ZxpIGWU9q-w=.92f6d88b-ce3a-42b9-b33c-44c9da3fd996@github.com> Message-ID: On Tue, 28 May 2024 17:29:19 GMT, Ashutosh Mehra wrote: > Backport of [JDK-8330275](https://bugs.openjdk.org/browse/JDK-8330275) to fix crash in ZGC. This pull request has now been integrated. Changeset: ceba7fc4 Author: Ashutosh Mehra Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk22u/commit/ceba7fc4aadfdf505d0ffa8c199a0c00cd39c2e6 Stats: 10 lines in 2 files changed: 4 ins; 0 del; 6 mod 8330275: Crash in XMark::follow_array Reviewed-by: stefank Backport-of: 42b1d858d15fd06de9ce41b08b430b12724652e9 ------------- PR: https://git.openjdk.org/jdk22u/pull/226 From duke at openjdk.org Thu May 30 14:19:42 2024 From: duke at openjdk.org (Rinku Kumar Maurya) Date: Thu, 30 May 2024 14:19:42 GMT Subject: [jdk17u-dev] RFR: 8256291: RunThese30M fails "assert(_class_unload ? true : ((((JfrTraceIdBits::load(class_loader_klass)) & ((1 << 4) << 8)) != 0))) failed: invariant" Message-ID: ClassLoaderData tagging should be changed to include the `class_loader_klass` as well at the tag site, so that an already tagged `cld` implies that `cld->class_loader_klass()` is also appropriately marked. If it's not done, then this unmarked/untagged class_loader_klass may get unloaded and referencing a dead class can cause crashes. ------------- Commit messages: - Backport e38df21641f13d7ae92f72cf8e72660072d3e5fe Changes: https://git.openjdk.org/jdk17u-dev/pull/2507/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2507&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256291 Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2507.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2507/head:pull/2507 PR: https://git.openjdk.org/jdk17u-dev/pull/2507 From shade at openjdk.org Thu May 30 14:21:29 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 30 May 2024 14:21:29 GMT Subject: [jdk21u-dev] RFR: 8327501: Common ForkJoinPool prevents class unloading in some cases [v3] In-Reply-To: References: Message-ID: > The change is stabilizing in mainline, but it looks simple, so we start testing it for JDK 21 pickup here. > > Additional testing: > - [x] Linux x86_64 server fastdebug, `all` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Backport 28216aa971ea65938117107542152abd532a5384 - Backport 53c4714aab2e072ba18631875dcaa3b2d5d22243 ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/338/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=338&range=02 Stats: 11 lines in 2 files changed: 8 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/338.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/338/head:pull/338 PR: https://git.openjdk.org/jdk21u-dev/pull/338 From shade at openjdk.org Thu May 30 14:21:29 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 30 May 2024 14:21:29 GMT Subject: [jdk21u-dev] RFR: 8327501: Common ForkJoinPool prevents class unloading in some cases [v2] In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 09:10:50 GMT, Aleksey Shipilev wrote: >> The change is stabilizing in mainline, but it looks simple, so we start testing it for JDK 21 pickup here. >> >> Additional testing: >> - [x] Linux x86_64 server fastdebug, `all` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. Both backports are clean. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/338#issuecomment-2042017730 From shade at openjdk.org Thu May 30 14:21:29 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 30 May 2024 14:21:29 GMT Subject: [jdk21u-dev] RFR: 8327501: Common ForkJoinPool prevents class unloading in some cases [v2] In-Reply-To: <2wBmyrfLiij-rq9PtiE2OEaua9bx6ORiq_nSGod3Vqk=.7f56115f-8aa5-447e-93ba-0c23b947a476@github.com> References: <2wBmyrfLiij-rq9PtiE2OEaua9bx6ORiq_nSGod3Vqk=.7f56115f-8aa5-447e-93ba-0c23b947a476@github.com> Message-ID: On Tue, 12 Mar 2024 09:29:13 GMT, Severin Gehwolf wrote: > Lets wait on getting this one backported until the compatibility impact wrt. setting the context class loader of a thread in the common pool is addressed. Yup. With this PR, I just confirmed all tests that I throw at this change pass in jdk21u-dev. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/338#issuecomment-1991187486 From asmehra at openjdk.org Thu May 30 14:42:14 2024 From: asmehra at openjdk.org (Ashutosh Mehra) Date: Thu, 30 May 2024 14:42:14 GMT Subject: [jdk22u] RFR: 8333093: Incorrect comment in zAddress_aarch64.cpp Message-ID: Hi all, This pull request contains a backport of commit [51ae08f7](https://github.com/openjdk/jdk/commit/51ae08f72b879bc611177ea643cd88e36185d9e8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Ashutosh Mehra on 28 May 2024 and was reviewed by Stefan Karlsson. It is a trivial change to fix the comments. Thanks! ------------- Commit messages: - Backport 51ae08f72b879bc611177ea643cd88e36185d9e8 Changes: https://git.openjdk.org/jdk22u/pull/231/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=231&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333093 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk22u/pull/231.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/231/head:pull/231 PR: https://git.openjdk.org/jdk22u/pull/231 From mdoerr at openjdk.org Thu May 30 14:49:33 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 30 May 2024 14:49:33 GMT Subject: [jdk11u] RFR: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message Message-ID: Basically clean backport of [JDK-8326643](https://bugs.openjdk.org/browse/JDK-8326643). Only Copyright year update didn't apply cleanly. Added test adaptation from [JDK-8255867](https://bugs.openjdk.org/browse/JDK-8255867) (see 2nd commit). ------------- Commit messages: - Include SSLEngineTemplate.java adaptation from JDK-8255867. - Backport cacc30b77cab0173ea14601094a5b5b3106ce2f5 Changes: https://git.openjdk.org/jdk11u/pull/91/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=91&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326643 Stats: 297 lines in 3 files changed: 286 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk11u/pull/91.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/91/head:pull/91 PR: https://git.openjdk.org/jdk11u/pull/91 From phh at openjdk.org Thu May 30 16:30:11 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 30 May 2024 16:30:11 GMT Subject: [jdk11u] RFR: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message In-Reply-To: References: Message-ID: On Thu, 30 May 2024 14:44:24 GMT, Martin Doerr wrote: > Basically clean backport of [JDK-8326643](https://bugs.openjdk.org/browse/JDK-8326643). Only Copyright year update didn't apply cleanly. Added test adaptation from [JDK-8255867](https://bugs.openjdk.org/browse/JDK-8255867) (see 2nd commit). Included test has passed. Why not backport [JDK-8255867](https://bugs.openjdk.org/browse/JDK-8255867) in its entirety rather than just the test adaptation part? ------------- PR Review: https://git.openjdk.org/jdk11u/pull/91#pullrequestreview-2088800925 From phh at openjdk.org Thu May 30 16:47:11 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 30 May 2024 16:47:11 GMT Subject: [jdk21u-dev] RFR: 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04 In-Reply-To: References: Message-ID: On Wed, 29 May 2024 15:04:35 GMT, Martin Doerr wrote: > Basically clean backport of [JDK-8305825](https://bugs.openjdk.org/browse/JDK-8305825). Skipped these removals from the ProblemList because they are not problem listed in 21: > javax/swing/JTree/8003400/Test8003400.java 8309734 linux-all > javax/swing/JTable/7124218/SelectEditTableCell.java 8309734 linux-all > javax/swing/JFileChooser/JFileChooserSetLocationTest.java 8309734 linux-all > > Can anybody test it on Ubuntu 23.04? Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/617#pullrequestreview-2088835117 From phh at openjdk.org Thu May 30 17:08:07 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 30 May 2024 17:08:07 GMT Subject: [jdk21u-dev] RFR: 8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs In-Reply-To: References: Message-ID: On Tue, 28 May 2024 09:07:10 GMT, Aleksey Shipilev wrote: > Unclean backport to avoid confusion on `is_gc_active` flag. The code shapes in JDK 21 are a bit different due to multiple refactorings in later JDKs. I applied renames by hand where needed. > > Additional testing: > - [x] Linux x86_64 fastdebug, `all` Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/609#pullrequestreview-2088882789 From mdoerr at openjdk.org Thu May 30 17:18:03 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 30 May 2024 17:18:03 GMT Subject: [jdk11u] RFR: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message In-Reply-To: References: Message-ID: On Thu, 30 May 2024 16:27:16 GMT, Paul Hohensee wrote: > Why not backport [JDK-8255867](https://bugs.openjdk.org/browse/JDK-8255867) in its entirety rather than just the test adaptation part? This is a late fix for parity with 11.0.24-oracle (critical backport). Oracle did not backport [JDK-8255867](https://bugs.openjdk.org/browse/JDK-8255867) AFAICS. That one may have side effects which may possibly cause problems in JDK 11. ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/91#issuecomment-2140327969 From phh at openjdk.org Thu May 30 17:31:13 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 30 May 2024 17:31:13 GMT Subject: [jdk11u-dev] RFR: 8331750: [11u] JDK-8259530 is not backported correctly to 11u In-Reply-To: References: Message-ID: On Tue, 7 May 2024 11:18:27 GMT, Kimura Yukihiro wrote: > This bug fix addresses the issue reported in https://github.com/openjdk/jdk11u-dev/pull/1805#issuecomment-2082702728. > I have confirmed that the fix passes the following tests: > - test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java > - All langtool tests > > Could someone please review the fix? > > Thanks, > Kimura Yukihiro Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/2702#pullrequestreview-2088983800 From phh at openjdk.org Thu May 30 17:37:19 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 30 May 2024 17:37:19 GMT Subject: [jdk11u] RFR: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message In-Reply-To: References: Message-ID: On Thu, 30 May 2024 14:44:24 GMT, Martin Doerr wrote: > Basically clean backport of [JDK-8326643](https://bugs.openjdk.org/browse/JDK-8326643). Only Copyright year update didn't apply cleanly. Added test adaptation from [JDK-8255867](https://bugs.openjdk.org/browse/JDK-8255867) (see 2nd commit). Included test has passed. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u/pull/91#pullrequestreview-2088999934 From duke at openjdk.org Thu May 30 19:29:10 2024 From: duke at openjdk.org (Xiaolong Peng) Date: Thu, 30 May 2024 19:29:10 GMT Subject: [jdk21u-dev] Integrated: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC In-Reply-To: <2Kxv67UXNf7X4hFhoDZZR1dBP-gHQpNHckUzLs0rjrw=.3d94c1d3-bc7a-418b-8e53-148929d555bb@github.com> References: <2Kxv67UXNf7X4hFhoDZZR1dBP-gHQpNHckUzLs0rjrw=.3d94c1d3-bc7a-418b-8e53-148929d555bb@github.com> Message-ID: On Wed, 15 May 2024 21:20:13 GMT, Xiaolong Peng wrote: > 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC This pull request has now been integrated. Changeset: dc8b95fb Author: Xiaolong Peng Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/dc8b95fb30773d2fd73e0fe1cfd014215d0dad55 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC Backport-of: 80ccc989a892e4d9f4e2c9395a100cfabbdcda64 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/575 From serb at openjdk.org Thu May 30 21:16:20 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 30 May 2024 21:16:20 GMT Subject: [jdk11u-dev] RFR: 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free Message-ID: <2hp6Gnb7UceHPhnF_0OWR0KZ1YI-laZJ5aK0hLUB-L8=.f80bc99e-eec0-4f05-93d0-a6c389cf0689@github.com> Hi all, This pull request contains a backport of commit [7c2c5858](https://github.com/openjdk/jdk/commit/7c2c58587d4eda5523331eae45e7d897252dc097) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 12 Dec 2021 and was reviewed by Prasanta Sadhukhan and Alexey Ivanov. Thanks! ------------- Commit messages: - Backport 7c2c58587d4eda5523331eae45e7d897252dc097 Changes: https://git.openjdk.org/jdk11u-dev/pull/2729/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2729&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8276819 Stats: 9 lines in 1 file changed: 3 ins; 4 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2729.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2729/head:pull/2729 PR: https://git.openjdk.org/jdk11u-dev/pull/2729 From mdoerr at openjdk.org Thu May 30 22:14:15 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 30 May 2024 22:14:15 GMT Subject: [jdk11u] RFR: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message In-Reply-To: References: Message-ID: On Thu, 30 May 2024 14:44:24 GMT, Martin Doerr wrote: > Basically clean backport of [JDK-8326643](https://bugs.openjdk.org/browse/JDK-8326643). Only Copyright year update didn't apply cleanly. Added test adaptation from [JDK-8255867](https://bugs.openjdk.org/browse/JDK-8255867) (see 2nd commit). Included test has passed. Thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/91#issuecomment-2140937197 From mdoerr at openjdk.org Thu May 30 22:41:02 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 30 May 2024 22:41:02 GMT Subject: [jdk21u-dev] RFR: 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04 In-Reply-To: References: Message-ID: On Wed, 29 May 2024 15:04:35 GMT, Martin Doerr wrote: > Basically clean backport of [JDK-8305825](https://bugs.openjdk.org/browse/JDK-8305825). Skipped these removals from the ProblemList because they are not problem listed in 21: > javax/swing/JTree/8003400/Test8003400.java 8309734 linux-all > javax/swing/JTable/7124218/SelectEditTableCell.java 8309734 linux-all > javax/swing/JFileChooser/JFileChooserSetLocationTest.java 8309734 linux-all > > Can anybody test it on Ubuntu 23.04? Thanks for the review! I don't have Ubuntu 23.04. The headful tests have passed on Ubuntu 22.04 (Power9) except MultiResolutionSplashTest. That one doesn't work on any linux with or without this patch on my X-server: Image with wrong resolution is used for splash screen! I'm going to ignore this unless anybody is volunteering to test it with another setup. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/617#issuecomment-2140961096 From zgu at openjdk.org Fri May 31 00:40:03 2024 From: zgu at openjdk.org (Zhengyu Gu) Date: Fri, 31 May 2024 00:40:03 GMT Subject: [jdk17u-dev] RFR: 8319713: Parallel: Remove PSAdaptiveSizePolicy::should_full_GC In-Reply-To: References: Message-ID: On Tue, 7 May 2024 16:57:41 GMT, Zhengyu Gu wrote: > Backport this patch to jdk17u, as a prerequisite for clean backport of [JDK-8328744](https://bugs.openjdk.org/browse/JDK-8328744), which is a p2 bug. Approved ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2450#issuecomment-2141048307 From zgu at openjdk.org Fri May 31 00:40:03 2024 From: zgu at openjdk.org (Zhengyu Gu) Date: Fri, 31 May 2024 00:40:03 GMT Subject: [jdk17u-dev] Integrated: 8319713: Parallel: Remove PSAdaptiveSizePolicy::should_full_GC In-Reply-To: References: Message-ID: <_ggN_VSpKCbT08fBVPwDOWrG9LCU1RN46gjtwzu49aA=.6e5b1dcd-b362-48e6-99cc-2ad1c4bf553e@github.com> On Tue, 7 May 2024 16:57:41 GMT, Zhengyu Gu wrote: > Backport this patch to jdk17u, as a prerequisite for clean backport of [JDK-8328744](https://bugs.openjdk.org/browse/JDK-8328744), which is a p2 bug. This pull request has now been integrated. Changeset: 7a8cf6c8 Author: Zhengyu Gu URL: https://git.openjdk.org/jdk17u-dev/commit/7a8cf6c8aec6cd648663def62d9496e516f05d4f Stats: 24 lines in 3 files changed: 0 ins; 23 del; 1 mod 8319713: Parallel: Remove PSAdaptiveSizePolicy::should_full_GC Backport-of: 4bcda602668835c35e2ac6ff6702d15cd249bc2a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2450 From zgu at openjdk.org Fri May 31 01:42:09 2024 From: zgu at openjdk.org (Zhengyu Gu) Date: Fri, 31 May 2024 01:42:09 GMT Subject: [jdk22u] RFR: 8272364: Parallel GC adaptive size policy may shrink the heap below MinHeapSize In-Reply-To: References: Message-ID: On Tue, 21 May 2024 09:41:57 GMT, Martin Doerr wrote: > This change causes test errors [JDK-8331675](https://bugs.openjdk.org/browse/JDK-8331675). Shouldn't they get addressed first? Please see latest comment in [JDK-8331675](https://bugs.openjdk.org/browse/JDK-8331675). ------------- PR Comment: https://git.openjdk.org/jdk22u/pull/217#issuecomment-2141091859 From duke at openjdk.org Fri May 31 06:11:09 2024 From: duke at openjdk.org (Xiaolong Peng) Date: Fri, 31 May 2024 06:11:09 GMT Subject: [jdk22u] RFR: 8331771: ZGC: Remove OopMapCacheAlloc_lock ordering workaround Message-ID: I'd like to backport the change of https://bugs.openjdk.org/browse/JDK-8331771 to JDK22 ------------- Commit messages: - Backport 5746137e8a46e1eb964fe8c4de015a62dc17a745 Changes: https://git.openjdk.org/jdk22u/pull/232/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=232&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331771 Stats: 22 lines in 4 files changed: 0 ins; 22 del; 0 mod Patch: https://git.openjdk.org/jdk22u/pull/232.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/232/head:pull/232 PR: https://git.openjdk.org/jdk22u/pull/232 From syan at openjdk.org Fri May 31 06:20:08 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 31 May 2024 06:20:08 GMT Subject: [jdk17u-dev] RFR: 8318479: [jmh] the test security.CacheBench failed for multiple threads run In-Reply-To: References: Message-ID: On Wed, 29 May 2024 13:03:55 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8318479](https://bugs.openjdk.org/browse/JDK-8318479) parity with 17.0.13-oracle, which remove the hardcoded maximum heap size, to avoid OOM fail with 100+ threads. > Only change the jmh testcase, no risk. Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2506#issuecomment-2141304610 From duke at openjdk.org Fri May 31 06:27:34 2024 From: duke at openjdk.org (Xiaolong Peng) Date: Fri, 31 May 2024 06:27:34 GMT Subject: [jdk21u-dev] RFR: 8331771: ZGC: Remove OopMapCacheAlloc_lock ordering workaround Message-ID: I'd like to backport [JDK-8331771](https://bugs.openjdk.org/browse/JDK-8331771) to jdk21 ------------- Commit messages: - Backport 5746137e8a46e1eb964fe8c4de015a62dc17a745 Changes: https://git.openjdk.org/jdk21u-dev/pull/626/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=626&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331771 Stats: 22 lines in 4 files changed: 0 ins; 22 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/626.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/626/head:pull/626 PR: https://git.openjdk.org/jdk21u-dev/pull/626 From duke at openjdk.org Fri May 31 06:48:32 2024 From: duke at openjdk.org (Xiaolong Peng) Date: Fri, 31 May 2024 06:48:32 GMT Subject: [jdk22u] RFR: 8329134: Reconsider TLAB zapping Message-ID: I'd like to backport [JDK-8329134](https://bugs.openjdk.org/browse/JDK-8329134) to jdk22. ------------- Commit messages: - Backport 5698f7ad29c939b7e52882ace575dd7113bf41de Changes: https://git.openjdk.org/jdk22u/pull/233/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=233&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329134 Stats: 30 lines in 5 files changed: 5 ins; 16 del; 9 mod Patch: https://git.openjdk.org/jdk22u/pull/233.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/233/head:pull/233 PR: https://git.openjdk.org/jdk22u/pull/233 From duke at openjdk.org Fri May 31 06:50:34 2024 From: duke at openjdk.org (Xiaolong Peng) Date: Fri, 31 May 2024 06:50:34 GMT Subject: [jdk21u-dev] RFR: 8329134: Reconsider TLAB zapping Message-ID: I'd like to backport [JDK-8329134](https://bugs.openjdk.org/browse/JDK-8329134) to jdk21 ------------- Commit messages: - Backport 5698f7ad29c939b7e52882ace575dd7113bf41de Changes: https://git.openjdk.org/jdk21u-dev/pull/627/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=627&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329134 Stats: 30 lines in 5 files changed: 5 ins; 16 del; 9 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/627.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/627/head:pull/627 PR: https://git.openjdk.org/jdk21u-dev/pull/627 From duke at openjdk.org Fri May 31 06:50:37 2024 From: duke at openjdk.org (Xiaolong Peng) Date: Fri, 31 May 2024 06:50:37 GMT Subject: [jdk17u-dev] RFR: 8329134: Reconsider TLAB zapping Message-ID: I'd like to backport [JDK-8329134](https://bugs.openjdk.org/browse/JDK-8329134) to jdk17 ------------- Commit messages: - Backport 5698f7ad29c939b7e52882ace575dd7113bf41de Changes: https://git.openjdk.org/jdk17u-dev/pull/2510/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2510&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329134 Stats: 28 lines in 5 files changed: 5 ins; 16 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2510.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2510/head:pull/2510 PR: https://git.openjdk.org/jdk17u-dev/pull/2510 From mbaesken at openjdk.org Fri May 31 07:12:11 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 31 May 2024 07:12:11 GMT Subject: [jdk11u] RFR: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message In-Reply-To: References: Message-ID: On Thu, 30 May 2024 14:44:24 GMT, Martin Doerr wrote: > Basically clean backport of [JDK-8326643](https://bugs.openjdk.org/browse/JDK-8326643). Only Copyright year update didn't apply cleanly. Added test adaptation from [JDK-8255867](https://bugs.openjdk.org/browse/JDK-8255867) (see 2nd commit). Included test has passed. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u/pull/91#pullrequestreview-2090041769 From andrewlu at openjdk.org Fri May 31 08:17:12 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 31 May 2024 08:17:12 GMT Subject: [jdk17u-dev] Integrated: 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified In-Reply-To: References: Message-ID: <6Sq6IcN0-UnXwUJsXI43g6V8dGGdcUCyc4vjNz6SURw=.f64c5561-2046-4736-88b6-ef379531148b@github.com> On Tue, 28 May 2024 08:31:59 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: cc0c1438 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/cc0c14380337f868d63f4ab746e4746a5dc2f115 Stats: 18 lines in 4 files changed: 18 ins; 0 del; 0 mod 8310108: Skip ReplaceCriticalClassesForSubgraphs when EnableJVMCI is specified Backport-of: 1b0dd7c254dc1a087874c8726d8d26b9a41d4145 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2502 From syan at openjdk.org Fri May 31 08:19:06 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 31 May 2024 08:19:06 GMT Subject: [jdk21u-dev] Integrated: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 17:58:06 GMT, SendaoYan wrote: > Hi, > This is clean backport of JDK-8331164, to fixed download failure when the URL needed to be redirected. > Only change devkit shell script, the risk is low. This pull request has now been integrated. Changeset: 362ecacc Author: SendaoYan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/362ecacc7ca93371eb07cbe76f859a2e2a198a5c Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8331164: createJMHBundle.sh download jars fail when url needed to be redirected Backport-of: eb88343fb763ee89010b7a9879638152decc6892 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/543 From andrewlu at openjdk.org Fri May 31 08:19:06 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 31 May 2024 08:19:06 GMT Subject: [jdk17u-dev] Integrated: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab In-Reply-To: <2-5aDesW7cArGfpYlC5zwsBiYBUlIO6ytRl-RBvU0-Q=.31221b27-35a9-48c4-a6a4-a5470e20f40f@github.com> References: <2-5aDesW7cArGfpYlC5zwsBiYBUlIO6ytRl-RBvU0-Q=.31221b27-35a9-48c4-a6a4-a5470e20f40f@github.com> Message-ID: <7KPwrpI8m5g3RJFtRhhpHd8VeGeXyr8BPeWoLzQXfbc=.f49e18dd-b393-4731-a0c1-3b54940a153f@github.com> On Tue, 28 May 2024 10:04:44 GMT, Andrew Lu wrote: > I backport this for parity with 17.0.13-oracle. This pull request has now been integrated. Changeset: eebb80c4 Author: Andrew Lu URL: https://git.openjdk.org/jdk17u-dev/commit/eebb80c4bcec64dc70065b597688cbe12c892a5b Stats: 80 lines in 1 file changed: 28 ins; 6 del; 46 mod 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause ungrab Backport-of: db5613af89a2d4ab5a8998ad1d43384778974866 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2503 From shade at openjdk.org Fri May 31 08:21:14 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 31 May 2024 08:21:14 GMT Subject: [jdk21u-dev] Integrated: 8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs In-Reply-To: References: Message-ID: On Tue, 28 May 2024 09:07:10 GMT, Aleksey Shipilev wrote: > Unclean backport to avoid confusion on `is_gc_active` flag. The code shapes in JDK 21 are a bit different due to multiple refactorings in later JDKs. I applied renames by hand where needed. > > Additional testing: > - [x] Linux x86_64 fastdebug, `all` This pull request has now been integrated. Changeset: 2a210449 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk21u-dev/commit/2a21044977ce911d66277f86f997bbab08c1b279 Stats: 63 lines in 27 files changed: 0 ins; 2 del; 61 mod 8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs Reviewed-by: phh Backport-of: 1eec30a6c03b7f4028405dc9bdb4d2a663b3987d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/609 From syan at openjdk.org Fri May 31 08:35:08 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 31 May 2024 08:35:08 GMT Subject: [jdk21u-dev] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected [v2] In-Reply-To: References: Message-ID: On Mon, 13 May 2024 09:42:42 GMT, SendaoYan wrote: >> Hi, >> This is clean backport of JDK-8331164, to fixed download failure when the URL needed to be redirected. >> Only change devkit shell script, the risk is low. > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-eb88343f > - Backport eb88343fb763ee89010b7a9879638152decc6892 Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/543#issuecomment-2141496587 From duke at openjdk.org Fri May 31 08:44:08 2024 From: duke at openjdk.org (Rinku Kumar Maurya) Date: Fri, 31 May 2024 08:44:08 GMT Subject: [jdk17u-dev] Integrated: 8256291: RunThese30M fails "assert(_class_unload ? true : ((((JfrTraceIdBits::load(class_loader_klass)) & ((1 << 4) << 8)) != 0))) failed: invariant" In-Reply-To: References: Message-ID: On Wed, 29 May 2024 13:23:46 GMT, Rinku Kumar Maurya wrote: > ClassLoaderData tagging should be changed to include the `class_loader_klass` as well at the tag site, so that an already tagged `cld` implies that `cld->class_loader_klass()` is also appropriately marked. If it's not done, then this unmarked/untagged class_loader_klass may get unloaded and referencing a dead class can cause crashes. This pull request has now been integrated. Changeset: 1de0c0a8 Author: Rinku Kumar Maurya Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/1de0c0a805f68914aec7358fc4aa9c9d2499ec98 Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod 8256291: RunThese30M fails "assert(_class_unload ? true : ((((JfrTraceIdBits::load(class_loader_klass)) & ((1 << 4) << 8)) != 0))) failed: invariant" Backport-of: e38df21641f13d7ae92f72cf8e72660072d3e5fe ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2507 From mdoerr at openjdk.org Fri May 31 09:05:05 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 09:05:05 GMT Subject: [jdk21u-dev] Integrated: 8319773: Avoid inflating monitors when installing hash codes for LM_LIGHTWEIGHT In-Reply-To: References: Message-ID: On Wed, 29 May 2024 16:16:53 GMT, Martin Doerr wrote: > Clean backport of [JDK-8319773](https://bugs.openjdk.org/browse/JDK-8319773). This pull request has now been integrated. Changeset: 55e97ce0 Author: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/55e97ce07a382f799f64f86ec9aea73875d41322 Stats: 76 lines in 4 files changed: 29 ins; 23 del; 24 mod 8319773: Avoid inflating monitors when installing hash codes for LM_LIGHTWEIGHT Backport-of: 65a0672791f868556776fc435b37319ed69f7c84 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/618 From mdoerr at openjdk.org Fri May 31 09:05:06 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 09:05:06 GMT Subject: [jdk21u-dev] Integrated: 8326106: Write and clear stack trace table outside of safepoint In-Reply-To: <_pRL95LV9P4wjMaelSboQb3iEm4AC9H5O7q_qDSN2U0=.94220f25-8ed4-41df-8035-7230b7c65d4e@github.com> References: <_pRL95LV9P4wjMaelSboQb3iEm4AC9H5O7q_qDSN2U0=.94220f25-8ed4-41df-8035-7230b7c65d4e@github.com> Message-ID: On Wed, 29 May 2024 13:55:38 GMT, Martin Doerr wrote: > Clean backport of [JDK-8326106](https://bugs.openjdk.org/browse/JDK-8326106). This pull request has now been integrated. Changeset: b56f0c0b Author: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/b56f0c0be4864cc7f6d6f57112d96b3b57bb64db Stats: 17 lines in 3 files changed: 4 ins; 7 del; 6 mod 8326106: Write and clear stack trace table outside of safepoint Backport-of: a776104e210db212c4e32894844d3c0cbaac53c3 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/615 From mdoerr at openjdk.org Fri May 31 09:05:11 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 09:05:11 GMT Subject: [jdk21u-dev] Integrated: 8312229: Crash involving yield, switch and anonymous classes In-Reply-To: <6N_SqFMAcPPdpe_Ev6bnxcGLAqwGUF0i69wnYpHq0Nw=.2e8f21be-b4dc-44d1-b572-ff386e416787@github.com> References: <6N_SqFMAcPPdpe_Ev6bnxcGLAqwGUF0i69wnYpHq0Nw=.2e8f21be-b4dc-44d1-b572-ff386e416787@github.com> Message-ID: On Wed, 29 May 2024 14:58:34 GMT, Martin Doerr wrote: > Clean backport of [JDK-8312229](https://bugs.openjdk.org/browse/JDK-8312229). This pull request has now been integrated. Changeset: 8d4f686e Author: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/8d4f686ef1a832511767dbd470d082459f14badb Stats: 53 lines in 2 files changed: 51 ins; 0 del; 2 mod 8312229: Crash involving yield, switch and anonymous classes Backport-of: 1f81e5b19ebfb7cd1b5a01d6cf79efda7e827c35 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/616 From shade at openjdk.org Fri May 31 09:06:14 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 31 May 2024 09:06:14 GMT Subject: [jdk21u-dev] RFR: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment In-Reply-To: References: <8A1BNN5ZXTXFpI4cZh-25KKo_rEx7FJLl34OUQS7HTk=.938f856d-3520-4761-8491-76eb9e7f2025@github.com> Message-ID: <1NLHjIl1AyArt8p7xxkltPk_uGV7c7arSjmeTv-UJAY=.b740baba-13f0-4616-a41b-0293b0f8a084@github.com> On Thu, 30 May 2024 08:51:15 GMT, Per Minborg wrote: >> This one is ready for integration. > >> This one is ready for integration. > > It appears [JDK-8323552](https://bugs.openjdk.org/browse/JDK-8323552) is not approved by the maintainer. Now you should be fine to integrate, @minborg! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/404#issuecomment-2141549440 From mdoerr at openjdk.org Fri May 31 09:07:05 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 09:07:05 GMT Subject: [jdk21u-dev] Integrated: 8324668: JDWP process management needs more efficient file descriptor handling In-Reply-To: References: Message-ID: On Wed, 29 May 2024 16:29:00 GMT, Martin Doerr wrote: > Clean backport of [JDK-8324668](https://bugs.openjdk.org/browse/JDK-8324668). This pull request has now been integrated. Changeset: 0dcbc1d0 Author: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/0dcbc1d0cd940a57adc46377993bfe702e7bc25b Stats: 121 lines in 1 file changed: 106 ins; 12 del; 3 mod 8324668: JDWP process management needs more efficient file descriptor handling Backport-of: a6632487863db5ff3136cdcc76b7440c15ce6be9 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/619 From mdoerr at openjdk.org Fri May 31 09:06:13 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 09:06:13 GMT Subject: [jdk21u-dev] Integrated: 8323670: A few client tests intermittently throw ConcurrentModificationException In-Reply-To: References: Message-ID: <8DgsznB7Lw_ld2a8TQ2blZ_GT0yzinmBxR-xopzCUiA=.46397d87-f650-48c9-ba6d-732e04163974@github.com> On Wed, 29 May 2024 16:33:39 GMT, Martin Doerr wrote: > Clean backport of [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670). This pull request has now been integrated. Changeset: 42e6a97c Author: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/42e6a97c9a8a726745fbdc9315e23488c49d8aa5 Stats: 48 lines in 1 file changed: 6 ins; 4 del; 38 mod 8323670: A few client tests intermittently throw ConcurrentModificationException Backport-of: 70e7cdcb9ecedd455cf701b5c7ad05286ac0067d ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/620 From syan at openjdk.org Fri May 31 09:10:05 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 31 May 2024 09:10:05 GMT Subject: [jdk17u-dev] Integrated: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: References: Message-ID: <6VVSZLlsFZ57pQHYtPUFW1WdDR7CFpSN6nsacw6z9zM=.26366c06-8dc1-4a0a-a61e-4b7ba6733a64@github.com> On Mon, 29 Apr 2024 17:58:25 GMT, SendaoYan wrote: > Hi, > This is clean backport of JDK-8331164, to fixed download failure when the URL needed to be redirected. > Only change devkit shell script, the risk is low. This pull request has now been integrated. Changeset: 9eb97026 Author: SendaoYan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/9eb970264a34c82c11468b15fae89dc39c574682 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8331164: createJMHBundle.sh download jars fail when url needed to be redirected Backport-of: eb88343fb763ee89010b7a9879638152decc6892 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2441 From syan at openjdk.org Fri May 31 09:10:06 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 31 May 2024 09:10:06 GMT Subject: [jdk17u-dev] Integrated: 8318479: [jmh] the test security.CacheBench failed for multiple threads run In-Reply-To: References: Message-ID: On Wed, 29 May 2024 13:03:55 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8318479](https://bugs.openjdk.org/browse/JDK-8318479) parity with 17.0.13-oracle, which remove the hardcoded maximum heap size, to avoid OOM fail with 100+ threads. > Only change the jmh testcase, no risk. This pull request has now been integrated. Changeset: 46ba9bbe Author: SendaoYan Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/46ba9bbe7e93c561b5af833ff164596955302a9d Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8318479: [jmh] the test security.CacheBench failed for multiple threads run Backport-of: 1535528cb119195b44244e8ee6bc0f913caa9270 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2506 From andrewlu at openjdk.org Fri May 31 09:16:23 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 31 May 2024 09:16:23 GMT Subject: [jdk21u-dev] RFR: 8322008: Exclude some CDS tests from running with -Xshare:off Message-ID: I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport 4d32c607a4b496bf2bb09e54167ecbbab5569a0c Changes: https://git.openjdk.org/jdk21u-dev/pull/629/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=629&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322008 Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/629.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/629/head:pull/629 PR: https://git.openjdk.org/jdk21u-dev/pull/629 From andrewlu at openjdk.org Fri May 31 09:16:26 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 31 May 2024 09:16:26 GMT Subject: [jdk21u-dev] RFR: 8323577: C2 SuperWord: remove AlignVector restrictions on IR tests added in JDK-8305055 Message-ID: I backport this for parity with 21.0.5-oracle. ------------- Commit messages: - Backport 45c65e6b1ac06aa06757393f1752661252e6f827 Changes: https://git.openjdk.org/jdk21u-dev/pull/628/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=628&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323577 Stats: 13 lines in 2 files changed: 0 ins; 12 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/628.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/628/head:pull/628 PR: https://git.openjdk.org/jdk21u-dev/pull/628 From andrewlu at openjdk.org Fri May 31 09:16:30 2024 From: andrewlu at openjdk.org (Andrew Lu) Date: Fri, 31 May 2024 09:16:30 GMT Subject: [jdk17u-dev] RFR: 8322008: Exclude some CDS tests from running with -Xshare:off Message-ID: I backport this for parity with 17.0.13-oracle. ------------- Commit messages: - Backport 4d32c607a4b496bf2bb09e54167ecbbab5569a0c Changes: https://git.openjdk.org/jdk17u-dev/pull/2511/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2511&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322008 Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2511.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2511/head:pull/2511 PR: https://git.openjdk.org/jdk17u-dev/pull/2511 From syan at openjdk.org Fri May 31 09:19:05 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 31 May 2024 09:19:05 GMT Subject: [jdk17u-dev] RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected In-Reply-To: References: Message-ID: On Mon, 29 Apr 2024 17:58:25 GMT, SendaoYan wrote: > Hi, > This is clean backport of JDK-8331164, to fixed download failure when the URL needed to be redirected. > Only change devkit shell script, the risk is low. Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2441#issuecomment-2141572124 From syan at openjdk.org Fri May 31 09:19:06 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 31 May 2024 09:19:06 GMT Subject: [jdk17u-dev] RFR: 8318479: [jmh] the test security.CacheBench failed for multiple threads run In-Reply-To: References: Message-ID: On Wed, 29 May 2024 13:03:55 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8318479](https://bugs.openjdk.org/browse/JDK-8318479) parity with 17.0.13-oracle, which remove the hardcoded maximum heap size, to avoid OOM fail with 100+ threads. > Only change the jmh testcase, no risk. Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2506#issuecomment-2141571759 From mdoerr at openjdk.org Fri May 31 09:34:12 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 09:34:12 GMT Subject: [jdk17u-dev] RFR: 8315362: NMT: summary diff reports threads count incorrectly [v4] In-Reply-To: <29geqiegEUHtoQCR4yX3Eba10K48d9RJZ6sA5xP7EBQ=.c147fb4d-8a66-4b00-b621-427c41239cde@github.com> References: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> <29geqiegEUHtoQCR4yX3Eba10K48d9RJZ6sA5xP7EBQ=.c147fb4d-8a66-4b00-b621-427c41239cde@github.com> Message-ID: On Wed, 29 May 2024 14:11:35 GMT, Evgeny Ignatenko wrote: >> 8315362: NMT: summary diff reports threads count incorrectly > > Evgeny Ignatenko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge master > - Adjust test to make it clean backport > - Fix inconsistency with patch at jdk21 > - Backport 37aed6f46d19a48b7bceffde61b529a69a6abf54 Ok, you could have made it clean by naming it "Backport 31c759dd7ef69449e225c3e656d8f522e1124852" which makes it a backport of the JDK 21 version. But, let's ship it! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2084#issuecomment-2141598936 From duke at openjdk.org Fri May 31 09:34:13 2024 From: duke at openjdk.org (Evgeny Ignatenko) Date: Fri, 31 May 2024 09:34:13 GMT Subject: [jdk17u-dev] Integrated: 8315362: NMT: summary diff reports threads count incorrectly In-Reply-To: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> References: <_8GZWpv2i5l_Io1fH1Vql3H8-FRgYvrnTszRrq4G8zQ=.171cf9e1-4a68-468b-8168-3e613e3c47b8@github.com> Message-ID: On Wed, 27 Dec 2023 07:31:16 GMT, Evgeny Ignatenko wrote: > 8315362: NMT: summary diff reports threads count incorrectly This pull request has now been integrated. Changeset: a058ad15 Author: Evgeny Ignatenko Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/a058ad151a7c68f65e915856b089ce4064c1caf8 Stats: 86 lines in 5 files changed: 73 ins; 11 del; 2 mod 8315362: NMT: summary diff reports threads count incorrectly Reviewed-by: mdoerr Backport-of: 37aed6f46d19a48b7bceffde61b529a69a6abf54 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2084 From duke at openjdk.org Fri May 31 10:17:08 2024 From: duke at openjdk.org (Evgeny Ignatenko) Date: Fri, 31 May 2024 10:17:08 GMT Subject: [jdk17u-dev] Integrated: 8318474: Fix memory reporter for thread_count In-Reply-To: References: Message-ID: <6ZgYEphcE-qWGj88TzQrNt_kTUkqQgpqT1_gmnAUwrM=.6ba46587-6c4b-4ccf-bf18-6ff1db6c5e80@github.com> On Wed, 27 Dec 2023 07:34:48 GMT, Evgeny Ignatenko wrote: > 8318474: Fix memory reporter for thread_count This pull request has now been integrated. Changeset: 5cdff9f8 Author: Evgeny Ignatenko Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/5cdff9f8c17868c5b66338fc1fa3df19eee266c5 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod 8318474: Fix memory reporter for thread_count Backport-of: 0baa9ecd76c9be33a1939e47dcae320bc8b65e96 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2085 From mdoerr at openjdk.org Fri May 31 10:37:18 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 10:37:18 GMT Subject: [jdk11u] Integrated: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message In-Reply-To: References: Message-ID: <2xdrrYDSLl9AHWHZemRhlvmDskAGkoVIyB3O3-nbltk=.b68f2a6d-474f-4e4b-9ac2-094915edfcc3@github.com> On Thu, 30 May 2024 14:44:24 GMT, Martin Doerr wrote: > Basically clean backport of [JDK-8326643](https://bugs.openjdk.org/browse/JDK-8326643). Only Copyright year update didn't apply cleanly. Added test adaptation from [JDK-8255867](https://bugs.openjdk.org/browse/JDK-8255867) (see 2nd commit). Included test has passed. This pull request has now been integrated. Changeset: 15c9397e Author: Martin Doerr URL: https://git.openjdk.org/jdk11u/commit/15c9397e45f094718fb976da9104364b83569c05 Stats: 297 lines in 3 files changed: 286 ins; 0 del; 11 mod 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message Reviewed-by: phh, mbaesken Backport-of: cacc30b77cab0173ea14601094a5b5b3106ce2f5 ------------- PR: https://git.openjdk.org/jdk11u/pull/91 From mdoerr at openjdk.org Fri May 31 10:47:10 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 10:47:10 GMT Subject: [jdk11u-dev] RFR: 8310201: Reduce verbose locale output in -XshowSettings launcher option In-Reply-To: References: Message-ID: On Thu, 30 May 2024 08:09:14 GMT, Andrew Lu wrote: > I backport this for parity with 11.0.25-oracle. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/2730#pullrequestreview-2090508910 From mbaesken at openjdk.org Fri May 31 10:50:09 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 31 May 2024 10:50:09 GMT Subject: [jdk21u-dev] RFR: 8332431: NullPointerException in JTable of SwingSet2 Message-ID: Backport of 8332431 ------------- Commit messages: - Backport 9a83dfee14f4cd9cda476d11a027294a810953cb Changes: https://git.openjdk.org/jdk21u-dev/pull/630/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=630&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332431 Stats: 15 lines in 1 file changed: 10 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/630.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/630/head:pull/630 PR: https://git.openjdk.org/jdk21u-dev/pull/630 From mbaesken at openjdk.org Fri May 31 10:50:10 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 31 May 2024 10:50:10 GMT Subject: [jdk21u-dev] RFR: 8332431: NullPointerException in JTable of SwingSet2 In-Reply-To: References: Message-ID: On Fri, 31 May 2024 10:45:24 GMT, Matthias Baesken wrote: > Backport of 8332431 the backport is clean except COPYRIGHT header. ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/630#issuecomment-2141753540 From mbaesken at openjdk.org Fri May 31 10:56:19 2024 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 31 May 2024 10:56:19 GMT Subject: [jdk22u] RFR: 8332431: NullPointerException in JTable of SwingSet2 Message-ID: 8332431: NullPointerException in JTable of SwingSet2 ------------- Commit messages: - Backport 9a83dfee14f4cd9cda476d11a027294a810953cb Changes: https://git.openjdk.org/jdk22u/pull/234/files Webrev: https://webrevs.openjdk.org/?repo=jdk22u&pr=234&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332431 Stats: 16 lines in 1 file changed: 10 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk22u/pull/234.diff Fetch: git fetch https://git.openjdk.org/jdk22u.git pull/234/head:pull/234 PR: https://git.openjdk.org/jdk22u/pull/234 From shade at openjdk.org Fri May 31 11:48:03 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 31 May 2024 11:48:03 GMT Subject: [jdk17u-dev] RFR: 8303942: os::write should write completely [v2] In-Reply-To: References: Message-ID: On Tue, 28 May 2024 18:57:27 GMT, Elif Aslan wrote: >> This is not a clean backport. There were multiple merge conflicts related to undefined parameters and existing methods. This backport is required to address a crash observed in Amazon production. Please refer to the related [PR](https://github.com/openjdk/jdk17u-dev/pull/2281), which has already been merged. >> >> >> In addition to GHA Tier 1, runtime hotspot, JFR, and hotspot GC tests have been run on macOS. >> >> >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/hotspot/jtreg:hotspot_runtime 880 880 0 0 >> ============================== >> TEST SUCCESS >> >> Finished building target 'test' in configuration 'macosx-x86_64-server-release' >> >> Additinonally, added clean backport of [JDK-8316468] (https://github.com/openjdk/jdk/commit/7ce5bd159024e70f5a997c47ed2ce962d6e6091b) >> >> After new commit reran runtime hotspot tests and they all passed > > Elif Aslan has updated the pull request incrementally with one additional commit since the last revision: > > backport of 7ce5bd159024e70f5a997c47ed2ce962d6e6091b This is a tad intrusive change, please make sure that all tests are pass. For example: JTREG_KEYWORDS="!headful & !external-dep & !printer" make test TEST=all ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2490#issuecomment-2141865233 From sgehwolf at redhat.com Fri May 31 12:00:58 2024 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Fri, 31 May 2024 14:00:58 +0200 Subject: CFV: New JDK Updates Committer: Maria Arias de Reyna Dominguez Message-ID: <9c5cc483e2e837e64adaba1218ab38c9c3f50515.camel@redhat.com> I hereby nominate Maria Arias de Reyna Dominguez (mariasde)[1] to JDK Updates Committer. Maria is an experienced Java developer, a Java Champion and member of the Red Hat JDK team. She is currently Author in the JDK Updates Project. Maria is actively contributing to the 21u, 17u and 11u updates releases and has pushed backports for about 7 different bugs for a total of 10 different backports across various JDK releases so far. Some of them non-trivial. Making her JDK Updates Committer would help her integrate changes herself reducing the need for sponsors and increase productivity. Votes are due by 23:59 UTC on Friday, June 14th, 2024. Only current JDK Updates Committers (and above) [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Thanks, Severin [1] https://openjdk.org/census#mariasde [2] https://github.com/openjdk/jdk21u-dev/commits?author=Delawen https://github.com/openjdk/jdk17u-dev/commits?author=Delawen https://github.com/openjdk/jdk11u-dev/commits?author=Delawen [3] https://openjdk.java.net/census#jdk-updates [4] http://openjdk.java.net/projects/#committer-vote From mdoerr at openjdk.org Fri May 31 12:33:23 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 12:33:23 GMT Subject: [jdk17u-dev] RFR: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive Message-ID: <8_iJD6CPZoQlPgCB9WCuw9nKlMd8ButKYqflzkz3reA=.1287b0bf-dda9-4562-810f-d35bbca79dac@github.com> Backport of [JDK-8324933](https://bugs.openjdk.org/browse/JDK-8324933). Clean except NULL vs. nullptr diff in removed code. ------------- Commit messages: - Backport 0e2fdc95ae47c11e6a1e47cdc6190268e29a9d9c Changes: https://git.openjdk.org/jdk17u-dev/pull/2512/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2512&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324933 Stats: 20 lines in 1 file changed: 8 ins; 1 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2512.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2512/head:pull/2512 PR: https://git.openjdk.org/jdk17u-dev/pull/2512 From martin.doerr at sap.com Fri May 31 12:45:38 2024 From: martin.doerr at sap.com (Doerr, Martin) Date: Fri, 31 May 2024 12:45:38 +0000 Subject: CFV: New JDK Updates Committer: Maria Arias de Reyna Dominguez In-Reply-To: <9c5cc483e2e837e64adaba1218ab38c9c3f50515.camel@redhat.com> References: <9c5cc483e2e837e64adaba1218ab38c9c3f50515.camel@redhat.com> Message-ID: Vote: yes Best regards, Martin Von: jdk-updates-dev im Auftrag von Severin Gehwolf Datum: Freitag, 31. Mai 2024 um 14:01 An: jdk-updates-dev at openjdk.org Betreff: CFV: New JDK Updates Committer: Maria Arias de Reyna Dominguez I hereby nominate Maria Arias de Reyna Dominguez (mariasde)[1] to JDK Updates Committer. Maria is an experienced Java developer, a Java Champion and member of the Red Hat JDK team. She is currently Author in the JDK Updates Project. Maria is actively contributing to the 21u, 17u and 11u updates releases and has pushed backports for about 7 different bugs for a total of 10 different backports across various JDK releases so far. Some of them non-trivial. Making her JDK Updates Committer would help her integrate changes herself reducing the need for sponsors and increase productivity. Votes are due by 23:59 UTC on Friday, June 14th, 2024. Only current JDK Updates Committers (and above) [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Thanks, Severin -------------- next part -------------- An HTML attachment was scrubbed... URL: From thomas.stuefe at gmail.com Fri May 31 13:16:04 2024 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Fri, 31 May 2024 15:16:04 +0200 Subject: CFV: New JDK Updates Committer: Maria Arias de Reyna Dominguez In-Reply-To: References: <9c5cc483e2e837e64adaba1218ab38c9c3f50515.camel@redhat.com> Message-ID: Vote: yes On Fri, May 31, 2024 at 2:45?PM Doerr, Martin wrote: > Vote: yes > > > > Best regards, > > Martin > > > > *Von: *jdk-updates-dev im Auftrag von > Severin Gehwolf > *Datum: *Freitag, 31. Mai 2024 um 14:01 > *An: *jdk-updates-dev at openjdk.org > *Betreff: *CFV: New JDK Updates Committer: Maria Arias de Reyna Dominguez > > I hereby nominate Maria Arias de Reyna Dominguez (mariasde)[1] to JDK > Updates Committer. > > Maria is an experienced Java developer, a Java Champion and member of > the Red Hat JDK team. She is currently Author in the JDK Updates > Project. Maria is actively contributing to the 21u, 17u and 11u updates > releases and has pushed backports for about 7 different bugs for a > total of 10 different backports across various JDK releases so far. > Some of them non-trivial. Making her JDK Updates Committer would help > her integrate changes herself reducing the need for sponsors and > increase productivity. > > Votes are due by 23:59 UTC on Friday, June 14th, 2024. > > Only current JDK Updates Committers (and above) [3] are eligible to vote > on this nomination. > > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [4]. > > Thanks, > Severin > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From mdoerr at openjdk.org Fri May 31 13:21:14 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 13:21:14 GMT Subject: [jdk17u-dev] RFR: 8312229: Crash involving yield, switch and anonymous classes Message-ID: Clean backport of [JDK-8312229](https://bugs.openjdk.org/browse/JDK-8312229). ------------- Commit messages: - Backport 1f81e5b19ebfb7cd1b5a01d6cf79efda7e827c35 Changes: https://git.openjdk.org/jdk17u-dev/pull/2513/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2513&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312229 Stats: 53 lines in 2 files changed: 51 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2513.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2513/head:pull/2513 PR: https://git.openjdk.org/jdk17u-dev/pull/2513 From mdoerr at openjdk.org Fri May 31 13:22:26 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 13:22:26 GMT Subject: [jdk17u-dev] RFR: 8326106: Write and clear stack trace table outside of safepoint Message-ID: <-3GVloSj62IJ5_cg8j_wsDhFBeuV-wKMUwva4XFKz9s=.7acc51cb-442c-41c1-bbec-84108c7f1e31@github.com> Clean backport of [JDK-8326106](https://bugs.openjdk.org/browse/JDK-8326106). ------------- Commit messages: - Backport a776104e210db212c4e32894844d3c0cbaac53c3 Changes: https://git.openjdk.org/jdk17u-dev/pull/2514/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2514&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326106 Stats: 17 lines in 3 files changed: 4 ins; 7 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2514.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2514/head:pull/2514 PR: https://git.openjdk.org/jdk17u-dev/pull/2514 From phh at openjdk.org Fri May 31 14:42:02 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 31 May 2024 14:42:02 GMT Subject: [jdk17u-dev] RFR: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive In-Reply-To: <8_iJD6CPZoQlPgCB9WCuw9nKlMd8ButKYqflzkz3reA=.1287b0bf-dda9-4562-810f-d35bbca79dac@github.com> References: <8_iJD6CPZoQlPgCB9WCuw9nKlMd8ButKYqflzkz3reA=.1287b0bf-dda9-4562-810f-d35bbca79dac@github.com> Message-ID: On Fri, 31 May 2024 12:29:00 GMT, Martin Doerr wrote: > Backport of [JDK-8324933](https://bugs.openjdk.org/browse/JDK-8324933). Clean except NULL vs. nullptr diff in removed code. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/2512#pullrequestreview-2091022361 From phh at openjdk.org Fri May 31 14:54:09 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 31 May 2024 14:54:09 GMT Subject: [jdk21u-dev] RFR: 8331771: ZGC: Remove OopMapCacheAlloc_lock ordering workaround In-Reply-To: References: Message-ID: On Fri, 31 May 2024 06:23:07 GMT, Xiaolong Peng wrote: > I'd like to backport [JDK-8331771](https://bugs.openjdk.org/browse/JDK-8331771) to jdk21 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u-dev/pull/626#pullrequestreview-2091053936 From phh at openjdk.org Fri May 31 14:57:07 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 31 May 2024 14:57:07 GMT Subject: [jdk22u] RFR: 8331771: ZGC: Remove OopMapCacheAlloc_lock ordering workaround In-Reply-To: References: Message-ID: On Fri, 31 May 2024 06:06:54 GMT, Xiaolong Peng wrote: > I'd like to backport the change of https://bugs.openjdk.org/browse/JDK-8331771 to JDK22 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk22u/pull/232#pullrequestreview-2091059453 From mdoerr at openjdk.org Fri May 31 14:59:10 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 14:59:10 GMT Subject: [jdk17u-dev] RFR: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive In-Reply-To: <8_iJD6CPZoQlPgCB9WCuw9nKlMd8ButKYqflzkz3reA=.1287b0bf-dda9-4562-810f-d35bbca79dac@github.com> References: <8_iJD6CPZoQlPgCB9WCuw9nKlMd8ButKYqflzkz3reA=.1287b0bf-dda9-4562-810f-d35bbca79dac@github.com> Message-ID: On Fri, 31 May 2024 12:29:00 GMT, Martin Doerr wrote: > Backport of [JDK-8324933](https://bugs.openjdk.org/browse/JDK-8324933). Clean except NULL vs. nullptr diff in removed code. Thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2512#issuecomment-2142445158 From mdoerr at openjdk.org Fri May 31 15:37:17 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 15:37:17 GMT Subject: [jdk21u-dev] RFR: 8325382: (fc) FileChannel.transferTo throws IOException when position equals size Message-ID: Backport of [JDK-8325382](https://bugs.openjdk.org/browse/JDK-8325382). ------------- Commit messages: - Backport 6b7c9718d68f30f47a163042d6e205945b9ff365 Changes: https://git.openjdk.org/jdk21u-dev/pull/631/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=631&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325382 Stats: 50 lines in 2 files changed: 36 ins; 9 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/631.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/631/head:pull/631 PR: https://git.openjdk.org/jdk21u-dev/pull/631 From duke at openjdk.org Fri May 31 15:39:21 2024 From: duke at openjdk.org (Xiaolong Peng) Date: Fri, 31 May 2024 15:39:21 GMT Subject: [jdk21u-dev] RFR: 8331771: ZGC: Remove OopMapCacheAlloc_lock ordering workaround [v2] In-Reply-To: References: Message-ID: > I'd like to backport [JDK-8331771](https://bugs.openjdk.org/browse/JDK-8331771) to jdk21 Xiaolong Peng has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' into backport - Backport 5746137e8a46e1eb964fe8c4de015a62dc17a745 ------------- Changes: https://git.openjdk.org/jdk21u-dev/pull/626/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=626&range=01 Stats: 22 lines in 4 files changed: 0 ins; 22 del; 0 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/626.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/626/head:pull/626 PR: https://git.openjdk.org/jdk21u-dev/pull/626 From duke at openjdk.org Fri May 31 15:44:35 2024 From: duke at openjdk.org (Neethu Prasad) Date: Fri, 31 May 2024 15:44:35 GMT Subject: [jdk21u-dev] RFR: Backport 0678253bffca91775d29d2942f48c806ab4d2cab Message-ID: Backport of JDK-8320602 Applying an update from the upstream source, quote: "Removing synchronized from the getInstance() methods". As the reporter noted, this change was made 16 years ago. Tests: Unit tests passed ------------- Commit messages: - Backport 0678253bffca91775d29d2942f48c806ab4d2cab Changes: https://git.openjdk.org/jdk21u-dev/pull/632/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=632&range=00 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/632.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/632/head:pull/632 PR: https://git.openjdk.org/jdk21u-dev/pull/632 From mdoerr at openjdk.org Fri May 31 15:50:33 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 15:50:33 GMT Subject: [jdk21u-dev] RFR: 8325179: Race in BasicDirectoryModel.validateFileCache Message-ID: Clean backport of [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179) and [JDK-8238169](https://bugs.openjdk.org/browse/JDK-8238169) which belong together. ------------- Commit messages: - Backport e66788c16563d343f6cccd2807a251ccc6f9b64a Changes: https://git.openjdk.org/jdk21u-dev/pull/633/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=633&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325179 Stats: 69 lines in 1 file changed: 17 ins; 21 del; 31 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/633.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/633/head:pull/633 PR: https://git.openjdk.org/jdk21u-dev/pull/633 From bpb at openjdk.org Fri May 31 15:51:02 2024 From: bpb at openjdk.org (Brian Burkhalter) Date: Fri, 31 May 2024 15:51:02 GMT Subject: [jdk21u-dev] RFR: 8325382: (fc) FileChannel.transferTo throws IOException when position equals size In-Reply-To: References: Message-ID: <--6zUq6XqO9rZd3n9hUs_ZwWSVlCb8f8luRVOisx-Jk=.62e87a07-fb79-4efe-affe-e075fdbd82db@github.com> On Fri, 31 May 2024 15:31:28 GMT, Martin Doerr wrote: > Backport of [JDK-8325382](https://bugs.openjdk.org/browse/JDK-8325382). Not clean because of indentation. Included test has passed. Looks all right to me. ------------- Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/631#pullrequestreview-2091168632 From duke at openjdk.org Fri May 31 15:54:12 2024 From: duke at openjdk.org (Neethu Prasad) Date: Fri, 31 May 2024 15:54:12 GMT Subject: [jdk21u-dev] RFR: 8329995: Restricted access to `/proc` can cause JFR initialization to crash Message-ID: Backport of JDK-8329995 ------------- Commit messages: - Backport a92ad03946d296510c8c2ac18278608e8032b3f3 Changes: https://git.openjdk.org/jdk21u-dev/pull/634/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=634&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329995 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/634.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/634/head:pull/634 PR: https://git.openjdk.org/jdk21u-dev/pull/634 From mdoerr at openjdk.org Fri May 31 15:56:19 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 15:56:19 GMT Subject: [jdk21u-dev] RFR: 8329126: No native wrappers generated anymore with -XX:-TieredCompilation after JDK-8251462 Message-ID: Clean backport of [JDK-8329126](https://bugs.openjdk.org/browse/JDK-8329126). ------------- Commit messages: - Backport f2e5808b46a3da6920dd56688c877ee0e2795de6 Changes: https://git.openjdk.org/jdk21u-dev/pull/635/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=635&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329126 Stats: 115 lines in 3 files changed: 114 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/635.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/635/head:pull/635 PR: https://git.openjdk.org/jdk21u-dev/pull/635 From mdoerr at openjdk.org Fri May 31 16:02:28 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 16:02:28 GMT Subject: [jdk21u-dev] RFR: 8329004: Update Libpng to 1.6.43 Message-ID: <6HsBLSUodqaKEmABXsADb4uiAAF_XLrVOPoUmqWuDcU=.283e40e3-b38b-41c4-8679-291cbb883830@github.com> Clean backport of [JDK-8329004](https://bugs.openjdk.org/browse/JDK-8329004). ------------- Commit messages: - Backport 4e4229438ad2e8ac59ac675465e4d3d4e13bf156 Changes: https://git.openjdk.org/jdk21u-dev/pull/636/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=636&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329004 Stats: 610 lines in 18 files changed: 258 ins; 120 del; 232 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/636.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/636/head:pull/636 PR: https://git.openjdk.org/jdk21u-dev/pull/636 From pminborg at openjdk.org Fri May 31 17:05:03 2024 From: pminborg at openjdk.org (Per Minborg) Date: Fri, 31 May 2024 17:05:03 GMT Subject: [jdk21u-dev] Integrated: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment In-Reply-To: <8A1BNN5ZXTXFpI4cZh-25KKo_rEx7FJLl34OUQS7HTk=.938f856d-3520-4761-8491-76eb9e7f2025@github.com> References: <8A1BNN5ZXTXFpI4cZh-25KKo_rEx7FJLl34OUQS7HTk=.938f856d-3520-4761-8491-76eb9e7f2025@github.com> Message-ID: On Mon, 25 Mar 2024 11:54:39 GMT, Per Minborg wrote: > Hi all, > > This pull request contains a backport of commit [93579c29](https://github.com/openjdk/jdk/commit/93579c29e3ba60a8bc16d712e7ffc733f324a223) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Per Minborg on 25 Mar 2024 and was reviewed by Maurizio Cimadamore. > > Thanks! This pull request has now been integrated. Changeset: 0d9833e5 Author: Per Minborg Committer: Martin Doerr URL: https://git.openjdk.org/jdk21u-dev/commit/0d9833e522d6401c2ba2495a5b4f058bb489649c Stats: 35 lines in 2 files changed: 27 ins; 4 del; 4 mod 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment Reviewed-by: mdoerr Backport-of: 93579c29e3ba60a8bc16d712e7ffc733f324a223 ------------- PR: https://git.openjdk.org/jdk21u-dev/pull/404 From duke at openjdk.org Fri May 31 17:07:05 2024 From: duke at openjdk.org (Xiaolong Peng) Date: Fri, 31 May 2024 17:07:05 GMT Subject: [jdk17u-dev] Integrated: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC In-Reply-To: References: Message-ID: On Wed, 15 May 2024 21:14:27 GMT, Xiaolong Peng wrote: > 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC This pull request has now been integrated. Changeset: 235baaae Author: Xiaolong Peng Committer: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/235baaae1b1ad22487bb7cb1aa0849a946524cd0 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC Backport-of: 80ccc989a892e4d9f4e2c9395a100cfabbdcda64 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/2474 From christoph.langer at sap.com Fri May 31 18:03:09 2024 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 31 May 2024 18:03:09 +0000 Subject: CFV: New JDK Updates Committer: Maria Arias de Reyna Dominguez In-Reply-To: <9c5cc483e2e837e64adaba1218ab38c9c3f50515.camel@redhat.com> References: <9c5cc483e2e837e64adaba1218ab38c9c3f50515.camel@redhat.com> Message-ID: Vote: yes /Christoph > -----Original Message----- > From: jdk-updates-dev On Behalf Of > Severin Gehwolf > Sent: Freitag, 31. Mai 2024 14:01 > To: jdk-updates-dev at openjdk.org > Subject: CFV: New JDK Updates Committer: Maria Arias de Reyna Dominguez > > I hereby nominate Maria Arias de Reyna Dominguez (mariasde)[1] to JDK > Updates Committer. > > Maria is an experienced Java developer, a Java Champion and member of the > Red Hat JDK team. She is currently Author in the JDK Updates Project. Maria is > actively contributing to the 21u, 17u and 11u updates releases and has pushed > backports for about 7 different bugs for a total of 10 different backports across > various JDK releases so far. > Some of them non-trivial. Making her JDK Updates Committer would help her > integrate changes herself reducing the need for sponsors and increase > productivity. > > Votes are due by 23:59 UTC on Friday, June 14th, 2024. > > Only current JDK Updates Committers (and above) [3] are eligible to vote on > this nomination. > > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [4]. > > Thanks, > Severin > > [1] https://openjdk.org/census#mariasde > [2] https://github.com/openjdk/jdk21u-dev/commits?author=Delawen > > https://github.com/openjdk/jdk17u-dev/commits?author=Delawen > https://github.com/openjdk/jdk11u-dev/commits?author=Delawen > [3] > https://openjdk.j/ > ava.net%2Fcensus%23jdk- > updates&data=05%7C02%7Cchristoph.langer%40sap.com%7C2624d0e6c13b4b > cf2abf08dc81696601%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C > 638527536900245321%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM > DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sd > ata=uXrlvhoKKWJTOStwQsBO3FNOa0YktI4Flzl%2FXgJUN08%3D&reserved=0 > [4] > http://openjdk.ja/ > va.net%2Fprojects%2F%23committer- > vote&data=05%7C02%7Cchristoph.langer%40sap.com%7C2624d0e6c13b4bcf2 > abf08dc81696601%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C638 > 527536900255791%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL > CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=S > 18J%2FYy9wWC6e3dtNoTOm3tSNWQ9miLjd%2Fm9YvMsB50%3D&reserved=0 From mdoerr at openjdk.org Fri May 31 19:16:18 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 19:16:18 GMT Subject: [jdk21u-dev] RFR: 8328953: JEditorPane.read throws ChangedCharSetException Message-ID: Backport of [JDK-8328953](https://bugs.openjdk.org/browse/JDK-8328953). Clean except Copyright year change. ------------- Commit messages: - Backport 245514da51ef77757f530317e079a3f58370a0be Changes: https://git.openjdk.org/jdk21u-dev/pull/637/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=637&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328953 Stats: 118 lines in 2 files changed: 92 ins; 16 del; 10 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/637.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/637/head:pull/637 PR: https://git.openjdk.org/jdk21u-dev/pull/637 From mdoerr at openjdk.org Fri May 31 19:19:33 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 19:19:33 GMT Subject: [jdk21u-dev] RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent Message-ID: Clean backport of [JDK-8305072](https://bugs.openjdk.org/browse/JDK-8305072). ------------- Commit messages: - Backport 2fcb816858406f33cefef3164b2c85f9f996c7da Changes: https://git.openjdk.org/jdk21u-dev/pull/638/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=638&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305072 Stats: 160 lines in 2 files changed: 158 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/638.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/638/head:pull/638 PR: https://git.openjdk.org/jdk21u-dev/pull/638 From mdoerr at openjdk.org Fri May 31 19:22:17 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 19:22:17 GMT Subject: [jdk21u-dev] RFR: 8328785: IOException: Symbol not found: C_GetInterface for PKCS11 interface prior to V3.0 Message-ID: Clean backport of [JDK-8328785](https://bugs.openjdk.org/browse/JDK-8328785). ------------- Commit messages: - Backport 6276789fb5e283c11ac73602c2a5f646eab96975 Changes: https://git.openjdk.org/jdk21u-dev/pull/639/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=639&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328785 Stats: 54 lines in 1 file changed: 20 ins; 29 del; 5 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/639.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/639/head:pull/639 PR: https://git.openjdk.org/jdk21u-dev/pull/639 From mdoerr at openjdk.org Fri May 31 19:27:13 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 19:27:13 GMT Subject: [jdk21u-dev] RFR: 8324577: [REDO] - [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE Message-ID: Clean backport of [JDK-8324577](https://bugs.openjdk.org/browse/JDK-8324577). ------------- Commit messages: - Backport f1d0e715b67e2ca47b525069d8153abbb33f75b9 Changes: https://git.openjdk.org/jdk21u-dev/pull/640/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=640&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324577 Stats: 17 lines in 1 file changed: 9 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/640.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/640/head:pull/640 PR: https://git.openjdk.org/jdk21u-dev/pull/640 From mdoerr at openjdk.org Fri May 31 19:32:34 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 19:32:34 GMT Subject: [jdk21u-dev] RFR: 8330748: ByteArrayOutputStream.writeTo(OutputStream) pins carrier Message-ID: <1cnohjuqQMqvVbB780N_kASMwi3ZviZKoDoeNhGys5k=.bb39c7d2-fbdc-404a-b240-de72b5bc1b37@github.com> Clean backport of [JDK-8330748](https://bugs.openjdk.org/browse/JDK-8330748). ------------- Commit messages: - Backport 819f3d6fc70ff6fe54ac5f9033c17c3dd4326aa5 Changes: https://git.openjdk.org/jdk21u-dev/pull/641/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=641&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8330748 Stats: 142 lines in 2 files changed: 139 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/641.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/641/head:pull/641 PR: https://git.openjdk.org/jdk21u-dev/pull/641 From mdoerr at openjdk.org Fri May 31 19:34:28 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 19:34:28 GMT Subject: [jdk21u-dev] RFR: 8328999: Update GIFlib to 5.2.2 Message-ID: Clean backport of [JDK-8328999](https://bugs.openjdk.org/browse/JDK-8328999). ------------- Commit messages: - Backport 6969a9e0b2143eee5a7cfa02460a8ab6dfa08cda Changes: https://git.openjdk.org/jdk21u-dev/pull/642/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=642&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328999 Stats: 846 lines in 8 files changed: 179 ins; 105 del; 562 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/642.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/642/head:pull/642 PR: https://git.openjdk.org/jdk21u-dev/pull/642 From mdoerr at openjdk.org Fri May 31 19:37:22 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 19:37:22 GMT Subject: [jdk21u-dev] RFR: 8331077: nroff man page update for jar tool Message-ID: <3viHPeLjiE4FQtyx_CYJudD4Gt_JPkyTy96tKr5Tr9M=.04c42da9-6c71-4dfd-ae8e-cb3066debb99@github.com> Clean backport of [JDK-8331077](https://bugs.openjdk.org/browse/JDK-8331077). ------------- Commit messages: - Backport c21672d8c94da6aa613174744ceaa945ca2a474a Changes: https://git.openjdk.org/jdk21u-dev/pull/643/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=643&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331077 Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/643.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/643/head:pull/643 PR: https://git.openjdk.org/jdk21u-dev/pull/643 From mdoerr at openjdk.org Fri May 31 19:47:09 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 19:47:09 GMT Subject: [jdk21u-dev] RFR: 8314225: SIGSEGV in JavaThread::is_lock_owned Message-ID: Clean backport of [JDK-8314225](https://bugs.openjdk.org/browse/JDK-8314225). ------------- Commit messages: - Backport ad0b54d429fdbd806c09aa06bb42f1ed4a0297e8 Changes: https://git.openjdk.org/jdk21u-dev/pull/644/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=644&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8314225 Stats: 98 lines in 11 files changed: 14 ins; 70 del; 14 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/644.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/644/head:pull/644 PR: https://git.openjdk.org/jdk21u-dev/pull/644 From mdoerr at openjdk.org Fri May 31 19:50:23 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 19:50:23 GMT Subject: [jdk21u-dev] RFR: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit Message-ID: Clean backport of [JDK-8261433](https://bugs.openjdk.org/browse/JDK-8261433). ------------- Commit messages: - Backport 7c2c24fc0511b36132952c96be46eea5904a53c5 Changes: https://git.openjdk.org/jdk21u-dev/pull/645/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=645&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8261433 Stats: 242 lines in 5 files changed: 165 ins; 22 del; 55 mod Patch: https://git.openjdk.org/jdk21u-dev/pull/645.diff Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/645/head:pull/645 PR: https://git.openjdk.org/jdk21u-dev/pull/645 From bpb at openjdk.org Fri May 31 19:52:01 2024 From: bpb at openjdk.org (Brian Burkhalter) Date: Fri, 31 May 2024 19:52:01 GMT Subject: [jdk21u-dev] RFR: 8330748: ByteArrayOutputStream.writeTo(OutputStream) pins carrier In-Reply-To: <1cnohjuqQMqvVbB780N_kASMwi3ZviZKoDoeNhGys5k=.bb39c7d2-fbdc-404a-b240-de72b5bc1b37@github.com> References: <1cnohjuqQMqvVbB780N_kASMwi3ZviZKoDoeNhGys5k=.bb39c7d2-fbdc-404a-b240-de72b5bc1b37@github.com> Message-ID: <19ttJpqUkDD7IPONhaxTm3F4ZCpwojcSvYL1iewgVmg=.fa79905b-fd9a-4c48-976c-4a61b61e528c@github.com> On Fri, 31 May 2024 19:27:22 GMT, Martin Doerr wrote: > Clean backport of [JDK-8330748](https://bugs.openjdk.org/browse/JDK-8330748). Looks all right to me. ------------- Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk21u-dev/pull/641#pullrequestreview-2091613571 From mdoerr at openjdk.org Fri May 31 19:57:01 2024 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 31 May 2024 19:57:01 GMT Subject: [jdk21u-dev] RFR: 8330748: ByteArrayOutputStream.writeTo(OutputStream) pins carrier In-Reply-To: <1cnohjuqQMqvVbB780N_kASMwi3ZviZKoDoeNhGys5k=.bb39c7d2-fbdc-404a-b240-de72b5bc1b37@github.com> References: <1cnohjuqQMqvVbB780N_kASMwi3ZviZKoDoeNhGys5k=.bb39c7d2-fbdc-404a-b240-de72b5bc1b37@github.com> Message-ID: On Fri, 31 May 2024 19:27:22 GMT, Martin Doerr wrote: > Clean backport of [JDK-8330748](https://bugs.openjdk.org/browse/JDK-8330748). Thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk21u-dev/pull/641#issuecomment-2142894516 From zgu at openjdk.org Fri May 31 20:11:19 2024 From: zgu at openjdk.org (Zhengyu Gu) Date: Fri, 31 May 2024 20:11:19 GMT Subject: [jdk17u-dev] RFR: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded Message-ID: <9HBqahg9Ap7ymgF92mXRGajviZAAFkSBx_WwqASloZk=.30e0df03-fd98-4eb8-ba75-0c43bad41fab@github.com> The only conflict of the backport is copyright year line. ------------- Commit messages: - Backport 142c311e3b9bd3f00edaa6ba7bcbc9fc285ee9b9 Changes: https://git.openjdk.org/jdk17u-dev/pull/2515/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2515&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328744 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2515.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2515/head:pull/2515 PR: https://git.openjdk.org/jdk17u-dev/pull/2515 From duke at openjdk.org Fri May 31 20:38:41 2024 From: duke at openjdk.org (fitzsim) Date: Fri, 31 May 2024 20:38:41 GMT Subject: [jdk11u-dev] RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls Message-ID: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls Reviewed-by: kbarrett, djelinski Backport-of: d7298245d6759f62e253b5cf0df975db17fdbf82 ------------- Commit messages: - 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls Changes: https://git.openjdk.org/jdk11u-dev/pull/2732/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2732&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286781 Stats: 51 lines in 8 files changed: 13 ins; 28 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2732.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2732/head:pull/2732 PR: https://git.openjdk.org/jdk11u-dev/pull/2732 From duke at openjdk.org Fri May 31 20:38:41 2024 From: duke at openjdk.org (fitzsim) Date: Fri, 31 May 2024 20:38:41 GMT Subject: [jdk11u-dev] RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls In-Reply-To: References: Message-ID: On Fri, 31 May 2024 20:33:34 GMT, fitzsim wrote: > 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls > > Reviewed-by: kbarrett, djelinski > Backport-of: d7298245d6759f62e253b5cf0df975db17fdbf82 The GHA sanity checks failed at first on the macOS builders, but the error was not clear -- it just looked like the jobs terminated -- so I restarted those subtasks and they passed. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2732#issuecomment-2142943356 From duke at openjdk.org Fri May 31 21:12:35 2024 From: duke at openjdk.org (Neethu Prasad) Date: Fri, 31 May 2024 21:12:35 GMT Subject: [jdk17u-dev] RFR: 8329995: Restricted access to `/proc` can cause JFR initialization to crash Message-ID: Backport of JDK-8329995 ------------- Commit messages: - 8329995: Restricted access to can cause JFR initialization to crash Changes: https://git.openjdk.org/jdk17u-dev/pull/2516/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=2516&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329995 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/2516.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/2516/head:pull/2516 PR: https://git.openjdk.org/jdk17u-dev/pull/2516 From duke at openjdk.org Fri May 31 21:14:51 2024 From: duke at openjdk.org (Neethu Prasad) Date: Fri, 31 May 2024 21:14:51 GMT Subject: [jdk11u-dev] RFR: 8329995: Restricted access to `/proc` can cause JFR initialization to crash Message-ID: Backport of JDK-8329995 ------------- Commit messages: - 8329995: Restricted access to can cause JFR initialization to crash Changes: https://git.openjdk.org/jdk11u-dev/pull/2733/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2733&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329995 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2733.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2733/head:pull/2733 PR: https://git.openjdk.org/jdk11u-dev/pull/2733 From serb at openjdk.org Fri May 31 22:30:15 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 31 May 2024 22:30:15 GMT Subject: [jdk22u] Integrated: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+ In-Reply-To: <618MdIz0vKLe9oVP1nzqoGFuAbiaocMoVE9rIgzu7Eo=.b159d66c-14e8-4ff2-b104-dce25f194c6e@github.com> References: <618MdIz0vKLe9oVP1nzqoGFuAbiaocMoVE9rIgzu7Eo=.b159d66c-14e8-4ff2-b104-dce25f194c6e@github.com> Message-ID: On Thu, 30 May 2024 02:47:30 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [eb60822a](https://github.com/openjdk/jdk/commit/eb60822a45ecd076484e707b2dd1049ed9d8079b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Abhishek Kumar on 19 Apr 2024 and was reviewed by Damon Nguyen, Jayathirth D V, Tejesh R and Sergey Bylokhov. > > Thanks! This pull request has now been integrated. Changeset: 0080e668 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk22u/commit/0080e668f2f102c51ab8567ac461590bfcf2cce6 Stats: 66 lines in 1 file changed: 19 ins; 33 del; 14 mod 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+ Backport-of: eb60822a45ecd076484e707b2dd1049ed9d8079b ------------- PR: https://git.openjdk.org/jdk22u/pull/230