[jdk11u-dev] RFR: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence [v5]

[Pavel Rappo]

On Wed, 1 May 2024 12:40:10 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> What are the reasons that the option type was changed from that of the original commit? In the original commit it was eXtended, in this backport it is standard.
>
>> What are the reasons that the option type was changed from that of the original commit? In the original commit it was eXtended, in this backport it is standard.
> 
> @yukikimmura, @RealCLanger, @phohensee, if there are no reasons for that change in option type, then I believe it should be reverted.

> @pavelrappo I was not involved in the review, I just discovered an issue with the test afterwards. However, I also can't see what exeactly you mean with the option type. Could you please elaborate this a bit more? Thanks

In the original commit, the new option is defined like this:

    new XOption(resources, "--legal-notices", 1)

In this backport, the new option is defined like this:

    new Option(resources, "--legal-notices", 1)

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1805#issuecomment-2088644279