[jdk11u-dev] RFR: 8310818: Refactor more Locale tests to use JUnit

Lutz Schmidt lucy at openjdk.org
Thu May 2 12:07:02 UTC 2024


On Mon, 29 Apr 2024 10:02:31 GMT, Andrew Lu <andrewlu at openjdk.org> wrote:

> This PR contains a backport of
> https://github.com/openjdk/jdk/commit/12e943091071b02b5756b57527a5f86a3d881cb8
> Patch is not clean, this class test/jdk/java/util/Locale/ISO639.java contains the Text Blocks
>     System.out.printf("""
>             Arguments.of("%s","%s","%s"),
>             """, iso639_1, iso639_2B, iso639_2T);
> But in jdk11 the Text Blocks is not supported, I modified the code to
> 	System.out.printf("Arguments.of("%s","%s","%s"),\n", iso639_1, iso639_2B, iso639_2T);
> Other than these the rest of the code is clean.

LGTM.

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk11u-dev/pull/2693#pullrequestreview-2035561029


More information about the jdk-updates-dev mailing list