[jdk21u-dev] RFR: 8310228: Improve error reporting for uncaught native exceptions on Windows [v3]

[Thomas Stuefe]

On Thu, 2 May 2024 11:20:11 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> A bugfix useful for windows.
>
> Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into backport-GoeLin-38bf1192
>  - Adapt to 8321713
>  - Merge branch 'openjdk:master' into backport-GoeLin-38bf1192
>  - Backport 38bf1192b637cf3513cb25ac21f513bfb51cb55b

> Hi @Stuefe, good point windows is essential here :) I restarted the tests. After the report of @Rigner I'm not so sure I should proceed with this. What do you think, is this useful for 21?

@GoeLin 
The fix seems correct, seems low risk and is somewhat useful. 

AFAIU, the bug is: An uncaught signal that is not handled specially by the JVM (eg implicit null pointer segfaults) should lead to a proper hs-err file. But it can lead to incorrect or torn hs-err files, the latter if we run out of stack. AFAIU this happens more or less randomly, depending on the content of the SSE control register at the time of the crash.

Seeing that the risk is low, and that we were historically plagued by bad hs-err files on windows, I would fix it in 21. Possibly even in 17.

@Rigner @JornVernee maybe discuss follow-up issues in the JBS section of the original bug, or its original PR? These discussions are valuable and should not get lost in this backport PR.

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/510#issuecomment-2091245058