[jdk21u-dev] RFR: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared [v3]

[Richard Reingruber]

On Mon, 6 May 2024 09:17:25 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Unclean backport to match the codebases between mainline and JDK 21, simplifying maintenance. It also implicitly fixes [JDK-8323505](https://bugs.openjdk.org/browse/JDK-8323505), since this move includes a few touchups to the test.
>> 
>> The uncleanliness comes from `MethodType.java` conflicts that does not have [JDK-8310849](https://bugs.openjdk.org/browse/JDK-8310849) in JDK 21. So it yields a few contextual conflicts. Since affected hunks are just removals, I removed them by hand.
>> 
>> There is a follow-up, [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255), but it does not seem to affect anything yet, since there are no `ReferenceKeySet.add` calls anywhere in sight. We can backport that separately.
>> 
>> Additional testing:
>>  - [x] MacOS AArch64 Server fastdebug, `jdk/internal/util` tests pass
>>  - [x] MacOS AArch64 Server fastdebug, `java/lang/invoke` tests pass
>>  - [x] Linux AArch64 Server fastdebug, `all` tests pass
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8310913-referenced-key-map
>  - Merge branch 'master' into JDK-8310913-referenced-key-map
>  - Backport 6af0af593446bc33dc94bbf7334c325c4ac0ac0f
>    
>    Reviewed-by: naoto, rriggs, mchung, liach

The backport looks good.
Please make sure not to forget the follow-up [JDK-8325255](https://bugs.openjdk.org/browse/JDK-8325255).

Cheers, Richard.

-------------

Marked as reviewed by rrich (Reviewer).

PR Review: https://git.openjdk.org/jdk21u-dev/pull/342#pullrequestreview-2040355466